Preparing report...

Report for github.com/iov-one/weave

A+    Excellent!    Found 155 issues across 435 files

Tweet

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint70%

Golint is a linter for Go source code.

    • weave/x/txfee/msg.go
    • Line 15: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • Line 30: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • weave/conditions.go
    • Line 35: warning: exported function NewCondition should have comment or be unexported (golint)
    • Line 58: warning: receiver name a should be consistent with previous receiver name c for Condition (golint)
    • Line 84: warning: exported method Condition.MarshalJSON should have comment or be unexported (golint)
    • Line 92: warning: exported method Condition.UnmarshalJSON should have comment or be unexported (golint)
    • Line 138: warning: exported method Address.UnmarshalJSON should have comment or be unexported (golint)
    • weave/types.go
    • Line 30: warning: exported method ValidatorUpdate.Validate should have comment or be unexported (golint)
    • Line 40: warning: exported method ValidatorUpdate.AsABCI should have comment or be unexported (golint)
    • Line 47: warning: exported function ValidatorUpdateFromABCI should have comment or be unexported (golint)
    • Line 54: warning: exported function PubkeyFromABCI should have comment or be unexported (golint)
    • Line 61: warning: exported method PubKey.AsABCI should have comment or be unexported (golint)
    • Line 68: warning: exported method ValidatorUpdates.Validate should have comment or be unexported (golint)
    • Line 124: warning: exported function StoreValidatorUpdates should have comment or be unexported (golint)
    • Line 134: warning: exported function GetValidatorUpdates should have comment or be unexported (golint)
    • Line 145: warning: exported function ValidatorUpdatesFromABCI should have comment or be unexported (golint)
    • weave/gconf/gconf.go
    • Line 43: warning: exported function Load should have comment or be unexported (golint)
    • Line 65: warning: exported type Configuration should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/account/msg.go
    • Line 31: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • Line 35: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • Line 44: warning: exported method RegisterDomainMsg.Path should have comment or be unexported (golint)
    • Line 48: warning: exported method RegisterDomainMsg.Validate should have comment or be unexported (golint)
    • Line 62: warning: exported method TransferDomainMsg.Path should have comment or be unexported (golint)
    • Line 66: warning: exported method TransferDomainMsg.Validate should have comment or be unexported (golint)
    • Line 76: warning: exported method RenewDomainMsg.Path should have comment or be unexported (golint)
    • Line 80: warning: exported method RenewDomainMsg.Validate should have comment or be unexported (golint)
    • Line 89: warning: exported method DeleteDomainMsg.Path should have comment or be unexported (golint)
    • Line 93: warning: exported method DeleteDomainMsg.Validate should have comment or be unexported (golint)
    • Line 102: warning: exported method RegisterAccountMsg.Path should have comment or be unexported (golint)
    • Line 106: warning: exported method RegisterAccountMsg.Validate should have comment or be unexported (golint)
    • Line 122: warning: exported method TransferAccountMsg.Path should have comment or be unexported (golint)
    • Line 126: warning: exported method TransferAccountMsg.Validate should have comment or be unexported (golint)
    • Line 138: warning: exported method ReplaceAccountTargetsMsg.Path should have comment or be unexported (golint)
    • Line 142: warning: exported method ReplaceAccountTargetsMsg.Validate should have comment or be unexported (golint)
    • Line 152: warning: exported method DeleteAccountMsg.Path should have comment or be unexported (golint)
    • Line 156: warning: exported method DeleteAccountMsg.Validate should have comment or be unexported (golint)
    • Line 169: warning: exported method FlushDomainMsg.Path should have comment or be unexported (golint)
    • Line 173: warning: exported method FlushDomainMsg.Validate should have comment or be unexported (golint)
    • Line 184: warning: exported method RenewAccountMsg.Path should have comment or be unexported (golint)
    • Line 188: warning: exported method RenewAccountMsg.Validate should have comment or be unexported (golint)
    • Line 195: warning: exported method AddAccountCertificateMsg.Path should have comment or be unexported (golint)
    • Line 199: warning: exported method AddAccountCertificateMsg.Validate should have comment or be unexported (golint)
    • Line 224: warning: exported method ReplaceAccountMsgFeesMsg.Path should have comment or be unexported (golint)
    • Line 228: warning: exported method ReplaceAccountMsgFeesMsg.Validate should have comment or be unexported (golint)
    • Line 238: warning: exported method DeleteAccountCertificateMsg.Path should have comment or be unexported (golint)
    • Line 242: warning: exported method DeleteAccountCertificateMsg.Validate should have comment or be unexported (golint)
    • weave/weavetest/handlers.go
    • Line 27: warning: exported method Handler.Check should have comment or be unexported (golint)
    • Line 37: warning: exported method Handler.Deliver should have comment or be unexported (golint)
    • Line 47: warning: exported method Handler.CheckCallCount should have comment or be unexported (golint)
    • Line 51: warning: exported method Handler.DeliverCallCount should have comment or be unexported (golint)
    • Line 55: warning: exported method Handler.CallCount should have comment or be unexported (golint)
    • weave/gconf/handler.go
    • Line 20: warning: exported type UpdateConfigurationHandler should have comment or be unexported (golint)
    • Line 62: warning: exported method UpdateConfigurationHandler.Check should have comment or be unexported (golint)
    • Line 69: warning: exported method UpdateConfigurationHandler.Deliver should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/preregistration/msg.go
    • Line 16: warning: exported method RegisterMsg.Path should have comment or be unexported (golint)
    • Line 20: warning: exported method RegisterMsg.Validate should have comment or be unexported (golint)
    • Line 32: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • Line 36: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • weave/errors/doc.go
    • Line 34: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
    • weave/x/validators/model.go
    • Line 28: warning: exported method WeaveAccounts.Validate should have comment or be unexported (golint)
    • Line 36: warning: exported function AsWeaveAccounts should have comment or be unexported (golint)
    • Line 44: warning: exported function AsAccounts should have comment or be unexported (golint)
    • Line 55: warning: exported method Accounts.Validate should have comment or be unexported (golint)
    • Line 62: warning: exported type AccountBucket should have comment or be unexported (golint)
    • Line 66: warning: exported function NewAccountBucket should have comment or be unexported (golint)
    • Line 72: warning: exported method AccountBucket.GetAccounts should have comment or be unexported (golint)
    • Line 87: warning: exported function AccountsWith should have comment or be unexported (golint)
    • weave/orm/helpers.go
    • Line 33: warning: exported function LimitIterator should have comment or be unexported (golint)
    • Line 37: warning: exported function ToSlice should have comment or be unexported (golint)
    • weave/datamigration/model.go
    • Line 13: warning: exported method ExecutedMigration.Validate should have comment or be unexported (golint)
    • Line 19: warning: exported function NewExecutedMigrationBucket should have comment or be unexported (golint)
    • weave/x/cron/model.go
    • Line 16: warning: exported method TaskResult.Validate should have comment or be unexported (golint)
    • Line 34: warning: exported function RegisterQuery should have comment or be unexported (golint)
    • weave/crypto/helpers.go
    • Line 12: warning: comment on exported type PubKey should be of the form "PubKey ..." (with optional leading article) (golint)
    • weave/x/batch/msg.go
    • Line 9: warning: exported const PathExecuteBatchMsg should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported type Msg should have comment or be unexported (golint)
    • Line 17: warning: exported function Validate should have comment or be unexported (golint)
    • weave/x/distribution/msg.go
    • Line 17: warning: exported method CreateMsg.Validate should have comment or be unexported (golint)
    • Line 27: warning: exported method CreateMsg.Path should have comment or be unexported (golint)
    • Line 33: warning: exported method DistributeMsg.Validate should have comment or be unexported (golint)
    • Line 44: warning: exported method DistributeMsg.Path should have comment or be unexported (golint)
    • Line 50: warning: exported method ResetMsg.Validate should have comment or be unexported (golint)
    • Line 59: warning: exported method ResetMsg.Path should have comment or be unexported (golint)
    • weave/weavetest/abci.go
    • Line 25: warning: comment on exported const ExecCheck should be of the form "ExecCheck ..." (golint)
    • Line 28: warning: comment on exported const NoBenchCheck should be of the form "NoBenchCheck ..." (golint)
    • Line 33: warning: comment on exported const ExecDeliver should be of the form "ExecDeliver ..." (golint)
    • Line 37: warning: exported const ExecCheckAndDeliver should have comment (or a comment on this block) or be unexported (golint)
    • weave/cmd/bnscli/cmd_sigs.go
    • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • weave/cmd/bnsd/x/termdeposit/model.go
    • Line 16: warning: exported method DepositContract.Validate should have comment or be unexported (golint)
    • Line 30: warning: exported function NewDepositContractBucket should have comment or be unexported (golint)
    • Line 41: warning: exported method Deposit.Validate should have comment or be unexported (golint)
    • Line 57: warning: exported function NewDepositBucket should have comment or be unexported (golint)
    • weave/store/test_suite.go
    • Line 13: warning: comment on exported type TestSuite should be of the form "TestSuite ..." (with optional leading article) (golint)
    • Line 25: warning: exported type TestStoreConstructor should have comment or be unexported (golint)
    • Line 27: warning: exported function NewTestSuite should have comment or be unexported (golint)
    • Line 287: warning: exported method TestSuite.AssertGetHas should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/account/decorator.go
    • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • weave/x/txfee/decorator.go
    • Line 12: warning: exported type Decorator should have comment or be unexported (golint)
    • Line 28: warning: exported method Decorator.Check should have comment or be unexported (golint)
    • Line 52: warning: exported method Decorator.Deliver should have comment or be unexported (golint)
    • Line 93: warning: exported function TransactionFee should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/qualityscore/msg.go
    • Line 10: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • Line 14: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • weave/time.go
    • Line 181: warning: exported method UnixDuration.MarshalJSON should have comment or be unexported (golint)
    • weave/x/escrow/msg.go
    • Line 43: warning: exported method CreateMsg.Path should have comment or be unexported (golint)
    • Line 70: warning: exported method ReleaseMsg.Path should have comment or be unexported (golint)
    • Line 87: warning: exported method ReturnMsg.Path should have comment or be unexported (golint)
    • Line 101: warning: exported method UpdatePartiesMsg.Path should have comment or be unexported (golint)
    • weave/x/paychan/msg.go
    • Line 17: warning: exported method CreateMsg.Validate should have comment or be unexported (golint)
    • Line 44: warning: exported method CreateMsg.Path should have comment or be unexported (golint)
    • Line 50: warning: exported method TransferMsg.Validate should have comment or be unexported (golint)
    • Line 78: warning: exported method TransferMsg.Path should have comment or be unexported (golint)
    • Line 84: warning: exported method CloseMsg.Validate should have comment or be unexported (golint)
    • Line 100: warning: exported method CloseMsg.Path should have comment or be unexported (golint)
    • weave/x/msgfee/model.go
    • Line 15: warning: exported method MsgFee.Validate should have comment or be unexported (golint)
    • Line 29: warning: exported method MsgFee.Copy should have comment or be unexported (golint)
    • weave/x/currency/handler.go
    • Line 12: warning: exported function RegisterQuery should have comment or be unexported (golint)
    • Line 16: warning: exported function RegisterRoutes should have comment or be unexported (golint)
    • weave/x/multisig/handlers.go
    • Line 25: warning: exported type CreateMsgHandler should have comment or be unexported (golint)
    • Line 32: warning: exported method CreateMsgHandler.Check should have comment or be unexported (golint)
    • Line 41: warning: exported method CreateMsgHandler.Deliver should have comment or be unexported (golint)
    • Line 82: warning: exported type UpdateMsgHandler should have comment or be unexported (golint)
    • Line 89: warning: exported method UpdateMsgHandler.Check should have comment or be unexported (golint)
    • Line 97: warning: exported method UpdateMsgHandler.Deliver should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/account/model.go
    • Line 20: warning: exported method Account.Validate should have comment or be unexported (golint)
    • Line 34: warning: exported function NewAccountBucket should have comment or be unexported (golint)
    • Line 59: warning: exported method Domain.Validate should have comment or be unexported (golint)
    • Line 99: warning: exported function NewDomainBucket should have comment or be unexported (golint)
    • weave/x/currency/model.go
    • Line 30: warning: exported method TokenInfo.Validate should have comment or be unexported (golint)
    • Line 45: warning: exported function NewTokenInfoBucket should have comment or be unexported (golint)
    • Line 51: warning: exported method TokenInfoBucket.Get should have comment or be unexported (golint)
    • Line 55: warning: exported method TokenInfoBucket.Save should have comment or be unexported (golint)
    • weave/weavetest/auth.go
    • Line 28: warning: exported method Auth.GetConditions should have comment or be unexported (golint)
    • Line 35: warning: exported method Auth.HasAddress should have comment or be unexported (golint)
    • Line 56: warning: exported method CtxAuth.SetConditions should have comment or be unexported (golint)
    • Line 57: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 60: warning: exported method CtxAuth.GetConditions should have comment or be unexported (golint)
    • Line 72: warning: exported method CtxAuth.HasAddress should have comment or be unexported (golint)
    • weave/orm/versioning_bucket.go
    • Line 14: warning: exported type VersioningBucket should have comment or be unexported (golint)
    • Line 95: warning: exported method VersioningBucket.GetVersion should have comment or be unexported (golint)
    • Line 129: warning: comment on exported method VersioningBucket.Save should be of the form "Save ..." (golint)
    • weave/datamigration/msg.go
    • Line 15: warning: exported method ExecuteMigrationMsg.Validate should have comment or be unexported (golint)
    • Line 24: warning: exported method ExecuteMigrationMsg.Path should have comment or be unexported (golint)
    • weave/cmd/bnscli/cmd_query.go
    • Line 247: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 257: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • weave/weavetest/tx.go
    • Line 23: warning: exported method Tx.GetMsg should have comment or be unexported (golint)
    • Line 27: warning: exported method Tx.Unmarshal should have comment or be unexported (golint)
    • Line 34: warning: exported method Tx.Marshal should have comment or be unexported (golint)
    • Line 54: warning: exported method Msg.Path should have comment or be unexported (golint)
    • Line 58: warning: exported method Msg.Validate should have comment or be unexported (golint)
    • Line 62: warning: exported method Msg.Unmarshal should have comment or be unexported (golint)
    • Line 72: warning: exported method Msg.Marshal should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/username/model.go
    • Line 17: warning: exported method BlockchainAddress.Validate should have comment or be unexported (golint)
    • Line 34: warning: exported method BlockchainAddress.Clone should have comment or be unexported (golint)
    • Line 55: warning: exported method Token.Copy should have comment or be unexported (golint)
    • weave/cmd/bnsd/client/keys.go
    • Line 16: warning: exported type PrivateKey should have comment or be unexported (golint)
    • Line 24: warning: exported function DecodePrivateKeyFromSeed should have comment or be unexported (golint)
    • weave/x/gov/model.go
    • Line 32: warning: exported method Electorate.SetVersion should have comment or be unexported (golint)
    • Line 36: warning: exported method Electorate.Validate should have comment or be unexported (golint)
    • Line 62: warning: comment on exported method Electorate.Elector should be of the form "Elector ..." (golint)
    • Line 75: warning: exported method Elector.Validate should have comment or be unexported (golint)
    • Line 90: warning: exported method ElectionRule.SetVersion should have comment or be unexported (golint)
    • Line 94: warning: exported method ElectionRule.Validate should have comment or be unexported (golint)
    • Line 132: warning: exported method Fraction.Validate should have comment or be unexported (golint)
    • Line 154: warning: exported method Proposal.Validate should have comment or be unexported (golint)
    • Line 254: warning: exported method Resolution.Validate should have comment or be unexported (golint)
    • Line 270: warning: exported function NewTallyResult should have comment or be unexported (golint)
    • Line 315: warning: exported method TallyResult.Validate should have comment or be unexported (golint)
    • Line 330: warning: comment on exported method Vote.Validate should be of the form "Validate ..." (golint)
    • weave/x/batch/decorator.go
    • Line 16: warning: exported const MaxBatchMessages should have comment or be unexported (golint)
    • Line 34: warning: exported type BatchTx should have comment or be unexported (golint)
    • Line 39: warning: exported method BatchTx.GetMsg should have comment or be unexported (golint)
    • weave/x/msgfee/antispam_query.go
    • Line 16: warning: exported function NewAntiSpamQuery should have comment or be unexported (golint)
    • Line 20: warning: exported method AntiSpamQuery.Query should have comment or be unexported (golint)
    • Line 28: warning: exported method AntiSpamQuery.RegisterQuery should have comment or be unexported (golint)
    • weave/x/validators/msg.go
    • Line 23: warning: exported method ApplyDiffMsg.Validate should have comment or be unexported (golint)
    • Line 35: warning: exported method ApplyDiffMsg.AsABCI should have comment or be unexported (golint)
    • weave/cmd/bnsd/scenarios/bnsdtest/client.go
    • Line 25: warning: comment on exported type ThrottledClient should be of the form "ThrottledClient ..." (with optional leading article) (golint)
    • Line 51: warning: exported method ThrottledClient.TendermintClient should have comment or be unexported (golint)
    • Line 55: warning: exported method ThrottledClient.GetUser should have comment or be unexported (golint)
    • Line 62: warning: exported method ThrottledClient.GetWallet should have comment or be unexported (golint)
    • Line 69: warning: exported method ThrottledClient.BroadcastTx should have comment or be unexported (golint)
    • Line 76: warning: exported method ThrottledClient.BroadcastTxAsync should have comment or be unexported (golint)
    • Line 83: warning: exported method ThrottledClient.BroadcastTxSync should have comment or be unexported (golint)
    • Line 90: warning: exported method ThrottledClient.AbciQuery should have comment or be unexported (golint)
    • weave/x/msgfee/handler_test.go
    • Line 33: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 64: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 79: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 94: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 108: warning: should not use basic type string as key in context.WithValue (golint)
    • weave/migration/msg.go
    • Line 14: warning: exported method UpgradeSchemaMsg.Validate should have comment or be unexported (golint)
    • Line 24: warning: exported method UpgradeSchemaMsg.Path should have comment or be unexported (golint)
    • weave/migration/orm.go
    • Line 49: warning: exported method Bucket.Get should have comment or be unexported (golint)
    • Line 60: warning: exported method Bucket.Save should have comment or be unexported (golint)
    • Line 71: warning: exported method Bucket.WithIndex should have comment or be unexported (golint)
    • Line 76: warning: exported method Bucket.WithMultiKeyIndex should have comment or be unexported (golint)
    • Line 92: warning: exported function NewModelBucket should have comment or be unexported (golint)
    • Line 101: warning: exported method ModelBucket.Register should have comment or be unexported (golint)
    • Line 105: warning: exported method ModelBucket.One should have comment or be unexported (golint)
    • Line 115: warning: exported method ModelBucket.Index should have comment or be unexported (golint)
    • Line 119: warning: exported method ModelBucket.ByIndex should have comment or be unexported (golint)
    • Line 148: warning: exported method ModelBucket.Put should have comment or be unexported (golint)
    • Line 155: warning: exported method ModelBucket.Delete should have comment or be unexported (golint)
    • Line 159: warning: exported method ModelBucket.Has should have comment or be unexported (golint)
    • Line 209: warning: exported function NewSerialModelBucket should have comment or be unexported (golint)
    • Line 218: warning: exported method SerialModelBucket.Register should have comment or be unexported (golint)
    • Line 222: warning: exported method SerialModelBucket.ByID should have comment or be unexported (golint)
    • Line 232: warning: exported method SerialModelBucket.ByIndex should have comment or be unexported (golint)
    • Line 260: warning: exported method SerialModelBucket.PrefixScan should have comment or be unexported (golint)
    • Line 269: warning: exported method SerialModelBucket.IndexScan should have comment or be unexported (golint)
    • Line 278: warning: exported method SerialModelBucket.Save should have comment or be unexported (golint)
    • Line 285: warning: exported method SerialModelBucket.Delete should have comment or be unexported (golint)
    • Line 289: warning: exported method SerialModelBucket.Has should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/termdeposit/msg.go
    • Line 18: warning: exported method CreateDepositContractMsg.Path should have comment or be unexported (golint)
    • Line 22: warning: exported method CreateDepositContractMsg.Validate should have comment or be unexported (golint)
    • Line 38: warning: exported method DepositMsg.Path should have comment or be unexported (golint)
    • Line 42: warning: exported method DepositMsg.Validate should have comment or be unexported (golint)
    • Line 59: warning: exported method ReleaseDepositMsg.Path should have comment or be unexported (golint)
    • Line 63: warning: exported method ReleaseDepositMsg.Validate should have comment or be unexported (golint)
    • Line 74: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • Line 78: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • weave/x/multisig/model.go
    • Line 23: warning: exported method Weight.Validate should have comment or be unexported (golint)
    • Line 37: warning: exported method Contract.Validate should have comment or be unexported (golint)
    • Line 52: warning: exported function NewContractBucket should have comment or be unexported (golint)
    • weave/x/sigs/msg.go
    • Line 20: warning: exported method BumpSequenceMsg.Validate should have comment or be unexported (golint)
    • Line 35: warning: exported method BumpSequenceMsg.Path should have comment or be unexported (golint)
    • weave/fraction.go
    • Line 27: warning: exported method Fraction.MarshalJSON should have comment or be unexported (golint)
    • Line 37: warning: exported method Fraction.UnmarshalJSON should have comment or be unexported (golint)
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 93: warning: receiver name a should be consistent with previous receiver name f for Fraction (golint)
    • weave/x/aswap/msg.go
    • Line 26: warning: exported method CreateMsg.Path should have comment or be unexported (golint)
    • Line 30: warning: exported method CreateMsg.Validate should have comment or be unexported (golint)
    • Line 59: warning: exported method ReleaseMsg.Path should have comment or be unexported (golint)
    • Line 63: warning: exported method ReleaseMsg.Validate should have comment or be unexported (golint)
    • Line 75: warning: exported method ReturnMsg.Path should have comment or be unexported (golint)
    • Line 80: warning: exported method ReturnMsg.Validate should have comment or be unexported (golint)
    • weave/weavetest/decorators.go
    • Line 26: warning: exported method Decorator.Check should have comment or be unexported (golint)
    • Line 35: warning: exported method Decorator.Deliver should have comment or be unexported (golint)
    • Line 44: warning: exported method Decorator.CheckCallCount should have comment or be unexported (golint)
    • Line 48: warning: exported method Decorator.DeliverCallCount should have comment or be unexported (golint)
    • Line 52: warning: exported method Decorator.CallCount should have comment or be unexported (golint)
    • Line 56: warning: exported function Decorate should have comment or be unexported (golint)
    • weave/x/msgfee/msg.go
    • Line 16: warning: exported method SetMsgFeeMsg.Validate should have comment or be unexported (golint)
    • Line 29: warning: exported method SetMsgFeeMsg.Path should have comment or be unexported (golint)
    • Line 48: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • weave/cmd/bnsd/scenarios/bnsdtest/bnsdtest.go
    • Line 36: warning: exported function StartBnsd should have comment or be unexported (golint)
    • Line 66: warning: exported type StartBnsdOption should have comment or be unexported (golint)
    • Line 132: warning: exported const TendermintLocalAddr should have comment or be unexported (golint)
    • Line 385: warning: exported function WaitCronTask should have comment or be unexported (golint)
    • Line 420: warning: exported function WaitCronTaskSuccess should have comment or be unexported (golint)
    • weave/cmd/bnsd/app/msg.go
    • Line 21: warning: exported method ExecuteBatchMsg.Path should have comment or be unexported (golint)
    • Line 25: warning: exported method ExecuteBatchMsg.Validate should have comment or be unexported (golint)
    • Line 29: warning: exported method ExecuteBatchMsg.MsgList should have comment or be unexported (golint)
    • Line 45: warning: exported method ExecuteProposalBatchMsg.Path should have comment or be unexported (golint)
    • Line 49: warning: exported method ExecuteProposalBatchMsg.Validate should have comment or be unexported (golint)
    • Line 53: warning: exported method ExecuteProposalBatchMsg.MsgList should have comment or be unexported (golint)
    • weave/app/helpers.go
    • Line 22: warning: exported function NewABCIStore should have comment or be unexported (golint)
    • Line 83: warning: exported method ABCIStore.ReverseIterator should have comment or be unexported (golint)
    • weave/cmd/bnsd/scenarios/bnsdtest/env.go
    • Line 48: warning: exported function WithMinFee should have comment or be unexported (golint)
    • Line 54: warning: exported function WithAntiSpamFee should have comment or be unexported (golint)
    • Line 60: warning: exported function WithLogger should have comment or be unexported (golint)
    • Line 66: warning: exported function WithThrottle should have comment or be unexported (golint)
    • Line 72: warning: exported function WithMsgFee should have comment or be unexported (golint)
    • Line 78: warning: exported function WithUsername should have comment or be unexported (golint)
    • weave/doc.go
    • Line 9: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
    • weave/orm/model.go
    • Line 9: warning: exported method VersionedIDRef.Validate should have comment or be unexported (golint)
    • Line 19: warning: exported method VersionedIDRef.SetVersion should have comment or be unexported (golint)
    • weave/x/gov/handler.go
    • Line 50: warning: exported function RegisterCronRoutes should have comment or be unexported (golint)
    • Line 67: warning: exported type VoteHandler should have comment or be unexported (golint)
    • Line 83: warning: exported method VoteHandler.Check should have comment or be unexported (golint)
    • Line 91: warning: exported method VoteHandler.Deliver should have comment or be unexported (golint)
    • Line 169: warning: exported type TallyHandler should have comment or be unexported (golint)
    • Line 187: warning: exported method TallyHandler.Check should have comment or be unexported (golint)
    • Line 191: warning: exported method TallyHandler.Deliver should have comment or be unexported (golint)
    • Line 280: warning: exported type CreateProposalHandler should have comment or be unexported (golint)
    • Line 300: warning: exported method CreateProposalHandler.Check should have comment or be unexported (golint)
    • Line 308: warning: exported method CreateProposalHandler.Deliver should have comment or be unexported (golint)
    • Line 430: warning: exported type DeleteProposalHandler should have comment or be unexported (golint)
    • Line 467: warning: exported method DeleteProposalHandler.Check should have comment or be unexported (golint)
    • Line 474: warning: exported method DeleteProposalHandler.Deliver should have comment or be unexported (golint)
    • Line 499: warning: exported type UpdateElectorateHandler should have comment or be unexported (golint)
    • Line 513: warning: exported method UpdateElectorateHandler.Check should have comment or be unexported (golint)
    • Line 521: warning: exported method UpdateElectorateHandler.Deliver should have comment or be unexported (golint)
    • Line 561: warning: exported type UpdateElectionRuleHandler should have comment or be unexported (golint)
    • Line 575: warning: exported method UpdateElectionRuleHandler.Check should have comment or be unexported (golint)
    • Line 583: warning: exported method UpdateElectionRuleHandler.Deliver should have comment or be unexported (golint)
    • weave/migration/model.go
    • Line 17: warning: exported method Schema.Validate should have comment or be unexported (golint)
    • Line 30: warning: exported method Schema.Copy should have comment or be unexported (golint)
    • Line 48: warning: exported type SchemaBucket should have comment or be unexported (golint)
    • Line 52: warning: exported function NewSchemaBucket should have comment or be unexported (golint)
    • Line 100: warning: exported method SchemaBucket.Get should have comment or be unexported (golint)
    • weave/cmd/bnsd/x/username/msg.go
    • Line 18: warning: exported method UpdateConfigurationMsg.Validate should have comment or be unexported (golint)
    • Line 25: warning: exported method UpdateConfigurationMsg.Path should have comment or be unexported (golint)
    • Line 31: warning: exported method RegisterTokenMsg.Validate should have comment or be unexported (golint)
    • Line 44: warning: exported method RegisterTokenMsg.Path should have comment or be unexported (golint)
    • Line 50: warning: exported method TransferTokenMsg.Validate should have comment or be unexported (golint)
    • Line 63: warning: exported method TransferTokenMsg.Path should have comment or be unexported (golint)
    • Line 69: warning: exported method ChangeTokenTargetsMsg.Validate should have comment or be unexported (golint)
    • Line 82: warning: exported method ChangeTokenTargetsMsg.Path should have comment or be unexported (golint)
    • weave/x/msgfee/fee_decorator.go
    • Line 30: warning: exported method FeeDecorator.Check should have comment or be unexported (golint)
    • Line 50: warning: exported method FeeDecorator.Deliver should have comment or be unexported (golint)
    • weave/coin/coin.go
    • Line 54: warning: comment on exported method Coin.Divide should be of the form "Divide ..." (golint)
    • Line 109: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 314: warning: exported method Coin.UnmarshalJSON should have comment or be unexported (golint)
    • weave/x/distribution/model.go
    • Line 18: warning: exported method Revenue.Validate should have comment or be unexported (golint)
    • Line 93: warning: exported function RevenueAccount should have comment or be unexported (golint)
    • weave/errors/errors.go
    • Line 162: warning: exported method Error.ABCICode should have comment or be unexported (golint)
    • Line 168: warning: receiver name kind should be consistent with previous receiver name e for Error (golint)
    • weave/cmd/bnsd/client/admin.go
    • Line 8: warning: exported const CurrentHeight should have comment (or a comment on this block) or be unexported (golint)
    • Line 16: warning: exported function Admin should have comment or be unexported (golint)
    • weave/cmd/bnsd/client/client.go
    • Line 22: warning: exported type Header should have comment or be unexported (golint)
    • Line 23: warning: exported type Status should have comment or be unexported (golint)
    • Line 24: warning: exported type GenesisDoc should have comment or be unexported (golint)
    • Line 26: warning: exported const BroadcastTxSyncDefaultTimeOut should have comment or be unexported (golint)
    • Line 28: warning: exported var QueryNewBlockHeader should have comment or be unexported (golint)
    • Line 59: warning: exported method BnsClient.TendermintClient should have comment or be unexported (golint)
    • Line 119: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 124: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 133: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 142: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 163: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 195: warning: exported method BnsClient.TxSearch should have comment or be unexported (golint)
    • Line 195: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 227: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 235: warning: exported method BnsClient.BroadcastTxSync should have comment or be unexported (golint)
    • Line 235: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 271: warning: exported method BnsClient.WaitForTxEvent should have comment or be unexported (golint)
    • Line 271: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 296: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 316: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 340: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 353: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 361: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 400: warning: exported type CurrenciesResponse should have comment or be unexported (golint)
    • Line 406: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • Line 436: warning: receiver name b should be consistent with previous receiver name bc for BnsClient (golint)
    • weave/x/currency/msg.go
    • Line 13: warning: exported method CreateMsg.Path should have comment or be unexported (golint)
    • Line 17: warning: exported method CreateMsg.Validate should have comment or be unexported (golint)
    • weave/x/gov/msg.go
    • Line 22: warning: exported method CreateProposalMsg.Path should have comment or be unexported (golint)
    • Line 26: warning: exported method CreateProposalMsg.Validate should have comment or be unexported (golint)
    • Line 58: warning: exported method DeleteProposalMsg.Path should have comment or be unexported (golint)
    • Line 62: warning: exported method DeleteProposalMsg.Validate should have comment or be unexported (golint)
    • Line 73: warning: exported method VoteMsg.Path should have comment or be unexported (golint)
    • Line 77: warning: exported method VoteMsg.Validate should have comment or be unexported (golint)
    • Line 94: warning: exported method TallyMsg.Path should have comment or be unexported (golint)
    • Line 98: warning: exported method TallyMsg.Validate should have comment or be unexported (golint)
    • Line 109: warning: exported method UpdateElectionRuleMsg.Path should have comment or be unexported (golint)
    • Line 113: warning: exported method UpdateElectionRuleMsg.Validate should have comment or be unexported (golint)
    • Line 133: warning: exported method CreateTextResolutionMsg.Path should have comment or be unexported (golint)
    • Line 137: warning: exported method CreateTextResolutionMsg.Validate should have comment or be unexported (golint)
    • Line 148: warning: exported method UpdateElectorateMsg.Path should have comment or be unexported (golint)
    • Line 152: warning: exported method UpdateElectorateMsg.Validate should have comment or be unexported (golint)
    • weave/x/gov/bucket.go
    • Line 59: warning: exported method ElectionRulesBucket.NextID should have comment or be unexported (golint)
    • Line 145: warning: exported function NewResolutionBucket should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell95%

Misspell Finds commonly misspelled English words

    • weave/x/cron/cron.go
    • Line 70: warning: "existance" is a misspelling of "existence" (misspell)
    • Line 149: warning: "implementes" is a misspelling of "implements" (misspell)
    • Line 193: warning: "infromation" is a misspelling of "information" (misspell)
    • weave/weavetest/cron.go
    • Line 31: warning: "implementes" is a misspelling of "implements" (misspell)
    • Line 58: warning: "implementes" is a misspelling of "implements" (misspell)
    • Line 73: warning: "implementes" is a misspelling of "implements" (misspell)