gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• istio/pkg/config/schema/gvk/resources.gen.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• istio/pkg/config/xds/filter_types.gen.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• istio/pkg/test/framework/features/features.gen.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint72%

Golint is a linter for Go source code.

• istio/pilot/pkg/networking/core/v1alpha3/envoyfilter/monitoring.go
  • Line 1: warning: package comment should be of the form "Package envoyfilter ..." (golint)
  • Line 23: warning: exported type Result should have comment or be unexported (golint)
  • Line 26: warning: exported const Error should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported type PatchType should have comment or be unexported (golint)
  • Line 33: warning: exported const Cluster should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: comment on exported const HttpFilter should be of the form "HttpFilter ..." (golint)
  • Line 91: warning: exported function RecordMetrics should have comment or be unexported (golint)

• istio/cni/pkg/plugin/kubernetes.go
  • Line 38: warning: exported type PodInfo should have comment or be unexported (golint)

• istio/tools/docker-builder/types.go
  • Line 31: warning: comment on exported type Group should be of the form "Group ..." (with optional leading article) (golint)
  • Line 36: warning: exported type BakeFile should have comment or be unexported (golint)
  • Line 41: warning: exported type Target should have comment or be unexported (golint)
  • Line 59: warning: exported type Args should have comment or be unexported (golint)
  • Line 87: warning: exported function DefaultArgs should have comment or be unexported (golint)

• istio/pilot/pkg/networking/grpcgen/grpcgen.go
  • Line 46: warning: exported type GrpcConfigGenerator should have comment or be unexported (golint)
  • Line 56: warning: exported method GrpcConfigGenerator.Generate should have comment or be unexported (golint)

• istio/istioctl/cmd/internal-debug.go
  • Line 33: warning: exported function HandlerForRetrieveDebugList should have comment or be unexported (golint)
  • Line 53: warning: exported function HandlerForDebugErrors should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/annotations.go
  • Line 25: warning: exported type AnnotationType should have comment or be unexported (golint)
  • Line 28: warning: exported const WorkloadAnnotation should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type Annotation should have comment or be unexported (golint)
  • Line 38: warning: exported var SidecarInject should have comment or be unexported (golint)
  • Line 51: warning: exported type AnnotationValue should have comment or be unexported (golint)
  • Line 55: warning: exported method AnnotationValue.Get should have comment or be unexported (golint)
  • Line 59: warning: exported method AnnotationValue.AsBool should have comment or be unexported (golint)
  • Line 63: warning: exported method AnnotationValue.AsInt should have comment or be unexported (golint)
  • Line 67: warning: exported method AnnotationValue.Set should have comment or be unexported (golint)
  • Line 72: warning: exported method AnnotationValue.SetBool should have comment or be unexported (golint)
  • Line 77: warning: exported method AnnotationValue.SetInt should have comment or be unexported (golint)
  • Line 82: warning: exported function NewAnnotationValue should have comment or be unexported (golint)
  • Line 96: warning: exported type Annotations should have comment or be unexported (golint)
  • Line 98: warning: exported function NewAnnotations should have comment or be unexported (golint)
  • Line 102: warning: exported method Annotations.Set should have comment or be unexported (golint)
  • Line 107: warning: exported method Annotations.SetBool should have comment or be unexported (golint)
  • Line 112: warning: exported method Annotations.SetInt should have comment or be unexported (golint)
  • Line 125: warning: exported method Annotations.GetByName should have comment or be unexported (golint)
  • Line 134: warning: exported method Annotations.Get should have comment or be unexported (golint)
  • Line 138: warning: exported method Annotations.GetBool should have comment or be unexported (golint)
  • Line 142: warning: exported method Annotations.GetInt should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/sync.go
  • Line 19: warning: exported var SyncAllKinds should have comment or be unexported (golint)

• istio/security/pkg/credentialfetcher/plugin/mock.go
  • Line 64: warning: exported method MockPlugin.Stop should have comment or be unexported (golint)
  • Line 127: warning: exported method MetadataServer.Stop should have comment or be unexported (golint)

• istio/cni/pkg/plugin/iptables.go
  • Line 15: warning: package comment should be of the form "Package plugin ..." (golint)

• istio/pilot/pkg/status/report.go
  • Line 28: warning: exported type DistributionReport should have comment or be unexported (golint)
  • Line 34: warning: exported function ReportFromYaml should have comment or be unexported (golint)
  • Line 40: warning: exported function ResourceFromString should have comment or be unexported (golint)
  • Line 58: warning: comment on exported type Resource should be of the form "Resource ..." (with optional leading article) (golint)
  • Line 71: warning: exported method Resource.ToModelKey should have comment or be unexported (golint)
  • Line 79: warning: exported function ResourceFromModelConfig should have comment or be unexported (golint)
  • Line 93: warning: exported function ResourceToModelConfig should have comment or be unexported (golint)
  • Line 103: warning: exported function GVKtoGVR should have comment or be unexported (golint)
  • Line 115: warning: exported function GVRtoGVK should have comment or be unexported (golint)

• istio/pkg/test/framework/components/istio/ingress/interface.go
  • Line 24: warning: exported type Instances should have comment or be unexported (golint)
  • Line 26: warning: exported method Instances.Callers should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/constants/constants.go
  • Line 36: warning: exported var BuiltInChainsMap should have comment or be unexported (golint)
  • Line 108: warning: exported const DefaultProxyUID should have comment (or a comment on this block) or be unexported (golint)
  • Line 135: warning: exported const DefaultIptablesProbePort should have comment (or a comment on this block) or be unexported (golint)
  • Line 140: warning: exported const ValidationContainerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 150: warning: exported const CommandConfigureRoutes should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/bootstrap/options.go
  • Line 100: warning: exported type InjectionOptions should have comment or be unexported (golint)
  • Line 115: warning: exported var PodNamespace should have comment or be unexported (golint)
  • Line 152: warning: exported method PilotArgs.Complete should have comment or be unexported (golint)

• istio/pkg/bootstrap/option/instances.go
  • Line 28: warning: exported type LocalhostValue should have comment or be unexported (golint)
  • Line 29: warning: exported type WildcardValue should have comment or be unexported (golint)
  • Line 30: warning: exported type DNSLookupFamilyValue should have comment or be unexported (golint)
  • Line 34: warning: exported const LocalhostIPv4 should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported function ProxyConfig should have comment or be unexported (golint)
  • Line 46: warning: exported function PilotSubjectAltName should have comment or be unexported (golint)
  • Line 50: warning: exported function ConnectTimeout should have comment or be unexported (golint)
  • Line 54: warning: exported function Cluster should have comment or be unexported (golint)
  • Line 58: warning: exported function NodeID should have comment or be unexported (golint)
  • Line 62: warning: exported function NodeType should have comment or be unexported (golint)
  • Line 67: warning: exported function XdsType should have comment or be unexported (golint)
  • Line 71: warning: exported function Region should have comment or be unexported (golint)
  • Line 75: warning: exported function Zone should have comment or be unexported (golint)
  • Line 79: warning: exported function SubZone should have comment or be unexported (golint)
  • Line 83: warning: exported function NodeMetadata should have comment or be unexported (golint)
  • Line 87: warning: exported function DiscoveryAddress should have comment or be unexported (golint)
  • Line 91: warning: exported function Localhost should have comment or be unexported (golint)
  • Line 95: warning: exported function Wildcard should have comment or be unexported (golint)
  • Line 99: warning: exported function DNSLookupFamily should have comment or be unexported (golint)
  • Line 103: warning: exported function OutlierLogPath should have comment or be unexported (golint)
  • Line 107: warning: exported function LightstepAddress should have comment or be unexported (golint)
  • Line 111: warning: exported function LightstepToken should have comment or be unexported (golint)
  • Line 115: warning: exported function OpenCensusAgentAddress should have comment or be unexported (golint)
  • Line 119: warning: exported function OpenCensusAgentContexts should have comment or be unexported (golint)
  • Line 124: warning: exported function StackDriverEnabled should have comment or be unexported (golint)
  • Line 128: warning: exported function StackDriverProjectID should have comment or be unexported (golint)
  • Line 132: warning: exported function StackDriverDebug should have comment or be unexported (golint)
  • Line 136: warning: exported function StackDriverMaxAnnotations should have comment or be unexported (golint)
  • Line 140: warning: exported function StackDriverMaxAttributes should have comment or be unexported (golint)
  • Line 144: warning: exported function StackDriverMaxEvents should have comment or be unexported (golint)
  • Line 148: warning: exported function PilotGRPCAddress should have comment or be unexported (golint)
  • Line 152: warning: exported function ZipkinAddress should have comment or be unexported (golint)
  • Line 156: warning: exported function DataDogAddress should have comment or be unexported (golint)
  • Line 160: warning: exported function StatsdAddress should have comment or be unexported (golint)
  • Line 164: warning: exported function TracingTLS should have comment or be unexported (golint)
  • Line 169: warning: exported function EnvoyMetricsServiceAddress should have comment or be unexported (golint)
  • Line 173: warning: exported function EnvoyMetricsServiceTLS should have comment or be unexported (golint)
  • Line 178: warning: exported function EnvoyMetricsServiceTCPKeepalive should have comment or be unexported (golint)
  • Line 182: warning: exported function EnvoyAccessLogServiceAddress should have comment or be unexported (golint)
  • Line 186: warning: exported function EnvoyAccessLogServiceTLS should have comment or be unexported (golint)
  • Line 191: warning: exported function EnvoyAccessLogServiceTCPKeepalive should have comment or be unexported (golint)
  • Line 195: warning: exported function EnvoyExtraStatTags should have comment or be unexported (golint)
  • Line 199: warning: exported function EnvoyStatsMatcherInclusionPrefix should have comment or be unexported (golint)
  • Line 203: warning: exported function EnvoyStatsMatcherInclusionSuffix should have comment or be unexported (golint)
  • Line 207: warning: exported function EnvoyStatsMatcherInclusionRegexp should have comment or be unexported (golint)
  • Line 211: warning: exported function EnvoyStatusPort should have comment or be unexported (golint)
  • Line 215: warning: exported function EnvoyPrometheusPort should have comment or be unexported (golint)
  • Line 219: warning: exported function STSPort should have comment or be unexported (golint)
  • Line 223: warning: exported function GCPProjectID should have comment or be unexported (golint)
  • Line 227: warning: exported function STSEnabled should have comment or be unexported (golint)
  • Line 231: warning: exported function ProvCert should have comment or be unexported (golint)
  • Line 235: warning: exported function DiscoveryHost should have comment or be unexported (golint)

• istio/pkg/util/gogo/conversion.go
  • Line 53: warning: exported function ConvertAny should have comment or be unexported (golint)
  • Line 60: warning: exported function BoolToProtoBool should have comment or be unexported (golint)
  • Line 70: warning: exported function DurationToProtoDuration should have comment or be unexported (golint)

• istio/pkg/config/resource/name.go
  • Line 88: warning: comment on exported function ParseFullNameWithDefaultNamespace should be of the form "ParseFullNameWithDefaultNamespace ..." (golint)

• istio/pkg/test/cert/ca/intermediate.go
  • Line 64: warning: comment on exported type Intermediate should be of the form "Intermediate ..." (with optional leading article) (golint)

• istio/pilot/pkg/model/fake_store.go
  • Line 23: warning: exported type FakeStore should have comment or be unexported (golint)
  • Line 27: warning: exported function NewFakeStore should have comment or be unexported (golint)
  • Line 36: warning: exported method FakeStore.Schemas should have comment or be unexported (golint)
  • Line 40: warning: exported method FakeStore.Get should have comment or be unexported (golint)
  • Line 42: warning: exported method FakeStore.List should have comment or be unexported (golint)
  • Line 57: warning: exported method FakeStore.Create should have comment or be unexported (golint)
  • Line 67: warning: exported method FakeStore.Update should have comment or be unexported (golint)
  • Line 69: warning: exported method FakeStore.UpdateStatus should have comment or be unexported (golint)
  • Line 71: warning: exported method FakeStore.Patch should have comment or be unexported (golint)
  • Line 75: warning: exported method FakeStore.Delete should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/listener.go
  • Line 56: warning: exported const NoConflict should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: comment on exported const HTTPOverHTTP should be of the form "HTTPOverHTTP ..." (golint)
  • Line 59: warning: comment on exported const HTTPOverTCP should be of the form "HTTPOverTCP ..." (golint)
  • Line 61: warning: comment on exported const HTTPOverAuto should be of the form "HTTPOverAuto ..." (golint)
  • Line 63: warning: comment on exported const TCPOverHTTP should be of the form "TCPOverHTTP ..." (golint)
  • Line 65: warning: comment on exported const TCPOverTCP should be of the form "TCPOverTCP ..." (golint)
  • Line 67: warning: comment on exported const TCPOverAuto should be of the form "TCPOverAuto ..." (golint)
  • Line 69: warning: comment on exported const AutoOverHTTP should be of the form "AutoOverHTTP ..." (golint)
  • Line 71: warning: comment on exported const AutoOverTCP should be of the form "AutoOverTCP ..." (golint)
  • Line 73: warning: comment on exported const AutoOverAuto should be of the form "AutoOverAuto ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/gateway/certificate.go
  • Line 28: warning: exported type CertificateAnalyzer should have comment or be unexported (golint)
  • Line 32: warning: exported method CertificateAnalyzer.Metadata should have comment or be unexported (golint)

• istio/istioctl/pkg/tag/generate.go
  • Line 34: warning: exported const IstioTagLabel should have comment (or a comment on this block) or be unexported (golint)

• istio/operator/pkg/metrics/monitoring.go
  • Line 76: warning: exported const RenderNotStartedError should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/config/kube/gateway/conversion.go
  • Line 40: warning: exported const DefaultClassName should have comment (or a comment on this block) or be unexported (golint)
  • Line 1389: warning: exported function StrPointer should have comment or be unexported (golint)

• istio/security/pkg/stsservice/mock/faketokenmanager.go
  • Line 27: warning: exported type FakeTokenManager should have comment or be unexported (golint)
  • Line 35: warning: exported function CreateFakeTokenManager should have comment or be unexported (golint)
  • Line 45: warning: exported method FakeTokenManager.SetGenerateTokenError should have comment or be unexported (golint)
  • Line 51: warning: exported method FakeTokenManager.SetDumpTokenError should have comment or be unexported (golint)
  • Line 57: warning: exported method FakeTokenManager.SetRespStsParam should have comment or be unexported (golint)
  • Line 63: warning: exported method FakeTokenManager.SetToken should have comment or be unexported (golint)

• istio/pilot/pkg/xds/bootstrapds.go
  • Line 35: warning: comment on exported type BootstrapGenerator should be of the form "BootstrapGenerator ..." (with optional leading article) (golint)

• istio/security/pkg/stsservice/tokenmanager/google/mock/mockserver.go
  • Line 32: warning: exported var FakeFederatedToken should have comment or be unexported (golint)
  • Line 58: warning: exported type Duration should have comment or be unexported (golint)
  • Line 101: warning: exported type Config should have comment or be unexported (golint)
  • Line 146: warning: exported method AuthorizationServer.SetGenFedTokenError should have comment or be unexported (golint)
  • Line 152: warning: exported method AuthorizationServer.BlockFederatedTokenRequest should have comment or be unexported (golint)
  • Line 158: warning: exported method AuthorizationServer.BlockAccessTokenRequest should have comment or be unexported (golint)
  • Line 164: warning: exported method AuthorizationServer.SetGenAcsTokenError should have comment or be unexported (golint)
  • Line 184: warning: comment on exported method AuthorizationServer.EnableDynamicAccessToken should be of the form "EnableDynamicAccessToken ..." (golint)
  • Line 191: warning: exported method AuthorizationServer.NumGetAccessTokenCalls should have comment or be unexported (golint)
  • Line 197: warning: exported method AuthorizationServer.NumGetFederatedTokenCalls should have comment or be unexported (golint)

• istio/istioctl/pkg/util/formatting/formatter.go
  • Line 39: warning: exported var MsgOutputFormatKeys should have comment or be unexported (golint)
  • Line 118: warning: exported function IstioctlColorDefault should have comment or be unexported (golint)

• istio/tests/fuzz/compare_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 52: warning: exported function FuzzCompareDiff should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/diag/messages.go
  • Line 89: warning: exported method Messages.FilterOutBasedOnResources should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/serviceentry/conversion.go
  • Line 46: warning: exported type HostAddress should have comment or be unexported (golint)

• istio/pkg/config/schema/codegen/collections.go
  • Line 144: warning: exported function WriteGvk should have comment or be unexported (golint)

• istio/pkg/security/security.go
  • Line 104: warning: exported const BearerTokenPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 310: warning: exported type CredFetcher should have comment or be unexported (golint)
  • Line 328: warning: exported const AuthSourceClientCertificate should have comment (or a comment on this block) or be unexported (golint)
  • Line 342: warning: exported type Authenticator should have comment or be unexported (golint)
  • Line 348: warning: exported function ExtractBearerToken should have comment or be unexported (golint)
  • Line 368: warning: exported function ExtractRequestToken should have comment or be unexported (golint)
  • Line 409: warning: exported type SdsCertificateConfig should have comment or be unexported (golint)
  • Line 416: warning: exported const ResourceSeparator should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/status/resourcelock.go
  • Line 27: warning: exported type ResourceStatus should have comment or be unexported (golint)
  • Line 62: warning: exported type WorkQueue should have comment or be unexported (golint)
  • Line 73: warning: exported method WorkQueue.Push should have comment or be unexported (golint)
  • Line 108: warning: exported method WorkQueue.Length should have comment or be unexported (golint)
  • Line 114: warning: exported method WorkQueue.Delete should have comment or be unexported (golint)
  • Line 120: warning: exported type WorkerPool should have comment or be unexported (golint)
  • Line 134: warning: exported function NewProgressWorkerPool should have comment or be unexported (golint)
  • Line 141: warning: exported function NewWorkerPool should have comment or be unexported (golint)
  • Line 154: warning: exported method WorkerPool.Delete should have comment or be unexported (golint)
  • Line 158: warning: exported method WorkerPool.Push should have comment or be unexported (golint)
  • Line 163: warning: exported method WorkerPool.Run should have comment or be unexported (golint)

• istio/security/pkg/pki/util/generate_csr.go
  • Line 121: warning: comment on exported function AppendCertByte should be of the form "AppendCertByte ..." (golint)

• istio/pkg/test/framework/resource/resource.go
  • Line 47: warning: exported method FakeResource.ID should have comment or be unexported (golint)

• istio/security/pkg/credentialfetcher/plugin/gce.go
  • Line 84: warning: exported method GCEPlugin.Stop should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/leaderelection.go
  • Line 17: warning: package comment should be of the form "Package k8sleaderelection ..." (golint)
  • Line 73: warning: exported const JitterFactor should have comment (or a comment on this block) or be unexported (golint)
  • Line 112: warning: exported type KeyComparisonFunc should have comment or be unexported (golint)
  • Line 114: warning: exported type LeaderElectionConfig should have comment or be unexported (golint)

• istio/pilot/pkg/xds/pushqueue.go
  • Line 23: warning: exported type PushQueue should have comment or be unexported (golint)
  • Line 41: warning: exported function NewPushQueue should have comment or be unexported (golint)
  • Line 76: warning: comment on exported method PushQueue.Dequeue should be of the form "Dequeue ..." (golint)
  • Line 106: warning: exported method PushQueue.MarkDone should have comment or be unexported (golint)
  • Line 121: warning: comment on exported method PushQueue.Pending should be of the form "Pending ..." (golint)

• istio/pkg/test/framework/image/settings.go
  • Line 77: warning: exported method Settings.ImagePullSecretName should have comment or be unexported (golint)
  • Line 92: warning: exported function PullSecretNameOrFail should have comment or be unexported (golint)
  • Line 104: warning: exported function PullImagePolicy should have comment or be unexported (golint)

• istio/pilot/pkg/simulation/traffic.go
  • Line 45: warning: exported type Protocol should have comment or be unexported (golint)
  • Line 48: warning: exported const HTTP should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported type TLSMode should have comment or be unexported (golint)
  • Line 56: warning: exported const Plaintext should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported method Call.IsHTTP should have comment or be unexported (golint)
  • Line 68: warning: exported var ErrNoListener should have comment or be unexported (golint)
  • Line 80: warning: exported type Expect should have comment or be unexported (golint)
  • Line 86: warning: exported type CallMode should have comment or be unexported (golint)
  • Line 97: warning: exported type Call should have comment or be unexported (golint)
  • Line 119: warning: exported method Call.FillDefaults should have comment or be unexported (golint)
  • Line 149: warning: exported type Result should have comment or be unexported (golint)
  • Line 168: warning: exported method Result.Matches should have comment or be unexported (golint)
  • Line 204: warning: exported type Simulation should have comment or be unexported (golint)
  • Line 211: warning: exported function NewSimulationFromConfigGen should have comment or be unexported (golint)
  • Line 221: warning: exported function NewSimulation should have comment or be unexported (golint)
  • Line 232: warning: exported method Simulation.RunExpectations should have comment or be unexported (golint)
  • Line 251: warning: exported method Simulation.Run should have comment or be unexported (golint)

• istio/pilot/pkg/model/extensions.go
  • Line 1: warning: package comment should be of the form "Package model ..." (golint)
  • Line 38: warning: exported type WasmPluginWrapper should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/echo.go
  • Line 65: warning: exported type Caller should have comment or be unexported (golint)
  • Line 76: warning: exported type Callers should have comment or be unexported (golint)
  • Line 112: warning: comment on exported type WorkloadPort should be of the form "WorkloadPort ..." (with optional leading article) (golint)

• istio/galley/pkg/config/testing/basicmeta/get.go
  • Line 38: warning: comment on exported function Get2 should be of the form "Get2 ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/util/find_errorline_utils.go
  • Line 29: warning: comment on exported const DestinationHost should be of the form "DestinationHost ..." (golint)
  • Line 33: warning: comment on exported const MirrorHost should be of the form "MirrorHost ..." (golint)
  • Line 37: warning: comment on exported const VSGateway should be of the form "VSGateway ..." (golint)
  • Line 41: warning: comment on exported const URISchemeMethodAuthorityRegexMatch should be of the form "URISchemeMethodAuthorityRegexMatch ..." (golint)
  • Line 45: warning: comment on exported const HeaderAndQueryParamsRegexMatch should be of the form "HeaderAndQueryParamsRegexMatch ..." (golint)
  • Line 49: warning: comment on exported const AllowOriginsRegexMatch should be of the form "AllowOriginsRegexMatch ..." (golint)
  • Line 53: warning: comment on exported const WorkloadSelector should be of the form "WorkloadSelector ..." (golint)
  • Line 57: warning: comment on exported const PortInPorts should be of the form "PortInPorts ..." (golint)
  • Line 61: warning: comment on exported const FromRegistry should be of the form "FromRegistry ..." (golint)
  • Line 65: warning: comment on exported const ImageInContainer should be of the form "ImageInContainer ..." (golint)
  • Line 69: warning: comment on exported const MetadataNamespace should be of the form "MetadataNamespace ..." (golint)
  • Line 73: warning: comment on exported const MetadataName should be of the form "MetadataName ..." (golint)
  • Line 77: warning: comment on exported const AuthorizationPolicyNameSpace should be of the form "AuthorizationPolicyNameSpace ..." (golint)
  • Line 81: warning: comment on exported const Annotation should be of the form "Annotation ..." (golint)
  • Line 85: warning: comment on exported const GatewaySelector should be of the form "GatewaySelector ..." (golint)
  • Line 89: warning: comment on exported const CredentialName should be of the form "CredentialName ..." (golint)
  • Line 93: warning: comment on exported const ServiceEntryPort should be of the form "ServiceEntryPort ..." (golint)
  • Line 97: warning: comment on exported const DestinationRuleTLSCert should be of the form "DestinationRuleTLSCert ..." (golint)
  • Line 101: warning: comment on exported const DestinationRuleTLSPortLevelCert should be of the form "DestinationRuleTLSPortLevelCert ..." (golint)
  • Line 125: warning: exported function AddLineNumber should have comment or be unexported (golint)

• istio/operator/pkg/apis/istio/v1alpha1/common.go
  • Line 63: warning: comment on exported type IntOrStringForPB should be of the form "IntOrStringForPB ..." (with optional leading article) (golint)

• istio/pilot/pkg/config/kube/ingressv1/conversion.go
  • Line 41: warning: exported const IstioIngressController should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/bootstrap/istio_ca.go
  • Line 101: warning: exported var SelfSignedCACertTTL should have comment or be unexported (golint)

• istio/tests/fuzz/security_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 37: warning: exported function FuzzGenCSR should have comment or be unexported (golint)
  • Line 75: warning: exported function FuzzCreateCertE2EUsingClientCertAuthenticator should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/status/server.go
  • Line 73: warning: exported var UpstreamLocalAddressIPv4 should have comment or be unexported (golint)
  • Line 77: warning: exported var PrometheusScrapingConfig should have comment or be unexported (golint)
  • Line 84: warning: exported var LegacyLocalhostProbeDestination should have comment or be unexported (golint)
  • Line 435: warning: exported type PrometheusScrapeConfiguration should have comment or be unexported (golint)

• istio/pilot/pkg/networking/plugin/authn/authentication.go
  • Line 89: warning: exported method Plugin.InboundMTLSConfiguration should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/factory.go
  • Line 35: warning: exported function GetBuilder should have comment or be unexported (golint)

• istio/pkg/test/shell/shell.go
  • Line 47: warning: exported function ExecuteArgs should have comment or be unexported (golint)

• istio/pkg/test/framework/resource/version.go
  • Line 32: warning: exported method RevVerMap.SetConfig should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/caclient/credentials.go
  • Line 47: warning: comment on exported function NewCATokenProvider should be of the form "NewCATokenProvider ..." (golint)
  • Line 53: warning: exported function NewXDSTokenProvider should have comment or be unexported (golint)
  • Line 57: warning: exported method TokenProvider.GetRequestMetadata should have comment or be unexported (golint)
  • Line 76: warning: comment on exported method TokenProvider.RequireTransportSecurity should be of the form "RequireTransportSecurity ..." (golint)

• istio/security/pkg/stsservice/tokenmanager/google/tokenexchangeplugin.go
  • Line 46: warning: exported const GCPAuthProvider should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported var GCEProvider should have comment or be unexported (golint)
  • Line 111: warning: comment on exported method Plugin.ExchangeToken should be of the form "ExchangeToken ..." (golint)
  • Line 329: warning: exported type Duration should have comment or be unexported (golint)
  • Line 478: warning: comment on exported method Plugin.DumpPluginStatus should be of the form "DumpPluginStatus ..." (golint)

• istio/pilot/pkg/networking/apigen/apigen.go
  • Line 48: warning: exported function NewGenerator should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/instance.go
  • Line 47: warning: exported method Simple.Provider should have comment or be unexported (golint)
  • Line 51: warning: exported method Simple.Cluster should have comment or be unexported (golint)

• istio/pkg/http/get.go
  • Line 27: warning: exported function DoHTTPGetWithTimeout should have comment or be unexported (golint)
  • Line 49: warning: exported function DoHTTPGet should have comment or be unexported (golint)

• istio/pkg/test/csrctrl/controllers/csr_controller.go
  • Line 15: warning: package comment should be of the form "Package csrctrl ..." (golint)
  • Line 48: warning: exported method CertificateSigningRequestSigningReconciler.Reconcile should have comment or be unexported (golint)
  • Line 102: warning: exported method CertificateSigningRequestSigningReconciler.SetupWithManager should have comment or be unexported (golint)
  • Line 115: warning: exported function GetCertApprovalCondition should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/archive/archive.go
  • Line 51: warning: exported function ProxyOutputPath should have comment or be unexported (golint)
  • Line 55: warning: exported function IstiodPath should have comment or be unexported (golint)
  • Line 59: warning: exported function OperatorPath should have comment or be unexported (golint)
  • Line 63: warning: exported function AnalyzePath should have comment or be unexported (golint)
  • Line 67: warning: exported function ClusterInfoPath should have comment or be unexported (golint)

• istio/pkg/bootstrap/platform/platform.go
  • Line 22: warning: exported const KubernetesServiceHost should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/controller.go
  • Line 157: warning: exported method Options.GetSyncInterval should have comment or be unexported (golint)
  • Line 164: warning: comment on exported function DetectEndpointMode should be of the form "DetectEndpointMode ..." (golint)
  • Line 195: warning: exported var EndpointModes should have comment or be unexported (golint)
  • Line 197: warning: exported var EndpointModeNames should have comment or be unexported (golint)
  • Line 423: warning: exported method Controller.Provider should have comment or be unexported (golint)
  • Line 427: warning: exported method Controller.Cluster should have comment or be unexported (golint)
  • Line 431: warning: exported method Controller.MCSServices should have comment or be unexported (golint)
  • Line 499: warning: exported method Controller.Network should have comment or be unexported (golint)
  • Line 518: warning: exported method Controller.Cleanup should have comment or be unexported (golint)
  • Line 1371: warning: exported method Controller.GetProxyWorkloadLabels should have comment or be unexported (golint)

• istio/pilot/pkg/model/authentication.go
  • Line 48: warning: exported const ResourceSeparator should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/xds/v3/model.go
  • Line 27: warning: exported const ClusterType should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: comment on exported const HttpProtocolOptionsType should be of the form "HttpProtocolOptionsType ..." (golint)

• istio/tests/fuzz/kube_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 55: warning: exported function FuzzInmemoryKube should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/schema/validation.go
  • Line 1: warning: package comment should be of the form "Package schema ..." (golint)
  • Line 38: warning: exported function CollectionValidationAnalyzer should have comment or be unexported (golint)

• istio/pkg/test/framework/components/prometheus/prometheus.go
  • Line 26: warning: exported type Instance should have comment or be unexported (golint)
  • Line 50: warning: exported type Config should have comment or be unexported (golint)

• istio/pkg/test/framework/components/zipkin/zipkin.go
  • Line 33: warning: exported type Config should have comment or be unexported (golint)

• istio/cni/pkg/monitoring/monitoring.go
  • Line 29: warning: exported function SetupMonitoring should have comment or be unexported (golint)

• istio/pilot/pkg/security/model/authentication.go
  • Line 65: warning: exported var SDSAdsConfig should have comment or be unexported (golint)

• istio/pilot/pkg/xds/lds.go
  • Line 26: warning: exported type LdsGenerator should have comment or be unexported (golint)
  • Line 66: warning: exported method LdsGenerator.Generate should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/call.go
  • Line 125: warning: exported method CallOptions.DeepCopy should have comment or be unexported (golint)
  • Line 242: warning: exported method ValidatorFunc.Validate should have comment or be unexported (golint)

• istio/security/pkg/server/ca/authenticate/oidc.go
  • Line 30: warning: exported const IDTokenAuthenticatorType should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported type JwtAuthenticator should have comment or be unexported (golint)
  • Line 41: warning: comment on exported function NewJwtAuthenticator should be of the form "NewJwtAuthenticator ..." (golint)
  • Line 71: warning: exported method JwtAuthenticator.AuthenticateRequest should have comment or be unexported (golint)
  • Line 130: warning: exported type JwtPayload should have comment or be unexported (golint)
  • Line 145: warning: exported method JwtAuthenticator.AuthenticatorType should have comment or be unexported (golint)

• istio/operator/pkg/object/objects.go
  • Line 15: warning: package comment should be of the form "Package object ..." (golint)
  • Line 477: warning: exported function ObjectsNotInLists should have comment or be unexported (golint)

• istio/pkg/config/host/names.go
  • Line 62: warning: exported method Names.Contains should have comment or be unexported (golint)

• istio/pkg/network/id.go
  • Line 22: warning: exported method ID.Equals should have comment or be unexported (golint)

• istio/istioctl/pkg/multicluster/env.go
  • Line 30: warning: exported type ConditionFunc should have comment or be unexported (golint)
  • Line 32: warning: exported type Environment should have comment or be unexported (golint)
  • Line 43: warning: exported type KubeEnvironment should have comment or be unexported (golint)
  • Line 50: warning: exported method KubeEnvironment.CreateClient should have comment or be unexported (golint)
  • Line 58: warning: exported method KubeEnvironment.Printf should have comment or be unexported (golint)
  • Line 62: warning: exported method KubeEnvironment.Errorf should have comment or be unexported (golint)
  • Line 66: warning: exported method KubeEnvironment.GetConfig should have comment or be unexported (golint)
  • Line 67: warning: exported method KubeEnvironment.Stdout should have comment or be unexported (golint)
  • Line 68: warning: exported method KubeEnvironment.Stderr should have comment or be unexported (golint)
  • Line 69: warning: exported method KubeEnvironment.ReadFile should have comment or be unexported (golint)
  • Line 70: warning: exported method KubeEnvironment.Poll should have comment or be unexported (golint)
  • Line 78: warning: exported function NewEnvironment should have comment or be unexported (golint)
  • Line 92: warning: exported function NewEnvironmentFromCobra should have comment or be unexported (golint)

• istio/pilot/pkg/security/trustdomain/bundle.go
  • Line 27: warning: exported type Bundle should have comment or be unexported (golint)

• istio/pkg/config/validation/validation.go
  • Line 135: warning: exported type Warning should have comment or be unexported (golint)
  • Line 143: warning: exported type AnalysisAwareError should have comment or be unexported (golint)
  • Line 303: warning: comment on exported function ValidateTrustDomain should be of the form "ValidateTrustDomain ..." (golint)
  • Line 1669: warning: exported function ValidateControlPlaneAuthPolicy should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/diag/level.go
  • Line 31: warning: exported method Level.IsWorseThanOrEqualTo should have comment or be unexported (golint)

• istio/pkg/webhooks/validation/controller/controller.go
  • Line 53: warning: exported type Options should have comment or be unexported (golint)
  • Line 92: warning: exported type Controller should have comment or be unexported (golint)
  • Line 218: warning: exported method Controller.Run should have comment or be unexported (golint)

• istio/security/pkg/server/ca/authenticate/cert_authenticator.go
  • Line 30: warning: exported const ClientCertAuthenticatorType should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported method ClientCertAuthenticator.AuthenticatorType should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/status/ready/probe.go
  • Line 39: warning: exported type Prober should have comment or be unexported (golint)

• istio/pilot/pkg/security/authz/model/model.go
  • Line 33: warning: exported const RBACTCPFilterStatPrefix should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/serviceregistry/serviceentry/servicediscovery.go
  • Line 96: warning: exported type ServiceDiscoveryOption should have comment or be unexported (golint)
  • Line 98: warning: exported function DisableServiceEntryProcessing should have comment or be unexported (golint)
  • Line 104: warning: exported function WithClusterID should have comment or be unexported (golint)
  • Line 110: warning: exported function WithNetworkIDCb should have comment or be unexported (golint)
  • Line 471: warning: exported method ServiceEntryStore.Provider should have comment or be unexported (golint)
  • Line 475: warning: exported method ServiceEntryStore.Cluster should have comment or be unexported (golint)
  • Line 811: warning: exported method ServiceEntryStore.GetProxyWorkloadLabels should have comment or be unexported (golint)
  • Line 839: warning: exported method ServiceEntryStore.NetworkGateways should have comment or be unexported (golint)
  • Line 844: warning: exported method ServiceEntryStore.MCSServices should have comment or be unexported (golint)
  • Line 977: warning: comment on exported method ServiceEntryStore.SetRefreshIndexes should be of the form "SetRefreshIndexes ..." (golint)

• istio/tests/fuzz/operator_translate_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 22: warning: exported function FuzzTranslateFromValueToSpec should have comment or be unexported (golint)

• istio/cni/pkg/log/uds.go
  • Line 32: warning: exported type UDSLogger should have comment or be unexported (golint)
  • Line 42: warning: exported function NewUDSLogger should have comment or be unexported (golint)
  • Line 53: warning: comment on exported method UDSLogger.StartUDSLogServer should be of the form "StartUDSLogServer ..." (golint)

• istio/pkg/test/framework/suite.go
  • Line 402: warning: exported type SuiteOutcome should have comment or be unexported (golint)

• istio/pkg/kube/inject/template.go
  • Line 39: warning: exported function CreateInjectionFuncmap should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/gateway/deploymentcontroller.go
  • Line 123: warning: exported method DeploymentController.Run should have comment or be unexported (golint)

• istio/pkg/dns/client/dns.go
  • Line 84: warning: exported function NewLocalDNSServer should have comment or be unexported (golint)
  • Line 183: warning: exported method LocalDNSServer.UpdateLookupTable should have comment or be unexported (golint)
  • Line 298: warning: exported method LocalDNSServer.NameTable should have comment or be unexported (golint)
  • Line 368: warning: exported method LocalDNSServer.Close should have comment or be unexported (golint)

• istio/pkg/test/csrctrl/controllers/start_csrctrl.go
  • Line 49: warning: exported function RunCSRController should have comment or be unexported (golint)

• istio/istioctl/pkg/verifier/verifier.go
  • Line 92: warning: exported method StatusVerifier.Colorize should have comment or be unexported (golint)
  • Line 469: warning: comment on exported function AllOperatorsInCluster should be of the form "AllOperatorsInCluster ..." (golint)

• istio/tools/docker-builder/main.go
  • Line 97: warning: exported function RunBake should have comment or be unexported (golint)
  • Line 151: warning: exported function CopyFile should have comment or be unexported (golint)
  • Line 318: warning: exported function StandardEnv should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/log/command.go
  • Line 17: warning: exported type Command should have comment or be unexported (golint)
  • Line 24: warning: exported var JumpInbound should have comment or be unexported (golint)
  • Line 34: warning: exported var IDToCommand should have comment or be unexported (golint)

• istio/pkg/config/resource/stringmap.go
  • Line 43: warning: comment on exported method StringMap.Delete should be of the form "Delete ..." (golint)

• istio/pkg/test/env/istio.go
  • Line 119: warning: exported function CheckFileExists should have comment or be unexported (golint)
  • Line 126: warning: exported function ReadProxySHA should have comment or be unexported (golint)

• istio/tests/fuzz/bootstrap_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 28: warning: exported function FuzzNewBootstrapServer should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/validation/vld_unix.go
  • Line 32: warning: comment on exported function GetOriginalDestination should be of the form "GetOriginalDestination ..." (golint)

• istio/pilot/pkg/networking/plugin/authz/authorization.go
  • Line 31: warning: exported type ActionType should have comment or be unexported (golint)
  • Line 130: warning: exported method Plugin.InboundMTLSConfiguration should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/listener_builder.go
  • Line 60: warning: comment on exported type ListenerBuilder should be of the form "ListenerBuilder ..." (with optional leading article) (golint)
  • Line 335: warning: exported function NewListenerBuilder should have comment or be unexported (golint)

• istio/pkg/test/framework/components/namespace/static.go
  • Line 25: warning: exported method Static.Name should have comment or be unexported (golint)
  • Line 29: warning: exported method Static.Prefix should have comment or be unexported (golint)
  • Line 33: warning: exported method Static.Labels should have comment or be unexported (golint)
  • Line 37: warning: exported method Static.SetLabel should have comment or be unexported (golint)
  • Line 41: warning: exported method Static.RemoveLabel should have comment or be unexported (golint)
  • Line 45: warning: exported method Static.UnmarshalJSON should have comment or be unexported (golint)

• istio/pkg/config/crd/validator.go
  • Line 53: warning: exported method Validator.ValidateCustomResourceYAML should have comment or be unexported (golint)
  • Line 67: warning: exported method Validator.ValidateCustomResource should have comment or be unexported (golint)
  • Line 99: warning: exported function NewValidatorFromFiles should have comment or be unexported (golint)
  • Line 161: warning: exported function NewValidatorFromCRDs should have comment or be unexported (golint)
  • Line 202: warning: exported function NewIstioValidator should have comment or be unexported (golint)

• istio/pkg/config/xds/filter_types.go
  • Line 15: warning: package comment should be of the form "Package xds ..." (golint)

• istio/pkg/test/echo/server/forwarder/instance.go
  • Line 184: warning: exported method Instance.Close should have comment or be unexported (golint)

• istio/operator/cmd/mesh/root.go
  • Line 41: warning: exported const ChartsDeprecatedStr should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/controller/workloadentry/workloadentry_controller.go
  • Line 108: warning: exported type HealthEvent should have comment or be unexported (golint)
  • Line 115: warning: exported type HealthCondition should have comment or be unexported (golint)
  • Line 128: warning: exported type Controller should have comment or be unexported (golint)
  • Line 159: warning: exported type HealthStatus should have comment or be unexported (golint)
  • Line 183: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 257: warning: exported method Controller.RegisterWorkload should have comment or be unexported (golint)
  • Line 322: warning: exported method Controller.QueueUnregisterWorkload should have comment or be unexported (golint)

• istio/pilot/pkg/networking/networking.go
  • Line 94: warning: exported type TransportProtocol should have comment or be unexported (golint)
  • Line 113: warning: exported method TransportProtocol.ToEnvoySocketProtocol should have comment or be unexported (golint)
  • Line 161: warning: exported const NoTunnelTypeName should have comment (or a comment on this block) or be unexported (golint)
  • Line 166: warning: exported type TunnelType should have comment or be unexported (golint)
  • Line 167: warning: exported type TunnelAbility should have comment or be unexported (golint)
  • Line 171: warning: comment on exported const NoTunnel should be of the form "NoTunnel ..." (golint)
  • Line 173: warning: comment on exported const H2Tunnel should be of the form "H2Tunnel ..." (golint)
  • Line 177: warning: exported function MakeTunnelAbility should have comment or be unexported (golint)
  • Line 185: warning: exported method TunnelType.ToString should have comment or be unexported (golint)
  • Line 194: warning: exported method TunnelAbility.SupportH2Tunnel should have comment or be unexported (golint)
  • Line 202: warning: exported const ListenerClassUndefined should have comment (or a comment on this block) or be unexported (golint)
  • Line 208: warning: exported function BuildCatchAllVirtualHost should have comment or be unexported (golint)
  • Line 266: warning: exported type TelemetryMode should have comment or be unexported (golint)
  • Line 269: warning: exported const TelemetryModeServer should have comment (or a comment on this block) or be unexported (golint)
  • Line 273: warning: exported function TelemetryModeForClass should have comment or be unexported (golint)

• istio/operator/pkg/apis/istio/v1alpha1/deepcopy.go
  • Line 58: warning: comment on exported method IstioOperator.GetObjectKind should be of the form "GetObjectKind ..." (golint)

• istio/pilot/pkg/xds/eventhandler.go
  • Line 22: warning: exported var AllEventTypes should have comment or be unexported (golint)
  • Line 32: warning: comment on exported type DistributionStatusCache should be of the form "DistributionStatusCache ..." (with optional leading article) (golint)

• istio/pkg/kube/client.go
  • Line 298: warning: exported function NewFakeClientWithVersion should have comment or be unexported (golint)

• istio/cni/cmd/istio-cni-taint/main.go
  • Line 41: warning: exported type ControllerOptions should have comment or be unexported (golint)
  • Line 47: warning: exported const LeassLockName should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/route/route.go
  • Line 1285: warning: exported function GetConsistentHashForVirtualService should have comment or be unexported (golint)

• istio/pilot/pkg/model/proxy_config.go
  • Line 76: warning: exported function GetProxyConfigs should have comment or be unexported (golint)

• istio/pkg/test/echo/common/metrics.go
  • Line 21: warning: exported type EchoMetrics should have comment or be unexported (golint)
  • Line 28: warning: exported var PortLabel should have comment or be unexported (golint)

• istio/pkg/config/validation/extensionprovider.go
  • Line 62: warning: exported function ValidateExtensionProviderEnvoyExtAuthzHTTP should have comment or be unexported (golint)
  • Line 86: warning: exported function ValidateExtensionProviderEnvoyExtAuthzGRPC should have comment or be unexported (golint)

• istio/security/pkg/pki/ra/common.go
  • Line 1: warning: package comment should be of the form "Package ra ..." (golint)

• istio/istioctl/pkg/multixds/gather.go
  • Line 42: warning: exported type ControlPlaneNotFoundError should have comment or be unexported (golint)
  • Line 171: warning: comment on exported function MultiRequestAndProcessXds should be of the form "MultiRequestAndProcessXds ..." (golint)

• istio/pilot/pkg/serviceregistry/kube/conversion.go
  • Line 56: warning: exported function ConvertService should have comment or be unexported (golint)
  • Line 158: warning: exported function ExternalNameServiceInstances should have comment or be unexported (golint)

• istio/pilot/pkg/model/context.go
  • Line 97: warning: exported method Environment.Mesh should have comment or be unexported (golint)
  • Line 120: warning: exported method Environment.AddMeshHandler should have comment or be unexported (golint)
  • Line 126: warning: exported method Environment.Networks should have comment or be unexported (golint)
  • Line 133: warning: exported method Environment.AddNetworksHandler should have comment or be unexported (golint)
  • Line 139: warning: exported method Environment.AddMetric should have comment or be unexported (golint)
  • Line 145: warning: exported method Environment.Version should have comment or be unexported (golint)
  • Line 163: warning: exported method Environment.ClusterLocal should have comment or be unexported (golint)
  • Line 167: warning: exported method Environment.GetLedger should have comment or be unexported (golint)
  • Line 171: warning: exported method Environment.SetLedger should have comment or be unexported (golint)
  • Line 181: warning: exported function AnyToUnnamedResources should have comment or be unexported (golint)
  • Line 189: warning: exported function ResourcesToAny should have comment or be unexported (golint)
  • Line 208: warning: exported var DefaultXdsLogDetails should have comment or be unexported (golint)
  • Line 365: warning: exported method StringList.MarshalJSON should have comment or be unexported (golint)
  • Line 372: warning: exported method StringList.UnmarshalJSON should have comment or be unexported (golint)
  • Line 400: warning: exported method PodPortList.MarshalJSON should have comment or be unexported (golint)
  • Line 414: warning: exported method PodPortList.UnmarshalJSON should have comment or be unexported (golint)
  • Line 430: warning: exported method StringBool.MarshalJSON should have comment or be unexported (golint)
  • Line 434: warning: exported method StringBool.UnmarshalJSON should have comment or be unexported (golint)
  • Line 447: warning: comment on exported type NodeMetaProxyConfig should be of the form "NodeMetaProxyConfig ..." (with optional leading article) (golint)
  • Line 451: warning: exported method NodeMetaProxyConfig.MarshalJSON should have comment or be unexported (golint)
  • Line 460: warning: exported method NodeMetaProxyConfig.UnmarshalJSON should have comment or be unexported (golint)
  • Line 676: warning: exported method BootstrapNodeMetadata.UnmarshalJSON should have comment or be unexported (golint)
  • Line 717: warning: exported var MaxIstioVersion should have comment or be unexported (golint)
  • Line 765: warning: exported var NodeTypes should have comment or be unexported (golint)
  • Line 813: warning: comment on exported method Proxy.BuildCatchAllVirtualHost should be of the form "BuildCatchAllVirtualHost ..." (golint)
  • Line 842: warning: exported method Proxy.SetServiceInstances should have comment or be unexported (golint)
  • Line 1089: warning: exported method Proxy.IsVM should have comment or be unexported (golint)
  • Line 1094: warning: exported method Proxy.IsProxylessGrpc should have comment or be unexported (golint)
  • Line 1098: warning: exported type GatewayController should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/httproute.go
  • Line 217: warning: exported function BuildSidecarOutboundVirtualHosts should have comment or be unexported (golint)

• istio/operator/pkg/helm/urlfetcher.go
  • Line 120: warning: comment on exported function URLToDirname should be of the form "URLToDirname ..." (golint)

• istio/galley/pkg/config/source/kube/interfaces.go
  • Line 94: warning: exported function NewInterfacesFromClient should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/config/config.go
  • Line 75: warning: exported type SelectionSpecs should have comment or be unexported (golint)
  • Line 212: warning: exported method SelectionSpec.UnmarshalJSON should have comment or be unexported (golint)
  • Line 242: warning: exported method SelectionSpec.MarshalJSON should have comment or be unexported (golint)
  • Line 260: warning: exported type Duration should have comment or be unexported (golint)
  • Line 262: warning: exported method Duration.MarshalJSON should have comment or be unexported (golint)
  • Line 266: warning: exported method Duration.UnmarshalJSON should have comment or be unexported (golint)

• istio/pkg/config/security/security.go
  • Line 93: warning: exported function CheckEmptyValues should have comment or be unexported (golint)
  • Line 102: warning: exported function ValidateAttribute should have comment or be unexported (golint)
  • Line 152: warning: exported function ValidateIPs should have comment or be unexported (golint)
  • Line 168: warning: exported function ValidatePorts should have comment or be unexported (golint)
  • Line 207: warning: exported function IsValidCipherSuite should have comment or be unexported (golint)

• istio/pilot/pkg/xds/monitoring.go
  • Line 1: warning: package comment should be of the form "Package xds ..." (golint)

• istio/pkg/istio-agent/xds_proxy_delta.go
  • Line 43: warning: comment on exported method XdsProxy.DeltaAggregatedResources should be of the form "DeltaAggregatedResources ..." (golint)
  • Line 122: warning: exported method XdsProxy.HandleDeltaUpstream should have comment or be unexported (golint)
  • Line 298: warning: exported method XdsProxy.PersistDeltaRequest should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/k8sresourcelock/leaselock.go
  • Line 31: warning: exported type LeaseLock should have comment or be unexported (golint)
  • Line 109: warning: exported function LeaseSpecToLeaderElectionRecord should have comment or be unexported (golint)
  • Line 129: warning: exported function LeaderElectionRecordToLeaseSpec should have comment or be unexported (golint)

• istio/cni/pkg/plugin/plugin.go
  • Line 15: warning: package comment should be of the form "Package plugin ..." (golint)
  • Line 47: warning: exported const ISTIOINIT should have comment or be unexported (golint)
  • Line 136: warning: exported function GetLoggingOptions should have comment or be unexported (golint)
  • Line 303: warning: exported function CmdCheck should have comment or be unexported (golint)
  • Line 307: warning: exported function CmdDelete should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/authz/authorizationpolicies.go
  • Line 42: warning: exported method AuthorizationPoliciesAnalyzer.Metadata should have comment or be unexported (golint)
  • Line 55: warning: exported method AuthorizationPoliciesAnalyzer.Analyze should have comment or be unexported (golint)

• istio/pkg/errdict/errdict.go
  • Line 24: warning: exported const LikelyCauseFirstPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 56: warning: exported var OperatorFailedToGetObjectFromAPIServer should have comment or be unexported (golint)

• istio/pilot/pkg/model/config.go
  • Line 59: warning: exported method ConfigKey.HashCode should have comment or be unexported (golint)
  • Line 169: warning: exported type EventHandler should have comment or be unexported (golint)

• istio/cni/pkg/repair/repaircontroller.go
  • Line 30: warning: exported type Controller should have comment or be unexported (golint)
  • Line 38: warning: exported function NewRepairController should have comment or be unexported (golint)
  • Line 82: warning: exported method Controller.Run should have comment or be unexported (golint)

• istio/operator/pkg/version/version.go
  • Line 84: warning: comment on exported function TagToVersionStringGrace should be of the form "TagToVersionStringGrace ..." (golint)

• istio/pkg/test/kube/dump.go
  • Line 61: warning: exported function DumpDeployments should have comment or be unexported (golint)
  • Line 83: warning: exported function DumpWebhooks should have comment or be unexported (golint)
  • Line 159: warning: exported function DumpCoreDumps should have comment or be unexported (golint)
  • Line 425: warning: exported function DumpDebug should have comment or be unexported (golint)
  • Line 455: warning: exported function DumpNdsz should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/util/config.go
  • Line 64: warning: exported function GetInjectorConfigMapName should have comment or be unexported (golint)

• istio/pilot/pkg/util/sets/string.go
  • Line 19: warning: exported type Set should have comment or be unexported (golint)

• istio/pkg/revisions/default_watcher.go
  • Line 62: warning: exported function NewDefaultWatcher should have comment or be unexported (golint)

• istio/pkg/config/protocol/instance.go
  • Line 153: warning: exported method Instance.IsUnsupported should have comment or be unexported (golint)

• istio/pkg/config/mesh/kubemesh/watcher.go
  • Line 73: warning: exported function AddUserMeshConfig should have comment or be unexported (golint)
  • Line 98: warning: exported function ReadConfigMap should have comment or be unexported (golint)
  • Line 119: warning: exported function ReadNetworksConfigMap should have comment or be unexported (golint)

• istio/pilot/pkg/xds/nds.go
  • Line 26: warning: comment on exported type NdsGenerator should be of the form "NdsGenerator ..." (with optional leading article) (golint)
  • Line 70: warning: exported method NdsGenerator.Generate should have comment or be unexported (golint)

• istio/operator/pkg/util/clog/clog.go
  • Line 63: warning: exported method ConsoleLogger.LogAndPrint should have comment or be unexported (golint)
  • Line 72: warning: exported method ConsoleLogger.LogAndError should have comment or be unexported (golint)
  • Line 81: warning: exported method ConsoleLogger.LogAndFatal should have comment or be unexported (golint)
  • Line 86: warning: exported method ConsoleLogger.LogAndPrintf should have comment or be unexported (golint)
  • Line 92: warning: exported method ConsoleLogger.LogAndErrorf should have comment or be unexported (golint)
  • Line 98: warning: exported method ConsoleLogger.LogAndFatalf should have comment or be unexported (golint)
  • Line 103: warning: exported method ConsoleLogger.Print should have comment or be unexported (golint)
  • Line 107: warning: exported method ConsoleLogger.PrintErr should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/crdclient/client.go
  • Line 105: warning: exported function New should have comment or be unexported (golint)
  • Line 134: warning: exported function NewForSchemas should have comment or be unexported (golint)
  • Line 187: warning: exported method Client.RegisterEventHandler should have comment or be unexported (golint)
  • Line 191: warning: exported method Client.SetWatchErrorHandler should have comment or be unexported (golint)
  • Line 242: warning: exported method Client.HasSynced should have comment or be unexported (golint)
  • Line 329: warning: exported method Client.UpdateStatus should have comment or be unexported (golint)
  • Line 431: warning: exported function TranslateObject should have comment or be unexported (golint)

• istio/pilot/tools/debug/pilot_cli.go
  • Line 80: warning: exported const LocalPortStart should have comment (or a comment on this block) or be unexported (golint)
  • Line 104: warning: exported function NewPodInfo should have comment or be unexported (golint)

• istio/pilot/pkg/networking/plugin/authn/util.go
  • Line 23: warning: exported function TrustDomainsForValidation should have comment or be unexported (golint)

• istio/pkg/config/mesh/watcher_test_utils.go
  • Line 24: warning: comment on exported type TestWatcher should be of the form "TestWatcher ..." (with optional leading article) (golint)
  • Line 30: warning: exported function NewTestWatcher should have comment or be unexported (golint)
  • Line 41: warning: comment on exported method TestWatcher.Update should be of the form "Update ..." (golint)

• istio/pkg/kube/inject/initializer.go
  • Line 28: warning: exported var IgnoredNamespaces should have comment or be unexported (golint)

• istio/pkg/istio-agent/agent.go
  • Line 90: warning: exported const MetadataClientCertKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 398: warning: comment on exported method Agent.Run should be of the form "Run ..." (golint)
  • Line 514: warning: exported method Agent.Check should have comment or be unexported (golint)
  • Line 524: warning: exported method Agent.GetDNSTable should have comment or be unexported (golint)
  • Line 531: warning: exported method Agent.Close should have comment or be unexported (golint)
  • Line 599: warning: comment on exported method Agent.FindRootCAForCA should be of the form "FindRootCAForCA ..." (golint)

• istio/security/pkg/nodeagent/util/util.go
  • Line 72: warning: comment on exported function OutputKeyCertToDir should be of the form "OutputKeyCertToDir ..." (golint)

• istio/cni/pkg/install/install.go
  • Line 33: warning: exported type Installer should have comment or be unexported (golint)

• istio/operator/pkg/tpath/struct.go
  • Line 15: warning: package comment should be of the form "Package tpath ..." (golint)

• istio/pkg/config/schema/collection/schemas.go
  • Line 247: warning: exported method Schemas.Equal should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/cluster_builder.go
  • Line 1164: warning: comment on exported method ClusterBuilder.IsHttp2Cluster should be of the form "IsHttp2Cluster ..." (golint)

• istio/pilot/cmd/pilot-agent/metrics/metrics.go
  • Line 41: warning: exported var EnvoyScrapeErrors should have comment or be unexported (golint)
  • Line 53: warning: exported var ScrapeTypeEnvoy should have comment or be unexported (golint)
  • Line 60: warning: exported function RecordStartupTime should have comment or be unexported (golint)

• istio/pilot/pkg/networking/util/util.go
  • Line 67: warning: comment on exported const InboundPassthroughClusterIpv4 should be of the form "InboundPassthroughClusterIpv4 ..." (golint)
  • Line 69: warning: exported const InboundPassthroughClusterIpv6 should have comment (or a comment on this block) or be unexported (golint)
  • Line 101: warning: comment on exported const AltSvcHeader should be of the form "AltSvcHeader ..." (golint)
  • Line 146: warning: exported function ListContains should have comment or be unexported (golint)
  • Line 193: warning: exported function BuildNetworkAddress should have comment or be unexported (golint)
  • Line 272: warning: exported function IsProtocolSniffingEnabledForPort should have comment or be unexported (golint)
  • Line 276: warning: exported function IsProtocolSniffingEnabledForInboundPort should have comment or be unexported (golint)
  • Line 280: warning: exported function IsProtocolSniffingEnabledForOutboundPort should have comment or be unexported (golint)
  • Line 323: warning: exported function LocalityMatch should have comment or be unexported (golint)
  • Line 335: warning: exported function LbPriority should have comment or be unexported (golint)
  • Line 348: warning: comment on exported function CloneClusterLoadAssignment should be of the form "CloneClusterLoadAssignment ..." (golint)
  • Line 372: warning: comment on exported function CloneLocalityLbEndpoint should be of the form "CloneLocalityLbEndpoint ..." (golint)
  • Line 589: warning: exported function StringToExactMatch should have comment or be unexported (golint)
  • Line 602: warning: exported function StringToPrefixMatch should have comment or be unexported (golint)
  • Line 615: warning: exported function StringSliceEqual should have comment or be unexported (golint)
  • Line 629: warning: exported function UInt32SliceEqual should have comment or be unexported (golint)
  • Line 643: warning: exported function CidrRangeSliceEqual should have comment or be unexported (golint)
  • Line 673: warning: comment on exported function MeshConfigToEnvoyForwardClientCertDetails should be of the form "MeshConfigToEnvoyForwardClientCertDetails ..." (golint)
  • Line 695: warning: comment on exported function IPv6Compliant should be of the form "IPv6Compliant ..." (golint)

• istio/security/pkg/nodeagent/plugin/providers/google/stsclient/stsclient.go
  • Line 44: warning: exported const Scope should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/config/constants/constants.go
  • Line 27: warning: comment on exported const DefaultCertChain should be of the form "DefaultCertChain ..." (golint)
  • Line 33: warning: comment on exported const DefaultKey should be of the form "DefaultKey ..." (golint)
  • Line 57: warning: exported const KubernetesGatewayName should have comment (or a comment on this block) or be unexported (golint)
  • Line 88: warning: comment on exported const CACertNamespaceConfigMapDataName should be of the form "CACertNamespaceConfigMapDataName ..." (golint)
  • Line 122: warning: comment on exported const AlwaysPushLabel should be of the form "AlwaysPushLabel ..." (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/multicluster.go
  • Line 116: warning: exported method Multicluster.Run should have comment or be unexported (golint)
  • Line 145: warning: comment on exported method Multicluster.ClusterAdded should be of the form "ClusterAdded ..." (golint)
  • Line 282: warning: exported method Multicluster.ClusterUpdated should have comment or be unexported (golint)
  • Line 289: warning: comment on exported method Multicluster.ClusterDeleted should be of the form "ClusterDeleted ..." (golint)

• istio/pilot/pkg/xds/rds.go
  • Line 23: warning: exported type RdsGenerator should have comment or be unexported (golint)
  • Line 59: warning: exported method RdsGenerator.Generate should have comment or be unexported (golint)

• istio/pkg/util/shellescape/quote.go
  • Line 24: warning: exported function Quote should have comment or be unexported (golint)

• istio/cni/pkg/install/server.go
  • Line 36: warning: comment on exported function SetReady should be of the form "SetReady ..." (golint)
  • Line 42: warning: comment on exported function SetNotReady should be of the form "SetNotReady ..." (golint)

• istio/pilot/pkg/status/reporter.go
  • Line 36: warning: exported function GenStatusReporterMapKey should have comment or be unexported (golint)
  • Line 41: warning: exported function NewIstioContext should have comment or be unexported (golint)
  • Line 57: warning: exported type Reporter should have comment or be unexported (golint)
  • Line 226: warning: exported method Reporter.DeleteInProgressResource should have comment or be unexported (golint)
  • Line 275: warning: exported method Reporter.QueryLastNonce should have comment or be unexported (golint)
  • Line 282: warning: comment on exported method Reporter.RegisterEvent should be of the form "RegisterEvent ..." (golint)
  • Line 356: warning: exported method Reporter.SetController should have comment or be unexported (golint)

• istio/istioctl/cmd/sysexits.go
  • Line 39: warning: exported function GetExitCode should have comment or be unexported (golint)

• istio/pilot/pkg/xds/adstest.go
  • Line 33: warning: exported function NewAdsTest should have comment or be unexported (golint)
  • Line 40: warning: exported function NewSdsTest should have comment or be unexported (golint)
  • Line 47: warning: exported function NewXdsTest should have comment or be unexported (golint)
  • Line 72: warning: exported type AdsTest should have comment or be unexported (golint)
  • Line 88: warning: exported method AdsTest.Cleanup should have comment or be unexported (golint)
  • Line 192: warning: exported method AdsTest.Request should have comment or be unexported (golint)
  • Line 212: warning: comment on exported method AdsTest.RequestResponseNack should be of the form "RequestResponseNack ..." (golint)
  • Line 226: warning: exported method AdsTest.WithID should have comment or be unexported (golint)
  • Line 231: warning: exported method AdsTest.WithType should have comment or be unexported (golint)
  • Line 236: warning: exported method AdsTest.WithMetadata should have comment or be unexported (golint)
  • Line 241: warning: exported method AdsTest.WithTimeout should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/filter/informer.go
  • Line 21: warning: exported type FilteredSharedIndexInformer should have comment or be unexported (golint)

• istio/pkg/config/xds/deprecated.go
  • Line 54: warning: exported var ReverseDeprecatedFilterNames should have comment or be unexported (golint)

• istio/security/pkg/credentialfetcher/fetcher.go
  • Line 25: warning: exported function NewCredFetcher should have comment or be unexported (golint)

• istio/operator/pkg/compare/compare.go
  • Line 223: warning: exported function ManifestDiff should have comment or be unexported (golint)
  • Line 237: warning: comment on exported function ManifestDiffWithRenameSelectIgnore should be of the form "ManifestDiffWithRenameSelectIgnore ..." (golint)

• istio/pkg/config/schema/fuzz/fuzz.go
  • Line 43: warning: exported type InstallFunc should have comment or be unexported (golint)
  • Line 45: warning: exported var FuzzIters should have comment or be unexported (golint)
  • Line 47: warning: exported function RoundTrip should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function Fuzz should be of the form "Fuzz ..." (golint)

• istio/pilot/pkg/model/controller.go
  • Line 55: warning: exported method ControllerHandlers.AppendServiceHandler should have comment or be unexported (golint)
  • Line 65: warning: exported method ControllerHandlers.AppendWorkloadHandler should have comment or be unexported (golint)
  • Line 75: warning: exported method ControllerHandlers.GetServiceHandlers should have comment or be unexported (golint)
  • Line 82: warning: exported method ControllerHandlers.GetWorkloadHandlers should have comment or be unexported (golint)
  • Line 89: warning: exported method ControllerHandlers.NotifyServiceHandlers should have comment or be unexported (golint)
  • Line 95: warning: exported method ControllerHandlers.NotifyWorkloadHandlers should have comment or be unexported (golint)

• istio/security/pkg/pki/ca/ca.go
  • Line 63: warning: exported type CertOpts should have comment or be unexported (golint)
  • Line 308: warning: exported method IstioCA.Run should have comment or be unexported (golint)

• istio/tests/fuzz/v1alpha3_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 34: warning: exported type NopTester should have comment or be unexported (golint)
  • Line 36: warning: exported method NopTester.Fail should have comment or be unexported (golint)
  • Line 38: warning: exported method NopTester.FailNow should have comment or be unexported (golint)
  • Line 40: warning: exported method NopTester.Fatal should have comment or be unexported (golint)
  • Line 42: warning: exported method NopTester.Fatalf should have comment or be unexported (golint)
  • Line 44: warning: exported method NopTester.Log should have comment or be unexported (golint)
  • Line 46: warning: exported method NopTester.Logf should have comment or be unexported (golint)
  • Line 48: warning: exported method NopTester.TempDir should have comment or be unexported (golint)
  • Line 53: warning: exported method NopTester.Helper should have comment or be unexported (golint)
  • Line 55: warning: exported method NopTester.Cleanup should have comment or be unexported (golint)
  • Line 59: warning: exported function ValidateTestOptions should have comment or be unexported (golint)
  • Line 78: warning: exported function FuzzValidateClusters should have comment or be unexported (golint)

• istio/istioctl/pkg/multicluster/cluster.go
  • Line 40: warning: exported const IstioEastWestGatewayServiceName should have comment (or a comment on this block) or be unexported (golint)

• istio/operator/pkg/util/httpserver/httpserver.go
  • Line 53: warning: exported method Server.MoveFiles should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/common/config.go
  • Line 35: warning: exported function FillInDefaults should have comment or be unexported (golint)

• istio/pkg/webhooks/util/util.go
  • Line 26: warning: exported type ConfigError should have comment or be unexported (golint)
  • Line 35: warning: exported method ConfigError.Reason should have comment or be unexported (golint)
  • Line 39: warning: exported function LoadCABundle should have comment or be unexported (golint)
  • Line 48: warning: exported function VerifyCABundle should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/cache/monitoring.go
  • Line 19: warning: exported var RequestType should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/injection/injection.go
  • Line 158: warning: comment on exported function GetEnableNamespacesByDefaultFromInjectedConfigMap should be of the form "GetEnableNamespacesByDefaultFromInjectedConfigMap ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/virtualservice/jwtclaimroute.go
  • Line 35: warning: exported type JWTClaimRouteAnalyzer should have comment or be unexported (golint)

• istio/pkg/test/csrctrl/signer/signer.go
  • Line 31: warning: exported type Signer should have comment or be unexported (golint)
  • Line 36: warning: exported function NewSigner should have comment or be unexported (golint)
  • Line 49: warning: exported method Signer.Sign should have comment or be unexported (golint)

• istio/pkg/test/framework/components/istio/config.go
  • Line 67: warning: comment on exported const IntegrationTestExternalIstiodRemoteGatewaysIOP should be of the form "IntegrationTestExternalIstiodRemoteGatewaysIOP ..." (golint)
  • Line 195: warning: exported method Config.OverridesYAML should have comment or be unexported (golint)
  • Line 208: warning: exported method Config.IstioOperatorConfigYAML should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/caclient/providers/google-cas/mock/ca_mock.go
  • Line 38: warning: exported type ContextDialer should have comment or be unexported (golint)
  • Line 40: warning: exported function ContextDialerCreate should have comment or be unexported (golint)
  • Line 47: warning: exported function BufDialer should have comment or be unexported (golint)
  • Line 118: warning: exported method CASService.FetchCaCerts should have comment or be unexported (golint)

• istio/cni/pkg/util/util.go
  • Line 28: warning: comment on exported function CreateFileWatcher should be of the form "CreateFileWatcher ..." (golint)
  • Line 72: warning: comment on exported function WaitForFileMod should be of the form "WaitForFileMod ..." (golint)
  • Line 84: warning: comment on exported function ReadCNIConfigMap should be of the form "ReadCNIConfigMap ..." (golint)
  • Line 99: warning: comment on exported function GetPlugins should be of the form "GetPlugins ..." (golint)
  • Line 109: warning: comment on exported function GetPlugin should be of the form "GetPlugin ..." (golint)
  • Line 119: warning: comment on exported function MarshalCNIConfig should be of the form "MarshalCNIConfig ..." (golint)

• istio/pilot/pkg/config/kube/gateway/conditions.go
  • Line 105: warning: exported type ConfigErrorReason should have comment or be unexported (golint)

• istio/pkg/envoy/proxy.go
  • Line 37: warning: comment on exported type ProxyConfig should be of the form "ProxyConfig ..." (with optional leading article) (golint)

• istio/pilot/pkg/xds/authentication.go
  • Line 30: warning: exported var AuthPlaintext should have comment or be unexported (golint)

• istio/pilot/pkg/xds/fake.go
  • Line 61: warning: exported type FakeOptions should have comment or be unexported (golint)
  • Line 104: warning: exported type FakeDiscoveryServer should have comment or be unexported (golint)
  • Line 115: warning: exported function NewFakeDiscoveryServer should have comment or be unexported (golint)
  • Line 343: warning: exported method FakeDiscoveryServer.KubeClient should have comment or be unexported (golint)
  • Line 347: warning: exported method FakeDiscoveryServer.PushContext should have comment or be unexported (golint)
  • Line 425: warning: exported method FakeDiscoveryServer.Endpoints should have comment or be unexported (golint)
  • Line 481: warning: exported type FakeXdsEvent should have comment or be unexported (golint)
  • Line 489: warning: exported type FakeXdsUpdater should have comment or be unexported (golint)
  • Line 497: warning: exported method FakeXdsUpdater.EDSUpdate should have comment or be unexported (golint)
  • Line 504: warning: exported method FakeXdsUpdater.EDSCacheUpdate should have comment or be unexported (golint)
  • Line 511: warning: exported method FakeXdsUpdater.ConfigUpdate should have comment or be unexported (golint)
  • Line 518: warning: exported method FakeXdsUpdater.ProxyUpdate should have comment or be unexported (golint)
  • Line 524: warning: exported method FakeXdsUpdater.SvcUpdate should have comment or be unexported (golint)
  • Line 531: warning: exported method FakeXdsUpdater.WaitOrFail should have comment or be unexported (golint)
  • Line 540: warning: exported method FakeXdsUpdater.Wait should have comment or be unexported (golint)

• istio/pkg/test/framework/components/environment/kube/fake.go
  • Line 34: warning: exported method FakeEnvironment.ID should have comment or be unexported (golint)
  • Line 38: warning: exported method FakeEnvironment.IsMultinetwork should have comment or be unexported (golint)
  • Line 42: warning: exported method FakeEnvironment.EnvironmentName should have comment or be unexported (golint)
  • Line 49: warning: exported method FakeEnvironment.AllClusters should have comment or be unexported (golint)
  • Line 61: warning: exported method FakeEnvironment.Clusters should have comment or be unexported (golint)

• istio/operator/cmd/mesh/upgrade.go
  • Line 531: warning: exported method Client.PodsForSelector should have comment or be unexported (golint)
  • Line 561: warning: exported method Client.ConfigMapForSelector should have comment or be unexported (golint)
  • Line 570: warning: exported method Client.CheckUnsupportedAlphaSecurityCRD should have comment or be unexported (golint)

• istio/operator/pkg/name/name.go
  • Line 88: warning: comment on exported const InstalledSpecCRPrefix should be of the form "InstalledSpecCRPrefix ..." (golint)
  • Line 97: warning: comment on exported const IstioBaseComponentName should be of the form "IstioBaseComponentName ..." (golint)
  • Line 100: warning: exported const PilotComponentName should have comment (or a comment on this block) or be unexported (golint)
  • Line 104: warning: comment on exported const IstiodRemoteComponentName should be of the form "IstiodRemoteComponentName ..." (golint)
  • Line 107: warning: comment on exported const IngressComponentName should be of the form "IngressComponentName ..." (golint)
  • Line 111: warning: comment on exported const IstioOperatorComponentName should be of the form "IstioOperatorComponentName ..." (golint)
  • Line 122: warning: exported var AllCoreComponentNames should have comment or be unexported (golint)

• istio/pilot/pkg/model/gateway.go
  • Line 116: warning: exported function RecordRejectedConfig should have comment or be unexported (golint)
  • Line 391: warning: exported function GetSNIHostsForServer should have comment or be unexported (golint)
  • Line 518: warning: exported type GatewayPortMap should have comment or be unexported (golint)

• istio/pilot/pkg/model/xds_cache.go
  • Line 119: warning: exported type CacheToken should have comment or be unexported (golint)
  • Line 344: warning: exported method DisabledCache.Add should have comment or be unexported (golint)
  • Line 346: warning: exported method DisabledCache.Get should have comment or be unexported (golint)
  • Line 350: warning: exported method DisabledCache.Clear should have comment or be unexported (golint)
  • Line 352: warning: exported method DisabledCache.ClearAll should have comment or be unexported (golint)
  • Line 354: warning: exported method DisabledCache.Keys should have comment or be unexported (golint)
  • Line 356: warning: exported method DisabledCache.Snapshot should have comment or be unexported (golint)

• istio/tests/fuzz/misc_fuzzers.go
  • Line 21: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 46: warning: exported function FuzzCheckIstioOperatorSpec should have comment or be unexported (golint)
  • Line 59: warning: exported function FuzzV1Alpha1ValidateConfig should have comment or be unexported (golint)
  • Line 71: warning: exported function FuzzGetEnabledComponents should have comment or be unexported (golint)
  • Line 83: warning: exported function FuzzUnmarshalAndValidateIOPS should have comment or be unexported (golint)
  • Line 88: warning: exported function FuzzVerify should have comment or be unexported (golint)
  • Line 101: warning: exported function FuzzRenderManifests should have comment or be unexported (golint)
  • Line 114: warning: exported function FuzzOverlayIOP should have comment or be unexported (golint)
  • Line 129: warning: exported function FuzzNewControlplane should have comment or be unexported (golint)
  • Line 147: warning: exported function FuzzResolveK8sConflict should have comment or be unexported (golint)
  • Line 160: warning: exported function FuzzYAMLManifestPatch should have comment or be unexported (golint)
  • Line 190: warning: exported function FuzzGalleyMeshFs should have comment or be unexported (golint)
  • Line 224: warning: exported function FuzzGalleyDiag should have comment or be unexported (golint)

• istio/pkg/mcp/internal/size.go
  • Line 23: warning: exported function ProtoSize should have comment or be unexported (golint)

• istio/pkg/util/istiomultierror/util.go
  • Line 43: warning: exported function New should have comment or be unexported (golint)

• istio/pilot/pkg/features/pilot.go
  • Line 29: warning: exported var MaxConcurrentStreams should have comment or be unexported (golint)
  • Line 185: warning: exported var InboundProtocolDetectionTimeoutSet should have its own declaration (golint)

• istio/pilot/pkg/security/authz/builder/builder.go
  • Line 47: warning: comment on exported type Option should be of the form "Option ..." (with optional leading article) (golint)

• istio/pkg/kube/configmapwatcher/configmapwatcher.go
  • Line 96: warning: exported method Controller.Run should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/common/call.go
  • Line 132: warning: exported function CallEcho should have comment or be unexported (golint)
  • Line 158: warning: exported function ForwardEcho should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/instances.go
  • Line 184: warning: exported method Instances.GetOrFail should have comment or be unexported (golint)
  • Line 192: warning: exported method Instances.Contains should have comment or be unexported (golint)
  • Line 204: warning: exported method Instances.ContainsMatch should have comment or be unexported (golint)
  • Line 259: warning: exported method Services.Instances should have comment or be unexported (golint)
  • Line 267: warning: exported method Services.MatchFQDNs should have comment or be unexported (golint)

• istio/operator/pkg/util/k8s.go
  • Line 28: warning: exported type JWTPolicy should have comment or be unexported (golint)
  • Line 31: warning: exported const FirstPartyJWT should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/serviceregistry/mock/discovery.go
  • Line 50: warning: exported type ServiceArgs should have comment or be unexported (golint)
  • Line 233: warning: exported method ServiceDiscovery.GetProxyWorkloadLabels should have comment or be unexported (golint)
  • Line 251: warning: exported method ServiceDiscovery.NetworkGateways should have comment or be unexported (golint)
  • Line 256: warning: exported method ServiceDiscovery.MCSServices should have comment or be unexported (golint)
  • Line 260: warning: exported type Controller should have comment or be unexported (golint)
  • Line 262: warning: exported method Controller.AppendServiceHandler should have comment or be unexported (golint)
  • Line 264: warning: exported method Controller.AppendWorkloadHandler should have comment or be unexported (golint)
  • Line 266: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 268: warning: exported method Controller.HasSynced should have comment or be unexported (golint)

• istio/istioctl/cmd/root.go
  • Line 59: warning: exported const FlagNamespace should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/util/retry/retry.go
  • Line 72: warning: exported function BackoffDelay should have comment or be unexported (golint)
  • Line 122: warning: exported var ErrConditionNotMet should have comment or be unexported (golint)

• istio/operator/pkg/tpath/tree.go
  • Line 15: warning: package comment should be of the form "Package tpath ..." (golint)

• istio/security/pkg/stsservice/mock/xdsserver.go
  • Line 53: warning: exported type DynamicListener should have comment or be unexported (golint)
  • Line 143: warning: exported type XDSCallbacks should have comment or be unexported (golint)
  • Line 160: warning: exported method XDSCallbacks.OnDeltaStreamOpen should have comment or be unexported (golint)
  • Line 164: warning: exported method XDSCallbacks.OnDeltaStreamClosed should have comment or be unexported (golint)
  • Line 168: warning: exported method XDSCallbacks.OnStreamDeltaRequest should have comment or be unexported (golint)
  • Line 172: warning: exported method XDSCallbacks.OnStreamDeltaResponse should have comment or be unexported (golint)
  • Line 176: warning: exported function CreateXdsCallback should have comment or be unexported (golint)
  • Line 182: warning: exported method XDSCallbacks.SetCallbackError should have comment or be unexported (golint)
  • Line 188: warning: exported method XDSCallbacks.SetExpectedToken should have comment or be unexported (golint)
  • Line 203: warning: exported method XDSCallbacks.ExpectedToken should have comment or be unexported (golint)
  • Line 209: warning: exported method XDSCallbacks.NumStream should have comment or be unexported (golint)
  • Line 215: warning: exported method XDSCallbacks.NumTokenReceived should have comment or be unexported (golint)
  • Line 221: warning: exported method XDSCallbacks.OnStreamOpen should have comment or be unexported (golint)
  • Line 256: warning: exported method XDSCallbacks.OnStreamClosed should have comment or be unexported (golint)
  • Line 260: warning: exported method XDSCallbacks.OnStreamRequest should have comment or be unexported (golint)
  • Line 277: warning: exported method XDSCallbacks.OnStreamResponse should have comment or be unexported (golint)
  • Line 281: warning: exported method XDSCallbacks.OnFetchRequest should have comment or be unexported (golint)
  • Line 286: warning: exported method XDSCallbacks.OnFetchResponse should have comment or be unexported (golint)

• istio/pkg/test/framework/resource/matcher.go
  • Line 26: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 51: warning: exported method Matcher.MatchTest should have comment or be unexported (golint)

• istio/security/pkg/server/ca/authenticate/kubeauth/kube_jwt.go
  • Line 37: warning: exported const KubeJWTAuthenticatorType should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported type RemoteKubeClientGetter should have comment or be unexported (golint)
  • Line 74: warning: exported method KubeJWTAuthenticator.AuthenticatorType should have comment or be unexported (golint)
  • Line 85: warning: exported method KubeJWTAuthenticator.AuthenticateRequest should have comment or be unexported (golint)
  • Line 157: warning: exported method KubeJWTAuthenticator.GetKubeClient should have comment or be unexported (golint)

• istio/tests/fuzz/analyzer_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)

• istio/pilot/pkg/grpc/grpc.go
  • Line 33: warning: exported type SendHandler should have comment or be unexported (golint)
  • Line 57: warning: exported function ServerOptions should have comment or be unexported (golint)

• istio/pilot/pkg/xds/endpoint_builder.go
  • Line 42: warning: comment on exported function GetTunnelBuilderType should be of the form "GetTunnelBuilderType ..." (golint)
  • Line 62: warning: exported type EndpointBuilder should have comment or be unexported (golint)
  • Line 84: warning: exported function NewEndpointBuilder should have comment or be unexported (golint)
  • Line 114: warning: exported method EndpointBuilder.DestinationRule should have comment or be unexported (golint)
  • Line 156: warning: exported method EndpointBuilder.Cacheable should have comment or be unexported (golint)
  • Line 163: warning: exported method EndpointBuilder.DependentConfigs should have comment or be unexported (golint)
  • Line 176: warning: exported method EndpointBuilder.DependentTypes should have comment or be unexported (golint)
  • Line 187: warning: comment on exported type EndpointTunnelApplier should be of the form "EndpointTunnelApplier ..." (with optional leading article) (golint)
  • Line 193: warning: exported type EndpointNoTunnelApplier should have comment or be unexported (golint)
  • Line 195: warning: comment on exported method EndpointNoTunnelApplier.ApplyTunnel should be of the form "ApplyTunnel ..." (golint)
  • Line 200: warning: exported type EndpointH2TunnelApplier should have comment or be unexported (golint)
  • Line 202: warning: comment on exported method EndpointH2TunnelApplier.ApplyTunnel should be of the form "ApplyTunnel ..." (golint)
  • Line 223: warning: exported type LocLbEndpointsAndOptions should have comment or be unexported (golint)
  • Line 231: warning: comment on exported function MakeTunnelApplier should be of the form "MakeTunnelApplier ..." (golint)
  • Line 258: warning: exported method LocLbEndpointsAndOptions.AssertInvarianceInTest should have comment or be unexported (golint)
  • Line 371: warning: comment on exported method EndpointBuilder.ApplyTunnelSetting should be of the form "ApplyTunnelSetting ..." (golint)

• istio/pkg/spiffe/spiffe.go
  • Line 37: warning: exported const Scheme should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported type Identity should have comment or be unexported (golint)
  • Line 66: warning: exported function ParseIdentity should have comment or be unexported (golint)
  • Line 94: warning: exported function SetTrustDomain should have comment or be unexported (golint)
  • Line 102: warning: exported function GetTrustDomain should have comment or be unexported (golint)

• istio/pkg/test/framework/components/redis/redis.go
  • Line 23: warning: comment on exported type Instance should be of the form "Instance ..." (with optional leading article) (golint)
  • Line 29: warning: exported type Config should have comment or be unexported (golint)

• istio/security/pkg/k8s/configutil.go
  • Line 83: warning: exported function UpdateDataInConfigMap should have comment or be unexported (golint)

• istio/security/pkg/pki/ca/selfsignedcarootcertrotator.go
  • Line 34: warning: exported type SelfSignedCARootCertRotatorConfig should have comment or be unexported (golint)

• istio/security/pkg/stsservice/tokenmanager/tokenmanager.go
  • Line 39: warning: exported type TokenManager should have comment or be unexported (golint)
  • Line 43: warning: exported type Config should have comment or be unexported (golint)
  • Line 58: warning: exported function GetGCPProjectInfo should have comment or be unexported (golint)
  • Line 103: warning: exported method TokenManager.GenerateToken should have comment or be unexported (golint)
  • Line 110: warning: exported method TokenManager.DumpTokenStatus should have comment or be unexported (golint)
  • Line 117: warning: exported method TokenManager.GetMetadata should have comment or be unexported (golint)

• istio/pilot/test/xdstest/validate.go
  • Line 32: warning: exported function ValidateListeners should have comment or be unexported (golint)
  • Line 44: warning: exported function ValidateListener should have comment or be unexported (golint)
  • Line 172: warning: exported function ValidateClusters should have comment or be unexported (golint)
  • Line 183: warning: exported function ValidateCluster should have comment or be unexported (golint)
  • Line 196: warning: exported function ValidateRoutes should have comment or be unexported (golint)
  • Line 202: warning: exported function ValidateRoute should have comment or be unexported (golint)
  • Line 208: warning: exported function ValidateRouteConfigurations should have comment or be unexported (golint)
  • Line 219: warning: exported function ValidateRouteConfiguration should have comment or be unexported (golint)
  • Line 246: warning: exported function ValidateClusterLoadAssignments should have comment or be unexported (golint)
  • Line 252: warning: exported function ValidateClusterLoadAssignment should have comment or be unexported (golint)

• istio/pkg/config/mesh/watcher.go
  • Line 55: warning: exported type InternalWatcher should have comment or be unexported (golint)
  • Line 221: warning: exported function PrettyFormatOfMeshConfig should have comment or be unexported (golint)

• istio/pkg/test/echo/common/scheme/scheme.go
  • Line 17: warning: comment on exported type Instance should be of the form "Instance ..." (with optional leading article) (golint)
  • Line 21: warning: exported const HTTP should have comment (or a comment on this block) or be unexported (golint)

• istio/tests/util/leak/check.go
  • Line 15: warning: package comment should be of the form "Package leak ..." (golint)
  • Line 70: warning: exported type TestingTB should have comment or be unexported (golint)

• istio/cni/pkg/repair/repair.go
  • Line 226: warning: exported function StartRepair should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/crd/conversion.go
  • Line 49: warning: exported function IstioStatusJSONFromMap should have comment or be unexported (golint)

• istio/pilot/pkg/keycertbundle/watcher.go
  • Line 31: warning: exported type Watcher should have comment or be unexported (golint)
  • Line 40: warning: exported function NewWatcher should have comment or be unexported (golint)
  • Line 133: warning: comment on exported method Watcher.GetKeyCertBundle should be of the form "GetKeyCertBundle ..." (golint)

• istio/pkg/test/echo/common/util.go
  • Line 30: warning: exported var DefaultRequestTimeout should have comment or be unexported (golint)
  • Line 33: warning: exported const ConnectionTimeout should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/config/map.go
  • Line 23: warning: exported type Map should have comment or be unexported (golint)
  • Line 25: warning: exported method Map.Map should have comment or be unexported (golint)
  • Line 49: warning: exported method Map.Slice should have comment or be unexported (golint)
  • Line 84: warning: exported method Map.Bool should have comment or be unexported (golint)
  • Line 96: warning: exported method Map.Int should have comment or be unexported (golint)

• istio/pilot/pkg/model/authorization.go
  • Line 26: warning: exported type AuthorizationPolicy should have comment or be unexported (golint)
  • Line 68: warning: exported type AuthorizationPoliciesResult should have comment or be unexported (golint)

• istio/pkg/test/echo/client/client.go
  • Line 101: warning: exported method Instance.Echo should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/config.go
  • Line 41: warning: exported type VMDistro should have comment or be unexported (golint)
  • Line 44: warning: exported const UbuntuXenial should have comment (or a comment on this block) or be unexported (golint)
  • Line 197: warning: exported method Config.IsHeadless should have comment or be unexported (golint)
  • Line 201: warning: exported method Config.IsStatefulSet should have comment or be unexported (golint)
  • Line 205: warning: exported method Config.IsNaked should have comment or be unexported (golint)
  • Line 209: warning: exported method Config.IsProxylessGRPC should have comment or be unexported (golint)
  • Line 214: warning: exported method Config.IsTProxy should have comment or be unexported (golint)
  • Line 219: warning: exported method Config.IsVM should have comment or be unexported (golint)
  • Line 223: warning: exported method Config.IsDelta should have comment or be unexported (golint)
  • Line 238: warning: exported method Config.IsExternal should have comment or be unexported (golint)

• istio/pilot/pkg/credentials/kube/multicluster.go
  • Line 39: warning: exported function NewMulticluster should have comment or be unexported (golint)
  • Line 48: warning: exported method Multicluster.ClusterAdded should have comment or be unexported (golint)
  • Line 60: warning: exported method Multicluster.ClusterUpdated should have comment or be unexported (golint)
  • Line 70: warning: exported method Multicluster.ClusterDeleted should have comment or be unexported (golint)
  • Line 77: warning: exported method Multicluster.ForCluster should have comment or be unexported (golint)
  • Line 97: warning: exported method Multicluster.AddEventHandler should have comment or be unexported (golint)
  • Line 104: warning: exported type AggregateController should have comment or be unexported (golint)
  • Line 113: warning: exported method AggregateController.GetKeyAndCert should have comment or be unexported (golint)
  • Line 129: warning: exported method AggregateController.GetCaCert should have comment or be unexported (golint)
  • Line 145: warning: exported method AggregateController.Authorize should have comment or be unexported (golint)
  • Line 149: warning: exported method AggregateController.AddEventHandler should have comment or be unexported (golint)

• istio/pilot/pkg/model/credentials/resource.go
  • Line 50: warning: exported method SecretResource.Key should have comment or be unexported (golint)
  • Line 54: warning: exported function ToKubernetesGatewayResource should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/leaderelection.go
  • Line 54: warning: exported type LeaderElection should have comment or be unexported (golint)
  • Line 160: warning: exported function NewLeaderElection should have comment or be unexported (golint)

• istio/galley/pkg/testing/mock/watch.go
  • Line 35: warning: exported type Watches should have comment or be unexported (golint)
  • Line 37: warning: exported method Watches.Send should have comment or be unexported (golint)

• istio/pilot/pkg/model/network.go
  • Line 126: warning: exported method NetworkManager.IsMultiNetworkEnabled should have comment or be unexported (golint)
  • Line 135: warning: exported method NetworkManager.AllGateways should have comment or be unexported (golint)
  • Line 144: warning: exported method NetworkManager.GatewaysByNetwork should have comment or be unexported (golint)
  • Line 152: warning: exported method NetworkManager.GatewaysForNetwork should have comment or be unexported (golint)
  • Line 156: warning: exported method NetworkManager.GatewaysForNetworkAndCluster should have comment or be unexported (golint)
  • Line 176: warning: exported function SortGateways should have comment or be unexported (golint)

• istio/pkg/test/framework/config/config.go
  • Line 41: warning: exported type Value should have comment or be unexported (golint)
  • Line 47: warning: exported function Parsed should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/sidecar/selector.go
  • Line 1: warning: package comment should be of the form "Package sidecar ..." (golint)

• istio/pilot/pkg/serviceregistry/aggregate/controller.go
  • Line 61: warning: exported type Options should have comment or be unexported (golint)
  • Line 225: warning: exported method Controller.MCSServices should have comment or be unexported (golint)
  • Line 282: warning: exported method Controller.GetProxyWorkloadLabels should have comment or be unexported (golint)
  • Line 336: warning: exported method Controller.AppendServiceHandler should have comment or be unexported (golint)
  • Line 340: warning: exported method Controller.AppendWorkloadHandler should have comment or be unexported (golint)

• istio/pkg/istio-agent/health/health_check.go
  • Line 28: warning: exported type WorkloadHealthChecker should have comment or be unexported (golint)
  • Line 42: warning: exported type ProbeEvent should have comment or be unexported (golint)
  • Line 84: warning: exported function NewWorkloadHealthChecker should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/serviceentry/protocoladresses.go
  • Line 29: warning: exported type ProtocolAdressesAnalyzer should have comment or be unexported (golint)
  • Line 33: warning: exported method ProtocolAdressesAnalyzer.Metadata should have comment or be unexported (golint)
  • Line 43: warning: exported method ProtocolAdressesAnalyzer.Analyze should have comment or be unexported (golint)

• istio/operator/pkg/util/tgz/tgz.go
  • Line 71: warning: exported function Extract should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/mock/discovery_mock.go
  • Line 34: warning: exported var ReplicatedFooServiceV1 should have comment or be unexported (golint)

• istio/pilot/pkg/status/state.go
  • Line 46: warning: exported type Progress should have comment or be unexported (golint)
  • Line 51: warning: exported method Progress.PlusEquals should have comment or be unexported (golint)
  • Line 56: warning: exported type DistributionController should have comment or be unexported (golint)
  • Line 69: warning: exported function NewController should have comment or be unexported (golint)
  • Line 101: warning: exported method DistributionController.Start should have comment or be unexported (golint)
  • Line 229: warning: exported function GetTypedStatus should have comment or be unexported (golint)
  • Line 243: warning: exported function ReconcileStatuses should have comment or be unexported (golint)
  • Line 290: warning: exported type DistroReportHandler should have comment or be unexported (golint)
  • Line 294: warning: exported method DistroReportHandler.OnAdd should have comment or be unexported (golint)
  • Line 298: warning: exported method DistroReportHandler.OnUpdate should have comment or be unexported (golint)
  • Line 302: warning: exported method DistroReportHandler.HandleNew should have comment or be unexported (golint)
  • Line 318: warning: exported method DistroReportHandler.OnDelete should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/util.go
  • Line 58: warning: comment on exported function FindPort should be of the form "FindPort ..." (golint)

• istio/tools/istio-clean-iptables/pkg/config/config.go
  • Line 24: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 44: warning: exported method Config.Print should have comment or be unexported (golint)

• istio/security/pkg/pki/util/generate_cert.go
  • Line 46: warning: comment on exported const EcdsaSigAlg should be of the form "EcdsaSigAlg ..." (golint)

• istio/pilot/pkg/xds/cds.go
  • Line 23: warning: exported type CdsGenerator should have comment or be unexported (golint)
  • Line 71: warning: exported method CdsGenerator.Generate should have comment or be unexported (golint)

• istio/pilot/pkg/xds/delta.go
  • Line 36: warning: exported method DiscoveryServer.StreamDeltas should have comment or be unexported (golint)

• istio/tests/common/jwt/jwt_token.go
  • Line 15: warning: package comment should be of the form "Package jwt ..." (golint)
  • Line 19: warning: comment on exported const TokenIssuer1 should be of the form "TokenIssuer1 ..." (golint)
  • Line 33: warning: comment on exported const TokenIssuer1WithAud should be of the form "TokenIssuer1WithAud ..." (golint)
  • Line 45: warning: comment on exported const TokenIssuer1WithAzp should be of the form "TokenIssuer1WithAzp ..." (golint)
  • Line 57: warning: comment on exported const TokenIssuer1WithNestedClaims1 should be of the form "TokenIssuer1WithNestedClaims1 ..." (golint)
  • Line 80: warning: comment on exported const TokenIssuer1WithNestedClaims2 should be of the form "TokenIssuer1WithNestedClaims2 ..." (golint)
  • Line 97: warning: comment on exported const TokenIssuer2 should be of the form "TokenIssuer2 ..." (golint)
  • Line 111: warning: comment on exported const TokenIssuer2WithSpaceDelimitedScope should be of the form "TokenIssuer2WithSpaceDelimitedScope ..." (golint)
  • Line 123: warning: comment on exported const TokenExpired should be of the form "TokenExpired ..." (golint)
  • Line 137: warning: exported const TokenInvalid should have comment (or a comment on this block) or be unexported (golint)

• istio/cni/pkg/plugin/redirect.go
  • Line 15: warning: package comment should be of the form "Package plugin ..." (golint)

• istio/istioctl/pkg/writer/compare/sds/writer.go
  • Line 31: warning: exported type Format should have comment or be unexported (golint)
  • Line 34: warning: exported const JSON should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/components/environment/kube/kube.go
  • Line 66: warning: exported method Environment.EnvironmentName should have comment or be unexported (golint)
  • Line 70: warning: exported method Environment.IsMulticluster should have comment or be unexported (golint)
  • Line 79: warning: exported method Environment.AllClusters should have comment or be unexported (golint)
  • Line 85: warning: exported method Environment.Clusters should have comment or be unexported (golint)
  • Line 103: warning: exported method Environment.Settings should have comment or be unexported (golint)

• istio/tests/fuzz/helm_reconciler_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 30: warning: exported function FuzzHelmReconciler should have comment or be unexported (golint)

• istio/pkg/mcp/internal/test/auth_checker.go
  • Line 21: warning: exported type FakeAuthChecker should have comment or be unexported (golint)
  • Line 25: warning: exported function NewFakeAuthChecker should have comment or be unexported (golint)
  • Line 29: warning: exported method FakeAuthChecker.Check should have comment or be unexported (golint)
  • Line 33: warning: exported method FakeAuthChecker.AuthType should have comment or be unexported (golint)

• istio/pilot/pkg/xds/discovery.go
  • Line 263: warning: exported method DiscoveryServer.IsServerReady should have comment or be unexported (golint)
  • Line 267: warning: exported method DiscoveryServer.Start should have comment or be unexported (golint)
  • Line 606: warning: comment on exported method DiscoveryServer.Shutdown should be of the form "Shutdown ..." (golint)
  • Line 662: warning: comment on exported method DiscoveryServer.ClientsOf should be of the form "ClientsOf ..." (golint)
  • Line 675: warning: exported method DiscoveryServer.WaitForRequestLimit should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/diag/helper.go
  • Line 60: warning: exported function MockResource should have comment or be unexported (golint)

• istio/tests/fuzz/pilot_model_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 46: warning: comment on exported function NewSI should be of the form "NewSI ..." (golint)
  • Line 124: warning: comment on exported function NewS should be of the form "NewS ..." (golint)
  • Line 148: warning: comment on exported function FuzzInitContext should be of the form "FuzzInitContext ..." (golint)
  • Line 209: warning: exported function FuzzBNMUnmarshalJSON should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/cmd/root.go
  • Line 429: warning: exported function GetCommand should have comment or be unexported (golint)
  • Line 433: warning: exported function GetRouteCommand should have comment or be unexported (golint)
  • Line 437: warning: exported function Execute should have comment or be unexported (golint)

• istio/pilot/pkg/credentials/model.go
  • Line 19: warning: exported type Controller should have comment or be unexported (golint)
  • Line 26: warning: exported type MulticlusterController should have comment or be unexported (golint)

• istio/pilot/pkg/bootstrap/servicecontroller.go
  • Line 31: warning: exported method Server.ServiceController should have comment or be unexported (golint)

• istio/pkg/test/util/yml/parts.go
  • Line 49: warning: comment on exported function GetMetadata should be of the form "GetMetadata ..." (golint)

• istio/pilot/pkg/xds/debug.go
  • Line 152: warning: exported method DiscoveryServer.AddDebugHandlers should have comment or be unexported (golint)

• istio/pkg/kube/inject/app_probe.go
  • Line 101: warning: exported type KubeAppProbers should have comment or be unexported (golint)

• istio/pkg/test/framework/test.go
  • Line 30: warning: exported type Test should have comment or be unexported (golint)

• istio/pilot/test/xdstest/mock_discovery.go
  • Line 33: warning: exported function NewMockServer should have comment or be unexported (golint)
  • Line 55: warning: exported method MockDiscovery.StreamAggregatedResources should have comment or be unexported (golint)
  • Line 71: warning: exported method MockDiscovery.DeltaAggregatedResources should have comment or be unexported (golint)

• istio/pkg/config/xds/filter_types.gen.go
  • Line 21: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• istio/pilot/pkg/xds/ads.go
  • Line 257: warning: exported method DiscoveryServer.Stream should have comment or be unexported (golint)
  • Line 834: warning: exported method DiscoveryServer.ProxyUpdate should have comment or be unexported (golint)
  • Line 960: warning: comment on exported method Connection.Synced should be of the form "Synced ..." (golint)
  • Line 972: warning: comment on exported method Connection.NonceAcked should be of the form "NonceAcked ..." (golint)
  • Line 982: warning: comment on exported method Connection.NonceSent should be of the form "NonceSent ..." (golint)
  • Line 992: warning: exported method Connection.Clusters should have comment or be unexported (golint)
  • Line 1001: warning: exported method Connection.Routes should have comment or be unexported (golint)
  • Line 1010: warning: comment on exported method Connection.Watching should be of the form "Watching ..." (golint)
  • Line 1020: warning: comment on exported method Connection.Watched should be of the form "Watched ..." (golint)
  • Line 1030: warning: exported method Connection.Stop should have comment or be unexported (golint)

• istio/samples/jwt-server/src/main.go
  • Line 118: warning: exported function NewJwtServer should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/util/service_lookup.go
  • Line 29: warning: exported function InitServiceEntryHostMap should have comment or be unexported (golint)
  • Line 72: warning: exported function GetDestinationHost should have comment or be unexported (golint)

• istio/pkg/security/mock.go
  • Line 34: warning: exported type DirectSecretManager should have comment or be unexported (golint)
  • Line 41: warning: exported function NewDirectSecretManager should have comment or be unexported (golint)
  • Line 47: warning: exported method DirectSecretManager.GenerateSecret should have comment or be unexported (golint)
  • Line 57: warning: exported method DirectSecretManager.Set should have comment or be unexported (golint)
  • Line 67: warning: exported type FakeAuthenticator should have comment or be unexported (golint)
  • Line 78: warning: exported function NewFakeAuthenticator should have comment or be unexported (golint)
  • Line 86: warning: exported method FakeAuthenticator.AuthenticateRequest should have comment or be unexported (golint)
  • Line 90: warning: exported method FakeAuthenticator.Authenticate should have comment or be unexported (golint)
  • Line 121: warning: exported method FakeAuthenticator.AuthenticatorType should have comment or be unexported (golint)
  • Line 125: warning: exported method FakeAuthenticator.Set should have comment or be unexported (golint)

• istio/pkg/test/framework/components/stackdriver/kube.go
  • Line 42: warning: exported type LogType should have comment or be unexported (golint)
  • Line 50: warning: exported const ServerAccessLog should have comment (or a comment on this block) or be unexported (golint)

• istio/security/pkg/nodeagent/cache/secretcache.go
  • Line 194: warning: exported method SecretManagerClient.Close should have comment or be unexported (golint)
  • Line 202: warning: exported method SecretManagerClient.SetUpdateCallback should have comment or be unexported (golint)
  • Line 208: warning: exported method SecretManagerClient.CallUpdateCallback should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/options/statusserver.go
  • Line 26: warning: exported function NewStatusServerOptions should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/caclient/providers/mock/mockcaclient.go
  • Line 63: warning: exported method CAClient.Close should have comment or be unexported (golint)
  • Line 90: warning: exported method CAClient.GetRootCertBundle should have comment or be unexported (golint)

• istio/cni/pkg/plugin/intercept_rule_mgr.go
  • Line 27: warning: exported type InterceptRuleMgrCtor should have comment or be unexported (golint)
  • Line 29: warning: exported var InterceptRuleMgrTypes should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function GetInterceptRuleMgrCtor should be of the form "GetInterceptRuleMgrCtor ..." (golint)
  • Line 38: warning: comment on exported function IptablesInterceptRuleMgrCtor should be of the form "IptablesInterceptRuleMgrCtor ..." (golint)

• istio/pkg/mcp/internal/test/types.go
  • Line 1: warning: package comment should be of the form "Package test ..." (golint)
  • Line 29: warning: exported type FakeTypeBase should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeTypeBase.Reset should have comment or be unexported (golint)
  • Line 33: warning: exported method FakeTypeBase.ProtoMessage should have comment or be unexported (golint)
  • Line 34: warning: exported method FakeTypeBase.Marshal should have comment or be unexported (golint)
  • Line 35: warning: exported method FakeTypeBase.Unmarshal should have comment or be unexported (golint)
  • Line 41: warning: exported type FakeType0 should have comment or be unexported (golint)
  • Line 42: warning: exported type FakeType1 should have comment or be unexported (golint)
  • Line 43: warning: exported type FakeType2 should have comment or be unexported (golint)
  • Line 46: warning: exported type UnmarshalErrorType should have comment or be unexported (golint)
  • Line 48: warning: exported method UnmarshalErrorType.Unmarshal should have comment or be unexported (golint)
  • Line 51: warning: exported const TypePrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported var FakeType0Collection should have comment or be unexported (golint)
  • Line 70: warning: exported type Fake should have comment or be unexported (golint)
  • Line 78: warning: exported function MakeRequest should have comment or be unexported (golint)
  • Line 91: warning: exported function MakeResources should have comment or be unexported (golint)
  • Line 105: warning: exported function MakeFakeResource should have comment or be unexported (golint)
  • Line 142: warning: exported var Type0A should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/metrics.go
  • Line 31: warning: comment on exported type SwitchMetric should be of the form "SwitchMetric ..." (with optional leading article) (golint)

• istio/pilot/pkg/serviceregistry/memory/discovery.go
  • Line 39: warning: comment on exported method ServiceController.AppendWorkloadHandler should be of the form "AppendWorkloadHandler ..." (golint)
  • Line 105: warning: exported method ServiceDiscovery.AddWorkload should have comment or be unexported (golint)
  • Line 297: warning: exported method ServiceDiscovery.GetProxyWorkloadLabels should have comment or be unexported (golint)
  • Line 323: warning: exported method ServiceDiscovery.AddGateways should have comment or be unexported (golint)
  • Line 327: warning: exported method ServiceDiscovery.NetworkGateways should have comment or be unexported (golint)
  • Line 331: warning: exported method ServiceDiscovery.MCSServices should have comment or be unexported (golint)

• istio/pkg/bootstrap/platform/gcp.go
  • Line 36: warning: exported const GCPProject should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported var GCPMetadata should have comment or be unexported (golint)
  • Line 256: warning: exported const ComputeReadonlyScope should have comment or be unexported (golint)

• istio/pkg/test/echo/common/response/response.go
  • Line 23: warning: exported var StatusCodeOK should have comment or be unexported (golint)
  • Line 35: warning: exported const RequestIDField should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/components/cluster/fake.go
  • Line 29: warning: exported function NewFake should have comment or be unexported (golint)
  • Line 65: warning: exported method FakeCluster.GetKubernetesVersion should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/sds/server.go
  • Line 54: warning: exported method Server.UpdateCallback should have comment or be unexported (golint)

• istio/pkg/config/model.go
  • Line 107: warning: exported function ObjectInRevision should have comment or be unexported (golint)
  • Line 124: warning: exported function ToProtoGogo should have comment or be unexported (golint)
  • Line 155: warning: exported function ToMap should have comment or be unexported (golint)
  • Line 171: warning: exported function ToJSON should have comment or be unexported (golint)
  • Line 196: warning: exported function ApplyYAML should have comment or be unexported (golint)
  • Line 204: warning: exported function ApplyJSONStrict should have comment or be unexported (golint)
  • Line 226: warning: exported function ApplyJSON should have comment or be unexported (golint)
  • Line 246: warning: exported function DeepCopy should have comment or be unexported (golint)
  • Line 284: warning: exported type Status should have comment or be unexported (golint)
  • Line 298: warning: exported method Config.DeepCopy should have comment or be unexported (golint)
  • Line 322: warning: exported type GroupVersionKind should have comment or be unexported (golint)

• istio/pilot/pkg/model/disabled_ledger.go
  • Line 29: warning: exported method DisabledLedger.Put should have comment or be unexported (golint)
  • Line 33: warning: exported method DisabledLedger.Delete should have comment or be unexported (golint)
  • Line 37: warning: exported method DisabledLedger.Get should have comment or be unexported (golint)
  • Line 41: warning: exported method DisabledLedger.RootHash should have comment or be unexported (golint)
  • Line 45: warning: exported method DisabledLedger.GetPreviousValue should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/accesslog.go
  • Line 120: warning: exported type AccessLogBuilder should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/echotest/filters.go
  • Line 20: warning: exported type Filter should have comment or be unexported (golint)
  • Line 21: warning: exported type CombinationFilter should have comment or be unexported (golint)

• istio/pkg/config/validation/virtualservice.go
  • Line 27: warning: exported type HTTPRouteType should have comment or be unexported (golint)
  • Line 30: warning: exported const IndependentRoute should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/components/istio/util.go
  • Line 180: warning: exported function PatchMeshConfig should have comment or be unexported (golint)

• istio/security/pkg/pki/util/crypto.go
  • Line 139: warning: comment on exported function PemCertBytestoString should be of the form "PemCertBytestoString ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/util/in_mesh.go
  • Line 27: warning: comment on exported function DeploymentInMesh should be of the form "DeploymentInMesh ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/webhook/webhook.go
  • Line 39: warning: exported type Analyzer should have comment or be unexported (golint)
  • Line 45: warning: exported method Analyzer.Metadata should have comment or be unexported (golint)
  • Line 72: warning: exported method Analyzer.Analyze should have comment or be unexported (golint)

• istio/pilot/pkg/config/memory/controller.go
  • Line 57: warning: exported method Controller.RegisterHasSyncedHandler should have comment or be unexported (golint)
  • Line 61: warning: exported method Controller.RegisterEventHandler should have comment or be unexported (golint)
  • Line 65: warning: exported method Controller.SetWatchErrorHandler should have comment or be unexported (golint)
  • Line 79: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 83: warning: exported method Controller.Schemas should have comment or be unexported (golint)
  • Line 87: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 91: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 101: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 113: warning: exported method Controller.UpdateStatus should have comment or be unexported (golint)
  • Line 125: warning: exported method Controller.Patch should have comment or be unexported (golint)
  • Line 143: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 156: warning: exported method Controller.List should have comment or be unexported (golint)

• istio/pkg/bootstrap/platform/aws.go
  • Line 28: warning: exported const AWSRegion should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/network.go
  • Line 114: warning: exported method Controller.NetworkGateways should have comment or be unexported (golint)

• istio/pkg/test/framework/components/istio/operator.go
  • Line 825: warning: exported function CreateRemoteSecret should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/kube/deployment.go
  • Line 611: warning: exported function GenerateDeployment should have comment or be unexported (golint)
  • Line 625: warning: exported function GenerateService should have comment or be unexported (golint)
  • Line 634: warning: exported var VMImages should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/capture/format.go
  • Line 19: warning: exported function FormatIptablesCommands should have comment or be unexported (golint)

• istio/operator/pkg/manifest/shared.go
  • Line 107: warning: exported function OverlayYAMLStrings should have comment or be unexported (golint)
  • Line 270: warning: exported function ReadLayeredYAMLs should have comment or be unexported (golint)
  • Line 325: warning: exported function GetProfile should have comment or be unexported (golint)
  • Line 333: warning: exported function GetMergedIOP should have comment or be unexported (golint)

• istio/operator/cmd/mesh/uninstall.go
  • Line 67: warning: exported const AllResourcesRemovedWarning should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/queue/instance.go
  • Line 29: warning: exported type BackoffTask should have comment or be unexported (golint)
  • Line 73: warning: exported function NewBackOffQueue should have comment or be unexported (golint)

• istio/tests/fuzz/config_validation_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 29: warning: exported function FuzzConfigValidation should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch.go
  • Line 30: warning: exported function ApplyRouteConfigurationPatches should have comment or be unexported (golint)

• istio/pkg/bootstrap/instance.go
  • Line 34: warning: exported const DefaultCfgDir should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/envoy/options.go
  • Line 59: warning: exported type Options should have comment or be unexported (golint)
  • Line 179: warning: exported const LogLevelTrace should have comment (or a comment on this block) or be unexported (golint)
  • Line 187: warning: exported method LogLevel.FlagName should have comment or be unexported (golint)
  • Line 191: warning: exported method LogLevel.FlagValue should have comment or be unexported (golint)
  • Line 261: warning: exported method ComponentLogLevels.FlagName should have comment or be unexported (golint)
  • Line 265: warning: exported method ComponentLogLevels.FlagValue should have comment or be unexported (golint)
  • Line 296: warning: exported const IPV4 should have comment (or a comment on this block) or be unexported (golint)
  • Line 377: warning: exported method BaseID.FlagName should have comment or be unexported (golint)
  • Line 381: warning: exported method BaseID.FlagValue should have comment or be unexported (golint)
  • Line 511: warning: exported method Epoch.FlagName should have comment or be unexported (golint)
  • Line 515: warning: exported method Epoch.FlagValue should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/fake.go
  • Line 52: warning: exported type TestOptions should have comment or be unexported (golint)
  • Line 89: warning: exported type ConfigGenTest should have comment or be unexported (golint)
  • Line 102: warning: exported function NewConfigGenTest should have comment or be unexported (golint)
  • Line 180: warning: exported method ConfigGenTest.Run should have comment or be unexported (golint)
  • Line 241: warning: comment on exported method ConfigGenTest.Listeners should be of the form "Listeners ..." (golint)
  • Line 246: warning: exported method ConfigGenTest.Clusters should have comment or be unexported (golint)
  • Line 259: warning: exported method ConfigGenTest.Routes should have comment or be unexported (golint)
  • Line 270: warning: exported method ConfigGenTest.PushContext should have comment or be unexported (golint)
  • Line 278: warning: exported method ConfigGenTest.Env should have comment or be unexported (golint)
  • Line 282: warning: exported method ConfigGenTest.Store should have comment or be unexported (golint)
  • Line 324: warning: exported type FakeXdsUpdater should have comment or be unexported (golint)
  • Line 326: warning: exported method FakeXdsUpdater.ConfigUpdate should have comment or be unexported (golint)
  • Line 328: warning: exported method FakeXdsUpdater.EDSUpdate should have comment or be unexported (golint)
  • Line 330: warning: exported method FakeXdsUpdater.EDSCacheUpdate should have comment or be unexported (golint)
  • Line 332: warning: exported method FakeXdsUpdater.SvcUpdate should have comment or be unexported (golint)
  • Line 334: warning: exported method FakeXdsUpdater.ProxyUpdate should have comment or be unexported (golint)

• istio/pkg/istio-agent/xds_proxy.go
  • Line 77: warning: comment on exported type XdsProxy should be of the form "XdsProxy ..." (with optional leading article) (golint)
  • Line 256: warning: exported method XdsProxy.UnregisterStream should have comment or be unexported (golint)
  • Line 265: warning: exported method XdsProxy.RegisterStream should have comment or be unexported (golint)
  • Line 275: warning: exported type ProxyConnection should have comment or be unexported (golint)
  • Line 305: warning: comment on exported method XdsProxy.StreamAggregatedResources should be of the form "StreamAggregatedResources ..." (golint)
  • Line 346: warning: exported method XdsProxy.HandleUpstream should have comment or be unexported (golint)

• istio/istioctl/pkg/multicluster/remote_secret.go
  • Line 461: warning: comment on exported type SecretType should be of the form "SecretType ..." (with optional leading article) (golint)
  • Line 470: warning: exported method RemoteSecretAuthType.Type should have comment or be unexported (golint)
  • Line 471: warning: exported method RemoteSecretAuthType.Set should have comment or be unexported (golint)
  • Line 477: warning: exported method SecretType.Type should have comment or be unexported (golint)
  • Line 478: warning: exported method SecretType.Set should have comment or be unexported (golint)
  • Line 484: warning: comment on exported const RemoteSecretAuthTypeBearerToken should be of the form "RemoteSecretAuthTypeBearerToken ..." (golint)
  • Line 487: warning: comment on exported const RemoteSecretAuthTypePlugin should be of the form "RemoteSecretAuthTypePlugin ..." (golint)
  • Line 490: warning: comment on exported const SecretTypeRemote should be of the form "SecretTypeRemote ..." (golint)
  • Line 493: warning: comment on exported const SecretTypeConfig should be of the form "SecretTypeConfig ..." (golint)
  • Line 582: warning: exported type Warning should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/deployment/services.go
  • Line 1: warning: package comment should be of the form "Package deployment ..." (golint)
  • Line 32: warning: exported type ServiceAssociationAnalyzer should have comment or be unexported (golint)
  • Line 37: warning: exported type PortMap should have comment or be unexported (golint)
  • Line 38: warning: exported type ProtocolMap should have comment or be unexported (golint)
  • Line 39: warning: exported type ServiceNames should have comment or be unexported (golint)
  • Line 40: warning: exported type ServiceSpecWithName should have comment or be unexported (golint)
  • Line 49: warning: exported method ServiceAssociationAnalyzer.Metadata should have comment or be unexported (golint)
  • Line 61: warning: exported method ServiceAssociationAnalyzer.Analyze should have comment or be unexported (golint)

• istio/pilot/pkg/security/authz/builder/logger.go
  • Line 30: warning: exported type AuthzLogger should have comment or be unexported (golint)
  • Line 35: warning: exported method AuthzLogger.AppendDebugf should have comment or be unexported (golint)
  • Line 39: warning: exported method AuthzLogger.AppendError should have comment or be unexported (golint)
  • Line 43: warning: exported method AuthzLogger.Report should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/caclient/providers/citadel/client.go
  • Line 47: warning: exported type CitadelClient should have comment or be unexported (golint)
  • Line 77: warning: exported method CitadelClient.Close should have comment or be unexported (golint)
  • Line 83: warning: comment on exported method CitadelClient.CSRSign should be of the form "CSRSign ..." (golint)
  • Line 250: warning: comment on exported method CitadelClient.GetRootCertBundle should be of the form "GetRootCertBundle ..." (golint)

• istio/istioctl/pkg/authz/analyzer.go
  • Line 15: warning: package comment should be of the form "Package authz ..." (golint)

• istio/pilot/pkg/model/telemetry.go
  • Line 167: warning: exported type TracingConfig should have comment or be unexported (golint)
  • Line 174: warning: exported type LoggingConfig should have comment or be unexported (golint)

• istio/operator/pkg/helm/renderer.go
  • Line 34: warning: exported const ChartsSubdirName should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: comment on exported function NewGenericRenderer should be of the form "NewGenericRenderer ..." (golint)
  • Line 85: warning: exported function GetFilesRecursive should have comment or be unexported (golint)
  • Line 139: warning: exported function LoadValues should have comment or be unexported (golint)
  • Line 171: warning: comment on exported function ListProfiles should be of the form "ListProfiles ..." (golint)

• istio/pilot/pkg/bootstrap/webhook.go
  • Line 27: warning: exported const HTTPSHandlerReadyPath should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/config/schema/schema.go
  • Line 103: warning: exported method Metadata.Equal should have comment or be unexported (golint)
  • Line 144: warning: exported method DirectTransformSettings.Equal should have comment or be unexported (golint)

• istio/pilot/pkg/model/status/helper.go
  • Line 23: warning: exported const StatusTrue should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported function GetConditionFromSpec should have comment or be unexported (golint)
  • Line 35: warning: exported function GetBoolConditionFromSpec should have comment or be unexported (golint)
  • Line 43: warning: exported function GetBoolCondition should have comment or be unexported (golint)
  • Line 57: warning: exported function GetCondition should have comment or be unexported (golint)
  • Line 66: warning: exported function UpdateConfigCondition should have comment or be unexported (golint)
  • Line 77: warning: exported function UpdateCondition should have comment or be unexported (golint)

• istio/pkg/test/framework/components/cluster/factory.go
  • Line 21: warning: exported type Factory should have comment or be unexported (golint)
  • Line 38: warning: exported function GetFactory should have comment or be unexported (golint)

• istio/operator/pkg/util/progress/progress.go
  • Line 29: warning: exported type InstallState should have comment or be unexported (golint)
  • Line 32: warning: exported const StateInstalling should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported function NewLog should have comment or be unexported (golint)
  • Line 140: warning: exported method Log.SetState should have comment or be unexported (golint)
  • Line 157: warning: exported method Log.NewComponent should have comment or be unexported (golint)
  • Line 167: warning: exported method Log.SetMessage should have comment or be unexported (golint)
  • Line 190: warning: exported method ManifestLog.ReportProgress should have comment or be unexported (golint)
  • Line 197: warning: exported method ManifestLog.ReportError should have comment or be unexported (golint)
  • Line 207: warning: exported method ManifestLog.ReportFinished should have comment or be unexported (golint)
  • Line 217: warning: exported method ManifestLog.ReportWaiting should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/util/hosts.go
  • Line 23: warning: exported type ScopedFqdn should have comment or be unexported (golint)

• istio/pkg/test/util/structpath/instance.go
  • Line 39: warning: exported type Instance should have comment or be unexported (golint)
  • Line 92: warning: exported method Instance.Select should have comment or be unexported (golint)
  • Line 120: warning: exported method Instance.Equals should have comment or be unexported (golint)
  • Line 146: warning: exported method Instance.ContainSubstring should have comment or be unexported (golint)
  • Line 210: warning: exported method Instance.Exists should have comment or be unexported (golint)
  • Line 224: warning: exported method Instance.NotExists should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/deployment/pod.go
  • Line 29: warning: exported type ApplicationUIDAnalyzer should have comment or be unexported (golint)
  • Line 34: warning: exported const UserID should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method ApplicationUIDAnalyzer.Metadata should have comment or be unexported (golint)
  • Line 48: warning: exported method ApplicationUIDAnalyzer.Analyze should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/sidecar/util.go
  • Line 1: warning: package comment should be of the form "Package sidecar ..." (golint)

• istio/pkg/cluster/id.go
  • Line 22: warning: exported method ID.Equals should have comment or be unexported (golint)

• istio/pkg/istio-agent/grpcxds/grpc_bootstrap.go
  • Line 35: warning: exported const ServerListenerNamePrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported type ChannelCreds should have comment or be unexported (golint)
  • Line 58: warning: exported type XdsServer should have comment or be unexported (golint)
  • Line 64: warning: exported type CertificateProvider should have comment or be unexported (golint)
  • Line 69: warning: exported method CertificateProvider.UnmarshalJSON should have comment or be unexported (golint)
  • Line 106: warning: exported const FileWatcherCertProviderName should have comment or be unexported (golint)
  • Line 108: warning: exported type FileWatcherCertProviderConfig should have comment or be unexported (golint)
  • Line 115: warning: exported method FileWatcherCertProviderConfig.FilePaths should have comment or be unexported (golint)
  • Line 149: warning: exported type GenerateBootstrapOptions should have comment or be unexported (golint)

• istio/pkg/test/framework/features/features.go
  • Line 28: warning: exported type Feature should have comment or be unexported (golint)
  • Line 39: warning: exported function BuildChecker should have comment or be unexported (golint)
  • Line 76: warning: exported var GlobalAllowlist should have comment or be unexported (golint)
  • Line 78: warning: exported type Allowlist should have comment or be unexported (golint)
  • Line 98: warning: exported method Allowlist.Contains should have comment or be unexported (golint)

• istio/pkg/test/framework/suitecontext.go
  • Line 33: warning: comment on exported type SuiteContext should be of the form "SuiteContext ..." (with optional leading article) (golint)
  • Line 205: warning: exported type Outcome should have comment or be unexported (golint)
  • Line 208: warning: exported const Passed should have comment (or a comment on this block) or be unexported (golint)
  • Line 214: warning: exported type TestOutcome should have comment or be unexported (golint)

• istio/security/pkg/server/ca/server.go
  • Line 163: warning: comment on exported function Authenticate should be of the form "Authenticate ..." (golint)

• istio/tools/bug-report/pkg/cluster/cluster.go
  • Line 34: warning: exported type ResourceType should have comment or be unexported (golint)
  • Line 37: warning: exported const Namespace should have comment (or a comment on this block) or be unexported (golint)

• istio/tests/fuzz/xds_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 30: warning: exported function FuzzXds should have comment or be unexported (golint)

• istio/operator/pkg/apis/istio/v1alpha1/validation/validation.go
  • Line 235: warning: exported function ValidateSubTypes should have comment or be unexported (golint)

• istio/operator/pkg/util/path.go
  • Line 75: warning: exported method Path.Equals should have comment or be unexported (golint)

• istio/pkg/config/mesh/networks_watcher.go
  • Line 36: warning: comment on exported type NetworksWatcher should be of the form "NetworksWatcher ..." (with optional leading article) (golint)
  • Line 45: warning: exported type InternalNetworkWatcher should have comment or be unexported (golint)
  • Line 114: warning: comment on exported method InternalNetworkWatcher.AddNetworksHandler should be of the form "AddNetworksHandler ..." (golint)

• istio/security/pkg/nodeagent/sds/sdsservice.go
  • Line 55: warning: exported function NewXdsServer should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/ingress/conversion.go
  • Line 42: warning: exported const IstioIngressController should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/loadbalancer/loadbalancer.go
  • Line 15: warning: package comment should be of the form "Package loadbalancer ..." (golint)
  • Line 31: warning: exported function GetLocalityLbSetting should have comment or be unexported (golint)
  • Line 60: warning: exported function ApplyLocalityLBSetting should have comment or be unexported (golint)

• istio/pkg/test/echo/common/model.go
  • Line 77: warning: exported var ServerFirstMagicString should have comment or be unexported (golint)

• istio/pilot/pkg/xds/debuggen.go
  • Line 49: warning: exported type ResponseCapture should have comment or be unexported (golint)
  • Line 55: warning: exported method ResponseCapture.Header should have comment or be unexported (golint)
  • Line 67: warning: exported method ResponseCapture.WriteHeader should have comment or be unexported (golint)
  • Line 71: warning: exported function NewResponseCapture should have comment or be unexported (golint)
  • Line 79: warning: exported function NewDebugGen should have comment or be unexported (golint)

• istio/pilot/pkg/xds/xdsgen.go
  • Line 159: warning: exported function ResourceSize should have comment or be unexported (golint)

• istio/pkg/util/protomarshal/protomarshal.go
  • Line 41: warning: exported function Unmarshal should have comment or be unexported (golint)
  • Line 45: warning: exported function UnmarshalAllowUnknown should have comment or be unexported (golint)

• istio/pkg/test/framework/components/cluster/config.go
  • Line 21: warning: exported type Kind should have comment or be unexported (golint)
  • Line 24: warning: exported const Kubernetes should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type Config should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/capture/run.go
  • Line 1: warning: package comment should be of the form "Package capture ..." (golint)
  • Line 36: warning: exported type Ops should have comment or be unexported (golint)
  • Line 54: warning: exported type IptablesConfigurator should have comment or be unexported (golint)
  • Line 61: warning: exported function NewIptablesConfigurator should have comment or be unexported (golint)
  • Line 69: warning: exported type NetworkRange should have comment or be unexported (golint)
  • Line 272: warning: exported function SplitV4V6 should have comment or be unexported (golint)
  • Line 284: warning: exported function ConfigureRoutes should have comment or be unexported (golint)
  • Line 389: warning: exported method IptablesConfigurator.Run should have comment or be unexported (golint)
  • Line 636: warning: exported type UDPRuleApplier should have comment or be unexported (golint)
  • Line 645: warning: exported method UDPRuleApplier.RunV4 should have comment or be unexported (golint)
  • Line 656: warning: exported method UDPRuleApplier.RunV6 should have comment or be unexported (golint)
  • Line 667: warning: exported method UDPRuleApplier.Run should have comment or be unexported (golint)
  • Line 672: warning: exported method UDPRuleApplier.WithChain should have comment or be unexported (golint)
  • Line 677: warning: exported method UDPRuleApplier.WithTable should have comment or be unexported (golint)

• istio/pilot/pkg/server/instance.go
  • Line 23: warning: exported type Component should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/route/route_cache.go
  • Line 53: warning: exported method Cache.Cacheable should have comment or be unexported (golint)
  • Line 76: warning: exported method Cache.DependentConfigs should have comment or be unexported (golint)
  • Line 95: warning: exported method Cache.DependentTypes should have comment or be unexported (golint)
  • Line 99: warning: exported method Cache.Key should have comment or be unexported (golint)

• istio/istioctl/cmd/kubeinject.go
  • Line 64: warning: exported type ExternalInjector should have comment or be unexported (golint)
  • Line 70: warning: exported method ExternalInjector.Inject should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/options/security.go
  • Line 36: warning: exported function NewSecurityOptions should have comment or be unexported (golint)
  • Line 80: warning: exported function SetupSecurityOptions should have comment or be unexported (golint)

• istio/pkg/bootstrap/platform/azure.go
  • Line 31: warning: exported const AzureMetadataEndpoint should have comment (or a comment on this block) or be unexported (golint)
  • Line 83: warning: exported function NewAzureWithPrefix should have comment or be unexported (golint)

• istio/tests/fuzz/mesh_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 22: warning: exported function FuzzParseMeshNetworks should have comment or be unexported (golint)
  • Line 27: warning: exported function FuzzValidateMeshConfig should have comment or be unexported (golint)

• istio/pkg/envoy/agent.go
  • Line 77: warning: exported type Agent should have comment or be unexported (golint)

• istio/tests/fuzz/inject_fuzzer.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 27: warning: exported function FuzzIntoResourceFile should have comment or be unexported (golint)

• istio/cni/pkg/taint/taintcontroller.go
  • Line 33: warning: exported type Controller should have comment or be unexported (golint)
  • Line 47: warning: exported function NewTaintSetterController should have comment or be unexported (golint)
  • Line 140: warning: comment on exported method Controller.Run should be of the form "Run ..." (golint)
  • Line 253: warning: exported method Controller.CheckNodeReadiness should have comment or be unexported (golint)
  • Line 311: warning: exported method Controller.ListAllNode should have comment or be unexported (golint)
  • Line 324: warning: exported method Controller.RegisterTaints should have comment or be unexported (golint)
  • Line 334: warning: comment on exported method Controller.ProcessNode should be of the form "ProcessNode ..." (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/k8sresourcelock/multilock.go
  • Line 28: warning: exported const UnknownLeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 107: warning: exported function ConcatRawRecord should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/fake.go
  • Line 43: warning: exported method FakeXdsUpdater.ConfigUpdate should have comment or be unexported (golint)
  • Line 56: warning: exported method FakeXdsUpdater.ProxyUpdate should have comment or be unexported (golint)
  • Line 82: warning: exported method FakeXdsUpdater.EDSUpdate should have comment or be unexported (golint)
  • Line 91: warning: exported method FakeXdsUpdater.EDSCacheUpdate should have comment or be unexported (golint)
  • Line 111: warning: exported method FakeXdsUpdater.Wait should have comment or be unexported (golint)
  • Line 115: warning: exported method FakeXdsUpdater.WaitForDuration should have comment or be unexported (golint)
  • Line 141: warning: exported type FakeControllerOptions should have comment or be unexported (golint)
  • Line 158: warning: exported type FakeController should have comment or be unexported (golint)
  • Line 162: warning: exported function NewFakeControllerWithOptions should have comment or be unexported (golint)

• istio/pilot/pkg/model/service.go
  • Line 113: warning: exported method Service.Key should have comment or be unexported (golint)
  • Line 253: warning: exported type WorkloadInstance should have comment or be unexported (golint)

• istio/pilot/pkg/xds/statusgen.go
  • Line 60: warning: exported function NewStatusGen should have comment or be unexported (golint)
  • Line 178: warning: exported method StatusGen.OnConnect should have comment or be unexported (golint)
  • Line 182: warning: exported method StatusGen.OnDisconnect should have comment or be unexported (golint)
  • Line 186: warning: exported method StatusGen.OnNack should have comment or be unexported (golint)

• istio/pkg/test/framework/components/istio/helm.go
  • Line 42: warning: exported const ReleasePrefix should have comment (or a comment on this block) or be unexported (golint)

• istio/tools/istio-iptables/pkg/log/nflog.go
  • Line 31: warning: exported var TraceLoggingEnabled should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/validation/validator.go
  • Line 32: warning: exported type ReturnCode should have comment or be unexported (golint)
  • Line 35: warning: exported const DONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported type Validator should have comment or be unexported (golint)
  • Line 42: warning: exported type Config should have comment or be unexported (golint)
  • Line 50: warning: exported type Service should have comment or be unexported (golint)
  • Line 54: warning: exported type Client should have comment or be unexported (golint)
  • Line 58: warning: exported method Validator.Run should have comment or be unexported (golint)
  • Line 103: warning: exported function NewValidator should have comment or be unexported (golint)
  • Line 162: warning: exported method Service.Run should have comment or be unexported (golint)
  • Line 188: warning: exported method Client.Run should have comment or be unexported (golint)

• istio/pilot/pkg/credentials/kube/secrets.go
  • Line 45: warning: comment on exported const GenericScrtCert should be of the form "GenericScrtCert ..." (golint)
  • Line 47: warning: comment on exported const GenericScrtKey should be of the form "GenericScrtKey ..." (golint)
  • Line 49: warning: comment on exported const GenericScrtCaCert should be of the form "GenericScrtCaCert ..." (golint)
  • Line 52: warning: comment on exported const TLSSecretCert should be of the form "TLSSecretCert ..." (golint)
  • Line 54: warning: comment on exported const TLSSecretKey should be of the form "TLSSecretKey ..." (golint)
  • Line 56: warning: comment on exported const TLSSecretCaCert should be of the form "TLSSecretCaCert ..." (golint)
  • Line 64: warning: exported type CredentialsController should have comment or be unexported (golint)
  • Line 83: warning: exported function NewCredentialsController should have comment or be unexported (golint)
  • Line 128: warning: error should be the last type when returning multiple items (golint)
  • Line 169: warning: exported method CredentialsController.Authorize should have comment or be unexported (golint)
  • Line 198: warning: exported method CredentialsController.GetKeyAndCert should have comment or be unexported (golint)
  • Line 207: warning: exported method CredentialsController.GetCaCert should have comment or be unexported (golint)
  • Line 293: warning: exported method CredentialsController.AddEventHandler should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/ingress/controller.go
  • Line 109: warning: comment on exported function V1Available should be of the form "V1Available ..." (golint)
  • Line 128: warning: comment on exported function NetworkingIngressAvailable should be of the form "NetworkingIngressAvailable ..." (golint)

• istio/pkg/jwt/jwt.go
  • Line 18: warning: exported const PolicyThirdParty should have comment (or a comment on this block) or be unexported (golint)

• istio/pilot/pkg/config/memory/store.go
  • Line 36: warning: exported const ResourceVersion should have comment or be unexported (golint)

• istio/pilot/pkg/xds/sds.go
  • Line 53: warning: exported method SecretResource.DependentConfigs should have comment or be unexported (golint)
  • Line 57: warning: exported method SecretResource.Cacheable should have comment or be unexported (golint)
  • Line 90: warning: exported method SecretGen.Generate should have comment or be unexported (golint)
  • Line 334: warning: exported type SecretGen should have comment or be unexported (golint)
  • Line 343: warning: exported function NewSecretGen should have comment or be unexported (golint)

• istio/galley/pkg/config/source/kube/rt/origin.go
  • Line 53: warning: exported method Origin.Comparator should have comment or be unexported (golint)
  • Line 72: warning: comment on exported method Origin.FieldMap should be of the form "FieldMap ..." (golint)

• istio/pilot/cmd/pilot-agent/config/config.go
  • Line 153: warning: exported function GetPilotSan should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/util/constants.go
  • Line 24: warning: exported const DefaultKubernetesDomain should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/istio-agent/metrics/metrics.go
  • Line 58: warning: exported var IstiodConnectionCancellations should have comment or be unexported (golint)
  • Line 65: warning: exported var Cancel should have comment or be unexported (golint)

• istio/pkg/test/framework/components/cluster/topology.go
  • Line 28: warning: exported function NewTopology should have comment or be unexported (golint)
  • Line 109: warning: exported method Topology.Kind should have comment or be unexported (golint)
  • Line 113: warning: exported method Topology.IsPrimary should have comment or be unexported (golint)
  • Line 117: warning: exported method Topology.IsConfig should have comment or be unexported (golint)
  • Line 121: warning: exported method Topology.IsRemote should have comment or be unexported (golint)
  • Line 125: warning: exported method Topology.IsExternalControlPlane should have comment or be unexported (golint)
  • Line 129: warning: exported method Topology.Primary should have comment or be unexported (golint)
  • Line 137: warning: exported method Topology.PrimaryName should have comment or be unexported (golint)
  • Line 141: warning: exported method Topology.Config should have comment or be unexported (golint)
  • Line 149: warning: exported method Topology.ConfigName should have comment or be unexported (golint)
  • Line 153: warning: exported method Topology.WithPrimary should have comment or be unexported (golint)
  • Line 159: warning: exported method Topology.WithConfig should have comment or be unexported (golint)
  • Line 165: warning: exported method Topology.MinKubeVersion should have comment or be unexported (golint)
  • Line 173: warning: exported method Topology.MaxKubeVersion should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/common/common.go
  • Line 28: warning: exported const ProxyContainerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: comment on exported const NamespaceAll should be of the form "NamespaceAll ..." (golint)
  • Line 124: warning: exported function LogAndPrintf should have comment or be unexported (golint)

• istio/galley/pkg/config/testing/data/collections.go
  • Line 27: warning: exported var Foo should have comment or be unexported (golint)

• istio/istioctl/pkg/writer/envoy/configdump/configdump.go
  • Line 119: warning: exported method ConfigWriter.PrintFullSummary should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/k8sresourcelock/endpointslock.go
  • Line 30: warning: exported type EndpointsLock should have comment or be unexported (golint)

• istio/pkg/bootstrap/config.go
  • Line 623: warning: exported function ReadPodAnnotations should have comment or be unexported (golint)

• istio/pilot/pkg/bootstrap/configcontroller.go
  • Line 43: warning: comment on exported type ConfigSourceAddressScheme should be of the form "ConfigSourceAddressScheme ..." (with optional leading article) (golint)
  • Line 47: warning: comment on exported const File should be of the form "File ..." (golint)
  • Line 51: warning: comment on exported const XDS should be of the form "XDS ..." (golint)
  • Line 54: warning: comment on exported const Kubernetes should be of the form "Kubernetes ..." (golint)

• istio/pkg/kube/adapter.go
  • Line 33: warning: comment on exported const Create should be of the form "Create ..." (golint)
  • Line 35: warning: exported const Update should have comment (or a comment on this block) or be unexported (golint)
  • Line 162: warning: exported function AdmissionReviewKubeToAdapter should have comment or be unexported (golint)
  • Line 241: warning: exported function AdmissionReviewAdapterToKube should have comment or be unexported (golint)

• istio/pkg/kube/mock_client.go
  • Line 49: warning: exported type MockPortForwarder should have comment or be unexported (golint)
  • Line 51: warning: exported method MockPortForwarder.Start should have comment or be unexported (golint)
  • Line 55: warning: exported method MockPortForwarder.Address should have comment or be unexported (golint)
  • Line 59: warning: exported method MockPortForwarder.Close should have comment or be unexported (golint)
  • Line 62: warning: exported method MockPortForwarder.WaitForStop should have comment or be unexported (golint)
  • Line 80: warning: exported method MockClient.Istio should have comment or be unexported (golint)
  • Line 84: warning: exported method MockClient.GatewayAPI should have comment or be unexported (golint)
  • Line 88: warning: exported method MockClient.MCSApis should have comment or be unexported (golint)
  • Line 92: warning: exported method MockClient.IstioInformer should have comment or be unexported (golint)
  • Line 96: warning: exported method MockClient.GatewayAPIInformer should have comment or be unexported (golint)
  • Line 100: warning: exported method MockClient.MCSApisInformer should have comment or be unexported (golint)
  • Line 104: warning: exported method MockClient.Metadata should have comment or be unexported (golint)
  • Line 108: warning: exported method MockClient.KubeInformer should have comment or be unexported (golint)
  • Line 112: warning: exported method MockClient.DynamicInformer should have comment or be unexported (golint)
  • Line 116: warning: exported method MockClient.MetadataInformer should have comment or be unexported (golint)
  • Line 120: warning: exported method MockClient.RunAndWait should have comment or be unexported (golint)
  • Line 124: warning: exported method MockClient.Kube should have comment or be unexported (golint)
  • Line 128: warning: exported method MockClient.DynamicClient should have comment or be unexported (golint)
  • Line 132: warning: exported method MockClient.MetadataClient should have comment or be unexported (golint)
  • Line 136: warning: exported method MockClient.AllDiscoveryDo should have comment or be unexported (golint)
  • Line 140: warning: exported method MockClient.EnvoyDo should have comment or be unexported (golint)
  • Line 148: warning: exported method MockClient.RESTConfig should have comment or be unexported (golint)
  • Line 152: warning: exported method MockClient.GetIstioVersions should have comment or be unexported (golint)
  • Line 156: warning: exported method MockClient.PodsForSelector should have comment or be unexported (golint)
  • Line 174: warning: exported method MockClient.Revision should have comment or be unexported (golint)
  • Line 178: warning: exported method MockClient.REST should have comment or be unexported (golint)
  • Line 182: warning: exported method MockClient.ApplyYAMLFiles should have comment or be unexported (golint)
  • Line 186: warning: exported method MockClient.ApplyYAMLFilesDryRun should have comment or be unexported (golint)
  • Line 196: warning: exported method MockClient.DeleteYAMLFiles should have comment or be unexported (golint)
  • Line 200: warning: exported method MockClient.DeleteYAMLFilesDryRun should have comment or be unexported (golint)
  • Line 204: warning: exported method MockClient.Ext should have comment or be unexported (golint)
  • Line 208: warning: exported method MockClient.Dynamic should have comment or be unexported (golint)
  • Line 212: warning: exported method MockClient.GetKubernetesVersion should have comment or be unexported (golint)
  • Line 223: warning: exported method MockClient.GetIstioPods should have comment or be unexported (golint)
  • Line 227: warning: exported method MockClient.PodExecCommands should have comment or be unexported (golint)
  • Line 231: warning: exported method MockClient.PodExec should have comment or be unexported (golint)
  • Line 235: warning: exported method MockClient.PodLogs should have comment or be unexported (golint)
  • Line 239: warning: exported method MockClient.NewPortForwarder should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/filter/discoverynamespaces.go
  • Line 53: warning: exported function NewDiscoveryNamespacesFilter should have comment or be unexported (golint)

• istio/pilot/pkg/networking/core/v1alpha3/configgen.go
  • Line 23: warning: exported type ConfigGeneratorImpl should have comment or be unexported (golint)
  • Line 29: warning: exported function NewConfigGenerator should have comment or be unexported (golint)
  • Line 36: warning: comment on exported method ConfigGeneratorImpl.MeshConfigChanged should be of the form "MeshConfigChanged ..." (golint)

• istio/pilot/pkg/networking/core/v1alpha3/listener_address.go
  • Line 34: warning: comment on exported const InboundPassthroughBindIpv4 should be of the form "InboundPassthroughBindIpv4 ..." (golint)
  • Line 36: warning: exported const InboundPassthroughBindIpv6 should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/components/echo/common/envoy.go
  • Line 45: warning: exported function WaitForConfig should have comment or be unexported (golint)

• istio/pkg/wasm/imagefetcher.go
  • Line 40: warning: exported type ImageFetcherOption should have comment or be unexported (golint)
  • Line 50: warning: exported type ImageFetcher should have comment or be unexported (golint)
  • Line 54: warning: exported function NewImageFetcher should have comment or be unexported (golint)

• istio/tools/istio-clean-iptables/pkg/cmd/root.go
  • Line 135: warning: exported function GetCommand should have comment or be unexported (golint)
  • Line 139: warning: exported function Execute should have comment or be unexported (golint)

• istio/security/pkg/monitoring/monitoring.go
  • Line 23: warning: exported const TokenExchange should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported var NumOutgoingRetries should have comment or be unexported (golint)
  • Line 38: warning: exported function Reset should have comment or be unexported (golint)

• istio/istioctl/pkg/tag/util.go
  • Line 31: warning: exported function GetTagWebhooks should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/util/match/match.go
  • Line 24: warning: exported function MatchesMap should have comment or be unexported (golint)
  • Line 44: warning: exported function MatchesGlobs should have comment or be unexported (golint)
  • Line 63: warning: exported function MatchesGlob should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/k8sresourcelock/interface.go
  • Line 33: warning: exported const LeaderElectionRecordAnnotationKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 107: warning: comment on exported function New should be of the form "New ..." (golint)

• istio/pilot/pkg/xds/eds.go
  • Line 382: warning: exported method EdsGenerator.Generate should have comment or be unexported (golint)

• istio/tests/fuzz/fuzz.go
  • Line 15: warning: package comment should be of the form "Package fuzz ..." (golint)
  • Line 23: warning: exported function FuzzParseInputs should have comment or be unexported (golint)
  • Line 31: warning: exported function FuzzParseAndBuildSchema should have comment or be unexported (golint)

• istio/cni/pkg/config/config.go
  • Line 22: warning: exported type Config should have comment or be unexported (golint)

• istio/pilot/pkg/model/kstatus/helper.go
  • Line 26: warning: exported const StatusTrue should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported function Wrap should have comment or be unexported (golint)
  • Line 56: warning: exported method WrappedStatus.Mutate should have comment or be unexported (golint)
  • Line 73: warning: exported var EmptyCondition should have comment or be unexported (golint)
  • Line 75: warning: exported function GetCondition should have comment or be unexported (golint)

• istio/pkg/config/schema/gvk/resources.gen.go
  • Line 12: warning: exported var AuthorizationPolicy should have comment or be unexported (golint)

• istio/pkg/kube/inject/inject.go
  • Line 103: warning: exported type Template should have comment or be unexported (golint)
  • Line 104: warning: exported type Templates should have comment or be unexported (golint)
  • Line 107: warning: exported type Injector should have comment or be unexported (golint)
  • Line 146: warning: exported const SidecarTemplateName should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/adsc/adsc.go
  • Line 132: warning: exported function DefaultGrpcDialOptions should have comment or be unexported (golint)
  • Line 223: warning: exported type ResponseHandler should have comment or be unexported (golint)
  • Line 245: warning: exported function NewWithBackoffPolicy should have comment or be unexported (golint)
  • Line 903: warning: comment on exported method ADSC.Send should be of the form "Send ..." (golint)
  • Line 1100: warning: exported function XdsInitialRequests should have comment or be unexported (golint)
  • Line 1118: warning: exported function ConfigInitialRequests should have comment or be unexported (golint)

• istio/pilot/pkg/model/push_context.go
  • Line 309: warning: exported function NewShardKey should have comment or be unexported (golint)
  • Line 321: warning: exported method ShardKey.Cluster should have comment or be unexported (golint)
  • Line 363: warning: exported type TriggerReason should have comment or be unexported (golint)
  • Line 473: warning: exported method PushRequest.PushReason should have comment or be unexported (golint)
  • Line 1997: warning: exported function NewGatewayContext should have comment or be unexported (golint)
  • Line 2083: warning: exported method PushContext.NetworkManager should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/options/agent.go
  • Line 32: warning: exported function NewAgentOptions should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/echotypes/types.go
  • Line 15: warning: package comment should be of the form "Package echotypes ..." (golint)
  • Line 22: warning: exported const Proxyless should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/test/framework/errors/deprecations.go
  • Line 25: warning: exported type DeprecatedError should have comment or be unexported (golint)
  • Line 29: warning: exported function NewDeprecatedError should have comment or be unexported (golint)
  • Line 33: warning: exported function IsDeprecatedError should have comment or be unexported (golint)
  • Line 38: warning: exported function IsOrContainsDeprecatedError should have comment or be unexported (golint)

• istio/pkg/kube/inject/webhook.go
  • Line 57: warning: exported var URLParameterToEnv should have comment or be unexported (golint)
  • Line 182: warning: exported type ContainerReorder should have comment or be unexported (golint)
  • Line 185: warning: exported const MoveFirst should have comment (or a comment on this block) or be unexported (golint)
  • Line 235: warning: exported function ExtractCanonicalServiceLabels should have comment or be unexported (golint)
  • Line 275: warning: exported type InjectionParameters should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/builder/iptables_builder_impl.go
  • Line 45: warning: comment on exported function NewIptablesBuilder should be of the form "NewIptablesBuilder ..." (golint)
  • Line 59: warning: exported method IptablesBuilder.InsertRule should have comment or be unexported (golint)
  • Line 89: warning: exported method IptablesBuilder.InsertRuleV4 should have comment or be unexported (golint)
  • Line 93: warning: exported method IptablesBuilder.InsertRuleV6 should have comment or be unexported (golint)
  • Line 132: warning: exported method IptablesBuilder.AppendRuleV4 should have comment or be unexported (golint)
  • Line 136: warning: exported method IptablesBuilder.AppendRule should have comment or be unexported (golint)
  • Line 142: warning: exported method IptablesBuilder.AppendRuleV6 should have comment or be unexported (golint)
  • Line 171: warning: exported method IptablesBuilder.BuildV4 should have comment or be unexported (golint)
  • Line 175: warning: exported method IptablesBuilder.BuildV6 should have comment or be unexported (golint)
  • Line 219: warning: exported method IptablesBuilder.BuildV4Restore should have comment or be unexported (golint)
  • Line 223: warning: exported method IptablesBuilder.BuildV6Restore should have comment or be unexported (golint)

• istio/pilot/pkg/xds/filters/filters.go
  • Line 42: warning: exported const OriginalSrcFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: comment on exported const AlpnFilterName should be of the form "AlpnFilterName ..." (golint)
  • Line 155: warning: exported function BuildRouterFilter should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/endpoint_builder.go
  • Line 49: warning: exported function NewEndpointBuilder should have comment or be unexported (golint)
  • Line 85: warning: exported function NewEndpointBuilderFromMetadata should have comment or be unexported (golint)

• istio/pilot/pkg/model/addressmap.go
  • Line 33: warning: exported method AddressMap.IsEmpty should have comment or be unexported (golint)
  • Line 43: warning: exported method AddressMap.DeepCopy should have comment or be unexported (golint)
  • Line 80: warning: exported method AddressMap.GetAddressesFor should have comment or be unexported (golint)
  • Line 96: warning: exported method AddressMap.SetAddressesFor should have comment or be unexported (golint)
  • Line 120: warning: exported method AddressMap.AddAddressesFor should have comment or be unexported (golint)
  • Line 137: warning: exported method AddressMap.ForEach should have comment or be unexported (golint)

• istio/pkg/kube/multicluster/secretcontroller.go
  • Line 49: warning: exported const MultiClusterSecretLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported type ClusterHandler should have comment or be unexported (golint)
  • Line 122: warning: exported method Controller.AddHandler should have comment or be unexported (golint)
  • Line 134: warning: exported method Cluster.HasSynced should have comment or be unexported (golint)
  • Line 138: warning: exported method Cluster.SyncDidTimeout should have comment or be unexported (golint)
  • Line 156: warning: exported method ClusterStore.Store should have comment or be unexported (golint)
  • Line 165: warning: exported method ClusterStore.Get should have comment or be unexported (golint)
  • Line 174: warning: exported method ClusterStore.GetByID should have comment or be unexported (golint)
  • Line 215: warning: exported method ClusterStore.Len should have comment or be unexported (golint)
  • Line 354: warning: exported method Controller.HasSynced should have comment or be unexported (golint)
  • Line 592: warning: exported method Controller.GetRemoteKubeClient should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/content/content.go
  • Line 53: warning: exported method Params.SetClient should have comment or be unexported (golint)
  • Line 59: warning: exported method Params.SetDryRun should have comment or be unexported (golint)
  • Line 65: warning: exported method Params.SetVerbose should have comment or be unexported (golint)
  • Line 71: warning: exported method Params.SetNamespace should have comment or be unexported (golint)
  • Line 77: warning: exported method Params.SetIstioNamespace should have comment or be unexported (golint)
  • Line 83: warning: exported method Params.SetPod should have comment or be unexported (golint)
  • Line 89: warning: exported method Params.SetContainer should have comment or be unexported (golint)

• istio/galley/pkg/config/analysis/analyzers/destinationrule/ca-certificates.go
  • Line 34: warning: exported method CaCertificateAnalyzer.Metadata should have comment or be unexported (golint)
  • Line 44: warning: exported method CaCertificateAnalyzer.Analyze should have comment or be unexported (golint)

• istio/pkg/config/labels/instance.go
  • Line 27: warning: exported const DNS1123LabelMaxLength should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/config/mesh/mesh.go
  • Line 263: warning: exported function DeepCopyMeshConfig should have comment or be unexported (golint)

• istio/pkg/test/echo/client/parsedresponse.go
  • Line 41: warning: exported var URLFieldRegex should have comment or be unexported (golint)
  • Line 113: warning: exported method ParsedResponses.Check should have comment or be unexported (golint)
  • Line 126: warning: exported method ParsedResponses.CheckOrFail should have comment or be unexported (golint)
  • Line 134: warning: exported method ParsedResponses.CheckOK should have comment or be unexported (golint)
  • Line 143: warning: exported method ParsedResponses.CheckOKOrFail should have comment or be unexported (golint)
  • Line 151: warning: exported method ParsedResponses.CheckCode should have comment or be unexported (golint)
  • Line 160: warning: exported method ParsedResponses.CheckCodeOrFail should have comment or be unexported (golint)
  • Line 168: warning: exported method ParsedResponses.CheckHost should have comment or be unexported (golint)
  • Line 177: warning: exported method ParsedResponses.CheckHostOrFail should have comment or be unexported (golint)
  • Line 204: warning: exported method ParsedResponses.CheckPort should have comment or be unexported (golint)
  • Line 214: warning: exported method ParsedResponses.CheckPortOrFail should have comment or be unexported (golint)
  • Line 274: warning: exported method ParsedResponses.CheckKey should have comment or be unexported (golint)
  • Line 283: warning: exported method ParsedResponses.CheckCluster should have comment or be unexported (golint)
  • Line 292: warning: exported method ParsedResponses.CheckClusterOrFail should have comment or be unexported (golint)
  • Line 300: warning: exported method ParsedResponses.CheckIP should have comment or be unexported (golint)
  • Line 309: warning: exported method ParsedResponses.CheckIPOrFail should have comment or be unexported (golint)
  • Line 365: warning: exported function ParseForwardedResponse should have comment or be unexported (golint)

• istio/pilot/pkg/serviceregistry/kube/controller/pod.go
  • Line 88: warning: exported function GetPodReadyCondition should have comment or be unexported (golint)
  • Line 93: warning: exported function GetPodCondition should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/echotest/run.go
  • Line 128: warning: exported method T.RunViaIngress should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/caclient/providers/google-cas/client.go
  • Line 34: warning: comment on exported type GoogleCASClient should be of the form "GoogleCASClient ..." (with optional leading article) (golint)
  • Line 98: warning: comment on exported method GoogleCASClient.CSRSign should be of the form "CSRSign ..." (golint)
  • Line 118: warning: comment on exported method GoogleCASClient.GetRootCertBundle should be of the form "GetRootCertBundle ..." (golint)
  • Line 148: warning: exported method GoogleCASClient.Close should have comment or be unexported (golint)

• istio/pilot/pkg/config/memory/monitor.go
  • Line 58: warning: comment on exported function NewSyncMonitor should be of the form "NewSyncMonitor ..." (golint)

• istio/pilot/test/mock/config.go
  • Line 56: warning: exported var ExampleServiceEntry should have comment or be unexported (golint)

• istio/istioctl/cmd/istiodconfig.go
  • Line 182: warning: exported type ScopeInfo should have comment or be unexported (golint)
  • Line 190: warning: exported type ScopeLevelPair should have comment or be unexported (golint)
  • Line 263: warning: exported type ControlzClient should have comment or be unexported (golint)
  • Line 268: warning: exported method ControlzClient.GetScopes should have comment or be unexported (golint)
  • Line 286: warning: exported method ControlzClient.PutScope should have comment or be unexported (golint)
  • Line 310: warning: exported method ControlzClient.PutScopes should have comment or be unexported (golint)
  • Line 337: warning: exported method ControlzClient.GetScope should have comment or be unexported (golint)

• istio/pilot/pkg/extensionproviders/cluster_lookup.go
  • Line 25: warning: exported function LookupCluster should have comment or be unexported (golint)

• istio/pkg/config/host/name.go
  • Line 88: warning: exported method Name.IsWildCarded should have comment or be unexported (golint)

• istio/pkg/mcp/internal/queue.go
  • Line 175: warning: exported method UniqueQueue.Ready should have comment or be unexported (golint)
  • Line 179: warning: exported method UniqueQueue.Done should have comment or be unexported (golint)
  • Line 183: warning: exported method UniqueQueue.Close should have comment or be unexported (golint)

• istio/pkg/istio-agent/health/health_probers.go
  • Line 37: warning: exported type Prober should have comment or be unexported (golint)
  • Line 45: warning: exported type ProbeResult should have comment or be unexported (golint)
  • Line 48: warning: exported const Healthy should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported method ProbeResult.IsHealthy should have comment or be unexported (golint)
  • Line 57: warning: exported type HTTPProber should have comment or be unexported (golint)
  • Line 64: warning: exported function NewHTTPProber should have comment or be unexported (golint)
  • Line 90: warning: comment on exported method HTTPProber.Probe should be of the form "Probe ..." (golint)
  • Line 146: warning: exported type TCPProber should have comment or be unexported (golint)
  • Line 152: warning: exported method TCPProber.Probe should have comment or be unexported (golint)
  • Line 165: warning: exported type ExecProber should have comment or be unexported (golint)
  • Line 171: warning: exported method ExecProber.Probe should have comment or be unexported (golint)
  • Line 186: warning: exported type EnvoyProber should have comment or be unexported (golint)
  • Line 192: warning: exported method EnvoyProber.Probe should have comment or be unexported (golint)
  • Line 199: warning: exported type AggregateProber should have comment or be unexported (golint)
  • Line 205: warning: exported method AggregateProber.Probe should have comment or be unexported (golint)

• istio/operator/pkg/util/yaml.go
  • Line 148: warning: exported function YAMLDiff should have comment or be unexported (golint)

• istio/pilot/pkg/model/test/mockopenidserver.go
  • Line 51: warning: exported const JwtPubKeyNoKid should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/config/xds/xds.go
  • Line 36: warning: comment on exported function BuildXDSObjectFromStruct should be of the form "BuildXDSObjectFromStruct ..." (golint)
  • Line 74: warning: exported function GogoStructToMessage should have comment or be unexported (golint)

• istio/pkg/test/framework/components/stackdriver/stackdriver.go
  • Line 39: warning: exported type Config should have comment or be unexported (golint)
  • Line 63: warning: exported function UseRealStackdriver should have comment or be unexported (golint)

• istio/tests/util/sanitycheck/sanity_check.go
  • Line 34: warning: exported function SetupTrafficTest should have comment or be unexported (golint)
  • Line 63: warning: exported function RunTrafficTestClientServer should have comment or be unexported (golint)

• istio/pilot/pkg/config/kube/gateway/controller.go
  • Line 86: warning: exported function NewController should have comment or be unexported (golint)
  • Line 126: warning: exported method Controller.Schemas should have comment or be unexported (golint)
  • Line 133: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 137: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 154: warning: exported method Controller.SetStatusWrite should have comment or be unexported (golint)
  • Line 230: warning: exported method Controller.QueueStatusUpdates should have comment or be unexported (golint)
  • Line 251: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 255: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 259: warning: exported method Controller.UpdateStatus should have comment or be unexported (golint)
  • Line 263: warning: exported method Controller.Patch should have comment or be unexported (golint)
  • Line 267: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 271: warning: exported method Controller.RegisterEventHandler should have comment or be unexported (golint)
  • Line 279: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 283: warning: exported method Controller.SetWatchErrorHandler should have comment or be unexported (golint)
  • Line 287: warning: exported method Controller.HasSynced should have comment or be unexported (golint)
  • Line 291: warning: exported method Controller.SecretAllowed should have comment or be unexported (golint)

• istio/pilot/pkg/model/envoyfilter.go
  • Line 168: warning: comment on exported method EnvoyFilterWrapper.Keys should be of the form "Keys ..." (golint)
  • Line 182: warning: exported method EnvoyFilterConfigPatchWrapper.Key should have comment or be unexported (golint)

• istio/pkg/util/identifier/util.go
  • Line 17: warning: exported const Undefined should have comment or be unexported (golint)
  • Line 19: warning: exported function IsSameOrEmpty should have comment or be unexported (golint)

• istio/pilot/pkg/xds/deltaadstest.go
  • Line 33: warning: exported function NewDeltaAdsTest should have comment or be unexported (golint)
  • Line 41: warning: exported function NewDeltaXdsTest should have comment or be unexported (golint)
  • Line 68: warning: exported type DeltaAdsTest should have comment or be unexported (golint)
  • Line 85: warning: exported method DeltaAdsTest.Cleanup should have comment or be unexported (golint)
  • Line 190: warning: exported method DeltaAdsTest.Request should have comment or be unexported (golint)
  • Line 229: warning: exported method DeltaAdsTest.WithID should have comment or be unexported (golint)
  • Line 234: warning: exported method DeltaAdsTest.WithType should have comment or be unexported (golint)
  • Line 239: warning: exported method DeltaAdsTest.WithMetadata should have comment or be unexported (golint)
  • Line 244: warning: exported method DeltaAdsTest.WithTimeout should have comment or be unexported (golint)

• istio/pkg/test/framework/features/features.gen.go
  • Line 20: warning: exported const Observability should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: don't use underscores in Go names; const Security_Certificates_Citadel should be SecurityCertificatesCitadel (golint)
  • Line 22: warning: don't use underscores in Go names; const Security_Certificates_LetsEncrypt should be SecurityCertificatesLetsEncrypt (golint)
  • Line 23: warning: don't use underscores in Go names; const Security_Certificates_Spire should be SecurityCertificatesSpire (golint)
  • Line 24: warning: don't use underscores in Go names; const Security_MTLS_OnByDefault should be SecurityMTLSOnByDefault (golint)
  • Line 25: warning: don't use underscores in Go names; const Traffic_CircuitBreakers_FailGracefully should be TrafficCircuitBreakersFailGracefully (golint)
  • Line 26: warning: don't use underscores in Go names; const Usability_Introspection_Status_Analysis_ContainsMessageWhenFalse should be UsabilityIntrospectionStatusAnalysisContainsMessageWhenFalse (golint)
  • Line 27: warning: don't use underscores in Go names; const Usability_Introspection_Status_Analysis_TrueWhenWarnOnly should be UsabilityIntrospectionStatusAnalysisTrueWhenWarnOnly (golint)
  • Line 28: warning: don't use underscores in Go names; const Usability_Introspection_Status_Distribution_EventuallyTrue should be UsabilityIntrospectionStatusDistributionEventuallyTrue (golint)
  • Line 29: warning: don't use underscores in Go names; const Usability_Introspection_Status_Distribution_ImmediatelyFalse should be UsabilityIntrospectionStatusDistributionImmediatelyFalse (golint)
  • Line 30: warning: don't use underscores in Go names; const Usability_Observability_Status should be UsabilityObservabilityStatus (golint)
  • Line 31: warning: don't use underscores in Go names; const Usability_Observability_Status_DefaultExists should be UsabilityObservabilityStatusDefaultExists (golint)

• istio/security/pkg/k8s/chiron/utils.go
  • Line 45: warning: comment on exported const RequestLifeTimeAnnotationForCertManager should be of the form "RequestLifeTimeAnnotationForCertManager ..." (golint)
  • Line 49: warning: exported type CsrNameGenerator should have comment or be unexported (golint)

• istio/tools/istio-iptables/pkg/config/config.go
  • Line 27: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 71: warning: exported method Config.Print should have comment or be unexported (golint)

• istio/cni/pkg/taint/taint.go
  • Line 33: warning: exported const TaintName should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type ConfigSettings should have comment or be unexported (golint)
  • Line 46: warning: exported type Options should have comment or be unexported (golint)
  • Line 51: warning: exported type Setter should have comment or be unexported (golint)
  • Line 57: warning: exported method Setter.Configs should have comment or be unexported (golint)
  • Line 61: warning: exported function NewTaintSetter should have comment or be unexported (golint)
  • Line 74: warning: comment on exported method Setter.LoadConfig should be of the form "LoadConfig ..." (golint)
  • Line 112: warning: comment on exported method Setter.HasReadinessTaint should be of the form "HasReadinessTaint ..." (golint)
  • Line 125: warning: comment on exported method Setter.RemoveReadinessTaint should be of the form "RemoveReadinessTaint ..." (golint)
  • Line 139: warning: comment on exported method Setter.AddReadinessTaint should be of the form "AddReadinessTaint ..." (golint)
  • Line 175: warning: comment on exported function GetNodeLatestReadiness should be of the form "GetNodeLatestReadiness ..." (golint)

• istio/operator/pkg/util/util.go
  • Line 27: warning: exported type FileFilter should have comment or be unexported (golint)

• istio/pkg/config/kube/conversion.go
  • Line 26: warning: exported const SMTP should have comment (or a comment on this block) or be unexported (golint)

• istio/pkg/file/file.go
  • Line 23: warning: comment on exported function AtomicCopy should be of the form "AtomicCopy ..." (golint)
  • Line 38: warning: exported function Copy should have comment or be unexported (golint)
  • Line 52: warning: comment on exported function AtomicWrite should be of the form "AtomicWrite ..." (golint)
  • Line 89: warning: exported function Exists should have comment or be unexported (golint)

• istio/istioctl/pkg/util/configdump/secret.go
  • Line 26: warning: comment on exported method Wrapper.GetSecretConfigDump should be of the form "GetSecretConfigDump ..." (golint)

• istio/galley/pkg/config/analysis/analyzers/sidecar/defaultselector.go
  • Line 1: warning: package comment should be of the form "Package sidecar ..." (golint)

• istio/pilot/pkg/xds/filters/context.go
  • Line 17: warning: exported type RouterFilterContext should have comment or be unexported (golint)

• istio/pilot/test/xdstest/extract.go
  • Line 42: warning: exported function ExtractRoutesFromListeners should have comment or be unexported (golint)
  • Line 122: warning: exported function ExtractListenerNames should have comment or be unexported (golint)
  • Line 130: warning: exported function ExtractListener should have comment or be unexported (golint)
  • Line 139: warning: exported function ExtractRouteConfigurations should have comment or be unexported (golint)
  • Line 147: warning: exported function ExtractListenerFilters should have comment or be unexported (golint)
  • Line 155: warning: exported function ExtractTCPProxy should have comment or be unexported (golint)
  • Line 170: warning: exported function ExtractHTTPConnectionManager should have comment or be unexported (golint)
  • Line 185: warning: exported function ExtractLoadAssignments should have comment or be unexported (golint)
  • Line 196: warning: exported function ExtractEndpoints should have comment or be unexported (golint)
  • Line 213: warning: exported function ExtractClusters should have comment or be unexported (golint)
  • Line 221: warning: exported function ExtractCluster should have comment or be unexported (golint)
  • Line 225: warning: exported function ExtractClusterEndpoints should have comment or be unexported (golint)
  • Line 233: warning: exported function ExtractEdsClusterNames should have comment or be unexported (golint)
  • Line 247: warning: exported function ExtractTLSSecrets should have comment or be unexported (golint)
  • Line 259: warning: exported function UnmarshalRouteConfiguration should have comment or be unexported (golint)
  • Line 271: warning: exported function UnmarshalClusterLoadAssignment should have comment or be unexported (golint)
  • Line 283: warning: exported function FilterClusters should have comment or be unexported (golint)
  • Line 293: warning: exported function ToDiscoveryResponse should have comment or be unexported (golint)
  • Line 308: warning: exported function InterfaceSlice should have comment or be unexported (golint)
  • Line 336: warning: exported function Dump should have comment or be unexported (golint)
  • Line 348: warning: exported function MapKeys should have comment or be unexported (golint)

• istio/security/pkg/nodeagent/test/mock/caserver.go
  • Line 57: warning: exported function NewCAServerWithKeyCert should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/kubectlcmd/kubectlcmd.go
  • Line 56: warning: exported function ReportRunningTasks should have comment or be unexported (golint)

• istio/galley/pkg/config/util/kubeyaml/kubeyaml.go
  • Line 75: warning: exported type Reader should have comment or be unexported (golint)
  • Line 86: warning: exported function NewYAMLReader should have comment or be unexported (golint)
  • Line 136: warning: exported type LineReader should have comment or be unexported (golint)

• istio/pilot/cmd/pilot-agent/options/options.go
  • Line 28: warning: exported var InstanceIPVar should have comment or be unexported (golint)

• istio/pilot/pkg/leaderelection/k8sleaderelection/k8sresourcelock/configmaplock.go
  • Line 35: warning: exported type ConfigMapLock should have comment or be unexported (golint)
  • Line 124: warning: comment on exported method ConfigMapLock.Key should be of the form "Key ..." (golint)

• istio/pilot/pkg/xds/simple.go
  • Line 1: warning: package comment should be of the form "Package xds ..." (golint)
  • Line 33: warning: comment on exported type SimpleServer should be of the form "SimpleServer ..." (with optional leading article) (golint)
  • Line 64: warning: comment on exported function NewXDS should be of the form "NewXDS ..." (golint)
  • Line 136: warning: exported method SimpleServer.StartGRPC should have comment or be unexported (golint)

• istio/pkg/test/framework/tools/featuresgen/cmd/root.go
  • Line 30: warning: exported const Copyright should have comment (or a comment on this block) or be unexported (golint)
  • Line 83: warning: exported function Execute should have comment or be unexported (golint)

• istio/pkg/test/framework/components/cluster/clusterboot/factory.go
  • Line 35: warning: exported function NewFactory should have comment or be unexported (golint)

• istio/pkg/uds/listener.go
  • Line 26: warning: exported function NewListener should have comment or be unexported (golint)

• istio/istioctl/cmd/analyze.go
  • Line 53: warning: exported const FileParseString should have comment or be unexported (golint)
  • Line 425: warning: exported function AnalyzersAsString should have comment or be unexported (golint)

• istio/tools/bug-report/pkg/bugreport/bugreport.go
  • Line 471: warning: exported function BuildClientsFromConfig should have comment or be unexported (golint)

• istio/pilot/pkg/trustbundle/trustbundle.go
  • Line 34: warning: exported type TrustAnchorConfig should have comment or be unexported (golint)
  • Line 38: warning: exported type TrustAnchorUpdate should have comment or be unexported (golint)
  • Line 43: warning: exported type TrustBundle should have comment or be unexported (golint)
  • Line 60: warning: exported const SourceIstioCA should have comment (or a comment on this block) or be unexported (golint)
  • Line 106: warning: exported method TrustBundle.UpdateCb should have comment or be unexported (golint)
  • Line 269: warning: exported method TrustBundle.ProcessRemoteTrustAnchors should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/util/traffic/result.go
  • Line 59: warning: exported method Result.PercentSuccess should have comment or be unexported (golint)

• istio/pkg/test/framework/components/echo/common/defaults.go
  • Line 22: warning: exported var EchoPorts should have comment or be unexported (golint)
  • Line 37: warning: exported var WorkloadPorts should have comment or be unexported (golint)

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• istio/security/pkg/stsservice/tokenmanager/google/tokenexchangeplugin_test.go
  • Line 160: warning: cyclomatic complexity 17 of function TestTokenExchangePluginWithCache() is high (> 15) (gocyclo)

• istio/tests/fuzz/analyzer_fuzzer.go
  • Line 96: warning: cyclomatic complexity 16 of function FuzzAnalyzer() is high (> 15) (gocyclo)

• istio/tests/integration/pilot/common/routing.go
  • Line 129: warning: cyclomatic complexity 18 of function virtualServiceCases() is high (> 15) (gocyclo)
  • Line 2156: warning: cyclomatic complexity 16 of function DNSTestCases() is high (> 15) (gocyclo)

• istio/istioctl/pkg/tag/generate.go
  • Line 74: warning: cyclomatic complexity 19 of function Generate() is high (> 15) (gocyclo)

• istio/pkg/test/echo/client/parsedresponse.go
  • Line 374: warning: cyclomatic complexity 16 of function parseResponse() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/conversion.go
  • Line 56: warning: cyclomatic complexity 20 of function ConvertService() is high (> 15) (gocyclo)

• istio/pilot/pkg/trustbundle/trustbundle_test.go
  • Line 158: warning: cyclomatic complexity 20 of function TestUpdateTrustAnchor() is high (> 15) (gocyclo)

• istio/pilot/test/mock/config.go
  • Line 131: warning: cyclomatic complexity 31 of function CheckMapInvariant() is high (> 15) (gocyclo)
  • Line 358: warning: cyclomatic complexity 16 of function CheckCacheFreshness() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/cluster_builder_test.go
  • Line 1527: warning: cyclomatic complexity 34 of function TestApplyUpstreamTLSSettings() is high (> 15) (gocyclo)
  • Line 55: warning: cyclomatic complexity 20 of function TestApplyDestinationRule() is high (> 15) (gocyclo)

• istio/pkg/test/echo/server/forwarder/protocol.go
  • Line 63: warning: cyclomatic complexity 47 of function newProtocol() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/listener_test.go
  • Line 854: warning: cyclomatic complexity 17 of function testOutboundListenerConflict() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/cluster_test.go
  • Line 1134: warning: cyclomatic complexity 17 of function TestGatewayLocalityLB() is high (> 15) (gocyclo)
  • Line 972: warning: cyclomatic complexity 17 of function TestSidecarLocalityLB() is high (> 15) (gocyclo)

• istio/pilot/pkg/security/authz/model/model.go
  • Line 79: warning: cyclomatic complexity 22 of function New() is high (> 15) (gocyclo)

• istio/tests/integration/security/reachability_test.go
  • Line 38: warning: cyclomatic complexity 21 of function TestReachability() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/listener_builder_test.go
  • Line 200: warning: cyclomatic complexity 30 of function TestVirtualInboundHasPassthroughClusters() is high (> 15) (gocyclo)

• istio/pkg/config/validation/validation.go
  • Line 1579: warning: cyclomatic complexity 28 of function ValidateMeshConfigProxyConfig() is high (> 15) (gocyclo)
  • Line 2149: warning: cyclomatic complexity 22 of function coveredValidation() is high (> 15) (gocyclo)
  • Line 2903: warning: cyclomatic complexity 20 of function validateReadinessProbe() is high (> 15) (gocyclo)
  • Line 3248: warning: cyclomatic complexity 19 of function validateLocalities() is high (> 15) (gocyclo)
  • Line 557: warning: cyclomatic complexity 19 of function validateTLSOptions() is high (> 15) (gocyclo)

• istio/pkg/test/framework/components/echo/echoboot/echoboot.go
  • Line 97: warning: cyclomatic complexity 17 of function (builder).With() is high (> 15) (gocyclo)

• istio/pkg/test/framework/components/echo/common/config.go
  • Line 35: warning: cyclomatic complexity 29 of function FillInDefaults() is high (> 15) (gocyclo)

• istio/galley/pkg/config/source/kube/rt/known.go
  • Line 39: warning: cyclomatic complexity 36 of function (*Provider).initKnownAdapters() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch.go
  • Line 139: warning: cyclomatic complexity 23 of function patchHTTPRoutes() is high (> 15) (gocyclo)
  • Line 256: warning: cyclomatic complexity 16 of function routeConfigurationMatch() is high (> 15) (gocyclo)

• istio/pkg/config/schema/schema.go
  • Line 159: warning: cyclomatic complexity 26 of function Build() is high (> 15) (gocyclo)

• istio/pkg/config/validation/virtualservice.go
  • Line 139: warning: cyclomatic complexity 27 of function validateHTTPRouteMatchRequest() is high (> 15) (gocyclo)

• istio/istioctl/pkg/validate/validate.go
  • Line 78: warning: cyclomatic complexity 21 of function (*validator).validateResource() is high (> 15) (gocyclo)

• istio/operator/pkg/translate/translate_value.go
  • Line 397: warning: cyclomatic complexity 21 of function translateHPASpec() is high (> 15) (gocyclo)
  • Line 541: warning: cyclomatic complexity 19 of function (*ReverseTranslator).translateK8sTree() is high (> 15) (gocyclo)

• istio/pilot/cmd/pilot-agent/status/server.go
  • Line 151: warning: cyclomatic complexity 17 of function NewServer() is high (> 15) (gocyclo)

• istio/security/pkg/pki/util/verify_cert.go
  • Line 44: warning: cyclomatic complexity 32 of function VerifyCertificate() is high (> 15) (gocyclo)

• istio/tests/integration/security/fuzz/fuzz_test.go
  • Line 127: warning: cyclomatic complexity 17 of function runFuzzer() is high (> 15) (gocyclo)

• istio/operator/pkg/manifest/shared.go
  • Line 127: warning: cyclomatic complexity 19 of function GenIOPFromProfile() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/listener.go
  • Line 908: warning: cyclomatic complexity 46 of function (*ConfigGeneratorImpl).buildSidecarOutboundListenerForPortOrUDS() is high (> 15) (gocyclo)
  • Line 1337: warning: cyclomatic complexity 37 of function buildListener() is high (> 15) (gocyclo)
  • Line 432: warning: cyclomatic complexity 33 of function (*ConfigGeneratorImpl).buildSidecarOutboundListeners() is high (> 15) (gocyclo)

• istio/pkg/dns/client/dns.go
  • Line 84: warning: cyclomatic complexity 18 of function NewLocalDNSServer() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/httproute.go
  • Line 217: warning: cyclomatic complexity 27 of function BuildSidecarOutboundVirtualHosts() is high (> 15) (gocyclo)
  • Line 124: warning: cyclomatic complexity 17 of function (*ConfigGeneratorImpl).buildSidecarOutboundHTTPRouteConfig() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/sidecar_simulation_test.go
  • Line 1127: warning: cyclomatic complexity 21 of function TestPassthroughTraffic() is high (> 15) (gocyclo)

• istio/tests/integration/pilot/common/traffic.go
  • Line 94: warning: cyclomatic complexity 23 of function (TrafficTestCase).RunForApps() is high (> 15) (gocyclo)

• istio/istioctl/pkg/tag/generate_test.go
  • Line 185: warning: cyclomatic complexity 17 of function TestGenerateMutatingWebhook() is high (> 15) (gocyclo)

• istio/pilot/cmd/pilot-agent/options/security.go
  • Line 80: warning: cyclomatic complexity 16 of function SetupSecurityOptions() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/envoyfilter/cluster_patch.go
  • Line 70: warning: cyclomatic complexity 16 of function mergeTransportSocketCluster() is high (> 15) (gocyclo)

• istio/pkg/dns/server/name_table.go
  • Line 40: warning: cyclomatic complexity 19 of function BuildNameTable() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/pod_test.go
  • Line 252: warning: cyclomatic complexity 17 of function TestPodCacheEvents() is high (> 15) (gocyclo)

• istio/pkg/spiffe/spiffe_test.go
  • Line 349: warning: cyclomatic complexity 16 of function TestGetGeneralCertPoolAndVerifyPeerCert() is high (> 15) (gocyclo)

• istio/pkg/test/echo/server/forwarder/tcp.go
  • Line 38: warning: cyclomatic complexity 18 of function (*tcpProtocol).makeRequest() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/tls.go
  • Line 95: warning: cyclomatic complexity 17 of function buildSidecarOutboundTLSFilterChainOpts() is high (> 15) (gocyclo)

• istio/tools/istio-iptables/pkg/cmd/root.go
  • Line 194: warning: cyclomatic complexity 29 of function bindFlags() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch.go
  • Line 403: warning: cyclomatic complexity 32 of function patchHTTPFilters() is high (> 15) (gocyclo)
  • Line 237: warning: cyclomatic complexity 28 of function patchNetworkFilters() is high (> 15) (gocyclo)
  • Line 615: warning: cyclomatic complexity 22 of function filterChainMatch() is high (> 15) (gocyclo)

• istio/operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
  • Line 193: warning: cyclomatic complexity 33 of function (*ReconcileIstioOperator).Reconcile() is high (> 15) (gocyclo)

• istio/istioctl/pkg/verifier/verifier.go
  • Line 254: warning: cyclomatic complexity 23 of function (*StatusVerifier).verifyPostInstall() is high (> 15) (gocyclo)

• istio/pilot/pkg/config/kube/crdclient/client_test.go
  • Line 156: warning: cyclomatic complexity 29 of function TestClient() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/controller_test.go
  • Line 1857: warning: cyclomatic complexity 17 of function TestEndpointUpdateBeforePodUpdate() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/httproute_test.go
  • Line 1286: warning: cyclomatic complexity 17 of function testSidecarRDSVHosts() is high (> 15) (gocyclo)

• istio/security/pkg/nodeagent/test/empty_certchain/empty_cert_test.go
  • Line 27: warning: cyclomatic complexity 17 of function TestBadCSRResponse() is high (> 15) (gocyclo)

• istio/istioctl/pkg/authz/listener.go
  • Line 130: warning: cyclomatic complexity 16 of function Print() is high (> 15) (gocyclo)

• istio/cni/pkg/plugin/plugin.go
  • Line 147: warning: cyclomatic complexity 34 of function CmdAdd() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/gateway.go
  • Line 327: warning: cyclomatic complexity 21 of function (*ConfigGeneratorImpl).buildGatewayHTTPRouteConfig() is high (> 15) (gocyclo)
  • Line 58: warning: cyclomatic complexity 18 of function (*ConfigGeneratorImpl).buildGatewayListeners() is high (> 15) (gocyclo)

• istio/security/pkg/pki/util/generate_cert_test.go
  • Line 575: warning: cyclomatic complexity 24 of function TestGenCertFromCSR() is high (> 15) (gocyclo)

• istio/tests/integration/security/util/rbac_util/util.go
  • Line 86: warning: cyclomatic complexity 18 of function (TestCase).CheckRBACRequest() is high (> 15) (gocyclo)

• istio/pkg/config/schema/codegen/tools/collections.main.go
  • Line 31: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/multicluster.go
  • Line 148: warning: cyclomatic complexity 18 of function (*Multicluster).ClusterAdded() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/endpointslice.go
  • Line 284: warning: cyclomatic complexity 16 of function (*endpointSliceController).InstancesByPort() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/cluster_builder.go
  • Line 1005: warning: cyclomatic complexity 23 of function (*ClusterBuilder).buildUpstreamClusterTLSContext() is high (> 15) (gocyclo)
  • Line 893: warning: cyclomatic complexity 17 of function (*ClusterBuilder).applyConnectionPool() is high (> 15) (gocyclo)

• istio/security/pkg/k8s/chiron/utils.go
  • Line 359: warning: cyclomatic complexity 20 of function getSignedCsr() is high (> 15) (gocyclo)

• istio/security/pkg/pki/util/keycertbundle_test.go
  • Line 48: warning: cyclomatic complexity 17 of function TestKeyCertBundleWithRootCertFromFile() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/pod.go
  • Line 115: warning: cyclomatic complexity 19 of function (*PodCache).onEvent() is high (> 15) (gocyclo)

• istio/galley/pkg/config/processing/snapshotter/analyzingdistributor.go
  • Line 192: warning: cyclomatic complexity 16 of function filterMessages() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/loadbalancer/loadbalancer_test.go
  • Line 39: warning: cyclomatic complexity 26 of function TestApplyLocalitySetting() is high (> 15) (gocyclo)

• istio/pilot/pkg/security/authn/v1beta1/policy_applier.go
  • Line 378: warning: cyclomatic complexity 23 of function composePeerAuthentication() is high (> 15) (gocyclo)

• istio/pkg/config/schema/fuzz/fuzz.go
  • Line 118: warning: cyclomatic complexity 18 of function roundTrip() is high (> 15) (gocyclo)

• istio/pkg/config/security/security.go
  • Line 102: warning: cyclomatic complexity 19 of function ValidateAttribute() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/listener_builder.go
  • Line 597: warning: cyclomatic complexity 17 of function (*ConfigGeneratorImpl).buildInboundFilterchains() is high (> 15) (gocyclo)

• istio/galley/pkg/config/analysis/analyzers/injection/injection.go
  • Line 61: warning: cyclomatic complexity 17 of function (*Analyzer).Analyze() is high (> 15) (gocyclo)

• istio/operator/pkg/helmreconciler/apply.go
  • Line 42: warning: cyclomatic complexity 17 of function (*HelmReconciler).ApplyManifest() is high (> 15) (gocyclo)

• istio/pilot/pkg/simulation/traffic.go
  • Line 251: warning: cyclomatic complexity 26 of function (*Simulation).Run() is high (> 15) (gocyclo)
  • Line 397: warning: cyclomatic complexity 21 of function (*Simulation).matchVirtualHost() is high (> 15) (gocyclo)
  • Line 168: warning: cyclomatic complexity 18 of function (Result).Matches() is high (> 15) (gocyclo)

• istio/operator/pkg/translate/translate.go
  • Line 176: warning: cyclomatic complexity 24 of function (*Translator).OverlayK8sSettings() is high (> 15) (gocyclo)
  • Line 613: warning: cyclomatic complexity 21 of function (*Translator).setComponentProperties() is high (> 15) (gocyclo)

• istio/operator/pkg/helmreconciler/wait.go
  • Line 98: warning: cyclomatic complexity 17 of function waitForResources() is high (> 15) (gocyclo)

• istio/pkg/test/framework/components/echo/common/call.go
  • Line 182: warning: cyclomatic complexity 24 of function fillInCallOptions() is high (> 15) (gocyclo)

• istio/operator/pkg/validate/validate.go
  • Line 73: warning: cyclomatic complexity 23 of function Validate() is high (> 15) (gocyclo)

• istio/pilot/pkg/keycertbundle/watcher_test.go
  • Line 25: warning: cyclomatic complexity 18 of function TestWatcher() is high (> 15) (gocyclo)

• istio/pilot/pkg/security/authz/builder/builder.go
  • Line 183: warning: cyclomatic complexity 16 of function (Builder).build() is high (> 15) (gocyclo)

• istio/pilot/test/xdstest/extract.go
  • Line 64: warning: cyclomatic complexity 17 of function ExtractSecretResources() is high (> 15) (gocyclo)

• istio/pkg/bootstrap/platform/gcp.go
  • Line 137: warning: cyclomatic complexity 20 of function (*gcpEnv).Metadata() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/serviceentry/servicediscovery.go
  • Line 267: warning: cyclomatic complexity 22 of function (*ServiceEntryStore).serviceEntryHandler() is high (> 15) (gocyclo)
  • Line 150: warning: cyclomatic complexity 20 of function (*ServiceEntryStore).workloadEntryHandler() is high (> 15) (gocyclo)

• istio/pilot/pkg/serviceregistry/kube/controller/controller.go
  • Line 953: warning: cyclomatic complexity 18 of function (*Controller).serviceInstancesFromWorkloadInstances() is high (> 15) (gocyclo)

• istio/galley/pkg/config/analysis/analyzers/webhook/webhook.go
  • Line 72: warning: cyclomatic complexity 21 of function (*Analyzer).Analyze() is high (> 15) (gocyclo)

• istio/operator/pkg/helmreconciler/prune.go
  • Line 196: warning: cyclomatic complexity 17 of function (*HelmReconciler).GetPrunedResources() is high (> 15) (gocyclo)

• istio/pkg/spiffe/spiffe.go
  • Line 192: warning: cyclomatic complexity 16 of function RetrieveSpiffeBundleRootCerts() is high (> 15) (gocyclo)

• istio/tests/integration/operator/switch_cr_test.go
  • Line 352: warning: cyclomatic complexity 18 of function compareInClusterAndGeneratedResources() is high (> 15) (gocyclo)

• istio/tests/integration/security/util/reachability/context.go
  • Line 70: warning: cyclomatic complexity 21 of function Run() is high (> 15) (gocyclo)

• istio/security/pkg/k8s/chiron/controller_test.go
  • Line 282: warning: cyclomatic complexity 16 of function TestScrtUpdated() is high (> 15) (gocyclo)

• istio/pilot/pkg/networking/core/v1alpha3/route/route.go
  • Line 384: warning: cyclomatic complexity 41 of function translateRoute() is high (> 15) (gocyclo)
  • Line 90: warning: cyclomatic complexity 16 of function BuildSidecarVirtualHostWrapper() is high (> 15) (gocyclo)

• istio/pilot/test/xdstest/validate.go
  • Line 73: warning: cyclomatic complexity 18 of function validateFilterChainMatch() is high (> 15) (gocyclo)

• istio/pkg/dns/client/dns_test.go
  • Line 34: warning: cyclomatic complexity 18 of function TestDNS() is high (> 15) (gocyclo)

• istio/security/pkg/nodeagent/test/csr_failure/csr_test.go
  • Line 27: warning: cyclomatic complexity 17 of function TestCSRFailure() is high (> 15) (gocyclo)

• istio/operator/pkg/tpath/tree.go
  • Line 147: warning: cyclomatic complexity 38 of function getPathContext() is high (> 15) (gocyclo)
  • Line 337: warning: cyclomatic complexity 21 of function setValueContext() is high (> 15) (gocyclo)

• istio/pilot/pkg/config/kube/crdclient/types.gen.go
  • Line 387: warning: cyclomatic complexity 43 of function patch() is high (> 15) (gocyclo)
  • Line 698: warning: cyclomatic complexity 23 of function delete() is high (> 15) (gocyclo)
  • Line 159: warning: cyclomatic complexity 22 of function update() is high (> 15) (gocyclo)
  • Line 52: warning: cyclomatic complexity 22 of function create() is high (> 15) (gocyclo)
  • Line 266: warning: cyclomatic complexity 21 of function updateStatus() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!