gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• operator/pkg/util/fswatch/fswatch.go
  • Line 71: warning: cyclomatic complexity 16 of function watchDir() is high (> 15) (gocyclo)

• operator/pkg/apis/istio/fixup_structs/main.go
  • Line 73: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

• operator/pkg/validate/validate.go
  • Line 44: warning: cyclomatic complexity 19 of function validate() is high (> 15) (gocyclo)

• operator/cmd/mesh/profile-common.go
  • Line 45: warning: cyclomatic complexity 24 of function genIOPS() is high (> 15) (gocyclo)

• operator/cmd/mesh/upgrade.go
  • Line 117: warning: cyclomatic complexity 20 of function upgrade() is high (> 15) (gocyclo)

• operator/pkg/translate/translate_value.go
  • Line 379: warning: cyclomatic complexity 18 of function (*ReverseTranslator).translateK8sTree() is high (> 15) (gocyclo)

• operator/pkg/manifest/installer.go
  • Line 546: warning: cyclomatic complexity 31 of function waitForResources() is high (> 15) (gocyclo)
  • Line 248: warning: cyclomatic complexity 17 of function ApplyManifest() is high (> 15) (gocyclo)

• operator/pkg/helmreconciler/rendering.go
  • Line 191: warning: cyclomatic complexity 22 of function (*HelmReconciler).ProcessObject() is high (> 15) (gocyclo)

• operator/pkg/tpath/tpath.go
  • Line 71: warning: cyclomatic complexity 22 of function getPathContext() is high (> 15) (gocyclo)

golint76%

Golint is a linter for Go source code.

• operator/pkg/helmreconciler/dependencies.go
  • Line 24: warning: exported function InsertChildrenRecursive should have comment or be unexported (golint)
  • Line 31: warning: exported function InstallTreeString should have comment or be unexported (golint)

• operator/pkg/helm/vfs_renderer.go
  • Line 136: warning: exported function BuiltinProfileToFilename should have comment or be unexported (golint)
  • Line 150: warning: comment on exported function ListBuiltinProfiles should be of the form "ListBuiltinProfiles ..." (golint)

• operator/pkg/util/reflect.go
  • Line 59: warning: exported function IsStruct should have comment or be unexported (golint)

• operator/pkg/tpath/tpath.go
  • Line 228: warning: exported function IsLeafNode should have comment or be unexported (golint)
  • Line 275: warning: comment on exported function DeleteFromTree should be of the form "DeleteFromTree ..." (golint)

• operator/pkg/controller/istiocontrolplane/inputs.go
  • Line 70: warning: exported method IstioRenderingInput.GetInputConfig should have comment or be unexported (golint)
  • Line 74: warning: exported method IstioRenderingInput.GetTargetNamespace should have comment or be unexported (golint)

• operator/pkg/hooks/upgrade_hooks.go
  • Line 67: warning: exported function RunPreUpgradeHooks should have comment or be unexported (golint)
  • Line 71: warning: exported function RunPostUpgradeHooks should have comment or be unexported (golint)

• operator/pkg/manifest/client.go
  • Line 130: warning: exported method Client.PodsForSelector should have comment or be unexported (golint)
  • Line 160: warning: exported method Client.ConfigMapForSelector should have comment or be unexported (golint)

• operator/pkg/manifest/installer.go
  • Line 89: warning: exported type CompositeOutput should have comment or be unexported (golint)
  • Line 248: warning: exported function ApplyManifest should have comment or be unexported (golint)
  • Line 349: warning: exported function GetKubectlGetItems should have comment or be unexported (golint)
  • Line 371: warning: exported function DeploymentExists should have comment or be unexported (golint)
  • Line 753: warning: exported function InitK8SRestClient should have comment or be unexported (golint)

• operator/pkg/util/yaml.go
  • Line 167: warning: exported function YAMLDiff should have comment or be unexported (golint)

• operator/pkg/compare/compare.go
  • Line 217: warning: exported function ManifestDiff should have comment or be unexported (golint)
  • Line 231: warning: comment on exported function ManifestDiffWithRenameSelectIgnore should be of the form "ManifestDiffWithRenameSelectIgnore ..." (golint)

• operator/pkg/controller/istiocontrolplane/customizer.go
  • Line 26: warning: exported type IstioRenderingCustomizerFactory should have comment or be unexported (golint)

• operator/pkg/controller/istiocontrolplane/pruningdetails.go
  • Line 138: warning: comment on exported function NewIstioPruningDetails should be of the form "NewIstioPruningDetails ..." (golint)

• operator/pkg/helmreconciler/customizers.go
  • Line 40: warning: exported method SimpleRenderingCustomizer.Input should have comment or be unexported (golint)
  • Line 44: warning: exported method SimpleRenderingCustomizer.PruningDetails should have comment or be unexported (golint)
  • Line 48: warning: exported method SimpleRenderingCustomizer.Listener should have comment or be unexported (golint)
  • Line 52: warning: exported method SimpleRenderingCustomizer.RegisterReconciler should have comment or be unexported (golint)

• operator/cmd/mesh/root.go
  • Line 27: warning: exported const SetFlagHelpStr should have comment (or a comment on this block) or be unexported (golint)

• operator/pkg/apis/istio/v1alpha1/deepcopy.go
  • Line 58: warning: comment on exported method IstioOperator.GetObjectKind should be of the form "GetObjectKind ..." (golint)

• operator/pkg/object/objects.go
  • Line 15: warning: package comment should be of the form "Package object ..." (golint)

• operator/pkg/helmreconciler/rendering.go
  • Line 191: warning: exported method HelmReconciler.ProcessObject should have comment or be unexported (golint)

• operator/pkg/helm/helm.go
  • Line 42: warning: comment on exported const NotesFileNameSuffix should be of the form "NotesFileNameSuffix ..." (golint)

• operator/cmd/mesh/upgrade.go
  • Line 90: warning: comment on exported function UpgradeCmd should be of the form "UpgradeCmd ..." (golint)

• operator/pkg/util/path.go
  • Line 103: warning: comment on exported function PathKV should be of the form "PathKV ..." (golint)

• operator/pkg/util/util.go
  • Line 39: warning: exported type FileFilter should have comment or be unexported (golint)

• operator/pkg/apis/istio/v1alpha1/common.go
  • Line 22: warning: comment on exported type IntOrStringForPB should be of the form "IntOrStringForPB ..." (with optional leading article) (golint)

• operator/pkg/name/name.go
  • Line 36: warning: comment on exported const IstioBaseComponentName should be of the form "IstioBaseComponentName ..." (golint)
  • Line 39: warning: exported const PilotComponentName should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: comment on exported const IngressComponentName should be of the form "IngressComponentName ..." (golint)
  • Line 53: warning: comment on exported const AddonComponentName should be of the form "AddonComponentName ..." (golint)
  • Line 56: warning: comment on exported const IstioOperatorComponentName should be of the form "IstioOperatorComponentName ..." (golint)
  • Line 62: warning: exported var AllCoreComponentNames should have comment or be unexported (golint)

• operator/pkg/helmreconciler/interfaces.go
  • Line 41: warning: exported type RenderingCustomizerFactory should have comment or be unexported (golint)

• operator/pkg/helmreconciler/pruning.go
  • Line 46: warning: comment on exported method HelmReconciler.PruneResources should be of the form "PruneResources ..." (golint)

• operator/pkg/translate/translate.go
  • Line 72: warning: comment on exported type FeatureMap should be of the form "FeatureMap ..." (with optional leading article) (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!