gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint53%

Golint is a linter for Go source code.

• cmd/controller/app/controller.go
  • Line 72: warning: exported function Run should have comment or be unexported (golint)

• pkg/controller/certificaterequests/venafi/venafi.go
  • Line 44: warning: exported const CRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type Venafi should have comment or be unexported (golint)
  • Line 65: warning: exported function NewVenafi should have comment or be unexported (golint)
  • Line 75: warning: exported method Venafi.Sign should have comment or be unexported (golint)

• test/e2e/framework/addon/chart/addon.go
  • Line 88: warning: exported method Chart.Setup should have comment or be unexported (golint)
  • Line 217: warning: exported method Chart.SupportsGlobal should have comment or be unexported (golint)
  • Line 228: warning: exported method Chart.Logs should have comment or be unexported (golint)

• test/e2e/suite/doc.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• cmd/ctl/pkg/deny/deny.go
  • Line 71: warning: exported function NewCmdDeny should have comment or be unexported (golint)

• internal/apis/acme/v1alpha3/types_challenge.go
  • Line 54: warning: exported type ChallengeSpec should have comment or be unexported (golint)
  • Line 102: warning: comment on exported type ACMEChallengeType should be of the form "ACMEChallengeType ..." (with optional leading article) (golint)
  • Line 116: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• cmd/util/signal.go
  • Line 42: warning: comment on exported function SetupExitHandler should be of the form "SetupExitHandler ..." (golint)

• pkg/apis/meta/v1/register.go
  • Line 35: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/controller/certificatesigningrequests/sync.go
  • Line 37: warning: exported method Controller.Sync should have comment or be unexported (golint)

• test/e2e/framework/addon/venafi/tpp.go
  • Line 33: warning: exported type VenafiTPP should have comment or be unexported (golint)
  • Line 45: warning: exported type TPPDetails should have comment or be unexported (golint)
  • Line 49: warning: exported method VenafiTPP.Setup should have comment or be unexported (golint)
  • Line 79: warning: exported method VenafiTPP.Provision should have comment or be unexported (golint)
  • Line 110: warning: exported method VenafiTPP.Details should have comment or be unexported (golint)
  • Line 114: warning: exported method VenafiTPP.Deprovision should have comment or be unexported (golint)
  • Line 118: warning: exported method VenafiTPP.SupportsGlobal should have comment or be unexported (golint)
  • Line 122: warning: exported method TPPDetails.BuildIssuer should have comment or be unexported (golint)
  • Line 135: warning: exported method TPPDetails.BuildClusterIssuer should have comment or be unexported (golint)

• pkg/webhook/server/tls/dynamic_source.go
  • Line 55: warning: exported method DynamicSource.Run should have comment or be unexported (golint)
  • Line 197: warning: exported method DynamicSource.GetCertificate should have comment or be unexported (golint)
  • Line 206: warning: exported method DynamicSource.Healthy should have comment or be unexported (golint)

• test/e2e/suite/issuers/acme/certificate/webhook.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• test/unit/coreclients/secrets.go
  • Line 17: warning: package comment should be of the form "Package coreclients ..." (golint)
  • Line 39: warning: exported type FakeSecretsGetterModifier should have comment or be unexported (golint)
  • Line 50: warning: exported function NewFakeSecretsGetter should have comment or be unexported (golint)
  • Line 86: warning: exported method FakeSecretsGetter.Secrets should have comment or be unexported (golint)
  • Line 90: warning: exported type ApplyFn should have comment or be unexported (golint)

• test/unit/gen/certificate.go
  • Line 29: warning: exported type CertificateModifier should have comment or be unexported (golint)
  • Line 31: warning: exported function Certificate should have comment or be unexported (golint)
  • Line 44: warning: exported function CertificateFrom should have comment or be unexported (golint)
  • Line 52: warning: comment on exported function SetCertificateIssuer should be of the form "SetCertificateIssuer ..." (golint)
  • Line 59: warning: exported function SetCertificateDNSNames should have comment or be unexported (golint)
  • Line 65: warning: exported function SetCertificateCommonName should have comment or be unexported (golint)
  • Line 71: warning: exported function SetCertificateIPs should have comment or be unexported (golint)
  • Line 77: warning: exported function SetCertificateURIs should have comment or be unexported (golint)
  • Line 83: warning: exported function SetCertificateIsCA should have comment or be unexported (golint)
  • Line 89: warning: exported function SetCertificateKeyAlgorithm should have comment or be unexported (golint)
  • Line 95: warning: exported function SetCertificateKeySize should have comment or be unexported (golint)
  • Line 101: warning: exported function SetCertificateKeyEncoding should have comment or be unexported (golint)
  • Line 107: warning: exported function SetCertificateSecretName should have comment or be unexported (golint)
  • Line 123: warning: exported function SetCertificateDuration should have comment or be unexported (golint)
  • Line 129: warning: exported function SetCertificateRenewBefore should have comment or be unexported (golint)
  • Line 135: warning: exported function SetCertificateNextPrivateKeySecretName should have comment or be unexported (golint)
  • Line 141: warning: exported function SetCertificateStatusCondition should have comment or be unexported (golint)
  • Line 157: warning: exported function SetCertificateLastFailureTime should have comment or be unexported (golint)
  • Line 163: warning: exported function SetCertificateNotAfter should have comment or be unexported (golint)
  • Line 169: warning: exported function SetCertificateNotBefore should have comment or be unexported (golint)
  • Line 175: warning: exported function SetCertificateRenewalTime should have comment or be unexported (golint)
  • Line 181: warning: exported function SetCertificateOrganization should have comment or be unexported (golint)
  • Line 187: warning: exported function SetCertificateNamespace should have comment or be unexported (golint)
  • Line 193: warning: exported function SetCertificateKeyUsages should have comment or be unexported (golint)
  • Line 199: warning: exported function SetCertificateRevision should have comment or be unexported (golint)
  • Line 205: warning: exported function SetCertificateUID should have comment or be unexported (golint)
  • Line 211: warning: exported function SetCertificateGeneration should have comment or be unexported (golint)
  • Line 217: warning: exported function AddCertificateAnnotations should have comment or be unexported (golint)
  • Line 229: warning: exported function AddCertificateLabels should have comment or be unexported (golint)
  • Line 259: warning: exported function SetCertificateRevisionHistoryLimit should have comment or be unexported (golint)
  • Line 265: warning: exported function SetCertificateAdditionalOutputFormats should have comment or be unexported (golint)

• test/unit/gen/issuer.go
  • Line 26: warning: exported type IssuerModifier should have comment or be unexported (golint)
  • Line 28: warning: exported function ClusterIssuer should have comment or be unexported (golint)
  • Line 39: warning: exported function ClusterIssuerFrom should have comment or be unexported (golint)
  • Line 60: warning: exported function Issuer should have comment or be unexported (golint)
  • Line 70: warning: exported function IssuerFrom should have comment or be unexported (golint)
  • Line 92: warning: exported function SetIssuerACME should have comment or be unexported (golint)
  • Line 98: warning: exported function SetIssuerACMEURL should have comment or be unexported (golint)
  • Line 108: warning: exported function SetIssuerACMEEmail should have comment or be unexported (golint)
  • Line 117: warning: exported function SetIssuerACMEPrivKeyRef should have comment or be unexported (golint)
  • Line 130: warning: exported function SetIssuerACMESolvers should have comment or be unexported (golint)
  • Line 140: warning: exported function SetIssuerACMEDuration should have comment or be unexported (golint)
  • Line 150: warning: exported function SetIssuerACMESkipTLSVerify should have comment or be unexported (golint)
  • Line 160: warning: exported function SetIssuerACMEDisableAccountKeyGeneration should have comment or be unexported (golint)
  • Line 170: warning: exported function SetIssuerACMEEAB should have comment or be unexported (golint)
  • Line 209: warning: exported function SetIssuerACMEAccountURL should have comment or be unexported (golint)
  • Line 219: warning: exported function SetIssuerACMELastRegisteredEmail should have comment or be unexported (golint)
  • Line 229: warning: exported function SetIssuerCA should have comment or be unexported (golint)
  • Line 235: warning: exported function SetIssuerCASecretName should have comment or be unexported (golint)
  • Line 245: warning: exported function SetIssuerVault should have comment or be unexported (golint)
  • Line 250: warning: exported function SetIssuerVaultURL should have comment or be unexported (golint)
  • Line 260: warning: exported function SetIssuerVaultPath should have comment or be unexported (golint)
  • Line 270: warning: exported function SetIssuerVaultCABundle should have comment or be unexported (golint)
  • Line 279: warning: exported function SetIssuerVaultTokenAuth should have comment or be unexported (golint)
  • Line 293: warning: exported function SetIssuerVaultAppRoleAuth should have comment or be unexported (golint)
  • Line 312: warning: exported function SetIssuerVaultKubernetesAuth should have comment or be unexported (golint)
  • Line 331: warning: exported function SetIssuerSelfSigned should have comment or be unexported (golint)
  • Line 337: warning: exported function SetIssuerVenafi should have comment or be unexported (golint)
  • Line 343: warning: exported function AddIssuerCondition should have comment or be unexported (golint)
  • Line 349: warning: exported function SetIssuerNamespace should have comment or be unexported (golint)

• cmd/ctl/pkg/build/commands/commands.go
  • Line 45: warning: exported type RegisterCommandFunc should have comment or be unexported (golint)

• internal/apis/certmanager/v1beta1/const.go
  • Line 22: warning: comment on exported const MinimumCertificateDuration should be of the form "MinimumCertificateDuration ..." (golint)
  • Line 25: warning: comment on exported const DefaultCertificateDuration should be of the form "DefaultCertificateDuration ..." (golint)
  • Line 28: warning: comment on exported const MinimumRenewBefore should be of the form "MinimumRenewBefore ..." (golint)
  • Line 31: warning: comment on exported const DefaultRenewBefore should be of the form "DefaultRenewBefore ..." (golint)
  • Line 36: warning: comment on exported const DefaultVaultTokenAuthSecretKey should be of the form "DefaultVaultTokenAuthSecretKey ..." (golint)
  • Line 39: warning: comment on exported const DefaultVaultKubernetesAuthMountPath should be of the form "DefaultVaultKubernetesAuthMountPath ..." (golint)

• internal/apis/certmanager/v1alpha3/doc.go
  • Line 22: warning: package comment should be of the form "Package v1alpha3 ..." (golint)

• internal/plugin/admission/certificaterequest/approval/certificaterequest_approval.go
  • Line 49: warning: exported const PluginName should have comment or be unexported (golint)
  • Line 67: warning: exported function Register should have comment or be unexported (golint)
  • Line 73: warning: exported function NewPlugin should have comment or be unexported (golint)

• test/e2e/suite/issuers/acme/certificaterequest/dns01.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• pkg/controller/certificatesigningrequests/util/signername.go
  • Line 25: warning: exported type SignerIssuerRef should have comment or be unexported (golint)

• pkg/issuer/selfsigned/setup.go
  • Line 31: warning: exported method SelfSigned.Setup should have comment or be unexported (golint)

• pkg/webhook/configfile/configfile.go
  • Line 46: warning: exported type Loader should have comment or be unexported (golint)
  • Line 78: warning: exported function NewFSLoader should have comment or be unexported (golint)

• pkg/webhook/handlers/conversion.go
  • Line 36: warning: exported type SchemeBackedConverter should have comment or be unexported (golint)
  • Line 44: warning: exported function NewSchemeBackedConverter should have comment or be unexported (golint)
  • Line 89: warning: exported method SchemeBackedConverter.Convert should have comment or be unexported (golint)

• test/e2e/suite/serving/cainjector.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• cmd/webhook/app/options/globalflags.go
  • Line 28: warning: exported function AddGlobalFlags should have comment or be unexported (golint)

• internal/apis/certmanager/v1/register.go
  • Line 36: warning: exported var AddToScheme should have comment or be unexported (golint)

• internal/vault/vault.go
  • Line 354: warning: exported method Vault.Sys should have comment or be unexported (golint)
  • Line 382: warning: exported method Vault.IsVaultInitializedAndUnsealed should have comment or be unexported (golint)

• test/integration/framework/helpers.go
  • Line 40: warning: exported function NewEventRecorder should have comment or be unexported (golint)
  • Line 46: warning: exported function NewClients should have comment or be unexported (golint)
  • Line 60: warning: exported function StartInformersAndController should have comment or be unexported (golint)
  • Line 80: warning: context.Context should be the first parameter of a function (golint)
  • Line 80: warning: exported function WaitForOpenAPIResourcesToBeLoaded should have comment or be unexported (golint)

• pkg/controller/certificatesigningrequests/fake/fake.go
  • Line 27: warning: exported type Signer should have comment or be unexported (golint)
  • Line 31: warning: exported method Signer.Sign should have comment or be unexported (golint)

• internal/apis/acme/v1alpha2/doc.go
  • Line 22: warning: package comment should be of the form "Package v1alpha2 ..." (golint)

• internal/plugin/admission/resourcevalidation/resourcevalidation.go
  • Line 34: warning: exported const PluginName should have comment or be unexported (golint)
  • Line 79: warning: exported function NewPlugin should have comment or be unexported (golint)

• test/acme/dns/server/server.go
  • Line 35: warning: exported type BasicServer should have comment or be unexported (golint)
  • Line 111: warning: exported method BasicServer.ListenAddr should have comment or be unexported (golint)
  • Line 115: warning: exported method BasicServer.Shutdown should have comment or be unexported (golint)

• test/e2e/suite/issuers/venafi/tpp/doc.go
  • Line 24: warning: exported function TPPDescribe should have comment or be unexported (golint)

• test/unit/gen/certificaterequest.go
  • Line 26: warning: exported type CertificateRequestModifier should have comment or be unexported (golint)
  • Line 28: warning: exported function CertificateRequest should have comment or be unexported (golint)
  • Line 38: warning: exported function CertificateRequestFrom should have comment or be unexported (golint)
  • Line 46: warning: comment on exported function SetCertificateRequestIssuer should be of the form "SetCertificateRequestIssuer ..." (golint)
  • Line 53: warning: exported function SetCertificateRequestCSR should have comment or be unexported (golint)
  • Line 59: warning: exported function SetCertificateRequestIsCA should have comment or be unexported (golint)
  • Line 65: warning: exported function SetCertificateRequestDuration should have comment or be unexported (golint)
  • Line 71: warning: exported function SetCertificateRequestCA should have comment or be unexported (golint)
  • Line 77: warning: exported function SetCertificateRequestCertificate should have comment or be unexported (golint)
  • Line 83: warning: exported function SetCertificateRequestStatusCondition should have comment or be unexported (golint)
  • Line 99: warning: exported function AddCertificateRequestStatusCondition should have comment or be unexported (golint)
  • Line 105: warning: exported function SetCertificateRequestNamespace should have comment or be unexported (golint)
  • Line 111: warning: exported function SetCertificateRequestName should have comment or be unexported (golint)
  • Line 117: warning: exported function SetCertificateRequestKeyUsages should have comment or be unexported (golint)
  • Line 123: warning: exported function AddCertificateRequestAnnotations should have comment or be unexported (golint)
  • Line 137: warning: exported function AddCertificateRequestOwnerReferences should have comment or be unexported (golint)
  • Line 143: warning: exported function SetCertificateRequestAnnotations should have comment or be unexported (golint)
  • Line 154: warning: exported function DeleteCertificateRequestAnnotation should have comment or be unexported (golint)
  • Line 163: warning: exported function SetCertificateRequestFailureTime should have comment or be unexported (golint)
  • Line 169: warning: exported function SetCertificateRequestTypeMeta should have comment or be unexported (golint)
  • Line 175: warning: exported function SetCertificateRequestUsername should have comment or be unexported (golint)
  • Line 181: warning: exported function SetCertificateRequestGroups should have comment or be unexported (golint)
  • Line 187: warning: exported function SetCertificateRequestRevision should have comment or be unexported (golint)

• internal/apis/meta/register.go
  • Line 27: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha3/conversion.go
  • Line 25: warning: exported function Convert_v1alpha3_CertificateSpec_To_certmanager_CertificateSpec should have comment or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; func Convert_v1alpha3_CertificateSpec_To_certmanager_CertificateSpec should be ConvertV1alpha3CertificateSpecToCertmanagerCertificateSpec (golint)
  • Line 59: warning: exported function Convert_certmanager_CertificateSpec_To_v1alpha3_CertificateSpec should have comment or be unexported (golint)
  • Line 59: warning: don't use underscores in Go names; func Convert_certmanager_CertificateSpec_To_v1alpha3_CertificateSpec should be ConvertCertmanagerCertificateSpecToV1alpha3CertificateSpec (golint)
  • Line 89: warning: exported function Convert_certmanager_X509Subject_To_v1alpha3_X509Subject should have comment or be unexported (golint)
  • Line 89: warning: don't use underscores in Go names; func Convert_certmanager_X509Subject_To_v1alpha3_X509Subject should be ConvertCertmanagerX509SubjectToV1alpha3X509Subject (golint)
  • Line 93: warning: exported function Convert_certmanager_CertificatePrivateKey_To_v1alpha3_CertificatePrivateKey should have comment or be unexported (golint)
  • Line 93: warning: don't use underscores in Go names; func Convert_certmanager_CertificatePrivateKey_To_v1alpha3_CertificatePrivateKey should be ConvertCertmanagerCertificatePrivateKeyToV1alpha3CertificatePrivateKey (golint)
  • Line 97: warning: exported function Convert_v1alpha3_CertificateRequestSpec_To_certmanager_CertificateRequestSpec should have comment or be unexported (golint)
  • Line 97: warning: don't use underscores in Go names; func Convert_v1alpha3_CertificateRequestSpec_To_certmanager_CertificateRequestSpec should be ConvertV1alpha3CertificateRequestSpecToCertmanagerCertificateRequestSpec (golint)
  • Line 106: warning: exported function Convert_certmanager_CertificateRequestSpec_To_v1alpha3_CertificateRequestSpec should have comment or be unexported (golint)
  • Line 106: warning: don't use underscores in Go names; func Convert_certmanager_CertificateRequestSpec_To_v1alpha3_CertificateRequestSpec should be ConvertCertmanagerCertificateRequestSpecToV1alpha3CertificateRequestSpec (golint)

• pkg/apis/certmanager/doc.go
  • Line 23: warning: exported const GroupName should have comment or be unexported (golint)

• pkg/util/versionchecker/versionchecker.go
  • Line 43: warning: exported var ErrCertManagerCRDsNotFound should have comment or be unexported (golint)
  • Line 48: warning: exported type Version should have comment or be unexported (golint)

• test/acme/dns/util.go
  • Line 152: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• test/e2e/suite/issuers/vault/import.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• internal/apis/config/webhook/types.go
  • Line 25: warning: exported type WebhookConfiguration should have comment or be unexported (golint)
  • Line 87: warning: exported method TLSConfig.FilesystemConfigProvided should have comment or be unexported (golint)
  • Line 94: warning: exported method TLSConfig.DynamicConfigProvided should have comment or be unexported (golint)

• internal/apis/certmanager/types.go
  • Line 51: warning: comment on exported const IngressIssuerNameAnnotationKey should be of the form "IngressIssuerNameAnnotationKey ..." (golint)
  • Line 54: warning: comment on exported const IngressClusterIssuerNameAnnotationKey should be of the form "IngressClusterIssuerNameAnnotationKey ..." (golint)
  • Line 58: warning: comment on exported const IngressACMEIssuerHTTP01IngressClassAnnotationKey should be of the form "IngressACMEIssuerHTTP01IngressClassAnnotationKey ..." (golint)
  • Line 104: warning: comment on exported const WantInjectAPIServerCAAnnotation should be of the form "WantInjectAPIServerCAAnnotation ..." (golint)
  • Line 162: warning: exported const UsageSigning should have comment (or a comment on this block) or be unexported (golint)

• internal/apis/certmanager/types_certificate.go
  • Line 52: warning: exported type PrivateKeyAlgorithm should have comment or be unexported (golint)
  • Line 55: warning: comment on exported const RSAKeyAlgorithm should be of the form "RSAKeyAlgorithm ..." (golint)
  • Line 58: warning: comment on exported const ECDSAKeyAlgorithm should be of the form "ECDSAKeyAlgorithm ..." (golint)
  • Line 61: warning: comment on exported const Ed25519KeyAlgorithm should be of the form "Ed25519KeyAlgorithm ..." (golint)
  • Line 65: warning: exported type PrivateKeyEncoding should have comment or be unexported (golint)
  • Line 248: warning: comment on exported type PrivateKeyRotationPolicy should be of the form "PrivateKeyRotationPolicy ..." (with optional leading article) (golint)
  • Line 296: warning: comment on exported type JKSKeystore should be of the form "JKSKeystore ..." (with optional leading article) (golint)
  • Line 311: warning: comment on exported type PKCS12Keystore should be of the form "PKCS12Keystore ..." (with optional leading article) (golint)
  • Line 417: warning: comment on exported const CertificateConditionIssuing should be of the form "CertificateConditionIssuing ..." (golint)

• cmd/ctl/pkg/status/certificate/types.go
  • Line 37: warning: exported type CertificateStatus should have comment or be unexported (golint)
  • Line 68: warning: exported type IssuerStatus should have comment or be unexported (golint)
  • Line 82: warning: exported type SecretStatus should have comment or be unexported (golint)
  • Line 112: warning: exported type CRStatus should have comment or be unexported (golint)
  • Line 126: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 142: warning: exported type ChallengeStatusList should have comment or be unexported (golint)
  • Line 149: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• pkg/issuer/venafi/client/fake/connector.go
  • Line 25: warning: exported type Connector should have comment or be unexported (golint)
  • Line 35: warning: exported method Connector.Default should have comment or be unexported (golint)
  • Line 42: warning: exported method Connector.Ping should have comment or be unexported (golint)
  • Line 49: warning: exported method Connector.ReadZoneConfiguration should have comment or be unexported (golint)
  • Line 56: warning: exported method Connector.RetrieveCertificate should have comment or be unexported (golint)
  • Line 63: warning: exported method Connector.RequestCertificate should have comment or be unexported (golint)
  • Line 70: warning: exported method Connector.RenewCertificate should have comment or be unexported (golint)

• pkg/webhook/server/server.go
  • Line 53: warning: exported var ErrNotListening should have comment or be unexported (golint)
  • Line 76: warning: exported type Server should have comment or be unexported (golint)
  • Line 119: warning: exported method Server.Run should have comment or be unexported (golint)

• test/e2e/suite/issuers/vault/certificaterequest/approle.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• test/unit/gen/challenge.go
  • Line 24: warning: exported type ChallengeModifier should have comment or be unexported (golint)
  • Line 26: warning: exported function Challenge should have comment or be unexported (golint)
  • Line 36: warning: exported function ChallengeFrom should have comment or be unexported (golint)
  • Line 44: warning: exported function SetChallengeNamespace should have comment or be unexported (golint)
  • Line 50: warning: exported function SetChallengeType should have comment or be unexported (golint)
  • Line 56: warning: exported function SetChallengeToken should have comment or be unexported (golint)
  • Line 62: warning: comment on exported function SetChallengeIssuer should be of the form "SetChallengeIssuer ..." (golint)
  • Line 69: warning: exported function SetChallengeDNSName should have comment or be unexported (golint)
  • Line 75: warning: exported function SetChallengePresented should have comment or be unexported (golint)
  • Line 81: warning: exported function SetChallengeWildcard should have comment or be unexported (golint)
  • Line 87: warning: exported function SetChallengeState should have comment or be unexported (golint)
  • Line 93: warning: exported function SetChallengeReason should have comment or be unexported (golint)
  • Line 99: warning: exported function SetChallengeURL should have comment or be unexported (golint)
  • Line 105: warning: exported function SetChallengeProcessing should have comment or be unexported (golint)

• internal/apis/certmanager/v1beta1/types_certificate.go
  • Line 55: warning: comment on exported type PrivateKeyAlgorithm should be of the form "PrivateKeyAlgorithm ..." (with optional leading article) (golint)
  • Line 59: warning: comment on exported const RSAKeyAlgorithm should be of the form "RSAKeyAlgorithm ..." (golint)
  • Line 62: warning: comment on exported const ECDSAKeyAlgorithm should be of the form "ECDSAKeyAlgorithm ..." (golint)
  • Line 66: warning: comment on exported type PrivateKeyEncoding should be of the form "PrivateKeyEncoding ..." (with optional leading article) (golint)
  • Line 239: warning: comment on exported type PrivateKeyRotationPolicy should be of the form "PrivateKeyRotationPolicy ..." (with optional leading article) (golint)
  • Line 297: warning: comment on exported type JKSKeystore should be of the form "JKSKeystore ..." (with optional leading article) (golint)
  • Line 312: warning: comment on exported type PKCS12Keystore should be of the form "PKCS12Keystore ..." (with optional leading article) (golint)
  • Line 429: warning: comment on exported const CertificateConditionIssuing should be of the form "CertificateConditionIssuing ..." (golint)

• test/e2e/framework/addon/vault/setup.go
  • Line 53: warning: exported function NewVaultTokenSecret should have comment or be unexported (golint)
  • Line 64: warning: exported function NewVaultAppRoleSecret should have comment or be unexported (golint)
  • Line 75: warning: exported function NewVaultServiceAccount should have comment or be unexported (golint)
  • Line 83: warning: exported function NewVaultServiceAccountRole should have comment or be unexported (golint)
  • Line 103: warning: exported function NewVaultServiceAccountClusterRoleBinding should have comment or be unexported (golint)
  • Line 123: warning: exported function NewVaultKubernetesSecret should have comment or be unexported (golint)
  • Line 135: warning: comment on exported method VaultInitializer.Init should be of the form "Init ..." (golint)
  • Line 155: warning: comment on exported method VaultInitializer.Setup should be of the form "Setup ..." (golint)
  • Line 219: warning: exported method VaultInitializer.Clean should have comment or be unexported (golint)
  • Line 232: warning: exported method VaultInitializer.CreateAppRole should have comment or be unexported (golint)
  • Line 234: warning: don't use underscores in Go names; var role_path should be rolePath (golint)
  • Line 270: warning: exported method VaultInitializer.CleanAppRole should have comment or be unexported (golint)
  • Line 503: warning: don't use underscores in Go names; var role_path should be rolePath (golint)

• pkg/controller/certificaterequests/selfsigned/selfsigned.go
  • Line 44: warning: exported const CRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported type SelfSigned should have comment or be unexported (golint)
  • Line 70: warning: exported function NewSelfSigned should have comment or be unexported (golint)
  • Line 80: warning: exported method SelfSigned.Sign should have comment or be unexported (golint)

• pkg/issuer/factory.go
  • Line 28: warning: comment on exported type IssuerConstructor should be of the form "IssuerConstructor ..." (with optional leading article) (golint)
  • Line 37: warning: comment on exported function RegisterIssuer should be of the form "RegisterIssuer ..." (golint)

• pkg/issuer/issuer.go
  • Line 23: warning: exported type Interface should have comment or be unexported (golint)
  • Line 30: warning: exported type IssueResponse should have comment or be unexported (golint)

• test/e2e/suite/issuers/venafi/tpp/certificate.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• cmd/ctl/pkg/install/helm/resource.go
  • Line 33: warning: comment on exported function ParseMultiDocumentYAML should be of the form "ParseMultiDocumentYAML ..." (golint)
  • Line 57: warning: comment on exported function FetchResources should be of the form "FetchResources ..." (golint)
  • Line 79: warning: comment on exported function FilterCrdResources should be of the form "FilterCrdResources ..." (golint)

• pkg/issuer/acme/dns/webhook/webhook.go
  • Line 37: warning: exported type Webhook should have comment or be unexported (golint)
  • Line 41: warning: exported method Webhook.Name should have comment or be unexported (golint)
  • Line 117: warning: exported method Webhook.Initialize should have comment or be unexported (golint)

• test/e2e/suite/conformance/rbac/issuer.go
  • Line 20: warning: should not use dot imports (golint)
  • Line 21: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/vault/certificate/approle_custom_mount.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• internal/apis/acme/v1beta1/types_order.go
  • Line 49: warning: exported type OrderSpec should have comment or be unexported (golint)
  • Line 86: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 166: warning: comment on exported type ACMEChallenge should be of the form "ACMEChallenge ..." (with optional leading article) (golint)

• internal/apis/meta/v1/register.go
  • Line 36: warning: exported var AddToScheme should have comment or be unexported (golint)

• cmd/util/defaults.go
  • Line 24: warning: exported const DefaultLeaderElect should have comment (or a comment on this block) or be unexported (golint)

• pkg/apis/meta/doc.go
  • Line 22: warning: exported const GroupName should have comment or be unexported (golint)

• pkg/controller/certificaterequests/ca/ca.go
  • Line 41: warning: exported const CRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type CA should have comment or be unexported (golint)
  • Line 67: warning: exported function NewCA should have comment or be unexported (golint)

• pkg/issuer/acme/http/http.go
  • Line 149: warning: exported method Solver.Check should have comment or be unexported (golint)

• test/e2e/framework/helper/kubectl.go
  • Line 26: warning: exported type Kubectl should have comment or be unexported (golint)
  • Line 33: warning: exported method Kubectl.Describe should have comment or be unexported (golint)
  • Line 38: warning: exported method Kubectl.DescribeResource should have comment or be unexported (golint)
  • Line 42: warning: exported method Helper.Kubectl should have comment or be unexported (golint)
  • Line 51: warning: exported method Kubectl.Run should have comment or be unexported (golint)

• internal/apis/certmanager/types_certificaterequest.go
  • Line 26: warning: comment on exported const CertificateRequestReasonPending should be of the form "CertificateRequestReasonPending ..." (golint)
  • Line 29: warning: comment on exported const CertificateRequestReasonFailed should be of the form "CertificateRequestReasonFailed ..." (golint)
  • Line 33: warning: comment on exported const CertificateRequestReasonIssued should be of the form "CertificateRequestReasonIssued ..." (golint)

• pkg/controller/certificate-shim/ingresses/controller.go
  • Line 37: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)

• test/e2e/framework/config/venafi.go
  • Line 30: warning: exported type VenafiTPPConfiguration should have comment or be unexported (golint)
  • Line 38: warning: exported type VenafiCloudConfiguration should have comment or be unexported (golint)
  • Line 43: warning: exported method Venafi.AddFlags should have comment or be unexported (golint)
  • Line 48: warning: exported method Venafi.Validate should have comment or be unexported (golint)
  • Line 52: warning: exported method VenafiTPPConfiguration.AddFlags should have comment or be unexported (golint)
  • Line 60: warning: exported method VenafiTPPConfiguration.Validate should have comment or be unexported (golint)
  • Line 64: warning: exported method VenafiCloudConfiguration.AddFlags should have comment or be unexported (golint)
  • Line 69: warning: exported method VenafiCloudConfiguration.Validate should have comment or be unexported (golint)

• test/e2e/suite/approval/approval.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/venafi/tpp/certificaterequest.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/unit/gen/certificatesigningrequest.go
  • Line 28: warning: exported type CertificateSigningRequestModifier should have comment or be unexported (golint)
  • Line 30: warning: exported function CertificateSigningRequest should have comment or be unexported (golint)
  • Line 44: warning: exported function CertificateSigningRequestWithRandomName should have comment or be unexported (golint)
  • Line 58: warning: exported function CertificateSigningRequestFrom should have comment or be unexported (golint)
  • Line 66: warning: exported function SetCertificateSigningRequestIsCA should have comment or be unexported (golint)
  • Line 72: warning: exported function SetCertificateSigningRequestRequest should have comment or be unexported (golint)
  • Line 78: warning: exported function AddCertificateSigningRequestAnnotations should have comment or be unexported (golint)
  • Line 92: warning: exported function SetCertificateSigningRequestSignerName should have comment or be unexported (golint)
  • Line 98: warning: exported function SetCertificateSigningRequestDuration should have comment or be unexported (golint)
  • Line 104: warning: exported function SetCertificateSigningRequestCertificate should have comment or be unexported (golint)
  • Line 110: warning: exported function SetCertificateSigningRequestStatusCondition should have comment or be unexported (golint)
  • Line 127: warning: exported function SetCertificateSigningRequestUsername should have comment or be unexported (golint)
  • Line 133: warning: exported function SetCertificateSigningRequestGroups should have comment or be unexported (golint)
  • Line 139: warning: exported function SetCertificateSigningRequestUID should have comment or be unexported (golint)
  • Line 145: warning: exported function SetCertificateSigningRequestExtra should have comment or be unexported (golint)
  • Line 151: warning: exported function SetCertificateSigningRequestUsages should have comment or be unexported (golint)

• internal/apis/acme/v1/register.go
  • Line 36: warning: exported var AddToScheme should have comment or be unexported (golint)

• test/e2e/framework/framework.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)
  • Line 51: warning: comment on exported var Scheme should be of the form "Scheme ..." (golint)
  • Line 244: warning: exported method Framework.Helper should have comment or be unexported (golint)
  • Line 248: warning: exported method Framework.CertificateDurationValid should have comment or be unexported (golint)
  • Line 266: warning: exported method Framework.CertificateRequestDurationValid should have comment or be unexported (golint)
  • Line 286: warning: exported function ConformanceDescribe should have comment or be unexported (golint)

• internal/apis/certmanager/v1beta1/types_certificaterequest.go
  • Line 26: warning: comment on exported const CertificateRequestReasonPending should be of the form "CertificateRequestReasonPending ..." (golint)
  • Line 29: warning: comment on exported const CertificateRequestReasonFailed should be of the form "CertificateRequestReasonFailed ..." (golint)
  • Line 33: warning: comment on exported const CertificateRequestReasonIssued should be of the form "CertificateRequestReasonIssued ..." (golint)
  • Line 37: warning: comment on exported const CertificateRequestReasonDenied should be of the form "CertificateRequestReasonDenied ..." (golint)

• pkg/apis/certmanager/v1/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/controller/certificatesigningrequests/util/conditions.go
  • Line 31: warning: exported function CertificateSigningRequestIsApproved should have comment or be unexported (golint)
  • Line 40: warning: exported function CertificateSigningRequestIsDenied should have comment or be unexported (golint)
  • Line 49: warning: exported function CertificateSigningRequestIsFailed should have comment or be unexported (golint)
  • Line 58: warning: exported function CertificateSigningRequestSetFailed should have comment or be unexported (golint)

• test/e2e/framework/config/samplewebhook.go
  • Line 23: warning: exported type DNS01Webhook should have comment or be unexported (golint)
  • Line 31: warning: exported method DNS01Webhook.AddFlags should have comment or be unexported (golint)
  • Line 36: warning: exported method DNS01Webhook.Validate should have comment or be unexported (golint)
  • Line 36: warning: receiver name n should be consistent with previous receiver name d for DNS01Webhook (golint)

• test/e2e/suite/issuers/vault/certificate/approle.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/ca/issuer.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• test/integration/ctl/install_framework/framework.go
  • Line 17: warning: don't use an underscore in package name (golint)
  • Line 30: warning: exported type TestInstallApiServer should have comment or be unexported (golint)
  • Line 39: warning: exported type CleanupFunction should have comment or be unexported (golint)
  • Line 41: warning: exported function NewTestInstallApiServer should have comment or be unexported (golint)
  • Line 106: warning: exported method TestInstallApiServer.KubeConfig should have comment or be unexported (golint)

• internal/apis/acme/v1alpha2/const.go
  • Line 20: warning: exported const ACMEFinalizer should have comment (or a comment on this block) or be unexported (golint)

• internal/apis/certmanager/v1beta1/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/controller/certificate-shim/gateways/controller.go
  • Line 38: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)

• pkg/controller/certificaterequests/approver/sync.go
  • Line 32: warning: exported const ApprovedMessage should have comment (or a comment on this block) or be unexported (golint)

• test/e2e/suite/conformance/import.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• test/unit/gen/conditions.go
  • Line 26: warning: exported type IssuerConditionModifier should have comment or be unexported (golint)
  • Line 28: warning: exported function IssuerCondition should have comment or be unexported (golint)
  • Line 38: warning: exported function IssuerConditionFrom should have comment or be unexported (golint)
  • Line 46: warning: exported function SetIssuerConditionStatus should have comment or be unexported (golint)
  • Line 52: warning: exported function SetIssuerConditionLastTransitionTime should have comment or be unexported (golint)
  • Line 58: warning: exported function SetIssuerConditionReason should have comment or be unexported (golint)
  • Line 64: warning: exported function SetIssuerConditionMessage should have comment or be unexported (golint)

• internal/apis/config/webhook/validation/validation.go
  • Line 27: warning: exported function ValidateWebhookConfiguration should have comment or be unexported (golint)

• internal/apis/certmanager/v1beta1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1beta1 ..." (golint)

• pkg/controller/acmeorders/selectors/labels.go
  • Line 25: warning: exported function Labels should have comment or be unexported (golint)

• pkg/controller/context.go
  • Line 94: warning: exported type IssuerOptions should have comment or be unexported (golint)
  • Line 109: warning: exported type ACMEOptions should have comment or be unexported (golint)
  • Line 156: warning: exported type CertificateOptions should have comment or be unexported (golint)
  • Line 165: warning: exported type SchedulerOptions should have comment or be unexported (golint)

• test/e2e/framework/util/errors/errors.go
  • Line 25: warning: exported function IsSkip should have comment or be unexported (golint)
  • Line 32: warning: exported function NewSkip should have comment or be unexported (golint)

• pkg/util/pki/csr.go
  • Line 39: warning: exported function IPAddressesForCertificate should have comment or be unexported (golint)
  • Line 51: warning: exported function URIsForCertificate should have comment or be unexported (golint)
  • Line 60: warning: exported function DNSNamesForCertificate should have comment or be unexported (golint)
  • Line 69: warning: exported function URLsFromStrings should have comment or be unexported (golint)
  • Line 90: warning: exported function IPAddressesToString should have comment or be unexported (golint)
  • Line 98: warning: exported function URLsToString should have comment or be unexported (golint)
  • Line 146: warning: exported function BuildKeyUsages should have comment or be unexported (golint)
  • Line 169: warning: exported function BuildCertManagerKeyUsages should have comment or be unexported (golint)
  • Line 339: warning: comment on exported function GenerateTemplateFromCertificateRequest should be of the form "GenerateTemplateFromCertificateRequest ..." (golint)
  • Line 350: warning: exported function GenerateTemplateFromCSRPEM should have comment or be unexported (golint)
  • Line 358: warning: exported function GenerateTemplateFromCSRPEMWithUsages should have comment or be unexported (golint)

• test/e2e/util/util.go
  • Line 52: warning: exported function CertificateOnlyValidForDomains should have comment or be unexported (golint)
  • Line 59: warning: exported function WaitForIssuerStatusFunc should have comment or be unexported (golint)
  • Line 166: warning: comment on exported function NewCertManagerBasicCertificate should be of the form "NewCertManagerBasicCertificate ..." (golint)
  • Line 194: warning: comment on exported function NewCertManagerBasicCertificateRequest should be of the form "NewCertManagerBasicCertificateRequest ..." (golint)
  • Line 275: warning: exported function NewCertManagerVaultCertificate should have comment or be unexported (golint)
  • Line 293: warning: exported function NewIngress should have comment or be unexported (golint)
  • Line 333: warning: exported function NewV1Beta1Ingress should have comment or be unexported (golint)
  • Line 373: warning: exported function NewGateway should have comment or be unexported (golint)

• cmd/ctl/pkg/install/helm/applycrd.go
  • Line 27: warning: comment on exported function CreateCRDs should be of the form "CreateCRDs ..." (golint)

• cmd/webhook/app/options/options.go
  • Line 37: warning: exported function NewWebhookFlags should have comment or be unexported (golint)
  • Line 41: warning: exported method WebhookFlags.AddFlags should have comment or be unexported (golint)
  • Line 45: warning: exported function ValidateWebhookFlags should have comment or be unexported (golint)
  • Line 50: warning: exported function NewWebhookConfiguration should have comment or be unexported (golint)
  • Line 64: warning: exported function AddConfigFlags should have comment or be unexported (golint)

• internal/apis/acme/v1alpha2/conversion.go
  • Line 25: warning: exported function Convert_v1alpha2_ChallengeSpec_To_acme_ChallengeSpec should have comment or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; func Convert_v1alpha2_ChallengeSpec_To_acme_ChallengeSpec should be ConvertV1alpha2ChallengeSpecToAcmeChallengeSpec (golint)
  • Line 45: warning: exported function Convert_acme_ChallengeSpec_To_v1alpha2_ChallengeSpec should have comment or be unexported (golint)
  • Line 45: warning: don't use underscores in Go names; func Convert_acme_ChallengeSpec_To_v1alpha2_ChallengeSpec should be ConvertAcmeChallengeSpecToV1alpha2ChallengeSpec (golint)
  • Line 65: warning: exported function Convert_v1alpha2_OrderSpec_To_acme_OrderSpec should have comment or be unexported (golint)
  • Line 65: warning: don't use underscores in Go names; func Convert_v1alpha2_OrderSpec_To_acme_OrderSpec should be ConvertV1alpha2OrderSpecToAcmeOrderSpec (golint)
  • Line 75: warning: exported function Convert_acme_OrderSpec_To_v1alpha2_OrderSpec should have comment or be unexported (golint)
  • Line 75: warning: don't use underscores in Go names; func Convert_acme_OrderSpec_To_v1alpha2_OrderSpec should be ConvertAcmeOrderSpecToV1alpha2OrderSpec (golint)
  • Line 87: warning: don't use underscores in Go names; func Convert_acme_ACMEIssuer_To_v1alpha2_ACMEIssuer should be ConvertAcmeACMEIssuerToV1alpha2ACMEIssuer (golint)
  • Line 93: warning: don't use underscores in Go names; func Convert_v1alpha2_ACMEIssuer_To_acme_ACMEIssuer should be ConvertV1alpha2ACMEIssuerToAcmeACMEIssuer (golint)

• internal/apis/certmanager/validation/certificate.go
  • Line 42: warning: exported function ValidateCertificateSpec should have comment or be unexported (golint)
  • Line 108: warning: exported function ValidateCertificate should have comment or be unexported (golint)
  • Line 114: warning: exported function ValidateUpdateCertificate should have comment or be unexported (golint)
  • Line 200: warning: exported function ValidateDuration should have comment or be unexported (golint)

• pkg/controller/certificates/trigger/policies/policies.go
  • Line 34: warning: exported type Input should have comment or be unexported (golint)
  • Line 73: warning: exported function NewTriggerPolicyChain should have comment or be unexported (golint)
  • Line 85: warning: exported function SecretDoesNotExist should have comment or be unexported (golint)
  • Line 92: warning: exported function SecretIsMissingData should have comment or be unexported (golint)
  • Line 107: warning: exported function SecretPublicKeysDiffer should have comment or be unexported (golint)
  • Line 119: warning: exported function SecretPrivateKeyMatchesSpec should have comment or be unexported (golint)
  • Line 140: warning: exported function SecretIssuerAnnotationsNotUpToDate should have comment or be unexported (golint)
  • Line 152: warning: exported function CurrentCertificateRequestNotValidForSpec should have comment or be unexported (golint)

• pkg/controller/test/recorder.go
  • Line 33: warning: exported method FakeRecorder.Event should have comment or be unexported (golint)
  • Line 37: warning: exported method FakeRecorder.Eventf should have comment or be unexported (golint)
  • Line 41: warning: exported method FakeRecorder.PastEventf should have comment or be unexported (golint)
  • Line 44: warning: exported method FakeRecorder.AnnotatedEventf should have comment or be unexported (golint)

• pkg/issuer/venafi/setup.go
  • Line 30: warning: exported method Venafi.Setup should have comment or be unexported (golint)

• pkg/logs/logs.go
  • Line 38: warning: exported var Log should have comment or be unexported (golint)
  • Line 44: warning: exported const ErrorLevel should have comment (or a comment on this block) or be unexported (golint)
  • Line 84: warning: exported const ResourceNameKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 95: warning: exported function WithResource should have comment or be unexported (golint)
  • Line 113: warning: exported function WithRelatedResource should have comment or be unexported (golint)
  • Line 131: warning: exported function WithRelatedResourceName should have comment or be unexported (golint)
  • Line 141: warning: exported function FromContext should have comment or be unexported (golint)
  • Line 152: warning: exported function NewContext should have comment or be unexported (golint)
  • Line 159: warning: exported function V should have comment or be unexported (golint)
  • Line 171: warning: exported function WithInfof should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/vault/vault_approle.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• pkg/webhook/server/tls/file_source.go
  • Line 69: warning: exported method FileCertificateSource.Run should have comment or be unexported (golint)
  • Line 108: warning: exported method FileCertificateSource.GetCertificate should have comment or be unexported (golint)
  • Line 117: warning: exported method FileCertificateSource.Healthy should have comment or be unexported (golint)

• test/e2e/suite/issuers/vault/issuer.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• internal/apis/acme/v1alpha2/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• cmd/webhook/app/testing/testwebhook.go
  • Line 45: warning: exported type StopFunc should have comment or be unexported (golint)
  • Line 47: warning: exported type ServerOptions should have comment or be unexported (golint)
  • Line 59: warning: context.Context should be the first parameter of a function (golint)
  • Line 59: warning: exported function StartWebhookServer should have comment or be unexported (golint)

• pkg/controller/certificaterequests/sync.go
  • Line 42: warning: exported method Controller.Sync should have comment or be unexported (golint)

• test/e2e/framework/config/certmanager.go
  • Line 23: warning: exported type CertManager should have comment or be unexported (golint)
  • Line 33: warning: exported method CertManager.AddFlags should have comment or be unexported (golint)
  • Line 38: warning: exported method CertManager.Validate should have comment or be unexported (golint)

• test/e2e/framework/config/gateway.go
  • Line 21: warning: exported type Gateway should have comment or be unexported (golint)
  • Line 33: warning: exported method Gateway.AddFlags should have comment or be unexported (golint)
  • Line 50: warning: exported method Gateway.Validate should have comment or be unexported (golint)

• test/e2e/framework/config/ingress_controller.go
  • Line 23: warning: exported type IngressController should have comment or be unexported (golint)
  • Line 34: warning: exported method IngressController.AddFlags should have comment or be unexported (golint)
  • Line 40: warning: exported method IngressController.Validate should have comment or be unexported (golint)

• internal/apis/config/webhook/v1alpha1/defaults.go
  • Line 30: warning: exported function SetDefaults_WebhookConfiguration should have comment or be unexported (golint)
  • Line 30: warning: don't use underscores in Go names; func SetDefaults_WebhookConfiguration should be SetDefaultsWebhookConfiguration (golint)

• internal/apis/meta/v1/conversion.go
  • Line 28: warning: don't use underscores in Go names; func Convert_meta_LocalObjectReference_To_v1_LocalObjectReference should be ConvertMetaLocalObjectReferenceToV1LocalObjectReference (golint)
  • Line 34: warning: don't use underscores in Go names; func Convert_v1_LocalObjectReference_To_meta_LocalObjectReference should be ConvertV1LocalObjectReferenceToMetaLocalObjectReference (golint)
  • Line 40: warning: don't use underscores in Go names; func Convert_meta_ObjectReference_To_v1_ObjectReference should be ConvertMetaObjectReferenceToV1ObjectReference (golint)
  • Line 46: warning: don't use underscores in Go names; func Convert_v1_ObjectReference_To_meta_ObjectReference should be ConvertV1ObjectReferenceToMetaObjectReference (golint)
  • Line 52: warning: don't use underscores in Go names; func Convert_meta_SecretKeySelector_To_v1_SecretKeySelector should be ConvertMetaSecretKeySelectorToV1SecretKeySelector (golint)
  • Line 58: warning: don't use underscores in Go names; func Convert_v1_SecretKeySelector_To_meta_SecretKeySelector should be ConvertV1SecretKeySelectorToMetaSecretKeySelector (golint)

• test/e2e/framework/config/config.go
  • Line 35: warning: exported type Config should have comment or be unexported (golint)
  • Line 52: warning: exported method Config.Validate should have comment or be unexported (golint)
  • Line 76: warning: comment on exported method Config.AddFlags should be of the form "AddFlags ..." (golint)

• test/e2e/suite/conformance/rbac/certificaterequest.go
  • Line 20: warning: should not use dot imports (golint)
  • Line 21: warning: should not use dot imports (golint)

• test/e2e/framework/addon/vault/vault.go
  • Line 17: warning: package comment should be of the form "Package vault ..." (golint)
  • Line 58: warning: exported type Details should have comment or be unexported (golint)
  • Line 80: warning: exported method Vault.Setup should have comment or be unexported (golint)
  • Line 186: warning: exported method Vault.SupportsGlobal should have comment or be unexported (golint)
  • Line 192: warning: exported method Vault.Logs should have comment or be unexported (golint)

• test/unit/gen/doc.go
  • Line 17: warning: package comment should be of the form "Package gen ..." (golint)

• internal/apis/config/webhook/v1alpha1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• internal/apis/certmanager/v1alpha3/types_certificate.go
  • Line 54: warning: comment on exported type KeyAlgorithm should be of the form "KeyAlgorithm ..." (with optional leading article) (golint)
  • Line 58: warning: comment on exported const RSAKeyAlgorithm should be of the form "RSAKeyAlgorithm ..." (golint)
  • Line 61: warning: comment on exported const ECDSAKeyAlgorithm should be of the form "ECDSAKeyAlgorithm ..." (golint)
  • Line 65: warning: comment on exported type KeyEncoding should be of the form "KeyEncoding ..." (with optional leading article) (golint)
  • Line 237: warning: comment on exported type PrivateKeyRotationPolicy should be of the form "PrivateKeyRotationPolicy ..." (with optional leading article) (golint)
  • Line 293: warning: comment on exported type JKSKeystore should be of the form "JKSKeystore ..." (with optional leading article) (golint)
  • Line 311: warning: comment on exported type PKCS12Keystore should be of the form "PKCS12Keystore ..." (with optional leading article) (golint)
  • Line 431: warning: comment on exported const CertificateConditionIssuing should be of the form "CertificateConditionIssuing ..." (golint)

• pkg/acme/client/middleware/logger.go
  • Line 34: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 49: warning: exported method Logger.AuthorizeOrder should have comment or be unexported (golint)
  • Line 58: warning: exported method Logger.GetOrder should have comment or be unexported (golint)
  • Line 67: warning: exported method Logger.FetchCert should have comment or be unexported (golint)
  • Line 76: warning: exported method Logger.ListCertAlternates should have comment or be unexported (golint)
  • Line 85: warning: exported method Logger.WaitOrder should have comment or be unexported (golint)
  • Line 94: warning: exported method Logger.CreateOrderCert should have comment or be unexported (golint)
  • Line 103: warning: exported method Logger.Accept should have comment or be unexported (golint)
  • Line 112: warning: exported method Logger.GetChallenge should have comment or be unexported (golint)
  • Line 121: warning: exported method Logger.GetAuthorization should have comment or be unexported (golint)
  • Line 130: warning: exported method Logger.WaitAuthorization should have comment or be unexported (golint)
  • Line 139: warning: exported method Logger.Register should have comment or be unexported (golint)
  • Line 148: warning: exported method Logger.GetReg should have comment or be unexported (golint)
  • Line 157: warning: exported method Logger.HTTP01ChallengeResponse should have comment or be unexported (golint)
  • Line 162: warning: exported method Logger.DNS01ChallengeRecord should have comment or be unexported (golint)
  • Line 167: warning: exported method Logger.Discover should have comment or be unexported (golint)
  • Line 176: warning: exported method Logger.UpdateReg should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/suite.go
  • Line 22: warning: should not use dot imports (golint)

• internal/apis/certmanager/v1alpha3/const.go
  • Line 22: warning: comment on exported const MinimumCertificateDuration should be of the form "MinimumCertificateDuration ..." (golint)
  • Line 25: warning: comment on exported const DefaultCertificateDuration should be of the form "DefaultCertificateDuration ..." (golint)
  • Line 28: warning: comment on exported const MinimumRenewBefore should be of the form "MinimumRenewBefore ..." (golint)
  • Line 31: warning: comment on exported const DefaultRenewBefore should be of the form "DefaultRenewBefore ..." (golint)
  • Line 36: warning: comment on exported const DefaultVaultTokenAuthSecretKey should be of the form "DefaultVaultTokenAuthSecretKey ..." (golint)
  • Line 39: warning: comment on exported const DefaultVaultKubernetesAuthMountPath should be of the form "DefaultVaultKubernetesAuthMountPath ..." (golint)

• pkg/controller/builder.go
  • Line 54: warning: comment on exported function NewBuilder should be of the form "NewBuilder ..." (golint)
  • Line 64: warning: exported method Builder.For should have comment or be unexported (golint)
  • Line 88: warning: exported method Builder.Complete should have comment or be unexported (golint)

• pkg/controller/certificates/metrics/controller.go
  • Line 54: warning: exported function NewController should have comment or be unexported (golint)

• pkg/controller/certificates/requestmanager/requestmanager_controller.go
  • Line 55: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 74: warning: exported function NewController should have comment or be unexported (golint)

• pkg/issuer/acme/dns/cloudflare/cloudflare.go
  • Line 32: warning: comment on exported type DNSProviderType should be of the form "DNSProviderType ..." (with optional leading article) (golint)
  • Line 92: warning: comment on exported function FindNearestZoneForFQDN should be of the form "FindNearestZoneForFQDN ..." (golint)

• test/e2e/suite/issuers/selfsigned/certificaterequest.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/vault/certificaterequest/approle_custom_mount.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• internal/apis/certmanager/validation/util/conditions.go
  • Line 23: warning: exported function GetCertificateRequestCondition should have comment or be unexported (golint)

• pkg/util/cmapichecker/cmapichecker.go
  • Line 35: warning: exported var ErrCertManagerCRDsNotFound should have comment or be unexported (golint)
  • Line 110: warning: exported type ApiCheckError should have comment or be unexported (golint)

• cmd/acmesolver/app/app.go
  • Line 30: warning: exported function NewACMESolverCommand should have comment or be unexported (golint)

• internal/apis/acme/v1alpha3/doc.go
  • Line 22: warning: package comment should be of the form "Package v1alpha3 ..." (golint)

• internal/apis/acme/v1beta1/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/conversion.go
  • Line 25: warning: exported function Convert_v1alpha2_CertificateSpec_To_certmanager_CertificateSpec should have comment or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; func Convert_v1alpha2_CertificateSpec_To_certmanager_CertificateSpec should be ConvertV1alpha2CertificateSpecToCertmanagerCertificateSpec (golint)
  • Line 67: warning: exported function Convert_certmanager_CertificateSpec_To_v1alpha2_CertificateSpec should have comment or be unexported (golint)
  • Line 67: warning: don't use underscores in Go names; func Convert_certmanager_CertificateSpec_To_v1alpha2_CertificateSpec should be ConvertCertmanagerCertificateSpecToV1alpha2CertificateSpec (golint)
  • Line 103: warning: exported function Convert_certmanager_X509Subject_To_v1alpha2_X509Subject should have comment or be unexported (golint)
  • Line 103: warning: don't use underscores in Go names; func Convert_certmanager_X509Subject_To_v1alpha2_X509Subject should be ConvertCertmanagerX509SubjectToV1alpha2X509Subject (golint)
  • Line 107: warning: exported function Convert_certmanager_CertificatePrivateKey_To_v1alpha2_CertificatePrivateKey should have comment or be unexported (golint)
  • Line 107: warning: don't use underscores in Go names; func Convert_certmanager_CertificatePrivateKey_To_v1alpha2_CertificatePrivateKey should be ConvertCertmanagerCertificatePrivateKeyToV1alpha2CertificatePrivateKey (golint)
  • Line 111: warning: exported function Convert_v1alpha2_CertificateRequestSpec_To_certmanager_CertificateRequestSpec should have comment or be unexported (golint)
  • Line 111: warning: don't use underscores in Go names; func Convert_v1alpha2_CertificateRequestSpec_To_certmanager_CertificateRequestSpec should be ConvertV1alpha2CertificateRequestSpecToCertmanagerCertificateRequestSpec (golint)
  • Line 120: warning: exported function Convert_certmanager_CertificateRequestSpec_To_v1alpha2_CertificateRequestSpec should have comment or be unexported (golint)
  • Line 120: warning: don't use underscores in Go names; func Convert_certmanager_CertificateRequestSpec_To_v1alpha2_CertificateRequestSpec should be ConvertCertmanagerCertificateRequestSpecToV1alpha2CertificateRequestSpec (golint)

• pkg/webhook/authority/authority.go
  • Line 90: warning: exported type SignFunc should have comment or be unexported (golint)
  • Line 94: warning: exported method DynamicAuthority.Run should have comment or be unexported (golint)

• test/e2e/framework/config/acme.go
  • Line 23: warning: exported type ACMEServer should have comment or be unexported (golint)
  • Line 34: warning: exported method ACMEServer.AddFlags should have comment or be unexported (golint)
  • Line 45: warning: exported method ACMEServer.Validate should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/external/external.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/certificatesigningrequests/venafi/cloud.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/acme/dnsproviders/dnsproviders.go
  • Line 30: warning: exported var ErrNoCredentials should have comment or be unexported (golint)
  • Line 33: warning: exported type Details should have comment or be unexported (golint)

• cmd/ctl/pkg/upgrade/migrateapiversion/migrator.go
  • Line 36: warning: exported type Migrator should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/types.go
  • Line 58: warning: comment on exported const IngressIssuerNameAnnotationKey should be of the form "IngressIssuerNameAnnotationKey ..." (golint)
  • Line 61: warning: comment on exported const IngressClusterIssuerNameAnnotationKey should be of the form "IngressClusterIssuerNameAnnotationKey ..." (golint)
  • Line 65: warning: comment on exported const IngressACMEIssuerHTTP01IngressClassAnnotationKey should be of the form "IngressACMEIssuerHTTP01IngressClassAnnotationKey ..." (golint)
  • Line 111: warning: comment on exported const WantInjectAPIServerCAAnnotation should be of the form "WantInjectAPIServerCAAnnotation ..." (golint)
  • Line 170: warning: exported const UsageSigning should have comment (or a comment on this block) or be unexported (golint)

• pkg/api/scheme.go
  • Line 50: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 51: warning: exported var Codecs should have comment or be unexported (golint)
  • Line 52: warning: exported var ParameterCodec should have comment or be unexported (golint)

• pkg/controller/certificates/revisionmanager/revisionmanager_controller.go
  • Line 47: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported function NewController should have comment or be unexported (golint)

• pkg/issuer/fake/helper.go
  • Line 25: warning: exported type Helper should have comment or be unexported (golint)
  • Line 31: warning: exported method Helper.GetGenericIssuer should have comment or be unexported (golint)

• pkg/issuer/venafi/client/request.go
  • Line 41: warning: exported var ErrorMissingSubject should have comment or be unexported (golint)
  • Line 43: warning: comment on exported method Venafi.RequestCertificate should be of the form "RequestCertificate ..." (golint)
  • Line 57: warning: exported method Venafi.RetrieveCertificate should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/acme/http01.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• cmd/ctl/pkg/install/install.go
  • Line 42: warning: exported type InstallOptions should have comment or be unexported (golint)
  • Line 81: warning: exported function NewCmdInstall should have comment or be unexported (golint)

• internal/apis/acme/v1alpha2/types_order.go
  • Line 48: warning: exported type OrderSpec should have comment or be unexported (golint)
  • Line 85: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 165: warning: comment on exported type ACMEChallenge should be of the form "ACMEChallenge ..." (with optional leading article) (golint)

• pkg/acme/webhook/apis/acme/v1alpha1/register.go
  • Line 40: warning: exported var AddToScheme should have comment or be unexported (golint)

• internal/test/paths/bazel.go
  • Line 43: warning: exported function CRDDirectory should have comment or be unexported (golint)

• pkg/controller/certificatesigningrequests/ca/ca.go
  • Line 45: warning: exported const CSRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported function NewCA should have comment or be unexported (golint)

• pkg/util/predicate/certificate.go
  • Line 34: warning: comment on exported function CertificateNextPrivateKeySecretName should be of the form "CertificateNextPrivateKeySecretName ..." (golint)

• test/e2e/suite/issuers/acme/issuer.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• internal/apis/acme/v1beta1/conversion.go
  • Line 27: warning: don't use underscores in Go names; func Convert_acme_ACMEIssuer_To_v1beta1_ACMEIssuer should be ConvertAcmeACMEIssuerToV1beta1ACMEIssuer (golint)
  • Line 33: warning: don't use underscores in Go names; func Convert_v1beta1_ACMEIssuer_To_acme_ACMEIssuer should be ConvertV1beta1ACMEIssuerToAcmeACMEIssuer (golint)

• internal/apis/certmanager/v1alpha2/doc.go
  • Line 22: warning: package comment should be of the form "Package v1alpha2 ..." (golint)

• internal/apis/certmanager/v1alpha3/types_issuer.go
  • Line 92: warning: comment on exported type IssuerConfig should be of the form "IssuerConfig ..." (with optional leading article) (golint)
  • Line 122: warning: comment on exported type VenafiIssuer should be of the form "VenafiIssuer ..." (with optional leading article) (golint)
  • Line 174: warning: comment on exported type SelfSignedIssuer should be of the form "SelfSignedIssuer ..." (with optional leading article) (golint)
  • Line 184: warning: comment on exported type VaultIssuer should be of the form "VaultIssuer ..." (with optional leading article) (golint)
  • Line 210: warning: comment on exported type VaultAuth should be of the form "VaultAuth ..." (with optional leading article) (golint)
  • Line 246: warning: comment on exported type VaultKubernetesAuth should be of the form "VaultKubernetesAuth ..." (with optional leading article) (golint)
  • Line 266: warning: exported type CAIssuer should have comment or be unexported (golint)

• pkg/apis/acme/v1/types_challenge.go
  • Line 56: warning: exported type ChallengeSpec should have comment or be unexported (golint)
  • Line 104: warning: comment on exported type ACMEChallengeType should be of the form "ACMEChallengeType ..." (with optional leading article) (golint)
  • Line 118: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• pkg/acme/webhook/cmd/cmd.go
  • Line 32: warning: exported function RunWebhookServer should have comment or be unexported (golint)

• pkg/issuer/venafi/client/venaficlient.go
  • Line 40: warning: exported type VenafiClientBuilder should have comment or be unexported (golint)
  • Line 152: warning: exported method Venafi.Ping should have comment or be unexported (golint)
  • Line 156: warning: exported method Venafi.ReadZoneConfiguration should have comment or be unexported (golint)
  • Line 160: warning: exported method Venafi.SetClient should have comment or be unexported (golint)

• test/e2e/framework/cleanup.go
  • Line 23: warning: exported type CleanupActionHandle should have comment or be unexported (golint)

• pkg/acme/webhook/apis/acme/doc.go
  • Line 23: warning: exported const GroupName should have comment (or a comment on this block) or be unexported (golint)

• pkg/controller/certificatesigningrequests/controller.go
  • Line 41: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 107: warning: exported method Controller.Register should have comment or be unexported (golint)
  • Line 176: warning: exported method Controller.ProcessItem should have comment or be unexported (golint)

• pkg/webhook/admission/chain.go
  • Line 27: warning: exported type PluginChain should have comment or be unexported (golint)
  • Line 33: warning: exported method PluginChain.Handles should have comment or be unexported (golint)
  • Line 42: warning: exported method PluginChain.Validate should have comment or be unexported (golint)
  • Line 58: warning: exported method PluginChain.Mutate should have comment or be unexported (golint)

• pkg/apis/acme/v1/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/apis/meta/v1/types.go
  • Line 39: warning: comment on exported type LocalObjectReference should be of the form "LocalObjectReference ..." (with optional leading article) (golint)
  • Line 63: warning: comment on exported type SecretKeySelector should be of the form "SecretKeySelector ..." (with optional leading article) (golint)
  • Line 77: warning: comment on exported const TLSCAKey should be of the form "TLSCAKey ..." (golint)

• pkg/controller/test/reactors.go
  • Line 28: warning: exported function NTimesReactor should have comment or be unexported (golint)
  • Line 42: warning: exported function ObjectCreatedReactor should have comment or be unexported (golint)
  • Line 61: warning: exported function ObjectDeletedReactor should have comment or be unexported (golint)

• test/e2e/framework/helper/validation/certificates/certificates.go
  • Line 251: warning: comment on exported function ExpectKeyUsageUsageDigitalSignature should be of the form "ExpectKeyUsageUsageDigitalSignature ..." (golint)

• test/e2e/suite/issuers/doc.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• test/e2e/framework/helper/pod_start.go
  • Line 46: warning: exported method Helper.WaitForAllPodsRunningInNamespaceTimeout should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/tests.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 42: warning: comment on exported method Suite.Define should be of the form "Define ..." (golint)

• pkg/acme/webhook/cmd/server/start.go
  • Line 36: warning: exported type WebhookServerOptions should have comment or be unexported (golint)
  • Line 46: warning: exported function NewWebhookServerOptions should have comment or be unexported (golint)
  • Line 66: warning: exported function NewCommandStartWebhookServer should have comment or be unexported (golint)
  • Line 92: warning: exported method WebhookServerOptions.Validate should have comment or be unexported (golint)
  • Line 96: warning: exported method WebhookServerOptions.Complete should have comment or be unexported (golint)
  • Line 100: warning: exported method WebhookServerOptions.Config should have comment or be unexported (golint)
  • Line 121: warning: exported method WebhookServerOptions.RunWebhookServer should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/selfsigned/selfsigned.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/certificatesigningrequests/acme/dns01.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• internal/apis/acme/validation/challenge.go
  • Line 29: warning: exported function ValidateChallengeUpdate should have comment or be unexported (golint)
  • Line 44: warning: exported function ValidateChallenge should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha3/generic_issuer.go
  • Line 26: warning: exported type GenericIssuer should have comment or be unexported (golint)
  • Line 38: warning: exported method ClusterIssuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 41: warning: exported method ClusterIssuer.GetSpec should have comment or be unexported (golint)
  • Line 44: warning: exported method ClusterIssuer.GetStatus should have comment or be unexported (golint)
  • Line 47: warning: exported method ClusterIssuer.SetSpec should have comment or be unexported (golint)
  • Line 50: warning: exported method ClusterIssuer.SetStatus should have comment or be unexported (golint)
  • Line 53: warning: exported method ClusterIssuer.Copy should have comment or be unexported (golint)
  • Line 56: warning: exported method Issuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 59: warning: exported method Issuer.GetSpec should have comment or be unexported (golint)
  • Line 62: warning: exported method Issuer.GetStatus should have comment or be unexported (golint)
  • Line 65: warning: exported method Issuer.SetSpec should have comment or be unexported (golint)
  • Line 68: warning: exported method Issuer.SetStatus should have comment or be unexported (golint)
  • Line 71: warning: exported method Issuer.Copy should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method IssuerStatus.ACMEStatus should be of the form "ACMEStatus ..." (golint)

• internal/controller/feature/features.go
  • Line 27: warning: comment on exported const ValidateCAA should be of the form "ValidateCAA ..." (golint)
  • Line 32: warning: comment on exported const ExperimentalCertificateSigningRequestControllers should be of the form "ExperimentalCertificateSigningRequestControllers ..." (golint)
  • Line 38: warning: comment on exported const ExperimentalGatewayAPISupport should be of the form "ExperimentalGatewayAPISupport ..." (golint)
  • Line 44: warning: comment on exported const AdditionalCertificateOutputFormats should be of the form "AdditionalCertificateOutputFormats ..." (golint)

• pkg/acme/accounts/test/registry.go
  • Line 39: warning: exported method FakeRegistry.AddClient should have comment or be unexported (golint)
  • Line 43: warning: exported method FakeRegistry.RemoveClient should have comment or be unexported (golint)
  • Line 47: warning: exported method FakeRegistry.GetClient should have comment or be unexported (golint)
  • Line 51: warning: exported method FakeRegistry.ListClients should have comment or be unexported (golint)

• pkg/controller/certificates/util.go
  • Line 37: warning: comment on exported const RetryAfterLastFailure should be of the form "RetryAfterLastFailure ..." (golint)

• test/e2e/framework/helper/validation/certificatesigningrequests/certificatesigningrequests.go
  • Line 41: warning: comment on exported function ExpectValidCertificate should be of the form "ExpectValidCertificate ..." (golint)
  • Line 254: warning: comment on exported function ExpectKeyUsageUsageDigitalSignature should be of the form "ExpectKeyUsageUsageDigitalSignature ..." (golint)
  • Line 347: warning: comment on exported function ExpectConditiotNotDenied should be of the form "ExpectConditiotNotDenied ..." (golint)

• test/e2e/suite/issuers/venafi/import.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• test/e2e/suite/issuers/acme/certificate/notafter.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/certificates/venafi/venafi.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• internal/apis/acme/v1alpha3/types_issuer.go
  • Line 133: warning: exported const HS256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 138: warning: comment on exported type ACMEChallengeSolver should be of the form "ACMEChallengeSolver ..." (with optional leading article) (golint)
  • Line 162: warning: comment on exported type CertificateDNSNameSelector should be of the form "CertificateDNSNameSelector ..." (with optional leading article) (golint)
  • Line 217: warning: exported type ACMEChallengeSolverHTTP01Ingress should have comment or be unexported (golint)
  • Line 248: warning: exported type ACMEChallengeSolverHTTP01GatewayHTTPRoute should have comment or be unexported (golint)
  • Line 260: warning: exported type ACMEChallengeSolverHTTP01IngressPodTemplate should have comment or be unexported (golint)
  • Line 276: warning: exported type ACMEChallengeSolverHTTP01IngressPodObjectMeta should have comment or be unexported (golint)
  • Line 286: warning: exported type ACMEChallengeSolverHTTP01IngressPodSpec should have comment or be unexported (golint)
  • Line 310: warning: exported type ACMEChallengeSolverHTTP01IngressTemplate should have comment or be unexported (golint)
  • Line 319: warning: exported type ACMEChallengeSolverHTTP01IngressObjectMeta should have comment or be unexported (golint)
  • Line 329: warning: comment on exported type ACMEChallengeSolverDNS01 should be of the form "ACMEChallengeSolverDNS01 ..." (with optional leading article) (golint)
  • Line 505: warning: exported type AzureManagedIdentity should have comment or be unexported (golint)
  • Line 515: warning: comment on exported type AzureDNSEnvironment should be of the form "AzureDNSEnvironment ..." (with optional leading article) (golint)
  • Line 519: warning: exported const AzurePublicCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 586: warning: exported type ACMEIssuerStatus should have comment or be unexported (golint)

• cmd/ctl/pkg/status/certificate/certificate.go
  • Line 294: warning: context.Context should be the first parameter of a function (golint)
  • Line 329: warning: context.Context should be the first parameter of a function (golint)
  • Line 351: warning: context.Context should be the first parameter of a function (golint)
  • Line 379: warning: context.Context should be the first parameter of a function (golint)

• pkg/scheduler/test/fake.go
  • Line 33: warning: exported method FakeScheduler.Add should have comment or be unexported (golint)
  • Line 37: warning: exported method FakeScheduler.Forget should have comment or be unexported (golint)

• pkg/webhook/handlers/interfaces.go
  • Line 26: warning: exported type ValidatingAdmissionHook should have comment or be unexported (golint)
  • Line 32: warning: exported type MutatingAdmissionHook should have comment or be unexported (golint)
  • Line 38: warning: exported type ConversionHook should have comment or be unexported (golint)

• pkg/webhook/server/tls/source.go
  • Line 26: warning: exported var ErrNotAvailable should have comment or be unexported (golint)
  • Line 29: warning: exported type CertificateSource should have comment or be unexported (golint)

• test/integration/ctl/ctl_status_certificate_test.go
  • Line 569: warning: context.Context should be the first parameter of a function (golint)
  • Line 580: warning: context.Context should be the first parameter of a function (golint)
  • Line 604: warning: context.Context should be the first parameter of a function (golint)
  • Line 621: warning: context.Context should be the first parameter of a function (golint)
  • Line 640: warning: context.Context should be the first parameter of a function (golint)

• internal/apis/acme/types_issuer.go
  • Line 122: warning: exported const HS256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 127: warning: comment on exported type ACMEChallengeSolver should be of the form "ACMEChallengeSolver ..." (with optional leading article) (golint)
  • Line 148: warning: comment on exported type CertificateDNSNameSelector should be of the form "CertificateDNSNameSelector ..." (with optional leading article) (golint)
  • Line 198: warning: exported type ACMEChallengeSolverHTTP01Ingress should have comment or be unexported (golint)
  • Line 225: warning: exported type ACMEChallengeSolverHTTP01GatewayHTTPRoute should have comment or be unexported (golint)
  • Line 237: warning: exported type ACMEChallengeSolverHTTP01IngressPodTemplate should have comment or be unexported (golint)
  • Line 252: warning: exported type ACMEChallengeSolverHTTP01IngressPodObjectMeta should have comment or be unexported (golint)
  • Line 260: warning: exported type ACMEChallengeSolverHTTP01IngressPodSpec should have comment or be unexported (golint)
  • Line 280: warning: exported type ACMEChallengeSolverHTTP01IngressTemplate should have comment or be unexported (golint)
  • Line 288: warning: exported type ACMEChallengeSolverHTTP01IngressObjectMeta should have comment or be unexported (golint)
  • Line 296: warning: comment on exported type ACMEChallengeSolverDNS01 should be of the form "ACMEChallengeSolverDNS01 ..." (with optional leading article) (golint)
  • Line 437: warning: exported type AzureManagedIdentity should have comment or be unexported (golint)
  • Line 443: warning: exported type AzureDNSEnvironment should have comment or be unexported (golint)
  • Line 446: warning: exported const AzurePublicCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 509: warning: exported type ACMEIssuerStatus should have comment or be unexported (golint)

• internal/apis/acme/v1beta1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1beta1 ..." (golint)

• internal/apis/certmanager/register.go
  • Line 27: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/acme/util.go
  • Line 38: warning: exported function IsFailureState should have comment or be unexported (golint)

• internal/vault/fake/client.go
  • Line 25: warning: exported type Client should have comment or be unexported (golint)
  • Line 31: warning: exported function NewFakeClient should have comment or be unexported (golint)
  • Line 40: warning: exported method Client.WithNewRequest should have comment or be unexported (golint)
  • Line 45: warning: exported method Client.WithRawRequest should have comment or be unexported (golint)
  • Line 52: warning: exported method Client.NewRequest should have comment or be unexported (golint)
  • Line 56: warning: exported method Client.SetToken should have comment or be unexported (golint)
  • Line 60: warning: exported method Client.Token should have comment or be unexported (golint)
  • Line 64: warning: exported method Client.RawRequest should have comment or be unexported (golint)
  • Line 68: warning: exported method Client.Sys should have comment or be unexported (golint)

• pkg/apis/experimental/doc.go
  • Line 23: warning: exported const GroupName should have comment or be unexported (golint)

• pkg/controller/acmeorders/selectors/dns_zones.go
  • Line 26: warning: exported function DNSZones should have comment or be unexported (golint)

• pkg/controller/certificates/issuing/issuing_controller.go
  • Line 56: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 86: warning: exported function NewController should have comment or be unexported (golint)

• pkg/controller/util.go
  • Line 174: warning: comment on exported function BuildAnnotationsToCopy should be of the form "BuildAnnotationsToCopy ..." (golint)

• pkg/util/pki/keyusage.go
  • Line 91: warning: exported function ExtKeyUsageFromOID should have comment or be unexported (golint)

• test/e2e/suite/issuers/acme/certificaterequest/http01.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 36: warning: should not use dot imports (golint)

• test/integration/framework/apiserver.go
  • Line 50: warning: exported type StopFunc should have comment or be unexported (golint)
  • Line 59: warning: exported type RunControlPlaneOption should have comment or be unexported (golint)
  • Line 77: warning: context.Context should be the first parameter of a function (golint)
  • Line 77: warning: exported function RunControlPlane should have comment or be unexported (golint)

• cmd/ctl/pkg/inspect/inspect.go
  • Line 28: warning: exported function NewCmdInspect should have comment or be unexported (golint)

• internal/apis/acme/v1beta1/const.go
  • Line 20: warning: exported const ACMEFinalizer should have comment (or a comment on this block) or be unexported (golint)

• internal/apis/certmanager/v1beta1/types.go
  • Line 58: warning: comment on exported const IngressIssuerNameAnnotationKey should be of the form "IngressIssuerNameAnnotationKey ..." (golint)
  • Line 61: warning: comment on exported const IngressClusterIssuerNameAnnotationKey should be of the form "IngressClusterIssuerNameAnnotationKey ..." (golint)
  • Line 65: warning: comment on exported const IngressACMEIssuerHTTP01IngressClassAnnotationKey should be of the form "IngressACMEIssuerHTTP01IngressClassAnnotationKey ..." (golint)
  • Line 111: warning: comment on exported const WantInjectAPIServerCAAnnotation should be of the form "WantInjectAPIServerCAAnnotation ..." (golint)
  • Line 170: warning: exported const UsageSigning should have comment (or a comment on this block) or be unexported (golint)

• pkg/apis/certmanager/v1/types_certificaterequest.go
  • Line 26: warning: comment on exported const CertificateRequestReasonPending should be of the form "CertificateRequestReasonPending ..." (golint)
  • Line 29: warning: comment on exported const CertificateRequestReasonFailed should be of the form "CertificateRequestReasonFailed ..." (golint)
  • Line 33: warning: comment on exported const CertificateRequestReasonIssued should be of the form "CertificateRequestReasonIssued ..." (golint)
  • Line 37: warning: comment on exported const CertificateRequestReasonDenied should be of the form "CertificateRequestReasonDenied ..." (golint)

• internal/apis/certmanager/validation/certificaterequest.go
  • Line 41: warning: exported function ValidateCertificateRequest should have comment or be unexported (golint)
  • Line 50: warning: exported function ValidateUpdateCertificateRequest should have comment or be unexported (golint)
  • Line 86: warning: exported function ValidateCertificateRequestSpec should have comment or be unexported (golint)

• pkg/controller/certificatesigningrequests/venafi/venafi.go
  • Line 47: warning: exported const CSRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 70: warning: exported function NewVenafi should have comment or be unexported (golint)

• test/e2e/framework/helper/featureset/featureset.go
  • Line 86: warning: exported type Feature should have comment or be unexported (golint)
  • Line 115: warning: comment on exported const ReusePrivateKeyFeature should be of the form "ReusePrivateKeyFeature ..." (golint)
  • Line 119: warning: comment on exported const URISANsFeature should be of the form "URISANsFeature ..." (golint)
  • Line 123: warning: comment on exported const EmailSANsFeature should be of the form "EmailSANsFeature ..." (golint)
  • Line 127: warning: comment on exported const CommonNameFeature should be of the form "CommonNameFeature ..." (golint)
  • Line 133: warning: comment on exported const KeyUsagesFeature should be of the form "KeyUsagesFeature ..." (golint)

• test/e2e/suite/issuers/selfsigned/certificate.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• internal/apis/config/webhook/register.go
  • Line 27: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• internal/webhook/feature/features.go
  • Line 34: warning: comment on exported const AdditionalCertificateOutputFormats should be of the form "AdditionalCertificateOutputFormats ..." (golint)

• internal/plugin/admission/apideprecation/apideprecation.go
  • Line 31: warning: exported const PluginName should have comment or be unexported (golint)
  • Line 62: warning: exported function NewPlugin should have comment or be unexported (golint)

• pkg/apis/acme/v1/types_issuer.go
  • Line 133: warning: exported const HS256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 218: warning: exported type ACMEChallengeSolverHTTP01Ingress should have comment or be unexported (golint)
  • Line 263: warning: exported type ACMEChallengeSolverHTTP01IngressPodTemplate should have comment or be unexported (golint)
  • Line 279: warning: exported type ACMEChallengeSolverHTTP01IngressPodObjectMeta should have comment or be unexported (golint)
  • Line 289: warning: exported type ACMEChallengeSolverHTTP01IngressPodSpec should have comment or be unexported (golint)
  • Line 313: warning: exported type ACMEChallengeSolverHTTP01IngressTemplate should have comment or be unexported (golint)
  • Line 322: warning: exported type ACMEChallengeSolverHTTP01IngressObjectMeta should have comment or be unexported (golint)
  • Line 332: warning: comment on exported type ACMEChallengeSolverDNS01 should be of the form "ACMEChallengeSolverDNS01 ..." (with optional leading article) (golint)
  • Line 508: warning: exported type AzureManagedIdentity should have comment or be unexported (golint)
  • Line 518: warning: comment on exported type AzureDNSEnvironment should be of the form "AzureDNSEnvironment ..." (with optional leading article) (golint)
  • Line 522: warning: exported const AzurePublicCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 589: warning: exported type ACMEIssuerStatus should have comment or be unexported (golint)

• pkg/controller/acmeorders/selectors/dns_names.go
  • Line 25: warning: exported function DNSNames should have comment or be unexported (golint)

• pkg/controller/controller.go
  • Line 47: warning: exported function NewController should have comment or be unexported (golint)

• pkg/controller/issuers/controller.go
  • Line 147: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)

• pkg/issuer/acme/http/solver/solver.go
  • Line 28: warning: exported type HTTP01Solver should have comment or be unexported (golint)
  • Line 38: warning: exported method HTTP01Solver.Listen should have comment or be unexported (golint)

• pkg/util/version.go
  • Line 24: warning: exported type Version should have comment or be unexported (golint)
  • Line 40: warning: exported function VersionInfo should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/ca/ca.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• test/unit/discovery/discovery.go
  • Line 29: warning: exported type Discovery should have comment or be unexported (golint)
  • Line 41: warning: exported function NewDiscovery should have comment or be unexported (golint)
  • Line 55: warning: exported method Discovery.WithServerGroups should have comment or be unexported (golint)
  • Line 60: warning: exported method Discovery.WithServerResourcesForGroupVersion should have comment or be unexported (golint)
  • Line 65: warning: exported method Discovery.ServerResourcesForGroupVersion should have comment or be unexported (golint)
  • Line 69: warning: exported method Discovery.ServerResources should have comment or be unexported (golint)
  • Line 73: warning: exported method Discovery.ServerGroupsAndResources should have comment or be unexported (golint)
  • Line 77: warning: exported method Discovery.ServerPreferredResources should have comment or be unexported (golint)
  • Line 81: warning: exported method Discovery.ServerPreferredNamespacedResources should have comment or be unexported (golint)
  • Line 85: warning: exported method Discovery.ServerGroups should have comment or be unexported (golint)
  • Line 89: warning: exported method Discovery.ServerVersion should have comment or be unexported (golint)
  • Line 93: warning: exported method Discovery.OpenAPISchema should have comment or be unexported (golint)
  • Line 97: warning: exported method Discovery.RESTClient should have comment or be unexported (golint)

• cmd/ctl/pkg/upgrade/upgrade.go
  • Line 28: warning: exported function NewCmdUpgrade should have comment or be unexported (golint)

• pkg/ctl/scheme.go
  • Line 20: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• pkg/controller/certificatesigningrequests/vault/vault.go
  • Line 44: warning: exported const CSRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported function NewVault should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/selfsigned/selfsigned.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/rbac/certificate.go
  • Line 20: warning: should not use dot imports (golint)
  • Line 21: warning: should not use dot imports (golint)

• test/e2e/framework/helper/certificaterequests.go
  • Line 207: warning: exported method Helper.WaitCertificateRequestIssuedValid should have comment or be unexported (golint)
  • Line 211: warning: exported method Helper.WaitCertificateRequestIssuedValidTLS should have comment or be unexported (golint)

• test/unit/listers/order.go
  • Line 29: warning: exported type FakeOrderLister should have comment or be unexported (golint)
  • Line 34: warning: exported type FakeOrderNamespaceLister should have comment or be unexported (golint)
  • Line 39: warning: exported function NewFakeOrderLister should have comment or be unexported (golint)
  • Line 51: warning: exported function NewFakeOrderNamespaceLister should have comment or be unexported (golint)
  • Line 62: warning: exported method FakeOrderLister.List should have comment or be unexported (golint)
  • Line 66: warning: exported method FakeOrderLister.Orders should have comment or be unexported (golint)
  • Line 70: warning: exported method FakeOrderNamespaceLister.List should have comment or be unexported (golint)
  • Line 74: warning: exported method FakeOrderNamespaceLister.Get should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/acme/acme.go
  • Line 23: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/acme/doc.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• test/unit/gen/secret.go
  • Line 23: warning: exported type SecretModifier should have comment or be unexported (golint)
  • Line 25: warning: exported function Secret should have comment or be unexported (golint)
  • Line 35: warning: exported function SecretFrom should have comment or be unexported (golint)
  • Line 43: warning: exported function SetSecretNamespace should have comment or be unexported (golint)
  • Line 49: warning: exported function SetSecretAnnotations should have comment or be unexported (golint)
  • Line 58: warning: exported function SetSecretData should have comment or be unexported (golint)

• pkg/controller/certificaterequests/approver/approver.go
  • Line 36: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 84: warning: exported method Controller.ProcessItem should have comment or be unexported (golint)

• test/e2e/suite/secrettemplate/secrettemplate.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• internal/ingress/convert.go
  • Line 57: warning: don't use underscores in Go names; func Convert_networking_Ingress_To_v1beta1_Ingress should be ConvertNetworkingIngressToV1beta1Ingress (golint)
  • Line 74: warning: don't use underscores in Go names; func autoConvert_networking_Ingress_To_v1beta1_Ingress should be autoConvertNetworkingIngressToV1beta1Ingress (golint)
  • Line 85: warning: exported function Convert_networking_IngressSpec_To_v1beta1_IngressSpec should have comment or be unexported (golint)
  • Line 85: warning: don't use underscores in Go names; func Convert_networking_IngressSpec_To_v1beta1_IngressSpec should be ConvertNetworkingIngressSpecToV1beta1IngressSpec (golint)
  • Line 98: warning: don't use underscores in Go names; func autoConvert_networking_IngressSpec_To_v1beta1_IngressSpec should be autoConvertNetworkingIngressSpecToV1beta1IngressSpec (golint)
  • Line 116: warning: exported function Convert_networking_IngressStatus_To_v1beta1_IngressStatus should have comment or be unexported (golint)
  • Line 116: warning: don't use underscores in Go names; func Convert_networking_IngressStatus_To_v1beta1_IngressStatus should be ConvertNetworkingIngressStatusToV1beta1IngressStatus (golint)
  • Line 120: warning: don't use underscores in Go names; func autoConvert_networking_IngressStatus_To_v1beta1_IngressStatus should be autoConvertNetworkingIngressStatusToV1beta1IngressStatus (golint)
  • Line 127: warning: exported function Convert_core_LoadBalancerStatus_To_v1_LoadBalancerStatus should have comment or be unexported (golint)
  • Line 127: warning: don't use underscores in Go names; func Convert_core_LoadBalancerStatus_To_v1_LoadBalancerStatus should be ConvertCoreLoadBalancerStatusToV1LoadBalancerStatus (golint)
  • Line 131: warning: don't use underscores in Go names; func autoConvert_core_LoadBalancerStatus_To_v1_LoadBalancerStatus should be autoConvertCoreLoadBalancerStatusToV1LoadBalancerStatus (golint)
  • Line 136: warning: exported function Convert_networking_IngressRule_To_v1beta1_IngressRule should have comment or be unexported (golint)
  • Line 136: warning: don't use underscores in Go names; func Convert_networking_IngressRule_To_v1beta1_IngressRule should be ConvertNetworkingIngressRuleToV1beta1IngressRule (golint)
  • Line 140: warning: don't use underscores in Go names; func autoConvert_networking_IngressRule_To_v1beta1_IngressRule should be autoConvertNetworkingIngressRuleToV1beta1IngressRule (golint)
  • Line 148: warning: exported function Convert_networking_IngressRuleValue_To_v1beta1_IngressRuleValue should have comment or be unexported (golint)
  • Line 148: warning: don't use underscores in Go names; func Convert_networking_IngressRuleValue_To_v1beta1_IngressRuleValue should be ConvertNetworkingIngressRuleValueToV1beta1IngressRuleValue (golint)
  • Line 152: warning: don't use underscores in Go names; func autoConvert_networking_IngressRuleValue_To_v1beta1_IngressRuleValue should be autoConvertNetworkingIngressRuleValueToV1beta1IngressRuleValue (golint)
  • Line 165: warning: exported function Convert_networking_HTTPIngressRuleValue_To_v1beta1_HTTPIngressRuleValue should have comment or be unexported (golint)
  • Line 165: warning: don't use underscores in Go names; func Convert_networking_HTTPIngressRuleValue_To_v1beta1_HTTPIngressRuleValue should be ConvertNetworkingHTTPIngressRuleValueToV1beta1HTTPIngressRuleValue (golint)
  • Line 169: warning: don't use underscores in Go names; func autoConvert_networking_HTTPIngressRuleValue_To_v1beta1_HTTPIngressRuleValue should be autoConvertNetworkingHTTPIngressRuleValueToV1beta1HTTPIngressRuleValue (golint)
  • Line 184: warning: exported function Convert_networking_HTTPIngressPath_To_v1beta1_HTTPIngressPath should have comment or be unexported (golint)
  • Line 184: warning: don't use underscores in Go names; func Convert_networking_HTTPIngressPath_To_v1beta1_HTTPIngressPath should be ConvertNetworkingHTTPIngressPathToV1beta1HTTPIngressPath (golint)
  • Line 188: warning: don't use underscores in Go names; func autoConvert_networking_HTTPIngressPath_To_v1beta1_HTTPIngressPath should be autoConvertNetworkingHTTPIngressPathToV1beta1HTTPIngressPath (golint)
  • Line 197: warning: exported function Convert_networking_IngressBackend_To_v1beta1_IngressBackend should have comment or be unexported (golint)
  • Line 197: warning: don't use underscores in Go names; func Convert_networking_IngressBackend_To_v1beta1_IngressBackend should be ConvertNetworkingIngressBackendToV1beta1IngressBackend (golint)
  • Line 212: warning: don't use underscores in Go names; func autoConvert_networking_IngressBackend_To_v1beta1_IngressBackend should be autoConvertNetworkingIngressBackendToV1beta1IngressBackend (golint)
  • Line 227: warning: don't use underscores in Go names; func Convert_v1beta1_Ingress_To_networking_Ingress should be ConvertV1beta1IngressToNetworkingIngress (golint)
  • Line 231: warning: don't use underscores in Go names; func autoConvert_v1beta1_Ingress_To_networking_Ingress should be autoConvertV1beta1IngressToNetworkingIngress (golint)
  • Line 242: warning: exported function Convert_v1beta1_IngressSpec_To_networking_IngressSpec should have comment or be unexported (golint)
  • Line 242: warning: don't use underscores in Go names; func Convert_v1beta1_IngressSpec_To_networking_IngressSpec should be ConvertV1beta1IngressSpecToNetworkingIngressSpec (golint)
  • Line 255: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressSpec_To_networking_IngressSpec should be autoConvertV1beta1IngressSpecToNetworkingIngressSpec (golint)
  • Line 273: warning: exported function Convert_v1beta1_IngressStatus_To_networking_IngressStatus should have comment or be unexported (golint)
  • Line 273: warning: don't use underscores in Go names; func Convert_v1beta1_IngressStatus_To_networking_IngressStatus should be ConvertV1beta1IngressStatusToNetworkingIngressStatus (golint)
  • Line 277: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressStatus_To_networking_IngressStatus should be autoConvertV1beta1IngressStatusToNetworkingIngressStatus (golint)
  • Line 284: warning: exported function Convert_v1_LoadBalancerStatus_To_core_LoadBalancerStatus should have comment or be unexported (golint)
  • Line 284: warning: don't use underscores in Go names; func Convert_v1_LoadBalancerStatus_To_core_LoadBalancerStatus should be ConvertV1LoadBalancerStatusToCoreLoadBalancerStatus (golint)
  • Line 288: warning: don't use underscores in Go names; func autoConvert_v1_LoadBalancerStatus_To_core_LoadBalancerStatus should be autoConvertV1LoadBalancerStatusToCoreLoadBalancerStatus (golint)
  • Line 293: warning: exported function Convert_v1beta1_IngressRule_To_networking_IngressRule should have comment or be unexported (golint)
  • Line 293: warning: don't use underscores in Go names; func Convert_v1beta1_IngressRule_To_networking_IngressRule should be ConvertV1beta1IngressRuleToNetworkingIngressRule (golint)
  • Line 297: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressRule_To_networking_IngressRule should be autoConvertV1beta1IngressRuleToNetworkingIngressRule (golint)
  • Line 305: warning: exported function Convert_v1beta1_IngressRuleValue_To_networking_IngressRuleValue should have comment or be unexported (golint)
  • Line 305: warning: don't use underscores in Go names; func Convert_v1beta1_IngressRuleValue_To_networking_IngressRuleValue should be ConvertV1beta1IngressRuleValueToNetworkingIngressRuleValue (golint)
  • Line 309: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressRuleValue_To_networking_IngressRuleValue should be autoConvertV1beta1IngressRuleValueToNetworkingIngressRuleValue (golint)
  • Line 322: warning: exported function Convert_v1beta1_HTTPIngressRuleValue_To_networking_HTTPIngressRuleValue should have comment or be unexported (golint)
  • Line 322: warning: don't use underscores in Go names; func Convert_v1beta1_HTTPIngressRuleValue_To_networking_HTTPIngressRuleValue should be ConvertV1beta1HTTPIngressRuleValueToNetworkingHTTPIngressRuleValue (golint)
  • Line 326: warning: don't use underscores in Go names; func autoConvert_v1beta1_HTTPIngressRuleValue_To_networking_HTTPIngressRuleValue should be autoConvertV1beta1HTTPIngressRuleValueToNetworkingHTTPIngressRuleValue (golint)
  • Line 341: warning: exported function Convert_v1beta1_HTTPIngressPath_To_networking_HTTPIngressPath should have comment or be unexported (golint)
  • Line 341: warning: don't use underscores in Go names; func Convert_v1beta1_HTTPIngressPath_To_networking_HTTPIngressPath should be ConvertV1beta1HTTPIngressPathToNetworkingHTTPIngressPath (golint)
  • Line 345: warning: don't use underscores in Go names; func autoConvert_v1beta1_HTTPIngressPath_To_networking_HTTPIngressPath should be autoConvertV1beta1HTTPIngressPathToNetworkingHTTPIngressPath (golint)
  • Line 354: warning: exported function Convert_v1beta1_IngressBackend_To_networking_IngressBackend should have comment or be unexported (golint)
  • Line 354: warning: don't use underscores in Go names; func Convert_v1beta1_IngressBackend_To_networking_IngressBackend should be ConvertV1beta1IngressBackendToNetworkingIngressBackend (golint)
  • Line 367: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressBackend_To_networking_IngressBackend should be autoConvertV1beta1IngressBackendToNetworkingIngressBackend (golint)

• test/e2e/framework/util.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)
  • Line 34: warning: should not use dot imports (golint)
  • Line 41: warning: exported function Failf should have comment or be unexported (golint)
  • Line 47: warning: exported function Skipf should have comment or be unexported (golint)
  • Line 53: warning: comment on exported function RbacClusterRoleHasAccessToResource should be of the form "RbacClusterRoleHasAccessToResource ..." (golint)

• pkg/controller/cainjector/setup.go
  • Line 48: warning: exported var MutatingWebhookSetup should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/ca/ca.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• test/e2e/framework/helper/certificates.go
  • Line 94: warning: don't use underscores in Go names; var ready_true_condition should be readyTrueCondition (golint)
  • Line 99: warning: don't use underscores in Go names; var issuing_true_condition should be issuingTrueCondition (golint)
  • Line 133: warning: don't use underscores in Go names; var ready_false_condition should be readyFalseCondition (golint)
  • Line 138: warning: don't use underscores in Go names; var issuing_true_condition should be issuingTrueCondition (golint)

• test/e2e/suite/issuers/acme/dnsproviders/rfc2136.go
  • Line 24: warning: exported type RFC2136 should have comment or be unexported (golint)
  • Line 29: warning: exported method RFC2136.Setup should have comment or be unexported (golint)
  • Line 47: warning: exported method RFC2136.Deprovision should have comment or be unexported (golint)
  • Line 51: warning: exported method RFC2136.Details should have comment or be unexported (golint)
  • Line 55: warning: exported method RFC2136.SupportsGlobal should have comment or be unexported (golint)

• test/internal/apiserver/apiserver.go
  • Line 33: warning: exported type StopFunc should have comment or be unexported (golint)
  • Line 35: warning: exported function RunBareControlPlane should have comment or be unexported (golint)

• test/integration/webhook/dynamic_authority_test.go
  • Line 155: warning: context.Context should be the first parameter of a function (golint)

• internal/apis/acme/register.go
  • Line 27: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• internal/ingress/ingress_test.go
  • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/plugin/admission/certificaterequest/identity/certificaterequest_identity.go
  • Line 34: warning: exported const PluginName should have comment or be unexported (golint)
  • Line 50: warning: exported function NewPlugin should have comment or be unexported (golint)

• pkg/apis/certmanager/v1/generic_issuer.go
  • Line 26: warning: exported type GenericIssuer should have comment or be unexported (golint)
  • Line 38: warning: exported method ClusterIssuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 41: warning: exported method ClusterIssuer.GetSpec should have comment or be unexported (golint)
  • Line 44: warning: exported method ClusterIssuer.GetStatus should have comment or be unexported (golint)
  • Line 47: warning: exported method ClusterIssuer.SetSpec should have comment or be unexported (golint)
  • Line 50: warning: exported method ClusterIssuer.SetStatus should have comment or be unexported (golint)
  • Line 53: warning: exported method ClusterIssuer.Copy should have comment or be unexported (golint)
  • Line 56: warning: exported method Issuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 59: warning: exported method Issuer.GetSpec should have comment or be unexported (golint)
  • Line 62: warning: exported method Issuer.GetStatus should have comment or be unexported (golint)
  • Line 65: warning: exported method Issuer.SetSpec should have comment or be unexported (golint)
  • Line 68: warning: exported method Issuer.SetStatus should have comment or be unexported (golint)
  • Line 71: warning: exported method Issuer.Copy should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method IssuerStatus.ACMEStatus should be of the form "ACMEStatus ..." (golint)

• pkg/apis/certmanager/v1/types_issuer.go
  • Line 96: warning: comment on exported type IssuerConfig should be of the form "IssuerConfig ..." (with optional leading article) (golint)
  • Line 126: warning: comment on exported type VenafiIssuer should be of the form "VenafiIssuer ..." (with optional leading article) (golint)
  • Line 178: warning: comment on exported type SelfSignedIssuer should be of the form "SelfSignedIssuer ..." (with optional leading article) (golint)
  • Line 188: warning: comment on exported type VaultIssuer should be of the form "VaultIssuer ..." (with optional leading article) (golint)
  • Line 214: warning: comment on exported type VaultAuth should be of the form "VaultAuth ..." (with optional leading article) (golint)
  • Line 250: warning: comment on exported type VaultKubernetesAuth should be of the form "VaultKubernetesAuth ..." (with optional leading article) (golint)
  • Line 270: warning: exported type CAIssuer should have comment or be unexported (golint)

• pkg/util/kube/pki.go
  • Line 72: warning: exported function SecretTLSCertChain should have comment or be unexported (golint)
  • Line 117: warning: exported function SecretTLSKeyPair should have comment or be unexported (golint)
  • Line 144: warning: exported function SecretTLSCert should have comment or be unexported (golint)

• test/e2e/framework/helper/helper.go
  • Line 34: warning: exported function NewHelper should have comment or be unexported (golint)

• cmd/ctl/pkg/experimental/experimental.go
  • Line 30: warning: exported function NewCmdExperimental should have comment or be unexported (golint)

• internal/apis/acme/v1beta1/types_challenge.go
  • Line 55: warning: exported type ChallengeSpec should have comment or be unexported (golint)
  • Line 103: warning: comment on exported type ACMEChallengeType should be of the form "ACMEChallengeType ..." (with optional leading article) (golint)
  • Line 117: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• internal/apis/acme/v1beta1/types_issuer.go
  • Line 133: warning: exported const HS256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 138: warning: comment on exported type ACMEChallengeSolver should be of the form "ACMEChallengeSolver ..." (with optional leading article) (golint)
  • Line 162: warning: comment on exported type CertificateDNSNameSelector should be of the form "CertificateDNSNameSelector ..." (with optional leading article) (golint)
  • Line 216: warning: exported type ACMEChallengeSolverHTTP01Ingress should have comment or be unexported (golint)
  • Line 247: warning: exported type ACMEChallengeSolverHTTP01GatewayHTTPRoute should have comment or be unexported (golint)
  • Line 259: warning: exported type ACMEChallengeSolverHTTP01IngressPodTemplate should have comment or be unexported (golint)
  • Line 275: warning: exported type ACMEChallengeSolverHTTP01IngressPodObjectMeta should have comment or be unexported (golint)
  • Line 285: warning: exported type ACMEChallengeSolverHTTP01IngressPodSpec should have comment or be unexported (golint)
  • Line 309: warning: exported type ACMEChallengeSolverHTTP01IngressTemplate should have comment or be unexported (golint)
  • Line 318: warning: exported type ACMEChallengeSolverHTTP01IngressObjectMeta should have comment or be unexported (golint)
  • Line 328: warning: comment on exported type ACMEChallengeSolverDNS01 should be of the form "ACMEChallengeSolverDNS01 ..." (with optional leading article) (golint)
  • Line 504: warning: exported type AzureManagedIdentity should have comment or be unexported (golint)
  • Line 514: warning: comment on exported type AzureDNSEnvironment should be of the form "AzureDNSEnvironment ..." (with optional leading article) (golint)
  • Line 518: warning: exported const AzurePublicCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 585: warning: exported type ACMEIssuerStatus should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/const.go
  • Line 22: warning: comment on exported const MinimumCertificateDuration should be of the form "MinimumCertificateDuration ..." (golint)
  • Line 25: warning: comment on exported const DefaultCertificateDuration should be of the form "DefaultCertificateDuration ..." (golint)
  • Line 28: warning: comment on exported const MinimumRenewBefore should be of the form "MinimumRenewBefore ..." (golint)
  • Line 31: warning: comment on exported const DefaultRenewBefore should be of the form "DefaultRenewBefore ..." (golint)
  • Line 36: warning: comment on exported const DefaultVaultTokenAuthSecretKey should be of the form "DefaultVaultTokenAuthSecretKey ..." (golint)
  • Line 39: warning: comment on exported const DefaultVaultKubernetesAuthMountPath should be of the form "DefaultVaultKubernetesAuthMountPath ..." (golint)

• pkg/acme/client/fake.go
  • Line 51: warning: exported method FakeACME.AuthorizeOrder should have comment or be unexported (golint)
  • Line 58: warning: exported method FakeACME.GetOrder should have comment or be unexported (golint)
  • Line 65: warning: exported method FakeACME.FetchCert should have comment or be unexported (golint)
  • Line 72: warning: exported method FakeACME.WaitOrder should have comment or be unexported (golint)
  • Line 79: warning: exported method FakeACME.CreateOrderCert should have comment or be unexported (golint)
  • Line 86: warning: exported method FakeACME.Accept should have comment or be unexported (golint)
  • Line 93: warning: exported method FakeACME.GetChallenge should have comment or be unexported (golint)
  • Line 100: warning: exported method FakeACME.GetAuthorization should have comment or be unexported (golint)
  • Line 107: warning: exported method FakeACME.WaitAuthorization should have comment or be unexported (golint)
  • Line 114: warning: exported method FakeACME.Register should have comment or be unexported (golint)
  • Line 121: warning: exported method FakeACME.GetReg should have comment or be unexported (golint)
  • Line 128: warning: exported method FakeACME.HTTP01ChallengeResponse should have comment or be unexported (golint)
  • Line 135: warning: exported method FakeACME.DNS01ChallengeRecord should have comment or be unexported (golint)
  • Line 142: warning: exported method FakeACME.Discover should have comment or be unexported (golint)
  • Line 151: warning: exported method FakeACME.UpdateReg should have comment or be unexported (golint)
  • Line 158: warning: exported method FakeACME.ListCertAlternates should have comment or be unexported (golint)

• pkg/util/util.go
  • Line 29: warning: exported function OnlyOneNotNil should have comment or be unexported (golint)
  • Line 42: warning: exported function EqualSorted should have comment or be unexported (golint)
  • Line 56: warning: exported function EqualUnsorted should have comment or be unexported (golint)
  • Line 73: warning: comment on exported function EqualURLsUnsorted should be of the form "EqualURLsUnsorted ..." (golint)
  • Line 97: warning: comment on exported function EqualIPsUnsorted should be of the form "EqualIPsUnsorted ..." (golint)
  • Line 124: warning: comment on exported function EqualKeyUsagesUnsorted should be of the form "EqualKeyUsagesUnsorted ..." (golint)
  • Line 157: warning: exported function RandStringRunes should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/venafi/tpp.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• internal/apis/acme/v1alpha3/conversion.go
  • Line 25: warning: exported function Convert_v1alpha3_ChallengeSpec_To_acme_ChallengeSpec should have comment or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; func Convert_v1alpha3_ChallengeSpec_To_acme_ChallengeSpec should be ConvertV1alpha3ChallengeSpecToAcmeChallengeSpec (golint)
  • Line 45: warning: exported function Convert_acme_ChallengeSpec_To_v1alpha3_ChallengeSpec should have comment or be unexported (golint)
  • Line 45: warning: don't use underscores in Go names; func Convert_acme_ChallengeSpec_To_v1alpha3_ChallengeSpec should be ConvertAcmeChallengeSpecToV1alpha3ChallengeSpec (golint)
  • Line 65: warning: exported function Convert_v1alpha3_OrderSpec_To_acme_OrderSpec should have comment or be unexported (golint)
  • Line 65: warning: don't use underscores in Go names; func Convert_v1alpha3_OrderSpec_To_acme_OrderSpec should be ConvertV1alpha3OrderSpecToAcmeOrderSpec (golint)
  • Line 75: warning: exported function Convert_acme_OrderSpec_To_v1alpha3_OrderSpec should have comment or be unexported (golint)
  • Line 75: warning: don't use underscores in Go names; func Convert_acme_OrderSpec_To_v1alpha3_OrderSpec should be ConvertAcmeOrderSpecToV1alpha3OrderSpec (golint)
  • Line 87: warning: don't use underscores in Go names; func Convert_acme_ACMEIssuer_To_v1alpha3_ACMEIssuer should be ConvertAcmeACMEIssuerToV1alpha3ACMEIssuer (golint)
  • Line 93: warning: don't use underscores in Go names; func Convert_v1alpha3_ACMEIssuer_To_acme_ACMEIssuer should be ConvertV1alpha3ACMEIssuerToAcmeACMEIssuer (golint)

• internal/apis/acme/v1alpha3/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• internal/apis/certmanager/v1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1 ..." (golint)

• pkg/acme/webhook/registry/challengepayload/challenge_payload.go
  • Line 32: warning: exported type REST should have comment or be unexported (golint)
  • Line 40: warning: exported function NewREST should have comment or be unexported (golint)
  • Line 46: warning: exported method REST.New should have comment or be unexported (golint)
  • Line 50: warning: exported method REST.GroupVersionKind should have comment or be unexported (golint)
  • Line 54: warning: exported method REST.NamespaceScoped should have comment or be unexported (golint)
  • Line 58: warning: exported method REST.Create should have comment or be unexported (golint)

• pkg/apis/acme/doc.go
  • Line 22: warning: exported const GroupName should have comment or be unexported (golint)

• pkg/apis/config/webhook/v1alpha1/types.go
  • Line 23: warning: exported type WebhookConfiguration should have comment or be unexported (golint)

• internal/apis/certmanager/validation/clusterissuer.go
  • Line 29: warning: exported function ValidateClusterIssuer should have comment or be unexported (golint)
  • Line 35: warning: exported function ValidateUpdateClusterIssuer should have comment or be unexported (golint)

• pkg/issuer/fake/issuer.go
  • Line 26: warning: exported type Issuer should have comment or be unexported (golint)

• pkg/issuer/venafi/client/fake/venafi.go
  • Line 27: warning: exported type Venafi should have comment or be unexported (golint)
  • Line 34: warning: exported method Venafi.Ping should have comment or be unexported (golint)
  • Line 38: warning: exported method Venafi.RequestCertificate should have comment or be unexported (golint)
  • Line 42: warning: exported method Venafi.RetrieveCertificate should have comment or be unexported (golint)
  • Line 46: warning: exported method Venafi.ReadZoneConfiguration should have comment or be unexported (golint)
  • Line 50: warning: exported method Venafi.SetClient should have comment or be unexported (golint)

• pkg/webhook/admission/handler.go
  • Line 24: warning: exported type Handler should have comment or be unexported (golint)
  • Line 28: warning: exported method Handler.Handles should have comment or be unexported (golint)
  • Line 34: warning: exported function NewHandler should have comment or be unexported (golint)

• test/e2e/suite/issuers/ca/certificaterequest.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• test/unit/gen/order.go
  • Line 28: warning: exported type OrderModifier should have comment or be unexported (golint)
  • Line 30: warning: exported function Order should have comment or be unexported (golint)
  • Line 40: warning: exported function OrderFrom should have comment or be unexported (golint)
  • Line 48: warning: comment on exported function SetOrderIssuer should be of the form "SetOrderIssuer ..." (golint)
  • Line 55: warning: exported function SetOrderDNSNames should have comment or be unexported (golint)
  • Line 61: warning: exported function SetOrderIPAddresses should have comment or be unexported (golint)
  • Line 67: warning: exported function SetOrderURL should have comment or be unexported (golint)
  • Line 73: warning: exported function SetOrderState should have comment or be unexported (golint)
  • Line 79: warning: exported function SetOrderReason should have comment or be unexported (golint)
  • Line 85: warning: exported function SetOrderStatus should have comment or be unexported (golint)
  • Line 91: warning: exported function SetOrderCertificate should have comment or be unexported (golint)
  • Line 97: warning: exported function SetOrderCommonName should have comment or be unexported (golint)
  • Line 103: warning: exported function SetOrderNamespace should have comment or be unexported (golint)
  • Line 109: warning: exported function SetOrderCsr should have comment or be unexported (golint)
  • Line 115: warning: exported function SetOrderDuration should have comment or be unexported (golint)
  • Line 121: warning: exported function SetOrderAnnotations should have comment or be unexported (golint)
  • Line 127: warning: exported function SetOrderOwnerReference should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha3/types.go
  • Line 58: warning: comment on exported const IngressIssuerNameAnnotationKey should be of the form "IngressIssuerNameAnnotationKey ..." (golint)
  • Line 61: warning: comment on exported const IngressClusterIssuerNameAnnotationKey should be of the form "IngressClusterIssuerNameAnnotationKey ..." (golint)
  • Line 65: warning: comment on exported const IngressACMEIssuerHTTP01IngressClassAnnotationKey should be of the form "IngressACMEIssuerHTTP01IngressClassAnnotationKey ..." (golint)
  • Line 111: warning: comment on exported const WantInjectAPIServerCAAnnotation should be of the form "WantInjectAPIServerCAAnnotation ..." (golint)
  • Line 170: warning: exported const UsageSigning should have comment (or a comment on this block) or be unexported (golint)

• pkg/acme/webhook/apiserver/apiserver.go
  • Line 38: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 66: warning: exported type Config should have comment or be unexported (golint)
  • Line 73: warning: exported type ExtraConfig should have comment or be unexported (golint)
  • Line 94: warning: exported type CompletedConfig should have comment or be unexported (golint)

• pkg/apis/certmanager/v1/types_certificate.go
  • Line 56: warning: comment on exported type PrivateKeyAlgorithm should be of the form "PrivateKeyAlgorithm ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported const RSAKeyAlgorithm should be of the form "RSAKeyAlgorithm ..." (golint)
  • Line 63: warning: comment on exported const ECDSAKeyAlgorithm should be of the form "ECDSAKeyAlgorithm ..." (golint)
  • Line 66: warning: comment on exported const Ed25519KeyAlgorithm should be of the form "Ed25519KeyAlgorithm ..." (golint)
  • Line 70: warning: comment on exported type PrivateKeyEncoding should be of the form "PrivateKeyEncoding ..." (with optional leading article) (golint)
  • Line 245: warning: comment on exported type PrivateKeyRotationPolicy should be of the form "PrivateKeyRotationPolicy ..." (with optional leading article) (golint)
  • Line 345: warning: comment on exported type JKSKeystore should be of the form "JKSKeystore ..." (with optional leading article) (golint)
  • Line 363: warning: comment on exported type PKCS12Keystore should be of the form "PKCS12Keystore ..." (with optional leading article) (golint)
  • Line 483: warning: comment on exported const CertificateConditionIssuing should be of the form "CertificateConditionIssuing ..." (golint)

• pkg/controller/acmechallenges/controller.go
  • Line 223: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)

• pkg/issuer/venafi/venafi.go
  • Line 49: warning: exported function NewVenafi should have comment or be unexported (golint)

• test/e2e/framework/config/helm.go
  • Line 25: warning: exported type Helm should have comment or be unexported (golint)
  • Line 30: warning: exported method Helm.AddFlags should have comment or be unexported (golint)
  • Line 34: warning: exported method Helm.Validate should have comment or be unexported (golint)

• test/e2e/suite/issuers/acme/dnsproviders/cloudflare.go
  • Line 47: warning: exported method Cloudflare.Setup should have comment or be unexported (golint)
  • Line 104: warning: exported method Cloudflare.Deprovision should have comment or be unexported (golint)
  • Line 109: warning: exported method Cloudflare.Details should have comment or be unexported (golint)
  • Line 113: warning: exported method Cloudflare.SupportsGlobal should have comment or be unexported (golint)
  • Line 117: warning: exported method Cloudflare.SetNamespace should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificatesigningrequests/vault/kubernetes.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/certificatesigningrequests/suite.go
  • Line 23: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/ca/clusterissuer.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• cmd/controller/app/start.go
  • Line 24: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 27: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 44: warning: exported type CertManagerControllerOptions should have comment or be unexported (golint)
  • Line 48: warning: exported function NewCertManagerControllerOptions should have comment or be unexported (golint)
  • Line 93: warning: exported method CertManagerControllerOptions.Validate should have comment or be unexported (golint)
  • Line 99: warning: exported method CertManagerControllerOptions.RunCertManagerController should have comment or be unexported (golint)

• internal/apis/meta/v1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1 ..." (golint)

• pkg/issuer/ca/ca.go
  • Line 42: warning: exported function NewCA should have comment or be unexported (golint)

• test/acme/dns/options.go
  • Line 100: warning: exported function SetResolvedFQDN should have comment or be unexported (golint)
  • Line 106: warning: exported function SetResolvedZone should have comment or be unexported (golint)
  • Line 112: warning: exported function SetAllowAmbientCredentials should have comment or be unexported (golint)
  • Line 118: warning: exported function SetConfig should have comment or be unexported (golint)
  • Line 128: warning: exported function SetStrict should have comment or be unexported (golint)
  • Line 134: warning: exported function SetUseAuthoritative should have comment or be unexported (golint)
  • Line 140: warning: exported function SetManifestPath should have comment or be unexported (golint)
  • Line 146: warning: exported function SetDNSServer should have comment or be unexported (golint)
  • Line 152: warning: exported function SetPollInterval should have comment or be unexported (golint)
  • Line 158: warning: exported function SetPropagationLimit should have comment or be unexported (golint)

• test/integration/ctl/ctl_install.go
  • Line 35: warning: exported function TestCtlInstall should have comment or be unexported (golint)
  • Line 90: warning: context.Context should be the first parameter of a function (golint)

• pkg/apis/config/webhook/v1alpha1/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• test/acme/dns/server/doc.go
  • Line 20: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• test/e2e/framework/util/config.go
  • Line 27: warning: exported function RestclientConfig should have comment or be unexported (golint)
  • Line 41: warning: exported function LoadConfig should have comment or be unexported (golint)

• internal/apis/acme/v1alpha3/types_order.go
  • Line 48: warning: exported type OrderSpec should have comment or be unexported (golint)
  • Line 85: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 165: warning: comment on exported type ACMEChallenge should be of the form "ACMEChallenge ..." (with optional leading article) (golint)

• cmd/webhook/app/webhook.go
  • Line 41: warning: exported function NewServerCommand should have comment or be unexported (golint)

• pkg/acme/webhook/apis/acme/v1alpha1/types.go
  • Line 121: warning: comment on exported const ChallengeActionCleanUp should be of the form "ChallengeActionCleanUp ..." (golint)

• pkg/apis/certmanager/v1/types.go
  • Line 177: warning: exported const UsageSigning should have comment (or a comment on this block) or be unexported (golint)

• pkg/acme/accounts/registry.go
  • Line 32: warning: comment on exported type Registry should be of the form "Registry ..." (with optional leading article) (golint)

• internal/apis/certmanager/validation/issuer.go
  • Line 37: warning: exported function ValidateIssuer should have comment or be unexported (golint)
  • Line 43: warning: exported function ValidateUpdateIssuer should have comment or be unexported (golint)
  • Line 50: warning: exported function ValidateIssuerSpec should have comment or be unexported (golint)
  • Line 54: warning: exported function ValidateIssuerConfig should have comment or be unexported (golint)
  • Line 106: warning: exported function ValidateACMEIssuerConfig should have comment or be unexported (golint)
  • Line 136: warning: exported function ValidateACMEIssuerChallengeSolverConfig should have comment or be unexported (golint)
  • Line 159: warning: exported function ValidateACMEIssuerChallengeSolverHTTP01Config should have comment or be unexported (golint)
  • Line 181: warning: exported function ValidateACMEIssuerChallengeSolverHTTP01IngressConfig should have comment or be unexported (golint)
  • Line 196: warning: exported function ValidateACMEIssuerChallengeSolverHTTP01GatewayConfig should have comment or be unexported (golint)
  • Line 210: warning: exported function ValidateCAIssuerConfig should have comment or be unexported (golint)
  • Line 223: warning: exported function ValidateSelfSignedIssuerConfig should have comment or be unexported (golint)
  • Line 227: warning: exported function ValidateVaultIssuerConfig should have comment or be unexported (golint)
  • Line 250: warning: exported function ValidateVenafiTPP should have comment or be unexported (golint)
  • Line 257: warning: exported function ValidateVenafiCloud should have comment or be unexported (golint)
  • Line 261: warning: exported function ValidateVenafiIssuerConfig should have comment or be unexported (golint)
  • Line 293: warning: exported function ValidateACMEChallengeSolverDNS01 should have comment or be unexported (golint)
  • Line 478: warning: exported function ValidateSecretKeySelector should have comment or be unexported (golint)

• test/e2e/framework/addon/venafi/cloud.go
  • Line 33: warning: exported type VenafiCloud should have comment or be unexported (golint)
  • Line 45: warning: exported type CloudDetails should have comment or be unexported (golint)
  • Line 49: warning: exported method VenafiCloud.Setup should have comment or be unexported (golint)
  • Line 70: warning: exported method VenafiCloud.Provision should have comment or be unexported (golint)
  • Line 102: warning: exported method VenafiCloud.Details should have comment or be unexported (golint)
  • Line 106: warning: exported method VenafiCloud.Deprovision should have comment or be unexported (golint)
  • Line 110: warning: exported method VenafiCloud.SupportsGlobal should have comment or be unexported (golint)
  • Line 114: warning: exported method CloudDetails.BuildIssuer should have comment or be unexported (golint)
  • Line 127: warning: exported method CloudDetails.BuildClusterIssuer should have comment or be unexported (golint)

• test/e2e/suite/issuers/ca/certificate.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)

• internal/apis/acme/v1/doc.go
  • Line 22: warning: package comment should be of the form "Package v1 ..." (golint)

• internal/apis/acme/v1beta1/types.go
  • Line 20: warning: comment on exported const ACMECertificateHTTP01IngressNameOverride should be of the form "ACMECertificateHTTP01IngressNameOverride ..." (golint)
  • Line 27: warning: comment on exported const ACMECertificateHTTP01IngressClassOverride should be of the form "ACMECertificateHTTP01IngressClassOverride ..." (golint)
  • Line 35: warning: comment on exported const IngressEditInPlaceAnnotationKey should be of the form "IngressEditInPlaceAnnotationKey ..." (golint)
  • Line 41: warning: exported const OrderKind should have comment (or a comment on this block) or be unexported (golint)

• internal/apis/meta/types.go
  • Line 38: warning: comment on exported type LocalObjectReference should be of the form "LocalObjectReference ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported type SecretKeySelector should be of the form "SecretKeySelector ..." (with optional leading article) (golint)
  • Line 73: warning: comment on exported const TLSCAKey should be of the form "TLSCAKey ..." (golint)

• internal/apis/certmanager/v1alpha2/types_issuer.go
  • Line 92: warning: comment on exported type IssuerConfig should be of the form "IssuerConfig ..." (with optional leading article) (golint)
  • Line 122: warning: comment on exported type VenafiIssuer should be of the form "VenafiIssuer ..." (with optional leading article) (golint)
  • Line 174: warning: comment on exported type SelfSignedIssuer should be of the form "SelfSignedIssuer ..." (with optional leading article) (golint)
  • Line 184: warning: comment on exported type VaultIssuer should be of the form "VaultIssuer ..." (with optional leading article) (golint)
  • Line 210: warning: comment on exported type VaultAuth should be of the form "VaultAuth ..." (with optional leading article) (golint)
  • Line 246: warning: comment on exported type VaultKubernetesAuth should be of the form "VaultKubernetesAuth ..." (with optional leading article) (golint)
  • Line 266: warning: exported type CAIssuer should have comment or be unexported (golint)

• pkg/util/errors/errors.go
  • Line 23: warning: exported function NewInvalidData should have comment or be unexported (golint)
  • Line 27: warning: exported function IsInvalidData should have comment or be unexported (golint)

• test/e2e/framework/config/addons.go
  • Line 51: warning: exported method Addons.AddFlags should have comment or be unexported (golint)
  • Line 61: warning: exported method Addons.Validate should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/types_certificaterequest.go
  • Line 26: warning: comment on exported const CertificateRequestReasonPending should be of the form "CertificateRequestReasonPending ..." (golint)
  • Line 29: warning: comment on exported const CertificateRequestReasonFailed should be of the form "CertificateRequestReasonFailed ..." (golint)
  • Line 33: warning: comment on exported const CertificateRequestReasonIssued should be of the form "CertificateRequestReasonIssued ..." (golint)
  • Line 37: warning: comment on exported const CertificateRequestReasonDenied should be of the form "CertificateRequestReasonDenied ..." (golint)

• internal/plugin/plugins.go
  • Line 28: warning: exported var AllOrderedPlugins should have comment or be unexported (golint)
  • Line 35: warning: exported function RegisterAllPlugins should have comment or be unexported (golint)
  • Line 42: warning: exported function DefaultOnAdmissionPlugins should have comment or be unexported (golint)

• internal/apis/certmanager/validation/certificate_for_issuer.go
  • Line 27: warning: exported function ValidateCertificateForIssuer should have comment or be unexported (golint)
  • Line 47: warning: exported function ValidateCertificateForACMEIssuer should have comment or be unexported (golint)
  • Line 69: warning: exported function ValidateCertificateForVaultIssuer should have comment or be unexported (golint)

• internal/apis/acme/v1/conversion.go
  • Line 28: warning: don't use underscores in Go names; func Convert_acme_ACMEIssuer_To_v1_ACMEIssuer should be ConvertAcmeACMEIssuerToV1ACMEIssuer (golint)
  • Line 34: warning: don't use underscores in Go names; func Convert_v1_ACMEIssuer_To_acme_ACMEIssuer should be ConvertV1ACMEIssuerToAcmeACMEIssuer (golint)

• devel/addon/samplewebhook/sample/main.go
  • Line 31: warning: exported var GroupName should have comment or be unexported (golint)

• internal/apis/certmanager/v1beta1/types_issuer.go
  • Line 94: warning: comment on exported type IssuerConfig should be of the form "IssuerConfig ..." (with optional leading article) (golint)
  • Line 124: warning: comment on exported type VenafiIssuer should be of the form "VenafiIssuer ..." (with optional leading article) (golint)
  • Line 176: warning: comment on exported type SelfSignedIssuer should be of the form "SelfSignedIssuer ..." (with optional leading article) (golint)
  • Line 186: warning: comment on exported type VaultIssuer should be of the form "VaultIssuer ..." (with optional leading article) (golint)
  • Line 212: warning: comment on exported type VaultAuth should be of the form "VaultAuth ..." (with optional leading article) (golint)
  • Line 248: warning: comment on exported type VaultKubernetesAuth should be of the form "VaultKubernetesAuth ..." (with optional leading article) (golint)
  • Line 268: warning: exported type CAIssuer should have comment or be unexported (golint)

• pkg/apis/acme/v1/types_order.go
  • Line 50: warning: exported type OrderSpec should have comment or be unexported (golint)
  • Line 87: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 167: warning: comment on exported type ACMEChallenge should be of the form "ACMEChallenge ..." (with optional leading article) (golint)

• pkg/controller/certificatesigningrequests/acme/acme.go
  • Line 49: warning: exported const CSRControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 79: warning: exported function NewACME should have comment or be unexported (golint)

• test/integration/versionchecker/versionchecker_test.go
  • Line 44: warning: error should be the last type when returning multiple items (golint)

• test/e2e/suite/conformance/certificates/acme/acme.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/unit/listers/secret.go
  • Line 28: warning: exported type FakeSecretListerModifier should have comment or be unexported (golint)
  • Line 29: warning: exported type FakeSecretNamespaceListerModifier should have comment or be unexported (golint)
  • Line 31: warning: exported type FakeSecretLister should have comment or be unexported (golint)
  • Line 36: warning: exported type FakeSecretNamespaceLister should have comment or be unexported (golint)
  • Line 41: warning: exported function NewFakeSecretLister should have comment or be unexported (golint)
  • Line 53: warning: exported function NewFakeSecretNamespaceLister should have comment or be unexported (golint)
  • Line 64: warning: exported method FakeSecretLister.List should have comment or be unexported (golint)
  • Line 68: warning: exported method FakeSecretLister.Secrets should have comment or be unexported (golint)
  • Line 72: warning: exported method FakeSecretNamespaceLister.List should have comment or be unexported (golint)
  • Line 76: warning: exported method FakeSecretNamespaceLister.Get should have comment or be unexported (golint)
  • Line 80: warning: exported function FakeSecretNamespaceListerFrom should have comment or be unexported (golint)
  • Line 87: warning: exported method FakeSecretNamespaceLister.SetFakeSecretNamespaceListerGet should have comment or be unexported (golint)
  • Line 96: warning: exported function FakeSecretListerFrom should have comment or be unexported (golint)
  • Line 103: warning: exported function SetFakeSecretListerSecret should have comment or be unexported (golint)
  • Line 109: warning: exported function SetFakeSecretNamespaceListerGet should have comment or be unexported (golint)

• internal/apis/acme/validation/order.go
  • Line 29: warning: exported function ValidateOrderUpdate should have comment or be unexported (golint)
  • Line 43: warning: exported function ValidateOrder should have comment or be unexported (golint)
  • Line 47: warning: exported function ValidateOrderSpecUpdate should have comment or be unexported (golint)
  • Line 55: warning: exported function ValidateOrderStatusUpdate should have comment or be unexported (golint)

• pkg/webhook/admission/plugins.go
  • Line 34: warning: exported function NewPlugins should have comment or be unexported (golint)
  • Line 41: warning: exported method Plugins.Register should have comment or be unexported (golint)
  • Line 45: warning: exported method Plugins.NewFromPlugins should have comment or be unexported (golint)
  • Line 67: warning: exported method Plugins.InitPlugin should have comment or be unexported (golint)

• pkg/webhook/admission/request_handler.go
  • Line 129: warning: exported method RequestHandler.Mutate should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/tests.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• cmd/ctl/pkg/status/status.go
  • Line 28: warning: exported function NewCmdStatus should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/generic_issuer.go
  • Line 26: warning: exported type GenericIssuer should have comment or be unexported (golint)
  • Line 38: warning: exported method ClusterIssuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 41: warning: exported method ClusterIssuer.GetSpec should have comment or be unexported (golint)
  • Line 44: warning: exported method ClusterIssuer.GetStatus should have comment or be unexported (golint)
  • Line 47: warning: exported method ClusterIssuer.SetSpec should have comment or be unexported (golint)
  • Line 50: warning: exported method ClusterIssuer.SetStatus should have comment or be unexported (golint)
  • Line 53: warning: exported method ClusterIssuer.Copy should have comment or be unexported (golint)
  • Line 56: warning: exported method Issuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 59: warning: exported method Issuer.GetSpec should have comment or be unexported (golint)
  • Line 62: warning: exported method Issuer.GetStatus should have comment or be unexported (golint)
  • Line 65: warning: exported method Issuer.SetSpec should have comment or be unexported (golint)
  • Line 68: warning: exported method Issuer.SetStatus should have comment or be unexported (golint)
  • Line 71: warning: exported method Issuer.Copy should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method IssuerStatus.ACMEStatus should be of the form "ACMEStatus ..." (golint)

• pkg/apis/acme/v1/types.go
  • Line 55: warning: exported const OrderKind should have comment (or a comment on this block) or be unexported (golint)

• pkg/controller/certificates/keymanager/keymanager_controller.go
  • Line 52: warning: exported const ControllerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported function NewController should have comment or be unexported (golint)

• cmd/ctl/cmd/cmd.go
  • Line 34: warning: exported function NewCertManagerCtlCommand should have comment or be unexported (golint)

• cmd/ctl/pkg/approve/approve.go
  • Line 71: warning: exported function NewCmdApprove should have comment or be unexported (golint)

• internal/apis/acme/v1alpha3/const.go
  • Line 20: warning: exported const ACMEFinalizer should have comment (or a comment on this block) or be unexported (golint)

• internal/apis/acme/v1alpha2/types_issuer.go
  • Line 133: warning: exported const HS256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 138: warning: comment on exported type ACMEChallengeSolver should be of the form "ACMEChallengeSolver ..." (with optional leading article) (golint)
  • Line 162: warning: comment on exported type CertificateDNSNameSelector should be of the form "CertificateDNSNameSelector ..." (with optional leading article) (golint)
  • Line 217: warning: exported type ACMEChallengeSolverHTTP01Ingress should have comment or be unexported (golint)
  • Line 248: warning: exported type ACMEChallengeSolverHTTP01GatewayHTTPRoute should have comment or be unexported (golint)
  • Line 260: warning: exported type ACMEChallengeSolverHTTP01IngressPodTemplate should have comment or be unexported (golint)
  • Line 276: warning: exported type ACMEChallengeSolverHTTP01IngressPodObjectMeta should have comment or be unexported (golint)
  • Line 286: warning: exported type ACMEChallengeSolverHTTP01IngressPodSpec should have comment or be unexported (golint)
  • Line 310: warning: exported type ACMEChallengeSolverHTTP01IngressTemplate should have comment or be unexported (golint)
  • Line 319: warning: exported type ACMEChallengeSolverHTTP01IngressObjectMeta should have comment or be unexported (golint)
  • Line 329: warning: comment on exported type ACMEChallengeSolverDNS01 should be of the form "ACMEChallengeSolverDNS01 ..." (with optional leading article) (golint)
  • Line 505: warning: exported type AzureManagedIdentity should have comment or be unexported (golint)
  • Line 515: warning: comment on exported type AzureDNSEnvironment should be of the form "AzureDNSEnvironment ..." (with optional leading article) (golint)
  • Line 519: warning: exported const AzurePublicCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 586: warning: exported type ACMEIssuerStatus should have comment or be unexported (golint)

• internal/apis/config/webhook/v1alpha1/register.go
  • Line 36: warning: exported var AddToScheme should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/types_certificate.go
  • Line 54: warning: comment on exported type KeyAlgorithm should be of the form "KeyAlgorithm ..." (with optional leading article) (golint)
  • Line 58: warning: comment on exported const RSAKeyAlgorithm should be of the form "RSAKeyAlgorithm ..." (golint)
  • Line 61: warning: comment on exported const ECDSAKeyAlgorithm should be of the form "ECDSAKeyAlgorithm ..." (golint)
  • Line 65: warning: comment on exported type KeyEncoding should be of the form "KeyEncoding ..." (with optional leading article) (golint)
  • Line 239: warning: comment on exported type PrivateKeyRotationPolicy should be of the form "PrivateKeyRotationPolicy ..." (with optional leading article) (golint)
  • Line 292: warning: comment on exported type JKSKeystore should be of the form "JKSKeystore ..." (with optional leading article) (golint)
  • Line 307: warning: comment on exported type PKCS12Keystore should be of the form "PKCS12Keystore ..." (with optional leading article) (golint)
  • Line 424: warning: comment on exported const CertificateConditionIssuing should be of the form "CertificateConditionIssuing ..." (golint)

• internal/apis/certmanager/v1alpha3/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/issuer/acme/dns/util/wait.go
  • Line 49: warning: exported var RecursiveNameservers should have comment or be unexported (golint)
  • Line 192: warning: exported function ValidateCAA should have comment or be unexported (golint)

• cmd/controller/app/options/options.go
  • Line 60: warning: exported type ControllerOptions should have comment or be unexported (golint)
  • Line 218: warning: exported function NewControllerOptions should have comment or be unexported (golint)
  • Line 248: warning: exported method ControllerOptions.AddFlags should have comment or be unexported (golint)
  • Line 360: warning: exported method ControllerOptions.Validate should have comment or be unexported (golint)
  • Line 360: warning: receiver name o should be consistent with previous receiver name s for ControllerOptions (golint)
  • Line 408: warning: exported method ControllerOptions.EnabledControllers should have comment or be unexported (golint)
  • Line 408: warning: receiver name o should be consistent with previous receiver name s for ControllerOptions (golint)

• pkg/controller/certificates/trigger/trigger_controller.go
  • Line 49: warning: exported const ControllerName should have comment or be unexported (golint)
  • Line 70: warning: exported function NewController should have comment or be unexported (golint)

• pkg/issuer/fake/factory.go
  • Line 24: warning: exported type Factory should have comment or be unexported (golint)
  • Line 30: warning: exported method Factory.IssuerFor should have comment or be unexported (golint)

• pkg/issuer/selfsigned/selfsigned.go
  • Line 36: warning: exported function NewSelfSigned should have comment or be unexported (golint)

• pkg/issuer/acme/dns/rfc2136/provider.go
  • Line 36: warning: exported type Solver should have comment or be unexported (golint)
  • Line 45: warning: exported type Option should have comment or be unexported (golint)
  • Line 47: warning: exported function WithNamespace should have comment or be unexported (golint)
  • Line 53: warning: exported function New should have comment or be unexported (golint)
  • Line 61: warning: exported method Solver.Name should have comment or be unexported (golint)
  • Line 65: warning: exported method Solver.Present should have comment or be unexported (golint)
  • Line 79: warning: exported method Solver.CleanUp should have comment or be unexported (golint)
  • Line 93: warning: exported method Solver.Initialize should have comment or be unexported (golint)

• test/e2e/framework/addon/globals.go
  • Line 29: warning: exported type Addon should have comment or be unexported (golint)
  • Line 101: warning: exported function GlobalLogs should have comment or be unexported (golint)

• test/e2e/framework/helper/validation/validation.go
  • Line 25: warning: exported function DefaultCertificateSet should have comment or be unexported (golint)
  • Line 45: warning: exported function DefaultCertificateSigningRequestSet should have comment or be unexported (golint)
  • Line 63: warning: exported function CertificateSetForUnsupportedFeatureSet should have comment or be unexported (golint)
  • Line 97: warning: exported function CertificateSigningRequestSetForUnsupportedFeatureSet should have comment or be unexported (golint)

• test/e2e/suite/conformance/certificates/venaficloud/cloud.go
  • Line 22: warning: should not use dot imports (golint)
  • Line 23: warning: should not use dot imports (golint)

• internal/apis/certmanager/v1alpha3/types_certificaterequest.go
  • Line 26: warning: comment on exported const CertificateRequestReasonPending should be of the form "CertificateRequestReasonPending ..." (golint)
  • Line 29: warning: comment on exported const CertificateRequestReasonFailed should be of the form "CertificateRequestReasonFailed ..." (golint)
  • Line 33: warning: comment on exported const CertificateRequestReasonIssued should be of the form "CertificateRequestReasonIssued ..." (golint)
  • Line 37: warning: comment on exported const CertificateRequestReasonDenied should be of the form "CertificateRequestReasonDenied ..." (golint)

• pkg/apis/acme/v1/const.go
  • Line 20: warning: exported const ACMEFinalizer should have comment (or a comment on this block) or be unexported (golint)

• pkg/issuer/acme/dns/rfc2136/rfc2136.go
  • Line 21: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
  • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• internal/apis/acme/v1alpha2/types_challenge.go
  • Line 54: warning: exported type ChallengeSpec should have comment or be unexported (golint)
  • Line 102: warning: comment on exported type ACMEChallengeType should be of the form "ACMEChallengeType ..." (with optional leading article) (golint)
  • Line 116: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• internal/apis/certmanager/v1alpha2/register.go
  • Line 36: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• pkg/api/util/conditions.go
  • Line 135: warning: exported function GetCertificateCondition should have comment or be unexported (golint)
  • Line 144: warning: exported function GetCertificateRequestCondition should have comment or be unexported (golint)
  • Line 285: warning: comment on exported function CertificateRequestReadyReason should be of the form "CertificateRequestReadyReason ..." (golint)
  • Line 305: warning: comment on exported function CertificateRequestInvalidRequestMessage should be of the form "CertificateRequestInvalidRequestMessage ..." (golint)
  • Line 322: warning: comment on exported function CertificateRequestHasInvalidRequest should be of the form "CertificateRequestHasInvalidRequest ..." (golint)

• test/e2e/framework/config/ginkgo.go
  • Line 23: warning: exported type Ginkgo should have comment or be unexported (golint)
  • Line 28: warning: exported method Ginkgo.AddFlags should have comment or be unexported (golint)
  • Line 33: warning: exported method Ginkgo.Validate should have comment or be unexported (golint)
  • Line 33: warning: receiver name c should be consistent with previous receiver name g for Ginkgo (golint)

• test/e2e/framework/config/suite.go
  • Line 25: warning: exported type Suite should have comment or be unexported (golint)
  • Line 29: warning: exported type ACME should have comment or be unexported (golint)
  • Line 33: warning: exported type Cloudflare should have comment or be unexported (golint)
  • Line 39: warning: exported method Suite.AddFlags should have comment or be unexported (golint)
  • Line 43: warning: exported method Suite.Validate should have comment or be unexported (golint)
  • Line 43: warning: receiver name c should be consistent with previous receiver name f for Suite (golint)
  • Line 49: warning: exported method ACME.AddFlags should have comment or be unexported (golint)
  • Line 53: warning: exported method ACME.Validate should have comment or be unexported (golint)
  • Line 57: warning: exported method Cloudflare.AddFlags should have comment or be unexported (golint)

• test/unit/gen/csr.go
  • Line 30: warning: exported type CSRModifier should have comment or be unexported (golint)
  • Line 32: warning: exported function CSR should have comment or be unexported (golint)
  • Line 78: warning: exported function SetCSRDNSNames should have comment or be unexported (golint)
  • Line 84: warning: exported function SetCSRIPAddresses should have comment or be unexported (golint)
  • Line 90: warning: exported function SetCSRURIs should have comment or be unexported (golint)
  • Line 96: warning: exported function SetCSRCommonName should have comment or be unexported (golint)
  • Line 102: warning: exported function SetCSREmails should have comment or be unexported (golint)

• cmd/ctl/pkg/completion/completion.go
  • Line 26: warning: exported function NewCmdCompletion should have comment or be unexported (golint)

• cmd/ctl/pkg/create/create.go
  • Line 28: warning: exported function NewCmdCreate should have comment or be unexported (golint)

• internal/apis/acme/types_challenge.go
  • Line 46: warning: exported type ChallengeSpec should have comment or be unexported (golint)
  • Line 93: warning: comment on exported type ACMEChallengeType should be of the form "ACMEChallengeType ..." (with optional leading article) (golint)
  • Line 106: warning: exported type ChallengeStatus should have comment or be unexported (golint)

• internal/apis/acme/v1alpha2/types.go
  • Line 20: warning: comment on exported const ACMECertificateHTTP01IngressNameOverride should be of the form "ACMECertificateHTTP01IngressNameOverride ..." (golint)
  • Line 27: warning: comment on exported const ACMECertificateHTTP01IngressClassOverride should be of the form "ACMECertificateHTTP01IngressClassOverride ..." (golint)
  • Line 35: warning: comment on exported const IngressEditInPlaceAnnotationKey should be of the form "IngressEditInPlaceAnnotationKey ..." (golint)

• internal/apis/certmanager/generic_issuer.go
  • Line 26: warning: exported type GenericIssuer should have comment or be unexported (golint)
  • Line 38: warning: exported method ClusterIssuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 41: warning: exported method ClusterIssuer.GetSpec should have comment or be unexported (golint)
  • Line 44: warning: exported method ClusterIssuer.GetStatus should have comment or be unexported (golint)
  • Line 47: warning: exported method ClusterIssuer.SetSpec should have comment or be unexported (golint)
  • Line 50: warning: exported method ClusterIssuer.SetStatus should have comment or be unexported (golint)
  • Line 53: warning: exported method ClusterIssuer.Copy should have comment or be unexported (golint)
  • Line 56: warning: exported method Issuer.GetObjectMeta should have comment or be unexported (golint)
  • Line 59: warning: exported method Issuer.GetSpec should have comment or be unexported (golint)
  • Line 62: warning: exported method Issuer.GetStatus should have comment or be unexported (golint)
  • Line 65: warning: exported method Issuer.SetSpec should have comment or be unexported (golint)
  • Line 68: warning: exported method Issuer.SetStatus should have comment or be unexported (golint)
  • Line 71: warning: exported method Issuer.Copy should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method IssuerStatus.ACMEStatus should be of the form "ACMEStatus ..." (golint)

• internal/apis/certmanager/v1/conversion.go
  • Line 28: warning: comment on exported function Convert_v1_CertificateSpec_To_certmanager_CertificateSpec should be of the form "Convert_v1_CertificateSpec_To_certmanager_CertificateSpec ..." (golint)
  • Line 29: warning: don't use underscores in Go names; func Convert_v1_CertificateSpec_To_certmanager_CertificateSpec should be ConvertV1CertificateSpecToCertmanagerCertificateSpec (golint)
  • Line 35: warning: comment on exported function Convert_certmanager_CertificateSpec_To_v1_CertificateSpec should be of the form "Convert_certmanager_CertificateSpec_To_v1_CertificateSpec ..." (golint)
  • Line 36: warning: don't use underscores in Go names; func Convert_certmanager_CertificateSpec_To_v1_CertificateSpec should be ConvertCertmanagerCertificateSpecToV1CertificateSpec (golint)

• pkg/apis/config/webhook/doc.go
  • Line 22: warning: exported const GroupName should have comment or be unexported (golint)

• pkg/controller/test/context_builder.go
  • Line 161: warning: comment on exported method Builder.InitWithRESTConfig should be of the form "InitWithRESTConfig ..." (golint)
  • Line 170: warning: exported method Builder.FakeKubeClient should have comment or be unexported (golint)
  • Line 174: warning: exported method Builder.FakeKubeInformerFactory should have comment or be unexported (golint)
  • Line 178: warning: exported method Builder.FakeCMClient should have comment or be unexported (golint)
  • Line 182: warning: exported method Builder.FakeGWClient should have comment or be unexported (golint)
  • Line 186: warning: exported method Builder.FakeCMInformerFactory should have comment or be unexported (golint)
  • Line 190: warning: exported method Builder.EnsureReactorCalled should have comment or be unexported (golint)
  • Line 225: warning: exported method Builder.AllReactorsCalled should have comment or be unexported (golint)
  • Line 235: warning: exported method Builder.AllEventsCalled should have comment or be unexported (golint)
  • Line 315: warning: exported method Builder.Start should have comment or be unexported (golint)
  • Line 324: warning: exported method Builder.Sync should have comment or be unexported (golint)
  • Line 349: warning: exported method Builder.Events should have comment or be unexported (golint)

• test/e2e/framework/log/log.go
  • Line 26: warning: exported var Writer should have comment or be unexported (golint)
  • Line 36: warning: exported function Logf should have comment or be unexported (golint)

• internal/apis/acme/types_order.go
  • Line 46: warning: exported type OrderSpec should have comment or be unexported (golint)
  • Line 79: warning: exported type OrderStatus should have comment or be unexported (golint)
  • Line 149: warning: comment on exported type ACMEChallenge should be of the form "ACMEChallenge ..." (with optional leading article) (golint)

• internal/apis/acme/v1alpha3/types.go
  • Line 20: warning: comment on exported const ACMECertificateHTTP01IngressNameOverride should be of the form "ACMECertificateHTTP01IngressNameOverride ..." (golint)
  • Line 27: warning: comment on exported const ACMECertificateHTTP01IngressClassOverride should be of the form "ACMECertificateHTTP01IngressClassOverride ..." (golint)
  • Line 35: warning: comment on exported const IngressEditInPlaceAnnotationKey should be of the form "IngressEditInPlaceAnnotationKey ..." (golint)
  • Line 41: warning: exported const OrderKind should have comment (or a comment on this block) or be unexported (golint)

• pkg/apis/certmanager/v1/const.go
  • Line 22: warning: comment on exported const MinimumCertificateDuration should be of the form "MinimumCertificateDuration ..." (golint)
  • Line 25: warning: comment on exported const DefaultCertificateDuration should be of the form "DefaultCertificateDuration ..." (golint)
  • Line 28: warning: comment on exported const MinimumRenewBefore should be of the form "MinimumRenewBefore ..." (golint)
  • Line 31: warning: comment on exported const DefaultRenewBefore should be of the form "DefaultRenewBefore ..." (golint)
  • Line 36: warning: comment on exported const DefaultVaultTokenAuthSecretKey should be of the form "DefaultVaultTokenAuthSecretKey ..." (golint)
  • Line 39: warning: comment on exported const DefaultVaultKubernetesAuthMountPath should be of the form "DefaultVaultKubernetesAuthMountPath ..." (golint)

• test/e2e/framework/addon/base/base.go
  • Line 29: warning: exported type Base should have comment or be unexported (golint)
  • Line 46: warning: exported method Details.Helper should have comment or be unexported (golint)
  • Line 52: warning: exported method Base.Setup should have comment or be unexported (golint)
  • Line 71: warning: exported method Base.Provision should have comment or be unexported (golint)
  • Line 75: warning: exported method Base.Deprovision should have comment or be unexported (golint)
  • Line 79: warning: exported method Base.Details should have comment or be unexported (golint)
  • Line 83: warning: exported method Base.SupportsGlobal should have comment or be unexported (golint)

• test/e2e/suite/approval/userinfo.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• test/e2e/suite/conformance/certificatesigningrequests/vault/approle.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)

• test/e2e/suite/issuers/acme/certificate/http01.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 45: warning: should not use dot imports (golint)

• cmd/cainjector/app/start.go
  • Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 133: warning: exported method InjectorControllerOptions.RunInjectorController should have comment or be unexported (golint)

• pkg/controller/test/util.go
  • Line 28: warning: exported type StringGenerator should have comment or be unexported (golint)

• pkg/issuer/venafi/client/api/customfield.go
  • Line 19: warning: exported type CustomFieldType should have comment or be unexported (golint)
  • Line 22: warning: exported const CustomFieldTypePlain should have comment (or a comment on this block) or be unexported (golint)

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• internal/apis/certmanager/v1alpha2/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)

• internal/apis/certmanager/v1beta1/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)

• pkg/controller/acmeorders/sync.go
  • Line 55: warning: cyclomatic complexity 40 of function (*controller).Sync() is high (> 15) (gocyclo)
  • Line 491: warning: cyclomatic complexity 21 of function (*controller).finalizeOrder() is high (> 15) (gocyclo)

• pkg/issuer/acme/http/ingress.go
  • Line 276: warning: cyclomatic complexity 16 of function (*Solver).cleanupIngresses() is high (> 15) (gocyclo)

• internal/apis/acme/v1alpha3/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)
  • Line 563: warning: cyclomatic complexity 17 of function autoConvert_acme_ACMEChallengeSolverDNS01_To_v1alpha3_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)
  • Line 480: warning: cyclomatic complexity 17 of function autoConvert_v1alpha3_ACMEChallengeSolverDNS01_To_acme_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)

• pkg/controller/certificates/internal/secretsmanager/keystore_test.go
  • Line 238: warning: cyclomatic complexity 17 of function TestEncodePKCS12Keystore() is high (> 15) (gocyclo)

• cmd/ctl/pkg/status/certificate/certificate.go
  • Line 138: warning: cyclomatic complexity 25 of function (*Options).GetResources() is high (> 15) (gocyclo)

• test/integration/certificates/issuing_controller_test.go
  • Line 466: warning: cyclomatic complexity 30 of function Test_IssuingController_SecretTemplate() is high (> 15) (gocyclo)
  • Line 253: warning: cyclomatic complexity 25 of function TestIssuingController_PKCS8_PrivateKey() is high (> 15) (gocyclo)
  • Line 49: warning: cyclomatic complexity 24 of function TestIssuingController() is high (> 15) (gocyclo)

• pkg/webhook/server/server.go
  • Line 119: warning: cyclomatic complexity 17 of function (*Server).Run() is high (> 15) (gocyclo)

• pkg/controller/certificates/issuing/issuing_controller.go
  • Line 148: warning: cyclomatic complexity 32 of function (*controller).ProcessItem() is high (> 15) (gocyclo)

• test/integration/ctl/ctl_status_certificate_test.go
  • Line 74: warning: cyclomatic complexity 40 of function TestCtlStatusCert() is high (> 15) (gocyclo)

• test/e2e/framework/helper/certificaterequests.go
  • Line 75: warning: cyclomatic complexity 30 of function (*Helper).ValidateIssuedCertificateRequest() is high (> 15) (gocyclo)

• pkg/issuer/vault/setup.go
  • Line 49: warning: cyclomatic complexity 23 of function (*Vault).Setup() is high (> 15) (gocyclo)

• test/integration/certificates/revisionmanager_controller_test.go
  • Line 46: warning: cyclomatic complexity 16 of function TestRevisionManagerController() is high (> 15) (gocyclo)

• cmd/controller/app/controller.go
  • Line 72: warning: cyclomatic complexity 24 of function Run() is high (> 15) (gocyclo)

• pkg/controller/certificate-shim/sync.go
  • Line 267: warning: cyclomatic complexity 20 of function buildCertificates() is high (> 15) (gocyclo)

• internal/apis/certmanager/v1/zz_generated.conversion.go
  • Line 46: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)

• internal/apis/certmanager/validation/issuer.go
  • Line 293: warning: cyclomatic complexity 57 of function ValidateACMEChallengeSolverDNS01() is high (> 15) (gocyclo)

• pkg/issuer/acme/dns/dns.go
  • Line 178: warning: cyclomatic complexity 37 of function (*Solver).solverForChallenge() is high (> 15) (gocyclo)

• pkg/issuer/acme/http/ingress_test.go
  • Line 152: warning: cyclomatic complexity 20 of function TestCleanupIngresses() is high (> 15) (gocyclo)

• pkg/controller/certificaterequests/approver/approver_test.go
  • Line 34: warning: cyclomatic complexity 16 of function TestProcessItem() is high (> 15) (gocyclo)

• pkg/controller/certificatesigningrequests/venafi/venafi.go
  • Line 88: warning: cyclomatic complexity 16 of function (*Venafi).Sign() is high (> 15) (gocyclo)

• internal/apis/acme/v1/zz_generated.conversion.go
  • Line 45: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)
  • Line 481: warning: cyclomatic complexity 17 of function autoConvert_v1_ACMEChallengeSolverDNS01_To_acme_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)
  • Line 564: warning: cyclomatic complexity 17 of function autoConvert_acme_ACMEChallengeSolverDNS01_To_v1_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)

• pkg/issuer/acme/setup.go
  • Line 70: warning: cyclomatic complexity 29 of function (*Acme).Setup() is high (> 15) (gocyclo)

• pkg/controller/certificates/util.go
  • Line 118: warning: cyclomatic complexity 22 of function RequestMatchesSpec() is high (> 15) (gocyclo)

• pkg/controller/clusterissuers/checks.go
  • Line 27: warning: cyclomatic complexity 22 of function (*controller).issuersForSecret() is high (> 15) (gocyclo)

• pkg/issuer/acme/http/http_test.go
  • Line 98: warning: cyclomatic complexity 19 of function TestReachabilityCustomDnsServers() is high (> 15) (gocyclo)

• pkg/controller/certificaterequests/sync.go
  • Line 42: warning: cyclomatic complexity 17 of function (*Controller).Sync() is high (> 15) (gocyclo)

• internal/apis/certmanager/v1alpha2/zz_generated.deepcopy.go
  • Line 397: warning: cyclomatic complexity 16 of function (*CertificateSpec).DeepCopyInto() is high (> 15) (gocyclo)

• pkg/controller/acmeorders/util.go
  • Line 82: warning: cyclomatic complexity 44 of function challengeSpecForAuthorization() is high (> 15) (gocyclo)

• internal/apis/certmanager/validation/certificate.go
  • Line 42: warning: cyclomatic complexity 29 of function ValidateCertificateSpec() is high (> 15) (gocyclo)

• pkg/controller/acmechallenges/sync.go
  • Line 64: warning: cyclomatic complexity 25 of function (*controller).Sync() is high (> 15) (gocyclo)

• cmd/ctl/pkg/create/certificaterequest/certificaterequest.go
  • Line 162: warning: cyclomatic complexity 21 of function (*Options).Run() is high (> 15) (gocyclo)

• test/integration/acme/orders_controller_test.go
  • Line 43: warning: cyclomatic complexity 18 of function TestAcmeOrdersController() is high (> 15) (gocyclo)

• internal/apis/acme/v1alpha2/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)
  • Line 480: warning: cyclomatic complexity 17 of function autoConvert_v1alpha2_ACMEChallengeSolverDNS01_To_acme_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)
  • Line 563: warning: cyclomatic complexity 17 of function autoConvert_acme_ACMEChallengeSolverDNS01_To_v1alpha2_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)

• internal/apis/acme/v1beta1/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)
  • Line 480: warning: cyclomatic complexity 17 of function autoConvert_v1beta1_ACMEChallengeSolverDNS01_To_acme_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)
  • Line 563: warning: cyclomatic complexity 17 of function autoConvert_acme_ACMEChallengeSolverDNS01_To_v1beta1_ACMEChallengeSolverDNS01() is high (> 15) (gocyclo)

• internal/apis/acme/validation/order.go
  • Line 55: warning: cyclomatic complexity 28 of function ValidateOrderStatusUpdate() is high (> 15) (gocyclo)

• cmd/ctl/pkg/create/certificatesigningrequest/certificatesigningrequest.go
  • Line 174: warning: cyclomatic complexity 21 of function (*Options).Run() is high (> 15) (gocyclo)

• internal/apis/certmanager/v1alpha3/zz_generated.conversion.go
  • Line 44: warning: cyclomatic complexity 69 of function RegisterConversions() is high (> 15) (gocyclo)

• pkg/issuer/acme/http/pod_test.go
  • Line 32: warning: cyclomatic complexity 19 of function TestEnsurePod() is high (> 15) (gocyclo)

• pkg/util/pki/generate_test.go
  • Line 63: warning: cyclomatic complexity 19 of function TestGeneratePrivateKeyForCertificate() is high (> 15) (gocyclo)

• pkg/controller/issuers/checks.go
  • Line 27: warning: cyclomatic complexity 22 of function (*controller).issuersForSecret() is high (> 15) (gocyclo)

• pkg/controller/certificates/internal/secretsmanager/secret.go
  • Line 263: warning: cyclomatic complexity 19 of function (*SecretsManager).setKeystores() is high (> 15) (gocyclo)

• pkg/controller/certificatesigningrequests/sync.go
  • Line 37: warning: cyclomatic complexity 17 of function (*Controller).Sync() is high (> 15) (gocyclo)

• internal/apis/acme/validation/order_test.go
  • Line 101: warning: cyclomatic complexity 17 of function TestValidateOrderUpdate() is high (> 15) (gocyclo)

• test/integration/ctl/migrate/ctl_upgrade_migrate_test.go
  • Line 76: warning: cyclomatic complexity 20 of function TestCtlUpgradeMigrate() is high (> 15) (gocyclo)

• test/integration/webhook/dynamic_source_test.go
  • Line 107: warning: cyclomatic complexity 17 of function TestDynamicSource_CARotation() is high (> 15) (gocyclo)

• pkg/issuer/acme/http/service_test.go
  • Line 32: warning: cyclomatic complexity 52 of function TestEnsureService() is high (> 15) (gocyclo)

• test/integration/ctl/ctl_create_cr_test.go
  • Line 165: warning: cyclomatic complexity 22 of function TestCtlCreateCRSuccessful() is high (> 15) (gocyclo)

• pkg/controller/certificatesigningrequests/acme/acme.go
  • Line 97: warning: cyclomatic complexity 17 of function (*ACME).Sign() is high (> 15) (gocyclo)

• pkg/webhook/server/tls/dynamic_source.go
  • Line 55: warning: cyclomatic complexity 26 of function (*DynamicSource).Run() is high (> 15) (gocyclo)

• pkg/controller/certificates/requestmanager/requestmanager_controller.go
  • Line 124: warning: cyclomatic complexity 19 of function (*controller).ProcessItem() is high (> 15) (gocyclo)

• pkg/issuer/acme/dns/util/wait.go
  • Line 192: warning: cyclomatic complexity 17 of function ValidateCAA() is high (> 15) (gocyclo)

• pkg/controller/certificaterequests/acme/acme.go
  • Line 91: warning: cyclomatic complexity 16 of function (*ACME).Sign() is high (> 15) (gocyclo)

• pkg/controller/certificates/keymanager/keymanager_controller.go
  • Line 127: warning: cyclomatic complexity 20 of function (*controller).ProcessItem() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!