Go Report Card

Preparing report...

Report for github.com/jsiebens/faas-nomad

A+    Excellent!    Found 17 issues across 24 files

Tweet
Last refresh:

Refresh now

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint33%

Golint is a linter for Go source code.

    • faas-nomad/pkg/services/mock_services.go
    • Line 11: warning: exported type MockSecrets should have comment or be unexported (golint)
    • Line 15: warning: exported method MockSecrets.List should have comment or be unexported (golint)
    • Line 26: warning: exported method MockSecrets.Set should have comment or be unexported (golint)
    • Line 31: warning: exported method MockSecrets.Delete should have comment or be unexported (golint)
    • Line 36: warning: exported type MockJobs should have comment or be unexported (golint)
    • Line 40: warning: exported method MockJobs.List should have comment or be unexported (golint)
    • Line 56: warning: exported method MockJobs.Info should have comment or be unexported (golint)
    • Line 72: warning: exported method MockJobs.Register should have comment or be unexported (golint)
    • Line 90: warning: exported method MockJobs.Deregister should have comment or be unexported (golint)
    • Line 97: warning: exported method MockJobs.Allocations should have comment or be unexported (golint)
    • Line 113: warning: exported type MockResolver should have comment or be unexported (golint)
    • Line 117: warning: exported method MockResolver.Resolve should have comment or be unexported (golint)
    • Line 128: warning: exported method MockResolver.RemoveCacheItem should have comment or be unexported (golint)
    • faas-nomad/pkg/services/secrets_service.go
    • Line 15: warning: exported type Secrets should have comment or be unexported (golint)
    • Line 21: warning: exported function NewVaultSecrets should have comment or be unexported (golint)
    • Line 55: warning: exported type VaultSecrets should have comment or be unexported (golint)
    • Line 60: warning: exported method VaultSecrets.List should have comment or be unexported (golint)
    • Line 75: warning: exported method VaultSecrets.Set should have comment or be unexported (golint)
    • Line 80: warning: exported method VaultSecrets.Delete should have comment or be unexported (golint)
    • faas-nomad/pkg/types/provider_config.go
    • Line 9: warning: exported type ConsulConfig should have comment or be unexported (golint)
    • Line 18: warning: exported type NomadConfig should have comment or be unexported (golint)
    • Line 27: warning: exported type VaultConfig should have comment or be unexported (golint)
    • Line 37: warning: exported type SchedulingConfig should have comment or be unexported (golint)
    • Line 47: warning: exported type LogConfig should have comment or be unexported (golint)
    • Line 53: warning: exported type ProviderConfig should have comment or be unexported (golint)
    • Line 64: warning: exported type ProxyConfig should have comment or be unexported (golint)
    • Line 68: warning: exported function DefaultConfig should have comment or be unexported (golint)
    • Line 72: warning: exported function LoadConfig should have comment or be unexported (golint)
    • faas-nomad/version/version.go
    • Line 4: warning: exported var Version should have comment or be unexported (golint)
    • Line 9: warning: exported function BuildVersion should have comment or be unexported (golint)
    • Line 16: warning: exported function GetReleaseInfo should have comment or be unexported (golint)
    • faas-nomad/pkg/handlers/deploy.go
    • Line 31: warning: exported function MakeDeployHandler should have comment or be unexported (golint)
    • Line 268: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • faas-nomad/pkg/handlers/info.go
    • Line 11: warning: exported const OrchestrationIdentifier should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: exported function MakeInfoHandler should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!