Preparing report...

Report for github.com/keptn/keptn

A+    Excellent!    Found 134 issues across 375 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • keptn/cli/cmd/install.go
    • Line 199: warning: cyclomatic complexity 17 of function (*InstallCmdHandler).doInstallation() is high (> 15) (gocyclo)
    • Line 63: warning: cyclomatic complexity 16 of function NewInstallCmd() is high (> 15) (gocyclo)

golint68%

Golint is a linter for Go source code.

    • keptn/shipyard-controller/db/project_mongodb_repo.go
    • Line 16: warning: exported type MongoDBProjectsRepo should have comment or be unexported (golint)
    • Line 20: warning: exported method MongoDBProjectsRepo.GetProjects should have comment or be unexported (golint)
    • Line 48: warning: exported method MongoDBProjectsRepo.GetProject should have comment or be unexported (golint)
    • Line 70: warning: exported method MongoDBProjectsRepo.CreateProject should have comment or be unexported (golint)
    • Line 70: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • Line 88: warning: exported method MongoDBProjectsRepo.UpdateProject should have comment or be unexported (golint)
    • Line 88: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • Line 106: warning: exported method MongoDBProjectsRepo.UpdateProjectUpstream should have comment or be unexported (golint)
    • Line 106: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • Line 125: warning: exported method MongoDBProjectsRepo.DeleteProject should have comment or be unexported (golint)
    • Line 125: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • Line 143: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • Line 161: warning: receiver name m should be consistent with previous receiver name mdbrepo for MongoDBProjectsRepo (golint)
    • keptn/shipyard-controller/operations/service.go
    • Line 3: warning: exported type CreateServiceParams should have comment or be unexported (golint)
    • Line 8: warning: exported type CreateServiceResponse should have comment or be unexported (golint)
    • Line 11: warning: exported type DeleteServiceResponse should have comment or be unexported (golint)
    • Line 15: warning: exported type GetServiceParams should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/fake/utils.go
    • Line 12: warning: exported const TestShipyardFile should have comment or be unexported (golint)
    • Line 62: warning: exported function ShouldContainEvent should have comment or be unexported (golint)
    • Line 87: warning: exported function ShouldNotContainEvent should have comment or be unexported (golint)
    • Line 125: warning: exported type EventScope should have comment or be unexported (golint)
    • Line 131: warning: exported function GetTestTriggeredEvent should have comment or be unexported (golint)
    • Line 146: warning: exported function GetTestStartedEvent should have comment or be unexported (golint)
    • Line 161: warning: exported function GetTestStartedEventWithUnmatchedTriggeredID should have comment or be unexported (golint)
    • Line 176: warning: exported function GetTestFinishedEventWithUnmatchedSource should have comment or be unexported (golint)
    • keptn/cli/cmd/install.go
    • Line 63: warning: exported function NewInstallCmd should have comment or be unexported (golint)
    • Line 192: warning: comment on exported type InstallCmdHandler should be of the form "InstallCmdHandler ..." (with optional leading article) (golint)
    • keptn/shipyard-controller/handler/sequencehooks/hooks.go
    • Line 5: warning: exported type ISequenceTriggeredHook should have comment or be unexported (golint)
    • Line 9: warning: exported type ISequenceTaskTriggeredHook should have comment or be unexported (golint)
    • Line 13: warning: exported type ISequenceTaskStartedHook should have comment or be unexported (golint)
    • Line 17: warning: exported type ISequenceTaskFinishedHook should have comment or be unexported (golint)
    • Line 21: warning: exported type ISubSequenceFinishedHook should have comment or be unexported (golint)
    • Line 25: warning: exported type ISequenceFinishedHook should have comment or be unexported (golint)
    • keptn/helm-service/pkg/helm/test_util.go
    • Line 58: warning: exported type GeneratedResource should have comment or be unexported (golint)
    • Line 63: warning: exported function Equals should have comment or be unexported (golint)
    • Line 98: warning: exported function GetTemplateByName should have comment or be unexported (golint)
    • keptn/configuration-service/common/git.go
    • Line 27: warning: comment on exported type CommandExecutor should be of the form "CommandExecutor ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported type CredentialReader should be of the form "CredentialReader ..." (with optional leading article) (golint)
    • Line 37: warning: exported type KeptnUtilsCommandExecutor should have comment or be unexported (golint)
    • Line 39: warning: exported method KeptnUtilsCommandExecutor.ExecuteCommand should have comment or be unexported (golint)
    • Line 43: warning: exported type K8sCredentialReader should have comment or be unexported (golint)
    • Line 45: warning: exported method K8sCredentialReader.GetCredentials should have comment or be unexported (golint)
    • Line 74: warning: exported type Git should have comment or be unexported (golint)
    • Line 79: warning: exported function NewGit should have comment or be unexported (golint)
    • keptn/shipyard-controller/operations/project.go
    • Line 5: warning: exported type UpdateProjectParams should have comment or be unexported (golint)
    • Line 22: warning: exported type CreateProjectParams should have comment or be unexported (golint)
    • Line 40: warning: exported type GetProjectParams should have comment or be unexported (golint)
    • Line 49: warning: exported type GetProjectProjectNameParams should have comment or be unexported (golint)
    • Line 58: warning: exported type CreateProjectResponse should have comment or be unexported (golint)
    • Line 61: warning: exported type UpdateProjectResponse should have comment or be unexported (golint)
    • Line 64: warning: exported type DeleteProjectResponse should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/evaluationmanager.go
    • Line 24: warning: comment on exported type IEvaluationManager should be of the form "IEvaluationManager ..." (with optional leading article) (golint)
    • Line 29: warning: exported type EvaluationManager should have comment or be unexported (golint)
    • Line 34: warning: exported function NewEvaluationManager should have comment or be unexported (golint)
    • Line 42: warning: exported method EvaluationManager.CreateEvaluation should have comment or be unexported (golint)
    • keptn/secret-service/pkg/controller/secretcontroller.go
    • Line 8: warning: exported const SecretAPIBasePath should have comment or be unexported (golint)
    • Line 10: warning: exported type SecretController should have comment or be unexported (golint)
    • Line 14: warning: exported function NewSecretController should have comment or be unexported (golint)
    • Line 18: warning: exported method SecretController.Inject should have comment or be unexported (golint)
    • keptn/jmeter-service/common.go
    • Line 58: warning: comment on exported function GetKeptnResource should be of the form "GetKeptnResource ..." (golint)
    • Line 89: warning: comment on exported function GetAllKeptnResources should be of the form "GetAllKeptnResources ..." (golint)
    • Line 203: warning: comment on exported function FileExists should be of the form "FileExists ..." (golint)
    • keptn/cli/pkg/credentialmanager/handler.go
    • Line 26: warning: comment on exported type CredentialManagerInterface should be of the form "CredentialManagerInterface ..." (with optional leading article) (golint)
    • Line 34: warning: exported var MockAuthCreds should have comment or be unexported (golint)
    • Line 35: warning: exported var MockKubeConfigCheck should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/sequencehooks/sequencestate.go
    • Line 16: warning: exported type SequenceStateMaterializedView should have comment or be unexported (golint)
    • Line 20: warning: exported function NewSequenceStateMaterializedView should have comment or be unexported (golint)
    • Line 24: warning: exported method SequenceStateMaterializedView.OnSequenceTriggered should have comment or be unexported (golint)
    • Line 55: warning: exported method SequenceStateMaterializedView.OnSequenceTaskTriggered should have comment or be unexported (golint)
    • Line 74: warning: exported method SequenceStateMaterializedView.OnSequenceTaskStarted should have comment or be unexported (golint)
    • Line 86: warning: exported method SequenceStateMaterializedView.OnSequenceTaskFinished should have comment or be unexported (golint)
    • Line 104: warning: exported method SequenceStateMaterializedView.OnSubSequenceFinished should have comment or be unexported (golint)
    • Line 116: warning: exported method SequenceStateMaterializedView.OnSequenceFinished should have comment or be unexported (golint)
    • keptn/test/go-tests/test_utils.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 22: warning: exported const KeptnSpecVersion should have comment or be unexported (golint)
    • Line 24: warning: exported type APIEventSender should have comment or be unexported (golint)
    • Line 27: warning: exported method APIEventSender.SendEvent should have comment or be unexported (golint)
    • Line 32: warning: exported function CreateProject should have comment or be unexported (golint)
    • Line 55: warning: exported function TriggerSequence should have comment or be unexported (golint)
    • Line 86: warning: exported function ApiGETRequest should have comment or be unexported (golint)
    • Line 105: warning: exported function ApiPOSTRequest should have comment or be unexported (golint)
    • Line 124: warning: exported function GetApiCredentials should have comment or be unexported (golint)
    • Line 140: warning: exported function ScaleDownUniform should have comment or be unexported (golint)
    • Line 150: warning: exported function ScaleUpUniform should have comment or be unexported (golint)
    • Line 160: warning: exported function CreateTmpShipyardFile should have comment or be unexported (golint)
    • Line 164: warning: exported function CreateTmpFile should have comment or be unexported (golint)
    • Line 176: warning: exported function ExecuteCommand should have comment or be unexported (golint)
    • Line 184: warning: exported function PrepareEnvVars should have comment or be unexported (golint)
    • Line 190: warning: exported function GetLatestEventOfType should have comment or be unexported (golint)
    • Line 205: warning: exported function IsEqual should have comment or be unexported (golint)
    • keptn/mongodb-datastore/handlers/events.go
    • Line 56: warning: comment on exported function UnlockProject should be of the form "UnlockProject ..." (golint)
    • Line 67: warning: exported type ProjectEventData should have comment or be unexported (golint)
    • Line 231: warning: context.Context should be the first parameter of a function (golint)
    • Line 287: warning: context.Context should be the first parameter of a function (golint)
    • Line 302: warning: context.Context should be the first parameter of a function (golint)
    • Line 632: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 731: warning: error var MinimumFilterNotProvided should have name of the form ErrFoo (golint)
    • Line 733: warning: comment on exported function GetEventsByType should be of the form "GetEventsByType ..." (golint)
    • keptn/cli/pkg/common/userinput.go
    • Line 12: warning: comment on exported type IUserInput should be of the form "IUserInput ..." (with optional leading article) (golint)
    • Line 17: warning: exported type UserInput should have comment or be unexported (golint)
    • Line 22: warning: exported type UserInputOptions should have comment or be unexported (golint)
    • Line 26: warning: exported function NewUserInput should have comment or be unexported (golint)
    • Line 33: warning: exported method UserInput.AskBool should have comment or be unexported (golint)
    • keptn/lighthouse-service/event_handler/common.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 43: warning: comment on exported type ResourceHandler should be of the form "ResourceHandler ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported type ServiceHandler should be of the form "ServiceHandler ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported type EventStore should be of the form "EventStore ..." (with optional leading article) (golint)
    • Line 58: warning: exported type SLOFileRetriever should have comment or be unexported (golint)
    • Line 63: warning: exported method SLOFileRetriever.GetSLOs should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/stagemanager.go
    • Line 8: warning: comment on exported type IStageManager should be of the form "IStageManager ..." (with optional leading article) (golint)
    • Line 14: warning: exported type StageManager should have comment or be unexported (golint)
    • Line 18: warning: exported function NewStageManager should have comment or be unexported (golint)
    • Line 24: warning: exported method StageManager.GetAllStages should have comment or be unexported (golint)
    • Line 36: warning: exported method StageManager.GetStage should have comment or be unexported (golint)
    • keptn/shipyard-controller/db/mongodb_staterepo.go
    • Line 16: warning: exported var ErrStateAlreadyExists should have comment or be unexported (golint)
    • Line 18: warning: exported type MongoDBStateRepo should have comment or be unexported (golint)
    • Line 22: warning: exported method MongoDBStateRepo.CreateSequenceState should have comment or be unexported (golint)
    • Line 53: warning: exported method MongoDBStateRepo.FindSequenceStates should have comment or be unexported (golint)
    • Line 146: warning: exported method MongoDBStateRepo.UpdateSequenceState should have comment or be unexported (golint)
    • Line 171: warning: exported method MongoDBStateRepo.DeleteSequenceStates should have comment or be unexported (golint)
    • keptn/shipyard-controller/common/utils.go
    • Line 13: warning: exported type RollbackFunc should have comment or be unexported (golint)
    • Line 15: warning: exported function Stringp should have comment or be unexported (golint)
    • Line 19: warning: exported function ValidateCreateProjectParams should have comment or be unexported (golint)
    • Line 56: warning: exported function ValidateUpdateProjectParams should have comment or be unexported (golint)
    • Line 68: warning: exported function ValidateCreateServiceParams should have comment or be unexported (golint)
    • Line 80: warning: exported function Merge should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/projecthandler.go
    • Line 16: warning: exported type IProjectHandler should have comment or be unexported (golint)
    • Line 24: warning: exported type ProjectHandler should have comment or be unexported (golint)
    • Line 29: warning: exported function NewProjectHandler should have comment or be unexported (golint)
    • Line 36: warning: comment on exported method ProjectHandler.GetAllProjects should be of the form "GetAllProjects ..." (golint)
    • Line 87: warning: comment on exported method ProjectHandler.GetProjectByName should be of the form "GetProjectByName ..." (golint)
    • Line 158: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 208: warning: comment on exported method ProjectHandler.DeleteProject should be of the form "DeleteProject ..." (golint)
    • keptn/cli/cmd/secret.go
    • Line 27: warning: exported type SecretCmdHandler should have comment or be unexported (golint)
    • Line 32: warning: exported method SecretCmdHandler.CreateSecret should have comment or be unexported (golint)
    • Line 53: warning: exported method SecretCmdHandler.UpdateSecret should have comment or be unexported (golint)
    • Line 75: warning: exported method SecretCmdHandler.DeleteSecret should have comment or be unexported (golint)
    • Line 102: warning: exported function NewSecretCmdHandler should have comment or be unexported (golint)
    • keptn/remediation-service/internal/sdk/taskregistry.go
    • Line 5: warning: exported type TaskRegistry should have comment or be unexported (golint)
    • Line 10: warning: exported type TaskEntry should have comment or be unexported (golint)
    • Line 14: warning: exported function NewTasksMap should have comment or be unexported (golint)
    • Line 20: warning: exported method TaskRegistry.Contains should have comment or be unexported (golint)
    • Line 29: warning: exported method TaskRegistry.Add should have comment or be unexported (golint)
    • Line 35: warning: exported method TaskRegistry.Get should have comment or be unexported (golint)
    • keptn/secret-service/pkg/repository/scopes.go
    • Line 9: warning: exported const ScopesConfigurationFile should have comment or be unexported (golint)
    • Line 11: warning: comment on exported type ScopesRepository should be of the form "ScopesRepository ..." (with optional leading article) (golint)
    • Line 16: warning: exported type FileBasedScopesRepository should have comment or be unexported (golint)
    • Line 21: warning: exported function NewFileBasedScopesRepository should have comment or be unexported (golint)
    • keptn/shipyard-controller/common/configurationstore.go
    • Line 9: warning: comment on exported type ConfigurationStore should be of the form "ConfigurationStore ..." (with optional leading article) (golint)
    • Line 22: warning: exported type GitConfigurationStore should have comment or be unexported (golint)
    • Line 29: warning: exported function NewGitConfigurationStore should have comment or be unexported (golint)
    • Line 38: warning: exported method GitConfigurationStore.GetProjectResource should have comment or be unexported (golint)
    • Line 42: warning: exported method GitConfigurationStore.CreateProject should have comment or be unexported (golint)
    • Line 49: warning: exported method GitConfigurationStore.UpdateProject should have comment or be unexported (golint)
    • Line 56: warning: exported method GitConfigurationStore.DeleteProject should have comment or be unexported (golint)
    • Line 66: warning: exported method GitConfigurationStore.CreateProjectShipyard should have comment or be unexported (golint)
    • Line 73: warning: exported method GitConfigurationStore.UpdateProjectResource should have comment or be unexported (golint)
    • Line 80: warning: exported method GitConfigurationStore.CreateStage should have comment or be unexported (golint)
    • Line 87: warning: exported method GitConfigurationStore.CreateService should have comment or be unexported (golint)
    • Line 94: warning: exported method GitConfigurationStore.DeleteService should have comment or be unexported (golint)
    • keptn/secret-service/pkg/backend/secretbackend_k8s.go
    • Line 19: warning: exported const SecretBackendTypeK8s should have comment or be unexported (golint)
    • Line 21: warning: exported var ErrSecretAlreadyExists should have comment or be unexported (golint)
    • Line 22: warning: exported var ErrSecretNotFound should have comment or be unexported (golint)
    • Line 24: warning: exported type K8sSecretBackend should have comment or be unexported (golint)
    • Line 30: warning: exported function NewK8sSecretBackend should have comment or be unexported (golint)
    • Line 50: warning: exported method K8sSecretBackend.CreateSecret should have comment or be unexported (golint)
    • Line 92: warning: exported method K8sSecretBackend.DeleteSecret should have comment or be unexported (golint)
    • Line 128: warning: exported method K8sSecretBackend.UpdateSecret should have comment or be unexported (golint)
    • keptn/shipyard-controller/db/projects_materialized_view.go
    • Line 38: warning: exported type ProjectsMaterializedView should have comment or be unexported (golint)
    • Line 69: warning: comment on exported method ProjectsMaterializedView.UpdateShipyard should be of the form "UpdateShipyard ..." (golint)
    • Line 180: warning: exported method ProjectsMaterializedView.UpdatedShipyard should have comment or be unexported (golint)
    • Line 365: warning: exported method ProjectsMaterializedView.GetService should have comment or be unexported (golint)
    • keptn/cli/cmd/authenticator.go
    • Line 12: warning: exported type MockedCredentialGetSetter should have comment or be unexported (golint)
    • Line 17: warning: exported method MockedCredentialGetSetter.SetCreds should have comment or be unexported (golint)
    • Line 20: warning: exported method MockedCredentialGetSetter.GetCreds should have comment or be unexported (golint)
    • Line 24: warning: exported type CredentialGetSetter should have comment or be unexported (golint)
    • Line 29: warning: exported type Authenticator should have comment or be unexported (golint)
    • Line 34: warning: exported type AuthenticatorOptions should have comment or be unexported (golint)
    • Line 39: warning: exported function NewAuthenticator should have comment or be unexported (golint)
    • Line 46: warning: exported method Authenticator.GetCredentials should have comment or be unexported (golint)
    • Line 50: warning: exported method Authenticator.Auth should have comment or be unexported (golint)
    • keptn/secret-service/pkg/handler/secrethandler.go
    • Line 10: warning: exported type ISecretHandler should have comment or be unexported (golint)
    • Line 16: warning: exported function NewSecretHandler should have comment or be unexported (golint)
    • Line 22: warning: exported type SecretHandler should have comment or be unexported (golint)
    • Line 59: warning: comment on exported method SecretHandler.UpdateSecret should be of the form "UpdateSecret ..." (golint)
    • Line 91: warning: comment on exported method SecretHandler.DeleteSecret should be of the form "DeleteSecret ..." (golint)
    • Line 128: warning: exported type DeleteSecretQueryParams should have comment or be unexported (golint)
    • keptn/remediation-service/internal/sdk/fake/test_keptn.go
    • Line 8: warning: exported type FakeKeptn should have comment or be unexported (golint)
    • Line 13: warning: exported method FakeKeptn.GetResourceHandler should have comment or be unexported (golint)
    • Line 20: warning: exported method FakeKeptn.GetTaskRegistry should have comment or be unexported (golint)
    • Line 24: warning: exported method FakeKeptn.SetConfigurationServiceURL should have comment or be unexported (golint)
    • Line 28: warning: exported method FakeKeptn.NewEvent should have comment or be unexported (golint)
    • Line 33: warning: exported method FakeKeptn.GetEventSender should have comment or be unexported (golint)
    • Line 37: warning: exported function NewFakeKeptn should have comment or be unexported (golint)
    • Line 58: warning: exported method FakeKeptn.Start should have comment or be unexported (golint)
    • keptn/secret-service/pkg/handler/common.go
    • Line 11: warning: exported function SetBadRequestErrorResponse should have comment or be unexported (golint)
    • Line 19: warning: exported function SetInternalServerErrorResponse should have comment or be unexported (golint)
    • Line 27: warning: exported function SetConflictErrorResponse should have comment or be unexported (golint)
    • Line 35: warning: exported function SetNotFoundErrorResponse should have comment or be unexported (golint)
    • keptn/jmeter-service/model.go
    • Line 22: warning: don't use underscores in Go names; const TestStrategy_Performance should be TestStrategyPerformance (golint)
    • Line 23: warning: don't use underscores in Go names; const TestStrategy_Functional should be TestStrategyFunctional (golint)
    • Line 24: warning: don't use underscores in Go names; const TestStrategy_HealthCheck should be TestStrategyHealthCheck (golint)
    • Line 25: warning: don't use underscores in Go names; const TestStrategy_RealUser should be TestStrategyRealUser (golint)
    • Line 28: warning: exported type JMeterConf should have comment or be unexported (golint)
    • Line 33: warning: exported type Workload should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/projectmanager.go
    • Line 23: warning: comment on exported type IProjectManager should be of the form "IProjectManager ..." (with optional leading article) (golint)
    • Line 32: warning: exported type ProjectManager should have comment or be unexported (golint)
    • Line 44: warning: exported function NewProjectManager should have comment or be unexported (golint)
    • Line 60: warning: exported method ProjectManager.Get should have comment or be unexported (golint)
    • Line 69: warning: exported method ProjectManager.GetByName should have comment or be unexported (golint)
    • Line 81: warning: error should be the last type when returning multiple items (golint)
    • Line 81: warning: exported method ProjectManager.Create should have comment or be unexported (golint)
    • Line 166: warning: error should be the last type when returning multiple items (golint)
    • Line 166: warning: exported method ProjectManager.Update should have comment or be unexported (golint)
    • Line 284: warning: error should be the last type when returning multiple items (golint)
    • Line 284: warning: exported method ProjectManager.Delete should have comment or be unexported (golint)
    • keptn/remediation-service/internal/sdk/keptn.go
    • Line 14: warning: exported const KeptnContextCEExtension should have comment or be unexported (golint)
    • Line 15: warning: exported const TriggeredIDCEExtension should have comment or be unexported (golint)
    • Line 16: warning: exported const ConfigurationServiceURL should have comment or be unexported (golint)
    • Line 18: warning: comment on exported type ResourceHandler should be of the form "ResourceHandler ..." (with optional leading article) (golint)
    • Line 24: warning: exported type Error should have comment or be unexported (golint)
    • Line 31: warning: comment on exported type TaskHandler should be of the form "TaskHandler ..." (with optional leading article) (golint)
    • Line 45: warning: exported type KeptnOption should have comment or be unexported (golint)
    • Line 54: warning: exported type IKeptn should have comment or be unexported (golint)
    • Line 93: warning: exported method Keptn.Start should have comment or be unexported (golint)
    • Line 100: warning: exported method Keptn.GetResourceHandler should have comment or be unexported (golint)
    • Line 104: warning: exported method Keptn.GetTaskRegistry should have comment or be unexported (golint)
    • keptn/remediation-service/internal/sdk/events.go
    • Line 8: warning: exported const DefaultHTTPEventEndpoint should have comment or be unexported (golint)
    • Line 10: warning: comment on exported type EventSender should be of the form "EventSender ..." (with optional leading article) (golint)
    • Line 15: warning: exported type EventReceiver should have comment or be unexported (golint)
    • keptn/distributor/pkg/lib/cloudeventscache.go
    • Line 8: warning: exported type CloudEventsCache should have comment or be unexported (golint)
    • Line 13: warning: exported function NewCloudEventsCache should have comment or be unexported (golint)
    • Line 19: warning: exported method CloudEventsCache.Add should have comment or be unexported (golint)
    • Line 33: warning: exported method CloudEventsCache.Get should have comment or be unexported (golint)
    • Line 59: warning: exported method CloudEventsCache.Contains should have comment or be unexported (golint)
    • Line 72: warning: exported method CloudEventsCache.Keep should have comment or be unexported (golint)
    • Line 89: warning: exported method CloudEventsCache.Length should have comment or be unexported (golint)
    • keptn/distributor/pkg/lib/nats_connection_handler.go
    • Line 12: warning: exported type NatsConnectionHandler should have comment or be unexported (golint)
    • Line 23: warning: exported function NewNatsConnectionHandler should have comment or be unexported (golint)
    • Line 32: warning: exported method NatsConnectionHandler.RemoveAllSubscriptions should have comment or be unexported (golint)
    • Line 44: warning: exported method NatsConnectionHandler.SubscribeToTopics should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/common.go
    • Line 12: warning: comment on exported type IEventSender should be of the form "IEventSender ..." (with optional leading article) (golint)
    • Line 17: warning: exported function SetNotFoundErrorResponse should have comment or be unexported (golint)
    • Line 25: warning: exported function SetInternalServerErrorResponse should have comment or be unexported (golint)
    • Line 33: warning: exported function SetBadRequestErrorResponse should have comment or be unexported (golint)
    • Line 41: warning: exported function SetConflictErrorResponse should have comment or be unexported (golint)
    • keptn/secret-service/pkg/model/scope.go
    • Line 3: warning: exported type Scopes should have comment or be unexported (golint)
    • Line 7: warning: exported type Scope should have comment or be unexported (golint)
    • Line 11: warning: exported type Capability should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/fake/shipyardcontroller.go
    • Line 8: warning: exported type ShipyardController should have comment or be unexported (golint)
    • Line 14: warning: exported method ShipyardController.GetAllTriggeredEvents should have comment or be unexported (golint)
    • Line 18: warning: exported method ShipyardController.GetTriggeredEventsOfProject should have comment or be unexported (golint)
    • Line 22: warning: exported method ShipyardController.HandleIncomingEvent should have comment or be unexported (golint)
    • keptn/cli/cmd/helpers.go
    • Line 86: warning: exported function LookupHostname should have comment or be unexported (golint)
    • Line 106: warning: exported function CheckEndpointStatus should have comment or be unexported (golint)
    • keptn/secret-service/pkg/backend/registry.go
    • Line 5: warning: exported function Register should have comment or be unexported (golint)
    • Line 9: warning: exported function GetRegisteredBackends should have comment or be unexported (golint)
    • Line 17: warning: exported function CreateBackend should have comment or be unexported (golint)
    • keptn/shipyard-controller/handler/statehandler.go
    • Line 10: warning: exported type IStateHandler should have comment or be unexported (golint)
    • Line 14: warning: exported type StateHandler should have comment or be unexported (golint)
    • Line 18: warning: exported function NewStateHandler should have comment or be unexported (golint)
    • Line 22: warning: comment on exported method StateHandler.GetSequenceState should be of the form "GetSequenceState ..." (golint)
    • keptn/shipyard-controller/models/state.go
    • Line 3: warning: exported type GetSequenceStateParams should have comment or be unexported (golint)
    • Line 41: warning: exported type StateFilter should have comment or be unexported (golint)
    • Line 46: warning: exported type SequenceStateEvaluation should have comment or be unexported (golint)
    • Line 51: warning: exported type SequenceStateEvent should have comment or be unexported (golint)
    • Line 57: warning: exported type SequenceStateStage should have comment or be unexported (golint)
    • Line 65: warning: exported type SequenceState should have comment or be unexported (golint)
    • Line 75: warning: exported type SequenceStates should have comment or be unexported (golint)
    • keptn/cli/pkg/kube/kube_utils.go
    • Line 18: warning: comment on exported type IKeptnNamespaceHandler should be of the form "IKeptnNamespaceHandler ..." (with optional leading article) (golint)
    • Line 25: warning: exported type KubernetesUtilsKeptnNamespaceHandler should have comment or be unexported (golint)
    • Line 27: warning: exported function NewKubernetesUtilsKeptnNamespaceHandler should have comment or be unexported (golint)
    • Line 31: warning: exported method KubernetesUtilsKeptnNamespaceHandler.ExistsNamespace should have comment or be unexported (golint)
    • Line 35: warning: exported method KubernetesUtilsKeptnNamespaceHandler.CreateNamespace should have comment or be unexported (golint)
    • Line 39: warning: exported method KubernetesUtilsKeptnNamespaceHandler.PatchKeptnManagedNamespace should have comment or be unexported (golint)
    • keptn/helm-service/controller/rollback_handler.go
    • Line 12: warning: exported type RollbackHandler should have comment or be unexported (golint)
    • Line 18: warning: exported function NewRollbackHandler should have comment or be unexported (golint)
    • Line 28: warning: exported method RollbackHandler.HandleEvent should have comment or be unexported (golint)
    • keptn/remediation-service/handler/get_action_event_handler.go
    • Line 15: warning: exported type GetActionEventHandler should have comment or be unexported (golint)
    • Line 18: warning: exported function NewGetActionEventHandler should have comment or be unexported (golint)
    • Line 22: warning: exported method GetActionEventHandler.Execute should have comment or be unexported (golint)
    • Line 52: warning: exported method GetActionEventHandler.InitData should have comment or be unexported (golint)
    • Line 82: warning: comment on exported function GetNextAction should be of the form "GetNextAction ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

    • keptn/shipyard-controller/handler/shipyardcontroller_test.go
    • Line 554: warning: ineffectual assignment to done (ineffassign)
    • Line 624: warning: ineffectual assignment to err (ineffassign)
    • Line 748: warning: ineffectual assignment to triggeredID (ineffassign)
    • Line 774: warning: ineffectual assignment to done (ineffassign)
    • Line 845: warning: ineffectual assignment to done (ineffassign)
    • Line 922: warning: ineffectual assignment to done (ineffassign)
    • Line 1045: warning: ineffectual assignment to done (ineffassign)
    • Line 1094: warning: ineffectual assignment to done (ineffassign)
    • Line 1126: warning: ineffectual assignment to done (ineffassign)
    • Line 1252: warning: ineffectual assignment to err (ineffassign)
    • Line 1285: warning: ineffectual assignment to triggeredID (ineffassign)
    • Line 1285: warning: ineffectual assignment to done (ineffassign)
    • Line 2092: warning: ineffectual assignment to nextStage (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!