Preparing report...

Report for github.com/konpyutaika/nifikop

(v0.8.0-release)

A    Great!    Found 76 issues across 120 files

Tweet

gofmt68%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo86%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • controllers/nificlustertask_controller.go
    • Line 66: warning: cyclomatic complexity 22 of function (*NifiClusterTaskReconciler).Reconcile() is high (> 15) (gocyclo)
    • Line 269: warning: cyclomatic complexity 17 of function (*NifiClusterTaskReconciler).handlePodRunningTask() is high (> 15) (gocyclo)
    • pkg/resources/nifi/nifi.go
    • Line 85: warning: cyclomatic complexity 40 of function (*Reconciler).Reconcile() is high (> 15) (gocyclo)
    • Line 522: warning: cyclomatic complexity 38 of function (*Reconciler).reconcileNifiPod() is high (> 15) (gocyclo)
    • Line 260: warning: cyclomatic complexity 31 of function (*Reconciler).reconcileNifiPodDelete() is high (> 15) (gocyclo)
    • Line 444: warning: cyclomatic complexity 17 of function (*Reconciler).reconcileNifiPVC() is high (> 15) (gocyclo)
    • main.go
    • Line 46: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)
    • controllers/nificluster_controller.go
    • Line 80: warning: cyclomatic complexity 25 of function (*NifiClusterReconciler).Reconcile() is high (> 15) (gocyclo)
    • Line 204: warning: cyclomatic complexity 17 of function (*NifiClusterReconciler).checkFinalizers() is high (> 15) (gocyclo)

golint58%

Golint is a linter for Go source code.

    • api/v1alpha1/common_types.go
    • Line 22: warning: comment on exported type ActionStep should be of the form "ActionStep ..." (with optional leading article) (golint)
    • Line 31: warning: comment on exported type InitClusterNode should be of the form "InitClusterNode ..." (with optional leading article) (golint)
    • Line 52: warning: exported method State.IsUpscale should have comment or be unexported (golint)
    • Line 56: warning: exported method State.IsDownscale should have comment or be unexported (golint)
    • Line 60: warning: exported method State.IsRunningState should have comment or be unexported (golint)
    • Line 64: warning: exported method State.IsRequiredState should have comment or be unexported (golint)
    • Line 68: warning: exported method State.Complete should have comment or be unexported (golint)
    • Line 79: warning: exported method ClusterState.IsReady should have comment or be unexported (golint)
    • Line 144: warning: exported type AccessPolicy should have comment or be unexported (golint)
    • Line 163: warning: exported method AccessPolicy.GetResource should have comment or be unexported (golint)
    • Line 179: warning: comment on exported const GlobalAccessPolicyType should be of the form "GlobalAccessPolicyType ..." (golint)
    • Line 181: warning: comment on exported const ComponentAccessPolicyType should be of the form "ComponentAccessPolicyType ..." (golint)
    • Line 184: warning: comment on exported const ReadAccessPolicyAction should be of the form "ReadAccessPolicyAction ..." (golint)
    • Line 186: warning: comment on exported const WriteAccessPolicyAction should be of the form "WriteAccessPolicyAction ..." (golint)
    • Line 189: warning: comment on exported const FlowAccessPolicyResource should be of the form "FlowAccessPolicyResource ..." (golint)
    • Line 192: warning: comment on exported const ControllerAccessPolicyResource should be of the form "ControllerAccessPolicyResource ..." (golint)
    • Line 194: warning: comment on exported const ParameterContextAccessPolicyResource should be of the form "ParameterContextAccessPolicyResource ..." (golint)
    • Line 197: warning: comment on exported const ProvenanceAccessPolicyResource should be of the form "ProvenanceAccessPolicyResource ..." (golint)
    • Line 199: warning: comment on exported const RestrictedComponentsAccessPolicyResource should be of the form "RestrictedComponentsAccessPolicyResource ..." (golint)
    • Line 204: warning: comment on exported const PoliciesAccessPolicyResource should be of the form "PoliciesAccessPolicyResource ..." (golint)
    • Line 206: warning: comment on exported const TenantsAccessPolicyResource should be of the form "TenantsAccessPolicyResource ..." (golint)
    • Line 208: warning: comment on exported const SiteToSiteAccessPolicyResource should be of the form "SiteToSiteAccessPolicyResource ..." (golint)
    • Line 210: warning: comment on exported const SystemAccessPolicyResource should be of the form "SystemAccessPolicyResource ..." (golint)
    • Line 212: warning: comment on exported const ProxyAccessPolicyResource should be of the form "ProxyAccessPolicyResource ..." (golint)
    • Line 214: warning: comment on exported const CountersAccessPolicyResource should be of the form "CountersAccessPolicyResource ..." (golint)
    • Line 217: warning: comment on exported const ComponentsAccessPolicyResource should be of the form "ComponentsAccessPolicyResource ..." (golint)
    • Line 220: warning: comment on exported const OperationAccessPolicyResource should be of the form "OperationAccessPolicyResource ..." (golint)
    • Line 223: warning: comment on exported const ProvenanceDataAccessPolicyResource should be of the form "ProvenanceDataAccessPolicyResource ..." (golint)
    • Line 225: warning: comment on exported const DataAccessPolicyResource should be of the form "DataAccessPolicyResource ..." (golint)
    • Line 228: warning: comment on exported const PoliciesComponentAccessPolicyResource should be of the form "PoliciesComponentAccessPolicyResource ..." (golint)
    • Line 230: warning: comment on exported const DataTransferAccessPolicyResource should be of the form "DataTransferAccessPolicyResource ..." (golint)
    • Line 233: warning: comment on exported const ProcessGroupType should be of the form "ProcessGroupType ..." (golint)
    • Line 246: warning: exported const ClientConfigTLS should have comment (or a comment on this block) or be unexported (golint)
    • Line 251: warning: exported const ExternalCluster should have comment (or a comment on this block) or be unexported (golint)
    • Line 260: warning: comment on exported const DataflowStateRan should be of the form "DataflowStateRan ..." (golint)
    • Line 282: warning: comment on exported const TLSKey should be of the form "TLSKey ..." (golint)
    • Line 318: warning: comment on exported type NodeState should be of the form "NodeState ..." (with optional leading article) (golint)
    • Line 344: warning: comment on exported const GracefulDownscaleRequired should be of the form "GracefulDownscaleRequired ..." (golint)
    • Line 349: warning: comment on exported const GracefulDownscaleSucceeded should be of the form "GracefulDownscaleSucceeded ..." (golint)
    • Line 378: warning: comment on exported const RemovePodStatus should be of the form "RemovePodStatus ..." (golint)
    • Line 395: warning: exported function ClusterRefsEquals should have comment or be unexported (golint)
    • Line 409: warning: exported function SecretRefsEquals should have comment or be unexported (golint)
    • Line 420: warning: exported type DataflowSyncMode should have comment or be unexported (golint)
    • Line 423: warning: exported const SyncNever should have comment (or a comment on this block) or be unexported (golint)
    • api/v1alpha1/nifiuser_types.go
    • Line 62: warning: exported method NifiUserSpec.GetCreateCert should have comment or be unexported (golint)
    • Line 69: warning: exported method NifiUser.GetIdentity should have comment or be unexported (golint)
    • pkg/nificlient/common.go
    • Line 9: warning: exported var ErrNodeNotConnected should have comment or be unexported (golint)
    • Line 10: warning: exported var ErrNifiClusterNotReturned200 should have comment or be unexported (golint)
    • Line 11: warning: exported var ErrNifiClusterNotReturned201 should have comment or be unexported (golint)
    • Line 12: warning: exported var ErrNifiClusterReturned404 should have comment or be unexported (golint)
    • Line 13: warning: exported var ErrNifiClusterNodeNotFound should have comment or be unexported (golint)
    • Line 15: warning: exported var ErrNoNodeClientsAvailable should have comment or be unexported (golint)
    • api/v1alpha1/nificluster_types.go
    • Line 13: warning: exported const ClusterListenerType should have comment (or a comment on this block) or be unexported (golint)
    • Line 102: warning: exported type ServicePolicy should have comment or be unexported (golint)
    • Line 110: warning: exported type PodPolicy should have comment or be unexported (golint)
    • Line 145: warning: exported type ReadOnlyConfig should have comment or be unexported (golint)
    • Line 213: warning: comment on exported type LogbackConfig should be of the form "LogbackConfig ..." (with optional leading article) (golint)
    • Line 221: warning: exported type BootstrapNotificationServicesConfig should have comment or be unexported (golint)
    • Line 340: warning: exported type ExternalServiceConfig should have comment or be unexported (golint)
    • Line 358: warning: exported type ExternalServiceSpec should have comment or be unexported (golint)
    • Line 416: warning: exported type PortConfig should have comment or be unexported (golint)
    • Line 456: warning: exported type PrometheusReportingTaskStatus should have comment or be unexported (golint)
    • Line 488: warning: exported type ManagedUser should have comment or be unexported (golint)
    • Line 497: warning: exported method ManagedUser.GetIdentity should have comment or be unexported (golint)
    • Line 516: warning: exported method NifiClusterSpec.GetInitContainerImage should have comment or be unexported (golint)
    • Line 524: warning: exported method ListenersConfig.GetClusterDomain should have comment or be unexported (golint)
    • Line 532: warning: exported method ReadOnlyConfig.GetMaximumTimerDrivenThreadCount should have comment or be unexported (golint)
    • Line 539: warning: exported method NifiClusterTaskSpec.GetDurationMinutes should have comment or be unexported (golint)
    • Line 574: warning: comment on exported method NodeConfig.GetNodeAnnotations should be of the form "GetNodeAnnotations ..." (golint)
    • Line 596: warning: comment on exported method NodeConfig.GetRunAsUser should be of the form "GetRunAsUser ..." (golint)
    • Line 606: warning: exported method NodeConfig.GetFSGroup should have comment or be unexported (golint)
    • Line 615: warning: comment on exported method NodeConfig.GetIsNode should be of the form "GetIsNode ..." (golint)
    • Line 623: warning: exported method NodeConfig.GetProvenanceStorage should have comment or be unexported (golint)
    • Line 638: warning: comment on exported method NifiProperties.GetAuthorizer should be of the form "GetAuthorizer ..." (golint)
    • Line 646: warning: comment on exported method NifiClusterSpec.GetMetricPort should be of the form "GetMetricPort ..." (golint)
    • Line 659: warning: exported method NifiCluster.RootProcessGroupId should have comment or be unexported (golint)
    • Line 663: warning: exported method NifiCluster.GetClientType should have comment or be unexported (golint)
    • Line 663: warning: receiver name c should be consistent with previous receiver name cluster for NifiCluster (golint)
    • Line 670: warning: exported method NifiCluster.GetType should have comment or be unexported (golint)
    • Line 670: warning: receiver name c should be consistent with previous receiver name cluster for NifiCluster (golint)
    • Line 677: warning: exported method NifiCluster.IsSet should have comment or be unexported (golint)
    • Line 677: warning: receiver name c should be consistent with previous receiver name cluster for NifiCluster (golint)
    • Line 682: warning: exported method NifiCluster.IsInternal should have comment or be unexported (golint)
    • Line 682: warning: receiver name c should be consistent with previous receiver name cluster for NifiCluster (golint)
    • Line 686: warning: exported method NifiCluster.IsExternal should have comment or be unexported (golint)
    • Line 686: warning: receiver name c should be consistent with previous receiver name cluster for NifiCluster (golint)
    • Line 690: warning: exported method NifiCluster.IsReady should have comment or be unexported (golint)
    • Line 700: warning: exported method NifiCluster.Id should have comment or be unexported (golint)
    • api/v1alpha1/nifidataflow_types.go
    • Line 40: warning: exported type FlowPosition should have comment or be unexported (golint)
    • Line 47: warning: exported type UpdateRequest should have comment or be unexported (golint)
    • Line 66: warning: exported type DropRequest should have comment or be unexported (golint)
    • Line 140: warning: exported method NifiDataflowSpec.GetSyncMode should have comment or be unexported (golint)
    • Line 147: warning: exported method NifiDataflowSpec.SyncOnce should have comment or be unexported (golint)
    • Line 154: warning: exported method NifiDataflowSpec.SyncAlways should have comment or be unexported (golint)
    • Line 161: warning: exported method NifiDataflowSpec.SyncNever should have comment or be unexported (golint)
    • Line 168: warning: exported method NifiDataflowSpec.GetParentProcessGroupID should have comment or be unexported (golint)
    • pkg/clientwrappers/scale/scale.go
    • Line 18: warning: comment on exported function UpScaleCluster should be of the form "UpScaleCluster ..." (golint)
    • Line 27: warning: comment on exported function DisconnectClusterNode should be of the form "DisconnectClusterNode ..." (golint)
    • Line 53: warning: comment on exported function OffloadClusterNode should be of the form "OffloadClusterNode ..." (golint)
    • Line 79: warning: comment on exported function ConnectClusterNode should be of the form "ConnectClusterNode ..." (golint)
    • Line 105: warning: comment on exported function RemoveClusterNode should be of the form "RemoveClusterNode ..." (golint)
    • Line 135: warning: comment on exported function CheckIfNCActionStepFinished should be of the form "CheckIfNCActionStepFinished ..." (golint)
    • Line 184: warning: exported function EnsureRemovedNodes should have comment or be unexported (golint)
    • Line 219: warning: should omit 2nd value from range; this loop is equivalent to `for nodeId := range ...` (golint)
    • pkg/clientwrappers/user/user.go
    • Line 17: warning: exported function ExistUser should have comment or be unexported (golint)
    • Line 39: warning: exported function FindUserByIdentity should have comment or be unexported (golint)
    • Line 66: warning: exported function CreateUser should have comment or be unexported (golint)
    • Line 87: warning: exported function SyncUser should have comment or be unexported (golint)
    • Line 167: warning: exported function RemoveUser should have comment or be unexported (golint)
    • pkg/clientwrappers/dataflow/dataflow.go
    • Line 42: warning: exported function RootProcessGroup should have comment or be unexported (golint)
    • Line 531: warning: exported function RemoveDataflow should have comment or be unexported (golint)
    • Line 565: warning: exported function UnscheduleDataflow should have comment or be unexported (golint)
    • pkg/resources/nifi/pod.go
    • Line 39: warning: exported const ContainerName should have comment (or a comment on this block) or be unexported (golint)
    • Line 277: warning: comment on exported function GetServerPort should be of the form "GetServerPort ..." (golint)
    • pkg/clientwrappers/parametercontext/parametercontext.go
    • Line 17: warning: exported function ExistParameterContext should have comment or be unexported (golint)
    • Line 39: warning: exported function CreateParameterContext should have comment or be unexported (golint)
    • Line 61: warning: exported function SyncParameterContext should have comment or be unexported (golint)
    • Line 113: warning: exported function RemoveParameterContext should have comment or be unexported (golint)
    • pkg/nificlient/client.go
    • Line 20: warning: exported const PRIMARY_NODE should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: comment on exported const CONNECTING_STATUS should be of the form "CONNECTING_STATUS ..." (golint)
    • Line 24: warning: comment on exported const CONNECTED_STATUS should be of the form "CONNECTED_STATUS ..." (golint)
    • Line 26: warning: comment on exported const DISCONNECTING_STATUS should be of the form "DISCONNECTING_STATUS ..." (golint)
    • Line 28: warning: comment on exported const DISCONNECTED_STATUS should be of the form "DISCONNECTED_STATUS ..." (golint)
    • Line 30: warning: comment on exported const OFFLOADING_STATUS should be of the form "OFFLOADING_STATUS ..." (golint)
    • Line 32: warning: comment on exported const OFFLOADED_STATUS should be of the form "OFFLOADED_STATUS ..." (golint)
    • Line 34: warning: comment on exported const REMOVING_STATUS should be of the form "REMOVING_STATUS ..." (golint)
    • Line 36: warning: comment on exported const REMOVED_STATUS should be of the form "REMOVED_STATUS ..." (golint)
    • Line 40: warning: comment on exported type NifiClient should be of the form "NifiClient ..." (with optional leading article) (golint)
    • Line 147: warning: exported function New should have comment or be unexported (golint)
    • Line 162: warning: should omit 2nd value from range; this loop is equivalent to `for nodeId := range ...` (golint)
    • Line 228: warning: should omit 2nd value from range; this loop is equivalent to `for nodeId := range ...` (golint)
    • pkg/util/util.go
    • Line 80: warning: exported function MergeAnnotations should have comment or be unexported (golint)
    • Line 198: warning: exported function NodesToIdList should have comment or be unexported (golint)
    • Line 205: warning: comment on exported function Max should be of the form "Max ..." (golint)
    • Line 213: warning: exported function Hash should have comment or be unexported (golint)
    • Line 219: warning: exported function GetEnvWithDefault should have comment or be unexported (golint)
    • Line 226: warning: exported function MustConvertToInt should have comment or be unexported (golint)
    • Line 235: warning: exported function GetRequeueInterval should have comment or be unexported (golint)
    • pkg/nificlient/config/nificluster/internalcluster.go
    • Line 9: warning: exported type InternalCluster should have comment or be unexported (golint)
    • Line 15: warning: exported method InternalCluster.ClusterLabelString should have comment or be unexported (golint)
    • Line 19: warning: exported method InternalCluster.IsInternal should have comment or be unexported (golint)
    • Line 19: warning: receiver name c should be consistent with previous receiver name cluster for InternalCluster (golint)
    • Line 23: warning: exported method InternalCluster.IsExternal should have comment or be unexported (golint)
    • Line 23: warning: receiver name c should be consistent with previous receiver name cluster for InternalCluster (golint)
    • Line 27: warning: exported method InternalCluster.IsReady should have comment or be unexported (golint)
    • Line 27: warning: receiver name c should be consistent with previous receiver name cluster for InternalCluster (golint)
    • Line 37: warning: exported method InternalCluster.Id should have comment or be unexported (golint)
    • Line 37: warning: receiver name c should be consistent with previous receiver name cluster for InternalCluster (golint)
    • pkg/common/common.go
    • Line 46: warning: comment on exported var NewNifiFromConfig should be of the form "NewNifiFromConfig ..." (golint)
    • Line 50: warning: comment on exported function NewClusterConnection should be of the form "NewClusterConnection ..." (golint)
    • Line 62: warning: exported type RequeueConfig should have comment or be unexported (golint)
    • Line 72: warning: exported function NewRequeueConfig should have comment or be unexported (golint)
    • controllers/controller_common.go
    • Line 19: warning: exported var ClusterRefLabel should have comment or be unexported (golint)
    • Line 21: warning: comment on exported function RequeueWithError should be of the form "RequeueWithError ..." (golint)
    • Line 30: warning: exported function Requeue should have comment or be unexported (golint)
    • Line 34: warning: exported function RequeueAfter should have comment or be unexported (golint)
    • Line 38: warning: comment on exported function Reconciled should be of the form "Reconciled ..." (golint)
    • Line 44: warning: comment on exported function ClusterLabelString should be of the form "ClusterLabelString ..." (golint)
    • Line 49: warning: comment on exported function CheckNodeConnectionError should be of the form "CheckNodeConnectionError ..." (golint)
    • Line 74: warning: comment on exported function ApplyClusterRefLabel should be of the form "ApplyClusterRefLabel ..." (golint)
    • Line 90: warning: comment on exported function ApplyClusterReferenceLabel should be of the form "ApplyClusterReferenceLabel ..." (golint)
    • Line 106: warning: comment on exported function GetClusterRefNamespace should be of the form "GetClusterRefNamespace ..." (golint)
    • pkg/nificlient/config/config_manager.go
    • Line 12: warning: exported var MockClientConfig should have comment or be unexported (golint)
    • Line 14: warning: exported function GetClientConfigManager should have comment or be unexported (golint)
    • Line 35: warning: exported function NewMockClientConfig should have comment or be unexported (golint)
    • pkg/resources/templates/config/authorizers.go
    • Line 3: warning: comment on exported var AuthorizersTemplate should be of the form "AuthorizersTemplate ..." (golint)
    • Line 38: warning: comment on exported var EmptyAuthorizersTemplate should be of the form "EmptyAuthorizersTemplate ..." (golint)
    • pkg/clientwrappers/common.go
    • Line 10: warning: exported function ErrorUpdateOperation should have comment or be unexported (golint)
    • Line 21: warning: exported function ErrorGetOperation should have comment or be unexported (golint)
    • Line 33: warning: exported function ErrorCreateOperation should have comment or be unexported (golint)
    • Line 45: warning: exported function ErrorRemoveOperation should have comment or be unexported (golint)
    • pkg/util/zookeeper/common.go
    • Line 11: warning: comment on exported function GetHostnameAddress should be of the form "GetHostnameAddress ..." (golint)
    • Line 16: warning: comment on exported function GetPortAddress should be of the form "GetPortAddress ..." (golint)
    • pkg/nificlient/config/basic/basic_config.go
    • Line 71: warning: exported type Claims should have comment or be unexported (golint)
    • Line 201: warning: exported function GetControllerBasicConfigFromSecret should have comment or be unexported (golint)
    • Line 228: warning: exported function GetAccessTokenSecret should have comment or be unexported (golint)
    • pkg/nificlient/config/nificluster/externalcluster.go
    • Line 11: warning: exported type ExternalCluster should have comment or be unexported (golint)
    • Line 21: warning: exported method ExternalCluster.IsExternal should have comment or be unexported (golint)
    • Line 25: warning: exported method ExternalCluster.IsInternal should have comment or be unexported (golint)
    • Line 29: warning: exported method ExternalCluster.ClusterLabelString should have comment or be unexported (golint)
    • Line 33: warning: exported method ExternalCluster.IsReady should have comment or be unexported (golint)
    • Line 52: warning: exported method ExternalCluster.Id should have comment or be unexported (golint)
    • pkg/util/clientconfig/common.go
    • Line 10: warning: exported const NifiDefaultTimeout should have comment (or a comment on this block) or be unexported (golint)
    • Line 13: warning: exported type Manager should have comment or be unexported (golint)
    • Line 18: warning: exported type ClusterConnect should have comment or be unexported (golint)
    • Line 43: warning: exported type NodeUri should have comment or be unexported (golint)
    • pkg/k8sutil/resource.go
    • Line 135: warning: exported function IsPodTerminatedOrShutdown should have comment or be unexported (golint)
    • Line 139: warning: exported function IsPodContainsTerminatedContainer should have comment or be unexported (golint)
    • Line 148: warning: exported function IsPodContainsPendingContainer should have comment or be unexported (golint)
    • Line 157: warning: exported function PodReady should have comment or be unexported (golint)
    • pkg/util/nifi/common.go
    • Line 12: warning: exported const PrefixNodeNameTemplate should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported function ParseStringToInt32 should have comment or be unexported (golint)
    • Line 42: warning: comment on exported function ComputeNodeName should be of the form "ComputeNodeName ..." (golint)
    • Line 48: warning: exported function ComputeRequestNiFiNodeService should have comment or be unexported (golint)
    • Line 58: warning: exported function ComputeRequestNiFiNodeNamespace should have comment or be unexported (golint)
    • Line 66: warning: exported function ComputeRequestNiFiNodeNamespaceFull should have comment or be unexported (golint)
    • Line 78: warning: exported function ComputeRequestNiFiNodeHostname should have comment or be unexported (golint)
    • Line 90: warning: exported function ComputeRequestNiFiNodeAddress should have comment or be unexported (golint)
    • Line 103: warning: exported function GenerateRequestNiFiNodeAddressFromCluster should have comment or be unexported (golint)
    • Line 115: warning: exported function GenerateRequestNiFiNodeHostnameFromCluster should have comment or be unexported (golint)
    • Line 126: warning: comment on exported function ComputeRequestNiFiAllNodeService should be of the form "ComputeRequestNiFiAllNodeService ..." (golint)
    • Line 135: warning: exported function ComputeRequestNiFiAllNodeNamespace should have comment or be unexported (golint)
    • Line 143: warning: exported function ComputeRequestNiFiAllNodeNamespaceFull should have comment or be unexported (golint)
    • Line 154: warning: exported function ComputeRequestNiFiAllNodeHostname should have comment or be unexported (golint)
    • Line 165: warning: exported function ComputeRequestNiFiAllNodeAddress should have comment or be unexported (golint)
    • Line 177: warning: exported function GenerateRequestNiFiAllNodeAddressFromCluster should have comment or be unexported (golint)
    • Line 188: warning: exported function GenerateRequestNiFiAllNodeHostnameFromCluster should have comment or be unexported (golint)
    • Line 200: warning: exported function ComputeHostListenerNodeHostname should have comment or be unexported (golint)
    • Line 211: warning: exported function ComputeHostListenerNodeAddress should have comment or be unexported (golint)
    • Line 224: warning: exported function GenerateHostListenerNodeAddressFromCluster should have comment or be unexported (golint)
    • Line 236: warning: exported function GenerateHostListenerNodeHostnameFromCluster should have comment or be unexported (golint)
    • Line 247: warning: exported function InternalListenerForComm should have comment or be unexported (golint)
    • pkg/clientwrappers/accesspolicies/policies.go
    • Line 15: warning: exported function ExistAccessPolicies should have comment or be unexported (golint)
    • Line 33: warning: exported function CreateAccessPolicy should have comment or be unexported (golint)
    • Line 56: warning: exported function UpdateAccessPolicy should have comment or be unexported (golint)
    • Line 92: warning: exported function UpdateAccessPolicyEntity should have comment or be unexported (golint)
    • pkg/clientwrappers/registryclient/registryclient.go
    • Line 15: warning: exported function ExistRegistryClient should have comment or be unexported (golint)
    • Line 37: warning: exported function CreateRegistryClient should have comment or be unexported (golint)
    • Line 58: warning: exported function SyncRegistryClient should have comment or be unexported (golint)
    • Line 86: warning: exported function RemoveRegistryClient should have comment or be unexported (golint)
    • pkg/clientwrappers/usergroup/usergroup.go
    • Line 16: warning: exported function ExistUserGroup should have comment or be unexported (golint)
    • Line 40: warning: exported function CreateUserGroup should have comment or be unexported (golint)
    • Line 61: warning: exported function SyncUserGroup should have comment or be unexported (golint)
    • Line 132: warning: exported function RemoveUserGroup should have comment or be unexported (golint)
    • Line 211: warning: exported function UserGroupEntityContainsAccessPolicy should have comment or be unexported (golint)
    • pkg/util/pki/common.go
    • Line 21: warning: exported const NodeCACertTemplate should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: comment on exported const SpiffeIdTemplate should be of the form "SpiffeIdTemplate ..." (golint)
    • Line 96: warning: exported function GetNodeUserName should have comment or be unexported (golint)
    • Line 101: warning: comment on exported function ClusterDNSNames should be of the form "ClusterDNSNames ..." (golint)
    • pkg/nificlient/config/common/common.go
    • Line 17: warning: exported function TlsConfig should have comment or be unexported (golint)
    • Line 25: warning: exported function ClusterConfig should have comment or be unexported (golint)
    • Line 99: warning: exported function UseSSL should have comment or be unexported (golint)
    • pkg/clientwrappers/reportingtask/reportingtask.go
    • Line 19: warning: don't use underscores in Go names; const reportingTaskType_ should be reportingTaskType (golint)
    • Line 27: warning: exported function ExistReportingTaks should have comment or be unexported (golint)
    • Line 49: warning: exported function CreateReportingTask should have comment or be unexported (golint)
    • Line 69: warning: exported function SyncReportingTask should have comment or be unexported (golint)
    • Line 127: warning: exported function RemoveReportingTaks should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell97%

Misspell Finds commonly misspelled English words