gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• engine/pkg/credentials/gitcreds/creds_test.go
  • Line 244: warning: cyclomatic complexity 17 of function TestSSHFlagHandlingTwice() is high (> 15) (gocyclo)

• engine/pkg/controller/trigger.go
  • Line 173: warning: cyclomatic complexity 24 of function (*Controller).shouldHandleTrigger() is high (> 15) (gocyclo)

• engine/apis/engine/v1alpha1/zz_generated.deepcopy.go
  • Line 263: warning: cyclomatic complexity 17 of function (*WorkflowSpec).DeepCopyInto() is high (> 15) (gocyclo)

golint65%

Golint is a linter for Go source code.

• engine/pkg/server/server.go
  • Line 24: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 66: warning: exported type KubeciServerConfig should have comment or be unexported (golint)
  • Line 77: warning: exported method KubeciServer.Run should have comment or be unexported (golint)
  • Line 88: warning: exported type CompletedConfig should have comment or be unexported (golint)

• engine/pkg/cmds/run.go
  • Line 13: warning: exported function NewCmdRun should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/workflow_template.go
  • Line 8: warning: exported const ResourceKindWorkflowTemplate should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported type WorkflowTemplate should have comment or be unexported (golint)
  • Line 23: warning: exported type WorkflowTemplateSpec should have comment or be unexported (golint)
  • Line 29: warning: exported type WorkflowTemplateList should have comment or be unexported (golint)

• engine/test/e2e/framework/namespace.go
  • Line 9: warning: exported method Framework.Namespace should have comment or be unexported (golint)
  • Line 13: warning: exported method Framework.CreateTestNamespace should have comment or be unexported (golint)
  • Line 25: warning: exported method Framework.CreateNamespace should have comment or be unexported (golint)
  • Line 30: warning: exported method Framework.DeleteNamespace should have comment or be unexported (golint)
  • Line 34: warning: exported method Framework.NewNamespace should have comment or be unexported (golint)

• engine/test/e2e/framework/operator.go
  • Line 12: warning: should not use dot imports (golint)
  • Line 13: warning: should not use dot imports (golint)
  • Line 19: warning: exported method Framework.NewTestKubeciOptions should have comment or be unexported (golint)
  • Line 34: warning: exported method Framework.StartAPIServerAndOperator should have comment or be unexported (golint)
  • Line 56: warning: exported method Framework.EventuallyAPIServerReady should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/validator.go
  • Line 3: warning: exported method Workflow.IsValid should have comment or be unexported (golint)
  • Line 7: warning: exported method Workflow.SetDefaults should have comment or be unexported (golint)

• engine/client/clientset/versioned/typed/engine/v1alpha1/util/workflow.go
  • Line 18: warning: exported function CreateOrPatchWorkflow should have comment or be unexported (golint)
  • Line 36: warning: exported function PatchWorkflow should have comment or be unexported (golint)
  • Line 40: warning: exported function PatchWorkflowObject should have comment or be unexported (golint)
  • Line 63: warning: exported function TryUpdateWorkflow should have comment or be unexported (golint)

• engine/pkg/controller/config.go
  • Line 33: warning: exported type Config should have comment or be unexported (golint)
  • Line 42: warning: exported function NewConfig should have comment or be unexported (golint)
  • Line 48: warning: exported method Config.New should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/crd.go
  • Line 11: warning: exported var EnableStatusSubresource should have comment or be unexported (golint)
  • Line 14: warning: exported method Workflow.CustomResourceDefinition should have comment or be unexported (golint)
  • Line 40: warning: exported method Workplan.CustomResourceDefinition should have comment or be unexported (golint)
  • Line 66: warning: exported method WorkflowTemplate.CustomResourceDefinition should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/doc.go
  • Line 8: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• engine/apis/engine/v1alpha1/objectref.go
  • Line 7: warning: exported method Workflow.ObjectReference should have comment or be unexported (golint)
  • Line 18: warning: exported method Workplan.ObjectReference should have comment or be unexported (golint)

• engine/pkg/cmds/server/start.go
  • Line 21: warning: exported type KubeciOptions should have comment or be unexported (golint)
  • Line 29: warning: exported function NewKubeciOptions should have comment or be unexported (golint)
  • Line 47: warning: exported method KubeciOptions.AddFlags should have comment or be unexported (golint)
  • Line 52: warning: exported method KubeciOptions.Validate should have comment or be unexported (golint)
  • Line 56: warning: exported method KubeciOptions.Complete should have comment or be unexported (golint)
  • Line 60: warning: exported method KubeciOptions.Config should have comment or be unexported (golint)
  • Line 93: warning: exported method KubeciOptions.Run should have comment or be unexported (golint)

• engine/pkg/controller/controller.go
  • Line 29: warning: exported type Controller should have comment or be unexported (golint)
  • Line 75: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 86: warning: exported method Controller.RunInformers should have comment or be unexported (golint)

• engine/pkg/controller/dynamic.go
  • Line 27: warning: exported type ResourceIdentifier should have comment or be unexported (golint)
  • Line 45: warning: exported method ResourceIdentifier.GetEnvFromPath should have comment or be unexported (golint)

• engine/pkg/controller/logs.go
  • Line 21: warning: exported type LogsREST should have comment or be unexported (golint)
  • Line 30: warning: exported function NewLogsREST should have comment or be unexported (golint)
  • Line 36: warning: exported method LogsREST.New should have comment or be unexported (golint)
  • Line 40: warning: exported method LogsREST.NamespaceScoped should have comment or be unexported (golint)
  • Line 44: warning: exported method LogsREST.GroupVersionKind should have comment or be unexported (golint)
  • Line 48: warning: exported method LogsREST.Categories should have comment or be unexported (golint)
  • Line 75: warning: exported method LogsREST.NewGetOptions should have comment or be unexported (golint)

• engine/pkg/credentials/gitcreds/creds.go
  • Line 37: warning: exported function Flags should have comment or be unexported (golint)

• engine/pkg/workplan-viewer/workplan_viewer.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 140: warning: exported function Serve should have comment or be unexported (golint)

• engine/pkg/docker/checks.go
  • Line 4: warning: exported const ACRegistry should have comment (or a comment on this block) or be unexported (golint)
  • Line 8: warning: exported type Docker should have comment or be unexported (golint)
  • Line 12: warning: exported method Docker.ToContainerImage should have comment or be unexported (golint)

• engine/apis/extensions/register.go
  • Line 3: warning: exported const GroupName should have comment or be unexported (golint)

• engine/pkg/cmds/root.go
  • Line 19: warning: exported function NewRootCmd should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/register.go
  • Line 10: warning: exported var SchemeGroupVersion should have comment or be unexported (golint)
  • Line 13: warning: comment on exported var SchemeBuilder should be of the form "SchemeBuilder ..." (golint)
  • Line 17: warning: exported var AddToScheme should have comment or be unexported (golint)

• engine/pkg/cmds/server/options.go
  • Line 18: warning: exported type ExtraOptions should have comment or be unexported (golint)
  • Line 31: warning: exported function NewExtraOptions should have comment or be unexported (golint)
  • Line 46: warning: exported method ExtraOptions.AddGoFlags should have comment or be unexported (golint)
  • Line 60: warning: exported method ExtraOptions.AddFlags should have comment or be unexported (golint)
  • Line 66: warning: exported method ExtraOptions.ApplyTo should have comment or be unexported (golint)

• engine/pkg/controller/step_tree.go
  • Line 9: warning: exported function InitWorkplanTree should have comment or be unexported (golint)
  • Line 25: warning: exported function UpdateWorkplanTreeForPod should have comment or be unexported (golint)

• engine/test/e2e/framework/framework.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 16: warning: exported type Framework should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)
  • Line 46: warning: exported method Framework.Invoke should have comment or be unexported (golint)
  • Line 53: warning: exported method Invocation.AppLabel should have comment or be unexported (golint)
  • Line 57: warning: exported method Invocation.App should have comment or be unexported (golint)
  • Line 61: warning: exported type Invocation should have comment or be unexported (golint)

• engine/pkg/logs/logs.go
  • Line 15: warning: exported type LogController should have comment or be unexported (golint)
  • Line 20: warning: exported type Query should have comment or be unexported (golint)
  • Line 28: warning: exported function NewLogController should have comment or be unexported (golint)
  • Line 43: warning: exported method LogController.WorkplanStatus should have comment or be unexported (golint)
  • Line 51: warning: exported method LogController.LogReader should have comment or be unexported (golint)

• engine/cmd/kubeci-engine/version.go
  • Line 8: warning: exported var Version should have comment or be unexported (golint)

• engine/apis/extensions/v1alpha1/register.go
  • Line 9: warning: exported const GroupName should have comment or be unexported (golint)
  • Line 11: warning: exported var SchemeGroupVersion should have comment or be unexported (golint)
  • Line 14: warning: comment on exported var SchemeBuilder should be of the form "SchemeBuilder ..." (golint)
  • Line 18: warning: exported var AddToScheme should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/workflow.go
  • Line 12: warning: exported const ResourceKindWorkflow should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type Workflow should have comment or be unexported (golint)
  • Line 27: warning: exported type ExecutionOrder should have comment or be unexported (golint)
  • Line 30: warning: exported const ExecutionOrderSerial should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported type WorkflowSpec should have comment or be unexported (golint)
  • Line 63: warning: exported type Template should have comment or be unexported (golint)
  • Line 68: warning: exported type Trigger should have comment or be unexported (golint)
  • Line 82: warning: exported type Step should have comment or be unexported (golint)
  • Line 95: warning: exported type WorkflowList should have comment or be unexported (golint)
  • Line 102: warning: exported method Workflow.Key should have comment or be unexported (golint)
  • Line 106: warning: exported method Workflow.Reference should have comment or be unexported (golint)
  • Line 116: warning: exported method Trigger.ResourceKey should have comment or be unexported (golint)

• engine/client/clientset/versioned/typed/engine/v1alpha1/util/workplan.go
  • Line 19: warning: exported function CreateOrPatchWorkplan should have comment or be unexported (golint)
  • Line 37: warning: exported function PatchWorkplan should have comment or be unexported (golint)
  • Line 41: warning: exported function PatchWorkplanObject should have comment or be unexported (golint)
  • Line 64: warning: exported function TryUpdateWorkplan should have comment or be unexported (golint)
  • Line 85: warning: exported function UpdateWorkplanStatus should have comment or be unexported (golint)

• engine/pkg/controller/workflow.go
  • Line 15: warning: exported method Controller.NewWorkflowValidatingWebhook should have comment or be unexported (golint)
  • Line 37: warning: exported method Controller.NewWorkflowMutatingWebhook should have comment or be unexported (golint)

• engine/pkg/dependency/dependency.go
  • Line 10: warning: comment on exported function ResolveDependency should be of the form "ResolveDependency ..." (golint)
  • Line 137: warning: exported function TasksToLayers should have comment or be unexported (golint)

• engine/pkg/cmds/credential.go
  • Line 14: warning: exported function NewCmdCredential should have comment or be unexported (golint)

• engine/pkg/controller/trigger.go
  • Line 25: warning: exported type TriggerREST should have comment or be unexported (golint)
  • Line 34: warning: exported function NewTriggerREST should have comment or be unexported (golint)
  • Line 40: warning: exported method TriggerREST.New should have comment or be unexported (golint)
  • Line 44: warning: exported method TriggerREST.NamespaceScoped should have comment or be unexported (golint)
  • Line 48: warning: exported method TriggerREST.GroupVersionKind should have comment or be unexported (golint)
  • Line 52: warning: exported method TriggerREST.Categories should have comment or be unexported (golint)
  • Line 56: warning: exported method TriggerREST.Create should have comment or be unexported (golint)

• engine/pkg/controller/workplan.go
  • Line 20: warning: exported method Controller.NewWorkplanMutatingWebhook should have comment or be unexported (golint)

• engine/pkg/eventer/recorder.go
  • Line 18: warning: exported const EventReasonWorkplanSucceeded should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported function NewEventRecorder should have comment or be unexported (golint)
  • Line 38: warning: exported function CreateEvent should have comment or be unexported (golint)

• engine/pkg/cmds/workplan_viewer.go
  • Line 9: warning: exported function NewCmdWorkplanViewer should have comment or be unexported (golint)

• engine/apis/extensions/v1alpha1/doc.go
  • Line 3: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• engine/apis/extensions/v1alpha1/types.go
  • Line 9: warning: exported const ResourceKindTrigger should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type Trigger should have comment or be unexported (golint)
  • Line 33: warning: exported type WorkplanLog should have comment or be unexported (golint)
  • Line 40: warning: exported type WorkplanLogOptions should have comment or be unexported (golint)

• engine/apis/engine/v1alpha1/workplan.go
  • Line 11: warning: exported const ResourceKindWorkplan should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported type Workplan should have comment or be unexported (golint)
  • Line 27: warning: exported type Task should have comment or be unexported (golint)
  • Line 32: warning: exported type WorkplanSpec should have comment or be unexported (golint)
  • Line 53: warning: exported type WorkplanPhase should have comment or be unexported (golint)
  • Line 56: warning: exported const WorkplanPending should have comment (or a comment on this block) or be unexported (golint)
  • Line 63: warning: exported type ContainerStatus should have comment or be unexported (golint)
  • Line 66: warning: exported const ContainerRunning should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: comment on exported type StepEntry should be of the form "StepEntry ..." (with optional leading article) (golint)
  • Line 80: warning: exported type WorkplanStatus should have comment or be unexported (golint)
  • Line 88: warning: exported type TriggeredFor should have comment or be unexported (golint)
  • Line 93: warning: exported type ObjectReference should have comment or be unexported (golint)
  • Line 102: warning: exported type WorkplanList should have comment or be unexported (golint)
  • Line 109: warning: exported method Workplan.Reference should have comment or be unexported (golint)

• engine/pkg/credentials/dockercreds/creds.go
  • Line 37: warning: exported function Flags should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• engine/test/e2e/e2e_suite_test.go
  • Line 56: warning: ineffectual assignment to err (ineffassign)

• engine/pkg/controller/workplan.go
  • Line 119: warning: ineffectual assignment to wp (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!