Go Report Card

Preparing report...

Report for github.com/kubeflow/kfserving

A+    Excellent!    Found 117 issues across 221 files

Tweet
Last refresh:

Refresh now

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint53%

Golint is a linter for Go source code.

    • kfserving/pkg/webhook/admission/pod/agent_injector.go
    • Line 31: warning: exported const LoggerConfigMapKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported type AgentConfig should have comment or be unexported (golint)
    • Line 48: warning: exported type LoggerConfig should have comment or be unexported (golint)
    • Line 57: warning: exported type AgentInjector should have comment or be unexported (golint)
    • Line 115: warning: exported method AgentInjector.InjectAgent should have comment or be unexported (golint)
    • kfserving/pkg/agent/storage/gcs.go
    • Line 32: warning: exported type GCSProvider should have comment or be unexported (golint)
    • Line 36: warning: exported method GCSProvider.DownloadModel should have comment or be unexported (golint)
    • Line 63: warning: exported type GCSObjectDownloader should have comment or be unexported (golint)
    • Line 72: warning: exported method GCSObjectDownloader.GetObjectIterator should have comment or be unexported (golint)
    • Line 77: warning: exported method GCSObjectDownloader.Download should have comment or be unexported (golint)
    • Line 119: warning: exported method GCSObjectDownloader.DownloadFile should have comment or be unexported (golint)
    • Line 140: warning: exported method GCSObjectDownloader.WriteToFile should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/inferenceservice_types.go
    • Line 36: warning: exported type EndpointSpec should have comment or be unexported (golint)
    • Line 74: warning: exported type LoggerMode should have comment or be unexported (golint)
    • Line 77: warning: exported const LogAll should have comment (or a comment on this block) or be unexported (golint)
    • Line 152: warning: exported type AlibiExplainerType should have comment or be unexported (golint)
    • Line 155: warning: exported const AlibiAnchorsTabularExplainer should have comment (or a comment on this block) or be unexported (golint)
    • Line 176: warning: exported type AIXExplainerType should have comment or be unexported (golint)
    • Line 179: warning: exported const AIXLimeImageExplainer should have comment (or a comment on this block) or be unexported (golint)
    • Line 287: warning: comment on exported type ComponentStatusMap should be of the form "ComponentStatusMap ..." (with optional leading article) (golint)
    • Line 333: warning: comment on exported type InferenceServiceList should be of the form "InferenceServiceList ..." (with optional leading article) (golint)
    • Line 342: warning: comment on exported type VirtualServiceStatus should be of the form "VirtualServiceStatus ..." (with optional leading article) (golint)
    • kfserving/pkg/controller/v1alpha1/trainedmodel/controller.go
    • Line 17: warning: package comment should be of the form "Package trainedmodel ..." (golint)
    • Line 53: warning: exported const InferenceServiceNotReady should have comment (or a comment on this block) or be unexported (golint)
    • Line 70: warning: exported method TrainedModelReconciler.Reconcile should have comment or be unexported (golint)
    • Line 321: warning: exported method TrainedModelReconciler.SetupWithManager should have comment or be unexported (golint)
    • kfserving/pkg/logger/worker.go
    • Line 30: warning: exported const CEInferenceRequest should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: comment on exported const InferenceServiceAttr should be of the form "InferenceServiceAttr ..." (golint)
    • Line 37: warning: comment on exported const EndpointAttr should be of the form "EndpointAttr ..." (golint)
    • Line 44: warning: comment on exported var WorkQueue should be of the form "WorkQueue ..." (golint)
    • Line 47: warning: exported function QueueLogRequest should have comment or be unexported (golint)
    • Line 70: warning: exported type Worker should have comment or be unexported (golint)
    • Line 123: warning: comment on exported method Worker.Start should be of the form "Start ..." (golint)
    • kfserving/pkg/apis/serving/v1beta1/explainer_aix360.go
    • Line 31: warning: exported type AIXExplainerType should have comment or be unexported (golint)
    • Line 34: warning: exported const AIXLimeImageExplainer should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: exported method AIXExplainerSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 54: warning: exported method AIXExplainerSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 59: warning: exported method AIXExplainerSpec.GetContainer should have comment or be unexported (golint)
    • Line 84: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 101: warning: exported method AIXExplainerSpec.Default should have comment or be unexported (golint)
    • Line 116: warning: exported method AIXExplainerSpec.GetProtocol should have comment or be unexported (golint)
    • Line 120: warning: exported method AIXExplainerSpec.IsMMS should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_triton.go
    • Line 30: warning: exported var TritonISGRPCPort should have comment or be unexported (golint)
    • Line 61: warning: comment on exported method TritonSpec.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 87: warning: exported method TritonSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 91: warning: exported method TritonSpec.GetProtocol should have comment or be unexported (golint)
    • Line 95: warning: exported method TritonSpec.IsMMS should have comment or be unexported (golint)
    • Line 99: warning: exported method TritonSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/credentials/s3/s3_secret.go
    • Line 25: warning: exported const AWSAccessKeyId should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported type S3Config should have comment or be unexported (golint)
    • Line 46: warning: exported var InferenceServiceS3SecretEndpointAnnotation should have comment or be unexported (golint)
    • Line 54: warning: exported function BuildSecretEnvs should have comment or be unexported (golint)
    • kfserving/pkg/utils/utils.go
    • Line 31: warning: exported function Filter should have comment or be unexported (golint)
    • Line 41: warning: exported function Union should have comment or be unexported (golint)
    • Line 51: warning: exported function Includes should have comment or be unexported (golint)
    • Line 60: warning: exported function IncludesArg should have comment or be unexported (golint)
    • Line 69: warning: exported function AppendVolumeIfNotExists should have comment or be unexported (golint)
    • Line 78: warning: exported function IsGPUEnabled should have comment or be unexported (golint)
    • Line 93: warning: comment on exported function ContainsString should be of the form "ContainsString ..." (golint)
    • Line 103: warning: exported function RemoveString should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/explainer_alibi.go
    • Line 26: warning: exported method AlibiExplainerSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 30: warning: exported method AlibiExplainerSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 35: warning: exported method AlibiExplainerSpec.CreateExplainerContainer should have comment or be unexported (golint)
    • Line 52: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 69: warning: exported method AlibiExplainerSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 76: warning: exported method AlibiExplainerSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/controller/v1alpha2/inferenceservice/reconcilers/knative/service_reconciler.go
    • Line 42: warning: exported type ServiceReconciler should have comment or be unexported (golint)
    • Line 48: warning: exported function NewServiceReconciler should have comment or be unexported (golint)
    • Line 56: warning: exported method ServiceReconciler.Reconcile should have comment or be unexported (golint)
    • Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kfserving/pkg/apis/serving/v1alpha2/configmap.go
    • Line 37: warning: comment on exported type ExplainerConfig should be of the form "ExplainerConfig ..." (with optional leading article) (golint)
    • Line 44: warning: comment on exported type ExplainersConfig should be of the form "ExplainersConfig ..." (with optional leading article) (golint)
    • Line 50: warning: comment on exported type PredictorProtocols should be of the form "PredictorProtocols ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type PredictorConfig should be of the form "PredictorConfig ..." (with optional leading article) (golint)
    • Line 66: warning: comment on exported type PredictorsConfig should be of the form "PredictorsConfig ..." (with optional leading article) (golint)
    • Line 78: warning: comment on exported type TransformerConfig should be of the form "TransformerConfig ..." (with optional leading article) (golint)
    • Line 85: warning: comment on exported type TransformersConfig should be of the form "TransformersConfig ..." (with optional leading article) (golint)
    • Line 90: warning: comment on exported type InferenceServicesConfig should be of the form "InferenceServicesConfig ..." (with optional leading article) (golint)
    • Line 97: warning: exported function GetInferenceServicesConfig should have comment or be unexported (golint)
    • Line 112: warning: exported function NewInferenceServicesConfig should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_scikit.go
    • Line 24: warning: exported var InvalidSKLearnRuntimeVersionError should have comment or be unexported (golint)
    • Line 29: warning: exported method SKLearnSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 33: warning: exported method SKLearnSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 38: warning: exported method SKLearnSpec.GetContainer should have comment or be unexported (golint)
    • Line 55: warning: exported method SKLearnSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 63: warning: exported method SKLearnSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/webhook/admission/pod/batcher_injector.go
    • Line 29: warning: exported const BatcherContainerName should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported type BatcherConfig should have comment or be unexported (golint)
    • Line 45: warning: exported type BatcherInjector should have comment or be unexported (golint)
    • Line 75: warning: exported method BatcherInjector.InjectBatcher should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/explainer_alibi.go
    • Line 70: warning: exported method AlibiExplainerSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 74: warning: exported method AlibiExplainerSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 79: warning: exported method AlibiExplainerSpec.GetContainer should have comment or be unexported (golint)
    • Line 102: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 118: warning: exported method AlibiExplainerSpec.Default should have comment or be unexported (golint)
    • Line 133: warning: exported method AlibiExplainerSpec.GetProtocol should have comment or be unexported (golint)
    • Line 137: warning: exported method AlibiExplainerSpec.IsMMS should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_onnxruntime.go
    • Line 31: warning: exported var ONNXServingRestPort should have comment or be unexported (golint)
    • Line 70: warning: comment on exported method ONNXRuntimeSpec.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 94: warning: exported method ONNXRuntimeSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 98: warning: exported method ONNXRuntimeSpec.GetProtocol should have comment or be unexported (golint)
    • Line 102: warning: exported method ONNXRuntimeSpec.IsMMS should have comment or be unexported (golint)
    • Line 106: warning: exported method ONNXRuntimeSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
    • Line 50: warning: exported type IngressReconciler should have comment or be unexported (golint)
    • Line 56: warning: exported function NewIngressReconciler should have comment or be unexported (golint)
    • Line 313: warning: exported method IngressReconciler.Reconcile should have comment or be unexported (golint)
    • Line 313: warning: receiver name ir should be consistent with previous receiver name r for IngressReconciler (golint)
    • Line 380: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kfserving/pkg/agent/puller.go
    • Line 32: warning: exported type OpType should have comment or be unexported (golint)
    • Line 35: warning: exported const Add should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported type Puller should have comment or be unexported (golint)
    • Line 48: warning: exported type ModelOp should have comment or be unexported (golint)
    • Line 55: warning: exported type WaitGroupWrapper should have comment or be unexported (golint)
    • Line 59: warning: exported function StartPullerAndProcessModels should have comment or be unexported (golint)
    • Line 89: warning: exported type ModelChannel should have comment or be unexported (golint)
    • kfserving/tools/tf2openapi/types/tfsignaturedef.go
    • Line 16: warning: exported type TFSignatureDef should have comment or be unexported (golint)
    • Line 23: warning: exported type TFMethod should have comment or be unexported (golint)
    • Line 26: warning: exported const Predict should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported function NewTFSignatureDef should have comment or be unexported (golint)
    • Line 71: warning: exported function NewTFMethod should have comment or be unexported (golint)
    • Line 83: warning: exported method TFSignatureDef.Schema should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_triton.go
    • Line 23: warning: comment on exported var TritonISGRPCPort should be of the form "TritonISGRPCPort ..." (golint)
    • Line 25: warning: exported var TritonISRestPort should have comment or be unexported (golint)
    • Line 28: warning: exported method TritonSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 32: warning: exported method TritonSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 37: warning: exported method TritonSpec.GetContainer should have comment or be unexported (golint)
    • Line 54: warning: exported method TritonSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 61: warning: exported method TritonSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_sklearn.go
    • Line 175: warning: exported method SKLearnSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 179: warning: exported method SKLearnSpec.GetProtocol should have comment or be unexported (golint)
    • Line 182: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 187: warning: exported method SKLearnSpec.IsMMS should have comment or be unexported (golint)
    • Line 192: warning: exported method SKLearnSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kfserving/pkg/controller/v1alpha2/inferenceservice/resources/istio/virtualservice.go
    • Line 39: warning: exported const IngressConfigKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported var RetryTimeout should have comment or be unexported (golint)
    • Line 66: warning: exported type IngressConfig should have comment or be unexported (golint)
    • Line 71: warning: exported type VirtualServiceBuilder should have comment or be unexported (golint)
    • Line 75: warning: exported function NewVirtualServiceBuilder should have comment or be unexported (golint)
    • Line 154: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 161: warning: exported method VirtualServiceBuilder.CreateVirtualService should have comment or be unexported (golint)
    • Line 174: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 196: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_pmml.go
    • Line 72: warning: exported method PMMLSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 76: warning: exported method PMMLSpec.GetProtocol should have comment or be unexported (golint)
    • Line 80: warning: exported method PMMLSpec.IsMMS should have comment or be unexported (golint)
    • Line 84: warning: exported method PMMLSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor.go
    • Line 109: warning: comment on exported method PredictorSpec.GetPredictorImplementations should be of the form "GetPredictorImplementations ..." (golint)
    • Line 128: warning: exported method PredictorSpec.GetPredictorImplementation should have comment or be unexported (golint)
    • Line 136: warning: exported function NonNilPredictors should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_lightgbm.go
    • Line 81: warning: exported method LightGBMSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 85: warning: exported method LightGBMSpec.GetProtocol should have comment or be unexported (golint)
    • Line 89: warning: exported method LightGBMSpec.IsMMS should have comment or be unexported (golint)
    • Line 93: warning: exported method LightGBMSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/credentials/gcs/gcs_secret.go
    • Line 24: warning: exported const GCSCredentialFileName should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported type GCSConfig should have comment or be unexported (golint)
    • Line 34: warning: exported function BuildSecretVolume should have comment or be unexported (golint)
    • kfserving/pkg/agent/storage/https.go
    • Line 36: warning: exported const HEADER_SUFFIX should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported type HTTPSProvider should have comment or be unexported (golint)
    • Line 43: warning: exported method HTTPSProvider.DownloadModel should have comment or be unexported (golint)
    • Line 61: warning: exported type HTTPSDownloader should have comment or be unexported (golint)
    • Line 68: warning: exported method HTTPSDownloader.Download should have comment or be unexported (golint)
    • kfserving/pkg/constants/constants.go
    • Line 121: warning: exported type InferenceServiceComponent should have comment or be unexported (golint)
    • Line 123: warning: exported type InferenceServiceVerb should have comment or be unexported (golint)
    • Line 125: warning: exported type InferenceServiceProtocol should have comment or be unexported (golint)
    • Line 135: warning: exported var LocalGatewayHost should have comment or be unexported (golint)
    • Line 211: warning: exported var ServiceAnnotationDisallowedList should have comment or be unexported (golint)
    • Line 242: warning: exported function InferenceServiceURL should have comment or be unexported (golint)
    • Line 246: warning: exported function InferenceServiceHostName should have comment or be unexported (golint)
    • Line 250: warning: exported function DefaultPredictorServiceName should have comment or be unexported (golint)
    • Line 254: warning: exported function CanaryPredictorServiceName should have comment or be unexported (golint)
    • Line 258: warning: exported function DefaultExplainerServiceName should have comment or be unexported (golint)
    • Line 262: warning: exported function CanaryExplainerServiceName should have comment or be unexported (golint)
    • Line 266: warning: exported function DefaultTransformerServiceName should have comment or be unexported (golint)
    • Line 270: warning: exported function CanaryTransformerServiceName should have comment or be unexported (golint)
    • Line 274: warning: exported function DefaultServiceName should have comment or be unexported (golint)
    • Line 278: warning: exported function CanaryServiceName should have comment or be unexported (golint)
    • Line 282: warning: exported function ModelConfigName should have comment or be unexported (golint)
    • Line 286: warning: exported function InferenceServicePrefix should have comment or be unexported (golint)
    • Line 290: warning: exported function PredictPath should have comment or be unexported (golint)
    • Line 293: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 298: warning: exported function ExplainPath should have comment or be unexported (golint)
    • Line 302: warning: exported function PredictPrefix should have comment or be unexported (golint)
    • Line 306: warning: exported function ExplainPrefix should have comment or be unexported (golint)
    • Line 310: warning: exported function VirtualServiceHostname should have comment or be unexported (golint)
    • Line 315: warning: exported function PredictorURL should have comment or be unexported (golint)
    • Line 323: warning: exported function TransformerURL should have comment or be unexported (golint)
    • Line 334: warning: comment on exported function HostRegExp should be of the form "HostRegExp ..." (golint)
    • kfserving/pkg/controller/v1alpha2/inferenceservice/resources/knative/service.go
    • Line 35: warning: exported type ServiceBuilder should have comment or be unexported (golint)
    • Line 40: warning: exported function NewServiceBuilder should have comment or be unexported (golint)
    • Line 53: warning: exported method ServiceBuilder.CreateInferenceServiceComponent should have comment or be unexported (golint)
    • Line 147: warning: exported method ServiceBuilder.CreatePredictorService should have comment or be unexported (golint)
    • Line 227: warning: exported method ServiceBuilder.CreateTransformerService should have comment or be unexported (golint)
    • Line 299: warning: exported method ServiceBuilder.CreateExplainerService should have comment or be unexported (golint)
    • kfserving/pkg/modelconfig/configmap.go
    • Line 34: warning: exported type ModelConfig should have comment or be unexported (golint)
    • Line 39: warning: exported type ModelConfigs should have comment or be unexported (golint)
    • Line 41: warning: exported type ConfigsDelta should have comment or be unexported (golint)
    • Line 46: warning: exported function NewConfigsDelta should have comment or be unexported (golint)
    • Line 53: warning: comment on exported method ConfigsDelta.Process should be of the form "Process ..." (golint)
    • Line 113: warning: exported function CreateEmptyModelConfig should have comment or be unexported (golint)
    • kfserving/pkg/agent/storage/s3.go
    • Line 32: warning: exported type S3Provider should have comment or be unexported (golint)
    • Line 41: warning: exported type S3ObjectDownloader should have comment or be unexported (golint)
    • Line 50: warning: exported method S3Provider.DownloadModel should have comment or be unexported (golint)
    • Line 76: warning: exported method S3ObjectDownloader.GetAllObjects should have comment or be unexported (golint)
    • Line 132: warning: exported method S3ObjectDownloader.Download should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_pmml.go
    • Line 25: warning: exported method PMMLSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 29: warning: exported method PMMLSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 34: warning: exported method PMMLSpec.GetContainer should have comment or be unexported (golint)
    • Line 51: warning: exported method PMMLSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 59: warning: exported method PMMLSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_lightgbm.go
    • Line 24: warning: exported method LightGBMSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 28: warning: exported method LightGBMSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 33: warning: exported method LightGBMSpec.GetContainer should have comment or be unexported (golint)
    • Line 51: warning: exported method LightGBMSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 62: warning: exported method LightGBMSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/constants/mlserver.go
    • Line 20: warning: exported const MLServerHTTPPortEnv should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: exported var MLServerISGRPCPort should have comment or be unexported (golint)
    • kfserving/pkg/agent/storage/utils.go
    • Line 39: warning: exported function FileExists should have comment or be unexported (golint)
    • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 51: warning: exported function AsSha256 should have comment or be unexported (golint)
    • Line 58: warning: exported function Create should have comment or be unexported (golint)
    • Line 65: warning: exported function RemoveDir should have comment or be unexported (golint)
    • Line 88: warning: exported function GetProvider should have comment or be unexported (golint)
    • kfserving/pkg/agent/syncer.go
    • Line 31: warning: exported type FileError should have comment or be unexported (golint)
    • Line 33: warning: error var NoSuccessFile should have name of the form ErrFoo (golint)
    • Line 33: warning: exported var NoSuccessFile should have comment or be unexported (golint)
    • Line 35: warning: exported function SyncModelDir should have comment or be unexported (golint)
    • kfserving/tools/tf2openapi/types/tfdtype.go
    • Line 9: warning: exported type TFDType should have comment or be unexported (golint)
    • Line 12: warning: comment on exported const DtBool should be of the form "DtBool ..." (golint)
    • Line 16: warning: exported const DtB64String should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported function NewTFDType should have comment or be unexported (golint)
    • Line 61: warning: exported method TFDType.Schema should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/predictor.go
    • Line 24: warning: comment on exported type Predictor should be of the form "Predictor ..." (with optional leading article) (golint)
    • Line 38: warning: comment on exported method PredictorSpec.GetStorageUri should be of the form "GetStorageUri ..." (golint)
    • Line 47: warning: exported method PredictorSpec.GetContainer should have comment or be unexported (golint)
    • Line 55: warning: exported method PredictorSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 62: warning: exported method PredictorSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/testing/be_sematic_equal_matcher.go
    • Line 29: warning: exported function BeSematicEqual should have comment or be unexported (golint)
    • Line 35: warning: exported type BeSematicEqualMatcher should have comment or be unexported (golint)
    • Line 39: warning: exported method BeSematicEqualMatcher.Match should have comment or be unexported (golint)
    • Line 53: warning: exported method BeSematicEqualMatcher.FailureMessage should have comment or be unexported (golint)
    • Line 57: warning: exported method BeSematicEqualMatcher.NegatedFailureMessage should have comment or be unexported (golint)
    • kfserving/tools/tf2openapi/types/tftensor.go
    • Line 14: warning: exported const B64KeySuffix should have comment or be unexported (golint)
    • Line 16: warning: exported type TFTensor should have comment or be unexported (golint)
    • Line 30: warning: exported type TFShape should have comment or be unexported (golint)
    • Line 32: warning: exported function NewTFTensor should have comment or be unexported (golint)
    • Line 62: warning: exported function NewTFShape should have comment or be unexported (golint)
    • Line 70: warning: exported method TFTensor.RowSchema should have comment or be unexported (golint)
    • Line 76: warning: exported method TFTensor.ColSchema should have comment or be unexported (golint)
    • kfserving/pkg/credentials/service_account_credentials.go
    • Line 36: warning: exported const CredentialConfigKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported type CredentialConfig should have comment or be unexported (golint)
    • Line 44: warning: exported type CredentialBuilder should have comment or be unexported (golint)
    • Line 51: warning: exported function NewCredentialBulder should have comment or be unexported (golint)
    • Line 65: warning: exported method CredentialBuilder.CreateSecretVolumeAndEnv should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_tensorflow.go
    • Line 25: warning: exported var TensorflowEntrypointCommand should have comment or be unexported (golint)
    • Line 33: warning: exported method TensorflowSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 37: warning: exported method TensorflowSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 42: warning: exported method TensorflowSpec.GetContainer should have comment or be unexported (golint)
    • Line 73: warning: exported method TensorflowSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 85: warning: exported method TensorflowSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_custom.go
    • Line 26: warning: exported method CustomSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 36: warning: exported method CustomSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 41: warning: exported method CustomSpec.GetContainer should have comment or be unexported (golint)
    • Line 45: warning: exported method CustomSpec.CreateExplainerContainer should have comment or be unexported (golint)
    • Line 49: warning: exported method CustomSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 53: warning: exported method CustomSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_onnx.go
    • Line 28: warning: exported var ONNXServingRestPort should have comment or be unexported (golint)
    • Line 35: warning: exported method ONNXSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 39: warning: exported method ONNXSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 44: warning: exported method ONNXSpec.GetContainer should have comment or be unexported (golint)
    • Line 68: warning: exported method ONNXSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 75: warning: exported method ONNXSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_pytorch.go
    • Line 26: warning: exported var DefaultPyTorchModelClassName should have comment or be unexported (golint)
    • Line 34: warning: exported method PyTorchSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 38: warning: exported method PyTorchSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 43: warning: exported method PyTorchSpec.GetContainer should have comment or be unexported (golint)
    • Line 63: warning: exported method PyTorchSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 77: warning: exported method PyTorchSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/agent/storage/provider.go
    • Line 19: warning: exported type Provider should have comment or be unexported (golint)
    • Line 23: warning: exported type Protocol should have comment or be unexported (golint)
    • Line 26: warning: exported const S3 should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: comment on exported const HTTPS should be of the form "HTTPS ..." (golint)
    • Line 34: warning: exported var SupportedProtocols should have comment or be unexported (golint)
    • Line 36: warning: exported function GetAllProtocol should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/framework_xgboost.go
    • Line 23: warning: exported method XGBoostSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 27: warning: exported method XGBoostSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 32: warning: exported method XGBoostSpec.GetContainer should have comment or be unexported (golint)
    • Line 50: warning: exported method XGBoostSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 61: warning: exported method XGBoostSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/logger/types.go
    • Line 23: warning: exported type LogRequestType should have comment or be unexported (golint)
    • Line 26: warning: exported const InferenceRequest should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported type LogRequest should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/configmap.go
    • Line 38: warning: exported const IngressConfigKeyName should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: comment on exported type ExplainerConfig should be of the form "ExplainerConfig ..." (with optional leading article) (golint)
    • Line 49: warning: comment on exported type ExplainersConfig should be of the form "ExplainersConfig ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type PredictorConfig should be of the form "PredictorConfig ..." (with optional leading article) (golint)
    • Line 72: warning: comment on exported type PredictorProtocols should be of the form "PredictorProtocols ..." (with optional leading article) (golint)
    • Line 78: warning: comment on exported type PredictorsConfig should be of the form "PredictorsConfig ..." (with optional leading article) (golint)
    • Line 90: warning: comment on exported type TransformerConfig should be of the form "TransformerConfig ..." (with optional leading article) (golint)
    • Line 98: warning: comment on exported type TransformersConfig should be of the form "TransformersConfig ..." (with optional leading article) (golint)
    • Line 103: warning: comment on exported type InferenceServicesConfig should be of the form "InferenceServicesConfig ..." (with optional leading article) (golint)
    • Line 113: warning: comment on exported type IngressConfig should be of the form "IngressConfig ..." (with optional leading article) (golint)
    • Line 121: warning: exported function NewInferenceServicesConfig should have comment or be unexported (golint)
    • Line 140: warning: exported function NewIngressConfig should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/explainer_aix360.go
    • Line 27: warning: exported method AIXExplainerSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 31: warning: exported method AIXExplainerSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 36: warning: exported method AIXExplainerSpec.CreateExplainerContainer should have comment or be unexported (golint)
    • Line 53: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 70: warning: exported method AIXExplainerSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 77: warning: exported method AIXExplainerSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/explainer_custom.go
    • Line 35: warning: exported function NewCustomExplainer should have comment or be unexported (golint)
    • Line 47: warning: receiver name c should be consistent with previous receiver name s for CustomExplainer (golint)
    • Line 55: warning: exported method CustomExplainer.GetStorageUri should have comment or be unexported (golint)
    • Line 55: warning: receiver name c should be consistent with previous receiver name s for CustomExplainer (golint)
    • Line 66: warning: receiver name c should be consistent with previous receiver name s for CustomExplainer (golint)
    • Line 92: warning: exported method CustomExplainer.GetProtocol should have comment or be unexported (golint)
    • Line 92: warning: receiver name c should be consistent with previous receiver name s for CustomExplainer (golint)
    • Line 96: warning: exported method CustomExplainer.IsMMS should have comment or be unexported (golint)
    • Line 96: warning: receiver name c should be consistent with previous receiver name s for CustomExplainer (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_tfserving.go
    • Line 32: warning: exported var TensorflowEntrypointCommand should have comment or be unexported (golint)
    • Line 84: warning: exported method TFServingSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 88: warning: comment on exported method TFServingSpec.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 112: warning: exported method TFServingSpec.GetProtocol should have comment or be unexported (golint)
    • Line 116: warning: exported method TFServingSpec.IsMMS should have comment or be unexported (golint)
    • Line 120: warning: exported method TFServingSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/agent/mocks/s3mock.go
    • Line 28: warning: exported type MockS3Client should have comment or be unexported (golint)
    • Line 32: warning: exported method MockS3Client.ListObjects should have comment or be unexported (golint)
    • Line 42: warning: exported type MockS3Downloader should have comment or be unexported (golint)
    • Line 45: warning: exported method MockS3Downloader.DownloadWithIterator should have comment or be unexported (golint)
    • Line 49: warning: exported type MockS3FailDownloader should have comment or be unexported (golint)
    • Line 53: warning: exported method MockS3FailDownloader.DownloadWithIterator should have comment or be unexported (golint)
    • kfserving/pkg/agent/watcher.go
    • Line 32: warning: exported type Watcher should have comment or be unexported (golint)
    • Line 39: warning: exported function NewWatcher should have comment or be unexported (golint)
    • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 72: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 79: warning: exported method Watcher.Start should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1alpha2/explainer.go
    • Line 23: warning: comment on exported type Explainer should be of the form "Explainer ..." (with optional leading article) (golint)
    • Line 37: warning: comment on exported method ExplainerSpec.GetStorageUri should be of the form "GetStorageUri ..." (golint)
    • Line 46: warning: exported method ExplainerSpec.CreateExplainerContainer should have comment or be unexported (golint)
    • Line 54: warning: exported method ExplainerSpec.ApplyDefaults should have comment or be unexported (golint)
    • Line 61: warning: exported method ExplainerSpec.Validate should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/explainer_art.go
    • Line 31: warning: exported type ARTExplainerType should have comment or be unexported (golint)
    • Line 34: warning: exported const ARTSquareAttackExplainer should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: comment on exported type ARTExplainerSpec should be of the form "ARTExplainerSpec ..." (with optional leading article) (golint)
    • Line 47: warning: exported method ARTExplainerSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 54: warning: exported method ARTExplainerSpec.GetResourceRequirements should have comment or be unexported (golint)
    • Line 59: warning: exported method ARTExplainerSpec.GetContainer should have comment or be unexported (golint)
    • Line 82: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 99: warning: exported method ARTExplainerSpec.Default should have comment or be unexported (golint)
    • Line 114: warning: exported method ARTExplainerSpec.GetProtocol should have comment or be unexported (golint)
    • Line 118: warning: exported method ARTExplainerSpec.IsMMS should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_custom.go
    • Line 38: warning: exported function NewCustomPredictor should have comment or be unexported (golint)
    • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 72: warning: exported method CustomPredictor.GetStorageUri should have comment or be unexported (golint)
    • Line 82: warning: comment on exported method CustomPredictor.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 87: warning: exported method CustomPredictor.GetProtocol should have comment or be unexported (golint)
    • Line 96: warning: exported method CustomPredictor.IsMMS should have comment or be unexported (golint)
    • Line 107: warning: exported method CustomPredictor.IsFrameworkSupported should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/transformer_custom.go
    • Line 36: warning: exported function NewCustomTransformer should have comment or be unexported (golint)
    • Line 56: warning: exported method CustomTransformer.GetStorageUri should have comment or be unexported (golint)
    • Line 66: warning: comment on exported method CustomTransformer.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 95: warning: exported method CustomTransformer.GetProtocol should have comment or be unexported (golint)
    • Line 99: warning: exported method CustomTransformer.IsMMS should have comment or be unexported (golint)
    • kfserving/pkg/controller/v1alpha2/inferenceservice/controller.go
    • Line 69: warning: comment on exported type InferenceServiceReconciler should be of the form "InferenceServiceReconciler ..." (with optional leading article) (golint)
    • Line 77: warning: exported method InferenceServiceReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 126: warning: exported function InferenceServiceReadiness should have comment or be unexported (golint)
    • kfserving/tools/tf2openapi/generator/generate.go
    • Line 11: warning: exported const DefaultSigDefKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: exported type Generator should have comment or be unexported (golint)
    • Line 30: warning: exported type Builder should have comment or be unexported (golint)
    • Line 34: warning: exported method Builder.Build should have comment or be unexported (golint)
    • Line 44: warning: exported method Builder.SetName should have comment or be unexported (golint)
    • Line 48: warning: exported method Builder.SetVersion should have comment or be unexported (golint)
    • Line 52: warning: exported method Builder.SetMetaGraphTags should have comment or be unexported (golint)
    • Line 56: warning: exported method Builder.SetSigDefKey should have comment or be unexported (golint)
    • Line 60: warning: exported method Generator.GenerateOpenAPI should have comment or be unexported (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_torchserve.go
    • Line 32: warning: exported const DefaultPyTorchModelClassName should have comment (or a comment on this block) or be unexported (golint)
    • Line 114: warning: comment on exported method TorchServeSpec.GetContainer should be of the form "GetContainer ..." (golint)
    • Line 119: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 126: warning: exported method TorchServeSpec.GetContainerV1 should have comment or be unexported (golint)
    • Line 148: warning: exported method TorchServeSpec.GetContainerV2 should have comment or be unexported (golint)
    • Line 163: warning: exported method TorchServeSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 167: warning: exported method TorchServeSpec.GetProtocol should have comment or be unexported (golint)
    • Line 171: warning: exported method TorchServeSpec.IsMMS should have comment or be unexported (golint)
    • Line 176: warning: exported method TorchServeSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • Line 186: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kfserving/pkg/apis/serving/v1beta1/predictor_xgboost.go
    • Line 180: warning: exported method XGBoostSpec.GetStorageUri should have comment or be unexported (golint)
    • Line 184: warning: exported method XGBoostSpec.GetProtocol should have comment or be unexported (golint)
    • Line 187: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 192: warning: exported method XGBoostSpec.IsMMS should have comment or be unexported (golint)
    • Line 197: warning: exported method XGBoostSpec.IsFrameworkSupported should have comment or be unexported (golint)
    • Line 207: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kfserving/pkg/batcher/handler.go
    • Line 33: warning: exported const SleepTime should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported type Request should have comment or be unexported (golint)
    • Line 42: warning: exported type Input should have comment or be unexported (golint)
    • Line 49: warning: exported type InputInfo should have comment or be unexported (golint)
    • Line 54: warning: exported type Response should have comment or be unexported (golint)
    • Line 60: warning: exported type ResponseError should have comment or be unexported (golint)
    • Line 64: warning: exported type PredictionResponse should have comment or be unexported (golint)
    • Line 68: warning: exported type BatcherInfo should have comment or be unexported (golint)
    • Line 80: warning: exported function GetNowTime should have comment or be unexported (golint)
    • Line 84: warning: exported function GenerateUUID should have comment or be unexported (golint)
    • Line 88: warning: exported method BatcherInfo.InitializeInfo should have comment or be unexported (golint)
    • Line 188: warning: exported method BatchHandler.Consume should have comment or be unexported (golint)
    • Line 199: warning: exported type BatchHandler should have comment or be unexported (golint)
    • Line 208: warning: exported function New should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

misspell98%

Misspell Finds commonly misspelled English words