gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• external-dns/source/gloo_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• external-dns/source/service_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• external-dns/provider/cloudflare/cloudflare_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• external-dns/provider/ultradns/ultradns_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• external-dns/main.go
  • Line 72: warning: cyclomatic complexity 55 of function main() is high (> 15) (gocyclo)

• external-dns/pkg/apis/externaldns/validation/validation.go
  • Line 27: warning: cyclomatic complexity 35 of function ValidateConfig() is high (> 15) (gocyclo)

• external-dns/provider/alibabacloud/alibaba_cloud.go
  • Line 1015: warning: cyclomatic complexity 18 of function (*AlibabaCloudProvider).updatePrivateZoneRecords() is high (> 15) (gocyclo)

• external-dns/provider/coredns/coredns.go
  • Line 335: warning: cyclomatic complexity 27 of function (coreDNSProvider).ApplyChanges() is high (> 15) (gocyclo)

• external-dns/provider/aws/aws_test.go
  • Line 157: warning: cyclomatic complexity 16 of function (*Route53APIStub).ChangeResourceRecordSetsWithContext() is high (> 15) (gocyclo)

• external-dns/source/ingressroute.go
  • Line 133: warning: cyclomatic complexity 18 of function (*ingressRouteSource).Endpoints() is high (> 15) (gocyclo)

• external-dns/provider/infoblox/infoblox_test.go
  • Line 100: warning: cyclomatic complexity 30 of function (*mockIBConnector).GetObject() is high (> 15) (gocyclo)

• external-dns/provider/infoblox/infoblox.go
  • Line 141: warning: cyclomatic complexity 18 of function (*InfobloxProvider).Records() is high (> 15) (gocyclo)

• external-dns/provider/alibabacloud/alibaba_cloud_test.go
  • Line 392: warning: cyclomatic complexity 17 of function TestAlibabaCloudProvider_splitDNSName() is high (> 15) (gocyclo)

• external-dns/provider/linode/linode.go
  • Line 261: warning: cyclomatic complexity 25 of function (*LinodeProvider).ApplyChanges() is high (> 15) (gocyclo)

• external-dns/source/virtualservice.go
  • Line 410: warning: cyclomatic complexity 21 of function virtualServiceBindsToGateway() is high (> 15) (gocyclo)

• external-dns/provider/exoscale/exoscale.go
  • Line 88: warning: cyclomatic complexity 22 of function (*ExoscaleProvider).ApplyChanges() is high (> 15) (gocyclo)

• external-dns/provider/ultradns/ultradns.go
  • Line 277: warning: cyclomatic complexity 28 of function (*UltraDNSProvider).submitChanges() is high (> 15) (gocyclo)
  • Line 71: warning: cyclomatic complexity 16 of function NewUltraDNSProvider() is high (> 15) (gocyclo)

• external-dns/provider/transip/transip.go
  • Line 88: warning: cyclomatic complexity 23 of function (*TransIPProvider).ApplyChanges() is high (> 15) (gocyclo)

• external-dns/provider/rdns/rdns.go
  • Line 163: warning: cyclomatic complexity 20 of function (RDNSProvider).ApplyChanges() is high (> 15) (gocyclo)
  • Line 266: warning: cyclomatic complexity 17 of function newEtcdv3Client() is high (> 15) (gocyclo)

• external-dns/provider/hetzner/hetzner.go
  • Line 105: warning: cyclomatic complexity 21 of function (*HetznerProvider).submitChanges() is high (> 15) (gocyclo)

• external-dns/provider/pdns/pdns.go
  • Line 274: warning: cyclomatic complexity 18 of function (*PDNSProvider).ConvertEndpointsToZones() is high (> 15) (gocyclo)

• external-dns/provider/aws/aws.go
  • Line 309: warning: cyclomatic complexity 23 of function (*AWSProvider).records() is high (> 15) (gocyclo)
  • Line 607: warning: cyclomatic complexity 17 of function (*AWSProvider).newChange() is high (> 15) (gocyclo)

• external-dns/provider/rcode0/rcode0.go
  • Line 218: warning: cyclomatic complexity 16 of function (*RcodeZeroProvider).submitChanges() is high (> 15) (gocyclo)

• external-dns/source/store.go
  • Line 171: warning: cyclomatic complexity 37 of function BuildWithConfig() is high (> 15) (gocyclo)

• external-dns/source/service.go
  • Line 254: warning: cyclomatic complexity 23 of function (*serviceSource).extractHeadlessEndpoints() is high (> 15) (gocyclo)
  • Line 160: warning: cyclomatic complexity 21 of function (*serviceSource).Endpoints() is high (> 15) (gocyclo)
  • Line 558: warning: cyclomatic complexity 18 of function (*serviceSource).extractNodePortTargets() is high (> 15) (gocyclo)
  • Line 443: warning: cyclomatic complexity 16 of function (*serviceSource).generateEndpoints() is high (> 15) (gocyclo)

• external-dns/source/httpproxy.go
  • Line 122: warning: cyclomatic complexity 18 of function (*httpProxySource).Endpoints() is high (> 15) (gocyclo)

• external-dns/source/crd.go
  • Line 121: warning: cyclomatic complexity 16 of function (*crdSource).Endpoints() is high (> 15) (gocyclo)

golint91%

Golint is a linter for Go source code.

• external-dns/controller/controller.go
  • Line 177: warning: exported method Controller.ShouldRunOnce should have comment or be unexported (golint)

• external-dns/endpoint/endpoint.go
  • Line 222: warning: exported type DNSEndpoint should have comment or be unexported (golint)
  • Line 230: warning: comment on exported type DNSEndpointList should be of the form "DNSEndpointList ..." (with optional leading article) (golint)

• external-dns/provider/akamai/akamai_test.go
  • Line 144: warning: don't use underscores in Go names; method parameter record_type should be recordType (golint)

• external-dns/provider/cloudflare/cloudflare.go
  • Line 261: warning: exported method CloudFlareProvider.PropertyValuesEqual should have comment or be unexported (golint)

• external-dns/provider/bluecat/bluecat.go
  • Line 63: warning: exported type GatewayClient should have comment or be unexported (golint)

• external-dns/registry/aws_sd_registry.go
  • Line 91: warning: exported method AWSSDRegistry.PropertyValuesEqual should have comment or be unexported (golint)

• external-dns/provider/ultradns/ultradns.go
  • Line 166: warning: exported method UltraDNSProvider.Records should have comment or be unexported (golint)
  • Line 404: warning: exported method UltraDNSProvider.ApplyChanges should have comment or be unexported (golint)

• external-dns/provider/ultradns/ultradns_test.go
  • Line 407: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

• external-dns/provider/provider.go
  • Line 36: warning: exported type BaseProvider should have comment or be unexported (golint)
  • Line 39: warning: exported method BaseProvider.AdjustEndpoints should have comment or be unexported (golint)
  • Line 43: warning: exported method BaseProvider.PropertyValuesEqual should have comment or be unexported (golint)

• external-dns/provider/zonefinder.go
  • Line 21: warning: exported type ZoneIDName should have comment or be unexported (golint)
  • Line 23: warning: exported method ZoneIDName.Add should have comment or be unexported (golint)
  • Line 27: warning: exported method ZoneIDName.FindZone should have comment or be unexported (golint)

• external-dns/provider/akamai/akamai.go
  • Line 42: warning: comment on exported type AkamaiDNSService should be of the form "AkamaiDNSService ..." (with optional leading article) (golint)
  • Line 52: warning: exported type AkamaiConfig should have comment or be unexported (golint)
  • Line 163: warning: exported method AkamaiProvider.ListZones should have comment or be unexported (golint)
  • Line 167: warning: exported method AkamaiProvider.GetRecordsets should have comment or be unexported (golint)
  • Line 171: warning: exported method AkamaiProvider.CreateRecordsets should have comment or be unexported (golint)
  • Line 175: warning: exported method AkamaiProvider.GetRecord should have comment or be unexported (golint)
  • Line 179: warning: exported method AkamaiProvider.DeleteRecord should have comment or be unexported (golint)
  • Line 183: warning: exported method AkamaiProvider.UpdateRecord should have comment or be unexported (golint)

• external-dns/provider/hetzner/hetzner.go
  • Line 37: warning: exported type HetznerChanges should have comment or be unexported (golint)
  • Line 44: warning: exported type HetznerProvider should have comment or be unexported (golint)
  • Line 51: warning: exported function NewHetznerProvider should have comment or be unexported (golint)
  • Line 67: warning: exported method HetznerProvider.Records should have comment or be unexported (golint)
  • Line 95: warning: exported method HetznerProvider.ApplyChanges should have comment or be unexported (golint)

• external-dns/provider/aws/aws.go
  • Line 220: warning: exported method AWSProvider.PropertyValuesEqual should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• external-dns/provider/ultradns/ultradns_test.go
  • Line 154: warning: ineffectual assignment to err (ineffassign)
  • Line 243: warning: ineffectual assignment to err (ineffassign)
  • Line 322: warning: ineffectual assignment to err (ineffassign)
  • Line 496: warning: ineffectual assignment to err (ineffassign)
  • Line 699: warning: ineffectual assignment to zones (ineffassign)

misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)