gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• service-catalog/test/upgrade/examiner/internal/tests/clusterbroker/tester.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• service-catalog/test/e2e/framework/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• service-catalog/test/upgrade/examiner/internal/tests/broker/tester.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• service-catalog/test/upgrade/examiner/internal/tests/clusterbroker/creator.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• service-catalog/pkg/apis/servicecatalog/v1beta1/plan_reference.go
  • Line 225: warning: cyclomatic complexity 16 of function (PlanReference).Format() is high (> 15) (gocyclo)

• service-catalog/pkg/apis/servicecatalog/validation/instance_test.go
  • Line 1248: warning: cyclomatic complexity 17 of function TestValidateServiceInstanceStatusUpdate() is high (> 15) (gocyclo)

• service-catalog/pkg/svcat/service-catalog/broker.go
  • Line 117: warning: cyclomatic complexity 17 of function (*SDK).RetrieveBrokerByID() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller.go
  • Line 1144: warning: cyclomatic complexity 20 of function convertClusterServicePlans() is high (> 15) (gocyclo)
  • Line 874: warning: cyclomatic complexity 16 of function GenerateEscapedName() is high (> 15) (gocyclo)
  • Line 1090: warning: cyclomatic complexity 16 of function convertCommonServicePlan() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_test.go
  • Line 2522: warning: cyclomatic complexity 30 of function assertActionFor() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_binding_ns_test.go
  • Line 403: warning: cyclomatic complexity 16 of function TestPollServiceBindingNamespacedRefs() is high (> 15) (gocyclo)

• service-catalog/pkg/apis/servicecatalog/validation/broker.go
  • Line 164: warning: cyclomatic complexity 26 of function validateCommonServiceBrokerSpec() is high (> 15) (gocyclo)

• service-catalog/pkg/migration/migration.go
  • Line 185: warning: cyclomatic complexity 29 of function (*Service).Restore() is high (> 15) (gocyclo)
  • Line 362: warning: cyclomatic complexity 26 of function (*Service).LoadResources() is high (> 15) (gocyclo)
  • Line 545: warning: cyclomatic complexity 25 of function (*Service).BackupResources() is high (> 15) (gocyclo)
  • Line 477: warning: cyclomatic complexity 17 of function (*Service).Cleanup() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_instance.go
  • Line 1015: warning: cyclomatic complexity 35 of function (*controller).pollServiceInstance() is high (> 15) (gocyclo)
  • Line 673: warning: cyclomatic complexity 33 of function (*controller).reconcileServiceInstanceUpdate() is high (> 15) (gocyclo)
  • Line 508: warning: cyclomatic complexity 29 of function (*controller).reconcileServiceInstanceAdd() is high (> 15) (gocyclo)
  • Line 855: warning: cyclomatic complexity 27 of function (*controller).reconcileServiceInstanceDelete() is high (> 15) (gocyclo)
  • Line 2049: warning: cyclomatic complexity 17 of function isServiceInstancePropertiesStateEqual() is high (> 15) (gocyclo)
  • Line 2381: warning: cyclomatic complexity 17 of function (*controller).prepareUpdateInstanceRequest() is high (> 15) (gocyclo)
  • Line 2471: warning: cyclomatic complexity 16 of function (*controller).prepareDeprovisionRequest() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_binding.go
  • Line 918: warning: cyclomatic complexity 31 of function (*controller).pollServiceBinding() is high (> 15) (gocyclo)
  • Line 189: warning: cyclomatic complexity 30 of function (*controller).reconcileServiceBindingAdd() is high (> 15) (gocyclo)
  • Line 369: warning: cyclomatic complexity 28 of function (*controller).reconcileServiceBindingDelete() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_instance_test.go
  • Line 414: warning: cyclomatic complexity 18 of function TestReconcileServiceInstanceWithParameters() is high (> 15) (gocyclo)
  • Line 3822: warning: cyclomatic complexity 16 of function TestUpdateServiceInstanceCondition() is high (> 15) (gocyclo)

• service-catalog/cmd/controller-manager/app/controller_manager.go
  • Line 85: warning: cyclomatic complexity 20 of function Run() is high (> 15) (gocyclo)

• service-catalog/pkg/apis/servicecatalog/validation/instance.go
  • Line 112: warning: cyclomatic complexity 24 of function validateServiceInstanceStatus() is high (> 15) (gocyclo)
  • Line 552: warning: cyclomatic complexity 22 of function validateScopedPlanRef() is high (> 15) (gocyclo)
  • Line 182: warning: cyclomatic complexity 17 of function validateServiceInstancePropertiesState() is high (> 15) (gocyclo)
  • Line 260: warning: cyclomatic complexity 16 of function validateServiceInstanceUpdate() is high (> 15) (gocyclo)

• service-catalog/pkg/apis/servicecatalog/validation/binding.go
  • Line 101: warning: cyclomatic complexity 22 of function validateServiceBindingStatus() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_clusterservicebroker.go
  • Line 159: warning: cyclomatic complexity 42 of function (*controller).reconcileClusterServiceBroker() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_binding_test.go
  • Line 3285: warning: cyclomatic complexity 16 of function TestPollServiceBinding() is high (> 15) (gocyclo)
  • Line 1827: warning: cyclomatic complexity 16 of function TestUpdateServiceBindingCondition() is high (> 15) (gocyclo)

• service-catalog/cmd/migration/migration.go
  • Line 38: warning: cyclomatic complexity 26 of function RunCommand() is high (> 15) (gocyclo)

• service-catalog/pkg/hyperkube/hyperkube.go
  • Line 126: warning: cyclomatic complexity 19 of function (*HyperKube).Run() is high (> 15) (gocyclo)

• service-catalog/pkg/svcat/service-catalog/class.go
  • Line 171: warning: cyclomatic complexity 18 of function (*SDK).RetrieveClassByID() is high (> 15) (gocyclo)

• service-catalog/pkg/controller/controller_servicebroker.go
  • Line 150: warning: cyclomatic complexity 40 of function (*controller).reconcileServiceBroker() is high (> 15) (gocyclo)

golint96%

Golint is a linter for Go source code.

• service-catalog/test/fake/serviceinstancecredentials.go
  • Line 34: warning: exported method ServiceBindings.UpdateStatus should have comment or be unexported (golint)

• service-catalog/test/e2e/framework/test_context.go
  • Line 29: warning: exported const RecommendedConfigPathEnvVar should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type TestContextType should have comment or be unexported (golint)
  • Line 42: warning: exported var TestContext should have comment or be unexported (golint)
  • Line 44: warning: comment on exported function RegisterCommonFlags should be of the form "RegisterCommonFlags ..." (golint)
  • Line 65: warning: exported function RegisterParseFlags should have comment or be unexported (golint)

• service-catalog/test/e2e/framework/util.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 25: warning: should not use dot imports (golint)
  • Line 38: warning: comment on exported const Poll should be of the form "Poll ..." (golint)
  • Line 44: warning: comment on exported const EndpointRegisterTimeout should be of the form "EndpointRegisterTimeout ..." (golint)
  • Line 56: warning: exported function Logf should have comment or be unexported (golint)
  • Line 60: warning: exported function Failf should have comment or be unexported (golint)
  • Line 66: warning: exported function Skipf should have comment or be unexported (golint)
  • Line 72: warning: exported type ClientConfigGetter should have comment or be unexported (golint)
  • Line 74: warning: comment on exported var RunId should be of the form "RunId ..." (golint)
  • Line 77: warning: exported function CreateKubeNamespace should have comment or be unexported (golint)
  • Line 101: warning: exported function DeleteKubeNamespace should have comment or be unexported (golint)
  • Line 105: warning: exported function ExpectNoError should have comment or be unexported (golint)
  • Line 112: warning: comment on exported function WaitForPodRunningInNamespace should be of the form "WaitForPodRunningInNamespace ..." (golint)
  • Line 125: warning: exported function WaitForEndpoint should have comment or be unexported (golint)

• service-catalog/pkg/kubernetes/pkg/client/leaderelectionconfig/config.go
  • Line 29: warning: exported const DefaultLeaseDuration should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function DefaultLeaderElectionConfiguration should have comment or be unexported (golint)

• service-catalog/test/e2e/framework/cleanup.go
  • Line 21: warning: exported type CleanupActionHandle should have comment or be unexported (golint)

• service-catalog/test/fake/clientset.go
  • Line 35: warning: exported method Clientset.Discovery should have comment or be unexported (golint)
  • Line 41: warning: exported method Clientset.ServicecatalogV1beta1 should have comment or be unexported (golint)
  • Line 45: warning: exported method Clientset.Servicecatalog should have comment or be unexported (golint)

• service-catalog/test/fake/servicecatalog.go
  • Line 36: warning: exported method ServicecatalogV1beta1.ClusterServiceBrokers should have comment or be unexported (golint)
  • Line 40: warning: exported method ServicecatalogV1beta1.ClusterServiceClasses should have comment or be unexported (golint)
  • Line 44: warning: exported method ServicecatalogV1beta1.ServiceInstances should have comment or be unexported (golint)
  • Line 49: warning: exported method ServicecatalogV1beta1.ServiceBindings should have comment or be unexported (golint)
  • Line 54: warning: exported method ServicecatalogV1beta1.ClusterServicePlans should have comment or be unexported (golint)
  • Line 58: warning: exported method ServicecatalogV1beta1.RESTClient should have comment or be unexported (golint)

• service-catalog/test/fake/serviceinstances.go
  • Line 37: warning: exported method ServiceInstances.Create should have comment or be unexported (golint)
  • Line 41: warning: exported method ServiceInstances.Update should have comment or be unexported (golint)
  • Line 50: warning: exported method ServiceInstances.UpdateStatus should have comment or be unexported (golint)
  • Line 59: warning: exported method ServiceInstances.Delete should have comment or be unexported (golint)
  • Line 63: warning: exported method ServiceInstances.DeleteCollection should have comment or be unexported (golint)
  • Line 67: warning: exported method ServiceInstances.Get should have comment or be unexported (golint)
  • Line 71: warning: exported method ServiceInstances.List should have comment or be unexported (golint)

• service-catalog/test/e2e/e2e.go
  • Line 22: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• service-catalog/test/e2e/instance.go
  • Line 30: warning: should not use dot imports (golint)
  • Line 31: warning: should not use dot imports (golint)

• service-catalog/test/e2e/util.go
  • Line 26: warning: exported function NewUPSBrokerPod should have comment or be unexported (golint)
  • Line 55: warning: exported function NewUPSBrokerService should have comment or be unexported (golint)

• service-catalog/test/e2e/walkthrough.go
  • Line 29: warning: should not use dot imports (golint)
  • Line 30: warning: should not use dot imports (golint)

• service-catalog/pkg/kubernetes/pkg/util/configz/configz.go
  • Line 32: warning: exported type Config should have comment or be unexported (golint)
  • Line 36: warning: exported function InstallHandler should have comment or be unexported (golint)
  • Line 44: warning: exported function New should have comment or be unexported (golint)
  • Line 55: warning: exported function Delete should have comment or be unexported (golint)
  • Line 61: warning: exported method Config.Set should have comment or be unexported (golint)
  • Line 67: warning: exported method Config.MarshalJSON should have comment or be unexported (golint)

• service-catalog/test/e2e/broker.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• service-catalog/test/e2e/framework/framework.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 24: warning: should not use dot imports (golint)
  • Line 47: warning: comment on exported function NewDefaultFramework should be of the form "NewDefaultFramework ..." (golint)
  • Line 92: warning: comment on exported function ServiceCatalogDescribe should be of the form "ServiceCatalogDescribe ..." (golint)

• service-catalog/pkg/kubernetes/pkg/apis/componentconfig/helpers.go
  • Line 24: warning: exported type IPVar should have comment or be unexported (golint)
  • Line 28: warning: exported method IPVar.Set should have comment or be unexported (golint)
  • Line 47: warning: exported method IPVar.Type should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• service-catalog/test/e2e/walkthrough.go
  • Line 248: warning: ineffectual assignment to instance (ineffassign)
  • Line 285: warning: ineffectual assignment to instance (ineffassign)
  • Line 321: warning: ineffectual assignment to instance (ineffassign)
  • Line 520: warning: ineffectual assignment to instance (ineffassign)
  • Line 557: warning: ineffectual assignment to instance (ineffassign)
  • Line 593: warning: ineffectual assignment to instance (ineffassign)

• service-catalog/pkg/controller/case_test.go
  • Line 487: warning: ineffectual assignment to err (ineffassign)

• service-catalog/pkg/controller/controller_binding.go
  • Line 578: warning: ineffectual assignment to err (ineffassign)

• service-catalog/pkg/controller/controller_instance.go
  • Line 431: warning: ineffectual assignment to delay (ineffassign)

• service-catalog/pkg/controller/controller_instance_test.go
  • Line 1157: warning: ineffectual assignment to updatedServiceInstance (ineffassign)
  • Line 1159: warning: ineffectual assignment to events (ineffassign)

• service-catalog/pkg/controller/controller_message_builder_test.go
  • Line 95: warning: ineffectual assignment to space (ineffassign)

• service-catalog/pkg/controller/controller_test.go
  • Line 1856: warning: ineffectual assignment to err (ineffassign)

• service-catalog/cmd/svcat/main.go
  • Line 237: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• service-catalog/cmd/svcat/plan/describe_cmd.go
  • Line 94: warning: "arugments" is a misspelling of "arguments" (misspell)

• service-catalog/cmd/svcat/plan/get_cmd.go
  • Line 89: warning: "arugments" is a misspelling of "arguments" (misspell)

• service-catalog/pkg/svcat/service-catalog/instance_test.go
  • Line 294: warning: "heirarchy" is a misspelling of "hierarchy" (misspell)

• service-catalog/pkg/controller/controller.go
  • Line 1277: warning: "migitation" is a misspelling of "mitigation" (misspell)

• service-catalog/pkg/controller/controller_clusterid_test.go
  • Line 65: warning: "soley" is a misspelling of "solely" (misspell)
  • Line 190: warning: "perserved" is a misspelling of "preserved" (misspell)

• service-catalog/pkg/controller/controller_serviceplan_test.go
  • Line 161: warning: "buidling" is a misspelling of "building" (misspell)

• service-catalog/cmd/svcat/instance/get_cmd.go
  • Line 71: warning: "specifiying" is a misspelling of "specifying" (misspell)
  • Line 75: warning: "specifiying" is a misspelling of "specifying" (misspell)

• service-catalog/cmd/healthcheck/framework/healthcheck.go
  • Line 443: warning: "occured" is a misspelling of "occurred" (misspell)

• service-catalog/pkg/svcat/service-catalog/broker_test.go
  • Line 90: warning: "arguement" is a misspelling of "argument" (misspell)
  • Line 104: warning: "arguement" is a misspelling of "argument" (misspell)

• service-catalog/pkg/controller/controller_binding_test.go
  • Line 2606: warning: "migitation" is a misspelling of "mitigation" (misspell)

• service-catalog/pkg/controller/controller_instance_test.go
  • Line 1850: warning: "reconcilation" is a misspelling of "reconciliation" (misspell)
  • Line 1919: warning: "reconcilation" is a misspelling of "reconciliation" (misspell)
  • Line 4866: warning: "paramaters" is a misspelling of "parameters" (misspell)