Go Report Card

Preparing report...

Report for github.com/kubernetes-sigs/kubefed

A    Great!    Found 106 issues across 185 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • kubefed/pkg/kubefedctl/join.go
    • Line 624: warning: cyclomatic complexity 21 of function createRoleAndBinding() is high (> 15) (gocyclo)
    • Line 830: warning: cyclomatic complexity 21 of function populateSecretInHostCluster() is high (> 15) (gocyclo)
    • Line 527: warning: cyclomatic complexity 21 of function createClusterRoleAndBinding() is high (> 15) (gocyclo)
    • Line 721: warning: cyclomatic complexity 21 of function createHealthCheckClusterRoleAndBinding() is high (> 15) (gocyclo)
    • kubefed/test/common/crudtester.go
    • Line 260: warning: cyclomatic complexity 26 of function (*FederatedTypeCrudTester).CheckDelete() is high (> 15) (gocyclo)
    • Line 429: warning: cyclomatic complexity 21 of function (*FederatedTypeCrudTester).CheckPropagation() is high (> 15) (gocyclo)
    • Line 528: warning: cyclomatic complexity 17 of function (*FederatedTypeCrudTester).checkFederatedStatus() is high (> 15) (gocyclo)

golint44%

Golint is a linter for Go source code.

    • kubefed/pkg/schedulingtypes/resources.go
    • Line 29: warning: exported var Pod should have comment or be unexported (golint)
    • Line 32: warning: exported var PodResource should have comment or be unexported (golint)
    • Line 40: warning: exported function GetResourceKind should have comment or be unexported (golint)
    • Line 50: warning: exported function GetPluralName should have comment or be unexported (golint)
    • kubefed/pkg/kubefedctl/enable/util.go
    • Line 41: warning: exported function DecodeYAMLFromFile should have comment or be unexported (golint)
    • Line 51: warning: exported function DecodeYAML should have comment or be unexported (golint)
    • Line 56: warning: exported function CrdForAPIResource should have comment or be unexported (golint)
    • Line 94: warning: exported function LookupAPIResource should have comment or be unexported (golint)
    • Line 149: warning: exported function NameMatchesResource should have comment or be unexported (golint)
    • Line 166: warning: exported function GetServerPreferredResources should have comment or be unexported (golint)
    • Line 180: warning: exported function NamespacedToScope should have comment or be unexported (golint)
    • Line 187: warning: exported function FederatedNamespacedToScope should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/safe_map.go
    • Line 23: warning: exported type SafeMap should have comment or be unexported (golint)
    • Line 28: warning: exported function NewSafeMap should have comment or be unexported (golint)
    • Line 34: warning: exported method SafeMap.Store should have comment or be unexported (golint)
    • Line 40: warning: exported method SafeMap.Get should have comment or be unexported (golint)
    • Line 47: warning: exported method SafeMap.GetAll should have comment or be unexported (golint)
    • Line 57: warning: exported method SafeMap.Delete should have comment or be unexported (golint)
    • Line 63: warning: exported method SafeMap.DeleteAll should have comment or be unexported (golint)
    • Line 71: warning: exported method SafeMap.Size should have comment or be unexported (golint)
    • kubefed/pkg/controller/sync/version/manager.go
    • Line 52: warning: exported type VersionManager should have comment or be unexported (golint)
    • Line 71: warning: exported function NewVersionManager should have comment or be unexported (golint)
    • Line 444: warning: exported function VersionMapToClusterVersions should have comment or be unexported (golint)
    • kubefed/pkg/controller/webhook/federatedtypeconfig/webhook.go
    • Line 36: warning: exported const ResourceName should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported type FederatedTypeConfigAdmissionHook should have comment or be unexported (golint)
    • Line 44: warning: exported method FederatedTypeConfigAdmissionHook.Handle should have comment or be unexported (golint)
    • kubefed/pkg/controller/webhook/util.go
    • Line 40: warning: exported function NewMutatingResource should have comment or be unexported (golint)
    • Line 48: warning: exported function NewValidatingResource should have comment or be unexported (golint)
    • Line 67: warning: exported function Unmarshal should have comment or be unexported (golint)
    • Line 71: warning: exported function Validate should have comment or be unexported (golint)
    • Line 87: warning: exported function AdmissionRequestDebugString should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/placement.go
    • Line 28: warning: exported type GenericClusterReference should have comment or be unexported (golint)
    • Line 32: warning: exported type GenericPlacementFields should have comment or be unexported (golint)
    • Line 37: warning: exported type GenericPlacementSpec should have comment or be unexported (golint)
    • Line 41: warning: exported type GenericPlacement should have comment or be unexported (golint)
    • Line 48: warning: exported function UnmarshalGenericPlacement should have comment or be unexported (golint)
    • Line 57: warning: exported method GenericPlacement.ClusterNames should have comment or be unexported (golint)
    • Line 68: warning: exported method GenericPlacement.ClusterSelector should have comment or be unexported (golint)
    • Line 72: warning: exported function GetClusterNames should have comment or be unexported (golint)
    • Line 80: warning: exported function SetClusterNames should have comment or be unexported (golint)
    • Line 93: warning: exported function SetClusterSelector should have comment or be unexported (golint)
    • kubefed/pkg/controller/schedulingmanager/controller.go
    • Line 37: warning: exported type SchedulingManager should have comment or be unexported (golint)
    • Line 50: warning: exported type SchedulerWrapper should have comment or be unexported (golint)
    • Line 62: warning: exported method SchedulerWrapper.HasPlugin should have comment or be unexported (golint)
    • Line 67: warning: exported function StartSchedulingManager should have comment or be unexported (golint)
    • Line 113: warning: exported method SchedulingManager.GetScheduler should have comment or be unexported (golint)
    • kubefed/pkg/controller/kubefedcluster/clusterclient.go
    • Line 42: warning: exported const UserAgentName should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: comment on exported const LabelZoneFailureDomain should be of the form "LabelZoneFailureDomain ..." (golint)
    • Line 48: warning: comment on exported const ClusterReady should be of the form "ClusterReady ..." (golint)
    • kubefed/pkg/controller/sync/status/status.go
    • Line 34: warning: exported type PropagationStatus should have comment or be unexported (golint)
    • Line 36: warning: exported type AggregateReason should have comment or be unexported (golint)
    • Line 38: warning: exported type ConditionType should have comment or be unexported (golint)
    • Line 41: warning: exported const ClusterPropagationOK should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: comment on exported const ClusterNotReady should be of the form "ClusterNotReady ..." (golint)
    • Line 60: warning: comment on exported const CreationTimedOut should be of the form "CreationTimedOut ..." (golint)
    • Line 75: warning: exported type GenericClusterStatus should have comment or be unexported (golint)
    • Line 81: warning: exported type GenericCondition should have comment or be unexported (golint)
    • Line 98: warning: exported type GenericFederatedStatus should have comment or be unexported (golint)
    • Line 104: warning: exported type GenericFederatedResource should have comment or be unexported (golint)
    • Line 111: warning: exported type PropagationStatusMap should have comment or be unexported (golint)
    • Line 113: warning: exported type CollectedPropagationStatus should have comment or be unexported (golint)
    • Line 118: warning: exported type CollectedResourceStatus should have comment or be unexported (golint)
    • kubefed/test/e2e/framework/util.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 32: warning: comment on exported const PollInterval should be of the form "PollInterval ..." (golint)
    • Line 35: warning: comment on exported const DefaultSingleCallTimeout should be of the form "DefaultSingleCallTimeout ..." (golint)
    • Line 51: warning: exported function Errorf should have comment or be unexported (golint)
    • Line 55: warning: exported function Logf should have comment or be unexported (golint)
    • Line 59: warning: exported function Failf should have comment or be unexported (golint)
    • Line 71: warning: exported function Skipf should have comment or be unexported (golint)
    • Line 77: warning: exported function ExpectNoError should have comment or be unexported (golint)
    • Line 90: warning: comment on exported type TestFixture should be of the form "TestFixture ..." (with optional leading article) (golint)
    • kubefed/pkg/apis/core/v1beta1/kubefedconfig_types.go
    • Line 44: warning: exported type DurationConfig should have comment or be unexported (golint)
    • Line 52: warning: exported type LeaderElectConfig should have comment or be unexported (golint)
    • Line 75: warning: exported type ResourceLockType should have comment or be unexported (golint)
    • Line 78: warning: exported const ConfigMapsResourceLock should have comment (or a comment on this block) or be unexported (golint)
    • Line 82: warning: exported type FeatureGatesConfig should have comment or be unexported (golint)
    • Line 87: warning: exported type ConfigurationMode should have comment or be unexported (golint)
    • Line 90: warning: exported const ConfigurationEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 94: warning: exported type ClusterHealthCheckConfig should have comment or be unexported (golint)
    • Line 109: warning: exported type SyncControllerConfig should have comment or be unexported (golint)
    • Line 120: warning: exported type ResourceAdoption should have comment or be unexported (golint)
    • Line 123: warning: exported const AdoptResourcesEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 127: warning: exported type StatusControllerConfig should have comment or be unexported (golint)
    • Line 137: warning: exported type KubeFedConfig should have comment or be unexported (golint)
    • kubefed/pkg/apis/core/v1beta1/validation/validation.go
    • Line 42: warning: exported function ValidateFederatedTypeConfig should have comment or be unexported (golint)
    • Line 55: warning: exported function ValidateFederatedTypeConfigName should have comment or be unexported (golint)
    • Line 63: warning: exported function ValidateFederatedTypeConfigSpec should have comment or be unexported (golint)
    • Line 80: warning: exported function ValidateFederatedAPIResource should have comment or be unexported (golint)
    • Line 93: warning: exported function ValidateStatusAPIResource should have comment or be unexported (golint)
    • Line 97: warning: exported function ValidateAPIResource should have comment or be unexported (golint)
    • Line 141: warning: exported function ValidateFederatedTypeConfigStatus should have comment or be unexported (golint)
    • Line 153: warning: exported function ValidateKubeFedCluster should have comment or be unexported (golint)
    • Line 268: warning: exported function ValidateKubeFedConfig should have comment or be unexported (golint)
    • kubefed/pkg/controller/webhook/kubefedcluster/webhook.go
    • Line 36: warning: exported const ResourceName should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported type KubeFedClusterAdmissionHook should have comment or be unexported (golint)
    • Line 44: warning: exported method KubeFedClusterAdmissionHook.Handle should have comment or be unexported (golint)
    • kubefed/pkg/kubefedctl/enable/directive.go
    • Line 40: warning: comment on exported type EnableTypeDirective should be of the form "EnableTypeDirective ..." (with optional leading article) (golint)
    • Line 50: warning: exported method EnableTypeDirective.SetDefaults should have comment or be unexported (golint)
    • Line 55: warning: exported function NewEnableTypeDirective should have comment or be unexported (golint)
    • kubefed/pkg/schedulingtypes/typeregistry.go
    • Line 23: warning: exported type SchedulingType should have comment or be unexported (golint)
    • Line 32: warning: exported function RegisterSchedulingType should have comment or be unexported (golint)
    • Line 40: warning: exported function SchedulingTypes should have comment or be unexported (golint)
    • Line 48: warning: exported function GetSchedulingType should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/worker.go
    • Line 28: warning: exported type ReconcileFunc should have comment or be unexported (golint)
    • Line 30: warning: exported type ReconcileWorker should have comment or be unexported (golint)
    • Line 41: warning: exported type WorkerOptions should have comment or be unexported (golint)
    • Line 48: warning: exported type WorkerTiming should have comment or be unexported (golint)
    • Line 78: warning: exported function NewReconcileWorker should have comment or be unexported (golint)
    • kubefed/pkg/schedulingtypes/plugin.go
    • Line 45: warning: exported type Plugin should have comment or be unexported (golint)
    • Line 60: warning: exported function NewPlugin should have comment or be unexported (golint)
    • Line 101: warning: exported method Plugin.Start should have comment or be unexported (golint)
    • Line 107: warning: exported method Plugin.Stop should have comment or be unexported (golint)
    • Line 112: warning: exported method Plugin.HasSynced should have comment or be unexported (golint)
    • Line 135: warning: exported method Plugin.FederatedTypeExists should have comment or be unexported (golint)
    • Line 146: warning: exported method Plugin.GetResourceClusters should have comment or be unexported (golint)
    • Line 164: warning: exported method Plugin.Reconcile should have comment or be unexported (golint)
    • Line 214: warning: comment on exported function PlacementUpdateNeeded should be of the form "PlacementUpdateNeeded ..." (golint)
    • Line 263: warning: exported function OverrideUpdateNeeded should have comment or be unexported (golint)
    • kubefed/test/e2e/framework/test_context.go
    • Line 30: warning: exported type TestContextType should have comment or be unexported (golint)
    • Line 43: warning: exported method TestContextType.RunControllers should have comment or be unexported (golint)
    • Line 56: warning: exported var TestContext should have comment or be unexported (golint)
    • Line 97: warning: exported function ParseFlags should have comment or be unexported (golint)
    • kubefed/test/common/typeconfig.go
    • Line 29: warning: exported function GetTypeConfig should have comment or be unexported (golint)
    • Line 39: warning: exported function EnableStatusCollection should have comment or be unexported (golint)
    • kubefed/test/common/util.go
    • Line 42: warning: exported function Equivalent should have comment or be unexported (golint)
    • Line 54: warning: comment on exported function WaitForNamespaceOrDie should be of the form "WaitForNamespaceOrDie ..." (golint)
    • kubefed/pkg/kubefedctl/federate/federate.go
    • Line 231: warning: exported function FederateResources should have comment or be unexported (golint)
    • Line 263: warning: exported type FederateArtifacts should have comment or be unexported (golint)
    • Line 273: warning: exported function GetFederateArtifacts should have comment or be unexported (golint)
    • Line 358: warning: exported function FederatedResourceFromTargetResource should have comment or be unexported (golint)
    • Line 434: warning: exported function CreateResources should have comment or be unexported (golint)
    • Line 458: warning: exported function CreateFederatedResources should have comment or be unexported (golint)
    • Line 469: warning: exported function CreateFederatedResource should have comment or be unexported (golint)
    • Line 505: warning: exported function GetContainedArtifactsList should have comment or be unexported (golint)
    • Line 538: warning: exported function WriteUnstructuredObjsToYaml should have comment or be unexported (golint)
    • kubefed/pkg/kubefedctl/enable/enable.go
    • Line 193: warning: exported function GetResources should have comment or be unexported (golint)
    • Line 220: warning: comment on exported function CreateResources should be of the form "CreateResources ..." (golint)
    • Line 356: warning: exported function GenerateTypeConfigForTarget should have comment or be unexported (golint)
    • kubefed/pkg/client/generic/scheme/register.go
    • Line 30: warning: exported var Scheme should have comment or be unexported (golint)
    • Line 31: warning: exported var Codecs should have comment or be unexported (golint)
    • Line 32: warning: exported var ParameterCodec should have comment or be unexported (golint)
    • Line 43: warning: exported var AddToScheme should have comment or be unexported (golint)
    • kubefed/pkg/schedulingtypes/replicascheduler.go
    • Line 44: warning: exported const RSPKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 56: warning: exported type ReplicaScheduler should have comment or be unexported (golint)
    • Line 67: warning: exported function NewReplicaScheduler should have comment or be unexported (golint)
    • Line 95: warning: exported method ReplicaScheduler.SchedulingKind should have comment or be unexported (golint)
    • Line 99: warning: exported method ReplicaScheduler.StartPlugin should have comment or be unexported (golint)
    • Line 114: warning: exported method ReplicaScheduler.StopPlugin should have comment or be unexported (golint)
    • Line 124: warning: exported method ReplicaScheduler.ObjectType should have comment or be unexported (golint)
    • Line 128: warning: exported method ReplicaScheduler.Start should have comment or be unexported (golint)
    • Line 132: warning: exported method ReplicaScheduler.HasSynced should have comment or be unexported (golint)
    • Line 151: warning: exported method ReplicaScheduler.Stop should have comment or be unexported (golint)
    • Line 159: warning: exported method ReplicaScheduler.Reconcile should have comment or be unexported (golint)
    • Line 242: warning: exported method ReplicaScheduler.GetSchedulingResult should have comment or be unexported (golint)
    • kubefed/pkg/controller/webhook/kubefedconfig/webhook.go
    • Line 39: warning: exported const ResourceName should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type KubeFedConfigValidator should have comment or be unexported (golint)
    • Line 47: warning: exported method KubeFedConfigValidator.Handle should have comment or be unexported (golint)
    • Line 94: warning: exported type KubeFedConfigDefaulter should have comment or be unexported (golint)
    • Line 98: warning: exported method KubeFedConfigDefaulter.Handle should have comment or be unexported (golint)
    • kubefed/test/common/crudtester.go
    • Line 70: warning: exported type TestClusterConfig should have comment or be unexported (golint)
    • Line 75: warning: exported type TestCluster should have comment or be unexported (golint)
    • Line 80: warning: exported function NewFederatedTypeCrudTester should have comment or be unexported (golint)
    • Line 93: warning: exported method FederatedTypeCrudTester.CheckLifecycle should have comment or be unexported (golint)
    • Line 107: warning: exported method FederatedTypeCrudTester.Create should have comment or be unexported (golint)
    • Line 144: warning: exported method FederatedTypeCrudTester.CheckCreate should have comment or be unexported (golint)
    • Line 175: warning: exported method FederatedTypeCrudTester.CheckUpdate should have comment or be unexported (golint)
    • Line 260: warning: exported method FederatedTypeCrudTester.CheckDelete should have comment or be unexported (golint)
    • Line 368: warning: exported method FederatedTypeCrudTester.SetDeleteOption should have comment or be unexported (golint)
    • Line 383: warning: exported method FederatedTypeCrudTester.CheckReplicaSet should have comment or be unexported (golint)
    • Line 659: warning: exported method FederatedTypeCrudTester.TestClusters should have comment or be unexported (golint)
    • Line 781: warning: exported method FederatedTypeCrudTester.CheckRemoteStatus should have comment or be unexported (golint)
    • Line 877: warning: exported method FederatedTypeCrudTester.CheckStatusCreated should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/planner/planner.go
    • Line 49: warning: exported function NewPlanner should have comment or be unexported (golint)
    • Line 55: warning: comment on exported method Planner.Plan should be of the form "Plan ..." (golint)
    • Line 232: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kubefed/pkg/client/generic/genericclient.go
    • Line 29: warning: exported type Client should have comment or be unexported (golint)
    • Line 43: warning: exported function New should have comment or be unexported (golint)
    • Line 48: warning: exported function NewForConfigOrDie should have comment or be unexported (golint)
    • Line 56: warning: exported function NewForConfigOrDieWithUserAgent should have comment or be unexported (golint)
    • kubefed/pkg/features/features.go
    • Line 32: warning: comment on exported const PushReconciler should be of the form "PushReconciler ..." (golint)
    • Line 38: warning: comment on exported const SchedulerPreferences should be of the form "SchedulerPreferences ..." (golint)
    • Line 44: warning: comment on exported const RawResourceStatusCollection should be of the form "RawResourceStatusCollection ..." (golint)
    • kubefed/pkg/kubefedctl/federate/util.go
    • Line 44: warning: exported function RemoveUnwantedFields should have comment or be unexported (golint)
    • Line 67: warning: exported function SetBasicMetaFields should have comment or be unexported (golint)
    • Line 228: warning: comment on exported function DecodeUnstructuredFromFile should be of the form "DecodeUnstructuredFromFile ..." (golint)
    • kubefed/test/common/testobjects.go
    • Line 30: warning: exported function NewTestObject should have comment or be unexported (golint)
    • Line 63: warning: exported function OverridesFromFixture should have comment or be unexported (golint)
    • Line 77: warning: exported function NewTestTargetObject should have comment or be unexported (golint)
    • kubefed/pkg/apis/core/v1beta1/federatedtypeconfig_types.go
    • Line 76: warning: exported const PropagationEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 84: warning: exported const StatusCollectionEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 145: warning: exported function SetFederatedTypeConfigDefaults should have comment or be unexported (golint)
    • Line 187: warning: exported method FederatedTypeConfig.GetObjectMeta should have comment or be unexported (golint)
    • Line 191: warning: exported method FederatedTypeConfig.GetTargetType should have comment or be unexported (golint)
    • Line 195: warning: comment on exported method FederatedTypeConfig.GetNamespaced should be of the form "GetNamespaced ..." (golint)
    • Line 202: warning: exported method FederatedTypeConfig.GetPropagationEnabled should have comment or be unexported (golint)
    • Line 206: warning: exported method FederatedTypeConfig.GetFederatedType should have comment or be unexported (golint)
    • Line 210: warning: comment on exported method FederatedTypeConfig.GetStatusType should be of the form "GetStatusType ..." (golint)
    • Line 221: warning: exported method FederatedTypeConfig.GetStatusEnabled should have comment or be unexported (golint)
    • Line 226: warning: comment on exported method FederatedTypeConfig.GetFederatedNamespaced should be of the form "GetFederatedNamespaced ..." (golint)
    • Line 243: warning: exported method FederatedTypeConfig.IsNamespace should have comment or be unexported (golint)
    • Line 247: warning: exported method APIResource.Namespaced should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/delaying_deliverer.go
    • Line 17: warning: package comment should be of the form "Package util ..." (golint)
    • Line 72: warning: comment on exported type DelayingDeliverer should be of the form "DelayingDeliverer ..." (with optional leading article) (golint)
    • Line 84: warning: exported function NewDelayingDeliverer should have comment or be unexported (golint)
    • Line 88: warning: exported function NewDelayingDelivererWithChannel should have comment or be unexported (golint)
    • Line 141: warning: comment on exported method DelayingDeliverer.Start should be of the form "Start ..." (golint)
    • Line 146: warning: comment on exported method DelayingDeliverer.Stop should be of the form "Stop ..." (golint)
    • Line 151: warning: comment on exported method DelayingDeliverer.DeliverAt should be of the form "DeliverAt ..." (golint)
    • Line 160: warning: comment on exported method DelayingDeliverer.DeliverAfter should be of the form "DeliverAfter ..." (golint)
    • Line 165: warning: comment on exported method DelayingDeliverer.GetTargetChannel should be of the form "GetTargetChannel ..." (golint)
    • Line 170: warning: comment on exported method DelayingDeliverer.StartWithHandler should be of the form "StartWithHandler ..." (golint)
    • kubefed/test/e2e/framework/framework.go
    • Line 38: warning: should not use dot imports (golint)
    • Line 39: warning: should not use dot imports (golint)
    • Line 45: warning: exported type KubeFedFrameworkImpl should have comment or be unexported (golint)
    • Line 111: warning: exported function NewKubeFedFramework should have comment or be unexported (golint)
    • Line 297: warning: exported function CreateTestNamespace should have comment or be unexported (golint)
    • Line 305: warning: exported function CreateNamespace should have comment or be unexported (golint)
    • kubefed/test/e2e/framework/unmanaged.go
    • Line 43: warning: should not use dot imports (golint)
    • Line 44: warning: should not use dot imports (golint)
    • Line 64: warning: exported function SetUpFeatureGates should have comment or be unexported (golint)
    • Line 76: warning: exported function SetUpControlPlane should have comment or be unexported (golint)
    • Line 93: warning: exported function TearDownControlPlane should have comment or be unexported (golint)
    • Line 109: warning: exported type UnmanagedFramework should have comment or be unexported (golint)
    • Line 125: warning: exported function NewUnmanagedFramework should have comment or be unexported (golint)
    • Line 185: warning: exported method UnmanagedFramework.ControllerConfig should have comment or be unexported (golint)
    • Line 198: warning: exported method UnmanagedFramework.Logger should have comment or be unexported (golint)
    • Line 202: warning: exported method UnmanagedFramework.KubeConfig should have comment or be unexported (golint)
    • Line 206: warning: exported method UnmanagedFramework.KubeClient should have comment or be unexported (golint)
    • Line 212: warning: exported method UnmanagedFramework.Client should have comment or be unexported (golint)
    • Line 216: warning: exported method UnmanagedFramework.ClusterNames should have comment or be unexported (golint)
    • Line 229: warning: exported method UnmanagedFramework.ClusterDynamicClients should have comment or be unexported (golint)
    • Line 246: warning: exported method UnmanagedFramework.ClusterKubeClients should have comment or be unexported (golint)
    • Line 258: warning: exported method UnmanagedFramework.ClusterConfigs should have comment or be unexported (golint)
    • Line 286: warning: exported method UnmanagedFramework.HostConfig should have comment or be unexported (golint)
    • Line 295: warning: exported method UnmanagedFramework.KubeFedSystemNamespace should have comment or be unexported (golint)
    • Line 299: warning: exported method UnmanagedFramework.TestNamespaceName should have comment or be unexported (golint)
    • Line 333: warning: exported function DeleteNamespace should have comment or be unexported (golint)
    • Line 416: warning: exported type EventsLister should have comment or be unexported (golint)
    • Line 418: warning: exported function DumpEventsInNamespace should have comment or be unexported (golint)
    • Line 437: warning: exported function WaitForUnmanagedClusterReadiness should have comment or be unexported (golint)
    • kubefed/test/common/fixtures.go
    • Line 32: warning: exported function TypeConfigFixturesOrDie should have comment or be unexported (golint)
    • Line 59: warning: exported function DecodeYamlFromBindata should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/orphaninganotation.go
    • Line 22: warning: comment on exported const OrphanManagedResourcesAnnotation should be of the form "OrphanManagedResourcesAnnotation ..." (golint)
    • Line 27: warning: exported const OrphanedManagedResourcesValue should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: comment on exported function EnableOrphaning should be of the form "EnableOrphaning ..." (golint)
    • Line 50: warning: comment on exported function DisableOrphaning should be of the form "DisableOrphaning ..." (golint)
    • kubefed/pkg/schedulingtypes/interface.go
    • Line 27: warning: exported type Scheduler should have comment or be unexported (golint)
    • Line 40: warning: exported type SchedulerEventHandlers should have comment or be unexported (golint)
    • Line 46: warning: exported type SchedulerFactory should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/federated_informer.go
    • Line 45: warning: comment on exported type FederatedObject should be of the form "FederatedObject ..." (with optional leading article) (golint)
    • Line 77: warning: comment on exported type RegisteredClustersView should be of the form "RegisteredClustersView ..." (with optional leading article) (golint)
    • Line 121: warning: comment on exported type TargetInformerFactory should be of the form "TargetInformerFactory ..." (with optional leading article) (golint)
    • Line 125: warning: comment on exported type ClusterLifecycleHandlerFuncs should be of the form "ClusterLifecycleHandlerFuncs ..." (with optional leading article) (golint)
    • Line 137: warning: comment on exported function NewFederatedInformer should be of the form "NewFederatedInformer ..." (golint)
    • Line 252: warning: exported function IsClusterReady should have comment or be unexported (golint)
    • Line 421: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kubefed/pkg/controller/util/meta.go
    • Line 43: warning: comment on exported function DeepCopyRelevantObjectMeta should be of the form "DeepCopyRelevantObjectMeta ..." (golint)
    • Line 63: warning: comment on exported function ObjectMetaEquivalent should be of the form "ObjectMetaEquivalent ..." (golint)
    • Line 82: warning: comment on exported function ObjectMetaObjEquivalent should be of the form "ObjectMetaObjEquivalent ..." (golint)
    • Line 105: warning: comment on exported function ObjectMetaAndSpecEquivalent should be of the form "ObjectMetaAndSpecEquivalent ..." (golint)
    • Line 115: warning: exported function MetaAccessor should have comment or be unexported (golint)
    • kubefed/test/e2e/framework/controller.go
    • Line 65: warning: comment on exported function NewFederatedTypeConfigControllerFixture should be of the form "NewFederatedTypeConfigControllerFixture ..." (golint)
    • Line 92: warning: exported function NewSchedulingManagerFixture should have comment or be unexported (golint)
    • Line 104: warning: exported function StartControllerManager should have comment or be unexported (golint)
    • Line 118: warning: exported method ControllerFixture.TearDown should have comment or be unexported (golint)
    • kubefed/pkg/controller/util/overrides.go
    • Line 30: warning: exported type ClusterOverride should have comment or be unexported (golint)
    • Line 36: warning: exported type GenericOverrideItem should have comment or be unexported (golint)
    • Line 41: warning: exported type GenericOverrideSpec should have comment or be unexported (golint)
    • Line 45: warning: exported type GenericOverride should have comment or be unexported (golint)
    • Line 70: warning: comment on exported type ClusterOverrides should be of the form "ClusterOverrides ..." (with optional leading article) (golint)
    • Line 73: warning: comment on exported type OverridesMap should be of the form "OverridesMap ..." (with optional leading article) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (exit status 2)

misspell99%

Misspell Finds commonly misspelled English words