Report for github.com/kubernetes/cloud-provider-aws
A+ Excellent! Found 7 issues across 40 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo87%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
cloud-provider-aws/pkg/providers/v1/aws.go
- Line 4140: warning: cyclomatic complexity 69 of function (*Cloud).EnsureLoadBalancer() is high (> 15) (gocyclo)
- Line 4802: warning: cyclomatic complexity 29 of function (*Cloud).EnsureLoadBalancerDeleted() is high (> 15) (gocyclo)
- Line 2418: warning: cyclomatic complexity 24 of function (*awsDisk).waitForAttachmentStatus() is high (> 15) (gocyclo)
- Line 1286: warning: cyclomatic complexity 24 of function newAWSCloud() is high (> 15) (gocyclo)
- Line 4679: warning: cyclomatic complexity 22 of function (*Cloud).updateInstanceSecurityGroupsForLoadBalancer() is high (> 15) (gocyclo)
- Line 3675: warning: cyclomatic complexity 18 of function (*Cloud).findELBSubnets() is high (> 15) (gocyclo)
- Line 2769: warning: cyclomatic complexity 16 of function (*Cloud).CreateDisk() is high (> 15) (gocyclo)
- Line 1546: warning: cyclomatic complexity 16 of function (*Cloud).ipv4AddressesFromMetadata() is high (> 15) (gocyclo)
- Line 2602: warning: cyclomatic complexity 16 of function (*Cloud).AttachDisk() is high (> 15) (gocyclo)
-
-
cloud-provider-aws/pkg/providers/v1/aws_loadbalancer.go
- Line 141: warning: cyclomatic complexity 50 of function (*Cloud).ensureLoadBalancerv2() is high (> 15) (gocyclo)
- Line 966: warning: cyclomatic complexity 40 of function (*Cloud).ensureLoadBalancer() is high (> 15) (gocyclo)
- Line 782: warning: cyclomatic complexity 20 of function (*Cloud).updateInstanceSecurityGroupsForNLB() is high (> 15) (gocyclo)
- Line 570: warning: cyclomatic complexity 19 of function (*Cloud).ensureTargetGroup() is high (> 15) (gocyclo)
- Line 399: warning: cyclomatic complexity 16 of function (*Cloud).reconcileLBAttributes() is high (> 15) (gocyclo)
- Line 1371: warning: cyclomatic complexity 16 of function (*Cloud).ensureLoadBalancerHealthCheck() is high (> 15) (gocyclo)
-
-
cloud-provider-aws/pkg/providers/v1/aws_test.go
- Line 1310: warning: cyclomatic complexity 27 of function TestSubnetIDsinVPC() is high (> 15) (gocyclo)
- Line 269: warning: cyclomatic complexity 20 of function TestOverridesActiveConfig() is high (> 15) (gocyclo)
- Line 3023: warning: cyclomatic complexity 16 of function (*MockedFakeELBV2).ModifyListener() is high (> 15) (gocyclo)
-
-
cloud-provider-aws/pkg/providers/v1/aws_fakes.go
- Line 317: warning: cyclomatic complexity 23 of function (*FakeMetadata).GetMetadata() is high (> 15) (gocyclo)
-
-
cloud-provider-aws/pkg/providers/v1/instances_test.go
- Line 29: warning: cyclomatic complexity 16 of function TestMapToAWSInstanceIDs() is high (> 15) (gocyclo)
ineffassign95%
IneffAssign detects ineffectual assignments in Go code.
-
-
cloud-provider-aws/cmd/ecr-credential-provider/main_test.go
- Line 31: warning: no required module provides package k8s.io/cloud-provider-aws/pkg/providers/v2/mocks; to add it: (ineffassign)
- Line 31: warning: could not import k8s.io/cloud-provider-aws/pkg/providers/v2/mocks (invalid package name: "") (ineffassign)
-
-
cloud-provider-aws/pkg/providers/v2/instances_test.go
- Line 32: warning: no required module provides package k8s.io/cloud-provider-aws/pkg/providers/v2/mocks; to add it: (ineffassign)
- Line 32: warning: could not import k8s.io/cloud-provider-aws/pkg/providers/v2/mocks (invalid package name: "") (ineffassign)