Go Report Card

Preparing report...

Report for github.com/kubernetes/ingress-gce

A+    Excellent!    Found 163 issues across 515 files

Tweet
Last refresh:

Refresh now

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • ingress-gce/pkg/fuzz/gcp.go
    • Line 436: warning: cyclomatic complexity 64 of function GCLBForVIP() is high (> 15) (gocyclo)
    • Line 694: warning: cyclomatic complexity 64 of function RegionalGCLBForVIP() is high (> 15) (gocyclo)
    • Line 164: warning: cyclomatic complexity 40 of function (*GCLB).CheckResourceDeletion() is high (> 15) (gocyclo)
    • Line 286: warning: cyclomatic complexity 21 of function (*GCLB).CheckResourceDeletionByProtocol() is high (> 15) (gocyclo)
    • ingress-gce/pkg/psc/controller_test.go
    • Line 503: warning: cyclomatic complexity 24 of function TestServiceAttachmentGarbageCollection() is high (> 15) (gocyclo)
    • Line 56: warning: cyclomatic complexity 22 of function TestServiceAttachmentCreation() is high (> 15) (gocyclo)
    • Line 392: warning: cyclomatic complexity 19 of function TestServiceAttachmentUpdate() is high (> 15) (gocyclo)
    • ingress-gce/pkg/neg/manager_test.go
    • Line 1147: warning: cyclomatic complexity 34 of function TestGarbageCollectionNegCrdEnabled() is high (> 15) (gocyclo)
    • Line 97: warning: cyclomatic complexity 20 of function TestEnsureAndStopSyncer() is high (> 15) (gocyclo)
    • Line 1023: warning: cyclomatic complexity 20 of function TestNegCRDeletions() is high (> 15) (gocyclo)
    • Line 818: warning: cyclomatic complexity 19 of function TestNegCRDuplicateCreations() is high (> 15) (gocyclo)
    • Line 710: warning: cyclomatic complexity 19 of function TestNegCRCreations() is high (> 15) (gocyclo)
    • ingress-gce/pkg/loadbalancers/l4_test.go
    • Line 1127: warning: cyclomatic complexity 28 of function assertInternalLbResources() is high (> 15) (gocyclo)
    • Line 798: warning: cyclomatic complexity 25 of function TestEnsureInternalLoadBalancerCustomSubnet() is high (> 15) (gocyclo)
    • Line 944: warning: cyclomatic complexity 19 of function TestEnsureInternalLoadBalancerModifyProtocol() is high (> 15) (gocyclo)
    • Line 1034: warning: cyclomatic complexity 18 of function TestEnsureInternalLoadBalancerAllPorts() is high (> 15) (gocyclo)
    • Line 237: warning: cyclomatic complexity 18 of function TestEnsureInternalLoadBalancerClearPreviousResources() is high (> 15) (gocyclo)
    • Line 717: warning: cyclomatic complexity 17 of function TestEnsureInternalLoadBalancerEnableGlobalAccess() is high (> 15) (gocyclo)

golint77%

Golint is a linter for Go source code.

    • ingress-gce/pkg/fuzz/features/https_redirects.go
    • Line 27: warning: comment on exported var HTTPSRedirects should be of the form "HTTPSRedirects ..." (golint)
    • Line 56: warning: receiver name v should be consistent with previous receiver name f for HTTPSRedirectsFeature (golint)
    • Line 82: warning: receiver name v should be consistent with previous receiver name f for HTTPSRedirectsFeature (golint)
    • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • ingress-gce/pkg/apis/svcneg/v1beta1/types.go
    • Line 26: warning: comment on exported type ServiceNetworkEndpointGroup should be of the form "ServiceNetworkEndpointGroup ..." (with optional leading article) (golint)
    • Line 74: warning: comment on exported type NetworkEndpointType should be of the form "NetworkEndpointType ..." (with optional leading article) (golint)
    • Line 78: warning: exported const VmIpPortEndpointType should have comment (or a comment on this block) or be unexported (golint)
    • Line 83: warning: comment on exported type Condition should be of the form "Condition ..." (with optional leading article) (golint)
    • ingress-gce/pkg/psc/metrics/metrics.go
    • Line 34: warning: exported const GCProcess should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: exported var PSCProcessLatency should have comment or be unexported (golint)
    • Line 71: warning: exported function RegisterMetrics should have comment or be unexported (golint)
    • Line 83: warning: comment on exported function PublishPSCProcessMetrics should be of the form "PublishPSCProcessMetrics ..." (golint)
    • ingress-gce/pkg/utils/namer/l4_namer.go
    • Line 43: warning: exported function NewL4Namer should have comment or be unexported (golint)
    • Line 90: warning: receiver name n should be consistent with previous receiver name namer for L4Namer (golint)
    • Line 97: warning: receiver name n should be consistent with previous receiver name namer for L4Namer (golint)
    • ingress-gce/pkg/neg/types/mock.go
    • Line 35: warning: exported type NetworkEndpointEntry should have comment or be unexported (golint)
    • Line 40: warning: exported type NetworkEndpointStore should have comment or be unexported (golint)
    • Line 42: warning: exported method NetworkEndpointStore.AddNetworkEndpointHealthStatus should have comment or be unexported (golint)
    • Line 54: warning: exported function MockNetworkEndpointAPIs should have comment or be unexported (golint)
    • Line 63: warning: comment on exported function MockAggregatedListNetworkEndpointGroupHook should be of the form "MockAggregatedListNetworkEndpointGroupHook ..." (golint)
    • Line 95: warning: exported function MockListNetworkEndpointsHook should have comment or be unexported (golint)
    • Line 112: warning: exported function MockAttachNetworkEndpointsHook should have comment or be unexported (golint)
    • Line 149: warning: exported function MockDetachNetworkEndpointsHook should have comment or be unexported (golint)
    • ingress-gce/pkg/annotations/service.go
    • Line 37: warning: exported const GoogleServiceApplicationProtocolKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 138: warning: comment on exported method NegAnnotation.NEGEnabled should be of the form "NEGEnabled ..." (golint)
    • Line 161: warning: exported method NegStatus.Marshal should have comment or be unexported (golint)
    • Line 270: warning: exported var ErrBackendConfigNoneFound should have comment or be unexported (golint)
    • Line 293: warning: exported method Service.NEGStatus should have comment or be unexported (golint)
    • Line 309: warning: exported type BackendConfigs should have comment or be unexported (golint)
    • ingress-gce/pkg/utils/common/finalizer.go
    • Line 35: warning: comment on exported const LegacyILBFinalizer should be of the form "LegacyILBFinalizer ..." (golint)
    • Line 109: warning: comment on exported function EnsureDeleteServiceFinalizer should be of the form "EnsureDeleteServiceFinalizer ..." (golint)
    • ingress-gce/pkg/composite/composite.go
    • Line 17: warning: package comment should be of the form "Package composite ..." (golint)
    • Line 33: warning: comment on exported function SetUrlMapForTargetHttpsProxy should be of the form "SetUrlMapForTargetHttpsProxy ..." (golint)
    • Line 71: warning: comment on exported function SetSslCertificateForTargetHttpsProxy should be of the form "SetSslCertificateForTargetHttpsProxy ..." (golint)
    • Line 112: warning: comment on exported function SetSslPolicyForTargetHttpsProxy should be of the form "SetSslPolicyForTargetHttpsProxy ..." (golint)
    • Line 150: warning: comment on exported function SetUrlMapForTargetHttpProxy should be of the form "SetUrlMapForTargetHttpProxy ..." (golint)
    • Line 188: warning: comment on exported function SetProxyForForwardingRule should be of the form "SetProxyForForwardingRule ..." (golint)
    • ingress-gce/pkg/instances/fakes.go
    • Line 158: warning: exported method FakeInstanceGroups.SetNamedPortsOfInstanceGroup should have comment or be unexported (golint)
    • Line 190: warning: exported method FakeInstanceGroups.ToInstanceReferences should have comment or be unexported (golint)
    • ingress-gce/pkg/psc/controller.go
    • Line 1: warning: package comment should be of the form "Package psc ..." (golint)
    • Line 63: warning: comment on exported const ServiceAttachmentFinalizerKey should be of the form "ServiceAttachmentFinalizerKey ..." (golint)
    • Line 90: warning: exported function NewController should have comment or be unexported (golint)
    • Line 543: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • ingress-gce/pkg/fuzz/helpers.go
    • Line 138: warning: exported function FrontendConfigForIngress should have comment or be unexported (golint)
    • Line 306: warning: comment on exported method IngressBuilder.ConfigureForILB should be of the form "ConfigureForILB ..." (golint)
    • ingress-gce/cmd/echo/app/env.go
    • Line 22: warning: exported const HostEnvVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported type Env should have comment or be unexported (golint)
    • Line 34: warning: exported var E should have comment or be unexported (golint)
    • ingress-gce/pkg/e2e/adapter/zz_generated.conversion.go
    • Line 35: warning: don't use underscores in Go names; func autoConvert_v1beta1_HTTPIngressPath_To_networking_HTTPIngressPath should be autoConvertV1beta1HTTPIngressPathToNetworkingHTTPIngressPath (golint)
    • Line 45: warning: don't use underscores in Go names; func Convert_v1beta1_HTTPIngressPath_To_networking_HTTPIngressPath should be ConvertV1beta1HTTPIngressPathToNetworkingHTTPIngressPath (golint)
    • Line 49: warning: don't use underscores in Go names; func autoConvert_networking_HTTPIngressPath_To_v1beta1_HTTPIngressPath should be autoConvertNetworkingHTTPIngressPathToV1beta1HTTPIngressPath (golint)
    • Line 59: warning: don't use underscores in Go names; func Convert_networking_HTTPIngressPath_To_v1beta1_HTTPIngressPath should be ConvertNetworkingHTTPIngressPathToV1beta1HTTPIngressPath (golint)
    • Line 63: warning: don't use underscores in Go names; func autoConvert_v1beta1_HTTPIngressRuleValue_To_networking_HTTPIngressRuleValue should be autoConvertV1beta1HTTPIngressRuleValueToNetworkingHTTPIngressRuleValue (golint)
    • Line 79: warning: don't use underscores in Go names; func Convert_v1beta1_HTTPIngressRuleValue_To_networking_HTTPIngressRuleValue should be ConvertV1beta1HTTPIngressRuleValueToNetworkingHTTPIngressRuleValue (golint)
    • Line 83: warning: don't use underscores in Go names; func autoConvert_networking_HTTPIngressRuleValue_To_v1beta1_HTTPIngressRuleValue should be autoConvertNetworkingHTTPIngressRuleValueToV1beta1HTTPIngressRuleValue (golint)
    • Line 99: warning: don't use underscores in Go names; func Convert_networking_HTTPIngressRuleValue_To_v1beta1_HTTPIngressRuleValue should be ConvertNetworkingHTTPIngressRuleValueToV1beta1HTTPIngressRuleValue (golint)
    • Line 103: warning: don't use underscores in Go names; func autoConvert_v1beta1_Ingress_To_networking_Ingress should be autoConvertV1beta1IngressToNetworkingIngress (golint)
    • Line 115: warning: don't use underscores in Go names; func Convert_v1beta1_Ingress_To_networking_Ingress should be ConvertV1beta1IngressToNetworkingIngress (golint)
    • Line 119: warning: don't use underscores in Go names; func autoConvert_networking_Ingress_To_v1beta1_Ingress should be autoConvertNetworkingIngressToV1beta1Ingress (golint)
    • Line 131: warning: don't use underscores in Go names; func Convert_networking_Ingress_To_v1beta1_Ingress should be ConvertNetworkingIngressToV1beta1Ingress (golint)
    • Line 135: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressBackend_To_networking_IngressBackend should be autoConvertV1beta1IngressBackendToNetworkingIngressBackend (golint)
    • Line 142: warning: don't use underscores in Go names; func autoConvert_networking_IngressBackend_To_v1beta1_IngressBackend should be autoConvertNetworkingIngressBackendToV1beta1IngressBackend (golint)
    • Line 148: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressClass_To_networking_IngressClass should be autoConvertV1beta1IngressClassToNetworkingIngressClass (golint)
    • Line 157: warning: don't use underscores in Go names; func Convert_v1beta1_IngressClass_To_networking_IngressClass should be ConvertV1beta1IngressClassToNetworkingIngressClass (golint)
    • Line 161: warning: don't use underscores in Go names; func autoConvert_networking_IngressClass_To_v1beta1_IngressClass should be autoConvertNetworkingIngressClassToV1beta1IngressClass (golint)
    • Line 170: warning: don't use underscores in Go names; func Convert_networking_IngressClass_To_v1beta1_IngressClass should be ConvertNetworkingIngressClassToV1beta1IngressClass (golint)
    • Line 174: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressClassList_To_networking_IngressClassList should be autoConvertV1beta1IngressClassListToNetworkingIngressClassList (golint)
    • Line 181: warning: don't use underscores in Go names; func Convert_v1beta1_IngressClassList_To_networking_IngressClassList should be ConvertV1beta1IngressClassListToNetworkingIngressClassList (golint)
    • Line 185: warning: don't use underscores in Go names; func autoConvert_networking_IngressClassList_To_v1beta1_IngressClassList should be autoConvertNetworkingIngressClassListToV1beta1IngressClassList (golint)
    • Line 192: warning: don't use underscores in Go names; func Convert_networking_IngressClassList_To_v1beta1_IngressClassList should be ConvertNetworkingIngressClassListToV1beta1IngressClassList (golint)
    • Line 196: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressClassSpec_To_networking_IngressClassSpec should be autoConvertV1beta1IngressClassSpecToNetworkingIngressClassSpec (golint)
    • Line 203: warning: don't use underscores in Go names; func Convert_v1beta1_IngressClassSpec_To_networking_IngressClassSpec should be ConvertV1beta1IngressClassSpecToNetworkingIngressClassSpec (golint)
    • Line 207: warning: don't use underscores in Go names; func autoConvert_networking_IngressClassSpec_To_v1beta1_IngressClassSpec should be autoConvertNetworkingIngressClassSpecToV1beta1IngressClassSpec (golint)
    • Line 214: warning: don't use underscores in Go names; func Convert_networking_IngressClassSpec_To_v1beta1_IngressClassSpec should be ConvertNetworkingIngressClassSpecToV1beta1IngressClassSpec (golint)
    • Line 218: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressList_To_networking_IngressList should be autoConvertV1beta1IngressListToNetworkingIngressList (golint)
    • Line 235: warning: don't use underscores in Go names; func Convert_v1beta1_IngressList_To_networking_IngressList should be ConvertV1beta1IngressListToNetworkingIngressList (golint)
    • Line 239: warning: don't use underscores in Go names; func autoConvert_networking_IngressList_To_v1beta1_IngressList should be autoConvertNetworkingIngressListToV1beta1IngressList (golint)
    • Line 256: warning: don't use underscores in Go names; func Convert_networking_IngressList_To_v1beta1_IngressList should be ConvertNetworkingIngressListToV1beta1IngressList (golint)
    • Line 260: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressRule_To_networking_IngressRule should be autoConvertV1beta1IngressRuleToNetworkingIngressRule (golint)
    • Line 269: warning: don't use underscores in Go names; func Convert_v1beta1_IngressRule_To_networking_IngressRule should be ConvertV1beta1IngressRuleToNetworkingIngressRule (golint)
    • Line 273: warning: don't use underscores in Go names; func autoConvert_networking_IngressRule_To_v1beta1_IngressRule should be autoConvertNetworkingIngressRuleToV1beta1IngressRule (golint)
    • Line 282: warning: don't use underscores in Go names; func Convert_networking_IngressRule_To_v1beta1_IngressRule should be ConvertNetworkingIngressRuleToV1beta1IngressRule (golint)
    • Line 286: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressRuleValue_To_networking_IngressRuleValue should be autoConvertV1beta1IngressRuleValueToNetworkingIngressRuleValue (golint)
    • Line 300: warning: don't use underscores in Go names; func Convert_v1beta1_IngressRuleValue_To_networking_IngressRuleValue should be ConvertV1beta1IngressRuleValueToNetworkingIngressRuleValue (golint)
    • Line 304: warning: don't use underscores in Go names; func autoConvert_networking_IngressRuleValue_To_v1beta1_IngressRuleValue should be autoConvertNetworkingIngressRuleValueToV1beta1IngressRuleValue (golint)
    • Line 318: warning: don't use underscores in Go names; func Convert_networking_IngressRuleValue_To_v1beta1_IngressRuleValue should be ConvertNetworkingIngressRuleValueToV1beta1IngressRuleValue (golint)
    • Line 322: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressSpec_To_networking_IngressSpec should be autoConvertV1beta1IngressSpecToNetworkingIngressSpec (golint)
    • Line 340: warning: don't use underscores in Go names; func autoConvert_networking_IngressSpec_To_v1beta1_IngressSpec should be autoConvertNetworkingIngressSpecToV1beta1IngressSpec (golint)
    • Line 358: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressStatus_To_networking_IngressStatus should be autoConvertV1beta1IngressStatusToNetworkingIngressStatus (golint)
    • Line 366: warning: don't use underscores in Go names; func Convert_v1beta1_IngressStatus_To_networking_IngressStatus should be ConvertV1beta1IngressStatusToNetworkingIngressStatus (golint)
    • Line 370: warning: don't use underscores in Go names; func autoConvert_networking_IngressStatus_To_v1beta1_IngressStatus should be autoConvertNetworkingIngressStatusToV1beta1IngressStatus (golint)
    • Line 378: warning: don't use underscores in Go names; func Convert_networking_IngressStatus_To_v1beta1_IngressStatus should be ConvertNetworkingIngressStatusToV1beta1IngressStatus (golint)
    • Line 382: warning: don't use underscores in Go names; func autoConvert_v1beta1_IngressTLS_To_networking_IngressTLS should be autoConvertV1beta1IngressTLSToNetworkingIngressTLS (golint)
    • Line 389: warning: don't use underscores in Go names; func Convert_v1beta1_IngressTLS_To_networking_IngressTLS should be ConvertV1beta1IngressTLSToNetworkingIngressTLS (golint)
    • Line 393: warning: don't use underscores in Go names; func autoConvert_networking_IngressTLS_To_v1beta1_IngressTLS should be autoConvertNetworkingIngressTLSToV1beta1IngressTLS (golint)
    • Line 400: warning: don't use underscores in Go names; func Convert_networking_IngressTLS_To_v1beta1_IngressTLS should be ConvertNetworkingIngressTLSToV1beta1IngressTLS (golint)
    • Line 408: warning: don't use underscores in Go names; func Convert_core_LoadBalancerStatus_To_v1_LoadBalancerStatus should be ConvertCoreLoadBalancerStatusToV1LoadBalancerStatus (golint)
    • Line 414: warning: don't use underscores in Go names; func Convert_v1_LoadBalancerStatus_To_core_LoadBalancerStatus should be ConvertV1LoadBalancerStatusToCoreLoadBalancerStatus (golint)
    • ingress-gce/pkg/utils/negdescription.go
    • Line 26: warning: comment on exported type NegDescription should be of the form "NegDescription ..." (with optional leading article) (golint)
    • Line 44: warning: comment on exported function NegDescriptionFromString should be of the form "NegDescriptionFromString ..." (golint)
    • ingress-gce/pkg/neg/types/network_endpoint.go
    • Line 117: warning: receiver name s1 should be consistent with previous receiver name s for NetworkEndpointSet (golint)
    • Line 133: warning: receiver name s1 should be consistent with previous receiver name s for NetworkEndpointSet (golint)
    • Line 155: warning: receiver name s1 should be consistent with previous receiver name s for NetworkEndpointSet (golint)
    • Line 167: warning: receiver name s1 should be consistent with previous receiver name s for NetworkEndpointSet (golint)
    • ingress-gce/pkg/events/events.go
    • Line 25: warning: exported const AddNodes should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported type RecorderProducer should have comment or be unexported (golint)
    • Line 40: warning: exported type RecorderProducerMock should have comment or be unexported (golint)
    • Line 43: warning: exported method RecorderProducerMock.Recorder should have comment or be unexported (golint)
    • Line 47: warning: comment on exported function GlobalEventf should be of the form "GlobalEventf ..." (golint)
    • Line 59: warning: comment on exported function TruncatedStringList should be of the form "TruncatedStringList ..." (golint)
    • ingress-gce/cmd/echo/app/flags.go
    • Line 25: warning: exported const DefaultCertLifeSpan should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported var F should have comment or be unexported (golint)
    • ingress-gce/pkg/neg/types/types.go
    • Line 35: warning: exported type NetworkEndpointType should have comment or be unexported (golint)
    • Line 36: warning: exported type EndpointsCalculatorMode should have comment or be unexported (golint)
    • Line 39: warning: exported const VmIpPortEndpointType should have comment (or a comment on this block) or be unexported (golint)
    • Line 54: warning: comment on exported const NegSyncSuccessful should be of the form "NegSyncSuccessful ..." (golint)
    • Line 60: warning: comment on exported const NegGCError should be of the form "NegGCError ..." (golint)
    • Line 75: warning: exported method SvcPortTuple.Empty should have comment or be unexported (golint)
    • Line 148: warning: exported function NewPortInfoMap should have comment or be unexported (golint)
    • Line 268: warning: exported method PortInfoMap.ToPortNegMap should have comment or be unexported (golint)
    • Line 276: warning: exported method PortInfoMap.ToPortSubsetNegMap should have comment or be unexported (golint)
    • ingress-gce/pkg/fuzz/default_validator_env.go
    • Line 88: warning: exported method DefaultValidatorEnv.FrontendConfigs should have comment or be unexported (golint)
    • Line 118: warning: comment on exported method DefaultValidatorEnv.BackendNamer should be of the form "BackendNamer ..." (golint)
    • Line 123: warning: comment on exported method DefaultValidatorEnv.FrontendNamerFactory should be of the form "FrontendNamerFactory ..." (golint)
    • ingress-gce/pkg/annotations/ingress.go
    • Line 63: warning: exported const GceIngressClass should have comment (or a comment on this block) or be unexported (golint)
    • Line 67: warning: comment on exported const ZoneKey should be of the form "ZoneKey ..." (golint)
    • Line 91: warning: comment on exported const RedirectUrlMapKey should be of the form "RedirectUrlMapKey ..." (golint)
    • Line 148: warning: exported method Ingress.StaticIPName should have comment or be unexported (golint)
    • Line 163: warning: exported method Ingress.GlobalStaticIPName should have comment or be unexported (golint)
    • Line 171: warning: exported method Ingress.RegionalStaticIPName should have comment or be unexported (golint)
    • Line 179: warning: exported method Ingress.IngressClass should have comment or be unexported (golint)
    • Line 201: warning: exported method Ingress.FrontendConfig should have comment or be unexported (golint)
    • ingress-gce/pkg/utils/utils.go
    • Line 82: warning: exported const L4ILBServiceDescKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 183: warning: exported function GetErrorType should have comment or be unexported (golint)
    • Line 365: warning: comment on exported function GetNodeConditionPredicate should be of the form "GetNodeConditionPredicate ..." (golint)
    • Line 482: warning: exported function ServiceKeyFunc should have comment or be unexported (golint)
    • Line 623: warning: exported function MakeL4ILBServiceDescription should have comment or be unexported (golint)
    • ingress-gce/pkg/loadbalancers/features/features.go
    • Line 17: warning: package comment should be of the form "Package features ..." (golint)
    • Line 28: warning: exported const FeatureL7ILB should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported var GAResourceVersions should have comment or be unexported (golint)
    • Line 70: warning: exported function NewResourceVersions should have comment or be unexported (golint)
    • Line 150: warning: comment on exported function ScopeFromIngress should be of the form "ScopeFromIngress ..." (golint)
    • ingress-gce/pkg/composite/gen.go
    • Line 3578: warning: exported function CreateAddress should have comment or be unexported (golint)
    • Line 3629: warning: exported function DeleteAddress should have comment or be unexported (golint)
    • Line 3665: warning: exported function GetAddress should have comment or be unexported (golint)
    • Line 3715: warning: exported function ListAddresses should have comment or be unexported (golint)
    • Line 3856: warning: exported function CreateBackendService should have comment or be unexported (golint)
    • Line 3907: warning: exported function UpdateBackendService should have comment or be unexported (golint)
    • Line 3954: warning: exported function DeleteBackendService should have comment or be unexported (golint)
    • Line 3990: warning: exported function GetBackendService should have comment or be unexported (golint)
    • Line 4037: warning: exported function ListBackendServices should have comment or be unexported (golint)
    • Line 4217: warning: exported function CreateForwardingRule should have comment or be unexported (golint)
    • Line 4268: warning: exported function DeleteForwardingRule should have comment or be unexported (golint)
    • Line 4304: warning: exported function GetForwardingRule should have comment or be unexported (golint)
    • Line 4354: warning: exported function ListForwardingRules should have comment or be unexported (golint)
    • Line 4495: warning: exported function CreateHealthCheck should have comment or be unexported (golint)
    • Line 4546: warning: exported function UpdateHealthCheck should have comment or be unexported (golint)
    • Line 4593: warning: exported function DeleteHealthCheck should have comment or be unexported (golint)
    • Line 4629: warning: exported function GetHealthCheck should have comment or be unexported (golint)
    • Line 4676: warning: exported function ListHealthChecks should have comment or be unexported (golint)
    • Line 4999: warning: exported function CreateNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 5034: warning: exported function DeleteNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 5057: warning: exported function GetNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 5093: warning: exported function ListNetworkEndpointGroups should have comment or be unexported (golint)
    • Line 5130: warning: exported function AttachNetworkEndpoints should have comment or be unexported (golint)
    • Line 5166: warning: exported function DetachNetworkEndpoints should have comment or be unexported (golint)
    • Line 5202: warning: exported function ListNetworkEndpoints should have comment or be unexported (golint)
    • Line 5253: warning: exported function AggregatedListNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 5771: warning: exported function CreateSslCertificate should have comment or be unexported (golint)
    • Line 5822: warning: exported function DeleteSslCertificate should have comment or be unexported (golint)
    • Line 5858: warning: exported function GetSslCertificate should have comment or be unexported (golint)
    • Line 5905: warning: exported function ListSslCertificates should have comment or be unexported (golint)
    • Line 6046: warning: exported function CreateTargetHttpProxy should have comment or be unexported (golint)
    • Line 6097: warning: exported function DeleteTargetHttpProxy should have comment or be unexported (golint)
    • Line 6133: warning: exported function GetTargetHttpProxy should have comment or be unexported (golint)
    • Line 6180: warning: exported function ListTargetHttpProxies should have comment or be unexported (golint)
    • Line 6321: warning: exported function CreateTargetHttpsProxy should have comment or be unexported (golint)
    • Line 6372: warning: exported function DeleteTargetHttpsProxy should have comment or be unexported (golint)
    • Line 6408: warning: exported function GetTargetHttpsProxy should have comment or be unexported (golint)
    • Line 6455: warning: exported function ListTargetHttpsProxies should have comment or be unexported (golint)
    • Line 6596: warning: exported function CreateUrlMap should have comment or be unexported (golint)
    • Line 6647: warning: exported function UpdateUrlMap should have comment or be unexported (golint)
    • Line 6694: warning: exported function DeleteUrlMap should have comment or be unexported (golint)
    • Line 6730: warning: exported function GetUrlMap should have comment or be unexported (golint)
    • Line 6777: warning: exported function ListUrlMaps should have comment or be unexported (golint)
    • ingress-gce/pkg/neg/metrics/metrics.go
    • Line 38: warning: exported const GCProcess should have comment (or a comment on this block) or be unexported (golint)
    • Line 69: warning: exported var NegOperationLatency should have comment or be unexported (golint)
    • Line 132: warning: exported function RegisterMetrics should have comment or be unexported (golint)
    • ingress-gce/pkg/loadbalancers/fakes.go
    • Line 27: warning: exported const FakeCertQuota should have comment or be unexported (golint)
    • Line 40: warning: exported function InsertGlobalForwardingRuleHook should have comment or be unexported (golint)
    • Line 47: warning: exported function InsertForwardingRuleHook should have comment or be unexported (golint)
    • ingress-gce/pkg/utils/namer/namer.go
    • Line 105: warning: exported const HTTPProtocol should have comment (or a comment on this block) or be unexported (golint)
    • Line 421: warning: comment on exported method Namer.RedirectUrlMap should be of the form "RedirectUrlMap ..." (golint)
    • Line 482: warning: receiver name namer should be consistent with previous receiver name n for Namer (golint)
    • ingress-gce/pkg/neg/readiness/interface.go
    • Line 47: warning: exported type NoopReflector should have comment or be unexported (golint)
    • Line 49: warning: exported method NoopReflector.Run should have comment or be unexported (golint)
    • Line 51: warning: exported method NoopReflector.SyncPod should have comment or be unexported (golint)
    • Line 53: warning: exported method NoopReflector.CommitPods should have comment or be unexported (golint)
    • ingress-gce/pkg/loadbalancers/l4.go
    • Line 45: warning: exported const SyncTypeCreate should have comment (or a comment on this block) or be unexported (golint)
    • Line 50: warning: comment on exported type L4 should be of the form "L4 ..." (with optional leading article) (golint)
    • Line 77: warning: exported var ILBResourceAnnotationKeys should have comment or be unexported (golint)
    • ingress-gce/pkg/test/utils.go
    • Line 27: warning: exported const FinalizerAddFlag should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported var BackendPort should have comment or be unexported (golint)
    • Line 215: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 235: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 258: warning: exported type FakeRecorderSource should have comment or be unexported (golint)
    • Line 260: warning: exported method FakeRecorderSource.Recorder should have comment or be unexported (golint)
    • Line 260: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 277: warning: comment on exported type L4ILBLatencyMetricInfo should be of the form "L4ILBLatencyMetricInfo ..." (with optional leading article) (golint)
    • ingress-gce/pkg/flags/flags.go
    • Line 104: warning: exported type LeaderElectionConfiguration should have comment or be unexported (golint)
    • Line 226: warning: exported type RateLimitSpecs should have comment or be unexported (golint)
    • Line 248: warning: exported method RateLimitSpecs.Values should have comment or be unexported (golint)
    • Line 252: warning: exported method RateLimitSpecs.Type should have comment or be unexported (golint)
    • Line 256: warning: exported type PortRanges should have comment or be unexported (golint)
    • Line 280: warning: comment on exported method PortRanges.Values should be of the form "Values ..." (golint)
    • Line 285: warning: exported method PortRanges.Type should have comment or be unexported (golint)
    • ingress-gce/pkg/e2e/fixtures.go
    • Line 58: warning: exported const ILBSubnetPurpose should have comment (or a comment on this block) or be unexported (golint)
    • Line 64: warning: exported type OS should have comment or be unexported (golint)
    • Line 67: warning: exported const Linux should have comment (or a comment on this block) or be unexported (golint)
    • Line 71: warning: exported var ErrSubnetExists should have comment or be unexported (golint)
    • Line 295: warning: comment on exported function EnsureFrontendConfig should be of the form "EnsureFrontendConfig ..." (golint)
    • ingress-gce/pkg/translator/translator.go
    • Line 284: warning: exported method Translator.ToCompositeTargetHttpProxy should have comment or be unexported (golint)
    • Line 299: warning: comment on exported method Translator.ToCompositeTargetHttpsProxy should be of the form "ToCompositeTargetHttpsProxy ..." (golint)
    • Line 332: warning: exported method Translator.ToCompositeSSLCertificates should have comment or be unexported (golint)
    • Line 398: warning: comment on exported function GetCertHash should be of the form "GetCertHash ..." (golint)
    • Line 403: warning: exported function ToTLSCerts should have comment or be unexported (golint)
    • ingress-gce/pkg/experimental/apis/workload/v1alpha1/types.go
    • Line 26: warning: comment on exported type Workload should be of the form "Workload ..." (with optional leading article) (golint)
    • Line 67: warning: exported const AddressTypeIPv4 should have comment (or a comment on this block) or be unexported (golint)
    • Line 95: warning: comment on exported type Condition should be of the form "Condition ..." (with optional leading article) (golint)
    • Line 125: warning: comment on exported type ConditionStatus should be of the form "ConditionStatus ..." (with optional leading article) (golint)
    • Line 129: warning: exported const ConditionStatusTrue should have comment (or a comment on this block) or be unexported (golint)
    • ingress-gce/pkg/composite/meta/meta.go
    • Line 56: warning: comment on exported var NoUpdate should be of the form "NoUpdate ..." (golint)
    • Line 70: warning: comment on exported var NoCRUD should be of the form "NoCRUD ..." (golint)
    • Line 83: warning: exported var Versions should have comment or be unexported (golint)
    • Line 89: warning: comment on exported var DefaultRegionalServices should be of the form "DefaultRegionalServices ..." (golint)
    • Line 97: warning: exported var DefaultZonalServices should have comment or be unexported (golint)
    • Line 101: warning: exported type GroupResourceInfo should have comment or be unexported (golint)
    • Line 147: warning: comment on exported method ApiService.IsMainService should be of the form "IsMainService ..." (golint)
    • Line 153: warning: comment on exported method ApiService.HasUpdate should be of the form "HasUpdate ..." (golint)
    • Line 158: warning: comment on exported method ApiService.HasCRUD should be of the form "HasCRUD ..." (golint)
    • Line 163: warning: exported method ApiService.IsDefaultRegionalService should have comment or be unexported (golint)
    • Line 167: warning: exported method ApiService.IsDefaultZonalService should have comment or be unexported (golint)
    • Line 171: warning: exported method ApiService.IsGroupResourceService should have comment or be unexported (golint)
    • Line 176: warning: exported method ApiService.GetGroupResourceInfo should have comment or be unexported (golint)
    • Line 183: warning: comment on exported method ApiService.GetCloudProviderName should be of the form "GetCloudProviderName ..." (golint)
    • Line 193: warning: exported var AllApiServices should have comment or be unexported (golint)
    • ingress-gce/pkg/neg/types/fakes.go
    • Line 32: warning: exported const TestZone1 should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: exported function NewFakeZoneGetter should have comment or be unexported (golint)
    • Line 71: warning: exported type FakeNetworkEndpointGroupCloud should have comment or be unexported (golint)
    • Line 79: warning: comment on exported function NewFakeNetworkEndpointGroupCloud should be of the form "NewFakeNetworkEndpointGroupCloud ..." (golint)
    • Line 89: warning: exported var NotFoundError should have comment or be unexported (golint)
    • Line 91: warning: exported method FakeNetworkEndpointGroupCloud.GetNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 109: warning: exported method FakeNetworkEndpointGroupCloud.ListNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 115: warning: exported method FakeNetworkEndpointGroupCloud.AggregatedListNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 127: warning: exported method FakeNetworkEndpointGroupCloud.CreateNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 139: warning: exported method FakeNetworkEndpointGroupCloud.DeleteNetworkEndpointGroup should have comment or be unexported (golint)
    • Line 160: warning: exported method FakeNetworkEndpointGroupCloud.AttachNetworkEndpoints should have comment or be unexported (golint)
    • Line 167: warning: exported method FakeNetworkEndpointGroupCloud.DetachNetworkEndpoints should have comment or be unexported (golint)
    • Line 188: warning: exported method FakeNetworkEndpointGroupCloud.ListNetworkEndpoints should have comment or be unexported (golint)
    • Line 202: warning: exported method FakeNetworkEndpointGroupCloud.NetworkURL should have comment or be unexported (golint)
    • Line 206: warning: exported method FakeNetworkEndpointGroupCloud.SubnetworkURL should have comment or be unexported (golint)
    • ingress-gce/pkg/neg/syncers/endpoints_calculator.go
    • Line 29: warning: comment on exported type LocalL4ILBEndpointsCalculator should be of the form "LocalL4ILBEndpointsCalculator ..." (with optional leading article) (golint)
    • Line 44: warning: exported function NewLocalL4ILBEndpointsCalculator should have comment or be unexported (golint)
    • Line 96: warning: comment on exported type ClusterL4ILBEndpointsCalculator should be of the form "ClusterL4ILBEndpointsCalculator ..." (with optional leading article) (golint)
    • Line 112: warning: exported function NewClusterL4ILBEndpointsCalculator should have comment or be unexported (golint)
    • Line 150: warning: exported function NewL7EndpointsCalculator should have comment or be unexported (golint)
    • ingress-gce/pkg/e2e/adapter/conversion.go
    • Line 30: warning: exported function Convert_v1beta1_IngressBackend_To_networking_IngressBackend should have comment or be unexported (golint)
    • Line 30: warning: don't use underscores in Go names; func Convert_v1beta1_IngressBackend_To_networking_IngressBackend should be ConvertV1beta1IngressBackendToNetworkingIngressBackend (golint)
    • Line 43: warning: exported function Convert_networking_IngressBackend_To_v1beta1_IngressBackend should have comment or be unexported (golint)
    • Line 43: warning: don't use underscores in Go names; func Convert_networking_IngressBackend_To_v1beta1_IngressBackend should be ConvertNetworkingIngressBackendToV1beta1IngressBackend (golint)
    • Line 57: warning: exported function Convert_v1beta1_IngressSpec_To_networking_IngressSpec should have comment or be unexported (golint)
    • Line 57: warning: don't use underscores in Go names; func Convert_v1beta1_IngressSpec_To_networking_IngressSpec should be ConvertV1beta1IngressSpecToNetworkingIngressSpec (golint)
    • Line 70: warning: exported function Convert_networking_IngressSpec_To_v1beta1_IngressSpec should have comment or be unexported (golint)
    • Line 70: warning: don't use underscores in Go names; func Convert_networking_IngressSpec_To_v1beta1_IngressSpec should be ConvertNetworkingIngressSpecToV1beta1IngressSpec (golint)
    • ingress-gce/pkg/fuzz/gcp.go
    • Line 40: warning: exported const NegResourceType should have comment (or a comment on this block) or be unexported (golint)
    • Line 392: warning: comment on exported method GCLB.CheckRedirectUrlMapDeletion should be of the form "CheckRedirectUrlMapDeletion ..." (golint)
    • Line 428: warning: exported type GCLBForVIPParams should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

misspell98%

Misspell Finds commonly misspelled English words