gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• kubevirt/pkg/virt-controller/watch/topology/nodetopologyupdater_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/cpu_plugin_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/kvm-caps-info-plugin_amd64.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/gpu/addresspool.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/device-manager/mediated_devices_types_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virtctl/ssh/resize_unix.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-launcher/virtwrap/converter/converter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/network/link/address_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/node_labeller_suite_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/device-manager/mediated_devices_types.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/generic/addresspool.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/vm.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/tests/framework/checks/checks.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/network/setup/network.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/kvm-caps-info-plugin_arm64.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/node_labeller.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-handler/node-labeller/node_labeller_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-launcher/virtwrap/api/deepcopy_generated.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virtctl/ssh/resize_windows.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/pkg/virt-controller/watch/migration_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kubevirt/tests/migration_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• kubevirt/pkg/virt-handler/container-disk/mount.go
  • Line 189: warning: cyclomatic complexity 21 of function (*mounter).MountAndVerify() is high (> 15) (gocyclo)
  • Line 376: warning: cyclomatic complexity 21 of function (*mounter).MountKernelArtifacts() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-config/config-map.go
  • Line 318: warning: cyclomatic complexity 51 of function setConfigFromConfigMap() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-handler/hotplug-disk/mount.go
  • Line 649: warning: cyclomatic complexity 17 of function (*volumeMounter).Unmount() is high (> 15) (gocyclo)
  • Line 306: warning: cyclomatic complexity 16 of function (*volumeMounter).mountBlockHotplugVolume() is high (> 15) (gocyclo)

• kubevirt/pkg/virtctl/imageupload/imageupload.go
  • Line 209: warning: cyclomatic complexity 25 of function (*command).run() is high (> 15) (gocyclo)

• kubevirt/tools/manifest-templator/manifest-templator.go
  • Line 73: warning: cyclomatic complexity 22 of function main() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/delete.go
  • Line 85: warning: cyclomatic complexity 113 of function DeleteAll() is high (> 15) (gocyclo)

• kubevirt/cmd/virt-launcher/virt-launcher.go
  • Line 340: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• kubevirt/pkg/network/dhcp/server/server.go
  • Line 95: warning: cyclomatic complexity 17 of function prepareDHCPOptions() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/vmi.go
  • Line 380: warning: cyclomatic complexity 67 of function (*VMIController).updateStatus() is high (> 15) (gocyclo)
  • Line 876: warning: cyclomatic complexity 25 of function (*VMIController).sync() is high (> 15) (gocyclo)
  • Line 1858: warning: cyclomatic complexity 20 of function (*VMIController).updateVolumeStatus() is high (> 15) (gocyclo)
  • Line 623: warning: cyclomatic complexity 18 of function preparePatch() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/replicaset.go
  • Line 145: warning: cyclomatic complexity 20 of function (*VMIReplicaSet).execute() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-launcher/virtwrap/api/deepcopy_generated.go
  • Line 633: warning: cyclomatic complexity 27 of function (*Devices).DeepCopyInto() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/apiservices.go
  • Line 29: warning: cyclomatic complexity 16 of function (*Reconciler).createOrUpdateAPIService() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/migration.go
  • Line 331: warning: cyclomatic complexity 50 of function (*MigrationController).updateStatus() is high (> 15) (gocyclo)
  • Line 794: warning: cyclomatic complexity 31 of function (*MigrationController).sync() is high (> 15) (gocyclo)

• kubevirt/cmd/virt-handler/virt-handler.go
  • Line 179: warning: cyclomatic complexity 29 of function (*virtHandlerApp).Run() is high (> 15) (gocyclo)

• kubevirt/pkg/network/infraconfigurators/masquerade.go
  • Line 343: warning: cyclomatic complexity 21 of function (*MasqueradePodNetworkConfigurator).createNatRulesUsingNftables() is high (> 15) (gocyclo)
  • Line 216: warning: cyclomatic complexity 16 of function (*MasqueradePodNetworkConfigurator).createNatRulesUsingIptables() is high (> 15) (gocyclo)

• kubevirt/pkg/virtctl/vm/vm.go
  • Line 335: warning: cyclomatic complexity 34 of function (*Command).Run() is high (> 15) (gocyclo)

• kubevirt/tools/marketplace/helper/bundleHelper.go
  • Line 77: warning: cyclomatic complexity 16 of function (*BundleHelper).downloadAndParseBundle() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/admissionregistration.go
  • Line 159: warning: cyclomatic complexity 16 of function (*Reconciler).createOrUpdateValidatingWebhookConfiguration() is high (> 15) (gocyclo)
  • Line 264: warning: cyclomatic complexity 16 of function (*Reconciler).createOrUpdateMutatingWebhookConfiguration() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/kubevirt_test.go
  • Line 763: warning: cyclomatic complexity 23 of function (*KubeVirtTestData).addResource() is high (> 15) (gocyclo)
  • Line 412: warning: cyclomatic complexity 22 of function (*KubeVirtTestData).deleteResource() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/reconcile.go
  • Line 659: warning: cyclomatic complexity 144 of function (*Reconciler).deleteObjectsNotInInstallStrategy() is high (> 15) (gocyclo)
  • Line 463: warning: cyclomatic complexity 32 of function (*Reconciler).Sync() is high (> 15) (gocyclo)
  • Line 116: warning: cyclomatic complexity 28 of function injectPlacementMetadata() is high (> 15) (gocyclo)

• kubevirt/pkg/monitoring/perfscale/vmi-phase-transitions.go
  • Line 35: warning: cyclomatic complexity 19 of function getTransitionTimeSeconds() is high (> 15) (gocyclo)

• kubevirt/pkg/util/openapi/openapi.go
  • Line 133: warning: cyclomatic complexity 17 of function LoadOpenAPISpec() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-launcher/notify-client/client.go
  • Line 233: warning: cyclomatic complexity 29 of function eventCallback() is high (> 15) (gocyclo)
  • Line 365: warning: cyclomatic complexity 25 of function (*Notifier).StartDomainNotifier() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/services/template.go
  • Line 448: warning: cyclomatic complexity 135 of function (*templateService).renderLaunchManifest() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/generate/install/strategy.go
  • Line 559: warning: cyclomatic complexity 45 of function loadInstallStrategyFromBytes() is high (> 15) (gocyclo)
  • Line 306: warning: cyclomatic complexity 18 of function dumpInstallStrategyToBytes() is high (> 15) (gocyclo)

• kubevirt/pkg/virtctl/vnc/vnc.go
  • Line 215: warning: cyclomatic complexity 18 of function checkAndRunVNCViewer() is high (> 15) (gocyclo)
  • Line 87: warning: cyclomatic complexity 17 of function (*VNC).Run() is high (> 15) (gocyclo)

• kubevirt/pkg/certificates/bootstrap/cert-manager.go
  • Line 101: warning: cyclomatic complexity 18 of function (*FileCertificateManager).Start() is high (> 15) (gocyclo)

• kubevirt/pkg/cloud-init/cloud-init.go
  • Line 525: warning: cyclomatic complexity 22 of function GenerateLocalData() is high (> 15) (gocyclo)
  • Line 182: warning: cyclomatic complexity 19 of function resolveConfigDriveSecrets() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/vm.go
  • Line 620: warning: cyclomatic complexity 37 of function (*VMController).startStop() is high (> 15) (gocyclo)
  • Line 1555: warning: cyclomatic complexity 31 of function (*VMController).updateStatus() is high (> 15) (gocyclo)
  • Line 194: warning: cyclomatic complexity 27 of function (*VMController).execute() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-handler/device-manager/pci_device.go
  • Line 243: warning: cyclomatic complexity 19 of function (*PCIDevicePlugin).healthCheck() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go
  • Line 356: warning: cyclomatic complexity 19 of function executeAgentCommands() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/snapshot/snapshot.go
  • Line 201: warning: cyclomatic complexity 34 of function (*VMSnapshotController).updateVMSnapshotContent() is high (> 15) (gocyclo)
  • Line 117: warning: cyclomatic complexity 25 of function (*VMSnapshotController).updateVMSnapshot() is high (> 15) (gocyclo)
  • Line 579: warning: cyclomatic complexity 19 of function (*VMSnapshotController).updateSnapshotStatus() is high (> 15) (gocyclo)
  • Line 764: warning: cyclomatic complexity 18 of function (*VMSnapshotController).getStorageClassNameForDV() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-launcher/virtwrap/access-credentials/access_credentials.go
  • Line 436: warning: cyclomatic complexity 35 of function (*AccessCredentialManager).watchSecrets() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-handler/vm.go
  • Line 1666: warning: cyclomatic complexity 50 of function (*VirtualMachineController).defaultExecute() is high (> 15) (gocyclo)
  • Line 863: warning: cyclomatic complexity 29 of function (*VirtualMachineController).updateInterfacesFromDomain() is high (> 15) (gocyclo)
  • Line 2601: warning: cyclomatic complexity 28 of function (*VirtualMachineController).vmUpdateHelperDefault() is high (> 15) (gocyclo)
  • Line 2497: warning: cyclomatic complexity 21 of function (*VirtualMachineController).vmUpdateHelperMigrationTarget() is high (> 15) (gocyclo)
  • Line 1847: warning: cyclomatic complexity 21 of function (*VirtualMachineController).execute() is high (> 15) (gocyclo)
  • Line 1062: warning: cyclomatic complexity 17 of function (*VirtualMachineController).updateGuestAgentConditions() is high (> 15) (gocyclo)
  • Line 1228: warning: cyclomatic complexity 16 of function (*VirtualMachineController).updateVMIStatus() is high (> 15) (gocyclo)
  • Line 1563: warning: cyclomatic complexity 16 of function (*VirtualMachineController).migrationTargetExecute() is high (> 15) (gocyclo)
  • Line 2753: warning: cyclomatic complexity 16 of function (*VirtualMachineController).calculateVmPhaseForStatusReason() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/rbacbackup.go
  • Line 13: warning: cyclomatic complexity 21 of function (*Reconciler).backupRBACs() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutators/preset.go
  • Line 69: warning: cyclomatic complexity 27 of function checkMergeConflicts() is high (> 15) (gocyclo)
  • Line 122: warning: cyclomatic complexity 26 of function mergeDomainSpec() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-api/rest/subresource.go
  • Line 396: warning: cyclomatic complexity 33 of function (*SubresourceAPIApp).StartVMRequestHandler() is high (> 15) (gocyclo)
  • Line 511: warning: cyclomatic complexity 23 of function (*SubresourceAPIApp).StopVMRequestHandler() is high (> 15) (gocyclo)
  • Line 263: warning: cyclomatic complexity 21 of function (*SubresourceAPIApp).RestartVMRequestHandler() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutators/vmi-mutator.go
  • Line 296: warning: cyclomatic complexity 23 of function (*VMIsMutator).setDefaultResourceRequests() is high (> 15) (gocyclo)
  • Line 51: warning: cyclomatic complexity 18 of function (*VMIsMutator).Mutate() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/snapshot/restore.go
  • Line 370: warning: cyclomatic complexity 29 of function (*vmRestoreTarget).Reconcile() is high (> 15) (gocyclo)
  • Line 222: warning: cyclomatic complexity 19 of function (*VMRestoreController).reconcileVolumeRestores() is high (> 15) (gocyclo)
  • Line 87: warning: cyclomatic complexity 17 of function (*VMRestoreController).updateVMRestore() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/util/types.go
  • Line 196: warning: cyclomatic complexity 20 of function (*Expectations).SatisfiedExpectations() is high (> 15) (gocyclo)
  • Line 57: warning: cyclomatic complexity 18 of function (*Stores).AllEmpty() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-launcher/virtwrap/manager.go
  • Line 687: warning: cyclomatic complexity 27 of function (*LibvirtDomainManager).SyncVMI() is high (> 15) (gocyclo)
  • Line 561: warning: cyclomatic complexity 24 of function (*LibvirtDomainManager).generateConverterContext() is high (> 15) (gocyclo)
  • Line 447: warning: cyclomatic complexity 22 of function (*LibvirtDomainManager).preStartHook() is high (> 15) (gocyclo)

• kubevirt/pkg/virtctl/expose/expose.go
  • Line 99: warning: cyclomatic complexity 39 of function (*Command).RunE() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-operator/resource/apply/rbac.go
  • Line 240: warning: cyclomatic complexity 25 of function changeRbacExistingByRequired() is high (> 15) (gocyclo)

• kubevirt/cmd/virt-chroot/main.go
  • Line 28: warning: cyclomatic complexity 23 of function main() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-controller/watch/workload-updater/workload-updater.go
  • Line 366: warning: cyclomatic complexity 25 of function (*WorkloadUpdateController).sync() is high (> 15) (gocyclo)

• kubevirt/tools/util/marshaller.go
  • Line 33: warning: cyclomatic complexity 28 of function MarshallObject() is high (> 15) (gocyclo)

• kubevirt/tests/utils.go
  • Line 314: warning: cyclomatic complexity 21 of function (*ObjectEventWatcher).Watch() is high (> 15) (gocyclo)
  • Line 1748: warning: cyclomatic complexity 20 of function cleanNamespaces() is high (> 15) (gocyclo)
  • Line 3596: warning: cyclomatic complexity 20 of function RunCommandPipeWithNS() is high (> 15) (gocyclo)

• kubevirt/pkg/virtctl/pause/pause.go
  • Line 100: warning: cyclomatic complexity 18 of function (*VirtCommand).Run() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-handler/device-manager/mediated_device.go
  • Line 343: warning: cyclomatic complexity 19 of function (*MediatedDevicePlugin).healthCheck() is high (> 15) (gocyclo)

• kubevirt/pkg/virt-handler/device-manager/generic_device.go
  • Line 293: warning: cyclomatic complexity 17 of function (*GenericDevicePlugin).healthCheck() is high (> 15) (gocyclo)

golint52%

Golint is a linter for Go source code.

• kubevirt/pkg/util/sysctl/sysctl.go
  • Line 30: warning: exported const NetIPv6Forwarding should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/pkg/virt-handler/heartbeat/heartbeat.go
  • Line 24: warning: exported type HeartBeat should have comment or be unexported (golint)
  • Line 34: warning: exported function NewHeartBeat should have comment or be unexported (golint)
  • Line 47: warning: exported method HeartBeat.Run should have comment or be unexported (golint)
  • Line 141: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kubevirt/pkg/virt-handler/device-manager/mediated_device_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-handler/device-manager/pci_device_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-api/rest/profiler.go
  • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 218: warning: exported method SubresourceAPIApp.StartClusterProfilerHandler should have comment or be unexported (golint)
  • Line 226: warning: exported method SubresourceAPIApp.StopClusterProfilerHandler should have comment or be unexported (golint)
  • Line 234: warning: exported method SubresourceAPIApp.DumpClusterProfilerHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/streamer.go
  • Line 24: warning: exported type Streamer should have comment or be unexported (golint)
  • Line 34: warning: exported function NewRawStreamer should have comment or be unexported (golint)
  • Line 50: warning: exported function NewWebsocketStreamer should have comment or be unexported (golint)
  • Line 67: warning: exported method Streamer.Handle should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/vmi-preset-admitter.go
  • Line 35: warning: exported type VMIPresetAdmitter should have comment or be unexported (golint)
  • Line 38: warning: exported method VMIPresetAdmitter.Admit should have comment or be unexported (golint)
  • Line 66: warning: exported function ValidateVMIPresetSpec should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/daemonsets.go
  • Line 20: warning: exported const VirtHandlerName should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported function NewHandlerDaemonSet should have comment or be unexported (golint)

• kubevirt/pkg/network/cache/infocache.go
  • Line 41: warning: exported type InterfaceCacheFactory should have comment or be unexported (golint)
  • Line 47: warning: exported function NewInterfaceCacheFactory should have comment or be unexported (golint)
  • Line 53: warning: exported function NewInterfaceCacheFactoryWithBasePath should have comment or be unexported (golint)
  • Line 75: warning: exported type DomainInterfaceStore should have comment or be unexported (golint)
  • Line 80: warning: exported type PodInterfaceCacheStore should have comment or be unexported (golint)
  • Line 86: warning: exported type DHCPConfigStore should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/api.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 91: warning: exported type VirtApi should have comment or be unexported (golint)
  • Line 138: warning: exported function NewVirtApi should have comment or be unexported (golint)
  • Line 1037: warning: don't use underscores in Go names; func error_guestfs should be errorGuestfs (golint)

• kubevirt/tests/libnet/expose_util.go
  • Line 8: warning: exported type Option should have comment or be unexported (golint)
  • Line 10: warning: exported function NewVMIExposeArgs should have comment or be unexported (golint)
  • Line 14: warning: exported function NewVMIRSExposeArgs should have comment or be unexported (golint)
  • Line 18: warning: exported function NewVMExposeArgs should have comment or be unexported (golint)
  • Line 22: warning: exported function NewExposeArgs should have comment or be unexported (golint)
  • Line 35: warning: exported function WithServiceName should have comment or be unexported (golint)
  • Line 41: warning: exported function WithPort should have comment or be unexported (golint)
  • Line 47: warning: exported function WithTargetPort should have comment or be unexported (golint)
  • Line 53: warning: exported function WithType should have comment or be unexported (golint)
  • Line 59: warning: exported function WithProtocol should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/webhooks/webhook.go
  • Line 17: warning: exported var KubeVirtGroupVersionResource should have comment or be unexported (golint)
  • Line 23: warning: exported function NewKubeVirtDeletionAdmitter should have comment or be unexported (golint)
  • Line 29: warning: exported type KubeVirtDeletionAdmitter should have comment or be unexported (golint)
  • Line 33: warning: exported method KubeVirtDeletionAdmitter.Admit should have comment or be unexported (golint)
  • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/virtctl/usbredir/usbredir.go
  • Line 41: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 154: warning: don't use underscores in Go names; var port_arg should be portArg (golint)

• kubevirt/tests/network/vmi_networking.go
  • Line 31: warning: should not use dot imports (golint)
  • Line 33: warning: should not use dot imports (golint)
  • Line 286: warning: don't use underscores in Go names; var virtio_vid should be virtioVid (golint)
  • Line 1017: warning: exported function NewRandomVMIWithInvalidNetworkInterface should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/hotplug-disk_suite_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-launcher/monitor.go
  • Line 37: warning: exported type OnShutdownCallback should have comment or be unexported (golint)
  • Line 38: warning: exported type OnGracefulShutdownCallback should have comment or be unexported (golint)
  • Line 52: warning: exported type ProcessMonitor should have comment or be unexported (golint)
  • Line 56: warning: exported function InitializePrivateDirectories should have comment or be unexported (golint)
  • Line 66: warning: exported function InitializeDisksDirectories should have comment or be unexported (golint)
  • Line 84: warning: exported function NewProcessMonitor should have comment or be unexported (golint)
  • Line 231: warning: exported function FindPid should have comment or be unexported (golint)

• kubevirt/pkg/controller/keys.go
  • Line 10: warning: exported var KeyFunc should have comment or be unexported (golint)
  • Line 13: warning: exported function NamespacedKey should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/nodetopologyupdater.go
  • Line 24: warning: exported type NodeTopologyUpdater should have comment or be unexported (golint)
  • Line 127: warning: exported function NewNodeTopologyUpdater should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/node-labeller/model.go
  • Line 58: warning: exported type SupportedHostFeature should have comment or be unexported (golint)
  • Line 62: warning: exported type HostFeature should have comment or be unexported (golint)
  • Line 79: warning: comment on exported type FeatureModel should be of the form "FeatureModel ..." (with optional leading article) (golint)
  • Line 84: warning: exported type Features should have comment or be unexported (golint)
  • Line 88: warning: exported type Feature should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/configuration/configuration.go
  • Line 16: warning: exported function NewListPermittedDevices should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/manager_test.go
  • Line 969: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1012: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1057: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1124: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1192: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1198: warning: don't use underscores in Go names; var fake_jobinfo_running should be fakeJobinfoRunning (golint)
  • Line 1267: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)
  • Line 1273: warning: don't use underscores in Go names; var fake_jobinfo_running should be fakeJobinfoRunning (golint)
  • Line 1362: warning: don't use underscores in Go names; var fake_jobinfo should be fakeJobinfo (golint)

• kubevirt/tools/analyzers/analyzer.go
  • Line 5: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• kubevirt/pkg/handler-launcher-com/notify/v1/version.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 21: warning: exported const NotifyVersion should have comment or be unexported (golint)

• kubevirt/pkg/hooks/info/info.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported const OnDefineDomainHookPointName should have comment or be unexported (golint)
  • Line 23: warning: exported const PreCloudInitIsoHookPointName should have comment or be unexported (golint)

• kubevirt/tests/storage/datavolume.go
  • Line 36: warning: should not use dot imports (golint)
  • Line 38: warning: should not use dot imports (golint)
  • Line 46: warning: should not use dot imports (golint)
  • Line 58: warning: exported const InvalidDataVolumeUrl should have comment or be unexported (golint)
  • Line 736: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/tests/libnet/skips.go
  • Line 4: warning: should not use dot imports (golint)
  • Line 5: warning: should not use dot imports (golint)
  • Line 10: warning: exported function SkipWhenNotDualStackCluster should have comment or be unexported (golint)

• kubevirt/tests/network/primary_pod_network.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-handler/device-manager/pci_device.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 44: warning: exported const PCI_RESOURCE_PREFIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type PCIDevice should have comment or be unexported (golint)
  • Line 55: warning: exported type PCIDevicePlugin should have comment or be unexported (golint)
  • Line 73: warning: exported function NewPCIDevicePlugin should have comment or be unexported (golint)
  • Line 164: warning: exported method PCIDevicePlugin.ListAndWatch should have comment or be unexported (golint)
  • Line 215: warning: exported method PCIDevicePlugin.Allocate should have comment or be unexported (golint)
  • Line 315: warning: exported method PCIDevicePlugin.GetDevicePath should have comment or be unexported (golint)
  • Line 319: warning: exported method PCIDevicePlugin.GetDeviceName should have comment or be unexported (golint)
  • Line 365: warning: exported method PCIDevicePlugin.GetDevicePluginOptions should have comment or be unexported (golint)
  • Line 372: warning: exported method PCIDevicePlugin.PreStartContainer should have comment or be unexported (golint)
  • Line 418: warning: exported method PCIDevicePlugin.GetInitialized should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/generic/hostdev.go
  • Line 31: warning: exported const AliasPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function CreateHostDevices should have comment or be unexported (golint)
  • Line 38: warning: exported function CreateHostDevicesFromPools should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/selinux/labels.go
  • Line 26: warning: exported var POLICY_FILES should have comment or be unexported (golint)
  • Line 28: warning: exported type SELinuxImpl should have comment or be unexported (golint)
  • Line 36: warning: exported function NewSELinux should have comment or be unexported (golint)
  • Line 54: warning: exported method SELinuxImpl.IsPresent should have comment or be unexported (golint)
  • Line 109: warning: exported method SELinuxImpl.IsPermissive should have comment or be unexported (golint)
  • Line 113: warning: exported method SELinuxImpl.Mode should have comment or be unexported (golint)
  • Line 142: warning: exported method SELinuxImpl.InstallPolicy should have comment or be unexported (golint)
  • Line 153: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 161: warning: exported type SELinux should have comment or be unexported (golint)
  • Line 167: warning: exported function RelabelFiles should have comment or be unexported (golint)
  • Line 178: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/util/cluster/cluster.go
  • Line 17: warning: exported const OpenShift3Major should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported function IsOnOpenShift should have comment or be unexported (golint)
  • Line 51: warning: exported function GetKubernetesVersion should have comment or be unexported (golint)
  • Line 74: warning: exported function GetOpenShiftMajorVersion should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/device_controller.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 39: warning: exported type DeviceControllerInterface should have comment or be unexported (golint)
  • Line 43: warning: exported type DeviceController should have comment or be unexported (golint)
  • Line 54: warning: exported type ControlledDevice should have comment or be unexported (golint)
  • Line 70: warning: exported function NewDeviceController should have comment or be unexported (golint)
  • Line 83: warning: exported method DeviceController.NodeHasDevice should have comment or be unexported (golint)
  • Line 240: warning: exported method DeviceController.Run should have comment or be unexported (golint)
  • Line 263: warning: exported method DeviceController.Initialized should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/notify-server/info.go
  • Line 1: warning: package comment should be of the form "Package eventsserver ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported type InfoServer should have comment or be unexported (golint)
  • Line 31: warning: exported method InfoServer.Info should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/node-labeller/node_labeller.go
  • Line 65: warning: exported function NewNodeLabeller should have comment or be unexported (golint)
  • Line 263: warning: should omit 2nd value from range; this loop is equivalent to `for feature := range ...` (golint)
  • Line 289: warning: exported method NodeLabeller.HostCapabilities should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/apiservices.go
  • Line 10: warning: exported function NewVirtAPIAPIServices should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/deployments.go
  • Line 1: warning: package comment should be of the form "Package components ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 41: warning: exported const VirtAPIName should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported function NewPrometheusService should have comment or be unexported (golint)
  • Line 83: warning: exported function NewApiServerService should have comment or be unexported (golint)
  • Line 263: warning: exported function NewApiServerDeployment should have comment or be unexported (golint)
  • Line 331: warning: exported function NewControllerDeployment should have comment or be unexported (golint)
  • Line 409: warning: comment on exported function NewOperatorDeployment should be of the form "NewOperatorDeployment ..." (golint)
  • Line 582: warning: exported function AddVersionSeparatorPrefix should have comment or be unexported (golint)
  • Line 594: warning: exported function NewPodDisruptionBudgetForDeployment should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/prometheus.go
  • Line 12: warning: exported const KUBEVIRT_PROMETHEUS_RULE_NAME should have comment or be unexported (golint)
  • Line 17: warning: exported function NewServiceMonitorCR should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/webhooks.go
  • Line 23: warning: exported function NewOperatorWebhookService should have comment or be unexported (golint)
  • Line 57: warning: exported function NewOpertorValidatingWebhookConfiguration should have comment or be unexported (golint)
  • Line 129: warning: exported function NewVirtAPIMutatingWebhookConfiguration should have comment or be unexported (golint)
  • Line 230: warning: exported function NewVirtAPIValidatingWebhookConfiguration should have comment or be unexported (golint)
  • Line 593: warning: exported const KubeVirtUpdateValidatePath should have comment or be unexported (golint)
  • Line 595: warning: exported const VMICreateValidatePath should have comment or be unexported (golint)
  • Line 597: warning: exported const VMIUpdateValidatePath should have comment or be unexported (golint)
  • Line 599: warning: exported const VMValidatePath should have comment or be unexported (golint)
  • Line 601: warning: exported const VMIRSValidatePath should have comment or be unexported (golint)
  • Line 603: warning: exported const VMIPresetValidatePath should have comment or be unexported (golint)
  • Line 605: warning: exported const MigrationCreateValidatePath should have comment or be unexported (golint)
  • Line 607: warning: exported const MigrationUpdateValidatePath should have comment or be unexported (golint)
  • Line 609: warning: exported const VMMutatePath should have comment or be unexported (golint)
  • Line 611: warning: exported const VMIMutatePath should have comment or be unexported (golint)
  • Line 613: warning: exported const MigrationMutatePath should have comment or be unexported (golint)
  • Line 615: warning: exported const VirtApiServiceName should have comment or be unexported (golint)
  • Line 617: warning: exported const VirtControllerServiceName should have comment or be unexported (golint)
  • Line 619: warning: exported const VirtHandlerServiceName should have comment or be unexported (golint)
  • Line 621: warning: exported const VirtAPIValidatingWebhookName should have comment or be unexported (golint)
  • Line 623: warning: exported const VirtOperatorServiceName should have comment or be unexported (golint)
  • Line 625: warning: exported const VirtAPIMutatingWebhookName should have comment or be unexported (golint)
  • Line 627: warning: exported const KubevirtOperatorWebhookServiceName should have comment or be unexported (golint)
  • Line 629: warning: exported const KubeVirtOperatorValidatingWebhookName should have comment or be unexported (golint)
  • Line 631: warning: exported const VMSnapshotValidatePath should have comment or be unexported (golint)
  • Line 633: warning: exported const VMRestoreValidatePath should have comment or be unexported (golint)
  • Line 635: warning: exported const VMFlavorValidatePath should have comment or be unexported (golint)
  • Line 637: warning: exported const VMClusterFlavorValidatePath should have comment or be unexported (golint)
  • Line 639: warning: exported const StatusValidatePath should have comment or be unexported (golint)
  • Line 641: warning: exported const LauncherEvictionValidatePath should have comment or be unexported (golint)

• kubevirt/pkg/handler-launcher-com/notify/info/generated_mock_info.go
  • Line 12: warning: comment on exported type MockNotifyInfoClient should be of the form "MockNotifyInfoClient ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockNotifyInfoClient should have comment or be unexported (golint)
  • Line 29: warning: exported method MockNotifyInfoClient.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockNotifyInfoClient.Info should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type MockNotifyInfoServer should be of the form "MockNotifyInfoServer ..." (with optional leading article) (golint)
  • Line 60: warning: exported function NewMockNotifyInfoServer should have comment or be unexported (golint)
  • Line 66: warning: exported method MockNotifyInfoServer.EXPECT should have comment or be unexported (golint)
  • Line 70: warning: exported method MockNotifyInfoServer.Info should have comment or be unexported (golint)

• kubevirt/pkg/inotify-informer/inotify.go
  • Line 55: warning: exported function NewFileListWatchFromClient should have comment or be unexported (golint)
  • Line 64: warning: exported type DirectoryListWatcher should have comment or be unexported (golint)
  • Line 155: warning: exported method DirectoryListWatcher.List should have comment or be unexported (golint)
  • Line 188: warning: exported method DirectoryListWatcher.Watch should have comment or be unexported (golint)
  • Line 192: warning: exported method DirectoryListWatcher.Stop should have comment or be unexported (golint)
  • Line 204: warning: exported method DirectoryListWatcher.ResultChan should have comment or be unexported (golint)

• kubevirt/tests/network/vmi_istio.go
  • Line 31: warning: should not use dot imports (golint)
  • Line 33: warning: should not use dot imports (golint)

• kubevirt/tools/perfscale-load-generator/flags/flags.go
  • Line 30: warning: exported var Kubeconfig should have comment or be unexported (golint)

• kubevirt/tests/network/networkpolicy.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• kubevirt/tests/libvmi/status.go
  • Line 15: warning: exported function GetPodByVirtualMachineInstance should have comment or be unexported (golint)
  • Line 43: warning: exported function IndexInterfaceStatusByName should have comment or be unexported (golint)

• kubevirt/pkg/hotplug-disk/hotplug-disk.go
  • Line 38: warning: comment on exported var TargetPodBasePath should be of the form "TargetPodBasePath ..." (golint)
  • Line 44: warning: exported type HotplugDiskManagerInterface should have comment or be unexported (golint)
  • Line 49: warning: exported function NewHotplugDiskManager should have comment or be unexported (golint)
  • Line 56: warning: exported function NewHotplugDiskWithOptions should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/node-labeller/api/capabilities.go
  • Line 12: warning: exported type CPUSiblings should have comment or be unexported (golint)
  • Line 14: warning: exported type Capabilities should have comment or be unexported (golint)
  • Line 19: warning: exported type Host should have comment or be unexported (golint)
  • Line 25: warning: exported type HostCPU should have comment or be unexported (golint)
  • Line 32: warning: exported type Counter should have comment or be unexported (golint)
  • Line 38: warning: exported type CPU should have comment or be unexported (golint)
  • Line 46: warning: exported type CPUs should have comment or be unexported (golint)
  • Line 51: warning: exported type Distances should have comment or be unexported (golint)
  • Line 55: warning: exported type Sibling should have comment or be unexported (golint)
  • Line 60: warning: exported type Pages should have comment or be unexported (golint)
  • Line 66: warning: exported type Memory should have comment or be unexported (golint)
  • Line 71: warning: exported type Cell should have comment or be unexported (golint)
  • Line 79: warning: exported type Cells should have comment or be unexported (golint)
  • Line 84: warning: exported type Topology should have comment or be unexported (golint)
  • Line 88: warning: exported method Capabilities.GetTSCCounter should have comment or be unexported (golint)
  • Line 108: warning: exported method CPUSiblings.UnmarshalXMLAttr should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/vm_test.go
  • Line 2244: warning: don't use underscores in Go names; var interface_name should be interfaceName (golint)
  • Line 2317: warning: don't use underscores in Go names; var interface_name should be interfaceName (golint)
  • Line 2340: warning: don't use underscores in Go names; var interface_name should be interfaceName (golint)
  • Line 2572: warning: don't use underscores in Go names; var interface_name should be interfaceName (golint)
  • Line 2586: warning: don't use underscores in Go names; var new_MAC should be newMAC (golint)
  • Line 2743: warning: don't use underscores in Go names; var old_interface_name should be oldInterfaceName (golint)
  • Line 2744: warning: don't use underscores in Go names; var old_MAC should be oldMAC (golint)
  • Line 2758: warning: don't use underscores in Go names; var new_interface_name should be newInterfaceName (golint)
  • Line 2759: warning: don't use underscores in Go names; var new_MAC should be newMAC (golint)
  • Line 2793: warning: don't use underscores in Go names; var interface_name should be interfaceName (golint)
  • Line 2806: warning: don't use underscores in Go names; var new_MAC should be newMAC (golint)

• kubevirt/tests/realtime/realtime.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)

• kubevirt/pkg/monitoring/domainstats/collector.go
  • Line 31: warning: exported const CollectionTimeout should have comment or be unexported (golint)
  • Line 32: warning: exported const StatsMaxAge should have comment or be unexported (golint)
  • Line 36: warning: exported type Collector should have comment or be unexported (golint)
  • Line 41: warning: exported type ConcurrentCollector should have comment or be unexported (golint)
  • Line 48: warning: exported function NewConcurrentCollector should have comment or be unexported (golint)
  • Line 56: warning: exported method ConcurrentCollector.Collect should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/cmd-client/client.go
  • Line 66: warning: exported const StandardLauncherSocketFileName should have comment or be unexported (golint)
  • Line 67: warning: exported const StandardInitLauncherSocketFileName should have comment or be unexported (golint)
  • Line 68: warning: exported const StandardLauncherUnresponsiveFileName should have comment or be unexported (golint)
  • Line 70: warning: exported type MigrationOptions should have comment or be unexported (golint)
  • Line 79: warning: exported type LauncherClient should have comment or be unexported (golint)
  • Line 104: warning: exported type VirtLauncherClient should have comment or be unexported (golint)
  • Line 114: warning: exported function SetLegacyBaseDir should have comment or be unexported (golint)
  • Line 118: warning: exported function SetPodsBaseDir should have comment or be unexported (golint)
  • Line 122: warning: exported function ListAllSockets should have comment or be unexported (golint)
  • Line 175: warning: exported function LegacySocketsDirectory should have comment or be unexported (golint)
  • Line 179: warning: exported function IsLegacySocket should have comment or be unexported (golint)
  • Line 187: warning: exported function SocketMonitoringEnabled should have comment or be unexported (golint)
  • Line 194: warning: exported function IsSocketUnresponsive should have comment or be unexported (golint)
  • Line 212: warning: exported function MarkSocketUnresponsive should have comment or be unexported (golint)
  • Line 222: warning: exported function SocketDirectoryOnHost should have comment or be unexported (golint)
  • Line 226: warning: exported function SocketFilePathOnHost should have comment or be unexported (golint)
  • Line 230: warning: comment on exported function FindPodDirOnHost should be of the form "FindPodDirOnHost ..." (golint)
  • Line 249: warning: comment on exported function FindSocketOnHost should be of the form "FindSocketOnHost ..." (golint)
  • Line 285: warning: exported function SocketOnGuest should have comment or be unexported (golint)
  • Line 290: warning: exported function UninitializedSocketOnGuest should have comment or be unexported (golint)
  • Line 295: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 308: warning: exported function NewClientWithInfoClient should have comment or be unexported (golint)
  • Line 336: warning: exported method VirtLauncherClient.Close should have comment or be unexported (golint)
  • Line 376: warning: exported function IsDisconnected should have comment or be unexported (golint)
  • Line 409: warning: exported method VirtLauncherClient.SyncVirtualMachine should have comment or be unexported (golint)
  • Line 413: warning: exported method VirtLauncherClient.PauseVirtualMachine should have comment or be unexported (golint)
  • Line 417: warning: exported method VirtLauncherClient.UnpauseVirtualMachine should have comment or be unexported (golint)
  • Line 421: warning: exported method VirtLauncherClient.FreezeVirtualMachine should have comment or be unexported (golint)
  • Line 442: warning: exported method VirtLauncherClient.UnfreezeVirtualMachine should have comment or be unexported (golint)
  • Line 446: warning: exported method VirtLauncherClient.ShutdownVirtualMachine should have comment or be unexported (golint)
  • Line 450: warning: exported method VirtLauncherClient.KillVirtualMachine should have comment or be unexported (golint)
  • Line 454: warning: exported method VirtLauncherClient.DeleteDomain should have comment or be unexported (golint)
  • Line 458: warning: exported method VirtLauncherClient.MigrateVirtualMachine should have comment or be unexported (golint)
  • Line 486: warning: exported method VirtLauncherClient.CancelVirtualMachineMigration should have comment or be unexported (golint)
  • Line 490: warning: exported method VirtLauncherClient.SyncMigrationTarget should have comment or be unexported (golint)
  • Line 494: warning: exported method VirtLauncherClient.SignalTargetPodCleanup should have comment or be unexported (golint)
  • Line 498: warning: exported method VirtLauncherClient.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 502: warning: exported method VirtLauncherClient.GetDomain should have comment or be unexported (golint)
  • Line 531: warning: exported method VirtLauncherClient.GetDomainStats should have comment or be unexported (golint)
  • Line 559: warning: exported method VirtLauncherClient.Ping should have comment or be unexported (golint)
  • Line 690: warning: exported method VirtLauncherClient.GuestPing should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/container-disk/mount.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 40: warning: exported type Mounter should have comment or be unexported (golint)
  • Line 57: warning: exported function NewMounter should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/kubevirt_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-controller/leaderelectionconfig/config.go
  • Line 31: warning: exported const DefaultLeaseDuration should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported function DefaultLeaderElectionConfiguration should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/api/schema.go
  • Line 45: warning: exported type LifeCycle should have comment or be unexported (golint)
  • Line 46: warning: exported type StateChangeReason should have comment or be unexported (golint)
  • Line 49: warning: exported const NoState should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: comment on exported const ReasonUnknown should be of the form "ReasonUnknown ..." (golint)
  • Line 61: warning: comment on exported const ReasonUser should be of the form "ReasonUser ..." (golint)
  • Line 64: warning: comment on exported const ReasonShutdown should be of the form "ReasonShutdown ..." (golint)
  • Line 74: warning: comment on exported const ReasonNonExistent should be of the form "ReasonNonExistent ..." (golint)
  • Line 77: warning: comment on exported const ReasonPausedUnknown should be of the form "ReasonPausedUnknown ..." (golint)
  • Line 100: warning: comment on exported type Domain should be of the form "Domain ..." (with optional leading article) (golint)
  • Line 108: warning: exported type DomainStatus should have comment or be unexported (golint)
  • Line 116: warning: exported type DomainSysInfo should have comment or be unexported (golint)
  • Line 122: warning: exported type GuestOSInfo should have comment or be unexported (golint)
  • Line 133: warning: exported type InterfaceStatus should have comment or be unexported (golint)
  • Line 141: warning: exported type Timezone should have comment or be unexported (golint)
  • Line 146: warning: exported type FSFreeze should have comment or be unexported (golint)
  • Line 150: warning: exported type Filesystem should have comment or be unexported (golint)
  • Line 158: warning: exported type User should have comment or be unexported (golint)
  • Line 171: warning: comment on exported type DomainList should be of the form "DomainList ..." (with optional leading article) (golint)
  • Line 204: warning: exported type CPUTune should have comment or be unexported (golint)
  • Line 211: warning: exported type NUMATune should have comment or be unexported (golint)
  • Line 216: warning: exported type MemNode should have comment or be unexported (golint)
  • Line 222: warning: exported type NumaTuneMemory should have comment or be unexported (golint)
  • Line 227: warning: exported type CPUTuneVCPUPin should have comment or be unexported (golint)
  • Line 232: warning: exported type CPUTuneIOThreadPin should have comment or be unexported (golint)
  • Line 237: warning: exported type CPUEmulatorPin should have comment or be unexported (golint)
  • Line 241: warning: exported type VCPUScheduler should have comment or be unexported (golint)
  • Line 247: warning: exported type VCPU should have comment or be unexported (golint)
  • Line 252: warning: exported type CPU should have comment or be unexported (golint)
  • Line 260: warning: exported type NUMA should have comment or be unexported (golint)
  • Line 264: warning: exported type NUMACell should have comment or be unexported (golint)
  • Line 272: warning: exported type CPUFeature should have comment or be unexported (golint)
  • Line 277: warning: exported type CPUTopology should have comment or be unexported (golint)
  • Line 283: warning: exported type Features should have comment or be unexported (golint)
  • Line 293: warning: exported type FeatureHyperv should have comment or be unexported (golint)
  • Line 310: warning: exported type FeatureSpinlocks should have comment or be unexported (golint)
  • Line 315: warning: exported type SyNICTimer should have comment or be unexported (golint)
  • Line 320: warning: exported type FeaturePVSpinlock should have comment or be unexported (golint)
  • Line 324: warning: exported type FeatureVendorID should have comment or be unexported (golint)
  • Line 329: warning: exported type FeatureEnabled should have comment or be unexported (golint)
  • Line 332: warning: exported type FeatureState should have comment or be unexported (golint)
  • Line 336: warning: exported type FeatureKVM should have comment or be unexported (golint)
  • Line 340: warning: exported type Metadata should have comment or be unexported (golint)
  • Line 346: warning: exported type KubeVirtMetadata should have comment or be unexported (golint)
  • Line 353: warning: exported type AccessCredentialMetadata should have comment or be unexported (golint)
  • Line 358: warning: exported type MigrationMetadata should have comment or be unexported (golint)
  • Line 369: warning: exported type GracePeriodMetadata should have comment or be unexported (golint)
  • Line 375: warning: exported type Commandline should have comment or be unexported (golint)
  • Line 380: warning: exported type Env should have comment or be unexported (golint)
  • Line 385: warning: exported type Arg should have comment or be unexported (golint)
  • Line 389: warning: exported type Resource should have comment or be unexported (golint)
  • Line 393: warning: exported type Memory should have comment or be unexported (golint)
  • Line 407: warning: exported type MemoryAllocationMode should have comment or be unexported (golint)
  • Line 410: warning: exported const MemoryAllocationModeImmediate should have comment (or a comment on this block) or be unexported (golint)
  • Line 413: warning: exported type MemoryAllocation should have comment or be unexported (golint)
  • Line 417: warning: exported type MemoryBackingSource should have comment or be unexported (golint)
  • Line 433: warning: exported type MemoryBackingAccess should have comment or be unexported (golint)
  • Line 437: warning: exported type NoSharePages should have comment or be unexported (golint)
  • Line 440: warning: exported type Devices should have comment or be unexported (golint)
  • Line 467: warning: exported type RedirectedDeviceSource should have comment or be unexported (golint)
  • Line 472: warning: exported type FilesystemDevice should have comment or be unexported (golint)
  • Line 481: warning: exported type FilesystemTarget should have comment or be unexported (golint)
  • Line 485: warning: exported type FilesystemSource should have comment or be unexported (golint)
  • Line 489: warning: exported type FilesystemDriver should have comment or be unexported (golint)
  • Line 494: warning: exported type FilesystemBinary should have comment or be unexported (golint)
  • Line 501: warning: exported type FilesystemBinaryCache should have comment or be unexported (golint)
  • Line 505: warning: exported type FilesystemBinaryLock should have comment or be unexported (golint)
  • Line 519: warning: comment on exported type HostDevice should be of the form "HostDevice ..." (with optional leading article) (golint)
  • Line 532: warning: exported type HostDeviceSource should have comment or be unexported (golint)
  • Line 552: warning: comment on exported type ControllerDriver should be of the form "ControllerDriver ..." (with optional leading article) (golint)
  • Line 562: warning: exported type Disk should have comment or be unexported (golint)
  • Line 580: warning: exported type DiskAuth should have comment or be unexported (golint)
  • Line 585: warning: exported type DiskSecret should have comment or be unexported (golint)
  • Line 591: warning: exported type ReadOnly should have comment or be unexported (golint)
  • Line 593: warning: exported type DiskSource should have comment or be unexported (golint)
  • Line 602: warning: exported type DiskTarget should have comment or be unexported (golint)
  • Line 608: warning: exported type DiskDriver should have comment or be unexported (golint)
  • Line 619: warning: exported type DiskSourceHost should have comment or be unexported (golint)
  • Line 624: warning: exported type BackingStore should have comment or be unexported (golint)
  • Line 630: warning: exported type BackingStoreFormat should have comment or be unexported (golint)
  • Line 634: warning: exported type BlockIO should have comment or be unexported (golint)
  • Line 643: warning: exported type Serial should have comment or be unexported (golint)
  • Line 650: warning: exported type SerialTarget should have comment or be unexported (golint)
  • Line 654: warning: exported type SerialSource should have comment or be unexported (golint)
  • Line 663: warning: exported type Console should have comment or be unexported (golint)
  • Line 670: warning: exported type ConsoleTarget should have comment or be unexported (golint)
  • Line 675: warning: exported type ConsoleSource should have comment or be unexported (golint)
  • Line 684: warning: exported type Interface should have comment or be unexported (golint)
  • Line 702: warning: exported type InterfaceDriver should have comment or be unexported (golint)
  • Line 707: warning: exported type LinkState should have comment or be unexported (golint)
  • Line 711: warning: exported type BandWidth should have comment or be unexported (golint)
  • Line 714: warning: exported type BootOrder should have comment or be unexported (golint)
  • Line 718: warning: exported type MAC should have comment or be unexported (golint)
  • Line 722: warning: exported type MTU should have comment or be unexported (golint)
  • Line 726: warning: exported type FilterRef should have comment or be unexported (golint)
  • Line 730: warning: exported type InterfaceSource should have comment or be unexported (golint)
  • Line 738: warning: exported type Model should have comment or be unexported (golint)
  • Line 742: warning: exported type InterfaceTarget should have comment or be unexported (golint)
  • Line 747: warning: exported type Alias should have comment or be unexported (golint)
  • Line 758: warning: exported type Rom should have comment or be unexported (golint)
  • Line 762: warning: exported function NewUserDefinedAlias should have comment or be unexported (golint)
  • Line 766: warning: exported method Alias.GetName should have comment or be unexported (golint)
  • Line 770: warning: exported method Alias.IsUserDefined should have comment or be unexported (golint)
  • Line 774: warning: exported method Alias.MarshalXML should have comment or be unexported (golint)
  • Line 782: warning: exported method Alias.UnmarshalXML should have comment or be unexported (golint)
  • Line 796: warning: exported method Alias.MarshalJSON should have comment or be unexported (golint)
  • Line 801: warning: exported method Alias.UnmarshalJSON should have comment or be unexported (golint)
  • Line 813: warning: exported type OS should have comment or be unexported (golint)
  • Line 826: warning: exported type OSType should have comment or be unexported (golint)
  • Line 832: warning: exported type SMBios should have comment or be unexported (golint)
  • Line 836: warning: exported type NVRam should have comment or be unexported (golint)
  • Line 841: warning: exported type Boot should have comment or be unexported (golint)
  • Line 845: warning: exported type BootMenu should have comment or be unexported (golint)
  • Line 850: warning: exported type Loader should have comment or be unexported (golint)
  • Line 857: warning: comment on exported type BIOS should be of the form "BIOS ..." (with optional leading article) (golint)
  • Line 862: warning: exported type SysInfo should have comment or be unexported (golint)
  • Line 870: warning: exported type Entry should have comment or be unexported (golint)
  • Line 879: warning: exported type Clock should have comment or be unexported (golint)
  • Line 886: warning: exported type Timer should have comment or be unexported (golint)
  • Line 898: warning: exported type Channel should have comment or be unexported (golint)
  • Line 904: warning: exported type ChannelTarget should have comment or be unexported (golint)
  • Line 912: warning: exported type ChannelSource should have comment or be unexported (golint)
  • Line 921: warning: exported type Video should have comment or be unexported (golint)
  • Line 925: warning: exported type VideoModel should have comment or be unexported (golint)
  • Line 933: warning: exported type Graphics should have comment or be unexported (golint)
  • Line 943: warning: exported type GraphicsListen should have comment or be unexported (golint)
  • Line 950: warning: exported type Address should have comment or be unexported (golint)
  • Line 964: warning: exported type Stats should have comment or be unexported (golint)
  • Line 968: warning: exported type MemBalloon should have comment or be unexported (golint)
  • Line 974: warning: exported type Watchdog should have comment or be unexported (golint)
  • Line 1006: warning: exported type IOThreads should have comment or be unexported (golint)
  • Line 1012: warning: exported type SecretUsage should have comment or be unexported (golint)
  • Line 1017: warning: exported type SecretSpec should have comment or be unexported (golint)
  • Line 1025: warning: exported function NewMinimalDomainSpec should have comment or be unexported (golint)
  • Line 1034: warning: exported function NewMinimalDomain should have comment or be unexported (golint)
  • Line 1038: warning: exported function NewMinimalDomainWithUUID should have comment or be unexported (golint)
  • Line 1048: warning: exported function NewMinimalDomainWithNS should have comment or be unexported (golint)
  • Line 1054: warning: exported function NewDomainReferenceFromName should have comment or be unexported (golint)
  • Line 1069: warning: exported method Domain.SetState should have comment or be unexported (golint)
  • Line 1074: warning: comment on exported method Domain.GetObjectKind should be of the form "GetObjectKind ..." (golint)
  • Line 1079: warning: comment on exported method Domain.GetObjectMeta should be of the form "GetObjectMeta ..." (golint)
  • Line 1084: warning: comment on exported method DomainList.GetObjectKind should be of the form "GetObjectKind ..." (golint)
  • Line 1089: warning: comment on exported method DomainList.GetListMeta should be of the form "GetListMeta ..." (golint)

• kubevirt/pkg/virt-launcher/virtwrap/util/cpu_utils.go
  • Line 32: warning: exported function GetPodCPUSet should have comment or be unexported (golint)

• kubevirt/tools/marketplace/main.go
  • Line 1: warning: package comment should not have leading space (golint)

• kubevirt/pkg/handler-launcher-com/cmd/info/generated_mock_info.go
  • Line 12: warning: comment on exported type MockCmdInfoClient should be of the form "MockCmdInfoClient ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockCmdInfoClient should have comment or be unexported (golint)
  • Line 29: warning: exported method MockCmdInfoClient.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockCmdInfoClient.Info should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type MockCmdInfoServer should be of the form "MockCmdInfoServer ..." (with optional leading article) (golint)
  • Line 60: warning: exported function NewMockCmdInfoServer should have comment or be unexported (golint)
  • Line 66: warning: exported method MockCmdInfoServer.EXPECT should have comment or be unexported (golint)
  • Line 70: warning: exported method MockCmdInfoServer.Info should have comment or be unexported (golint)

• kubevirt/pkg/network/driver/common.go
  • Line 52: warning: exported const LibvirtUserAndGroupId should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported type NetworkHandler should have comment or be unexported (golint)
  • Line 89: warning: exported type NetworkUtilsHandler should have comment or be unexported (golint)
  • Line 91: warning: exported method NetworkUtilsHandler.LinkByName should have comment or be unexported (golint)
  • Line 94: warning: exported method NetworkUtilsHandler.AddrList should have comment or be unexported (golint)
  • Line 97: warning: exported method NetworkUtilsHandler.RouteList should have comment or be unexported (golint)
  • Line 100: warning: exported method NetworkUtilsHandler.AddrReplace should have comment or be unexported (golint)
  • Line 103: warning: exported method NetworkUtilsHandler.AddrDel should have comment or be unexported (golint)
  • Line 106: warning: exported method NetworkUtilsHandler.LinkSetDown should have comment or be unexported (golint)
  • Line 109: warning: exported method NetworkUtilsHandler.LinkSetUp should have comment or be unexported (golint)
  • Line 112: warning: exported method NetworkUtilsHandler.LinkSetName should have comment or be unexported (golint)
  • Line 115: warning: exported method NetworkUtilsHandler.LinkAdd should have comment or be unexported (golint)
  • Line 118: warning: exported method NetworkUtilsHandler.LinkSetLearningOff should have comment or be unexported (golint)
  • Line 121: warning: exported method NetworkUtilsHandler.ParseAddr should have comment or be unexported (golint)
  • Line 124: warning: exported method NetworkUtilsHandler.AddrAdd should have comment or be unexported (golint)
  • Line 127: warning: exported method NetworkUtilsHandler.LinkSetMaster should have comment or be unexported (golint)
  • Line 130: warning: exported method NetworkUtilsHandler.HasNatIptables should have comment or be unexported (golint)
  • Line 146: warning: exported method NetworkUtilsHandler.ConfigureIpv4ArpIgnore should have comment or be unexported (golint)
  • Line 151: warning: exported method NetworkUtilsHandler.ConfigureIpForwarding should have comment or be unexported (golint)
  • Line 163: warning: exported method NetworkUtilsHandler.IsIpv6Enabled should have comment or be unexported (golint)
  • Line 181: warning: exported method NetworkUtilsHandler.IsIpv4Primary should have comment or be unexported (golint)
  • Line 190: warning: exported method NetworkUtilsHandler.IptablesNewChain should have comment or be unexported (golint)
  • Line 199: warning: exported method NetworkUtilsHandler.IptablesAppendRule should have comment or be unexported (golint)
  • Line 208: warning: exported method NetworkUtilsHandler.NftablesNewChain should have comment or be unexported (golint)
  • Line 218: warning: exported method NetworkUtilsHandler.NftablesAppendRule should have comment or be unexported (golint)
  • Line 229: warning: exported method NetworkUtilsHandler.GetNFTIPString should have comment or be unexported (golint)
  • Line 236: warning: exported method NetworkUtilsHandler.NftablesLoad should have comment or be unexported (golint)
  • Line 261: warning: exported method NetworkUtilsHandler.ReadIPAddressesFromLink should have comment or be unexported (golint)
  • Line 339: warning: exported method NetworkUtilsHandler.StartDHCP should have comment or be unexported (golint)
  • Line 382: warning: exported method NetworkUtilsHandler.CreateTapDevice should have comment or be unexported (golint)
  • Line 409: warning: exported method NetworkUtilsHandler.BindTapDeviceToBridge should have comment or be unexported (golint)
  • Line 434: warning: exported method NetworkUtilsHandler.DisableTXOffloadChecksum should have comment or be unexported (golint)
  • Line 443: warning: comment on exported var DHCPServer should be of the form "DHCPServer ..." (golint)
  • Line 445: warning: exported var DHCPv6Server should have comment or be unexported (golint)

• kubevirt/tests/framework/matcher/phase.go
  • Line 14: warning: exported function BeRunning should have comment or be unexported (golint)
  • Line 20: warning: exported function HaveSucceeded should have comment or be unexported (golint)
  • Line 26: warning: exported function BeInPhase should have comment or be unexported (golint)
  • Line 32: warning: exported function HavePhase should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/migration-proxy/migration-proxy.go
  • Line 41: warning: exported const LibvirtDirectMigrationPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type ProxyManager should have comment or be unexported (golint)
  • Line 72: warning: exported type MigrationProxyListener should have comment or be unexported (golint)
  • Line 108: warning: exported function GetMigrationPortsList should have comment or be unexported (golint)
  • Line 116: warning: exported function NewMigrationProxyManager should have comment or be unexported (golint)
  • Line 126: warning: exported function SourceUnixFile should have comment or be unexported (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 211: warning: exported function ConstructProxyKey should have comment or be unexported (golint)
  • Line 290: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 347: warning: comment on exported function NewSourceProxy should be of the form "NewSourceProxy ..." (golint)
  • Line 362: warning: comment on exported function NewTargetProxy should be of the form "NewTargetProxy ..." (golint)

• kubevirt/pkg/virt-launcher/virtwrap/stats/types.go
  • Line 53: warning: exported type DomainStats should have comment or be unexported (golint)
  • Line 73: warning: exported type DomainStatsCPU should have comment or be unexported (golint)
  • Line 82: warning: exported type DomainStatsVcpu should have comment or be unexported (golint)
  • Line 91: warning: exported type DomainStatsNet should have comment or be unexported (golint)
  • Line 114: warning: exported type DomainStatsBlock should have comment or be unexported (golint)
  • Line 148: warning: comment on exported type DomainStatsMemory should be of the form "DomainStatsMemory ..." (with optional leading article) (golint)

• kubevirt/pkg/virt-launcher/virtwrap/cmd-server/server.go
  • Line 47: warning: exported type ServerOptions should have comment or be unexported (golint)
  • Line 51: warning: exported function NewServerOptions should have comment or be unexported (golint)
  • Line 55: warning: exported type Launcher should have comment or be unexported (golint)
  • Line 96: warning: exported method Launcher.MigrateVirtualMachine should have comment or be unexported (golint)
  • Line 121: warning: exported method Launcher.CancelVirtualMachineMigration should have comment or be unexported (golint)
  • Line 140: warning: exported method Launcher.SignalTargetPodCleanup should have comment or be unexported (golint)
  • Line 157: warning: exported method Launcher.SyncMigrationTarget should have comment or be unexported (golint)
  • Line 176: warning: exported method Launcher.SyncVirtualMachine should have comment or be unexported (golint)
  • Line 194: warning: exported method Launcher.PauseVirtualMachine should have comment or be unexported (golint)
  • Line 211: warning: exported method Launcher.UnpauseVirtualMachine should have comment or be unexported (golint)
  • Line 228: warning: exported method Launcher.FreezeVirtualMachine should have comment or be unexported (golint)
  • Line 245: warning: exported method Launcher.UnfreezeVirtualMachine should have comment or be unexported (golint)
  • Line 262: warning: exported method Launcher.KillVirtualMachine should have comment or be unexported (golint)
  • Line 280: warning: exported method Launcher.ShutdownVirtualMachine should have comment or be unexported (golint)
  • Line 298: warning: exported method Launcher.DeleteVirtualMachine should have comment or be unexported (golint)
  • Line 316: warning: exported method Launcher.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 333: warning: exported method Launcher.GetDomain should have comment or be unexported (golint)
  • Line 361: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 369: warning: exported method Launcher.GetDomainStats should have comment or be unexported (golint)
  • Line 390: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 418: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 445: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 472: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 501: warning: exported method Launcher.GuestPing should have comment or be unexported (golint)
  • Line 516: warning: exported function RunServer should have comment or be unexported (golint)
  • Line 573: warning: exported method Launcher.Ping should have comment or be unexported (golint)
  • Line 580: warning: exported function ReceivedEarlyExitSignal should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/apply/patches.go
  • Line 23: warning: exported type Customizer should have comment or be unexported (golint)
  • Line 29: warning: exported function NewCustomizer should have comment or be unexported (golint)
  • Line 84: warning: exported method Customizer.Hash should have comment or be unexported (golint)
  • Line 88: warning: exported method Customizer.GenericApplyPatches should have comment or be unexported (golint)
  • Line 121: warning: exported method Customizer.Apply should have comment or be unexported (golint)
  • Line 223: warning: exported method Customizer.GetPatches should have comment or be unexported (golint)
  • Line 227: warning: exported method Customizer.GetPatchesForResource should have comment or be unexported (golint)

• kubevirt/tools/perfscale-load-generator/object/unstructured.go
  • Line 33: warning: exported function CreateObject should have comment or be unexported (golint)
  • Line 63: warning: exported function AddLabels should have comment or be unexported (golint)

• kubevirt/pkg/network/infraconfigurators/common.go
  • Line 33: warning: exported type PodNetworkInfraConfigurator should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/virt-api_suite_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/network/setup/network.go
  • Line 33: warning: exported type VMNetworkConfigurator should have comment or be unexported (golint)
  • Line 47: warning: exported function NewVMNetworkConfigurator should have comment or be unexported (golint)
  • Line 58: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 76: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 87: warning: exported method VMNetworkConfigurator.SetupPodNetworkPhase1 should have comment or be unexported (golint)
  • Line 87: warning: receiver name n should be consistent with previous receiver name v for VMNetworkConfigurator (golint)
  • Line 101: warning: exported method VMNetworkConfigurator.SetupPodNetworkPhase2 should have comment or be unexported (golint)
  • Line 101: warning: receiver name n should be consistent with previous receiver name v for VMNetworkConfigurator (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/vmirs-admitter.go
  • Line 37: warning: exported type VMIRSAdmitter should have comment or be unexported (golint)
  • Line 41: warning: exported method VMIRSAdmitter.Admit should have comment or be unexported (golint)
  • Line 69: warning: exported function ValidateVMIRSSpec should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/vm/vm.go
  • Line 41: warning: exported const COMMAND_START should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported function NewStartCommand should have comment or be unexported (golint)
  • Line 80: warning: exported function NewStopCommand should have comment or be unexported (golint)
  • Line 98: warning: exported function NewRestartCommand should have comment or be unexported (golint)
  • Line 115: warning: exported function NewMigrateCommand should have comment or be unexported (golint)
  • Line 130: warning: exported function NewGuestOsInfoCommand should have comment or be unexported (golint)
  • Line 145: warning: exported function NewUserListCommand should have comment or be unexported (golint)
  • Line 160: warning: exported function NewFSListCommand should have comment or be unexported (golint)
  • Line 175: warning: exported function NewAddVolumeCommand should have comment or be unexported (golint)
  • Line 195: warning: exported function NewRemoveVolumeCommand should have comment or be unexported (golint)
  • Line 240: warning: exported type Command should have comment or be unexported (golint)
  • Line 335: warning: exported method Command.Run should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/ssh/ssh.go
  • Line 52: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 86: warning: exported type SSH should have comment or be unexported (golint)
  • Line 90: warning: exported method SSH.Run should have comment or be unexported (golint)

• kubevirt/tools/tools.go
  • Line 5: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• kubevirt/tests/network/vmi_slirp_interface.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• kubevirt/pkg/monitoring/domainstats/scraper.go
  • Line 5: warning: exported type MetricsScraper should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/server/socket_listener.go
  • Line 1: warning: package comment should be of the form "Package server ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 31: warning: comment on exported function NewUDP4FilterListener should be of the form "NewUDP4FilterListener ..." (golint)
  • Line 55: warning: exported function CreateListenConfig should have comment or be unexported (golint)
  • Line 70: warning: exported type ServeIfConn should have comment or be unexported (golint)

• kubevirt/tools/doc-generator/fakeCollector.go
  • Line 72: warning: exported function RegisterFakeCollector should have comment or be unexported (golint)

• kubevirt/pkg/hooks/manager.go
  • Line 53: warning: exported type Manager should have comment or be unexported (golint)
  • Line 58: warning: exported function GetManager should have comment or be unexported (golint)
  • Line 69: warning: exported method Manager.Collect should have comment or be unexported (golint)
  • Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 183: warning: exported method Manager.OnDefineDomain should have comment or be unexported (golint)
  • Line 236: warning: exported method Manager.PreCloudInitIso should have comment or be unexported (golint)
  • Line 301: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/network/dhcp/server/server.go
  • Line 50: warning: exported function SingleClientDHCPServer should have comment or be unexported (golint)
  • Line 181: warning: exported type DHCPHandler should have comment or be unexported (golint)
  • Line 189: warning: exported method DHCPHandler.ServeDHCP should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/profiler/profile-manager.go
  • Line 32: warning: exported type ProfileManager should have comment or be unexported (golint)
  • Line 37: warning: exported type ProfilerResults should have comment or be unexported (golint)
  • Line 41: warning: exported function NewProfileManager should have comment or be unexported (golint)
  • Line 86: warning: exported method ProfileManager.HandleStartProfiler should have comment or be unexported (golint)
  • Line 101: warning: exported method ProfileManager.HandleStopProfiler should have comment or be unexported (golint)
  • Line 115: warning: exported method ProfileManager.HandleDumpProfiler should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/generated_mock_nodetopologyupdater.go
  • Line 12: warning: comment on exported type MockNodeTopologyUpdater should be of the form "MockNodeTopologyUpdater ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockNodeTopologyUpdater should have comment or be unexported (golint)
  • Line 29: warning: exported method MockNodeTopologyUpdater.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockNodeTopologyUpdater.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/virt-chroot/virt-chroot.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 33: warning: exported function GetChrootBinaryPath should have comment or be unexported (golint)
  • Line 37: warning: exported function GetChrootMountNamespace should have comment or be unexported (golint)
  • Line 41: warning: exported function MountChroot should have comment or be unexported (golint)
  • Line 53: warning: exported function UmountChroot should have comment or be unexported (golint)
  • Line 58: warning: exported function CreateMDEVType should have comment or be unexported (golint)
  • Line 64: warning: exported function RemoveMDEVType should have comment or be unexported (golint)
  • Line 70: warning: comment on exported function ExecChroot should be of the form "ExecChroot ..." (golint)

• kubevirt/pkg/config/config.go
  • Line 80: warning: comment on exported var DownwardMetricDisk should be of the form "DownwardMetricDisk ..." (golint)

• kubevirt/pkg/flavor/flavor.go
  • Line 17: warning: exported type Methods should have comment or be unexported (golint)
  • Line 22: warning: exported type Conflicts should have comment or be unexported (golint)
  • Line 39: warning: exported function NewMethods should have comment or be unexported (golint)
  • Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/util/os_helper.go
  • Line 50: warning: exported function MkdirAllWithNosec should have comment or be unexported (golint)
  • Line 55: warning: exported function OpenFileWithNosec should have comment or be unexported (golint)
  • Line 60: warning: exported function WriteFileWithNosec should have comment or be unexported (golint)
  • Line 65: warning: exported function WriteBytes should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/workload-updater/workload-updater.go
  • Line 40: warning: comment on exported const FailedEvictVirtualMachineInstanceReason should be of the form "FailedEvictVirtualMachineInstanceReason ..." (golint)
  • Line 42: warning: comment on exported const SuccessfulEvictVirtualMachineInstanceReason should be of the form "SuccessfulEvictVirtualMachineInstanceReason ..." (golint)
  • Line 59: warning: var defaultThrottleIntervalSeconds is of type time.Duration; don't use unit-specific suffix "Seconds" (golint)
  • Line 68: warning: exported type WorkloadUpdateController should have comment or be unexported (golint)
  • Line 92: warning: exported function NewWorkloadUpdateController should have comment or be unexported (golint)
  • Line 244: warning: exported method WorkloadUpdateController.Execute should have comment or be unexported (golint)
  • Line 494: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/virt-api/rest/vnc.go
  • Line 15: warning: exported method SubresourceAPIApp.VNCRequestHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/pod-eviction-admitter.go
  • Line 18: warning: exported type PodEvictionAdmitter should have comment or be unexported (golint)
  • Line 23: warning: exported method PodEvictionAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/masquerade.go
  • Line 32: warning: exported type MasqueradeConfigGenerator should have comment or be unexported (golint)
  • Line 39: warning: exported method MasqueradeConfigGenerator.Generate should have comment or be unexported (golint)

• kubevirt/pkg/network/cache/types.go
  • Line 12: warning: exported type PodIfaceState should have comment or be unexported (golint)
  • Line 15: warning: exported const PodIfaceNetworkPreparationPending should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type PodCacheInterface should have comment or be unexported (golint)
  • Line 27: warning: exported type DHCPConfig should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go
  • Line 1: warning: package comment should be of the form "Package agentpoller ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 274: warning: exported type AgentPoller should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/access-credentials/access_credentials.go
  • Line 72: warning: exported type AccessCredentialManager should have comment or be unexported (golint)
  • Line 87: warning: exported function NewManager should have comment or be unexported (golint)
  • Line 399: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 615: warning: exported method AccessCredentialManager.HandleQemuAgentAccessCredentials should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/vmi-update-admitter.go
  • Line 37: warning: exported type VMIUpdateAdmitter should have comment or be unexported (golint)
  • Line 41: warning: exported method VMIUpdateAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/util/client.go
  • Line 38: warning: exported const KubeVirtFinalizer should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported function UpdateConditionsDeploying should have comment or be unexported (golint)
  • Line 60: warning: exported function UpdateConditionsUpdating should have comment or be unexported (golint)
  • Line 73: warning: exported function UpdateConditionsCreated should have comment or be unexported (golint)
  • Line 77: warning: exported function UpdateConditionsAvailable should have comment or be unexported (golint)
  • Line 84: warning: exported function UpdateConditionsFailedExists should have comment or be unexported (golint)
  • Line 89: warning: exported function UpdateConditionsFailedError should have comment or be unexported (golint)
  • Line 97: warning: exported function UpdateConditionsDeleting should have comment or be unexported (golint)
  • Line 106: warning: exported function UpdateConditionsDeletionFailed should have comment or be unexported (golint)
  • Line 154: warning: exported function SetConditionTimestamps should have comment or be unexported (golint)
  • Line 175: warning: exported function AddFinalizer should have comment or be unexported (golint)
  • Line 190: warning: exported function SetOperatorVersion should have comment or be unexported (golint)
  • Line 194: warning: exported function IsServiceMonitorEnabled should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/numa_placement_test.go
  • Line 23: warning: don't use underscores in Go names; var MiBInBytes_2 should be MiBInBytes2 (golint)
  • Line 24: warning: don't use underscores in Go names; var MiBInBytes_22 should be MiBInBytes22 (golint)
  • Line 25: warning: don't use underscores in Go names; var MiBInBytes_20 should be MiBInBytes20 (golint)
  • Line 26: warning: don't use underscores in Go names; var MiBInBytes_32 should be MiBInBytes32 (golint)

• kubevirt/tests/libnet/namespace.go
  • Line 15: warning: exported function AddLabelToNamespace should have comment or be unexported (golint)
  • Line 24: warning: exported function RemoveLabelFromNamespace should have comment or be unexported (golint)
  • Line 33: warning: exported function RemoveAllLabelsFromNamespace should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/definitions.go
  • Line 39: warning: exported function ComposeAPIDefinitions should have comment or be unexported (golint)
  • Line 161: warning: exported function GroupVersionProxyBase should have comment or be unexported (golint)
  • Line 177: warning: exported function GenericNamespacedResourceProxy should have comment or be unexported (golint)
  • Line 247: warning: exported function GenericClusterResourceProxy should have comment or be unexported (golint)
  • Line 304: warning: exported function ResourceProxyAutodiscovery should have comment or be unexported (golint)
  • Line 453: warning: exported const NamespaceParamName should have comment (or a comment on this block) or be unexported (golint)
  • Line 457: warning: exported function NameParam should have comment or be unexported (golint)
  • Line 461: warning: exported function NamespaceParam should have comment or be unexported (golint)
  • Line 517: warning: exported function GroupBasePath should have comment or be unexported (golint)
  • Line 521: warning: exported function GroupVersionBasePath should have comment or be unexported (golint)
  • Line 525: warning: exported function NamespacedResourceBasePath should have comment or be unexported (golint)
  • Line 529: warning: exported function NamespacedResourcePath should have comment or be unexported (golint)
  • Line 533: warning: exported function ClusterResourceBasePath should have comment or be unexported (golint)
  • Line 537: warning: exported function ClusterResourcePath should have comment or be unexported (golint)
  • Line 541: warning: exported function SubResourcePath should have comment or be unexported (golint)
  • Line 549: warning: exported const PortParamName should have comment (or a comment on this block) or be unexported (golint)
  • Line 555: warning: exported function PortForwardPortParameter should have comment or be unexported (golint)
  • Line 559: warning: exported function PortForwardProtocolParameter should have comment or be unexported (golint)
  • Line 563: warning: exported function Noop should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/notify-client/client.go
  • Line 42: warning: exported type Notifier should have comment or be unexported (golint)
  • Line 60: warning: exported function NewNotifier should have comment or be unexported (golint)
  • Line 107: warning: comment on exported method Notifier.SetCustomTimeouts should be of the form "SetCustomTimeouts ..." (golint)
  • Line 166: warning: exported method Notifier.SendDomainEvent should have comment or be unexported (golint)
  • Line 365: warning: exported method Notifier.StartDomainNotifier should have comment or be unexported (golint)
  • Line 511: warning: exported method Notifier.SendK8sEvent should have comment or be unexported (golint)
  • Line 574: warning: exported method Notifier.Close should have comment or be unexported (golint)

• kubevirt/tests/network/vmi_lifecycle.go
  • Line 30: warning: should not use dot imports (golint)
  • Line 31: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/generated_mock_converter.go
  • Line 10: warning: comment on exported type MockDirectIOChecker should be of the form "MockDirectIOChecker ..." (with optional leading article) (golint)
  • Line 21: warning: exported function NewMockDirectIOChecker should have comment or be unexported (golint)
  • Line 27: warning: exported method MockDirectIOChecker.EXPECT should have comment or be unexported (golint)
  • Line 31: warning: exported method MockDirectIOChecker.CheckBlockDevice should have comment or be unexported (golint)
  • Line 42: warning: exported method MockDirectIOChecker.CheckFile should have comment or be unexported (golint)

• kubevirt/pkg/ephemeral-disk-utils/utils.go
  • Line 32: warning: comment on exported var DefaultOwnershipManager should be of the form "DefaultOwnershipManager ..." (golint)
  • Line 35: warning: comment on exported function MockDefaultOwnershipManager should be of the form "MockDefaultOwnershipManager ..." (golint)
  • Line 47: warning: exported type OwnershipManager should have comment or be unexported (golint)
  • Line 51: warning: exported method OwnershipManager.SetFileOwnership should have comment or be unexported (golint)
  • Line 82: warning: exported function RemoveFilesIfExist should have comment or be unexported (golint)
  • Line 92: warning: exported function FileExists should have comment or be unexported (golint)
  • Line 104: warning: exported type OwnershipManagerInterface should have comment or be unexported (golint)
  • Line 108: warning: exported function GetEphemeralBackingSourceBlockDevices should have comment or be unexported (golint)

• kubevirt/pkg/network/link/names.go
  • Line 26: warning: exported function GenerateTapDeviceName should have comment or be unexported (golint)
  • Line 30: warning: exported function GenerateNewBridgedVmiInterfaceName should have comment or be unexported (golint)

• kubevirt/pkg/util/net/grpc/grpc.go
  • Line 1: warning: package comment should be of the form "Package grpc ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 36: warning: exported const CONNECT_TIMEOUT_SECONDS should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported function DialSocket should have comment or be unexported (golint)
  • Line 43: warning: exported function DialSocketWithTimeout should have comment or be unexported (golint)
  • Line 66: warning: exported function CreateSocket should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/drain/disruptionbudget/disruptionbudget.go
  • Line 42: warning: exported type DisruptionBudgetController should have comment or be unexported (golint)
  • Line 53: warning: exported function NewDisruptionBudgetController should have comment or be unexported (golint)
  • Line 327: warning: exported method DisruptionBudgetController.Execute should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/common.go
  • Line 22: warning: don't use an underscore in package name (golint)
  • Line 40: warning: exported type DeviceHandler should have comment or be unexported (golint)
  • Line 51: warning: exported type DeviceUtilsHandler should have comment or be unexported (golint)
  • Line 53: warning: exported var Handler should have comment or be unexported (golint)
  • Line 55: warning: comment on exported method DeviceUtilsHandler.GetDeviceIOMMUGroup should be of the form "GetDeviceIOMMUGroup ..." (golint)
  • Line 68: warning: comment on exported method DeviceUtilsHandler.GetDeviceDriver should be of the form "GetDeviceDriver ..." (golint)
  • Line 80: warning: exported method DeviceUtilsHandler.GetDeviceNumaNode should have comment or be unexported (golint)
  • Line 98: warning: exported method DeviceUtilsHandler.GetDevicePCIID should have comment or be unexported (golint)
  • Line 118: warning: comment on exported method DeviceUtilsHandler.GetMdevParentPCIAddr should be of the form "GetMdevParentPCIAddr ..." (golint)
  • Line 128: warning: exported method DeviceUtilsHandler.CreateMDEVType should have comment or be unexported (golint)
  • Line 148: warning: exported method DeviceUtilsHandler.RemoveMDEVType should have comment or be unexported (golint)
  • Line 167: warning: exported method DeviceUtilsHandler.ReadMDEVAvailableInstances should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/rest/lifecycle.go
  • Line 1: warning: package comment should be of the form "Package rest ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 36: warning: exported type LifecycleHandler should have comment or be unexported (golint)
  • Line 41: warning: exported function NewLifecycleHandler should have comment or be unexported (golint)
  • Line 48: warning: exported method LifecycleHandler.PauseHandler should have comment or be unexported (golint)
  • Line 76: warning: exported method LifecycleHandler.UnpauseHandler should have comment or be unexported (golint)
  • Line 104: warning: exported method LifecycleHandler.FreezeHandler should have comment or be unexported (golint)
  • Line 157: warning: exported method LifecycleHandler.UnfreezeHandler should have comment or be unexported (golint)
  • Line 185: warning: exported method LifecycleHandler.GetGuestInfo should have comment or be unexported (golint)
  • Line 217: warning: exported method LifecycleHandler.GetUsers should have comment or be unexported (golint)
  • Line 247: warning: exported method LifecycleHandler.GetFilesystems should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/converter_test.go
  • Line 1658: warning: don't use underscores in Go names; var test_address should be testAddress (golint)
  • Line 1697: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)

• kubevirt/pkg/virt-operator/resource/apply/certificates.go
  • Line 11: warning: exported function GetCADuration should have comment or be unexported (golint)
  • Line 29: warning: exported function GetCARenewBefore should have comment or be unexported (golint)
  • Line 49: warning: exported function GetCertDuration should have comment or be unexported (golint)
  • Line 67: warning: exported function GetCertRenewBefore should have comment or be unexported (golint)

• kubevirt/pkg/downwardmetrics/vhostmd/api/api.go
  • Line 5: warning: exported type MetricContext should have comment or be unexported (golint)
  • Line 6: warning: exported type MetricType should have comment or be unexported (golint)
  • Line 9: warning: exported const MetricContextHost should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported const MetricTypeReal64 should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type Metrics should have comment or be unexported (golint)
  • Line 29: warning: exported type Metric should have comment or be unexported (golint)

• kubevirt/pkg/util/pdbs/pdbs.go
  • Line 13: warning: exported function PDBsForVMI should have comment or be unexported (golint)
  • Line 30: warning: exported function IsPDBFromOldMigrationController should have comment or be unexported (golint)

• kubevirt/tests/storage/guestfs.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)
  • Line 23: warning: exported const APPLIANCE_FILES should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/gpu/addresspool.go
  • Line 51: warning: should omit 2nd value from range; this loop is equivalent to `for resource := range ...` (golint)

• kubevirt/pkg/virt-launcher/virtwrap/efi/efi.go
  • Line 28: warning: exported const EFICode should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type EFIEnvironment should have comment or be unexported (golint)
  • Line 43: warning: exported method EFIEnvironment.Bootable should have comment or be unexported (golint)
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 51: warning: exported method EFIEnvironment.EFICode should have comment or be unexported (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 59: warning: exported method EFIEnvironment.EFIVars should have comment or be unexported (golint)
  • Line 62: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 67: warning: exported function DetectEFIEnvironment should have comment or be unexported (golint)

• kubevirt/tools/cluster-profiler/cluster-profiler.go
  • Line 40: warning: exported const PROFILER_START should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/tests/reporter/kubernetes.go
  • Line 48: warning: exported type JustAfterEachReporter should have comment or be unexported (golint)
  • Line 52: warning: exported type KubernetesReporter should have comment or be unexported (golint)
  • Line 63: warning: exported function NewKubernetesReporter should have comment or be unexported (golint)
  • Line 71: warning: exported method KubernetesReporter.SpecSuiteWillBegin should have comment or be unexported (golint)
  • Line 75: warning: exported method KubernetesReporter.BeforeSuiteDidRun should have comment or be unexported (golint)
  • Line 79: warning: exported method KubernetesReporter.SpecWillRun should have comment or be unexported (golint)
  • Line 83: warning: exported method KubernetesReporter.SpecDidComplete should have comment or be unexported (golint)
  • Line 85: warning: exported method KubernetesReporter.JustAfterEach should have comment or be unexported (golint)
  • Line 102: warning: exported method KubernetesReporter.DumpTestNamespaces should have comment or be unexported (golint)
  • Line 106: warning: exported method KubernetesReporter.DumpAllNamespaces should have comment or be unexported (golint)
  • Line 883: warning: exported method KubernetesReporter.AfterSuiteDidRun should have comment or be unexported (golint)
  • Line 890: warning: exported method KubernetesReporter.SpecSuiteDidEnd should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/hyperv.go
  • Line 20: warning: package comment should be of the form "Package webhooks ..." (golint)
  • Line 20: warning: package comment should not have leading space (golint)
  • Line 59: warning: exported type HypervFeature should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method HypervFeature.TryToSetRequirement should be of the form "TryToSetRequirement ..." (golint)
  • Line 96: warning: exported method HypervFeature.IsRequirementFulfilled should have comment or be unexported (golint)
  • Line 170: warning: exported function ValidateVirtualMachineInstanceHypervFeatureDependencies should have comment or be unexported (golint)
  • Line 198: warning: exported function SetVirtualMachineInstanceHypervFeatureDependencies should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/cache/cache.go
  • Line 64: warning: exported type DomainWatcher should have comment or be unexported (golint)
  • Line 98: warning: exported function InitializeGhostRecordCache should have comment or be unexported (golint)
  • Line 141: warning: exported function LastKnownUIDFromGhostRecordCache should have comment or be unexported (golint)
  • Line 179: warning: exported function HasGhostRecord should have comment or be unexported (golint)
  • Line 189: warning: exported function AddGhostRecord should have comment or be unexported (golint)
  • Line 247: warning: exported function DeleteGhostRecord should have comment or be unexported (golint)
  • Line 550: warning: exported method DomainWatcher.List should have comment or be unexported (golint)
  • Line 573: warning: exported method DomainWatcher.Watch should have comment or be unexported (golint)
  • Line 577: warning: exported method DomainWatcher.Stop should have comment or be unexported (golint)
  • Line 590: warning: exported method DomainWatcher.ResultChan should have comment or be unexported (golint)
  • Line 594: warning: exported function NewSharedInformer should have comment or be unexported (golint)

• kubevirt/pkg/network/link/ethtool.go
  • Line 12: warning: exported const SIOCETHTOOL should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: comment on exported type IFReqData should be of the form "IFReqData ..." (with optional leading article) (golint)
  • Line 24: warning: comment on exported type EthtoolValue should be of the form "EthtoolValue ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported function EthtoolTXOff should be of the form "EthtoolTXOff ..." (golint)

• kubevirt/pkg/testutils/matchers.go
  • Line 33: warning: exported function HaveStatusCode should have comment or be unexported (golint)
  • Line 72: warning: comment on exported function IgnoreEvents should be of the form "IgnoreEvents ..." (golint)
  • Line 84: warning: exported function ExpectEvent should have comment or be unexported (golint)
  • Line 116: warning: exported function SatisfyAnyRegexp should have comment or be unexported (golint)

• kubevirt/pkg/virt-config/feature-gates.go
  • Line 27: warning: exported const CPUManager should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported method ClusterConfig.CPUManagerEnabled should have comment or be unexported (golint)
  • Line 57: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 61: warning: exported method ClusterConfig.NUMAEnabled should have comment or be unexported (golint)
  • Line 61: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 65: warning: exported method ClusterConfig.DownwardMetricsEnabled should have comment or be unexported (golint)
  • Line 65: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 69: warning: exported method ClusterConfig.IgnitionEnabled should have comment or be unexported (golint)
  • Line 69: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 73: warning: exported method ClusterConfig.LiveMigrationEnabled should have comment or be unexported (golint)
  • Line 73: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 78: warning: exported method ClusterConfig.SRIOVLiveMigrationEnabled should have comment or be unexported (golint)
  • Line 78: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 82: warning: exported method ClusterConfig.HypervStrictCheckEnabled should have comment or be unexported (golint)
  • Line 82: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 86: warning: exported method ClusterConfig.CPUNodeDiscoveryEnabled should have comment or be unexported (golint)
  • Line 86: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 90: warning: exported method ClusterConfig.SidecarEnabled should have comment or be unexported (golint)
  • Line 90: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 94: warning: exported method ClusterConfig.GPUPassthroughEnabled should have comment or be unexported (golint)
  • Line 94: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 98: warning: exported method ClusterConfig.SnapshotEnabled should have comment or be unexported (golint)
  • Line 98: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 102: warning: exported method ClusterConfig.HotplugVolumesEnabled should have comment or be unexported (golint)
  • Line 102: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 106: warning: exported method ClusterConfig.HostDiskEnabled should have comment or be unexported (golint)
  • Line 106: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 110: warning: exported method ClusterConfig.VirtiofsEnabled should have comment or be unexported (golint)
  • Line 110: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 114: warning: exported method ClusterConfig.MacvtapEnabled should have comment or be unexported (golint)
  • Line 114: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 118: warning: exported method ClusterConfig.HostDevicesPassthroughEnabled should have comment or be unexported (golint)
  • Line 118: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 122: warning: exported method ClusterConfig.NonRootEnabled should have comment or be unexported (golint)
  • Line 122: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)
  • Line 126: warning: exported method ClusterConfig.ClusterProfilerEnabled should have comment or be unexported (golint)
  • Line 126: warning: receiver name config should be consistent with previous receiver name c for ClusterConfig (golint)

• kubevirt/pkg/virt-handler/heartbeat/heartbeat_test.go
  • Line 22: warning: don't use underscores in Go names; const cpu_manager_static_path should be cpuManagerStaticPath (golint)
  • Line 23: warning: don't use underscores in Go names; const cpu_manager_none_path should be cpuManagerNonePath (golint)

• kubevirt/pkg/virt-handler/selinux/context_executor.go
  • Line 33: warning: exported type ContextExecutor should have comment or be unexported (golint)
  • Line 41: warning: exported function NewContextExecutor should have comment or be unexported (golint)
  • Line 68: warning: exported method ContextExecutor.Execute should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/migration_test.go
  • Line 1018: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

• kubevirt/pkg/middleware/middleware.go
  • Line 37: warning: exported type AppError should have comment or be unexported (golint)
  • Line 60: warning: comment on exported type ResourceExistsError should be of the form "ResourceExistsError ..." (with optional leading article) (golint)
  • Line 62: warning: exported type ResourceNotFoundError should have comment or be unexported (golint)
  • Line 63: warning: exported type PreconditionError should have comment or be unexported (golint)
  • Line 64: warning: exported type InternalServerError should have comment or be unexported (golint)
  • Line 65: warning: exported type UnsupportedMediaTypeError should have comment or be unexported (golint)
  • Line 66: warning: exported type BadRequestError should have comment or be unexported (golint)
  • Line 67: warning: exported type UnprocessableEntityError should have comment or be unexported (golint)
  • Line 69: warning: exported type KubernetesError should have comment or be unexported (golint)
  • Line 73: warning: exported method KubernetesError.Cause should have comment or be unexported (golint)
  • Line 81: warning: exported method KubernetesError.Status should have comment or be unexported (golint)
  • Line 91: warning: exported method KubernetesError.StatusCode should have comment or be unexported (golint)
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 102: warning: exported method KubernetesError.Body should have comment or be unexported (golint)
  • Line 152: warning: exported function NewResourceConflictError should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/vmistats/collector.go
  • Line 68: warning: exported type VMICollector should have comment or be unexported (golint)
  • Line 72: warning: exported method VMICollector.Describe should have comment or be unexported (golint)
  • Line 76: warning: comment on exported function SetupVMICollector should be of the form "SetupVMICollector ..." (golint)
  • Line 86: warning: comment on exported method VMICollector.Collect should be of the form "Collect ..." (golint)

• kubevirt/pkg/util/openapi/openapi.go
  • Line 23: warning: exported type Validator should have comment or be unexported (golint)
  • Line 29: warning: exported function CreateOpenAPIConfig should have comment or be unexported (golint)
  • Line 133: warning: exported function LoadOpenAPISpec should have comment or be unexported (golint)
  • Line 227: warning: exported function CreateOpenAPIValidator should have comment or be unexported (golint)
  • Line 278: warning: exported method Validator.Validate should have comment or be unexported (golint)
  • Line 295: warning: exported method Validator.ValidateSpec should have comment or be unexported (golint)
  • Line 301: warning: exported method Validator.ValidateStatus should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/container-disk/mount_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-launcher/virtwrap/manager.go
  • Line 78: warning: exported const PCI_RESOURCE_PREFIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 87: warning: exported type DomainManager should have comment or be unexported (golint)
  • Line 112: warning: exported type LibvirtDomainManager should have comment or be unexported (golint)
  • Line 159: warning: exported function NewLibvirtDomainManager should have comment or be unexported (golint)
  • Line 332: warning: exported method LibvirtDomainManager.Exec should have comment or be unexported (golint)
  • Line 336: warning: exported method LibvirtDomainManager.GuestPing should have comment or be unexported (golint)
  • Line 379: warning: exported method LibvirtDomainManager.CancelVMIMigration should have comment or be unexported (golint)
  • Line 383: warning: exported method LibvirtDomainManager.MigrateVMI should have comment or be unexported (golint)
  • Line 687: warning: exported method LibvirtDomainManager.SyncVMI should have comment or be unexported (golint)
  • Line 953: warning: exported method LibvirtDomainManager.PauseVMI should have comment or be unexported (golint)
  • Line 965: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 993: warning: exported method LibvirtDomainManager.UnpauseVMI should have comment or be unexported (golint)
  • Line 1005: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1058: warning: exported method LibvirtDomainManager.FreezeVMI should have comment or be unexported (golint)
  • Line 1089: warning: exported method LibvirtDomainManager.UnfreezeVMI should have comment or be unexported (golint)
  • Line 1101: warning: exported method LibvirtDomainManager.MarkGracefulShutdownVMI should have comment or be unexported (golint)
  • Line 1141: warning: exported method LibvirtDomainManager.SignalShutdownVMI should have comment or be unexported (golint)
  • Line 1151: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1193: warning: exported method LibvirtDomainManager.KillVMI should have comment or be unexported (golint)
  • Line 1200: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1233: warning: exported method LibvirtDomainManager.DeleteVMI should have comment or be unexported (golint)
  • Line 1240: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1256: warning: exported method LibvirtDomainManager.ListAllDomains should have comment or be unexported (golint)
  • Line 1307: warning: exported method LibvirtDomainManager.GetDomainStats should have comment or be unexported (golint)

• kubevirt/tools/perfscale-audit/api/api.go
  • Line 30: warning: exported type Duration should have comment or be unexported (golint)
  • Line 32: warning: exported method Duration.MarshalJSON should have comment or be unexported (golint)
  • Line 36: warning: exported method Duration.UnmarshalJSON should have comment or be unexported (golint)
  • Line 54: warning: exported type InputThreshold should have comment or be unexported (golint)
  • Line 58: warning: exported type InputConfig should have comment or be unexported (golint)
  • Line 80: warning: exported method InputConfig.GetDuration should have comment or be unexported (golint)
  • Line 84: warning: exported type ResultType should have comment or be unexported (golint)
  • Line 87: warning: exported const ResultTypeVMICreationToRunningP99 should have comment (or a comment on this block) or be unexported (golint)
  • Line 93: warning: exported const ResultTypeResourceOperationCountFormat should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: exported type ThresholdResult should have comment or be unexported (golint)
  • Line 101: warning: exported type ResultValue should have comment or be unexported (golint)
  • Line 106: warning: exported type Result should have comment or be unexported (golint)
  • Line 118: warning: exported method Result.DumpToFile should have comment or be unexported (golint)
  • Line 129: warning: exported method Result.DumpToStdout should have comment or be unexported (golint)
  • Line 139: warning: exported function ReadInputFile should have comment or be unexported (golint)

• kubevirt/pkg/downwardmetrics/vhostmd/disk.go
  • Line 23: warning: exported type Header should have comment or be unexported (golint)
  • Line 30: warning: exported type Disk should have comment or be unexported (golint)
  • Line 39: warning: exported method Disk.Verify should have comment or be unexported (golint)
  • Line 53: warning: exported method Disk.Metrics should have comment or be unexported (golint)

• kubevirt/pkg/downwardmetrics/vhostmd/vhostmd.go
  • Line 5: warning: exported type MetricsIO should have comment or be unexported (golint)
  • Line 11: warning: exported function NewMetricsIODisk should have comment or be unexported (golint)

• kubevirt/pkg/os/fs/filesystem.go
  • Line 1: warning: package comment should be of the form "Package fs ..." (golint)
  • Line 28: warning: comment on exported type Fs should be of the form "Fs ..." (with optional leading article) (golint)

• kubevirt/pkg/virt-controller/watch/topology/nodetopologyupdater_test.go
  • Line 153: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)

• kubevirt/pkg/virt-controller/services/template.go
  • Line 60: warning: exported const KvmDevice should have comment or be unexported (golint)
  • Line 61: warning: exported const TunDevice should have comment or be unexported (golint)
  • Line 62: warning: exported const VhostNetDevice should have comment or be unexported (golint)
  • Line 68: warning: exported const MultusNetworksAnnotation should have comment or be unexported (golint)
  • Line 73: warning: exported const CAP_NET_BIND_SERVICE should have comment (or a comment on this block) or be unexported (golint)
  • Line 83: warning: comment on exported const NFD_CPU_MODEL_PREFIX should be of the form "NFD_CPU_MODEL_PREFIX ..." (golint)
  • Line 86: warning: exported const NFD_CPU_FEATURE_PREFIX should have comment or be unexported (golint)
  • Line 87: warning: exported const NFD_KVM_INFO_PREFIX should have comment or be unexported (golint)
  • Line 88: warning: exported const IntelVendorName should have comment or be unexported (golint)
  • Line 90: warning: exported const MULTUS_RESOURCE_NAME_ANNOTATION should have comment or be unexported (golint)
  • Line 91: warning: exported const MULTUS_DEFAULT_NETWORK_CNI_ANNOTATION should have comment or be unexported (golint)
  • Line 93: warning: comment on exported const ISTIO_KUBEVIRT_ANNOTATION should be of the form "ISTIO_KUBEVIRT_ANNOTATION ..." (golint)
  • Line 96: warning: exported const VELERO_PREBACKUP_HOOK_CONTAINER_ANNOTATION should have comment or be unexported (golint)
  • Line 97: warning: exported const VELERO_PREBACKUP_HOOK_COMMAND_ANNOTATION should have comment or be unexported (golint)
  • Line 98: warning: exported const VELERO_POSTBACKUP_HOOK_CONTAINER_ANNOTATION should have comment or be unexported (golint)
  • Line 99: warning: exported const VELERO_POSTBACKUP_HOOK_COMMAND_ANNOTATION should have comment or be unexported (golint)
  • Line 101: warning: exported const ENV_VAR_LIBVIRT_DEBUG_LOGS should have comment or be unexported (golint)
  • Line 102: warning: exported const ENV_VAR_VIRTIOFSD_DEBUG_LOGS should have comment or be unexported (golint)
  • Line 103: warning: exported const ENV_VAR_VIRT_LAUNCHER_LOG_VERBOSITY should have comment or be unexported (golint)
  • Line 105: warning: exported const ENV_VAR_POD_NAME should have comment or be unexported (golint)
  • Line 107: warning: comment on exported const EXT_LOG_VERBOSITY_THRESHOLD should be of the form "EXT_LOG_VERBOSITY_THRESHOLD ..." (golint)
  • Line 112: warning: exported type TemplateService should have comment or be unexported (golint)
  • Line 138: warning: exported type PvcNotFoundError should have comment or be unexported (golint)
  • Line 146: warning: exported type DataVolumeNotFoundError should have comment or be unexported (golint)
  • Line 248: warning: exported function CPUModelLabelFromCPUModel should have comment or be unexported (golint)
  • Line 257: warning: exported function CPUFeatureLabelsFromCPUFeatures should have comment or be unexported (golint)
  • Line 269: warning: exported function SetNodeAffinityForForbiddenFeaturePolicy should have comment or be unexported (golint)
  • Line 1970: warning: exported function HaveMasqueradeInterface should have comment or be unexported (golint)
  • Line 1980: warning: exported function HaveContainerDiskVolume should have comment or be unexported (golint)
  • Line 2023: warning: exported function NewTemplateService should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/errors/errors.go
  • Line 29: warning: error var MigrationAbortInProgressError should have name of the form ErrFoo (golint)
  • Line 29: warning: exported var MigrationAbortInProgressError should have comment or be unexported (golint)
  • Line 55: warning: exported function FormatLibvirtError should have comment or be unexported (golint)

• kubevirt/cmd/virt-chroot/tap-device-maker.go
  • Line 52: warning: exported function NewCreateTapCommand should have comment or be unexported (golint)

• kubevirt/pkg/network/istio/annotations.go
  • Line 23: warning: exported const ISTIO_INJECT_ANNOTATION should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/statsconv/converter.go
  • Line 30: warning: exported type DomainIdentifier should have comment or be unexported (golint)
  • Line 35: warning: exported function Convert_libvirt_DomainStats_to_stats_DomainStats should have comment or be unexported (golint)
  • Line 35: warning: don't use underscores in Go names; func Convert_libvirt_DomainStats_to_stats_DomainStats should be ConvertLibvirtDomainStatsToStatsDomainStats (golint)
  • Line 57: warning: exported function Convert_libvirt_DomainStatsCpu_To_stats_DomainStatsCpu should have comment or be unexported (golint)
  • Line 57: warning: don't use underscores in Go names; func Convert_libvirt_DomainStatsCpu_To_stats_DomainStatsCpu should be ConvertLibvirtDomainStatsCPUToStatsDomainStatsCPU (golint)
  • Line 72: warning: exported function Convert_libvirt_MemoryStat_to_stats_DomainStatsMemory should have comment or be unexported (golint)
  • Line 72: warning: don't use underscores in Go names; func Convert_libvirt_MemoryStat_to_stats_DomainStatsMemory should be ConvertLibvirtMemoryStatToStatsDomainStatsMemory (golint)
  • Line 115: warning: exported function Convert_libvirt_DomainStatsVcpu_To_stats_DomainStatsVcpu should have comment or be unexported (golint)
  • Line 115: warning: don't use underscores in Go names; func Convert_libvirt_DomainStatsVcpu_To_stats_DomainStatsVcpu should be ConvertLibvirtDomainStatsVcpuToStatsDomainStatsVcpu (golint)
  • Line 130: warning: exported function Convert_libvirt_DomainStatsNet_To_stats_DomainStatsNet should have comment or be unexported (golint)
  • Line 130: warning: don't use underscores in Go names; func Convert_libvirt_DomainStatsNet_To_stats_DomainStatsNet should be ConvertLibvirtDomainStatsNetToStatsDomainStatsNet (golint)
  • Line 163: warning: exported function Convert_libvirt_DomainStatsBlock_To_stats_DomainStatsBlock should have comment or be unexported (golint)
  • Line 163: warning: don't use underscores in Go names; func Convert_libvirt_DomainStatsBlock_To_stats_DomainStatsBlock should be ConvertLibvirtDomainStatsBlockToStatsDomainStatsBlock (golint)

• kubevirt/pkg/virtctl/console/console.go
  • Line 40: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 57: warning: exported type Console should have comment or be unexported (golint)
  • Line 70: warning: exported method Console.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/migration-update-admitter.go
  • Line 32: warning: exported type MigrationUpdateAdmitter should have comment or be unexported (golint)
  • Line 63: warning: exported method MigrationUpdateAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/portforward/portforward.go
  • Line 47: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 76: warning: exported type PortForward should have comment or be unexported (golint)
  • Line 82: warning: exported method PortForward.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/generated_mock_hinter.go
  • Line 12: warning: comment on exported type MockHinter should be of the form "MockHinter ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockHinter should have comment or be unexported (golint)
  • Line 29: warning: exported method MockHinter.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockHinter.TopologyHintsForVMI should have comment or be unexported (golint)
  • Line 44: warning: exported method MockHinter.TopologyHintsRequiredForVMI should have comment or be unexported (golint)
  • Line 54: warning: exported method MockHinter.TSCFrequenciesInUse should have comment or be unexported (golint)
  • Line 64: warning: exported method MockHinter.LowestTSCFrequencyOnCluster should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/mediated_devices_types_test.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 245: warning: should omit 2nd value from range; this loop is equivalent to `for mdevType := range ...` (golint)

• kubevirt/pkg/util/ratelimiter/ratelimiter.go
  • Line 10: warning: exported type ReloadableRateLimiter should have comment or be unexported (golint)
  • Line 15: warning: exported method ReloadableRateLimiter.TryAccept should have comment or be unexported (golint)
  • Line 19: warning: exported method ReloadableRateLimiter.Accept should have comment or be unexported (golint)
  • Line 23: warning: exported method ReloadableRateLimiter.Stop should have comment or be unexported (golint)
  • Line 27: warning: exported method ReloadableRateLimiter.QPS should have comment or be unexported (golint)
  • Line 31: warning: exported method ReloadableRateLimiter.Wait should have comment or be unexported (golint)
  • Line 41: warning: exported method ReloadableRateLimiter.Set should have comment or be unexported (golint)
  • Line 47: warning: exported function NewReloadableRateLimiter should have comment or be unexported (golint)

• kubevirt/tests/vmi_servers.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 17: warning: exported const TCPServer should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported function StartTCPServer should have comment or be unexported (golint)
  • Line 30: warning: exported function StartHTTPServer should have comment or be unexported (golint)
  • Line 35: warning: exported function StartPythonHttpServer should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/generic/addresspool.go
  • Line 51: warning: should omit 2nd value from range; this loop is equivalent to `for resource := range ...` (golint)

• kubevirt/pkg/virt-operator/util/types.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported type Stores should have comment or be unexported (golint)
  • Line 57: warning: exported method Stores.AllEmpty should have comment or be unexported (golint)
  • Line 81: warning: exported function IsStoreEmpty should have comment or be unexported (golint)
  • Line 85: warning: exported function IsManagedByOperator should have comment or be unexported (golint)
  • Line 92: warning: exported function IsSCCStoreEmpty should have comment or be unexported (golint)
  • Line 102: warning: exported type Expectations should have comment or be unexported (golint)
  • Line 125: warning: exported type Informers should have comment or be unexported (golint)
  • Line 150: warning: exported method Expectations.DeleteExpectations should have comment or be unexported (golint)
  • Line 173: warning: exported method Expectations.ResetExpectations should have comment or be unexported (golint)
  • Line 196: warning: exported method Expectations.SatisfiedExpectations should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/apply/reconcile.go
  • Line 53: warning: exported const Duration7d should have comment or be unexported (golint)
  • Line 54: warning: exported const Duration1d should have comment or be unexported (golint)
  • Line 425: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 436: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 463: warning: exported method Reconciler.Sync should have comment or be unexported (golint)

• kubevirt/pkg/util/util.go
  • Line 12: warning: exported const ExtensionAPIServerAuthenticationConfigMap should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported const NonRootUID should have comment or be unexported (golint)
  • Line 24: warning: exported const NonRootUserString should have comment or be unexported (golint)
  • Line 25: warning: exported const RootUser should have comment or be unexported (golint)
  • Line 27: warning: exported function IsNonRootVMI should have comment or be unexported (golint)
  • Line 32: warning: exported function IsSRIOVVmi should have comment or be unexported (golint)
  • Line 41: warning: comment on exported function IsGPUVMI should be of the form "IsGPUVMI ..." (golint)
  • Line 49: warning: comment on exported function IsVMIVirtiofsEnabled should be of the form "IsVMIVirtiofsEnabled ..." (golint)
  • Line 61: warning: comment on exported function IsHostDevVMI should be of the form "IsHostDevVMI ..." (golint)
  • Line 69: warning: comment on exported function IsVFIOVMI should be of the form "IsVFIOVMI ..." (golint)
  • Line 112: warning: exported function ResourceNameToEnvVar should have comment or be unexported (golint)
  • Line 119: warning: comment on exported function HasKernelBootContainerImage should be of the form "HasKernelBootContainerImage ..." (golint)
  • Line 133: warning: exported function HasHugePages should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/generated_mock_authorizer.go
  • Line 11: warning: comment on exported type MockVirtApiAuthorizor should be of the form "MockVirtApiAuthorizor ..." (with optional leading article) (golint)
  • Line 22: warning: exported function NewMockVirtApiAuthorizor should have comment or be unexported (golint)
  • Line 28: warning: exported method MockVirtApiAuthorizor.EXPECT should have comment or be unexported (golint)
  • Line 32: warning: exported method MockVirtApiAuthorizor.Authorize should have comment or be unexported (golint)
  • Line 44: warning: exported method MockVirtApiAuthorizor.AddUserHeaders should have comment or be unexported (golint)
  • Line 52: warning: exported method MockVirtApiAuthorizor.GetUserHeaders should have comment or be unexported (golint)
  • Line 62: warning: exported method MockVirtApiAuthorizor.AddGroupHeaders should have comment or be unexported (golint)
  • Line 70: warning: exported method MockVirtApiAuthorizor.GetGroupHeaders should have comment or be unexported (golint)
  • Line 80: warning: exported method MockVirtApiAuthorizor.AddExtraPrefixHeaders should have comment or be unexported (golint)
  • Line 88: warning: exported method MockVirtApiAuthorizor.GetExtraPrefixHeaders should have comment or be unexported (golint)

• kubevirt/pkg/network/driver/generated_mock_common.go
  • Line 17: warning: comment on exported type MockNetworkHandler should be of the form "MockNetworkHandler ..." (with optional leading article) (golint)
  • Line 28: warning: exported function NewMockNetworkHandler should have comment or be unexported (golint)
  • Line 34: warning: exported method MockNetworkHandler.EXPECT should have comment or be unexported (golint)
  • Line 38: warning: exported method MockNetworkHandler.LinkByName should have comment or be unexported (golint)
  • Line 49: warning: exported method MockNetworkHandler.AddrList should have comment or be unexported (golint)
  • Line 60: warning: exported method MockNetworkHandler.ReadIPAddressesFromLink should have comment or be unexported (golint)
  • Line 72: warning: exported method MockNetworkHandler.RouteList should have comment or be unexported (golint)
  • Line 83: warning: exported method MockNetworkHandler.AddrDel should have comment or be unexported (golint)
  • Line 93: warning: exported method MockNetworkHandler.AddrAdd should have comment or be unexported (golint)
  • Line 103: warning: exported method MockNetworkHandler.AddrReplace should have comment or be unexported (golint)
  • Line 113: warning: exported method MockNetworkHandler.LinkSetDown should have comment or be unexported (golint)
  • Line 123: warning: exported method MockNetworkHandler.LinkSetUp should have comment or be unexported (golint)
  • Line 133: warning: exported method MockNetworkHandler.LinkSetName should have comment or be unexported (golint)
  • Line 143: warning: exported method MockNetworkHandler.LinkAdd should have comment or be unexported (golint)
  • Line 153: warning: exported method MockNetworkHandler.LinkSetLearningOff should have comment or be unexported (golint)
  • Line 163: warning: exported method MockNetworkHandler.ParseAddr should have comment or be unexported (golint)
  • Line 174: warning: exported method MockNetworkHandler.SetRandomMac should have comment or be unexported (golint)
  • Line 185: warning: exported method MockNetworkHandler.GetMacDetails should have comment or be unexported (golint)
  • Line 196: warning: exported method MockNetworkHandler.LinkSetMaster should have comment or be unexported (golint)
  • Line 206: warning: exported method MockNetworkHandler.StartDHCP should have comment or be unexported (golint)
  • Line 216: warning: exported method MockNetworkHandler.HasNatIptables should have comment or be unexported (golint)
  • Line 226: warning: exported method MockNetworkHandler.IsIpv6Enabled should have comment or be unexported (golint)
  • Line 237: warning: exported method MockNetworkHandler.IsIpv4Primary should have comment or be unexported (golint)
  • Line 248: warning: exported method MockNetworkHandler.ConfigureIpForwarding should have comment or be unexported (golint)
  • Line 258: warning: exported method MockNetworkHandler.ConfigureIpv4ArpIgnore should have comment or be unexported (golint)
  • Line 268: warning: exported method MockNetworkHandler.IptablesNewChain should have comment or be unexported (golint)
  • Line 278: warning: exported method MockNetworkHandler.IptablesAppendRule should have comment or be unexported (golint)
  • Line 293: warning: exported method MockNetworkHandler.NftablesNewChain should have comment or be unexported (golint)
  • Line 303: warning: exported method MockNetworkHandler.NftablesAppendRule should have comment or be unexported (golint)
  • Line 318: warning: exported method MockNetworkHandler.NftablesLoad should have comment or be unexported (golint)
  • Line 328: warning: exported method MockNetworkHandler.GetNFTIPString should have comment or be unexported (golint)
  • Line 338: warning: exported method MockNetworkHandler.CreateTapDevice should have comment or be unexported (golint)
  • Line 348: warning: exported method MockNetworkHandler.BindTapDeviceToBridge should have comment or be unexported (golint)
  • Line 358: warning: exported method MockNetworkHandler.DisableTXOffloadChecksum should have comment or be unexported (golint)

• kubevirt/pkg/util/net/ip/ip.go
  • Line 1: warning: package comment should be of the form "Package ip ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 33: warning: exported const IPv4Loopback should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/tests/numa/numa.go
  • Line 11: warning: should not use dot imports (golint)
  • Line 12: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-controller/watch/vm.go
  • Line 58: warning: exported type CloneAuthFunc should have comment or be unexported (golint)
  • Line 71: warning: exported const HotPlugVolumeErrorReason should have comment (or a comment on this block) or be unexported (golint)
  • Line 78: warning: exported function NewVMController should have comment or be unexported (golint)
  • Line 136: warning: exported type VMController should have comment or be unexported (golint)
  • Line 152: warning: exported method VMController.Run should have comment or be unexported (golint)
  • Line 178: warning: exported method VMController.Execute should have comment or be unexported (golint)

• kubevirt/tools/perfscale-load-generator/executor/executor.go
  • Line 65: warning: exported method Executor.Run should have comment or be unexported (golint)

• kubevirt/pkg/container-disk/container-disk.go
  • Line 49: warning: exported type SocketPathGetter should have comment or be unexported (golint)
  • Line 50: warning: exported type KernelBootSocketPathGetter should have comment or be unexported (golint)
  • Line 52: warning: exported const KernelBootName should have comment or be unexported (golint)
  • Line 53: warning: exported const KernelBootVolumeName should have comment or be unexported (golint)
  • Line 59: warning: exported function GetLegacyVolumeMountDirOnHost should have comment or be unexported (golint)
  • Line 63: warning: exported function GetVolumeMountDirOnGuest should have comment or be unexported (golint)
  • Line 67: warning: exported function GetVolumeMountDirOnHost should have comment or be unexported (golint)
  • Line 92: warning: exported function GetDiskTargetDirFromHostView should have comment or be unexported (golint)
  • Line 103: warning: exported function GetDiskTargetPathFromHostView should have comment or be unexported (golint)
  • Line 112: warning: exported function GetDiskTargetPathFromLauncherView should have comment or be unexported (golint)
  • Line 116: warning: exported function GetKernelBootArtifactPathFromLauncherView should have comment or be unexported (golint)
  • Line 121: warning: exported function SetLocalDirectory should have comment or be unexported (golint)
  • Line 126: warning: exported function SetKubeletPodsDirectory should have comment or be unexported (golint)
  • Line 187: warning: exported function GetImage should have comment or be unexported (golint)
  • Line 194: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 211: warning: exported function GenerateInitContainers should have comment or be unexported (golint)
  • Line 215: warning: exported function GenerateContainers should have comment or be unexported (golint)
  • Line 219: warning: exported function GenerateKernelBootContainer should have comment or be unexported (golint)
  • Line 223: warning: exported function GenerateKernelBootInitContainer should have comment or be unexported (golint)
  • Line 342: warning: exported function CreateEphemeralImages should have comment or be unexported (golint)

• kubevirt/pkg/util/lookup/lookup.go
  • Line 14: warning: exported function VirtualMachinesOnNode should have comment or be unexported (golint)
  • Line 35: warning: exported function ActiveVirtualMachinesOnNode should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/kubevirt.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 59: warning: exported type KubeVirtController should have comment or be unexported (golint)
  • Line 75: warning: exported function NewKubeVirtController should have comment or be unexported (golint)
  • Line 538: warning: exported method KubeVirtController.Run should have comment or be unexported (golint)
  • Line 580: warning: exported method KubeVirtController.Execute should have comment or be unexported (golint)

• kubevirt/tests/storage/snapshot.go
  • Line 11: warning: should not use dot imports (golint)
  • Line 12: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/flavor-admitter.go
  • Line 16: warning: exported type FlavorAdmitter should have comment or be unexported (golint)
  • Line 20: warning: exported method FlavorAdmitter.Admit should have comment or be unexported (golint)
  • Line 38: warning: exported type ClusterFlavorAdmitter should have comment or be unexported (golint)
  • Line 42: warning: exported method ClusterFlavorAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/tests/framework/matcher/owner.go
  • Line 13: warning: exported function BeOwned should have comment or be unexported (golint)
  • Line 17: warning: exported function HaveOwners should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/version/version.go
  • Line 16: warning: exported function VersionCommand should have comment or be unexported (golint)
  • Line 38: warning: exported type Version should have comment or be unexported (golint)
  • Line 42: warning: exported method Version.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/scc.go
  • Line 1: warning: package comment should be of the form "Package components ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported function GetAllSCC should have comment or be unexported (golint)
  • Line 45: warning: exported function NewKubeVirtHandlerSCC should have comment or be unexported (golint)
  • Line 66: warning: exported function NewKubeVirtControllerSCC should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/apply/delete.go
  • Line 85: warning: exported function DeleteAll should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/device_controller_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-handler/isolation/isolation.go
  • Line 64: warning: exported type RealIsolationResult should have comment or be unexported (golint)
  • Line 71: warning: exported function NewIsolationResult should have comment or be unexported (golint)
  • Line 75: warning: exported method RealIsolationResult.DoNetNS should have comment or be unexported (golint)
  • Line 85: warning: exported method RealIsolationResult.PIDNamespace should have comment or be unexported (golint)
  • Line 89: warning: exported method RealIsolationResult.Slice should have comment or be unexported (golint)
  • Line 93: warning: exported method RealIsolationResult.MountNamespace should have comment or be unexported (golint)
  • Line 138: warning: exported method RealIsolationResult.NetNamespace should have comment or be unexported (golint)
  • Line 142: warning: exported method RealIsolationResult.MountRoot should have comment or be unexported (golint)
  • Line 146: warning: exported method RealIsolationResult.Pid should have comment or be unexported (golint)
  • Line 150: warning: exported method RealIsolationResult.PPid should have comment or be unexported (golint)
  • Line 154: warning: exported method RealIsolationResult.Controller should have comment or be unexported (golint)
  • Line 158: warning: exported function NodeIsolationResult should have comment or be unexported (golint)

• kubevirt/pkg/hooks/hooks.go
  • Line 30: warning: exported const HookSidecarListAnnotationName should have comment or be unexported (golint)
  • Line 31: warning: exported const HookSocketsSharedDirectory should have comment or be unexported (golint)
  • Line 33: warning: exported type HookSidecarList should have comment or be unexported (golint)
  • Line 35: warning: exported type HookSidecar should have comment or be unexported (golint)
  • Line 42: warning: exported function UnmarshalHookSidecarList should have comment or be unexported (golint)

• kubevirt/pkg/rest/filter/filter.go
  • Line 30: warning: exported function RequestLoggingFilter should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/bridge.go
  • Line 12: warning: exported type BridgeConfigGenerator should have comment or be unexported (golint)
  • Line 21: warning: exported method BridgeConfigGenerator.Generate should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/subresource.go
  • Line 54: warning: exported type SubresourceAPIApp should have comment or be unexported (golint)
  • Line 64: warning: exported function NewSubresourceAPIApp should have comment or be unexported (golint)
  • Line 77: warning: exported type URLResolver should have comment or be unexported (golint)
  • Line 168: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 209: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 218: warning: exported method SubresourceAPIApp.MigrateVMRequestHandler should have comment or be unexported (golint)
  • Line 263: warning: exported method SubresourceAPIApp.RestartVMRequestHandler should have comment or be unexported (golint)
  • Line 396: warning: exported method SubresourceAPIApp.StartVMRequestHandler should have comment or be unexported (golint)
  • Line 511: warning: exported method SubresourceAPIApp.StopVMRequestHandler should have comment or be unexported (golint)
  • Line 607: warning: exported method SubresourceAPIApp.PauseVMIRequestHandler should have comment or be unexported (golint)
  • Line 630: warning: exported method SubresourceAPIApp.UnpauseVMIRequestHandler should have comment or be unexported (golint)
  • Line 649: warning: exported method SubresourceAPIApp.FreezeVMIRequestHandler should have comment or be unexported (golint)
  • Line 665: warning: exported method SubresourceAPIApp.UnfreezeVMIRequestHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/util/libvirt_helper.go
  • Line 33: warning: exported const QEMUSeaBiosDebugPipe should have comment or be unexported (golint)
  • Line 41: warning: exported var LifeCycleTranslationMap should have comment or be unexported (golint)
  • Line 52: warning: exported var ShutdownReasonTranslationMap should have comment or be unexported (golint)
  • Line 57: warning: exported var ShutoffReasonTranslationMap should have comment or be unexported (golint)
  • Line 68: warning: exported var CrashedReasonTranslationMap should have comment or be unexported (golint)
  • Line 73: warning: exported var PausedReasonTranslationMap should have comment or be unexported (golint)
  • Line 90: warning: exported type LibvirtWrapper should have comment or be unexported (golint)
  • Line 94: warning: exported function NewLibvirtWrapper should have comment or be unexported (golint)
  • Line 105: warning: exported function ConvState should have comment or be unexported (golint)
  • Line 109: warning: exported function ConvReason should have comment or be unexported (golint)
  • Line 124: warning: comment on exported function SetDomainSpecStr should be of the form "SetDomainSpecStr ..." (golint)
  • Line 135: warning: exported function SetDomainSpecStrWithHooks should have comment or be unexported (golint)
  • Line 211: warning: exported function GetDomainSpecWithFlags should have comment or be unexported (golint)
  • Line 225: warning: exported method LibvirtWrapper.StartLibvirt should have comment or be unexported (golint)
  • Line 400: warning: exported function StartVirtlog should have comment or be unexported (golint)
  • Line 405: warning: comment on exported function SplitVMINamespaceKey should be of the form "SplitVMINamespaceKey ..." (golint)
  • Line 421: warning: exported function DomainFromNamespaceName should have comment or be unexported (golint)
  • Line 425: warning: exported function NewDomain should have comment or be unexported (golint)
  • Line 438: warning: exported function NewDomainFromName should have comment or be unexported (golint)
  • Line 488: warning: exported method LibvirtWrapper.SetupLibvirt should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/vnc/vnc.go
  • Line 43: warning: exported const LISTEN_TIMEOUT should have comment (or a comment on this block) or be unexported (golint)
  • Line 45: warning: comment on exported const MACOS_TIGER_VNC_PATTERN should be of the form "MACOS_TIGER_VNC_PATTERN ..." (golint)
  • Line 50: warning: comment on exported const MACOS_CHICKEN_VNC should be of the form "MACOS_CHICKEN_VNC ..." (golint)
  • Line 54: warning: comment on exported const MACOS_REAL_VNC should be of the form "MACOS_REAL_VNC ..." (golint)
  • Line 65: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 83: warning: exported type VNC should have comment or be unexported (golint)
  • Line 87: warning: exported method VNC.Run should have comment or be unexported (golint)

• kubevirt/pkg/cloud-init/cloud-init.go
  • Line 42: warning: exported type IsoCreationFunc should have comment or be unexported (golint)
  • Line 53: warning: exported type DataSourceType should have comment or be unexported (golint)
  • Line 54: warning: exported type DeviceMetadataType should have comment or be unexported (golint)
  • Line 57: warning: exported const DataSourceNoCloud should have comment (or a comment on this block) or be unexported (golint)
  • Line 74: warning: exported type PublicSSHKey should have comment or be unexported (golint)
  • Line 78: warning: exported type NoCloudMetadata should have comment or be unexported (golint)
  • Line 83: warning: exported type ConfigDriveMetadata should have comment or be unexported (golint)
  • Line 92: warning: exported type DeviceData should have comment or be unexported (golint)
  • Line 417: warning: comment on exported function SetIsoCreationFunction should be of the form "SetIsoCreationFunction ..." (golint)
  • Line 422: warning: exported function SetLocalDirectory should have comment or be unexported (golint)
  • Line 439: warning: comment on exported function SetLocalDirectoryOnly should be of the form "SetLocalDirectoryOnly ..." (golint)
  • Line 449: warning: exported function GetIsoFilePath should have comment or be unexported (golint)
  • Line 459: warning: exported function PrepareLocalPath should have comment or be unexported (golint)
  • Line 472: warning: exported function GenerateEmptyIso should have comment or be unexported (golint)
  • Line 525: warning: exported function GenerateLocalData should have comment or be unexported (golint)

• kubevirt/pkg/certificates/bootstrap/cert-manager.go
  • Line 24: warning: exported const CertBytesValue should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type FileCertificateManager should have comment or be unexported (golint)
  • Line 67: warning: exported type FallbackCertificateManager should have comment or be unexported (golint)
  • Line 72: warning: exported method FallbackCertificateManager.Start should have comment or be unexported (golint)
  • Line 76: warning: exported method FallbackCertificateManager.Stop should have comment or be unexported (golint)
  • Line 80: warning: exported method FallbackCertificateManager.Current should have comment or be unexported (golint)
  • Line 88: warning: exported method FallbackCertificateManager.ServerHealthy should have comment or be unexported (golint)
  • Line 92: warning: exported function NewFileCertificateManager should have comment or be unexported (golint)
  • Line 101: warning: exported method FileCertificateManager.Start should have comment or be unexported (golint)
  • Line 166: warning: exported method FileCertificateManager.Stop should have comment or be unexported (golint)
  • Line 176: warning: exported method FileCertificateManager.ServerHealthy should have comment or be unexported (golint)
  • Line 180: warning: exported method FileCertificateManager.Current should have comment or be unexported (golint)
  • Line 180: warning: receiver name s should be consistent with previous receiver name f for FileCertificateManager (golint)
  • Line 226: warning: exported type SecretCertificateManager should have comment or be unexported (golint)
  • Line 236: warning: exported method SecretCertificateManager.Start should have comment or be unexported (golint)
  • Line 239: warning: exported method SecretCertificateManager.Stop should have comment or be unexported (golint)
  • Line 242: warning: exported method SecretCertificateManager.Current should have comment or be unexported (golint)
  • Line 272: warning: exported method SecretCertificateManager.ServerHealthy should have comment or be unexported (golint)

• kubevirt/pkg/service/service.go
  • Line 36: warning: exported type Service should have comment or be unexported (golint)
  • Line 41: warning: exported type ServiceListen should have comment or be unexported (golint)
  • Line 47: warning: exported type ServiceLibvirt should have comment or be unexported (golint)
  • Line 51: warning: exported method ServiceListen.Address should have comment or be unexported (golint)
  • Line 55: warning: exported method ServiceListen.InitFlags should have comment or be unexported (golint)
  • Line 61: warning: exported method ServiceListen.AddCommonFlags should have comment or be unexported (golint)
  • Line 66: warning: exported method ServiceLibvirt.AddLibvirtFlags should have comment or be unexported (golint)
  • Line 71: warning: exported function Setup should have comment or be unexported (golint)

• kubevirt/tests/performance/density.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• kubevirt/pkg/controller/conditions.go
  • Line 1: warning: package comment should be of the form "Package controller ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 30: warning: exported type VirtualMachineConditionManager should have comment or be unexported (golint)
  • Line 33: warning: exported function NewVirtualMachineConditionManager should have comment or be unexported (golint)
  • Line 37: warning: exported method VirtualMachineConditionManager.GetCondition should have comment or be unexported (golint)
  • Line 49: warning: exported method VirtualMachineConditionManager.HasCondition should have comment or be unexported (golint)
  • Line 53: warning: exported method VirtualMachineConditionManager.RemoveCondition should have comment or be unexported (golint)
  • Line 64: warning: exported type VirtualMachineInstanceConditionManager should have comment or be unexported (golint)
  • Line 84: warning: exported method VirtualMachineInstanceConditionManager.CheckFailure should have comment or be unexported (golint)
  • Line 107: warning: exported method VirtualMachineInstanceConditionManager.GetCondition should have comment or be unexported (golint)
  • Line 119: warning: exported method VirtualMachineInstanceConditionManager.HasCondition should have comment or be unexported (golint)
  • Line 123: warning: exported method VirtualMachineInstanceConditionManager.HasConditionWithStatus should have comment or be unexported (golint)
  • Line 128: warning: exported method VirtualMachineInstanceConditionManager.HasConditionWithStatusAndReason should have comment or be unexported (golint)
  • Line 133: warning: exported method VirtualMachineInstanceConditionManager.RemoveCondition should have comment or be unexported (golint)
  • Line 175: warning: exported method VirtualMachineInstanceConditionManager.PodHasCondition should have comment or be unexported (golint)
  • Line 180: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 188: warning: exported method VirtualMachineInstanceConditionManager.GetPodConditionWithStatus should have comment or be unexported (golint)
  • Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 201: warning: exported method VirtualMachineInstanceConditionManager.GetPodCondition should have comment or be unexported (golint)
  • Line 210: warning: exported function NewVirtualMachineInstanceConditionManager should have comment or be unexported (golint)
  • Line 214: warning: exported type VirtualMachineInstanceMigrationConditionManager should have comment or be unexported (golint)
  • Line 217: warning: exported method VirtualMachineInstanceMigrationConditionManager.HasCondition should have comment or be unexported (golint)
  • Line 226: warning: exported method VirtualMachineInstanceMigrationConditionManager.HasConditionWithStatus should have comment or be unexported (golint)
  • Line 238: warning: exported method VirtualMachineInstanceMigrationConditionManager.RemoveCondition should have comment or be unexported (golint)
  • Line 248: warning: exported function NewVirtualMachineInstanceMigrationConditionManager should have comment or be unexported (golint)
  • Line 252: warning: exported type DataVolumeConditionManager should have comment or be unexported (golint)
  • Line 255: warning: exported method DataVolumeConditionManager.GetCondition should have comment or be unexported (golint)
  • Line 267: warning: exported method DataVolumeConditionManager.HasCondition should have comment or be unexported (golint)
  • Line 271: warning: exported method DataVolumeConditionManager.HasConditionWithStatus should have comment or be unexported (golint)
  • Line 276: warning: exported method DataVolumeConditionManager.HasConditionWithStatusAndReason should have comment or be unexported (golint)
  • Line 281: warning: exported function NewDataVolumeConditionManager should have comment or be unexported (golint)

• kubevirt/pkg/rest/mime.go
  • Line 23: warning: exported const MIME_JSON should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/findmnt.go
  • Line 1: warning: package comment should be of the form "Package hotplug_volume ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 19: warning: don't use an underscore in package name (golint)
  • Line 49: warning: exported type FindmntInfo should have comment or be unexported (golint)
  • Line 56: warning: exported type FileSystems should have comment or be unexported (golint)
  • Line 60: warning: exported function LookupFindmntInfoByVolume should have comment or be unexported (golint)
  • Line 68: warning: exported function LookupFindmntInfoByDevice should have comment or be unexported (golint)
  • Line 84: warning: exported method FindmntInfo.GetSourcePath should have comment or be unexported (golint)
  • Line 92: warning: exported method FindmntInfo.GetSourceDevice should have comment or be unexported (golint)
  • Line 100: warning: exported method FindmntInfo.GetOptions should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/secrets.go
  • Line 36: warning: exported type CertificateCreationCallback should have comment or be unexported (golint)
  • Line 125: warning: exported function PopulateSecretWithCertificate should have comment or be unexported (golint)
  • Line 144: warning: exported function NewCACertSecret should have comment or be unexported (golint)
  • Line 161: warning: exported function NewKubeVirtCAConfigMap should have comment or be unexported (golint)
  • Line 177: warning: exported function NewCertSecrets should have comment or be unexported (golint)
  • Line 254: warning: comment on exported function NextRotationDeadline should be of the form "NextRotationDeadline ..." (golint)
  • Line 297: warning: exported function ValidateSecret should have comment or be unexported (golint)
  • Line 307: warning: exported function LoadCertificates should have comment or be unexported (golint)
  • Line 325: warning: exported function MergeCABundle should have comment or be unexported (golint)

• kubevirt/tools/perfscale-load-generator/watcher/watcher.go
  • Line 47: warning: exported type ObjListWatcher should have comment or be unexported (golint)
  • Line 63: warning: exported function NewObjListWatcher should have comment or be unexported (golint)
  • Line 99: warning: exported method ObjListWatcher.Run should have comment or be unexported (golint)
  • Line 111: warning: exported method ObjListWatcher.Stop should have comment or be unexported (golint)
  • Line 177: warning: exported method ObjListWatcher.WaitRunning should have comment or be unexported (golint)
  • Line 196: warning: exported method ObjListWatcher.WaitDeletion should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/leaderelectionconfig/types.go
  • Line 26: warning: exported type Configuration should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutating-webhook.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 76: warning: exported function ServeVMs should have comment or be unexported (golint)
  • Line 80: warning: exported function ServeVMIs should have comment or be unexported (golint)
  • Line 84: warning: exported function ServeMigrationCreate should have comment or be unexported (golint)

• kubevirt/tools/vms-generator/utils/utils.go
  • Line 40: warning: exported const VmiEphemeral should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: exported const Preemtible should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: exported const VmCirros should have comment (or a comment on this block) or be unexported (golint)
  • Line 78: warning: exported const VmiReplicaSetCirros should have comment or be unexported (golint)
  • Line 80: warning: exported const VmiPresetSmall should have comment or be unexported (golint)
  • Line 82: warning: exported const VmiMigration should have comment or be unexported (golint)
  • Line 99: warning: exported const EthernetAdaptorModelToEnableMultiqueue should have comment or be unexported (golint)
  • Line 101: warning: exported var DockerPrefix should have comment or be unexported (golint)
  • Line 102: warning: exported var DockerTag should have comment or be unexported (golint)
  • Line 365: warning: exported function GetVMIMigratable should have comment or be unexported (golint)
  • Line 376: warning: exported function GetVMIEphemeral should have comment or be unexported (golint)
  • Line 383: warning: exported function GetVMISata should have comment or be unexported (golint)
  • Line 390: warning: exported function GetVMIEphemeralFedora should have comment or be unexported (golint)
  • Line 398: warning: exported function GetVMISecureBoot should have comment or be unexported (golint)
  • Line 421: warning: exported function GetVMIAlpineEFI should have comment or be unexported (golint)
  • Line 438: warning: exported function GetVMISlirp should have comment or be unexported (golint)
  • Line 453: warning: exported function GetVMIMasquerade should have comment or be unexported (golint)
  • Line 469: warning: exported function GetVMISRIOV should have comment or be unexported (golint)
  • Line 482: warning: exported function GetVMIMultusPtp should have comment or be unexported (golint)
  • Line 494: warning: exported function GetVMIMultusMultipleNet should have comment or be unexported (golint)
  • Line 507: warning: exported function GetVMINoCloud should have comment or be unexported (golint)
  • Line 516: warning: exported function GetVMIFlavorSmall should have comment or be unexported (golint)
  • Line 526: warning: exported function GetVMIPvc should have comment or be unexported (golint)
  • Line 533: warning: exported function GetVMIBlockPvc should have comment or be unexported (golint)
  • Line 540: warning: exported function GetVMIHostDisk should have comment or be unexported (golint)
  • Line 546: warning: exported function GetVMIWindows should have comment or be unexported (golint)
  • Line 595: warning: exported function GetVMIKernelBoot should have comment or be unexported (golint)
  • Line 634: warning: exported function GetPreemtible should have comment or be unexported (golint)
  • Line 650: warning: exported function GetNonPreemtible should have comment or be unexported (golint)
  • Line 666: warning: exported function GetVMPriorityClass should have comment or be unexported (golint)
  • Line 673: warning: exported function GetVMCirros should have comment or be unexported (golint)
  • Line 683: warning: exported function GetTemplateFedoraWithContainerDisk should have comment or be unexported (golint)
  • Line 723: warning: exported function GetTemplateFedora should have comment or be unexported (golint)
  • Line 729: warning: exported function GetTemplateRHEL7 should have comment or be unexported (golint)
  • Line 748: warning: exported function GetTestTemplateRHEL7 should have comment or be unexported (golint)
  • Line 781: warning: exported function GetTemplateWindows should have comment or be unexported (golint)
  • Line 880: warning: exported function GetVMDataVolume should have comment or be unexported (golint)
  • Line 919: warning: exported function GetVMMultiPvc should have comment or be unexported (golint)
  • Line 957: warning: exported function GetVMIReplicaSetCirros should have comment or be unexported (golint)
  • Line 983: warning: exported function GetVMIMigration should have comment or be unexported (golint)
  • Line 998: warning: exported function GetVMIPresetSmall should have comment or be unexported (golint)
  • Line 1013: warning: exported function GetVMIWithHookSidecar should have comment or be unexported (golint)
  • Line 1027: warning: exported function GetVMIGPU should have comment or be unexported (golint)
  • Line 1042: warning: exported function GetVMIMacvtap should have comment or be unexported (golint)

• kubevirt/pkg/network/link/address.go
  • Line 66: warning: exported function GenerateMasqueradeGatewayAndVmIPAddrs should have comment or be unexported (golint)
  • Line 103: warning: exported function RetrieveMacAddressFromVMISpecIface should have comment or be unexported (golint)
  • Line 114: warning: exported function GetFakeBridgeIP should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/cache/maps.go
  • Line 15: warning: exported type PodInterfaceByVMIAndName should have comment or be unexported (golint)
  • Line 19: warning: exported method PodInterfaceByVMIAndName.DeleteAllForVMI should have comment or be unexported (golint)
  • Line 29: warning: exported method PodInterfaceByVMIAndName.Load should have comment or be unexported (golint)
  • Line 38: warning: exported method PodInterfaceByVMIAndName.Store should have comment or be unexported (golint)
  • Line 54: warning: exported method PodInterfaceByVMIAndName.Size should have comment or be unexported (golint)
  • Line 58: warning: exported type LauncherPIDByVMI should have comment or be unexported (golint)
  • Line 62: warning: exported method LauncherPIDByVMI.Load should have comment or be unexported (golint)
  • Line 71: warning: exported method LauncherPIDByVMI.Delete should have comment or be unexported (golint)
  • Line 75: warning: exported method LauncherPIDByVMI.Store should have comment or be unexported (golint)
  • Line 79: warning: exported method LauncherPIDByVMI.Size should have comment or be unexported (golint)
  • Line 91: warning: exported type LauncherClientInfo should have comment or be unexported (golint)
  • Line 99: warning: exported type LauncherClientInfoByVMI should have comment or be unexported (golint)
  • Line 103: warning: exported method LauncherClientInfoByVMI.Delete should have comment or be unexported (golint)
  • Line 107: warning: exported method LauncherClientInfoByVMI.Store should have comment or be unexported (golint)
  • Line 111: warning: exported method LauncherClientInfoByVMI.Load should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/mount_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-api/rest/portforward.go
  • Line 14: warning: exported method SubresourceAPIApp.PortForwardRequestHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/sriov/hostdev.go
  • Line 38: warning: exported const AliasPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 45: warning: exported function CreateHostDevices should have comment or be unexported (golint)
  • Line 50: warning: exported function CreateHostDevicesFromIfacesAndPool should have comment or be unexported (golint)
  • Line 91: warning: exported function SafelyDetachHostDevices should have comment or be unexported (golint)
  • Line 114: warning: exported function FilterHostDevices should have comment or be unexported (golint)
  • Line 184: warning: exported function AttachHostDevices should have comment or be unexported (golint)
  • Line 221: warning: exported function GetHostDevicesToAttach should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/util/readycheck.go
  • Line 32: warning: exported function DaemonsetIsReady should have comment or be unexported (golint)
  • Line 81: warning: exported function DeploymentIsReady should have comment or be unexported (golint)

• kubevirt/pkg/watchdog/watchdog.go
  • Line 36: warning: exported function WatchdogFileDirectory should have comment or be unexported (golint)
  • Line 40: warning: exported function WatchdogFileFromNamespaceName should have comment or be unexported (golint)
  • Line 45: warning: comment on exported function WatchdogFileGetUID should be of the form "WatchdogFileGetUID ..." (golint)
  • Line 60: warning: exported function WatchdogFileRemove should have comment or be unexported (golint)
  • Line 70: warning: exported function WatchdogFileUpdate should have comment or be unexported (golint)
  • Line 84: warning: exported function WatchdogFileExists should have comment or be unexported (golint)
  • Line 98: warning: exported function WatchdogFileIsExpired should have comment or be unexported (golint)
  • Line 137: warning: exported function GetExpiredDomains should have comment or be unexported (golint)

• kubevirt/tests/libreplicaset/replicaset.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)
  • Line 17: warning: exported function DoScaleWithScaleSubresource should have comment or be unexported (golint)

• kubevirt/pkg/handler-launcher-com/cmd/v1/generated_mock_cmd.go
  • Line 12: warning: comment on exported type MockCmdClient should be of the form "MockCmdClient ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockCmdClient should have comment or be unexported (golint)
  • Line 29: warning: exported method MockCmdClient.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockCmdClient.SyncVirtualMachine should have comment or be unexported (golint)
  • Line 49: warning: exported method MockCmdClient.PauseVirtualMachine should have comment or be unexported (golint)
  • Line 65: warning: exported method MockCmdClient.UnpauseVirtualMachine should have comment or be unexported (golint)
  • Line 81: warning: exported method MockCmdClient.FreezeVirtualMachine should have comment or be unexported (golint)
  • Line 97: warning: exported method MockCmdClient.UnfreezeVirtualMachine should have comment or be unexported (golint)
  • Line 113: warning: exported method MockCmdClient.ShutdownVirtualMachine should have comment or be unexported (golint)
  • Line 129: warning: exported method MockCmdClient.KillVirtualMachine should have comment or be unexported (golint)
  • Line 145: warning: exported method MockCmdClient.DeleteVirtualMachine should have comment or be unexported (golint)
  • Line 161: warning: exported method MockCmdClient.MigrateVirtualMachine should have comment or be unexported (golint)
  • Line 177: warning: exported method MockCmdClient.SyncMigrationTarget should have comment or be unexported (golint)
  • Line 193: warning: exported method MockCmdClient.CancelVirtualMachineMigration should have comment or be unexported (golint)
  • Line 209: warning: exported method MockCmdClient.SignalTargetPodCleanup should have comment or be unexported (golint)
  • Line 225: warning: exported method MockCmdClient.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 241: warning: exported method MockCmdClient.GetDomain should have comment or be unexported (golint)
  • Line 257: warning: exported method MockCmdClient.GetDomainStats should have comment or be unexported (golint)
  • Line 273: warning: exported method MockCmdClient.GetGuestInfo should have comment or be unexported (golint)
  • Line 289: warning: exported method MockCmdClient.GetUsers should have comment or be unexported (golint)
  • Line 305: warning: exported method MockCmdClient.GetFilesystems should have comment or be unexported (golint)
  • Line 321: warning: exported method MockCmdClient.Ping should have comment or be unexported (golint)
  • Line 337: warning: exported method MockCmdClient.Exec should have comment or be unexported (golint)
  • Line 353: warning: exported method MockCmdClient.GuestPing should have comment or be unexported (golint)
  • Line 369: warning: comment on exported type MockCmdServer should be of the form "MockCmdServer ..." (with optional leading article) (golint)
  • Line 380: warning: exported function NewMockCmdServer should have comment or be unexported (golint)
  • Line 386: warning: exported method MockCmdServer.EXPECT should have comment or be unexported (golint)
  • Line 390: warning: exported method MockCmdServer.SyncVirtualMachine should have comment or be unexported (golint)
  • Line 401: warning: exported method MockCmdServer.PauseVirtualMachine should have comment or be unexported (golint)
  • Line 412: warning: exported method MockCmdServer.UnpauseVirtualMachine should have comment or be unexported (golint)
  • Line 423: warning: exported method MockCmdServer.FreezeVirtualMachine should have comment or be unexported (golint)
  • Line 434: warning: exported method MockCmdServer.UnfreezeVirtualMachine should have comment or be unexported (golint)
  • Line 445: warning: exported method MockCmdServer.ShutdownVirtualMachine should have comment or be unexported (golint)
  • Line 456: warning: exported method MockCmdServer.KillVirtualMachine should have comment or be unexported (golint)
  • Line 467: warning: exported method MockCmdServer.DeleteVirtualMachine should have comment or be unexported (golint)
  • Line 478: warning: exported method MockCmdServer.MigrateVirtualMachine should have comment or be unexported (golint)
  • Line 489: warning: exported method MockCmdServer.SyncMigrationTarget should have comment or be unexported (golint)
  • Line 500: warning: exported method MockCmdServer.CancelVirtualMachineMigration should have comment or be unexported (golint)
  • Line 511: warning: exported method MockCmdServer.SignalTargetPodCleanup should have comment or be unexported (golint)
  • Line 522: warning: exported method MockCmdServer.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 533: warning: exported method MockCmdServer.GetDomain should have comment or be unexported (golint)
  • Line 544: warning: exported method MockCmdServer.GetDomainStats should have comment or be unexported (golint)
  • Line 555: warning: exported method MockCmdServer.GetGuestInfo should have comment or be unexported (golint)
  • Line 566: warning: exported method MockCmdServer.GetUsers should have comment or be unexported (golint)
  • Line 577: warning: exported method MockCmdServer.GetFilesystems should have comment or be unexported (golint)
  • Line 588: warning: exported method MockCmdServer.Ping should have comment or be unexported (golint)
  • Line 599: warning: exported method MockCmdServer.Exec should have comment or be unexported (golint)
  • Line 610: warning: exported method MockCmdServer.GuestPing should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutators/migration-create-mutator.go
  • Line 34: warning: exported type MigrationCreateMutator should have comment or be unexported (golint)
  • Line 37: warning: exported method MigrationCreateMutator.Mutate should have comment or be unexported (golint)

• kubevirt/tests/network/dual_stack_cluster.go
  • Line 4: warning: should not use dot imports (golint)
  • Line 5: warning: should not use dot imports (golint)

• kubevirt/tests/utils.go
  • Line 51: warning: should not use dot imports (golint)
  • Line 53: warning: should not use dot imports (golint)
  • Line 113: warning: should not use dot imports (golint)
  • Line 121: warning: exported var Config should have comment or be unexported (golint)
  • Line 122: warning: exported var KubeVirtDefaultConfig should have comment or be unexported (golint)
  • Line 123: warning: exported var Arch should have comment or be unexported (golint)
  • Line 125: warning: exported type EventType should have comment or be unexported (golint)
  • Line 127: warning: exported const TempDirPrefix should have comment or be unexported (golint)
  • Line 135: warning: exported const NormalEvent should have comment (or a comment on this block) or be unexported (golint)
  • Line 142: warning: exported const SubresourceServiceAccountName should have comment (or a comment on this block) or be unexported (golint)
  • Line 148: warning: exported const SubresourceTestLabel should have comment or be unexported (golint)
  • Line 156: warning: exported var TestNamespaces should have comment or be unexported (golint)
  • Line 175: warning: exported const OSWindows should have comment (or a comment on this block) or be unexported (golint)
  • Line 183: warning: exported var HostPathAlpine should have comment or be unexported (golint)
  • Line 188: warning: exported const DiskAlpineHostPath should have comment (or a comment on this block) or be unexported (golint)
  • Line 199: warning: exported const VMIResource should have comment or be unexported (golint)
  • Line 202: warning: exported const SecretLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 206: warning: exported const IstioInjectNamespaceLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 224: warning: exported const MigrationWaitTime should have comment or be unexported (golint)
  • Line 225: warning: exported const ContainerCompletionWaitTime should have comment or be unexported (golint)
  • Line 233: warning: exported type ProcessFunc should have comment or be unexported (golint)
  • Line 235: warning: exported type ObjectEventWatcher should have comment or be unexported (golint)
  • Line 244: warning: exported type WarningsPolicy should have comment or be unexported (golint)
  • Line 261: warning: exported function NewObjectEventWatcher should have comment or be unexported (golint)
  • Line 265: warning: exported method ObjectEventWatcher.Timeout should have comment or be unexported (golint)
  • Line 270: warning: exported method ObjectEventWatcher.SetWarningsPolicy should have comment or be unexported (golint)
  • Line 314: warning: exported method ObjectEventWatcher.Watch should have comment or be unexported (golint)
  • Line 414: warning: exported method ObjectEventWatcher.WaitFor should have comment or be unexported (golint)
  • Line 425: warning: exported method ObjectEventWatcher.WaitNotFor should have comment or be unexported (golint)
  • Line 438: warning: exported function WaitForAllPodsReady should have comment or be unexported (golint)
  • Line 467: warning: exported function SynchronizedAfterTestSuiteCleanup should have comment or be unexported (golint)
  • Line 478: warning: exported function AfterTestSuitCleanup should have comment or be unexported (golint)
  • Line 489: warning: exported function BeforeTestCleanup should have comment or be unexported (golint)
  • Line 498: warning: exported function CleanNodes should have comment or be unexported (golint)
  • Line 562: warning: exported function AddLabelToNode should have comment or be unexported (golint)
  • Line 583: warning: exported function RemoveLabelFromNode should have comment or be unexported (golint)
  • Line 608: warning: exported function Taint should have comment or be unexported (golint)
  • Line 643: warning: exported function SynchronizedBeforeTestSetup should have comment or be unexported (golint)
  • Line 671: warning: exported function BeforeTestSuitSetup should have comment or be unexported (golint)
  • Line 710: warning: exported function AdjustKubeVirtResource should have comment or be unexported (golint)
  • Line 791: warning: exported function RestoreKubeVirtResource should have comment or be unexported (golint)
  • Line 837: warning: exported function ShouldAllowEmulation should have comment or be unexported (golint)
  • Line 850: warning: exported function EnsureKVMPresent should have comment or be unexported (golint)
  • Line 877: warning: exported function GetNodesWithKVM should have comment or be unexported (golint)
  • Line 898: warning: exported function GetSupportedCPUFeatures should have comment or be unexported (golint)
  • Line 921: warning: exported function GetSupportedCPUModels should have comment or be unexported (golint)
  • Line 945: warning: exported function CreateConfigMap should have comment or be unexported (golint)
  • Line 958: warning: exported function CreateSecret should have comment or be unexported (golint)
  • Line 971: warning: exported function CreateHostPathPVC should have comment or be unexported (golint)
  • Line 975: warning: exported function CreatePVC should have comment or be unexported (golint)
  • Line 986: warning: exported function CreateRuntimeClass should have comment or be unexported (golint)
  • Line 1002: warning: exported function DeleteRuntimeClass should have comment or be unexported (golint)
  • Line 1043: warning: exported function DeleteAllSeparateDeviceHostPathPvs should have comment or be unexported (golint)
  • Line 1057: warning: exported function CreateAllSeparateDeviceHostPathPvs should have comment or be unexported (golint)
  • Line 1119: warning: exported function CreateHostPathPv should have comment or be unexported (golint)
  • Line 1123: warning: exported function CreateHostPathPvWithSize should have comment or be unexported (golint)
  • Line 1179: warning: exported function GetListOfManifests should have comment or be unexported (golint)
  • Line 1205: warning: exported function ReadManifestYamlFile should have comment or be unexported (golint)
  • Line 1235: warning: exported function IsOpenShift should have comment or be unexported (golint)
  • Line 1248: warning: exported function ServiceMonitorEnabled should have comment or be unexported (golint)
  • Line 1292: warning: exported function ApplyRawManifest should have comment or be unexported (golint)
  • Line 1308: warning: exported function DeleteRawManifest should have comment or be unexported (golint)
  • Line 1340: warning: exported function DeployTestingInfrastructure should have comment or be unexported (golint)
  • Line 1344: warning: exported function WipeTestingInfrastructure should have comment or be unexported (golint)
  • Line 1510: warning: exported function DeleteConfigMap should have comment or be unexported (golint)
  • Line 1520: warning: exported function DeleteSecret should have comment or be unexported (golint)
  • Line 1530: warning: exported function DeletePVC should have comment or be unexported (golint)
  • Line 1541: warning: exported function DeletePV should have comment or be unexported (golint)
  • Line 1552: warning: exported function VerifyDummyNicForBridgeNetwork should have comment or be unexported (golint)
  • Line 1562: warning: exported function RunVMI should have comment or be unexported (golint)
  • Line 1575: warning: exported function RunVMIAndExpectLaunch should have comment or be unexported (golint)
  • Line 1582: warning: exported function RunVMIAndExpectLaunchWithDataVolume should have comment or be unexported (golint)
  • Line 1595: warning: exported function RunVMIAndExpectLaunchIgnoreWarnings should have comment or be unexported (golint)
  • Line 1602: warning: exported function RunVMIAndExpectLaunchWithIgnoreWarningArg should have comment or be unexported (golint)
  • Line 1623: warning: exported function RunVMIAndExpectScheduling should have comment or be unexported (golint)
  • Line 1645: warning: exported function GetRunningPodByVirtualMachineInstance should have comment or be unexported (golint)
  • Line 1651: warning: exported function GetPodByVirtualMachineInstance should have comment or be unexported (golint)
  • Line 1680: warning: exported function GetRunningPodByLabel should have comment or be unexported (golint)
  • Line 1725: warning: exported function GetComputeContainerOfPod should have comment or be unexported (golint)
  • Line 1729: warning: exported function GetContainerDiskContainerOfPod should have comment or be unexported (golint)
  • Line 1734: warning: exported function GetContainerOfPod should have comment or be unexported (golint)
  • Line 1945: warning: exported function NewRandomDataVolumeWithRegistryImport should have comment or be unexported (golint)
  • Line 1949: warning: exported function NewRandomBlankDataVolume should have comment or be unexported (golint)
  • Line 1953: warning: exported function NewRandomVirtualMachineInstanceWithOCSDisk should have comment or be unexported (golint)
  • Line 1972: warning: exported function NewRandomDataVolumeWithRegistryImportInStorageClass should have comment or be unexported (golint)
  • Line 2041: warning: exported function NewRandomDataVolumeWithPVCSource should have comment or be unexported (golint)
  • Line 2045: warning: exported function NewRandomDataVolumeWithPVCSourceWithStorageClass should have comment or be unexported (golint)
  • Line 2081: warning: exported function NewRandomVMI should have comment or be unexported (golint)
  • Line 2085: warning: exported function NewRandomVMIWithNS should have comment or be unexported (golint)
  • Line 2109: warning: exported function NewRandomVMIWithDataVolume should have comment or be unexported (golint)
  • Line 2135: warning: exported function NewRandomVMWithEphemeralDisk should have comment or be unexported (golint)
  • Line 2151: warning: exported function NewRandomVMWithRegistryDataVolume should have comment or be unexported (golint)
  • Line 2160: warning: exported function NewRandomVMWithDataVolumeWithRegistryImport should have comment or be unexported (golint)
  • Line 2170: warning: exported function NewRandomVMWithDataVolume should have comment or be unexported (golint)
  • Line 2179: warning: exported function NewRandomVMWithDataVolumeInStorageClass should have comment or be unexported (golint)
  • Line 2188: warning: exported function NewRandomVMWithDataVolumeAndUserData should have comment or be unexported (golint)
  • Line 2197: warning: exported function NewRandomVMWithDataVolumeAndUserDataInStorageClass should have comment or be unexported (golint)
  • Line 2202: warning: exported function NewRandomVMWithCloneDataVolume should have comment or be unexported (golint)
  • Line 2212: warning: exported function NewRandomVMIWithEphemeralDiskHighMemory should have comment or be unexported (golint)
  • Line 2219: warning: exported function NewRandomVMIWithEphemeralDiskAndUserdataHighMemory should have comment or be unexported (golint)
  • Line 2226: warning: exported function NewRandomVMIWithEphemeralDiskAndConfigDriveUserdataHighMemory should have comment or be unexported (golint)
  • Line 2233: warning: exported function NewRandomVMIWithEFIBootloader should have comment or be unexported (golint)
  • Line 2250: warning: exported function NewRandomVMIWithSecureBoot should have comment or be unexported (golint)
  • Line 2270: warning: exported function NewRandomMigration should have comment or be unexported (golint)
  • Line 2286: warning: exported function NewRandomVMIWithEphemeralDisk should have comment or be unexported (golint)
  • Line 2296: warning: exported function AddEphemeralDisk should have comment or be unexported (golint)
  • Line 2317: warning: exported function AddBootOrderToDisk should have comment or be unexported (golint)
  • Line 2327: warning: exported function AddPVCDisk should have comment or be unexported (golint)
  • Line 2348: warning: exported function AddEphemeralCdrom should have comment or be unexported (golint)
  • Line 2369: warning: exported function NewRandomFedoraVMI should have comment or be unexported (golint)
  • Line 2380: warning: exported function NewRandomFedoraVMIWithGuestAgent should have comment or be unexported (golint)
  • Line 2391: warning: exported function NewRandomFedoraVMIWithBlacklistGuestAgent should have comment or be unexported (golint)
  • Line 2403: warning: exported function AddPVCFS should have comment or be unexported (golint)
  • Line 2420: warning: exported function NewRandomVMIWithFSFromDataVolume should have comment or be unexported (golint)
  • Line 2439: warning: exported function NewRandomVMIWithPVCFS should have comment or be unexported (golint)
  • Line 2448: warning: exported function NewRandomFedoraVMIWithDmidecode should have comment or be unexported (golint)
  • Line 2453: warning: exported function NewRandomFedoraVMIWithVirtWhatCpuidHelper should have comment or be unexported (golint)
  • Line 2458: warning: exported function GetFedoraToolsGuestAgentBlacklistUserData should have comment or be unexported (golint)
  • Line 2464: warning: exported function NewRandomVMIWithEphemeralDiskAndUserdata should have comment or be unexported (golint)
  • Line 2470: warning: exported function NewRandomVMIWithEphemeralDiskAndConfigDriveUserdata should have comment or be unexported (golint)
  • Line 2476: warning: exported function NewRandomVMIWithEphemeralDiskAndUserdataNetworkData should have comment or be unexported (golint)
  • Line 2482: warning: exported function NewRandomVMIWithEphemeralDiskAndConfigDriveUserdataNetworkData should have comment or be unexported (golint)
  • Line 2488: warning: exported function AddUserData should have comment or be unexported (golint)
  • Line 2492: warning: exported function AddCloudInitNoCloudData should have comment or be unexported (golint)
  • Line 2508: warning: exported function AddCloudInitConfigDriveData should have comment or be unexported (golint)
  • Line 2539: warning: exported function NewRandomVMIWithPVC should have comment or be unexported (golint)
  • Line 2546: warning: exported function NewRandomVMIWithPVCAndUserData should have comment or be unexported (golint)
  • Line 2554: warning: exported function CreateBlockVolumePvAndPvc should have comment or be unexported (golint)
  • Line 2644: warning: exported function DeletePvAndPvc should have comment or be unexported (golint)
  • Line 2663: warning: exported function NewRandomVMIWithCDRom should have comment or be unexported (golint)
  • Line 2687: warning: exported function NewRandomVMIWithEphemeralPVC should have comment or be unexported (golint)
  • Line 2712: warning: exported function AddHostDisk should have comment or be unexported (golint)
  • Line 2737: warning: exported function NewRandomVMIWithHostDisk should have comment or be unexported (golint)
  • Line 2762: warning: exported function NewRandomVMIWithWatchdog should have comment or be unexported (golint)
  • Line 2776: warning: exported function NewRandomVMIWithConfigMap should have comment or be unexported (golint)
  • Line 2782: warning: exported function AddConfigMapDisk should have comment or be unexported (golint)
  • Line 2786: warning: exported function AddConfigMapDiskWithCustomLabel should have comment or be unexported (golint)
  • Line 2803: warning: exported function NewRandomVMIWithSecret should have comment or be unexported (golint)
  • Line 2809: warning: exported function AddSecretDisk should have comment or be unexported (golint)
  • Line 2813: warning: exported function AddSecretDiskWithCustomLabel should have comment or be unexported (golint)
  • Line 2828: warning: exported function AddLabelDownwardAPIVolume should have comment or be unexported (golint)
  • Line 2851: warning: exported function AddDownwardMetricsVolume should have comment or be unexported (golint)
  • Line 2868: warning: exported function NewRandomVMIWithServiceAccount should have comment or be unexported (golint)
  • Line 2874: warning: exported function AddServiceAccountDisk should have comment or be unexported (golint)
  • Line 2889: warning: exported function NewRandomVMIWithSlirpInterfaceEphemeralDiskAndUserdata should have comment or be unexported (golint)
  • Line 2897: warning: exported function NewRandomVMIWithMasqueradeInterfaceEphemeralDiskAndUserdata should have comment or be unexported (golint)
  • Line 2905: warning: exported function AddExplicitPodNetworkInterface should have comment or be unexported (golint)
  • Line 2910: warning: exported function NewRandomVMIWithe1000NetworkInterface should have comment or be unexported (golint)
  • Line 2918: warning: exported function NewRandomVMIWithCustomMacAddress should have comment or be unexported (golint)
  • Line 2925: warning: comment on exported function WaitForVMIStartOrFailed should be of the form "WaitForVMIStartOrFailed ..." (golint)
  • Line 2986: warning: exported function WaitForSuccessfulVMIStartIgnoreWarnings should have comment or be unexported (golint)
  • Line 2993: warning: exported function WaitForSuccessfulVMIStartWithTimeout should have comment or be unexported (golint)
  • Line 3000: warning: exported function WaitForSuccessfulVMIStartWithTimeoutIgnoreWarnings should have comment or be unexported (golint)
  • Line 3007: warning: exported function WaitForPodToDisappearWithTimeout should have comment or be unexported (golint)
  • Line 3016: warning: exported function WaitForVirtualMachineToDisappearWithTimeout should have comment or be unexported (golint)
  • Line 3025: warning: exported function WaitForMigrationToDisappearWithTimeout should have comment or be unexported (golint)
  • Line 3034: warning: exported function WaitForSuccessfulVMIStart should have comment or be unexported (golint)
  • Line 3040: warning: exported function WaitForSuccessfulVMIStartWithContext should have comment or be unexported (golint)
  • Line 3045: warning: exported function WaitForSuccessfulVMIStartWithContextIgnoreSelectedWarnings should have comment or be unexported (golint)
  • Line 3050: warning: exported function WaitUntilVMIReadyAsync should have comment or be unexported (golint)
  • Line 3068: warning: exported function WaitUntilVMIReady should have comment or be unexported (golint)
  • Line 3074: warning: exported function WaitUntilVMIReadyIgnoreSelectedWarnings should have comment or be unexported (golint)
  • Line 3080: warning: exported function WaitUntilVMIReadyWithContext should have comment or be unexported (golint)
  • Line 3086: warning: exported function WaitUntilVMIReadyWithContextIgnoreSelectedWarnings should have comment or be unexported (golint)
  • Line 3092: warning: exported function LoginToVM should have comment or be unexported (golint)
  • Line 3106: warning: exported function NewInt32 should have comment or be unexported (golint)
  • Line 3110: warning: exported function NewRandomReplicaSetFromVMI should have comment or be unexported (golint)
  • Line 3131: warning: exported function NewBool should have comment or be unexported (golint)
  • Line 3135: warning: exported function RenderPrivilegedPod should have comment or be unexported (golint)
  • Line 3152: warning: exported function RenderPod should have comment or be unexported (golint)
  • Line 3198: warning: exported function NewVirtctlCommand should have comment or be unexported (golint)
  • Line 3213: warning: exported function NewRepeatableVirtctlCommand should have comment or be unexported (golint)
  • Line 3220: warning: exported function ExecuteCommandOnCephToolbox should have comment or be unexported (golint)
  • Line 3239: warning: exported function ExecuteCommandOnPod should have comment or be unexported (golint)
  • Line 3253: warning: exported function CopyFromPod should have comment or be unexported (golint)
  • Line 3270: warning: exported function ExecuteCommandOnPodV2 should have comment or be unexported (golint)
  • Line 3315: warning: exported function GetRunningVirtualMachineInstanceDomainXML should have comment or be unexported (golint)
  • Line 3358: warning: exported function LibvirtDomainIsPaused should have comment or be unexported (golint)
  • Line 3388: warning: exported function LibvirtDomainIsPersistent should have comment or be unexported (golint)
  • Line 3418: warning: comment on exported function BeforeAll should be of the form "BeforeAll ..." (golint)
  • Line 3430: warning: exported function SkipIfNonRoot should have comment or be unexported (golint)
  • Line 3436: warning: exported function SkipIfMissingRequiredImage should have comment or be unexported (golint)
  • Line 3447: warning: exported function SkipIfNoRhelImage should have comment or be unexported (golint)
  • Line 3458: warning: exported function SkipIfUseFlannel should have comment or be unexported (golint)
  • Line 3467: warning: exported function GetHighestCPUNumberAmongNodes should have comment or be unexported (golint)
  • Line 3482: warning: exported function GetK8sCmdClient should have comment or be unexported (golint)
  • Line 3491: warning: exported function SkipIfNoCmd should have comment or be unexported (golint)
  • Line 3508: warning: exported function RunCommand should have comment or be unexported (golint)
  • Line 3512: warning: exported function RunCommandWithNS should have comment or be unexported (golint)
  • Line 3516: warning: exported function RunCommandWithNSAndInput should have comment or be unexported (golint)
  • Line 3542: warning: exported function CreateCommandWithNS should have comment or be unexported (golint)
  • Line 3592: warning: exported function RunCommandPipe should have comment or be unexported (golint)
  • Line 3596: warning: exported function RunCommandPipeWithNS should have comment or be unexported (golint)
  • Line 3693: warning: exported function GenerateVMJson should have comment or be unexported (golint)
  • Line 3707: warning: exported function GenerateVMIJson should have comment or be unexported (golint)
  • Line 3721: warning: exported function GenerateTemplateJson should have comment or be unexported (golint)
  • Line 3734: warning: exported function NotDeleted should have comment or be unexported (golint)
  • Line 3743: warning: exported function Running should have comment or be unexported (golint)
  • Line 3752: warning: exported function UnfinishedVMIPodSelector should have comment or be unexported (golint)
  • Line 3775: warning: exported function RemoveHostDiskImage should have comment or be unexported (golint)
  • Line 3785: warning: exported function CreateNFSPvAndPvc should have comment or be unexported (golint)
  • Line 3863: warning: exported function CreateHostDiskImage should have comment or be unexported (golint)
  • Line 3878: warning: exported function RenderHostPathPod should have comment or be unexported (golint)
  • Line 3898: warning: exported function GetNodeWithHugepages should have comment or be unexported (golint)
  • Line 3920: warning: exported function SkipIfVersionAboveOrEqual should have comment or be unexported (golint)
  • Line 3929: warning: exported function SkipIfOpenShift should have comment or be unexported (golint)
  • Line 3935: warning: exported function SkipIfOpenShift4 should have comment or be unexported (golint)
  • Line 3946: warning: exported function SkipIfMigrationIsNotPossible should have comment or be unexported (golint)
  • Line 4047: warning: exported function NewRandomVirtualMachine should have comment or be unexported (golint)
  • Line 4075: warning: exported function StopVirtualMachineWithTimeout should have comment or be unexported (golint)
  • Line 4106: warning: exported function StopVirtualMachine should have comment or be unexported (golint)
  • Line 4110: warning: exported function StartVirtualMachine should have comment or be unexported (golint)
  • Line 4138: warning: exported function DisableFeatureGate should have comment or be unexported (golint)
  • Line 4167: warning: exported function EnableFeatureGate should have comment or be unexported (golint)
  • Line 4187: warning: exported function HasDataVolumeCRD should have comment or be unexported (golint)
  • Line 4202: warning: exported function HasCDI should have comment or be unexported (golint)
  • Line 4218: warning: exported function SkipIfARM64 should have comment or be unexported (golint)
  • Line 4224: warning: exported function HasBindingModeWaitForFirstConsumer should have comment or be unexported (golint)
  • Line 4236: warning: exported function GetCephStorageClass should have comment or be unexported (golint)
  • Line 4250: warning: exported function HasExperimentalIgnitionSupport should have comment or be unexported (golint)
  • Line 4254: warning: exported function HasLiveMigration should have comment or be unexported (golint)
  • Line 4258: warning: exported function GetVmPodName should have comment or be unexported (golint)
  • Line 4278: warning: exported function AppendEmptyDisk should have comment or be unexported (golint)
  • Line 4297: warning: exported function GetRunningVMIDomainSpec should have comment or be unexported (golint)
  • Line 4313: warning: exported function ForwardPorts should have comment or be unexported (golint)
  • Line 4361: warning: exported function GenerateHelloWorldServer should have comment or be unexported (golint)
  • Line 4435: warning: exported function UpdateCDIConfigMap should have comment or be unexported (golint)
  • Line 4484: warning: exported function ExpectResourceVersionToBeLessThanConfigVersion should have comment or be unexported (golint)
  • Line 4505: warning: exported function ExpectResourceVersionToBeEqualConfigVersion should have comment or be unexported (golint)
  • Line 4520: warning: exported function WaitForConfigToBePropagatedToComponent should have comment or be unexported (golint)
  • Line 4557: warning: exported function WaitAgentConnected should have comment or be unexported (golint)
  • Line 4561: warning: exported function WaitForVMICondition should have comment or be unexported (golint)
  • Line 4575: warning: exported function WaitForVMIConditionRemovedOrFalse should have comment or be unexported (golint)
  • Line 4589: warning: exported function WaitForVMCondition should have comment or be unexported (golint)
  • Line 4603: warning: exported function WaitForVMConditionRemovedOrFalse should have comment or be unexported (golint)
  • Line 4661: warning: exported function PodReady should have comment or be unexported (golint)
  • Line 4670: warning: exported function RetryWithMetadataIfModified should have comment or be unexported (golint)
  • Line 4676: warning: exported function RetryIfModified should have comment or be unexported (golint)
  • Line 4688: warning: exported function GenerateRandomMac should have comment or be unexported (golint)
  • Line 4733: warning: exported function CallUrlOnPod should have comment or be unexported (golint)
  • Line 4817: warning: exported function GetCertFromSecret should have comment or be unexported (golint)
  • Line 4828: warning: exported function GetBundleFromConfigMap should have comment or be unexported (golint)
  • Line 4841: warning: exported function ContainsCrt should have comment or be unexported (golint)
  • Line 4855: warning: exported function FormatIPForURL should have comment or be unexported (golint)
  • Line 4862: warning: exported function GetKubernetesApiServiceIp should have comment or be unexported (golint)
  • Line 4873: warning: exported function IsRunningOnKindInfra should have comment or be unexported (golint)
  • Line 4878: warning: exported function IsUsingBuiltinNodeDrainKey should have comment or be unexported (golint)
  • Line 4882: warning: exported function GetNodeDrainKey should have comment or be unexported (golint)
  • Line 4894: warning: exported function GetKubeVirtConfigMap should have comment or be unexported (golint)
  • Line 4907: warning: exported function RandTmpDir should have comment or be unexported (golint)
  • Line 4929: warning: exported function DetectLatestUpstreamOfficialTag should have comment or be unexported (golint)
  • Line 4989: warning: exported function IsLauncherCapabilityValid should have comment or be unexported (golint)
  • Line 4999: warning: exported function IsLauncherCapabilityDropped should have comment or be unexported (golint)
  • Line 5025: warning: exported function CheckCloudInitMetaData should have comment or be unexported (golint)
  • Line 5038: warning: exported function MountCloudInitFunc should have comment or be unexported (golint)
  • Line 5053: warning: exported function DryRunCreate should have comment or be unexported (golint)
  • Line 5064: warning: exported function DryRunUpdate should have comment or be unexported (golint)
  • Line 5076: warning: exported function DryRunPatch should have comment or be unexported (golint)
  • Line 5088: warning: exported function VerifyVolumeAndDiskVMAdded should have comment or be unexported (golint)
  • Line 5129: warning: exported function VerifyVolumeAndDiskVMIAdded should have comment or be unexported (golint)
  • Line 5165: warning: exported function AddVolumeAndVerify should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/operator.go
  • Line 1: warning: package comment should be of the form "Package rbac ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 31: warning: exported const OperatorServiceAccountName should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function GetAllOperator should be of the form "GetAllOperator ..." (golint)
  • Line 60: warning: comment on exported function NewOperatorClusterRole should be of the form "NewOperatorClusterRole ..." (golint)
  • Line 496: warning: exported function GetKubevirtComponentsServiceAccounts should have comment or be unexported (golint)

• kubevirt/tests/network/port_forward.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-handler/cmd-client/generated_mock_client.go
  • Line 15: warning: comment on exported type MockLauncherClient should be of the form "MockLauncherClient ..." (with optional leading article) (golint)
  • Line 26: warning: exported function NewMockLauncherClient should have comment or be unexported (golint)
  • Line 32: warning: exported method MockLauncherClient.EXPECT should have comment or be unexported (golint)
  • Line 36: warning: exported method MockLauncherClient.SyncVirtualMachine should have comment or be unexported (golint)
  • Line 46: warning: exported method MockLauncherClient.PauseVirtualMachine should have comment or be unexported (golint)
  • Line 56: warning: exported method MockLauncherClient.UnpauseVirtualMachine should have comment or be unexported (golint)
  • Line 66: warning: exported method MockLauncherClient.FreezeVirtualMachine should have comment or be unexported (golint)
  • Line 76: warning: exported method MockLauncherClient.UnfreezeVirtualMachine should have comment or be unexported (golint)
  • Line 86: warning: exported method MockLauncherClient.SyncMigrationTarget should have comment or be unexported (golint)
  • Line 96: warning: exported method MockLauncherClient.SignalTargetPodCleanup should have comment or be unexported (golint)
  • Line 106: warning: exported method MockLauncherClient.ShutdownVirtualMachine should have comment or be unexported (golint)
  • Line 116: warning: exported method MockLauncherClient.KillVirtualMachine should have comment or be unexported (golint)
  • Line 126: warning: exported method MockLauncherClient.MigrateVirtualMachine should have comment or be unexported (golint)
  • Line 136: warning: exported method MockLauncherClient.CancelVirtualMachineMigration should have comment or be unexported (golint)
  • Line 146: warning: exported method MockLauncherClient.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 156: warning: exported method MockLauncherClient.DeleteDomain should have comment or be unexported (golint)
  • Line 166: warning: exported method MockLauncherClient.GetDomain should have comment or be unexported (golint)
  • Line 178: warning: exported method MockLauncherClient.GetDomainStats should have comment or be unexported (golint)
  • Line 190: warning: exported method MockLauncherClient.GetGuestInfo should have comment or be unexported (golint)
  • Line 201: warning: exported method MockLauncherClient.GetUsers should have comment or be unexported (golint)
  • Line 212: warning: exported method MockLauncherClient.GetFilesystems should have comment or be unexported (golint)
  • Line 223: warning: exported method MockLauncherClient.Exec should have comment or be unexported (golint)
  • Line 235: warning: exported method MockLauncherClient.Ping should have comment or be unexported (golint)
  • Line 245: warning: exported method MockLauncherClient.GuestPing should have comment or be unexported (golint)
  • Line 255: warning: exported method MockLauncherClient.Close should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/generic_device.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 42: warning: exported const DeviceNamespace should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported type GenericDevice should have comment or be unexported (golint)
  • Line 53: warning: exported type GenericDevicePlugin should have comment or be unexported (golint)
  • Line 71: warning: exported function NewGenericDevicePlugin should have comment or be unexported (golint)
  • Line 121: warning: exported method GenericDevicePlugin.GetDevicePath should have comment or be unexported (golint)
  • Line 125: warning: exported method GenericDevicePlugin.GetDeviceName should have comment or be unexported (golint)
  • Line 230: warning: exported method GenericDevicePlugin.ListAndWatch should have comment or be unexported (golint)
  • Line 256: warning: exported method GenericDevicePlugin.Allocate should have comment or be unexported (golint)
  • Line 281: warning: exported method GenericDevicePlugin.GetDevicePluginOptions should have comment or be unexported (golint)
  • Line 288: warning: exported method GenericDevicePlugin.PreStartContainer should have comment or be unexported (golint)
  • Line 358: warning: exported function IsChanClosed should have comment or be unexported (golint)
  • Line 368: warning: exported function SocketPath should have comment or be unexported (golint)
  • Line 372: warning: exported method GenericDevicePlugin.GetInitialized should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/mount.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 639: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/legacy/hostdev.go
  • Line 30: warning: exported type CreateHostDevice should have comment or be unexported (golint)
  • Line 37: warning: exported function CreateGPUHostDevices should have comment or be unexported (golint)
  • Line 41: warning: exported function CreateVGPUHostDevices should have comment or be unexported (golint)
  • Line 45: warning: exported function CreateGPUHostDevicesFromPool should have comment or be unexported (golint)
  • Line 49: warning: exported function CreateVGPUHostDevicesFromPool should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/network.go
  • Line 188: warning: exported function CalculateNetworkQueues should have comment or be unexported (golint)
  • Line 256: warning: comment on exported function GetResolvConfDetailsFromPod should be of the form "GetResolvConfDetailsFromPod ..." (golint)

• kubevirt/tests/libnet/ipv6.go
  • Line 57: warning: exported function WithIPv6 should have comment or be unexported (golint)

• kubevirt/tests/performance/realtime.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• kubevirt/tests/storage/storage.go
  • Line 39: warning: should not use dot imports (golint)
  • Line 41: warning: should not use dot imports (golint)
  • Line 57: warning: should not use dot imports (golint)
  • Line 65: warning: exported type VMICreationFunc should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/domainstats/prometheus/prometheus.go
  • Line 43: warning: exported const PrometheusCollectionTimeout should have comment or be unexported (golint)
  • Line 437: warning: exported type DomainStatsCollector should have comment or be unexported (golint)
  • Line 444: warning: comment on exported function SetupDomainStatsCollector should be of the form "SetupDomainStatsCollector ..." (golint)
  • Line 458: warning: exported method DomainStatsCollector.Describe should have comment or be unexported (golint)
  • Line 462: warning: comment on exported method DomainStatsCollector.Collect should be of the form "Collect ..." (golint)
  • Line 483: warning: exported function NewPrometheusScraper should have comment or be unexported (golint)
  • Line 544: warning: exported function Handler should have comment or be unexported (golint)

• kubevirt/pkg/testutils/mock_queue.go
  • Line 44: warning: exported method MockWorkQueue.Add should have comment or be unexported (golint)
  • Line 53: warning: exported method MockWorkQueue.AddRateLimited should have comment or be unexported (golint)
  • Line 58: warning: exported method MockWorkQueue.AddAfter should have comment or be unexported (golint)
  • Line 68: warning: exported method MockWorkQueue.GetRateLimitedEnqueueCount should have comment or be unexported (golint)
  • Line 72: warning: exported method MockWorkQueue.GetAddAfterEnqueueCount should have comment or be unexported (golint)
  • Line 98: warning: exported function NewMockWorkQueue should have comment or be unexported (golint)
  • Line 102: warning: exported function NewFakeInformerFor should have comment or be unexported (golint)
  • Line 108: warning: exported function NewFakeInformerWithIndexersFor should have comment or be unexported (golint)
  • Line 114: warning: exported type VirtualMachineFeeder should have comment or be unexported (golint)
  • Line 119: warning: exported method VirtualMachineFeeder.Add should have comment or be unexported (golint)
  • Line 125: warning: exported method VirtualMachineFeeder.Modify should have comment or be unexported (golint)
  • Line 131: warning: exported method VirtualMachineFeeder.Delete should have comment or be unexported (golint)
  • Line 137: warning: exported function NewVirtualMachineFeeder should have comment or be unexported (golint)
  • Line 144: warning: exported type PodFeeder should have comment or be unexported (golint)
  • Line 149: warning: exported method PodFeeder.Add should have comment or be unexported (golint)
  • Line 155: warning: exported method PodFeeder.Modify should have comment or be unexported (golint)
  • Line 161: warning: exported method PodFeeder.Delete should have comment or be unexported (golint)
  • Line 167: warning: exported function NewPodFeeder should have comment or be unexported (golint)
  • Line 174: warning: exported type PodDisruptionBudgetFeeder should have comment or be unexported (golint)
  • Line 179: warning: exported method PodDisruptionBudgetFeeder.Add should have comment or be unexported (golint)
  • Line 185: warning: exported method PodDisruptionBudgetFeeder.Modify should have comment or be unexported (golint)
  • Line 191: warning: exported method PodDisruptionBudgetFeeder.Delete should have comment or be unexported (golint)
  • Line 197: warning: exported function NewPodDisruptionBudgetFeeder should have comment or be unexported (golint)
  • Line 204: warning: exported type MigrationFeeder should have comment or be unexported (golint)
  • Line 209: warning: exported method MigrationFeeder.Add should have comment or be unexported (golint)
  • Line 215: warning: exported method MigrationFeeder.Modify should have comment or be unexported (golint)
  • Line 221: warning: exported method MigrationFeeder.Delete should have comment or be unexported (golint)
  • Line 227: warning: exported function NewMigrationFeeder should have comment or be unexported (golint)
  • Line 234: warning: exported type DomainFeeder should have comment or be unexported (golint)
  • Line 239: warning: exported method DomainFeeder.Add should have comment or be unexported (golint)
  • Line 245: warning: exported method DomainFeeder.Modify should have comment or be unexported (golint)
  • Line 251: warning: exported method DomainFeeder.Delete should have comment or be unexported (golint)
  • Line 257: warning: exported function NewDomainFeeder should have comment or be unexported (golint)
  • Line 264: warning: exported type DataVolumeFeeder should have comment or be unexported (golint)
  • Line 269: warning: exported method DataVolumeFeeder.Add should have comment or be unexported (golint)
  • Line 275: warning: exported method DataVolumeFeeder.Modify should have comment or be unexported (golint)
  • Line 281: warning: exported method DataVolumeFeeder.Delete should have comment or be unexported (golint)
  • Line 287: warning: exported function NewDataVolumeFeeder should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/isolation/validation.go
  • Line 17: warning: exported const QEMUIMGPath should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported function GetImageInfo should have comment or be unexported (golint)
  • Line 45: warning: exported function GetFileSize should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/statsconv/util/domstats_utils.go
  • Line 10: warning: exported var Testdata should have comment or be unexported (golint)
  • Line 118: warning: exported var Testdataexpected should have comment or be unexported (golint)
  • Line 249: warning: exported function LoadStats should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/pause/pause.go
  • Line 39: warning: exported const COMMAND_PAUSE should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported function NewPauseCommand should have comment or be unexported (golint)
  • Line 68: warning: exported function NewUnpauseCommand should have comment or be unexported (golint)
  • Line 95: warning: exported type VirtCommand should have comment or be unexported (golint)
  • Line 100: warning: exported method VirtCommand.Run should have comment or be unexported (golint)

• kubevirt/tests/framework/matcher/helper/reflect.go
  • Line 5: warning: exported function IsNil should have comment or be unexported (golint)
  • Line 9: warning: exported function IsSlice should have comment or be unexported (golint)

• kubevirt/tests/libnet/cluster.go
  • Line 16: warning: exported function IsClusterDualStack should have comment or be unexported (golint)

• kubevirt/pkg/downwardmetrics/downwardmetrics.go
  • Line 12: warning: exported function CreateDownwardMetricDisk should have comment or be unexported (golint)
  • Line 21: warning: exported function FormatDownwardMetricPath should have comment or be unexported (golint)
  • Line 25: warning: exported function HasDownwardMetricDisk should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/cgroup/generated_mock_cgroup.go
  • Line 10: warning: comment on exported type MockParser should be of the form "MockParser ..." (with optional leading article) (golint)
  • Line 21: warning: exported function NewMockParser should have comment or be unexported (golint)
  • Line 27: warning: exported method MockParser.EXPECT should have comment or be unexported (golint)
  • Line 31: warning: exported method MockParser.Parse should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/usbredir.go
  • Line 14: warning: exported method SubresourceAPIApp.USBRedirRequestHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/rest/console.go
  • Line 42: warning: exported type ConsoleHandler should have comment or be unexported (golint)
  • Line 53: warning: exported type UsbredirHandlerVMI should have comment or be unexported (golint)
  • Line 57: warning: exported function NewConsoleHandler should have comment or be unexported (golint)
  • Line 70: warning: exported method ConsoleHandler.USBRedirHandler should have comment or be unexported (golint)
  • Line 133: warning: exported method ConsoleHandler.VNCHandler should have comment or be unexported (golint)
  • Line 152: warning: exported method ConsoleHandler.SerialHandler should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/notify-server/server.go
  • Line 45: warning: exported type Notify should have comment or be unexported (golint)
  • Line 51: warning: exported method Notify.HandleDomainEvent should have comment or be unexported (golint)
  • Line 93: warning: exported method Notify.HandleK8SEvent should have comment or be unexported (golint)
  • Line 123: warning: exported function RunServer should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/generated_mock_mount.go
  • Line 4: warning: don't use an underscore in package name (golint)
  • Line 13: warning: comment on exported type MockVolumeMounter should be of the form "MockVolumeMounter ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewMockVolumeMounter should have comment or be unexported (golint)
  • Line 30: warning: exported method MockVolumeMounter.EXPECT should have comment or be unexported (golint)
  • Line 34: warning: exported method MockVolumeMounter.Mount should have comment or be unexported (golint)
  • Line 44: warning: exported method MockVolumeMounter.MountFromPod should have comment or be unexported (golint)
  • Line 54: warning: exported method MockVolumeMounter.Unmount should have comment or be unexported (golint)
  • Line 64: warning: exported method MockVolumeMounter.UnmountAll should have comment or be unexported (golint)
  • Line 74: warning: exported method MockVolumeMounter.IsMounted should have comment or be unexported (golint)

• kubevirt/pkg/virt-config/config-map.go
  • Line 42: warning: exported const ConfigMapName should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: exported type ConfigModifiedFn should have comment or be unexported (golint)
  • Line 279: warning: exported type ClusterConfig should have comment or be unexported (golint)
  • Line 293: warning: exported method ClusterConfig.SetConfigModifiedCallback should have comment or be unexported (golint)
  • Line 422: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 430: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 535: warning: comment on exported method ClusterConfig.GetConfig should be of the form "GetConfig ..." (golint)
  • Line 594: warning: exported method ClusterConfig.GetConfigFromKubeVirtCR should have comment or be unexported (golint)
  • Line 620: warning: exported method ClusterConfig.HasDataSourceAPI should have comment or be unexported (golint)
  • Line 635: warning: exported method ClusterConfig.HasDataVolumeAPI should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutators/vmi-mutator.go
  • Line 45: warning: exported type VMIsMutator should have comment or be unexported (golint)
  • Line 51: warning: exported method VMIsMutator.Mutate should have comment or be unexported (golint)
  • Line 144: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kubevirt/pkg/virt-handler/selinux/executor.go
  • Line 33: warning: exported type Executor should have comment or be unexported (golint)
  • Line 43: warning: exported type SELinuxExecutor should have comment or be unexported (golint)
  • Line 46: warning: exported method SELinuxExecutor.NewSELinux should have comment or be unexported (golint)
  • Line 50: warning: exported method SELinuxExecutor.FileLabel should have comment or be unexported (golint)
  • Line 54: warning: exported method SELinuxExecutor.SetExecLabel should have comment or be unexported (golint)
  • Line 58: warning: exported method SELinuxExecutor.LockOSThread should have comment or be unexported (golint)
  • Line 62: warning: exported method SELinuxExecutor.UnlockOSThread should have comment or be unexported (golint)
  • Line 66: warning: exported method SELinuxExecutor.CloseOnExec should have comment or be unexported (golint)
  • Line 70: warning: exported method SELinuxExecutor.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/apply/generations.go
  • Line 50: warning: exported function GetExpectedGeneration should have comment or be unexported (golint)
  • Line 67: warning: exported function SetGeneration should have comment or be unexported (golint)

• kubevirt/tools/perfscale-load-generator/object/utils.go
  • Line 29: warning: exported const VMIResource should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/tests/network/framework.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 26: warning: exported function SIGDescribe should have comment or be unexported (golint)
  • Line 30: warning: exported function FSIGDescribe should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/perfscale/register.go
  • Line 29: warning: exported function RegisterPerfScaleMetrics should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/hinter.go
  • Line 16: warning: exported type Hinter should have comment or be unexported (golint)
  • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 81: warning: exported function NewTopologyHinter should have comment or be unexported (golint)

• kubevirt/tests/network/services.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 30: warning: should not use dot imports (golint)

• kubevirt/pkg/network/istio/ports.go
  • Line 25: warning: exported const EnvoyAdminPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function ReservedPorts should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/deviceplugin/v1beta1/constants.go
  • Line 22: warning: comment on exported const Unhealthy should be of the form "Unhealthy ..." (golint)
  • Line 25: warning: comment on exported const Version should be of the form "Version ..." (golint)
  • Line 35: warning: exported var SupportedVersions should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/hostdev.go
  • Line 30: warning: exported type HostDeviceMetaData should have comment or be unexported (golint)
  • Line 42: warning: exported type AddressPooler should have comment or be unexported (golint)
  • Line 46: warning: exported function CreatePCIHostDevices should have comment or be unexported (golint)
  • Line 50: warning: exported function CreateMDEVHostDevices should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/vmi-create-admitter.go
  • Line 81: warning: exported type VMICreateAdmitter should have comment or be unexported (golint)
  • Line 85: warning: exported method VMICreateAdmitter.Admit should have comment or be unexported (golint)
  • Line 114: warning: exported function ValidateVirtualMachineInstanceSpec should have comment or be unexported (golint)
  • Line 1457: warning: exported function ValidateVirtualMachineInstanceMetadata should have comment or be unexported (golint)
  • Line 1497: warning: exported function ValidateDuplicateDHCPPrivateOptions should have comment or be unexported (golint)

• kubevirt/pkg/hooks/v1alpha1/v1alpha1.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported const Version should have comment or be unexported (golint)

• kubevirt/pkg/healthz/healthz.go
  • Line 36: warning: exported type KubeApiHealthzVersion should have comment or be unexported (golint)
  • Line 41: warning: exported method KubeApiHealthzVersion.Update should have comment or be unexported (golint)
  • Line 47: warning: exported method KubeApiHealthzVersion.Clear should have comment or be unexported (golint)
  • Line 53: warning: exported method KubeApiHealthzVersion.GetVersion should have comment or be unexported (golint)
  • Line 71: warning: exported function KubeConnectionHealthzFuncFactory should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/vcpu/vcpu.go
  • Line 11: warning: exported type VCPUPool should have comment or be unexported (golint)
  • Line 16: warning: exported function CalculateRequestedVCPUs should have comment or be unexported (golint)
  • Line 105: warning: exported function NewStrictCPUPool should have comment or be unexported (golint)
  • Line 109: warning: exported function NewRelaxedCPUPool should have comment or be unexported (golint)
  • Line 174: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/apiserver.go
  • Line 1: warning: package comment should be of the form "Package rbac ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 30: warning: exported const ApiServiceAccountName should have comment or be unexported (golint)
  • Line 32: warning: exported function GetAllApiServer should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/virt_operator_suite_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kubevirt/tools/perfscale-load-generator/object/template.go
  • Line 38: warning: exported const Replica should have comment (or a comment on this block) or be unexported (golint)
  • Line 87: warning: exported function GenerateObjectTemplateData should have comment or be unexported (golint)

• kubevirt/tests/storage/restore.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• kubevirt/pkg/network/dhcp/serverv6/serverv6.go
  • Line 38: warning: exported type DHCPv6Handler should have comment or be unexported (golint)
  • Line 43: warning: exported function SingleClientDHCPv6Server should have comment or be unexported (golint)
  • Line 76: warning: exported method DHCPv6Handler.ServeDHCPv6 should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/generated_mock_configurator.go
  • Line 13: warning: comment on exported type MockConfigurator should be of the form "MockConfigurator ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewMockConfigurator should have comment or be unexported (golint)
  • Line 30: warning: exported method MockConfigurator.EXPECT should have comment or be unexported (golint)
  • Line 34: warning: exported method MockConfigurator.EnsureDHCPServerStarted should have comment or be unexported (golint)
  • Line 44: warning: exported method MockConfigurator.Generate should have comment or be unexported (golint)
  • Line 55: warning: comment on exported type MockConfigGenerator should be of the form "MockConfigGenerator ..." (with optional leading article) (golint)
  • Line 66: warning: exported function NewMockConfigGenerator should have comment or be unexported (golint)
  • Line 72: warning: exported method MockConfigGenerator.EXPECT should have comment or be unexported (golint)
  • Line 76: warning: exported method MockConfigGenerator.Generate should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/cgroup/cgroup.go
  • Line 39: warning: exported function ControllerPath should have comment or be unexported (golint)
  • Line 50: warning: exported function CPUSetPath should have comment or be unexported (golint)
  • Line 61: warning: exported type Parser should have comment or be unexported (golint)
  • Line 122: warning: exported function NewParser should have comment or be unexported (golint)

• kubevirt/tests/framework/checks/skips.go
  • Line 13: warning: exported function SkipTestIfNoCPUManager should have comment or be unexported (golint)
  • Line 30: warning: exported function SkipTestIfNoFeatureGate should have comment or be unexported (golint)
  • Line 36: warning: exported function SkipTestIfNotEnoughNodesWithCPUManagerWith2MiHugepages should have comment or be unexported (golint)
  • Line 62: warning: exported function SkipTestIfNotRealtimeCapable should have comment or be unexported (golint)

• kubevirt/tests/libnet/ipaddress.go
  • Line 10: warning: exported function GetPodIpByFamily should have comment or be unexported (golint)
  • Line 18: warning: exported function GetVmiPrimaryIpByFamily should have comment or be unexported (golint)
  • Line 22: warning: exported function GetIp should have comment or be unexported (golint)

• kubevirt/pkg/util/hardware/hw_utils.go
  • Line 32: warning: exported const PCI_ADDRESS_PATTERN should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported function ParseCPUSetLine should be of the form "ParseCPUSetLine ..." (golint)

• kubevirt/pkg/util/status/status.go
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 240: warning: exported type VMStatusUpdater should have comment or be unexported (golint)
  • Line 244: warning: exported method VMStatusUpdater.UpdateStatus should have comment or be unexported (golint)
  • Line 248: warning: exported method VMStatusUpdater.PatchStatus should have comment or be unexported (golint)
  • Line 252: warning: exported function NewVMStatusUpdater should have comment or be unexported (golint)
  • Line 262: warning: exported type VMIRSStatusUpdater should have comment or be unexported (golint)
  • Line 266: warning: exported method VMIRSStatusUpdater.UpdateStatus should have comment or be unexported (golint)
  • Line 270: warning: exported function NewVMIRSStatusUpdater should have comment or be unexported (golint)
  • Line 280: warning: exported type KVStatusUpdater should have comment or be unexported (golint)
  • Line 284: warning: exported method KVStatusUpdater.UpdateStatus should have comment or be unexported (golint)
  • Line 288: warning: exported method KVStatusUpdater.PatchStatus should have comment or be unexported (golint)
  • Line 292: warning: exported function NewKubeVirtStatusUpdater should have comment or be unexported (golint)
  • Line 302: warning: exported type MigrationStatusUpdater should have comment or be unexported (golint)
  • Line 306: warning: exported method MigrationStatusUpdater.UpdateStatus should have comment or be unexported (golint)
  • Line 310: warning: exported function NewMigrationStatusUpdater should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/legacy/addresspool.go
  • Line 39: warning: exported type AddressPool should have comment or be unexported (golint)
  • Line 72: warning: exported method AddressPool.Pop should have comment or be unexported (golint)
  • Line 82: warning: exported method AddressPool.Len should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/install/strategy.go
  • Line 62: warning: exported const ManifestsEncodingGzipBase64 should have comment or be unexported (golint)
  • Line 66: warning: exported type APIServiceInterface should have comment or be unexported (golint)
  • Line 73: warning: exported type Strategy should have comment or be unexported (golint)
  • Line 97: warning: exported method Strategy.ServiceAccounts should have comment or be unexported (golint)
  • Line 101: warning: exported method Strategy.ClusterRoles should have comment or be unexported (golint)
  • Line 105: warning: exported method Strategy.ClusterRoleBindings should have comment or be unexported (golint)
  • Line 109: warning: exported method Strategy.Roles should have comment or be unexported (golint)
  • Line 113: warning: exported method Strategy.RoleBindings should have comment or be unexported (golint)
  • Line 117: warning: exported method Strategy.Services should have comment or be unexported (golint)
  • Line 121: warning: exported method Strategy.Deployments should have comment or be unexported (golint)
  • Line 125: warning: exported method Strategy.ApiDeployments should have comment or be unexported (golint)
  • Line 138: warning: exported method Strategy.ControllerDeployments should have comment or be unexported (golint)
  • Line 152: warning: exported method Strategy.DaemonSets should have comment or be unexported (golint)
  • Line 156: warning: exported method Strategy.ValidatingWebhookConfigurations should have comment or be unexported (golint)
  • Line 160: warning: exported method Strategy.MutatingWebhookConfigurations should have comment or be unexported (golint)
  • Line 164: warning: exported method Strategy.APIServices should have comment or be unexported (golint)
  • Line 168: warning: exported method Strategy.CertificateSecrets should have comment or be unexported (golint)
  • Line 172: warning: exported method Strategy.SCCs should have comment or be unexported (golint)
  • Line 176: warning: exported method Strategy.ServiceMonitors should have comment or be unexported (golint)
  • Line 180: warning: exported method Strategy.PrometheusRules should have comment or be unexported (golint)
  • Line 184: warning: exported method Strategy.ConfigMaps should have comment or be unexported (golint)
  • Line 188: warning: exported method Strategy.CRDs should have comment or be unexported (golint)
  • Line 225: warning: exported function NewInstallStrategyConfigMap should have comment or be unexported (golint)
  • Line 273: warning: exported function DumpInstallStrategyToConfigMap should have comment or be unexported (golint)
  • Line 369: warning: exported function GenerateCurrentInstallStrategy should have comment or be unexported (golint)
  • Line 517: warning: exported function LoadInstallStrategyFromCache should have comment or be unexported (golint)

• kubevirt/tests/console/console.go
  • Line 29: warning: should not use dot imports (golint)
  • Line 40: warning: exported const PromptExpression should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported var ShellSuccess should have comment or be unexported (golint)
  • Line 274: warning: exported function RetValue should have comment or be unexported (golint)

• kubevirt/doc.go
  • Line 1: warning: package comment should be of the form "Package root ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• kubevirt/pkg/testutils/mock_config.go
  • Line 21: warning: exported function NewFakeClusterConfig should have comment or be unexported (golint)
  • Line 25: warning: exported function NewFakeClusterConfigWithCPUArch should have comment or be unexported (golint)
  • Line 40: warning: exported function NewFakeClusterConfigUsingKV should have comment or be unexported (golint)
  • Line 44: warning: exported function NewFakeClusterConfigUsingKVWithCPUArch should have comment or be unexported (golint)
  • Line 57: warning: exported function NewFakeClusterConfigUsingKVConfig should have comment or be unexported (golint)
  • Line 73: warning: exported function NewFakeContainerDiskSource should have comment or be unexported (golint)
  • Line 81: warning: exported function RemoveDataVolumeAPI should have comment or be unexported (golint)
  • Line 85: warning: exported function AddDataVolumeAPI should have comment or be unexported (golint)
  • Line 95: warning: exported function UpdateFakeClusterConfig should have comment or be unexported (golint)
  • Line 100: warning: exported function UpdateFakeKubeVirtClusterConfig should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/serverv6/conn.go
  • Line 1: warning: package comment should be of the form "Package serverv6 ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 32: warning: exported type FilteredConn should have comment or be unexported (golint)
  • Line 38: warning: exported method FilteredConn.ReadFrom should have comment or be unexported (golint)
  • Line 48: warning: exported method FilteredConn.WriteTo should have comment or be unexported (golint)
  • Line 53: warning: exported method FilteredConn.Close should have comment or be unexported (golint)
  • Line 57: warning: exported method FilteredConn.LocalAddr should have comment or be unexported (golint)
  • Line 61: warning: exported method FilteredConn.SetDeadline should have comment or be unexported (golint)
  • Line 65: warning: exported method FilteredConn.SetReadDeadline should have comment or be unexported (golint)
  • Line 69: warning: exported method FilteredConn.SetWriteDeadline should have comment or be unexported (golint)
  • Line 73: warning: exported function NewConnection should have comment or be unexported (golint)

• kubevirt/pkg/util/webhooks/webhooks.go
  • Line 19: warning: comment on exported function GetAdmissionReview should be of the form "GetAdmissionReview ..." (golint)
  • Line 39: warning: comment on exported function ToAdmissionResponseError should be of the form "ToAdmissionResponseError ..." (golint)
  • Line 51: warning: exported function ToAdmissionResponse should have comment or be unexported (golint)
  • Line 75: warning: exported function ValidationErrorsToAdmissionResponse should have comment or be unexported (golint)
  • Line 87: warning: exported function ValidateSchema should have comment or be unexported (golint)
  • Line 100: warning: exported function ValidateRequestResource should have comment or be unexported (golint)
  • Line 113: warning: exported function ValidateStatus should have comment or be unexported (golint)
  • Line 131: warning: exported function GetVMIFromAdmissionReview should have comment or be unexported (golint)
  • Line 159: warning: exported function GetVMFromAdmissionReview should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/selinux/generated_mock_executor.go
  • Line 12: warning: comment on exported type MockExecutor should be of the form "MockExecutor ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockExecutor should have comment or be unexported (golint)
  • Line 29: warning: exported method MockExecutor.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockExecutor.NewSELinux should have comment or be unexported (golint)
  • Line 45: warning: exported method MockExecutor.FileLabel should have comment or be unexported (golint)
  • Line 56: warning: exported method MockExecutor.SetExecLabel should have comment or be unexported (golint)
  • Line 66: warning: exported method MockExecutor.LockOSThread should have comment or be unexported (golint)
  • Line 74: warning: exported method MockExecutor.UnlockOSThread should have comment or be unexported (golint)
  • Line 82: warning: exported method MockExecutor.CloseOnExec should have comment or be unexported (golint)
  • Line 90: warning: exported method MockExecutor.Run should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/cluster.go
  • Line 1: warning: package comment should be of the form "Package rbac ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported function GetAllCluster should have comment or be unexported (golint)

• kubevirt/pkg/controller/controller_ref.go
  • Line 45: warning: exported function IsControlledBy should have comment or be unexported (golint)

• kubevirt/pkg/controller/virtinformers.go
  • Line 63: warning: exported const OperatorLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 66: warning: error var unexpectedObjectError should have name of the form errFoo (golint)
  • Line 70: warning: exported type KubeInformerFactory should have comment or be unexported (golint)
  • Line 254: warning: exported function NewKubeInformerFactory should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/cmd-server/info.go
  • Line 1: warning: package comment should be of the form "Package cmdserver ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported type InfoServer should have comment or be unexported (golint)
  • Line 31: warning: exported method InfoServer.Info should have comment or be unexported (golint)

• kubevirt/tests/util/util.go
  • Line 16: warning: comment on exported var NamespaceTestDefault should be of the form "NamespaceTestDefault ..." (golint)
  • Line 19: warning: exported function PanicOnError should have comment or be unexported (golint)
  • Line 25: warning: exported function GetAllSchedulableNodes should have comment or be unexported (golint)
  • Line 31: warning: exported function GetCurrentKv should have comment or be unexported (golint)
  • Line 37: warning: exported function GetKvList should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/validations_generated.go
  • Line 3: warning: exported var CRDsValidation should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/migration.go
  • Line 62: warning: exported type MigrationController should have comment or be unexported (golint)
  • Line 79: warning: exported function NewMigrationController should have comment or be unexported (golint)
  • Line 133: warning: exported method MigrationController.Run should have comment or be unexported (golint)
  • Line 155: warning: exported method MigrationController.Execute should have comment or be unexported (golint)
  • Line 344: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kubevirt/pkg/os/fs/defaultfs.go
  • Line 1: warning: package comment should be of the form "Package fs ..." (golint)
  • Line 37: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 42: warning: comment on exported function NewWithRootPath should be of the form "NewWithRootPath ..." (golint)
  • Line 106: warning: exported method DefaultFs.WriteFile should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/api/defaults.go
  • Line 4: warning: exported const DefaultProtocol should have comment (or a comment on this block) or be unexported (golint)
  • Line 10: warning: exported function NewDefaulter should have comment or be unexported (golint)
  • Line 14: warning: exported type Defaulter should have comment or be unexported (golint)
  • Line 18: warning: exported method Defaulter.IsPPC64 should have comment or be unexported (golint)
  • Line 25: warning: exported method Defaulter.IsARM64 should have comment or be unexported (golint)
  • Line 32: warning: exported method Defaulter.SetDefaults_Devices should have comment or be unexported (golint)
  • Line 32: warning: don't use underscores in Go names; method SetDefaults_Devices should be SetDefaultsDevices (golint)
  • Line 36: warning: exported method Defaulter.SetDefaults_OSType should have comment or be unexported (golint)
  • Line 36: warning: don't use underscores in Go names; method SetDefaults_OSType should be SetDefaultsOSType (golint)
  • Line 62: warning: exported method Defaulter.SetDefaults_DomainSpec should have comment or be unexported (golint)
  • Line 62: warning: don't use underscores in Go names; method SetDefaults_DomainSpec should be SetDefaultsDomainSpec (golint)
  • Line 69: warning: exported method Defaulter.SetDefaults_SysInfo should have comment or be unexported (golint)
  • Line 69: warning: don't use underscores in Go names; method SetDefaults_SysInfo should be SetDefaultsSysInfo (golint)
  • Line 75: warning: exported method Defaulter.SetObjectDefaults_Domain should have comment or be unexported (golint)
  • Line 75: warning: don't use underscores in Go names; method SetObjectDefaults_Domain should be SetObjectDefaultsDomain (golint)

• kubevirt/pkg/util/net/dns/resolveconf.go
  • Line 17: warning: exported function ParseNameservers should have comment or be unexported (golint)
  • Line 49: warning: exported function ParseSearchDomains should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/validating-webhook.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 32: warning: exported function ServeVMICreate should have comment or be unexported (golint)
  • Line 36: warning: exported function ServeVMIUpdate should have comment or be unexported (golint)
  • Line 40: warning: exported function ServeVMs should have comment or be unexported (golint)
  • Line 45: warning: exported function ServeVMIRS should have comment or be unexported (golint)
  • Line 49: warning: exported function ServeVMIPreset should have comment or be unexported (golint)
  • Line 53: warning: exported function ServeMigrationCreate should have comment or be unexported (golint)
  • Line 57: warning: exported function ServeMigrationUpdate should have comment or be unexported (golint)
  • Line 61: warning: exported function ServeVMSnapshots should have comment or be unexported (golint)
  • Line 65: warning: exported function ServeVMRestores should have comment or be unexported (golint)
  • Line 69: warning: exported function ServeVmFlavors should have comment or be unexported (golint)
  • Line 73: warning: exported function ServeVmClusterFlavors should have comment or be unexported (golint)
  • Line 77: warning: exported function ServeStatusValidation should have comment or be unexported (golint)
  • Line 87: warning: exported function ServePodEvictionInterceptor should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/generic_device_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/pciaddress.go
  • Line 27: warning: exported function NewPciAddressField should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/live-migration-source.go
  • Line 285: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 335: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/tools/perfscale-load-generator/config/config.go
  • Line 36: warning: exported const RequestTimeout should have comment or be unexported (golint)

• kubevirt/pkg/ignition/ignition.go
  • Line 35: warning: exported const IgnitionFile should have comment or be unexported (golint)
  • Line 37: warning: exported function GetIgnitionSource should have comment or be unexported (golint)
  • Line 42: warning: exported function SetLocalDirectory should have comment or be unexported (golint)
  • Line 45: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 50: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 52: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 59: warning: exported function GetDomainBasePath should have comment or be unexported (golint)
  • Line 63: warning: exported function GenerateIgnitionLocalData should have comment or be unexported (golint)

• kubevirt/pkg/util/types/dv.go
  • Line 34: warning: exported type CloneSource should have comment or be unexported (golint)
  • Line 39: warning: exported function GetCloneSourceWithInformers should have comment or be unexported (golint)
  • Line 81: warning: exported function GetCloneSource should have comment or be unexported (golint)

• kubevirt/pkg/network/infraconfigurators/bridge.go
  • Line 19: warning: exported type BridgePodNetworkConfigurator should have comment or be unexported (golint)
  • Line 33: warning: exported function NewBridgePodNetworkConfigurator should have comment or be unexported (golint)
  • Line 43: warning: exported method BridgePodNetworkConfigurator.DiscoverPodNetworkInterface should have comment or be unexported (golint)
  • Line 79: warning: exported method BridgePodNetworkConfigurator.GenerateNonRecoverableDHCPConfig should have comment or be unexported (golint)
  • Line 97: warning: exported method BridgePodNetworkConfigurator.PreparePodNetworkInterface should have comment or be unexported (golint)
  • Line 159: warning: exported method BridgePodNetworkConfigurator.GenerateNonRecoverableDomainIfaceSpec should have comment or be unexported (golint)

• kubevirt/pkg/util/types/patch.go
  • Line 22: warning: exported type PatchOperation should have comment or be unexported (golint)

• kubevirt/pkg/util/types/pvc.go
  • Line 32: warning: exported function IsPVCBlockFromStore should have comment or be unexported (golint)
  • Line 51: warning: exported function HasSharedAccessMode should have comment or be unexported (golint)
  • Line 60: warning: exported function IsPreallocated should have comment or be unexported (golint)
  • Line 72: warning: exported function PVCNameFromVirtVolume should have comment or be unexported (golint)
  • Line 82: warning: exported function VirtVolumesToPVCMap should have comment or be unexported (golint)

• kubevirt/pkg/util/webhooks/validating-webhooks/validating-webhook.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported type Admitter should have comment or be unexported (golint)
  • Line 21: warning: exported type AlwaysPassAdmitter should have comment or be unexported (golint)
  • Line 24: warning: exported function NewPassingAdmissionResponse should have comment or be unexported (golint)
  • Line 28: warning: exported method AlwaysPassAdmitter.Admit should have comment or be unexported (golint)
  • Line 32: warning: exported function NewAdmissionResponse should have comment or be unexported (golint)
  • Line 58: warning: exported function Serve should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/vmi.go
  • Line 127: warning: exported function NewVMIController should have comment or be unexported (golint)
  • Line 192: warning: exported type VMIController should have comment or be unexported (golint)
  • Line 207: warning: exported method VMIController.Run should have comment or be unexported (golint)
  • Line 229: warning: exported method VMIController.Execute should have comment or be unexported (golint)

• kubevirt/tests/storage/imageupload.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)
  • Line 12: warning: should not use dot imports (golint)

• kubevirt/pkg/controller/controller_ref_manager.go
  • Line 41: warning: exported type BaseControllerRefManager should have comment or be unexported (golint)
  • Line 50: warning: exported method BaseControllerRefManager.CanAdopt should have comment or be unexported (golint)
  • Line 129: warning: exported type VirtualMachineControllerRefManager should have comment or be unexported (golint)
  • Line 391: warning: exported type VirtualMachineControlInterface should have comment or be unexported (golint)
  • Line 396: warning: exported type RealVirtualMachineControl should have comment or be unexported (golint)
  • Line 400: warning: exported method RealVirtualMachineControl.PatchVirtualMachine should have comment or be unexported (golint)
  • Line 406: warning: exported method RealVirtualMachineControl.PatchDataVolume should have comment or be unexported (golint)

• kubevirt/pkg/network/link/reserved_macs.go
  • Line 22: warning: exported const StaticMasqueradeBridgeMAC should have comment or be unexported (golint)
  • Line 24: warning: exported function IsReserved should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/addresspool.go
  • Line 31: warning: exported type AddressPool should have comment or be unexported (golint)
  • Line 95: warning: exported type BestEffortAddressPool should have comment or be unexported (golint)
  • Line 105: warning: exported method BestEffortAddressPool.Pop should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/status-admitter.go
  • Line 11: warning: exported type StatusAdmitter should have comment or be unexported (golint)
  • Line 15: warning: exported method StatusAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/tests/flags/flags.go
  • Line 29: warning: exported var KubeVirtUtilityVersionTag should have comment or be unexported (golint)
  • Line 30: warning: exported var KubeVirtVersionTag should have comment or be unexported (golint)
  • Line 31: warning: exported var KubeVirtVersionTagAlt should have comment or be unexported (golint)
  • Line 32: warning: exported var KubeVirtUtilityRepoPrefix should have comment or be unexported (golint)
  • Line 33: warning: exported var KubeVirtRepoPrefix should have comment or be unexported (golint)
  • Line 34: warning: exported var ImagePrefixAlt should have comment or be unexported (golint)
  • Line 35: warning: exported var ContainerizedDataImporterNamespace should have comment or be unexported (golint)
  • Line 36: warning: exported var KubeVirtKubectlPath should have comment or be unexported (golint)
  • Line 37: warning: exported var KubeVirtOcPath should have comment or be unexported (golint)
  • Line 38: warning: exported var KubeVirtVirtctlPath should have comment or be unexported (golint)
  • Line 39: warning: exported var KubeVirtGoCliPath should have comment or be unexported (golint)
  • Line 40: warning: exported var KubeVirtInstallNamespace should have comment or be unexported (golint)
  • Line 41: warning: exported var PreviousReleaseTag should have comment or be unexported (golint)
  • Line 42: warning: exported var PreviousReleaseRegistry should have comment or be unexported (golint)
  • Line 43: warning: exported var ConfigFile should have comment or be unexported (golint)
  • Line 44: warning: exported var SkipShasumCheck should have comment or be unexported (golint)
  • Line 45: warning: exported var SkipDualStackTests should have comment or be unexported (golint)
  • Line 46: warning: exported var IPV4ConnectivityCheckAddress should have comment or be unexported (golint)
  • Line 47: warning: exported var IPV6ConnectivityCheckAddress should have comment or be unexported (golint)
  • Line 48: warning: exported var ConnectivityCheckDNS should have comment or be unexported (golint)
  • Line 49: warning: exported var ArtifactsDir should have comment or be unexported (golint)
  • Line 50: warning: exported var ApplyDefaulte2eConfiguration should have comment or be unexported (golint)
  • Line 52: warning: exported var DeployTestingInfrastructureFlag should have comment or be unexported (golint)
  • Line 53: warning: exported var PathToTestingInfrastrucureManifests should have comment or be unexported (golint)
  • Line 54: warning: exported var DNSServiceName should have comment or be unexported (golint)
  • Line 55: warning: exported var DNSServiceNamespace should have comment or be unexported (golint)
  • Line 87: warning: exported function NormalizeFlags should have comment or be unexported (golint)

• kubevirt/tools/perfscale-load-generator/config/types.go
  • Line 43: warning: exported type Duration should have comment or be unexported (golint)
  • Line 47: warning: exported method Duration.MarshalJSON should have comment or be unexported (golint)
  • Line 51: warning: exported method Duration.UnmarshalJSON should have comment or be unexported (golint)

• kubevirt/pkg/handler-launcher-com/common.go
  • Line 1: warning: package comment should be of the form "Package handler_launcher_com ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 19: warning: don't use an underscore in package name (golint)
  • Line 26: warning: exported function GetHighestCompatibleVersion should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/cli/event.go
  • Line 28: warning: exported type DomainEventDeviceRemoved should have comment or be unexported (golint)
  • Line 36: warning: exported function NewDomainEventDeviceRemoved should have comment or be unexported (golint)
  • Line 49: warning: exported method DomainEventDeviceRemoved.Register should have comment or be unexported (golint)
  • Line 58: warning: exported method DomainEventDeviceRemoved.Deregister should have comment or be unexported (golint)
  • Line 69: warning: exported method DomainEventDeviceRemoved.EventChannel should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/domainstats/downwardmetrics/scraper.go
  • Line 24: warning: exported const DownwardmetricsRefreshDuration should have comment or be unexported (golint)
  • Line 25: warning: exported const DownwardmetricsCollectionTimeout should have comment or be unexported (golint)
  • Line 27: warning: exported type StaticHostMetrics should have comment or be unexported (golint)
  • Line 34: warning: exported type Scraper should have comment or be unexported (golint)
  • Line 40: warning: exported method Scraper.Scrape should have comment or be unexported (golint)
  • Line 78: warning: exported method Scraper.Report should have comment or be unexported (golint)
  • Line 123: warning: exported type Collector should have comment or be unexported (golint)
  • Line 127: warning: exported function RunDownwardMetricsCollector should have comment or be unexported (golint)

• kubevirt/pkg/host-disk/host-disk.go
  • Line 43: warning: exported const EventReasonToleratedSmallPV should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported function ReplacePVCByHostDisk should have comment or be unexported (golint)
  • Line 139: warning: exported function GetMountedHostDiskPathFromHandler should have comment or be unexported (golint)
  • Line 143: warning: exported function GetMountedHostDiskDirFromHandler should have comment or be unexported (golint)
  • Line 147: warning: exported function GetMountedHostDiskPath should have comment or be unexported (golint)
  • Line 151: warning: exported function GetMountedHostDiskDir should have comment or be unexported (golint)
  • Line 155: warning: exported type DiskImgCreator should have comment or be unexported (golint)
  • Line 163: warning: exported function NewHostDiskCreator should have comment or be unexported (golint)
  • Line 177: warning: exported method DiskImgCreator.Create should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go
  • Line 48: warning: exported type CloneAuthFunc should have comment or be unexported (golint)
  • Line 50: warning: exported type VMsAdmitter should have comment or be unexported (golint)
  • Line 66: warning: exported function NewVMsAdmitter should have comment or be unexported (golint)
  • Line 81: warning: exported method VMsAdmitter.Admit should have comment or be unexported (golint)
  • Line 140: warning: exported method VMsAdmitter.AdmitStatus should have comment or be unexported (golint)
  • Line 264: warning: exported function ValidateVirtualMachineSpec should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/application.go
  • Line 124: warning: exported type VirtControllerApp should have comment or be unexported (golint)
  • Line 232: warning: exported function Execute should have comment or be unexported (golint)
  • Line 376: warning: receiver name app should be consistent with previous receiver name vca for VirtControllerApp (golint)
  • Line 391: warning: exported method VirtControllerApp.Run should have comment or be unexported (golint)
  • Line 653: warning: exported method VirtControllerApp.AddFlags should have comment or be unexported (golint)

• kubevirt/pkg/ephemeral-disk/fake/ephemeral-disk.go
  • Line 10: warning: exported type MockEphemeralDiskImageCreator should have comment or be unexported (golint)
  • Line 14: warning: exported method MockEphemeralDiskImageCreator.CreateBackedImageForVolume should have comment or be unexported (golint)
  • Line 18: warning: exported method MockEphemeralDiskImageCreator.CreateEphemeralImages should have comment or be unexported (golint)
  • Line 22: warning: exported method MockEphemeralDiskImageCreator.GetFilePath should have comment or be unexported (golint)
  • Line 26: warning: exported method MockEphemeralDiskImageCreator.Init should have comment or be unexported (golint)

• kubevirt/pkg/certificates/triple/triple.go
  • Line 28: warning: exported type KeyPair should have comment or be unexported (golint)
  • Line 33: warning: exported function NewCA should have comment or be unexported (golint)
  • Line 53: warning: exported function NewServerKeyPair should have comment or be unexported (golint)
  • Line 93: warning: exported function NewClientKeyPair should have comment or be unexported (golint)

• kubevirt/pkg/controller/controller.go
  • Line 74: warning: exported function HandlePanic should have comment or be unexported (golint)
  • Line 80: warning: exported function NewResourceEventHandlerFuncsForWorkqueue should have comment or be unexported (golint)
  • Line 103: warning: exported function MigrationKey should have comment or be unexported (golint)
  • Line 107: warning: exported function VirtualMachineInstanceKey should have comment or be unexported (golint)
  • Line 111: warning: exported function VirtualMachineKey should have comment or be unexported (golint)
  • Line 115: warning: exported function PodKey should have comment or be unexported (golint)
  • Line 119: warning: exported function DataVolumeKey should have comment or be unexported (golint)
  • Line 123: warning: exported function VirtualMachineInstanceKeys should have comment or be unexported (golint)
  • Line 131: warning: exported function HasFinalizer should have comment or be unexported (golint)
  • Line 140: warning: exported function RemoveFinalizer should have comment or be unexported (golint)
  • Line 150: warning: exported function AddFinalizer should have comment or be unexported (golint)
  • Line 157: warning: exported function ObservedLatestApiVersionAnnotation should have comment or be unexported (golint)
  • Line 170: warning: exported function SetLatestApiVersionAnnotation should have comment or be unexported (golint)
  • Line 181: warning: exported function ApplyVolumeRequestOnVMISpec should have comment or be unexported (golint)
  • Line 240: warning: exported function CurrentVMIPod should have comment or be unexported (golint)
  • Line 278: warning: exported function VMIActivePodsCount should have comment or be unexported (golint)
  • Line 302: warning: exported function GeneratePatchBytes should have comment or be unexported (golint)
  • Line 306: warning: exported function EscapeJSONPointer should have comment or be unexported (golint)
  • Line 311: warning: exported function SetVMIPhaseTransitionTimestamp should have comment or be unexported (golint)
  • Line 328: warning: exported function VMIHasHotplugVolumes should have comment or be unexported (golint)
  • Line 345: warning: exported function AttachmentPods should have comment or be unexported (golint)

• kubevirt/pkg/network/domainspec/generators.go
  • Line 35: warning: exported type LibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 39: warning: exported function NewMacvtapLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 48: warning: exported function NewMasqueradeLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 58: warning: exported function NewSlirpLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 65: warning: exported function NewBridgeLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 75: warning: exported type BridgeLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 83: warning: exported method BridgeLibvirtSpecGenerator.Generate should have comment or be unexported (golint)
  • Line 124: warning: exported type MasqueradeLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 132: warning: exported method MasqueradeLibvirtSpecGenerator.Generate should have comment or be unexported (golint)
  • Line 174: warning: exported type SlirpLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 179: warning: exported method SlirpLibvirtSpecGenerator.Generate should have comment or be unexported (golint)
  • Line 207: warning: exported type MacvtapLibvirtSpecGenerator should have comment or be unexported (golint)
  • Line 214: warning: exported method MacvtapLibvirtSpecGenerator.Generate should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/controller.go
  • Line 1: warning: package comment should be of the form "Package rbac ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 30: warning: exported const ControllerServiceAccountName should have comment or be unexported (golint)
  • Line 32: warning: exported function GetAllController should have comment or be unexported (golint)

• kubevirt/tests/assert/xfail.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• kubevirt/tests/framework/cleanup/cleanup.go
  • Line 8: warning: exported const KubeVirtTestLabelPrefix should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/tests/framework/matcher/existence.go
  • Line 12: warning: exported function Exist should have comment or be unexported (golint)
  • Line 16: warning: exported function BePresent should have comment or be unexported (golint)
  • Line 20: warning: exported function BeGone should have comment or be unexported (golint)

• kubevirt/pkg/emptydisk/emptydisk.go
  • Line 60: warning: exported function NewEmptyDiskCreator should have comment or be unexported (golint)

• kubevirt/cmd/virt-launcher/virt-launcher.go
  • Line 605: warning: exported function RemoveContents should have comment or be unexported (golint)

• kubevirt/pkg/controller/expectations.go
  • Line 38: warning: comment on exported const ExpectationsTimeout should be of the form "ExpectationsTimeout ..." (golint)
  • Line 51: warning: exported var UpdateTaintBackoff should have comment or be unexported (golint)
  • Line 57: warning: exported type ResyncPeriodFunc should have comment or be unexported (golint)
  • Line 59: warning: comment on exported function NoResyncPeriodFunc should be of the form "NoResyncPeriodFunc ..." (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 189: warning: exported method ControllerExpectations.ExpectCreations should have comment or be unexported (golint)
  • Line 193: warning: exported method ControllerExpectations.ExpectDeletions should have comment or be unexported (golint)
  • Line 197: warning: comment on exported method ControllerExpectations.LowerExpectations should be of the form "LowerExpectations ..." (golint)
  • Line 206: warning: comment on exported method ControllerExpectations.RaiseExpectations should be of the form "RaiseExpectations ..." (golint)
  • Line 220: warning: exported method ControllerExpectations.AllPendingCreations should have comment or be unexported (golint)
  • Line 251: warning: receiver name e should be consistent with previous receiver name exp for ControlleeExpectations (golint)
  • Line 257: warning: receiver name e should be consistent with previous receiver name exp for ControlleeExpectations (golint)
  • Line 263: warning: receiver name e should be consistent with previous receiver name exp for ControlleeExpectations (golint)
  • Line 271: warning: exported function NewControllerExpectationsWithName should have comment or be unexported (golint)
  • Line 336: warning: exported method UIDTrackingControllerExpectations.AddExpectedDeletion should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/agent-poller/agent_parser.go
  • Line 151: warning: comment on exported function ParseFSFreezeStatus should be of the form "ParseFSFreezeStatus ..." (golint)

• kubevirt/pkg/virt-launcher/virtwrap/statsconv/generated_mock_converter.go
  • Line 10: warning: comment on exported type MockDomainIdentifier should be of the form "MockDomainIdentifier ..." (with optional leading article) (golint)
  • Line 21: warning: exported function NewMockDomainIdentifier should have comment or be unexported (golint)
  • Line 27: warning: exported method MockDomainIdentifier.EXPECT should have comment or be unexported (golint)
  • Line 31: warning: exported method MockDomainIdentifier.GetName should have comment or be unexported (golint)
  • Line 42: warning: exported method MockDomainIdentifier.GetUUIDString should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/util/config.go
  • Line 41: warning: comment on exported const OperatorImageEnvName should be of the form "OperatorImageEnvName ..." (golint)
  • Line 43: warning: exported const VirtApiShasumEnvName should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: comment on exported const TargetInstallNamespace should be of the form "TargetInstallNamespace ..." (golint)
  • Line 51: warning: comment on exported const TargetImagePullPolicy should be of the form "TargetImagePullPolicy ..." (golint)
  • Line 53: warning: comment on exported const TargetDeploymentConfig should be of the form "TargetDeploymentConfig ..." (golint)
  • Line 56: warning: comment on exported const AdditionalPropertiesNamePullPolicy should be of the form "AdditionalPropertiesNamePullPolicy ..." (golint)
  • Line 59: warning: comment on exported const AdditionalPropertiesMonitorNamespace should be of the form "AdditionalPropertiesMonitorNamespace ..." (golint)
  • Line 62: warning: comment on exported const AdditionalPropertiesMonitorServiceAccount should be of the form "AdditionalPropertiesMonitorServiceAccount ..." (golint)
  • Line 65: warning: comment on exported const AdditionalPropertiesWorkloadUpdatesEnabled should be of the form "AdditionalPropertiesWorkloadUpdatesEnabled ..." (golint)
  • Line 68: warning: comment on exported const DefaultMonitorAccount should be of the form "DefaultMonitorAccount ..." (golint)
  • Line 71: warning: comment on exported const ImagePrefixKey should be of the form "ImagePrefixKey ..." (golint)
  • Line 79: warning: comment on exported const PassthroughEnvPrefix should be of the form "PassthroughEnvPrefix ..." (golint)
  • Line 91: warning: exported type KubeVirtDeploymentConfig should have comment or be unexported (golint)
  • Line 117: warning: exported function GetConfigFromEnv should have comment or be unexported (golint)
  • Line 147: warning: exported function GetTargetConfigFromKV should have comment or be unexported (golint)
  • Line 253: warning: exported function VerifyEnv should have comment or be unexported (golint)
  • Line 282: warning: exported function GetPassthroughEnv should have comment or be unexported (golint)
  • Line 327: warning: exported method KubeVirtDeploymentConfig.GetOperatorVersion should have comment or be unexported (golint)
  • Line 334: warning: exported method KubeVirtDeploymentConfig.GetApiVersion should have comment or be unexported (golint)
  • Line 341: warning: exported method KubeVirtDeploymentConfig.GetControllerVersion should have comment or be unexported (golint)
  • Line 348: warning: exported method KubeVirtDeploymentConfig.GetHandlerVersion should have comment or be unexported (golint)
  • Line 355: warning: exported method KubeVirtDeploymentConfig.GetLauncherVersion should have comment or be unexported (golint)
  • Line 362: warning: exported method KubeVirtDeploymentConfig.GetKubeVirtVersion should have comment or be unexported (golint)
  • Line 366: warning: exported method KubeVirtDeploymentConfig.GetImageRegistry should have comment or be unexported (golint)
  • Line 370: warning: exported method KubeVirtDeploymentConfig.GetImagePrefix should have comment or be unexported (golint)
  • Line 374: warning: exported method KubeVirtDeploymentConfig.GetExtraEnv should have comment or be unexported (golint)
  • Line 378: warning: exported method KubeVirtDeploymentConfig.UseShasums should have comment or be unexported (golint)
  • Line 382: warning: exported method KubeVirtDeploymentConfig.SetTargetDeploymentConfig should have comment or be unexported (golint)
  • Line 391: warning: exported method KubeVirtDeploymentConfig.SetObservedDeploymentConfig should have comment or be unexported (golint)
  • Line 400: warning: exported method KubeVirtDeploymentConfig.GetImagePullPolicy should have comment or be unexported (golint)
  • Line 408: warning: exported method KubeVirtDeploymentConfig.WorkloadUpdatesEnabled should have comment or be unexported (golint)
  • Line 413: warning: exported method KubeVirtDeploymentConfig.GetMonitorNamespaces should have comment or be unexported (golint)
  • Line 421: warning: exported method KubeVirtDeploymentConfig.GetMonitorServiceAccount should have comment or be unexported (golint)
  • Line 429: warning: exported method KubeVirtDeploymentConfig.GetNamespace should have comment or be unexported (golint)
  • Line 433: warning: exported method KubeVirtDeploymentConfig.GetVerbosity should have comment or be unexported (golint)
  • Line 438: warning: exported method KubeVirtDeploymentConfig.GetProductName should have comment or be unexported (golint)
  • Line 442: warning: exported method KubeVirtDeploymentConfig.GetProductVersion should have comment or be unexported (golint)
  • Line 505: warning: exported method KubeVirtDeploymentConfig.GetDeploymentID should have comment or be unexported (golint)
  • Line 509: warning: exported method KubeVirtDeploymentConfig.GetJson should have comment or be unexported (golint)
  • Line 517: warning: exported function NewEnvVarMap should have comment or be unexported (golint)
  • Line 527: warning: exported function IsValidLabel should have comment or be unexported (golint)

• kubevirt/tools/perfscale-audit/metric-client/metric-client.go
  • Line 58: warning: exported type MetricClient should have comment or be unexported (golint)
  • Line 63: warning: exported function NewMetricClient should have comment or be unexported (golint)
  • Line 273: warning: exported method MetricClient.GenerateResults should have comment or be unexported (golint)

• kubevirt/pkg/certificates/certificates.go
  • Line 12: warning: exported function GenerateSelfSignedCert should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/api/prometheus.go
  • Line 46: warning: exported type Decrementer should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/profiler/process-profiler.go
  • Line 39: warning: exported var ProcessProfileBaseDir should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/filter.go
  • Line 10: warning: exported const TSCFrequencyLabel should have comment or be unexported (golint)
  • Line 11: warning: exported const TSCFrequencySchedulingLabel should have comment or be unexported (golint)
  • Line 12: warning: exported const TSCScalableLabel should have comment or be unexported (golint)
  • Line 14: warning: exported type FilterPredicateFunc should have comment or be unexported (golint)
  • Line 16: warning: exported function IsSchedulable should have comment or be unexported (golint)
  • Line 24: warning: exported function HasInvTSCFrequency should have comment or be unexported (golint)
  • Line 38: warning: exported function TSCFrequencyGreaterEqual should have comment or be unexported (golint)
  • Line 54: warning: exported function NodeOfVMI should have comment or be unexported (golint)
  • Line 69: warning: exported function Not should have comment or be unexported (golint)
  • Line 75: warning: exported function FilterNodesFromCache should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/generated_mock_common.go
  • Line 4: warning: don't use an underscore in package name (golint)
  • Line 10: warning: comment on exported type MockDeviceHandler should be of the form "MockDeviceHandler ..." (with optional leading article) (golint)
  • Line 21: warning: exported function NewMockDeviceHandler should have comment or be unexported (golint)
  • Line 27: warning: exported method MockDeviceHandler.EXPECT should have comment or be unexported (golint)
  • Line 31: warning: exported method MockDeviceHandler.GetDeviceIOMMUGroup should have comment or be unexported (golint)
  • Line 42: warning: exported method MockDeviceHandler.GetDeviceDriver should have comment or be unexported (golint)
  • Line 53: warning: exported method MockDeviceHandler.GetDeviceNumaNode should have comment or be unexported (golint)
  • Line 63: warning: exported method MockDeviceHandler.GetDevicePCIID should have comment or be unexported (golint)
  • Line 74: warning: exported method MockDeviceHandler.GetMdevParentPCIAddr should have comment or be unexported (golint)
  • Line 85: warning: exported method MockDeviceHandler.CreateMDEVType should have comment or be unexported (golint)
  • Line 95: warning: exported method MockDeviceHandler.RemoveMDEVType should have comment or be unexported (golint)
  • Line 105: warning: exported method MockDeviceHandler.ReadMDEVAvailableInstances should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/isolation/generated_mock_detector.go
  • Line 12: warning: comment on exported type MockPodIsolationDetector should be of the form "MockPodIsolationDetector ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewMockPodIsolationDetector should have comment or be unexported (golint)
  • Line 29: warning: exported method MockPodIsolationDetector.EXPECT should have comment or be unexported (golint)
  • Line 33: warning: exported method MockPodIsolationDetector.Detect should have comment or be unexported (golint)
  • Line 44: warning: exported method MockPodIsolationDetector.DetectForSocket should have comment or be unexported (golint)
  • Line 55: warning: exported method MockPodIsolationDetector.Whitelist should have comment or be unexported (golint)
  • Line 65: warning: exported method MockPodIsolationDetector.AdjustResources should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/pci-placement.go
  • Line 9: warning: exported function PlacePCIDevicesOnRootComplex should have comment or be unexported (golint)

• kubevirt/tests/network/expose.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 12: warning: should not use dot imports (golint)

• kubevirt/pkg/container-disk/validation.go
  • Line 8: warning: exported const DiskSourceFallbackPath should have comment (or a comment on this block) or be unexported (golint)
  • Line 11: warning: exported type DiskInfo should have comment or be unexported (golint)
  • Line 18: warning: exported function VerifyQCOW2 should have comment or be unexported (golint)
  • Line 29: warning: exported function VerifyImage should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/vmistats/fakecollector.go
  • Line 56: warning: exported function RegisterFakeCollector should have comment or be unexported (golint)

• kubevirt/tests/storage/events.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)

• kubevirt/pkg/testutils/mock_flavor.go
  • Line 11: warning: exported type MockFlavorMethods should have comment or be unexported (golint)
  • Line 16: warning: exported method MockFlavorMethods.FindProfile should have comment or be unexported (golint)
  • Line 20: warning: exported method MockFlavorMethods.ApplyToVmi should have comment or be unexported (golint)
  • Line 24: warning: exported function NewMockFlavorMethods should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/rest/console.go
  • Line 15: warning: exported method SubresourceAPIApp.ConsoleRequestHandler should have comment or be unexported (golint)

• kubevirt/pkg/testutils/domain.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 11: warning: exported function ExpectVirtioTransitionalOnly should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/arm64.go
  • Line 17: warning: package comment should be of the form "Package webhooks ..." (golint)
  • Line 17: warning: package comment should not have leading space (golint)

• kubevirt/pkg/virt-api/webhooks/mutating-webhook/mutators/vm-mutator.go
  • Line 34: warning: exported type VMsMutator should have comment or be unexported (golint)
  • Line 46: warning: exported method VMsMutator.Mutate should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/isolation/generated_mock_isolation.go
  • Line 11: warning: comment on exported type MockIsolationResult should be of the form "MockIsolationResult ..." (with optional leading article) (golint)
  • Line 22: warning: exported function NewMockIsolationResult should have comment or be unexported (golint)
  • Line 28: warning: exported method MockIsolationResult.EXPECT should have comment or be unexported (golint)
  • Line 32: warning: exported method MockIsolationResult.Slice should have comment or be unexported (golint)
  • Line 42: warning: exported method MockIsolationResult.Pid should have comment or be unexported (golint)
  • Line 52: warning: exported method MockIsolationResult.PPid should have comment or be unexported (golint)
  • Line 62: warning: exported method MockIsolationResult.PIDNamespace should have comment or be unexported (golint)
  • Line 72: warning: exported method MockIsolationResult.MountRoot should have comment or be unexported (golint)
  • Line 82: warning: exported method MockIsolationResult.MountNamespace should have comment or be unexported (golint)
  • Line 92: warning: exported method MockIsolationResult.NetNamespace should have comment or be unexported (golint)
  • Line 102: warning: exported method MockIsolationResult.DoNetNS should have comment or be unexported (golint)
  • Line 112: warning: exported method MockIsolationResult.Mounts should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/servicemonitor.go
  • Line 30: warning: exported const MONITOR_SERVICEACCOUNT_NAME should have comment or be unexported (golint)
  • Line 32: warning: exported function GetAllServiceMonitor should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/expose/expose.go
  • Line 26: warning: exported const COMMAND_EXPOSE should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type Command should have comment or be unexported (golint)
  • Line 98: warning: comment on exported method Command.RunE should be of the form "RunE ..." (golint)

• kubevirt/pkg/ephemeral-disk/ephemeral-disk.go
  • Line 40: warning: exported type EphemeralDiskCreatorInterface should have comment or be unexported (golint)
  • Line 54: warning: exported function NewEphemeralDiskCreator should have comment or be unexported (golint)

• kubevirt/pkg/network/errors/errors.go
  • Line 5: warning: exported type CriticalNetworkError should have comment or be unexported (golint)
  • Line 11: warning: exported function CreateCriticalNetworkError should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/application.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 77: warning: exported type VirtOperatorApp should have comment or be unexported (golint)
  • Line 125: warning: exported function Execute should have comment or be unexported (golint)
  • Line 289: warning: exported method VirtOperatorApp.Run should have comment or be unexported (golint)
  • Line 412: warning: exported method VirtOperatorApp.AddFlags should have comment or be unexported (golint)

• kubevirt/tests/storage/hotplug.go
  • Line 30: warning: should not use dot imports (golint)
  • Line 32: warning: should not use dot imports (golint)
  • Line 34: warning: should not use dot imports (golint)

• kubevirt/pkg/virt-operator/resource/generate/csv/csv.go
  • Line 1: warning: package comment should be of the form "Package csv ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 37: warning: exported type NewClusterServiceVersionData should have comment or be unexported (golint)
  • Line 141: warning: exported function NewClusterServiceVersion should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/validating-webhook/admitters/migration-create-admitter.go
  • Line 40: warning: exported type MigrationCreateAdmitter should have comment or be unexported (golint)
  • Line 79: warning: exported method MigrationCreateAdmitter.Admit should have comment or be unexported (golint)
  • Line 160: warning: exported function ValidateVirtualMachineInstanceMigrationSpec should have comment or be unexported (golint)

• kubevirt/tools/util/marshaller.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 33: warning: exported function MarshallObject should have comment or be unexported (golint)

• kubevirt/tests/migration.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)
  • Line 19: warning: exported function ExpectMigrationSuccess should have comment or be unexported (golint)
  • Line 44: warning: exported function RunMigrationAndExpectCompletion should have comment or be unexported (golint)
  • Line 57: warning: exported function ConfirmVMIPostMigration should have comment or be unexported (golint)
  • Line 77: warning: exported function EnsureNoMigrationMetadataInPersistentXML should have comment or be unexported (golint)

• kubevirt/pkg/hooks/v1alpha2/v1alpha2.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported const Version should have comment or be unexported (golint)

• kubevirt/pkg/util/migrations/migrations.go
  • Line 10: warning: exported function ListUnfinishedMigrations should have comment or be unexported (golint)
  • Line 22: warning: exported function FilterRunningMigrations should have comment or be unexported (golint)
  • Line 52: warning: exported function MigrationFailed should have comment or be unexported (golint)
  • Line 61: warning: exported function MigrationNeedsProtection should have comment or be unexported (golint)

• kubevirt/tests/containerdisk/containerdisk.go
  • Line 28: warning: exported type ContainerDisk should have comment or be unexported (golint)
  • Line 31: warning: exported const ContainerDiskCirrosCustomLocation should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported function DataVolumeImportUrlForContainerDisk should have comment or be unexported (golint)
  • Line 52: warning: exported function DataVolumeImportUrlFromRegistryForContainerDisk should have comment or be unexported (golint)
  • Line 56: warning: exported function ContainerDiskFromRegistryFor should have comment or be unexported (golint)

• kubevirt/tests/libnet/service/service.go
  • Line 28: warning: exported function BuildHeadlessSpec should have comment or be unexported (golint)
  • Line 34: warning: exported function BuildIPv6Spec should have comment or be unexported (golint)
  • Line 42: warning: exported function BuildSpec should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/api_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-api/rest/authorizer.go
  • Line 46: warning: exported type VirtApiAuthorizor should have comment or be unexported (golint)
  • Line 204: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 214: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 301: warning: exported function NewAuthorizorFromConfig should have comment or be unexported (golint)
  • Line 321: warning: exported function NewAuthorizor should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/cli/libvirt.go
  • Line 41: warning: exported const ConnectionTimeout should have comment or be unexported (golint)
  • Line 42: warning: exported const ConnectionInterval should have comment or be unexported (golint)
  • Line 44: warning: comment on exported type Connection should be of the form "Connection ..." (with optional leading article) (golint)
  • Line 67: warning: exported type Stream should have comment or be unexported (golint)
  • Line 72: warning: exported type VirStream should have comment or be unexported (golint)
  • Line 76: warning: exported type LibvirtConnection should have comment or be unexported (golint)
  • Line 114: warning: exported method VirStream.UnderlyingStream should have comment or be unexported (golint)
  • Line 118: warning: exported method LibvirtConnection.SetReconnectChan should have comment or be unexported (golint)
  • Line 122: warning: exported method LibvirtConnection.NewStream should have comment or be unexported (golint)
  • Line 135: warning: exported method LibvirtConnection.Close should have comment or be unexported (golint)
  • Line 139: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 144: warning: exported method LibvirtConnection.DomainEventLifecycleRegister should have comment or be unexported (golint)
  • Line 155: warning: exported method LibvirtConnection.DomainEventDeviceAddedRegister should have comment or be unexported (golint)
  • Line 166: warning: exported method LibvirtConnection.DomainEventDeviceRemovedRegister should have comment or be unexported (golint)
  • Line 177: warning: exported method LibvirtConnection.AgentEventLifecycleRegister should have comment or be unexported (golint)
  • Line 188: warning: exported method LibvirtConnection.VolatileDomainEventDeviceRemovedRegister should have comment or be unexported (golint)
  • Line 196: warning: exported method LibvirtConnection.DomainEventDeregister should have comment or be unexported (golint)
  • Line 200: warning: exported method LibvirtConnection.LookupDomainByName should have comment or be unexported (golint)
  • Line 210: warning: exported method LibvirtConnection.DomainDefineXML should have comment or be unexported (golint)
  • Line 220: warning: exported method LibvirtConnection.ListAllDomains should have comment or be unexported (golint)
  • Line 237: warning: comment on exported method LibvirtConnection.QemuAgentCommand should be of the form "QemuAgentCommand ..." (golint)
  • Line 253: warning: exported method LibvirtConnection.GetAllDomainStats should have comment or be unexported (golint)
  • Line 267: warning: exported method LibvirtConnection.GetDomainStats should have comment or be unexported (golint)
  • Line 321: warning: exported method LibvirtConnection.GetDeviceAliasMap should have comment or be unexported (golint)
  • Line 456: warning: exported type VirDomain should have comment or be unexported (golint)
  • Line 486: warning: exported function NewConnection should have comment or be unexported (golint)
  • Line 490: warning: exported function NewConnectionWithTimeout should have comment or be unexported (golint)
  • Line 544: warning: exported function IsDown should have comment or be unexported (golint)
  • Line 553: warning: exported function IsPaused should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/webhooks/kubevirt-update-admitter.go
  • Line 54: warning: exported method KubeVirtUpdateAdmitter.Admit should have comment or be unexported (golint)

• kubevirt/tests/performance/framework.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 31: warning: exported var RunPerfTests should have comment or be unexported (golint)
  • Line 56: warning: exported function SIGDescribe should have comment or be unexported (golint)
  • Line 60: warning: exported function FSIGDescribe should have comment or be unexported (golint)

• kubevirt/tests/io_utils.go
  • Line 1: warning: package comment should be of the form "Package tests ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 37: warning: should not use dot imports (golint)
  • Line 41: warning: exported function NodeNameWithHandler should have comment or be unexported (golint)
  • Line 52: warning: exported function ExecuteCommandInVirtHandlerPod should have comment or be unexported (golint)
  • Line 70: warning: exported function CreateErrorDisk should have comment or be unexported (golint)
  • Line 98: warning: exported function RemoveErrorDisk should have comment or be unexported (golint)
  • Line 108: warning: exported function FixErrorDevice should have comment or be unexported (golint)
  • Line 157: warning: exported function CreateFaultyDisk should have comment or be unexported (golint)
  • Line 163: warning: exported function CreatePVandPVCwithFaultyDisk should have comment or be unexported (golint)
  • Line 232: warning: exported function RemoveFaultyDisk should have comment or be unexported (golint)

• kubevirt/cmd/virt-chroot/selinux.go
  • Line 33: warning: exported function RelabelCommand should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/workqueue/prometheus/prometheus.go
  • Line 46: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 58: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 70: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 83: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 96: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 108: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
  • Line 121: warning: receiver name should not be an underscore, omit the name if it is unused (golint)

• kubevirt/pkg/util/webhooks/tls.go
  • Line 15: warning: exported function SetupPromTLS should have comment or be unexported (golint)
  • Line 44: warning: exported function SetupTLSWithCertManager should have comment or be unexported (golint)
  • Line 79: warning: exported function SetupTLSForVirtHandlerServer should have comment or be unexported (golint)
  • Line 152: warning: exported function SetupTLSForVirtHandlerClients should have comment or be unexported (golint)

• kubevirt/pkg/virt-config/virt-config.go
  • Line 34: warning: exported const ParallelOutboundMigrationsPerNodeDefault should have comment (or a comment on this block) or be unexported (golint)
  • Line 74: warning: comment on exported const DefaultVirtHandlerQPS should be of the form "DefaultVirtHandlerQPS ..." (golint)
  • Line 85: warning: exported function IsAMD64 should have comment or be unexported (golint)
  • Line 92: warning: exported function IsARM64 should have comment or be unexported (golint)
  • Line 99: warning: exported function IsPPC64 should have comment or be unexported (golint)
  • Line 106: warning: exported method ClusterConfig.GetMemBalloonStatsPeriod should have comment or be unexported (golint)
  • Line 110: warning: exported method ClusterConfig.AllowEmulation should have comment or be unexported (golint)
  • Line 114: warning: exported method ClusterConfig.GetMigrationConfiguration should have comment or be unexported (golint)
  • Line 118: warning: exported method ClusterConfig.GetImagePullPolicy should have comment or be unexported (golint)
  • Line 122: warning: exported method ClusterConfig.GetResourceVersion should have comment or be unexported (golint)
  • Line 128: warning: exported method ClusterConfig.GetMachineType should have comment or be unexported (golint)
  • Line 132: warning: exported method ClusterConfig.GetCPUModel should have comment or be unexported (golint)
  • Line 136: warning: exported method ClusterConfig.GetCPURequest should have comment or be unexported (golint)
  • Line 140: warning: exported method ClusterConfig.GetDiskVerification should have comment or be unexported (golint)
  • Line 144: warning: exported method ClusterConfig.GetMemoryOvercommit should have comment or be unexported (golint)
  • Line 148: warning: exported method ClusterConfig.GetEmulatedMachines should have comment or be unexported (golint)
  • Line 152: warning: exported method ClusterConfig.GetLessPVCSpaceToleration should have comment or be unexported (golint)
  • Line 156: warning: exported method ClusterConfig.GetMinimumReservePVCBytes should have comment or be unexported (golint)
  • Line 160: warning: exported method ClusterConfig.GetNodeSelectors should have comment or be unexported (golint)
  • Line 164: warning: exported method ClusterConfig.GetDefaultNetworkInterface should have comment or be unexported (golint)
  • Line 168: warning: exported method ClusterConfig.IsSlirpInterfaceEnabled should have comment or be unexported (golint)
  • Line 172: warning: exported method ClusterConfig.GetSMBIOS should have comment or be unexported (golint)
  • Line 176: warning: exported method ClusterConfig.IsBridgeInterfaceOnPodNetworkEnabled should have comment or be unexported (golint)
  • Line 180: warning: exported method ClusterConfig.GetDefaultClusterConfig should have comment or be unexported (golint)
  • Line 184: warning: exported method ClusterConfig.GetSELinuxLauncherType should have comment or be unexported (golint)
  • Line 188: warning: exported method ClusterConfig.GetDefaultRuntimeClass should have comment or be unexported (golint)
  • Line 192: warning: exported method ClusterConfig.GetSupportedAgentVersions should have comment or be unexported (golint)
  • Line 196: warning: exported method ClusterConfig.GetOVMFPath should have comment or be unexported (golint)
  • Line 200: warning: exported method ClusterConfig.GetCPUAllocationRatio should have comment or be unexported (golint)
  • Line 204: warning: exported method ClusterConfig.GetMinimumClusterTSCFrequency should have comment or be unexported (golint)
  • Line 208: warning: exported method ClusterConfig.GetPermittedHostDevices should have comment or be unexported (golint)
  • Line 212: warning: exported method ClusterConfig.GetDesiredMDEVTypes should have comment or be unexported (golint)
  • Line 220: warning: exported method ClusterConfig.GetVirtHandlerVerbosity should have comment or be unexported (golint)
  • Line 228: warning: exported method ClusterConfig.GetVirtAPIVerbosity should have comment or be unexported (golint)
  • Line 236: warning: exported method ClusterConfig.GetVirtControllerVerbosity should have comment or be unexported (golint)
  • Line 244: warning: exported method ClusterConfig.GetVirtLauncherVerbosity should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/node-labeller/kvm-caps-info-plugin_amd64.go
  • Line 63: warning: exported const HV_X64_MSR_RESET should have comment (or a comment on this block) or be unexported (golint)
  • Line 78: warning: exported var CapsDesc should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/cli/generated_mock_libvirt.go
  • Line 13: warning: comment on exported type MockConnection should be of the form "MockConnection ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewMockConnection should have comment or be unexported (golint)
  • Line 30: warning: exported method MockConnection.EXPECT should have comment or be unexported (golint)
  • Line 34: warning: exported method MockConnection.LookupDomainByName should have comment or be unexported (golint)
  • Line 45: warning: exported method MockConnection.DomainDefineXML should have comment or be unexported (golint)
  • Line 56: warning: exported method MockConnection.Close should have comment or be unexported (golint)
  • Line 67: warning: exported method MockConnection.DomainEventLifecycleRegister should have comment or be unexported (golint)
  • Line 77: warning: exported method MockConnection.DomainEventDeviceAddedRegister should have comment or be unexported (golint)
  • Line 87: warning: exported method MockConnection.DomainEventDeviceRemovedRegister should have comment or be unexported (golint)
  • Line 97: warning: exported method MockConnection.AgentEventLifecycleRegister should have comment or be unexported (golint)
  • Line 107: warning: exported method MockConnection.VolatileDomainEventDeviceRemovedRegister should have comment or be unexported (golint)
  • Line 118: warning: exported method MockConnection.DomainEventDeregister should have comment or be unexported (golint)
  • Line 128: warning: exported method MockConnection.ListAllDomains should have comment or be unexported (golint)
  • Line 139: warning: exported method MockConnection.NewStream should have comment or be unexported (golint)
  • Line 150: warning: exported method MockConnection.SetReconnectChan should have comment or be unexported (golint)
  • Line 158: warning: exported method MockConnection.QemuAgentCommand should have comment or be unexported (golint)
  • Line 169: warning: exported method MockConnection.GetAllDomainStats should have comment or be unexported (golint)
  • Line 180: warning: exported method MockConnection.GetDomainStats should have comment or be unexported (golint)
  • Line 191: warning: comment on exported type MockStream should be of the form "MockStream ..." (with optional leading article) (golint)
  • Line 202: warning: exported function NewMockStream should have comment or be unexported (golint)
  • Line 208: warning: exported method MockStream.EXPECT should have comment or be unexported (golint)
  • Line 234: warning: exported method MockStream.Close should have comment or be unexported (golint)
  • Line 244: warning: exported method MockStream.UnderlyingStream should have comment or be unexported (golint)
  • Line 254: warning: comment on exported type MockVirDomain should be of the form "MockVirDomain ..." (with optional leading article) (golint)
  • Line 265: warning: exported function NewMockVirDomain should have comment or be unexported (golint)
  • Line 271: warning: exported method MockVirDomain.EXPECT should have comment or be unexported (golint)
  • Line 275: warning: exported method MockVirDomain.GetState should have comment or be unexported (golint)
  • Line 287: warning: exported method MockVirDomain.Create should have comment or be unexported (golint)
  • Line 297: warning: exported method MockVirDomain.CreateWithFlags should have comment or be unexported (golint)
  • Line 307: warning: exported method MockVirDomain.Suspend should have comment or be unexported (golint)
  • Line 317: warning: exported method MockVirDomain.Resume should have comment or be unexported (golint)
  • Line 327: warning: exported method MockVirDomain.AttachDevice should have comment or be unexported (golint)
  • Line 337: warning: exported method MockVirDomain.AttachDeviceFlags should have comment or be unexported (golint)
  • Line 347: warning: exported method MockVirDomain.DetachDevice should have comment or be unexported (golint)
  • Line 357: warning: exported method MockVirDomain.DetachDeviceFlags should have comment or be unexported (golint)
  • Line 367: warning: exported method MockVirDomain.DestroyFlags should have comment or be unexported (golint)
  • Line 377: warning: exported method MockVirDomain.ShutdownFlags should have comment or be unexported (golint)
  • Line 387: warning: exported method MockVirDomain.UndefineFlags should have comment or be unexported (golint)
  • Line 397: warning: exported method MockVirDomain.GetName should have comment or be unexported (golint)
  • Line 408: warning: exported method MockVirDomain.GetUUIDString should have comment or be unexported (golint)
  • Line 419: warning: exported method MockVirDomain.GetXMLDesc should have comment or be unexported (golint)
  • Line 430: warning: exported method MockVirDomain.GetMetadata should have comment or be unexported (golint)
  • Line 441: warning: exported method MockVirDomain.OpenConsole should have comment or be unexported (golint)
  • Line 451: warning: exported method MockVirDomain.MigrateToURI3 should have comment or be unexported (golint)
  • Line 461: warning: exported method MockVirDomain.MigrateStartPostCopy should have comment or be unexported (golint)
  • Line 471: warning: exported method MockVirDomain.MemoryStats should have comment or be unexported (golint)
  • Line 482: warning: exported method MockVirDomain.GetJobStats should have comment or be unexported (golint)
  • Line 493: warning: exported method MockVirDomain.GetJobInfo should have comment or be unexported (golint)
  • Line 504: warning: exported method MockVirDomain.GetDiskErrors should have comment or be unexported (golint)
  • Line 515: warning: exported method MockVirDomain.SetTime should have comment or be unexported (golint)
  • Line 525: warning: exported method MockVirDomain.IsPersistent should have comment or be unexported (golint)
  • Line 536: warning: exported method MockVirDomain.AbortJob should have comment or be unexported (golint)
  • Line 546: warning: exported method MockVirDomain.Free should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/install/generated_mock_strategy.go
  • Line 15: warning: comment on exported type MockAPIServiceInterface should be of the form "MockAPIServiceInterface ..." (with optional leading article) (golint)
  • Line 26: warning: exported function NewMockAPIServiceInterface should have comment or be unexported (golint)
  • Line 32: warning: exported method MockAPIServiceInterface.EXPECT should have comment or be unexported (golint)
  • Line 36: warning: exported method MockAPIServiceInterface.Get should have comment or be unexported (golint)
  • Line 47: warning: exported method MockAPIServiceInterface.Create should have comment or be unexported (golint)
  • Line 58: warning: exported method MockAPIServiceInterface.Delete should have comment or be unexported (golint)
  • Line 68: warning: exported method MockAPIServiceInterface.Patch should have comment or be unexported (golint)

• kubevirt/tests/framework/checks/checks.go
  • Line 13: warning: exported function IsCPUManagerPresent should have comment or be unexported (golint)
  • Line 26: warning: exported function IsRealtimeCapable should have comment or be unexported (golint)
  • Line 28: warning: should omit 2nd value from range; this loop is equivalent to `for label := range ...` (golint)
  • Line 36: warning: exported function Has2MiHugepages should have comment or be unexported (golint)
  • Line 42: warning: exported function HasFeature should have comment or be unexported (golint)

• kubevirt/pkg/network/istio/proxy.go
  • Line 28: warning: exported function ProxyInjectionEnabled should have comment or be unexported (golint)
  • Line 35: warning: exported function GetLoopbackAddress should have comment or be unexported (golint)

• kubevirt/pkg/network/infraconfigurators/generated_mock_common.go
  • Line 13: warning: comment on exported type MockPodNetworkInfraConfigurator should be of the form "MockPodNetworkInfraConfigurator ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewMockPodNetworkInfraConfigurator should have comment or be unexported (golint)
  • Line 30: warning: exported method MockPodNetworkInfraConfigurator.EXPECT should have comment or be unexported (golint)
  • Line 34: warning: exported method MockPodNetworkInfraConfigurator.DiscoverPodNetworkInterface should have comment or be unexported (golint)
  • Line 44: warning: exported method MockPodNetworkInfraConfigurator.PreparePodNetworkInterface should have comment or be unexported (golint)
  • Line 54: warning: exported method MockPodNetworkInfraConfigurator.GenerateNonRecoverableDomainIfaceSpec should have comment or be unexported (golint)
  • Line 64: warning: exported method MockPodNetworkInfraConfigurator.GenerateNonRecoverableDHCPConfig should have comment or be unexported (golint)

• kubevirt/tests/framework/storage/nfs.go
  • Line 15: warning: exported function RenderNFSServerWithPVC should have comment or be unexported (golint)
  • Line 62: warning: exported function RenderNFSServer should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/components/crds.go
  • Line 1: warning: package comment should be of the form "Package components ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 42: warning: exported var VIRTUALMACHINE should have comment or be unexported (golint)
  • Line 126: warning: exported function NewVirtualMachineInstanceCrd should have comment or be unexported (golint)
  • Line 164: warning: exported function NewVirtualMachineCrd should have comment or be unexported (golint)
  • Line 199: warning: exported function NewPresetCrd should have comment or be unexported (golint)
  • Line 225: warning: exported function NewReplicaSetCrd should have comment or be unexported (golint)
  • Line 271: warning: exported function NewVirtualMachineInstanceMigrationCrd should have comment or be unexported (golint)
  • Line 303: warning: comment on exported function NewKubeVirtCrd should be of the form "NewKubeVirtCrd ..." (golint)
  • Line 353: warning: exported function NewVirtualMachineSnapshotCrd should have comment or be unexported (golint)
  • Line 395: warning: exported function NewVirtualMachineSnapshotContentCrd should have comment or be unexported (golint)
  • Line 434: warning: exported function NewVirtualMachineRestoreCrd should have comment or be unexported (golint)
  • Line 475: warning: exported function NewVirtualMachineFlavorCrd should have comment or be unexported (golint)
  • Line 502: warning: exported function NewVirtualMachineClusterFlavorCrd should have comment or be unexported (golint)
  • Line 529: warning: comment on exported function NewKubeVirtCR should be of the form "NewKubeVirtCR ..." (golint)

• kubevirt/tools/marketplace/helper/bundleHelper.go
  • Line 1: warning: package comment should be of the form "Package helper ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 38: warning: exported type Channel should have comment or be unexported (golint)
  • Line 43: warning: exported type Pkg should have comment or be unexported (golint)
  • Line 48: warning: exported type Data should have comment or be unexported (golint)
  • Line 54: warning: exported type Bundle should have comment or be unexported (golint)
  • Line 58: warning: exported type BundleHelper should have comment or be unexported (golint)
  • Line 66: warning: exported function NewBundleHelper should have comment or be unexported (golint)
  • Line 161: warning: exported method BundleHelper.AddOldManifests should have comment or be unexported (golint)
  • Line 224: warning: exported function GetCSVVersion should have comment or be unexported (golint)
  • Line 239: warning: exported function GetCSVName should have comment or be unexported (golint)
  • Line 254: warning: exported method BundleHelper.GetLatestPublishedCSVVersion should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/replicaset.go
  • Line 68: warning: exported function NewVMIReplicaSet should have comment or be unexported (golint)
  • Line 96: warning: exported type VMIReplicaSet should have comment or be unexported (golint)
  • Line 107: warning: exported method VMIReplicaSet.Run should have comment or be unexported (golint)
  • Line 129: warning: exported method VMIReplicaSet.Execute should have comment or be unexported (golint)
  • Line 744: warning: exported function OwnerRef should have comment or be unexported (golint)

• kubevirt/pkg/network/dhcp/configurator.go
  • Line 35: warning: exported type Configurator should have comment or be unexported (golint)
  • Line 48: warning: exported type ConfigGenerator should have comment or be unexported (golint)
  • Line 52: warning: exported function NewBridgeConfigurator should have comment or be unexported (golint)
  • Line 63: warning: exported function NewMasqueradeConfigurator should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/container-disk/generated_mock_mount.go
  • Line 4: warning: don't use an underscore in package name (golint)
  • Line 15: warning: comment on exported type MockMounter should be of the form "MockMounter ..." (with optional leading article) (golint)
  • Line 26: warning: exported function NewMockMounter should have comment or be unexported (golint)
  • Line 32: warning: exported method MockMounter.EXPECT should have comment or be unexported (golint)
  • Line 36: warning: exported method MockMounter.ContainerDisksReady should have comment or be unexported (golint)
  • Line 47: warning: exported method MockMounter.MountAndVerify should have comment or be unexported (golint)
  • Line 58: warning: exported method MockMounter.MountKernelArtifacts should have comment or be unexported (golint)
  • Line 68: warning: exported method MockMounter.Unmount should have comment or be unexported (golint)
  • Line 78: warning: exported method MockMounter.UnmountKernelArtifacts should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/node-labeller/util/util.go
  • Line 23: warning: exported const DeprecatedLabelNamespace should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported var DefaultObsoleteCPUModels should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/vm.go
  • Line 113: warning: exported var RequiredGuestAgentCommands should have comment or be unexported (golint)
  • Line 126: warning: exported var SSHRelatedGuestAgentCommands should have comment or be unexported (golint)
  • Line 135: warning: exported var PasswordRelatedGuestAgentCommands should have comment or be unexported (golint)
  • Line 139: warning: exported function NewController should have comment or be unexported (golint)
  • Line 232: warning: exported type VirtualMachineController should have comment or be unexported (golint)
  • Line 1161: warning: exported function IsoGuestVolumePath should have comment or be unexported (golint)
  • Line 1219: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 1431: warning: exported method VirtualMachineController.Run should have comment or be unexported (golint)
  • Line 1431: warning: receiver name c should be consistent with previous receiver name d for VirtualMachineController (golint)
  • Line 1467: warning: receiver name c should be consistent with previous receiver name d for VirtualMachineController (golint)
  • Line 1472: warning: exported method VirtualMachineController.Execute should have comment or be unexported (golint)
  • Line 1472: warning: receiver name c should be consistent with previous receiver name d for VirtualMachineController (golint)
  • Line 2557: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2651: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2958: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/sriov/pcipool.go
  • Line 31: warning: exported type PCIAddressPool should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/converter/converter.go
  • Line 67: warning: exported type HostDeviceType should have comment or be unexported (golint)
  • Line 79: warning: exported const QEMUSeaBiosDebugPipe should have comment (or a comment on this block) or be unexported (golint)
  • Line 87: warning: exported type HostDevicesList should have comment or be unexported (golint)
  • Line 92: warning: exported type EFIConfiguration should have comment or be unexported (golint)
  • Line 98: warning: exported type ConverterContext should have comment or be unexported (golint)
  • Line 153: warning: exported function Convert_v1_Disk_To_api_Disk should have comment or be unexported (golint)
  • Line 153: warning: don't use underscores in Go names; func Convert_v1_Disk_To_api_Disk should be ConvertV1DiskToAPIDisk (golint)
  • Line 231: warning: exported type DirectIOChecker should have comment or be unexported (golint)
  • Line 238: warning: exported function NewDirectIOChecker should have comment or be unexported (golint)
  • Line 276: warning: exported function Convert_v1_BlockSize_To_api_BlockIO should have comment or be unexported (golint)
  • Line 276: warning: don't use underscores in Go names; func Convert_v1_BlockSize_To_api_BlockIO should be ConvertV1BlockSizeToAPIBlockIO (golint)
  • Line 358: warning: exported function SetDriverCacheMode should have comment or be unexported (golint)
  • Line 427: warning: comment on exported function SetOptimalIOMode should be of the form "SetOptimalIOMode ..." (golint)
  • Line 505: warning: comment on exported function FormatDeviceName should be of the form "FormatDeviceName ..." (golint)
  • Line 525: warning: don't use underscores in Go names; func Add_Agent_To_api_Channel should be AddAgentToAPIChannel (golint)
  • Line 537: warning: exported function Convert_v1_Volume_To_api_Disk should have comment or be unexported (golint)
  • Line 537: warning: don't use underscores in Go names; func Convert_v1_Volume_To_api_Disk should be ConvertV1VolumeToAPIDisk (golint)
  • Line 589: warning: don't use underscores in Go names; func Convert_v1_Hotplug_Volume_To_api_Disk should be ConvertV1HotplugVolumeToAPIDisk (golint)
  • Line 606: warning: exported function Convert_v1_Config_To_api_Disk should have comment or be unexported (golint)
  • Line 606: warning: don't use underscores in Go names; func Convert_v1_Config_To_api_Disk should be ConvertV1ConfigToAPIDisk (golint)
  • Line 630: warning: exported function GetFilesystemVolumePath should have comment or be unexported (golint)
  • Line 639: warning: exported function GetBlockDeviceVolumePath should have comment or be unexported (golint)
  • Line 648: warning: exported function Convert_v1_PersistentVolumeClaim_To_api_Disk should have comment or be unexported (golint)
  • Line 648: warning: don't use underscores in Go names; func Convert_v1_PersistentVolumeClaim_To_api_Disk should be ConvertV1PersistentVolumeClaimToAPIDisk (golint)
  • Line 656: warning: don't use underscores in Go names; func Convert_v1_Hotplug_PersistentVolumeClaim_To_api_Disk should be ConvertV1HotplugPersistentVolumeClaimToAPIDisk (golint)
  • Line 663: warning: exported function Convert_v1_DataVolume_To_api_Disk should have comment or be unexported (golint)
  • Line 663: warning: don't use underscores in Go names; func Convert_v1_DataVolume_To_api_Disk should be ConvertV1DataVolumeToAPIDisk (golint)
  • Line 671: warning: don't use underscores in Go names; func Convert_v1_Hotplug_DataVolume_To_api_Disk should be ConvertV1HotplugDataVolumeToAPIDisk (golint)
  • Line 679: warning: don't use underscores in Go names; func Convert_v1_FilesystemVolumeSource_To_api_Disk should be ConvertV1FilesystemVolumeSourceToAPIDisk (golint)
  • Line 691: warning: don't use underscores in Go names; func Convert_v1_Hotplug_FilesystemVolumeSource_To_api_Disk should be ConvertV1HotplugFilesystemVolumeSourceToAPIDisk (golint)
  • Line 702: warning: exported function Convert_v1_BlockVolumeSource_To_api_Disk should have comment or be unexported (golint)
  • Line 702: warning: don't use underscores in Go names; func Convert_v1_BlockVolumeSource_To_api_Disk should be ConvertV1BlockVolumeSourceToAPIDisk (golint)
  • Line 715: warning: don't use underscores in Go names; func Convert_v1_Hotplug_BlockVolumeSource_To_api_Disk should be ConvertV1HotplugBlockVolumeSourceToAPIDisk (golint)
  • Line 726: warning: exported function Convert_v1_HostDisk_To_api_Disk should have comment or be unexported (golint)
  • Line 726: warning: don't use underscores in Go names; func Convert_v1_HostDisk_To_api_Disk should be ConvertV1HostDiskToAPIDisk (golint)
  • Line 734: warning: exported function Convert_v1_SysprepSource_To_api_Disk should have comment or be unexported (golint)
  • Line 734: warning: don't use underscores in Go names; func Convert_v1_SysprepSource_To_api_Disk should be ConvertV1SysprepSourceToAPIDisk (golint)
  • Line 745: warning: exported function Convert_v1_CloudInitSource_To_api_Disk should have comment or be unexported (golint)
  • Line 745: warning: don't use underscores in Go names; func Convert_v1_CloudInitSource_To_api_Disk should be ConvertV1CloudInitSourceToAPIDisk (golint)
  • Line 766: warning: exported function Convert_v1_DownwardMetricSource_To_api_Disk should have comment or be unexported (golint)
  • Line 766: warning: don't use underscores in Go names; func Convert_v1_DownwardMetricSource_To_api_Disk should be ConvertV1DownwardMetricSourceToAPIDisk (golint)
  • Line 781: warning: exported function Convert_v1_EmptyDiskSource_To_api_Disk should have comment or be unexported (golint)
  • Line 781: warning: don't use underscores in Go names; func Convert_v1_EmptyDiskSource_To_api_Disk should be ConvertV1EmptyDiskSourceToAPIDisk (golint)
  • Line 795: warning: exported function Convert_v1_ContainerDiskSource_To_api_Disk should have comment or be unexported (golint)
  • Line 795: warning: don't use underscores in Go names; func Convert_v1_ContainerDiskSource_To_api_Disk should be ConvertV1ContainerDiskSourceToAPIDisk (golint)
  • Line 821: warning: exported function Convert_v1_EphemeralVolumeSource_To_api_Disk should have comment or be unexported (golint)
  • Line 821: warning: don't use underscores in Go names; func Convert_v1_EphemeralVolumeSource_To_api_Disk should be ConvertV1EphemeralVolumeSourceToAPIDisk (golint)
  • Line 852: warning: exported function Convert_v1_Watchdog_To_api_Watchdog should have comment or be unexported (golint)
  • Line 852: warning: don't use underscores in Go names; func Convert_v1_Watchdog_To_api_Watchdog should be ConvertV1WatchdogToAPIWatchdog (golint)
  • Line 862: warning: exported function Convert_v1_Rng_To_api_Rng should have comment or be unexported (golint)
  • Line 862: warning: don't use underscores in Go names; func Convert_v1_Rng_To_api_Rng should be ConvertV1RngToAPIRng (golint)
  • Line 878: warning: exported function Convert_v1_Usbredir_To_api_Usbredir should have comment or be unexported (golint)
  • Line 878: warning: don't use underscores in Go names; func Convert_v1_Usbredir_To_api_Usbredir should be ConvertV1UsbredirToAPIUsbredir (golint)
  • Line 905: warning: exported function Convert_v1_Input_To_api_InputDevice should have comment or be unexported (golint)
  • Line 905: warning: don't use underscores in Go names; func Convert_v1_Input_To_api_InputDevice should be ConvertV1InputToAPIInputDevice (golint)
  • Line 928: warning: exported function Convert_v1_Clock_To_api_Clock should have comment or be unexported (golint)
  • Line 928: warning: don't use underscores in Go names; func Convert_v1_Clock_To_api_Clock should be ConvertV1ClockToAPIClock (golint)
  • Line 985: warning: exported function Convert_v1_Features_To_api_Features should have comment or be unexported (golint)
  • Line 985: warning: don't use underscores in Go names; func Convert_v1_Features_To_api_Features should be ConvertV1FeaturesToAPIFeatures (golint)
  • Line 1021: warning: exported function Convert_v1_FeatureHyperv_To_api_FeatureHyperv should have comment or be unexported (golint)
  • Line 1021: warning: don't use underscores in Go names; func Convert_v1_FeatureHyperv_To_api_FeatureHyperv should be ConvertV1FeatureHypervToAPIFeatureHyperv (golint)
  • Line 1067: warning: exported function ConvertV1ToAPIBalloning should have comment or be unexported (golint)
  • Line 1090: warning: exported function Convert_v1_VirtualMachineInstance_To_api_Domain should have comment or be unexported (golint)
  • Line 1090: warning: don't use underscores in Go names; func Convert_v1_VirtualMachineInstance_To_api_Domain should be ConvertV1VirtualMachineInstanceToAPIDomain (golint)
  • Line 1904: warning: exported function QuantityToByte should have comment or be unexported (golint)
  • Line 1919: warning: exported function QuantityToMebiByte should have comment or be unexported (golint)
  • Line 1954: warning: exported function GetImageInfo should have comment or be unexported (golint)
  • Line 2034: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/tests/network/probes.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• kubevirt/pkg/network/infraconfigurators/masquerade.go
  • Line 24: warning: exported const LibvirtDirectMigrationPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type MasqueradePodNetworkConfigurator should have comment or be unexported (golint)
  • Line 42: warning: exported function NewMasqueradePodNetworkConfigurator should have comment or be unexported (golint)
  • Line 53: warning: exported method MasqueradePodNetworkConfigurator.DiscoverPodNetworkInterface should have comment or be unexported (golint)
  • Line 100: warning: exported method MasqueradePodNetworkConfigurator.GenerateNonRecoverableDHCPConfig should have comment or be unexported (golint)
  • Line 104: warning: exported method MasqueradePodNetworkConfigurator.PreparePodNetworkInterface should have comment or be unexported (golint)
  • Line 142: warning: exported method MasqueradePodNetworkConfigurator.GenerateNonRecoverableDomainIfaceSpec should have comment or be unexported (golint)
  • Line 193: warning: exported function GetLoopbackAdrress should have comment or be unexported (golint)
  • Line 196: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 473: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 481: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 509: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/virt-controller/watch/drain/evacuation/evacuation.go
  • Line 33: warning: exported type EvacuationController should have comment or be unexported (golint)
  • Line 45: warning: exported function NewEvacuationController should have comment or be unexported (golint)
  • Line 283: warning: exported method EvacuationController.Execute should have comment or be unexported (golint)
  • Line 341: warning: exported function GenerateNewMigration should have comment or be unexported (golint)
  • Line 427: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kubevirt/pkg/virt-handler/device-manager/mediated_devices_types.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 37: warning: exported type MDEVTypesManager should have comment or be unexported (golint)
  • Line 44: warning: exported function NewMDEVTypesManager should have comment or be unexported (golint)
  • Line 128: warning: should omit 2nd value from range; this loop is equivalent to `for desiredType := range ...` (golint)

• kubevirt/pkg/virtctl/root.go
  • Line 30: warning: exported function NewVirtctlCommand should have comment or be unexported (golint)
  • Line 113: warning: exported function Execute should have comment or be unexported (golint)

• kubevirt/pkg/virt-launcher/virtwrap/generated_mock_manager.go
  • Line 16: warning: comment on exported type MockDomainManager should be of the form "MockDomainManager ..." (with optional leading article) (golint)
  • Line 27: warning: exported function NewMockDomainManager should have comment or be unexported (golint)
  • Line 33: warning: exported method MockDomainManager.EXPECT should have comment or be unexported (golint)
  • Line 37: warning: exported method MockDomainManager.SyncVMI should have comment or be unexported (golint)
  • Line 48: warning: exported method MockDomainManager.PauseVMI should have comment or be unexported (golint)
  • Line 58: warning: exported method MockDomainManager.UnpauseVMI should have comment or be unexported (golint)
  • Line 68: warning: exported method MockDomainManager.FreezeVMI should have comment or be unexported (golint)
  • Line 78: warning: exported method MockDomainManager.UnfreezeVMI should have comment or be unexported (golint)
  • Line 88: warning: exported method MockDomainManager.KillVMI should have comment or be unexported (golint)
  • Line 98: warning: exported method MockDomainManager.DeleteVMI should have comment or be unexported (golint)
  • Line 108: warning: exported method MockDomainManager.SignalShutdownVMI should have comment or be unexported (golint)
  • Line 118: warning: exported method MockDomainManager.MarkGracefulShutdownVMI should have comment or be unexported (golint)
  • Line 128: warning: exported method MockDomainManager.ListAllDomains should have comment or be unexported (golint)
  • Line 139: warning: exported method MockDomainManager.MigrateVMI should have comment or be unexported (golint)
  • Line 149: warning: exported method MockDomainManager.PrepareMigrationTarget should have comment or be unexported (golint)
  • Line 159: warning: exported method MockDomainManager.GetDomainStats should have comment or be unexported (golint)
  • Line 170: warning: exported method MockDomainManager.CancelVMIMigration should have comment or be unexported (golint)
  • Line 180: warning: exported method MockDomainManager.GetGuestInfo should have comment or be unexported (golint)
  • Line 191: warning: exported method MockDomainManager.GetUsers should have comment or be unexported (golint)
  • Line 202: warning: exported method MockDomainManager.GetFilesystems should have comment or be unexported (golint)
  • Line 213: warning: exported method MockDomainManager.FinalizeVirtualMachineMigration should have comment or be unexported (golint)
  • Line 223: warning: exported method MockDomainManager.InterfacesStatus should have comment or be unexported (golint)
  • Line 233: warning: exported method MockDomainManager.GetGuestOSInfo should have comment or be unexported (golint)
  • Line 243: warning: exported method MockDomainManager.Exec should have comment or be unexported (golint)
  • Line 254: warning: exported method MockDomainManager.GuestPing should have comment or be unexported (golint)

• kubevirt/tests/framework/matcher/getter.go
  • Line 75: warning: comment on exported function AllVMIs should be of the form "AllVMIs ..." (golint)

• kubevirt/tests/pod_servers.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)
  • Line 18: warning: exported function NewHTTPServerPod should have comment or be unexported (golint)
  • Line 23: warning: exported function NewTCPServerPod should have comment or be unexported (golint)
  • Line 28: warning: exported function CreatePodAndWaitUntil should have comment or be unexported (golint)
  • Line 44: warning: exported function StartTCPServerPod should have comment or be unexported (golint)
  • Line 49: warning: exported function StartHTTPServerPod should have comment or be unexported (golint)

• kubevirt/pkg/virt-api/webhooks/utils.go
  • Line 38: warning: exported var Arch should have comment or be unexported (golint)
  • Line 40: warning: exported var Validator should have comment or be unexported (golint)
  • Line 42: warning: exported var VirtualMachineInstanceGroupVersionResource should have comment or be unexported (golint)
  • Line 48: warning: exported var VirtualMachineGroupVersionResource should have comment or be unexported (golint)
  • Line 54: warning: exported var VirtualMachineInstancePresetGroupVersionResource should have comment or be unexported (golint)
  • Line 60: warning: exported var VirtualMachineInstanceReplicaSetGroupVersionResource should have comment or be unexported (golint)
  • Line 66: warning: exported var MigrationGroupVersionResource should have comment or be unexported (golint)
  • Line 72: warning: exported var KubeVirtGroupVersionResource should have comment or be unexported (golint)
  • Line 78: warning: exported type Informers should have comment or be unexported (golint)
  • Line 88: warning: exported function IsKubeVirtServiceAccount should have comment or be unexported (golint)
  • Line 103: warning: exported function IsARM64 should have comment or be unexported (golint)
  • Line 110: warning: exported function IsPPC64 should have comment or be unexported (golint)

• kubevirt/pkg/virt-controller/watch/topology/tsc.go
  • Line 14: warning: exported function LowestTSCFrequency should have comment or be unexported (golint)
  • Line 28: warning: exported function TSCFrequencyFromNode should have comment or be unexported (golint)
  • Line 44: warning: exported function TSCFrequencyFromPod should have comment or be unexported (golint)
  • Line 59: warning: exported function TSCFrequenciesOnNode should have comment or be unexported (golint)
  • Line 73: warning: exported function CalculateTSCLabelDiff should have comment or be unexported (golint)
  • Line 99: warning: exported function ToTSCSchedulableLabels should have comment or be unexported (golint)
  • Line 106: warning: exported function ToTSCSchedulableLabel should have comment or be unexported (golint)
  • Line 110: warning: exported function VMIHasInvTSCFeature should have comment or be unexported (golint)

• kubevirt/pkg/util/net/dns/sanitize.go
  • Line 30: warning: comment on exported function SanitizeHostname should be of the form "SanitizeHostname ..." (golint)

• kubevirt/pkg/util/webhooks/ca-manager.go
  • Line 37: warning: exported type ClientCAManager should have comment or be unexported (golint)
  • Line 52: warning: exported function NewKubernetesClientCAManager should have comment or be unexported (golint)
  • Line 63: warning: exported function NewCAManager should have comment or be unexported (golint)

• kubevirt/pkg/virt-operator/resource/generate/rbac/handler.go
  • Line 31: warning: exported const HandlerServiceAccountName should have comment or be unexported (golint)
  • Line 33: warning: exported function GetAllHandler should have comment or be unexported (golint)

• kubevirt/tests/libnet/cloudinit.go
  • Line 28: warning: exported type NetworkDataOption should have comment or be unexported (golint)
  • Line 29: warning: exported type NetworkDataInterfaceOption should have comment or be unexported (golint)
  • Line 31: warning: exported function NewNetworkData should have comment or be unexported (golint)
  • Line 51: warning: exported function WithEthernet should have comment or be unexported (golint)
  • Line 71: warning: exported function WithAddresses should have comment or be unexported (golint)
  • Line 81: warning: exported function WithDHCP4Enabled should have comment or be unexported (golint)
  • Line 89: warning: exported function WithAcceptRA should have comment or be unexported (golint)
  • Line 97: warning: exported function WithDHCP6Enabled should have comment or be unexported (golint)
  • Line 105: warning: exported function WithGateway6 should have comment or be unexported (golint)
  • Line 112: warning: exported function WithNameserverFromCluster should have comment or be unexported (golint)
  • Line 126: warning: exported function WithMatchingMAC should have comment or be unexported (golint)
  • Line 136: warning: exported type CloudInitNetworkData should have comment or be unexported (golint)
  • Line 141: warning: exported type CloudInitInterface should have comment or be unexported (golint)
  • Line 158: warning: exported type CloudInitNameservers should have comment or be unexported (golint)
  • Line 163: warning: exported type CloudInitMatch should have comment or be unexported (golint)
  • Line 169: warning: exported type CloudInitRoute should have comment or be unexported (golint)
  • Line 181: warning: exported const DefaultIPv6Address should have comment (or a comment on this block) or be unexported (golint)

• kubevirt/pkg/handler-launcher-com/cmd/v1/version.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 21: warning: exported const CmdVersion should have comment or be unexported (golint)

• kubevirt/cmd/virt-chroot/mdev-handler.go
  • Line 68: warning: exported function NewCreateMDEVCommand should have comment or be unexported (golint)
  • Line 81: warning: exported function NewRemoveMDEVCommand should have comment or be unexported (golint)

• kubevirt/pkg/virtctl/guestfs/guestfs.go
  • Line 121: warning: comment on exported function SetImageSetFunc should be of the form "SetImageSetFunc ..." (golint)

• kubevirt/tools/perfscale-load-generator/object/namespace.go
  • Line 35: warning: exported function CreateNamespace should have comment or be unexported (golint)

• kubevirt/tests/storage/framework.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 26: warning: exported function SIGDescribe should have comment or be unexported (golint)
  • Line 30: warning: exported function FSIGDescribe should have comment or be unexported (golint)

• kubevirt/pkg/monitoring/domainstats/downwardmetrics/hostmetrics.go
  • Line 34: warning: don't use underscores in Go names; var clk_tck should be clkTck (golint)

• kubevirt/pkg/virt-handler/hotplug-disk/findmnt_test.go
  • Line 20: warning: don't use an underscore in package name (golint)

• kubevirt/pkg/virt-launcher/virtwrap/device/hostdevice/gpu/hostdev.go
  • Line 31: warning: exported const AliasPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function CreateHostDevices should have comment or be unexported (golint)
  • Line 38: warning: exported function CreateHostDevicesFromPools should have comment or be unexported (golint)

• kubevirt/tests/network/vmi_multus.go
  • Line 34: warning: should not use dot imports (golint)
  • Line 36: warning: should not use dot imports (golint)
  • Line 500: warning: don't use underscores in Go names; var is_present should be isPresent (golint)

• kubevirt/pkg/downwardmetrics/vhostmd/metrics/metrics.go
  • Line 9: warning: exported function MustToUnitlessHostMetric should have comment or be unexported (golint)
  • Line 13: warning: exported function MustToHostMetric should have comment or be unexported (golint)
  • Line 17: warning: exported function MustToVMMetric should have comment or be unexported (golint)
  • Line 21: warning: exported function MustToMetric should have comment or be unexported (golint)
  • Line 29: warning: exported function ToMetric should have comment or be unexported (golint)

• kubevirt/pkg/virt-handler/device-manager/mediated_device.go
  • Line 20: warning: don't use an underscore in package name (golint)
  • Line 41: warning: exported const MDEV_RESOURCE_PREFIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type MDEV should have comment or be unexported (golint)
  • Line 55: warning: exported type MediatedDevicePlugin should have comment or be unexported (golint)
  • Line 73: warning: exported function NewMediatedDevicePlugin should have comment or be unexported (golint)
  • Line 167: warning: exported method MediatedDevicePlugin.GetDevicePath should have comment or be unexported (golint)
  • Line 171: warning: exported method MediatedDevicePlugin.GetDeviceName should have comment or be unexported (golint)
  • Line 175: warning: exported method MediatedDevicePlugin.Allocate should have comment or be unexported (golint)
  • Line 247: warning: exported method MediatedDevicePlugin.ListAndWatch should have comment or be unexported (golint)
  • Line 288: warning: exported method MediatedDevicePlugin.GetDevicePluginOptions should have comment or be unexported (golint)
  • Line 295: warning: exported method MediatedDevicePlugin.PreStartContainer should have comment or be unexported (golint)
  • Line 435: warning: exported method MediatedDevicePlugin.GetInitialized should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!