Preparing report...

Report for github.com/lamg/pmproxy

A    Great!    Found 18 issues across 45 files

Tweet

gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint71%

Golint is a linter for Go source code.

    • pmproxy/reset.go
    • Line 28: warning: exported method PMClient.ResetConsumption should have comment or be unexported (golint)
    • pmproxy/serve.go
    • Line 165: warning: exported function StdIface should have comment or be unexported (golint)
    • Line 202: warning: exported const ApiCmd should have comment (or a comment on this block) or be unexported (golint)
    • pmproxy/session.go
    • Line 36: warning: exported method PMClient.Login should have comment or be unexported (golint)
    • Line 170: warning: exported method PMClient.Logout should have comment or be unexported (golint)
    • Line 203: warning: exported method PMClient.LoggedUsers should have comment or be unexported (golint)
    • pmproxy/managers/conf.go
    • Line 39: warning: exported function ConfPath should have comment or be unexported (golint)
    • Line 46: warning: exported function Load should have comment or be unexported (golint)
    • pmproxy/managers/dialer.go
    • Line 31: warning: exported type Dialer should have comment or be unexported (golint)
    • Line 38: warning: exported method Dialer.DialContext should have comment or be unexported (golint)
    • Line 94: warning: exported function NetDialerF should have comment or be unexported (golint)
    • Line 102: warning: exported function MockDialerF should have comment or be unexported (golint)
    • pmproxy/common.go
    • Line 39: warning: exported type PMClient should have comment or be unexported (golint)
    • Line 107: warning: exported function PostCmd should have comment or be unexported (golint)
    • pmproxy/show.go
    • Line 29: warning: exported method PMClient.ShowMng should have comment or be unexported (golint)
    • pmproxy/managers/cmd.go
    • Line 30: warning: exported type Cmd should have comment or be unexported (golint)
    • Line 52: warning: exported type UserInfo should have comment or be unexported (golint)
    • Line 63: warning: exported type Credentials should have comment or be unexported (golint)
    • Line 68: warning: exported type MatchType should have comment or be unexported (golint)
    • Line 73: warning: exported type DiscoverRes should have comment or be unexported (golint)
    • Line 78: warning: exported type CmdF should have comment or be unexported (golint)
    • Line 81: warning: exported const Open should have comment (or a comment on this block) or be unexported (golint)
    • Line 122: warning: exported type StringErr should have comment or be unexported (golint)
    • Line 131: warning: exported method StringErr.Is should have comment or be unexported (golint)
    • Line 136: warning: exported type CheckErr should have comment or be unexported (golint)
    • Line 147: warning: exported type ManagerErr should have comment or be unexported (golint)
    • Line 158: warning: exported type NoConnErr should have comment or be unexported (golint)
    • Line 167: warning: exported type NoUser should have comment or be unexported (golint)
    • Line 177: warning: exported type NoAdmErr should have comment or be unexported (golint)
    • Line 186: warning: exported type QuotaReachedErr should have comment or be unexported (golint)
    • Line 195: warning: exported type ForbiddenByRulesErr should have comment or be unexported (golint)
    • Line 204: warning: exported type DependencyErr should have comment or be unexported (golint)

license0%

Checks whether your project has a LICENSE file.


ineffassign93%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!