Report for github.com/laszlocph/drone-oss-08
(v0.14.3)
A+ Excellent! Found 85 issues across 371 files
gofmt98%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
remote/coding/coding_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
cncd/pipeline/pipeline/frontend/yaml/compiler/convert.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
server/configFetcher.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
server/procBuilder_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint78%
Golint is a linter for Go source code.
-
-
server/procStatus.go
- Line 24: warning: exported type UpdateProcStore should have comment or be unexported (golint)
- Line 28: warning: exported function UpdateProcStatus should have comment or be unexported (golint)
- Line 51: warning: exported function UpdateProcToStatusStarted should have comment or be unexported (golint)
- Line 57: warning: exported function UpdateProcToStatusSkipped should have comment or be unexported (golint)
- Line 66: warning: exported function UpdateProcStatusToDone should have comment or be unexported (golint)
- Line 81: warning: exported function UpdateProcToStatusKilled should have comment or be unexported (golint)
-
-
remote/gogs/fixtures/hooks.go
- Line 17: warning: comment on exported var HookPush should be of the form "HookPush ..." (golint)
- Line 67: warning: comment on exported var HookPushTag should be of the form "HookPushTag ..." (golint)
-
-
remote/coding/internal/file.go
- Line 22: warning: exported type Commit should have comment or be unexported (golint)
- Line 26: warning: exported type File should have comment or be unexported (golint)
- Line 30: warning: exported method Client.GetFile should have comment or be unexported (golint)
-
-
remote/coding/internal/user.go
- Line 21: warning: exported type User should have comment or be unexported (golint)
- Line 27: warning: exported method Client.GetCurrentUser should have comment or be unexported (golint)
-
-
remote/gitlab3/client/drone.go
- Line 21: warning: exported method Client.AddDroneService should have comment or be unexported (golint)
- Line 32: warning: exported method Client.DeleteDroneService should have comment or be unexported (golint)
-
-
model/build.go
- Line 17: warning: comment on exported type Build should be of the form "Build ..." (with optional leading article) (golint)
-
-
remote/gitlab3/gitlab.go
- Line 35: warning: exported const DefaultScope should have comment or be unexported (golint)
- Line 71: warning: exported type Gitlab should have comment or be unexported (golint)
- Line 84: warning: exported function Load should have comment or be unexported (golint)
- Line 85: warning: don't use underscores in Go names; var url_ should be url (golint)
- Line 127: warning: don't use underscores in Go names; var trans_ should be trans (golint)
- Line 149: warning: don't use underscores in Go names; var token_ should be token (golint)
- Line 196: warning: exported method Gitlab.Auth should have comment or be unexported (golint)
- Line 205: warning: exported method Gitlab.Teams should have comment or be unexported (golint)
- Line 227: warning: don't use underscores in Go names; var repo_ should be repo (golint)
- Line 270: warning: don't use underscores in Go names; range var repo_ should be repo (golint)
- Line 341: warning: exported method Gitlab.Dir should have comment or be unexported (golint)
- Line 341: warning: receiver name c should be consistent with previous receiver name g for Gitlab (golint)
- Line 345: warning: comment on exported method Gitlab.Status should be of the form "Status ..." (golint)
- Line 424: warning: don't use underscores in Go names; var ssl_verify should be sslVerify (golint)
- Line 445: warning: comment on exported method Gitlab.Hook should be of the form "Hook ..." (golint)
- Line 625: warning: comment on exported method Gitlab.Oauth2Transport should be of the form "Oauth2Transport ..." (golint)
- Line 645: warning: exported const StatusPending should have comment (or a comment on this block) or be unexported (golint)
- Line 653: warning: exported const DescPending should have comment (or a comment on this block) or be unexported (golint)
-
-
remote/coding/coding.go
- Line 70: warning: exported type Coding should have comment or be unexported (golint)
- Line 241: warning: exported method Coding.Dir should have comment or be unexported (golint)
-
-
model/cc.go
- Line 23: warning: exported type CCProjects should have comment or be unexported (golint)
- Line 28: warning: exported type CCProject should have comment or be unexported (golint)
- Line 38: warning: exported function NewCC should have comment or be unexported (golint)
-
-
remote/coding/internal/coding.go
- Line 26: warning: exported type Client should have comment or be unexported (golint)
- Line 34: warning: exported type GenericAPIResponse should have comment or be unexported (golint)
- Line 39: warning: exported function NewClient should have comment or be unexported (golint)
- Line 49: warning: comment on exported method Client.Get should be of the form "Get ..." (golint)
- Line 54: warning: comment on exported method Client.Do should be of the form "Do ..." (golint)
-
-
remote/gitlab/client/groups.go
- Line 26: warning: comment on exported method Client.AllGroups should be of the form "AllGroups ..." (golint)
- Line 53: warning: exported method Client.Groups should have comment or be unexported (golint)
-
-
remote/gitlab/client/types.go
- Line 17: warning: exported type QMap should have comment or be unexported (golint)
- Line 19: warning: exported type User should have comment or be unexported (golint)
- Line 27: warning: exported type ProjectAccess should have comment or be unexported (golint)
- Line 32: warning: exported type GroupAccess should have comment or be unexported (golint)
- Line 37: warning: exported type Permissions should have comment or be unexported (golint)
- Line 42: warning: exported type Member should have comment or be unexported (golint)
- Line 52: warning: exported type Project should have comment or be unexported (golint)
- Line 69: warning: exported type Namespace should have comment or be unexported (golint)
- Line 75: warning: exported type Person should have comment or be unexported (golint)
- Line 112: warning: exported type HookObjAttr should have comment or be unexported (golint)
- Line 139: warning: exported type HookPayload should have comment or be unexported (golint)
- Line 154: warning: exported type FileRef should have comment or be unexported (golint)
-
-
remote/gitlab3/client/project.go
- Line 32: warning: comment on exported method Client.AllProjects should be of the form "AllProjects ..." (golint)
- Line 33: warning: don't use underscores in Go names; method parameter hide_archives should be hideArchives (golint)
- Line 34: warning: don't use underscores in Go names; var per_page should be perPage (golint)
- Line 59: warning: comment on exported method Client.Projects should be of the form "Projects ..." (golint)
- Line 60: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 60: warning: don't use underscores in Go names; method parameter per_page should be perPage (golint)
- Line 60: warning: don't use underscores in Go names; method parameter hide_archives should be hideArchives (golint)
- Line 82: warning: comment on exported method Client.Project should be of the form "Project ..." (golint)
- Line 83: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 96: warning: comment on exported method Client.RepoRawFile should be of the form "RepoRawFile ..." (golint)
- Line 97: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 114: warning: exported method Client.RepoRawFileRef should have comment or be unexported (golint)
- Line 114: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 131: warning: comment on exported method Client.SetStatus should be of the form "SetStatus ..." (golint)
- Line 132: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 152: warning: comment on exported method Client.SearchProjectId should be of the form "SearchProjectId ..." (golint)
- Line 153: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
-
-
store/datastore/init_cgo.go
- Line 21: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
-
-
server/procBuilder.go
- Line 176: warning: don't use underscores in Go names; method envsubst_ should be envsubst (golint)
-
-
cmd/drone-server/setup.go
- Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 77: warning: comment on exported function SetupRemote should be of the form "SetupRemote ..." (golint)
- Line 221: warning: don't use underscores in Go names; func parameter store_ should be store (golint)
-
-
model/sender.go
- Line 17: warning: exported type SenderService should have comment or be unexported (golint)
- Line 25: warning: exported type SenderStore should have comment or be unexported (golint)
- Line 33: warning: exported type Sender should have comment or be unexported (golint)
-
-
server/rpc.go
- Line 49: warning: exported var Config should have comment or be unexported (golint)
- Line 94: warning: exported type RPC should have comment or be unexported (golint)
- Line 131: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 530: warning: exported function NewDroneServer should have comment or be unexported (golint)
- Line 554: warning: exported method DroneServer.Next should have comment or be unexported (golint)
- Line 577: warning: exported method DroneServer.Init should have comment or be unexported (golint)
- Line 591: warning: exported method DroneServer.Update should have comment or be unexported (golint)
- Line 605: warning: exported method DroneServer.Upload should have comment or be unexported (golint)
- Line 621: warning: exported method DroneServer.Done should have comment or be unexported (golint)
- Line 635: warning: exported method DroneServer.Wait should have comment or be unexported (golint)
- Line 641: warning: exported method DroneServer.Extend should have comment or be unexported (golint)
- Line 647: warning: exported method DroneServer.Log should have comment or be unexported (golint)
-
-
cncd/pipeline/pipeline/frontend/metadata.go
- Line 238: warning: exported method Metadata.SetPlatform should have comment or be unexported (golint)
-
-
remote/coding/internal/error.go
- Line 21: warning: exported type APIClientErr should have comment or be unexported (golint)
-
-
remote/coding/internal/project.go
- Line 23: warning: exported type Project should have comment or be unexported (golint)
- Line 33: warning: exported type Depot should have comment or be unexported (golint)
- Line 37: warning: exported type ProjectListData should have comment or be unexported (golint)
- Line 45: warning: exported method Client.GetProject should have comment or be unexported (golint)
- Line 60: warning: exported method Client.GetDepot should have comment or be unexported (golint)
- Line 75: warning: exported method Client.GetProjectList should have comment or be unexported (golint)
-
-
remote/coding/hook.go
- Line 35: warning: exported type User should have comment or be unexported (golint)
- Line 40: warning: exported type Repository should have comment or be unexported (golint)
- Line 48: warning: exported type Committer should have comment or be unexported (golint)
- Line 53: warning: exported type Commit should have comment or be unexported (golint)
- Line 59: warning: exported type PullRequest should have comment or be unexported (golint)
- Line 61: warning: exported type MergeRequest should have comment or be unexported (golint)
- Line 74: warning: exported type PushHook should have comment or be unexported (golint)
- Line 84: warning: exported type PullRequestHook should have comment or be unexported (golint)
- Line 90: warning: exported type MergeRequestHook should have comment or be unexported (golint)
-
-
remote/gitlab/gitlab.go
- Line 35: warning: exported const DefaultScope should have comment or be unexported (golint)
- Line 71: warning: exported type Gitlab should have comment or be unexported (golint)
- Line 84: warning: exported function Load should have comment or be unexported (golint)
- Line 85: warning: don't use underscores in Go names; var url_ should be url (golint)
- Line 127: warning: don't use underscores in Go names; var trans_ should be trans (golint)
- Line 149: warning: don't use underscores in Go names; var token_ should be token (golint)
- Line 196: warning: exported method Gitlab.Auth should have comment or be unexported (golint)
- Line 205: warning: exported method Gitlab.Teams should have comment or be unexported (golint)
- Line 227: warning: don't use underscores in Go names; var repo_ should be repo (golint)
- Line 270: warning: don't use underscores in Go names; range var repo_ should be repo (golint)
- Line 341: warning: exported method Gitlab.Dir should have comment or be unexported (golint)
- Line 341: warning: receiver name c should be consistent with previous receiver name g for Gitlab (golint)
- Line 345: warning: comment on exported method Gitlab.Status should be of the form "Status ..." (golint)
- Line 424: warning: don't use underscores in Go names; var ssl_verify should be sslVerify (golint)
- Line 445: warning: comment on exported method Gitlab.Hook should be of the form "Hook ..." (golint)
- Line 625: warning: comment on exported method Gitlab.Oauth2Transport should be of the form "Oauth2Transport ..." (golint)
- Line 645: warning: exported const StatusPending should have comment (or a comment on this block) or be unexported (golint)
- Line 653: warning: exported const DescPending should have comment (or a comment on this block) or be unexported (golint)
-
-
remote/gitea/gitea_oauth.go
- Line 54: warning: comment on exported function NewOauth should be of the form "NewOauth ..." (golint)
-
-
remote/gitlab/client/gitlab.go
- Line 27: warning: exported type Client should have comment or be unexported (golint)
- Line 34: warning: exported function New should have comment or be unexported (golint)
- Line 50: warning: exported method Client.ResourceUrl should have comment or be unexported (golint)
- Line 57: warning: don't use underscores in Go names; var query_params should be queryParams (golint)
- Line 75: warning: exported method Client.Do should have comment or be unexported (golint)
-
-
remote/gitlab3/client/gitlab.go
- Line 27: warning: exported type Client should have comment or be unexported (golint)
- Line 34: warning: exported function New should have comment or be unexported (golint)
- Line 50: warning: exported method Client.ResourceUrl should have comment or be unexported (golint)
- Line 57: warning: don't use underscores in Go names; var query_params should be queryParams (golint)
- Line 75: warning: exported method Client.Do should have comment or be unexported (golint)
-
-
remote/remote.go
- Line 27: warning: exported type Remote should have comment or be unexported (golint)
- Line 82: warning: exported type ByName should have comment or be unexported (golint)
-
-
server/login.go
- Line 33: warning: exported function HandleLogin should have comment or be unexported (golint)
- Line 50: warning: exported function HandleAuth should have comment or be unexported (golint)
- Line 153: warning: exported function GetLogout should have comment or be unexported (golint)
- Line 159: warning: exported function GetLoginToken should have comment or be unexported (golint)
-
-
model/cc_test.go
- Line 31: warning: don't use underscores in Go names; var now_fmt should be nowFmt (golint)
-
-
shared/oauth2/oauth2.go
- Line 5: warning: package comment should be of the form "Package oauth2 ..." (golint)
- Line 77: warning: exported method CacheFile.Token should have comment or be unexported (golint)
- Line 90: warning: exported method CacheFile.PutToken should have comment or be unexported (golint)
- Line 217: warning: don't use underscores in Go names; var url_ should be url (golint)
-
-
server/sync.go
- Line 41: warning: comment on exported function NamespaceFilter should be of the form "NamespaceFilter ..." (golint)
- Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
remote/bitbucket/fixtures/hooks.go
- Line 17: warning: exported const HookPush should have comment or be unexported (golint)
- Line 68: warning: exported const HookPushEmptyHash should have comment or be unexported (golint)
- Line 83: warning: exported const HookPull should have comment or be unexported (golint)
- Line 173: warning: exported const HookMerged should have comment or be unexported (golint)
-
-
model/registry.go
- Line 34: warning: comment on exported type ReadOnlyRegistryService should be of the form "ReadOnlyRegistryService ..." (with optional leading article) (golint)
-
-
plugins/registry/combine.go
- Line 12: warning: exported function Combined should have comment or be unexported (golint)
-
-
remote/bitbucketserver/internal/client.go
- Line 47: warning: exported type Client should have comment or be unexported (golint)
- Line 53: warning: exported function NewClientWithToken should have comment or be unexported (golint)
- Line 63: warning: exported method Client.FindCurrentUser should have comment or be unexported (golint)
- Line 101: warning: exported method Client.FindRepo should have comment or be unexported (golint)
- Line 119: warning: exported method Client.FindRepos should have comment or be unexported (golint)
- Line 123: warning: exported method Client.FindRepoPerms should have comment or be unexported (golint)
- Line 143: warning: exported method Client.FindFileForRepo should have comment or be unexported (golint)
- Line 161: warning: exported method Client.CreateHook should have comment or be unexported (golint)
- Line 184: warning: exported method Client.CreateStatus should have comment or be unexported (golint)
- Line 189: warning: exported method Client.DeleteHook should have comment or be unexported (golint)
- Line 204: warning: exported method Client.GetHookDetails should have comment or be unexported (golint)
- Line 219: warning: exported method Client.GetHooks should have comment or be unexported (golint)
-
-
remote/gitlab3/client/types.go
- Line 17: warning: exported type QMap should have comment or be unexported (golint)
- Line 19: warning: exported type User should have comment or be unexported (golint)
- Line 27: warning: exported type ProjectAccess should have comment or be unexported (golint)
- Line 32: warning: exported type GroupAccess should have comment or be unexported (golint)
- Line 37: warning: exported type Permissions should have comment or be unexported (golint)
- Line 42: warning: exported type Member should have comment or be unexported (golint)
- Line 52: warning: exported type Project should have comment or be unexported (golint)
- Line 69: warning: exported type Namespace should have comment or be unexported (golint)
- Line 75: warning: exported type Person should have comment or be unexported (golint)
- Line 112: warning: exported type HookObjAttr should have comment or be unexported (golint)
- Line 139: warning: exported type HookPayload should have comment or be unexported (golint)
-
-
remote/gitlab3/helper.go
- Line 103: warning: exported function GetUserAvatar should have comment or be unexported (golint)
- Line 115: warning: exported function ExtractFromPath should have comment or be unexported (golint)
- Line 123: warning: exported function GetUserEmail should have comment or be unexported (golint)
- Line 127: warning: exported function GetProjectId should have comment or be unexported (golint)
- Line 135: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
web/web.go
- Line 13: warning: exported function HttpFS should have comment or be unexported (golint)
- Line 22: warning: exported function Lookup should have comment or be unexported (golint)
- Line 37: warning: exported function MustLookup should have comment or be unexported (golint)
-
-
server/badge.go
- Line 38: warning: exported function GetBadge should have comment or be unexported (golint)
- Line 81: warning: exported function GetCC should have comment or be unexported (golint)
-
-
model/netrc.go
- Line 17: warning: exported type Netrc should have comment or be unexported (golint)
-
-
server/stream.go
- Line 39: warning: exported function EventStreamSSE should have comment or be unexported (golint)
- Line 118: warning: exported function LogStreamSSE should have comment or be unexported (golint)
-
-
remote/bitbucket/internal/types.go
- Line 23: warning: exported type Account should have comment or be unexported (golint)
- Line 30: warning: exported type AccountResp should have comment or be unexported (golint)
- Line 38: warning: exported type BuildStatus should have comment or be unexported (golint)
- Line 46: warning: exported type Email should have comment or be unexported (golint)
- Line 52: warning: exported type EmailResp should have comment or be unexported (golint)
- Line 60: warning: exported type Hook should have comment or be unexported (golint)
- Line 68: warning: exported type HookResp should have comment or be unexported (golint)
- Line 76: warning: exported type Links should have comment or be unexported (golint)
- Line 82: warning: exported type Link should have comment or be unexported (golint)
- Line 87: warning: exported type LinkClone should have comment or be unexported (golint)
- Line 91: warning: exported type Repo should have comment or be unexported (golint)
- Line 102: warning: exported type RepoResp should have comment or be unexported (golint)
- Line 110: warning: exported type Change should have comment or be unexported (golint)
- Line 128: warning: exported type PushHook should have comment or be unexported (golint)
- Line 136: warning: exported type PullRequestHook should have comment or be unexported (golint)
- Line 174: warning: exported type ListOpts should have comment or be unexported (golint)
- Line 179: warning: exported method ListOpts.Encode should have comment or be unexported (golint)
- Line 190: warning: exported type ListTeamOpts should have comment or be unexported (golint)
- Line 196: warning: exported method ListTeamOpts.Encode should have comment or be unexported (golint)
- Line 210: warning: exported type Error should have comment or be unexported (golint)
- Line 221: warning: exported type RepoPermResp should have comment or be unexported (golint)
- Line 227: warning: exported type RepoPerm should have comment or be unexported (golint)
-
-
remote/coding/fixtures/hooks.go
- Line 17: warning: exported const PushHook should have comment or be unexported (golint)
- Line 59: warning: exported const DeleteBranchPushHook should have comment or be unexported (golint)
- Line 90: warning: exported const PullRequestHook should have comment or be unexported (golint)
- Line 149: warning: exported const MergeRequestHook should have comment or be unexported (golint)
-
-
remote/bitbucketserver/internal/types.go
- Line 17: warning: exported type User should have comment or be unexported (golint)
- Line 32: warning: exported type CloneLink should have comment or be unexported (golint)
- Line 37: warning: exported type SelfRefLink should have comment or be unexported (golint)
- Line 41: warning: exported type BuildStatus should have comment or be unexported (golint)
- Line 49: warning: exported type Repo should have comment or be unexported (golint)
- Line 77: warning: exported type Repos should have comment or be unexported (golint)
- Line 85: warning: exported type Hook should have comment or be unexported (golint)
- Line 90: warning: exported type HookDetail should have comment or be unexported (golint)
- Line 99: warning: exported type Value should have comment or be unexported (golint)
- Line 150: warning: exported type PostHook should have comment or be unexported (golint)
- Line 180: warning: exported type RefChange should have comment or be unexported (golint)
- Line 187: warning: exported type HookPluginDetails should have comment or be unexported (golint)
- Line 200: warning: exported type HookSettings should have comment or be unexported (golint)
-
-
remote/coding/internal/webhook.go
- Line 23: warning: exported type Webhook should have comment or be unexported (golint)
- Line 28: warning: exported method Client.GetWebhooks should have comment or be unexported (golint)
- Line 42: warning: exported method Client.AddWebhook should have comment or be unexported (golint)
- Line 75: warning: exported method Client.RemoveWebhook should have comment or be unexported (golint)
-
-
router/middleware/token/token.go
- Line 28: warning: exported function Refresh should have comment or be unexported (golint)
- Line 37: warning: don't use underscores in Go names; var remote_ should be remote (golint)
-
-
remote/gitlab/helper.go
- Line 103: warning: exported function GetUserAvatar should have comment or be unexported (golint)
- Line 115: warning: exported function ExtractFromPath should have comment or be unexported (golint)
- Line 123: warning: exported function GetUserEmail should have comment or be unexported (golint)
- Line 127: warning: exported function GetProjectId should have comment or be unexported (golint)
- Line 135: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
router/middleware/session/repo.go
- Line 29: warning: exported function Repo should have comment or be unexported (golint)
- Line 41: warning: exported function Repos should have comment or be unexported (golint)
- Line 53: warning: exported function SetRepo should have comment or be unexported (golint)
- Line 83: warning: exported function Perm should have comment or be unexported (golint)
- Line 95: warning: exported function SetPerm should have comment or be unexported (golint)
- Line 152: warning: exported function MustPull should have comment or be unexported (golint)
- Line 175: warning: exported function MustPush should have comment or be unexported (golint)
-
-
cncd/queue/fifo.go
- Line 15: warning: exported const StatusSkipped should have comment (or a comment on this block) or be unexported (golint)
-
-
model/event.go
- Line 21: warning: exported const Enqueued should have comment (or a comment on this block) or be unexported (golint)
-
-
model/repo.go
- Line 22: warning: exported type RepoLite should have comment or be unexported (golint)
- Line 61: warning: exported method Repo.ResetVisibility should have comment or be unexported (golint)
-
-
cncd/queue/fifo_test.go
- Line 293: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 308: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 328: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
store/store.go
- Line 25: warning: exported type Store should have comment or be unexported (golint)
- Line 181: warning: exported function CreateUser should have comment or be unexported (golint)
- Line 185: warning: exported function UpdateUser should have comment or be unexported (golint)
- Line 189: warning: exported function DeleteUser should have comment or be unexported (golint)
- Line 193: warning: exported function GetRepo should have comment or be unexported (golint)
- Line 197: warning: exported function GetRepoName should have comment or be unexported (golint)
- Line 201: warning: exported function GetRepoOwnerName should have comment or be unexported (golint)
- Line 205: warning: exported function CreateRepo should have comment or be unexported (golint)
- Line 209: warning: exported function UpdateRepo should have comment or be unexported (golint)
- Line 213: warning: exported function DeleteRepo should have comment or be unexported (golint)
- Line 217: warning: exported function GetBuild should have comment or be unexported (golint)
- Line 221: warning: exported function GetBuildNumber should have comment or be unexported (golint)
- Line 225: warning: exported function GetBuildRef should have comment or be unexported (golint)
- Line 229: warning: exported function GetBuildCommit should have comment or be unexported (golint)
- Line 233: warning: exported function GetBuildLast should have comment or be unexported (golint)
- Line 237: warning: exported function GetBuildLastBefore should have comment or be unexported (golint)
- Line 241: warning: exported function GetBuildList should have comment or be unexported (golint)
- Line 245: warning: exported function GetBuildQueue should have comment or be unexported (golint)
- Line 249: warning: exported function CreateBuild should have comment or be unexported (golint)
-
-
server/build.go
- Line 41: warning: exported function GetBuilds should have comment or be unexported (golint)
- Line 57: warning: exported function GetBuild should have comment or be unexported (golint)
- Line 83: warning: exported function GetBuildLast should have comment or be unexported (golint)
- Line 98: warning: exported function GetBuildLogs should have comment or be unexported (golint)
- Line 131: warning: exported function GetProcLogs should have comment or be unexported (golint)
- Line 240: warning: exported function PostApproval should have comment or be unexported (golint)
- Line 242: warning: don't use underscores in Go names; var remote_ should be remote (golint)
- Line 348: warning: exported function PostDecline should have comment or be unexported (golint)
- Line 350: warning: don't use underscores in Go names; var remote_ should be remote (golint)
- Line 382: warning: exported function GetBuildQueue should have comment or be unexported (golint)
- Line 393: warning: don't use underscores in Go names; var remote_ should be remote (golint)
- Line 552: warning: exported function DeleteBuildLogs should have comment or be unexported (golint)
-
-
server/repo.go
- Line 34: warning: exported function PostRepo should have comment or be unexported (golint)
- Line 102: warning: exported function PatchRepo should have comment or be unexported (golint)
- Line 166: warning: exported function ChownRepo should have comment or be unexported (golint)
- Line 179: warning: exported function GetRepo should have comment or be unexported (golint)
- Line 183: warning: exported function DeleteRepo should have comment or be unexported (golint)
- Line 210: warning: exported function RepairRepo should have comment or be unexported (golint)
- Line 256: warning: exported function MoveRepo should have comment or be unexported (golint)
-
-
cmd/drone-server/server.go
- Line 78: warning: don't use underscores in Go names; var remote_ should be remote (golint)
- Line 83: warning: don't use underscores in Go names; var store_ should be store (golint)
-
-
shared/token/token.go
- Line 24: warning: exported type SecretFunc should have comment or be unexported (golint)
- Line 27: warning: exported const UserToken should have comment (or a comment on this block) or be unexported (golint)
- Line 34: warning: comment on exported const SignerAlgo should be of the form "SignerAlgo ..." (golint)
- Line 37: warning: exported type Token should have comment or be unexported (golint)
- Line 42: warning: exported function Parse should have comment or be unexported (golint)
- Line 53: warning: exported function ParseRequest should have comment or be unexported (golint)
- Line 80: warning: exported function CheckCsrf should have comment or be unexported (golint)
- Line 95: warning: exported function New should have comment or be unexported (golint)
- Line 105: warning: comment on exported method Token.SignExpires should be of the form "SignExpires ..." (golint)
-
-
plugins/registry/filesystem.go
- Line 18: warning: exported function Filesystem should have comment or be unexported (golint)
-
-
router/middleware/session/user.go
- Line 27: warning: exported function User should have comment or be unexported (golint)
- Line 39: warning: exported function Token should have comment or be unexported (golint)
- Line 51: warning: exported function SetUser should have comment or be unexported (golint)
- Line 86: warning: exported function MustAdmin should have comment or be unexported (golint)
- Line 102: warning: exported function MustRepoAdmin should have comment or be unexported (golint)
- Line 119: warning: exported function MustUser should have comment or be unexported (golint)
-
-
remote/gitlab3/client/user.go
- Line 25: warning: exported method Client.CurrentUser should have comment or be unexported (golint)
-
-
server/users.go
- Line 28: warning: exported function GetUsers should have comment or be unexported (golint)
- Line 37: warning: exported function GetUser should have comment or be unexported (golint)
- Line 46: warning: exported function PatchUser should have comment or be unexported (golint)
- Line 70: warning: exported function PostUser should have comment or be unexported (golint)
- Line 97: warning: exported function DeleteUser should have comment or be unexported (golint)
-
-
remote/gitea/gitea.go
- Line 57: warning: exported const DescPending should have comment (or a comment on this block) or be unexported (golint)
-
-
remote/github/fixtures/hooks.go
- Line 66: warning: comment on exported const HookPushDeleted should be of the form "HookPushDeleted ..." (golint)
- Line 142: warning: comment on exported const HookDeploy should be of the form "HookDeploy ..." (golint)
-
-
remote/bitbucketserver/bitbucketserver.go
- Line 54: warning: exported type Config should have comment or be unexported (golint)
- Line 106: warning: exported method Config.Login should have comment or be unexported (golint)
- Line 149: warning: exported method Config.Repo should have comment or be unexported (golint)
- Line 157: warning: exported method Config.Repos should have comment or be unexported (golint)
- Line 170: warning: exported method Config.Perm should have comment or be unexported (golint)
- Line 176: warning: exported method Config.File should have comment or be unexported (golint)
- Line 182: warning: exported method Config.Dir should have comment or be unexported (golint)
- Line 201: warning: exported method Config.Netrc should have comment or be unexported (golint)
- Line 220: warning: exported method Config.Activate should have comment or be unexported (golint)
- Line 226: warning: exported method Config.Deactivate should have comment or be unexported (golint)
- Line 231: warning: exported method Config.Hook should have comment or be unexported (golint)
- Line 235: warning: exported function CreateConsumer should have comment or be unexported (golint)
-
-
server/swagger/doc.go
- Line 15: warning: package comment should be of the form "Package swagger ..." (golint)
-
-
remote/bitbucket/internal/client.go
- Line 50: warning: exported type Client should have comment or be unexported (golint)
- Line 55: warning: exported function NewClient should have comment or be unexported (golint)
- Line 59: warning: exported function NewClientToken should have comment or be unexported (golint)
- Line 68: warning: exported method Client.FindCurrent should have comment or be unexported (golint)
- Line 75: warning: exported method Client.ListEmail should have comment or be unexported (golint)
- Line 82: warning: exported method Client.ListTeams should have comment or be unexported (golint)
- Line 89: warning: exported method Client.FindRepo should have comment or be unexported (golint)
- Line 96: warning: exported method Client.ListRepos should have comment or be unexported (golint)
- Line 103: warning: exported method Client.ListReposAll should have comment or be unexported (golint)
- Line 121: warning: exported method Client.FindHook should have comment or be unexported (golint)
- Line 128: warning: exported method Client.ListHooks should have comment or be unexported (golint)
- Line 135: warning: exported method Client.CreateHook should have comment or be unexported (golint)
- Line 141: warning: exported method Client.DeleteHook should have comment or be unexported (golint)
- Line 147: warning: exported method Client.FindSource should have comment or be unexported (golint)
- Line 152: warning: exported method Client.CreateStatus should have comment or be unexported (golint)
- Line 158: warning: exported method Client.GetPermission should have comment or be unexported (golint)
- Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
cncd/pipeline/pipeline/frontend/yaml/compiler/compiler.go
- Line 14: warning: exported type Registry should have comment or be unexported (golint)
- Line 22: warning: exported type Secret should have comment or be unexported (golint)
- Line 28: warning: exported type ResourceLimit should have comment or be unexported (golint)
-
-
remote/gitlab/client/drone.go
- Line 21: warning: exported method Client.AddDroneService should have comment or be unexported (golint)
- Line 32: warning: exported method Client.DeleteDroneService should have comment or be unexported (golint)
-
-
server/builsStatus.go
- Line 23: warning: exported type UpdateBuildStore should have comment or be unexported (golint)
- Line 27: warning: exported function UpdateToStatusRunning should have comment or be unexported (golint)
- Line 33: warning: exported function UpdateToStatusPending should have comment or be unexported (golint)
- Line 40: warning: exported function UpdateToStatusDeclined should have comment or be unexported (golint)
- Line 47: warning: exported function UpdateStatusToDone should have comment or be unexported (golint)
- Line 53: warning: exported function UpdateToStatusError should have comment or be unexported (golint)
- Line 61: warning: exported function UpdateToStatusKilled should have comment or be unexported (golint)
-
-
server/hook.go
- Line 52: warning: exported function GetQueueInfo should have comment or be unexported (golint)
- Line 58: warning: exported function PauseQueue should have comment or be unexported (golint)
- Line 63: warning: exported function ResumeQueue should have comment or be unexported (golint)
- Line 68: warning: exported function BlockTilQueueHasRunningItem should have comment or be unexported (golint)
- Line 78: warning: exported function PostHook should have comment or be unexported (golint)
- Line 79: warning: don't use underscores in Go names; var remote_ should be remote (golint)
-
-
cncd/pipeline/pipeline/backend/docker/convert.go
- Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
model/const.go
- Line 18: warning: exported const EventPush should have comment (or a comment on this block) or be unexported (golint)
- Line 25: warning: exported const StatusSkipped should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported const RepoGit should have comment (or a comment on this block) or be unexported (golint)
- Line 44: warning: exported const VisibilityPublic should have comment (or a comment on this block) or be unexported (golint)
-
-
server/configFetcher.go
- Line 12: warning: don't use underscores in Go names; struct field remote_ should be remote (golint)
-
-
plugins/environments/filesystem.go
- Line 12: warning: comment on exported function Filesystem should be of the form "Filesystem ..." (golint)
-
-
remote/gitlab/client/project.go
- Line 31: warning: comment on exported method Client.AllProjects should be of the form "AllProjects ..." (golint)
- Line 32: warning: don't use underscores in Go names; method parameter hide_archives should be hideArchives (golint)
- Line 33: warning: don't use underscores in Go names; var per_page should be perPage (golint)
- Line 58: warning: comment on exported method Client.Projects should be of the form "Projects ..." (golint)
- Line 59: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 59: warning: don't use underscores in Go names; method parameter per_page should be perPage (golint)
- Line 59: warning: don't use underscores in Go names; method parameter hide_archives should be hideArchives (golint)
- Line 82: warning: comment on exported method Client.Project should be of the form "Project ..." (golint)
- Line 83: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 96: warning: exported method Client.RepoRawFileRef should have comment or be unexported (golint)
- Line 96: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 123: warning: comment on exported method Client.SetStatus should be of the form "SetStatus ..." (golint)
- Line 124: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
- Line 144: warning: comment on exported method Client.SearchProjectId should be of the form "SearchProjectId ..." (golint)
- Line 145: warning: receiver name c should be consistent with previous receiver name g for Client (golint)
-
-
remote/gitlab/client/user.go
- Line 25: warning: exported method Client.CurrentUser should have comment or be unexported (golint)
-
-
remote/gitlab3/client/groups.go
- Line 26: warning: comment on exported method Client.AllGroups should be of the form "AllGroups ..." (golint)
- Line 53: warning: exported method Client.Groups should have comment or be unexported (golint)
-
-
server/user.go
- Line 34: warning: exported function GetSelf should have comment or be unexported (golint)
- Line 38: warning: exported function GetFeed should have comment or be unexported (golint)
- Line 81: warning: exported function GetRepos should have comment or be unexported (golint)
- Line 129: warning: exported function PostToken should have comment or be unexported (golint)
- Line 141: warning: exported function DeleteToken should have comment or be unexported (golint)
-
-
cncd/pipeline/pipeline/frontend/yaml/compiler/convert.go
- Line 22: warning: don't use underscores in Go names; var network_mode should be networkMode (golint)
- Line 23: warning: don't use underscores in Go names; var ipc_mode should be ipcMode (golint)
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
cncd/pipeline/pipeline/frontend/yaml/compiler/convert.go
- Line 12: warning: cyclomatic complexity 28 of function (*Compiler).createProcess() is high (> 15) (gocyclo)
-
-
cncd/pipeline/piped/main.go
- Line 125: warning: cyclomatic complexity 27 of function run() is high (> 15) (gocyclo)
-
-
server/build.go
- Line 392: warning: cyclomatic complexity 24 of function PostBuild() is high (> 15) (gocyclo)
- Line 240: warning: cyclomatic complexity 17 of function PostApproval() is high (> 15) (gocyclo)
- Line 164: warning: cyclomatic complexity 17 of function DeleteBuild() is high (> 15) (gocyclo)
-
-
cncd/pipeline/pipeline/pipeline.go
- Line 106: warning: cyclomatic complexity 17 of function (*Runtime).exec() is high (> 15) (gocyclo)
-
-
server/login.go
- Line 50: warning: cyclomatic complexity 16 of function HandleAuth() is high (> 15) (gocyclo)
-
-
server/rpc.go
- Line 338: warning: cyclomatic complexity 16 of function (*RPC).Done() is high (> 15) (gocyclo)
-
-
server/hook.go
- Line 78: warning: cyclomatic complexity 43 of function PostHook() is high (> 15) (gocyclo)
-
-
cmd/drone-agent/agent.go
- Line 166: warning: cyclomatic complexity 25 of function (*runner).run() is high (> 15) (gocyclo)
-
-
cncd/pipeline/pipeline/frontend/yaml/compiler/compiler.go
- Line 68: warning: cyclomatic complexity 24 of function (*Compiler).Compile() is high (> 15) (gocyclo)
-
-
remote/bitbucketserver/internal/client.go
- Line 317: warning: cyclomatic complexity 22 of function arrayToHookSettings() is high (> 15) (gocyclo)
- Line 370: warning: cyclomatic complexity 21 of function hookSettingsToArray() is high (> 15) (gocyclo)
-
-
cli/drone/deploy/deploy.go
- Line 49: warning: cyclomatic complexity 18 of function deploy() is high (> 15) (gocyclo)
-
-
server/repo.go
- Line 102: warning: cyclomatic complexity 18 of function PatchRepo() is high (> 15) (gocyclo)
-
-
server/stream.go
- Line 118: warning: cyclomatic complexity 16 of function LogStreamSSE() is high (> 15) (gocyclo)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!