Preparing report...

Report for github.com/lugu/qiloop

A+    Excellent!    Found 52 issues across 146 files

Tweet

gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • qiloop/bus/directory/directory_test.go
    • Line 342: warning: cyclomatic complexity 22 of function TestStub() is high (> 15) (gocyclo)
    • Line 196: warning: cyclomatic complexity 17 of function TestServiceDirectoryInfo() is high (> 15) (gocyclo)
    • Line 115: warning: cyclomatic complexity 16 of function TestServerDirectory() is high (> 15) (gocyclo)
    • qiloop/type/encoding/encoding.go
    • Line 288: warning: cyclomatic complexity 38 of function (qiDecoder).value() is high (> 15) (gocyclo)
    • Line 56: warning: cyclomatic complexity 29 of function (qiEncoder).value() is high (> 15) (gocyclo)
    • Line 136: warning: cyclomatic complexity 21 of function (qiEncoder).Encode() is high (> 15) (gocyclo)
    • Line 408: warning: cyclomatic complexity 19 of function (qiDecoder).Decode() is high (> 15) (gocyclo)
    • qiloop/bus/object_stub_gen.go
    • Line 1103: warning: cyclomatic complexity 17 of function readMetaObject() is high (> 15) (gocyclo)
    • Line 1174: warning: cyclomatic complexity 17 of function writeMetaObject() is high (> 15) (gocyclo)
    • Line 215: warning: cyclomatic complexity 16 of function (*stubObject).Receive() is high (> 15) (gocyclo)

golint82%

Golint is a linter for Go source code.

    • qiloop/meta/signature/name.go
    • Line 25: warning: exported function ValidName should have comment or be unexported (golint)
    • Line 35: warning: exported function CleanMethodName should have comment or be unexported (golint)
    • Line 45: warning: exported function CleanVarName should have comment or be unexported (golint)
    • qiloop/bus/call.go
    • Line 21: warning: exported method Params.Signature should have comment or be unexported (golint)
    • Line 34: warning: exported type Response should have comment or be unexported (golint)
    • Line 39: warning: exported function NewResponse should have comment or be unexported (golint)
    • qiloop/meta/signature/type.go
    • Line 227: warning: comment on exported function NewUintType should be of the form "NewUintType ..." (golint)
    • Line 439: warning: exported function TypeIsObjectReference should have comment or be unexported (golint)
    • qiloop/type/encoding/gob.go
    • Line 8: warning: exported function NewGobEncoder should have comment or be unexported (golint)
    • Line 12: warning: exported function NewGobDecoder should have comment or be unexported (golint)
    • qiloop/type/encoding/json.go
    • Line 22: warning: exported function NewJSONEncoder should have comment or be unexported (golint)
    • Line 34: warning: exported function NewJSONDecoder should have comment or be unexported (golint)
    • qiloop/bus/net/cert/cert.go
    • Line 18: warning: exported function GenerateCertificate should have comment or be unexported (golint)
    • Line 42: warning: exported function Certificate should have comment or be unexported (golint)
    • qiloop/type/encoding/cap.go
    • Line 3: warning: exported type Capability should have comment or be unexported (golint)
    • Line 18: warning: exported function DefaultCap should have comment or be unexported (golint)
    • qiloop/meta/idl/parser.go
    • Line 617: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • qiloop/type/encoding/encoding.go
    • Line 16: warning: exported type Writer should have comment or be unexported (golint)
    • Line 20: warning: exported type Encoder should have comment or be unexported (golint)
    • Line 24: warning: exported type Decoder should have comment or be unexported (golint)
    • Line 28: warning: exported type CustomEncoder should have comment or be unexported (golint)
    • Line 32: warning: exported type CustomDecoder should have comment or be unexported (golint)
    • Line 36: warning: exported type BinaryEncoder should have comment or be unexported (golint)
    • Line 40: warning: exported type BinaryDecoder should have comment or be unexported (golint)
    • Line 44: warning: exported function NewEncoder should have comment or be unexported (golint)
    • Line 48: warning: exported function NewDecoder should have comment or be unexported (golint)
    • Line 236: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • qiloop/meta/idl/interface.go
    • Line 81: warning: exported method Method.Type should have comment or be unexported (golint)
    • Line 156: warning: receiver name p should be consistent with previous receiver name s for Property (golint)
    • Line 164: warning: receiver name p should be consistent with previous receiver name s for Property (golint)
    • Line 224: warning: receiver name itf should be consistent with previous receiver name s for InterfaceType (golint)
    • Line 317: warning: exported method InterfaceType.Type should have comment or be unexported (golint)
    • qiloop/bus/auth.go
    • Line 72: warning: exported method CapabilityMap.MetaObjectCache should have comment or be unexported (golint)
    • Line 76: warning: exported method CapabilityMap.ObjectPtrUID should have comment or be unexported (golint)
    • Line 80: warning: exported method CapabilityMap.RemoteCancelableCalls should have comment or be unexported (golint)
    • qiloop/bus/object.go
    • Line 81: warning: should omit 2nd value from range; this loop is equivalent to `for uid := range ...` (golint)
    • Line 259: warning: should omit 2nd value from range; this loop is equivalent to `for uid := range ...` (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign95%

IneffAssign detects ineffectual assignments in Go code.


misspell93%

Misspell Finds commonly misspelled English words

    • qiloop/doc.go
    • Line 38: warning: "commmand" is a misspelling of "command" (misspell)
    • Line 103: warning: "terminaison" is a misspelling of "termination" (misspell)
    • qiloop/bus/auth.go
    • Line 34: warning: "negociation" is a misspelling of "negotiation" (misspell)
    • Line 170: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 172: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 181: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 182: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 183: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 202: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 202: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 203: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 229: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 230: warning: "negociated" is a misspelling of "negotiated" (misspell)
    • Line 232: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 233: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 235: warning: "prefered" is a misspelling of "preferred" (misspell)
    • Line 256: warning: "prefered" is a misspelling of "preferred" (misspell)