Preparing report...

Report for github.com/luk4z7/middleware-acl

D    Needs lots of improvement    Found 15 issues across 15 files

Tweet

gofmt0%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint20%

Golint is a linter for Go source code.

    • middleware-acl/src/middleware/service/user/user.go
    • Line 7: warning: comment on exported function GetUserRoles should be of the form "GetUserRoles ..." (golint)
    • Line 14: warning: comment on exported function DeleteRoleFromUser should be of the form "DeleteRoleFromUser ..." (golint)
    • Line 21: warning: comment on exported function CheckUserPermission should be of the form "CheckUserPermission ..." (golint)
    • middleware-acl/src/middleware/service/role/role.go
    • Line 8: warning: comment on exported function GetAll should be of the form "GetAll ..." (golint)
    • Line 16: warning: comment on exported function Create should be of the form "Create ..." (golint)
    • Line 28: warning: comment on exported function Get should be of the form "Get ..." (golint)
    • Line 35: warning: comment on exported function Update should be of the form "Update ..." (golint)
    • Line 42: warning: comment on exported function Delete should be of the form "Delete ..." (golint)
    • Line 49: warning: comment on exported function DeletePermissionForUser should be of the form "DeletePermissionForUser ..." (golint)
    • middleware-acl/src/middleware/core/response/response.go
    • Line 9: warning: exported type Body should have comment or be unexported (golint)
    • Line 15: warning: exported type Meta should have comment or be unexported (golint)
    • Line 22: warning: exported type Pagination should have comment or be unexported (golint)
    • Line 26: warning: exported type Headers should have comment or be unexported (golint)
    • Line 28: warning: exported function Header should have comment or be unexported (golint)
    • Line 37: warning: exported function MountEnvelope should have comment or be unexported (golint)
    • Line 45: warning: exported function Envelope should have comment or be unexported (golint)
    • middleware-acl/src/middleware/controller/role/role.go
    • Line 13: warning: exported function GetAll should have comment or be unexported (golint)
    • Line 24: warning: exported function Create should have comment or be unexported (golint)
    • Line 62: warning: exported function Get should have comment or be unexported (golint)
    • Line 74: warning: exported function Update should have comment or be unexported (golint)
    • Line 114: warning: exported function Delete should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign20%

IneffAssign detects ineffectual assignments in Go code.

    • middleware-acl/src/middleware/core/adapter/adapter.go
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/casbin/mongodb-adapter (invalid package name: "") (ineffassign)
    • Line 5: warning: could not import github.com/casbin/casbin/persist (invalid package name: "") (ineffassign)
    • Line 9: warning: undeclared name: mongodbadapter (ineffassign)
    • Line 4: warning: "github.com/casbin/mongodb-adapter" imported but not used (ineffassign)
    • middleware-acl/src/middleware/controller/role/role_test.go
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 11: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: could not import github.com/codegangsta/negroni (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import github.com/stretchr/testify/assert (invalid package name: "") (ineffassign)
    • Line 11: warning: could not import middleware/service/user (invalid package name: "") (ineffassign)
    • middleware-acl/src/middleware/controller/role/role.go
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 7: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: could not import middleware/service/role (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import middleware/core/response (invalid package name: "") (ineffassign)
    • Line 7: warning: could not import middleware/lib/error (invalid package name: "") (ineffassign)
    • Line 8: warning: could not import github.com/gorilla/mux (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import middleware/service/model (invalid package name: "") (ineffassign)
    • Line 5: warning: could not import middleware/service/role (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import middleware/core/response (invalid package name: "") (ineffassign)
    • Line 7: warning: could not import middleware/lib/error (invalid package name: "") (ineffassign)
    • Line 8: warning: could not import github.com/gorilla/mux (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import middleware/service/model (invalid package name: "") (ineffassign)
    • middleware-acl/src/middleware/controller/user/user.go
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 7: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: could not import middleware/service/user (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import github.com/gorilla/mux (invalid package name: "") (ineffassign)
    • Line 7: warning: could not import middleware/core/response (invalid package name: "") (ineffassign)
    • Line 8: warning: could not import middleware/lib/error (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import middleware/service/model (invalid package name: "") (ineffassign)
    • Line 5: warning: could not import middleware/service/user (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import github.com/gorilla/mux (invalid package name: "") (ineffassign)
    • Line 7: warning: could not import middleware/core/response (invalid package name: "") (ineffassign)
    • Line 8: warning: could not import middleware/lib/error (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import middleware/service/model (invalid package name: "") (ineffassign)
    • middleware-acl/src/middleware/router/role.go
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/gorilla/mux (invalid package name: "") (ineffassign)
    • Line 5: warning: could not import github.com/codegangsta/negroni (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import middleware/controller/role (invalid package name: "") (ineffassign)
    • middleware-acl/src/middleware/service/role/role.go
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import middleware/service/authorization (invalid package name: "") (ineffassign)
    • Line 5: warning: could not import middleware/service/model (invalid package name: "") (ineffassign)
    • middleware-acl/src/middleware/server.go
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/codegangsta/negroni (invalid package name: "") (ineffassign)
    • Line 6: warning: could not import github.com/rs/cors (invalid package name: "") (ineffassign)
    • Line 8: warning: could not import middleware/router (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!