gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• flyteadmin/cmd/entrypoints/k8s_secret.go
  • Line 95: warning: cyclomatic complexity 16 of function persistSecrets() is high (> 15) (gocyclo)

• flyteadmin/pkg/manager/impl/validation/launch_plan_validator.go
  • Line 82: warning: cyclomatic complexity 18 of function checkAndFetchExpectedInputForLaunchPlan() is high (> 15) (gocyclo)

• flyteadmin/pkg/manager/impl/validation/task_validator.go
  • Line 168: warning: cyclomatic complexity 18 of function validateTaskResources() is high (> 15) (gocyclo)

golint34%

Golint is a linter for Go source code.

• flyteadmin/pkg/manager/mocks/launch_plan.go
  • Line 11: warning: exported type CreateLaunchPlanFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type UpdateLaunchPlanFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type GetLaunchPlanFunc should have comment or be unexported (golint)
  • Line 17: warning: exported type GetActiveLaunchPlanFunc should have comment or be unexported (golint)
  • Line 19: warning: exported type ListLaunchPlansFunc should have comment or be unexported (golint)
  • Line 21: warning: exported type ListLaunchPlanIdsFunc should have comment or be unexported (golint)
  • Line 23: warning: exported type ListActiveLaunchPlansFunc should have comment or be unexported (golint)
  • Line 26: warning: exported type MockLaunchPlanManager should have comment or be unexported (golint)
  • Line 36: warning: exported method MockLaunchPlanManager.SetCreateCallback should have comment or be unexported (golint)
  • Line 40: warning: exported method MockLaunchPlanManager.CreateLaunchPlan should have comment or be unexported (golint)
  • Line 49: warning: exported method MockLaunchPlanManager.SetUpdateLaunchPlan should have comment or be unexported (golint)
  • Line 53: warning: exported method MockLaunchPlanManager.UpdateLaunchPlan should have comment or be unexported (golint)
  • Line 61: warning: exported method MockLaunchPlanManager.GetLaunchPlan should have comment or be unexported (golint)
  • Line 69: warning: exported method MockLaunchPlanManager.SetGetActiveLaunchPlanCallback should have comment or be unexported (golint)
  • Line 73: warning: exported method MockLaunchPlanManager.GetActiveLaunchPlan should have comment or be unexported (golint)
  • Line 81: warning: exported method MockLaunchPlanManager.SetListLaunchPlansCallback should have comment or be unexported (golint)
  • Line 85: warning: exported method MockLaunchPlanManager.ListLaunchPlans should have comment or be unexported (golint)
  • Line 93: warning: exported method MockLaunchPlanManager.SetListActiveLaunchPlansCallback should have comment or be unexported (golint)
  • Line 97: warning: exported method MockLaunchPlanManager.ListActiveLaunchPlans should have comment or be unexported (golint)
  • Line 105: warning: exported method MockLaunchPlanManager.ListLaunchPlanIds should have comment or be unexported (golint)
  • Line 113: warning: exported function NewMockLaunchPlanManager should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/named_entity.go
  • Line 9: warning: exported type GetNamedEntityFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type UpdateNamedEntityFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type ListNamedEntitiesFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type NamedEntityManager should have comment or be unexported (golint)
  • Line 19: warning: exported method NamedEntityManager.GetNamedEntity should have comment or be unexported (golint)
  • Line 26: warning: exported method NamedEntityManager.UpdateNamedEntity should have comment or be unexported (golint)
  • Line 33: warning: exported method NamedEntityManager.ListNamedEntities should have comment or be unexported (golint)

• flyteadmin/pkg/common/executions.go
  • Line 9: warning: exported const ExecutionIDLength should have comment or be unexported (golint)
  • Line 11: warning: comment on exported const AllowedExecutionIDStartCharStr should be of the form "AllowedExecutionIDStartCharStr ..." (golint)
  • Line 13: warning: exported const AllowedExecutionIDStr should have comment or be unexported (golint)
  • Line 15: warning: exported var AllowedExecutionIDStartChars should have comment or be unexported (golint)
  • Line 16: warning: exported var AllowedExecutionIDChars should have comment or be unexported (golint)
  • Line 18: warning: comment on exported function GetExecutionName should be of the form "GetExecutionName ..." (golint)
  • Line 50: warning: exported function IsExecutionTerminal should have comment or be unexported (golint)
  • Line 54: warning: exported function IsNodeExecutionTerminal should have comment or be unexported (golint)
  • Line 58: warning: exported function IsTaskExecutionTerminal should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/interfaces/execution_target_provider.go
  • Line 9: warning: exported type ExecutionTargetProvider should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/execution_event.go
  • Line 7: warning: exported type ExecutionEvent should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/registration_validation_provider.go
  • Line 1: warning: package comment should be of the form "Package runtime ..." (golint)
  • Line 15: warning: comment on exported type RegistrationValidationProvider should be of the form "RegistrationValidationProvider ..." (with optional leading article) (golint)
  • Line 18: warning: exported method RegistrationValidationProvider.GetWorkflowNodeLimit should have comment or be unexported (golint)
  • Line 22: warning: exported method RegistrationValidationProvider.GetMaxLabelEntries should have comment or be unexported (golint)
  • Line 26: warning: exported method RegistrationValidationProvider.GetMaxAnnotationEntries should have comment or be unexported (golint)
  • Line 30: warning: exported method RegistrationValidationProvider.GetWorkflowSizeLimit should have comment or be unexported (golint)
  • Line 34: warning: exported function NewRegistrationValidationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/util/filters.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 120: warning: exported function ParseFilters should have comment or be unexported (golint)
  • Line 149: warning: exported function GetSingleValueEqualityFilter should have comment or be unexported (golint)
  • Line 153: warning: exported type FilterSpec should have comment or be unexported (golint)
  • Line 190: warning: exported function AddRequestFilters should have comment or be unexported (golint)
  • Line 205: warning: comment on exported function GetDbFilters should be of the form "GetDbFilters ..." (golint)
  • Line 224: warning: exported function GetWorkflowExecutionIdentifierFilters should have comment or be unexported (golint)
  • Line 256: warning: comment on exported function GetNodeExecutionIdentifierFilters should be of the form "GetNodeExecutionIdentifierFilters ..." (golint)

• flyteadmin/pkg/manager/impl/validation/task_validator.go
  • Line 1: warning: package comment should be of the form "Package validation ..." (golint)
  • Line 83: warning: exported function ValidateTask should have comment or be unexported (golint)

• flyteadmin/cmd/entrypoints/serve.go
  • Line 135: warning: exported function GetHandleOpenapiSpec should have comment or be unexported (golint)

• flyteadmin/auth/authzserver/encryptor.go
  • Line 3: warning: exported type Encryptor should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/workflow.go
  • Line 9: warning: exported type CreateWorkflowFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type MockWorkflowManager should have comment or be unexported (golint)
  • Line 15: warning: exported method MockWorkflowManager.SetCreateCallback should have comment or be unexported (golint)
  • Line 19: warning: exported method MockWorkflowManager.CreateWorkflow should have comment or be unexported (golint)
  • Line 28: warning: exported method MockWorkflowManager.ListWorkflows should have comment or be unexported (golint)
  • Line 33: warning: exported method MockWorkflowManager.GetWorkflow should have comment or be unexported (golint)
  • Line 38: warning: exported method MockWorkflowManager.ListWorkflowIdentifiers should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/resource.go
  • Line 10: warning: exported type CreateOrUpdateResourceFunction should have comment or be unexported (golint)
  • Line 11: warning: exported type GetResourceFunction should have comment or be unexported (golint)
  • Line 13: warning: exported type ListAllResourcesFunction should have comment or be unexported (golint)
  • Line 14: warning: exported type DeleteResourceFunction should have comment or be unexported (golint)
  • Line 16: warning: exported type MockResourceRepo should have comment or be unexported (golint)
  • Line 23: warning: exported method MockResourceRepo.CreateOrUpdate should have comment or be unexported (golint)
  • Line 30: warning: exported method MockResourceRepo.Get should have comment or be unexported (golint)
  • Line 38: warning: exported method MockResourceRepo.GetRaw should have comment or be unexported (golint)
  • Line 46: warning: exported method MockResourceRepo.ListAll should have comment or be unexported (golint)
  • Line 53: warning: exported method MockResourceRepo.Delete should have comment or be unexported (golint)
  • Line 60: warning: exported function NewMockResourceRepo should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/config/seed_data.go
  • Line 12: warning: comment on exported function SeedProjects should be of the form "SeedProjects ..." (golint)

• flyteadmin/pkg/runtime/mocks/mock_cluster_resource_provider.go
  • Line 9: warning: exported type MockClusterResourceConfiguration should have comment or be unexported (golint)
  • Line 16: warning: exported method MockClusterResourceConfiguration.GetTemplatePath should have comment or be unexported (golint)
  • Line 19: warning: exported method MockClusterResourceConfiguration.GetTemplateData should have comment or be unexported (golint)
  • Line 23: warning: exported method MockClusterResourceConfiguration.GetRefreshInterval should have comment or be unexported (golint)
  • Line 27: warning: exported method MockClusterResourceConfiguration.GetCustomTemplateData should have comment or be unexported (golint)
  • Line 31: warning: exported function NewMockClusterResourceConfiguration should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/factory.go
  • Line 30: warning: exported type PublisherConfig should have comment or be unexported (golint)
  • Line 34: warning: exported type ProcessorConfig should have comment or be unexported (golint)
  • Line 39: warning: exported type EmailerConfig should have comment or be unexported (golint)
  • Line 44: warning: exported function GetEmailer should have comment or be unexported (golint)
  • Line 77: warning: exported function NewNotificationsProcessor should have comment or be unexported (golint)
  • Line 116: warning: exported function NewNotificationsPublisher should have comment or be unexported (golint)
  • Line 167: warning: exported function NewEventsPublisher should have comment or be unexported (golint)

• flyteadmin/pkg/audit/message.go
  • Line 5: warning: exported type Principal should have comment or be unexported (golint)
  • Line 15: warning: exported type Client should have comment or be unexported (golint)
  • Line 19: warning: exported type AccessMode should have comment or be unexported (golint)
  • Line 22: warning: exported const ReadOnly should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: comment on exported type Request should be of the form "Request ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
  • Line 47: warning: exported type Message should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/mocks/execution_target_provider.go
  • Line 9: warning: exported type MockExecutionTargetProvider should have comment or be unexported (golint)
  • Line 11: warning: comment on exported method MockExecutionTargetProvider.GetExecutionTarget should be of the form "GetExecutionTarget ..." (golint)

• flyteadmin/pkg/repositories/models/task.go
  • Line 6: warning: comment on exported type TaskKey should be of the form "TaskKey ..." (with optional leading article) (golint)
  • Line 14: warning: comment on exported type Task should be of the form "Task ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/interfaces/common.go
  • Line 7: warning: comment on exported type Identifier should be of the form "Identifier ..." (with optional leading article) (golint)
  • Line 15: warning: comment on exported type ListResourceInput should be of the form "ListResourceInput ..." (with optional leading article) (golint)
  • Line 30: warning: comment on exported type UpdateResourceInput should be of the form "UpdateResourceInput ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/models/task_execution.go
  • Line 10: warning: comment on exported type TaskExecutionKey should be of the form "TaskExecutionKey ..." (with optional leading article) (golint)
  • Line 19: warning: comment on exported type TaskExecution should be of the form "TaskExecution ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/cluster_config_provider.go
  • Line 17: warning: comment on exported type ClusterConfigurationProvider should be of the form "ClusterConfigurationProvider ..." (with optional leading article) (golint)
  • Line 20: warning: exported method ClusterConfigurationProvider.GetLabelClusterMap should have comment or be unexported (golint)
  • Line 29: warning: exported method ClusterConfigurationProvider.GetClusterConfigs should have comment or be unexported (golint)
  • Line 38: warning: exported function NewClusterConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/project.go
  • Line 15: warning: exported method AdminService.RegisterProject should have comment or be unexported (golint)
  • Line 42: warning: exported method AdminService.ListProjects should have comment or be unexported (golint)
  • Line 67: warning: exported method AdminService.UpdateProject should have comment or be unexported (golint)

• flyteadmin/pkg/common/constants.go
  • Line 5: warning: exported var RuntimeTypeKey should have comment or be unexported (golint)
  • Line 6: warning: exported var RuntimeVersionKey should have comment or be unexported (golint)
  • Line 9: warning: exported const AuditFieldsContextKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported const MaxResponseStatusBytes should have comment or be unexported (golint)

• flyteadmin/pkg/data/implementations/noop_remote_url.go
  • Line 13: warning: comment on exported type NoopRemoteURL should be of the form "NoopRemoteURL ..." (with optional leading article) (golint)
  • Line 18: warning: exported method NoopRemoteURL.Get should have comment or be unexported (golint)
  • Line 30: warning: exported function NewNoopRemoteURL should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/errors/test_error_transformer.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 29: warning: exported function NewTestErrorTransformer should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/task_repo.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 11: warning: exported type CreateTaskFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type GetTaskFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListTaskFunc should have comment or be unexported (golint)
  • Line 14: warning: exported type ListTaskIdentifiersFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type MockTaskRepo should have comment or be unexported (golint)
  • Line 23: warning: exported method MockTaskRepo.Create should have comment or be unexported (golint)
  • Line 30: warning: exported method MockTaskRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 34: warning: exported method MockTaskRepo.Get should have comment or be unexported (golint)
  • Line 48: warning: exported method MockTaskRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 52: warning: exported method MockTaskRepo.List should have comment or be unexported (golint)
  • Line 60: warning: exported method MockTaskRepo.SetListCallback should have comment or be unexported (golint)
  • Line 64: warning: exported method MockTaskRepo.ListTaskIdentifiers should have comment or be unexported (golint)
  • Line 73: warning: exported method MockTaskRepo.SetListTaskIdentifiersCallback should have comment or be unexported (golint)
  • Line 77: warning: exported function NewMockTaskRepo should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/noop/event_scheduler.go
  • Line 1: warning: package comment should be of the form "Package noop ..." (golint)
  • Line 12: warning: exported type EventScheduler should have comment or be unexported (golint)
  • Line 14: warning: exported method EventScheduler.AddSchedule should have comment or be unexported (golint)
  • Line 20: warning: exported method EventScheduler.RemoveSchedule should have comment or be unexported (golint)
  • Line 26: warning: exported function NewNoopEventScheduler should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/repository.go
  • Line 8: warning: exported type MockRepository should have comment or be unexported (golint)
  • Line 22: warning: exported method MockRepository.TaskRepo should have comment or be unexported (golint)
  • Line 26: warning: exported method MockRepository.WorkflowRepo should have comment or be unexported (golint)
  • Line 30: warning: exported method MockRepository.LaunchPlanRepo should have comment or be unexported (golint)
  • Line 34: warning: exported method MockRepository.ExecutionRepo should have comment or be unexported (golint)
  • Line 38: warning: exported method MockRepository.ExecutionEventRepo should have comment or be unexported (golint)
  • Line 42: warning: exported method MockRepository.NodeExecutionRepo should have comment or be unexported (golint)
  • Line 46: warning: exported method MockRepository.NodeExecutionEventRepo should have comment or be unexported (golint)
  • Line 50: warning: exported method MockRepository.ProjectRepo should have comment or be unexported (golint)
  • Line 54: warning: exported method MockRepository.ResourceRepo should have comment or be unexported (golint)
  • Line 58: warning: exported method MockRepository.TaskExecutionRepo should have comment or be unexported (golint)
  • Line 62: warning: exported method MockRepository.NamedEntityRepo should have comment or be unexported (golint)
  • Line 66: warning: exported function NewMockRepository should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/mocks/mock_registration_validation_provider.go
  • Line 5: warning: exported type MockRegistrationValidationProvider should have comment or be unexported (golint)
  • Line 12: warning: exported method MockRegistrationValidationProvider.GetWorkflowNodeLimit should have comment or be unexported (golint)
  • Line 16: warning: exported method MockRegistrationValidationProvider.GetMaxLabelEntries should have comment or be unexported (golint)
  • Line 20: warning: exported method MockRegistrationValidationProvider.GetMaxAnnotationEntries should have comment or be unexported (golint)
  • Line 24: warning: exported method MockRegistrationValidationProvider.GetWorkflowSizeLimit should have comment or be unexported (golint)
  • Line 28: warning: exported function NewMockRegistrationValidationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/data/mocks/remote.go
  • Line 10: warning: comment on exported type MockRemoteURL should be of the form "MockRemoteURL ..." (with optional leading article) (golint)
  • Line 15: warning: exported method MockRemoteURL.Get should have comment or be unexported (golint)
  • Line 22: warning: exported function NewMockRemoteURL should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/version_manager.go
  • Line 11: warning: exported type VersionManager should have comment or be unexported (golint)
  • Line 17: warning: exported method VersionManager.GetVersion should have comment or be unexported (golint)
  • Line 27: warning: exported function NewVersionManager should have comment or be unexported (golint)

• flyteadmin/auth/config/config.go
  • Line 15: warning: exported type SecretName should have comment or be unexported (golint)
  • Line 18: warning: comment on exported const SecretNameOIdCClientSecret should be of the form "SecretNameOIdCClientSecret ..." (golint)
  • Line 21: warning: comment on exported const SecretNameCookieHashKey should be of the form "SecretNameCookieHashKey ..." (golint)
  • Line 23: warning: comment on exported const SecretNameCookieBlockKey should be of the form "SecretNameCookieBlockKey ..." (golint)
  • Line 25: warning: comment on exported const SecretNameClaimSymmetricKey should be of the form "SecretNameClaimSymmetricKey ..." (golint)
  • Line 28: warning: comment on exported const SecretNameTokenSigningRSAKey should be of the form "SecretNameTokenSigningRSAKey ..." (golint)
  • Line 31: warning: comment on exported const SecretNameOldTokenSigningRSAKey should be of the form "SecretNameOldTokenSigningRSAKey ..." (golint)
  • Line 52: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 119: warning: exported type Config should have comment or be unexported (golint)
  • Line 151: warning: exported type AuthorizationServer should have comment or be unexported (golint)
  • Line 173: warning: exported type ExternalAuthorizationServer should have comment or be unexported (golint)
  • Line 196: warning: exported type UserAuthConfig should have comment or be unexported (golint)
  • Line 212: warning: exported type OpenIDOptions should have comment or be unexported (golint)
  • Line 234: warning: exported function GetConfig should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/base_model.go
  • Line 5: warning: comment on exported type BaseModel should be of the form "BaseModel ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/gormimpl/task_repo.go
  • Line 16: warning: comment on exported type TaskRepo should be of the form "TaskRepo ..." (with optional leading article) (golint)
  • Line 23: warning: exported method TaskRepo.Create should have comment or be unexported (golint)
  • Line 33: warning: exported method TaskRepo.Get should have comment or be unexported (golint)
  • Line 59: warning: exported method TaskRepo.List should have comment or be unexported (golint)
  • Line 89: warning: exported method TaskRepo.ListTaskIdentifiers should have comment or be unexported (golint)
  • Line 126: warning: comment on exported function NewTaskRepo should be of the form "NewTaskRepo ..." (golint)

• flyteadmin/pkg/audit/log.go
  • Line 15: warning: exported type LogBuilder should have comment or be unexported (golint)
  • Line 94: warning: exported function NewLogBuilder should have comment or be unexported (golint)

• flyteadmin/auth/cookie_manager.go
  • Line 18: warning: exported type CookieManager should have comment or be unexported (golint)
  • Line 24: warning: exported const ErrB64Decoding should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: comment on exported const ErrTokenNil should be of the form "ErrTokenNil ..." (golint)
  • Line 27: warning: comment on exported const ErrNoIDToken should be of the form "ErrNoIDToken ..." (golint)
  • Line 31: warning: exported function NewCookieManager should have comment or be unexported (golint)
  • Line 50: warning: comment on exported method CookieManager.RetrieveTokenValues should be of the form "RetrieveTokenValues ..." (golint)
  • Line 78: warning: exported method CookieManager.SetUserInfoCookie should have comment or be unexported (golint)
  • Line 96: warning: exported method CookieManager.RetrieveUserInfo should have comment or be unexported (golint)
  • Line 112: warning: exported method CookieManager.RetrieveAuthCodeRequest should have comment or be unexported (golint)
  • Line 121: warning: exported method CookieManager.SetAuthCodeCookie should have comment or be unexported (golint)
  • Line 133: warning: exported method CookieManager.SetTokenCookies should have comment or be unexported (golint)
  • Line 193: warning: exported method CookieManager.DeleteCookies should have comment or be unexported (golint)

• flyteadmin/auth/authzserver/resource_server.go
  • Line 30: warning: exported method ResourceServer.ValidateAccessToken should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/named_entity_metadata_repo.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 11: warning: exported type GetNamedEntityFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type ListNamedEntityFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type UpdateNamedEntityFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type MockNamedEntityRepo should have comment or be unexported (golint)
  • Line 21: warning: exported method MockNamedEntityRepo.Update should have comment or be unexported (golint)
  • Line 28: warning: exported method MockNamedEntityRepo.Get should have comment or be unexported (golint)
  • Line 46: warning: exported method MockNamedEntityRepo.List should have comment or be unexported (golint)
  • Line 53: warning: exported method MockNamedEntityRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 57: warning: exported method MockNamedEntityRepo.SetListCallback should have comment or be unexported (golint)
  • Line 61: warning: exported method MockNamedEntityRepo.SetUpdateCallback should have comment or be unexported (golint)
  • Line 65: warning: exported function NewMockNamedEntityRepo should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/util/metrics.go
  • Line 17: warning: comment on exported type RequestMetrics should be of the form "RequestMetrics ..." (with optional leading article) (golint)
  • Line 27: warning: exported method RequestMetrics.Time should have comment or be unexported (golint)
  • Line 31: warning: exported method RequestMetrics.Record should have comment or be unexported (golint)
  • Line 46: warning: exported method RequestMetrics.Success should have comment or be unexported (golint)
  • Line 50: warning: exported function NewRequestMetrics should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/resource.go
  • Line 16: warning: exported function WorkflowAttributesToResourceModel should have comment or be unexported (golint)
  • Line 59: warning: exported function MergeUpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 86: warning: exported function FromResourceModelToWorkflowAttributes should have comment or be unexported (golint)
  • Line 101: warning: exported function ProjectDomainAttributesToResourceModel should have comment or be unexported (golint)
  • Line 115: warning: exported function MergeUpdateProjectDomainAttributes should have comment or be unexported (golint)
  • Line 142: warning: exported function FromResourceModelToProjectDomainAttributes should have comment or be unexported (golint)
  • Line 156: warning: exported function FromResourceModelToMatchableAttributes should have comment or be unexported (golint)
  • Line 172: warning: exported function FromResourceModelsToMatchableAttributes should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/project_repo.go
  • Line 9: warning: exported type ProjectRepoInterface should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/named_entity.go
  • Line 15: warning: exported method AdminService.GetNamedEntity should have comment or be unexported (golint)
  • Line 41: warning: exported method AdminService.UpdateNamedEntity should have comment or be unexported (golint)
  • Line 67: warning: exported method AdminService.ListNamedEntities should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/impl/random_cluster_selector.go
  • Line 28: warning: comment on exported type RandomClusterSelector should be of the form "RandomClusterSelector ..." (with optional leading article) (golint)
  • Line 102: warning: exported method RandomClusterSelector.GetAllValidTargets should have comment or be unexported (golint)
  • Line 112: warning: exported method RandomClusterSelector.GetTarget should have comment or be unexported (golint)
  • Line 169: warning: exported function NewRandomClusterSelector should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/workflow_repo.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 11: warning: exported type CreateWorkflowFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type GetWorkflowFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListWorkflowFunc should have comment or be unexported (golint)
  • Line 14: warning: exported type ListIdentifiersFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type MockWorkflowRepo should have comment or be unexported (golint)
  • Line 23: warning: exported method MockWorkflowRepo.Create should have comment or be unexported (golint)
  • Line 30: warning: exported method MockWorkflowRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 34: warning: exported method MockWorkflowRepo.Get should have comment or be unexported (golint)
  • Line 48: warning: exported method MockWorkflowRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 52: warning: exported method MockWorkflowRepo.List should have comment or be unexported (golint)
  • Line 60: warning: exported method MockWorkflowRepo.SetListCallback should have comment or be unexported (golint)
  • Line 64: warning: exported method MockWorkflowRepo.SetListIdentifiersFunc should have comment or be unexported (golint)
  • Line 68: warning: exported method MockWorkflowRepo.ListIdentifiers should have comment or be unexported (golint)
  • Line 78: warning: exported function NewMockWorkflowRepo should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/node_execution.go
  • Line 18: warning: exported method AdminService.CreateNodeEvent should have comment or be unexported (golint)
  • Line 43: warning: exported method AdminService.GetNodeExecution should have comment or be unexported (golint)
  • Line 68: warning: exported method AdminService.ListNodeExecutions should have comment or be unexported (golint)
  • Line 93: warning: exported method AdminService.ListNodeExecutionsForTask should have comment or be unexported (golint)
  • Line 125: warning: exported method AdminService.GetNodeExecutionData should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/task.go
  • Line 9: warning: comment on exported type TaskInterface should be of the form "TaskInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/mocks/project_repo.go
  • Line 11: warning: exported type CreateProjectFunction should have comment or be unexported (golint)
  • Line 12: warning: exported type GetProjectFunction should have comment or be unexported (golint)
  • Line 13: warning: exported type ListProjectsFunction should have comment or be unexported (golint)
  • Line 14: warning: exported type UpdateProjectFunction should have comment or be unexported (golint)
  • Line 16: warning: exported type MockProjectRepo should have comment or be unexported (golint)
  • Line 23: warning: exported method MockProjectRepo.Create should have comment or be unexported (golint)
  • Line 30: warning: exported method MockProjectRepo.Get should have comment or be unexported (golint)
  • Line 41: warning: exported method MockProjectRepo.List should have comment or be unexported (golint)
  • Line 48: warning: exported method MockProjectRepo.UpdateProject should have comment or be unexported (golint)
  • Line 55: warning: exported function NewMockProjectRepo should have comment or be unexported (golint)

• flyteadmin/pkg/workflowengine/mocks/mock_executor.go
  • Line 9: warning: exported type ExecuteWorkflowFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type ExecuteTaskFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type TerminateWorkflowExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type MockExecutor should have comment or be unexported (golint)
  • Line 19: warning: exported method MockExecutor.SetExecuteWorkflowCallback should have comment or be unexported (golint)
  • Line 23: warning: exported method MockExecutor.ExecuteWorkflow should have comment or be unexported (golint)
  • Line 31: warning: exported method MockExecutor.SetExecuteTaskCallback should have comment or be unexported (golint)
  • Line 35: warning: exported method MockExecutor.ExecuteTask should have comment or be unexported (golint)
  • Line 42: warning: exported method MockExecutor.SetTerminateExecutionCallback should have comment or be unexported (golint)
  • Line 46: warning: exported method MockExecutor.TerminateWorkflowExecution should have comment or be unexported (golint)
  • Line 53: warning: exported function NewMockExecutor should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/attributes.go
  • Line 15: warning: exported method AdminService.UpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 44: warning: exported method AdminService.GetWorkflowAttributes should have comment or be unexported (golint)
  • Line 73: warning: exported method AdminService.DeleteWorkflowAttributes should have comment or be unexported (golint)
  • Line 102: warning: exported method AdminService.UpdateProjectDomainAttributes should have comment or be unexported (golint)
  • Line 130: warning: exported method AdminService.GetProjectDomainAttributes should have comment or be unexported (golint)
  • Line 158: warning: exported method AdminService.DeleteProjectDomainAttributes should have comment or be unexported (golint)
  • Line 186: warning: exported method AdminService.ListMatchableAttributes should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/node_execution_validator.go
  • Line 10: warning: exported function ValidateNodeExecutionIdentifier should have comment or be unexported (golint)
  • Line 24: warning: comment on exported function ValidateNodeExecutionEventRequest should be of the form "ValidateNodeExecutionEventRequest ..." (golint)
  • Line 56: warning: exported function ValidateNodeExecutionListRequest should have comment or be unexported (golint)
  • Line 66: warning: exported function ValidateNodeExecutionForTaskListRequest should have comment or be unexported (golint)

• flyteadmin/pkg/common/filters.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 13: warning: exported type FilterExpression should have comment or be unexported (golint)
  • Line 15: warning: comment on exported type GormQueryExpr should be of the form "GormQueryExpr ..." (with optional leading article) (golint)
  • Line 63: warning: exported const EqualExpression should have comment or be unexported (golint)
  • Line 115: warning: exported function GetUnrecognizedFilterFunctionErr should have comment or be unexported (golint)
  • Line 120: warning: exported function GetUnsupportedFilterExpressionErr should have comment or be unexported (golint)
  • Line 125: warning: exported function GetInvalidSingleValueFilterErr should have comment or be unexported (golint)
  • Line 130: warning: exported function GetInvalidRepeatedValueFilterErr should have comment or be unexported (golint)
  • Line 135: warning: comment on exported type InlineFilter should be of the form "InlineFilter ..." (with optional leading article) (golint)
  • Line 252: warning: comment on exported function NewSingleValueFilter should be of the form "NewSingleValueFilter ..." (golint)
  • Line 267: warning: comment on exported function NewRepeatedValueFilter should be of the form "NewRepeatedValueFilter ..." (golint)
  • Line 281: warning: exported function NewInlineFilter should have comment or be unexported (golint)
  • Line 293: warning: comment on exported type MapFilter should be of the form "MapFilter ..." (with optional leading article) (golint)
  • Line 306: warning: exported function NewMapFilter should have comment or be unexported (golint)
  • Line 329: warning: exported function NewWithDefaultValueFilter should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/resource.go
  • Line 5: warning: exported type ResourcePriority should have comment or be unexported (golint)
  • Line 8: warning: exported const ResourcePriorityDomainLevel should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: comment on exported type Resource should be of the form "Resource ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/mocks/mock_whitelist_provider.go
  • Line 5: warning: exported type MockWhitelistConfiguration should have comment or be unexported (golint)
  • Line 9: warning: exported method MockWhitelistConfiguration.GetTaskTypeWhitelist should have comment or be unexported (golint)
  • Line 13: warning: exported function NewMockWhitelistConfiguration should have comment or be unexported (golint)

• flyteadmin/auth/config/third_party_config.go
  • Line 3: warning: comment on exported type ThirdPartyConfigOptions should be of the form "ThirdPartyConfigOptions ..." (with optional leading article) (golint)
  • Line 9: warning: exported type FlyteClientConfig should have comment or be unexported (golint)
  • Line 15: warning: exported method ThirdPartyConfigOptions.IsEmpty should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/mocks/mock_application_provider.go
  • Line 7: warning: exported type MockApplicationProvider should have comment or be unexported (golint)
  • Line 17: warning: exported method MockApplicationProvider.GetDbConfig should have comment or be unexported (golint)
  • Line 21: warning: exported method MockApplicationProvider.SetDbConfig should have comment or be unexported (golint)
  • Line 25: warning: exported method MockApplicationProvider.GetTopLevelConfig should have comment or be unexported (golint)
  • Line 29: warning: exported method MockApplicationProvider.SetTopLevelConfig should have comment or be unexported (golint)
  • Line 33: warning: exported method MockApplicationProvider.GetSchedulerConfig should have comment or be unexported (golint)
  • Line 37: warning: exported method MockApplicationProvider.SetSchedulerConfig should have comment or be unexported (golint)
  • Line 41: warning: exported method MockApplicationProvider.GetRemoteDataConfig should have comment or be unexported (golint)
  • Line 45: warning: exported method MockApplicationProvider.SetRemoteDataConfig should have comment or be unexported (golint)
  • Line 49: warning: exported method MockApplicationProvider.GetNotificationsConfig should have comment or be unexported (golint)
  • Line 53: warning: exported method MockApplicationProvider.SetNotificationsConfig should have comment or be unexported (golint)
  • Line 57: warning: exported method MockApplicationProvider.GetDomainsConfig should have comment or be unexported (golint)
  • Line 61: warning: exported method MockApplicationProvider.SetDomainsConfig should have comment or be unexported (golint)
  • Line 65: warning: exported method MockApplicationProvider.SetExternalEventsConfig should have comment or be unexported (golint)
  • Line 69: warning: exported method MockApplicationProvider.GetExternalEventsConfig should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/mocks/mock_task_resource_provider.go
  • Line 5: warning: exported type MockTaskResourceConfiguration should have comment or be unexported (golint)
  • Line 10: warning: exported method MockTaskResourceConfiguration.GetDefaults should have comment or be unexported (golint)
  • Line 13: warning: exported method MockTaskResourceConfiguration.GetLimits should have comment or be unexported (golint)
  • Line 17: warning: exported function NewMockTaskResourceConfiguration should have comment or be unexported (golint)

• flyteadmin/auth/authzserver/utils.go
  • Line 32: warning: exported function GetIssuer should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/launch_plan.go
  • Line 9: warning: comment on exported type LaunchPlanInterface should be of the form "LaunchPlanInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/interfaces/task_execution.go
  • Line 9: warning: comment on exported type TaskExecutionInterface should be of the form "TaskExecutionInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/interfaces/execution_event_repo.go
  • Line 11: warning: exported type ExecutionEventRepoInterface should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/config/postgres.go
  • Line 12: warning: exported const Postgres should have comment or be unexported (golint)
  • Line 14: warning: comment on exported type DbConnectionConfigProvider should be of the form "DbConnectionConfigProvider ..." (with optional leading article) (golint)
  • Line 28: warning: exported type BaseConfig should have comment or be unexported (golint)
  • Line 32: warning: comment on exported type PostgresConfigProvider should be of the form "PostgresConfigProvider ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported function NewPostgresConfigProvider should be of the form "NewPostgresConfigProvider ..." (golint)
  • Line 46: warning: exported method PostgresConfigProvider.GetType should have comment or be unexported (golint)
  • Line 50: warning: exported method PostgresConfigProvider.GetArgs should have comment or be unexported (golint)
  • Line 60: warning: exported method PostgresConfigProvider.WithDebugModeEnabled should have comment or be unexported (golint)
  • Line 64: warning: exported method PostgresConfigProvider.WithDebugModeDisabled should have comment or be unexported (golint)
  • Line 68: warning: exported method PostgresConfigProvider.IsDebug should have comment or be unexported (golint)
  • Line 72: warning: comment on exported function OpenDbConnection should be of the form "OpenDbConnection ..." (golint)

• flyteadmin/pkg/manager/impl/testutils/constants.go
  • Line 4: warning: exported const ProjectQueryPattern should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/pkg/repositories/postgres_repo.go
  • Line 11: warning: exported type PostgresRepo should have comment or be unexported (golint)
  • Line 25: warning: exported method PostgresRepo.ExecutionRepo should have comment or be unexported (golint)
  • Line 29: warning: exported method PostgresRepo.ExecutionEventRepo should have comment or be unexported (golint)
  • Line 33: warning: exported method PostgresRepo.LaunchPlanRepo should have comment or be unexported (golint)
  • Line 37: warning: exported method PostgresRepo.NamedEntityRepo should have comment or be unexported (golint)
  • Line 41: warning: exported method PostgresRepo.ProjectRepo should have comment or be unexported (golint)
  • Line 45: warning: exported method PostgresRepo.NodeExecutionRepo should have comment or be unexported (golint)
  • Line 49: warning: exported method PostgresRepo.NodeExecutionEventRepo should have comment or be unexported (golint)
  • Line 53: warning: exported method PostgresRepo.TaskRepo should have comment or be unexported (golint)
  • Line 57: warning: exported method PostgresRepo.TaskExecutionRepo should have comment or be unexported (golint)
  • Line 61: warning: exported method PostgresRepo.WorkflowRepo should have comment or be unexported (golint)
  • Line 65: warning: exported method PostgresRepo.ResourceRepo should have comment or be unexported (golint)
  • Line 69: warning: exported function NewPostgresRepo should have comment or be unexported (golint)

• flyteadmin/auth/interfaces/cookie.go
  • Line 12: warning: exported type CookieHandler should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/aws/mocks/mock_cloud_watch_event_client.go
  • Line 13: warning: comment on exported type MockCloudWatchEventClient should be of the form "MockCloudWatchEventClient ..." (with optional leading article) (golint)
  • Line 21: warning: exported method MockCloudWatchEventClient.SetPutRuleFunc should have comment or be unexported (golint)
  • Line 25: warning: exported method MockCloudWatchEventClient.PutRule should have comment or be unexported (golint)
  • Line 33: warning: exported method MockCloudWatchEventClient.SetPutTargetsFunc should have comment or be unexported (golint)
  • Line 37: warning: exported method MockCloudWatchEventClient.PutTargets should have comment or be unexported (golint)
  • Line 45: warning: exported method MockCloudWatchEventClient.SetDeleteRuleFunc should have comment or be unexported (golint)
  • Line 49: warning: exported method MockCloudWatchEventClient.DeleteRule should have comment or be unexported (golint)
  • Line 57: warning: exported method MockCloudWatchEventClient.SetRemoveTargetsFunc should have comment or be unexported (golint)
  • Line 61: warning: exported method MockCloudWatchEventClient.RemoveTargets should have comment or be unexported (golint)
  • Line 69: warning: exported function NewMockCloudWatchEventClient should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/launch_plan_validator.go
  • Line 17: warning: exported function ValidateLaunchPlan should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/project_repo.go
  • Line 19: warning: exported type ProjectRepo should have comment or be unexported (golint)
  • Line 25: warning: exported method ProjectRepo.Create should have comment or be unexported (golint)
  • Line 35: warning: exported method ProjectRepo.Get should have comment or be unexported (golint)
  • Line 51: warning: exported method ProjectRepo.List should have comment or be unexported (golint)
  • Line 86: warning: exported function NewProjectRepo should have comment or be unexported (golint)
  • Line 96: warning: exported method ProjectRepo.UpdateProject should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/node_execution.go
  • Line 22: warning: exported type ToNodeExecutionModelInput should have comment or be unexported (golint)
  • Line 77: warning: exported function CreateNodeExecutionModel should have comment or be unexported (golint)
  • Line 140: warning: exported function UpdateNodeExecutionModel should have comment or be unexported (golint)
  • Line 204: warning: exported function FromNodeExecutionModel should have comment or be unexported (golint)
  • Line 234: warning: exported function FromNodeExecutionModels should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/interfaces/cluster.go
  • Line 9: warning: comment on exported type ClusterInterface should be of the form "ClusterInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/interfaces/node_execution_event_repo.go
  • Line 11: warning: exported type NodeExecutionEventRepoInterface should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/common.go
  • Line 14: warning: exported const Project should have comment or be unexported (golint)
  • Line 15: warning: exported const Domain should have comment or be unexported (golint)
  • Line 16: warning: exported const Name should have comment or be unexported (golint)
  • Line 17: warning: exported const Description should have comment or be unexported (golint)
  • Line 18: warning: exported const ResourceType should have comment or be unexported (golint)
  • Line 19: warning: exported const State should have comment or be unexported (golint)
  • Line 20: warning: exported const ID should have comment or be unexported (golint)
  • Line 71: warning: comment on exported function ValidateListInput should be of the form "ValidateListInput ..." (golint)

• flyteadmin/pkg/data/interfaces/remote.go
  • Line 9: warning: comment on exported type RemoteURLInterface should be of the form "RemoteURLInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/executioncluster/mocks/mock_cluster.go
  • Line 9: warning: exported type GetTargetFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type GetAllValidTargetsFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type MockCluster should have comment or be unexported (golint)
  • Line 17: warning: exported method MockCluster.SetGetTargetCallback should have comment or be unexported (golint)
  • Line 21: warning: exported method MockCluster.SetGetAllValidTargetsCallback should have comment or be unexported (golint)
  • Line 25: warning: exported method MockCluster.GetTarget should have comment or be unexported (golint)
  • Line 32: warning: exported method MockCluster.GetAllValidTargets should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/util/transformers.go
  • Line 10: warning: comment on exported function TransformAndRecordError should be of the form "TransformAndRecordError ..." (golint)

• flyteadmin/pkg/runtime/namespace_config_provider.go
  • Line 23: warning: exported type NamespaceMappingConfigurationProvider should have comment or be unexported (golint)
  • Line 25: warning: exported method NamespaceMappingConfigurationProvider.GetNamespaceMappingConfig should have comment or be unexported (golint)
  • Line 44: warning: exported function NewNamespaceMappingConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/data/implementations/aws_remote_url.go
  • Line 28: warning: comment on exported type AWSRemoteURL should be of the form "AWSRemoteURL ..." (with optional leading article) (golint)
  • Line 34: warning: exported type AWSS3Object should have comment or be unexported (golint)
  • Line 55: warning: exported method AWSRemoteURL.Get should have comment or be unexported (golint)
  • Line 95: warning: exported function NewAWSRemoteURL should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/task.go
  • Line 9: warning: exported type CreateTaskFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type ListUniqueIdsFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type MockTaskManager should have comment or be unexported (golint)
  • Line 17: warning: exported method MockTaskManager.SetCreateCallback should have comment or be unexported (golint)
  • Line 21: warning: exported method MockTaskManager.CreateTask should have comment or be unexported (golint)
  • Line 30: warning: exported method MockTaskManager.GetTask should have comment or be unexported (golint)
  • Line 34: warning: exported method MockTaskManager.ListTasks should have comment or be unexported (golint)
  • Line 38: warning: exported method MockTaskManager.SetListUniqueIdsFunc should have comment or be unexported (golint)
  • Line 42: warning: exported method MockTaskManager.ListUniqueTaskIdentifiers should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/namespace_configuration.go
  • Line 5: warning: exported type NamespaceMappingConfig should have comment or be unexported (golint)
  • Line 9: warning: exported type NamespaceMappingConfiguration should have comment or be unexported (golint)

• flyteadmin/auth/authzserver/stateless_token_store.go
  • Line 86: warning: exported method StatelessTokenStore.InvalidateAuthorizeCodeSession should have comment or be unexported (golint)
  • Line 90: warning: exported method StatelessTokenStore.GetAuthorizeCodeSession should have comment or be unexported (golint)
  • Line 111: warning: exported method StatelessTokenStore.GetPKCERequestSession should have comment or be unexported (golint)
  • Line 132: warning: exported method StatelessTokenStore.GetRefreshTokenSession should have comment or be unexported (golint)
  • Line 149: warning: exported method StatelessTokenStore.DeleteRefreshTokenSession should have comment or be unexported (golint)
  • Line 166: warning: exported method StatelessCodeProvider.AuthorizeCodeSignature should have comment or be unexported (golint)
  • Line 170: warning: exported method StatelessCodeProvider.GenerateAccessToken should have comment or be unexported (golint)
  • Line 175: warning: exported method StatelessCodeProvider.GenerateAuthorizeCode should have comment or be unexported (golint)
  • Line 229: warning: exported method StatelessCodeProvider.ValidateAuthorizeCode should have comment or be unexported (golint)
  • Line 233: warning: exported method StatelessCodeProvider.RefreshTokenSignature should have comment or be unexported (golint)
  • Line 237: warning: exported method StatelessCodeProvider.GenerateRefreshToken should have comment or be unexported (golint)
  • Line 266: warning: exported method StatelessCodeProvider.Encrypt should have comment or be unexported (golint)
  • Line 270: warning: exported method StatelessCodeProvider.Decrypt should have comment or be unexported (golint)
  • Line 274: warning: exported method StatelessCodeProvider.ValidateRefreshToken should have comment or be unexported (golint)
  • Line 278: warning: exported function NewStatelessCodeProvider should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/interfaces/event_scheduler.go
  • Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
  • Line 10: warning: exported type AddScheduleInput should have comment or be unexported (golint)
  • Line 21: warning: exported type RemoveScheduleInput should have comment or be unexported (golint)
  • Line 28: warning: exported type EventScheduler should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/quality_of_service_configuration.go
  • Line 8: warning: exported type TierName should have comment or be unexported (golint)
  • Line 13: warning: exported type QualityOfServiceSpec should have comment or be unexported (golint)
  • Line 17: warning: exported type QualityOfServiceConfig should have comment or be unexported (golint)
  • Line 22: warning: exported type QualityOfServiceConfiguration should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/node_execution.go
  • Line 10: warning: exported type NodeExecutionKey should have comment or be unexported (golint)
  • Line 15: warning: comment on exported type NodeExecution should be of the form "NodeExecution ..." (with optional leading article) (golint)

• flyteadmin/pkg/clusterresource/controller.go
  • Line 67: warning: comment on exported type Controller should be of the form "Controller ..." (with optional leading article) (golint)
  • Line 88: warning: exported type FileName should have comment or be unexported (golint)
  • Line 89: warning: exported type NamespaceName should have comment or be unexported (golint)
  • Line 90: warning: exported type LastModTimeCache should have comment or be unexported (golint)
  • Line 91: warning: exported type NamespaceCache should have comment or be unexported (golint)
  • Line 556: warning: exported function NewClusterResourceController should have comment or be unexported (golint)

• flyteadmin/auth/cookie.go
  • Line 41: warning: exported const ErrSecureCookie should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: comment on exported const ErrInvalidCsrfToken should be of the form "ErrInvalidCsrfToken ..." (golint)
  • Line 46: warning: exported var AllowedChars should have comment or be unexported (golint)
  • Line 48: warning: exported function HashCsrfState should have comment or be unexported (golint)
  • Line 54: warning: exported function NewSecureCookie should have comment or be unexported (golint)
  • Line 95: warning: exported function ReadSecureCookie should have comment or be unexported (golint)
  • Line 106: warning: exported function NewCsrfToken should have comment or be unexported (golint)
  • Line 116: warning: exported function NewCsrfCookie should have comment or be unexported (golint)
  • Line 126: warning: exported function VerifyCsrfCookie should have comment or be unexported (golint)
  • Line 142: warning: comment on exported function NewRedirectCookie should be of the form "NewRedirectCookie ..." (golint)

• flyteadmin/pkg/manager/impl/workflow_manager.go
  • Line 42: warning: exported type WorkflowManager should have comment or be unexported (golint)
  • Line 134: warning: exported method WorkflowManager.CreateWorkflow should have comment or be unexported (golint)
  • Line 215: warning: exported method WorkflowManager.GetWorkflow should have comment or be unexported (golint)
  • Line 229: warning: comment on exported method WorkflowManager.ListWorkflows should be of the form "ListWorkflows ..." (golint)
  • Line 286: warning: exported method WorkflowManager.ListWorkflowIdentifiers should have comment or be unexported (golint)
  • Line 339: warning: exported function NewWorkflowManager should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/testutils/repository.go
  • Line 13: warning: exported function GetRepoWithDefaultProjectAndErr should have comment or be unexported (golint)
  • Line 23: warning: exported function GetRepoWithDefaultProject should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/execution.go
  • Line 10: warning: exported type CreateExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type RelaunchExecutionFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type CreateExecutionEventFunc should have comment or be unexported (golint)
  • Line 18: warning: exported type GetExecutionFunc should have comment or be unexported (golint)
  • Line 19: warning: exported type GetExecutionDataFunc should have comment or be unexported (golint)
  • Line 21: warning: exported type ListExecutionFunc should have comment or be unexported (golint)
  • Line 22: warning: exported type TerminateExecutionFunc should have comment or be unexported (golint)
  • Line 25: warning: exported type MockExecutionManager should have comment or be unexported (golint)
  • Line 35: warning: exported method MockExecutionManager.SetCreateCallback should have comment or be unexported (golint)
  • Line 39: warning: exported method MockExecutionManager.CreateExecution should have comment or be unexported (golint)
  • Line 48: warning: exported method MockExecutionManager.SetRelaunchCallback should have comment or be unexported (golint)
  • Line 52: warning: exported method MockExecutionManager.RelaunchExecution should have comment or be unexported (golint)
  • Line 61: warning: exported method MockExecutionManager.SetCreateEventCallback should have comment or be unexported (golint)
  • Line 65: warning: exported method MockExecutionManager.CreateWorkflowEvent should have comment or be unexported (golint)
  • Line 74: warning: exported method MockExecutionManager.SetGetCallback should have comment or be unexported (golint)
  • Line 78: warning: exported method MockExecutionManager.GetExecution should have comment or be unexported (golint)
  • Line 86: warning: exported method MockExecutionManager.SetGetDataCallback should have comment or be unexported (golint)
  • Line 90: warning: exported method MockExecutionManager.GetExecutionData should have comment or be unexported (golint)
  • Line 98: warning: exported method MockExecutionManager.SetListCallback should have comment or be unexported (golint)
  • Line 102: warning: exported method MockExecutionManager.ListExecutions should have comment or be unexported (golint)
  • Line 110: warning: exported method MockExecutionManager.SetTerminateExecutionCallback should have comment or be unexported (golint)
  • Line 114: warning: exported method MockExecutionManager.TerminateExecution should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/named_entity_repo.go
  • Line 107: warning: comment on exported type NamedEntityRepo should be of the form "NamedEntityRepo ..." (with optional leading article) (golint)
  • Line 114: warning: exported method NamedEntityRepo.Update should have comment or be unexported (golint)
  • Line 132: warning: exported method NamedEntityRepo.Get should have comment or be unexported (golint)
  • Line 165: warning: exported method NamedEntityRepo.List should have comment or be unexported (golint)
  • Line 214: warning: comment on exported function NewNamedEntityRepo should be of the form "NewNamedEntityRepo ..." (golint)

• flyteadmin/pkg/runtime/interfaces/task_resource_configuration.go
  • Line 3: warning: exported type TaskResourceSet should have comment or be unexported (golint)
  • Line 10: warning: comment on exported type TaskResourceConfiguration should be of the form "TaskResourceConfiguration ..." (with optional leading article) (golint)

• flyteadmin/pkg/rpc/adminservice/version.go
  • Line 9: warning: exported method AdminService.GetVersion should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/errors/errors.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 16: warning: exported function GetMissingEntityError should have comment or be unexported (golint)
  • Line 20: warning: exported function GetMissingEntityByIDError should have comment or be unexported (golint)
  • Line 24: warning: exported function GetInvalidInputError should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/implementations/sendgrid_emailer.go
  • Line 19: warning: exported type SendgridEmailer should have comment or be unexported (golint)
  • Line 63: warning: exported method SendgridEmailer.SendEmail should have comment or be unexported (golint)
  • Line 78: warning: exported function NewSendGridEmailer should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/impl/factory.go
  • Line 10: warning: exported function GetExecutionCluster should have comment or be unexported (golint)

• flyteadmin/pkg/flytek8s/client.go
  • Line 1: warning: package comment should be of the form "Package flytek8s ..." (golint)
  • Line 18: warning: comment on exported function RemoteClusterConfig should be of the form "RemoteClusterConfig ..." (golint)
  • Line 39: warning: exported function GetRestClientConfigForCluster should have comment or be unexported (golint)
  • Line 49: warning: comment on exported function GetRestClientConfig should be of the form "GetRestClientConfig ..." (golint)
  • Line 74: warning: comment on exported function NewKubeClient should be of the form "NewKubeClient ..." (golint)

• flyteadmin/pkg/repositories/interfaces/named_entity_repo.go
  • Line 11: warning: exported type GetNamedEntityInput should have comment or be unexported (golint)
  • Line 18: warning: comment on exported type ListNamedEntityInput should be of the form "ListNamedEntityInput ..." (with optional leading article) (golint)
  • Line 26: warning: exported type NamedEntityCollectionOutput should have comment or be unexported (golint)
  • Line 30: warning: comment on exported type NamedEntityRepoInterface should be of the form "NamedEntityRepoInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/async/notifications/interfaces/publisher.go
  • Line 22: warning: comment on exported type Publisher should be of the form "Publisher ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/interfaces/workflow_repo.go
  • Line 9: warning: comment on exported type WorkflowRepoInterface should be of the form "WorkflowRepoInterface ..." (with optional leading article) (golint)
  • Line 20: warning: comment on exported type WorkflowCollectionOutput should be of the form "WorkflowCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/async/events/interfaces/workflow_execution.go
  • Line 9: warning: exported type WorkflowExecutionEventWriter should have comment or be unexported (golint)

• flyteadmin/tests/helpers.go
  • Line 11: warning: comment on exported function GetTestAdminServiceClient should be of the form "GetTestAdminServiceClient ..." (golint)
  • Line 26: warning: exported function GetTestHostEndpoint should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/mocks/publisher.go
  • Line 9: warning: exported type PublishFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type MockPublisher should have comment or be unexported (golint)
  • Line 15: warning: exported method MockPublisher.SetPublishCallback should have comment or be unexported (golint)
  • Line 19: warning: exported method MockPublisher.Publish should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/task_repo.go
  • Line 9: warning: comment on exported type TaskRepoInterface should be of the form "TaskRepoInterface ..." (with optional leading article) (golint)
  • Line 22: warning: comment on exported type TaskCollectionOutput should be of the form "TaskCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/workflowengine/interfaces/executor.go
  • Line 12: warning: exported type ExecuteWorkflowInput should have comment or be unexported (golint)
  • Line 24: warning: exported type ExecuteTaskInput should have comment or be unexported (golint)
  • Line 37: warning: exported type TerminateWorkflowInput should have comment or be unexported (golint)
  • Line 42: warning: exported type ExecutionInfo should have comment or be unexported (golint)
  • Line 46: warning: exported type FlyteWorkflowInterface should have comment or be unexported (golint)
  • Line 52: warning: exported type Executor should have comment or be unexported (golint)

• flyteadmin/pkg/workflowengine/interfaces/compiler.go
  • Line 9: warning: comment on exported type Compiler should be of the form "Compiler ..." (with optional leading article) (golint)

• flyteadmin/pkg/async/notifications/mocks/processor.go
  • Line 9: warning: exported type RunFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type StopFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type MockSubscriber should have comment or be unexported (golint)
  • Line 18: warning: exported method MockSubscriber.Run should have comment or be unexported (golint)
  • Line 25: warning: exported method MockSubscriber.Stop should have comment or be unexported (golint)
  • Line 32: warning: exported type SendEmailFunc should have comment or be unexported (golint)
  • Line 34: warning: exported type MockEmailer should have comment or be unexported (golint)
  • Line 38: warning: exported method MockEmailer.SetSendEmailFunc should have comment or be unexported (golint)
  • Line 42: warning: exported method MockEmailer.SendEmail should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/noop/workflow_executor.go
  • Line 13: warning: exported function NewWorkflowExecutor should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/named_entity.go
  • Line 8: warning: exported function CreateNamedEntityModel should have comment or be unexported (golint)
  • Line 24: warning: exported function FromNamedEntityMetadataFields should have comment or be unexported (golint)
  • Line 30: warning: exported function FromNamedEntityModel should have comment or be unexported (golint)
  • Line 44: warning: exported function FromNamedEntityModels should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/named_entity_manager.go
  • Line 37: warning: exported type NamedEntityMetrics should have comment or be unexported (golint)
  • Line 41: warning: exported type NamedEntityManager should have comment or be unexported (golint)
  • Line 47: warning: exported method NamedEntityManager.UpdateNamedEntity should have comment or be unexported (golint)
  • Line 70: warning: exported method NamedEntityManager.GetNamedEntity should have comment or be unexported (golint)
  • Line 108: warning: exported method NamedEntityManager.ListNamedEntities should have comment or be unexported (golint)
  • Line 166: warning: exported function NewNamedEntityManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/node_execution_repo.go
  • Line 10: warning: comment on exported type NodeExecutionRepoInterface should be of the form "NodeExecutionRepoInterface ..." (with optional leading article) (golint)
  • Line 26: warning: exported type NodeExecutionResource should have comment or be unexported (golint)
  • Line 30: warning: comment on exported type NodeExecutionCollectionOutput should be of the form "NodeExecutionCollectionOutput ..." (with optional leading article) (golint)
  • Line 35: warning: comment on exported type NodeExecutionEventCollectionOutput should be of the form "NodeExecutionEventCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/mocks/task_execution_repo.go
  • Line 10: warning: exported type CreateTaskExecutionFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type GetTaskExecutionFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type UpdateTaskExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListTaskExecutionFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type MockTaskExecutionRepo should have comment or be unexported (golint)
  • Line 22: warning: exported method MockTaskExecutionRepo.Create should have comment or be unexported (golint)
  • Line 29: warning: exported method MockTaskExecutionRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 33: warning: exported method MockTaskExecutionRepo.Get should have comment or be unexported (golint)
  • Line 40: warning: exported method MockTaskExecutionRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 44: warning: exported method MockTaskExecutionRepo.Update should have comment or be unexported (golint)
  • Line 51: warning: exported method MockTaskExecutionRepo.SetUpdateCallback should have comment or be unexported (golint)
  • Line 55: warning: exported method MockTaskExecutionRepo.List should have comment or be unexported (golint)
  • Line 62: warning: exported method MockTaskExecutionRepo.SetListCallback should have comment or be unexported (golint)
  • Line 66: warning: exported function NewMockTaskExecutionRepo should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/workflow.go
  • Line 13: warning: comment on exported function CreateWorkflowModel should be of the form "CreateWorkflowModel ..." (golint)
  • Line 37: warning: exported function FromWorkflowModel should have comment or be unexported (golint)
  • Line 59: warning: exported function FromWorkflowModels should have comment or be unexported (golint)
  • Line 71: warning: exported function FromWorkflowModelsToIdentifiers should have comment or be unexported (golint)

• flyteadmin/pkg/audit/common.go
  • Line 7: warning: exported type AuthenticatedClientMeta should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/mocks/mock_event_scheduler.go
  • Line 9: warning: exported type AddScheduleFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type RemoveScheduleFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type MockEventScheduler should have comment or be unexported (golint)
  • Line 16: warning: exported method MockEventScheduler.AddSchedule should have comment or be unexported (golint)
  • Line 23: warning: exported method MockEventScheduler.SetAddScheduleFunc should have comment or be unexported (golint)
  • Line 27: warning: exported method MockEventScheduler.RemoveSchedule should have comment or be unexported (golint)
  • Line 34: warning: exported method MockEventScheduler.SetRemoveScheduleFunc should have comment or be unexported (golint)
  • Line 38: warning: exported function NewMockEventScheduler should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/implementations/emailers.go
  • Line 3: warning: exported type ExternalEmailer should have comment or be unexported (golint)
  • Line 6: warning: exported const Sendgrid should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/pkg/workflowengine/impl/propeller_executor.go
  • Line 41: warning: exported type FlytePropeller should have comment or be unexported (golint)
  • Line 50: warning: exported type FlyteWorkflowBuilder should have comment or be unexported (golint)
  • Line 52: warning: exported method FlyteWorkflowBuilder.BuildFlyteWorkflow should have comment or be unexported (golint)
  • Line 113: warning: exported method FlytePropeller.ExecuteWorkflow should have comment or be unexported (golint)
  • Line 190: warning: exported method FlytePropeller.ExecuteTask should have comment or be unexported (golint)
  • Line 267: warning: exported method FlytePropeller.TerminateWorkflowExecution should have comment or be unexported (golint)
  • Line 311: warning: exported function NewFlytePropeller should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/execution_repo.go
  • Line 9: warning: comment on exported type ExecutionRepoInterface should be of the form "ExecutionRepoInterface ..." (with optional leading article) (golint)
  • Line 23: warning: comment on exported type ExecutionCollectionOutput should be of the form "ExecutionCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/executions/quality_of_service.go
  • Line 17: warning: exported type QualityOfServiceSpec should have comment or be unexported (golint)
  • Line 21: warning: exported type GetQualityOfServiceInput should have comment or be unexported (golint)
  • Line 27: warning: exported type QualityOfServiceAllocator should have comment or be unexported (golint)
  • Line 198: warning: exported function NewQualityOfServiceAllocator should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/workflow_validator.go
  • Line 23: warning: exported function ValidateWorkflow should have comment or be unexported (golint)
  • Line 38: warning: exported function ValidateCompiledWorkflow should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go
  • Line 16: warning: comment on exported type TaskExecutionRepo should be of the form "TaskExecutionRepo ..." (with optional leading article) (golint)
  • Line 23: warning: exported method TaskExecutionRepo.Create should have comment or be unexported (golint)
  • Line 33: warning: exported method TaskExecutionRepo.Get should have comment or be unexported (golint)
  • Line 81: warning: exported method TaskExecutionRepo.Update should have comment or be unexported (golint)
  • Line 92: warning: exported method TaskExecutionRepo.List should have comment or be unexported (golint)
  • Line 131: warning: comment on exported function NewTaskExecutionRepo should be of the form "NewTaskExecutionRepo ..." (golint)

• flyteadmin/pkg/manager/interfaces/named_entity.go
  • Line 9: warning: comment on exported type NamedEntityInterface should be of the form "NamedEntityInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/async/events/implementations/node_execution_event_writer.go
  • Line 40: warning: exported function NewNodeExecutionEventWriter should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/resource_repo.go
  • Line 17: warning: exported type ResourceRepo should have comment or be unexported (golint)
  • Line 52: warning: exported method ResourceRepo.CreateOrUpdate should have comment or be unexported (golint)
  • Line 84: warning: exported method ResourceRepo.Get should have comment or be unexported (golint)
  • Line 121: warning: exported method ResourceRepo.GetRaw should have comment or be unexported (golint)
  • Line 145: warning: exported method ResourceRepo.ListAll should have comment or be unexported (golint)
  • Line 158: warning: exported method ResourceRepo.Delete should have comment or be unexported (golint)
  • Line 178: warning: exported function NewResourceRepo should have comment or be unexported (golint)

• flyteadmin/auth/handlers.go
  • Line 31: warning: exported const RedirectURLParameter should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type HTTPRequestToMetadataAnnotator should have comment or be unexported (golint)
  • Line 38: warning: exported function RegisterHandlers should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function RefreshTokensIfExists should be of the form "RefreshTokensIfExists ..." (golint)
  • Line 179: warning: exported function AuthenticationLoggingInterceptor should have comment or be unexported (golint)
  • Line 213: warning: exported function SetContextForIdentity should have comment or be unexported (golint)
  • Line 256: warning: exported function WithUserEmail should have comment or be unexported (golint)
  • Line 260: warning: exported function WithAuditFields should have comment or be unexported (golint)
  • Line 274: warning: comment on exported function GetHTTPRequestCookieToMetadataHandler should be of the form "GetHTTPRequestCookieToMetadataHandler ..." (golint)
  • Line 323: warning: comment on exported function GetHTTPMetadataTaggingHandler should be of the form "GetHTTPMetadataTaggingHandler ..." (golint)
  • Line 333: warning: exported function IdentityContextFromRequest should have comment or be unexported (golint)
  • Line 369: warning: exported function QueryUserInfo should have comment or be unexported (golint)
  • Line 388: warning: exported function QueryUserInfoUsingAccessToken should have comment or be unexported (golint)
  • Line 415: warning: comment on exported function GetOIdCMetadataEndpointRedirectHandler should be of the form "GetOIdCMetadataEndpointRedirectHandler ..." (golint)
  • Line 424: warning: exported function GetLogoutEndpointHandler should have comment or be unexported (golint)

• flyteadmin/auth/authzserver/doc.go
  • Line 1: warning: package comment should be of the form "Package authzserver ..." (golint)

• flyteadmin/pkg/manager/interfaces/node_execution.go
  • Line 9: warning: comment on exported type NodeExecutionInterface should be of the form "NodeExecutionInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/validation/attributes_validator.go
  • Line 36: warning: exported function ValidateProjectDomainAttributesUpdateRequest should have comment or be unexported (golint)
  • Line 51: warning: exported function ValidateProjectDomainAttributesGetRequest should have comment or be unexported (golint)
  • Line 60: warning: exported function ValidateProjectDomainAttributesDeleteRequest should have comment or be unexported (golint)
  • Line 69: warning: exported function ValidateWorkflowAttributesUpdateRequest should have comment or be unexported (golint)
  • Line 86: warning: exported function ValidateWorkflowAttributesGetRequest should have comment or be unexported (golint)
  • Line 98: warning: exported function ValidateWorkflowAttributesDeleteRequest should have comment or be unexported (golint)
  • Line 110: warning: exported function ValidateListAllMatchableAttributesRequest should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/factory.go
  • Line 12: warning: exported type RepoConfig should have comment or be unexported (golint)
  • Line 15: warning: exported const POSTGRES should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported var RepositoryConfigurationName should have comment or be unexported (golint)
  • Line 39: warning: exported function GetRepository should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/execution.go
  • Line 12: warning: comment on exported type ExecutionKey should be of the form "ExecutionKey ..." (with optional leading article) (golint)
  • Line 19: warning: comment on exported type Execution should be of the form "Execution ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/mocks/mock_execution_queue_provider.go
  • Line 5: warning: exported type MockQueueConfigurationProvider should have comment or be unexported (golint)
  • Line 10: warning: exported method MockQueueConfigurationProvider.GetExecutionQueues should have comment or be unexported (golint)
  • Line 14: warning: exported method MockQueueConfigurationProvider.GetWorkflowConfigs should have comment or be unexported (golint)
  • Line 18: warning: exported function NewMockQueueConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/common/testutils/common.go
  • Line 5: warning: comment on exported function GetPluginOverridesAttributes should be of the form "GetPluginOverridesAttributes ..." (golint)

• flyteadmin/auth/authzserver/provider.go
  • Line 39: warning: exported const ClientIDClaim should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported method Provider.PublicKeys should have comment or be unexported (golint)
  • Line 57: warning: exported method Provider.KeySet should have comment or be unexported (golint)
  • Line 116: warning: exported method Provider.ValidateAccessToken should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/project.go
  • Line 9: warning: comment on exported type ProjectInterface should be of the form "ProjectInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/testutils/attributes.go
  • Line 5: warning: exported var ExecutionQueueAttributes should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/aws/serialization.go
  • Line 1: warning: package comment should be of the form "Package aws ..." (golint)
  • Line 21: warning: comment on exported type ScheduleWorkflowPayload should be of the form "ScheduleWorkflowPayload ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported type ScheduledWorkflowExecutionRequest should be of the form "ScheduledWorkflowExecutionRequest ..." (with optional leading article) (golint)
  • Line 41: warning: comment on exported function SerializeScheduleWorkflowPayload should be of the form "SerializeScheduleWorkflowPayload ..." (golint)
  • Line 58: warning: exported function DeserializeScheduleWorkflowPayload should have comment or be unexported (golint)

• flyteadmin/pkg/async/events/interfaces/node_execution.go
  • Line 9: warning: exported type NodeExecutionEventWriter should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/workflow.go
  • Line 19: warning: exported method AdminService.CreateWorkflow should have comment or be unexported (golint)
  • Line 45: warning: exported method AdminService.GetWorkflow should have comment or be unexported (golint)
  • Line 75: warning: exported method AdminService.ListWorkflowIds should have comment or be unexported (golint)
  • Line 105: warning: exported method AdminService.ListWorkflows should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/aws/interfaces/cloud_watch_event_client.go
  • Line 5: warning: comment on exported type CloudWatchEventClient should be of the form "CloudWatchEventClient ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/util/single_task_execution.go
  • Line 73: warning: exported function CreateOrGetWorkflowModel should have comment or be unexported (golint)
  • Line 164: warning: exported function CreateOrGetLaunchPlan should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/execution_validator.go
  • Line 28: warning: exported function ValidateExecutionRequest should have comment or be unexported (golint)
  • Line 73: warning: exported function CheckAndFetchInputsForExecution should have comment or be unexported (golint)
  • Line 120: warning: exported function CheckValidExecutionID should have comment or be unexported (golint)
  • Line 134: warning: exported function ValidateCreateWorkflowEventRequest should have comment or be unexported (golint)
  • Line 145: warning: exported function ValidateWorkflowExecutionIdentifier should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/project_validator.go
  • Line 24: warning: exported function ValidateProjectRegisterRequest should have comment or be unexported (golint)
  • Line 35: warning: exported function ValidateProject should have comment or be unexported (golint)
  • Line 71: warning: comment on exported function ValidateProjectAndDomain should be of the form "ValidateProjectAndDomain ..." (golint)

• flyteadmin/pkg/repositories/interfaces/resource_repo.go
  • Line 9: warning: exported type ResourceRepoInterface should have comment or be unexported (golint)
  • Line 22: warning: exported type ResourceID should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/config/migrations.go
  • Line 9: warning: exported var Migrations should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/execution_manager.go
  • Line 79: warning: exported type ExecutionManager should have comment or be unexported (golint)
  • Line 760: warning: exported method ExecutionManager.CreateExecution should have comment or be unexported (golint)
  • Line 782: warning: exported method ExecutionManager.RelaunchExecution should have comment or be unexported (golint)
  • Line 966: warning: exported method ExecutionManager.CreateWorkflowEvent should have comment or be unexported (golint)
  • Line 1041: warning: exported method ExecutionManager.GetExecution should have comment or be unexported (golint)
  • Line 1063: warning: exported method ExecutionManager.GetExecutionData should have comment or be unexported (golint)
  • Line 1133: warning: exported method ExecutionManager.ListExecutions should have comment or be unexported (golint)
  • Line 1264: warning: exported method ExecutionManager.TerminateExecution should have comment or be unexported (golint)
  • Line 1331: warning: exported function NewExecutionManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/node_execution_event.go
  • Line 11: warning: comment on exported function CreateNodeExecutionEventModel should be of the form "CreateNodeExecutionEventModel ..." (golint)

• flyteadmin/cmd/entrypoints/k8s_secret.go
  • Line 29: warning: exported const PodNamespaceEnvVar should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/auth/constants.go
  • Line 6: warning: comment on exported const CsrfFormKey should be of the form "CsrfFormKey ..." (golint)
  • Line 8: warning: exported const AuthorizationResponseCodeType should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: comment on exported const OAuth2MetadataEndpoint should be of the form "OAuth2MetadataEndpoint ..." (golint)
  • Line 18: warning: comment on exported const OIdCMetadataEndpoint should be of the form "OIdCMetadataEndpoint ..." (golint)

• flyteadmin/pkg/runtime/whitelist_provider.go
  • Line 14: warning: comment on exported type WhitelistConfigurationProvider should be of the form "WhitelistConfigurationProvider ..." (with optional leading article) (golint)
  • Line 17: warning: exported method WhitelistConfigurationProvider.GetTaskTypeWhitelist should have comment or be unexported (golint)
  • Line 22: warning: exported function NewWhitelistConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/factory.go
  • Line 22: warning: exported type WorkflowSchedulerConfig should have comment or be unexported (golint)
  • Line 28: warning: exported type WorkflowScheduler should have comment or be unexported (golint)
  • Line 59: warning: exported function NewWorkflowScheduler should have comment or be unexported (golint)

• flyteadmin/pkg/common/mocks/storage.go
  • Line 13: warning: exported type NopCloser should have comment or be unexported (golint)
  • Line 17: warning: exported method NopCloser.Close should have comment or be unexported (golint)
  • Line 19: warning: exported type TestDataStore should have comment or be unexported (golint)
  • Line 29: warning: exported method TestDataStore.Head should have comment or be unexported (golint)
  • Line 33: warning: exported method TestDataStore.ReadProtobuf should have comment or be unexported (golint)
  • Line 37: warning: exported method TestDataStore.WriteProtobuf should have comment or be unexported (golint)
  • Line 42: warning: exported method TestDataStore.GetBaseContainerFQN should have comment or be unexported (golint)
  • Line 46: warning: comment on exported method TestDataStore.ReadRaw should be of the form "ReadRaw ..." (golint)
  • Line 51: warning: comment on exported method TestDataStore.WriteRaw should be of the form "WriteRaw ..." (golint)
  • Line 57: warning: comment on exported method TestDataStore.CopyRaw should be of the form "CopyRaw ..." (golint)
  • Line 62: warning: exported method TestDataStore.ConstructReference should have comment or be unexported (golint)
  • Line 71: warning: exported function GetMockStorageClient should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/mocks/mock_configuration_provider.go
  • Line 9: warning: exported type MockConfigurationProvider should have comment or be unexported (golint)
  • Line 21: warning: exported method MockConfigurationProvider.ApplicationConfiguration should have comment or be unexported (golint)
  • Line 25: warning: exported method MockConfigurationProvider.QueueConfiguration should have comment or be unexported (golint)
  • Line 29: warning: exported method MockConfigurationProvider.ClusterConfiguration should have comment or be unexported (golint)
  • Line 33: warning: exported method MockConfigurationProvider.TaskResourceConfiguration should have comment or be unexported (golint)
  • Line 37: warning: exported method MockConfigurationProvider.WhitelistConfiguration should have comment or be unexported (golint)
  • Line 41: warning: exported method MockConfigurationProvider.RegistrationValidationConfiguration should have comment or be unexported (golint)
  • Line 45: warning: exported method MockConfigurationProvider.AddRegistrationValidationConfiguration should have comment or be unexported (golint)
  • Line 49: warning: exported method MockConfigurationProvider.ClusterResourceConfiguration should have comment or be unexported (golint)
  • Line 53: warning: exported method MockConfigurationProvider.AddClusterResourceConfiguration should have comment or be unexported (golint)
  • Line 57: warning: exported method MockConfigurationProvider.NamespaceMappingConfiguration should have comment or be unexported (golint)
  • Line 61: warning: exported method MockConfigurationProvider.AddNamespaceMappingConfiguration should have comment or be unexported (golint)
  • Line 65: warning: exported method MockConfigurationProvider.QualityOfServiceConfiguration should have comment or be unexported (golint)
  • Line 69: warning: exported method MockConfigurationProvider.AddQualityOfServiceConfiguration should have comment or be unexported (golint)
  • Line 73: warning: exported function NewMockConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/execution.go
  • Line 15: warning: exported method AdminService.CreateExecution should have comment or be unexported (golint)
  • Line 44: warning: exported method AdminService.RelaunchExecution should have comment or be unexported (golint)
  • Line 69: warning: exported method AdminService.CreateWorkflowEvent should have comment or be unexported (golint)
  • Line 95: warning: exported method AdminService.GetExecution should have comment or be unexported (golint)
  • Line 120: warning: exported method AdminService.GetExecutionData should have comment or be unexported (golint)
  • Line 145: warning: exported method AdminService.ListExecutions should have comment or be unexported (golint)
  • Line 170: warning: exported method AdminService.TerminateExecution should have comment or be unexported (golint)

• flyteadmin/pkg/data/implementations/gcp_remote_url.go
  • Line 54: warning: comment on exported type GCPRemoteURL should be of the form "GCPRemoteURL ..." (with optional leading article) (golint)
  • Line 62: warning: exported type GCPGCSObject should have comment or be unexported (golint)
  • Line 121: warning: exported method GCPRemoteURL.Get should have comment or be unexported (golint)
  • Line 171: warning: exported function NewGCPRemoteURL should have comment or be unexported (golint)

• flyteadmin/pkg/config/config.go
  • Line 10: warning: exported const SectionKey should have comment or be unexported (golint)
  • Line 14: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 26: warning: exported type ServerSecurityOptions should have comment or be unexported (golint)
  • Line 45: warning: exported type SslOptions should have comment or be unexported (golint)
  • Line 55: warning: exported function MustRegisterSubsection should have comment or be unexported (golint)
  • Line 59: warning: exported function GetConfig should have comment or be unexported (golint)
  • Line 63: warning: exported function SetConfig should have comment or be unexported (golint)
  • Line 69: warning: exported method ServerConfig.GetHostAddress should have comment or be unexported (golint)
  • Line 73: warning: exported method ServerConfig.GetGrpcHostAddress should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/implementations/processor.go
  • Line 34: warning: comment on exported type Processor should be of the form "Processor ..." (with optional leading article) (golint)
  • Line 41: warning: comment on exported method Processor.StartProcessing should be of the form "StartProcessing ..." (golint)
  • Line 139: warning: exported method Processor.StopProcessing should have comment or be unexported (golint)
  • Line 166: warning: exported function NewProcessor should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/project.go
  • Line 9: warning: exported type CreateProjectModelInput should have comment or be unexported (golint)
  • Line 15: warning: exported function CreateProjectModel should have comment or be unexported (golint)
  • Line 30: warning: exported function FromProjectModel should have comment or be unexported (golint)
  • Line 47: warning: exported function FromProjectModels should have comment or be unexported (golint)

• flyteadmin/pkg/common/namespace.go
  • Line 5: warning: exported type NamespaceMapping should have comment or be unexported (golint)
  • Line 10: warning: exported const NamespaceMappingProjectDomain should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/pkg/manager/impl/task_execution_manager.go
  • Line 49: warning: exported type TaskExecutionManager should have comment or be unexported (golint)
  • Line 123: warning: exported method TaskExecutionManager.CreateTaskExecutionEvent should have comment or be unexported (golint)
  • Line 198: warning: exported method TaskExecutionManager.GetTaskExecution should have comment or be unexported (golint)
  • Line 218: warning: exported method TaskExecutionManager.ListTaskExecutions should have comment or be unexported (golint)
  • Line 276: warning: exported method TaskExecutionManager.GetTaskExecutionData should have comment or be unexported (golint)
  • Line 330: warning: exported function NewTaskExecutionManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/named_entity.go
  • Line 7: warning: comment on exported type NamedEntityMetadataKey should be of the form "NamedEntityMetadataKey ..." (with optional leading article) (golint)
  • Line 15: warning: comment on exported type NamedEntityMetadataFields should be of the form "NamedEntityMetadataFields ..." (with optional leading article) (golint)
  • Line 22: warning: comment on exported type NamedEntityMetadata should be of the form "NamedEntityMetadata ..." (with optional leading article) (golint)
  • Line 29: warning: comment on exported type NamedEntityKey should be of the form "NamedEntityKey ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported type NamedEntity should be of the form "NamedEntity ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/interfaces/cluster_configuration.go
  • Line 9: warning: comment on exported type ClusterConfig should be of the form "ClusterConfig ..." (with optional leading article) (golint)
  • Line 17: warning: exported type Auth should have comment or be unexported (golint)
  • Line 23: warning: exported type ClusterEntity should have comment or be unexported (golint)
  • Line 28: warning: exported method Auth.GetCA should have comment or be unexported (golint)
  • Line 36: warning: exported method Auth.GetToken should have comment or be unexported (golint)
  • Line 44: warning: exported type Clusters should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type ClusterConfiguration should be of the form "ClusterConfiguration ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/gormimpl/node_execution_repo.go
  • Line 17: warning: comment on exported type NodeExecutionRepo should be of the form "NodeExecutionRepo ..." (with optional leading article) (golint)
  • Line 24: warning: exported method NodeExecutionRepo.Create should have comment or be unexported (golint)
  • Line 34: warning: exported method NodeExecutionRepo.Get should have comment or be unexported (golint)
  • Line 65: warning: exported method NodeExecutionRepo.Update should have comment or be unexported (golint)
  • Line 75: warning: exported method NodeExecutionRepo.List should have comment or be unexported (golint)
  • Line 111: warning: exported method NodeExecutionRepo.ListEvents should have comment or be unexported (golint)
  • Line 145: warning: exported method NodeExecutionRepo.Exists should have comment or be unexported (golint)
  • Line 165: warning: comment on exported function NewNodeExecutionRepo should be of the form "NewNodeExecutionRepo ..." (golint)

• flyteadmin/pkg/async/notifications/implementations/noop_notifications.go
  • Line 16: warning: comment on exported type NoopEmail should be of the form "NoopEmail ..." (with optional leading article) (golint)
  • Line 19: warning: exported method NoopEmail.SendEmail should have comment or be unexported (golint)
  • Line 25: warning: exported function NewNoopEmail should have comment or be unexported (golint)
  • Line 29: warning: exported type NoopPublish should have comment or be unexported (golint)
  • Line 31: warning: exported method NoopPublish.Publish should have comment or be unexported (golint)
  • Line 36: warning: exported function NewNoopPublish should have comment or be unexported (golint)
  • Line 40: warning: exported type NoopProcess should have comment or be unexported (golint)
  • Line 42: warning: exported method NoopProcess.StartProcessing should have comment or be unexported (golint)
  • Line 46: warning: exported method NoopProcess.StopProcessing should have comment or be unexported (golint)
  • Line 51: warning: exported function NewNoopProcess should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/workflow.go
  • Line 3: warning: comment on exported type WorkflowKey should be of the form "WorkflowKey ..." (with optional leading article) (golint)
  • Line 11: warning: comment on exported type Workflow should be of the form "Workflow ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/configuration_provider.go
  • Line 7: warning: comment on exported type ConfigurationProvider should be of the form "ConfigurationProvider ..." (with optional leading article) (golint)
  • Line 20: warning: exported method ConfigurationProvider.ApplicationConfiguration should have comment or be unexported (golint)
  • Line 24: warning: exported method ConfigurationProvider.QueueConfiguration should have comment or be unexported (golint)
  • Line 28: warning: exported method ConfigurationProvider.ClusterConfiguration should have comment or be unexported (golint)
  • Line 32: warning: exported method ConfigurationProvider.TaskResourceConfiguration should have comment or be unexported (golint)
  • Line 36: warning: exported method ConfigurationProvider.WhitelistConfiguration should have comment or be unexported (golint)
  • Line 40: warning: exported method ConfigurationProvider.RegistrationValidationConfiguration should have comment or be unexported (golint)
  • Line 44: warning: exported method ConfigurationProvider.ClusterResourceConfiguration should have comment or be unexported (golint)
  • Line 48: warning: exported method ConfigurationProvider.NamespaceMappingConfiguration should have comment or be unexported (golint)
  • Line 52: warning: exported method ConfigurationProvider.QualityOfServiceConfiguration should have comment or be unexported (golint)
  • Line 56: warning: exported function NewConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/execution_event.go
  • Line 11: warning: comment on exported function CreateExecutionEventModel should be of the form "CreateExecutionEventModel ..." (golint)

• flyteadmin/pkg/errors/errors.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 15: warning: exported type FlyteAdminError should have comment or be unexported (golint)
  • Line 53: warning: exported function NewFlyteAdminErrorFromStatus should have comment or be unexported (golint)
  • Line 59: warning: exported function NewFlyteAdminError should have comment or be unexported (golint)
  • Line 65: warning: exported function NewFlyteAdminErrorf should have comment or be unexported (golint)
  • Line 77: warning: exported function NewCollectedFlyteAdminError should have comment or be unexported (golint)
  • Line 81: warning: exported function NewAlreadyInTerminalStateError should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/registration_validation_provider.go
  • Line 3: warning: exported type RegistrationValidationConfig should have comment or be unexported (golint)
  • Line 10: warning: comment on exported type RegistrationValidationConfiguration should be of the form "RegistrationValidationConfiguration ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/util/shared.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 23: warning: exported function GetExecutionName should have comment or be unexported (golint)
  • Line 30: warning: exported function GetTask should have comment or be unexported (golint)
  • Line 45: warning: exported function GetWorkflowModel should have comment or be unexported (golint)
  • Line 59: warning: exported function FetchAndGetWorkflowClosure should have comment or be unexported (golint)
  • Line 72: warning: exported function GetWorkflow should have comment or be unexported (golint)
  • Line 94: warning: exported function GetLaunchPlanModel should have comment or be unexported (golint)
  • Line 108: warning: exported function GetLaunchPlan should have comment or be unexported (golint)
  • Line 117: warning: exported function GetNamedEntityModel should have comment or be unexported (golint)
  • Line 131: warning: exported function GetNamedEntity should have comment or be unexported (golint)
  • Line 141: warning: comment on exported function GetActiveLaunchPlanVersionFilters should be of the form "GetActiveLaunchPlanVersionFilters ..." (golint)
  • Line 162: warning: comment on exported function ListActiveLaunchPlanVersionsFilters should be of the form "ListActiveLaunchPlanVersionsFilters ..." (golint)
  • Line 179: warning: exported function GetExecutionModel should have comment or be unexported (golint)
  • Line 193: warning: exported function GetNodeExecutionModel should have comment or be unexported (golint)
  • Line 205: warning: exported function GetTaskModel should have comment or be unexported (golint)
  • Line 221: warning: exported function GetTaskExecutionModel should have comment or be unexported (golint)

• flyteadmin/pkg/common/cloud.go
  • Line 5: warning: exported type CloudProvider should have comment or be unexported (golint)
  • Line 8: warning: exported const AWS should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/pkg/manager/impl/project_manager.go
  • Line 20: warning: exported type ProjectManager should have comment or be unexported (golint)
  • Line 30: warning: exported method ProjectManager.CreateProject should have comment or be unexported (golint)
  • Line 56: warning: exported method ProjectManager.ListProjects should have comment or be unexported (golint)
  • Line 105: warning: exported method ProjectManager.UpdateProject should have comment or be unexported (golint)
  • Line 131: warning: exported function NewProjectManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/node_execution_event.go
  • Line 7: warning: exported type NodeExecutionEvent should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/mocks/execution_repo.go
  • Line 10: warning: exported type CreateExecutionFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type UpdateExecutionFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type GetExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListExecutionFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type MockExecutionRepo should have comment or be unexported (golint)
  • Line 24: warning: exported method MockExecutionRepo.Create should have comment or be unexported (golint)
  • Line 31: warning: exported method MockExecutionRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 35: warning: exported method MockExecutionRepo.SetUpdateCallback should have comment or be unexported (golint)
  • Line 39: warning: exported method MockExecutionRepo.Update should have comment or be unexported (golint)
  • Line 46: warning: exported method MockExecutionRepo.SetUpdateExecutionCallback should have comment or be unexported (golint)
  • Line 50: warning: exported method MockExecutionRepo.Get should have comment or be unexported (golint)
  • Line 57: warning: exported method MockExecutionRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 61: warning: exported method MockExecutionRepo.List should have comment or be unexported (golint)
  • Line 69: warning: exported method MockExecutionRepo.SetListCallback should have comment or be unexported (golint)
  • Line 73: warning: exported method MockExecutionRepo.Exists should have comment or be unexported (golint)
  • Line 80: warning: exported function NewMockExecutionRepo should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/config/database.go
  • Line 3: warning: comment on exported type DbConfig should be of the form "DbConfig ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/interfaces/version.go
  • Line 11: warning: comment on exported type VersionInterface should be of the form "VersionInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/shared/errors.go
  • Line 1: warning: package comment should be of the form "Package shared ..." (golint)
  • Line 15: warning: exported function GetMissingArgumentError should have comment or be unexported (golint)
  • Line 19: warning: exported function GetInvalidArgumentError should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/node_execution.go
  • Line 9: warning: exported type CreateNodeEventFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type GetNodeExecutionFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type ListNodeExecutionsFunc should have comment or be unexported (golint)
  • Line 14: warning: exported type ListNodeExecutionsForTaskFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type GetNodeExecutionDataFunc should have comment or be unexported (golint)
  • Line 19: warning: exported type MockNodeExecutionManager should have comment or be unexported (golint)
  • Line 27: warning: exported method MockNodeExecutionManager.SetCreateNodeEventCallback should have comment or be unexported (golint)
  • Line 31: warning: exported method MockNodeExecutionManager.CreateNodeEvent should have comment or be unexported (golint)
  • Line 40: warning: exported method MockNodeExecutionManager.SetGetNodeExecutionFunc should have comment or be unexported (golint)
  • Line 44: warning: exported method MockNodeExecutionManager.GetNodeExecution should have comment or be unexported (golint)
  • Line 52: warning: exported method MockNodeExecutionManager.SetListNodeExecutionsFunc should have comment or be unexported (golint)
  • Line 56: warning: exported method MockNodeExecutionManager.ListNodeExecutions should have comment or be unexported (golint)
  • Line 64: warning: exported method MockNodeExecutionManager.SetListNodeExecutionsForTaskFunc should have comment or be unexported (golint)
  • Line 68: warning: exported method MockNodeExecutionManager.ListNodeExecutionsForTask should have comment or be unexported (golint)
  • Line 76: warning: exported method MockNodeExecutionManager.SetGetNodeExecutionDataFunc should have comment or be unexported (golint)
  • Line 80: warning: exported method MockNodeExecutionManager.GetNodeExecutionData should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/launch_plan_repo.go
  • Line 23: warning: comment on exported type LaunchPlanRepo should be of the form "LaunchPlanRepo ..." (with optional leading article) (golint)
  • Line 31: warning: exported method LaunchPlanRepo.Create should have comment or be unexported (golint)
  • Line 41: warning: exported method LaunchPlanRepo.Update should have comment or be unexported (golint)
  • Line 51: warning: exported method LaunchPlanRepo.Get should have comment or be unexported (golint)
  • Line 78: warning: comment on exported method LaunchPlanRepo.SetActive should be of the form "SetActive ..." (golint)
  • Line 109: warning: exported method LaunchPlanRepo.List should have comment or be unexported (golint)
  • Line 145: warning: exported method LaunchPlanRepo.ListLaunchPlanIdentifiers should have comment or be unexported (golint)
  • Line 180: warning: comment on exported function NewLaunchPlanRepo should be of the form "NewLaunchPlanRepo ..." (golint)

• flyteadmin/pkg/repositories/gormimpl/execution_event_repo.go
  • Line 13: warning: exported type ExecutionEventRepo should have comment or be unexported (golint)
  • Line 19: warning: exported method ExecutionEventRepo.Create should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function NewExecutionEventRepo should be of the form "NewExecutionEventRepo ..." (golint)

• flyteadmin/pkg/async/notifications/implementations/event_publisher.go
  • Line 26: warning: comment on exported type EventPublisher should be of the form "EventPublisher ..." (with optional leading article) (golint)
  • Line 38: warning: exported const Task should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: comment on exported method EventPublisher.Publish should be of the form "Publish ..." (golint)
  • Line 83: warning: exported function NewEventsPublisher should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/mocks/emailer.go
  • Line 8: warning: exported type AwsSendEmailFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type SESClient should have comment or be unexported (golint)
  • Line 15: warning: exported method SESClient.SetSendEmailFunc should have comment or be unexported (golint)
  • Line 19: warning: exported method SESClient.SendEmail should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/mocks/mock_workflow_executor.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 4: warning: exported type MockWorkflowExecutor should have comment or be unexported (golint)
  • Line 9: warning: exported method MockWorkflowExecutor.SetRunFunc should have comment or be unexported (golint)
  • Line 13: warning: exported method MockWorkflowExecutor.Run should have comment or be unexported (golint)
  • Line 19: warning: exported method MockWorkflowExecutor.SetStopFunc should have comment or be unexported (golint)
  • Line 23: warning: exported method MockWorkflowExecutor.Stop should have comment or be unexported (golint)

• flyteadmin/pkg/server/cert_utils.go
  • Line 15: warning: exported const ErrCertificate should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported function GetSslCredentials should have comment or be unexported (golint)

• flyteadmin/pkg/workflowengine/impl/interface_provider.go
  • Line 18: warning: exported type InterfaceProvider should have comment or be unexported (golint)
  • Line 20: warning: exported type LaunchPlanInterfaceProvider should have comment or be unexported (golint)
  • Line 26: warning: exported method LaunchPlanInterfaceProvider.GetID should have comment or be unexported (golint)
  • Line 29: warning: exported method LaunchPlanInterfaceProvider.GetExpectedInputs should have comment or be unexported (golint)
  • Line 33: warning: exported method LaunchPlanInterfaceProvider.GetExpectedOutputs should have comment or be unexported (golint)
  • Line 37: warning: exported function NewLaunchPlanInterfaceProvider should have comment or be unexported (golint)

• flyteadmin/auth/token.go
  • Line 25: warning: exported const ErrRefreshingToken should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: comment on exported function GetRefreshedToken should be of the form "GetRefreshedToken ..." (golint)
  • Line 49: warning: exported function ParseIDTokenAndValidate should have comment or be unexported (golint)
  • Line 126: warning: exported function IdentityContextFromIDTokenToken should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/testutils/mock_requests.go
  • Line 10: warning: exported function GetValidTaskRequest should have comment or be unexported (golint)
  • Line 41: warning: exported function GetValidTaskRequestWithOverrides should have comment or be unexported (golint)
  • Line 72: warning: exported function GetValidTaskSpecBytes should have comment or be unexported (golint)
  • Line 77: warning: exported function GetWorkflowRequest should have comment or be unexported (golint)
  • Line 119: warning: exported function GetLaunchPlanRequest should have comment or be unexported (golint)
  • Line 157: warning: exported function GetLaunchPlanRequestWithCronSchedule should have comment or be unexported (golint)
  • Line 168: warning: exported function GetLaunchPlanRequestWithFixedRateSchedule should have comment or be unexported (golint)
  • Line 183: warning: exported function GetExecutionRequest should have comment or be unexported (golint)
  • Line 223: warning: exported function GetSampleWorkflowSpecForTest should have comment or be unexported (golint)
  • Line 242: warning: exported function GetSampleLpSpecForTest should have comment or be unexported (golint)
  • Line 287: warning: exported function GetWorkflowRequestInterfaceBytes should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/configuration.go
  • Line 3: warning: comment on exported type Configuration should be of the form "Configuration ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/application_config_provider.go
  • Line 75: warning: comment on exported type ApplicationConfigurationProvider should be of the form "ApplicationConfigurationProvider ..." (with optional leading article) (golint)
  • Line 78: warning: exported method ApplicationConfigurationProvider.GetDbConfig should have comment or be unexported (golint)
  • Line 104: warning: exported method ApplicationConfigurationProvider.GetTopLevelConfig should have comment or be unexported (golint)
  • Line 108: warning: exported method ApplicationConfigurationProvider.GetSchedulerConfig should have comment or be unexported (golint)
  • Line 112: warning: exported method ApplicationConfigurationProvider.GetRemoteDataConfig should have comment or be unexported (golint)
  • Line 116: warning: exported method ApplicationConfigurationProvider.GetNotificationsConfig should have comment or be unexported (golint)
  • Line 120: warning: exported method ApplicationConfigurationProvider.GetDomainsConfig should have comment or be unexported (golint)
  • Line 124: warning: exported method ApplicationConfigurationProvider.GetExternalEventsConfig should have comment or be unexported (golint)
  • Line 128: warning: exported function NewApplicationConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/async/events/implementations/workflow_execution_event_writer.go
  • Line 40: warning: exported function NewWorkflowExecutionEventWriter should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/shared/constants.go
  • Line 1: warning: package comment should be of the form "Package shared ..." (golint)

• flyteadmin/pkg/repositories/models/project.go
  • Line 3: warning: exported type Project should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/implementations/aws_emailer.go
  • Line 17: warning: exported type AwsEmailer should have comment or be unexported (golint)
  • Line 23: warning: exported function FlyteEmailToSesEmailInput should have comment or be unexported (golint)
  • Line 53: warning: exported method AwsEmailer.SendEmail should have comment or be unexported (golint)
  • Line 68: warning: exported function NewAwsEmailer should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/launch_plan_manager.go
  • Line 42: warning: exported type LaunchPlanManager should have comment or be unexported (golint)
  • Line 59: warning: exported method LaunchPlanManager.CreateLaunchPlan should have comment or be unexported (golint)
  • Line 343: warning: exported method LaunchPlanManager.UpdateLaunchPlan should have comment or be unexported (golint)
  • Line 361: warning: exported method LaunchPlanManager.GetLaunchPlan should have comment or be unexported (golint)
  • Line 371: warning: exported method LaunchPlanManager.GetActiveLaunchPlan should have comment or be unexported (golint)
  • Line 403: warning: exported method LaunchPlanManager.ListLaunchPlans should have comment or be unexported (golint)
  • Line 463: warning: exported method LaunchPlanManager.ListActiveLaunchPlans should have comment or be unexported (golint)
  • Line 518: warning: comment on exported method LaunchPlanManager.ListLaunchPlanIds should be of the form "ListLaunchPlanIds ..." (golint)
  • Line 563: warning: exported function NewLaunchPlanManager should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/task_execution.go
  • Line 9: warning: exported type CreateTaskExecutionEventFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type GetTaskExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListTaskExecutionsFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type GetTaskExecutionDataFunc should have comment or be unexported (golint)
  • Line 18: warning: exported type MockTaskExecutionManager should have comment or be unexported (golint)
  • Line 25: warning: exported method MockTaskExecutionManager.CreateTaskExecutionEvent should have comment or be unexported (golint)
  • Line 33: warning: exported method MockTaskExecutionManager.SetCreateTaskEventCallback should have comment or be unexported (golint)
  • Line 38: warning: exported method MockTaskExecutionManager.GetTaskExecution should have comment or be unexported (golint)
  • Line 46: warning: exported method MockTaskExecutionManager.SetGetTaskExecutionCallback should have comment or be unexported (golint)
  • Line 51: warning: exported method MockTaskExecutionManager.ListTaskExecutions should have comment or be unexported (golint)
  • Line 59: warning: exported method MockTaskExecutionManager.SetListTaskExecutionsCallback should have comment or be unexported (golint)
  • Line 64: warning: exported method MockTaskExecutionManager.GetTaskExecutionData should have comment or be unexported (golint)
  • Line 72: warning: exported method MockTaskExecutionManager.SetGetTaskExecutionDataCallback should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/launch_plan.go
  • Line 18: warning: exported method AdminService.CreateLaunchPlan should have comment or be unexported (golint)
  • Line 43: warning: exported method AdminService.GetLaunchPlan should have comment or be unexported (golint)
  • Line 74: warning: exported method AdminService.GetActiveLaunchPlan should have comment or be unexported (golint)
  • Line 98: warning: exported method AdminService.UpdateLaunchPlan should have comment or be unexported (golint)
  • Line 129: warning: exported method AdminService.ListLaunchPlans should have comment or be unexported (golint)
  • Line 155: warning: exported method AdminService.ListActiveLaunchPlans should have comment or be unexported (golint)
  • Line 184: warning: exported method AdminService.ListLaunchPlanIds should have comment or be unexported (golint)

• flyteadmin/pkg/workflowengine/impl/compiler.go
  • Line 44: warning: exported function NewCompiler should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/task_execution_repo.go
  • Line 10: warning: comment on exported type TaskExecutionRepoInterface should be of the form "TaskExecutionRepoInterface ..." (with optional leading article) (golint)
  • Line 22: warning: exported type GetTaskExecutionInput should have comment or be unexported (golint)
  • Line 26: warning: comment on exported type TaskExecutionCollectionOutput should be of the form "TaskExecutionCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/interfaces/queue_configuration.go
  • Line 3: warning: comment on exported type ExecutionQueue should be of the form "ExecutionQueue ..." (with optional leading article) (golint)
  • Line 10: warning: exported method ExecutionQueue.GetAttributes should have comment or be unexported (golint)
  • Line 14: warning: exported type ExecutionQueues should have comment or be unexported (golint)
  • Line 16: warning: comment on exported type WorkflowConfig should be of the form "WorkflowConfig ..." (with optional leading article) (golint)
  • Line 22: warning: exported type WorkflowConfigs should have comment or be unexported (golint)
  • Line 24: warning: exported type QueueConfig should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type QueueConfiguration should be of the form "QueueConfiguration ..." (with optional leading article) (golint)

• flyteadmin/pkg/rpc/adminservice/tests/util.go
  • Line 9: warning: exported type NewMockAdminServerInput should have comment or be unexported (golint)
  • Line 20: warning: exported function NewMockAdminServer should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/email.go
  • Line 12: warning: exported type GetTemplateValue should have comment or be unexported (golint)
  • Line 112: warning: comment on exported function ToEmailMessageFromWorkflowExecutionEvent should be of the form "ToEmailMessageFromWorkflowExecutionEvent ..." (golint)

• flyteadmin/auth/auth_context.go
  • Line 1: warning: package comment should be of the form "Package auth ..." (golint)
  • Line 25: warning: exported const IdpConnectionTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: comment on exported type Context should be of the form "Context ..." (with optional leading article) (golint)
  • Line 53: warning: exported method Context.OAuth2Provider should have comment or be unexported (golint)
  • Line 57: warning: exported method Context.OAuth2ClientConfig should have comment or be unexported (golint)
  • Line 71: warning: exported method Context.OidcProvider should have comment or be unexported (golint)
  • Line 75: warning: exported method Context.CookieManager should have comment or be unexported (golint)
  • Line 79: warning: exported method Context.Options should have comment or be unexported (golint)
  • Line 83: warning: exported method Context.GetUserInfoURL should have comment or be unexported (golint)
  • Line 87: warning: exported method Context.GetHTTPClient should have comment or be unexported (golint)
  • Line 91: warning: exported method Context.GetOAuth2MetadataURL should have comment or be unexported (golint)
  • Line 95: warning: exported method Context.GetOIdCMetadataURL should have comment or be unexported (golint)
  • Line 99: warning: exported method Context.AuthMetadataService should have comment or be unexported (golint)
  • Line 103: warning: exported method Context.IdentityService should have comment or be unexported (golint)
  • Line 107: warning: exported method Context.OAuth2ResourceServer should have comment or be unexported (golint)
  • Line 110: warning: exported function NewAuthenticationContext should have comment or be unexported (golint)
  • Line 186: warning: comment on exported function GetOAuth2ClientConfig should be of the form "GetOAuth2ClientConfig ..." (golint)

• flyteadmin/pkg/manager/impl/resources/resource_manager.go
  • Line 26: warning: exported type ResourceManager should have comment or be unexported (golint)
  • Line 31: warning: exported method ResourceManager.GetResource should have comment or be unexported (golint)
  • Line 94: warning: exported method ResourceManager.UpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 118: warning: exported method ResourceManager.GetWorkflowAttributes should have comment or be unexported (golint)
  • Line 138: warning: exported method ResourceManager.DeleteWorkflowAttributes should have comment or be unexported (golint)
  • Line 187: warning: exported method ResourceManager.UpdateProjectDomainAttributes should have comment or be unexported (golint)
  • Line 211: warning: exported method ResourceManager.GetProjectDomainAttributes should have comment or be unexported (golint)
  • Line 231: warning: exported method ResourceManager.DeleteProjectDomainAttributes should have comment or be unexported (golint)
  • Line 245: warning: exported method ResourceManager.ListAll should have comment or be unexported (golint)
  • Line 267: warning: exported function NewResourceManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/workflow_repo.go
  • Line 16: warning: comment on exported type WorkflowRepo should be of the form "WorkflowRepo ..." (with optional leading article) (golint)
  • Line 23: warning: exported method WorkflowRepo.Create should have comment or be unexported (golint)
  • Line 33: warning: exported method WorkflowRepo.Get should have comment or be unexported (golint)
  • Line 59: warning: exported method WorkflowRepo.List should have comment or be unexported (golint)
  • Line 88: warning: exported method WorkflowRepo.ListIdentifiers should have comment or be unexported (golint)
  • Line 123: warning: comment on exported function NewWorkflowRepo should be of the form "NewWorkflowRepo ..." (golint)

• flyteadmin/pkg/rpc/adminservice/metrics.go
  • Line 1: warning: package comment should be of the form "Package adminservice ..." (golint)
  • Line 96: warning: exported type AdminMetrics should have comment or be unexported (golint)
  • Line 114: warning: exported function InitMetrics should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/execution_repo.go
  • Line 18: warning: comment on exported type ExecutionRepo should be of the form "ExecutionRepo ..." (with optional leading article) (golint)
  • Line 25: warning: exported method ExecutionRepo.Create should have comment or be unexported (golint)
  • Line 35: warning: exported method ExecutionRepo.Get should have comment or be unexported (golint)
  • Line 59: warning: exported method ExecutionRepo.Update should have comment or be unexported (golint)
  • Line 69: warning: exported method ExecutionRepo.List should have comment or be unexported (golint)
  • Line 113: warning: exported method ExecutionRepo.Exists should have comment or be unexported (golint)
  • Line 131: warning: comment on exported function NewExecutionRepo should be of the form "NewExecutionRepo ..." (golint)

• flyteadmin/auth/authzserver/metadata_provider.go
  • Line 17: warning: exported type OAuth2MetadataProvider should have comment or be unexported (golint)
  • Line 21: warning: comment on exported method OAuth2MetadataProvider.AuthFuncOverride should be of the form "AuthFuncOverride ..." (golint)
  • Line 27: warning: exported method OAuth2MetadataProvider.GetOAuth2Metadata should have comment or be unexported (golint)
  • Line 87: warning: exported method OAuth2MetadataProvider.GetPublicClientConfig should have comment or be unexported (golint)
  • Line 96: warning: exported function NewService should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/config/migration_models.go
  • Line 15: warning: exported type TaskKey should have comment or be unexported (golint)
  • Line 22: warning: exported type ExecutionKey should have comment or be unexported (golint)
  • Line 28: warning: exported type NodeExecutionKey should have comment or be unexported (golint)
  • Line 33: warning: exported type NodeExecution should have comment or be unexported (golint)
  • Line 57: warning: exported type TaskExecutionKey should have comment or be unexported (golint)
  • Line 68: warning: exported type TaskExecution should have comment or be unexported (golint)

• flyteadmin/pkg/manager/mocks/resource.go
  • Line 11: warning: exported type UpdateProjectDomainFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type GetProjectDomainFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type DeleteProjectDomainFunc should have comment or be unexported (golint)
  • Line 17: warning: exported type ListResourceFunc should have comment or be unexported (golint)
  • Line 19: warning: exported type GetResourceFunc should have comment or be unexported (golint)
  • Line 21: warning: exported type MockResourceManager should have comment or be unexported (golint)
  • Line 29: warning: exported method MockResourceManager.GetResource should have comment or be unexported (golint)
  • Line 36: warning: exported method MockResourceManager.UpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 41: warning: exported method MockResourceManager.GetWorkflowAttributes should have comment or be unexported (golint)
  • Line 46: warning: exported method MockResourceManager.DeleteWorkflowAttributes should have comment or be unexported (golint)
  • Line 51: warning: exported method MockResourceManager.SetUpdateProjectDomainAttributes should have comment or be unexported (golint)
  • Line 55: warning: exported method MockResourceManager.UpdateProjectDomainAttributes should have comment or be unexported (golint)
  • Line 64: warning: exported method MockResourceManager.GetProjectDomainAttributes should have comment or be unexported (golint)
  • Line 73: warning: exported method MockResourceManager.DeleteProjectDomainAttributes should have comment or be unexported (golint)
  • Line 82: warning: exported method MockResourceManager.ListAll should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/execution_queue_provider.go
  • Line 16: warning: comment on exported type QueueConfigurationProvider should be of the form "QueueConfigurationProvider ..." (with optional leading article) (golint)
  • Line 19: warning: exported method QueueConfigurationProvider.GetExecutionQueues should have comment or be unexported (golint)
  • Line 23: warning: exported method QueueConfigurationProvider.GetWorkflowConfigs should have comment or be unexported (golint)
  • Line 27: warning: exported function NewQueueConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/base.go
  • Line 31: warning: exported type AdminService should have comment or be unexported (golint)
  • Line 59: warning: exported function NewAdminServer should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/execution_target.go
  • Line 12: warning: comment on exported type ExecutionTargetSpec should be of the form "ExecutionTargetSpec ..." (with optional leading article) (golint)
  • Line 22: warning: comment on exported type ExecutionTarget should be of the form "ExecutionTarget ..." (with optional leading article) (golint)
  • Line 32: warning: exported method ExecutionTarget.Compare should have comment or be unexported (golint)

• flyteadmin/pkg/data/factory.go
  • Line 20: warning: exported type RemoteDataHandlerConfig should have comment or be unexported (golint)
  • Line 29: warning: exported type RemoteDataHandler should have comment or be unexported (golint)
  • Line 41: warning: exported function GetRemoteDataHandler should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/implementations/publisher.go
  • Line 21: warning: comment on exported type Publisher should be of the form "Publisher ..." (with optional leading article) (golint)
  • Line 27: warning: comment on exported method Publisher.Publish should be of the form "Publish ..." (golint)
  • Line 47: warning: exported function NewPublisher should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/models/launch_plan.go
  • Line 3: warning: comment on exported type LaunchPlanKey should be of the form "LaunchPlanKey ..." (with optional leading article) (golint)
  • Line 11: warning: exported type LaunchPlanScheduleType should have comment or be unexported (golint)
  • Line 22: warning: comment on exported type LaunchPlan should be of the form "LaunchPlan ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/mocks/launch_plan_repo.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 11: warning: exported type CreateLaunchPlanFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type UpdateLaunchPlanFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type SetActiveLaunchPlanFunc should have comment or be unexported (golint)
  • Line 14: warning: exported type GetLaunchPlanFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type ListLaunchPlanFunc should have comment or be unexported (golint)
  • Line 16: warning: exported type ListLaunchPlanIdentifiersFunc should have comment or be unexported (golint)
  • Line 19: warning: exported type MockLaunchPlanRepo should have comment or be unexported (golint)
  • Line 28: warning: exported method MockLaunchPlanRepo.Create should have comment or be unexported (golint)
  • Line 35: warning: exported method MockLaunchPlanRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 39: warning: exported method MockLaunchPlanRepo.Update should have comment or be unexported (golint)
  • Line 46: warning: exported method MockLaunchPlanRepo.SetUpdateCallback should have comment or be unexported (golint)
  • Line 50: warning: exported method MockLaunchPlanRepo.SetActive should have comment or be unexported (golint)
  • Line 58: warning: exported method MockLaunchPlanRepo.SetSetActiveCallback should have comment or be unexported (golint)
  • Line 62: warning: exported method MockLaunchPlanRepo.Get should have comment or be unexported (golint)
  • Line 77: warning: exported method MockLaunchPlanRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 81: warning: exported method MockLaunchPlanRepo.List should have comment or be unexported (golint)
  • Line 89: warning: exported method MockLaunchPlanRepo.SetListCallback should have comment or be unexported (golint)
  • Line 93: warning: exported method MockLaunchPlanRepo.ListLaunchPlanIdentifiers should have comment or be unexported (golint)
  • Line 101: warning: exported method MockLaunchPlanRepo.SetListLaunchPlanIdentifiersCallback should have comment or be unexported (golint)
  • Line 105: warning: exported function NewMockLaunchPlanRepo should have comment or be unexported (golint)

• flyteadmin/pkg/workflowengine/mocks/mock_compiler.go
  • Line 10: warning: exported type MockCompiler should have comment or be unexported (golint)
  • Line 19: warning: exported method MockCompiler.CompileTask should have comment or be unexported (golint)
  • Line 26: warning: exported method MockCompiler.AddCompileTaskCallback should have comment or be unexported (golint)
  • Line 31: warning: exported method MockCompiler.GetRequirements should have comment or be unexported (golint)
  • Line 39: warning: exported method MockCompiler.AddGetRequirementCallback should have comment or be unexported (golint)
  • Line 45: warning: exported method MockCompiler.CompileWorkflow should have comment or be unexported (golint)
  • Line 54: warning: exported method MockCompiler.AddCompileWorkflowCallback should have comment or be unexported (golint)
  • Line 60: warning: exported function NewMockCompiler should have comment or be unexported (golint)

• flyteadmin/pkg/common/sorting.go
  • Line 14: warning: exported type SortParameter should have comment or be unexported (golint)
  • Line 26: warning: exported function NewSortParameter should have comment or be unexported (golint)

• flyteadmin/auth/identity_context.go
  • Line 30: warning: exported method IdentityContext.Audience should have comment or be unexported (golint)
  • Line 34: warning: exported method IdentityContext.UserID should have comment or be unexported (golint)
  • Line 38: warning: exported method IdentityContext.AppID should have comment or be unexported (golint)
  • Line 42: warning: exported method IdentityContext.UserInfo should have comment or be unexported (golint)
  • Line 50: warning: exported method IdentityContext.IsEmpty should have comment or be unexported (golint)
  • Line 54: warning: exported method IdentityContext.Scopes should have comment or be unexported (golint)
  • Line 62: warning: exported method IdentityContext.WithContext should have comment or be unexported (golint)
  • Line 66: warning: exported method IdentityContext.AuthenticatedAt should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/executions/queues.go
  • Line 30: warning: exported type QueueAllocator should have comment or be unexported (golint)
  • Line 112: warning: exported function NewQueueAllocator should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/application_configuration.go
  • Line 3: warning: comment on exported type DbConfigSection should be of the form "DbConfigSection ..." (with optional leading article) (golint)
  • Line 25: warning: comment on exported type DbConfig should be of the form "DbConfig ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported type ApplicationConfig should be of the form "ApplicationConfig ..." (with optional leading article) (golint)
  • Line 57: warning: comment on exported type AWSConfig should be of the form "AWSConfig ..." (with optional leading article) (golint)
  • Line 62: warning: comment on exported type GCPConfig should be of the form "GCPConfig ..." (with optional leading article) (golint)
  • Line 67: warning: comment on exported type EventSchedulerConfig should be of the form "EventSchedulerConfig ..." (with optional leading article) (golint)
  • Line 82: warning: comment on exported type WorkflowExecutorConfig should be of the form "WorkflowExecutorConfig ..." (with optional leading article) (golint)
  • Line 96: warning: comment on exported type SchedulerConfig should be of the form "SchedulerConfig ..." (with optional leading article) (golint)
  • Line 106: warning: comment on exported type SignedURL should be of the form "SignedURL ..." (with optional leading article) (golint)
  • Line 114: warning: comment on exported type RemoteDataConfig should be of the form "RemoteDataConfig ..." (with optional leading article) (golint)
  • Line 126: warning: comment on exported type NotificationsPublisherConfig should be of the form "NotificationsPublisherConfig ..." (with optional leading article) (golint)
  • Line 132: warning: comment on exported type NotificationsProcessorConfig should be of the form "NotificationsProcessorConfig ..." (with optional leading article) (golint)
  • Line 141: warning: exported type EmailServerConfig should have comment or be unexported (golint)
  • Line 148: warning: comment on exported type NotificationsEmailerConfig should be of the form "NotificationsEmailerConfig ..." (with optional leading article) (golint)
  • Line 160: warning: comment on exported type EventsPublisherConfig should be of the form "EventsPublisherConfig ..." (with optional leading article) (golint)
  • Line 168: warning: exported type ExternalEventsConfig should have comment or be unexported (golint)
  • Line 183: warning: comment on exported type NotificationsConfig should be of the form "NotificationsConfig ..." (with optional leading article) (golint)
  • Line 201: warning: comment on exported type Domain should be of the form "Domain ..." (with optional leading article) (golint)
  • Line 209: warning: exported type DomainsConfig should have comment or be unexported (golint)
  • Line 211: warning: comment on exported type ApplicationConfiguration should be of the form "ApplicationConfiguration ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/task_resource_provider.go
  • Line 12: warning: exported type TaskResourceSpec should have comment or be unexported (golint)
  • Line 17: warning: comment on exported type TaskResourceProvider should be of the form "TaskResourceProvider ..." (with optional leading article) (golint)
  • Line 20: warning: exported method TaskResourceProvider.GetDefaults should have comment or be unexported (golint)
  • Line 24: warning: exported method TaskResourceProvider.GetLimits should have comment or be unexported (golint)
  • Line 28: warning: exported function NewTaskResourceProvider should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/util/digests.go
  • Line 14: warning: comment on exported function GetLaunchPlanDigest should be of the form "GetLaunchPlanDigest ..." (golint)
  • Line 27: warning: comment on exported function GetTaskDigest should be of the form "GetTaskDigest ..." (golint)
  • Line 40: warning: comment on exported function GetWorkflowDigest should be of the form "GetWorkflowDigest ..." (golint)

• flyteadmin/auth/init_secrets.go
  • Line 23: warning: exported const SymmetricKeyLength should have comment (or a comment on this block) or be unexported (golint)
  • Line 73: warning: exported type SecretsSet should have comment or be unexported (golint)
  • Line 121: warning: exported function NewSecrets should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/execution.go
  • Line 10: warning: comment on exported type ExecutionInterface should be of the form "ExecutionInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/mocks/project.go
  • Line 9: warning: exported type CreateProjectFunc should have comment or be unexported (golint)
  • Line 10: warning: exported type ListProjectFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type UpdateProjectFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type MockProjectManager should have comment or be unexported (golint)
  • Line 19: warning: exported method MockProjectManager.SetCreateProject should have comment or be unexported (golint)
  • Line 23: warning: exported method MockProjectManager.CreateProject should have comment or be unexported (golint)
  • Line 30: warning: exported method MockProjectManager.UpdateProject should have comment or be unexported (golint)
  • Line 37: warning: exported method MockProjectManager.SetListCallback should have comment or be unexported (golint)
  • Line 41: warning: exported method MockProjectManager.ListProjects should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/task_manager.go
  • Line 41: warning: exported type TaskManager should have comment or be unexported (golint)
  • Line 63: warning: exported method TaskManager.CreateTask should have comment or be unexported (golint)
  • Line 127: warning: exported method TaskManager.GetTask should have comment or be unexported (golint)
  • Line 140: warning: exported method TaskManager.ListTasks should have comment or be unexported (golint)
  • Line 200: warning: comment on exported method TaskManager.ListUniqueTaskIdentifiers should be of the form "ListUniqueTaskIdentifiers ..." (golint)
  • Line 253: warning: exported function NewTaskManager should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/launch_plan.go
  • Line 13: warning: exported function CreateLaunchPlan should have comment or be unexported (golint)
  • Line 27: warning: comment on exported function CreateLaunchPlanModel should be of the form "CreateLaunchPlanModel ..." (golint)
  • Line 69: warning: comment on exported function FromLaunchPlanModel should be of the form "FromLaunchPlanModel ..." (golint)
  • Line 111: warning: exported function FromLaunchPlanModels should have comment or be unexported (golint)
  • Line 123: warning: exported function FromLaunchPlanModelsToIdentifiers should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/node_execution_manager.go
  • Line 54: warning: exported type NodeExecutionManager should have comment or be unexported (golint)
  • Line 223: warning: exported method NodeExecutionManager.CreateNodeEvent should have comment or be unexported (golint)
  • Line 288: warning: exported method NodeExecutionManager.GetNodeExecution should have comment or be unexported (golint)
  • Line 359: warning: exported method NodeExecutionManager.ListNodeExecutions should have comment or be unexported (golint)
  • Line 395: warning: comment on exported method NodeExecutionManager.ListNodeExecutionsForTask should be of the form "ListNodeExecutionsForTask ..." (golint)
  • Line 423: warning: exported method NodeExecutionManager.GetNodeExecutionData should have comment or be unexported (golint)
  • Line 494: warning: exported function NewNodeExecutionManager should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/quality_of_service_provider.go
  • Line 19: warning: comment on exported type QualityOfServiceConfigProvider should be of the form "QualityOfServiceConfigProvider ..." (with optional leading article) (golint)
  • Line 23: warning: exported method QualityOfServiceConfigProvider.GetTierExecutionValues should have comment or be unexported (golint)
  • Line 35: warning: exported method QualityOfServiceConfigProvider.GetDefaultTiers should have comment or be unexported (golint)
  • Line 56: warning: exported function NewQualityOfServiceConfigProvider should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/task.go
  • Line 18: warning: exported method AdminService.CreateTask should have comment or be unexported (golint)
  • Line 44: warning: exported method AdminService.GetTask should have comment or be unexported (golint)
  • Line 74: warning: exported method AdminService.ListTaskIds should have comment or be unexported (golint)
  • Line 103: warning: exported method AdminService.ListTasks should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/execution.go
  • Line 20: warning: comment on exported type CreateExecutionModelInput should be of the form "CreateExecutionModelInput ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported function CreateExecutionModel should be of the form "CreateExecutionModel ..." (golint)
  • Line 105: warning: comment on exported function UpdateExecutionModelState should be of the form "UpdateExecutionModelState ..." (golint)
  • Line 163: warning: comment on exported function SetExecutionAborted should be of the form "SetExecutionAborted ..." (golint)
  • Line 186: warning: exported function GetExecutionIdentifier should have comment or be unexported (golint)
  • Line 194: warning: exported function FromExecutionModel should have comment or be unexported (golint)
  • Line 226: warning: exported function FromExecutionModels should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/interfaces/workflow_executor.go
  • Line 3: warning: comment on exported type WorkflowExecutor should be of the form "WorkflowExecutor ..." (with optional leading article) (golint)

• flyteadmin/pkg/runtime/interfaces/whitelist.go
  • Line 3: warning: exported type WhitelistScope should have comment or be unexported (golint)
  • Line 8: warning: comment on exported type TaskTypeWhitelist should be of the form "TaskTypeWhitelist ..." (with optional leading article) (golint)
  • Line 11: warning: exported type WhitelistConfiguration should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/cluster_resource_provider.go
  • Line 20: warning: comment on exported type ClusterResourceConfigurationProvider should be of the form "ClusterResourceConfigurationProvider ..." (with optional leading article) (golint)
  • Line 23: warning: exported method ClusterResourceConfigurationProvider.GetTemplatePath should have comment or be unexported (golint)
  • Line 27: warning: exported method ClusterResourceConfigurationProvider.GetTemplateData should have comment or be unexported (golint)
  • Line 31: warning: exported method ClusterResourceConfigurationProvider.GetRefreshInterval should have comment or be unexported (golint)
  • Line 35: warning: exported method ClusterResourceConfigurationProvider.GetCustomTemplateData should have comment or be unexported (golint)
  • Line 39: warning: exported function NewClusterResourceConfigurationProvider should have comment or be unexported (golint)

• flyteadmin/pkg/rpc/adminservice/task_execution.go
  • Line 19: warning: exported method AdminService.CreateTaskEvent should have comment or be unexported (golint)
  • Line 53: warning: exported method AdminService.GetTaskExecution should have comment or be unexported (golint)
  • Line 88: warning: exported method AdminService.ListTaskExecutions should have comment or be unexported (golint)
  • Line 117: warning: exported method AdminService.GetTaskExecutionData should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/interfaces/emailer.go
  • Line 9: warning: comment on exported type Emailer should be of the form "Emailer ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/validation/task_execution_validator.go
  • Line 10: warning: exported function ValidateTaskExecutionRequest should have comment or be unexported (golint)
  • Line 25: warning: exported function ValidateTaskExecutionIdentifier should have comment or be unexported (golint)
  • Line 48: warning: exported function ValidateTaskExecutionListRequest should have comment or be unexported (golint)

• flyteadmin/pkg/executioncluster/impl/in_cluster.go
  • Line 16: warning: exported type InCluster should have comment or be unexported (golint)
  • Line 20: warning: exported method InCluster.GetTarget should have comment or be unexported (golint)
  • Line 27: warning: exported method InCluster.GetAllValidTargets should have comment or be unexported (golint)
  • Line 33: warning: exported function NewInCluster should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/interfaces/launch_plan_repo.go
  • Line 11: warning: comment on exported type LaunchPlanRepoInterface should be of the form "LaunchPlanRepoInterface ..." (with optional leading article) (golint)
  • Line 28: warning: exported type SetStateInput should have comment or be unexported (golint)
  • Line 34: warning: comment on exported type LaunchPlanCollectionOutput should be of the form "LaunchPlanCollectionOutput ..." (with optional leading article) (golint)

• flyteadmin/pkg/repositories/mocks/node_execution_repo.go
  • Line 10: warning: exported type CreateNodeExecutionFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type UpdateNodeExecutionFunc should have comment or be unexported (golint)
  • Line 12: warning: exported type GetNodeExecutionFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ListNodeExecutionFunc should have comment or be unexported (golint)
  • Line 15: warning: exported type ListNodeExecutionEventFunc should have comment or be unexported (golint)
  • Line 18: warning: exported type MockNodeExecutionRepo should have comment or be unexported (golint)
  • Line 27: warning: exported method MockNodeExecutionRepo.Create should have comment or be unexported (golint)
  • Line 34: warning: exported method MockNodeExecutionRepo.SetCreateCallback should have comment or be unexported (golint)
  • Line 38: warning: exported method MockNodeExecutionRepo.Update should have comment or be unexported (golint)
  • Line 45: warning: exported method MockNodeExecutionRepo.SetUpdateCallback should have comment or be unexported (golint)
  • Line 49: warning: exported method MockNodeExecutionRepo.Get should have comment or be unexported (golint)
  • Line 56: warning: exported method MockNodeExecutionRepo.SetGetCallback should have comment or be unexported (golint)
  • Line 60: warning: exported method MockNodeExecutionRepo.List should have comment or be unexported (golint)
  • Line 68: warning: exported method MockNodeExecutionRepo.SetListCallback should have comment or be unexported (golint)
  • Line 72: warning: exported method MockNodeExecutionRepo.ListEvents should have comment or be unexported (golint)
  • Line 80: warning: exported method MockNodeExecutionRepo.SetListEventCallback should have comment or be unexported (golint)
  • Line 84: warning: exported method MockNodeExecutionRepo.Exists should have comment or be unexported (golint)
  • Line 91: warning: exported function NewMockNodeExecutionRepo should have comment or be unexported (golint)

• flyteadmin/auth/interfaces/context.go
  • Line 25: warning: exported type HandlerRegisterer should have comment or be unexported (golint)

• flyteadmin/pkg/async/schedule/aws/cloud_watch_scheduler.go
  • Line 255: warning: exported function NewCloudWatchScheduler should have comment or be unexported (golint)

• flyteadmin/pkg/audit/util.go
  • Line 13: warning: exported const Project should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported function ParametersFromIdentifier should have comment or be unexported (golint)
  • Line 39: warning: exported function ParametersFromNamedEntityIdentifier should have comment or be unexported (golint)
  • Line 50: warning: exported function ParametersFromNamedEntityIdentifierAndResource should have comment or be unexported (golint)
  • Line 59: warning: exported function ParametersFromExecutionIdentifier should have comment or be unexported (golint)
  • Line 70: warning: exported function ParametersFromNodeExecutionIdentifier should have comment or be unexported (golint)
  • Line 82: warning: exported function ParametersFromTaskExecutionIdentifier should have comment or be unexported (golint)

• flyteadmin/auth/user_info_provider.go
  • Line 9: warning: exported type UserInfoProvider should have comment or be unexported (golint)
  • Line 19: warning: exported function NewUserInfoProvider should have comment or be unexported (golint)

• flyteadmin/pkg/async/shared.go
  • Line 13: warning: exported function Retry should have comment or be unexported (golint)

• flyteadmin/pkg/async/notifications/interfaces/processor.go
  • Line 3: warning: comment on exported type Processor should be of the form "Processor ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/validation/validation.go
  • Line 22: warning: exported function ValidateEmptyStringField should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function ValidateMaxLengthStringField should be of the form "ValidateMaxLengthStringField ..." (golint)
  • Line 37: warning: comment on exported function ValidateMaxMapLengthField should be of the form "ValidateMaxMapLengthField ..." (golint)
  • Line 45: warning: exported function ValidateIdentifierFieldsSet should have comment or be unexported (golint)
  • Line 64: warning: comment on exported function ValidateIdentifier should be of the form "ValidateIdentifier ..." (golint)
  • Line 77: warning: comment on exported function ValidateNamedEntityIdentifier should be of the form "ValidateNamedEntityIdentifier ..." (golint)
  • Line 94: warning: exported function ValidateResourceType should have comment or be unexported (golint)
  • Line 101: warning: exported function ValidateVersion should have comment or be unexported (golint)
  • Line 108: warning: exported function ValidateResourceListRequest should have comment or be unexported (golint)
  • Line 124: warning: exported function ValidateActiveLaunchPlanRequest should have comment or be unexported (golint)
  • Line 137: warning: exported function ValidateActiveLaunchPlanListRequest should have comment or be unexported (golint)
  • Line 150: warning: exported function ValidateNamedEntityIdentifierListRequest should have comment or be unexported (golint)
  • Line 207: warning: comment on exported function ValidateToken should be of the form "ValidateToken ..." (golint)
  • Line 223: warning: exported function ValidateLimit should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/transformers/task.go
  • Line 1: warning: package comment should be of the form "Package transformers ..." (golint)
  • Line 14: warning: comment on exported function CreateTaskModel should be of the form "CreateTaskModel ..." (golint)
  • Line 40: warning: exported function FromTaskModel should have comment or be unexported (golint)
  • Line 64: warning: exported function FromTaskModels should have comment or be unexported (golint)
  • Line 76: warning: exported function FromTaskModelsToIdentifiers should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/workflow.go
  • Line 9: warning: comment on exported type WorkflowInterface should be of the form "WorkflowInterface ..." (with optional leading article) (golint)

• flyteadmin/pkg/manager/impl/testutils/config.go
  • Line 9: warning: exported function GetApplicationConfigWithDefaultDomains should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/errors/postgres.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 78: warning: exported function NewPostgresErrorTransformer should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/validation/named_entity_validator.go
  • Line 11: warning: exported function ValidateNamedEntityGetRequest should have comment or be unexported (golint)
  • Line 21: warning: exported function ValidateNamedEntityUpdateRequest should have comment or be unexported (golint)
  • Line 41: warning: exported function ValidateNamedEntityListRequest should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/gormimpl/node_execution_event_repo.go
  • Line 13: warning: exported type NodeExecutionEventRepo should have comment or be unexported (golint)
  • Line 19: warning: exported method NodeExecutionEventRepo.Create should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function NewNodeExecutionEventRepo should be of the form "NewNodeExecutionEventRepo ..." (golint)

• flyteadmin/pkg/repositories/transformers/task_execution.go
  • Line 25: warning: exported type CreateTaskExecutionModelInput should have comment or be unexported (golint)
  • Line 72: warning: exported function CreateTaskExecutionModel should have comment or be unexported (golint)
  • Line 199: warning: exported function UpdateTaskExecutionModel should have comment or be unexported (golint)
  • Line 243: warning: exported function FromTaskExecutionModel should have comment or be unexported (golint)
  • Line 279: warning: exported function FromTaskExecutionModels should have comment or be unexported (golint)

• flyteadmin/pkg/common/entity.go
  • Line 7: warning: exported type Entity should have comment or be unexported (golint)
  • Line 10: warning: exported const Execution should have comment (or a comment on this block) or be unexported (golint)

• flyteadmin/cmd/entrypoints/clusterresource.go
  • Line 26: warning: exported function GetLocalDbConfig should have comment or be unexported (golint)

• flyteadmin/pkg/manager/impl/testutils/mock_closures.go
  • Line 1: warning: package comment should be of the form "Package testutils ..." (golint)
  • Line 13: warning: exported var MockCreatedAtValue should have comment or be unexported (golint)
  • Line 14: warning: exported var MockCreatedAtProto should have comment or be unexported (golint)
  • Line 16: warning: exported function GetTaskClosure should have comment or be unexported (golint)
  • Line 25: warning: exported function GetTaskClosureBytes should have comment or be unexported (golint)
  • Line 30: warning: exported function GetWorkflowClosure should have comment or be unexported (golint)
  • Line 46: warning: exported function GetWorkflowClosureBytes should have comment or be unexported (golint)
  • Line 52: warning: exported function MakeStringLiteral should have comment or be unexported (golint)

• flyteadmin/pkg/repositories/errors/error_transformer.go
  • Line 7: warning: comment on exported type ErrorTransformer should be of the form "ErrorTransformer ..." (with optional leading article) (golint)

• flyteadmin/pkg/async/schedule/aws/workflow_executor.go
  • Line 1: warning: package comment should be of the form "Package aws ..." (golint)
  • Line 310: warning: exported function NewWorkflowExecutor should have comment or be unexported (golint)

• flyteadmin/pkg/manager/interfaces/resource.go
  • Line 9: warning: comment on exported type ResourceInterface should be of the form "ResourceInterface ..." (with optional leading article) (golint)
  • Line 30: warning: comment on exported type ResourceRequest should be of the form "ResourceRequest ..." (with optional leading article) (golint)
  • Line 39: warning: exported type ResourceResponse should have comment or be unexported (golint)

• flyteadmin/pkg/runtime/interfaces/cluster_resource_configuration.go
  • Line 9: warning: exported type DataSourceValueFrom should have comment or be unexported (golint)
  • Line 14: warning: exported type DataSource should have comment or be unexported (golint)
  • Line 19: warning: exported type DomainName should have comment or be unexported (golint)
  • Line 21: warning: exported type TemplateData should have comment or be unexported (golint)
  • Line 23: warning: exported type ClusterResourceConfig should have comment or be unexported (golint)
  • Line 48: warning: exported type ClusterResourceConfiguration should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• flyteadmin/tests/node_execution_test.go
  • Line 90: warning: ineffectual assignment to err (ineffassign)

• flyteadmin/tests/task_test.go
  • Line 47: warning: ineffectual assignment to response (ineffassign)
  • Line 372: warning: ineffectual assignment to err (ineffassign)
  • Line 442: warning: ineffectual assignment to err (ineffassign)
  • Line 454: warning: ineffectual assignment to err (ineffassign)

• flyteadmin/tests/launch_plan_test.go
  • Line 209: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!