gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• flytectl/boilerplate/flyte/golang_support_tools/tools.go
  • Line 10: expected 'STRING', found '-':1::warning: file is not gofmted with -s (gofmt)
  • Line 11: expected ')', found 'EOF':1::warning: file is not gofmted with -s (gofmt)

• flytectl/cmd/get/execution_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• flytectl/cmd/get/node_execution_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• flytectl/cmd/register/register_util.go
  • Line 152: warning: cyclomatic complexity 16 of function hydrateNode() is high (> 15) (gocyclo)

• flytectl/pkg/visualize/graphviz.go
  • Line 207: warning: cyclomatic complexity 16 of function (*graphBuilder).constructNode() is high (> 15) (gocyclo)

golint64%

Golint is a linter for Go source code.

• flytectl/pkg/pkce/token_cache_keyring.go
  • Line 18: warning: exported const KeyRingServiceUser should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported method TokenCacheKeyringProvider.SaveToken should have comment or be unexported (golint)
  • Line 41: warning: exported method TokenCacheKeyringProvider.GetToken should have comment or be unexported (golint)

• flytectl/pkg/configutil/configutil.go
  • Line 11: warning: exported const AdminConfigTemplate should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported type ConfigTemplateSpec should have comment or be unexported (golint)
  • Line 58: warning: exported var FlytectlConfig should have comment or be unexported (golint)

• flytectl/pkg/visualize/graphviz.go
  • Line 14: warning: comment on exported const StartNode should be of the form "StartNode ..." (golint)
  • Line 16: warning: exported const EndNode should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: comment on exported const SubgraphPrefix should be of the form "SubgraphPrefix ..." (golint)
  • Line 21: warning: comment on exported const DoubleCircleShape should be of the form "DoubleCircleShape ..." (golint)
  • Line 27: warning: comment on exported const ColorAttr should be of the form "ColorAttr ..." (golint)
  • Line 32: warning: comment on exported const LabelAttr should be of the form "LabelAttr ..." (golint)
  • Line 37: warning: comment on exported const ElseFail should be of the form "ElseFail ..." (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_matcher_deleter.go
  • Line 9: warning: exported method AdminDeleterExtClient.DeleteWorkflowAttributes should have comment or be unexported (golint)
  • Line 19: warning: exported method AdminDeleterExtClient.DeleteProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/cmd/create/serialization_utils.go
  • Line 10: warning: comment on exported function MakeLiteralForVariables should be of the form "MakeLiteralForVariables ..." (golint)

• flytectl/cmd/update/project.go
  • Line 16: warning: comment on exported type ProjectConfig should be of the form "ProjectConfig ..." (with optional leading article) (golint)
  • Line 59: warning: exported var DefaultProjectConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/workflow/workflow_config.go
  • Line 10: warning: exported var DefaultConfig should have comment or be unexported (golint)

• flytectl/pkg/filters/operator.go
  • Line 4: warning: exported const Equals should have comment (or a comment on this block) or be unexported (golint)

• flytectl/pkg/ext/execution_fetcher.go
  • Line 11: warning: exported method AdminFetcherExtClient.FetchExecution should have comment or be unexported (golint)
  • Line 25: warning: exported method AdminFetcherExtClient.FetchNodeExecutionData should have comment or be unexported (golint)
  • Line 42: warning: exported method AdminFetcherExtClient.FetchNodeExecutionDetails should have comment or be unexported (golint)
  • Line 58: warning: exported method AdminFetcherExtClient.FetchTaskExecutionsOnNode should have comment or be unexported (golint)
  • Line 76: warning: exported method AdminFetcherExtClient.ListExecution should have comment or be unexported (golint)

• flytectl/pkg/ext/task_fetcher.go
  • Line 13: warning: exported method AdminFetcherExtClient.FetchAllVerOfTask should have comment or be unexported (golint)
  • Line 28: warning: exported method AdminFetcherExtClient.FetchTaskLatestVersion should have comment or be unexported (golint)
  • Line 41: warning: exported method AdminFetcherExtClient.FetchTaskVersion should have comment or be unexported (golint)

• flytectl/pkg/ext/updater.go
  • Line 28: warning: exported method AdminUpdaterExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/cmd/get/launch_plan.go
  • Line 117: warning: exported function LaunchplanToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/get/node_execution.go
  • Line 67: warning: exported type NodeExecution should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/pkg/filters/util.go
  • Line 7: warning: exported function BuildResourceListRequestWithName should have comment or be unexported (golint)
  • Line 29: warning: exported function BuildProjectListRequest should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_match_fetcher.go
  • Line 10: warning: exported method AdminFetcherExtClient.FetchWorkflowAttributes should have comment or be unexported (golint)
  • Line 27: warning: exported method AdminFetcherExtClient.FetchProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/plugin_override/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/get/workflow.go
  • Line 93: warning: exported function WorkflowToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/plugin_override/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/sandbox/exec.go
  • Line 33: warning: exported function Execute should have comment or be unexported (golint)

• flytectl/cmd/get/execution.go
  • Line 97: warning: exported function ExecutionToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/register/files_config.go
  • Line 6: warning: exported var DefaultFilesConfig should have comment or be unexported (golint)

• flytectl/pkg/filters/filters.go
  • Line 11: warning: exported var InReg should have comment or be unexported (golint)

• flytectl/cmd/core/cmd.go
  • Line 15: warning: exported type PFlagProvider should have comment or be unexported (golint)
  • Line 19: warning: exported type CommandEntry should have comment or be unexported (golint)
  • Line 28: warning: exported function AddCommands should have comment or be unexported (golint)

• flytectl/cmd/get/task.go
  • Line 106: warning: exported function TaskToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/update/interfaces/updater.go
  • Line 12: warning: exported type Updater should have comment or be unexported (golint)

• flytectl/cmd/get/execution_util.go
  • Line 30: warning: exported function WriteExecConfigToFile should have comment or be unexported (golint)
  • Line 43: warning: exported function CreateAndWriteExecConfigForTask should have comment or be unexported (golint)
  • Line 52: warning: exported function CreateAndWriteExecConfigForWorkflow should have comment or be unexported (golint)
  • Line 61: warning: exported function TaskInputs should have comment or be unexported (golint)
  • Line 81: warning: exported function ParamMapForTask should have comment or be unexported (golint)
  • Line 97: warning: exported function WorkflowParams should have comment or be unexported (golint)
  • Line 108: warning: exported function ParamMapForWorkflow should have comment or be unexported (golint)

• flytectl/cmd/get/project.go
  • Line 63: warning: exported function ProjectToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/testutils/test_utils.go
  • Line 27: warning: exported var Err should have comment or be unexported (golint)
  • Line 39: warning: exported function Setup should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/sandbox/sandbox_config.go
  • Line 8: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• flytectl/cmd/config/subcommand/workflowexecutionconfig/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/update/matchable_attribute_util.go
  • Line 11: warning: exported function DecorateAndUpdateMatchableAttr should have comment or be unexported (golint)

• flytectl/cmd/sandbox/start.go
  • Line 50: warning: exported const GeneratedManifest should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported var FlyteManifest should have comment or be unexported (golint)
  • Line 60: warning: exported type ExecResult should have comment or be unexported (golint)

• flytectl/cmd/core/types.go
  • Line 5: warning: exported type CommandFunc should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_match_updater.go
  • Line 9: warning: exported method AdminUpdaterExtClient.UpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 21: warning: exported method AdminUpdaterExtClient.UpdateProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/cmd/register/register_util.go
  • Line 47: warning: exported type Result should have comment or be unexported (golint)
  • Line 58: warning: exported var FlyteSnacksRelease should have comment or be unexported (golint)
  • Line 59: warning: exported var Client should have comment or be unexported (golint)
  • Line 69: warning: exported type Condition should have comment or be unexported (golint)
  • Line 281: warning: exported function DownloadFileFromHTTP should have comment or be unexported (golint)

• flytectl/cmd/completion.go
  • Line 1: warning: package comment should be of the form "Package cmd ..." (golint)

• flytectl/cmd/root.go
  • Line 110: warning: exported function GenerateDocs should have comment or be unexported (golint)
  • Line 120: warning: exported function GenReSTTree should have comment or be unexported (golint)
  • Line 129: warning: exported function ExecuteCmd should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/register/files.go
  • Line 98: warning: exported function Register should have comment or be unexported (golint)

• flytectl/pkg/adminutils/config.go
  • Line 8: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 15: warning: exported type Config should have comment or be unexported (golint)
  • Line 20: warning: exported function GetConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/matchable_attr_file_config_utils.go
  • Line 49: warning: exported function DumpTaskResourceAttr should have comment or be unexported (golint)

• flytectl/pkg/util/util.go
  • Line 15: warning: exported const HTTPRequestErrorMessage should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported function GetRequest should have comment or be unexported (golint)
  • Line 38: warning: exported function ParseGithubTag should have comment or be unexported (golint)
  • Line 47: warning: exported function WriteIntoFile should have comment or be unexported (golint)
  • Line 63: warning: exported function IsVersionGreaterThan should have comment or be unexported (golint)

• flytectl/pkg/printer/printer.go
  • Line 23: warning: comment on exported type OutputFormat should be of the form "OutputFormat ..." (with optional leading article) (golint)
  • Line 27: warning: exported const OutputFormatTABLE should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported const GraphVisualizationServiceURL should have comment or be unexported (golint)
  • Line 36: warning: exported function OutputFormats should have comment or be unexported (golint)
  • Line 44: warning: exported type Column should have comment or be unexported (golint)
  • Line 51: warning: exported type Printer should have comment or be unexported (golint)
  • Line 94: warning: exported method Printer.JSONToTable should have comment or be unexported (golint)
  • Line 127: warning: exported method Printer.PrintInterface should have comment or be unexported (golint)
  • Line 167: warning: exported method Printer.Print should have comment or be unexported (golint)
  • Line 217: warning: exported type PrintableProto should have comment or be unexported (golint)
  • Line 225: warning: exported method PrintableProto.MarshalJSON should have comment or be unexported (golint)

• flytectl/pkg/visualize/graphvizer.go
  • Line 7: warning: exported type Graphvizer should have comment or be unexported (golint)
  • Line 18: warning: exported type FlyteGraph should have comment or be unexported (golint)

• flytectl/cmd/update/named_entity.go
  • Line 19: warning: exported type NamedEntityConfig should have comment or be unexported (golint)
  • Line 25: warning: exported method NamedEntityConfig.UpdateNamedEntity should have comment or be unexported (golint)

• flytectl/cmd/get/matchable_attribute_util.go
  • Line 11: warning: exported function FetchAndUnDecorateMatchableAttr should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/workflowexecutionconfig/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/pkg/docker/docker.go
  • Line 16: warning: exported type Docker should have comment or be unexported (golint)
  • Line 29: warning: exported type FlyteDocker should have comment or be unexported (golint)

• flytectl/pkg/docker/docker_util.go
  • Line 27: warning: exported var Kubeconfig should have comment or be unexported (golint)
  • Line 191: warning: exported function InspectExecResp should have comment or be unexported (golint)

• flytectl/pkg/commandutils/command_utils.go
  • Line 10: warning: exported function AskForConfirmation should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/pkg/ext/project_fetcher.go
  • Line 11: warning: exported method AdminFetcherExtClient.ListProjects should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/task/task_config.go
  • Line 12: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• flytectl/pkg/filters/type.go
  • Line 4: warning: exported var DefaultLimit should have comment or be unexported (golint)
  • Line 12: warning: exported type Filters should have comment or be unexported (golint)

• flytectl/pkg/ext/deleter.go
  • Line 28: warning: exported method AdminDeleterExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/config/init_flags.go
  • Line 11: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• flytectl/cmd/config/subcommand/launchplan/launchplan_config.go
  • Line 14: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/plugin_override/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/create/execution.go
  • Line 148: warning: exported type ExecutionType should have comment or be unexported (golint)
  • Line 151: warning: exported const Task should have comment (or a comment on this block) or be unexported (golint)
  • Line 156: warning: exported type ExecutionParams should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/workflowexecutionconfig/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/pkg/ext/fetcher.go
  • Line 76: warning: exported method AdminFetcherExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/clierrors/errors.go
  • Line 4: warning: exported var ErrInvalidStateUpdate should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/project/project_config.go
  • Line 14: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• flytectl/cmd/core/cmd_ctx.go
  • Line 10: warning: exported type CommandContext should have comment or be unexported (golint)
  • Line 19: warning: exported function NewCommandContext should have comment or be unexported (golint)
  • Line 39: warning: exported method CommandContext.AdminClient should have comment or be unexported (golint)
  • Line 43: warning: exported method CommandContext.OutputPipe should have comment or be unexported (golint)
  • Line 47: warning: exported method CommandContext.InputPipe should have comment or be unexported (golint)
  • Line 51: warning: exported method CommandContext.AdminFetcherExt should have comment or be unexported (golint)
  • Line 55: warning: exported method CommandContext.AdminUpdaterExt should have comment or be unexported (golint)
  • Line 59: warning: exported method CommandContext.AdminDeleterExt should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!