Preparing report...

Report for github.com/maicoin/max-exchange-api-go

A    Great!    Found 36 issues across 48 files

Tweet

gofmt85%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • max-exchange-api-go/api/private_api.go
    • Line 640: warning: cyclomatic complexity 24 of function (*PrivateApiService).GetApiV2TradesMy() is high (> 15) (gocyclo)
    • Line 265: warning: cyclomatic complexity 24 of function (*PrivateApiService).GetApiV2Deposits() is high (> 15) (gocyclo)
    • Line 835: warning: cyclomatic complexity 24 of function (*PrivateApiService).GetApiV2Withdrawals() is high (> 15) (gocyclo)
    • Line 525: warning: cyclomatic complexity 20 of function (*PrivateApiService).GetApiV2Orders() is high (> 15) (gocyclo)

golint27%

Golint is a linter for Go source code.

    • max-exchange-api-go/models/depth.go
    • Line 24: warning: comment on exported type Depth should be of the form "Depth ..." (with optional leading article) (golint)
    • Line 31: warning: exported type Bargain should have comment or be unexported (golint)
    • Line 36: warning: exported method Bargain.MarshalJSON should have comment or be unexported (golint)
    • max-exchange-api-go/api/private_api.go
    • Line 26: warning: exported type PrivateApiService should have comment or be unexported (golint)
    • Line 28: warning: comment on exported method PrivateApiService.GetApiV2Deposit should be of the form "GetApiV2Deposit ..." (golint)
    • Line 97: warning: comment on exported method PrivateApiService.GetApiV2DepositAddress should be of the form "GetApiV2DepositAddress ..." (golint)
    • Line 173: warning: comment on exported method PrivateApiService.GetApiV2DepositAddresses should be of the form "GetApiV2DepositAddresses ..." (golint)
    • Line 249: warning: comment on exported method PrivateApiService.GetApiV2Deposits should be of the form "GetApiV2Deposits ..." (golint)
    • Line 374: warning: comment on exported method PrivateApiService.GetApiV2MembersMe should be of the form "GetApiV2MembersMe ..." (golint)
    • Line 441: warning: comment on exported method PrivateApiService.GetApiV2Order should be of the form "GetApiV2Order ..." (golint)
    • Line 510: warning: comment on exported method PrivateApiService.GetApiV2Orders should be of the form "GetApiV2Orders ..." (golint)
    • Line 623: warning: comment on exported method PrivateApiService.GetApiV2TradesMy should be of the form "GetApiV2TradesMy ..." (golint)
    • Line 750: warning: comment on exported method PrivateApiService.GetApiV2Withdrawal should be of the form "GetApiV2Withdrawal ..." (golint)
    • Line 819: warning: comment on exported method PrivateApiService.GetApiV2Withdrawals should be of the form "GetApiV2Withdrawals ..." (golint)
    • Line 944: warning: comment on exported method PrivateApiService.PostApiV2DepositAddresses should be of the form "PostApiV2DepositAddresses ..." (golint)
    • Line 1013: warning: comment on exported method PrivateApiService.PostApiV2OrderDelete should be of the form "PostApiV2OrderDelete ..." (golint)
    • Line 1082: warning: comment on exported method PrivateApiService.PostApiV2Orders should be of the form "PostApiV2Orders ..." (golint)
    • Line 1178: warning: comment on exported method PrivateApiService.PostApiV2OrdersClear should be of the form "PostApiV2OrdersClear ..." (golint)
    • Line 1261: warning: comment on exported method PrivateApiService.PostApiV2OrdersMulti should be of the form "PostApiV2OrdersMulti ..." (golint)
    • max-exchange-api-go/types/types.go
    • Line 21: warning: exported type Price should have comment or be unexported (golint)
    • Line 23: warning: exported type Volume should have comment or be unexported (golint)
    • Line 25: warning: exported type Timestamp should have comment or be unexported (golint)
    • Line 27: warning: exported function ParsePrice should have comment or be unexported (golint)
    • Line 31: warning: exported function ParseVolume should have comment or be unexported (golint)
    • Line 47: warning: comment on exported type OrderState should be of the form "OrderState ..." (with optional leading article) (golint)
    • max-exchange-api-go/models/wrapper.go
    • Line 21: warning: exported type Market should have comment or be unexported (golint)
    • Line 22: warning: exported type Currency should have comment or be unexported (golint)
    • Line 23: warning: exported type Order should have comment or be unexported (golint)
    • Line 24: warning: exported type OrderBook should have comment or be unexported (golint)
    • Line 25: warning: exported type Trade should have comment or be unexported (golint)
    • Line 26: warning: exported type Member should have comment or be unexported (golint)
    • Line 27: warning: exported type Deposit should have comment or be unexported (golint)
    • Line 28: warning: exported type PaymentAddress should have comment or be unexported (golint)
    • Line 29: warning: exported type Withdrawal should have comment or be unexported (golint)
    • max-exchange-api-go/subscription.go
    • Line 40: warning: exported type TickerSubscription should have comment or be unexported (golint)
    • Line 59: warning: exported type OrderBookSubscription should have comment or be unexported (golint)
    • Line 78: warning: exported type TradeSubscription should have comment or be unexported (golint)
    • Line 97: warning: exported type AccountSubscription should have comment or be unexported (golint)
    • max-exchange-api-go/api/public_api.go
    • Line 27: warning: exported type PublicApiService should have comment or be unexported (golint)
    • Line 30: warning: comment on exported method PublicApiService.GetApiV2Currencies should be of the form "GetApiV2Currencies ..." (golint)
    • Line 93: warning: comment on exported method PublicApiService.GetApiV2Depth should be of the form "GetApiV2Depth ..." (golint)
    • Line 150: warning: comment on exported method PublicApiService.GetApiV2K should be of the form "GetApiV2K ..." (golint)
    • Line 221: warning: comment on exported method PublicApiService.GetApiV2Markets should be of the form "GetApiV2Markets ..." (golint)
    • Line 284: warning: comment on exported method PublicApiService.GetApiV2OrderBook should be of the form "GetApiV2OrderBook ..." (golint)
    • Line 364: warning: comment on exported method PublicApiService.GetApiV2Tickers should be of the form "GetApiV2Tickers ..." (golint)
    • Line 427: warning: comment on exported method PublicApiService.GetApiV2TickersMarket should be of the form "GetApiV2TickersMarket ..." (golint)
    • Line 492: warning: comment on exported method PublicApiService.GetApiV2Timestamp should be of the form "GetApiV2Timestamp ..." (golint)
    • Line 539: warning: comment on exported method PublicApiService.GetApiV2Trades should be of the form "GetApiV2Trades ..." (golint)
    • max-exchange-api-go/api/api_response.go
    • Line 16: warning: exported type APIResponse should have comment or be unexported (golint)
    • Line 33: warning: exported function NewAPIResponse should have comment or be unexported (golint)
    • Line 39: warning: exported function NewAPIResponseWithError should have comment or be unexported (golint)
    • max-exchange-api-go/models/events.go
    • Line 23: warning: exported type TickerEvent should have comment or be unexported (golint)
    • Line 28: warning: exported type OrderBookEvent should have comment or be unexported (golint)
    • Line 38: warning: exported type TradeEvent should have comment or be unexported (golint)
    • Line 45: warning: exported type AccountEvent should have comment or be unexported (golint)
    • max-exchange-api-go/api/configuration.go
    • Line 52: warning: exported type Configuration should have comment or be unexported (golint)
    • Line 61: warning: exported function NewConfiguration should have comment or be unexported (golint)
    • Line 70: warning: exported method Configuration.AddDefaultHeader should have comment or be unexported (golint)
    • max-exchange-api-go/params.go
    • Line 22: warning: exported var DepositStateSubmitting should have comment or be unexported (golint)
    • Line 34: warning: exported var WithdrawalStateSubmitting should have comment or be unexported (golint)
    • Line 50: warning: exported var OrderTypeLimit should have comment or be unexported (golint)
    • Line 57: warning: exported var OrderSideSell should have comment or be unexported (golint)
    • Line 62: warning: exported var OrderStateWait should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell93%

Misspell Finds commonly misspelled English words