Report for github.com/medusar/lucas
A+ Excellent! Found 11 issues across 28 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
lucas/command/connection.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
lucas/protocol/protocol.go
- Line 633: warning: cyclomatic complexity 17 of function (*BufRedisConn).writeArray() is high (> 15) (gocyclo)
- Line 353: warning: cyclomatic complexity 16 of function (*RedisConn).WriteArray() is high (> 15) (gocyclo)
golint64%
Golint is a linter for Go source code.
-
-
lucas/store/hashes.go
- Line 63: warning: exported function Hget should have comment or be unexported (golint)
- Line 76: warning: exported function Hgetall should have comment or be unexported (golint)
- Line 88: warning: exported function Hkeys should have comment or be unexported (golint)
- Line 119: warning: comment on exported function Hexists should be of the form "Hexists ..." (golint)
- Line 203: warning: exported function Hvals should have comment or be unexported (golint)
- Line 219: warning: comment on exported function HincrBy should be of the form "HincrBy ..." (golint)
- Line 258: warning: exported function HincrByFloat should have comment or be unexported (golint)
-
-
lucas/store/lists.go
- Line 213: warning: exported function Lpush should have comment or be unexported (golint)
- Line 235: warning: exported function Rpush should have comment or be unexported (golint)
- Line 257: warning: exported function Llen should have comment or be unexported (golint)
- Line 268: warning: exported function Lpop should have comment or be unexported (golint)
- Line 279: warning: exported function Rpop should have comment or be unexported (golint)
- Line 290: warning: comment on exported function Lindex should be of the form "Lindex ..." (golint)
- Line 307: warning: comment on exported function Lrem should be of the form "Lrem ..." (golint)
- Line 325: warning: comment on exported function Lset should be of the form "Lset ..." (golint)
-
-
lucas/store/sets.go
- Line 68: warning: exported function Sadd should have comment or be unexported (golint)
- Line 125: warning: exported function SdiffStore should have comment or be unexported (golint)
- Line 138: warning: comment on exported function Sinter should be of the form "Sinter ..." (golint)
- Line 174: warning: exported function SinterStore should have comment or be unexported (golint)
- Line 186: warning: exported function Smembers should have comment or be unexported (golint)
- Line 203: warning: exported function Sismember should have comment or be unexported (golint)
- Line 215: warning: exported function Spop should have comment or be unexported (golint)
- Line 241: warning: exported function Srem should have comment or be unexported (golint)
- Line 260: warning: exported function Sunion should have comment or be unexported (golint)
- Line 279: warning: exported function SunionStore should have comment or be unexported (golint)
- Line 291: warning: comment on exported function Smove should be of the form "Smove ..." (golint)
-
-
lucas/store/strings.go
- Line 193: warning: exported function Get should have comment or be unexported (golint)
- Line 205: warning: exported function Set should have comment or be unexported (golint)
- Line 209: warning: exported function GetSet should have comment or be unexported (golint)
- Line 222: warning: exported function SetEX should have comment or be unexported (golint)
- Line 230: warning: exported function SetNX should have comment or be unexported (golint)
- Line 233: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 239: warning: exported function StrLen should have comment or be unexported (golint)
- Line 250: warning: exported function Incr should have comment or be unexported (golint)
- Line 254: warning: comment on exported function IncrBy should be of the form "IncrBy ..." (golint)
- Line 276: warning: comment on exported function Append should be of the form "Append ..." (golint)
- Line 292: warning: comment on exported function SetRange should be of the form "SetRange ..." (golint)
- Line 368: warning: exported function Mset should have comment or be unexported (golint)
- Line 420: warning: exported function BitCount should have comment or be unexported (golint)
-
-
lucas/client/main.go
- Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
lucas/command/command.go
- Line 12: warning: exported var GetInfo should have comment or be unexported (golint)
- Line 18: warning: comment on exported type RedisCmdInfo should be of the form "RedisCmdInfo ..." (with optional leading article) (golint)
- Line 28: warning: exported type RedisCmd should have comment or be unexported (golint)
- Line 142: warning: exported function LoopAndInvoke should have comment or be unexported (golint)
- Line 153: warning: exported function Execute should have comment or be unexported (golint)
- Line 162: warning: exported function ParseRequest should have comment or be unexported (golint)
-
-
lucas/store/store.go
- Line 26: warning: exported function Ttl should have comment or be unexported (golint)
- Line 35: warning: exported function Expire should have comment or be unexported (golint)
- Line 39: warning: exported function ExpireAt should have comment or be unexported (golint)
- Line 52: warning: exported function Keys should have comment or be unexported (golint)
- Line 72: warning: exported function Exists should have comment or be unexported (golint)
- Line 77: warning: exported function Del should have comment or be unexported (golint)
- Line 92: warning: exported function Type should have comment or be unexported (golint)
-
-
lucas/store/zset.go
- Line 407: warning: exported function Zadd should have comment or be unexported (golint)
- Line 443: warning: exported function ZrangeWithScore should have comment or be unexported (golint)
- Line 454: warning: exported function Zrange should have comment or be unexported (golint)
- Line 465: warning: exported function ZRangeByScore should have comment or be unexported (golint)
- Line 476: warning: exported function ZRangeByScoreWithScore should have comment or be unexported (golint)
- Line 487: warning: exported function Zrank should have comment or be unexported (golint)
- Line 498: warning: exported function Zrevrank should have comment or be unexported (golint)
- Line 509: warning: exported function Zrem should have comment or be unexported (golint)
- Line 520: warning: exported function Zscore should have comment or be unexported (golint)
-
-
lucas/client/client.go
- Line 11: warning: exported type RedisCli should have comment or be unexported (golint)
- Line 15: warning: exported function NewRedisCli should have comment or be unexported (golint)
- Line 40: warning: exported function ParseClientCmd should have comment or be unexported (golint)
-
-
lucas/protocol/protocol.go
- Line 13: warning: exported var Delimiter should have comment or be unexported (golint)
- Line 17: warning: exported type Resp should have comment or be unexported (golint)
- Line 29: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 34: warning: exported function NewNil should have comment or be unexported (golint)
- Line 38: warning: exported function NewBulk should have comment or be unexported (golint)
- Line 42: warning: exported type RedisRW should have comment or be unexported (golint)
- Line 73: warning: exported function NewRedisConn should have comment or be unexported (golint)
- Line 84: warning: exported method RedisConn.WriteBytes should have comment or be unexported (golint)
- Line 182: warning: comment on exported method RedisConn.ReadBulk should be of the form "ReadBulk ..." (golint)
- Line 301: warning: exported method RedisConn.ReadInlineRequest should have comment or be unexported (golint)
- Line 336: warning: exported method RedisConn.WriteString should have comment or be unexported (golint)
- Line 340: warning: exported method RedisConn.WriteInteger should have comment or be unexported (golint)
- Line 344: warning: exported method RedisConn.WriteBulk should have comment or be unexported (golint)
- Line 349: warning: exported method RedisConn.WriteError should have comment or be unexported (golint)
- Line 353: warning: exported method RedisConn.WriteArray should have comment or be unexported (golint)
- Line 404: warning: exported method RedisConn.Close should have comment or be unexported (golint)
- Line 409: warning: exported method RedisConn.IsClosed should have comment or be unexported (golint)
- Line 413: warning: exported method RedisConn.WriteNil should have comment or be unexported (golint)
- Line 418: warning: exported type BufRedisConn should have comment or be unexported (golint)
- Line 443: warning: exported method BufRedisConn.ReadByte should have comment or be unexported (golint)
- Line 447: warning: exported method BufRedisConn.ReadLine should have comment or be unexported (golint)
- Line 461: warning: exported method BufRedisConn.ReadInt should have comment or be unexported (golint)
- Line 474: warning: exported method BufRedisConn.ReadBulk should have comment or be unexported (golint)
- Line 492: warning: exported method BufRedisConn.ReadArray should have comment or be unexported (golint)
- Line 509: warning: exported method BufRedisConn.ReadReply should have comment or be unexported (golint)
- Line 531: warning: exported method BufRedisConn.ReadRequest should have comment or be unexported (golint)
- Line 575: warning: exported method BufRedisConn.ReadInlineRequest should have comment or be unexported (golint)
- Line 602: warning: exported method BufRedisConn.WriteString should have comment or be unexported (golint)
- Line 607: warning: exported method BufRedisConn.WriteInteger should have comment or be unexported (golint)
- Line 612: warning: exported method BufRedisConn.WriteBulk should have comment or be unexported (golint)
- Line 618: warning: exported method BufRedisConn.WriteError should have comment or be unexported (golint)
- Line 623: warning: exported method BufRedisConn.WriteNil should have comment or be unexported (golint)
- Line 628: warning: exported method BufRedisConn.WriteArray should have comment or be unexported (golint)
- Line 687: warning: exported method BufRedisConn.Close should have comment or be unexported (golint)
- Line 692: warning: exported method BufRedisConn.IsClosed should have comment or be unexported (golint)
- Line 696: warning: exported function NewBufRedisConn should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!