Preparing report...

Report for github.com/mendersoftware/iot-manager

(v0.0.0-20211217112528-2ab132c3c257)

A+    Excellent!    Found 12 issues across 34 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint67%

Golint is a linter for Go source code.

    • model/settings.go
    • Line 19: warning: comment on exported type Settings should be of the form "Settings ..." (with optional leading article) (golint)
    • Line 24: warning: exported method Settings.Validate should have comment or be unexported (golint)
    • client/workflows/client.go
    • Line 34: warning: exported const URICheckHealth should have comment (or a comment on this block) or be unexported (golint)
    • Line 49: warning: exported type Options should have comment or be unexported (golint)
    • Line 53: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 66: warning: exported method Options.SetClient should have comment or be unexported (golint)
    • store/mongo/datastore_mongo.go
    • Line 39: warning: exported const CollNameSettings should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: exported var ErrFailedToGetSettings should have comment or be unexported (golint)
    • Line 50: warning: exported type Config should have comment or be unexported (golint)
    • Line 54: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 59: warning: exported method Config.SetAutomigrate should have comment or be unexported (golint)
    • Line 167: warning: exported method DataStoreMongo.Close should have comment or be unexported (golint)
    • Line 174: warning: exported method DataStoreMongo.SetSettings should have comment or be unexported (golint)
    • Line 197: warning: exported method DataStoreMongo.GetSettings should have comment or be unexported (golint)
    • config/config.go
    • Line 55: warning: comment on exported const SettingWorkflowsURLDefault should be of the form "SettingWorkflowsURLDefault ..." (golint)
    • app/app.go
    • Line 31: warning: exported var ErrNoConnectionString should have comment or be unexported (golint)
    • Line 43: warning: exported type DeviceUpdate should have comment or be unexported (golint)
    • Line 45: warning: exported type Status should have comment or be unexported (golint)
    • Line 48: warning: exported const StatusEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 71: warning: comment on exported function New should be of the form "New ..." (golint)
    • store/mongo/migration_1_0_0.go
    • Line 28: warning: exported const IndexNameSettingsGet should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: don't use underscores in Go names; type migration_1_0_0 should be migration1_0_0 (golint)
    • client/iothub/client.go
    • Line 43: warning: comment on exported const APIVersion should be of the form "APIVersion ..." (golint)
    • Line 59: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 88: warning: exported type Options should have comment or be unexported (golint)
    • Line 92: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 105: warning: exported method Options.SetClient should have comment or be unexported (golint)
    • Line 110: warning: exported function NewClient should have comment or be unexported (golint)
    • client/iothub/model.go
    • Line 35: warning: exported type Key should have comment or be unexported (golint)
    • Line 37: warning: exported method Key.MarshalText should have comment or be unexported (golint)
    • Line 44: warning: exported type SymmetricKey should have comment or be unexported (golint)
    • Line 49: warning: exported type AuthType should have comment or be unexported (golint)
    • Line 52: warning: exported const AuthTypeSymmetric should have comment (or a comment on this block) or be unexported (golint)
    • Line 59: warning: exported type Auth should have comment or be unexported (golint)
    • Line 65: warning: exported function NewSymmetricAuth should have comment or be unexported (golint)
    • Line 84: warning: exported type Status should have comment or be unexported (golint)
    • Line 87: warning: exported const StatusEnabled should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: exported method Status.UnmarshalText should have comment or be unexported (golint)
    • Line 101: warning: exported method Status.Validate should have comment or be unexported (golint)
    • Line 105: warning: exported type DeviceCapabilities should have comment or be unexported (golint)
    • Line 109: warning: exported type TwinProperties should have comment or be unexported (golint)
    • Line 114: warning: exported type X509ThumbPrint should have comment or be unexported (golint)
    • Line 119: warning: exported type Device should have comment or be unexported (golint)
    • Line 164: warning: exported type DeviceTwin should have comment or be unexported (golint)
    • Line 186: warning: exported type UpdateProperties should have comment or be unexported (golint)
    • Line 190: warning: exported type DeviceTwinUpdate should have comment or be unexported (golint)
    • Line 196: warning: exported type Cursor should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!