Report for github.com/mendersoftware/mender-artifact
A+ Excellent! Found 41 issues across 73 files
gofmt93%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
mender-artifact/handlers/module_image_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
mender-artifact/handlers/rootfs_image.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
mender-artifact/artifact/metadata_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
mender-artifact/cli/write_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
mender-artifact/awriter/writer_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint61%
Golint is a linter for Go source code.
-
-
mender-artifact/areader/reader.go
- Line 35: warning: exported type SignatureVerifyFn should have comment or be unexported (golint)
- Line 36: warning: exported type DevicesCompatibleFn should have comment or be unexported (golint)
- Line 37: warning: exported type ScriptsReadFn should have comment or be unexported (golint)
- Line 39: warning: exported type ProgressReader should have comment or be unexported (golint)
- Line 43: warning: exported type Reader should have comment or be unexported (golint)
- Line 66: warning: exported function NewReader should have comment or be unexported (golint)
- Line 75: warning: exported function NewReaderSigned should have comment or be unexported (golint)
- Line 233: warning: exported function ReadVersion should have comment or be unexported (golint)
- Line 247: warning: exported method Reader.RegisterHandler should have comment or be unexported (golint)
- Line 258: warning: exported method Reader.GetHandlers should have comment or be unexported (golint)
- Line 550: warning: exported method Reader.ReadArtifact should have comment or be unexported (golint)
- Line 559: warning: exported method Reader.ReadArtifactHeaders should have comment or be unexported (golint)
- Line 590: warning: exported method Reader.ReadArtifactData should have comment or be unexported (golint)
- Line 610: warning: exported method Reader.GetCompatibleDevices should have comment or be unexported (golint)
- Line 617: warning: exported method Reader.GetArtifactName should have comment or be unexported (golint)
- Line 624: warning: exported method Reader.GetInfo should have comment or be unexported (golint)
- Line 628: warning: exported method Reader.GetUpdates should have comment or be unexported (golint)
- Line 670: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 972: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 1042: warning: exported method Reader.GetUpdateStorers should have comment or be unexported (golint)
- Line 1061: warning: exported method Reader.MergeArtifactDepends should have comment or be unexported (golint)
- Line 1096: warning: exported method Reader.MergeArtifactProvides should have comment or be unexported (golint)
- Line 1134: warning: exported method Reader.MergeArtifactClearsProvides should have comment or be unexported (golint)
- Line 1142: warning: exported method Reader.Compressor should have comment or be unexported (golint)
-
-
mender-artifact/artifact/metadata.go
- Line 99: warning: exported method HeaderInfo.UnmarshalJSON should have comment or be unexported (golint)
- Line 114: warning: exported function NewHeaderInfo should have comment or be unexported (golint)
- Line 122: warning: comment on exported method HeaderInfo.GetArtifactName should be of the form "GetArtifactName ..." (golint)
- Line 123: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 127: warning: comment on exported method HeaderInfo.GetCompatibleDevices should be of the form "GetCompatibleDevices ..." (golint)
- Line 128: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 132: warning: comment on exported method HeaderInfo.GetUpdates should be of the form "GetUpdates ..." (golint)
- Line 133: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 138: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 165: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 172: warning: exported method HeaderInfo.GetArtifactDepends should have comment or be unexported (golint)
- Line 172: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 176: warning: exported method HeaderInfo.GetArtifactProvides should have comment or be unexported (golint)
- Line 176: warning: receiver name hi should be consistent with previous receiver name h for HeaderInfo (golint)
- Line 180: warning: exported type HeaderInfoV3 should have comment or be unexported (golint)
- Line 190: warning: exported function NewHeaderInfoV3 should have comment or be unexported (golint)
- Line 199: warning: comment on exported method HeaderInfoV3.GetArtifactName should be of the form "GetArtifactName ..." (golint)
- Line 207: warning: comment on exported method HeaderInfoV3.GetCompatibleDevices should be of the form "GetCompatibleDevices ..." (golint)
- Line 215: warning: comment on exported method HeaderInfoV3.GetUpdates should be of the form "GetUpdates ..." (golint)
- Line 275: warning: exported type ArtifactDepends should have comment or be unexported (golint)
- Line 281: warning: exported var ErrCompatibleDevices should have comment or be unexported (golint)
- Line 283: warning: exported method ArtifactDepends.UnmarshalJSON should have comment or be unexported (golint)
- Line 298: warning: exported type ArtifactProvides should have comment or be unexported (golint)
- Line 324: warning: exported type TypeInfoDepends should have comment or be unexported (golint)
- Line 326: warning: exported method TypeInfoDepends.Map should have comment or be unexported (golint)
- Line 330: warning: exported function NewTypeInfoDepends should have comment or be unexported (golint)
- Line 395: warning: exported type TypeInfoProvides should have comment or be unexported (golint)
- Line 397: warning: exported method TypeInfoProvides.Map should have comment or be unexported (golint)
- Line 401: warning: exported function NewTypeInfoProvides should have comment or be unexported (golint)
- Line 471: warning: exported method HeaderInfoV3.GetArtifactDepends should have comment or be unexported (golint)
- Line 475: warning: exported method HeaderInfoV3.GetArtifactProvides should have comment or be unexported (golint)
- Line 499: warning: exported method Metadata.Map should have comment or be unexported (golint)
-
-
mender-artifact/artifact/signer.go
- Line 53: warning: exported method RSA.Sign should have comment or be unexported (golint)
- Line 66: warning: exported method RSA.Verify should have comment or be unexported (golint)
- Line 85: warning: exported type ECDSA256 should have comment or be unexported (golint)
- Line 87: warning: exported method ECDSA256.Sign should have comment or be unexported (golint)
- Line 138: warning: exported method ECDSA256.Verify should have comment or be unexported (golint)
- Line 167: warning: exported type SigningMethod should have comment or be unexported (golint)
- Line 181: warning: exported function NewSigner should have comment or be unexported (golint)
- Line 185: warning: exported function NewVerifier should have comment or be unexported (golint)
- Line 189: warning: exported method PKISigner.Sign should have comment or be unexported (golint)
- Line 203: warning: exported method PKISigner.Verify should have comment or be unexported (golint)
- Line 217: warning: exported function GetPublic should have comment or be unexported (golint)
-
-
mender-artifact/cli/cli.go
- Line 96: warning: exported function Run should have comment or be unexported (golint)
-
-
mender-artifact/utils/progress.go
- Line 23: warning: exported type ProgressReader should have comment or be unexported (golint)
- Line 28: warning: exported function NewProgressReader should have comment or be unexported (golint)
- Line 32: warning: exported method ProgressReader.Wrap should have comment or be unexported (golint)
- Line 47: warning: exported type ProgressWriter should have comment or be unexported (golint)
- Line 53: warning: exported function NewProgressWriter should have comment or be unexported (golint)
- Line 57: warning: exported method ProgressWriter.Wrap should have comment or be unexported (golint)
- Line 62: warning: exported method ProgressWriter.Reset should have comment or be unexported (golint)
- Line 67: warning: exported method ProgressWriter.Finish should have comment or be unexported (golint)
-
-
mender-artifact/handlers/module_image.go
- Line 27: warning: exported type ModuleImage should have comment or be unexported (golint)
- Line 41: warning: exported function NewModuleImage should have comment or be unexported (golint)
- Line 49: warning: exported function NewAugmentedModuleImage should have comment or be unexported (golint)
- Line 55: warning: exported method ModuleImage.NewAugmentedInstance should have comment or be unexported (golint)
- Line 61: warning: exported method ModuleImage.NewInstance should have comment or be unexported (golint)
- Line 71: warning: exported method ModuleImage.GetVersion should have comment or be unexported (golint)
- Line 75: warning: exported method ModuleImage.GetUpdateType should have comment or be unexported (golint)
- Line 79: warning: exported method ModuleImage.GetUpdateOriginalType should have comment or be unexported (golint)
- Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 87: warning: exported method ModuleImage.GetUpdateFiles should have comment or be unexported (golint)
- Line 90: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 95: warning: exported method ModuleImage.GetUpdateAugmentFiles should have comment or be unexported (golint)
- Line 99: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 104: warning: exported method ModuleImage.SetUpdateFiles should have comment or be unexported (golint)
- Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 113: warning: exported method ModuleImage.SetUpdateAugmentFiles should have comment or be unexported (golint)
- Line 124: warning: exported method ModuleImage.GetUpdateAllFiles should have comment or be unexported (golint)
- Line 137: warning: exported method ModuleImage.GetUpdateOriginalDepends should have comment or be unexported (golint)
- Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 145: warning: exported method ModuleImage.GetUpdateOriginalProvides should have comment or be unexported (golint)
- Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 153: warning: exported method ModuleImage.GetUpdateOriginalMetaData should have comment or be unexported (golint)
- Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 161: warning: exported method ModuleImage.GetUpdateOriginalClearsProvides should have comment or be unexported (golint)
- Line 167: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 176: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 181: warning: exported method ModuleImage.GetUpdateAugmentDepends should have comment or be unexported (golint)
- Line 185: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 190: warning: exported method ModuleImage.GetUpdateAugmentProvides should have comment or be unexported (golint)
- Line 194: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 199: warning: exported method ModuleImage.GetUpdateAugmentMetaData should have comment or be unexported (golint)
- Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 207: warning: exported method ModuleImage.GetUpdateAugmentClearsProvides should have comment or be unexported (golint)
- Line 210: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 351: warning: exported method ModuleImage.GetUpdateDepends should have comment or be unexported (golint)
- Line 375: warning: exported method ModuleImage.GetUpdateProvides should have comment or be unexported (golint)
- Line 399: warning: exported method ModuleImage.GetUpdateMetaData should have comment or be unexported (golint)
- Line 407: warning: exported method ModuleImage.GetUpdateClearsProvides should have comment or be unexported (golint)
- Line 411: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 418: warning: exported method ModuleImage.ComposeHeader should have comment or be unexported (golint)
- Line 448: warning: exported method ModuleImage.ReadHeader should have comment or be unexported (golint)
- Line 489: warning: exported method ModuleImage.GetUpdateOriginalTypeInfoWriter should have comment or be unexported (golint)
- Line 492: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 497: warning: exported method ModuleImage.GetUpdateAugmentTypeInfoWriter should have comment or be unexported (golint)
- Line 500: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
mender-artifact/artifact/update.go
- Line 23: warning: exported const HeaderDirectory should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: exported function UpdatePath should have comment or be unexported (golint)
- Line 31: warning: exported function UpdateHeaderPath should have comment or be unexported (golint)
- Line 35: warning: exported function UpdateDataPath should have comment or be unexported (golint)
-
-
mender-artifact/artifact/compressor.go
- Line 27: warning: exported type Compressor should have comment or be unexported (golint)
- Line 33: warning: exported function RegisterCompressor should have comment or be unexported (golint)
- Line 37: warning: exported function NewCompressorFromFileName should have comment or be unexported (golint)
- Line 47: warning: exported function NewCompressorFromId should have comment or be unexported (golint)
- Line 73: warning: exported function GetRegisteredCompressorIds should have comment or be unexported (golint)
-
-
mender-artifact/artifact/compressor_gzip.go
- Line 22: warning: exported type CompressorGzip should have comment or be unexported (golint)
- Line 26: warning: exported function NewCompressorGzip should have comment or be unexported (golint)
- Line 30: warning: exported method CompressorGzip.GetFileExtension should have comment or be unexported (golint)
- Line 34: warning: exported method CompressorGzip.NewReader should have comment or be unexported (golint)
- Line 38: warning: exported method CompressorGzip.NewWriter should have comment or be unexported (golint)
-
-
mender-artifact/artifact/checksum.go
- Line 31: warning: exported type Checksum should have comment or be unexported (golint)
- Line 39: warning: exported function NewWriterChecksum should have comment or be unexported (golint)
- Line 51: warning: exported function NewReaderChecksum should have comment or be unexported (golint)
- Line 87: warning: exported method Checksum.Checksum should have comment or be unexported (golint)
- Line 97: warning: exported method Checksum.Verify should have comment or be unexported (golint)
- Line 106: warning: exported type ChecksumStore should have comment or be unexported (golint)
- Line 119: warning: exported function NewChecksumStore should have comment or be unexported (golint)
- Line 127: warning: exported method ChecksumStore.Add should have comment or be unexported (golint)
- Line 138: warning: exported method ChecksumStore.Get should have comment or be unexported (golint)
- Line 146: warning: comment on exported method ChecksumStore.GetAndMark should be of the form "GetAndMark ..." (golint)
- Line 155: warning: exported method ChecksumStore.FilesNotMarked should have comment or be unexported (golint)
- Line 165: warning: exported method ChecksumStore.GetRaw should have comment or be unexported (golint)
- Line 169: warning: exported method ChecksumStore.ReadRaw should have comment or be unexported (golint)
-
-
mender-artifact/cli/template.go
- Line 17: warning: comment on exported const CustomSubcommandHelpTemplate should be of the form "CustomSubcommandHelpTemplate ..." (golint)
-
-
mender-artifact/cli/util/tty.go
- Line 27: warning: comment on exported function DisableEcho should be of the form "DisableEcho ..." (golint)
- Line 44: warning: comment on exported function EchoSigHandler should be of the form "EchoSigHandler ..." (golint)
-
-
mender-artifact/utils/json.go
- Line 19: warning: exported function AppendStructToMap should have comment or be unexported (golint)
- Line 31: warning: exported function MarshallStructToMap should have comment or be unexported (golint)
-
-
mender-artifact/artifact/tar_writer_file.go
- Line 25: warning: exported type FileArchiver should have comment or be unexported (golint)
- Line 29: warning: exported function NewTarWriterFile should have comment or be unexported (golint)
-
-
mender-artifact/awriter/writer.go
- Line 32: warning: exported type ProgressWriter should have comment or be unexported (golint)
- Line 49: warning: exported function NewWriter should have comment or be unexported (golint)
- Line 57: warning: exported function NewWriterSigned should have comment or be unexported (golint)
- Line 63: warning: exported type Updates should have comment or be unexported (golint)
- Line 147: warning: exported function WriteSignature should have comment or be unexported (golint)
- Line 164: warning: exported type WriteArtifactArgs should have comment or be unexported (golint)
- Line 179: warning: exported method Writer.WriteArtifact should have comment or be unexported (golint)
-
-
mender-artifact/handlers/common.go
- Line 43: warning: exported type ComposeHeaderArgs should have comment or be unexported (golint)
- Line 53: warning: exported type ArtifactUpdateHeaders should have comment or be unexported (golint)
- Line 85: warning: exported type ArtifactUpdate should have comment or be unexported (golint)
- Line 100: warning: exported type Composer should have comment or be unexported (golint)
- Line 105: warning: exported type UpdateStorer should have comment or be unexported (golint)
- Line 118: warning: exported type UpdateStorerProducer should have comment or be unexported (golint)
- Line 122: warning: exported type Installer should have comment or be unexported (golint)
- Line 145: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 224: warning: exported type WriteInfoArgs should have comment or be unexported (golint)
-
-
mender-artifact/utils/attributes.go
- Line 24: warning: comment on exported function StringsMatchingWildcards should be of the form "StringsMatchingWildcards ..." (golint)
-
-
mender-artifact/cli/partition.go
- Line 48: warning: exported type VPImage should have comment or be unexported (golint)
- Line 55: warning: comment on exported type VPFile should be of the form "VPFile ..." (with optional leading article) (golint)
- Line 75: warning: exported type ModImageBase should have comment or be unexported (golint)
- Line 80: warning: exported type ModImageArtifact should have comment or be unexported (golint)
- Line 87: warning: exported type ModImageSdimg should have comment or be unexported (golint)
- Line 92: warning: exported type ModImageRaw should have comment or be unexported (golint)
- Line 150: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 205: warning: comment on exported function CopyIntoImage should be of the form "CopyIntoImage ..." (golint)
- Line 220: warning: comment on exported function CopyFromImage should be of the form "CopyFromImage ..." (golint)
- Line 264: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 280: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 285: warning: comment on exported method ModImageArtifact.Open should be of the form "Open ..." (golint)
- Line 290: warning: comment on exported method ModImageArtifact.OpenDir should be of the form "OpenDir ..." (golint)
- Line 295: warning: comment on exported method ModImageArtifact.Close should be of the form "Close ..." (golint)
- Line 310: warning: comment on exported method ModImageSdimg.Open should be of the form "Open ..." (golint)
- Line 315: warning: exported method ModImageSdimg.OpenDir should have comment or be unexported (golint)
- Line 319: warning: exported method ModImageSdimg.Close should have comment or be unexported (golint)
- Line 335: warning: exported method ModImageRaw.Open should have comment or be unexported (golint)
- Line 339: warning: exported method ModImageRaw.OpenDir should have comment or be unexported (golint)
- Line 343: warning: exported method ModImageRaw.Close should have comment or be unexported (golint)
-
-
mender-artifact/cli/copy.go
- Line 30: warning: exported function Cat should have comment or be unexported (golint)
- Line 64: warning: exported function Copy should have comment or be unexported (golint)
- Line 212: warning: exported function Remove should have comment or be unexported (golint)
-
-
mender-artifact/artifact/scripter.go
- Line 24: warning: exported type Scripts should have comment or be unexported (golint)
- Line 42: warning: exported method Scripts.Add should have comment or be unexported (golint)
- Line 71: warning: exported method Scripts.Get should have comment or be unexported (golint)
-
-
mender-artifact/artifact/tar_writer_stream.go
- Line 24: warning: exported function ToStream should have comment or be unexported (golint)
- Line 35: warning: exported type StreamArchiver should have comment or be unexported (golint)
- Line 39: warning: exported function NewTarWriterStream should have comment or be unexported (golint)
-
-
mender-artifact/cli/dump.go
- Line 38: warning: exported function DumpCommand should have comment or be unexported (golint)
-
-
mender-artifact/utils/binpath.go
- Line 26: warning: exported var ExternalBinaryPaths should have comment or be unexported (golint)
- Line 29: warning: exported function GetBinaryPath should have comment or be unexported (golint)
-
-
mender-artifact/handlers/rootfs_image.go
- Line 43: warning: exported function NewRootfsV2 should have comment or be unexported (golint)
- Line 53: warning: exported function NewRootfsV3 should have comment or be unexported (golint)
- Line 68: warning: exported function NewAugmentedRootfs should have comment or be unexported (golint)
- Line 80: warning: comment on exported method Rootfs.NewInstance should be of the form "NewInstance ..." (golint)
- Line 89: warning: exported method Rootfs.NewAugmentedInstance should have comment or be unexported (golint)
- Line 103: warning: exported method Rootfs.GetVersion should have comment or be unexported (golint)
- Line 107: warning: exported method Rootfs.ReadHeader should have comment or be unexported (golint)
- Line 171: warning: exported method Rootfs.GetUpdateFiles should have comment or be unexported (golint)
- Line 171: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 181: warning: exported method Rootfs.SetUpdateFiles should have comment or be unexported (golint)
- Line 181: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 200: warning: exported method Rootfs.GetUpdateAugmentFiles should have comment or be unexported (golint)
- Line 200: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 203: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 208: warning: exported method Rootfs.SetUpdateAugmentFiles should have comment or be unexported (golint)
- Line 208: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 212: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 232: warning: exported method Rootfs.GetUpdateAllFiles should have comment or be unexported (golint)
- Line 232: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 239: warning: exported method Rootfs.GetUpdateType should have comment or be unexported (golint)
- Line 239: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 243: warning: exported method Rootfs.GetUpdateOriginalType should have comment or be unexported (golint)
- Line 243: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 247: warning: exported method Rootfs.GetUpdateDepends should have comment or be unexported (golint)
- Line 247: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 251: warning: exported method Rootfs.GetUpdateProvides should have comment or be unexported (golint)
- Line 251: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 255: warning: exported method Rootfs.GetUpdateMetaData should have comment or be unexported (golint)
- Line 255: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 260: warning: exported method Rootfs.GetUpdateClearsProvides should have comment or be unexported (golint)
- Line 260: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 270: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 273: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 279: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 287: warning: exported method Rootfs.GetUpdateOriginalDepends should have comment or be unexported (golint)
- Line 287: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 294: warning: exported method Rootfs.GetUpdateOriginalProvides should have comment or be unexported (golint)
- Line 294: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 301: warning: exported method Rootfs.GetUpdateOriginalMetaData should have comment or be unexported (golint)
- Line 301: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 304: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 309: warning: exported method Rootfs.GetUpdateOriginalClearsProvides should have comment or be unexported (golint)
- Line 309: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 315: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 320: warning: exported method Rootfs.GetUpdateAugmentDepends should have comment or be unexported (golint)
- Line 320: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 324: warning: exported method Rootfs.GetUpdateAugmentProvides should have comment or be unexported (golint)
- Line 324: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 328: warning: exported method Rootfs.GetUpdateAugmentMetaData should have comment or be unexported (golint)
- Line 328: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 331: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 336: warning: exported method Rootfs.GetUpdateAugmentClearsProvides should have comment or be unexported (golint)
- Line 336: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 339: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 347: warning: exported method Rootfs.ComposeHeader should have comment or be unexported (golint)
- Line 347: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 396: warning: exported method Rootfs.GetUpdateOriginalTypeInfoWriter should have comment or be unexported (golint)
- Line 396: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
- Line 401: warning: exported method Rootfs.GetUpdateAugmentTypeInfoWriter should have comment or be unexported (golint)
- Line 401: warning: receiver name rfs should be consistent with previous receiver name rp for Rootfs (golint)
-
-
mender-artifact/artifact/compressor_lzma.go
- Line 24: warning: exported type CompressorLzma should have comment or be unexported (golint)
- Line 28: warning: exported function NewCompressorLzma should have comment or be unexported (golint)
- Line 32: warning: exported method CompressorLzma.GetFileExtension should have comment or be unexported (golint)
- Line 36: warning: exported method CompressorLzma.NewReader should have comment or be unexported (golint)
- Line 40: warning: exported method CompressorLzma.NewWriter should have comment or be unexported (golint)
-
-
mender-artifact/artifact/compressor_none.go
- Line 21: warning: don't use underscores in Go names; type compressor_none_reader should be compressorNoneReader (golint)
- Line 33: warning: don't use underscores in Go names; type compressor_none_writer should be compressorNoneWriter (golint)
- Line 45: warning: exported type CompressorNone should have comment or be unexported (golint)
- Line 49: warning: exported function NewCompressorNone should have comment or be unexported (golint)
- Line 53: warning: exported method CompressorNone.GetFileExtension should have comment or be unexported (golint)
- Line 57: warning: exported method CompressorNone.NewReader should have comment or be unexported (golint)
- Line 63: warning: exported method CompressorNone.NewWriter should have comment or be unexported (golint)
-
-
mender-artifact/awriter/signer.go
- Line 25: warning: exported var ErrAlreadyExistingSignature should have comment or be unexported (golint)
- Line 26: warning: exported var ErrManifestNotFound should have comment or be unexported (golint)
- Line 28: warning: comment on exported function SignExisting should be of the form "SignExisting ..." (golint)
-
-
mender-artifact/awriter/writer_test.go
- Line 63: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
gocyclo90%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
mender-artifact/handlers/rootfs_image.go
- Line 107: warning: cyclomatic complexity 19 of function (*Rootfs).ReadHeader() is high (> 15) (gocyclo)
-
-
mender-artifact/areader/reader_test.go
- Line 652: warning: cyclomatic complexity 39 of function TestReadBrokenArtifact() is high (> 15) (gocyclo)
-
-
mender-artifact/areader/reader.go
- Line 475: warning: cyclomatic complexity 16 of function (*Reader).readHeaderV2() is high (> 15) (gocyclo)
-
-
mender-artifact/cli/copy_test.go
- Line 148: warning: cyclomatic complexity 29 of function TestCopyRootfsImage() is high (> 15) (gocyclo)
-
-
mender-artifact/cli/write.go
- Line 326: warning: cyclomatic complexity 19 of function makeTypeInfo() is high (> 15) (gocyclo)
- Line 123: warning: cyclomatic complexity 18 of function writeRootfs() is high (> 15) (gocyclo)
- Line 680: warning: cyclomatic complexity 16 of function getDeviceSnapshot() is high (> 15) (gocyclo)
-
-
mender-artifact/cli/copy.go
- Line 64: warning: cyclomatic complexity 18 of function Copy() is high (> 15) (gocyclo)
- Line 138: warning: cyclomatic complexity 18 of function Install() is high (> 15) (gocyclo)
-
-
mender-artifact/cli/read.go
- Line 144: warning: cyclomatic complexity 17 of function printPayload() is high (> 15) (gocyclo)
ineffassign87%
IneffAssign detects ineffectual assignments in Go code.
-
-
mender-artifact/areader/reader_test.go
- Line 164: warning: ineffectual assignment to err (ineffassign)
- Line 287: warning: ineffectual assignment to art (ineffassign)
-
-
mender-artifact/cli/artifacts_test.go
- Line 58: warning: ineffectual assignment to err (ineffassign)
-
-
mender-artifact/cli/copy_test.go
- Line 602: warning: ineffectual assignment to err (ineffassign)
-
-
mender-artifact/cli/modify_existing_test.go
- Line 205: warning: ineffectual assignment to err (ineffassign)
-
-
mender-artifact/cli/sign_test.go
- Line 154: warning: ineffectual assignment to err (ineffassign)
-
-
mender-artifact/utils/attributes.go
- Line 47: warning: ineffectual assignment to i (ineffassign)
-
-
mender-artifact/utils/json_test.go
- Line 81: warning: ineffectual assignment to retMap (ineffassign)
-
-
mender-artifact/cli/util/tty_windows.go
- Line 38: warning: ineffectual assignment to newCmode (ineffassign)
-
-
mender-artifact/areader/reader.go
- Line 395: warning: ineffectual assignment to err (ineffassign)
misspell91%
Misspell Finds commonly misspelled English words
-
-
mender-artifact/utils/json_test.go
- Line 39: warning: "Successfull" is a misspelling of "Successful" (misspell)
-
-
mender-artifact/artifact/scripter.go
- Line 30: warning: "refference" is a misspelling of "reference" (misspell)
-
-
mender-artifact/artifact/signer.go
- Line 266: warning: "occured" is a misspelling of "occurred" (misspell)
-
-
mender-artifact/cli/util/tty.go
- Line 45: warning: "immedeately" is a misspelling of "immediately" (misspell)
-
-
mender-artifact/utils/attributes.go
- Line 24: warning: "containg" is a misspelling of "containing" (misspell)
-
-
mender-artifact/utils/binpath_test.go
- Line 32: warning: "existant" is a misspelling of "existent" (misspell)