Preparing report...

Report for github.com/merklecounty/rget

A+    Excellent!    Found 11 issues across 28 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint67%

Golint is a linter for Go source code.

    • rget/rgetct/ct.go
    • Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • rget/rgethash/sgethash.go
    • Line 24: warning: exported type URLSum should have comment or be unexported (golint)
    • Line 29: warning: exported type URLSumList should have comment or be unexported (golint)
    • Line 31: warning: exported function FromSHA256SumFile should have comment or be unexported (golint)
    • Line 44: warning: exported method URLSumList.AddURL should have comment or be unexported (golint)
    • Line 68: warning: exported method URLSumList.Domain should have comment or be unexported (golint)
    • Line 73: warning: exported method URLSumList.ShortDomain should have comment or be unexported (golint)
    • Line 78: warning: exported method URLSumList.GetURLSum should have comment or be unexported (golint)
    • Line 88: warning: exported method URLSumList.SumExists should have comment or be unexported (golint)
    • Line 98: warning: exported method URLSumList.MerkleRoot should have comment or be unexported (golint)
    • Line 107: warning: exported method URLSumList.SHA256SumFile should have comment or be unexported (golint)
    • Line 129: warning: exported var ErrCommonNameEmpty should have comment or be unexported (golint)
    • rget/gitcache/gitcache.go
    • Line 20: warning: exported type GitCache should have comment or be unexported (golint)
    • Line 54: warning: exported function NewGitCache should have comment or be unexported (golint)
    • Line 103: warning: exported method GitCache.Delete should have comment or be unexported (golint)
    • Line 120: warning: exported method GitCache.Prefix should have comment or be unexported (golint)
    • Line 125: warning: exported method GitCache.Get should have comment or be unexported (golint)
    • Line 129: warning: exported method GitCache.Put should have comment or be unexported (golint)
    • rget/rgetserver/rgetserver.go
    • Line 19: warning: exported type Server should have comment or be unexported (golint)
    • Line 59: warning: exported method Server.ReleaseHandler should have comment or be unexported (golint)
    • Line 86: warning: exported method Server.APIHandler should have comment or be unexported (golint)
    • Line 86: warning: receiver name r should be consistent with previous receiver name s for Server (golint)

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • rget/autocert/renewal_test.go
    • Line 189: warning: cyclomatic complexity 27 of function TestRenewFromCacheAlreadyRenewed() is high (> 15) (gocyclo)
    • Line 50: warning: cyclomatic complexity 25 of function TestRenewFromCache() is high (> 15) (gocyclo)
    • rget/autocert/autocert_test.go
    • Line 468: warning: cyclomatic complexity 23 of function startACMEServerStub() is high (> 15) (gocyclo)
    • Line 713: warning: cyclomatic complexity 21 of function TestRevokeFailedAuthz() is high (> 15) (gocyclo)
    • Line 614: warning: cyclomatic complexity 20 of function TestVerifyHTTP01() is high (> 15) (gocyclo)
    • Line 955: warning: cyclomatic complexity 17 of function TestValidCert() is high (> 15) (gocyclo)
    • rget/autocert/autocert.go
    • Line 1105: warning: cyclomatic complexity 20 of function validCert() is high (> 15) (gocyclo)
    • Line 706: warning: cyclomatic complexity 16 of function (*Manager).verify() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!