Go Report Card

Preparing report...

Report for github.com/mesos/mr-redis

A+    Excellent!    Found 18 issues across 39 files

Tweet
Last refresh:

Refresh now

gofmt89%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint71%

Golint is a linter for Go source code.

    • mr-redis/sched/httplib/httplib.go
    • Line 14: warning: exported type InputData should have comment or be unexported (golint)
    • Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 29: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 98: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 158: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 183: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 211: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 235: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • mr-redis/exec/docker/docker.go
    • Line 16: warning: comment on exported type Dcontainer should be of the form "Dcontainer ..." (with optional leading article) (golint)
    • Line 53: warning: don't use underscores in Go names; var prev_line should be prevLine (golint)
    • Line 62: warning: don't use underscores in Go names; var line_str should be lineStr (golint)
    • Line 106: warning: exported method Dcontainer.Wait should have comment or be unexported (golint)
    • Line 123: warning: exported method Dcontainer.Close should have comment or be unexported (golint)
    • Line 130: warning: exported method Dcontainer.Kill should have comment or be unexported (golint)
    • mr-redis/exec/RedMon/RedMon.go
    • Line 1: warning: don't use MixedCaps in package name; RedMon should be redmon (golint)
    • Line 26: warning: don't use underscores in Go names; struct field MS_Sync should be MSSync (golint)
    • mr-redis/common/store/zookeeper/db.go
    • Line 12: warning: exported const ETC_BASE_DIR should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported var DEF_ACL should have comment or be unexported (golint)
    • Line 27: warning: exported function New should have comment or be unexported (golint)
    • Line 61: warning: error should be the last type when returning multiple items (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign87%

IneffAssign detects ineffectual assignments in Go code.

    • mr-redis/common/types/Instance.go
    • Line 74: warning: ineffectual assignment to err (ineffassign)
    • Line 75: warning: ineffectual assignment to err (ineffassign)
    • Line 76: warning: ineffectual assignment to err (ineffassign)
    • Line 77: warning: ineffectual assignment to err (ineffassign)
    • Line 78: warning: ineffectual assignment to err (ineffassign)
    • Line 79: warning: ineffectual assignment to err (ineffassign)
    • Line 80: warning: ineffectual assignment to err (ineffassign)
    • Line 81: warning: ineffectual assignment to err (ineffassign)
    • Line 82: warning: ineffectual assignment to err (ineffassign)
    • Line 83: warning: ineffectual assignment to err (ineffassign)
    • Line 84: warning: ineffectual assignment to err (ineffassign)
    • Line 85: warning: ineffectual assignment to err (ineffassign)
    • Line 86: warning: ineffectual assignment to err (ineffassign)
    • Line 87: warning: ineffectual assignment to err (ineffassign)
    • Line 88: warning: ineffectual assignment to err (ineffassign)
    • mr-redis/common/types/Proc.go
    • Line 122: warning: ineffectual assignment to err (ineffassign)
    • Line 123: warning: ineffectual assignment to err (ineffassign)
    • Line 125: warning: ineffectual assignment to err (ineffassign)
    • Line 126: warning: ineffectual assignment to err (ineffassign)
    • Line 128: warning: ineffectual assignment to err (ineffassign)
    • Line 129: warning: ineffectual assignment to err (ineffassign)
    • Line 131: warning: ineffectual assignment to err (ineffassign)
    • Line 132: warning: ineffectual assignment to err (ineffassign)
    • Line 134: warning: ineffectual assignment to err (ineffassign)
    • Line 135: warning: ineffectual assignment to err (ineffassign)
    • Line 136: warning: ineffectual assignment to err (ineffassign)
    • Line 137: warning: ineffectual assignment to err (ineffassign)
    • Line 138: warning: ineffectual assignment to err (ineffassign)
    • Line 139: warning: ineffectual assignment to err (ineffassign)

misspell84%

Misspell Finds commonly misspelled English words

    • mr-redis/common/types/Proc.go
    • Line 143: warning: "occured" is a misspelling of "occurred" (misspell)
    • Line 240: warning: "occured" is a misspelling of "occurred" (misspell)
    • Line 247: warning: "occured" is a misspelling of "occurred" (misspell)
    • Line 261: warning: "occured" is a misspelling of "occurred" (misspell)
    • Line 276: warning: "occured" is a misspelling of "occurred" (misspell)