Report for github.com/metacurrency/holochain
A Great! Found 97 issues across 128 files
gofmt81%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
holochain/entry_dna.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/jsribosome.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/cmd/hcdev/hcdev_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/action_bundle_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/action_commit_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_agent.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/service.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/cmd/hcdev/hcdev.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/bridge.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_del.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_headers.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_migrate_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/gossip_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/node_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/apptest/apptest_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/action_query.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_agent_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_del_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_migrate.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_key.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/entry_links.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/test_data_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
holochain/warrant.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint42%
Golint is a linter for Go source code.
-
-
holochain/action_get.go
- Line 6: warning: should not use dot imports (golint)
- Line 14: warning: exported type APIFnGet should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnGet.Name should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnGet.Args should have comment or be unexported (golint)
- Line 33: warning: exported method APIFnGet.Call should have comment or be unexported (golint)
- Line 80: warning: exported type ActionGet should have comment or be unexported (golint)
- Line 85: warning: exported method ActionGet.Name should have comment or be unexported (golint)
- Line 106: warning: exported method ActionGet.SysValidation should have comment or be unexported (golint)
- Line 110: warning: exported method ActionGet.Receive should have comment or be unexported (golint)
-
-
holochain/action_query.go
- Line 10: warning: exported type APIFnQuery should have comment or be unexported (golint)
- Line 14: warning: exported method APIFnQuery.Name should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnQuery.Args should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnQuery.Call should have comment or be unexported (golint)
-
-
holochain/kad_query.go
- Line 17: warning: should not use dot imports (golint)
-
-
holochain/kad_table.go
- Line 14: warning: should not use dot imports (golint)
- Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 175: warning: exported function SortClosestPeers should have comment or be unexported (golint)
-
-
holochain/validate.go
- Line 13: warning: should not use dot imports (golint)
- Line 42: warning: exported const PkgReqChainOptNone should have comment (or a comment on this block) or be unexported (golint)
-
-
holochain/header.go
- Line 13: warning: should not use dot imports (golint)
- Line 20: warning: exported type Signature should have comment or be unexported (golint)
- Line 81: warning: receiver name sig1 should be consistent with previous receiver name sig for Signature (golint)
-
-
holochain/log.go
- Line 36: warning: exported var EnableAllLoggersEnv should have comment or be unexported (golint)
- Line 38: warning: exported method Logger.GetColor should have comment or be unexported (golint)
- Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 56: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 73: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 88: warning: exported method Logger.New should have comment or be unexported (golint)
- Line 88: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 115: warning: exported method Logger.SetPrefix should have comment or be unexported (golint)
- Line 115: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 119: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 128: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 153: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 157: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 169: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 177: warning: exported method Logger.Log should have comment or be unexported (golint)
- Line 177: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
- Line 181: warning: exported method Logger.Logf should have comment or be unexported (golint)
- Line 181: warning: receiver name l should be consistent with previous receiver name h for Logger (golint)
-
-
holochain/notifi.go
- Line 1: warning: package comment should be of the form "Package holochain ..." (golint)
-
-
holochain/cmd/hcadmin/hcadmin.go
- Line 16: warning: should not use dot imports (golint)
-
-
holochain/action_link.go
- Line 5: warning: should not use dot imports (golint)
- Line 12: warning: exported type ActionLink should have comment or be unexported (golint)
- Line 18: warning: exported function NewLinkAction should have comment or be unexported (golint)
- Line 23: warning: exported method ActionLink.Name should have comment or be unexported (golint)
- Line 27: warning: exported method ActionLink.SysValidation should have comment or be unexported (golint)
- Line 35: warning: exported method ActionLink.Receive should have comment or be unexported (golint)
- Line 80: warning: exported method ActionLink.CheckValidationRequest should have comment or be unexported (golint)
-
-
holochain/app_package.go
- Line 13: warning: exported const AppPackageVersion should have comment (or a comment on this block) or be unexported (golint)
- Line 16: warning: exported type AppPackageUIFile should have comment or be unexported (golint)
- Line 22: warning: exported type AppPackageTests should have comment or be unexported (golint)
- Line 27: warning: exported type AppPackageScenario should have comment or be unexported (golint)
- Line 33: warning: exported type AppPackage should have comment or be unexported (golint)
- Line 67: warning: exported const BasicTemplateAppPackageFormat should have comment (or a comment on this block) or be unexported (golint)
- Line 70: warning: exported var BasicTemplateAppPackage should have comment or be unexported (golint)
-
-
holochain/entry.go
- Line 12: warning: should not use dot imports (golint)
- Line 21: warning: exported const SysEntryTypePrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 119: warning: exported method GobEntry.Marshal should have comment or be unexported (golint)
- Line 123: warning: exported method GobEntry.Unmarshal should have comment or be unexported (golint)
- Line 128: warning: exported method GobEntry.Content should have comment or be unexported (golint)
- Line 130: warning: exported method GobEntry.Sum should have comment or be unexported (golint)
- Line 148: warning: exported method JSONEntry.Marshal should have comment or be unexported (golint)
- Line 156: warning: exported method JSONEntry.Unmarshal should have comment or be unexported (golint)
- Line 160: warning: exported method JSONEntry.Content should have comment or be unexported (golint)
- Line 162: warning: exported type JSONSchemaValidator should have comment or be unexported (golint)
- Line 168: warning: exported method JSONSchemaValidator.Validate should have comment or be unexported (golint)
- Line 174: warning: receiver name d should be consistent with previous receiver name def for EntryDef (golint)
- Line 184: warning: exported method EntryDef.BuildJSONSchemaValidatorFromString should have comment or be unexported (golint)
- Line 184: warning: receiver name d should be consistent with previous receiver name def for EntryDef (golint)
-
-
holochain/entry_agent.go
- Line 8: warning: exported const AgentEntryType should have comment (or a comment on this block) or be unexported (golint)
- Line 46: warning: exported var AgentEntryDef should have comment or be unexported (golint)
- Line 48: warning: exported method AgentEntry.ToJSON should have comment or be unexported (golint)
- Line 55: warning: exported function AgentEntryFromJSON should have comment or be unexported (golint)
-
-
holochain/test_data.go
- Line 6: warning: should not use dot imports (golint)
-
-
holochain/entry_headers.go
- Line 4: warning: exported const HeadersEntryType should have comment (or a comment on this block) or be unexported (golint)
- Line 8: warning: exported const HeadersEntrySchema should have comment (or a comment on this block) or be unexported (golint)
- Line 103: warning: exported var HeadersEntryDef should have comment or be unexported (golint)
-
-
holochain/cmd/bs/bs.go
- Line 19: warning: exported const DefaultPort should have comment (or a comment on this block) or be unexported (golint)
- Line 83: warning: exported type Node should have comment or be unexported (golint)
-
-
holochain/action_update.go
- Line 4: warning: should not use dot imports (golint)
- Line 11: warning: exported type APIFnMod should have comment or be unexported (golint)
- Line 15: warning: exported method APIFnMod.Name should have comment or be unexported (golint)
- Line 19: warning: exported method APIFnMod.Args should have comment or be unexported (golint)
- Line 23: warning: exported method APIFnMod.Call should have comment or be unexported (golint)
- Line 29: warning: exported type ActionMod should have comment or be unexported (golint)
- Line 36: warning: exported function NewModAction should have comment or be unexported (golint)
- Line 41: warning: exported method ActionMod.Entry should have comment or be unexported (golint)
- Line 45: warning: exported method ActionMod.EntryType should have comment or be unexported (golint)
- Line 49: warning: exported method ActionMod.Name should have comment or be unexported (golint)
- Line 53: warning: exported method ActionMod.SetHeader should have comment or be unexported (golint)
- Line 57: warning: exported method ActionMod.GetHeader should have comment or be unexported (golint)
- Line 61: warning: exported method ActionMod.Share should have comment or be unexported (golint)
- Line 71: warning: exported method ActionMod.SysValidation should have comment or be unexported (golint)
- Line 121: warning: exported method ActionMod.Receive should have comment or be unexported (golint)
- Line 149: warning: exported method ActionMod.CheckValidationRequest should have comment or be unexported (golint)
-
-
holochain/buntdbht.go
- Line 16: warning: should not use dot imports (golint)
- Line 21: warning: exported type BuntHT should have comment or be unexported (golint)
- Line 34: warning: exported method BuntHT.Open should have comment or be unexported (golint)
- Line 497: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 666: warning: exported method BuntHT.Iterate should have comment or be unexported (golint)
-
-
holochain/kad_bucket.go
- Line 30: warning: exported method Bucket.Peers should have comment or be unexported (golint)
- Line 41: warning: exported method Bucket.Has should have comment or be unexported (golint)
- Line 52: warning: exported method Bucket.Remove should have comment or be unexported (golint)
- Line 62: warning: exported method Bucket.MoveToFront should have comment or be unexported (golint)
- Line 72: warning: exported method Bucket.PushFront should have comment or be unexported (golint)
- Line 78: warning: exported method Bucket.PopBack should have comment or be unexported (golint)
- Line 86: warning: exported method Bucket.Len should have comment or be unexported (golint)
-
-
holochain/kad_lookup.go
- Line 13: warning: should not use dot imports (golint)
- Line 20: warning: exported var ErrEmptyRoutingTable should have comment or be unexported (golint)
- Line 30: warning: comment on exported method Node.GetClosestPeers should be of the form "GetClosestPeers ..." (golint)
-
-
holochain/ui/webserver.go
- Line 16: warning: should not use dot imports (golint)
- Line 23: warning: exported type WebServer should have comment or be unexported (golint)
- Line 32: warning: exported function NewWebServer should have comment or be unexported (golint)
- Line 40: warning: comment on exported function AddCors should be of the form "AddCors ..." (golint)
-
-
holochain/chain.go
- Line 24: warning: should not use dot imports (golint)
- Line 30: warning: exported var ErrHashNotFound should have comment or be unexported (golint)
- Line 31: warning: exported var ErrIncompleteChain should have comment or be unexported (golint)
- Line 32: warning: exported var ErrChainLockedForBundle should have comment or be unexported (golint)
- Line 33: warning: exported var ErrBundleNotStarted should have comment or be unexported (golint)
- Line 36: warning: exported const ChainMarshalFlagsNone should have comment (or a comment on this block) or be unexported (golint)
- Line 44: warning: exported type Bundle should have comment or be unexported (golint)
- Line 372: warning: exported type ChainPair should have comment or be unexported (golint)
-
-
holochain/holochain.go
- Line 5: warning: package comment should be of the form "Package holochain ..." (golint)
- Line 17: warning: should not use dot imports (golint)
- Line 104: warning: exported method Holochain.Nucleus should have comment or be unexported (golint)
- Line 108: warning: exported method Holochain.Chain should have comment or be unexported (golint)
- Line 112: warning: exported method Holochain.Name should have comment or be unexported (golint)
- Line 116: warning: exported method Holochain.World should have comment or be unexported (golint)
- Line 122: warning: error var SendTimeoutErr should have name of the form ErrFoo (golint)
- Line 122: warning: exported var SendTimeoutErr should have comment or be unexported (golint)
- Line 129: warning: exported method Holochain.Debug should have comment or be unexported (golint)
- Line 391: warning: comment on exported method Holochain.AgentTopHash should be of the form "AgentTopHash ..." (golint)
- Line 516: warning: exported method Config.Setup should have comment or be unexported (golint)
- Line 547: warning: exported method Config.SetGossipInterval should have comment or be unexported (golint)
- Line 659: warning: exported method Holochain.GetPrivateEntryDefs should have comment or be unexported (golint)
- Line 777: warning: comment on exported method Holochain.Node should be of the form "Node ..." (golint)
- Line 827: warning: exported const DefaultRetryInterval should have comment (or a comment on this block) or be unexported (golint)
- Line 943: warning: exported type QueryReturn should have comment or be unexported (golint)
- Line 949: warning: exported type QueryConstrain should have comment or be unexported (golint)
- Line 958: warning: exported type QueryOrder should have comment or be unexported (golint)
- Line 962: warning: exported type QueryOptions should have comment or be unexported (golint)
- Line 969: warning: exported type QueryResult should have comment or be unexported (golint)
-
-
holochain/service.go
- Line 16: warning: should not use dot imports (golint)
- Line 59: warning: comment on exported type CloneSpec should be of the form "CloneSpec ..." (with optional leading article) (golint)
- Line 88: warning: exported type EntryDefFile should have comment or be unexported (golint)
- Line 96: warning: exported type ZomeFile should have comment or be unexported (golint)
- Line 107: warning: exported type DNAFile should have comment or be unexported (golint)
- Line 658: warning: exported method Service.InitAppDir should have comment or be unexported (golint)
- Line 658: warning: receiver name service should be consistent with previous receiver name s for Service (golint)
- Line 846: warning: exported function DNAHashofUngenedChain should have comment or be unexported (golint)
- Line 880: warning: comment on exported method Service.ListChains should be of the form "ListChains ..." (golint)
- Line 990: warning: receiver name service should be consistent with previous receiver name s for Service (golint)
- Line 1013: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
- Line 1079: warning: receiver name service should be consistent with previous receiver name s for Service (golint)
- Line 1098: warning: receiver name service should be consistent with previous receiver name s for Service (golint)
- Line 1270: warning: comment on exported function GetTestScenarios should be of the form "GetTestScenarios ..." (golint)
- Line 1317: warning: exported const TestingAppDecodingFormat should have comment (or a comment on this block) or be unexported (golint)
- Line 1320: warning: exported function TestingAppAppPackage should have comment or be unexported (golint)
- Line 1828: warning: exported const SampleHTML should have comment (or a comment on this block) or be unexported (golint)
-
-
holochain/utils.go
- Line 30: warning: exported const OS_READ should have comment (or a comment on this block) or be unexported (golint)
- Line 78: warning: exported function WriteFile should have comment or be unexported (golint)
- Line 101: warning: exported function ReadFile should have comment or be unexported (golint)
- Line 111: warning: exported function DirExists should have comment or be unexported (golint)
- Line 117: warning: exported function FileExists should have comment or be unexported (golint)
- Line 126: warning: exported function FileSize should have comment or be unexported (golint)
- Line 329: warning: exported function BuildJSONSchemaValidatorFromFile should have comment or be unexported (golint)
- Line 345: warning: exported function BuildJSONSchemaValidatorFromString should have comment or be unexported (golint)
-
-
holochain/warrant.go
- Line 11: warning: should not use dot imports (golint)
- Line 17: warning: exported const SelfRevocationType should have comment (or a comment on this block) or be unexported (golint)
- Line 46: warning: error var WarrantPropertyNotFoundErr should have name of the form ErrFoo (golint)
- Line 46: warning: exported var WarrantPropertyNotFoundErr should have comment or be unexported (golint)
- Line 47: warning: error var UnknownWarrantTypeErr should have name of the form ErrFoo (golint)
- Line 47: warning: exported var UnknownWarrantTypeErr should have comment or be unexported (golint)
- Line 54: warning: exported function NewSelfRevocationWarrant should have comment or be unexported (golint)
- Line 60: warning: exported function DecodeWarrant should have comment or be unexported (golint)
- Line 71: warning: exported method SelfRevocationWarrant.Type should have comment or be unexported (golint)
- Line 75: warning: exported method SelfRevocationWarrant.Parties should have comment or be unexported (golint)
- Line 108: warning: exported method SelfRevocationWarrant.Verify should have comment or be unexported (golint)
- Line 127: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 137: warning: exported method SelfRevocationWarrant.Property should have comment or be unexported (golint)
- Line 148: warning: exported method SelfRevocationWarrant.Encode should have comment or be unexported (golint)
- Line 157: warning: exported method SelfRevocationWarrant.Decode should have comment or be unexported (golint)
-
-
holochain/action_getlinks.go
- Line 6: warning: should not use dot imports (golint)
- Line 14: warning: exported type APIFnGetLinks should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnGetLinks.Name should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnGetLinks.Args should have comment or be unexported (golint)
- Line 26: warning: exported method APIFnGetLinks.Call should have comment or be unexported (golint)
- Line 76: warning: exported type ActionGetLinks should have comment or be unexported (golint)
- Line 81: warning: exported function NewGetLinksAction should have comment or be unexported (golint)
- Line 86: warning: exported method ActionGetLinks.Name should have comment or be unexported (golint)
- Line 90: warning: exported method ActionGetLinks.SysValidation should have comment or be unexported (golint)
- Line 95: warning: exported method ActionGetLinks.Receive should have comment or be unexported (golint)
-
-
holochain/action_updateagent.go
- Line 5: warning: should not use dot imports (golint)
- Line 13: warning: exported type APIFnModAgent should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnModAgent.Args should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnModAgent.Name should have comment or be unexported (golint)
- Line 25: warning: exported method APIFnModAgent.Call should have comment or be unexported (golint)
-
-
holochain/dht.go
- Line 17: warning: should not use dot imports (golint)
- Line 21: warning: exported type HashType should have comment or be unexported (golint)
- Line 23: warning: comment on exported type DHTConfig should be of the form "DHTConfig ..." (with optional leading article) (golint)
- Line 50: warning: exported type Channel should have comment or be unexported (golint)
- Line 79: warning: exported const MaxRetries should have comment (or a comment on this block) or be unexported (golint)
- Line 137: warning: exported type ListAddReq should have comment or be unexported (golint)
- Line 144: warning: exported var KValue should have comment or be unexported (golint)
- Line 145: warning: exported var AlphaValue should have comment or be unexported (golint)
- Line 148: warning: exported const GossipWithQueueSize should have comment (or a comment on this block) or be unexported (golint)
- Line 152: warning: exported var ErrNotAcceptedByAnyRemoteNode should have comment or be unexported (golint)
- Line 333: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 583: warning: comment on exported method DHT.MakeReceiptSignature should be of the form "MakeReceiptSignature ..." (golint)
- Line 609: warning: exported method DHT.Iterate should have comment or be unexported (golint)
-
-
holochain/entry_migrate.go
- Line 5: warning: should not use dot imports (golint)
- Line 9: warning: exported const MigrateEntryType should have comment (or a comment on this block) or be unexported (golint)
- Line 10: warning: comment on exported const MigrateEntrySchema should be of the form "MigrateEntrySchema ..." (golint)
- Line 47: warning: comment on exported const MigrateEntryTypeClose should be of the form "MigrateEntryTypeClose ..." (golint)
- Line 60: warning: exported var MigrateEntryDef should have comment or be unexported (golint)
- Line 62: warning: comment on exported method MigrateEntry.Def should be of the form "Def ..." (golint)
- Line 67: warning: exported method MigrateEntry.ToJSON should have comment or be unexported (golint)
- Line 84: warning: exported function MigrateEntryFromJSON should have comment or be unexported (golint)
-
-
holochain/gossip.go
- Line 12: warning: should not use dot imports (golint)
- Line 39: warning: comment on exported type PeerListType should be of the form "PeerListType ..." (with optional leading article) (golint)
- Line 43: warning: exported const BlockedList should have comment (or a comment on this block) or be unexported (golint)
- Line 46: warning: exported type PeerRecord should have comment or be unexported (golint)
- Line 51: warning: exported type PeerList should have comment or be unexported (golint)
- Line 56: warning: exported var ErrDHTErrNoGossipersAvailable should have comment or be unexported (golint)
- Line 57: warning: exported var ErrDHTExpectedGossipReqInBody should have comment or be unexported (golint)
- Line 58: warning: exported var ErrNoSuchIdx should have comment or be unexported (golint)
- Line 131: warning: exported type GossiperData should have comment or be unexported (golint)
- Line 136: warning: exported method DHT.GetGossipers should have comment or be unexported (golint)
- Line 270: warning: exported const GossipBackPutDelay should have comment (or a comment on this block) or be unexported (golint)
-
-
holochain/zygosome.go
- Line 13: warning: should not use dot imports (golint)
- Line 23: warning: exported const ZygoRibosomeType should have comment (or a comment on this block) or be unexported (golint)
- Line 106: warning: comment on exported method ZygoRibosome.BundleCanceled should be of the form "BundleCanceled ..." (golint)
- Line 1373: warning: exported method ZygoRibosome.RunAsyncSendResponse should have comment or be unexported (golint)
-
-
holochain/hash/hash.go
- Line 144: warning: comment on exported function HashXORDistance should be of the form "HashXORDistance ..." (golint)
- Line 154: warning: comment on exported function HashLess should be of the form "HashLess ..." (golint)
- Line 178: warning: comment on exported type HashDistance should be of the form "HashDistance ..." (with optional leading article) (golint)
- Line 185: warning: exported type HashSorterArr should have comment or be unexported (golint)
-
-
holochain/action_debug.go
- Line 1: warning: package comment should be of the form "Package holochain ..." (golint)
- Line 10: warning: exported type APIFnDebug should have comment or be unexported (golint)
- Line 14: warning: exported method APIFnDebug.Name should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnDebug.Args should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnDebug.Call should have comment or be unexported (golint)
-
-
holochain/action_property.go
- Line 6: warning: exported type APIFnProperty should have comment or be unexported (golint)
- Line 10: warning: exported method APIFnProperty.Name should have comment or be unexported (golint)
- Line 14: warning: exported method APIFnProperty.Args should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnProperty.Call should have comment or be unexported (golint)
-
-
holochain/action_sign.go
- Line 10: warning: exported type APIFnSign should have comment or be unexported (golint)
- Line 14: warning: exported method APIFnSign.Name should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnSign.Args should have comment or be unexported (golint)
- Line 22: warning: exported method APIFnSign.Call should have comment or be unexported (golint)
- Line 35: warning: exported type APIFnVerifySignature should have comment or be unexported (golint)
- Line 41: warning: exported method APIFnVerifySignature.Name should have comment or be unexported (golint)
- Line 45: warning: exported method APIFnVerifySignature.Args should have comment or be unexported (golint)
- Line 49: warning: exported method APIFnVerifySignature.Call should have comment or be unexported (golint)
-
-
holochain/entry_links.go
- Line 8: warning: exported const DataFormatLinks should have comment (or a comment on this block) or be unexported (golint)
- Line 24: warning: exported method LinksEntry.ToJSON should have comment or be unexported (golint)
- Line 31: warning: exported function LinksEntryFromJSON should have comment or be unexported (golint)
-
-
holochain/node_test_util.go
- Line 49: warning: context.Context should be the first parameter of a function (golint)
- Line 59: warning: context.Context should be the first parameter of a function (golint)
- Line 65: warning: context.Context should be the first parameter of a function (golint)
- Line 73: warning: context.Context should be the first parameter of a function (golint)
- Line 79: warning: context.Context should be the first parameter of a function (golint)
- Line 86: warning: context.Context should be the first parameter of a function (golint)
- Line 154: warning: context.Context should be the first parameter of a function (golint)
- Line 174: warning: context.Context should be the first parameter of a function (golint)
-
-
holochain/revocation.go
- Line 15: warning: exported type Revocation should have comment or be unexported (golint)
- Line 21: warning: error var SelfRevocationDoesNotVerify should have name of the form ErrFoo (golint)
- Line 21: warning: exported var SelfRevocationDoesNotVerify should have comment or be unexported (golint)
- Line 31: warning: exported function NewSelfRevocation should have comment or be unexported (golint)
- Line 76: warning: exported method SelfRevocation.Marshal should have comment or be unexported (golint)
- Line 85: warning: exported method SelfRevocation.Unmarshal should have comment or be unexported (golint)
-
-
holochain/apptest/apptest.go
- Line 12: warning: should not use dot imports (golint)
- Line 147: warning: error should be the last type when returning multiple items (golint)
- Line 647: warning: exported function StartBridgeApp should have comment or be unexported (golint)
- Line 661: warning: exported function StopBridgeApps should have comment or be unexported (golint)
- Line 687: warning: exported type BridgeAppForTests should have comment or be unexported (golint)
-
-
holochain/cmd/common.go
- Line 26: warning: exported var ErrServiceUninitialized should have comment or be unexported (golint)
- Line 28: warning: exported function MakeErr should have comment or be unexported (golint)
- Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 42: warning: exported function MakeErrFromErr should have comment or be unexported (golint)
- Line 46: warning: exported function GetCurrentDirectory should have comment or be unexported (golint)
- Line 55: warning: exported function ExecBinScript should have comment or be unexported (golint)
- Line 67: warning: exported function OsExecSilent should have comment or be unexported (golint)
- Line 88: warning: comment on exported function OsExecPipes_noRun should be of the form "OsExecPipes_noRun ..." (golint)
- Line 89: warning: don't use underscores in Go names; func OsExecPipes_noRun should be OsExecPipesNoRun (golint)
- Line 129: warning: exported function GetConfigExtensionList should have comment or be unexported (golint)
- Line 218: warning: exported function Die should have comment or be unexported (golint)
- Line 223: warning: exported function GolangHolochainDir should have comment or be unexported (golint)
- Line 230: warning: exported function IsFile should have comment or be unexported (golint)
- Line 233: warning: exported function IsFileFromString should have comment or be unexported (golint)
- Line 237: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 246: warning: exported function IsDir should have comment or be unexported (golint)
- Line 252: warning: exported function GetTmpDir should have comment or be unexported (golint)
- Line 258: warning: exported function MakeTmpDir should have comment or be unexported (golint)
- Line 271: warning: comment on exported function GetFreePort should be of the form "GetFreePort ..." (golint)
- Line 290: warning: exported function GetUnixTimestamp_secondsFromNow should have comment or be unexported (golint)
- Line 290: warning: don't use underscores in Go names; func GetUnixTimestamp_secondsFromNow should be GetUnixTimestampSecondsFromNow (golint)
- Line 293: warning: exported function GetDuration_fromUnixTimestamp should have comment or be unexported (golint)
- Line 293: warning: don't use underscores in Go names; func GetDuration_fromUnixTimestamp should be GetDurationFromUnixTimestamp (golint)
- Line 300: warning: exported function UpackageAppPackage should have comment or be unexported (golint)
-
-
holochain/action_bridge.go
- Line 13: warning: exported type APIFnBridge should have comment or be unexported (golint)
- Line 21: warning: exported method APIFnBridge.Name should have comment or be unexported (golint)
- Line 25: warning: exported method APIFnBridge.Args should have comment or be unexported (golint)
- Line 29: warning: exported method APIFnBridge.Call should have comment or be unexported (golint)
-
-
holochain/action_put.go
- Line 10: warning: exported type ActionPut should have comment or be unexported (golint)
- Line 16: warning: exported function NewPutAction should have comment or be unexported (golint)
- Line 21: warning: exported method ActionPut.Name should have comment or be unexported (golint)
- Line 25: warning: exported method ActionPut.SysValidation should have comment or be unexported (golint)
- Line 30: warning: exported method ActionPut.Receive should have comment or be unexported (golint)
- Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 89: warning: exported method ActionPut.CheckValidationRequest should have comment or be unexported (golint)
-
-
holochain/node.go
- Line 16: warning: should not use dot imports (golint)
- Line 42: warning: exported type ReceiverFn should have comment or be unexported (golint)
- Line 44: warning: exported type MsgType should have comment or be unexported (golint)
- Line 108: warning: exported var ErrBlockedListed should have comment or be unexported (golint)
- Line 118: warning: exported type BytesSent should have comment or be unexported (golint)
- Line 123: warning: exported var BytesSentChan should have comment or be unexported (golint)
- Line 126: warning: exported const RetryingStopper should have comment (or a comment on this block) or be unexported (golint)
- Line 164: warning: exported const ActionProtocol should have comment (or a comment on this block) or be unexported (golint)
- Line 172: warning: exported const PeerTTL should have comment (or a comment on this block) or be unexported (golint)
- Line 178: warning: comment on exported method Holochain.HandlePeerFound should be of the form "HandlePeerFound ..." (golint)
- Line 307: warning: exported method Node.EnableMDNSDiscovery should have comment or be unexported (golint)
- Line 307: warning: receiver name n should be consistent with previous receiver name node for Node (golint)
- Line 318: warning: exported method Node.ExternalAddr should have comment or be unexported (golint)
- Line 318: warning: receiver name n should be consistent with previous receiver name node for Node (golint)
- Line 321: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 324: warning: don't use underscores in Go names; var external_addr should be externalAddr (golint)
- Line 356: warning: don't use underscores in Go names; var addr_string should be addrString (golint)
- Line 365: warning: don't use underscores in Go names; var external_addr should be externalAddr (golint)
- Line 621: warning: comment on exported method Node.IsBlocked should be of the form "IsBlocked ..." (golint)
- Line 650: warning: exported type ErrorResponse should have comment or be unexported (golint)
- Line 657: warning: exported const ErrUnknownCode should have comment (or a comment on this block) or be unexported (golint)
-
-
holochain/nucleus.go
- Line 10: warning: should not use dot imports (golint)
- Line 13: warning: exported type DNA should have comment or be unexported (golint)
- Line 44: warning: exported method Nucleus.DNA should have comment or be unexported (golint)
- Line 58: warning: exported method Nucleus.RunGenesis should have comment or be unexported (golint)
- Line 74: warning: exported method Nucleus.Start should have comment or be unexported (golint)
- Line 85: warning: exported type AppMsg should have comment or be unexported (golint)
-
-
holochain/ribosome.go
- Line 12: warning: should not use dot imports (golint)
- Line 17: warning: exported type RibosomeFactory should have comment or be unexported (golint)
- Line 23: warning: exported const STRING_CALLING should have comment (or a comment on this block) or be unexported (golint)
- Line 56: warning: error var ValidationFailedErr should have name of the form ErrFoo (golint)
- Line 56: warning: exported var ValidationFailedErr should have comment or be unexported (golint)
- Line 66: warning: exported function IsValidationFailedErr should have comment or be unexported (golint)
-
-
holochain/peerqueue/distance.go
- Line 7: warning: should not use dot imports (golint)
-
-
holochain/action.go
- Line 1: warning: package comment should be of the form "Package holochain ..." (golint)
- Line 10: warning: should not use dot imports (golint)
- Line 18: warning: exported type ArgType should have comment or be unexported (golint)
- Line 34: warning: exported const DHTChangeOK should have comment (or a comment on this block) or be unexported (golint)
- Line 84: warning: exported type ModAgentOptions should have comment or be unexported (golint)
- Line 89: warning: error var NonDHTAction should have name of the form ErrFoo (golint)
- Line 89: warning: exported var NonDHTAction should have comment or be unexported (golint)
- Line 90: warning: exported var ErrNotValidForDNAType should have comment or be unexported (golint)
- Line 91: warning: exported var ErrNotValidForAgentType should have comment or be unexported (golint)
- Line 92: warning: exported var ErrNotValidForKeyType should have comment or be unexported (golint)
- Line 93: warning: exported var ErrNotValidForHeadersType should have comment or be unexported (golint)
- Line 94: warning: exported var ErrNotValidForDelType should have comment or be unexported (golint)
- Line 95: warning: exported var ErrModInvalidForLinks should have comment or be unexported (golint)
- Line 96: warning: exported var ErrModMissingHeader should have comment or be unexported (golint)
- Line 97: warning: exported var ErrModReplacesHashNotDifferent should have comment or be unexported (golint)
- Line 98: warning: exported var ErrEntryDefInvalid should have comment or be unexported (golint)
- Line 99: warning: exported var ErrActionMissingHeader should have comment or be unexported (golint)
- Line 100: warning: exported var ErrActionReceiveInvalid should have comment or be unexported (golint)
- Line 102: warning: exported var ErrNilEntryInvalid should have comment or be unexported (golint)
- Line 271: warning: exported var ErrWrongNargs should have comment or be unexported (golint)
- Line 370: warning: exported const ValidationFailureBadPublicKeyFormat should have comment (or a comment on this block) or be unexported (golint)
- Line 374: warning: exported function RunValidationPhase should have comment or be unexported (golint)
-
-
holochain/capabilities.go
- Line 17: warning: exported type Capability should have comment or be unexported (golint)
- Line 23: warning: error var CapabilityInvalidErr should have name of the form ErrFoo (golint)
- Line 23: warning: exported var CapabilityInvalidErr should have comment or be unexported (golint)
-
-
holochain/jsribosome.go
- Line 12: warning: should not use dot imports (golint)
- Line 20: warning: exported const JSRibosomeType should have comment (or a comment on this block) or be unexported (golint)
- Line 92: warning: comment on exported method JSRibosome.BundleCanceled should be of the form "BundleCanceled ..." (golint)
- Line 311: warning: exported const JSLibrary should have comment (or a comment on this block) or be unexported (golint)
- Line 548: warning: exported const HolochainErrorPrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 982: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 991: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 1176: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 1185: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 1415: warning: exported method JSRibosome.RunAsyncSendResponse should have comment or be unexported (golint)
-
-
holochain/zome.go
- Line 38: warning: exported method Zome.GetPrivateEntryDefs should have comment or be unexported (golint)
- Line 49: warning: receiver name zome should be consistent with previous receiver name z for Zome (golint)
- Line 62: warning: exported method Zome.MakeRibosome should have comment or be unexported (golint)
- Line 62: warning: receiver name zome should be consistent with previous receiver name z for Zome (golint)
- Line 67: warning: exported method Zome.CodeFileName should have comment or be unexported (golint)
- Line 67: warning: receiver name zome should be consistent with previous receiver name z for Zome (golint)
-
-
holochain/action_addlist.go
- Line 11: warning: exported type ActionListAdd should have comment or be unexported (golint)
- Line 15: warning: exported function NewListAddAction should have comment or be unexported (golint)
- Line 20: warning: exported method ActionListAdd.Name should have comment or be unexported (golint)
- Line 26: warning: exported method ActionListAdd.Receive should have comment or be unexported (golint)
-
-
holochain/action_bundleclose.go
- Line 6: warning: exported type APIFnCloseBundle should have comment or be unexported (golint)
- Line 10: warning: exported method APIFnCloseBundle.Name should have comment or be unexported (golint)
- Line 14: warning: exported method APIFnCloseBundle.Args should have comment or be unexported (golint)
- Line 18: warning: exported method APIFnCloseBundle.Call should have comment or be unexported (golint)
-
-
holochain/agent.go
- Line 25: warning: exported type AgentType should have comment or be unexported (golint)
- Line 28: warning: exported const LibP2P should have comment (or a comment on this block) or be unexported (golint)
- Line 47: warning: exported type LibP2PAgent should have comment or be unexported (golint)
- Line 53: warning: exported method LibP2PAgent.Identity should have comment or be unexported (golint)
- Line 56: warning: exported method LibP2PAgent.SetIdentity should have comment or be unexported (golint)
- Line 60: warning: exported method LibP2PAgent.AgentType should have comment or be unexported (golint)
- Line 64: warning: exported method LibP2PAgent.PrivKey should have comment or be unexported (golint)
- Line 68: warning: exported method LibP2PAgent.PubKey should have comment or be unexported (golint)
- Line 72: warning: exported method LibP2PAgent.EncodePubKey should have comment or be unexported (golint)
- Line 82: warning: exported function DecodePubKey should have comment or be unexported (golint)
- Line 89: warning: exported method LibP2PAgent.GenKeys should have comment or be unexported (golint)
- Line 103: warning: exported method LibP2PAgent.NodeID should have comment or be unexported (golint)
- Line 111: warning: exported method LibP2PAgent.AgentEntry should have comment or be unexported (golint)
-
-
holochain/doc.go
- Line 4: warning: package comment should be of the form "Package holochain ..." (golint)
-
-
holochain/world.go
- Line 10: warning: should not use dot imports (golint)
- Line 35: warning: exported var ErrNodeNotFound should have comment or be unexported (golint)
- Line 217: warning: exported function HoldingTask should have comment or be unexported (golint)
-
-
holochain/action_delete.go
- Line 4: warning: should not use dot imports (golint)
- Line 11: warning: exported type APIFnDel should have comment or be unexported (golint)
- Line 15: warning: exported method APIFnDel.Name should have comment or be unexported (golint)
- Line 19: warning: exported method APIFnDel.Args should have comment or be unexported (golint)
- Line 23: warning: exported method APIFnDel.Call should have comment or be unexported (golint)
- Line 29: warning: exported type ActionDel should have comment or be unexported (golint)
- Line 34: warning: exported function NewDelAction should have comment or be unexported (golint)
- Line 39: warning: exported method ActionDel.Name should have comment or be unexported (golint)
- Line 43: warning: exported method ActionDel.Entry should have comment or be unexported (golint)
- Line 51: warning: exported method ActionDel.EntryType should have comment or be unexported (golint)
- Line 55: warning: exported method ActionDel.SetHeader should have comment or be unexported (golint)
- Line 59: warning: exported method ActionDel.GetHeader should have comment or be unexported (golint)
- Line 63: warning: exported method ActionDel.Share should have comment or be unexported (golint)
- Line 72: warning: exported method ActionDel.SysValidation should have comment or be unexported (golint)
- Line 80: warning: exported method ActionDel.Receive should have comment or be unexported (golint)
- Line 109: warning: exported method ActionDel.CheckValidationRequest should have comment or be unexported (golint)
-
-
holochain/action_makehash.go
- Line 1: warning: package comment should be of the form "Package holochain ..." (golint)
- Line 8: warning: should not use dot imports (golint)
- Line 14: warning: exported type APIFnMakeHash should have comment or be unexported (golint)
- Line 19: warning: exported method APIFnMakeHash.Name should have comment or be unexported (golint)
- Line 23: warning: exported method APIFnMakeHash.Args should have comment or be unexported (golint)
- Line 27: warning: exported method APIFnMakeHash.Call should have comment or be unexported (golint)
-
-
holochain/bridge.go
- Line 14: warning: should not use dot imports (golint)
- Line 41: warning: exported type BridgeSpec should have comment or be unexported (golint)
- Line 43: warning: error var BridgeAppNotFoundErr should have name of the form ErrFoo (golint)
- Line 43: warning: exported var BridgeAppNotFoundErr should have comment or be unexported (golint)
- Line 70: warning: should omit 2nd value from range; this loop is equivalent to `for zomeName := range ...` (golint)
-
-
holochain/action_bundlestart.go
- Line 7: warning: exported const DefaultBundleTimeout should have comment (or a comment on this block) or be unexported (golint)
- Line 10: warning: exported type APIFnStartBundle should have comment or be unexported (golint)
- Line 15: warning: exported function NewStartBundleAction should have comment or be unexported (golint)
- Line 23: warning: exported method APIFnStartBundle.Name should have comment or be unexported (golint)
- Line 27: warning: exported method APIFnStartBundle.Args should have comment or be unexported (golint)
- Line 31: warning: exported method APIFnStartBundle.Call should have comment or be unexported (golint)
-
-
holochain/change.go
- Line 10: warning: exported type ChangeType should have comment or be unexported (golint)
- Line 13: warning: exported const Deprecation should have comment (or a comment on this block) or be unexported (golint)
- Line 24: warning: exported method Change.Log should have comment or be unexported (golint)
- Line 35: warning: exported var ChangeAppProperty should have comment or be unexported (golint)
-
-
holochain/ht.go
- Line 12: warning: should not use dot imports (golint)
- Line 19: warning: exported const AddLinkAction should have comment (or a comment on this block) or be unexported (golint)
- Line 61: warning: exported const ReceiptOK should have comment (or a comment on this block) or be unexported (golint)
- Line 74: warning: exported var ErrLinkNotFound should have comment or be unexported (golint)
- Line 75: warning: exported var ErrPutLinkOverDeleted should have comment or be unexported (golint)
- Line 76: warning: exported var ErrHashDeleted should have comment or be unexported (golint)
- Line 77: warning: exported var ErrHashModified should have comment or be unexported (golint)
- Line 78: warning: exported var ErrHashRejected should have comment or be unexported (golint)
- Line 79: warning: exported var ErrEntryTypeMismatch should have comment or be unexported (golint)
- Line 81: warning: exported type HashTableIterateFn should have comment or be unexported (golint)
-
-
holochain/action_getbridges.go
- Line 6: warning: exported type APIFnGetBridges should have comment or be unexported (golint)
- Line 9: warning: exported method APIFnGetBridges.Name should have comment or be unexported (golint)
- Line 13: warning: exported method APIFnGetBridges.Args should have comment or be unexported (golint)
- Line 17: warning: exported method APIFnGetBridges.Call should have comment or be unexported (golint)
-
-
holochain/action_migrate.go
- Line 1: warning: package comment should be of the form "Package holochain ..." (golint)
- Line 8: warning: should not use dot imports (golint)
- Line 15: warning: exported type ActionMigrate should have comment or be unexported (golint)
- Line 20: warning: exported method ActionMigrate.Name should have comment or be unexported (golint)
- Line 24: warning: exported method ActionMigrate.Entry should have comment or be unexported (golint)
- Line 32: warning: exported method ActionMigrate.EntryType should have comment or be unexported (golint)
- Line 36: warning: exported method ActionMigrate.SetHeader should have comment or be unexported (golint)
- Line 40: warning: exported method ActionMigrate.GetHeader should have comment or be unexported (golint)
- Line 44: warning: exported method ActionMigrate.Share should have comment or be unexported (golint)
- Line 44: warning: receiver name action should be consistent with previous receiver name a for ActionMigrate (golint)
- Line 49: warning: exported method ActionMigrate.SysValidation should have comment or be unexported (golint)
- Line 49: warning: receiver name action should be consistent with previous receiver name a for ActionMigrate (golint)
- Line 66: warning: exported method ActionMigrate.CheckValidationRequest should have comment or be unexported (golint)
- Line 71: warning: exported method ActionMigrate.Receive should have comment or be unexported (golint)
- Line 80: warning: exported type APIFnMigrate should have comment or be unexported (golint)
- Line 84: warning: exported method APIFnMigrate.Name should have comment or be unexported (golint)
- Line 88: warning: exported method APIFnMigrate.Args should have comment or be unexported (golint)
- Line 99: warning: exported method APIFnMigrate.Call should have comment or be unexported (golint)
-
-
holochain/action_send.go
- Line 12: warning: exported type Callback should have comment or be unexported (golint)
- Line 18: warning: exported type SendOptions should have comment or be unexported (golint)
- Line 23: warning: exported type ActionSend should have comment or be unexported (golint)
- Line 29: warning: exported type APIFnSend should have comment or be unexported (golint)
- Line 33: warning: exported method APIFnSend.Name should have comment or be unexported (golint)
- Line 37: warning: exported method APIFnSend.Args should have comment or be unexported (golint)
- Line 41: warning: exported method APIFnSend.Call should have comment or be unexported (golint)
- Line 61: warning: exported method ActionSend.Name should have comment or be unexported (golint)
- Line 65: warning: exported method ActionSend.Receive should have comment or be unexported (golint)
-
-
holochain/entry_del.go
- Line 5: warning: should not use dot imports (golint)
- Line 9: warning: exported const DelEntryType should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported var DelEntryDef should have comment or be unexported (golint)
- Line 43: warning: exported method DelEntry.ToJSON should have comment or be unexported (golint)
- Line 56: warning: exported function DelEntryFromJSON should have comment or be unexported (golint)
-
-
holochain/entry_dna.go
- Line 4: warning: exported const DNAEntryType should have comment (or a comment on this block) or be unexported (golint)
- Line 8: warning: exported var DNAEntryDef should have comment or be unexported (golint)
-
-
holochain/bs.go
- Line 24: warning: exported const BootstrapTTL should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: exported type BSReq should have comment or be unexported (golint)
- Line 33: warning: exported type BSResp should have comment or be unexported (golint)
- Line 39: warning: exported method Holochain.BSpost should have comment or be unexported (golint)
- Line 95: warning: exported method Holochain.BSget should have comment or be unexported (golint)
-
-
holochain/kad_rpc.go
- Line 16: warning: should not use dot imports (golint)
- Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 24: warning: exported var ErrDHTUnexpectedTypeInBody should have comment or be unexported (golint)
- Line 26: warning: exported type FindNodeReq should have comment or be unexported (golint)
- Line 30: warning: comment on exported type PeerInfo should be of the form "PeerInfo ..." (with optional leading article) (golint)
- Line 38: warning: exported type CloserPeersResp should have comment or be unexported (golint)
- Line 42: warning: comment on exported var CloserPeerCount should be of the form "CloserPeerCount ..." (golint)
-
-
holochain/test.go
- Line 6: warning: should not use dot imports (golint)
- Line 8: warning: should not use dot imports (golint)
- Line 19: warning: exported var Crash should have comment or be unexported (golint)
- Line 21: warning: exported function Panix should have comment or be unexported (golint)
- Line 27: warning: exported function MakeTestDirName should have comment or be unexported (golint)
- Line 33: warning: exported function MakeTestSeed should have comment or be unexported (golint)
- Line 48: warning: exported function SetupTestService should have comment or be unexported (golint)
- Line 107: warning: exported function SetupTestChain should have comment or be unexported (golint)
- Line 125: warning: exported function PrepareTestChain should have comment or be unexported (golint)
- Line 131: warning: exported function SetupTestDir should have comment or be unexported (golint)
- Line 140: warning: exported function CleanupTestDir should have comment or be unexported (golint)
- Line 147: warning: exported function CleanupTestChain should have comment or be unexported (golint)
- Line 152: warning: exported function ShouldLog should have comment or be unexported (golint)
- Line 183: warning: exported function SetIdentity should have comment or be unexported (golint)
- Line 189: warning: exported function SetAgentIdentity should have comment or be unexported (golint)
- Line 196: warning: exported function NormaliseJSON should have comment or be unexported (golint)
-
-
holochain/cmd/hcdev/hcdev.go
- Line 21: warning: should not use dot imports (golint)
- Line 51: warning: exported type MutableContext should have comment or be unexported (golint)
- Line 1163: warning: exported function GetLastRunContext should have comment or be unexported (golint)
-
-
holochain/action_call.go
- Line 6: warning: exported type APIFnCall should have comment or be unexported (golint)
- Line 12: warning: exported method APIFnCall.Name should have comment or be unexported (golint)
- Line 16: warning: exported method APIFnCall.Args should have comment or be unexported (golint)
- Line 20: warning: exported method APIFnCall.Call should have comment or be unexported (golint)
-
-
holochain/action_commit.go
- Line 4: warning: should not use dot imports (golint)
- Line 11: warning: exported type APIFnCommit should have comment or be unexported (golint)
- Line 15: warning: exported method APIFnCommit.Name should have comment or be unexported (golint)
- Line 19: warning: exported method APIFnCommit.Args should have comment or be unexported (golint)
- Line 23: warning: exported method APIFnCommit.Call should have comment or be unexported (golint)
- Line 28: warning: exported method APIFnCommit.SetAction should have comment or be unexported (golint)
- Line 32: warning: exported type ActionCommit should have comment or be unexported (golint)
- Line 38: warning: exported function NewCommitAction should have comment or be unexported (golint)
- Line 43: warning: exported method ActionCommit.Entry should have comment or be unexported (golint)
- Line 47: warning: exported method ActionCommit.EntryType should have comment or be unexported (golint)
- Line 51: warning: exported method ActionCommit.Name should have comment or be unexported (golint)
- Line 55: warning: exported method ActionCommit.SetHeader should have comment or be unexported (golint)
- Line 59: warning: exported method ActionCommit.GetHeader should have comment or be unexported (golint)
- Line 63: warning: exported method ActionCommit.Share should have comment or be unexported (golint)
- Line 95: warning: exported method ActionCommit.SysValidation should have comment or be unexported (golint)
- Line 100: warning: exported method ActionCommit.Receive should have comment or be unexported (golint)
- Line 105: warning: exported method ActionCommit.CheckValidationRequest should have comment or be unexported (golint)
-
-
holochain/entry_key.go
- Line 4: warning: comment on exported const KeyEntryType should be of the form "KeyEntryType ..." (golint)
- Line 7: warning: exported const DataFormatSysKey should have comment (or a comment on this block) or be unexported (golint)
- Line 10: warning: exported var KeyEntryDef should have comment or be unexported (golint)
gocyclo92%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
holochain/cmd/hcdev/hcdev.go
- Line 70: warning: cyclomatic complexity 129 of function setupApp() is high (> 15) (gocyclo)
-
-
holochain/cmd/hcadmin/hcadmin.go
- Line 23: warning: cyclomatic complexity 49 of function setupApp() is high (> 15) (gocyclo)
-
-
holochain/jsribosome.go
- Line 591: warning: cyclomatic complexity 126 of function NewJSRibosome() is high (> 15) (gocyclo)
- Line 401: warning: cyclomatic complexity 43 of function jsProcessArgs() is high (> 15) (gocyclo)
-
-
holochain/holochain.go
- Line 975: warning: cyclomatic complexity 53 of function (*Holochain).Query() is high (> 15) (gocyclo)
-
-
holochain/action.go
- Line 159: warning: cyclomatic complexity 17 of function (*Holochain).GetValidationResponse() is high (> 15) (gocyclo)
-
-
holochain/apptest/apptest.go
- Line 406: warning: cyclomatic complexity 35 of function DoTest() is high (> 15) (gocyclo)
-
-
holochain/ui/webserver.go
- Line 48: warning: cyclomatic complexity 35 of function (*WebServer).Start() is high (> 15) (gocyclo)
-
-
holochain/zygosome.go
- Line 578: warning: cyclomatic complexity 126 of function NewZygoRibosome() is high (> 15) (gocyclo)
- Line 434: warning: cyclomatic complexity 46 of function zyProcessArgs() is high (> 15) (gocyclo)
-
-
holochain/entry.go
- Line 199: warning: cyclomatic complexity 37 of function sysValidateEntry() is high (> 15) (gocyclo)
-
-
holochain/service.go
- Line 335: warning: cyclomatic complexity 21 of function (*Service).loadDNA() is high (> 15) (gocyclo)
- Line 1098: warning: cyclomatic complexity 18 of function (*Service).saveFromAppPackage() is high (> 15) (gocyclo)
ineffassign80%
IneffAssign detects ineffectual assignments in Go code.
-
-
holochain/warrant_test.go
- Line 63: warning: ineffectual assignment to err (ineffassign)
- Line 65: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/cmd/hcdev/hcdev.go
- Line 252: warning: ineffectual assignment to format (ineffassign)
- Line 610: warning: ineffectual assignment to scenarioBridgeSpecs (ineffassign)
-
-
holochain/action_bundle_test.go
- Line 54: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/action_migrate_test.go
- Line 74: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/agent_test.go
- Line 49: warning: ineffectual assignment to err (ineffassign)
- Line 56: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/buntdbht.go
- Line 544: warning: ineffectual assignment to err (ineffassign)
- Line 637: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/dht_test.go
- Line 69: warning: ineffectual assignment to err (ineffassign)
- Line 72: warning: ineffectual assignment to et (ineffassign)
- Line 136: warning: ineffectual assignment to r (ineffassign)
- Line 403: warning: ineffectual assignment to err (ineffassign)
- Line 458: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/gossip.go
- Line 444: warning: ineffectual assignment to done (ineffassign)
- Line 465: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/zygosome.go
- Line 100: warning: ineffectual assignment to result (ineffassign)
-
-
holochain/ui/webserver.go
- Line 83: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/action_bundleclose.go
- Line 55: warning: ineffectual assignment to err (ineffassign)
- Line 57: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/test_data_test.go
- Line 63: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/validate_test.go
- Line 31: warning: ineffectual assignment to err (ineffassign)
- Line 171: warning: ineffectual assignment to err (ineffassign)
- Line 179: warning: ineffectual assignment to err (ineffassign)
- Line 251: warning: ineffectual assignment to vpkg (ineffassign)
-
-
holochain/world_test.go
- Line 72: warning: ineffectual assignment to err (ineffassign)
- Line 293: warning: ineffectual assignment to propigated (ineffassign)
- Line 305: warning: ineffectual assignment to propigated (ineffassign)
- Line 327: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/zygosome_test.go
- Line 441: warning: ineffectual assignment to err (ineffassign)
- Line 455: warning: ineffectual assignment to err (ineffassign)
- Line 1020: warning: ineffectual assignment to err (ineffassign)
- Line 1027: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/hash/hash_test.go
- Line 18: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/chain_test.go
- Line 746: warning: ineffectual assignment to err (ineffassign)
- Line 748: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/header_test.go
- Line 102: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/log.go
- Line 144: warning: ineffectual assignment to ok (ineffassign)
-
-
holochain/buntdbht_test.go
- Line 55: warning: ineffectual assignment to data (ineffassign)
- Line 88: warning: ineffectual assignment to data (ineffassign)
- Line 88: warning: ineffectual assignment to entryType (ineffassign)
- Line 88: warning: ineffectual assignment to status (ineffassign)
- Line 91: warning: ineffectual assignment to entryType (ineffassign)
- Line 91: warning: ineffectual assignment to status (ineffassign)
- Line 118: warning: ineffectual assignment to data (ineffassign)
- Line 118: warning: ineffectual assignment to entryType (ineffassign)
- Line 118: warning: ineffectual assignment to status (ineffassign)
- Line 121: warning: ineffectual assignment to data (ineffassign)
- Line 121: warning: ineffectual assignment to entryType (ineffassign)
- Line 121: warning: ineffectual assignment to status (ineffassign)
-
-
holochain/chain.go
- Line 607: warning: ineffectual assignment to lastEntry (ineffassign)
-
-
holochain/holochain.go
- Line 800: warning: ineffectual assignment to err (ineffassign)
- Line 803: warning: ineffectual assignment to err (ineffassign)
-
-
holochain/holochain_test.go
- Line 151: warning: ineffectual assignment to val (ineffassign)
-
-
holochain/jsribosome_test.go
- Line 282: warning: ineffectual assignment to err (ineffassign)
- Line 289: warning: ineffectual assignment to err (ineffassign)
- Line 311: warning: ineffectual assignment to err (ineffassign)
- Line 428: warning: ineffectual assignment to err (ineffassign)
- Line 633: warning: ineffectual assignment to err (ineffassign)
- Line 647: warning: ineffectual assignment to err (ineffassign)
- Line 974: warning: ineffectual assignment to err (ineffassign)
- Line 992: warning: ineffectual assignment to v (ineffassign)
-
-
holochain/service.go
- Line 1272: warning: ineffectual assignment to dirContentList (ineffassign)
misspell89%
Misspell Finds commonly misspelled English words
-
-
holochain/app_package.go
- Line 169: warning: "additonal" is a misspelling of "additional" (misspell)
-
-
holochain/kad_query.go
- Line 234: warning: "proccessing" is a misspelling of "processing" (misspell)
-
-
holochain/action.go
- Line 98: warning: "Defintion" is a misspelling of "Definition" (misspell)
-
-
holochain/dht.go
- Line 570: warning: "reciept" is a misspelling of "receipt" (misspell)
- Line 578: warning: "reciept" is a misspelling of "receipt" (misspell)
-
-
holochain/service.go
- Line 1293: warning: "retuns" is a misspelling of "returns" (misspell)
-
-
holochain/zygosome.go
- Line 492: warning: "preceeded" is a misspelling of "preceded" (misspell)
-
-
holochain/action_migrate_test.go
- Line 21: warning: "retreive" is a misspelling of "retrieve" (misspell)
-
-
holochain/chain.go
- Line 249: warning: "funciton" is a misspelling of "function" (misspell)
-
-
holochain/revocation.go
- Line 26: warning: "concatination" is a misspelling of "contamination" (misspell)
-
-
holochain/jsribosome_test.go
- Line 310: warning: "SUCESS" is a misspelling of "SUCCESS" (misspell)
-
-
holochain/node.go
- Line 339: warning: "aquire" is a misspelling of "acquire" (misspell)
-
-
holochain/cmd/common.go
- Line 158: warning: "existance" is a misspelling of "existence" (misspell)
-
-
holochain/holochain.go
- Line 787: warning: "asyncronous" is a misspelling of "asynchronous" (misspell)
- Line 812: warning: "asyncronous" is a misspelling of "asynchronous" (misspell)
-
-
holochain/jsribosome.go
- Line 473: warning: "preceeded" is a misspelling of "preceded" (misspell)