Preparing report...

Report for github.com/metrumresearchgroup/bbi

A    Great!    Found 26 issues across 93 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • bbi/parsers/nmparser/parse_lst_file.go
    • Line 256: warning: cyclomatic complexity 30 of function ParseLstEstimationFile() is high (> 15) (gocyclo)
    • Line 52: warning: cyclomatic complexity 23 of function getMatrixData() is high (> 15) (gocyclo)
    • Line 414: warning: cyclomatic complexity 16 of function mustCalculateConditionNumber() is high (> 15) (gocyclo)
    • bbi/cmd/nonmem.go
    • Line 817: warning: cyclomatic complexity 21 of function nonmemModelsFromArguments() is high (> 15) (gocyclo)
    • Line 688: warning: cyclomatic complexity 17 of function NewNonMemModel() is high (> 15) (gocyclo)

golint88%

Golint is a linter for Go source code.

    • bbi/cmd/nonmem.go
    • Line 928: warning: exported method NonMemModel.LogIdentifier should have comment or be unexported (golint)
    • bbi/cmd/run.go
    • Line 134: warning: exported type PostWorkExecutor should have comment or be unexported (golint)
    • Line 142: warning: exported type PostExecutionHookEnvironment should have comment or be unexported (golint)
    • Line 153: warning: exported function PostExecutionEnvironment should have comment or be unexported (golint)
    • Line 188: warning: exported function PostWorkExecution should have comment or be unexported (golint)
    • Line 229: warning: exported function ExecutePostWorkDirectivesWithEnvironment should have comment or be unexported (golint)
    • bbi/configlib/config.go
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 42: warning: exported method Config.GetPostWorkExecEnvs should have comment or be unexported (golint)
    • Line 46: warning: exported method Config.SetPostWorkExecEnvs should have comment or be unexported (golint)
    • Line 50: warning: exported type NonMemDetail should have comment or be unexported (golint)
    • Line 57: warning: exported type LocalDetail should have comment or be unexported (golint)
    • Line 61: warning: exported type NMFEOptions should have comment or be unexported (golint)
    • Line 72: warning: exported method Config.RenderYamlToFile should have comment or be unexported (golint)
    • Line 126: warning: exported function WriteViperConfig should have comment or be unexported (golint)
    • Line 148: warning: exported function ReadSpecifiedFileIntoConfigStruct should have comment or be unexported (golint)
    • Line 174: warning: exported function LocateAndReadConfigFile should have comment or be unexported (golint)
    • bbi/cmd/local.go
    • Line 40: warning: exported method LocalModel.BuildExecutionEnvironment should have comment or be unexported (golint)
    • Line 53: warning: exported method LocalModel.GetPostWorkConfig should have comment or be unexported (golint)
    • Line 57: warning: exported method LocalModel.GetPostWorkExecutablePath should have comment or be unexported (golint)
    • Line 61: warning: exported method LocalModel.GetGlobalConfig should have comment or be unexported (golint)
    • Line 65: warning: exported method LocalModel.GetWorkingPath should have comment or be unexported (golint)
    • Line 69: warning: comment on exported method LocalModel.CancellationChannel should be of the form "CancellationChannel ..." (golint)
    • Line 502: warning: exported function HashFileOnChannel should have comment or be unexported (golint)
    • bbi/parsers/nmparser/get_model_output.go
    • Line 41: warning: don't use underscores in Go names; var err_msg should be errMsg (golint)
    • Line 42: warning: don't use underscores in Go names; var err_msg should be errMsg (golint)
    • Line 169: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 174: warning: comment on exported function GetCovCorOutput should be of the form "GetCovCorOutput ..." (golint)
    • bbi/parsers/nmparser/structs.go
    • Line 138: warning: comment on exported type ConditionNumDetails should be of the form "ConditionNumDetails ..." (with optional leading article) (golint)
    • Line 227: warning: exported function NewConditionNumDetails should have comment or be unexported (golint)
    • bbi/parsers/nmparser/utils.go
    • Line 22: warning: comment on exported function CheckIfNotGradientBased should be of the form "CheckIfNotGradientBased ..." (golint)
    • Line 42: warning: comment on exported function CheckIfBayesian should be of the form "CheckIfBayesian ..." (golint)
    • bbi/cmd/sge.go
    • Line 36: warning: exported method SGEModel.BuildExecutionEnvironment should have comment or be unexported (golint)
    • Line 49: warning: exported method SGEModel.GetPostWorkConfig should have comment or be unexported (golint)
    • Line 53: warning: exported method SGEModel.GetPostWorkExecutablePath should have comment or be unexported (golint)
    • Line 57: warning: exported method SGEModel.GetGlobalConfig should have comment or be unexported (golint)
    • Line 61: warning: exported method SGEModel.GetWorkingPath should have comment or be unexported (golint)
    • Line 65: warning: comment on exported method SGEModel.CancellationChannel should be of the form "CancellationChannel ..." (golint)
    • Line 66: warning: receiver name l should be consistent with previous receiver name s for SGEModel (golint)
    • Line 71: warning: receiver name l should be consistent with previous receiver name s for SGEModel (golint)
    • Line 120: warning: receiver name l should be consistent with previous receiver name s for SGEModel (golint)
    • Line 136: warning: receiver name l should be consistent with previous receiver name s for SGEModel (golint)
    • Line 141: warning: receiver name l should be consistent with previous receiver name s for SGEModel (golint)

license0%

Checks whether your project has a LICENSE file.


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell95%

Misspell Finds commonly misspelled English words