Preparing report...

Report for github.com/mikn/greddis

A+    Excellent!    Found 7 issues across 18 files

Tweet

gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • greddis/pubsub.go
    • Line 129: warning: cyclomatic complexity 22 of function (*subscriptionManager).Listen() is high (> 15) (gocyclo)
    • Line 294: warning: cyclomatic complexity 16 of function (*subscriptionManager).Unsubscribe() is high (> 15) (gocyclo)

golint72%

Golint is a linter for Go source code.

    • greddis/client.go
    • Line 1: warning: package comment should be of the form "Package greddis ..." (golint)
    • Line 21: warning: exported type PubSubOpts should have comment or be unexported (golint)
    • Line 29: warning: exported type Subscriber should have comment or be unexported (golint)
    • Line 54: warning: exported type SubClient should have comment or be unexported (golint)
    • greddis/pubsub.go
    • Line 22: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
    • Line 34: warning: exported method Message.Init should have comment or be unexported (golint)
    • Line 39: warning: exported method Message.Pattern should have comment or be unexported (golint)
    • Line 43: warning: exported method Message.Topic should have comment or be unexported (golint)
    • Line 59: warning: exported type MessageChan should have comment or be unexported (golint)
    • Line 61: warning: exported type MessageChanMap should have comment or be unexported (golint)
    • greddis/reader.go
    • Line 12: warning: exported type ScanFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type Reader should have comment or be unexported (golint)
    • Line 31: warning: exported function NewReader should have comment or be unexported (golint)
    • Line 38: warning: exported method Reader.Len should have comment or be unexported (golint)
    • Line 42: warning: exported method Reader.Next should have comment or be unexported (golint)
    • Line 50: warning: exported method Reader.WriteTo should have comment or be unexported (golint)
    • Line 64: warning: exported method Reader.Bytes should have comment or be unexported (golint)
    • Line 69: warning: exported method Reader.Int should have comment or be unexported (golint)
    • Line 74: warning: exported function ScanSimpleString should have comment or be unexported (golint)
    • Line 78: warning: exported function ScanInteger should have comment or be unexported (golint)
    • Line 82: warning: exported function ScanBulkString should have comment or be unexported (golint)
    • Line 86: warning: exported function ScanArray should have comment or be unexported (golint)
    • greddis/result.go
    • Line 1: warning: package comment should be of the form "Package greddis ..." (golint)
    • Line 23: warning: exported function NewResult should have comment or be unexported (golint)
    • greddis/array.go
    • Line 12: warning: exported type StrInt should have comment or be unexported (golint)
    • Line 23: warning: exported function NewArrayWriter should have comment or be unexported (golint)
    • Line 30: warning: exported type ArrayWriter should have comment or be unexported (golint)
    • Line 37: warning: exported method ArrayWriter.Init should have comment or be unexported (golint)
    • Line 45: warning: exported method ArrayWriter.Len should have comment or be unexported (golint)
    • Line 49: warning: exported method ArrayWriter.Add should have comment or be unexported (golint)
    • Line 61: warning: exported method ArrayWriter.AddString should have comment or be unexported (golint)
    • Line 69: warning: exported method ArrayWriter.Flush should have comment or be unexported (golint)
    • Line 79: warning: exported method ArrayWriter.Reset should have comment or be unexported (golint)
    • Line 116: warning: receiver name c should be consistent with previous receiver name w for ArrayWriter (golint)
    • Line 120: warning: receiver name c should be consistent with previous receiver name w for ArrayWriter (golint)
    • Line 172: warning: exported function NewArrayReader should have comment or be unexported (golint)
    • Line 178: warning: exported type ArrayReader should have comment or be unexported (golint)
    • Line 191: warning: exported method ArrayReader.Err should have comment or be unexported (golint)
    • Line 195: warning: exported method ArrayReader.Init should have comment or be unexported (golint)
    • Line 204: warning: exported method ArrayReader.NextIs should have comment or be unexported (golint)
    • Line 204: warning: receiver name r should be consistent with previous receiver name a for ArrayReader (golint)
    • Line 214: warning: receiver name r should be consistent with previous receiver name a for ArrayReader (golint)
    • Line 225: warning: receiver name r should be consistent with previous receiver name a for ArrayReader (golint)
    • Line 239: warning: receiver name r should be consistent with previous receiver name a for ArrayReader (golint)
    • Line 247: warning: receiver name r should be consistent with previous receiver name a for ArrayReader (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign94%

IneffAssign detects ineffectual assignments in Go code.

    • greddis/client_test.go
    • Line 65: warning: ineffectual assignment to err (ineffassign)
    • Line 80: warning: ineffectual assignment to err (ineffassign)
    • Line 106: warning: ineffectual assignment to err (ineffassign)
    • Line 133: warning: ineffectual assignment to err (ineffassign)
    • Line 151: warning: ineffectual assignment to err (ineffassign)
    • Line 168: warning: ineffectual assignment to err (ineffassign)
    • Line 183: warning: ineffectual assignment to err (ineffassign)
    • Line 212: warning: ineffectual assignment to err (ineffassign)
    • Line 237: warning: ineffectual assignment to err (ineffassign)
    • Line 252: warning: ineffectual assignment to err (ineffassign)
    • Line 266: warning: ineffectual assignment to err (ineffassign)
    • Line 295: warning: ineffectual assignment to err (ineffassign)
    • Line 310: warning: ineffectual assignment to err (ineffassign)
    • Line 331: warning: ineffectual assignment to err (ineffassign)
    • Line 347: warning: ineffectual assignment to err (ineffassign)
    • Line 364: warning: ineffectual assignment to err (ineffassign)
    • Line 379: warning: ineffectual assignment to err (ineffassign)
    • Line 408: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!