Go Report Card

Preparing report...

Report for github.com/minishift/minishift

A+    Excellent!    Found 152 issues across 317 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint55%

Golint is a linter for Go source code.

    • minishift/pkg/minishift/profile/profile.go
    • Line 30: warning: comment on exported function GetProfileList should be of the form "GetProfileList ..." (golint)
    • Line 61: warning: comment on exported function SetActiveProfile should be of the form "SetActiveProfile ..." (golint)
    • Line 75: warning: comment on exported function GetActiveProfile should be of the form "GetActiveProfile ..." (golint)
    • Line 83: warning: exported function SetDefaultProfileActive should have comment or be unexported (golint)
    • minishift/cmd/minishift/cmd/config/util.go
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 59: warning: exported function SetString should have comment or be unexported (golint)
    • Line 64: warning: exported function SetInt should have comment or be unexported (golint)
    • Line 73: warning: exported function SetBool should have comment or be unexported (golint)
    • Line 82: warning: exported function SetSlice should have comment or be unexported (golint)
    • Line 93: warning: exported function RequiresRestartMsg should have comment or be unexported (golint)
    • minishift/pkg/minishift/docker/image/oci_image_handler.go
    • Line 57: warning: exported type Index should have comment or be unexported (golint)
    • Line 62: warning: exported type SchemaVersion should have comment or be unexported (golint)
    • Line 64: warning: exported type Manifests should have comment or be unexported (golint)
    • Line 66: warning: exported type Manifest should have comment or be unexported (golint)
    • Line 74: warning: exported type Annotations should have comment or be unexported (golint)
    • Line 78: warning: exported type Platform should have comment or be unexported (golint)
    • Line 219: warning: exported method OciImageHandler.GetCachedImages should have comment or be unexported (golint)
    • Line 234: warning: exported method OciImageHandler.GetDockerImages should have comment or be unexported (golint)
    • Line 464: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 493: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • minishift/pkg/util/input.go
    • Line 29: warning: exported function ReadInputFromStdin should have comment or be unexported (golint)
    • Line 36: warning: exported function IsTtySupported should have comment or be unexported (golint)
    • Line 41: warning: exported function ReadPasswordFromStdin should have comment or be unexported (golint)
    • Line 52: warning: exported function AskForConfirmation should have comment or be unexported (golint)
    • Line 58: warning: comment on exported function GetPasswordKeyring should be of the form "GetPasswordKeyring ..." (golint)
    • Line 67: warning: comment on exported function SetPasswordKeyring should be of the form "SetPasswordKeyring ..." (golint)
    • minishift/pkg/util/runner.go
    • Line 25: warning: exported type Runner should have comment or be unexported (golint)
    • Line 30: warning: exported type RealRunner should have comment or be unexported (golint)
    • Line 34: warning: comment on exported method RealRunner.Output should be of the form "Output ..." (golint)
    • Line 47: warning: exported method RealRunner.Run should have comment or be unexported (golint)
    • minishift/pkg/minishift/addon/parser/command_handler.go
    • Line 37: warning: exported type CommandHandler should have comment or be unexported (golint)
    • Line 69: warning: exported type DockerCommandHandler should have comment or be unexported (golint)
    • Line 73: warning: exported method DockerCommandHandler.Parse should have comment or be unexported (golint)
    • Line 80: warning: exported type OcCommandHandler should have comment or be unexported (golint)
    • Line 84: warning: exported method OcCommandHandler.Parse should have comment or be unexported (golint)
    • Line 91: warning: exported type OpenShiftCommandHandler should have comment or be unexported (golint)
    • Line 95: warning: exported method OpenShiftCommandHandler.Parse should have comment or be unexported (golint)
    • Line 102: warning: exported type SleepCommandHandler should have comment or be unexported (golint)
    • Line 106: warning: exported method SleepCommandHandler.Parse should have comment or be unexported (golint)
    • Line 113: warning: exported type SSHCommandHandler should have comment or be unexported (golint)
    • Line 117: warning: exported method SSHCommandHandler.Parse should have comment or be unexported (golint)
    • Line 124: warning: exported type EchoCommandHandler should have comment or be unexported (golint)
    • Line 128: warning: exported method EchoCommandHandler.Parse should have comment or be unexported (golint)
    • Line 135: warning: exported type CatCommandHandler should have comment or be unexported (golint)
    • Line 139: warning: exported method CatCommandHandler.Parse should have comment or be unexported (golint)
    • minishift/pkg/minishift/hostfolder/sshfs_hostfolder.go
    • Line 42: warning: exported var SftpPort should have comment or be unexported (golint)
    • Line 45: warning: exported type SSHFSHostFolder should have comment or be unexported (golint)
    • Line 50: warning: exported function NewSSHFSHostFolder should have comment or be unexported (golint)
    • Line 54: warning: exported method SSHFSHostFolder.Config should have comment or be unexported (golint)
    • Line 58: warning: exported method SSHFSHostFolder.Mount should have comment or be unexported (golint)
    • Line 106: warning: exported method SSHFSHostFolder.Umount should have comment or be unexported (golint)
    • Line 207: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • minishift/pkg/util/crypto.go
    • Line 44: warning: comment on exported function GenerateSelfSignedCert should be of the form "GenerateSelfSignedCert ..." (golint)
    • Line 103: warning: comment on exported function EncryptText should be of the form "EncryptText ..." (golint)
    • Line 124: warning: comment on exported function DecryptText should be of the form "DecryptText ..." (golint)
    • minishift/cmd/minishift/cmd/util/oc.go
    • Line 64: warning: exported function SetOcContext should have comment or be unexported (golint)
    • Line 74: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 79: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 84: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 92: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 97: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 101: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 128: warning: error should be the last type when returning multiple items (golint)
    • minishift/pkg/minishift/systemtray/minishifttray.go
    • Line 34: warning: exported type MinishiftTray should have comment or be unexported (golint)
    • Line 38: warning: exported function NewMinishiftTray should have comment or be unexported (golint)
    • Line 62: warning: exported method MinishiftTray.EnsureRunning should have comment or be unexported (golint)
    • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 109: warning: exported method MinishiftTray.GetPID should have comment or be unexported (golint)
    • minishift/pkg/minishift/update/update.go
    • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 93: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 161: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 178: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 221: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 232: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 317: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • minishift/pkg/util/proxy.go
    • Line 28: warning: exported const OpenShiftRegistryIp should have comment or be unexported (golint)
    • Line 122: warning: comment on exported method ProxyConfig.OverrideHttpProxy should be of the form "OverrideHttpProxy ..." (golint)
    • Line 127: warning: comment on exported method ProxyConfig.OverrideHttpsProxy should be of the form "OverrideHttpsProxy ..." (golint)
    • Line 146: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 156: warning: comment on exported method ProxyConfig.ApplyToEnvironment should be of the form "ApplyToEnvironment ..." (golint)
    • Line 174: warning: comment on exported method ProxyConfig.IsEnabled should be of the form "IsEnabled ..." (golint)
    • minishift/pkg/minishift/oc/oc.go
    • Line 46: warning: exported type OcRunner should have comment or be unexported (golint)
    • Line 66: warning: exported method OcRunner.Run should have comment or be unexported (golint)
    • Line 75: warning: exported method OcRunner.RunAsUser should have comment or be unexported (golint)
    • Line 93: warning: comment on exported method OcRunner.AddSystemAdminEntryToKubeConfig should be of the form "AddSystemAdminEntryToKubeConfig ..." (golint)
    • Line 159: warning: exported function SupportFlag should have comment or be unexported (golint)
    • minishift/pkg/minishift/config/instance_state_config.go
    • Line 28: warning: exported var InstanceStateConfig should have comment or be unexported (golint)
    • Line 30: warning: exported type InstanceStateConfigType should have comment or be unexported (golint)
    • Line 44: warning: comment on exported function NewInstanceStateConfig should be of the form "NewInstanceStateConfig ..." (golint)
    • Line 78: warning: exported method InstanceStateConfigType.Delete should have comment or be unexported (golint)
    • minishift/pkg/minishift/hostfolder/cifs_hostfolder.go
    • Line 31: warning: exported type CifsHostFolder should have comment or be unexported (golint)
    • Line 35: warning: exported function NewCifsHostFolder should have comment or be unexported (golint)
    • Line 39: warning: exported method CifsHostFolder.Config should have comment or be unexported (golint)
    • Line 43: warning: exported method CifsHostFolder.Mount should have comment or be unexported (golint)
    • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 96: warning: exported method CifsHostFolder.Umount should have comment or be unexported (golint)
    • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • minishift/pkg/minishift/addon/command/cat_command.go
    • Line 26: warning: exported type CatCommand should have comment or be unexported (golint)
    • Line 30: warning: exported function NewCatCommand should have comment or be unexported (golint)
    • Line 49: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 59: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • minishift/pkg/util/utils.go
    • Line 29: warning: exported type RetriableError should have comment or be unexported (golint)
    • Line 57: warning: exported function Pad should have comment or be unexported (golint)
    • Line 61: warning: exported function Retry should have comment or be unexported (golint)
    • Line 65: warning: exported function RetryAfter should have comment or be unexported (golint)
    • Line 81: warning: exported type MultiError should have comment or be unexported (golint)
    • Line 85: warning: exported method MultiError.Collect should have comment or be unexported (golint)
    • Line 91: warning: exported method MultiError.ToError should have comment or be unexported (golint)
    • Line 122: warning: exported function FriendlyDuration should have comment or be unexported (golint)
    • minishift/pkg/minishift/config/instance_config.go
    • Line 29: warning: exported var InstanceConfig should have comment or be unexported (golint)
    • Line 31: warning: exported type InstanceConfigType should have comment or be unexported (golint)
    • Line 38: warning: comment on exported function NewInstanceConfig should be of the form "NewInstanceConfig ..." (golint)
    • Line 72: warning: exported method InstanceConfigType.Delete should have comment or be unexported (golint)
    • minishift/pkg/minishift/network/dns/localdns_systemd.go
    • Line 41: warning: exported type SystemdDnsService should have comment or be unexported (golint)
    • Line 51: warning: comment on exported method SystemdDnsService.Status should be of the form "Status ..." (golint)
    • Line 61: warning: exported method SystemdDnsService.Start should have comment or be unexported (golint)
    • Line 71: warning: exported method SystemdDnsService.Stop should have comment or be unexported (golint)
    • Line 75: warning: exported method SystemdDnsService.Restart should have comment or be unexported (golint)
    • minishift/pkg/minishift/hostfolder/config/hostfolder_config.go
    • Line 20: warning: exported const Source should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported type HostFolderConfig should have comment or be unexported (golint)
    • Line 35: warning: exported method HostFolderConfig.Option should have comment or be unexported (golint)
    • Line 39: warning: exported method HostFolderConfig.MountPoint should have comment or be unexported (golint)
    • minishift/pkg/minishift/config/viper_config.go
    • Line 27: warning: exported type ViperConfig should have comment or be unexported (golint)
    • Line 29: warning: comment on exported function ReadViperConfig should be of the form "ReadViperConfig ..." (golint)
    • Line 47: warning: comment on exported function WriteViperConfig should be of the form "WriteViperConfig ..." (golint)
    • Line 61: warning: exported function Decode should have comment or be unexported (golint)
    • Line 67: warning: exported function Encode should have comment or be unexported (golint)
    • minishift/pkg/minishift/addon/addon_meta.go
    • Line 31: warning: exported const NameMetaTagName should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type RequiredVar should have comment or be unexported (golint)
    • Line 59: warning: exported type DefaultAddOnMeta should have comment or be unexported (golint)
    • Line 63: warning: exported function NewAddOnMeta should have comment or be unexported (golint)
    • Line 88: warning: exported method DefaultAddOnMeta.Name should have comment or be unexported (golint)
    • Line 92: warning: exported method DefaultAddOnMeta.Description should have comment or be unexported (golint)
    • Line 96: warning: exported method DefaultAddOnMeta.Url should have comment or be unexported (golint)
    • Line 109: warning: exported method DefaultAddOnMeta.RequiredVars should have comment or be unexported (golint)
    • Line 112: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 117: warning: exported method DefaultAddOnMeta.VarDefaults should have comment or be unexported (golint)
    • Line 137: warning: exported method DefaultAddOnMeta.GetValue should have comment or be unexported (golint)
    • Line 141: warning: exported method DefaultAddOnMeta.OpenShiftVersion should have comment or be unexported (golint)
    • Line 148: warning: exported method DefaultAddOnMeta.MinishiftVersion should have comment or be unexported (golint)
    • Line 155: warning: exported method DefaultAddOnMeta.Dependency should have comment or be unexported (golint)
    • Line 182: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 187: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 191: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 234: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 238: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • minishift/pkg/minishift/openshift/version/openshift_versions.go
    • Line 37: warning: exported function GetOpenshiftVersion should have comment or be unexported (golint)
    • Line 82: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 98: warning: exported function GetGithubReleases should have comment or be unexported (golint)
    • Line 116: warning: exported function OpenShiftTagsByAscending should have comment or be unexported (golint)
    • minishift/pkg/version/version.go
    • Line 25: warning: exported const VersionPrefix should have comment or be unexported (golint)
    • Line 42: warning: exported function GetMinishiftVersion should have comment or be unexported (golint)
    • Line 46: warning: exported function GetSemverVersion should have comment or be unexported (golint)
    • Line 50: warning: exported function GetOpenShiftVersion should have comment or be unexported (golint)
    • Line 54: warning: exported function GetCentOsIsoVersion should have comment or be unexported (golint)
    • Line 58: warning: exported function GetCommitSha should have comment or be unexported (golint)
    • minishift/pkg/testing/runner_mock.go
    • Line 30: warning: exported type Runner should have comment or be unexported (golint)
    • Line 32: warning: exported type FakeRunner should have comment or be unexported (golint)
    • Line 36: warning: exported type ExpectedCommand should have comment or be unexported (golint)
    • Line 41: warning: exported function NewFakeRunner should have comment or be unexported (golint)
    • Line 47: warning: exported method FakeRunner.ExpectAndReturn should have comment or be unexported (golint)
    • Line 55: warning: exported method Runner.Output should have comment or be unexported (golint)
    • Line 68: warning: exported method Runner.Run should have comment or be unexported (golint)
    • minishift/pkg/minishift/provisioner/buildroot_provisioner.go
    • Line 34: warning: exported function NewBuildrootProvisioner should have comment or be unexported (golint)
    • Line 42: warning: exported type BuildrootProvisioner should have comment or be unexported (golint)
    • Line 50: warning: exported method BuildrootProvisioner.GenerateDockerOptions should have comment or be unexported (golint)
    • Line 77: warning: exported method BuildrootProvisioner.Package should have comment or be unexported (golint)
    • Line 81: warning: exported method BuildrootProvisioner.Provision should have comment or be unexported (golint)
    • Line 90: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • minishift/pkg/util/github/github.go
    • Line 46: warning: exported type OpenShiftBinaryType should have comment or be unexported (golint)
    • Line 49: warning: exported const OC should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: exported const TAR should have comment (or a comment on this block) or be unexported (golint)
    • Line 67: warning: exported function Client should have comment or be unexported (golint)
    • Line 84: warning: exported function GetGitHubApiToken should have comment or be unexported (golint)
    • Line 94: warning: exported function ListOptions should have comment or be unexported (golint)
    • Line 98: warning: exported function IsRateLimitError should have comment or be unexported (golint)
    • Line 105: warning: exported function DownloadOpenShiftReleaseBinary should have comment or be unexported (golint)
    • minishift/pkg/util/os/os.go
    • Line 26: warning: exported type OS should have comment or be unexported (golint)
    • Line 29: warning: exported const LINUX should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported function CurrentOS should have comment or be unexported (golint)
    • Line 50: warning: exported function CurrentExecutable should have comment or be unexported (golint)
    • Line 58: warning: exported function CurrentUser should have comment or be unexported (golint)
    • minishift/pkg/minishift/systemtray/systemtray.go
    • Line 47: warning: exported const WEB_CONSOLE should have comment (or a comment on this block) or be unexported (golint)
    • Line 54: warning: exported const START_PROFILE should have comment (or a comment on this block) or be unexported (golint)
    • Line 69: warning: exported type MenuAction should have comment or be unexported (golint)
    • Line 75: warning: exported function OnReady should have comment or be unexported (golint)
    • Line 105: warning: exported function OnExit should have comment or be unexported (golint)
    • minishift/pkg/minishift/addon/addon.go
    • Line 71: warning: exported function NewAddOn should have comment or be unexported (golint)
    • Line 82: warning: exported method DefaultAddOn.Commands should have comment or be unexported (golint)
    • Line 86: warning: exported method DefaultAddOn.RemoveCommands should have comment or be unexported (golint)
    • Line 90: warning: exported method DefaultAddOn.MetaData should have comment or be unexported (golint)
    • Line 94: warning: exported method DefaultAddOn.MetaDataForAddonRemove should have comment or be unexported (golint)
    • Line 98: warning: exported method DefaultAddOn.IsEnabled should have comment or be unexported (golint)
    • Line 102: warning: exported method DefaultAddOn.SetEnabled should have comment or be unexported (golint)
    • Line 106: warning: exported method DefaultAddOn.SetPriority should have comment or be unexported (golint)
    • Line 110: warning: exported method DefaultAddOn.GetPriority should have comment or be unexported (golint)
    • Line 114: warning: exported method DefaultAddOn.InstallPath should have comment or be unexported (golint)
    • Line 118: warning: receiver name meta should be consistent with previous receiver name a for DefaultAddOn (golint)
    • Line 147: warning: comment on exported type ByStatusThenPriorityThenName should be of the form "ByStatusThenPriorityThenName ..." (with optional leading article) (golint)
    • minishift/cmd/minishift/state/instance_dirs.go
    • Line 25: warning: exported type MinishiftDirs should have comment or be unexported (golint)
    • Line 40: warning: exported var InstanceDirs should have comment or be unexported (golint)
    • Line 42: warning: comment on exported function GetMinishiftDirsStructure should be of the form "GetMinishiftDirsStructure ..." (golint)
    • minishift/pkg/minishift/network/utils.go
    • Line 36: warning: exported var VMSwitch should have comment or be unexported (golint)
    • Line 38: warning: comment on exported function GetIP should be of the form "GetIP ..." (golint)
    • Line 47: warning: exported function DetermineHostIP should have comment or be unexported (golint)
    • Line 114: warning: exported function HasNameserverConfiguredLocally should have comment or be unexported (golint)
    • Line 123: warning: comment on exported function OverrideInsecureSkipVerifyForLocalConnections should be of the form "OverrideInsecureSkipVerifyForLocalConnections ..." (golint)
    • minishift/pkg/minishift/network/proxy/localproxy.go
    • Line 45: warning: exported function StartProxy should have comment or be unexported (golint)
    • Line 92: warning: exported function SetBasicAuth should have comment or be unexported (golint)
    • Line 117: warning: exported function EnsureProxyDaemonRunning should have comment or be unexported (golint)
    • Line 159: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 184: warning: exported function GetPID should have comment or be unexported (golint)
    • minishift/pkg/minishift/network/dns/localdns_docker.go
    • Line 54: warning: exported type DockerDnsService should have comment or be unexported (golint)
    • Line 64: warning: comment on exported method DockerDnsService.Status should be of the form "Status ..." (golint)
    • Line 74: warning: exported method DockerDnsService.Restart should have comment or be unexported (golint)
    • Line 97: warning: exported method DockerDnsService.Start should have comment or be unexported (golint)
    • Line 122: warning: exported method DockerDnsService.Stop should have comment or be unexported (golint)
    • minishift/pkg/minishift/timezone/timezone.go
    • Line 28: warning: exported function SetTimeZone should have comment or be unexported (golint)
    • Line 39: warning: exported function UpdateTimeZoneInConfig should have comment or be unexported (golint)
    • Line 47: warning: exported function UpdateTimeZone should have comment or be unexported (golint)
    • Line 57: warning: exported function GetTimeZone should have comment or be unexported (golint)
    • Line 67: warning: exported function GetTimeZoneList should have comment or be unexported (golint)
    • minishift/cmd/testing/cli/harness.go
    • Line 83: warning: comment on exported function PreventExitWithNonZeroExitCode should be of the form "PreventExitWithNonZeroExitCode ..." (golint)
    • Line 101: warning: exported function TearDown should have comment or be unexported (golint)
    • minishift/pkg/minishift/addon/command/execution_context.go
    • Line 58: warning: exported method ExecutionContext.AddToContext should have comment or be unexported (golint)
    • Line 62: warning: exported method ExecutionContext.RemoveFromContext should have comment or be unexported (golint)
    • Line 66: warning: exported method ExecutionContext.Interpolate should have comment or be unexported (golint)
    • Line 70: warning: exported method ExecutionContext.Vars should have comment or be unexported (golint)
    • minishift/cmd/minishift/cmd/util/env.go
    • Line 33: warning: error var BooleanFormatError should have name of the form ErrFoo (golint)
    • Line 33: warning: exported var BooleanFormatError should have comment or be unexported (golint)
    • Line 34: warning: error var BooleanNoValueError should have name of the form ErrFoo (golint)
    • minishift/pkg/minishift/clusterup/clusterup.go
    • Line 50: warning: exported type ClusterUpConfig should have comment or be unexported (golint)
    • Line 169: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 179: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 202: warning: exported function CopyOcBinaryFromImageToVM should have comment or be unexported (golint)
    • minishift/pkg/minikube/constants/constants.go
    • Line 28: warning: exported const APIServerPort should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported var Minipath should be of the form "Minipath ..." (golint)
    • Line 45: warning: exported var ProfileName should have comment or be unexported (golint)
    • Line 75: warning: exported function GetProfileConfigFile should have comment or be unexported (golint)
    • Line 79: warning: comment on exported function GetMinishiftHomeDir should be of the form "GetMinishiftHomeDir ..." (golint)
    • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • minishift/pkg/minishift/constants/constants.go
    • Line 27: warning: exported const CentOsIsoAlias should have comment (or a comment on this block) or be unexported (golint)
    • Line 49: warning: exported var ValidIsoAliases should have comment or be unexported (golint)
    • Line 64: warning: exported function GetOpenshiftImageToFetchOC should have comment or be unexported (golint)
    • minishift/pkg/minikube/tests/driver_mock.go
    • Line 38: warning: exported method MockDriver.DriverName should have comment or be unexported (golint)
    • Line 48: warning: exported method MockDriver.GetIP should have comment or be unexported (golint)
    • Line 70: warning: exported method MockDriver.GetSSHPort should have comment or be unexported (golint)
    • Line 82: warning: comment on exported method MockDriver.GetSSHKeyPath should be of the form "GetSSHKeyPath ..." (golint)
    • minishift/pkg/minishift/registration/utils.go
    • Line 27: warning: exported type RegistrationParameters should have comment or be unexported (golint)
    • Line 37: warning: comment on exported function NeedRegistration should be of the form "NeedRegistration ..." (golint)
    • Line 44: warning: exported type RegistrationHostActionFunc should have comment or be unexported (golint)
    • Line 57: warning: comment on exported function RegisterHostVM should be of the form "RegisterHostVM ..." (golint)
    • Line 82: warning: comment on exported function UnregisterHostVM should be of the form "UnregisterHostVM ..." (golint)
    • minishift/cmd/minishift/cmd/completion.go
    • Line 102: warning: exported function GenerateBashCompletion should have comment or be unexported (golint)
    • Line 116: warning: exported function GenerateZshCompletion should have comment or be unexported (golint)
    • Line 117: warning: don't use underscores in Go names; var zsh_initialization should be zshInitialization (golint)
    • Line 270: warning: don't use underscores in Go names; var zsh_tail should be zshTail (golint)
    • minishift/pkg/minishift/registration/registration.go
    • Line 28: warning: exported var ErrDetectionFailed should have comment or be unexported (golint)
    • Line 33: warning: exported type Detector should have comment or be unexported (golint)
    • Line 37: warning: exported type StandardRegistrator should have comment or be unexported (golint)
    • Line 39: warning: exported function SetDetector should have comment or be unexported (golint)
    • Line 43: warning: comment on exported type Registrator should be of the form "Registrator ..." (with optional leading article) (golint)
    • Line 65: warning: exported function Register should have comment or be unexported (golint)
    • Line 69: warning: exported function DetectRegistrator should have comment or be unexported (golint)
    • Line 73: warning: exported method StandardRegistrator.DetectRegistrator should have comment or be unexported (golint)
    • minishift/pkg/minishift/config/validations.go
    • Line 40: warning: exported function IsValidDriver should have comment or be unexported (golint)
    • Line 90: warning: exported function IsValidDiskSize should have comment or be unexported (golint)
    • Line 94: warning: exported function IsValidMemorySize should have comment or be unexported (golint)
    • Line 98: warning: exported function IsPositive should have comment or be unexported (golint)
    • Line 109: warning: exported function IsValidCIDR should have comment or be unexported (golint)
    • Line 117: warning: exported function IsValidPath should have comment or be unexported (golint)
    • Line 125: warning: exported function IsValidProxy should have comment or be unexported (golint)
    • Line 132: warning: exported function IsValidISOUrl should have comment or be unexported (golint)
    • Line 172: warning: exported function IsValidIPv4AddressSlice should have comment or be unexported (golint)
    • Line 185: warning: exported function IsValidIPv4Address should have comment or be unexported (golint)
    • Line 194: warning: exported function IsValidNetmask should have comment or be unexported (golint)
    • Line 218: warning: exported function IsValidPort should have comment or be unexported (golint)
    • Line 229: warning: exported function IsSystemTrayAvailable should have comment or be unexported (golint)
    • Line 236: warning: exported function IsValidTimezone should have comment or be unexported (golint)
    • minishift/pkg/minishift/network/dns/localdns.go
    • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 73: warning: exported function Status should have comment or be unexported (golint)
    • Line 77: warning: exported function Start should have comment or be unexported (golint)
    • Line 97: warning: exported function Stop should have comment or be unexported (golint)
    • minishift/pkg/minishift/config/allinstancesconfig.go
    • Line 27: warning: exported var AllInstancesConfig should have comment or be unexported (golint)
    • Line 29: warning: exported type GlobalConfigType should have comment or be unexported (golint)
    • Line 39: warning: comment on exported function NewAllInstancesConfig should be of the form "NewAllInstancesConfig ..." (golint)
    • Line 73: warning: exported method GlobalConfigType.Delete should have comment or be unexported (golint)
    • minishift/pkg/testing/http_mock.go
    • Line 32: warning: exported const OCTET_STREAM should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported var DefaultRoundTripper should have comment or be unexported (golint)
    • Line 49: warning: exported function ResetDefaultRoundTripper should have comment or be unexported (golint)
    • Line 61: warning: exported type ResponseType should have comment or be unexported (golint)
    • Line 64: warning: exported const SERVE_STRING should have comment (or a comment on this block) or be unexported (golint)
    • Line 68: warning: exported type CannedResponse should have comment or be unexported (golint)
    • Line 74: warning: exported function NewMockRoundTripper should have comment or be unexported (golint)
    • Line 83: warning: exported method MockRoundTripper.RoundTrip should have comment or be unexported (golint)
    • Line 129: warning: exported method MockRoundTripper.RegisterResponse should have comment or be unexported (golint)
    • Line 133: warning: exported method MockRoundTripper.Verbose should have comment or be unexported (golint)
    • Line 137: warning: exported method MockRoundTripper.AllowDelegation should have comment or be unexported (golint)
    • minishift/cmd/testing/cli/viper.go
    • Line 30: warning: exported type TestOption should have comment or be unexported (golint)
    • Line 38: warning: exported function RunCommand should have comment or be unexported (golint)
    • Line 44: warning: exported function SetOptionValue should have comment or be unexported (golint)
    • Line 60: warning: exported function UnsetValues should have comment or be unexported (golint)
    • Line 72: warning: comment on exported function HideEnv should be of the form "HideEnv ..." (golint)
    • Line 93: warning: exported function InitTestConfig should have comment or be unexported (golint)
    • minishift/pkg/util/os/atexit/atexit.go
    • Line 26: warning: exported const ExitHandlerPanicMessage should have comment or be unexported (golint)
    • Line 51: warning: comment on exported function RegisterExitHandler should be of the form "RegisterExitHandler ..." (golint)
    • minishift/pkg/minikube/tests/provision_mock.go
    • Line 29: warning: comment on exported type MockProvisioner should be of the form "MockProvisioner ..." (with optional leading article) (golint)
    • Line 38: warning: exported method MockProvisioner.Service should have comment or be unexported (golint)
    • Line 42: warning: exported method MockProvisioner.Package should have comment or be unexported (golint)
    • Line 46: warning: exported method MockProvisioner.Hostname should have comment or be unexported (golint)
    • Line 50: warning: exported method MockProvisioner.SetHostname should have comment or be unexported (golint)
    • Line 54: warning: exported method MockProvisioner.GetDockerOptionsDir should have comment or be unexported (golint)
    • Line 58: warning: exported method MockProvisioner.GetAuthOptions should have comment or be unexported (golint)
    • Line 62: warning: exported method MockProvisioner.GenerateDockerOptions should have comment or be unexported (golint)
    • Line 66: warning: exported method MockProvisioner.CompatibleWithHost should have comment or be unexported (golint)
    • Line 70: warning: exported method MockProvisioner.SetOsReleaseInfo should have comment or be unexported (golint)
    • Line 73: warning: exported method MockProvisioner.GetOsReleaseInfo should have comment or be unexported (golint)
    • Line 77: warning: exported method MockProvisioner.AttemptIPContact should have comment or be unexported (golint)
    • Line 80: warning: exported method MockProvisioner.Provision should have comment or be unexported (golint)
    • Line 85: warning: exported method MockProvisioner.SSHCommand should have comment or be unexported (golint)
    • Line 89: warning: exported method MockProvisioner.GetDriver should have comment or be unexported (golint)
    • Line 93: warning: comment on exported method MockProvisioner.GetSwarmOptions should be of the form "GetSwarmOptions ..." (golint)
    • Line 98: warning: exported type MockDetector should have comment or be unexported (golint)
    • Line 102: warning: exported method MockDetector.DetectProvisioner should have comment or be unexported (golint)
    • minishift/pkg/minishift/registration/redhat.go
    • Line 34: warning: exported const RHSMName should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported function NewRedHatRegistrator should have comment or be unexported (golint)
    • Line 50: warning: exported type RedHatRegistrator should have comment or be unexported (golint)
    • Line 187: warning: comment on exported method RedHatRegistrator.IsRegistered should be of the form "IsRegistered ..." (golint)
    • Line 191: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • minishift/pkg/util/shell/shell.go
    • Line 32: warning: exported type ShellConfig should have comment or be unexported (golint)
    • Line 39: warning: exported function GetShell should have comment or be unexported (golint)
    • Line 42: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 58: warning: exported function FindNoProxyFromEnv should have comment or be unexported (golint)
    • Line 83: warning: exported function GenerateUsageHint should have comment or be unexported (golint)
    • Line 105: warning: exported function GetPrefixSuffixDelimiterForSet should have comment or be unexported (golint)
    • Line 136: warning: exported function GetPrefixSuffixDelimiterForUnSet should have comment or be unexported (golint)
    • minishift/pkg/minikube/cluster/cluster.go
    • Line 58: warning: exported const SshCommunicationError should have comment (or a comment on this block) or be unexported (golint)
    • Line 291: warning: exported method MachineConfig.ShouldCacheMinikubeISO should have comment or be unexported (golint)
    • Line 305: warning: exported method MachineConfig.GetISOCacheFilepath should have comment or be unexported (golint)
    • Line 309: warning: exported method MachineConfig.GetISOFileURI should have comment or be unexported (golint)
    • Line 322: warning: exported method MachineConfig.IsMinikubeISOCached should have comment or be unexported (golint)
    • Line 439: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 449: warning: exported function CheckIfApiExistsAndLoad should have comment or be unexported (golint)
    • Line 465: warning: exported function CreateSSHShell should have comment or be unexported (golint)
    • Line 493: warning: exported function GetConsoleURL should have comment or be unexported (golint)
    • Line 506: warning: exported function GetHostIP should have comment or be unexported (golint)
    • minishift/pkg/minishift/docker/docker.go
    • Line 29: warning: exported type DockerCommander should have comment or be unexported (golint)
    • Line 108: warning: exported method VmDockerCommander.Ps should have comment or be unexported (golint)
    • Line 115: warning: exported method VmDockerCommander.Start should have comment or be unexported (golint)
    • Line 125: warning: exported method VmDockerCommander.Stop should have comment or be unexported (golint)
    • Line 135: warning: exported method VmDockerCommander.Restart should have comment or be unexported (golint)
    • Line 170: warning: exported method VmDockerCommander.Cp should have comment or be unexported (golint)
    • Line 177: warning: exported method VmDockerCommander.CpToContainer should have comment or be unexported (golint)
    • Line 184: warning: exported method VmDockerCommander.Exec should have comment or be unexported (golint)
    • Line 190: warning: exported method VmDockerCommander.LocalExec should have comment or be unexported (golint)
    • Line 196: warning: exported method VmDockerCommander.Status should have comment or be unexported (golint)
    • Line 208: warning: exported method VmDockerCommander.Run should have comment or be unexported (golint)
    • Line 218: warning: exported method VmDockerCommander.Create should have comment or be unexported (golint)
    • Line 228: warning: exported method VmDockerCommander.Rm should have comment or be unexported (golint)
    • Line 238: warning: exported method VmDockerCommander.GetID should have comment or be unexported (golint)
    • Line 246: warning: exported method VmDockerCommander.Pull should have comment or be unexported (golint)
    • Line 254: warning: exported method VmDockerCommander.IsImageExist should have comment or be unexported (golint)
    • minishift/pkg/minishift/openshift/openshift.go
    • Line 29: warning: exported type OpenShiftPatchTarget should have comment or be unexported (golint)
    • Line 35: warning: exported function GetOpenShiftPatchTarget should have comment or be unexported (golint)
    • Line 72: warning: exported function RestartOpenShift should have comment or be unexported (golint)
    • Line 100: warning: exported function Patch should have comment or be unexported (golint)
    • Line 149: warning: exported function ViewConfig should have comment or be unexported (golint)
    • minishift/pkg/minishift/openshift/service.go
    • Line 41: warning: exported type ServiceSpec should have comment or be unexported (golint)
    • Line 54: warning: exported type RouteSpec should have comment or be unexported (golint)
    • Line 73: warning: exported type Route should have comment or be unexported (golint)
    • Line 79: warning: exported type Service should have comment or be unexported (golint)
    • Line 87: warning: exported type Services should have comment or be unexported (golint)
    • Line 92: warning: exported const ProjectsCustomCol should have comment (or a comment on this block) or be unexported (golint)
    • Line 231: warning: exported function NewServices should have comment or be unexported (golint)
    • Line 235: warning: exported method Services.Add should have comment or be unexported (golint)
    • Line 244: warning: exported method Services.HasService should have comment or be unexported (golint)
    • minishift/pkg/minishift/addon/parser/parse_error.go
    • Line 19: warning: exported type ParseError should have comment or be unexported (golint)
    • Line 25: warning: exported type DefaultParseError should have comment or be unexported (golint)
    • Line 31: warning: exported function NewParseError should have comment or be unexported (golint)
    • Line 41: warning: exported method DefaultParseError.AddonName should have comment or be unexported (golint)
    • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 49: warning: exported method DefaultParseError.AddonDir should have comment or be unexported (golint)
    • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • minishift/pkg/minishift/docker/image/image.go
    • Line 27: warning: exported type ImageMissStrategy should have comment or be unexported (golint)
    • Line 30: warning: exported const Skip should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type ImageCacheConfig should have comment or be unexported (golint)
    • Line 50: warning: exported function CreateExportCommand should have comment or be unexported (golint)
    • minishift/pkg/minishift/systemd/systemd.go
    • Line 26: warning: exported type SystemdCommander should have comment or be unexported (golint)
    • Line 57: warning: exported method VmSystemdCommander.Enable should have comment or be unexported (golint)
    • Line 65: warning: exported method VmSystemdCommander.Disable should have comment or be unexported (golint)
    • Line 73: warning: exported method VmSystemdCommander.DaemonReload should have comment or be unexported (golint)
    • Line 82: warning: exported method VmSystemdCommander.Restart should have comment or be unexported (golint)
    • Line 91: warning: exported method VmSystemdCommander.Start should have comment or be unexported (golint)
    • Line 100: warning: exported method VmSystemdCommander.Stop should have comment or be unexported (golint)
    • Line 108: warning: exported method VmSystemdCommander.Status should have comment or be unexported (golint)
    • Line 113: warning: exported method VmSystemdCommander.Exec should have comment or be unexported (golint)
    • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • minishift/pkg/minishift/shell/powershell/powershell.go
    • Line 48: warning: exported type PowerShell should have comment or be unexported (golint)
    • Line 52: warning: exported function New should have comment or be unexported (golint)
    • Line 59: warning: exported function IsAdmin should have comment or be unexported (golint)
    • Line 73: warning: exported method PowerShell.Execute should have comment or be unexported (golint)
    • Line 87: warning: exported method PowerShell.ExecuteAsAdmin should have comment or be unexported (golint)
    • minishift/pkg/util/strings/strings.go
    • Line 53: warning: exported function EscapeSingleQuote should have comment or be unexported (golint)
    • Line 120: warning: exported function ConvertSlashes should have comment or be unexported (golint)
    • Line 124: warning: exported function ParseLines should have comment or be unexported (golint)
    • minishift/pkg/minikube/assets/vm_assets.go
    • Line 26: warning: exported type CopyableFile should have comment or be unexported (golint)
    • Line 35: warning: exported type BaseAsset should have comment or be unexported (golint)
    • Line 45: warning: exported method BaseAsset.GetAssetName should have comment or be unexported (golint)
    • Line 49: warning: exported method BaseAsset.GetTargetDir should have comment or be unexported (golint)
    • Line 53: warning: exported method BaseAsset.GetTargetName should have comment or be unexported (golint)
    • Line 57: warning: exported method BaseAsset.GetPermissions should have comment or be unexported (golint)
    • Line 61: warning: exported type FileAsset should have comment or be unexported (golint)
    • Line 65: warning: exported function NewFileAsset should have comment or be unexported (golint)
    • Line 82: warning: exported method FileAsset.GetLength should have comment or be unexported (golint)
    • Line 102: warning: exported type MemoryAsset should have comment or be unexported (golint)
    • Line 106: warning: exported method MemoryAsset.GetLength should have comment or be unexported (golint)
    • minishift/pkg/minikube/sshutil/sshutil.go
    • Line 66: warning: exported function NewRawSSHClient should have comment or be unexported (golint)
    • Line 89: warning: exported function TransferFile should have comment or be unexported (golint)
    • Line 137: warning: exported function RunCommand should have comment or be unexported (golint)
    • minishift/pkg/minishift/provisioner/minishift_provisioner.go
    • Line 36: warning: exported function NewMinishiftProvisioner should have comment or be unexported (golint)
    • Line 44: warning: exported type MinishiftProvisioner should have comment or be unexported (golint)
    • Line 52: warning: exported method MinishiftProvisioner.SetHostname should have comment or be unexported (golint)
    • Line 75: warning: exported method MinishiftProvisioner.GetRedhatRelease should have comment or be unexported (golint)
    • Line 86: warning: exported method MinishiftProvisioner.Package should have comment or be unexported (golint)
    • Line 111: warning: exported method MinishiftProvisioner.Provision should have comment or be unexported (golint)
    • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 150: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 157: warning: exported method MinishiftProvisioner.GenerateDockerOptions should have comment or be unexported (golint)
    • minishift/pkg/util/archive/archive.go
    • Line 28: warning: exported function Ungzip should have comment or be unexported (golint)
    • Line 51: warning: exported function Untar should have comment or be unexported (golint)
    • Line 109: warning: exported function Unzip should have comment or be unexported (golint)
    • minishift/cmd/minishift/cmd/config/config.go
    • Line 28: warning: exported const DefaultRoutingSuffix should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: exported type MinishiftConfig should have comment or be unexported (golint)
    • Line 35: warning: exported type Setting should have comment or be unexported (golint)
    • Line 45: warning: comment on exported var ISOUrl should be of the form "ISOUrl ..." (golint)
    • Line 47: warning: exported var CPUs should have comment or be unexported (golint)
    • Line 63: warning: comment on exported var SkipRegistryCheck should be of the form "SkipRegistryCheck ..." (golint)
    • Line 71: warning: comment on exported var ExtraClusterUpFlags should be of the form "ExtraClusterUpFlags ..." (golint)
    • Line 74: warning: comment on exported var NoProxyList should be of the form "NoProxyList ..." (golint)
    • Line 78: warning: comment on exported var LocalProxy should be of the form "LocalProxy ..." (golint)
    • Line 83: warning: comment on exported var Username should be of the form "Username ..." (golint)
    • Line 88: warning: comment on exported var LogDir should be of the form "LogDir ..." (golint)
    • Line 92: warning: comment on exported var HostFoldersMountPath should be of the form "HostFoldersMountPath ..." (golint)
    • Line 96: warning: comment on exported var ServicesSftpPort should be of the form "ServicesSftpPort ..." (golint)
    • Line 100: warning: comment on exported var NoProvision should be of the form "NoProvision ..." (golint)
    • Line 103: warning: comment on exported var ImageCaching should be of the form "ImageCaching ..." (golint)
    • Line 107: warning: comment on exported var SkipDeprecationCheck should be of the form "SkipDeprecationCheck ..." (golint)
    • Line 132: warning: comment on exported var SkipCheckClusterUpFlag should be of the form "SkipCheckClusterUpFlag ..." (golint)
    • Line 136: warning: comment on exported var SkipInstanceIP should be of the form "SkipInstanceIP ..." (golint)
    • Line 152: warning: comment on exported var CheckNetworkHttpHost should be of the form "CheckNetworkHttpHost ..." (golint)
    • Line 156: warning: comment on exported var NetworkDevice should be of the form "NetworkDevice ..." (golint)
    • Line 162: warning: comment on exported var NameServers should be of the form "NameServers ..." (golint)
    • Line 167: warning: comment on exported var HypervVirtualSwitch should be of the form "HypervVirtualSwitch ..." (golint)
    • Line 170: warning: comment on exported var SaveStartFlags should be of the form "SaveStartFlags ..." (golint)
    • Line 173: warning: comment on exported var AutoStartTray should be of the form "AutoStartTray ..." (golint)
    • Line 176: warning: comment on exported var StaticIPAutoSet should be of the form "StaticIPAutoSet ..." (golint)
    • Line 197: warning: exported var ConfigCmd should have comment or be unexported (golint)
    • minishift/cmd/minishift/cmd/config/functions.go
    • Line 23: warning: exported function GetDefaultRoutingSuffix should have comment or be unexported (golint)
    • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 32: warning: exported function GetDefaultPublicHostName should have comment or be unexported (golint)
    • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • minishift/pkg/minishift/cache/oc_caching.go
    • Line 29: warning: exported const OC_CACHE_DIR should have comment or be unexported (golint)
    • Line 37: warning: exported method Oc.EnsureIsCached should have comment or be unexported (golint)
    • Line 48: warning: exported method Oc.GetCacheFilepath should have comment or be unexported (golint)
    • minishift/cmd/minishift/cmd/util/shared_flags.go
    • Line 33: warning: exported var HttpProxyFlag should have comment or be unexported (golint)
    • Line 41: warning: exported var HttpsProxyFlag should have comment or be unexported (golint)
    • Line 49: warning: exported var AddOnEnvFlag should have comment or be unexported (golint)
    • Line 56: warning: exported function NewStringValue should have comment or be unexported (golint)
    • Line 73: warning: exported function NewStringSliceValue should have comment or be unexported (golint)
    • Line 108: warning: comment on exported function InitClusterUpFlags should be of the form "InitClusterUpFlags ..." (golint)
    • minishift/cmd/minishift/cmd/util/util.go
    • Line 49: warning: exported var DefaultAssets should have comment or be unexported (golint)
    • Line 61: warning: exported function VMExists should have comment or be unexported (golint)
    • Line 69: warning: exported function ExitIfUndefined should have comment or be unexported (golint)
    • Line 76: warning: exported function IsHostRunning should have comment or be unexported (golint)
    • Line 80: warning: exported function IsHostStopped should have comment or be unexported (golint)
    • Line 84: warning: exported function ExitIfNotRunning should have comment or be unexported (golint)
    • Line 91: warning: exported function GetVMStatus should have comment or be unexported (golint)
    • Line 104: warning: exported function DoesVMExist should have comment or be unexported (golint)
    • Line 138: warning: exported function GetNoProxyConfig should have comment or be unexported (golint)
    • Line 163: warning: exported function ValidateGenericDriverFlags should have comment or be unexported (golint)
    • Line 180: warning: exported function GetOpenShiftReleaseVersion should have comment or be unexported (golint)
    • Line 200: warning: comment on exported function DetermineClusterUpParameters should be of the form "DetermineClusterUpParameters ..." (golint)
    • Line 227: warning: exported function EnsureConfigFileExists should have comment or be unexported (golint)
    • Line 242: warning: exported function CreateMinishiftDirs should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

    • minishift/cmd/minishift/cmd/hostfolder/add_test.go
    • Line 33: warning: ineffectual assignment to err (ineffassign)
    • Line 48: warning: ineffectual assignment to err (ineffassign)
    • Line 63: warning: ineffectual assignment to err (ineffassign)
    • Line 78: warning: ineffectual assignment to err (ineffassign)
    • Line 94: warning: ineffectual assignment to err (ineffassign)
    • Line 111: warning: ineffectual assignment to err (ineffassign)
    • Line 129: warning: ineffectual assignment to err (ineffassign)
    • Line 147: warning: ineffectual assignment to err (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words