Preparing report...

Report for github.com/mitch000001/go-hbci

A+    Excellent!    Found 79 issues across 191 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • go-hbci/segment/basic_account_information_unmarshaler.go
    • Line 206: warning: cyclomatic complexity 38 of function (*AccountInformationV6).UnmarshalHBCI() is high (> 15) (gocyclo)
    • Line 123: warning: cyclomatic complexity 32 of function (*AccountInformationV5).UnmarshalHBCI() is high (> 15) (gocyclo)
    • Line 47: warning: cyclomatic complexity 29 of function (*AccountInformationV4).UnmarshalHBCI() is high (> 15) (gocyclo)

golint67%

Golint is a linter for Go source code.

    • go-hbci/segment/signature_header.go
    • Line 10: warning: exported type SignatureHeader should have comment or be unexported (golint)
    • Line 19: warning: exported function NewSignatureHeaderSegmentV3 should have comment or be unexported (golint)
    • Line 35: warning: exported function NewPinTanSignatureHeaderSegment should have comment or be unexported (golint)
    • Line 56: warning: exported function NewRDHSignatureHeaderSegment should have comment or be unexported (golint)
    • Line 79: warning: exported type SignatureHeaderSegment should have comment or be unexported (golint)
    • Line 88: warning: exported type SignatureHeaderV3 should have comment or be unexported (golint)
    • Line 111: warning: exported method SignatureHeaderV3.SetSecurityFunction should have comment or be unexported (golint)
    • Line 115: warning: exported method SignatureHeaderV3.SetControlReference should have comment or be unexported (golint)
    • Line 119: warning: exported method SignatureHeaderV3.SetSigningKeyName should have comment or be unexported (golint)
    • Line 123: warning: exported method SignatureHeaderV3.SetClientSystemID should have comment or be unexported (golint)
    • Line 127: warning: exported method SignatureHeaderV3.SetSignatureID should have comment or be unexported (golint)
    • Line 131: warning: exported method SignatureHeaderV3.Version should have comment or be unexported (golint)
    • Line 132: warning: exported method SignatureHeaderV3.ID should have comment or be unexported (golint)
    • Line 152: warning: exported function NewSignatureHeaderSegmentV4 should have comment or be unexported (golint)
    • Line 168: warning: exported function NewPinTanSignatureHeaderSegmentV4 should have comment or be unexported (golint)
    • Line 189: warning: exported type SignatureHeaderSegmentV4 should have comment or be unexported (golint)
    • Line 213: warning: exported method SignatureHeaderSegmentV4.SetSecurityFunction should have comment or be unexported (golint)
    • Line 222: warning: exported method SignatureHeaderSegmentV4.SetControlReference should have comment or be unexported (golint)
    • Line 226: warning: exported method SignatureHeaderSegmentV4.SetSigningKeyName should have comment or be unexported (golint)
    • Line 230: warning: exported method SignatureHeaderSegmentV4.SetClientSystemID should have comment or be unexported (golint)
    • Line 234: warning: exported method SignatureHeaderSegmentV4.SetSignatureID should have comment or be unexported (golint)
    • Line 238: warning: exported method SignatureHeaderSegmentV4.Version should have comment or be unexported (golint)
    • Line 239: warning: exported method SignatureHeaderSegmentV4.ID should have comment or be unexported (golint)
    • go-hbci/segment/user_parameter_data.go
    • Line 10: warning: exported type CommonUserParameterData should have comment or be unexported (golint)
    • Line 15: warning: exported type CommonUserParameterDataSegment should have comment or be unexported (golint)
    • Line 24: warning: exported type CommonUserParameterDataV2 should have comment or be unexported (golint)
    • Line 39: warning: exported method CommonUserParameterDataV2.Version should have comment or be unexported (golint)
    • Line 40: warning: exported method CommonUserParameterDataV2.ID should have comment or be unexported (golint)
    • Line 52: warning: exported method CommonUserParameterDataV2.UserParameterData should have comment or be unexported (golint)
    • Line 60: warning: exported type CommonUserParameterDataV3 should have comment or be unexported (golint)
    • Line 77: warning: exported method CommonUserParameterDataV3.Version should have comment or be unexported (golint)
    • Line 78: warning: exported method CommonUserParameterDataV3.ID should have comment or be unexported (golint)
    • Line 92: warning: exported method CommonUserParameterDataV3.UserParameterData should have comment or be unexported (golint)
    • Line 100: warning: exported type CommonUserParameterDataV4 should have comment or be unexported (golint)
    • Line 117: warning: exported method CommonUserParameterDataV4.Version should have comment or be unexported (golint)
    • Line 118: warning: exported method CommonUserParameterDataV4.ID should have comment or be unexported (golint)
    • Line 132: warning: exported method CommonUserParameterDataV4.UserParameterData should have comment or be unexported (golint)
    • go-hbci/crypto/rsa.go
    • Line 8: warning: exported type RSAKeyParameters should have comment or be unexported (golint)
    • Line 14: warning: exported function NewRSAKeyParameters should have comment or be unexported (golint)
    • Line 32: warning: exported function NewRSAPrivateCrtKeyParameters should have comment or be unexported (golint)
    • Line 52: warning: exported type RSAPrivateCrtKeyParameters should have comment or be unexported (golint)
    • Line 62: warning: exported method RSAPrivateCrtKeyParameters.PublicExponent should have comment or be unexported (golint)
    • Line 63: warning: exported method RSAPrivateCrtKeyParameters.P should have comment or be unexported (golint)
    • Line 64: warning: exported method RSAPrivateCrtKeyParameters.Q should have comment or be unexported (golint)
    • Line 65: warning: exported method RSAPrivateCrtKeyParameters.DP should have comment or be unexported (golint)
    • Line 66: warning: exported method RSAPrivateCrtKeyParameters.DQ should have comment or be unexported (golint)
    • Line 67: warning: exported method RSAPrivateCrtKeyParameters.QInv should have comment or be unexported (golint)
    • Line 69: warning: exported type RSAEngine should have comment or be unexported (golint)
    • Line 73: warning: exported method RSAEngine.Init should have comment or be unexported (golint)
    • Line 80: warning: exported method RSAEngine.ProcessBlock should have comment or be unexported (golint)
    • Line 91: warning: exported type RSACoreEngine should have comment or be unexported (golint)
    • Line 96: warning: exported method RSACoreEngine.Init should have comment or be unexported (golint)
    • Line 101: warning: exported method RSACoreEngine.InputBlockSize should have comment or be unexported (golint)
    • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 110: warning: exported method RSACoreEngine.OutputBlockSize should have comment or be unexported (golint)
    • Line 114: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 119: warning: exported method RSACoreEngine.ConvertInput should have comment or be unexported (golint)
    • Line 143: warning: exported method RSACoreEngine.ConvertOutput should have comment or be unexported (golint)
    • Line 179: warning: exported method RSACoreEngine.ProcessBlock should have comment or be unexported (golint)
    • Line 211: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • go-hbci/segment/account_transaction.go
    • Line 17: warning: exported function AccountTransactionRequestBuilder should have comment or be unexported (golint)
    • Line 28: warning: exported function SepaAccountTransactionRequestBuilder should have comment or be unexported (golint)
    • Line 42: warning: exported type AccountTransactionRequestSegment should have comment or be unexported (golint)
    • Line 52: warning: exported function NewAccountTransactionRequestSegmentV5 should have comment or be unexported (golint)
    • Line 65: warning: exported type AccountTransactionRequestV5 should have comment or be unexported (golint)
    • Line 75: warning: exported method AccountTransactionRequestV5.SetContinuationReference should have comment or be unexported (golint)
    • Line 79: warning: exported method AccountTransactionRequestV5.SetTransactionRange should have comment or be unexported (golint)
    • Line 92: warning: exported method AccountTransactionRequestV5.Version should have comment or be unexported (golint)
    • Line 93: warning: exported method AccountTransactionRequestV5.ID should have comment or be unexported (golint)
    • Line 108: warning: exported function NewAccountTransactionRequestSegmentV6 should have comment or be unexported (golint)
    • Line 121: warning: exported type AccountTransactionRequestV6 should have comment or be unexported (golint)
    • Line 131: warning: exported method AccountTransactionRequestV6.SetContinuationReference should have comment or be unexported (golint)
    • Line 135: warning: exported method AccountTransactionRequestV6.SetTransactionRange should have comment or be unexported (golint)
    • Line 148: warning: exported method AccountTransactionRequestV6.Version should have comment or be unexported (golint)
    • Line 149: warning: exported method AccountTransactionRequestV6.ID should have comment or be unexported (golint)
    • Line 164: warning: exported function NewAccountTransactionRequestSegmentV7 should have comment or be unexported (golint)
    • Line 177: warning: exported type AccountTransactionRequestV7 should have comment or be unexported (golint)
    • Line 187: warning: exported method AccountTransactionRequestV7.SetContinuationReference should have comment or be unexported (golint)
    • Line 191: warning: exported method AccountTransactionRequestV7.SetTransactionRange should have comment or be unexported (golint)
    • Line 204: warning: exported method AccountTransactionRequestV7.Version should have comment or be unexported (golint)
    • Line 205: warning: exported method AccountTransactionRequestV7.ID should have comment or be unexported (golint)
    • Line 220: warning: exported type AccountTransactionResponse should have comment or be unexported (golint)
    • Line 227: warning: exported type AccountTransactionResponseSegment should have comment or be unexported (golint)
    • Line 231: warning: exported type AccountTransactionResponseSegmentV5 should have comment or be unexported (golint)
    • Line 237: warning: exported method AccountTransactionResponseSegmentV5.Transactions should have comment or be unexported (golint)
    • Line 241: warning: exported method AccountTransactionResponseSegmentV5.Version should have comment or be unexported (golint)
    • Line 242: warning: exported method AccountTransactionResponseSegmentV5.ID should have comment or be unexported (golint)
    • Line 253: warning: exported type AccountTransactionResponseSegmentV6 should have comment or be unexported (golint)
    • Line 259: warning: exported method AccountTransactionResponseSegmentV6.Transactions should have comment or be unexported (golint)
    • Line 263: warning: exported method AccountTransactionResponseSegmentV6.Version should have comment or be unexported (golint)
    • Line 264: warning: exported method AccountTransactionResponseSegmentV6.ID should have comment or be unexported (golint)
    • Line 275: warning: exported type AccountTransactionResponseSegmentV7 should have comment or be unexported (golint)
    • Line 281: warning: exported method AccountTransactionResponseSegmentV7.Transactions should have comment or be unexported (golint)
    • Line 285: warning: exported method AccountTransactionResponseSegmentV7.Version should have comment or be unexported (golint)
    • Line 286: warning: exported method AccountTransactionResponseSegmentV7.ID should have comment or be unexported (golint)
    • go-hbci/segment/basic_account_information.go
    • Line 8: warning: exported type AccountInformation should have comment or be unexported (golint)
    • Line 15: warning: exported type AccountInformationSegment should have comment or be unexported (golint)
    • Line 24: warning: exported type AccountInformationV4 should have comment or be unexported (golint)
    • Line 36: warning: exported method AccountInformationV4.Version should have comment or be unexported (golint)
    • Line 37: warning: exported method AccountInformationV4.ID should have comment or be unexported (golint)
    • Line 41: warning: exported method AccountInformationV4.Account should have comment or be unexported (golint)
    • Line 78: warning: exported type AccountInformationV5 should have comment or be unexported (golint)
    • Line 91: warning: exported method AccountInformationV5.Version should have comment or be unexported (golint)
    • Line 92: warning: exported method AccountInformationV5.ID should have comment or be unexported (golint)
    • Line 96: warning: exported method AccountInformationV5.Account should have comment or be unexported (golint)
    • Line 137: warning: exported type AccountInformationV6 should have comment or be unexported (golint)
    • Line 152: warning: exported method AccountInformationV6.Version should have comment or be unexported (golint)
    • Line 153: warning: exported method AccountInformationV6.ID should have comment or be unexported (golint)
    • Line 157: warning: exported method AccountInformationV6.Account should have comment or be unexported (golint)
    • go-hbci/segment/key_management.go
    • Line 12: warning: exported function NewPublicKeyRenewalSegment should have comment or be unexported (golint)
    • Line 26: warning: exported type PublicKeyRenewalSegment should have comment or be unexported (golint)
    • Line 38: warning: exported method PublicKeyRenewalSegment.Version should have comment or be unexported (golint)
    • Line 39: warning: exported method PublicKeyRenewalSegment.ID should have comment or be unexported (golint)
    • Line 53: warning: exported function NewPublicKeyRequestSegment should have comment or be unexported (golint)
    • Line 63: warning: exported type PublicKeyRequestSegment should have comment or be unexported (golint)
    • Line 73: warning: exported method PublicKeyRequestSegment.Version should have comment or be unexported (golint)
    • Line 74: warning: exported method PublicKeyRequestSegment.ID should have comment or be unexported (golint)
    • Line 87: warning: exported function NewPublicKeyTransmissionSegment should have comment or be unexported (golint)
    • Line 104: warning: exported type PublicKeyTransmissionSegment should have comment or be unexported (golint)
    • Line 117: warning: exported method PublicKeyTransmissionSegment.Version should have comment or be unexported (golint)
    • Line 118: warning: exported method PublicKeyTransmissionSegment.ID should have comment or be unexported (golint)
    • Line 135: warning: exported const KeyCompromitted should have comment (or a comment on this block) or be unexported (golint)
    • Line 146: warning: exported function NewPublicKeyRevocationSegment should have comment or be unexported (golint)
    • Line 161: warning: exported type PublicKeyRevocationSegment should have comment or be unexported (golint)
    • Line 176: warning: exported method PublicKeyRevocationSegment.Version should have comment or be unexported (golint)
    • Line 177: warning: exported method PublicKeyRevocationSegment.ID should have comment or be unexported (golint)
    • Line 192: warning: exported function NewPublicKeyRevocationConfirmationSegment should have comment or be unexported (golint)
    • Line 213: warning: exported type PublicKeyRevocationConfirmationSegment should have comment or be unexported (golint)
    • Line 230: warning: exported method PublicKeyRevocationConfirmationSegment.Version should have comment or be unexported (golint)
    • Line 231: warning: exported method PublicKeyRevocationConfirmationSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/segment.go
    • Line 18: warning: exported type Segment should have comment or be unexported (golint)
    • Line 24: warning: exported type ClientSegment should have comment or be unexported (golint)
    • Line 29: warning: exported type BankSegment should have comment or be unexported (golint)
    • Line 34: warning: exported type CommonSegment should have comment or be unexported (golint)
    • Line 48: warning: exported type Marshaler should have comment or be unexported (golint)
    • Line 52: warning: exported type Unmarshaler should have comment or be unexported (golint)
    • Line 56: warning: exported function SegmentFromHeaderBytes should have comment or be unexported (golint)
    • Line 65: warning: exported function NewReferencingBasicSegment should have comment or be unexported (golint)
    • Line 70: warning: exported function NewBasicSegment should have comment or be unexported (golint)
    • Line 75: warning: exported function NewBasicSegmentWithHeader should have comment or be unexported (golint)
    • go-hbci/segment/bank_announcement.go
    • Line 7: warning: exported type BankAnnouncementSegment should have comment or be unexported (golint)
    • Line 13: warning: exported method BankAnnouncementSegment.Version should have comment or be unexported (golint)
    • Line 14: warning: exported method BankAnnouncementSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/common_bank_parameter_data_unmarshaler.go
    • Line 10: warning: exported method CommonBankParameterSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 41: warning: exported method CommonBankParameterV2.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 110: warning: exported method CommonBankParameterV3.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/crypto/iso9796_encoding.go
    • Line 23: warning: comment on exported type ISO9796d1Encoding should be of the form "ISO9796d1Encoding ..." (with optional leading article) (golint)
    • Line 39: warning: exported function NewISO9796d1Encoding should have comment or be unexported (golint)
    • Line 43: warning: exported method ISO9796d1Encoding.GetUnderlyingCipher should have comment or be unexported (golint)
    • Line 47: warning: exported method ISO9796d1Encoding.Init should have comment or be unexported (golint)
    • Line 54: warning: exported method ISO9796d1Encoding.BlockSize should have comment or be unexported (golint)
    • Line 58: warning: comment on exported method ISO9796d1Encoding.InputBlockSize should be of the form "InputBlockSize ..." (golint)
    • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 73: warning: comment on exported method ISO9796d1Encoding.OutputBlockSize should be of the form "OutputBlockSize ..." (golint)
    • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 86: warning: comment on exported method ISO9796d1Encoding.SetPadBits should be of the form "SetPadBits ..." (golint)
    • Line 98: warning: comment on exported method ISO9796d1Encoding.PadBits should be of the form "PadBits ..." (golint)
    • Line 105: warning: exported method ISO9796d1Encoding.ProcessBlock should have comment or be unexported (golint)
    • Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • go-hbci/segment/supported_security_method.go
    • Line 7: warning: exported type SecurityMethodSegment should have comment or be unexported (golint)
    • Line 13: warning: exported method SecurityMethodSegment.Version should have comment or be unexported (golint)
    • Line 14: warning: exported method SecurityMethodSegment.ID should have comment or be unexported (golint)
    • go-hbci/generator/test_files/test_stubs.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 7: warning: exported function ExtractElements should have comment or be unexported (golint)
    • Line 8: warning: exported function SegmentFromHeaderBytes should have comment or be unexported (golint)
    • Line 10: warning: exported type Segment should have comment or be unexported (golint)
    • Line 20: warning: exported type BankSegment should have comment or be unexported (golint)
    • go-hbci/segment/account_balance.go
    • Line 29: warning: exported type AccountBalanceRequest should have comment or be unexported (golint)
    • Line 34: warning: exported function NewAccountBalanceRequestV5 should have comment or be unexported (golint)
    • Line 43: warning: exported type AccountBalanceRequestSegmentV5 should have comment or be unexported (golint)
    • Line 51: warning: exported method AccountBalanceRequestSegmentV5.Version should have comment or be unexported (golint)
    • Line 52: warning: exported method AccountBalanceRequestSegmentV5.ID should have comment or be unexported (golint)
    • Line 65: warning: exported method AccountBalanceRequestSegmentV5.SetContinuationMark should have comment or be unexported (golint)
    • Line 69: warning: exported function NewAccountBalanceRequestV6 should have comment or be unexported (golint)
    • Line 78: warning: exported type AccountBalanceRequestSegmentV6 should have comment or be unexported (golint)
    • Line 86: warning: exported method AccountBalanceRequestSegmentV6.Version should have comment or be unexported (golint)
    • Line 87: warning: exported method AccountBalanceRequestSegmentV6.ID should have comment or be unexported (golint)
    • Line 100: warning: exported method AccountBalanceRequestSegmentV6.SetContinuationMark should have comment or be unexported (golint)
    • Line 106: warning: exported type AccountBalanceResponse should have comment or be unexported (golint)
    • Line 111: warning: exported type AccountBalanceResponseSegment should have comment or be unexported (golint)
    • Line 126: warning: exported method AccountBalanceResponseSegment.Version should have comment or be unexported (golint)
    • Line 127: warning: exported method AccountBalanceResponseSegment.ID should have comment or be unexported (golint)
    • Line 131: warning: exported method AccountBalanceResponseSegment.AccountBalance should have comment or be unexported (golint)
    • go-hbci/segment/sync.go
    • Line 16: warning: exported type SyncMode should have comment or be unexported (golint)
    • Line 20: warning: exported function NewSynchronisationSegmentV2 should have comment or be unexported (golint)
    • Line 32: warning: exported type SynchronisationRequestSegment should have comment or be unexported (golint)
    • Line 36: warning: exported type SynchronisationRequestV2 should have comment or be unexported (golint)
    • Line 46: warning: exported method SynchronisationRequestV2.Version should have comment or be unexported (golint)
    • Line 47: warning: exported method SynchronisationRequestV2.ID should have comment or be unexported (golint)
    • Line 57: warning: exported function NewSynchronisationSegmentV3 should have comment or be unexported (golint)
    • Line 69: warning: exported type SynchronisationRequestV3 should have comment or be unexported (golint)
    • Line 79: warning: exported method SynchronisationRequestV3.Version should have comment or be unexported (golint)
    • Line 80: warning: exported method SynchronisationRequestV3.ID should have comment or be unexported (golint)
    • Line 92: warning: exported type SynchronisationResponse should have comment or be unexported (golint)
    • Line 99: warning: exported type SynchronisationResponseSegment should have comment or be unexported (golint)
    • Line 103: warning: exported type SynchronisationResponseSegmentV3 should have comment or be unexported (golint)
    • Line 110: warning: exported method SynchronisationResponseSegmentV3.Version should have comment or be unexported (golint)
    • Line 111: warning: exported method SynchronisationResponseSegmentV3.ID should have comment or be unexported (golint)
    • Line 123: warning: exported method SynchronisationResponseSegmentV3.ClientSystemID should have comment or be unexported (golint)
    • Line 127: warning: exported method SynchronisationResponseSegmentV3.LastMessageNumber should have comment or be unexported (golint)
    • Line 131: warning: exported method SynchronisationResponseSegmentV3.SignatureID should have comment or be unexported (golint)
    • Line 135: warning: exported type SynchronisationResponseSegmentV4 should have comment or be unexported (golint)
    • Line 142: warning: exported method SynchronisationResponseSegmentV4.Version should have comment or be unexported (golint)
    • Line 143: warning: exported method SynchronisationResponseSegmentV4.ID should have comment or be unexported (golint)
    • Line 155: warning: exported method SynchronisationResponseSegmentV4.ClientSystemID should have comment or be unexported (golint)
    • Line 159: warning: exported method SynchronisationResponseSegmentV4.LastMessageNumber should have comment or be unexported (golint)
    • Line 163: warning: exported method SynchronisationResponseSegmentV4.SignatureID should have comment or be unexported (golint)
    • go-hbci/segment/identification.go
    • Line 8: warning: exported function NewIdentificationSegment should have comment or be unexported (golint)
    • Line 25: warning: exported type IdentificationSegment should have comment or be unexported (golint)
    • Line 33: warning: exported method IdentificationSegment.Version should have comment or be unexported (golint)
    • Line 34: warning: exported method IdentificationSegment.ID should have comment or be unexported (golint)
    • go-hbci/cmd/banking/root.go
    • Line 52: warning: exported var UserID should have comment or be unexported (golint)
    • Line 53: warning: exported var BLZ should have comment or be unexported (golint)
    • Line 54: warning: exported var PIN should have comment or be unexported (golint)
    • go-hbci/segment/supported_compression_method.go
    • Line 7: warning: exported type CompressionMethodSegment should have comment or be unexported (golint)
    • Line 12: warning: exported method CompressionMethodSegment.Version should have comment or be unexported (golint)
    • Line 13: warning: exported method CompressionMethodSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/basic_account_information_unmarshaler.go
    • Line 10: warning: exported method AccountInformationSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 47: warning: exported method AccountInformationV4.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 123: warning: exported method AccountInformationV5.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 206: warning: exported method AccountInformationV6.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/communication_access.go
    • Line 8: warning: exported function NewCommunicationAccessRequestSegment should have comment or be unexported (golint)
    • Line 21: warning: exported type CommunicationAccessRequestSegment should have comment or be unexported (golint)
    • Line 29: warning: exported method CommunicationAccessRequestSegment.Version should have comment or be unexported (golint)
    • Line 30: warning: exported method CommunicationAccessRequestSegment.ID should have comment or be unexported (golint)
    • Line 43: warning: exported const HKKOMSegmentNumber should have comment or be unexported (golint)
    • Line 45: warning: exported function NewCommunicationAccessResponseSegment should have comment or be unexported (golint)
    • Line 58: warning: exported type CommunicationAccessResponseSegment should have comment or be unexported (golint)
    • Line 65: warning: exported method CommunicationAccessResponseSegment.Version should have comment or be unexported (golint)
    • Line 66: warning: exported method CommunicationAccessResponseSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/encryption_header.go
    • Line 10: warning: exported const EncryptionHeaderSegmentID should have comment or be unexported (golint)
    • Line 12: warning: exported type EncryptionHeader should have comment or be unexported (golint)
    • Line 20: warning: exported function NewPinTanEncryptionHeaderSegment should have comment or be unexported (golint)
    • Line 38: warning: exported function NewEncryptionHeaderSegment should have comment or be unexported (golint)
    • Line 58: warning: exported type EncryptionHeaderSegment should have comment or be unexported (golint)
    • Line 67: warning: exported type EncryptionHeaderV2 should have comment or be unexported (golint)
    • Line 84: warning: exported method EncryptionHeaderV2.Version should have comment or be unexported (golint)
    • Line 85: warning: exported method EncryptionHeaderV2.ID should have comment or be unexported (golint)
    • Line 102: warning: exported method EncryptionHeaderV2.SetEncryptionKeyName should have comment or be unexported (golint)
    • Line 106: warning: exported method EncryptionHeaderV2.SetEncryptionAlgorithm should have comment or be unexported (golint)
    • Line 110: warning: exported method EncryptionHeaderV2.SetClientSystemID should have comment or be unexported (golint)
    • Line 114: warning: exported method EncryptionHeaderV2.SetSecurityProfile should have comment or be unexported (golint)
    • Line 118: warning: exported function NewPinTanEncryptionHeaderSegmentV3 should have comment or be unexported (golint)
    • Line 137: warning: exported type EncryptionHeaderSegmentV3 should have comment or be unexported (golint)
    • Line 164: warning: exported method EncryptionHeaderSegmentV3.Version should have comment or be unexported (golint)
    • Line 165: warning: exported method EncryptionHeaderSegmentV3.ID should have comment or be unexported (golint)
    • Line 183: warning: exported method EncryptionHeaderSegmentV3.SetEncryptionKeyName should have comment or be unexported (golint)
    • Line 187: warning: exported method EncryptionHeaderSegmentV3.SetEncryptionAlgorithm should have comment or be unexported (golint)
    • Line 191: warning: exported method EncryptionHeaderSegmentV3.SetClientSystemID should have comment or be unexported (golint)
    • Line 195: warning: exported method EncryptionHeaderSegmentV3.SetSecurityProfile should have comment or be unexported (golint)
    • go-hbci/segment/acknowledgement.go
    • Line 10: warning: exported type MessageAcknowledgement should have comment or be unexported (golint)
    • Line 16: warning: exported method MessageAcknowledgement.Version should have comment or be unexported (golint)
    • Line 17: warning: exported method MessageAcknowledgement.ID should have comment or be unexported (golint)
    • Line 21: warning: exported method MessageAcknowledgement.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 53: warning: exported method MessageAcknowledgement.SetReferencingMessage should have comment or be unexported (golint)
    • Line 57: warning: exported method MessageAcknowledgement.Acknowledgements should have comment or be unexported (golint)
    • Line 76: warning: exported type SegmentAcknowledgement should have comment or be unexported (golint)
    • Line 82: warning: exported method SegmentAcknowledgement.Version should have comment or be unexported (golint)
    • Line 83: warning: exported method SegmentAcknowledgement.ID should have comment or be unexported (golint)
    • Line 87: warning: exported method SegmentAcknowledgement.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 117: warning: exported method SegmentAcknowledgement.SetReferencingMessage should have comment or be unexported (golint)
    • Line 121: warning: exported method SegmentAcknowledgement.Acknowledgements should have comment or be unexported (golint)
    • go-hbci/segment/status_protocol.go
    • Line 12: warning: exported function StatusProtocolRequestBuilder should have comment or be unexported (golint)
    • Line 27: warning: exported type StatusProtocolRequest should have comment or be unexported (golint)
    • Line 31: warning: exported function NewStatusProtocolRequestV3 should have comment or be unexported (golint)
    • Line 44: warning: exported type StatusProtocolRequestSegmentV3 should have comment or be unexported (golint)
    • Line 52: warning: exported method StatusProtocolRequestSegmentV3.ID should have comment or be unexported (golint)
    • Line 53: warning: exported method StatusProtocolRequestSegmentV3.Version should have comment or be unexported (golint)
    • Line 66: warning: exported function NewStatusProtocolRequestV4 should have comment or be unexported (golint)
    • Line 79: warning: exported type StatusProtocolRequestSegmentV4 should have comment or be unexported (golint)
    • Line 87: warning: exported method StatusProtocolRequestSegmentV4.ID should have comment or be unexported (golint)
    • Line 88: warning: exported method StatusProtocolRequestSegmentV4.Version should have comment or be unexported (golint)
    • Line 101: warning: exported type StatusProtocolResponse should have comment or be unexported (golint)
    • Line 108: warning: exported type StatusProtocolResponseSegment should have comment or be unexported (golint)
    • Line 112: warning: exported type StatusProtocolResponseSegmentV3 should have comment or be unexported (golint)
    • Line 121: warning: exported method StatusProtocolResponseSegmentV3.ID should have comment or be unexported (golint)
    • Line 122: warning: exported method StatusProtocolResponseSegmentV3.Version should have comment or be unexported (golint)
    • Line 136: warning: exported method StatusProtocolResponseSegmentV3.Status should have comment or be unexported (golint)
    • Line 152: warning: exported type StatusProtocolResponseSegmentV4 should have comment or be unexported (golint)
    • Line 161: warning: exported method StatusProtocolResponseSegmentV4.ID should have comment or be unexported (golint)
    • Line 162: warning: exported method StatusProtocolResponseSegmentV4.Version should have comment or be unexported (golint)
    • Line 176: warning: exported method StatusProtocolResponseSegmentV4.Status should have comment or be unexported (golint)
    • go-hbci/segment/account_information.go
    • Line 8: warning: exported type AccountInformationRequest should have comment or be unexported (golint)
    • Line 13: warning: exported function NewAccountInformationRequestSegmentV1 should have comment or be unexported (golint)
    • Line 22: warning: exported type AccountInformationRequestSegmentV1 should have comment or be unexported (golint)
    • Line 30: warning: exported method AccountInformationRequestSegmentV1.Version should have comment or be unexported (golint)
    • Line 31: warning: exported method AccountInformationRequestSegmentV1.ID should have comment or be unexported (golint)
    • Line 44: warning: exported method AccountInformationRequestSegmentV1.SetContinuationMark should have comment or be unexported (golint)
    • Line 48: warning: exported function NewAccountInformationRequestSegmentV2 should have comment or be unexported (golint)
    • Line 57: warning: exported type AccountInformationRequestSegmentV2 should have comment or be unexported (golint)
    • Line 65: warning: exported method AccountInformationRequestSegmentV2.Version should have comment or be unexported (golint)
    • Line 66: warning: exported method AccountInformationRequestSegmentV2.ID should have comment or be unexported (golint)
    • Line 79: warning: exported method AccountInformationRequestSegmentV2.SetContinuationMark should have comment or be unexported (golint)
    • Line 83: warning: exported function NewAccountInformationRequestSegmentV3 should have comment or be unexported (golint)
    • Line 92: warning: exported type AccountInformationRequestSegmentV3 should have comment or be unexported (golint)
    • Line 100: warning: exported method AccountInformationRequestSegmentV3.Version should have comment or be unexported (golint)
    • Line 101: warning: exported method AccountInformationRequestSegmentV3.ID should have comment or be unexported (golint)
    • Line 114: warning: exported method AccountInformationRequestSegmentV3.SetContinuationMark should have comment or be unexported (golint)
    • Line 118: warning: exported function NewAccountInformationRequestSegmentV4 should have comment or be unexported (golint)
    • Line 127: warning: exported type AccountInformationRequestSegmentV4 should have comment or be unexported (golint)
    • Line 135: warning: exported method AccountInformationRequestSegmentV4.Version should have comment or be unexported (golint)
    • Line 136: warning: exported method AccountInformationRequestSegmentV4.ID should have comment or be unexported (golint)
    • Line 149: warning: exported method AccountInformationRequestSegmentV4.SetContinuationMark should have comment or be unexported (golint)
    • Line 153: warning: exported function NewAccountInformationRequestSegmentV5 should have comment or be unexported (golint)
    • Line 162: warning: exported type AccountInformationRequestSegmentV5 should have comment or be unexported (golint)
    • Line 170: warning: exported method AccountInformationRequestSegmentV5.Version should have comment or be unexported (golint)
    • Line 171: warning: exported method AccountInformationRequestSegmentV5.ID should have comment or be unexported (golint)
    • Line 184: warning: exported method AccountInformationRequestSegmentV5.SetContinuationMark should have comment or be unexported (golint)
    • Line 188: warning: exported function NewAccountInformationRequestSegmentV6 should have comment or be unexported (golint)
    • Line 197: warning: exported type AccountInformationRequestSegmentV6 should have comment or be unexported (golint)
    • Line 205: warning: exported method AccountInformationRequestSegmentV6.Version should have comment or be unexported (golint)
    • Line 206: warning: exported method AccountInformationRequestSegmentV6.ID should have comment or be unexported (golint)
    • Line 219: warning: exported method AccountInformationRequestSegmentV6.SetContinuationMark should have comment or be unexported (golint)
    • Line 225: warning: exported type AccountInformationResponseSegment should have comment or be unexported (golint)
    • Line 245: warning: exported method AccountInformationResponseSegment.Version should have comment or be unexported (golint)
    • Line 246: warning: exported method AccountInformationResponseSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/encryption_header_unmarshaler.go
    • Line 10: warning: exported method EncryptionHeaderSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 41: warning: exported method EncryptionHeaderV2.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 117: warning: exported method EncryptionHeaderSegmentV3.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/message_end.go
    • Line 5: warning: exported function NewMessageEndSegment should have comment or be unexported (golint)
    • Line 15: warning: exported type MessageEndSegment should have comment or be unexported (golint)
    • Line 20: warning: exported method MessageEndSegment.Version should have comment or be unexported (golint)
    • Line 21: warning: exported method MessageEndSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/message_header.go
    • Line 8: warning: exported function NewReferencingMessageHeaderSegment should have comment or be unexported (golint)
    • Line 14: warning: exported function NewMessageHeaderSegment should have comment or be unexported (golint)
    • Line 27: warning: exported type MessageHeaderSegment should have comment or be unexported (golint)
    • Line 36: warning: exported method MessageHeaderSegment.Version should have comment or be unexported (golint)
    • Line 37: warning: exported method MessageHeaderSegment.ID should have comment or be unexported (golint)
    • Line 41: warning: exported method MessageHeaderSegment.ReferencingMessage should have comment or be unexported (golint)
    • Line 49: warning: exported method MessageHeaderSegment.SetMessageNumber should have comment or be unexported (golint)
    • Line 63: warning: exported method MessageHeaderSegment.SetSize should have comment or be unexported (golint)
    • go-hbci/segment/dialog.go
    • Line 12: warning: exported function NewDialogEndSegment should have comment or be unexported (golint)
    • Line 20: warning: exported type DialogEndSegment should have comment or be unexported (golint)
    • Line 25: warning: exported method DialogEndSegment.Version should have comment or be unexported (golint)
    • Line 26: warning: exported method DialogEndSegment.ID should have comment or be unexported (golint)
    • Line 36: warning: exported function NewProcessingPreparationSegment should have comment or be unexported (golint)
    • Line 48: warning: exported type ProcessingPreparationSegment should have comment or be unexported (golint)
    • Line 63: warning: exported method ProcessingPreparationSegment.Version should have comment or be unexported (golint)
    • Line 64: warning: exported method ProcessingPreparationSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/segment_index.go
    • Line 5: warning: exported type VersionedSegment should have comment or be unexported (golint)
    • Line 14: warning: exported type SegmentIndex should have comment or be unexported (golint)
    • Line 18: warning: exported method SegmentIndex.UnmarshalerForSegment should have comment or be unexported (golint)
    • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 32: warning: exported method SegmentIndex.IsIndexed should have comment or be unexported (golint)
    • Line 37: warning: exported method SegmentIndex.IsUnmarshaler should have comment or be unexported (golint)
    • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 62: warning: exported var KnownSegments should have comment or be unexported (golint)
    • go-hbci/generator/test_files/multiple_versioned_test_segment.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 5: warning: exported type MultipleVersionedTestSegment should have comment or be unexported (golint)
    • Line 9: warning: exported type MultipleVersionedTestSegmentV1 should have comment or be unexported (golint)
    • Line 22: warning: exported type MultipleVersionedTestSegmentV2 should have comment or be unexported (golint)
    • go-hbci/generator/test_files/multiple_versioned_test_segment_unmarshaler.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 10: warning: exported method MultipleVersionedTestSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 41: warning: exported method MultipleVersionedTestSegmentV1.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 75: warning: exported method MultipleVersionedTestSegmentV2.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/account_transaction_unmarshaler.go
    • Line 10: warning: exported method AccountTransactionResponseSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 47: warning: exported method AccountTransactionResponseSegmentV5.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 81: warning: exported method AccountTransactionResponseSegmentV6.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 115: warning: exported method AccountTransactionResponseSegmentV7.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/business_transaction.go
    • Line 12: warning: exported type BusinessTransactionParamsSegment should have comment or be unexported (golint)
    • Line 21: warning: exported method BusinessTransactionParamsSegment.Version should have comment or be unexported (golint)
    • Line 22: warning: exported method BusinessTransactionParamsSegment.ID should have comment or be unexported (golint)
    • Line 34: warning: exported method BusinessTransactionParamsSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 60: warning: exported type PinTanBusinessTransactionParams should have comment or be unexported (golint)
    • Line 65: warning: exported type PinTanBusinessTransactionParamsSegment should have comment or be unexported (golint)
    • Line 69: warning: exported method PinTanBusinessTransactionParamsSegment.Version should have comment or be unexported (golint)
    • Line 70: warning: exported method PinTanBusinessTransactionParamsSegment.ID should have comment or be unexported (golint)
    • Line 72: warning: exported method PinTanBusinessTransactionParamsSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 92: warning: exported method PinTanBusinessTransactionParamsSegment.PinTanBusinessTransactions should have comment or be unexported (golint)
    • go-hbci/segment/signature_header_unmarshaler.go
    • Line 10: warning: exported method SignatureHeaderSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 41: warning: exported method SignatureHeaderV3.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 138: warning: exported method SignatureHeaderSegmentV4.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/sync_unmarshaler.go
    • Line 10: warning: exported method SynchronisationResponseSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 41: warning: exported method SynchronisationResponseSegmentV3.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 82: warning: exported method SynchronisationResponseSegmentV4.UnmarshalHBCI should have comment or be unexported (golint)
    • go-hbci/segment/encrypted_data.go
    • Line 5: warning: exported function NewEncryptedDataSegment should have comment or be unexported (golint)
    • Line 15: warning: exported type EncryptedDataSegment should have comment or be unexported (golint)
    • Line 20: warning: exported method EncryptedDataSegment.Version should have comment or be unexported (golint)
    • Line 21: warning: exported method EncryptedDataSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/signature_end.go
    • Line 5: warning: exported type SignatureEnd should have comment or be unexported (golint)
    • Line 11: warning: exported function NewSignatureEndSegmentV1 should have comment or be unexported (golint)
    • Line 26: warning: exported type SignatureEndSegment should have comment or be unexported (golint)
    • Line 30: warning: exported type SignatureEndV1 should have comment or be unexported (golint)
    • Line 37: warning: exported method SignatureEndV1.Version should have comment or be unexported (golint)
    • Line 38: warning: exported method SignatureEndV1.ID should have comment or be unexported (golint)
    • Line 50: warning: exported method SignatureEndV1.SetControlReference should have comment or be unexported (golint)
    • Line 54: warning: exported method SignatureEndV1.SetSignature should have comment or be unexported (golint)
    • Line 58: warning: exported method SignatureEndV1.SetPinTan should have comment or be unexported (golint)
    • Line 61: warning: exported function NewSignatureEndSegmentV2 should have comment or be unexported (golint)
    • Line 71: warning: exported type SignatureEndV2 should have comment or be unexported (golint)
    • Line 78: warning: exported method SignatureEndV2.Version should have comment or be unexported (golint)
    • Line 79: warning: exported method SignatureEndV2.ID should have comment or be unexported (golint)
    • Line 91: warning: exported method SignatureEndV2.SetControlReference should have comment or be unexported (golint)
    • Line 95: warning: exported method SignatureEndV2.SetSignature should have comment or be unexported (golint)
    • Line 99: warning: exported method SignatureEndV2.SetPinTan should have comment or be unexported (golint)
    • go-hbci/segment/common_bank_parameter_data.go
    • Line 8: warning: exported type CommonBankParameter should have comment or be unexported (golint)
    • Line 15: warning: exported type CommonBankParameterSegment should have comment or be unexported (golint)
    • Line 24: warning: exported type CommonBankParameterV2 should have comment or be unexported (golint)
    • Line 35: warning: exported method CommonBankParameterV2.Version should have comment or be unexported (golint)
    • Line 36: warning: exported method CommonBankParameterV2.ID should have comment or be unexported (golint)
    • Line 52: warning: exported method CommonBankParameterV2.BankParameterData should have comment or be unexported (golint)
    • Line 65: warning: exported type CommonBankParameterV3 should have comment or be unexported (golint)
    • Line 78: warning: exported method CommonBankParameterV3.Version should have comment or be unexported (golint)
    • Line 79: warning: exported method CommonBankParameterV3.ID should have comment or be unexported (golint)
    • Line 97: warning: exported method CommonBankParameterV3.BankParameterData should have comment or be unexported (golint)
    • go-hbci/segment/tan.go
    • Line 5: warning: exported function NewTanRequestProcess2 should have comment or be unexported (golint)
    • Line 15: warning: exported function NewTanRequestProcess4 should have comment or be unexported (golint)
    • Line 23: warning: exported type TanRequestSegment should have comment or be unexported (golint)
    • Line 33: warning: exported method TanRequestSegment.Version should have comment or be unexported (golint)
    • Line 34: warning: exported method TanRequestSegment.ID should have comment or be unexported (golint)
    • go-hbci/segment/user_parameter_data_unmarshaler.go
    • Line 10: warning: exported method CommonUserParameterDataSegment.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 47: warning: exported method CommonUserParameterDataV2.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 88: warning: exported method CommonUserParameterDataV3.UnmarshalHBCI should have comment or be unexported (golint)
    • Line 143: warning: exported method CommonUserParameterDataV4.UnmarshalHBCI should have comment or be unexported (golint)

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell98%

Misspell Finds commonly misspelled English words