Preparing report...

Report for github.com/negasus/haproxy-spoe-go

A+    Excellent!    Found 15 issues across 23 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint43%

Golint is a linter for Go source code.

    • haproxy-spoe-go/request/request.go
    • Line 15: warning: exported type Request should have comment or be unexported (golint)
    • Line 32: warning: exported function AcquireRequest should have comment or be unexported (golint)
    • Line 41: warning: exported function ReleaseRequest should have comment or be unexported (golint)
    • Line 46: warning: exported method Request.Reset should have comment or be unexported (golint)
    • haproxy-spoe-go/message/messages.go
    • Line 6: warning: exported var ErrMessageNotFound should have comment or be unexported (golint)
    • Line 9: warning: exported type Messages should have comment or be unexported (golint)
    • Line 11: warning: exported function NewMessages should have comment or be unexported (golint)
    • Line 15: warning: exported method Messages.Reset should have comment or be unexported (golint)
    • Line 23: warning: exported method Messages.GetByName should have comment or be unexported (golint)
    • Line 33: warning: exported method Messages.GetByIndex should have comment or be unexported (golint)
    • Line 41: warning: exported method Messages.Len should have comment or be unexported (golint)
    • haproxy-spoe-go/agent/agent.go
    • Line 9: warning: exported function New should have comment or be unexported (golint)
    • Line 17: warning: exported type Agent should have comment or be unexported (golint)
    • Line 21: warning: exported method Agent.Serve should have comment or be unexported (golint)
    • haproxy-spoe-go/client/client.go
    • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 13: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 19: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 24: warning: comment on exported method Client.Init should be of the form "Init ..." (golint)
    • Line 73: warning: comment on exported method Client.Notify should be of the form "Notify ..." (golint)
    • Line 92: warning: comment on exported method Client.Stop should be of the form "Stop ..." (golint)
    • haproxy-spoe-go/frame/frame.go
    • Line 10: warning: exported type Type should have comment or be unexported (golint)
    • Line 13: warning: exported const TypeUnset should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: exported function AcquireFrame should have comment or be unexported (golint)
    • Line 32: warning: exported function ReleaseFrame should have comment or be unexported (golint)
    • Line 69: warning: exported method Frame.Reset should have comment or be unexported (golint)
    • haproxy-spoe-go/action/action.go
    • Line 7: warning: exported type Type should have comment or be unexported (golint)
    • Line 9: warning: exported type Scope should have comment or be unexported (golint)
    • Line 15: warning: exported const TypeSetVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type Action should have comment or be unexported (golint)
    • Line 38: warning: exported method Action.SetVar should have comment or be unexported (golint)
    • Line 45: warning: exported method Action.UnsetVar should have comment or be unexported (golint)
    • Line 57: warning: exported function AcquireAction should have comment or be unexported (golint)
    • Line 66: warning: exported function ReleaseAction should have comment or be unexported (golint)
    • Line 71: warning: exported method Action.Reset should have comment or be unexported (golint)
    • haproxy-spoe-go/action/actions.go
    • Line 3: warning: exported type Actions should have comment or be unexported (golint)
    • Line 5: warning: exported method Actions.SetVar should have comment or be unexported (golint)
    • Line 11: warning: exported method Actions.UnsetVar should have comment or be unexported (golint)
    • Line 17: warning: exported method Actions.Reset should have comment or be unexported (golint)
    • Line 25: warning: exported function NewActions should have comment or be unexported (golint)
    • haproxy-spoe-go/payload/kv/kv.go
    • Line 16: warning: exported function AcquireKV should have comment or be unexported (golint)
    • Line 20: warning: exported function ReleaseKV should have comment or be unexported (golint)
    • Line 25: warning: exported type Item should have comment or be unexported (golint)
    • Line 30: warning: exported type KV should have comment or be unexported (golint)
    • Line 35: warning: exported function NewKV should have comment or be unexported (golint)
    • Line 44: warning: exported method KV.Data should have comment or be unexported (golint)
    • Line 48: warning: exported method KV.Reset should have comment or be unexported (golint)
    • Line 52: warning: exported method KV.Add should have comment or be unexported (golint)
    • Line 56: warning: exported method KV.Get should have comment or be unexported (golint)
    • Line 66: warning: exported method KV.Bytes should have comment or be unexported (golint)
    • Line 85: warning: exported method KV.Unmarshal should have comment or be unexported (golint)
    • Line 118: warning: exported method KV.UnmarshalNB should have comment or be unexported (golint)
    • haproxy-spoe-go/message/message.go
    • Line 14: warning: exported type Message should have comment or be unexported (golint)
    • Line 27: warning: exported function AcquireMessage should have comment or be unexported (golint)
    • Line 36: warning: exported function ReleaseMessage should have comment or be unexported (golint)
    • Line 41: warning: exported method Message.Reset should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign86%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!