gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• internal/measured-appnet/dispatcher.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• examples/spate/client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• examples/spate/main.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• examples/spate/main.go
  • Line 9: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

golint16%

Golint is a linter for Go source code.

• network/line_message.go
  • Line 8: warning: exported type LineMessage should have comment or be unexported (golint)
  • Line 12: warning: exported function NewLineMessageString should have comment or be unexported (golint)
  • Line 20: warning: exported function NewLineMessage should have comment or be unexported (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• network/transport_properties.go
  • Line 3: warning: exported type TransportProperties should have comment or be unexported (golint)
  • Line 9: warning: exported function NewTransportProperties should have comment or be unexported (golint)
  • Line 17: warning: exported method TransportProperties.Set should have comment or be unexported (golint)
  • Line 21: warning: exported method TransportProperties.Require should have comment or be unexported (golint)
  • Line 26: warning: exported method TransportProperties.Prefer should have comment or be unexported (golint)
  • Line 31: warning: exported method TransportProperties.Ignore should have comment or be unexported (golint)
  • Line 36: warning: exported method TransportProperties.Avoid should have comment or be unexported (golint)
  • Line 40: warning: exported method TransportProperties.Prohibit should have comment or be unexported (golint)

• examples/spate/server.go
  • Line 17: warning: exported type AsyncReadResult should have comment or be unexported (golint)
  • Line 18: warning: don't use underscores in Go names; struct field resp_length should be respLength (golint)
  • Line 22: warning: exported type IntervalElement should have comment or be unexported (golint)
  • Line 30: warning: don't use underscores in Go names; var resp_length should be respLength (golint)
  • Line 36: warning: exported type AsyncReadFromResult should have comment or be unexported (golint)
  • Line 37: warning: don't use underscores in Go names; struct field resp_length should be respLength (golint)
  • Line 45: warning: don't use underscores in Go names; var resp_length should be respLength (golint)
  • Line 52: warning: exported type SpateServerSpawner should have comment or be unexported (golint)
  • Line 53: warning: don't use underscores in Go names; struct field runtime_duration should be runtimeDuration (golint)
  • Line 54: warning: don't use underscores in Go names; struct field interval_freq should be intervalFreq (golint)
  • Line 56: warning: don't use underscores in Go names; struct field packet_size should be packetSize (golint)
  • Line 62: warning: exported function NewSpateServerSpawner should have comment or be unexported (golint)
  • Line 63: warning: don't use underscores in Go names; var runtime_duration should be runtimeDuration (golint)
  • Line 64: warning: don't use underscores in Go names; var interval_freq should be intervalFreq (golint)
  • Line 73: warning: exported method SpateServerSpawner.Port should have comment or be unexported (golint)
  • Line 78: warning: exported method SpateServerSpawner.Transport should have comment or be unexported (golint)
  • Line 83: warning: exported method SpateServerSpawner.Network should have comment or be unexported (golint)
  • Line 88: warning: exported method SpateServerSpawner.Address should have comment or be unexported (golint)
  • Line 93: warning: exported method SpateServerSpawner.RuntimeDuration should have comment or be unexported (golint)
  • Line 93: warning: don't use underscores in Go names; method parameter runtime_duration should be runtimeDuration (golint)
  • Line 98: warning: exported method SpateServerSpawner.IntervalFrequency should have comment or be unexported (golint)
  • Line 103: warning: exported method SpateServerSpawner.PacketSize should have comment or be unexported (golint)
  • Line 103: warning: don't use underscores in Go names; method parameter packet_size should be packetSize (golint)
  • Line 108: warning: don't use underscores in Go names; func parameter recv_bytes should be recvBytes (golint)
  • Line 117: warning: don't use underscores in Go names; var elements_at_start should be elementsAtStart (golint)
  • Line 118: warning: don't use underscores in Go names; var start_time should be startTime (golint)
  • Line 130: warning: exported method SpateServerSpawner.Spawn should have comment or be unexported (golint)
  • Line 162: warning: don't use underscores in Go names; var bytes_received should be bytesReceived (golint)
  • Line 163: warning: don't use underscores in Go names; var packets_received should be packetsReceived (golint)
  • Line 168: warning: don't use underscores in Go names; var recv_bytes_channel should be recvBytesChannel (golint)
  • Line 180: warning: don't use underscores in Go names; var read_result should be readResult (golint)
  • Line 192: warning: don't use underscores in Go names; var bytes_received should be bytesReceived (golint)
  • Line 194: warning: don't use underscores in Go names; var packets_received should be packetsReceived (golint)

• network/fixed_message.go
  • Line 8: warning: exported type FixedMessage should have comment or be unexported (golint)
  • Line 14: warning: exported function NewFixedMessageString should have comment or be unexported (golint)
  • Line 19: warning: exported function NewFixedMessage should have comment or be unexported (golint)

• network/types.go
  • Line 4: warning: exported const NETWORK_IP should have comment (or a comment on this block) or be unexported (golint)

• network/udp.go
  • Line 8: warning: exported type UDP should have comment or be unexported (golint)
  • Line 17: warning: exported function NewUDP should have comment or be unexported (golint)
  • Line 21: warning: exported method UDP.Send should have comment or be unexported (golint)
  • Line 26: warning: exported method UDP.Receive should have comment or be unexported (golint)
  • Line 49: warning: exported method UDP.Close should have comment or be unexported (golint)
  • Line 59: warning: exported method UDP.SetError should have comment or be unexported (golint)
  • Line 63: warning: exported method UDP.GetError should have comment or be unexported (golint)
  • Line 67: warning: exported method UDP.LocalAddr should have comment or be unexported (golint)
  • Line 71: warning: exported method UDP.RemoteAddr should have comment or be unexported (golint)

• internal/measured-appnet/dispatcher.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported type TimedPacketDispatcherService should have comment or be unexported (golint)
  • Line 17: warning: exported method TimedPacketDispatcherService.Register should have comment or be unexported (golint)

• examples/spate/bits.go
  • Line 17: warning: exported function ParseBitsPerSecond should have comment or be unexported (golint)

• examples/spate/rand.go
  • Line 8: warning: comment on exported type FastRand should be of the form "FastRand ..." (with optional leading article) (golint)
  • Line 15: warning: exported function NewFastRand should have comment or be unexported (golint)
  • Line 19: warning: exported method FastRand.Get should have comment or be unexported (golint)

• network/scion/scion.go
  • Line 26: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 37: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 41: warning: exported function Network should have comment or be unexported (golint)

• network/endpoint.go
  • Line 3: warning: exported type Endpoint should have comment or be unexported (golint)
  • Line 11: warning: exported function NewRemoteEndpoint should have comment or be unexported (golint)
  • Line 15: warning: exported function NewLocalEndpoint should have comment or be unexported (golint)
  • Line 19: warning: exported method Endpoint.WithNetwork should have comment or be unexported (golint)
  • Line 23: warning: exported method Endpoint.WithTransport should have comment or be unexported (golint)
  • Line 27: warning: exported method Endpoint.WithAddress should have comment or be unexported (golint)

• network/quic.go
  • Line 14: warning: exported type QUIC should have comment or be unexported (golint)
  • Line 23: warning: exported function NewQUIC should have comment or be unexported (golint)
  • Line 27: warning: exported method QUIC.Send should have comment or be unexported (golint)
  • Line 33: warning: exported method QUIC.Receive should have comment or be unexported (golint)
  • Line 50: warning: exported method QUIC.Close should have comment or be unexported (golint)
  • Line 57: warning: exported method QUIC.LocalAddr should have comment or be unexported (golint)
  • Line 61: warning: exported method QUIC.RemoteAddr should have comment or be unexported (golint)
  • Line 65: warning: exported method QUIC.SetError should have comment or be unexported (golint)
  • Line 69: warning: exported method QUIC.GetError should have comment or be unexported (golint)

• network/tcp.go
  • Line 8: warning: exported type TCP should have comment or be unexported (golint)
  • Line 15: warning: exported function NewTCP should have comment or be unexported (golint)
  • Line 19: warning: exported method TCP.Send should have comment or be unexported (golint)
  • Line 24: warning: exported method TCP.Receive should have comment or be unexported (golint)
  • Line 37: warning: exported method TCP.Close should have comment or be unexported (golint)
  • Line 41: warning: exported method TCP.LocalAddr should have comment or be unexported (golint)
  • Line 45: warning: exported method TCP.RemoteAddr should have comment or be unexported (golint)
  • Line 49: warning: exported method TCP.SetError should have comment or be unexported (golint)
  • Line 53: warning: exported method TCP.GetError should have comment or be unexported (golint)

• lua/selector.go
  • Line 13: warning: don't use underscores in Go names; func new_lua_path_interface should be newLuaPathInterface (golint)
  • Line 21: warning: don't use underscores in Go names; func new_lua_path should be newLuaPath (golint)
  • Line 85: warning: don't use underscores in Go names; func lua_table_slice_to_table should be luaTableSliceToTable (golint)
  • Line 99: warning: don't use underscores in Go names; func new_state should be newState (golint)
  • Line 106: warning: don't use underscores in Go names; method get_pan_path should be getPanPath (golint)
  • Line 110: warning: don't use underscores in Go names; method clear_addr should be clearAddr (golint)
  • Line 118: warning: don't use underscores in Go names; method set_paths should be setPaths (golint)
  • Line 130: warning: exported type LuaSelector should have comment or be unexported (golint)
  • Line 137: warning: comment on exported function NewSelector should be of the form "NewSelector ..." (golint)
  • Line 192: warning: exported method LuaSelector.Initialize should have comment or be unexported (golint)
  • Line 218: warning: exported method LuaSelector.Path should have comment or be unexported (golint)
  • Line 240: warning: exported method LuaSelector.PathDown should have comment or be unexported (golint)
  • Line 259: warning: exported method LuaSelector.Refresh should have comment or be unexported (golint)
  • Line 284: warning: exported method LuaSelector.Close should have comment or be unexported (golint)

• internal/measured-appnet/packet_conn.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported type TimedSCIONPacketConn should have comment or be unexported (golint)
  • Line 28: warning: exported method TimedSCIONPacketConn.SetDeadline should have comment or be unexported (golint)
  • Line 32: warning: exported method TimedSCIONPacketConn.Close should have comment or be unexported (golint)
  • Line 36: warning: exported method TimedSCIONPacketConn.WriteTo should have comment or be unexported (golint)
  • Line 52: warning: exported method TimedSCIONPacketConn.SetWriteDeadline should have comment or be unexported (golint)
  • Line 56: warning: exported method TimedSCIONPacketConn.ReadFrom should have comment or be unexported (golint)
  • Line 107: warning: exported method TimedSCIONPacketConn.SetReadDeadline should have comment or be unexported (golint)

• rpc/rpc.go
  • Line 14: warning: exported type IDMsg should have comment or be unexported (golint)
  • Line 18: warning: exported type IDServer should have comment or be unexported (golint)
  • Line 22: warning: exported method IDServer.GetID should have comment or be unexported (golint)
  • Line 28: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 49: warning: exported type Client should have comment or be unexported (golint)
  • Line 55: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 84: warning: exported method Client.Call should have comment or be unexported (golint)
  • Line 89: warning: exported method Client.Close should have comment or be unexported (golint)

• debug/selector.go
  • Line 9: warning: exported type DebugSelector should have comment or be unexported (golint)
  • Line 14: warning: exported function NewDebugSelector should have comment or be unexported (golint)
  • Line 22: warning: exported method DebugSelector.Initialize should have comment or be unexported (golint)
  • Line 29: warning: exported method DebugSelector.Path should have comment or be unexported (golint)
  • Line 37: warning: exported method DebugSelector.PathDown should have comment or be unexported (golint)
  • Line 45: warning: exported method DebugSelector.Refresh should have comment or be unexported (golint)
  • Line 52: warning: exported method DebugSelector.Close should have comment or be unexported (golint)

• internal/measured-appnet/appnet.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported type Network should have comment or be unexported (golint)
  • Line 33: warning: exported function DefNetwork should have comment or be unexported (golint)
  • Line 38: warning: exported function Dial should have comment or be unexported (golint)
  • Line 46: warning: exported function DialAddr should have comment or be unexported (golint)
  • Line 61: warning: exported function Listen should have comment or be unexported (golint)
  • Line 80: warning: exported function ListenPort should have comment or be unexported (golint)

• examples/spate/client.go
  • Line 18: warning: exported type SpateClientSpawner should have comment or be unexported (golint)
  • Line 21: warning: don't use underscores in Go names; struct field server_address should be serverAddress (golint)
  • Line 22: warning: don't use underscores in Go names; struct field packet_size should be packetSize (golint)
  • Line 23: warning: don't use underscores in Go names; struct field single_path should be singlePath (golint)
  • Line 30: warning: comment on exported function NewSpateClientSpawner should be of the form "NewSpateClientSpawner ..." (golint)
  • Line 41: warning: exported method SpateClientSpawner.ServerAddress should have comment or be unexported (golint)
  • Line 41: warning: don't use underscores in Go names; method parameter server_address should be serverAddress (golint)
  • Line 46: warning: exported method SpateClientSpawner.Network should have comment or be unexported (golint)
  • Line 50: warning: exported method SpateClientSpawner.Transport should have comment or be unexported (golint)
  • Line 55: warning: exported method SpateClientSpawner.PacketSize should have comment or be unexported (golint)
  • Line 55: warning: don't use underscores in Go names; method parameter packet_size should be packetSize (golint)
  • Line 60: warning: exported method SpateClientSpawner.Parallel should have comment or be unexported (golint)
  • Line 65: warning: exported method SpateClientSpawner.SinglePath should have comment or be unexported (golint)
  • Line 65: warning: don't use underscores in Go names; method parameter single_path should be singlePath (golint)
  • Line 70: warning: exported method SpateClientSpawner.Interactive should have comment or be unexported (golint)
  • Line 75: warning: exported method SpateClientSpawner.Bandwidth should have comment or be unexported (golint)
  • Line 80: warning: exported method SpateClientSpawner.Script should have comment or be unexported (golint)
  • Line 85: warning: exported method SpateClientSpawner.Spawn should have comment or be unexported (golint)
  • Line 174: warning: don't use underscores in Go names; var bytes_sent should be bytesSent (golint)
  • Line 175: warning: don't use underscores in Go names; var packets_sent should be packetsSent (golint)
  • Line 211: warning: don't use underscores in Go names; var closed_conn should be closedConn (golint)
  • Line 212: warning: don't use underscores in Go names; var total_conn should be totalConn (golint)
  • Line 217: warning: don't use underscores in Go names; var bytes_sent should be bytesSent (golint)
  • Line 218: warning: don't use underscores in Go names; var packets_sent should be packetsSent (golint)
  • Line 223: warning: don't use underscores in Go names; var closed_conn should be closedConn (golint)
  • Line 232: warning: don't use underscores in Go names; var actual_bandwidth should be actualBandwidth (golint)
  • Line 255: warning: don't use underscores in Go names; var target_duration should be targetDuration (golint)
  • Line 256: warning: don't use underscores in Go names; var data_cs should be dataCs (golint)
  • Line 260: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 269: warning: don't use underscores in Go names; var sum_error should be sumError (golint)
  • Line 279: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
  • Line 287: warning: don't use underscores in Go names; var sum_error should be sumError (golint)
  • Line 306: warning: don't use underscores in Go names; var sent_bytes should be sentBytes (golint)

• network/scion/udp.go
  • Line 11: warning: exported type UDPDialer should have comment or be unexported (golint)
  • Line 15: warning: exported function NewUDPDialer should have comment or be unexported (golint)
  • Line 20: warning: exported method UDPDialer.Dial should have comment or be unexported (golint)
  • Line 28: warning: exported type UDPListener should have comment or be unexported (golint)
  • Line 32: warning: exported function NewUDPListener should have comment or be unexported (golint)
  • Line 40: warning: exported method UDPListener.Listen should have comment or be unexported (golint)
  • Line 48: warning: exported method UDPListener.Stop should have comment or be unexported (golint)

• rpc/connection_tracer.go
  • Line 14: warning: exported type ServerConnectionTracer should have comment or be unexported (golint)
  • Line 44: warning: exported type RTTStats should have comment or be unexported (golint)
  • Line 48: warning: exported function NewRTTStats should have comment or be unexported (golint)
  • Line 59: warning: exported type ConnectionTracerMsg should have comment or be unexported (golint)
  • Line 88: warning: don't use underscores in Go names; func non_nil_string should be nonNilString (golint)
  • Line 123: warning: exported type ConnectionTracerClient should have comment or be unexported (golint)
  • Line 128: warning: don't use underscores in Go names; struct field tracing_id should be tracingID (golint)
  • Line 132: warning: don't use underscores in Go names; method new_msg should be newMsg (golint)
  • Line 143: warning: exported function NewConnectionTracerClient should have comment or be unexported (golint)
  • Line 161: warning: exported method ConnectionTracerClient.StartedConnection should have comment or be unexported (golint)
  • Line 182: warning: exported method ConnectionTracerClient.NegotiatedVersion should have comment or be unexported (golint)
  • Line 197: warning: exported method ConnectionTracerClient.ClosedConnection should have comment or be unexported (golint)
  • Line 210: warning: exported method ConnectionTracerClient.SentTransportParameters should have comment or be unexported (golint)
  • Line 222: warning: exported method ConnectionTracerClient.ReceivedTransportParameters should have comment or be unexported (golint)
  • Line 234: warning: exported method ConnectionTracerClient.RestoredTransportParameters should have comment or be unexported (golint)
  • Line 246: warning: exported method ConnectionTracerClient.SentPacket should have comment or be unexported (golint)
  • Line 261: warning: exported method ConnectionTracerClient.ReceivedVersionNegotiationPacket should have comment or be unexported (golint)
  • Line 275: warning: exported method ConnectionTracerClient.ReceivedRetry should have comment or be unexported (golint)
  • Line 287: warning: exported method ConnectionTracerClient.ReceivedPacket should have comment or be unexported (golint)
  • Line 301: warning: exported method ConnectionTracerClient.BufferedPacket should have comment or be unexported (golint)
  • Line 313: warning: exported method ConnectionTracerClient.DroppedPacket should have comment or be unexported (golint)
  • Line 327: warning: exported method ConnectionTracerClient.UpdatedMetrics should have comment or be unexported (golint)
  • Line 342: warning: exported method ConnectionTracerClient.AcknowledgedPacket should have comment or be unexported (golint)
  • Line 355: warning: exported method ConnectionTracerClient.LostPacket should have comment or be unexported (golint)
  • Line 369: warning: exported method ConnectionTracerClient.UpdatedCongestionState should have comment or be unexported (golint)
  • Line 381: warning: exported method ConnectionTracerClient.UpdatedPTOCount should have comment or be unexported (golint)
  • Line 393: warning: exported method ConnectionTracerClient.UpdatedKeyFromTLS should have comment or be unexported (golint)
  • Line 406: warning: exported method ConnectionTracerClient.UpdatedKey should have comment or be unexported (golint)
  • Line 419: warning: exported method ConnectionTracerClient.DroppedEncryptionLevel should have comment or be unexported (golint)
  • Line 431: warning: exported method ConnectionTracerClient.DroppedKey should have comment or be unexported (golint)
  • Line 443: warning: exported method ConnectionTracerClient.SetLossTimer should have comment or be unexported (golint)
  • Line 457: warning: exported method ConnectionTracerClient.LossTimerExpired should have comment or be unexported (golint)
  • Line 470: warning: exported method ConnectionTracerClient.LossTimerCanceled should have comment or be unexported (golint)
  • Line 481: warning: exported method ConnectionTracerClient.Close should have comment or be unexported (golint)
  • Line 492: warning: exported method ConnectionTracerClient.Debug should have comment or be unexported (golint)
  • Line 506: warning: exported type NilMsg should have comment or be unexported (golint)
  • Line 508: warning: exported type ConnectionTracerServer should have comment or be unexported (golint)
  • Line 513: warning: exported function NewConnectionTracerServer should have comment or be unexported (golint)
  • Line 517: warning: exported method ConnectionTracerServer.NewTracerForConnection should have comment or be unexported (golint)
  • Line 521: warning: don't use underscores in Go names; var tracing_id should be tracingID (golint)
  • Line 526: warning: exported method ConnectionTracerServer.StartedConnection should have comment or be unexported (golint)
  • Line 534: warning: exported method ConnectionTracerServer.NegotiatedVersion should have comment or be unexported (golint)
  • Line 539: warning: exported method ConnectionTracerServer.ClosedConnection should have comment or be unexported (golint)
  • Line 543: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 548: warning: exported method ConnectionTracerServer.SentTransportParameters should have comment or be unexported (golint)
  • Line 553: warning: exported method ConnectionTracerServer.ReceivedTransportParameters should have comment or be unexported (golint)
  • Line 558: warning: exported method ConnectionTracerServer.RestoredTransportParameters should have comment or be unexported (golint)
  • Line 563: warning: exported method ConnectionTracerServer.SentPacket should have comment or be unexported (golint)
  • Line 568: warning: exported method ConnectionTracerServer.ReceivedVersionNegotiationPacket should have comment or be unexported (golint)
  • Line 573: warning: exported method ConnectionTracerServer.ReceivedRetry should have comment or be unexported (golint)
  • Line 578: warning: exported method ConnectionTracerServer.ReceivedPacket should have comment or be unexported (golint)
  • Line 583: warning: exported method ConnectionTracerServer.BufferedPacket should have comment or be unexported (golint)
  • Line 588: warning: exported method ConnectionTracerServer.DroppedPacket should have comment or be unexported (golint)
  • Line 593: warning: exported method ConnectionTracerServer.UpdatedMetrics should have comment or be unexported (golint)
  • Line 598: warning: exported method ConnectionTracerServer.AcknowledgedPacket should have comment or be unexported (golint)
  • Line 603: warning: exported method ConnectionTracerServer.LostPacket should have comment or be unexported (golint)
  • Line 608: warning: exported method ConnectionTracerServer.UpdatedCongestionState should have comment or be unexported (golint)
  • Line 613: warning: exported method ConnectionTracerServer.UpdatedPTOCount should have comment or be unexported (golint)
  • Line 618: warning: exported method ConnectionTracerServer.UpdatedKeyFromTLS should have comment or be unexported (golint)
  • Line 623: warning: exported method ConnectionTracerServer.UpdatedKey should have comment or be unexported (golint)
  • Line 628: warning: exported method ConnectionTracerServer.DroppedEncryptionLevel should have comment or be unexported (golint)
  • Line 633: warning: exported method ConnectionTracerServer.DroppedKey should have comment or be unexported (golint)
  • Line 638: warning: exported method ConnectionTracerServer.SetLossTimer should have comment or be unexported (golint)
  • Line 646: warning: exported method ConnectionTracerServer.LossTimerExpired should have comment or be unexported (golint)
  • Line 651: warning: exported method ConnectionTracerServer.LossTimerCanceled should have comment or be unexported (golint)
  • Line 656: warning: exported method ConnectionTracerServer.Close should have comment or be unexported (golint)
  • Line 661: warning: exported method ConnectionTracerServer.Debug should have comment or be unexported (golint)

• network/errors.go
  • Line 6: warning: error var NetTypeError should have name of the form ErrFoo (golint)
  • Line 6: warning: exported var NetTypeError should have comment or be unexported (golint)
  • Line 7: warning: error var AddrTypeError should have name of the form ErrFoo (golint)
  • Line 8: warning: error var EOM should have name of the form ErrFoo (golint)
  • Line 9: warning: error var NewlineError should have name of the form ErrFoo (golint)

• network/interfaces.go
  • Line 8: warning: exported type Message should have comment or be unexported (golint)
  • Line 13: warning: exported type Connection should have comment or be unexported (golint)
  • Line 23: warning: exported type Dialer should have comment or be unexported (golint)
  • Line 27: warning: exported type Listener should have comment or be unexported (golint)
  • Line 32: warning: exported type Preconnection should have comment or be unexported (golint)
  • Line 37: warning: exported type Network should have comment or be unexported (golint)

• lua/stats.go
  • Line 17: warning: don't use underscores in Go names; func new_lua_parameters should be newLuaParameters (golint)
  • Line 51: warning: don't use underscores in Go names; func new_lua_rtt_stats should be newLuaRttStats (golint)
  • Line 65: warning: exported type Stats should have comment or be unexported (golint)
  • Line 70: warning: exported function NewStats should have comment or be unexported (golint)
  • Line 113: warning: exported method Stats.TracerForConnection should have comment or be unexported (golint)
  • Line 113: warning: don't use underscores in Go names; method parameter tracer_id should be tracerID (golint)
  • Line 128: warning: exported method Stats.StartedConnection should have comment or be unexported (golint)
  • Line 145: warning: exported method Stats.NegotiatedVersion should have comment or be unexported (golint)
  • Line 150: warning: don't use underscores in Go names; var c_vs should be cVs (golint)
  • Line 151: warning: don't use underscores in Go names; var s_vs should be sVs (golint)
  • Line 173: warning: exported method Stats.ClosedConnection should have comment or be unexported (golint)
  • Line 188: warning: exported method Stats.SentTransportParameters should have comment or be unexported (golint)
  • Line 203: warning: exported method Stats.ReceivedTransportParameters should have comment or be unexported (golint)
  • Line 218: warning: exported method Stats.RestoredTransportParameters should have comment or be unexported (golint)
  • Line 233: warning: exported method Stats.SentPacket should have comment or be unexported (golint)
  • Line 247: warning: exported method Stats.ReceivedVersionNegotiationPacket should have comment or be unexported (golint)
  • Line 267: warning: exported method Stats.ReceivedRetry should have comment or be unexported (golint)
  • Line 281: warning: exported method Stats.ReceivedPacket should have comment or be unexported (golint)
  • Line 295: warning: exported method Stats.BufferedPacket should have comment or be unexported (golint)
  • Line 310: warning: exported method Stats.DroppedPacket should have comment or be unexported (golint)
  • Line 327: warning: exported method Stats.UpdatedMetrics should have comment or be unexported (golint)
  • Line 345: warning: exported method Stats.AcknowledgedPacket should have comment or be unexported (golint)
  • Line 361: warning: exported method Stats.LostPacket should have comment or be unexported (golint)
  • Line 378: warning: exported method Stats.UpdatedCongestionState should have comment or be unexported (golint)
  • Line 393: warning: exported method Stats.UpdatedPTOCount should have comment or be unexported (golint)
  • Line 408: warning: exported method Stats.UpdatedKeyFromTLS should have comment or be unexported (golint)
  • Line 424: warning: exported method Stats.UpdatedKey should have comment or be unexported (golint)
  • Line 440: warning: exported method Stats.DroppedEncryptionLevel should have comment or be unexported (golint)
  • Line 455: warning: exported method Stats.DroppedKey should have comment or be unexported (golint)
  • Line 470: warning: exported method Stats.SetLossTimer should have comment or be unexported (golint)
  • Line 487: warning: exported method Stats.LossTimerExpired should have comment or be unexported (golint)
  • Line 503: warning: exported method Stats.LossTimerCanceled should have comment or be unexported (golint)
  • Line 517: warning: exported method Stats.Close should have comment or be unexported (golint)
  • Line 531: warning: exported method Stats.Debug should have comment or be unexported (golint)

• internal/measured-appnet/timednet.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: exported function NewNetwork should have comment or be unexported (golint)

• network/ip/ip.go
  • Line 19: warning: exported type UDPDialer should have comment or be unexported (golint)
  • Line 23: warning: exported function NewUDPDialer should have comment or be unexported (golint)
  • Line 31: warning: exported method UDPDialer.Dial should have comment or be unexported (golint)
  • Line 39: warning: exported type UDPListener should have comment or be unexported (golint)
  • Line 43: warning: exported function NewUDPListener should have comment or be unexported (golint)
  • Line 51: warning: exported method UDPListener.Listen should have comment or be unexported (golint)
  • Line 59: warning: exported method UDPListener.Stop should have comment or be unexported (golint)
  • Line 63: warning: exported type TCPDialer should have comment or be unexported (golint)
  • Line 67: warning: exported function NewTCPDialer should have comment or be unexported (golint)
  • Line 75: warning: exported method TCPDialer.Dial should have comment or be unexported (golint)
  • Line 83: warning: exported type TCPListener should have comment or be unexported (golint)
  • Line 87: warning: exported function NewTCPListener should have comment or be unexported (golint)
  • Line 99: warning: exported method TCPListener.Listen should have comment or be unexported (golint)
  • Line 107: warning: exported method TCPListener.Stop should have comment or be unexported (golint)
  • Line 111: warning: exported type QUICDialer should have comment or be unexported (golint)
  • Line 115: warning: exported function NewQUICDialer should have comment or be unexported (golint)
  • Line 119: warning: exported method QUICDialer.Dial should have comment or be unexported (golint)
  • Line 135: warning: exported type QUICListener should have comment or be unexported (golint)
  • Line 139: warning: exported function NewQUICListener should have comment or be unexported (golint)
  • Line 147: warning: exported method QUICListener.Listen should have comment or be unexported (golint)
  • Line 159: warning: exported method QUICListener.Stop should have comment or be unexported (golint)
  • Line 176: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 189: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 193: warning: exported function Network should have comment or be unexported (golint)

• lua/lua.go
  • Line 12: warning: exported type State should have comment or be unexported (golint)
  • Line 18: warning: exported function NewState should have comment or be unexported (golint)
  • Line 27: warning: exported method State.LoadScript should have comment or be unexported (golint)
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• network/scion/quic.go
  • Line 20: warning: exported type QUICDialer should have comment or be unexported (golint)
  • Line 31: warning: exported function NewQUICDialer should have comment or be unexported (golint)
  • Line 60: warning: exported method QUICDialer.Dial should have comment or be unexported (golint)
  • Line 88: warning: exported type QUICListener should have comment or be unexported (golint)
  • Line 93: warning: exported function NewQUICListener should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 130: warning: exported method QUICListener.Listen should have comment or be unexported (golint)
  • Line 143: warning: exported method QUICListener.Stop should have comment or be unexported (golint)

• rpc/path.go
  • Line 9: warning: exported type Path should have comment or be unexported (golint)
  • Line 18: warning: exported method Path.PanPath should have comment or be unexported (golint)
  • Line 29: warning: exported function NewPathFrom should have comment or be unexported (golint)

• rpc/tracer.go
  • Line 15: warning: exported type TracerClient should have comment or be unexported (golint)
  • Line 20: warning: exported function NewTracerClient should have comment or be unexported (golint)
  • Line 24: warning: exported method TracerClient.TracerForConnection should have comment or be unexported (golint)
  • Line 34: warning: exported method TracerClient.SentPacket should have comment or be unexported (golint)
  • Line 49: warning: exported method TracerClient.DroppedPacket should have comment or be unexported (golint)
  • Line 64: warning: exported type TracerMsg should have comment or be unexported (golint)
  • Line 78: warning: exported type TracerServer should have comment or be unexported (golint)
  • Line 84: warning: exported function NewTracerServer should have comment or be unexported (golint)
  • Line 110: warning: exported method TracerServer.SentPacket should have comment or be unexported (golint)
  • Line 120: warning: exported method TracerServer.DroppedPacket should have comment or be unexported (golint)

• rpc/selector.go
  • Line 12: warning: exported var DefaultDaemonAddress should have comment or be unexported (golint)
  • Line 19: warning: exported type ServerSelector should have comment or be unexported (golint)
  • Line 32: warning: exported function NewServerSelectorFunc should have comment or be unexported (golint)
  • Line 71: warning: exported type SelectorMsg should have comment or be unexported (golint)
  • Line 79: warning: exported type SelectorServer should have comment or be unexported (golint)
  • Line 95: warning: exported function NewSelectorServer should have comment or be unexported (golint)
  • Line 99: warning: exported method SelectorServer.Initialize should have comment or be unexported (golint)
  • Line 112: warning: exported method SelectorServer.Path should have comment or be unexported (golint)
  • Line 123: warning: exported method SelectorServer.PathDown should have comment or be unexported (golint)
  • Line 131: warning: exported method SelectorServer.Refresh should have comment or be unexported (golint)
  • Line 144: warning: exported method SelectorServer.Close should have comment or be unexported (golint)
  • Line 152: warning: exported type SelectorClient should have comment or be unexported (golint)
  • Line 160: warning: exported function NewSelectorClient should have comment or be unexported (golint)
  • Line 165: warning: exported method SelectorClient.Initialize should have comment or be unexported (golint)
  • Line 185: warning: exported method SelectorClient.Path should have comment or be unexported (golint)
  • Line 201: warning: exported method SelectorClient.PathDown should have comment or be unexported (golint)
  • Line 216: warning: exported method SelectorClient.Refresh should have comment or be unexported (golint)
  • Line 234: warning: exported method SelectorClient.Close should have comment or be unexported (golint)

• panapi.go
  • Line 8: warning: exported const DaemonSocketPath should have comment (or a comment on this block) or be unexported (golint)
  • Line 11: warning: exported function NewRemoteEndpoint should have comment or be unexported (golint)
  • Line 15: warning: exported function NewLocalEndpoint should have comment or be unexported (golint)
  • Line 19: warning: comment on exported type TransportProperties should be of the form "TransportProperties ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewTransportProperties should have comment or be unexported (golint)

• preconnection.go
  • Line 9: warning: exported type Listener should have comment or be unexported (golint)
  • Line 14: warning: exported method Listener.Stop should have comment or be unexported (golint)
  • Line 18: warning: exported type Preconnection should have comment or be unexported (golint)
  • Line 24: warning: exported method Preconnection.Listen should have comment or be unexported (golint)
  • Line 39: warning: exported method Preconnection.Initiate should have comment or be unexported (golint)
  • Line 43: warning: exported function NewPreconnection should have comment or be unexported (golint)

• examples/spate/csv.go
  • Line 8: warning: exported type CSVPoint should have comment or be unexported (golint)
  • Line 12: warning: exported function WriteCSV should have comment or be unexported (golint)

• examples/spate/log.go
  • Line 9: warning: exported function Error should have comment or be unexported (golint)
  • Line 10: warning: don't use underscores in Go names; var error_label should be errorLabel (golint)
  • Line 15: warning: exported function Warn should have comment or be unexported (golint)
  • Line 16: warning: don't use underscores in Go names; var warn_label should be warnLabel (golint)
  • Line 21: warning: exported function Info should have comment or be unexported (golint)
  • Line 22: warning: don't use underscores in Go names; var info_label should be infoLabel (golint)

• cmd/daemon/main.go
  • Line 53: warning: don't use underscores in Go names; var lua_state should be luaState (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• network/ip/ip.go
  • Line 198: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!