Preparing report...

Report for github.com/nknorg/nconnect

A+    Excellent!    Found 10 issues across 22 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo86%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint59%

Golint is a linter for Go source code.

    • nconnect/config/config.go
    • Line 20: warning: exported const RandomIdentifierChars should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported var Version should have comment or be unexported (golint)
    • Line 34: warning: exported type Config should have comment or be unexported (golint)
    • Line 80: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 87: warning: exported function LoadOrNewConfig should have comment or be unexported (golint)
    • Line 111: warning: exported method Config.SetPlatformSpecificDefaultValues should have comment or be unexported (golint)
    • Line 123: warning: exported method Config.VerifyClient should have comment or be unexported (golint)
    • Line 130: warning: exported method Config.VerifyServer should have comment or be unexported (golint)
    • Line 134: warning: exported method Config.GetAcceptAddrs should have comment or be unexported (golint)
    • Line 140: warning: exported method Config.SetAcceptAddrs should have comment or be unexported (golint)
    • Line 147: warning: exported method Config.AddAcceptAddrs should have comment or be unexported (golint)
    • Line 154: warning: exported method Config.RemoveAcceptAddrs should have comment or be unexported (golint)
    • Line 161: warning: exported method Config.GetAdminAddrs should have comment or be unexported (golint)
    • Line 167: warning: exported method Config.SetAdminAddrs should have comment or be unexported (golint)
    • Line 174: warning: exported method Config.AddAdminAddrs should have comment or be unexported (golint)
    • Line 181: warning: exported method Config.RemoveAdminAddrs should have comment or be unexported (golint)
    • Line 188: warning: exported method Config.SetAdminHTTPAPI should have comment or be unexported (golint)
    • Line 195: warning: exported method Config.SetSeed should have comment or be unexported (golint)
    • Line 211: warning: exported method Config.SetTunaConfig should have comment or be unexported (golint)
    • Line 219: warning: exported method Config.Save should have comment or be unexported (golint)
    • Line 243: warning: exported function RandomIdentifier should have comment or be unexported (golint)
    • nconnect/admin/client.go
    • Line 24: warning: exported type Client should have comment or be unexported (golint)
    • Line 29: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 45: warning: exported method Client.RPCCall should have comment or be unexported (golint)
    • Line 89: warning: exported method Client.GetInfo should have comment or be unexported (golint)
    • nconnect/ss/ss.go
    • Line 14: warning: exported type Config should have comment or be unexported (golint)
    • Line 41: warning: exported function Start should have comment or be unexported (golint)
    • nconnect/util/util.go
    • Line 12: warning: exported function GetFreePort should have comment or be unexported (golint)
    • Line 28: warning: exported function MergeStrings should have comment or be unexported (golint)
    • Line 45: warning: exported function RemoveStrings should have comment or be unexported (golint)
    • Line 62: warning: exported function JSONConvert should have comment or be unexported (golint)
    • Line 70: warning: exported function MatchRegex should have comment or be unexported (golint)
    • Line 84: warning: exported function ParseExecError should have comment or be unexported (golint)
    • nconnect/admin/token.go
    • Line 12: warning: exported const TokenSize should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported type UnixTime should have comment or be unexported (golint)
    • Line 27: warning: exported method UnixTime.MarshalJSON should have comment or be unexported (golint)
    • Line 31: warning: exported type Token should have comment or be unexported (golint)
    • Line 36: warning: exported function NewToken should have comment or be unexported (golint)
    • Line 45: warning: exported method Token.IsValid should have comment or be unexported (golint)
    • Line 52: warning: exported type TokenStore should have comment or be unexported (golint)
    • Line 61: warning: exported function NewTokenStore should have comment or be unexported (golint)
    • Line 72: warning: exported method TokenStore.Start should have comment or be unexported (golint)
    • Line 82: warning: exported method TokenStore.GetCurrentToken should have comment or be unexported (golint)
    • Line 88: warning: exported method TokenStore.IsValid should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!