Preparing report...

Report for github.com/nlowe/mousiki

A+    Excellent!    Found 28 issues across 40 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint30%

Golint is a linter for Go source code.

    • mousiki/testutil/json.go
    • Line 11: warning: exported function UnmarshalRequest should have comment or be unexported (golint)
    • Line 16: warning: exported function MarshalResponse should have comment or be unexported (golint)
    • mousiki/mousiki/ui/centered_modal.go
    • Line 5: warning: exported type CenteredModal should have comment or be unexported (golint)
    • Line 11: warning: exported function NewCenteredModal should have comment or be unexported (golint)
    • Line 25: warning: exported method CenteredModal.Resize should have comment or be unexported (golint)
    • mousiki/pandora/api/feedback.go
    • Line 3: warning: exported type AddFeedbackRequest should have comment or be unexported (golint)
    • Line 8: warning: exported type AddFeedbackResponse should have comment or be unexported (golint)
    • Line 17: warning: exported type AddTiredRequest should have comment or be unexported (golint)
    • Line 21: warning: exported type AddTiredResponse should have comment or be unexported (golint)
    • mousiki/mousiki/ui/station_switcher.go
    • Line 14: warning: exported const EscapeActionExit should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported function NewStationPickerForPager should have comment or be unexported (golint)
    • mousiki/mousiki/ui/track.go
    • Line 15: warning: exported function FormatTrackTitle should have comment or be unexported (golint)
    • Line 19: warning: exported function FormatTrackArtist should have comment or be unexported (golint)
    • Line 23: warning: exported function FormatTrackAlbum should have comment or be unexported (golint)
    • Line 27: warning: exported function FormatTrack should have comment or be unexported (golint)
    • mousiki/pandora/api/station.go
    • Line 5: warning: exported type StationSortOrder should have comment or be unexported (golint)
    • Line 7: warning: exported const StationSortOrderLastPlayed should have comment or be unexported (golint)
    • Line 9: warning: exported type StationRequest should have comment or be unexported (golint)
    • Line 14: warning: exported type StationResponse should have comment or be unexported (golint)
    • mousiki/mousiki/station_controller.go
    • Line 13: warning: exported const NoStationSelected should have comment or be unexported (golint)
    • Line 26: warning: exported type StationController should have comment or be unexported (golint)
    • Line 48: warning: exported function NewStationController should have comment or be unexported (golint)
    • Line 64: warning: exported method StationController.Play should have comment or be unexported (golint)
    • Line 109: warning: exported method StationController.Skip should have comment or be unexported (golint)
    • Line 116: warning: exported method StationController.NowPlaying should have comment or be unexported (golint)
    • Line 120: warning: comment on exported method StationController.ProvideFeedback should be of the form "ProvideFeedback ..." (golint)
    • Line 145: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 168: warning: exported method StationController.UpNext should have comment or be unexported (golint)
    • Line 175: warning: exported method StationController.ListStations should have comment or be unexported (golint)
    • Line 179: warning: exported method StationController.SwitchStations should have comment or be unexported (golint)
    • Line 207: warning: exported method StationController.ExplainCurrentTrack should have comment or be unexported (golint)
    • Line 226: warning: exported method StationController.StationChanged should have comment or be unexported (golint)
    • Line 230: warning: exported method StationController.CurrentStation should have comment or be unexported (golint)
    • Line 234: warning: exported method StationController.NotificationChan should have comment or be unexported (golint)
    • mousiki/pandora/api/login.go
    • Line 3: warning: exported type LoginRequest should have comment or be unexported (golint)
    • Line 10: warning: exported type LoginResponse should have comment or be unexported (golint)
    • mousiki/cmd/root.go
    • Line 27: warning: exported var RootCmd should have comment or be unexported (golint)
    • Line 77: warning: exported function MarkFlagRequired should have comment or be unexported (golint)
    • Line 118: warning: exported function Exec should have comment or be unexported (golint)
    • mousiki/pandora/api/playlist.go
    • Line 5: warning: exported type FragmentRequestReason should have comment or be unexported (golint)
    • Line 8: warning: exported const FragmentRequestReasonNormal should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported type GetPlaylistFragmentRequest should have comment or be unexported (golint)
    • Line 23: warning: exported type GetPlaylistFragmentResponse should have comment or be unexported (golint)
    • mousiki/pandora/api/legacy.go
    • Line 45: warning: exported type LegacyRequest should have comment or be unexported (golint)
    • Line 49: warning: exported type LegacyResponse should have comment or be unexported (golint)
    • Line 53: warning: exported type LegacyPartnerLoginRequest should have comment or be unexported (golint)
    • Line 66: warning: exported type LegacyPartnerLoginResponseResult should have comment or be unexported (golint)
    • Line 72: warning: exported type LegacyPartnerLoginResponse should have comment or be unexported (golint)
    • Line 77: warning: exported type LegacyUserLoginRequest should have comment or be unexported (golint)
    • Line 86: warning: exported type LegacyUserLoginResponseResult should have comment or be unexported (golint)
    • Line 90: warning: exported type LegacyUserLoginResponse should have comment or be unexported (golint)
    • mousiki/pandora/audio.go
    • Line 3: warning: exported type AudioFormat should have comment or be unexported (golint)
    • Line 6: warning: exported const AudioFormatAACPlus should have comment (or a comment on this block) or be unexported (golint)
    • Line 11: warning: exported function IsValidAudioFormat should have comment or be unexported (golint)
    • mousiki/pandora/track.go
    • Line 5: warning: exported type TrackType should have comment or be unexported (golint)
    • Line 8: warning: exported const TrackTypeTrack should have comment (or a comment on this block) or be unexported (golint)
    • Line 11: warning: exported type TrackRating should have comment or be unexported (golint)
    • Line 23: warning: exported type Track should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!