gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• nocalhost/internal/nhctl/envsubst/nocalhostInclude_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/envsubst/nocalhost_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/cmd/nocalhost-dep/nocalhost-dep.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/daemon_server/syncthing.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nocalhost-api/repository/application_cluster/application_cluster_repo.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/syncthing/api.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/cmd/nhctl/cmds/sync_status.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/envsubst/parse/parse.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/app/git.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/internal/nhctl/app/install.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/pkg/nocalhost-api/app/api/v1/applications/get.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/create.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nocalhost/vpn/vpn.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• nocalhost/internal/nocalhost-api/model/model.go
  • Line 33: warning: cyclomatic complexity 18 of function WhereBuild() is high (> 15) (gocyclo)

• nocalhost/test/nhctlcli/cmdrunner.go
  • Line 72: warning: cyclomatic complexity 17 of function (*CmdRunner).RunWithRollingOut() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/app/install.go
  • Line 126: warning: cyclomatic complexity 17 of function (*Application).installHelm() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/app/build.go
  • Line 44: warning: cyclomatic complexity 17 of function BuildApplication() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/controller/statefulset_controller.go
  • Line 43: warning: cyclomatic complexity 27 of function (*StatefulSetController).ReplaceImage() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/controller/syncthing.go
  • Line 32: warning: cyclomatic complexity 17 of function (*Controller).NewSyncthing() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/controller/dev_start.go
  • Line 180: warning: cyclomatic complexity 16 of function (*Controller).genWorkDirAndPVAndMounts() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/app/upgrade.go
  • Line 215: warning: cyclomatic complexity 16 of function (*Application).upgradeForHelm() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/controller/deployment_controller.go
  • Line 42: warning: cyclomatic complexity 24 of function (*DeploymentController).ReplaceImage() is high (> 15) (gocyclo)
  • Line 263: warning: cyclomatic complexity 21 of function (*DeploymentController).RollBack() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/resouce_cache/search.go
  • Line 292: warning: cyclomatic complexity 22 of function (*criteria).Query() is high (> 15) (gocyclo)

• nocalhost/pkg/nocalhost-api/app/api/v1/service_account/service_account.go
  • Line 55: warning: cyclomatic complexity 17 of function ListAuthorization() is high (> 15) (gocyclo)

• nocalhost/internal/nocalhost-dep/webhook/annotation.go
  • Line 34: warning: cyclomatic complexity 16 of function (*ObjectMetaHolder).getOwnRefSignedAnnotation() is high (> 15) (gocyclo)

• nocalhost/pkg/nhctl/clientgoutils/replica_set.go
  • Line 76: warning: cyclomatic complexity 17 of function (*ClientGoUtils).WaitLatestRevisionReady() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/daemon_server/daemon.go
  • Line 58: warning: cyclomatic complexity 21 of function StartDaemon() is high (> 15) (gocyclo)
  • Line 175: warning: cyclomatic complexity 19 of function handleCommand() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/envsubst/parse/parse.go
  • Line 103: warning: cyclomatic complexity 16 of function (*Parser).Parse() is high (> 15) (gocyclo)

• nocalhost/cmd/nhctl/cmds/init_demo.go
  • Line 314: warning: cyclomatic complexity 16 of function FindOutWebEndpoint() is high (> 15) (gocyclo)

• nocalhost/internal/nocalhost-dep/webhook/webhook.go
  • Line 318: warning: cyclomatic complexity 30 of function (*WebhookServer).mutate() is high (> 15) (gocyclo)

• nocalhost/internal/nocalhost-dep/webhook/patcher.go
  • Line 104: warning: cyclomatic complexity 29 of function nocalhostDepConfigmap() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/daemon_server/portforward_manager.go
  • Line 155: warning: cyclomatic complexity 40 of function (*PortForwardManager).StartPortForwardGoRoutine() is high (> 15) (gocyclo)

• nocalhost/internal/nhctl/daemon_handler/get.go
  • Line 53: warning: cyclomatic complexity 25 of function HandleGetResourceInfoRequest() is high (> 15) (gocyclo)

golint27%

Golint is a linter for Go source code.

• nocalhost/pkg/nhctl/clientgoutils/type.go
  • Line 15: warning: exported type ResourceType should have comment or be unexported (golint)
  • Line 18: warning: exported const JobType should have comment (or a comment on this block) or be unexported (golint)

• nocalhost/internal/nhctl/model/model.go
  • Line 15: warning: exported type NocalHostResource should have comment or be unexported (golint)
  • Line 23: warning: exported type DevStartOptions should have comment or be unexported (golint)

• nocalhost/internal/nhctl/nocalhost/const.go
  • Line 16: warning: exported const NocalhostApplicationName should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported const DefaultNocalhostApplication should be of the form "DefaultNocalhostApplication ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/resource_validator.go
  • Line 75: warning: exported function AddMetas should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/pod.go
  • Line 22: warning: comment on exported method ClientGoUtils.ListPodsByDeployment should be of the form "ListPodsByDeployment ..." (golint)
  • Line 38: warning: exported method ClientGoUtils.ListPodsByStatefulSet should have comment or be unexported (golint)
  • Line 53: warning: exported method ClientGoUtils.ListPodsByLabels should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/setupcluster/reader.go
  • Line 25: warning: exported type DevKubeConfigReader should have comment or be unexported (golint)
  • Line 118: warning: exported function NewDevKubeConfigReader should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster/delete.go
  • Line 27: warning: comment on exported function Delete should be of the form "Delete ..." (golint)

• nocalhost/internal/nhctl/app/install.go
  • Line 32: warning: exported method Application.Install should have comment or be unexported (golint)
  • Line 64: warning: exported method Application.InstallKustomize should have comment or be unexported (golint)
  • Line 89: warning: exported method Application.InstallManifest should have comment or be unexported (golint)
  • Line 204: warning: exported method Application.InstallDepConfigMap should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/service_account/role_binding_watcher.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 85: warning: exported function NewRoleBindingWatcher should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/update.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 29: warning: exported type DevSpaceRequest should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function Update should be of the form "Update ..." (golint)
  • Line 69: warning: comment on exported function UpdateResourceLimit should be of the form "UpdateResourceLimit ..." (golint)

• nocalhost/internal/nhctl/controller/statefulset_controller.go
  • Line 32: warning: exported const OriginSpecJson should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported type StatefulSetController should have comment or be unexported (golint)
  • Line 39: warning: exported method StatefulSetController.Name should have comment or be unexported (golint)
  • Line 43: warning: exported method StatefulSetController.ReplaceImage should have comment or be unexported (golint)
  • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 226: warning: exported method StatefulSetController.ScaleReplicasToOne should have comment or be unexported (golint)
  • Line 251: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 290: warning: exported method StatefulSetController.RollBack should have comment or be unexported (golint)
  • Line 343: warning: exported method StatefulSetController.GetDefaultPodNameWait should have comment or be unexported (golint)
  • Line 347: warning: exported method StatefulSetController.GetPodList should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/exec.go
  • Line 20: warning: exported type ExecFlags should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/sign/verifer.go
  • Line 41: warning: comment on exported method Verifier.ParseQuery should be of the form "ParseQuery ..." (golint)
  • Line 56: warning: comment on exported method Verifier.ParseValues should be of the form "ParseValues ..." (golint)
  • Line 63: warning: comment on exported method Verifier.SetTimeout should be of the form "SetTimeout ..." (golint)
  • Line 69: warning: comment on exported method Verifier.MustString should be of the form "MustString ..." (golint)
  • Line 78: warning: comment on exported method Verifier.MustStrings should be of the form "MustStrings ..." (golint)
  • Line 83: warning: comment on exported method Verifier.MustInt64 should be of the form "MustInt64 ..." (golint)
  • Line 89: warning: comment on exported method Verifier.MustHasKeys should be of the form "MustHasKeys ..." (golint)
  • Line 99: warning: comment on exported method Verifier.MustHasOtherKeys should be of the form "MustHasOtherKeys ..." (golint)
  • Line 108: warning: comment on exported method Verifier.CheckTimeStamp should be of the form "CheckTimeStamp ..." (golint)
  • Line 118: warning: comment on exported method Verifier.GetAppID should be of the form "GetAppID ..." (golint)
  • Line 123: warning: comment on exported method Verifier.GetNonceStr should be of the form "GetNonceStr ..." (golint)
  • Line 128: warning: comment on exported method Verifier.GetSign should be of the form "GetSign ..." (golint)
  • Line 133: warning: comment on exported method Verifier.GetTimestamp should be of the form "GetTimestamp ..." (golint)
  • Line 138: warning: comment on exported method Verifier.GetBodyWithoutSign should be of the form "GetBodyWithoutSign ..." (golint)
  • Line 149: warning: comment on exported method Verifier.GetBody should be of the form "GetBody ..." (golint)

• nocalhost/internal/nhctl/app_flags/settings.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/internal/nhctl/appmeta_manager/application_secret_watcher.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 70: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 104: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 128: warning: exported function NewApplicationSecretWatcher should have comment or be unexported (golint)
  • Line 137: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 145: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 149: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 164: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 168: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)
  • Line 214: warning: receiver name asw should be consistent with previous receiver name aws for applicationSecretWatcher (golint)

• nocalhost/cmd/nocalhost-dep/nocalhost-dep.go
  • Line 30: warning: exported var GIT_COMMIT_SHA should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/Service.go
  • Line 33: warning: exported method Controller.IsInDevMode should have comment or be unexported (golint)
  • Line 37: warning: exported method Controller.IsProcessor should have comment or be unexported (golint)
  • Line 45: warning: exported method Controller.CheckIfExist should have comment or be unexported (golint)
  • Line 67: warning: exported method Controller.GetDescription should have comment or be unexported (golint)
  • Line 81: warning: exported method Controller.Associate should have comment or be unexported (golint)
  • Line 96: warning: exported method Controller.UpdateSvcProfile should have comment or be unexported (golint)
  • Line 109: warning: exported method Controller.UpdateProfile should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/dev_end.go
  • Line 21: warning: exported method Controller.DevEnd should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/errno/errno.go
  • Line 17: warning: comment on exported type Errno should be of the form "Errno ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported function DecodeErr should be of the form "DecodeErr ..." (golint)

• nocalhost/internal/nocalhost-api/model/cluster_user.go
  • Line 21: warning: comment on exported type ClusterUserModel should be of the form "ClusterUserModel ..." (with optional leading article) (golint)
  • Line 42: warning: exported type ClusterUserPluginModel should have comment or be unexported (golint)
  • Line 65: warning: exported type ClusterUserJoinCluster should have comment or be unexported (golint)
  • Line 75: warning: exported type ClusterUserJoinClusterAndAppAndUser should have comment or be unexported (golint)
  • Line 96: warning: comment on exported method ClusterUserModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/internal/nocalhost-api/service/application_user/application_user_service.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type ApplicationUserService should have comment or be unexported (golint)
  • Line 36: warning: exported function NewApplicationUserService should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/pre_pull/pre_pull_service.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type PrePullService should have comment or be unexported (golint)
  • Line 30: warning: exported function NewPrePullService should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/upgrade.go
  • Line 30: warning: exported method Application.PrepareForUpgrade should have comment or be unexported (golint)
  • Line 65: warning: exported method Application.Upgrade should have comment or be unexported (golint)

• nocalhost/internal/nhctl/resouce_cache/lru.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 7: warning: exported function NewLRU should have comment or be unexported (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nocalhost-api/repository/cluster/cluster_repo.go
  • Line 24: warning: exported type ClusterRepo should have comment or be unexported (golint)
  • Line 38: warning: exported function NewClusterRepo should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/deployment.go
  • Line 24: warning: exported method ClientGoUtils.ListDeployments should have comment or be unexported (golint)
  • Line 67: warning: exported function CheckIfDeploymentIsReplicaFailure should have comment or be unexported (golint)
  • Line 81: warning: exported method ClientGoUtils.GetDeployment should have comment or be unexported (golint)
  • Line 86: warning: exported method ClientGoUtils.CreateDeployment should have comment or be unexported (golint)
  • Line 91: warning: exported method ClientGoUtils.DeleteDeployment should have comment or be unexported (golint)

• nocalhost/internal/nhctl/dbutils/db.go
  • Line 26: warning: comment on exported function CreateLevelDB should be of the form "CreateLevelDB ..." (golint)
  • Line 38: warning: comment on exported function OpenLevelDB should be of the form "OpenLevelDB ..." (golint)

• nocalhost/internal/nhctl/syncthing/local/cert.go
  • Line 15: warning: comment on exported var Cert should be of the form "Cert ..." (golint)
  • Line 29: warning: exported var Key should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/filepath.go
  • Line 51: warning: comment on exported method Application.GetConfigPath should be of the form "GetConfigPath ..." (golint)
  • Line 56: warning: comment on exported method Application.GetConfigV2Path should be of the form "GetConfigV2Path ..." (golint)
  • Line 61: warning: exported method Application.GetHomeDir should have comment or be unexported (golint)
  • Line 69: warning: exported method Application.MarkAsGenerated should have comment or be unexported (golint)
  • Line 73: warning: exported method Application.HasBeenGenerateSecret should have comment or be unexported (golint)

• nocalhost/internal/nhctl/daemon_server/portforward.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/applications/application.go
  • Line 15: warning: exported type CreateAppRequest should have comment or be unexported (golint)
  • Line 21: warning: exported type AppPublicSwitchRequest should have comment or be unexported (golint)
  • Line 25: warning: exported type UpdateApplicationInstallRequest should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type ApplicationJsonContext should be of the form "ApplicationJsonContext ..." (with optional leading article) (golint)
  • Line 40: warning: exported type ApplicationListQuery should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/handler.go
  • Line 35: warning: comment on exported function SendResponse should be of the form "SendResponse ..." (golint)
  • Line 47: warning: comment on exported function GetUserID should be of the form "GetUserID ..." (golint)
  • Line 65: warning: comment on exported function RouteNotFound should be of the form "RouteNotFound ..." (golint)
  • Line 92: warning: comment on exported function Recover should be of the form "Recover ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/wait.go
  • Line 32: warning: exported method ClientGoUtils.WaitForResourceReady should have comment or be unexported (golint)
  • Line 106: warning: exported method ClientGoUtils.WaitDeploymentToBeReady should have comment or be unexported (golint)
  • Line 110: warning: exported method ClientGoUtils.WaitStatefulSetToBeReady should have comment or be unexported (golint)
  • Line 147: warning: exported method ClientGoUtils.WaitJobToBeReady should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/pre_pull_model.go
  • Line 21: warning: comment on exported type PrePullModel should be of the form "PrePullModel ..." (with optional leading article) (golint)
  • Line 34: warning: comment on exported method PrePullModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/application_cluster/create.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/pkg/nocalhost-api/app/router/middleware/auth.go
  • Line 22: warning: comment on exported function AuthMiddleware should be of the form "AuthMiddleware ..." (golint)

• nocalhost/internal/nhctl/syncthing/daemon/daemon.go
  • Line 24: warning: exported const MARK_ENV_NAME should have comment or be unexported (golint)
  • Line 29: warning: exported type Daemon should have comment or be unexported (golint)
  • Line 37: warning: comment on exported function Background should be of the form "Background ..." (golint)
  • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 82: warning: exported function NewDaemon should have comment or be unexported (golint)
  • Line 136: warning: exported function RunSubProcess should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/resource_manager.go
  • Line 35: warning: exported type ResourceReader should have comment or be unexported (golint)
  • Line 39: warning: exported type Resource should have comment or be unexported (golint)
  • Line 43: warning: exported function NewResourceFromStr should have comment or be unexported (golint)
  • Line 47: warning: exported method Resource.Append should have comment or be unexported (golint)
  • Line 59: warning: exported method Resource.GetResourceInfo should have comment or be unexported (golint)
  • Line 65: warning: exported function NewKustomizeResourceReader should have comment or be unexported (golint)
  • Line 88: warning: exported function NewManifestResourceReader should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/get.go
  • Line 19: warning: exported method Application.GetDependencies should have comment or be unexported (golint)
  • Line 45: warning: comment on exported method Application.GetResourceDir should be of the form "GetResourceDir ..." (golint)

• nocalhost/internal/nhctl/fp/filepath.go
  • Line 36: warning: exported type FilePathEnhance should have comment or be unexported (golint)
  • Line 49: warning: exported function NewFilePath should have comment or be unexported (golint)
  • Line 58: warning: exported method FilePathEnhance.Abs should have comment or be unexported (golint)
  • Line 62: warning: exported method FilePathEnhance.RelOrAbs should have comment or be unexported (golint)
  • Line 91: warning: exported method FilePathEnhance.WriteFile should have comment or be unexported (golint)
  • Line 102: warning: exported method FilePathEnhance.ReadFile should have comment or be unexported (golint)
  • Line 123: warning: exported method FilePathEnhance.ReadFileCompel should have comment or be unexported (golint)
  • Line 136: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 144: warning: exported method FilePathEnhance.CheckExist should have comment or be unexported (golint)
  • Line 158: warning: exported method FilePathEnhance.Mkdir should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/router/middleware/requestid.go
  • Line 21: warning: comment on exported function RequestID should be of the form "RequestID ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/stateful_set.go
  • Line 22: warning: exported method ClientGoUtils.UpdateStatefulSet should have comment or be unexported (golint)
  • Line 44: warning: exported method ClientGoUtils.DeleteStatefulSet should have comment or be unexported (golint)
  • Line 48: warning: exported method ClientGoUtils.CreateStatefulSet should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/yaml.go
  • Line 21: warning: exported var YamlCmd should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/redis/redis.go
  • Line 25: warning: comment on exported var RedisClient should be of the form "RedisClient ..." (golint)
  • Line 28: warning: comment on exported const Nil should be of the form "Nil ..." (golint)
  • Line 31: warning: exported function Init should have comment or be unexported (golint)
  • Line 53: warning: comment on exported function InitTestRedis should be of the form "InitTestRedis ..." (golint)

• nocalhost/internal/nhctl/daemon_handler/get.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 53: warning: exported function HandleGetResourceInfoRequest should have comment or be unexported (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 203: warning: exported type Result should have comment or be unexported (golint)
  • Line 208: warning: exported type App should have comment or be unexported (golint)
  • Line 213: warning: exported type Group should have comment or be unexported (golint)
  • Line 218: warning: exported type Resource should have comment or be unexported (golint)
  • Line 223: warning: exported type Item should have comment or be unexported (golint)

• nocalhost/internal/nhctl/profile/config_v1.go
  • Line 22: warning: comment on exported type NocalHostAppConfig should be of the form "NocalHostAppConfig ..." (with optional leading article) (golint)
  • Line 32: warning: exported type PersistentVolumeDir should have comment or be unexported (golint)
  • Line 37: warning: exported type ResourceQuota should have comment or be unexported (golint)
  • Line 42: warning: exported type QuotaList should have comment or be unexported (golint)
  • Line 47: warning: exported type ServiceDevOptions should have comment or be unexported (golint)
  • Line 70: warning: exported type PreInstallItem should have comment or be unexported (golint)
  • Line 75: warning: exported type NocalhostResource should have comment or be unexported (golint)
  • Line 79: warning: exported type SortedRelPath should have comment or be unexported (golint)
  • Line 81: warning: exported method SortedRelPath.Load should have comment or be unexported (golint)
  • Line 96: warning: exported type RelPath should have comment or be unexported (golint)
  • Line 98: warning: exported method RelPath.Load should have comment or be unexported (golint)
  • Line 112: warning: receiver name a should be consistent with previous receiver name c for SortedRelPath (golint)
  • Line 113: warning: receiver name a should be consistent with previous receiver name c for SortedRelPath (golint)
  • Line 114: warning: receiver name a should be consistent with previous receiver name c for SortedRelPath (golint)

• nocalhost/internal/nocalhost-api/repository/pre_pull/pre_pull_repo.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported type PrePullRepo should have comment or be unexported (golint)
  • Line 31: warning: exported function NewPrePullRepoRepo should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/redis/idalloc.go
  • Line 25: warning: comment on exported type IdAlloc should be of the form "IdAlloc ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 40: warning: comment on exported method IdAlloc.GetNewID should be of the form "GetNewID ..." (golint)
  • Line 50: warning: comment on exported method IdAlloc.GetCurrentID should be of the form "GetCurrentID ..." (golint)
  • Line 64: warning: comment on exported method IdAlloc.GetKey should be of the form "GetKey ..." (golint)

• nocalhost/pkg/nocalhost-api/pkg/version/version.go
  • Line 36: warning: comment on exported function Get should be of the form "Get ..." (golint)

• nocalhost/internal/nhctl/utils/util.go
  • Line 33: warning: exported function Should should have comment or be unexported (golint)
  • Line 37: warning: comment on exported function ShouldI should be of the form "ShouldI ..." (golint)
  • Line 44: warning: exported function GetHomePath should have comment or be unexported (golint)
  • Line 58: warning: exported function IsSudoUser should have comment or be unexported (golint)
  • Line 65: warning: exported function Sha1ToString should have comment or be unexported (golint)
  • Line 71: warning: exported function GetNhctlBinName should have comment or be unexported (golint)
  • Line 78: warning: exported function GetNhctlPath should have comment or be unexported (golint)
  • Line 88: warning: exported function CopyFile should have comment or be unexported (golint)
  • Line 186: warning: exported function CheckKubectlVersion should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/tools/helper.go
  • Line 34: warning: comment on exported function CheckOS should be of the form "CheckOS ..." (golint)
  • Line 49: warning: comment on exported function CheckK8s should be of the form "CheckK8s ..." (golint)
  • Line 81: warning: comment on exported function ExecCommand should be of the form "ExecCommand ..." (golint)
  • Line 161: warning: comment on exported function CheckFile should be of the form "CheckFile ..." (golint)
  • Line 170: warning: comment on exported function CheckCmdExists should be of the form "CheckCmdExists ..." (golint)
  • Line 176: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 182: warning: comment on exported function CheckThirdPartyCLI should be of the form "CheckThirdPartyCLI ..." (golint)
  • Line 209: warning: exported function GenerateRangeNum should have comment or be unexported (golint)
  • Line 215: warning: exported function RemoveDuplicateElement should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/daemon/attr_default.go
  • Line 19: warning: exported function NewSysProcAttr should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/testcase/reset.go
  • Line 22: warning: exported function Reset should have comment or be unexported (golint)
  • Line 27: warning: exported function Upgrade should have comment or be unexported (golint)
  • Line 37: warning: exported function Config should have comment or be unexported (golint)
  • Line 42: warning: exported function SyncStatus should have comment or be unexported (golint)
  • Line 47: warning: exported function List should have comment or be unexported (golint)
  • Line 52: warning: exported function Db should have comment or be unexported (golint)
  • Line 57: warning: exported function Pvc should have comment or be unexported (golint)
  • Line 62: warning: exported function NhctlVersion should have comment or be unexported (golint)
  • Line 68: warning: exported function Apply should have comment or be unexported (golint)

• nocalhost/cmd/nocalhost-api/nocalhost-api.go
  • Line 33: warning: exported var GIT_COMMIT_SHA should have comment or be unexported (golint)
  • Line 39: warning: exported var Svc should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/constvar/constvar.go
  • Line 16: warning: comment on exported const DefaultLimit should be of the form "DefaultLimit ..." (golint)
  • Line 19: warning: comment on exported const DefaultAvatar should be of the form "DefaultAvatar ..." (golint)

• nocalhost/internal/nhctl/nocalhost/leveldb_application.go
  • Line 17: warning: exported function UpdateKey should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/rest_client.go
  • Line 26: warning: exported const ResourcePods should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported method ClientGoUtils.GetRestClient should have comment or be unexported (golint)
  • Line 41: warning: comment on exported method ClientGoUtils.GetResourcesByRestClient should be of the form "GetResourcesByRestClient ..." (golint)

• nocalhost/cmd/nhctl/cmds/get.go
  • Line 36: warning: exported const JSON should have comment or be unexported (golint)
  • Line 37: warning: exported const YAML should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/syncthing.go
  • Line 44: warning: exported const SyncSecretName should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: comment on exported const DefaultAPIKey should be of the form "DefaultAPIKey ..." (golint)
  • Line 68: warning: comment on exported const DefaultFolderName should be of the form "DefaultFolderName ..." (golint)
  • Line 92: warning: exported type Syncthing should have comment or be unexported (golint)
  • Line 304: warning: exported method Syncthing.GetRemoteConfigXML should have comment or be unexported (golint)
  • Line 313: warning: exported method Syncthing.GetLocalConfigXML should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/cluster_user.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type ClusterUserCreateRequest should have comment or be unexported (golint)
  • Line 28: warning: exported type ClusterUserListQuery should have comment or be unexported (golint)
  • Line 32: warning: exported type SpaceResourceLimit should have comment or be unexported (golint)
  • Line 48: warning: exported method SpaceResourceLimit.Validate should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/create.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 71: warning: exported function ValidSpaceResourceLimit should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/cache/encoding.go
  • Line 31: warning: comment on exported type Encoding should be of the form "Encoding ..." (with optional leading article) (golint)
  • Line 73: warning: comment on exported type JSONEncoding should be of the form "JSONEncoding ..." (with optional leading article) (golint)
  • Line 144: warning: comment on exported function GzipEncode should be of the form "GzipEncode ..." (golint)
  • Line 172: warning: comment on exported function GzipDecode should be of the form "GzipDecode ..." (golint)
  • Line 189: warning: comment on exported type JSONSnappyEncoding should be of the form "JSONSnappyEncoding ..." (with optional leading article) (golint)
  • Line 202: warning: comment on exported method JSONSnappyEncoding.Unmarshal should be of the form "Unmarshal ..." (golint)

• nocalhost/test/nhctlcli/suite/suite.go
  • Line 28: warning: comment on exported type T should be of the form "T ..." (with optional leading article) (golint)
  • Line 74: warning: exported method T.Clean should have comment or be unexported (golint)
  • Line 80: warning: exported method T.Alert should have comment or be unexported (golint)

• nocalhost/internal/nhctl/dbutils/dbutils.go
  • Line 22: warning: exported type LevelDBUtils should have comment or be unexported (golint)
  • Line 27: warning: comment on exported method LevelDBUtils.Close should be of the form "Close ..." (golint)
  • Line 35: warning: exported method LevelDBUtils.Get should have comment or be unexported (golint)
  • Line 39: warning: exported method LevelDBUtils.Put should have comment or be unexported (golint)
  • Line 43: warning: exported method LevelDBUtils.ListAll should have comment or be unexported (golint)
  • Line 56: warning: exported method LevelDBUtils.ListAllKeys should have comment or be unexported (golint)
  • Line 68: warning: exported method LevelDBUtils.CompactFirstKey should have comment or be unexported (golint)
  • Line 80: warning: exported method LevelDBUtils.CompactKey should have comment or be unexported (golint)
  • Line 84: warning: comment on exported method LevelDBUtils.GetSize should be of the form "GetSize ..." (golint)

• nocalhost/pkg/nocalhost-api/pkg/setupcluster/setup.go
  • Line 29: warning: exported type SetUpCluster should have comment or be unexported (golint)
  • Line 245: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/pkg/nhctl/clientgoutils/clientgo_utils.go
  • Line 53: warning: exported type ClientGoUtils should have comment or be unexported (golint)
  • Line 63: warning: exported type PortForwardAPodRequest should have comment or be unexported (golint)
  • Line 126: warning: exported method ClientGoUtils.KubeConfigFilePath should have comment or be unexported (golint)
  • Line 130: warning: comment on exported method ClientGoUtils.NameSpace should be of the form "NameSpace ..." (golint)
  • Line 136: warning: comment on exported method ClientGoUtils.Context should be of the form "Context ..." (golint)
  • Line 142: warning: exported method ClientGoUtils.GetDynamicClient should have comment or be unexported (golint)
  • Line 154: warning: exported function GetNamespaceFromKubeConfig should have comment or be unexported (golint)
  • Line 164: warning: exported method ClientGoUtils.GetDefaultNamespace should have comment or be unexported (golint)
  • Line 169: warning: exported method ClientGoUtils.GetDiscoveryClient should have comment or be unexported (golint)
  • Line 177: warning: exported method ClientGoUtils.Discovery should have comment or be unexported (golint)
  • Line 206: warning: exported method ClientGoUtils.GetDeploymentClient should have comment or be unexported (golint)
  • Line 210: warning: exported method ClientGoUtils.GetStatefulSetClient should have comment or be unexported (golint)
  • Line 214: warning: exported method ClientGoUtils.GetDaemonSetClient should have comment or be unexported (golint)
  • Line 218: warning: exported method ClientGoUtils.GetJobsClient should have comment or be unexported (golint)
  • Line 222: warning: exported method ClientGoUtils.GetCronJobsClient should have comment or be unexported (golint)
  • Line 226: warning: exported method ClientGoUtils.GetPodClient should have comment or be unexported (golint)
  • Line 230: warning: exported method ClientGoUtils.GetPod should have comment or be unexported (golint)
  • Line 235: warning: exported method ClientGoUtils.GetDaemonSet should have comment or be unexported (golint)
  • Line 240: warning: exported method ClientGoUtils.GetStatefulSet should have comment or be unexported (golint)
  • Line 245: warning: exported method ClientGoUtils.GetJobs should have comment or be unexported (golint)
  • Line 250: warning: exported method ClientGoUtils.ListJobs should have comment or be unexported (golint)
  • Line 255: warning: exported method ClientGoUtils.GetCronJobs should have comment or be unexported (golint)
  • Line 260: warning: exported method ClientGoUtils.CheckDeploymentReady should have comment or be unexported (golint)
  • Line 273: warning: comment on exported method ClientGoUtils.ListPodsOfDeployment should be of the form "ListPodsOfDeployment ..." (golint)
  • Line 302: warning: exported method ClientGoUtils.ListLatestRevisionPodsByDeployment should have comment or be unexported (golint)
  • Line 379: warning: exported method ClientGoUtils.CreateSecret should have comment or be unexported (golint)
  • Line 383: warning: exported method ClientGoUtils.UpdateSecret should have comment or be unexported (golint)
  • Line 387: warning: exported method ClientGoUtils.GetSecret should have comment or be unexported (golint)
  • Line 391: warning: exported method ClientGoUtils.DeleteSecret should have comment or be unexported (golint)
  • Line 395: warning: exported method ClientGoUtils.PortForwardAPod should have comment or be unexported (golint)
  • Line 427: warning: exported method ClientGoUtils.GetNodesList should have comment or be unexported (golint)
  • Line 435: warning: exported method ClientGoUtils.GetService should have comment or be unexported (golint)
  • Line 443: warning: exported method ClientGoUtils.CheckExistNameSpace should have comment or be unexported (golint)
  • Line 451: warning: exported method ClientGoUtils.CreateNameSpace should have comment or be unexported (golint)
  • Line 460: warning: exported method ClientGoUtils.DeleteNameSpace should have comment or be unexported (golint)
  • Line 483: warning: exported method ClientGoUtils.DeleteStatefulSetAndPVC should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/utils.go
  • Line 25: warning: exported function Must should have comment or be unexported (golint)
  • Line 31: warning: exported function MustI should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/root.go
  • Line 76: warning: exported function Execute should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/utils/url.go
  • Line 24: warning: comment on exported function GetDefaultAvatarURL should be of the form "GetDefaultAvatarURL ..." (golint)
  • Line 40: warning: comment on exported function GetQiNiuPublicAccessURL should be of the form "GetQiNiuPublicAccessURL ..." (golint)

• nocalhost/internal/nhctl/daemon_client/client.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 34: warning: exported type DaemonClient should have comment or be unexported (golint)
  • Line 39: warning: exported function StartDaemonServer should have comment or be unexported (golint)
  • Line 75: warning: exported function CheckIfDaemonServerRunning should have comment or be unexported (golint)
  • Line 85: warning: exported function NewDaemonClient should have comment or be unexported (golint)
  • Line 148: warning: exported method DaemonClient.SendGetDaemonServerInfoCommand should have comment or be unexported (golint)
  • Line 162: warning: exported method DaemonClient.SendRestartDaemonServerCommand should have comment or be unexported (golint)
  • Line 171: warning: exported method DaemonClient.SendStopDaemonServerCommand should have comment or be unexported (golint)
  • Line 180: warning: exported method DaemonClient.SendGetDaemonServerStatusCommand should have comment or be unexported (golint)
  • Line 194: warning: exported method DaemonClient.SendGetApplicationMetaCommand should have comment or be unexported (golint)
  • Line 213: warning: exported method DaemonClient.SendGetApplicationMetasCommand should have comment or be unexported (golint)
  • Line 231: warning: exported method DaemonClient.SendStartPortForwardCommand should have comment or be unexported (golint)
  • Line 281: warning: comment on exported method DaemonClient.SendGetResourceInfoCommand should be of the form "SendGetResourceInfoCommand ..." (golint)

• nocalhost/internal/nhctl/port-forward/port_status_default.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 24: warning: exported function PidPortStatus should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/deployment_controller.go
  • Line 32: warning: exported type DeploymentController should have comment or be unexported (golint)
  • Line 36: warning: exported method DeploymentController.Name should have comment or be unexported (golint)
  • Line 202: warning: exported method DeploymentController.ScaleReplicasToOne should have comment or be unexported (golint)
  • Line 216: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 234: warning: exported method DeploymentController.Container should have comment or be unexported (golint)
  • Line 263: warning: exported method DeploymentController.RollBack should have comment or be unexported (golint)
  • Line 354: warning: exported method DeploymentController.GetDefaultPodNameWait should have comment or be unexported (golint)
  • Line 379: warning: exported method DeploymentController.GetPodList should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/getter.go
  • Line 20: warning: exported method Application.GetType should have comment or be unexported (golint)
  • Line 24: warning: exported method Application.IsHelm should have comment or be unexported (golint)
  • Line 29: warning: exported method Application.IsManifest should have comment or be unexported (golint)
  • Line 34: warning: exported method Application.IsKustomize should have comment or be unexported (golint)
  • Line 39: warning: exported method Application.GetClient should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/application_cluster/get.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/create.go
  • Line 24: warning: comment on exported function Create should be of the form "Create ..." (golint)

• nocalhost/internal/nhctl/resouce_cache/list_test.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/internal/nhctl/utils/spinner.go
  • Line 30: warning: exported type Spinner should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-dep/webhook/annotation.go
  • Line 26: warning: exported type ObjectMetaHolder should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/init.go
  • Line 21: warning: exported var InitCmd should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/setupcluster/clusterdevs.go
  • Line 21: warning: exported type ClusterDevsSetUp should have comment or be unexported (golint)
  • Line 159: warning: exported function NewClusterDevsSetUp should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/applications/get.go
  • Line 30: warning: comment on exported function Get should be of the form "Get ..." (golint)
  • Line 76: warning: comment on exported function ListPermitted should be of the form "ListPermitted ..." (golint)
  • Line 89: warning: comment on exported function GetDetail should be of the form "GetDetail ..." (golint)
  • Line 115: warning: comment on exported function GetSpaceDetail should be of the form "GetSpaceDetail ..." (golint)
  • Line 142: warning: comment on exported function PluginGet should be of the form "PluginGet ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/pvc.go
  • Line 26: warning: comment on exported method ClientGoUtils.CreatePVC should be of the form "CreatePVC ..." (golint)
  • Line 57: warning: exported method ClientGoUtils.DeletePVC should have comment or be unexported (golint)
  • Line 62: warning: exported method ClientGoUtils.ListPvcs should have comment or be unexported (golint)
  • Line 70: warning: exported method ClientGoUtils.GetPvcByLabels should have comment or be unexported (golint)
  • Line 88: warning: exported method ClientGoUtils.GetPvcByName should have comment or be unexported (golint)

• nocalhost/internal/nhctl/daemon_common/daemon.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported const DefaultDaemonPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported var Version should have comment or be unexported (golint)
  • Line 29: warning: exported type DaemonServerInfo should have comment or be unexported (golint)
  • Line 35: warning: exported type PortForwardProfile should have comment or be unexported (golint)
  • Line 47: warning: exported function NewDaemonServerInfo should have comment or be unexported (golint)
  • Line 51: warning: exported type DaemonServerStatusResponse should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/dev_space.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 28: warning: exported type DevSpace should have comment or be unexported (golint)
  • Line 34: warning: exported function NewDevSpace should have comment or be unexported (golint)
  • Line 42: warning: exported method DevSpace.Delete should have comment or be unexported (golint)
  • Line 65: warning: exported method DevSpace.Create should have comment or be unexported (golint)
  • Line 87: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nhctl/controller/syncthing.go
  • Line 32: warning: exported method Controller.NewSyncthing should have comment or be unexported (golint)
  • Line 152: warning: exported method Controller.NewSyncthingHttpClient should have comment or be unexported (golint)
  • Line 163: warning: exported method Controller.CreateSyncThingSecret should have comment or be unexported (golint)

• nocalhost/internal/nhctl/envsubst/parse/node.go
  • Line 20: warning: exported type Node should have comment or be unexported (golint)
  • Line 35: warning: exported const NodeText should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type TextNode should have comment or be unexported (golint)
  • Line 45: warning: exported function NewText should have comment or be unexported (golint)
  • Line 53: warning: exported type VariableNode should have comment or be unexported (golint)
  • Line 60: warning: exported function NewVariable should have comment or be unexported (golint)
  • Line 116: warning: exported type SubstitutionNode should have comment or be unexported (golint)
  • Line 145: warning: exported method SubstitutionNode.StringWithDefault should have comment or be unexported (golint)

• nocalhost/internal/nhctl/appmeta/application_dev_meta.go
  • Line 23: warning: exported type SvcType should have comment or be unexported (golint)
  • Line 26: warning: exported const Deployment should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported function SvcTypeOf should have comment or be unexported (golint)
  • Line 53: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 67: warning: exported method SvcType.Origin should have comment or be unexported (golint)
  • Line 78: warning: exported type ApplicationDevMeta should have comment or be unexported (golint)
  • Line 80: warning: comment on exported type EVENT should be of the form "EVENT ..." (with optional leading article) (golint)
  • Line 82: warning: exported type ApplicationEvent should have comment or be unexported (golint)
  • Line 101: warning: exported method ApplicationDevMeta.Events should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/get.go
  • Line 55: warning: comment on exported function GetMe should be of the form "GetMe ..." (golint)
  • Line 82: warning: comment on exported function GetList should be of the form "GetList ..." (golint)

• nocalhost/internal/nocalhost-api/model/cluster_model.go
  • Line 21: warning: comment on exported type ClusterModel should be of the form "ClusterModel ..." (with optional leading article) (golint)
  • Line 35: warning: exported type ClusterList should have comment or be unexported (golint)
  • Line 56: warning: comment on exported method ClusterModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/internal/nhctl/daemon_server/syncthing.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/pkg/nhctl/clientgoutils/configmap.go
  • Line 21: warning: exported method ClientGoUtils.DeleteConfigMapByName should have comment or be unexported (golint)
  • Line 25: warning: exported method ClientGoUtils.GetConfigMaps should have comment or be unexported (golint)

• nocalhost/internal/nhctl/profile/config_v2.go
  • Line 18: warning: exported type NocalHostAppConfigV2 should have comment or be unexported (golint)
  • Line 23: warning: exported type ConfigProperties should have comment or be unexported (golint)
  • Line 28: warning: exported type ApplicationConfig should have comment or be unexported (golint)
  • Line 40: warning: exported type ServiceConfigV2 should have comment or be unexported (golint)
  • Line 48: warning: exported type ContainerConfig should have comment or be unexported (golint)
  • Line 54: warning: exported type ContainerInstallConfig should have comment or be unexported (golint)
  • Line 60: warning: exported type ContainerDevConfig should have comment or be unexported (golint)
  • Line 77: warning: exported type DevCommands should have comment or be unexported (golint)
  • Line 85: warning: exported type SyncConfig should have comment or be unexported (golint)
  • Line 91: warning: exported type DebugConfig should have comment or be unexported (golint)
  • Line 95: warning: exported type DependLabelSelector should have comment or be unexported (golint)
  • Line 100: warning: exported type HelmValue should have comment or be unexported (golint)
  • Line 105: warning: exported type Env should have comment or be unexported (golint)
  • Line 110: warning: exported type EnvFrom should have comment or be unexported (golint)
  • Line 114: warning: exported type EnvFile should have comment or be unexported (golint)
  • Line 118: warning: exported method NocalHostAppConfigV2.GetSvcConfigV2 should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/user/user_service.go
  • Line 31: warning: comment on exported const MaxID should be of the form "MaxID ..." (golint)
  • Line 37: warning: comment on exported type UserService should be of the form "UserService ..." (with optional leading article) (golint)
  • Line 58: warning: exported function NewUserService should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/pod_controller.go
  • Line 20: warning: exported method Controller.BuildPodController should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster/get.go
  • Line 28: warning: exported type ClusterStatus should have comment or be unexported (golint)
  • Line 34: warning: exported type ClusterSafeList should have comment or be unexported (golint)
  • Line 53: warning: comment on exported function ListByUser should be of the form "ListByUser ..." (golint)
  • Line 88: warning: comment on exported function GetSpaceList should be of the form "GetSpaceList ..." (golint)
  • Line 111: warning: comment on exported function GetDetail should be of the form "GetDetail ..." (golint)
  • Line 182: warning: comment on exported function GetSpaceDetail should be of the form "GetSpaceDetail ..." (golint)
  • Line 208: warning: comment on exported function GetStorageClass should be of the form "GetStorageClass ..." (golint)
  • Line 277: warning: comment on exported function GetStorageClassByKubeConfig should be of the form "GetStorageClassByKubeConfig ..." (golint)

• nocalhost/internal/nhctl/app/config_converter.go
  • Line 22: warning: exported function ConvertAppProfileFileV1ToV2 should have comment or be unexported (golint)
  • Line 48: warning: exported function ConvertConfigFileV1ToV2 should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/application_cluster/application_cluster_service.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported type ApplicationClusterService should have comment or be unexported (golint)
  • Line 35: warning: exported function NewApplicationClusterService should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/cluster_user/cluster_user_service.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported type ClusterUserService should have comment or be unexported (golint)
  • Line 53: warning: exported function NewClusterUserService should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/applications/update.go
  • Line 27: warning: exported function PublicSwitch should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function Update should be of the form "Update ..." (golint)
  • Line 101: warning: comment on exported function UpdateApplicationInstall should be of the form "UpdateApplicationInstall ..." (golint)

• nocalhost/test/util/retry.go
  • Line 46: warning: exported function Retry should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/testcase/init.go
  • Line 40: warning: exported var StatusChan should have comment or be unexported (golint)
  • Line 42: warning: exported function GetVersion should have comment or be unexported (golint)
  • Line 63: warning: exported function InstallNhctl should have comment or be unexported (golint)
  • Line 99: warning: exported function Init should have comment or be unexported (golint)
  • Line 147: warning: exported function StatusCheck should have comment or be unexported (golint)
  • Line 181: warning: exported function GetKubeconfig should have comment or be unexported (golint)
  • Line 223: warning: exported type Response should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/testcase/install.go
  • Line 21: warning: exported function InstallBookInfo should have comment or be unexported (golint)
  • Line 25: warning: exported function InstallBookInfoThreeTimes should have comment or be unexported (golint)
  • Line 48: warning: exported function UninstallBookInfo should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/manifetst.go
  • Line 20: warning: exported function StandardNocalhostMetas should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/replica_set.go
  • Line 26: warning: exported method ClientGoUtils.UpdateReplicaSet should have comment or be unexported (golint)
  • Line 31: warning: exported method ClientGoUtils.GetSortedReplicaSetsByDeployment should have comment or be unexported (golint)
  • Line 51: warning: exported method ClientGoUtils.GetReplicaSetsByDeployment should have comment or be unexported (golint)
  • Line 75: warning: comment on exported method ClientGoUtils.WaitLatestRevisionReady should be of the form "WaitLatestRevisionReady ..." (golint)

• nocalhost/internal/nhctl/appmeta/application_meta.go
  • Line 35: warning: exported const SecretType should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported var ErrAlreadyDev should have comment or be unexported (golint)
  • Line 63: warning: comment on exported function GetApplicationName should be of the form "GetApplicationName ..." (golint)
  • Line 81: warning: exported type AppType should have comment or be unexported (golint)
  • Line 83: warning: exported function AppTypeOf should have comment or be unexported (golint)
  • Line 102: warning: exported type ApplicationState should have comment or be unexported (golint)
  • Line 104: warning: exported function ApplicationStateOf should have comment or be unexported (golint)
  • Line 114: warning: exported type ApplicationMetas should have comment or be unexported (golint)
  • Line 115: warning: exported type ApplicationMetaSimples should have comment or be unexported (golint)
  • Line 117: warning: comment on exported method ApplicationMetas.Desc should be of the form "Desc ..." (golint)
  • Line 134: warning: exported type ApplicationMetaSimple should have comment or be unexported (golint)
  • Line 144: warning: comment on exported type ApplicationMeta should be of the form "ApplicationMeta ..." (with optional leading article) (golint)
  • Line 176: warning: exported function Decode should have comment or be unexported (golint)
  • Line 230: warning: exported method ApplicationMeta.GetClient should have comment or be unexported (golint)
  • Line 234: warning: exported method ApplicationMeta.GetApplicationDevMeta should have comment or be unexported (golint)
  • Line 237: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 272: warning: exported method ApplicationMeta.InitGoClient should have comment or be unexported (golint)
  • Line 278: warning: exported method ApplicationMeta.SvcDevModePossessor should have comment or be unexported (golint)
  • Line 292: warning: exported method ApplicationMeta.SvcDevStart should have comment or be unexported (golint)
  • Line 312: warning: exported method ApplicationMeta.SvcDevEnd should have comment or be unexported (golint)
  • Line 328: warning: exported method ApplicationMeta.CheckIfSvcDeveloping should have comment or be unexported (golint)
  • Line 344: warning: exported method ApplicationMeta.Update should have comment or be unexported (golint)
  • Line 373: warning: exported method ApplicationMeta.IsInstalled should have comment or be unexported (golint)
  • Line 377: warning: exported method ApplicationMeta.IsInstalling should have comment or be unexported (golint)
  • Line 381: warning: exported method ApplicationMeta.IsNotInstall should have comment or be unexported (golint)
  • Line 385: warning: exported method ApplicationMeta.NotInstallTips should have comment or be unexported (golint)
  • Line 393: warning: exported method ApplicationMeta.IsHelm should have comment or be unexported (golint)
  • Line 504: warning: exported method ApplicationMeta.NewResourceReader should have comment or be unexported (golint)

• nocalhost/internal/nhctl/pod_controller/pod_controller.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type PodController should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/terminate/terminate_default.go
  • Line 26: warning: exported function Terminate should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/utils/utils.go
  • Line 25: warning: exported function Mush should have comment or be unexported (golint)
  • Line 32: warning: exported type ProgressBar should have comment or be unexported (golint)
  • Line 36: warning: exported method ProgressBar.TrackProgress should have comment or be unexported (golint)
  • Line 65: warning: exported function RenderProgressBar should have comment or be unexported (golint)

• nocalhost/internal/nhctl/nocalhost/leveldb_profile.go
  • Line 27: warning: error var ProfileNotFound should have name of the form ErrFoo (golint)
  • Line 27: warning: exported var ProfileNotFound should have comment or be unexported (golint)
  • Line 29: warning: exported function UpdateProfileV2 should have comment or be unexported (golint)
  • Line 47: warning: exported function GetKubeConfigFromProfile should have comment or be unexported (golint)
  • Line 55: warning: exported function GetProfileV2 should have comment or be unexported (golint)
  • Line 88: warning: exported function UnmarshalProfileUnStrict should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/application.go
  • Line 38: warning: exported var ErrNotFound should have comment or be unexported (golint)
  • Line 42: warning: exported type Application should have comment or be unexported (golint)
  • Line 56: warning: exported type SvcDependency should have comment or be unexported (golint)
  • Line 63: warning: exported method Application.GetAppMeta should have comment or be unexported (golint)
  • Line 84: warning: comment on exported function NewApplication should be of the form "NewApplication ..." (golint)
  • Line 223: warning: exported method Application.ReloadCfg should have comment or be unexported (golint)
  • Line 234: warning: exported method Application.ReloadSvcCfg should have comment or be unexported (golint)
  • Line 257: warning: exported method Application.LoadSvcCfgFromLocalIfValid should have comment or be unexported (golint)
  • Line 385: warning: exported method Application.GetProfile should have comment or be unexported (golint)
  • Line 389: warning: exported method Application.GetProfileCompel should have comment or be unexported (golint)
  • Line 395: warning: exported method Application.UpdateProfile should have comment or be unexported (golint)
  • Line 413: warning: exported method Application.LoadConfigFromLocalV2 should have comment or be unexported (golint)
  • Line 444: warning: exported type HelmFlags should have comment or be unexported (golint)
  • Line 455: warning: exported method Application.GetApplicationConfigV2 should have comment or be unexported (golint)
  • Line 459: warning: exported method Application.GetAppProfileV2 should have comment or be unexported (golint)
  • Line 470: warning: exported method Application.SaveAppProfileV2 should have comment or be unexported (golint)
  • Line 483: warning: exported type PortForwardOptions should have comment or be unexported (golint)
  • Line 494: warning: exported type PortForwardEndOptions should have comment or be unexported (golint)
  • Line 498: warning: exported method Application.Controller should have comment or be unexported (golint)
  • Line 509: warning: exported method Application.GetConfigFile should have comment or be unexported (golint)
  • Line 517: warning: exported method Application.GetDescription should have comment or be unexported (golint)
  • Line 553: warning: exported method Application.ListContainersByDeployment should have comment or be unexported (golint)
  • Line 564: warning: exported method Application.SendPortForwardTCPHeartBeat should have comment or be unexported (golint)
  • Line 574: warning: exported method Application.PortForwardAPod should have comment or be unexported (golint)
  • Line 578: warning: comment on exported method Application.SetPidFileEmpty should be of the form "SetPidFileEmpty ..." (golint)
  • Line 583: warning: exported method Application.CleanUpTmpResources should have comment or be unexported (golint)
  • Line 591: warning: exported method Application.CleanupResources should have comment or be unexported (golint)
  • Line 600: warning: exported method Application.Uninstall should have comment or be unexported (golint)
  • Line 604: warning: exported method Application.IsAnyServiceInDevMode should have comment or be unexported (golint)
  • Line 613: warning: exported method Application.PortForwardFollow should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/secret-config/secret.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 16: warning: exported const DefaultSyncthingHome should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: comment on exported const CertPEM should be of the form "CertPEM ..." (golint)
  • Line 37: warning: exported const KeyPEM should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-dep/go-client/client.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported function InitClientSet should have comment or be unexported (golint)
  • Line 36: warning: exported function InitCachedRestMapper should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/delete.go
  • Line 26: warning: comment on exported function Delete should be of the form "Delete ..." (golint)

• nocalhost/pkg/nocalhost-api/app/router/ginbase/gin_operator.go
  • Line 21: warning: exported const NotExist should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported function IsAdmin should have comment or be unexported (golint)
  • Line 29: warning: exported function LoginUser should have comment or be unexported (golint)
  • Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 38: warning: exported function IsCurrentUser should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/utils/env.go
  • Line 25: warning: comment on exported function GetKVFromEnvFiles should be of the form "GetKVFromEnvFiles ..." (golint)

• nocalhost/internal/nhctl/nocalhost/db/db.go
  • Line 20: warning: exported function OpenApplicationLevelDB should have comment or be unexported (golint)
  • Line 25: warning: exported function CreateApplicationLevelDB should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/network/req/folderStatus.go
  • Line 21: warning: exported method SyncthingHttpClient.FolderStatus should have comment or be unexported (golint)
  • Line 35: warning: exported method Model.StateChangedLog should have comment or be unexported (golint)
  • Line 41: warning: exported method Model.OutOfSyncLog should have comment or be unexported (golint)
  • Line 47: warning: exported method Model.IdleTips should have comment or be unexported (golint)
  • Line 65: warning: exported method Model.OutOfSyncTips should have comment or be unexported (golint)
  • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 78: warning: exported method Model.OutOfSync should have comment or be unexported (golint)
  • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 91: warning: exported type Model should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/redis/lock.go
  • Line 24: warning: comment on exported type Lock should be of the form "Lock ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported function NewLock should be of the form "NewLock ..." (golint)
  • Line 40: warning: comment on exported method Lock.Lock should be of the form "Lock ..." (golint)
  • Line 49: warning: comment on exported method Lock.Unlock should be of the form "Unlock ..." (golint)
  • Line 59: warning: comment on exported method Lock.GetKey should be of the form "GetKey ..." (golint)
  • Line 66: warning: comment on exported method Lock.GenToken should be of the form "GenToken ..." (golint)

• nocalhost/pkg/nocalhost-api/pkg/cache/key.go
  • Line 20: warning: comment on exported function BuildCacheKey should be of the form "BuildCacheKey ..." (golint)

• nocalhost/internal/nocalhost-api/repository/application_cluster/application_cluster_repo.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported type ApplicationClusterRepo should have comment or be unexported (golint)
  • Line 35: warning: exported function NewApplicationClusterRepo should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/resource_operator.go
  • Line 31: warning: exported method ClientGoUtils.NewFactory should have comment or be unexported (golint)
  • Line 40: warning: exported method ClientGoUtils.ApplyAndWait should have comment or be unexported (golint)
  • Line 74: warning: exported method ClientGoUtils.Apply should have comment or be unexported (golint)
  • Line 84: warning: comment on exported method ClientGoUtils.Delete should be of the form "Delete ..." (golint)

• nocalhost/internal/nocalhost-api/repository/cluster_user/cluster_user_repo.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type ClusterUserRepo should have comment or be unexported (golint)
  • Line 45: warning: exported function NewApplicationClusterRepo should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/render.go
  • Line 25: warning: exported type RenderOps should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/cli.go
  • Line 20: warning: exported type CLI should have comment or be unexported (golint)
  • Line 26: warning: exported type Config should have comment or be unexported (golint)
  • Line 32: warning: exported function NewCLI should have comment or be unexported (golint)
  • Line 44: warning: exported method CLI.Command should have comment or be unexported (golint)
  • Line 49: warning: exported method CLI.CommandWithNamespace should have comment or be unexported (golint)
  • Line 54: warning: exported method CLI.Run should have comment or be unexported (golint)
  • Line 59: warning: exported method CLI.RunWithRollingOut should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/application_cluster/application_cluster.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type ApplicationClusterRequest should have comment or be unexported (golint)

• nocalhost/internal/nhctl/request/request.go
  • Line 32: warning: exported const LOGIN should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type ApiRequest should have comment or be unexported (golint)
  • Line 61: warning: exported type MiniKubeCluster should have comment or be unexported (golint)
  • Line 65: warning: exported type MiniKube should have comment or be unexported (golint)
  • Line 69: warning: exported type MiniKubeInfo should have comment or be unexported (golint)
  • Line 74: warning: exported type Response should have comment or be unexported (golint)
  • Line 80: warning: exported type LoginRes should have comment or be unexported (golint)
  • Line 86: warning: exported type Token should have comment or be unexported (golint)
  • Line 90: warning: exported function NewReq should have comment or be unexported (golint)
  • Line 101: warning: exported method ApiRequest.CheckPortIsAvailable should have comment or be unexported (golint)
  • Line 105: warning: comment on exported method ApiRequest.ExposeService should be of the form "ExposeService ..." (golint)
  • Line 149: warning: exported method ApiRequest.IdleThePortForwardIfNeeded should have comment or be unexported (golint)
  • Line 172: warning: exported method ApiRequest.GetAvailableRandomLocalPort should have comment or be unexported (golint)
  • Line 181: warning: exported method ApiRequest.UpdateDataBaseClusterUser should have comment or be unexported (golint)
  • Line 205: warning: exported method ApiRequest.Login should have comment or be unexported (golint)
  • Line 252: warning: exported method ApiRequest.AddBookInfoApplicationForThree should have comment or be unexported (golint)
  • Line 259: warning: exported method ApiRequest.AddBookInfoApplication should have comment or be unexported (golint)
  • Line 317: warning: comment on exported method ApiRequest.GetKubeConfig should be of the form "GetKubeConfig ..." (golint)
  • Line 340: warning: exported method ApiRequest.AddCluster should have comment or be unexported (golint)
  • Line 370: warning: exported method ApiRequest.AddUser should have comment or be unexported (golint)
  • Line 401: warning: exported method ApiRequest.AddDevSpace should have comment or be unexported (golint)
  • Line 433: warning: exported method ApiRequest.SetInjectBatchUserTemplate should have comment or be unexported (golint)
  • Line 438: warning: exported method ApiRequest.InjectBatchDevSpace should have comment or be unexported (golint)

• nocalhost/internal/nhctl/envsubst/nocalhostInclude_test.go
  • Line 56: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 63: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 67: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• nocalhost/pkg/nocalhost-api/pkg/utils/slice.go
  • Line 21: warning: comment on exported function StringSliceReflectEqual should be of the form "StringSliceReflectEqual ..." (golint)
  • Line 26: warning: comment on exported function StringSliceEqual should be of the form "StringSliceEqual ..." (golint)
  • Line 57: warning: comment on exported function Uint64SliceReverse should be of the form "Uint64SliceReverse ..." (golint)
  • Line 67: warning: comment on exported function StringSliceContains should be of the form "StringSliceContains ..." (golint)
  • Line 77: warning: comment on exported function IsInSlice should be of the form "IsInSlice ..." (golint)
  • Line 91: warning: comment on exported function Uint64ShuffleSlice should be of the form "Uint64ShuffleSlice ..." (golint)
  • Line 102: warning: exported function Uint64DeleteElemInSlice should have comment or be unexported (golint)
  • Line 116: warning: exported function Uint64DeleteElemInSliceWithOrder should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/dev_start.go
  • Line 31: warning: exported method Controller.GetDevContainerEnv should have comment or be unexported (golint)
  • Line 104: warning: exported method Controller.GetSyncThingSecretName should have comment or be unexported (golint)
  • Line 292: warning: exported method Controller.GetPersistentVolumeDirs should have comment or be unexported (golint)
  • Line 340: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 365: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 478: warning: exported method Controller.GetNocalhostDevContainerPod should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/sync.go
  • Line 28: warning: exported method Controller.StopFileSyncOnly should have comment or be unexported (golint)
  • Line 61: warning: exported method Controller.FindOutSyncthingProcess should have comment or be unexported (golint)
  • Line 78: warning: exported method Controller.GetSyncThingPid should have comment or be unexported (golint)
  • Line 91: warning: exported method Controller.StopSyncAndPortForwardProcess should have comment or be unexported (golint)
  • Line 117: warning: exported method Controller.SetSyncingStatus should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/const.go
  • Line 18: warning: exported const DefaultSecretGenSign should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: comment on exported const DefaultInitHelmGitRepo should be of the form "DefaultInitHelmGitRepo ..." (golint)
  • Line 45: warning: comment on exported const DefaultInitHelmResourcePath should be of the form "DefaultInitHelmResourcePath ..." (golint)
  • Line 63: warning: comment on exported const DefaultNocalhostMainBranch should be of the form "DefaultNocalhostMainBranch ..." (golint)
  • Line 71: warning: comment on exported const PortForwardManual should be of the form "PortForwardManual ..." (golint)

• nocalhost/internal/nhctl/daemon_server/portforward_manager.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 39: warning: exported type PortForwardManager should have comment or be unexported (golint)
  • Line 44: warning: exported function NewPortForwardManager should have comment or be unexported (golint)
  • Line 48: warning: exported method PortForwardManager.StopPortForwardGoRoutine should have comment or be unexported (golint)
  • Line 79: warning: comment on exported method PortForwardManager.ListAllRunningPFGoRoutineProfile should be of the form "ListAllRunningPFGoRoutineProfile ..." (golint)
  • Line 88: warning: exported method PortForwardManager.RecoverPortForwardForApplication should have comment or be unexported (golint)
  • Line 135: warning: exported method PortForwardManager.RecoverAllPortForward should have comment or be unexported (golint)
  • Line 153: warning: comment on exported method PortForwardManager.StartPortForwardGoRoutine should be of the form "StartPortForwardGoRoutine ..." (golint)

• nocalhost/cmd/nhctl/cmds/init_dep.go
  • Line 33: warning: exported var InitDepCommand should have comment or be unexported (golint)

• nocalhost/test/util/contant.go
  • Line 4: warning: exported const CommitId should have comment (or a comment on this block) or be unexported (golint)

• nocalhost/internal/nocalhost-dep/webhook/patcher.go
  • Line 29: warning: exported type Patcher should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/build.go
  • Line 225: warning: comment on exported function RenderConfig should be of the form "RenderConfig ..." (golint)
  • Line 339: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nhctl/syncthing/syncthingInstaller.go
  • Line 59: warning: exported type SyncthingInstaller should have comment or be unexported (golint)
  • Line 65: warning: exported function NewInstaller should have comment or be unexported (golint)
  • Line 73: warning: comment on exported method SyncthingInstaller.InstallIfNeeded should be of the form "InstallIfNeeded ..." (golint)
  • Line 265: warning: exported function CopyFile should have comment or be unexported (golint)
  • Line 285: warning: exported function GetDir should have comment or be unexported (golint)
  • Line 289: warning: exported function FileExists should have comment or be unexported (golint)
  • Line 302: warning: exported function GetDownloadURL should have comment or be unexported (golint)
  • Line 324: warning: exported function GetBinaryName should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/repository/application/application_repo.go
  • Line 24: warning: exported type ApplicationRepo should have comment or be unexported (golint)
  • Line 40: warning: exported function NewClusterRepo should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/user_base.go
  • Line 24: warning: comment on exported type UserBaseModel should be of the form "UserBaseModel ..." (with optional leading article) (golint)
  • Line 49: warning: comment on exported type UserInfo should be of the form "UserInfo ..." (with optional leading article) (golint)
  • Line 58: warning: comment on exported type UserList should be of the form "UserList ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported method UserBaseModel.TableName should be of the form "TableName ..." (golint)
  • Line 91: warning: comment on exported function GenerateSaName should be of the form "GenerateSaName ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/apply.go
  • Line 30: warning: exported type ApplyFlags should have comment or be unexported (golint)
  • Line 41: warning: exported method ApplyFlags.SetBeforeApply should have comment or be unexported (golint)
  • Line 46: warning: exported method ApplyFlags.SetDoApply should have comment or be unexported (golint)
  • Line 51: warning: exported method ClientGoUtils.DeleteResourceInfo should have comment or be unexported (golint)
  • Line 72: warning: comment on exported method ClientGoUtils.ApplyResourceInfo should be of the form "ApplyResourceInfo ..." (golint)
  • Line 162: warning: exported method ClientGoUtils.GetResourceInfoFromReader should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/network/req/folderOverride.go
  • Line 15: warning: exported method SyncthingHttpClient.FolderOverride should have comment or be unexported (golint)

• nocalhost/internal/nhctl/envsubst/parse/parse.go
  • Line 13: warning: package comment should be of the form "Package parse ..." (golint)
  • Line 24: warning: comment on exported type Mode should be of the form "Mode ..." (with optional leading article) (golint)
  • Line 47: warning: comment on exported type Restrictions should be of the form "Restrictions ..." (with optional leading article) (golint)
  • Line 74: warning: exported type Includation should have comment or be unexported (golint)
  • Line 98: warning: exported method Parser.ParseWithoutIncludation should have comment or be unexported (golint)
  • Line 309: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nocalhost-api/repository/user/user_base_repo.go
  • Line 1: warning: package comment should be of the form "Package user ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 25: warning: comment on exported type BaseRepo should be of the form "BaseRepo ..." (with optional leading article) (golint)
  • Line 43: warning: comment on exported function NewUserRepo should be of the form "NewUserRepo ..." (golint)

• nocalhost/cmd/nhctl/cmds/version.go
  • Line 26: warning: exported var OsArch should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/network/req/syncthingHttpClient.go
  • Line 22: warning: exported type SyncthingHttpClient should have comment or be unexported (golint)
  • Line 29: warning: exported function NewSyncthingHttpClient should have comment or be unexported (golint)
  • Line 52: warning: exported method SyncthingHttpClient.Post should have comment or be unexported (golint)
  • Line 87: warning: exported function ResponseToBArray should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/utils/string.go
  • Line 20: warning: comment on exported function IsEmpty should be of the form "IsEmpty ..." (golint)
  • Line 29: warning: comment on exported function StringToUint64 should be of the form "StringToUint64 ..." (golint)
  • Line 42: warning: comment on exported function StringToInt64 should be of the form "StringToInt64 ..." (golint)
  • Line 55: warning: comment on exported function StringToInt should be of the form "StringToInt ..." (golint)

• nocalhost/test/nhctlcli/testcase/profile.go
  • Line 28: warning: exported function ProfileGetUbuntuWithJson should have comment or be unexported (golint)
  • Line 32: warning: exported function ProfileGetDetailsWithoutJson should have comment or be unexported (golint)
  • Line 50: warning: exported function ProfileSetDetails should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/global/static.go
  • Line 16: warning: exported const NocalhostSystemNamespace should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported const NocalhostDefaultPriorityclassName should be of the form "NocalhostDefaultPriorityclassName ..." (golint)
  • Line 42: warning: exported var Version should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/ports/ports.go
  • Line 73: warning: exported function IsTCP4PortAvailable should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/application.go
  • Line 25: warning: comment on exported function ListByApplication should be of the form "ListByApplication ..." (golint)
  • Line 36: warning: comment on exported function ListNotInApplication should be of the form "ListNotInApplication ..." (golint)

• nocalhost/internal/nocalhost-api/cache/user/user_base.go
  • Line 27: warning: comment on exported const DefaultExpireTime should be of the form "DefaultExpireTime ..." (golint)
  • Line 36: warning: comment on exported function NewUserCache should be of the form "NewUserCache ..." (golint)
  • Line 47: warning: comment on exported method Cache.GetUserBaseCacheKey should be of the form "GetUserBaseCacheKey ..." (golint)
  • Line 52: warning: comment on exported method Cache.SetUserBaseCache should be of the form "SetUserBaseCache ..." (golint)
  • Line 65: warning: comment on exported method Cache.GetUserBaseCache should be of the form "GetUserBaseCache ..." (golint)
  • Line 75: warning: comment on exported method Cache.MultiGetUserBaseCache should be of the form "MultiGetUserBaseCache ..." (golint)
  • Line 91: warning: comment on exported method Cache.DelUserBaseCache should be of the form "DelUserBaseCache ..." (golint)

• nocalhost/cmd/nhctl/cmds/port_forward.go
  • Line 21: warning: exported var PortForwardCmd should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/utils/utils.go
  • Line 35: warning: comment on exported function GenShortID should be of the form "GenShortID ..." (golint)
  • Line 40: warning: comment on exported var XRequestID should be of the form "XRequestID ..." (golint)
  • Line 49: warning: comment on exported function GetRequestID should be of the form "GetRequestID ..." (golint)
  • Line 66: warning: comment on exported function GetLocalIP should be of the form "GetLocalIP ..." (golint)
  • Line 90: warning: comment on exported function Md5 should be of the form "Md5 ..." (golint)
  • Line 102: warning: comment on exported function RandomStr should be of the form "RandomStr ..." (golint)
  • Line 163: warning: comment on exported function ReplaceDNS1123 should be of the form "ReplaceDNS1123 ..." (golint)

• nocalhost/internal/nocalhost-dep/serviceaccount/service_account_watcher.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 34: warning: exported type ServiceAccountWatcher should have comment or be unexported (golint)
  • Line 44: warning: exported method ServiceAccountWatcher.CreateOrUpdate should have comment or be unexported (golint)
  • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 54: warning: exported method ServiceAccountWatcher.Delete should have comment or be unexported (golint)
  • Line 64: warning: exported method ServiceAccountWatcher.WatcherInfo should have comment or be unexported (golint)
  • Line 89: warning: exported function NewServiceAccountWatcher should have comment or be unexported (golint)
  • Line 189: warning: exported method ServiceAccountWatcher.IsClusterAdmin should have comment or be unexported (golint)
  • Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 198: warning: exported method ServiceAccountWatcher.Quit should have comment or be unexported (golint)
  • Line 202: warning: exported method ServiceAccountWatcher.Prepare should have comment or be unexported (golint)
  • Line 227: warning: comment on exported method ServiceAccountWatcher.Watch should be of the form "Watch ..." (golint)

• nocalhost/internal/nhctl/app/pvc.go
  • Line 22: warning: comment on exported method Application.GetAllPVCs should be of the form "GetAllPVCs ..." (golint)
  • Line 33: warning: comment on exported method Application.CleanUpPVCs should be of the form "CleanUpPVCs ..." (golint)

• nocalhost/test/nhctlcli/cmdrunner.go
  • Line 28: warning: exported var Runner should have comment or be unexported (golint)
  • Line 30: warning: exported type CmdRunner should have comment or be unexported (golint)
  • Line 32: warning: exported method CmdRunner.RunWithCheckResult should have comment or be unexported (golint)
  • Line 40: warning: exported method CmdRunner.CheckResult should have comment or be unexported (golint)
  • Line 48: warning: exported method CmdRunner.Run should have comment or be unexported (golint)
  • Line 72: warning: exported method CmdRunner.RunWithRollingOut should have comment or be unexported (golint)
  • Line 126: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nhctl/app/env.go
  • Line 20: warning: comment on exported type InstallEnvForDep should be of the form "InstallEnvForDep ..." (with optional leading article) (golint)
  • Line 26: warning: exported type ServiceEnvForDep should have comment or be unexported (golint)
  • Line 32: warning: exported type ContainerEnvForDep should have comment or be unexported (golint)
  • Line 37: warning: exported method Application.GetInstallEnvForDep should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/svc_profile_ops.go
  • Line 22: warning: exported method Application.GetSvcProfile should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/error.go
  • Line 15: warning: exported type ErrorType should have comment or be unexported (golint)
  • Line 18: warning: exported const InvalidYaml should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type TypedError should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/exec.go
  • Line 29: warning: exported method ClientGoUtils.ExecShell should have comment or be unexported (golint)
  • Line 33: warning: exported method ClientGoUtils.Exec should have comment or be unexported (golint)
  • Line 102: warning: exported function Execute should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/config_edit.go
  • Line 25: warning: exported type ConfigEditFlags should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/model.go
  • Line 20: warning: comment on exported type NullType should be of the form "NullType ..." (with optional leading article) (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/delete.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 153: warning: comment on exported function PluginReCreate should be of the form "PluginReCreate ..." (golint)

• nocalhost/internal/nhctl/syncthing/local/syncthingTemplates.go
  • Line 15: warning: comment on exported const LocalSyncConfigXML should be of the form "LocalSyncConfigXML ..." (golint)
  • Line 108: warning: comment on exported const RemoteSyncConfigXML should be of the form "RemoteSyncConfigXML ..." (golint)

• nocalhost/internal/nocalhost-api/idl/user.go
  • Line 19: warning: comment on exported type TransferUserInput should be of the form "TransferUserInput ..." (with optional leading article) (golint)
  • Line 25: warning: comment on exported function TransferUser should be of the form "TransferUser ..." (golint)

• nocalhost/cmd/nhctl/cmds/config_template.go
  • Line 24: warning: exported type CommonFlags should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/application_model.go
  • Line 21: warning: comment on exported type ApplicationModel should be of the form "ApplicationModel ..." (with optional leading article) (golint)
  • Line 34: warning: exported type PluginApplicationModel should have comment or be unexported (golint)
  • Line 52: warning: exported method ApplicationModel.FillEditable should have comment or be unexported (golint)
  • Line 66: warning: comment on exported method ApplicationModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/pkg/nocalhost-api/pkg/clientgo/client.go
  • Line 46: warning: exported const DepInstaller should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: exported var LimitedRules should have comment or be unexported (golint)
  • Line 57: warning: exported type GoClient should have comment or be unexported (golint)
  • Line 63: warning: exported type InitResult should have comment or be unexported (golint)
  • Line 68: warning: comment on exported function NewAdminGoClient should be of the form "NewAdminGoClient ..." (golint)
  • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 153: warning: error should be the last type when returning multiple items (golint)
  • Line 214: warning: comment on exported method GoClient.GetDepDeploymentStatus should be of the form "GetDepDeploymentStatus ..." (golint)
  • Line 237: warning: comment on exported method GoClient.IfNocalhostNameSpaceExist should be of the form "IfNocalhostNameSpaceExist ..." (golint)
  • Line 246: warning: comment on exported method GoClient.CreateNS should be of the form "CreateNS ..." (golint)
  • Line 266: warning: exported method GoClient.ExistNs should have comment or be unexported (golint)
  • Line 278: warning: exported method GoClient.ExistDeployment should have comment or be unexported (golint)
  • Line 290: warning: exported method GoClient.ExistClusterRoleBinding should have comment or be unexported (golint)
  • Line 302: warning: exported method GoClient.ExistPriorityClass should have comment or be unexported (golint)
  • Line 314: warning: exported method GoClient.ExistServiceAccount should have comment or be unexported (golint)
  • Line 326: warning: comment on exported method GoClient.DeleteNS should be of the form "DeleteNS ..." (golint)
  • Line 335: warning: comment on exported method GoClient.GenerateNsName should be of the form "GenerateNsName ..." (golint)
  • Line 347: warning: comment on exported method GoClient.IsAdmin should be of the form "IsAdmin ..." (golint)
  • Line 373: warning: comment on exported method GoClient.CreateServiceAccount should be of the form "CreateServiceAccount ..." (golint)
  • Line 392: warning: comment on exported method GoClient.RefreshServiceAccount should be of the form "RefreshServiceAccount ..." (golint)
  • Line 460: warning: exported method GoClient.DeleteResourceQuota should have comment or be unexported (golint)
  • Line 512: warning: exported method GoClient.DeleteLimitRange should have comment or be unexported (golint)
  • Line 556: warning: comment on exported method GoClient.CreateClusterRoleBinding should be of the form "CreateClusterRoleBinding ..." (golint)
  • Line 590: warning: exported method GoClient.UpdateRole should have comment or be unexported (golint)
  • Line 612: warning: comment on exported method GoClient.AppendRoleBinding should be of the form "AppendRoleBinding ..." (golint)
  • Line 675: warning: comment on exported method GoClient.AppendClusterRoleBinding should be of the form "AppendClusterRoleBinding ..." (golint)
  • Line 737: warning: exported method GoClient.RemoveClusterRoleBinding should have comment or be unexported (golint)
  • Line 765: warning: exported method GoClient.RemoveRoleBinding should have comment or be unexported (golint)
  • Line 793: warning: comment on exported method GoClient.CreateRole should be of the form "CreateRole ..." (golint)
  • Line 825: warning: comment on exported method GoClient.CreateClusterRole should be of the form "CreateClusterRole ..." (golint)
  • Line 890: warning: comment on exported method GoClient.CreateNocalhostPriorityClass should be of the form "CreateNocalhostPriorityClass ..." (golint)
  • Line 903: warning: comment on exported method GoClient.DeployNocalhostDep should be of the form "DeployNocalhostDep ..." (golint)
  • Line 939: warning: comment on exported method GoClient.DeployPrePullImages should be of the form "DeployPrePullImages ..." (golint)
  • Line 995: warning: comment on exported method GoClient.CreateConfigMap should be of the form "CreateConfigMap ..." (golint)
  • Line 1018: warning: comment on exported method GoClient.GetSecret should be of the form "GetSecret ..." (golint)
  • Line 1023: warning: comment on exported method GoClient.GetServiceAccount should be of the form "GetServiceAccount ..." (golint)
  • Line 1028: warning: comment on exported method GoClient.GetClusterNode should be of the form "GetClusterNode ..." (golint)
  • Line 1033: warning: exported method GoClient.GetClusterRoleBinding should have comment or be unexported (golint)
  • Line 1037: warning: exported method GoClient.ListClusterRoleBindingByLabel should have comment or be unexported (golint)
  • Line 1045: warning: comment on exported method GoClient.GetClusterVersion should be of the form "GetClusterVersion ..." (golint)
  • Line 1050: warning: comment on exported method GoClient.WatchServiceAccount should be of the form "WatchServiceAccount ..." (golint)
  • Line 1117: warning: exported method GoClient.GetStorageClassList should have comment or be unexported (golint)
  • Line 1121: warning: comment on exported method GoClient.MatchedArtifactVersion should be of the form "MatchedArtifactVersion ..." (golint)
  • Line 1137: warning: exported method GoClient.ListJobs should have comment or be unexported (golint)
  • Line 1141: warning: exported method GoClient.DeleteJob should have comment or be unexported (golint)
  • Line 1145: warning: exported method GoClient.ListPods should have comment or be unexported (golint)
  • Line 1149: warning: exported method GoClient.DeletePod should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app_flags/flags.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type InstallFlags should have comment or be unexported (golint)
  • Line 35: warning: exported type ListFlags should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-dep/webhook/webhook.go
  • Line 63: warning: exported type WebhookServer should have comment or be unexported (golint)
  • Line 68: warning: comment on exported type WhSvrParameters should be of the form "WhSvrParameters ..." (with optional leading article) (golint)
  • Line 76: warning: exported type Config should have comment or be unexported (golint)
  • Line 185: warning: exported function LoadConfig should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/testcase/daemon.go
  • Line 29: warning: exported function RestartDaemon should have comment or be unexported (golint)
  • Line 34: warning: exported function StopDaemon should have comment or be unexported (golint)
  • Line 39: warning: exported function Exec should have comment or be unexported (golint)
  • Line 47: warning: exported function PortForwardStart should have comment or be unexported (golint)
  • Line 68: warning: exported function PortForwardServiceStart should have comment or be unexported (golint)
  • Line 81: warning: exported function StatusCheckPortForward should have comment or be unexported (golint)
  • Line 103: warning: exported function PortForwardEnd should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/options.go
  • Line 15: warning: exported type FileSyncOptions should have comment or be unexported (golint)
  • Line 26: warning: exported type SyncStatusOptions should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/sync.go
  • Line 84: warning: exported function StartSyncthing should have comment or be unexported (golint)

• nocalhost/test/nhctlcli/suite/function.go
  • Line 29: warning: exported function PortForward should have comment or be unexported (golint)
  • Line 49: warning: exported function PortForwardService should have comment or be unexported (golint)
  • Line 70: warning: exported function Deployment should have comment or be unexported (golint)
  • Line 97: warning: exported function StatefulSet should have comment or be unexported (golint)
  • Line 109: warning: exported function Compatible should have comment or be unexported (golint)
  • Line 151: warning: exported function Reset should have comment or be unexported (golint)
  • Line 169: warning: exported function Apply should have comment or be unexported (golint)
  • Line 174: warning: exported function Upgrade should have comment or be unexported (golint)
  • Line 182: warning: exported function Profile should have comment or be unexported (golint)
  • Line 191: warning: exported function Install should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/tpl/tpl.go
  • Line 242: warning: exported function GetSvcTpl should have comment or be unexported (golint)
  • Line 255: warning: exported function CombineTpl should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/service.go
  • Line 38: warning: exported var NocalhostDefaultSaNs should have comment or be unexported (golint)
  • Line 80: warning: exported method Service.ClusterSvc should have comment or be unexported (golint)
  • Line 84: warning: exported method Service.ApplicationSvc should have comment or be unexported (golint)
  • Line 88: warning: exported method Service.ApplicationClusterSvc should have comment or be unexported (golint)
  • Line 92: warning: exported method Service.ClusterUser should have comment or be unexported (golint)
  • Line 96: warning: exported method Service.PrePull should have comment or be unexported (golint)
  • Line 100: warning: exported method Service.ApplicationUser should have comment or be unexported (golint)
  • Line 320: warning: exported method Service.AuthorizeNsToUser should have comment or be unexported (golint)
  • Line 339: warning: exported method Service.UnAuthorizeNsToUser should have comment or be unexported (golint)
  • Line 353: warning: exported method Service.AuthorizeClusterToUser should have comment or be unexported (golint)
  • Line 367: warning: exported method Service.UnAuthorizeClusterToUser should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/network/req/reqFacade.go
  • Line 19: warning: exported method SyncthingHttpClient.GetSyncthingStatus should have comment or be unexported (golint)
  • Line 110: warning: comment on exported type SyncthingStatus should be of the form "SyncthingStatus ..." (with optional leading article) (golint)
  • Line 118: warning: exported type StatusEnum should have comment or be unexported (golint)
  • Line 134: warning: exported var NotInDevModeTemplate should have comment or be unexported (golint)
  • Line 140: warning: exported var NotProcessor should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/application_user/application_user.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type ApplicationUsersRequest should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/port_forward.go
  • Line 26: warning: exported type ForwardPort should have comment or be unexported (golint)
  • Line 31: warning: exported method ClientGoUtils.CreatePortForwarder should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/service/application/application_service.go
  • Line 23: warning: exported type ApplicationService should have comment or be unexported (golint)
  • Line 41: warning: exported function NewApplicationService should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/router/middleware/permission.go
  • Line 23: warning: comment on exported function PermissionMiddleware should be of the form "PermissionMiddleware ..." (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/service_account/service_account.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 32: warning: exported type SaAuthorizeRequest should have comment or be unexported (golint)
  • Line 38: warning: exported function Authorize should have comment or be unexported (golint)
  • Line 55: warning: exported function ListAuthorization should have comment or be unexported (golint)
  • Line 239: warning: exported type ServiceAccountModel should have comment or be unexported (golint)
  • Line 247: warning: exported type NS should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/app_profile_v2.go
  • Line 128: warning: exported method Application.UpgradeAppConfigV1ToV2 should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/repository/application_user/application_user_repo.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type ApplicationUserRepo should have comment or be unexported (golint)
  • Line 36: warning: exported function NewApplicationUserRepo should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/application_cluster_model.go
  • Line 21: warning: comment on exported type ApplicationClusterModel should be of the form "ApplicationClusterModel ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported type ApplicationClusterJoinModel should be of the form "ApplicationClusterJoinModel ..." (with optional leading article) (golint)
  • Line 48: warning: comment on exported method ApplicationClusterModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/internal/nhctl/syncthing/network/req/connectionStats.go
  • Line 17: warning: exported method SyncthingHttpClient.SystemConnections should have comment or be unexported (golint)
  • Line 38: warning: exported type ConnectionStatsResponse should have comment or be unexported (golint)
  • Line 42: warning: exported type ConnectionStats should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/sign/sign_md5.go
  • Line 17: warning: exported function Md5Sign should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/log/zap.go
  • Line 30: warning: comment on exported const WriterStdOut should be of the form "WriterStdOut ..." (golint)
  • Line 32: warning: comment on exported const WriterFile should be of the form "WriterFile ..." (golint)
  • Line 37: warning: comment on exported const RotateTimeDaily should be of the form "RotateTimeDaily ..." (golint)
  • Line 39: warning: comment on exported const RotateTimeHourly should be of the form "RotateTimeHourly ..." (golint)

• nocalhost/pkg/nhctl/log/log.go
  • Line 53: warning: exported function Init should have comment or be unexported (golint)
  • Line 85: warning: exported function CustomDurationEncoder should have comment or be unexported (golint)
  • Line 89: warning: exported function CustomTimeEncoder should have comment or be unexported (golint)
  • Line 93: warning: exported function CustomLevelEncoder should have comment or be unexported (golint)
  • Line 105: warning: exported function AddField should have comment or be unexported (golint)
  • Line 110: warning: exported function Debug should have comment or be unexported (golint)
  • Line 117: warning: exported function Debugf should have comment or be unexported (golint)
  • Line 124: warning: exported function Info should have comment or be unexported (golint)
  • Line 131: warning: exported function Infof should have comment or be unexported (golint)
  • Line 138: warning: exported function Warn should have comment or be unexported (golint)
  • Line 145: warning: exported function Warnf should have comment or be unexported (golint)
  • Line 152: warning: exported function WarnE should have comment or be unexported (golint)
  • Line 164: warning: exported function Error should have comment or be unexported (golint)
  • Line 171: warning: exported function Errorf should have comment or be unexported (golint)
  • Line 178: warning: exported function ErrorE should have comment or be unexported (golint)
  • Line 189: warning: exported function Fatal should have comment or be unexported (golint)
  • Line 196: warning: exported function Fatalf should have comment or be unexported (golint)
  • Line 203: warning: comment on exported function FatalE should be of the form "FatalE ..." (golint)
  • Line 217: warning: exported function LogE should have comment or be unexported (golint)
  • Line 223: warning: exported function Log should have comment or be unexported (golint)
  • Line 229: warning: exported function Logf should have comment or be unexported (golint)
  • Line 235: warning: exported function LogStack should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/profile.go
  • Line 23: warning: exported method Controller.SaveConfigToProfile should have comment or be unexported (golint)
  • Line 42: warning: exported method Controller.GetAppProfile should have comment or be unexported (golint)
  • Line 46: warning: exported method Controller.GetProfile should have comment or be unexported (golint)
  • Line 54: warning: exported method Controller.GetWorkDir should have comment or be unexported (golint)
  • Line 62: warning: exported method Controller.GetStorageClass should have comment or be unexported (golint)
  • Line 70: warning: exported method Controller.GetDevImage should have comment or be unexported (golint)
  • Line 78: warning: exported method Controller.GetPortForwardForSync should have comment or be unexported (golint)
  • Line 92: warning: exported method Controller.SetPortForwardedStatus should have comment or be unexported (golint)
  • Line 122: warning: comment on exported method Controller.AddPortForwardToDB should be of the form "AddPortForwardToDB ..." (golint)
  • Line 136: warning: exported method Controller.DeletePortForwardFromDB should have comment or be unexported (golint)
  • Line 172: warning: exported method Controller.SetSyncthingPort should have comment or be unexported (golint)
  • Line 196: warning: comment on exported method Controller.GetProfileForUpdate should be of the form "GetProfileForUpdate ..." (golint)

• nocalhost/internal/nhctl/nocalhost/nocalhost.go
  • Line 33: warning: exported const DefaultNewFilePermission should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported function Init should have comment or be unexported (golint)
  • Line 151: warning: comment on exported function GetAppHomeDir should be of the form "GetAppHomeDir ..." (golint)
  • Line 156: warning: exported function CleanupAppFilesUnderNs should have comment or be unexported (golint)
  • Line 169: warning: exported function GetSyncThingBinDir should have comment or be unexported (golint)
  • Line 173: warning: exported function GetLogDir should have comment or be unexported (golint)
  • Line 177: warning: comment on exported function GetNsAndApplicationInfo should be of the form "GetNsAndApplicationInfo ..." (golint)
  • Line 206: warning: exported function GetApplicationMetaInstalled should have comment or be unexported (golint)
  • Line 231: warning: exported function GetApplicationMeta should have comment or be unexported (golint)
  • Line 258: warning: exported function GetApplicationMetas should have comment or be unexported (golint)

• nocalhost/internal/nhctl/envsubst/parse/env.go
  • Line 19: warning: exported type Env should have comment or be unexported (golint)
  • Line 21: warning: exported method Env.Get should have comment or be unexported (golint)
  • Line 25: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 30: warning: exported method Env.Has should have comment or be unexported (golint)
  • Line 35: warning: exported method Env.Lookup should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/dev_cmd.go
  • Line 22: warning: exported type DevCommandType should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/sign/signer.go
  • Line 25: warning: comment on exported type CryptoFunc should be of the form "CryptoFunc ..." (with optional leading article) (golint)
  • Line 53: warning: comment on exported function NewSignerMd5 should be of the form "NewSignerMd5 ..." (golint)
  • Line 58: warning: comment on exported function NewSignerHmac should be of the form "NewSignerHmac ..." (golint)
  • Line 63: warning: comment on exported method Signer.SetBody should be of the form "SetBody ..." (golint)
  • Line 70: warning: comment on exported method Signer.GetBody should be of the form "GetBody ..." (golint)
  • Line 75: warning: comment on exported method Signer.AddBody should be of the form "AddBody ..." (golint)
  • Line 86: warning: comment on exported method Signer.SetTimeStamp should be of the form "SetTimeStamp ..." (golint)
  • Line 91: warning: comment on exported method Signer.GetTimeStamp should be of the form "GetTimeStamp ..." (golint)
  • Line 96: warning: comment on exported method Signer.SetNonceStr should be of the form "SetNonceStr ..." (golint)
  • Line 101: warning: comment on exported method Signer.GetNonceStr should be of the form "GetNonceStr ..." (golint)
  • Line 106: warning: comment on exported method Signer.SetAppID should be of the form "SetAppID ..." (golint)
  • Line 116: warning: comment on exported method Signer.RandNonceStr should be of the form "RandNonceStr ..." (golint)
  • Line 121: warning: comment on exported method Signer.SetSignBodyPrefix should be of the form "SetSignBodyPrefix ..." (golint)
  • Line 127: warning: comment on exported method Signer.SetSignBodySuffix should be of the form "SetSignBodySuffix ..." (golint)
  • Line 133: warning: comment on exported method Signer.SetSplitChar should be of the form "SetSplitChar ..." (golint)
  • Line 139: warning: comment on exported method Signer.SetAppSecret should be of the form "SetAppSecret ..." (golint)
  • Line 145: warning: comment on exported method Signer.SetAppSecretWrapBody should be of the form "SetAppSecretWrapBody ..." (golint)
  • Line 152: warning: comment on exported method Signer.GetSignBodyString should be of the form "GetSignBodyString ..." (golint)
  • Line 157: warning: comment on exported method Signer.MakeRawBodyString should be of the form "MakeRawBodyString ..." (golint)
  • Line 162: warning: comment on exported method Signer.GetSignedQuery should be of the form "GetSignedQuery ..." (golint)
  • Line 167: warning: comment on exported method Signer.MakeSignedQuery should be of the form "MakeSignedQuery ..." (golint)
  • Line 174: warning: comment on exported method Signer.GetSignature should be of the form "GetSignature ..." (golint)
  • Line 179: warning: comment on exported method Signer.MakeSign should be of the form "MakeSign ..." (golint)
  • Line 189: warning: comment on exported function SortKVPairs should be of the form "SortKVPairs ..." (golint)

• nocalhost/test/tke/tke.go
  • Line 31: warning: exported function CreateK8s should have comment or be unexported (golint)
  • Line 58: warning: exported function DeleteTke should have comment or be unexported (golint)
  • Line 62: warning: exported function NewTask should have comment or be unexported (golint)
  • Line 76: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 196: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 219: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/application_user/update.go
  • Line 13: warning: don't use an underscore in package name (golint)

• nocalhost/internal/nhctl/nocalhost_path/filepath.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported const DefaultApplicationDbDir should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported function GetAppDbDir should have comment or be unexported (golint)
  • Line 30: warning: exported function GetAppDirUnderNs should have comment or be unexported (golint)
  • Line 34: warning: exported function GetNhctlHomeDir should have comment or be unexported (golint)
  • Line 38: warning: comment on exported function GetNhctlNameSpaceDir should be of the form "GetNhctlNameSpaceDir ..." (golint)

• nocalhost/internal/nhctl/controller/filepath.go
  • Line 24: warning: exported method Controller.GetSyncThingPidFile should have comment or be unexported (golint)
  • Line 28: warning: exported method Controller.GetApplicationSyncDir should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/clientgoutils/resource.go
  • Line 34: warning: comment on exported method ResourceList.Visits should be of the form "Visits ..." (golint)
  • Line 107: warning: exported function LoadValidManifest should have comment or be unexported (golint)
  • Line 129: warning: comment on exported function GetYamlFilesAndDirs should be of the form "GetYamlFilesAndDirs ..." (golint)

• nocalhost/cmd/nhctl/cmds/cmdutil.go
  • Line 55: warning: exported function Prepare should have comment or be unexported (golint)
  • Line 99: warning: exported function InitDefaultApplicationInCurrentNs should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/cache/memory.go
  • Line 30: warning: comment on exported function NewMemoryCache should be of the form "NewMemoryCache ..." (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/service_account/role_binding_watcher_boss.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 26: warning: exported type Supervisor should have comment or be unexported (golint)
  • Line 31: warning: exported function GetAllPermittedNs should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/const.go
  • Line 31: warning: exported type ContainerDevEnv should have comment or be unexported (golint)

• nocalhost/internal/nhctl/controller/port_forward.go
  • Line 30: warning: exported method Controller.EndDevPortForward should have comment or be unexported (golint)
  • Line 56: warning: exported method Controller.StopAllPortForward should have comment or be unexported (golint)
  • Line 83: warning: exported method Controller.UpdatePortForwardStatus should have comment or be unexported (golint)
  • Line 150: warning: exported method Controller.PortForwardAfterDevStart should have comment or be unexported (golint)
  • Line 199: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 205: warning: comment on exported function GetPortForwardForString should be of the form "GetPortForwardForString ..." (golint)
  • Line 228: warning: exported method Controller.CheckIfPortForwardExists should have comment or be unexported (golint)

• nocalhost/internal/nhctl/profile/app_profile.go
  • Line 15: warning: comment on exported type AppProfile should be of the form "AppProfile ..." (with optional leading article) (golint)

• nocalhost/pkg/nhctl/clientgoutils/event.go
  • Line 22: warning: exported method ClientGoUtils.ListEventsByReplicaSet should have comment or be unexported (golint)
  • Line 41: warning: exported method ClientGoUtils.ListEvents should have comment or be unexported (golint)
  • Line 54: warning: exported method ClientGoUtils.ListEventsByStatefulSet should have comment or be unexported (golint)
  • Line 70: warning: exported method ClientGoUtils.DeleteEvent should have comment or be unexported (golint)
  • Line 74: warning: exported method ClientGoUtils.DeleteEvents should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/utils/time.go
  • Line 20: warning: comment on exported function GetDate should be of the form "GetDate ..." (golint)
  • Line 25: warning: comment on exported function GetTodayDateInt should be of the form "GetTodayDateInt ..." (golint)
  • Line 35: warning: comment on exported function TimeLayout should be of the form "TimeLayout ..." (golint)
  • Line 40: warning: comment on exported function TimeToString should be of the form "TimeToString ..." (golint)
  • Line 45: warning: comment on exported function TimeToShortString should be of the form "TimeToShortString ..." (golint)

• nocalhost/internal/nocalhost-api/service/cluster/cluster_service.go
  • Line 23: warning: exported type ClusterService should have comment or be unexported (golint)
  • Line 39: warning: exported function NewClusterService should have comment or be unexported (golint)

• nocalhost/internal/nhctl/appmeta_manager/application_secret_event.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 44: warning: exported var Events should have comment or be unexported (golint)
  • Line 50: warning: exported type ApplicationEventPack should have comment or be unexported (golint)
  • Line 55: warning: exported function RegisterListener should have comment or be unexported (golint)
  • Line 77: warning: exported function EventPush should have comment or be unexported (golint)
  • Line 87: warning: exported function EventPop should have comment or be unexported (golint)
  • Line 101: warning: exported function Init should have comment or be unexported (golint)
  • Line 133: warning: exported function Start should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/sign/keys.go
  • Line 16: warning: exported const KeyNameTimeStamp should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: comment on exported type DefaultKeyName should be of the form "DefaultKeyName ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported method DefaultKeyName.SetKeyNameTimestamp should be of the form "SetKeyNameTimestamp ..." (golint)
  • Line 44: warning: comment on exported method DefaultKeyName.SetKeyNameNonceStr should be of the form "SetKeyNameNonceStr ..." (golint)
  • Line 49: warning: comment on exported method DefaultKeyName.SetKeyNameAppID should be of the form "SetKeyNameAppID ..." (golint)
  • Line 54: warning: comment on exported method DefaultKeyName.SetKeyNameSign should be of the form "SetKeyNameSign ..." (golint)

• nocalhost/test/nhctlcli/testcase/dev.go
  • Line 32: warning: exported function DevStart should have comment or be unexported (golint)
  • Line 36: warning: exported function DevStartT should have comment or be unexported (golint)
  • Line 62: warning: exported function Sync should have comment or be unexported (golint)
  • Line 66: warning: exported function SyncT should have comment or be unexported (golint)
  • Line 71: warning: exported function SyncCheck should have comment or be unexported (golint)
  • Line 75: warning: exported function SyncCheckT should have comment or be unexported (golint)
  • Line 119: warning: exported function PortForwardCheck should have comment or be unexported (golint)
  • Line 134: warning: exported function DevEnd should have comment or be unexported (golint)
  • Line 138: warning: exported function DevEndT should have comment or be unexported (golint)

• nocalhost/internal/nhctl/profile/profile_v2.go
  • Line 29: warning: comment on exported const DefaultDevImage should be of the form "DefaultDevImage ..." (golint)
  • Line 31: warning: exported const DefaultWorkDir should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported type AppProfileV2 should have comment or be unexported (golint)
  • Line 76: warning: exported method AppProfileV2.LoadManifests should have comment or be unexported (golint)
  • Line 84: warning: exported function ProfileV2Key should have comment or be unexported (golint)
  • Line 88: warning: exported function NewAppProfileV2ForUpdate should have comment or be unexported (golint)
  • Line 134: warning: exported method AppProfileV2.SvcProfileV2 should have comment or be unexported (golint)
  • Line 166: warning: comment on exported method AppProfileV2.GenerateIdentifierIfNeeded should be of the form "GenerateIdentifierIfNeeded ..." (golint)
  • Line 176: warning: exported method AppProfileV2.Save should have comment or be unexported (golint)
  • Line 190: warning: exported method AppProfileV2.CloseDb should have comment or be unexported (golint)
  • Line 197: warning: exported type SvcProfileV2 should have comment or be unexported (golint)
  • Line 232: warning: exported type ContainerProfileV2 should have comment or be unexported (golint)
  • Line 236: warning: exported type DevPortForward should have comment or be unexported (golint)
  • Line 251: warning: comment on exported method SvcProfileV2.GetContainerDevConfigOrDefault should be of the form "GetContainerDevConfigOrDefault ..." (golint)
  • Line 261: warning: exported method SvcProfileV2.GetDefaultContainerDevConfig should have comment or be unexported (golint)
  • Line 268: warning: exported method SvcProfileV2.GetContainerDevConfig should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/init_demo.go
  • Line 32: warning: exported type Init should have comment or be unexported (golint)
  • Line 86: warning: exported var InitCommand should have comment or be unexported (golint)
  • Line 314: warning: exported function FindOutWebEndpoint should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/applications/delete.go
  • Line 24: warning: comment on exported function Delete should be of the form "Delete ..." (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/user.go
  • Line 19: warning: comment on exported type CreateRequest should be of the form "CreateRequest ..." (with optional leading article) (golint)
  • Line 25: warning: comment on exported type CreateResponse should be of the form "CreateResponse ..." (with optional leading article) (golint)
  • Line 30: warning: comment on exported type RegisterRequest should be of the form "RegisterRequest ..." (with optional leading article) (golint)
  • Line 37: warning: comment on exported type CreateUserRequest should be of the form "CreateUserRequest ..." (with optional leading article) (golint)
  • Line 47: warning: comment on exported type UpdateUserRequest should be of the form "UpdateUserRequest ..." (with optional leading article) (golint)
  • Line 56: warning: comment on exported type LoginCredentials should be of the form "LoginCredentials ..." (with optional leading article) (golint)
  • Line 63: warning: comment on exported type UpdateRequest should be of the form "UpdateRequest ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported type ListResponse should be of the form "ListResponse ..." (with optional leading article) (golint)
  • Line 78: warning: comment on exported type SwaggerListResponse should be of the form "SwaggerListResponse ..." (with optional leading article) (golint)

• nocalhost/internal/nhctl/envsubst/envsubst.go
  • Line 24: warning: exported function Render should have comment or be unexported (golint)

• nocalhost/pkg/nhctl/k8sutils/utils.go
  • Line 19: warning: exported function ValidateDNS1123Name should have comment or be unexported (golint)
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/internal/nhctl/appmeta_manager/application_secret_boss.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 30: warning: exported type Supervisor should have comment or be unexported (golint)
  • Line 35: warning: exported function GetApplicationMetas should have comment or be unexported (golint)
  • Line 40: warning: exported function GetApplicationMeta should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/install.go
  • Line 192: warning: exported function InstallApplication should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/list.go
  • Line 80: warning: exported function ListApplicationSvc should have comment or be unexported (golint)
  • Line 101: warning: exported function ListApplicationsResult should have comment or be unexported (golint)
  • Line 129: warning: exported function ListApplicationsFull should have comment or be unexported (golint)
  • Line 136: warning: exported function ListApplicationsJson should have comment or be unexported (golint)
  • Line 142: warning: exported function ListApplicationsYaml should have comment or be unexported (golint)
  • Line 148: warning: exported function ListApplications should have comment or be unexported (golint)
  • Line 157: warning: comment on exported function DoGetApplicationMetas should be of the form "DoGetApplicationMetas ..." (golint)
  • Line 169: warning: exported type Namespace should have comment or be unexported (golint)
  • Line 174: warning: exported type ApplicationInfo should have comment or be unexported (golint)

• nocalhost/internal/nhctl/syncthing/network/req/completion.go
  • Line 20: warning: exported method SyncthingHttpClient.Completion should have comment or be unexported (golint)
  • Line 35: warning: exported method FolderCompletion.NeedOverrideForce should have comment or be unexported (golint)
  • Line 43: warning: exported method FolderCompletion.UploadPct should have comment or be unexported (golint)
  • Line 48: warning: exported type FolderCompletion should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster/update.go
  • Line 23: warning: comment on exported function Update should be of the form "Update ..." (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/get.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 28: warning: comment on exported function GetFirst should be of the form "GetFirst ..." (golint)
  • Line 53: warning: comment on exported function GetList should be of the form "GetList ..." (golint)
  • Line 76: warning: exported function ListAll should have comment or be unexported (golint)
  • Line 105: warning: comment on exported function ListByUserId should be of the form "ListByUserId ..." (golint)
  • Line 139: warning: comment on exported function GetDevSpaceDetail should be of the form "GetDevSpaceDetail ..." (golint)
  • Line 165: warning: comment on exported function GetJoinClusterAndAppAndUser should be of the form "GetJoinClusterAndAppAndUser ..." (golint)
  • Line 194: warning: comment on exported function GetJoinClusterAndAppAndUserDetail should be of the form "GetJoinClusterAndAppAndUserDetail ..." (golint)

• nocalhost/pkg/nhctl/clientgoutils/patch.go
  • Line 22: warning: exported method ClientGoUtils.Patch should have comment or be unexported (golint)

• nocalhost/test/util/util.go
  • Line 36: warning: exported var Client should have comment or be unexported (golint)
  • Line 38: warning: exported function Init should have comment or be unexported (golint)
  • Line 47: warning: exported function WaitForCommandDone should have comment or be unexported (golint)
  • Line 61: warning: exported function WaitResourceToBeStatus should have comment or be unexported (golint)
  • Line 109: warning: exported function TimeoutChecker should have comment or be unexported (golint)
  • Line 122: warning: exported function NeedsToInitK8sOnTke should have comment or be unexported (golint)
  • Line 136: warning: exported function GetKubeconfig should have comment or be unexported (golint)

• nocalhost/internal/nhctl/nocalhost/error.go
  • Line 18: warning: error var CreatePvcFailed should have name of the form ErrFoo (golint)
  • Line 18: warning: exported var CreatePvcFailed should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/pkg/cache/redis.go
  • Line 34: warning: comment on exported function NewRedisCache should be of the form "NewRedisCache ..." (golint)

• nocalhost/test/nhctlcli/nhctl.go
  • Line 19: warning: exported function NewNhctl should have comment or be unexported (golint)
  • Line 33: warning: exported function NewKubectl should have comment or be unexported (golint)
  • Line 42: warning: exported type Conf should have comment or be unexported (golint)
  • Line 48: warning: exported method Conf.GetKubeConfig should have comment or be unexported (golint)
  • Line 51: warning: exported method Conf.GetNamespace should have comment or be unexported (golint)
  • Line 54: warning: exported method Conf.GetCmd should have comment or be unexported (golint)

• nocalhost/internal/nhctl/nocalhost/leveldb.go
  • Line 20: warning: exported function ListAllFromApplicationDb should have comment or be unexported (golint)
  • Line 29: warning: exported function CompactApplicationDb should have comment or be unexported (golint)
  • Line 51: warning: exported function GetApplicationDbSize should have comment or be unexported (golint)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster/cluster.go
  • Line 17: warning: exported type CreateClusterRequest should have comment or be unexported (golint)
  • Line 23: warning: exported type KubeConfig should have comment or be unexported (golint)
  • Line 27: warning: exported type Clusters should have comment or be unexported (golint)
  • Line 32: warning: exported type Cluster should have comment or be unexported (golint)
  • Line 37: warning: exported type StorageClassRequest should have comment or be unexported (golint)
  • Line 41: warning: exported type StorageClassResponse should have comment or be unexported (golint)
  • Line 45: warning: exported type UpdateClusterRequest should have comment or be unexported (golint)
  • Line 49: warning: exported type ClusterDetailResponse should have comment or be unexported (golint)

• nocalhost/internal/nhctl/daemon_server/command/command.go
  • Line 20: warning: exported type DaemonCommandType should have comment or be unexported (golint)
  • Line 23: warning: exported const StartPortForward should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type BaseCommand should have comment or be unexported (golint)
  • Line 46: warning: exported type BaseResponse should have comment or be unexported (golint)
  • Line 53: warning: exported type PortForwardCommand should have comment or be unexported (golint)
  • Line 67: warning: exported type GetApplicationMetaCommand should have comment or be unexported (golint)
  • Line 76: warning: exported type GetApplicationMetasCommand should have comment or be unexported (golint)
  • Line 84: warning: exported type GetResourceInfoCommand should have comment or be unexported (golint)
  • Line 95: warning: exported function ParseBaseCommand should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/pvc_list.go
  • Line 30: warning: exported type PVCFlags should have comment or be unexported (golint)
  • Line 123: warning: exported function DisplayPVCsByYaml should have comment or be unexported (golint)
  • Line 130: warning: exported function DisplayPVCsByJson should have comment or be unexported (golint)
  • Line 137: warning: exported function DisplayPVCs should have comment or be unexported (golint)

• nocalhost/internal/nocalhost-api/model/init.go
  • Line 29: warning: exported var DB should have comment or be unexported (golint)
  • Line 31: warning: comment on exported function Init should be of the form "Init ..." (golint)
  • Line 78: warning: comment on exported function GetDB should be of the form "GetDB ..." (golint)
  • Line 83: warning: comment on exported function MigrateDB should be of the form "MigrateDB ..." (golint)

• nocalhost/internal/nhctl/resouce_cache/search.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 45: warning: exported type Searcher should have comment or be unexported (golint)
  • Line 52: warning: exported function GetSupportGroupVersionResource should have comment or be unexported (golint)
  • Line 104: warning: exported function GetSearcher should have comment or be unexported (golint)
  • Line 177: warning: exported method Searcher.Start should have comment or be unexported (golint)
  • Line 181: warning: exported method Searcher.Stop should have comment or be unexported (golint)
  • Line 185: warning: exported method Searcher.GetGvr should have comment or be unexported (golint)
  • Line 232: warning: exported function SortByNameAsc should have comment or be unexported (golint)
  • Line 238: warning: exported method Searcher.Criteria should have comment or be unexported (golint)

• nocalhost/internal/nhctl/watcher/commonWatcher.go
  • Line 26: warning: exported type Watcher should have comment or be unexported (golint)
  • Line 32: warning: exported type Controller should have comment or be unexported (golint)
  • Line 39: warning: exported function NewController should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nocalhost/pkg/nocalhost-api/conf/conf.go
  • Line 27: warning: exported var Conf should have comment or be unexported (golint)
  • Line 30: warning: comment on exported function Init should be of the form "Init ..." (golint)
  • Line 88: warning: comment on exported type AppConfig should be of the form "AppConfig ..." (with optional leading article) (golint)
  • Line 97: warning: comment on exported type LogConfig should be of the form "LogConfig ..." (with optional leading article) (golint)
  • Line 111: warning: comment on exported type MySQLConfig should be of the form "MySQLConfig ..." (with optional leading article) (golint)
  • Line 123: warning: comment on exported type RedisConfig should be of the form "RedisConfig ..." (with optional leading article) (golint)
  • Line 134: warning: comment on exported type CacheConfig should be of the form "CacheConfig ..." (with optional leading article) (golint)
  • Line 140: warning: comment on exported function InitLog should be of the form "InitLog ..." (golint)

• nocalhost/internal/nocalhost-api/model/application_user_model.go
  • Line 21: warning: comment on exported type ApplicationUserModel should be of the form "ApplicationUserModel ..." (with optional leading article) (golint)
  • Line 37: warning: comment on exported method ApplicationUserModel.TableName should be of the form "TableName ..." (golint)

• nocalhost/pkg/nocalhost-api/pkg/cache/driver.go
  • Line 20: warning: comment on exported const DefaultExpireTime should be of the form "DefaultExpireTime ..." (golint)
  • Line 26: warning: exported var Client should have comment or be unexported (golint)
  • Line 28: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported function Set should be of the form "Set ..." (golint)
  • Line 44: warning: comment on exported function Get should be of the form "Get ..." (golint)
  • Line 49: warning: comment on exported function MultiSet should be of the form "MultiSet ..." (golint)
  • Line 54: warning: comment on exported function MultiGet should be of the form "MultiGet ..." (golint)
  • Line 59: warning: comment on exported function Del should be of the form "Del ..." (golint)
  • Line 64: warning: comment on exported function Incr should be of the form "Incr ..." (golint)
  • Line 69: warning: comment on exported function Decr should be of the form "Decr ..." (golint)

• nocalhost/internal/nhctl/profile/svc_profile.go
  • Line 15: warning: exported type SvcProfile should have comment or be unexported (golint)

• nocalhost/cmd/nhctl/cmds/config_get.go
  • Line 69: warning: exported type ConfigForPlugin should have comment or be unexported (golint)

• nocalhost/internal/nhctl/app/exec.go
  • Line 21: warning: exported method Application.Exec should have comment or be unexported (golint)

• nocalhost/internal/nhctl/daemon_server/daemon.go
  • Line 13: warning: don't use an underscore in package name (golint)
  • Line 58: warning: exported function StartDaemon should have comment or be unexported (golint)
  • Line 287: warning: exported function Process should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign95%

IneffAssign detects ineffectual assignments in Go code.

• nocalhost/internal/nhctl/request/request.go
  • Line 417: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/app/git.go
  • Line 36: warning: ineffectual assignment to gitDirName (ineffassign)

• nocalhost/pkg/nocalhost-api/pkg/cache/memory.go
  • Line 91: warning: ineffectual assignment to val (ineffassign)

• nocalhost/pkg/nocalhost-api/pkg/clientgo/client.go
  • Line 1105: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/fp/filepath.go
  • Line 189: warning: ineffectual assignment to err (ineffassign)

• nocalhost/pkg/nocalhost-api/app/api/v1/cluster_user/dev_space.go
  • Line 96: warning: ineffectual assignment to err (ineffassign)
  • Line 143: warning: ineffectual assignment to err (ineffassign)
  • Line 183: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/controller/syncthing.go
  • Line 166: warning: ineffectual assignment to err (ineffassign)

• nocalhost/pkg/nhctl/clientgoutils/apply.go
  • Line 152: warning: ineffectual assignment to err (ineffassign)

• nocalhost/test/nhctlcli/testcase/init.go
  • Line 205: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/syncthing/network/req/syncthingHttpClient.go
  • Line 81: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/daemon_client/client.go
  • Line 204: warning: ineffectual assignment to err (ineffassign)
  • Line 222: warning: ineffectual assignment to err (ineffassign)

• nocalhost/internal/nhctl/appmeta_manager/application_secret_watcher.go
  • Line 72: warning: ineffectual assignment to devMetaCurrent (ineffassign)

• nocalhost/pkg/nocalhost-api/app/api/v1/user/delete.go
  • Line 48: warning: ineffectual assignment to err (ineffassign)

• nocalhost/test/nhctlcli/cmdrunner.go
  • Line 77: warning: ineffectual assignment to err (ineffassign)

misspell99%

Misspell Finds commonly misspelled English words

• nocalhost/internal/nocalhost-dep/webhook/webhook.go
  • Line 614: warning: "reponse" is a misspelling of "response" (misspell)