Go Report Card

Preparing report...

Report for github.com/noironetworks/aci-containers

A+    Excellent!    Found 135 issues across 454 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • aci-containers/pkg/hostagent/services.go
    • Line 663: warning: cyclomatic complexity 28 of function (*serviceEndpointSlice).SetOpflexService() is high (> 15) (gocyclo)
    • Line 322: warning: cyclomatic complexity 17 of function (*HostAgent).updateServiceDesc() is high (> 15) (gocyclo)
    • Line 582: warning: cyclomatic complexity 17 of function (*serviceEndpoint).SetOpflexService() is high (> 15) (gocyclo)
    • aci-containers/pkg/controller/services.go
    • Line 1081: warning: cyclomatic complexity 31 of function (*AciController).allocateServiceIps() is high (> 15) (gocyclo)
    • Line 1020: warning: cyclomatic complexity 19 of function (*AciController).writeApicSvc() is high (> 15) (gocyclo)
    • Line 912: warning: cyclomatic complexity 16 of function (*AciController).opflexDeviceChanged() is high (> 15) (gocyclo)
    • aci-containers/pkg/controller/nodes.go
    • Line 129: warning: cyclomatic complexity 19 of function (*AciController).createServiceEndpoint() is high (> 15) (gocyclo)
    • Line 331: warning: cyclomatic complexity 17 of function (*AciController).nodeChanged() is high (> 15) (gocyclo)
    • aci-containers/pkg/hostagent/snats.go
    • Line 950: warning: cyclomatic complexity 27 of function (*HostAgent).getMatchingSnatPolicy() is high (> 15) (gocyclo)
    • Line 581: warning: cyclomatic complexity 21 of function (*HostAgent).snaGlobalInfoChanged() is high (> 15) (gocyclo)
    • Line 694: warning: cyclomatic complexity 21 of function (*HostAgent).syncSnat() is high (> 15) (gocyclo)
    • Line 222: warning: cyclomatic complexity 18 of function (*HostAgent).snatPolicyUpdated() is high (> 15) (gocyclo)
    • Line 1049: warning: cyclomatic complexity 16 of function (*HostAgent).handleObjectUpdateForSnat() is high (> 15) (gocyclo)
    • aci-containers/pkg/controller/network_policy.go
    • Line 1062: warning: cyclomatic complexity 19 of function (*AciController).handleNetPolUpdate() is high (> 15) (gocyclo)
    • Line 1357: warning: cyclomatic complexity 17 of function (*serviceEndpoint).SetNpServiceAugmentForService() is high (> 15) (gocyclo)
    • Line 920: warning: cyclomatic complexity 16 of function (*AciController).getServiceAugmentByPort() is high (> 15) (gocyclo)
    • Line 661: warning: cyclomatic complexity 16 of function (*AciController).buildNetPolSubjRules() is high (> 15) (gocyclo)
    • aci-containers/pkg/apicapi/apicapi.go
    • Line 415: warning: cyclomatic complexity 20 of function (*ApicConnection).runConn() is high (> 15) (gocyclo)
    • Line 1168: warning: cyclomatic complexity 19 of function (*ApicConnection).subscribe() is high (> 15) (gocyclo)
    • Line 302: warning: cyclomatic complexity 17 of function (*ApicConnection).handleQueuedDn() is high (> 15) (gocyclo)

golint73%

Golint is a linter for Go source code.

    • aci-containers/pkg/metadata/cnimetadata.go
    • Line 26: warning: exported type ContainerIfaceIP should have comment or be unexported (golint)
    • Line 31: warning: exported type ContainerIfaceMd should have comment or be unexported (golint)
    • Line 39: warning: exported type ContainerId should have comment or be unexported (golint)
    • Line 45: warning: exported type ContainerMetadata should have comment or be unexported (golint)
    • Line 50: warning: exported function RecordMetadata should have comment or be unexported (golint)
    • Line 63: warning: exported function LoadMetadata should have comment or be unexported (golint)
    • Line 86: warning: exported function CheckMetadata should have comment or be unexported (golint)
    • Line 115: warning: exported function GetMetadata should have comment or be unexported (golint)
    • Line 128: warning: exported function ClearMetadata should have comment or be unexported (golint)
    • Line 133: warning: exported function GetIfaceNames should have comment or be unexported (golint)
    • aci-containers/pkg/hostagent/config.go
    • Line 36: warning: exported type OpflexServerConfig should have comment or be unexported (golint)
    • Line 41: warning: exported type GroupDefaults should have comment or be unexported (golint)
    • Line 64: warning: exported type HostAgentNodeConfig should have comment or be unexported (golint)
    • Line 84: warning: comment on exported type HostAgentConfig should be of the form "HostAgentConfig ..." (with optional leading article) (golint)
    • Line 232: warning: exported method HostAgentConfig.InitFlags should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/watchers/apic_watch_test.go
    • Line 82: warning: don't use underscores in Go names; var apic_epgA_obj should be apicEpgAObj (golint)
    • Line 117: warning: don't use underscores in Go names; var apic_contract_obj should be apicContractObj (golint)
    • Line 146: warning: don't use underscores in Go names; var apic_filter_obj should be apicFilterObj (golint)
    • Line 176: warning: don't use underscores in Go names; var gbp_epgA_obj should be gbpEpgAObj (golint)
    • Line 184: warning: don't use underscores in Go names; var gbp_epgA_obj_trim should be gbpEpgAObjTrim (golint)
    • Line 191: warning: don't use underscores in Go names; var gbp_contract should be gbpContract (golint)
    • aci-containers/pkg/gbpserver/watchers/k8s_watch_test.go
    • Line 29: warning: don't use underscores in Go names; type k8s_suite should be k8sSuite (golint)
    • Line 83: warning: don't use underscores in Go names; var k8s_epgA should be k8sEpgA (golint)
    • Line 88: warning: don't use underscores in Go names; var k8s_epgA_trim should be k8sEpgATrim (golint)
    • Line 93: warning: don't use underscores in Go names; var k8s_contract should be k8sContract (golint)
    • Line 97: warning: don't use underscores in Go names; var k8s_gbp_epgA should be k8sGbpEpgA (golint)
    • Line 104: warning: don't use underscores in Go names; var k8s_gbp_epgA_trim should be k8sGbpEpgATrim (golint)
    • aci-containers/pkg/util/common.go
    • Line 24: warning: exported function DeepCopyObj should have comment or be unexported (golint)
    • Line 36: warning: comment on exported function IsEndPointSlicesSupported should be of the form "IsEndPointSlicesSupported ..." (golint)
    • aci-containers/pkg/gbpserver/gbp_common.go
    • Line 99: warning: exported type BDSubnet should have comment or be unexported (golint)
    • Line 153: warning: exported method BDSubnet.SubnetsUri should have comment or be unexported (golint)
    • Line 157: warning: exported method BDSubnet.SnUri should have comment or be unexported (golint)
    • Line 162: warning: exported method BDSubnet.BDUri should have comment or be unexported (golint)
    • Line 166: warning: exported method BDSubnet.FDUri should have comment or be unexported (golint)
    • Line 169: warning: exported method BDSubnet.FDMcastUri should have comment or be unexported (golint)
    • Line 172: warning: exported method BDSubnet.FDToBDUri should have comment or be unexported (golint)
    • Line 176: warning: exported method BDSubnet.CreateSubnet should have comment or be unexported (golint)
    • Line 187: warning: exported method BDSubnet.CreateBD should have comment or be unexported (golint)
    • Line 192: warning: exported method BDSubnet.CreateFD should have comment or be unexported (golint)
    • Line 224: warning: exported method BDSubnet.Setup should have comment or be unexported (golint)
    • Line 230: warning: exported method BDSubnet.CreateEPG should have comment or be unexported (golint)
    • Line 262: warning: exported type GBPMo should have comment or be unexported (golint)
    • Line 511: warning: exported function CreateRoot should have comment or be unexported (golint)
    • aci-containers/pkg/snatpolicy/apis/aci.snat/v1/types.go
    • Line 7: warning: exported type PolicyState should have comment or be unexported (golint)
    • Line 10: warning: exported const Ready should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: exported type PodSelector should have comment or be unexported (golint)
    • Line 66: warning: comment on exported type PortRange should be of the form "PortRange ..." (with optional leading article) (golint)
    • aci-containers/pkg/util/nwpolicy.go
    • Line 25: warning: exported function GetNetPolPolicyTypes should have comment or be unexported (golint)
    • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/gbpserver/watchers/apic_watch.go
    • Line 36: warning: exported type ApicWatcher should have comment or be unexported (golint)
    • Line 50: warning: exported type ApicInfo should have comment or be unexported (golint)
    • Line 58: warning: exported function NewApicWatcher should have comment or be unexported (golint)
    • Line 104: warning: exported method ApicWatcher.Init should have comment or be unexported (golint)
    • Line 178: warning: exported method ApicWatcher.EpgChanged should have comment or be unexported (golint)
    • Line 189: warning: exported method ApicWatcher.ProcessEpg should have comment or be unexported (golint)
    • Line 241: warning: exported method ApicWatcher.EpgDeleted should have comment or be unexported (golint)
    • Line 280: warning: exported method ApicWatcher.ContractChanged should have comment or be unexported (golint)
    • Line 332: warning: exported method ApicWatcher.ContractDeleted should have comment or be unexported (golint)
    • Line 351: warning: exported method ApicWatcher.FilterChanged should have comment or be unexported (golint)
    • Line 391: warning: exported method ApicWatcher.FilterDeleted should have comment or be unexported (golint)
    • Line 396: warning: exported method ApicWatcher.NetPolChanged should have comment or be unexported (golint)
    • Line 422: warning: exported method ApicWatcher.NetPolDeleted should have comment or be unexported (golint)
    • aci-containers/pkg/nodeinfo/apis/aci.snat/v1/types.go
    • Line 11: warning: exported type NodeInfo should have comment or be unexported (golint)
    • Line 19: warning: exported type NodeInfoSpec should have comment or be unexported (golint)
    • Line 27: warning: comment on exported type NodeInfoStatus should be of the form "NodeInfoStatus ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported type NodeInfoList should be of the form "NodeInfoList ..." (with optional leading article) (golint)
    • aci-containers/pkg/ipam/ipalloc.go
    • Line 15: warning: package comment should be of the form "Package ipam ..." (golint)
    • Line 28: warning: comment on exported type IpRange should be of the form "IpRange ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported type IpAlloc should be of the form "IpAlloc ..." (with optional leading article) (golint)
    • Line 41: warning: comment on exported function New should be of the form "New ..." (golint)
    • Line 48: warning: comment on exported function NewFromRanges should be of the form "NewFromRanges ..." (golint)
    • Line 125: warning: comment on exported method IpAlloc.AddRange should be of the form "AddRange ..." (golint)
    • Line 163: warning: comment on exported method IpAlloc.AddIp should be of the form "AddIp ..." (golint)
    • Line 168: warning: comment on exported method IpAlloc.AddSubnet should be of the form "AddSubnet ..." (golint)
    • Line 199: warning: comment on exported method IpAlloc.RemoveRange should be of the form "RemoveRange ..." (golint)
    • Line 230: warning: comment on exported method IpAlloc.RemoveSubnet should be of the form "RemoveSubnet ..." (golint)
    • Line 235: warning: comment on exported method IpAlloc.RemoveIp should be of the form "RemoveIp ..." (golint)
    • Line 240: warning: comment on exported method IpAlloc.GetIp should be of the form "GetIp ..." (golint)
    • Line 258: warning: comment on exported method IpAlloc.GetIpChunk should be of the form "GetIpChunk ..." (golint)
    • Line 303: warning: comment on exported method IpAlloc.AddAll should be of the form "AddAll ..." (golint)
    • Line 308: warning: comment on exported method IpAlloc.AddRanges should be of the form "AddRanges ..." (golint)
    • Line 316: warning: comment on exported method IpAlloc.RemoveAll should be of the form "RemoveAll ..." (golint)
    • Line 321: warning: comment on exported method IpAlloc.RemoveRanges should be of the form "RemoveRanges ..." (golint)
    • Line 329: warning: comment on exported method IpAlloc.GetSize should be of the form "GetSize ..." (golint)
    • Line 342: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 347: warning: comment on exported method IpAlloc.Empty should be of the form "Empty ..." (golint)
    • Line 371: warning: comment on exported method IpAlloc.Intersect should be of the form "Intersect ..." (golint)
    • aci-containers/pkg/gbpserver/inventory.go
    • Line 47: warning: exported var InvDB should have comment or be unexported (golint)
    • Line 228: warning: exported function GetInvMoMap should have comment or be unexported (golint)
    • Line 242: warning: exported type Endpoint should have comment or be unexported (golint)
    • Line 280: warning: exported method Endpoint.Add should have comment or be unexported (golint)
    • Line 397: warning: exported method Endpoint.FromMo should have comment or be unexported (golint)
    • Line 443: warning: exported method Endpoint.Delete should have comment or be unexported (golint)
    • aci-containers/pkg/eprpcclient/eprpcclient.go
    • Line 28: warning: exported type Client should have comment or be unexported (golint)
    • Line 33: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 41: warning: exported method Client.Register should have comment or be unexported (golint)
    • Line 47: warning: exported method Client.Unregister should have comment or be unexported (golint)
    • Line 53: warning: exported type ResyncArgs should have comment or be unexported (golint)
    • Line 55: warning: exported method Client.Resync should have comment or be unexported (golint)
    • Line 61: warning: exported method Client.Close should have comment or be unexported (golint)
    • aci-containers/pkg/controller/subnetcache.go
    • Line 25: warning: exported method AciController.SubnetChanged should have comment or be unexported (golint)
    • Line 35: warning: exported method AciController.SubnetDeleted should have comment or be unexported (golint)
    • Line 46: warning: exported method AciController.UpdateSubnetDnCache should have comment or be unexported (golint)
    • Line 66: warning: exported method AciController.BuildSubnetDnCache should have comment or be unexported (golint)
    • aci-containers/pkg/apicapi/apic_types.go
    • Line 31: warning: exported type ApicObjectBody should have comment or be unexported (golint)
    • Line 36: warning: exported type ApicObject should have comment or be unexported (golint)
    • Line 38: warning: exported type ApicResponse should have comment or be unexported (golint)
    • Line 44: warning: exported type ApicObjectHandler should have comment or be unexported (golint)
    • Line 45: warning: exported type ApicDnHandler should have comment or be unexported (golint)
    • Line 47: warning: exported type ApicSlice should have comment or be unexported (golint)
    • Line 49: warning: exported const ApicNameAliasLength should have comment or be unexported (golint)
    • Line 83: warning: exported type ApicConnection should have comment or be unexported (golint)
    • Line 133: warning: exported method ApicConnection.GetDesiredState should have comment or be unexported (golint)
    • Line 177: warning: exported method ApicObject.GetDn should have comment or be unexported (golint)
    • Line 189: warning: exported method ApicObject.GetRn should have comment or be unexported (golint)
    • Line 200: warning: exported method ApicObject.BuildDn should have comment or be unexported (golint)
    • Line 215: warning: exported method ApicObject.GetTag should have comment or be unexported (golint)
    • Line 241: warning: exported method ApicObject.SetTag should have comment or be unexported (golint)
    • Line 272: warning: exported method ApicObject.SetAttr should have comment or be unexported (golint)
    • Line 283: warning: exported method ApicObject.GetAttr should have comment or be unexported (golint)
    • Line 293: warning: exported method ApicObject.GetAttrStr should have comment or be unexported (golint)
    • Line 308: warning: exported method ApicObject.AddChild should have comment or be unexported (golint)
    • Line 325: warning: exported function EmptyApicObject should have comment or be unexported (golint)
    • Line 334: warning: exported method ApicSlice.Copy should have comment or be unexported (golint)
    • Line 342: warning: exported method ApicObject.Copy should have comment or be unexported (golint)
    • Line 359: warning: exported function NewFvTenant should have comment or be unexported (golint)
    • Line 367: warning: exported function NewCloudAwsProvider should have comment or be unexported (golint)
    • Line 376: warning: exported function NewCloudCtxProfile should have comment or be unexported (golint)
    • Line 384: warning: exported function NewCloudRsToCtx should have comment or be unexported (golint)
    • Line 392: warning: exported function NewCloudRsCtxProfileToRegion should have comment or be unexported (golint)
    • Line 400: warning: exported function NewCloudCidr should have comment or be unexported (golint)
    • Line 408: warning: exported function NewCloudSubnet should have comment or be unexported (golint)
    • Line 416: warning: exported function NewFvCtx should have comment or be unexported (golint)
    • Line 424: warning: exported function NewFvBD should have comment or be unexported (golint)
    • Line 432: warning: exported function NewCloudApp should have comment or be unexported (golint)
    • Line 440: warning: exported function NewCloudEpg should have comment or be unexported (golint)
    • Line 448: warning: exported function NewFvSubnet should have comment or be unexported (golint)
    • Line 456: warning: exported function NewRsCtx should have comment or be unexported (golint)
    • Line 464: warning: exported function NewRsBdToOut should have comment or be unexported (golint)
    • Line 472: warning: exported function NewTagInst should have comment or be unexported (golint)
    • Line 480: warning: exported function NewTagAnnotation should have comment or be unexported (golint)
    • Line 493: warning: exported function NewHostprotPol should have comment or be unexported (golint)
    • Line 501: warning: exported function NewHostprotSubj should have comment or be unexported (golint)
    • Line 510: warning: exported function NewHostprotRule should have comment or be unexported (golint)
    • Line 519: warning: exported function NewHostprotRemoteIp should have comment or be unexported (golint)
    • Line 528: warning: exported function NewQosDppPol should have comment or be unexported (golint)
    • Line 537: warning: exported function NewQosRequirement should have comment or be unexported (golint)
    • Line 545: warning: exported function NewRsEgressDppPol should have comment or be unexported (golint)
    • Line 553: warning: exported function NewRsIngressDppPol should have comment or be unexported (golint)
    • Line 561: warning: exported function NewQosEpDscpMarking should have comment or be unexported (golint)
    • Line 569: warning: exported function NewVnsLDevVip should have comment or be unexported (golint)
    • Line 577: warning: exported function NewVnsRsALDevToPhysDomP should have comment or be unexported (golint)
    • Line 585: warning: exported function NewVnsLIf should have comment or be unexported (golint)
    • Line 593: warning: exported function NewVnsRsCIfAttN should have comment or be unexported (golint)
    • Line 601: warning: exported function NewVnsCDev should have comment or be unexported (golint)
    • Line 609: warning: exported function NewVnsCif should have comment or be unexported (golint)
    • Line 617: warning: exported function NewVnsRsCIfPathAtt should have comment or be unexported (golint)
    • Line 625: warning: exported function NewVnsAbsGraph should have comment or be unexported (golint)
    • Line 633: warning: exported function NewVnsAbsTermNodeCon should have comment or be unexported (golint)
    • Line 641: warning: exported function NewVnsAbsTermNodeProv should have comment or be unexported (golint)
    • Line 649: warning: exported function NewVnsAbsTermConn should have comment or be unexported (golint)
    • Line 656: warning: exported function NewVnsInTerm should have comment or be unexported (golint)
    • Line 663: warning: exported function NewVnsOutTerm should have comment or be unexported (golint)
    • Line 670: warning: exported function NewVnsAbsConnection should have comment or be unexported (golint)
    • Line 678: warning: exported function NewVnsRsAbsConnectionConns should have comment or be unexported (golint)
    • Line 686: warning: exported function NewVnsAbsNode should have comment or be unexported (golint)
    • Line 694: warning: exported function NewVnsAbsFuncConn should have comment or be unexported (golint)
    • Line 702: warning: exported function NewVnsRsNodeToLDev should have comment or be unexported (golint)
    • Line 710: warning: exported function NewVnsSvcRedirectPol should have comment or be unexported (golint)
    • Line 718: warning: exported function NewVnsRedirectDest should have comment or be unexported (golint)
    • Line 727: warning: exported function NewFvIPSLAMonitoringPol should have comment or be unexported (golint)
    • Line 735: warning: exported function NewVnsRsIPSLAMonitoringPol should have comment or be unexported (golint)
    • Line 743: warning: exported function NewVnsRedirectHealthGroup should have comment or be unexported (golint)
    • Line 751: warning: exported function NewVnsRsRedirectHealthGroup should have comment or be unexported (golint)
    • Line 759: warning: exported function NewVnsLDevCtx should have comment or be unexported (golint)
    • Line 771: warning: exported function NewVnsRsLDevCtxToLDev should have comment or be unexported (golint)
    • Line 779: warning: exported function NewVnsLIfCtx should have comment or be unexported (golint)
    • Line 787: warning: exported function NewVnsRsLIfCtxToSvcRedirectPol should have comment or be unexported (golint)
    • Line 795: warning: exported function NewVnsRsLIfCtxToBD should have comment or be unexported (golint)
    • Line 803: warning: exported function NewVnsRsLIfCtxToLIf should have comment or be unexported (golint)
    • Line 811: warning: exported function NewVzBrCP should have comment or be unexported (golint)
    • Line 819: warning: exported function NewVzSubj should have comment or be unexported (golint)
    • Line 827: warning: exported function NewVzInTerm should have comment or be unexported (golint)
    • Line 834: warning: exported function NewVzOutTerm should have comment or be unexported (golint)
    • Line 841: warning: exported function NewVzRsFiltAtt should have comment or be unexported (golint)
    • Line 849: warning: exported function NewVzRsInTermGraphAtt should have comment or be unexported (golint)
    • Line 857: warning: exported function NewVzRsOutTermGraphAtt should have comment or be unexported (golint)
    • Line 865: warning: exported function NewVzRsSubjFiltAtt should have comment or be unexported (golint)
    • Line 873: warning: exported function NewVzRsSubjGraphAtt should have comment or be unexported (golint)
    • Line 881: warning: exported function NewVzFilter should have comment or be unexported (golint)
    • Line 889: warning: exported function NewVzEntry should have comment or be unexported (golint)
    • Line 897: warning: exported function NewL3extInstP should have comment or be unexported (golint)
    • Line 905: warning: exported function NewL3extSubnet should have comment or be unexported (golint)
    • Line 913: warning: exported function NewFvRsProv should have comment or be unexported (golint)
    • Line 921: warning: exported function NewFvRsCons should have comment or be unexported (golint)
    • Line 929: warning: exported function NewVmmInjectedContGrp should have comment or be unexported (golint)
    • Line 940: warning: exported function NewVmmInjectedDepl should have comment or be unexported (golint)
    • Line 952: warning: exported function NewVmmInjectedReplSet should have comment or be unexported (golint)
    • Line 964: warning: exported function NewVmmInjectedSvc should have comment or be unexported (golint)
    • Line 976: warning: exported function NewVmmInjectedSvcEp should have comment or be unexported (golint)
    • Line 984: warning: exported function NewVmmInjectedSvcPort should have comment or be unexported (golint)
    • Line 999: warning: exported function NewVmmInjectedHost should have comment or be unexported (golint)
    • Line 1011: warning: exported function NewVmmInjectedNs should have comment or be unexported (golint)
    • Line 1023: warning: exported function NewVmmInjectedNwPol should have comment or be unexported (golint)
    • Line 1035: warning: exported function NewVmmInjectedOrg should have comment or be unexported (golint)
    • Line 1045: warning: exported function NewVmmInjectedOrgUnit should have comment or be unexported (golint)
    • Line 1055: warning: exported function NewVmmInjectedOrgUnitContGrp should have comment or be unexported (golint)
    • Line 1065: warning: exported function NewVmmInjectedOrgUnitDepl should have comment or be unexported (golint)
    • Line 1075: warning: exported function NewInfra should have comment or be unexported (golint)
    • Line 1082: warning: exported function NewNetflowVmmExporterPol should have comment or be unexported (golint)
    • Line 1091: warning: exported function NewVmmVSwitchPolicyCont should have comment or be unexported (golint)
    • Line 1098: warning: exported function NewVmmRsVswitchExporterPol should have comment or be unexported (golint)
    • Line 1106: warning: exported function NewSpanVSrcGrp should have comment or be unexported (golint)
    • Line 1114: warning: exported function NewSpanVSrc should have comment or be unexported (golint)
    • Line 1122: warning: exported function NewSpanRsSrcToVPort should have comment or be unexported (golint)
    • Line 1129: warning: exported function NewSpanVDestGrp should have comment or be unexported (golint)
    • Line 1137: warning: exported function NewSpanVDest should have comment or be unexported (golint)
    • Line 1145: warning: exported function NewSpanVEpgSummary should have comment or be unexported (golint)
    • Line 1151: warning: exported function NewSpanSpanLbl should have comment or be unexported (golint)
    • Line 1159: warning: exported function NewInfraAccBndlGrp should have comment or be unexported (golint)
    • Line 1167: warning: exported function NewInfraAccPortGrp should have comment or be unexported (golint)
    • Line 1175: warning: exported function NewInfraRsSpanVSrcGrp should have comment or be unexported (golint)
    • Line 1183: warning: exported function NewInfraRsSpanVDestGrp should have comment or be unexported (golint)
    • Line 1191: warning: exported function NewInfraRsSpanVSrcGrpAP should have comment or be unexported (golint)
    • Line 1199: warning: exported function NewInfraRsSpanVDestGrpAP should have comment or be unexported (golint)
    • Line 1207: warning: exported function NewVmmInjectedClusterInfo should have comment or be unexported (golint)
    • Line 1215: warning: exported function NewVmmClusterFaultInfo should have comment or be unexported (golint)
    • Line 1221: warning: exported function NewVmmInjectedLabel should have comment or be unexported (golint)
    • aci-containers/pkg/hostagent/eprpc.go
    • Line 29: warning: exported type EpRPC should have comment or be unexported (golint)
    • Line 73: warning: exported function NewEpRPC should have comment or be unexported (golint)
    • Line 80: warning: exported method EpRPC.Register should have comment or be unexported (golint)
    • Line 102: warning: exported method EpRPC.Unregister should have comment or be unexported (golint)
    • Line 126: warning: exported type ResyncArgs should have comment or be unexported (golint)
    • Line 128: warning: exported method EpRPC.Resync should have comment or be unexported (golint)
    • aci-containers/pkg/controller/version.go
    • Line 26: warning: comment on exported type VersionInfo should be of the form "VersionInfo ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported function GetVersion should be of the form "GetVersion ..." (golint)
    • Line 41: warning: comment on exported function VersionString should be of the form "VersionString ..." (golint)
    • aci-containers/pkg/objdb/etcd_client.go
    • Line 30: warning: exported type API should have comment or be unexported (golint)
    • Line 50: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 107: warning: exported method EtcdClient.GetRaw should have comment or be unexported (golint)
    • Line 122: warning: comment on exported method EtcdClient.SetObj should be of the form "SetObj ..." (golint)
    • Line 135: warning: exported method EtcdClient.SetRaw should have comment or be unexported (golint)
    • aci-containers/pkg/ipam/ipcache.go
    • Line 15: warning: package comment should be of the form "Package ipam ..." (golint)
    • Line 26: warning: comment on exported type IpCache should be of the form "IpCache ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported function NewIpCache should be of the form "NewIpCache ..." (golint)
    • Line 41: warning: comment on exported method IpCache.AllocateIp should be of the form "AllocateIp ..." (golint)
    • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 73: warning: comment on exported method IpCache.DeallocateIp should be of the form "DeallocateIp ..." (golint)
    • Line 82: warning: comment on exported method IpCache.LoadRanges should be of the form "LoadRanges ..." (golint)
    • Line 96: warning: comment on exported method IpCache.RemoveIp should be of the form "RemoveIp ..." (golint)
    • Line 116: warning: comment on exported method IpCache.CombineV4 should be of the form "CombineV4 ..." (golint)
    • Line 126: warning: comment on exported method IpCache.CombineV6 should be of the form "CombineV6 ..." (golint)
    • Line 136: warning: exported method IpCache.GetV4IpCache should have comment or be unexported (golint)
    • Line 140: warning: exported method IpCache.GetV6IpCache should have comment or be unexported (golint)
    • Line 144: warning: comment on exported function HasIp should be of the form "HasIp ..." (golint)
    • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 161: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/controller/config.go
    • Line 27: warning: exported type OpflexGroup should have comment or be unexported (golint)
    • Line 32: warning: comment on exported type ControllerConfig should be of the form "ControllerConfig ..." (with optional leading article) (golint)
    • Line 220: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 234: warning: exported function InitFlags should have comment or be unexported (golint)
    • aci-containers/pkg/controller/services.go
    • Line 38: warning: comment on exported const DefaultServiceContractScope should be of the form "DefaultServiceContractScope ..." (golint)
    • Line 41: warning: comment on exported const DefaultServiceExtSubNetShared should be of the form "DefaultServiceExtSubNetShared ..." (golint)
    • Line 473: warning: don't use underscores in Go names; func parameter p_start should be pStart (golint)
    • Line 474: warning: don't use underscores in Go names; func parameter p_end should be pEnd (golint)
    • Line 516: warning: don't use underscores in Go names; var p_start should be pStart (golint)
    • Line 517: warning: don't use underscores in Go names; var p_end should be pEnd (golint)
    • Line 535: warning: don't use underscores in Go names; var p_start should be pStart (golint)
    • Line 536: warning: don't use underscores in Go names; var p_end should be pEnd (golint)
    • Line 571: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1182: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/metrics/pod_stats.go
    • Line 26: warning: exported type Tuple should have comment or be unexported (golint)
    • Line 34: warning: exported type PodStatsType should have comment or be unexported (golint)
    • Line 40: warning: exported type StatsRec should have comment or be unexported (golint)
    • Line 47: warning: exported type PodStatsObj should have comment or be unexported (golint)
    • Line 55: warning: exported function NewPodStats should have comment or be unexported (golint)
    • Line 99: warning: exported method PodStatsObj.StatsUpdate should have comment or be unexported (golint)
    • Line 123: warning: exported method PodStatsObj.UpdatePodMeta should have comment or be unexported (golint)
    • aci-containers/pkg/hostagent/pods.go
    • Line 48: warning: exported const NullMac should have comment or be unexported (golint)
    • Line 75: warning: exported method HostAgent.EPRegAdd should have comment or be unexported (golint)
    • Line 121: warning: exported method HostAgent.EPRegDelEP should have comment or be unexported (golint)
    • Line 254: warning: exported method HostAgent.FormEPFilePath should have comment or be unexported (golint)
    • Line 416: warning: don't use underscores in Go names; var ep_file_exists should be epFileExists (golint)
    • aci-containers/pkg/controller/qos_test.go
    • Line 212: warning: don't use underscores in Go names; var rule_0_0 should be rule0_0 (golint)
    • Line 219: warning: don't use underscores in Go names; var rule_1_0 should be rule1_0 (golint)
    • Line 225: warning: don't use underscores in Go names; var rule_2_0 should be rule2_0 (golint)
    • aci-containers/pkg/hostagent/snats.go
    • Line 48: warning: comment on exported const SnatService should be of the form "SnatService ..." (golint)
    • Line 52: warning: exported type ResourceType should have comment or be unexported (golint)
    • Line 55: warning: exported const POD should have comment (or a comment on this block) or be unexported (golint)
    • Line 63: warning: exported type OpflexPortRange should have comment or be unexported (golint)
    • Line 68: warning: comment on exported type OpflexSnatIp should be of the form "OpflexSnatIp ..." (with optional leading article) (golint)
    • Line 82: warning: comment on exported type OpflexSnatIpRemoteInfo should be of the form "OpflexSnatIpRemoteInfo ..." (with optional leading article) (golint)
    • Line 143: warning: exported method HostAgent.FormSnatFilePath should have comment or be unexported (golint)
    • Line 147: warning: exported function SnatGlobalInfoLogger should have comment or be unexported (golint)
    • Line 626: warning: don't use underscores in Go names; var file_exists should be fileExists (golint)
    • Line 931: warning: don't use underscores in Go names; var ip_temp should be ipTemp (golint)
    • Line 936: warning: don't use underscores in Go names; var ip_temp should be ipTemp (golint)
    • Line 1182: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1192: warning: don't use underscores in Go names; var ip_temp should be ipTemp (golint)
    • aci-containers/pkg/snatlocalinfo/apis/aci.snat/v1/types.go
    • Line 15: warning: comment on exported type SnatLocalInfo should be of the form "SnatLocalInfo ..." (with optional leading article) (golint)
    • Line 25: warning: comment on exported type SnatLocalInfoList should be of the form "SnatLocalInfoList ..." (with optional leading article) (golint)
    • Line 33: warning: exported type SnatPolicy should have comment or be unexported (golint)
    • Line 39: warning: exported type LocalInfo should have comment or be unexported (golint)
    • aci-containers/pkg/metrics/prom_exporter.go
    • Line 40: warning: exported function InitPromExporter should have comment or be unexported (golint)
    • Line 47: warning: exported method PodStatsObj.Describe should have comment or be unexported (golint)
    • Line 51: warning: exported method PodStatsObj.Collect should have comment or be unexported (golint)
    • aci-containers/pkg/testutil/testutil.go
    • Line 25: warning: comment on exported function WaitFor should be of the form "WaitFor ..." (golint)
    • Line 48: warning: comment on exported function WaitForComp should be of the form "WaitForComp ..." (golint)
    • Line 72: warning: comment on exported function WaitNil should be of the form "WaitNil ..." (golint)
    • Line 82: warning: comment on exported function WaitNotNil should be of the form "WaitNotNil ..." (golint)
    • Line 91: warning: comment on exported function WaitCondition should be of the form "WaitCondition ..." (golint)
    • Line 101: warning: comment on exported function WaitEqual should be of the form "WaitEqual ..." (golint)
    • Line 111: warning: comment on exported function WaitNotEqual should be of the form "WaitNotEqual ..." (golint)
    • aci-containers/pkg/util/iputil.go
    • Line 19: warning: comment on exported function GetIPsFromCIDR should be of the form "GetIPsFromCIDR ..." (golint)
    • Line 25: warning: don't use underscores in Go names; var ip_temp should be ipTemp (golint)
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 48: warning: comment on exported function SetDifferenceIPs should be of the form "SetDifferenceIPs ..." (golint)
    • Line 54: warning: comment on exported function DrawIP should be of the form "DrawIP ..." (golint)
    • Line 59: warning: comment on exported function ExpandCIDRs should be of the form "ExpandCIDRs ..." (golint)
    • aci-containers/pkg/hostagent/setup.go
    • Line 34: warning: exported function StartPlugin should have comment or be unexported (golint)
    • Line 51: warning: exported var PluginCloner should have comment or be unexported (golint)
    • Line 78: warning: exported type ClientRPC should have comment or be unexported (golint)
    • Line 80: warning: exported type SetupVethArgs should have comment or be unexported (golint)
    • Line 87: warning: exported type SetupVethResult should have comment or be unexported (golint)
    • Line 100: warning: exported method ClientRPC.SetupVeth should have comment or be unexported (golint)
    • Line 138: warning: exported type ClearVethArgs should have comment or be unexported (golint)
    • Line 150: warning: exported method ClientRPC.ClearVeth should have comment or be unexported (golint)
    • Line 178: warning: exported type SetupNetworkArgs should have comment or be unexported (golint)
    • Line 193: warning: exported method ClientRPC.SetupNetwork should have comment or be unexported (golint)
    • Line 302: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/gbpserver/kafkac/client.go
    • Line 1: warning: package comment should be of the form "Package kafkac ..." (golint)
    • Line 37: warning: exported type KafkaClient should have comment or be unexported (golint)
    • Line 60: warning: exported type CloudInfo should have comment or be unexported (golint)
    • Line 69: warning: exported type KafkaCfg should have comment or be unexported (golint)
    • Line 81: warning: exported type CapicEPMsg should have comment or be unexported (golint)
    • Line 94: warning: exported function InitKafkaClient should have comment or be unexported (golint)
    • Line 137: warning: exported method KafkaClient.UpdateEpgDN should have comment or be unexported (golint)
    • Line 156: warning: exported method KafkaClient.AddEP should have comment or be unexported (golint)
    • Line 183: warning: exported method KafkaClient.DeleteEP should have comment or be unexported (golint)
    • Line 226: warning: exported function GetClientConfig should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/watchers/k8s_statedriver.go
    • Line 32: warning: exported const FieldClassID should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported method K8sStateDriver.StateExists should have comment or be unexported (golint)
    • Line 63: warning: exported method K8sStateDriver.Init should have comment or be unexported (golint)
    • Line 115: warning: exported method K8sStateDriver.Get should have comment or be unexported (golint)
    • Line 126: warning: exported method K8sStateDriver.Update should have comment or be unexported (golint)
    • aci-containers/pkg/qospolicy/apis/aci.qos/v1/types.go
    • Line 7: warning: exported type PolicyState should have comment or be unexported (golint)
    • Line 10: warning: exported const Ready should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: comment on exported type PolicingType should be of the form "PolicingType ..." (with optional leading article) (golint)
    • Line 54: warning: comment on exported type QosPolicy should be of the form "QosPolicy ..." (with optional leading article) (golint)
    • Line 72: warning: exported type PodSelector should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/gbp.go
    • Line 43: warning: exported const RdClassID should have comment (or a comment on this block) or be unexported (golint)
    • Line 195: warning: exported type GBPEpGroup should have comment or be unexported (golint)
    • Line 199: warning: exported method GBPEpGroup.Make should have comment or be unexported (golint)
    • Line 216: warning: exported method GBPEpGroup.Validate should have comment or be unexported (golint)
    • Line 220: warning: exported type GBPBridgeDomain should have comment or be unexported (golint)
    • Line 224: warning: exported method GBPBridgeDomain.Make should have comment or be unexported (golint)
    • Line 269: warning: exported method GBPBridgeDomain.Validate should have comment or be unexported (golint)
    • Line 273: warning: exported method GBPBridgeDomain.AddSubnet should have comment or be unexported (golint)
    • Line 277: warning: exported type GBPeInstContext should have comment or be unexported (golint)
    • Line 281: warning: exported method GBPeInstContext.Make should have comment or be unexported (golint)
    • Line 288: warning: exported method GBPeInstContext.Validate should have comment or be unexported (golint)
    • Line 339: warning: exported type GBPBDToVrf should have comment or be unexported (golint)
    • Line 342: warning: exported type GBPBDToSubnets should have comment or be unexported (golint)
    • Line 345: warning: exported type GBPEPGToFD should have comment or be unexported (golint)
    • Line 348: warning: exported type GBPFDToBD should have comment or be unexported (golint)
    • Line 351: warning: exported type GBPEPGToSnet should have comment or be unexported (golint)
    • Line 354: warning: exported type GBPRuleToClass should have comment or be unexported (golint)
    • Line 357: warning: exported type GBPRuleToAct should have comment or be unexported (golint)
    • Line 361: warning: exported type GBPContract should have comment or be unexported (golint)
    • Line 365: warning: exported method GBPContract.Make should have comment or be unexported (golint)
    • Line 373: warning: exported method GBPContract.Validate should have comment or be unexported (golint)
    • Line 380: warning: exported type GBPSubject should have comment or be unexported (golint)
    • Line 384: warning: exported method GBPSubject.Make should have comment or be unexported (golint)
    • Line 392: warning: exported method GBPSubject.Validate should have comment or be unexported (golint)
    • Line 396: warning: exported type GBPRule should have comment or be unexported (golint)
    • Line 400: warning: exported method GBPRule.Make should have comment or be unexported (golint)
    • Line 408: warning: exported method GBPRule.Validate should have comment or be unexported (golint)
    • Line 412: warning: exported type GBPClassifierRsrc should have comment or be unexported (golint)
    • Line 416: warning: exported method GBPClassifierRsrc.Make should have comment or be unexported (golint)
    • Line 424: warning: exported method GBPClassifierRsrc.Validate should have comment or be unexported (golint)
    • Line 428: warning: exported type GBPL24Classifier should have comment or be unexported (golint)
    • Line 432: warning: exported method GBPL24Classifier.Make should have comment or be unexported (golint)
    • Line 439: warning: exported method GBPL24Classifier.Validate should have comment or be unexported (golint)
    • Line 443: warning: exported type GBPAction should have comment or be unexported (golint)
    • Line 447: warning: exported method GBPAction.Make should have comment or be unexported (golint)
    • Line 456: warning: exported method GBPAction.Validate should have comment or be unexported (golint)
    • Line 460: warning: exported type GBPRoutingDomain should have comment or be unexported (golint)
    • Line 495: warning: exported method GBPRoutingDomain.Make should have comment or be unexported (golint)
    • Line 513: warning: exported method GBPRoutingDomain.Validate should have comment or be unexported (golint)
    • Line 513: warning: receiver name a should be consistent with previous receiver name rd for GBPRoutingDomain (golint)
    • Line 517: warning: exported type GBPVrfIntSubnet should have comment or be unexported (golint)
    • Line 521: warning: exported method GBPVrfIntSubnet.Make should have comment or be unexported (golint)
    • Line 528: warning: exported method GBPVrfIntSubnet.Validate should have comment or be unexported (golint)
    • Line 532: warning: exported type GBPSubnetSet should have comment or be unexported (golint)
    • Line 536: warning: exported method GBPSubnetSet.Make should have comment or be unexported (golint)
    • Line 544: warning: exported method GBPSubnetSet.Validate should have comment or be unexported (golint)
    • Line 548: warning: exported type GBPSubnet should have comment or be unexported (golint)
    • Line 552: warning: exported method GBPSubnet.Make should have comment or be unexported (golint)
    • Line 575: warning: exported method GBPSubnet.Validate should have comment or be unexported (golint)
    • Line 579: warning: exported type GBPFloodDomain should have comment or be unexported (golint)
    • Line 583: warning: exported method GBPFloodDomain.Make should have comment or be unexported (golint)
    • Line 591: warning: exported method GBPFloodDomain.Validate should have comment or be unexported (golint)
    • Line 591: warning: receiver name ss should be consistent with previous receiver name fd for GBPFloodDomain (golint)
    • Line 595: warning: exported type GBPFloodMcast should have comment or be unexported (golint)
    • Line 599: warning: exported method GBPFloodMcast.Make should have comment or be unexported (golint)
    • Line 606: warning: exported method GBPFloodMcast.Validate should have comment or be unexported (golint)
    • Line 606: warning: receiver name ss should be consistent with previous receiver name fm for GBPFloodMcast (golint)
    • Line 610: warning: exported function CreateDefVrf should have comment or be unexported (golint)
    • Line 616: warning: comment on exported method Server.InitDB should be of the form "InitDB ..." (golint)
    • Line 744: warning: exported function DoAll should have comment or be unexported (golint)
    • Line 830: warning: exported function SendDefaultsToAPIC should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/version.go
    • Line 26: warning: comment on exported type VersionInfo should be of the form "VersionInfo ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported function GetVersion should be of the form "GetVersion ..." (golint)
    • Line 41: warning: comment on exported function VersionString should be of the form "VersionString ..." (golint)
    • aci-containers/pkg/apicapi/apicapi.go
    • Line 15: warning: package comment should be of the form "Package apicapi ..." (golint)
    • Line 184: warning: exported function New should have comment or be unexported (golint)
    • Line 544: warning: exported method ApicConnection.GetVersion should have comment or be unexported (golint)
    • Line 617: warning: don't use underscores in Go names; var version_split should be versionSplit (golint)
    • Line 618: warning: don't use underscores in Go names; var version_number should be versionNumber (golint)
    • Line 630: warning: exported method ApicConnection.Run should have comment or be unexported (golint)
    • Line 765: warning: comment on exported method ApicConnection.ValidateAciVrfAssociation should be of the form "ValidateAciVrfAssociation ..." (golint)
    • Line 895: warning: exported method ApicConnection.ForceRelogin should have comment or be unexported (golint)
    • Line 899: warning: exported method ApicConnection.PostTestAPI should have comment or be unexported (golint)
    • Line 936: warning: exported method ApicConnection.PostDnInline should have comment or be unexported (golint)
    • Line 973: warning: exported method ApicConnection.DeleteDnInline should have comment or be unexported (golint)
    • Line 1024: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1031: warning: exported method ApicConnection.DeleteDn should have comment or be unexported (golint)
    • Line 1103: warning: exported method ApicConnection.AddSubscriptionClass should have comment or be unexported (golint)
    • Line 1116: warning: exported method ApicConnection.AddSubscriptionDn should have comment or be unexported (golint)
    • Line 1128: warning: exported method ApicConnection.SetSubscriptionHooks should have comment or be unexported (golint)
    • Line 1139: warning: exported method ApicConnection.GetApicResponse should have comment or be unexported (golint)
    • Line 1186: warning: don't use underscores in Go names; var refresh_interval should be refreshInterval (golint)
    • aci-containers/pkg/controller/snats.go
    • Line 36: warning: exported type ContPodSelector should have comment or be unexported (golint)
    • Line 41: warning: exported type ContPortRange should have comment or be unexported (golint)
    • Line 46: warning: exported type ContSnatPolicy should have comment or be unexported (golint)
    • Line 55: warning: exported function SnatPolicyLogger should have comment or be unexported (golint)
    • Line 280: warning: don't use underscores in Go names; var cr_labels should be crLabels (golint)
    • Line 281: warning: don't use underscores in Go names; var cr_ns should be crNs (golint)
    • Line 330: warning: don't use underscores in Go names; var ip_temp should be ipTemp (golint)
    • aci-containers/pkg/util/snat.go
    • Line 32: warning: exported type StartSorter should have comment or be unexported (golint)
    • Line 38: warning: exported const PORTPERNODES should have comment or be unexported (golint)
    • Line 39: warning: exported const MIN_PORT should have comment or be unexported (golint)
    • Line 40: warning: exported const MAX_PORT should have comment or be unexported (golint)
    • Line 42: warning: comment on exported function ExpandPortRanges should be of the form "ExpandPortRanges ..." (golint)
    • Line 63: warning: comment on exported function CreateSnatGlobalInfoCR should be of the form "CreateSnatGlobalInfoCR ..." (golint)
    • Line 81: warning: comment on exported function UpdateGlobalInfoCR should be of the form "UpdateGlobalInfoCR ..." (golint)
    • Line 91: warning: exported function GetGlobalInfoCR should have comment or be unexported (golint)
    • Line 128: warning: comment on exported function DeleteNodeInfoCR should be of the form "DeleteNodeInfoCR ..." (golint)
    • Line 138: warning: exported function GetPortRangeFromConfigMap should have comment or be unexported (golint)
    • Line 159: warning: exported function MatchLabels should have comment or be unexported (golint)
    • Line 175: warning: comment on exported function UpdateSnatPolicyCR should be of the form "UpdateSnatPolicyCR ..." (golint)
    • aci-containers/pkg/loadbalancer/nslb.go
    • Line 33: warning: exported type LBProvider should have comment or be unexported (golint)
    • Line 38: warning: exported type NSLoadBalancer should have comment or be unexported (golint)
    • Line 47: warning: exported function NewNSLB should have comment or be unexported (golint)
    • Line 71: warning: exported method NSLoadBalancer.Stop should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/watchers/ep_sync.go
    • Line 41: warning: exported type EPSyncer should have comment or be unexported (golint)
    • Line 51: warning: exported method EPSyncer.Init should have comment or be unexported (golint)
    • Line 70: warning: exported method EPSyncer.Run should have comment or be unexported (golint)
    • Line 84: warning: don't use underscores in Go names; var l_epgs should be lEpgs (golint)
    • Line 86: warning: don't use underscores in Go names; var r_epgs should be rEpgs (golint)
    • Line 111: warning: don't use underscores in Go names; var c_dns should be cDNS (golint)
    • Line 121: warning: don't use underscores in Go names; var r_epgs should be rEpgs (golint)
    • Line 135: warning: don't use underscores in Go names; method parameter r_epgs should be rEpgs (golint)
    • Line 181: warning: exported method EPSyncer.AddExtEP should have comment or be unexported (golint)
    • Line 185: warning: don't use underscores in Go names; var pi_name should be piName (golint)
    • aci-containers/pkg/metadata/annotations.go
    • Line 23: warning: comment on exported type OpflexGroup should be of the form "OpflexGroup ..." (with optional leading article) (golint)
    • Line 33: warning: comment on exported type ServiceEndpoint should be of the form "ServiceEndpoint ..." (with optional leading article) (golint)
    • Line 41: warning: comment on exported type NetIps should be of the form "NetIps ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported const ServiceEpAnnotation should be of the form "ServiceEpAnnotation ..." (golint)
    • Line 50: warning: comment on exported const ServiceContractScopeAnnotation should be of the form "ServiceContractScopeAnnotation ..." (golint)
    • Line 53: warning: comment on exported const PodNetworkRangeAnnotation should be of the form "PodNetworkRangeAnnotation ..." (golint)
    • Line 56: warning: comment on exported const EgAnnotation should be of the form "EgAnnotation ..." (golint)
    • Line 59: warning: comment on exported const SgAnnotation should be of the form "SgAnnotation ..." (golint)
    • Line 62: warning: comment on exported const QpAnnotation should be of the form "QpAnnotation ..." (golint)
    • Line 65: warning: comment on exported const CompEgAnnotation should be of the form "CompEgAnnotation ..." (golint)
    • Line 68: warning: comment on exported const CompSgAnnotation should be of the form "CompSgAnnotation ..." (golint)
    • aci-containers/pkg/controller/environment.go
    • Line 44: warning: exported type Environment should have comment or be unexported (golint)
    • Line 56: warning: exported type K8sEnvironment should have comment or be unexported (golint)
    • Line 67: warning: exported function NewK8sEnvironment should have comment or be unexported (golint)
    • Line 126: warning: exported method K8sEnvironment.RESTConfig should have comment or be unexported (golint)
    • Line 130: warning: exported method K8sEnvironment.VmmPolicy should have comment or be unexported (golint)
    • Line 134: warning: exported method K8sEnvironment.OpFlexDeviceType should have comment or be unexported (golint)
    • Line 142: warning: exported method K8sEnvironment.ServiceBd should have comment or be unexported (golint)
    • Line 146: warning: exported method K8sEnvironment.Init should have comment or be unexported (golint)
    • Line 189: warning: exported method K8sEnvironment.InitStaticAciObjects should have comment or be unexported (golint)
    • Line 194: warning: exported method K8sEnvironment.NodePodNetworkChanged should have comment or be unexported (golint)
    • Line 198: warning: exported method K8sEnvironment.NodeServiceChanged should have comment or be unexported (golint)
    • Line 204: warning: exported method K8sEnvironment.PrepareRun should have comment or be unexported (golint)
    • aci-containers/pkg/apicapi/apic_sync.go
    • Line 207: warning: exported function PrepareApicSlice should have comment or be unexported (golint)
    • Line 368: warning: exported method ApicConnection.ClearApicContainer should have comment or be unexported (golint)
    • Line 372: warning: exported method ApicConnection.WriteApicContainer should have comment or be unexported (golint)
    • Line 376: warning: exported method ApicConnection.ClearApicObjects should have comment or be unexported (golint)
    • Line 380: warning: exported method ApicConnection.WriteApicObjects should have comment or be unexported (golint)
    • aci-containers/pkg/hostagent/environment.go
    • Line 37: warning: exported type Environment should have comment or be unexported (golint)
    • Line 47: warning: exported type K8sEnvironment should have comment or be unexported (golint)
    • Line 62: warning: exported function NewK8sEnvironment should have comment or be unexported (golint)
    • Line 136: warning: exported method K8sEnvironment.Init should have comment or be unexported (golint)
    • Line 160: warning: exported method K8sEnvironment.PrepareRun should have comment or be unexported (golint)
    • Line 193: warning: exported method K8sEnvironment.CniDeviceChanged should have comment or be unexported (golint)
    • Line 197: warning: exported method K8sEnvironment.CniDeviceDeleted should have comment or be unexported (golint)
    • Line 200: warning: exported method K8sEnvironment.CheckPodExists should have comment or be unexported (golint)
    • aci-containers/pkg/controller/acicontainersoperator.go
    • Line 63: warning: exported type Controller should have comment or be unexported (golint)
    • Line 66: warning: don't use underscores in Go names; struct field Operator_Clientset should be OperatorClientset (golint)
    • Line 67: warning: don't use underscores in Go names; struct field K8s_Clientset should be K8sClientset (golint)
    • Line 68: warning: don't use underscores in Go names; struct field Operator_Queue should be OperatorQueue (golint)
    • Line 69: warning: don't use underscores in Go names; struct field Deployment_Queue should be DeploymentQueue (golint)
    • Line 70: warning: don't use underscores in Go names; struct field Daemonset_Queue should be DaemonsetQueue (golint)
    • Line 71: warning: don't use underscores in Go names; struct field Node_Queue should be NodeQueue (golint)
    • Line 72: warning: don't use underscores in Go names; struct field Route_Queue should be RouteQueue (golint)
    • Line 73: warning: don't use underscores in Go names; struct field Informer_Operator should be InformerOperator (golint)
    • Line 74: warning: don't use underscores in Go names; struct field Informer_Deployment should be InformerDeployment (golint)
    • Line 75: warning: don't use underscores in Go names; struct field Informer_Daemonset should be InformerDaemonset (golint)
    • Line 76: warning: don't use underscores in Go names; struct field Informer_Node should be InformerNode (golint)
    • Line 77: warning: don't use underscores in Go names; struct field Informer_Route should be InformerRoute (golint)
    • Line 85: warning: exported var Version should have comment or be unexported (golint)
    • Line 94: warning: exported var Dnsoper should have comment or be unexported (golint)
    • Line 102: warning: exported function NewAciContainersOperator should have comment or be unexported (golint)
    • Line 107: warning: don't use underscores in Go names; var operator_queue should be operatorQueue (golint)
    • Line 108: warning: don't use underscores in Go names; var deployment_queue should be deploymentQueue (golint)
    • Line 109: warning: don't use underscores in Go names; var daemonset_queue should be daemonsetQueue (golint)
    • Line 110: warning: don't use underscores in Go names; var node_queue should be nodeQueue (golint)
    • Line 111: warning: don't use underscores in Go names; var route_queue should be routeQueue (golint)
    • Line 115: warning: don't use underscores in Go names; var aci_operator_informer should be aciOperatorInformer (golint)
    • Line 129: warning: don't use underscores in Go names; var aci_deployment_informer should be aciDeploymentInformer (golint)
    • Line 143: warning: don't use underscores in Go names; var aci_daemonset_informer should be aciDaemonsetInformer (golint)
    • Line 156: warning: don't use underscores in Go names; var node_informer should be nodeInformer (golint)
    • Line 170: warning: don't use underscores in Go names; var route_informer should be routeInformer (golint)
    • Line 251: warning: don't use underscores in Go names; var dep_obj should be depObj (golint)
    • Line 261: warning: don't use underscores in Go names; var dep_obj should be depObj (golint)
    • Line 268: warning: don't use underscores in Go names; var dep_obj should be depObj (golint)
    • Line 347: warning: don't use underscores in Go names; var old_dep should be oldDep (golint)
    • Line 348: warning: don't use underscores in Go names; var new_dep should be newDep (golint)
    • Line 361: warning: don't use underscores in Go names; var old_ds should be oldDs (golint)
    • Line 362: warning: don't use underscores in Go names; var new_ds should be newDs (golint)
    • Line 374: warning: exported method Controller.GetAciContainersOperatorCR should have comment or be unexported (golint)
    • Line 382: warning: exported method Controller.ReadConfigMap should have comment or be unexported (golint)
    • Line 392: warning: exported method Controller.CreateAciContainersOperatorObj should have comment or be unexported (golint)
    • Line 402: warning: exported method Controller.CreateAciContainersOperatorCR should have comment or be unexported (golint)
    • Line 435: warning: exported method Controller.Run should have comment or be unexported (golint)
    • Line 560: warning: exported method Controller.CheckOwnerReference should have comment or be unexported (golint)
    • Line 570: warning: exported method Controller.UpdateDeploymentOwnerReference should have comment or be unexported (golint)
    • Line 600: warning: exported method Controller.UpdateHostDaemonsetOwnerReference should have comment or be unexported (golint)
    • Line 632: warning: exported method Controller.UpdateOvsDaemonsetOwnerReference should have comment or be unexported (golint)
    • Line 1149: warning: don't use underscores in Go names; var old_node should be oldNode (golint)
    • Line 1150: warning: don't use underscores in Go names; var new_node should be newNode (golint)
    • aci-containers/pkg/controller/network_policy_test.go
    • Line 297: warning: don't use underscores in Go names; var rule_0_0 should be rule0_0 (golint)
    • Line 301: warning: don't use underscores in Go names; var rule_1_0 should be rule1_0 (golint)
    • Line 307: warning: don't use underscores in Go names; var rule_2_0 should be rule2_0 (golint)
    • Line 327: warning: don't use underscores in Go names; var rule_3_0 should be rule3_0 (golint)
    • Line 333: warning: don't use underscores in Go names; var rule_4_1 should be rule4_1 (golint)
    • Line 339: warning: don't use underscores in Go names; var rule_5_0 should be rule5_0 (golint)
    • Line 345: warning: don't use underscores in Go names; var rule_6_0 should be rule6_0 (golint)
    • Line 352: warning: don't use underscores in Go names; var rule_7_0 should be rule7_0 (golint)
    • Line 357: warning: don't use underscores in Go names; var rule_8_0 should be rule8_0 (golint)
    • Line 363: warning: don't use underscores in Go names; var rule_8_1 should be rule8_1 (golint)
    • Line 370: warning: don't use underscores in Go names; var rule_9_0 should be rule9_0 (golint)
    • Line 376: warning: don't use underscores in Go names; var rule_10_0 should be rule10_0 (golint)
    • Line 382: warning: don't use underscores in Go names; var rule_11_0 should be rule11_0 (golint)
    • Line 389: warning: don't use underscores in Go names; var rule_11_s should be rule11S (golint)
    • Line 396: warning: don't use underscores in Go names; var rule_12_0 should be rule12_0 (golint)
    • Line 402: warning: don't use underscores in Go names; var rule_12_s_0 should be rule12S0 (golint)
    • Line 410: warning: don't use underscores in Go names; var rule_12_s_1 should be rule12S1 (golint)
    • Line 418: warning: don't use underscores in Go names; var rule_13_0 should be rule13_0 (golint)
    • Line 422: warning: don't use underscores in Go names; var rule_14_0 should be rule14_0 (golint)
    • Line 428: warning: don't use underscores in Go names; var rule_14_s should be rule14S (golint)
    • Line 435: warning: don't use underscores in Go names; var rule_15_0 should be rule15_0 (golint)
    • Line 939: warning: don't use underscores in Go names; var rule_0_0_v6 should be rule0_0V6 (golint)
    • Line 943: warning: don't use underscores in Go names; var rule_1_0_v6 should be rule1_0V6 (golint)
    • Line 949: warning: don't use underscores in Go names; var rule_2_0_v6 should be rule2_0V6 (golint)
    • Line 969: warning: don't use underscores in Go names; var rule_3_0_v6 should be rule3_0V6 (golint)
    • Line 975: warning: don't use underscores in Go names; var rule_4_1_v6 should be rule4_1V6 (golint)
    • Line 981: warning: don't use underscores in Go names; var rule_5_0_v6 should be rule5_0V6 (golint)
    • Line 987: warning: don't use underscores in Go names; var rule_6_0_v6 should be rule6_0V6 (golint)
    • Line 994: warning: don't use underscores in Go names; var rule_7_0_v6 should be rule7_0V6 (golint)
    • Line 999: warning: don't use underscores in Go names; var rule_8_0_v6 should be rule8_0V6 (golint)
    • Line 1005: warning: don't use underscores in Go names; var rule_8_1_v6 should be rule8_1V6 (golint)
    • Line 1012: warning: don't use underscores in Go names; var rule_9_0_v6 should be rule9_0V6 (golint)
    • Line 1018: warning: don't use underscores in Go names; var rule_10_0_v6 should be rule10_0V6 (golint)
    • Line 1024: warning: don't use underscores in Go names; var rule_11_0_v6 should be rule11_0V6 (golint)
    • Line 1031: warning: don't use underscores in Go names; var rule_11_s_v6 should be rule11SV6 (golint)
    • Line 1038: warning: don't use underscores in Go names; var rule_12_0_v6 should be rule12_0V6 (golint)
    • Line 1044: warning: don't use underscores in Go names; var rule_12_s_0_v6 should be rule12S0V6 (golint)
    • Line 1052: warning: don't use underscores in Go names; var rule_12_s_1_v6 should be rule12S1V6 (golint)
    • Line 1060: warning: don't use underscores in Go names; var rule_13_0_v6 should be rule13_0V6 (golint)
    • Line 1064: warning: don't use underscores in Go names; var rule_14_0_v6 should be rule14_0V6 (golint)
    • Line 1070: warning: don't use underscores in Go names; var rule_14_s_v6 should be rule14SV6 (golint)
    • Line 1495: warning: don't use underscores in Go names; var rule_11_0 should be rule11_0 (golint)
    • Line 1502: warning: don't use underscores in Go names; var rule_11_s should be rule11S (golint)
    • Line 1509: warning: don't use underscores in Go names; var rule_12_0 should be rule12_0 (golint)
    • Line 1515: warning: don't use underscores in Go names; var rule_12_s_0 should be rule12S0 (golint)
    • Line 1523: warning: don't use underscores in Go names; var rule_12_s_1 should be rule12S1 (golint)
    • Line 1531: warning: don't use underscores in Go names; var rule_13_0 should be rule13_0 (golint)
    • Line 1535: warning: don't use underscores in Go names; var rule_14_0 should be rule14_0 (golint)
    • Line 1541: warning: don't use underscores in Go names; var rule_14_s should be rule14S (golint)
    • Line 1922: warning: don't use underscores in Go names; var rule_1_0 should be rule1_0 (golint)
    • Line 1928: warning: don't use underscores in Go names; var rule_1_s should be rule1S (golint)
    • aci-containers/pkg/gbpserver/watchers/k8s_watch.go
    • Line 36: warning: exported type K8sWatcher should have comment or be unexported (golint)
    • Line 43: warning: exported function NewK8sWatcher should have comment or be unexported (golint)
    • Line 69: warning: exported method K8sWatcher.InitEPInformer should have comment or be unexported (golint)
    • Line 75: warning: exported method K8sWatcher.InitIntentInformers should have comment or be unexported (golint)
    • Line 260: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/hostagent/packet_event.go
    • Line 25: warning: exported type PacketEvent should have comment or be unexported (golint)
    • Line 38: warning: exported method HostAgent.RunPacketEventListener should have comment or be unexported (golint)
    • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • aci-containers/pkg/loadbalancer/aws.go
    • Line 33: warning: exported type AwsLB should have comment or be unexported (golint)
    • Line 56: warning: exported function NewAwsLB should have comment or be unexported (golint)
    • Line 66: warning: exported method AwsLB.Init should have comment or be unexported (golint)
    • Line 94: warning: exported method AwsLB.UpdateService should have comment or be unexported (golint)
    • Line 124: warning: don't use underscores in Go names; var tg_input should be tgInput (golint)
    • Line 136: warning: don't use underscores in Go names; var tg_result should be tgResult (golint)
    • Line 210: warning: don't use underscores in Go names; var ec2_input should be ec2Input (golint)
    • Line 220: warning: don't use underscores in Go names; var ec2_res should be ec2Res (golint)
    • aci-containers/pkg/gbpserver/watchers/ep_sync_test.go
    • Line 46: warning: don't use underscores in Go names; type eps_suite should be epsSuite (golint)
    • Line 1702: warning: don't use underscores in Go names; var l_epg_uris should be lEpgUris (golint)
    • Line 1710: warning: don't use underscores in Go names; var exp_contracts should be expContracts (golint)
    • Line 1718: warning: don't use underscores in Go names; var exp_r_epgs should be expREpgs (golint)
    • Line 1723: warning: don't use underscores in Go names; var exp_subnets should be expSubnets (golint)
    • Line 1731: warning: don't use underscores in Go names; range var epg_uri should be epgURI (golint)
    • Line 1734: warning: don't use underscores in Go names; range var c_uri should be cURI (golint)
    • Line 1737: warning: don't use underscores in Go names; range var r_epg should be rEpg (golint)
    • Line 1741: warning: don't use underscores in Go names; var l_epgs should be lEpgs (golint)
    • Line 1743: warning: don't use underscores in Go names; range var epg_uri should be epgURI (golint)
    • Line 1752: warning: don't use underscores in Go names; var r_epgs should be rEpgs (golint)
    • aci-containers/pkg/gbpserver/config.go
    • Line 22: warning: comment on exported type GBPServerConfig should be of the form "GBPServerConfig ..." (with optional leading article) (golint)
    • Line 72: warning: exported type ApicInfo should have comment or be unexported (golint)
    • Line 102: warning: exported function InitConfig should have comment or be unexported (golint)
    • aci-containers/pkg/gbpserver/policy.go
    • Line 39: warning: exported type IntRange should have comment or be unexported (golint)
    • Line 44: warning: comment on exported type WLRule should be of the form "WLRule ..." (with optional leading article) (golint)
    • Line 50: warning: exported type Contract should have comment or be unexported (golint)
    • Line 57: warning: exported method Contract.Make should have comment or be unexported (golint)
    • Line 95: warning: exported method Contract.Delete should have comment or be unexported (golint)
    • Line 287: warning: exported method Contract.FromMo should have comment or be unexported (golint)
    • Line 355: warning: exported type EPG should have comment or be unexported (golint)
    • Line 364: warning: exported method EPG.Make should have comment or be unexported (golint)
    • Line 387: warning: exported method EPG.Delete should have comment or be unexported (golint)
    • Line 493: warning: exported method EPG.FromMo should have comment or be unexported (golint)
    • Line 688: warning: exported type NetworkPolicy should have comment or be unexported (golint)
    • Line 692: warning: exported type Hpp should have comment or be unexported (golint)
    • Line 697: warning: exported type HpSubj should have comment or be unexported (golint)
    • Line 703: warning: exported type HpSubjChild should have comment or be unexported (golint)
    • Line 710: warning: exported type HpSubjGrandchild should have comment or be unexported (golint)
    • Line 729: warning: exported method NetworkPolicy.Make should have comment or be unexported (golint)
    • Line 775: warning: exported method HpSubj.Make should have comment or be unexported (golint)
    • Line 855: warning: exported method HpSubjChild.Make should have comment or be unexported (golint)
    • aci-containers/pkg/rdconfig/apis/aci.snat/v1/types.go
    • Line 11: warning: exported type RdConfig should have comment or be unexported (golint)
    • Line 19: warning: exported type RdConfigSpec should have comment or be unexported (golint)
    • Line 27: warning: comment on exported type RdConfigStatus should be of the form "RdConfigStatus ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported type RdConfigList should be of the form "RdConfigList ..." (with optional leading article) (golint)
    • aci-containers/pkg/gbpserver/server.go
    • Line 38: warning: exported const NoContainer should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: exported var DefETCD should have comment or be unexported (golint)
    • Line 60: warning: exported type PostResp should have comment or be unexported (golint)
    • Line 64: warning: exported type ListResp should have comment or be unexported (golint)
    • Line 68: warning: exported type Server should have comment or be unexported (golint)
    • Line 95: warning: exported type StateDriver should have comment or be unexported (golint)
    • Line 177: warning: exported var LocalhostCert should have comment or be unexported (golint)
    • Line 192: warning: exported var LocalhostKey should have comment or be unexported (golint)
    • Line 229: warning: exported function StartNewServer should have comment or be unexported (golint)
    • Line 314: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 325: warning: exported method Server.InitState should have comment or be unexported (golint)
    • Line 380: warning: exported method Server.Config should have comment or be unexported (golint)
    • Line 385: warning: exported method Server.Stop should have comment or be unexported (golint)
    • Line 396: warning: exported method Server.UTReadMsg should have comment or be unexported (golint)
    • Line 410: warning: exported method Server.RegisterCallBack should have comment or be unexported (golint)
    • Line 414: warning: exported method Server.RemoveCallBack should have comment or be unexported (golint)
    • Line 418: warning: exported method Server.AddNetPol should have comment or be unexported (golint)
    • Line 427: warning: exported method Server.DelNetPol should have comment or be unexported (golint)
    • Line 436: warning: exported method Server.AddEPG should have comment or be unexported (golint)
    • Line 445: warning: exported method Server.DelEPG should have comment or be unexported (golint)
    • Line 454: warning: exported method Server.AddContract should have comment or be unexported (golint)
    • Line 463: warning: exported method Server.DelContract should have comment or be unexported (golint)
    • Line 472: warning: exported method Server.AddEP should have comment or be unexported (golint)
    • Line 481: warning: exported method Server.DelEP should have comment or be unexported (golint)
    • Line 490: warning: exported method Server.UpdateTunnels should have comment or be unexported (golint)
    • Line 688: warning: exported function UuidToCid should have comment or be unexported (golint)
    • aci-containers/pkg/controller/controller.go
    • Line 53: warning: exported type AciController should have comment or be unexported (golint)
    • Line 215: warning: exported type ServiceEndPointType should have comment or be unexported (golint)
    • Line 284: warning: exported function NewController should have comment or be unexported (golint)
    • Line 335: warning: exported method AciController.Init should have comment or be unexported (golint)
    • Line 433: warning: exported method AciController.Run should have comment or be unexported (golint)
    • aci-containers/pkg/snatglobalinfo/apis/aci.snat/v1/types.go
    • Line 7: warning: exported type GlobalInfoList should have comment or be unexported (golint)
    • Line 8: warning: exported type SnatGlobalInfoSpec should have comment or be unexported (golint)
    • Line 36: warning: comment on exported type SnatGlobalInfoList should be of the form "SnatGlobalInfoList ..." (with optional leading article) (golint)
    • Line 44: warning: exported type GlobalInfo should have comment or be unexported (golint)
    • Line 52: warning: comment on exported type PortRange should be of the form "PortRange ..." (with optional leading article) (golint)
    • aci-containers/tools.go
    • Line 15: warning: package comment should be of the form "Package tools ..." (golint)
    • Line 19: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • aci-containers/pkg/hostagent/version.go
    • Line 26: warning: comment on exported type VersionInfo should be of the form "VersionInfo ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported function GetVersion should be of the form "GetVersion ..." (golint)
    • Line 41: warning: comment on exported function VersionString should be of the form "VersionString ..." (golint)
    • aci-containers/pkg/index/pod_selector_index.go
    • Line 31: warning: comment on exported type PodSelector should be of the form "PodSelector ..." (with optional leading article) (golint)
    • Line 44: warning: comment on exported type GetPodSelectorFunc should be of the form "GetPodSelectorFunc ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported function PodSelectorFromNsAndSelector should be of the form "PodSelectorFromNsAndSelector ..." (golint)
    • Line 67: warning: comment on exported function NilSelectorFunc should be of the form "NilSelectorFunc ..." (golint)
    • Line 72: warning: comment on exported type GetKeyFunc should be of the form "GetKeyFunc ..." (with optional leading article) (golint)
    • Line 75: warning: comment on exported type UpdateFunc should be of the form "UpdateFunc ..." (with optional leading article) (golint)
    • Line 78: warning: comment on exported type PodHashFunc should be of the form "PodHashFunc ..." (with optional leading article) (golint)
    • Line 87: warning: comment on exported type PodSelectorIndex should be of the form "PodSelectorIndex ..." (with optional leading article) (golint)
    • Line 115: warning: comment on exported function NewPodSelectorIndex should be of the form "NewPodSelectorIndex ..." (golint)
    • Line 137: warning: comment on exported method PodSelectorIndex.SetPodUpdateCallback should be of the form "SetPodUpdateCallback ..." (golint)
    • Line 143: warning: comment on exported method PodSelectorIndex.SetObjUpdateCallback should be of the form "SetObjUpdateCallback ..." (golint)
    • Line 149: warning: comment on exported method PodSelectorIndex.SetPodHashFunc should be of the form "SetPodHashFunc ..." (golint)
    • Line 155: warning: comment on exported method PodSelectorIndex.GetObjForPod should be of the form "GetObjForPod ..." (golint)
    • Line 168: warning: comment on exported method PodSelectorIndex.GetPodForObj should be of the form "GetPodForObj ..." (golint)
    • Line 179: warning: comment on exported method PodSelectorIndex.UpdatePod should be of the form "UpdatePod ..." (golint)
    • Line 192: warning: comment on exported method PodSelectorIndex.UpdatePodNoCallback should be of the form "UpdatePodNoCallback ..." (golint)
    • Line 276: warning: comment on exported method PodSelectorIndex.DeletePod should be of the form "DeletePod ..." (golint)
    • Line 303: warning: comment on exported method PodSelectorIndex.UpdateNamespace should be of the form "UpdateNamespace ..." (golint)
    • Line 335: warning: comment on exported method PodSelectorIndex.DeleteNamespace should be of the form "DeleteNamespace ..." (golint)
    • Line 423: warning: comment on exported method PodSelectorIndex.UpdateSelectorObj should be of the form "UpdateSelectorObj ..." (golint)
    • Line 437: warning: comment on exported method PodSelectorIndex.UpdateSelectorObjNoCallback should be of the form "UpdateSelectorObjNoCallback ..." (golint)
    • Line 449: warning: comment on exported method PodSelectorIndex.DeleteSelectorObj should be of the form "DeleteSelectorObj ..." (golint)
    • aci-containers/pkg/hostagent/agent.go
    • Line 41: warning: exported type HostAgent should have comment or be unexported (golint)
    • Line 105: warning: exported type ServiceEndPointType should have comment or be unexported (golint)
    • Line 137: warning: exported function NewHostAgent should have comment or be unexported (golint)
    • Line 213: warning: exported method HostAgent.Init should have comment or be unexported (golint)
    • Line 240: warning: exported method HostAgent.ScheduleSync should have comment or be unexported (golint)
    • Line 313: warning: exported method HostAgent.EnableSync should have comment or be unexported (golint)
    • Line 331: warning: exported method HostAgent.Run should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

misspell97%

Misspell Finds commonly misspelled English words