Preparing report...

Report for github.com/nothollyhigh/kissgate

A    Great!    Found 11 issues across 11 files

Tweet

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint0%

Golint is a linter for Go source code.

    • kissgate/app/app.go
    • Line 63: warning: exported function Run should have comment or be unexported (golint)
    • Line 77: warning: exported function Stop should have comment or be unexported (golint)
    • kissgate/app/connmgr.go
    • Line 22: warning: exported type ConnMgr should have comment or be unexported (golint)
    • Line 34: warning: comment on exported method ConnMgr.UpdateInNum should be of the form "UpdateInNum ..." (golint)
    • Line 39: warning: comment on exported method ConnMgr.GetInNum should be of the form "GetInNum ..." (golint)
    • Line 44: warning: comment on exported method ConnMgr.UpdateOutNum should be of the form "UpdateOutNum ..." (golint)
    • Line 49: warning: comment on exported method ConnMgr.GetOutNum should be of the form "GetOutNum ..." (golint)
    • Line 54: warning: comment on exported method ConnMgr.UpdateSuccessNum should be of the form "UpdateSuccessNum ..." (golint)
    • Line 59: warning: comment on exported method ConnMgr.GetSuccessNum should be of the form "GetSuccessNum ..." (golint)
    • Line 64: warning: comment on exported method ConnMgr.UpdateFailedNum should be of the form "UpdateFailedNum ..." (golint)
    • Line 69: warning: comment on exported method ConnMgr.GetdateFailedNum should be of the form "GetdateFailedNum ..." (golint)
    • Line 74: warning: comment on exported method ConnMgr.UpdateClientInSize should be of the form "UpdateClientInSize ..." (golint)
    • Line 79: warning: comment on exported method ConnMgr.GetClientInSize should be of the form "GetClientInSize ..." (golint)
    • Line 84: warning: comment on exported method ConnMgr.UpdateClientOutSize should be of the form "UpdateClientOutSize ..." (golint)
    • Line 89: warning: comment on exported method ConnMgr.GetClientOutSize should be of the form "GetClientOutSize ..." (golint)
    • Line 94: warning: comment on exported method ConnMgr.UpdateServerInSize should be of the form "UpdateServerInSize ..." (golint)
    • Line 99: warning: comment on exported method ConnMgr.GetServerInSize should be of the form "GetServerInSize ..." (golint)
    • Line 104: warning: comment on exported method ConnMgr.UpdateServerOutSize should be of the form "UpdateServerOutSize ..." (golint)
    • Line 109: warning: comment on exported method ConnMgr.GetServerOutSize should be of the form "GetServerOutSize ..." (golint)
    • Line 114: warning: exported method ConnMgr.LogDataFlowRecord should have comment or be unexported (golint)
    • Line 120: warning: exported method ConnMgr.StartDataFlowRecord should have comment or be unexported (golint)
    • kissgate/app/proxy.go
    • Line 9: warning: exported var PT_TCP should have comment or be unexported (golint)
    • Line 12: warning: comment on exported var DEFAULT_TCP_NODELAY should be of the form "DEFAULT_TCP_NODELAY ..." (golint)
    • Line 25: warning: exported type IProxy should have comment or be unexported (golint)
    • Line 29: warning: comment on exported type ProxyBase should be of the form "ProxyBase ..." (with optional leading article) (golint)
    • Line 39: warning: comment on exported method ProxyBase.GetBestLine should be of the form "GetBestLine ..." (golint)
    • Line 47: warning: comment on exported method ProxyBase.GetBestLineWithoutLock should be of the form "GetBestLineWithoutLock ..." (golint)
    • Line 64: warning: comment on exported method ProxyBase.AddLine should be of the form "AddLine ..." (golint)
    • Line 72: warning: comment on exported method ProxyBase.StartCheckLines should be of the form "StartCheckLines ..." (golint)
    • Line 79: warning: comment on exported method ProxyBase.StopCheckLines should be of the form "StopCheckLines ..." (golint)
    • kissgate/app/proxymgr.go
    • Line 15: warning: exported type ProxyMgr should have comment or be unexported (golint)
    • Line 19: warning: exported method ProxyMgr.AddProxy should have comment or be unexported (golint)
    • Line 27: warning: exported method ProxyMgr.InitPorxy should have comment or be unexported (golint)
    • kissgate/app/proxyws.go
    • Line 18: warning: exported var DefaultSocketOpt should have comment or be unexported (golint)
    • Line 32: warning: comment on exported type ProxyWebsocket should be of the form "ProxyWebsocket ..." (with optional leading article) (golint)
    • Line 50: warning: exported method ProxyWebsocket.InitConn should have comment or be unexported (golint)
    • Line 79: warning: exported method ProxyWebsocket.OnNew should have comment or be unexported (golint)
    • Line 272: warning: exported method ProxyWebsocket.Start should have comment or be unexported (golint)
    • Line 346: warning: exported method ProxyWebsocket.Stop should have comment or be unexported (golint)
    • Line 354: warning: exported function NewWebsocketProxy should have comment or be unexported (golint)
    • kissgate/app/line.go
    • Line 19: warning: exported const COUNT_MINUTES should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported type FailedInMunite should have comment or be unexported (golint)
    • Line 28: warning: exported var ErrorInvalidAddr should have comment or be unexported (golint)
    • Line 31: warning: comment on exported type Line should be of the form "Line ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported method Line.Score should be of the form "Score ..." (golint)
    • Line 61: warning: exported method Line.CheckLine should have comment or be unexported (golint)
    • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 73: warning: comment on exported method Line.Start should be of the form "Start ..." (golint)
    • Line 107: warning: comment on exported method Line.UpdateDelay should be of the form "UpdateDelay ..." (golint)
    • Line 120: warning: comment on exported method Line.Stop should be of the form "Stop ..." (golint)
    • Line 134: warning: comment on exported method Line.UpdateLoad should be of the form "UpdateLoad ..." (golint)
    • Line 139: warning: comment on exported method Line.Pause should be of the form "Pause ..." (golint)
    • Line 144: warning: comment on exported method Line.UnPause should be of the form "UnPause ..." (golint)
    • Line 151: warning: comment on exported method Line.HandleRedirect should be of the form "HandleRedirect ..." (golint)
    • Line 172: warning: comment on exported method Line.UpdateFailedNum should be of the form "UpdateFailedNum ..." (golint)
    • Line 189: warning: comment on exported method Line.GetFailedInLastNMinutes should be of the form "GetFailedInLastNMinutes ..." (golint)
    • Line 207: warning: comment on exported function NewLine should be of the form "NewLine ..." (golint)
    • kissgate/app/proxytcp.go
    • Line 10: warning: comment on exported type ProxyTcp should be of the form "ProxyTcp ..." (with optional leading article) (golint)
    • Line 26: warning: exported method ProxyTcp.InitConn should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyTcp.OnNew should have comment or be unexported (golint)
    • Line 264: warning: exported method ProxyTcp.Start should have comment or be unexported (golint)
    • Line 272: warning: exported method ProxyTcp.Stop should have comment or be unexported (golint)
    • Line 281: warning: exported function NewTcpProxy should have comment or be unexported (golint)
    • kissgate/app/xmlparser.go
    • Line 11: warning: exported type XMLConfig should have comment or be unexported (golint)
    • Line 17: warning: exported type XMLOptions should have comment or be unexported (golint)
    • Line 25: warning: exported type XMLHeartbeat should have comment or be unexported (golint)
    • Line 31: warning: exported type XMLProxy should have comment or be unexported (golint)
    • Line 36: warning: exported type XMLLine should have comment or be unexported (golint)
    • Line 49: warning: exported type XMLNode should have comment or be unexported (golint)
    • Line 57: warning: exported type XMLCert should have comment or be unexported (golint)
    • Line 63: warning: exported type XMLRoute should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!