Go Report Card

Preparing report...

Report for github.com/oVirt/ovirt-engine-sdk-go

A+    Excellent!    Found 24 issues across 116 files

Tweet
Last refresh:

Refresh now

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint94%

Golint is a linter for Go source code.

    • ovirt-engine-sdk-go/sdk/ovirtsdk/helper.go
    • Line 8: warning: exported const DefaultInterval should have comment or be unexported (golint)
    • Line 10: warning: exported const DefaultVMTimeout should have comment or be unexported (golint)
    • Line 45: warning: exported const DefaultDiskTimeout should have comment or be unexported (golint)
    • Line 47: warning: exported method Connection.WaitForDisk should have comment or be unexported (golint)
    • ovirt-engine-sdk-go/sdk/ovirtsdk/reader.go
    • Line 164: warning: exported method XMLReader.ReadBools should have comment or be unexported (golint)
    • Line 189: warning: exported method XMLReader.ReadInt64s should have comment or be unexported (golint)
    • Line 205: warning: exported method XMLReader.ReadFloat64 should have comment or be unexported (golint)
    • Line 213: warning: exported method XMLReader.ReadFloat64s should have comment or be unexported (golint)
    • Line 240: warning: exported method XMLReader.ReadTimes should have comment or be unexported (golint)
    • ovirt-engine-sdk-go/sdk/ovirtsdk/type.go
    • Line 19: warning: exported type Href should have comment or be unexported (golint)
    • Line 34: warning: exported method Struct.Href should have comment or be unexported (golint)
    • Line 41: warning: exported method Struct.MustHref should have comment or be unexported (golint)
    • Line 48: warning: exported method Struct.SetHref should have comment or be unexported (golint)
    • ovirt-engine-sdk-go/sdk/ovirtsdk/writer.go
    • Line 29: warning: don't use underscores in Go names; var esc_quot should be escQuot (golint)
    • Line 30: warning: don't use underscores in Go names; var esc_apos should be escApos (golint)
    • Line 31: warning: don't use underscores in Go names; var esc_amp should be escAmp (golint)
    • Line 32: warning: don't use underscores in Go names; var esc_lt should be escLt (golint)
    • Line 33: warning: don't use underscores in Go names; var esc_gt should be escGt (golint)
    • Line 34: warning: don't use underscores in Go names; var esc_tab should be escTab (golint)
    • Line 35: warning: don't use underscores in Go names; var esc_nl should be escNl (golint)
    • Line 36: warning: don't use underscores in Go names; var esc_cr should be escCr (golint)
    • Line 37: warning: don't use underscores in Go names; var esc_fffd should be escFffd (golint)
    • Line 52: warning: exported method XMLWriter.WriteElement should have comment or be unexported (golint)
    • Line 62: warning: exported method XMLWriter.WriteStart should have comment or be unexported (golint)
    • Line 86: warning: exported method XMLWriter.WriteEnd should have comment or be unexported (golint)
    • Line 97: warning: exported method XMLWriter.WriteCharacter should have comment or be unexported (golint)
    • Line 101: warning: exported method XMLWriter.WriteCharacters should have comment or be unexported (golint)
    • Line 111: warning: exported method XMLWriter.WriteBool should have comment or be unexported (golint)
    • Line 115: warning: exported method XMLWriter.WriteBools should have comment or be unexported (golint)
    • Line 125: warning: exported method XMLWriter.FormatBool should have comment or be unexported (golint)
    • Line 129: warning: exported method XMLWriter.WriteInt64 should have comment or be unexported (golint)
    • Line 133: warning: exported method XMLWriter.WriteInt64s should have comment or be unexported (golint)
    • Line 143: warning: exported method XMLWriter.FormatInt64 should have comment or be unexported (golint)
    • Line 147: warning: exported method XMLWriter.WriteFloat64 should have comment or be unexported (golint)
    • Line 151: warning: exported method XMLWriter.WriteFloat64s should have comment or be unexported (golint)
    • Line 161: warning: exported method XMLWriter.FormatFloat64 should have comment or be unexported (golint)
    • Line 165: warning: exported method XMLWriter.WriteDate should have comment or be unexported (golint)
    • Line 169: warning: exported method XMLWriter.WriteDates should have comment or be unexported (golint)
    • Line 179: warning: exported method XMLWriter.FormatDate should have comment or be unexported (golint)
    • Line 183: warning: exported method XMLWriter.EscapeString should have comment or be unexported (golint)

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

ineffassign87%

IneffAssign detects ineffectual assignments in Go code.

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words