gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• probe-engine/experiment/run/urlgetter.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• probe-engine/legacy/oonitemplates/oonitemplates.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• probe-engine/legacy/oonitemplates/oonitemplates_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• probe-engine/internal/psiphonx/psiphonx_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• probe-engine/experiment/urlgetter/configurer_test.go
  • Line 151: warning: cyclomatic complexity 21 of function TestConfigurerNewConfigurationResolverDNSOverHTTPSGoogle() is high (> 15) (gocyclo)
  • Line 75: warning: cyclomatic complexity 21 of function TestConfigurerNewConfigurationResolverDNSOverHTTPSPowerdns() is high (> 15) (gocyclo)
  • Line 303: warning: cyclomatic complexity 21 of function TestConfigurerNewConfigurationResolverUDP() is high (> 15) (gocyclo)
  • Line 227: warning: cyclomatic complexity 21 of function TestConfigurerNewConfigurationResolverDNSOverHTTPSCloudflare() is high (> 15) (gocyclo)
  • Line 17: warning: cyclomatic complexity 17 of function TestConfigurerNewConfigurationVanilla() is high (> 15) (gocyclo)

• probe-engine/netx/httptransport/saver_test.go
  • Line 243: warning: cyclomatic complexity 17 of function TestSaverBodySuccess() is high (> 15) (gocyclo)

• probe-engine/netx/netx.go
  • Line 346: warning: cyclomatic complexity 20 of function NewDNSClientWithOverrides() is high (> 15) (gocyclo)

• probe-engine/legacy/netxlogger/netxlogger.go
  • Line 32: warning: cyclomatic complexity 21 of function (*Handler).OnMeasurement() is high (> 15) (gocyclo)

• probe-engine/probeservices/probeservices_test.go
  • Line 298: warning: cyclomatic complexity 22 of function TestTryAllCanceledContext() is high (> 15) (gocyclo)
  • Line 470: warning: cyclomatic complexity 20 of function TestTryAllIntegrationWeFallback() is high (> 15) (gocyclo)

• probe-engine/experiment/hirl/hirl_test.go
  • Line 76: warning: cyclomatic complexity 17 of function TestCancelledContext() is high (> 15) (gocyclo)
  • Line 170: warning: cyclomatic complexity 17 of function TestWithFakeMethods() is high (> 15) (gocyclo)

• probe-engine/experiment/urlgetter/getter_test.go
  • Line 653: warning: cyclomatic complexity 45 of function TestGetterIntegrationHTTPSWithTunnel() is high (> 15) (gocyclo)
  • Line 399: warning: cyclomatic complexity 44 of function TestGetterIntegrationHTTPS() is high (> 15) (gocyclo)
  • Line 540: warning: cyclomatic complexity 42 of function TestGetterIntegrationTLSHandshake() is high (> 15) (gocyclo)
  • Line 219: warning: cyclomatic complexity 22 of function TestGetterWithCancelledContextNoFollowRedirects() is high (> 15) (gocyclo)
  • Line 151: warning: cyclomatic complexity 22 of function TestGetterWithCancelledContextAndMethod() is high (> 15) (gocyclo)
  • Line 16: warning: cyclomatic complexity 22 of function TestGetterWithVeryShortTimeout() is high (> 15) (gocyclo)
  • Line 84: warning: cyclomatic complexity 22 of function TestGetterWithCancelledContextVanilla() is high (> 15) (gocyclo)
  • Line 344: warning: cyclomatic complexity 18 of function TestGetterWithCancelledContextUnknownResolverURL() is high (> 15) (gocyclo)
  • Line 289: warning: cyclomatic complexity 17 of function TestGetterWithCancelledContextCannotStartTunnel() is high (> 15) (gocyclo)

• probe-engine/legacy/netx/oldhttptransport/tracetripper_test.go
  • Line 108: warning: cyclomatic complexity 21 of function TestTraceTripperWithCorrectSnaps() is high (> 15) (gocyclo)

• probe-engine/experiment/webconnectivity/summary.go
  • Line 98: warning: cyclomatic complexity 41 of function Summarize() is high (> 15) (gocyclo)

• probe-engine/probeservices/measurementmeta_test.go
  • Line 17: warning: cyclomatic complexity 16 of function TestGetMeasurementMetaWorkingAsIntended() is high (> 15) (gocyclo)

• probe-engine/experiment_integration_test.go
  • Line 221: warning: cyclomatic complexity 24 of function TestUseOptions() is high (> 15) (gocyclo)

• probe-engine/experimentbuilder_test.go
  • Line 105: warning: cyclomatic complexity 19 of function TestExperimentBuilderSetOptionGuessType() is high (> 15) (gocyclo)

• probe-engine/experiment/sniblocking/sniblocking_test.go
  • Line 175: warning: cyclomatic complexity 17 of function TestMeasureoneCancelledContext() is high (> 15) (gocyclo)
  • Line 229: warning: cyclomatic complexity 17 of function TestMeasureoneWithPreMeasurementFailure() is high (> 15) (gocyclo)
  • Line 281: warning: cyclomatic complexity 17 of function TestMeasureoneSuccess() is high (> 15) (gocyclo)

• probe-engine/experiment/telegram/telegram_test.go
  • Line 28: warning: cyclomatic complexity 16 of function TestGood() is high (> 15) (gocyclo)

• probe-engine/experiment/tor/tor_test.go
  • Line 768: warning: cyclomatic complexity 25 of function TestScrubLogger() is high (> 15) (gocyclo)

• probe-engine/oonimkall/tasks/runner.go
  • Line 117: warning: cyclomatic complexity 22 of function (*Runner).Run() is high (> 15) (gocyclo)

• probe-engine/experiment/fbmessenger/fbmessenger_test.go
  • Line 93: warning: cyclomatic complexity 20 of function TestWithCancelledContext() is high (> 15) (gocyclo)
  • Line 28: warning: cyclomatic complexity 19 of function TestSuccess() is high (> 15) (gocyclo)

• probe-engine/experiment/hhfm/hhfm_test.go
  • Line 145: warning: cyclomatic complexity 35 of function TestCancelledContext() is high (> 15) (gocyclo)
  • Line 35: warning: cyclomatic complexity 33 of function TestSuccess() is high (> 15) (gocyclo)

• probe-engine/experiment/webconnectivity/dnsanalysis.go
  • Line 32: warning: cyclomatic complexity 16 of function DNSAnalysis() is high (> 15) (gocyclo)

• probe-engine/netx/errorx/errorx_test.go
  • Line 46: warning: cyclomatic complexity 27 of function TestToFailureString() is high (> 15) (gocyclo)

• probe-engine/netx/errorx/errorx.go
  • Line 190: warning: cyclomatic complexity 25 of function toFailureString() is high (> 15) (gocyclo)

golint100%

Golint is a linter for Go source code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• probe-engine/netx/errorx/errorx_test.go
  • Line 177: warning: ineffectual assignment to err (ineffassign)

• probe-engine/experiment/tlstool/internal/splitter.go
  • Line 32: warning: ineffectual assignment to buf (ineffassign)

• probe-engine/legacy/netx/modelx/modelx_test.go
  • Line 59: warning: ineffectual assignment to ctx (ineffassign)

• probe-engine/legacy/netx/dialer_test.go
  • Line 103: warning: ineffectual assignment to err (ineffassign)

• probe-engine/netx/quicdialer/system.go
  • Line 28: warning: ineffectual assignment to err (ineffassign)
  • Line 38: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• probe-engine/experiment/webconnectivity/httpanalysis_test.go
  • Line 699: warning: "communit" is a misspelling of "communist" (misspell)

• probe-engine/netx/dialer/proxy.go
  • Line 41: warning: "precendence" is a misspelling of "precedence" (misspell)

• probe-engine/netx/resolver/encoder_test.go
  • Line 54: warning: "containg" is a misspelling of "containing" (misspell)

• probe-engine/netx/resolver/integration_test.go
  • Line 37: warning: "ouput" is a misspelling of "output" (misspell)

• probe-engine/experiment/tor/tor_test.go
  • Line 103: warning: "actualy" is a misspelling of "actually" (misspell)

• probe-engine/experiment/webconnectivity/summary.go
  • Line 112: warning: "succeded" is a misspelling of "succeeded" (misspell)
  • Line 132: warning: "debateable" is a misspelling of "debatable" (misspell)
  • Line 149: warning: "succeded" is a misspelling of "succeeded" (misspell)

• probe-engine/legacy/netx/resolver_test.go
  • Line 37: warning: "ouput" is a misspelling of "output" (misspell)

• probe-engine/netx/dialer/errorwrapper.go
  • Line 22: warning: "succeded" is a misspelling of "succeeded" (misspell)

• probe-engine/netx/quicdialer/errorwrapper.go
  • Line 25: warning: "succeded" is a misspelling of "succeeded" (misspell)