gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• multicloud-operators-subscription/pkg/controller/subscription/reference.go
  • Line 60: warning: cyclomatic complexity 16 of function (*ReconcileSubscription).ListAndDeployReferredObject() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/synchronizer/kubernetes/synchronizer.go
  • Line 494: warning: cyclomatic complexity 23 of function (*KubeSynchronizer).RegisterTemplate() is high (> 15) (gocyclo)
  • Line 227: warning: cyclomatic complexity 22 of function (*KubeSynchronizer).updateResourceByTemplateUnit() is high (> 15) (gocyclo)
  • Line 36: warning: cyclomatic complexity 16 of function (*KubeSynchronizer).checkServerObjects() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/webhook/listener/github_events.go
  • Line 80: warning: cyclomatic complexity 16 of function (*WebhookListener).processSubscription() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/controller/mcmhub/ansiblejob.go
  • Line 52: warning: cyclomatic complexity 16 of function (*JobInstances).registryJobs() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/utils/gitrepo.go
  • Line 156: warning: cyclomatic complexity 19 of function CloneGitRepo() is high (> 15) (gocyclo)
  • Line 716: warning: cyclomatic complexity 17 of function IsClusterAdmin() is high (> 15) (gocyclo)
  • Line 546: warning: cyclomatic complexity 17 of function SortResources() is high (> 15) (gocyclo)
  • Line 637: warning: cyclomatic complexity 16 of function sortKubeResource() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/utils/timewindow.go
  • Line 212: warning: cyclomatic complexity 17 of function generateNextPoint() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/subscriber/objectbucket/objectbucket_subscriber_item.go
  • Line 292: warning: cyclomatic complexity 22 of function (*SubscriberItem).doSubscribeDeployable() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/subscriber/namespace/deployable_reconciler.go
  • Line 223: warning: cyclomatic complexity 18 of function (*DeployableReconciler).doSubscribeDeployable() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/controller/mcmhub/mcmhub_controller.go
  • Line 467: warning: cyclomatic complexity 33 of function (*ReconcileSubscription).Reconcile() is high (> 15) (gocyclo)
  • Line 730: warning: cyclomatic complexity 24 of function (*ReconcileSubscription).finalCommit() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/controller/subscription/subscription_controller.go
  • Line 196: warning: cyclomatic complexity 28 of function (*ReconcileSubscription).Reconcile() is high (> 15) (gocyclo)
  • Line 336: warning: cyclomatic complexity 27 of function (*ReconcileSubscription).doReconcile() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/utils/deployable.go
  • Line 367: warning: cyclomatic complexity 18 of function isEqualResourceUnitStatus() is high (> 15) (gocyclo)
  • Line 231: warning: cyclomatic complexity 18 of function isSubscriptionResourceStatusUpdated() is high (> 15) (gocyclo)

• multicloud-operators-subscription/cmd/manager/exec/manager.go
  • Line 56: warning: cyclomatic complexity 22 of function RunManager() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/subscriber/git/git_subscriber_item.go
  • Line 424: warning: cyclomatic complexity 27 of function (*SubscriberItem).subscribeResource() is high (> 15) (gocyclo)
  • Line 180: warning: cyclomatic complexity 16 of function (*SubscriberItem).doSubscription() is high (> 15) (gocyclo)

• multicloud-operators-subscription/pkg/controller/mcmhub/hub.go
  • Line 55: warning: cyclomatic complexity 21 of function (*ReconcileSubscription).doMCMHubReconcile() is high (> 15) (gocyclo)
  • Line 747: warning: cyclomatic complexity 19 of function (*ReconcileSubscription).updateSubAnnotations() is high (> 15) (gocyclo)

golint68%

Golint is a linter for Go source code.

• multicloud-operators-subscription/pkg/utils/cert.go
  • Line 31: warning: exported function GenerateServerCerts should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/apis/apps/v1/subscription_types.go
  • Line 206: warning: comment on exported type AnsibleJobsStatus should be of the form "AnsibleJobsStatus ..." (with optional leading article) (golint)

• multicloud-operators-subscription/pkg/subscriber/objectbucket/objectbucket_subscriber.go
  • Line 34: warning: exported type SyncSource should have comment or be unexported (golint)
  • Line 140: warning: comment on exported function CreateObjectBucketSubsriber should be of the form "CreateObjectBucketSubsriber ..." (golint)

• multicloud-operators-subscription/pkg/subscriber/namespace/namespace_subscriber.go
  • Line 59: warning: exported type SyncSource should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/kustomize.go
  • Line 59: warning: exported function CheckPackageOverride should have comment or be unexported (golint)
  • Line 67: warning: exported function VerifyAndOverrideKustomize should have comment or be unexported (golint)
  • Line 94: warning: exported function OverrideKustomize should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/subscriber/processdeployable/deployable_queue.go
  • Line 30: warning: exported type SyncSource should have comment or be unexported (golint)
  • Line 36: warning: comment on exported function Units should be of the form "Units ..." (golint)

• multicloud-operators-subscription/pkg/subscriber/namespace/deployable_reconciler.go
  • Line 48: warning: exported function NewNsDeployableReconciler should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/synchronizer/kubernetes/extension.go
  • Line 60: warning: comment on exported method SubscriptionExtension.UpdateHostStatus should be of the form "UpdateHostStatus ..." (golint)

• multicloud-operators-subscription/pkg/synchronizer/kubernetes/sync_client.go
  • Line 33: warning: exported type DplUnit should have comment or be unexported (golint)
  • Line 45: warning: exported type SyncSource should have comment or be unexported (golint)
  • Line 54: warning: exported method KubeSynchronizer.GetInterval should have comment or be unexported (golint)
  • Line 58: warning: exported method KubeSynchronizer.GetLocalClient should have comment or be unexported (golint)
  • Line 111: warning: exported method KubeSynchronizer.IsResourceNamespaced should have comment or be unexported (golint)
  • Line 115: warning: exported method KubeSynchronizer.AddTemplates should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/ansiblejob.go
  • Line 34: warning: exported type Job should have comment or be unexported (golint)
  • Line 286: warning: exported type FormatFunc should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/hub.go
  • Line 458: warning: exported function GetSubscriptionRefChannel should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/hub_git.go
  • Line 46: warning: exported type GitOps should have comment or be unexported (golint)
  • Line 86: warning: exported type RepoRegistery should have comment or be unexported (golint)
  • Line 91: warning: exported type GetCommitFunc should have comment or be unexported (golint)
  • Line 97: warning: exported type HubGitOps should have comment or be unexported (golint)
  • Line 111: warning: exported type HubGitOption should have comment or be unexported (golint)
  • Line 143: warning: exported function NewHookGit should have comment or be unexported (golint)
  • Line 162: warning: comment on exported method HubGitOps.Start should be of the form "Start ..." (golint)
  • Line 174: warning: exported method HubGitOps.GitWatch should have comment or be unexported (golint)
  • Line 247: warning: comment on exported method HubGitOps.GetSubRecords should be of the form "GetSubRecords ..." (golint)
  • Line 252: warning: comment on exported method HubGitOps.GetRepoRecords should be of the form "GetRepoRecords ..." (golint)
  • Line 346: warning: exported method HubGitOps.ResolveLocalGitFolder should have comment or be unexported (golint)
  • Line 350: warning: exported method HubGitOps.RegisterBranch should have comment or be unexported (golint)
  • Line 510: warning: exported method HubGitOps.DeregisterBranch should have comment or be unexported (golint)
  • Line 540: warning: exported function GetLatestRemoteGitCommitID should have comment or be unexported (golint)
  • Line 549: warning: exported method HubGitOps.GetLatestCommitID should have comment or be unexported (golint)
  • Line 567: warning: exported method HubGitOps.GetRepoRootDirctory should have comment or be unexported (golint)
  • Line 578: warning: exported method HubGitOps.DownloadAnsibleHookResource should have comment or be unexported (golint)
  • Line 701: warning: exported method HubGitOps.HasHookFolders should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/mcmhub_controller.go
  • Line 81: warning: exported const INFOLevel should have comment (or a comment on this block) or be unexported (golint)
  • Line 866: warning: exported function PrintHelper should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/subscriber/git/git_subscriber.go
  • Line 36: warning: exported type SyncSource should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/deployable.go
  • Line 123: warning: exported function GetHostDeployable should have comment or be unexported (golint)
  • Line 289: warning: exported function PrintSubscriptionStatus should have comment or be unexported (golint)

• multicloud-operators-subscription/cmd/manager/exec/options.go
  • Line 35: warning: exported var Options should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/spoketoken/spoke_token_controller.go
  • Line 97: warning: comment on exported type ReconcileAgentToken should be of the form "ReconcileAgentToken ..." (with optional leading article) (golint)
  • Line 107: warning: exported type Config should have comment or be unexported (golint)
  • Line 112: warning: comment on exported method ReconcileAgentToken.Reconcile should be of the form "Reconcile ..." (golint)

• multicloud-operators-subscription/pkg/subscriber/helmrepo/helm_subscriber_item.go
  • Line 71: warning: comment on exported method SubscriberItem.Start should be of the form "Start ..." (golint)
  • Line 121: warning: exported method SubscriberItem.Stop should have comment or be unexported (golint)
  • Line 425: warning: exported function GetSubscriptionChartsOnHub should have comment or be unexported (golint)
  • Line 485: warning: exported function ChartIndexToHelmReleases should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/webhook/listener/bitbucket_events.go
  • Line 34: warning: exported const RepoPushEvent should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported type BitBucketPayload should have comment or be unexported (golint)
  • Line 42: warning: exported type BitBucketRepository should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/helmrepo.go
  • Line 47: warning: exported function GetPackageAlias should have comment or be unexported (golint)
  • Line 100: warning: exported function CreateOrUpdateHelmChart should have comment or be unexported (golint)
  • Line 220: warning: exported function Override should have comment or be unexported (golint)
  • Line 271: warning: exported function PkgToReleaseCRName should have comment or be unexported (golint)
  • Line 290: warning: exported function CreateHelmCRDeployable should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/kubernetes.go
  • Line 94: warning: exported function NamespacedNameFormat should have comment or be unexported (golint)
  • Line 128: warning: exported function GetComponentNamespace should have comment or be unexported (golint)
  • Line 137: warning: exported function BuildKubeClient should have comment or be unexported (golint)

• multicloud-operators-subscription/version/version.go
  • Line 18: warning: exported var Version should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/aws/objectstore.go
  • Line 49: warning: comment on exported const DeployableGenerateNameMeta should be of the form "DeployableGenerateNameMeta ..." (golint)
  • Line 51: warning: comment on exported const DployableMateGenerateNameKey should be of the form "DployableMateGenerateNameKey ..." (golint)
  • Line 53: warning: comment on exported const DeployableVersionMeta should be of the form "DeployableVersionMeta ..." (golint)
  • Line 55: warning: comment on exported const DeployableMetaVersionKey should be of the form "DeployableMetaVersionKey ..." (golint)
  • Line 79: warning: exported type DeployableObject should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/webhook/listener/gitlab_events.go
  • Line 36: warning: exported const GitLabPushEvents should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: exported type GitLabPayload should have comment or be unexported (golint)
  • Line 45: warning: exported type GitLabRepository should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/webhook/listener/webhook_listner.go
  • Line 49: warning: exported const GithubEventHeader should have comment (or a comment on this block) or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/hook.go
  • Line 44: warning: exported const PrehookDirSuffix should have comment (or a comment on this block) or be unexported (golint)
  • Line 87: warning: exported type Hooks should have comment or be unexported (golint)
  • Line 96: warning: exported method Hooks.ConstructStatus should have comment or be unexported (golint)
  • Line 134: warning: exported type AnsibleHooks should have comment or be unexported (golint)
  • Line 149: warning: exported type HookOps should have comment or be unexported (golint)
  • Line 163: warning: exported function NewAnsibleHooks should have comment or be unexported (golint)
  • Line 179: warning: exported type AppliedInstance should have comment or be unexported (golint)
  • Line 184: warning: exported method AnsibleHooks.GetLastAppliedInstance should have comment or be unexported (golint)
  • Line 199: warning: exported method AnsibleHooks.ResetGitOps should have comment or be unexported (golint)
  • Line 203: warning: exported method AnsibleHooks.AppendStatusToSubscription should have comment or be unexported (golint)
  • Line 218: warning: exported method AnsibleHooks.AppendPreHookStatusToSubscription should have comment or be unexported (golint)
  • Line 233: warning: exported method AnsibleHooks.SetSuffixFunc should have comment or be unexported (golint)
  • Line 241: warning: exported method AnsibleHooks.DeregisterSubscription should have comment or be unexported (golint)
  • Line 250: warning: exported method AnsibleHooks.RegisterSubscription should have comment or be unexported (golint)
  • Line 304: warning: exported type SuffixFunc should have comment or be unexported (golint)
  • Line 398: warning: exported function GetReferenceString should have comment or be unexported (golint)
  • Line 483: warning: exported method AnsibleHooks.ApplyPreHooks should have comment or be unexported (golint)
  • Line 493: warning: exported type EqualSub should have comment or be unexported (golint)
  • Line 536: warning: exported method AnsibleHooks.IsPreHooksCompleted should have comment or be unexported (golint)
  • Line 550: warning: exported method AnsibleHooks.HasHooks should have comment or be unexported (golint)
  • Line 575: warning: exported method AnsibleHooks.ApplyPostHooks should have comment or be unexported (golint)
  • Line 584: warning: exported method AnsibleHooks.IsPostHooksCompleted should have comment or be unexported (golint)
  • Line 611: warning: comment on exported function GetClustersByPlacement should be of the form "GetClustersByPlacement ..." (golint)

• multicloud-operators-subscription/pkg/apis/apps/v1/zz_generated.openapi.go
  • Line 26: warning: exported function GetOpenAPIDefinitions should have comment or be unexported (golint)
  • Line 32: warning: don't use underscores in Go names; func schema_pkg_apis_apps_v1_Subscription should be schemaPkgApisAppsV1Subscription (golint)

• multicloud-operators-subscription/pkg/synchronizer/kubernetes/promethues.go
  • Line 9: warning: exported const Synchronizer should have comment (or a comment on this block) or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/mcmhub/metaupdate.go
  • Line 114: warning: exported function ObjectString should have comment or be unexported (golint)
  • Line 118: warning: exported function UpdateHelmTopoAnnotation should have comment or be unexported (golint)
  • Line 424: warning: exported function GetDeployableTemplateAsUnstructrure should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/subscription.go
  • Line 65: warning: exported function IsSubscriptionResourceChanged should have comment or be unexported (golint)
  • Line 91: warning: exported function IsSubscriptionBasicChanged should have comment or be unexported (golint)
  • Line 158: warning: comment on exported function FilterOutTimeRelatedFields should be of the form "FilterOutTimeRelatedFields ..." (golint)
  • Line 226: warning: exported function IsHubRelatedStatusChanged should have comment or be unexported (golint)
  • Line 487: warning: exported function IsEqualSubScriptionStatus should have comment or be unexported (golint)
  • Line 663: warning: exported function SkipOrUpdateSubscriptionStatus should have comment or be unexported (golint)
  • Line 780: warning: comment on exported function CanPassPackageFilter should be of the form "CanPassPackageFilter ..." (golint)
  • Line 966: warning: comment on exported function RemoveSubOwnerRef should be of the form "RemoveSubOwnerRef ..." (golint)
  • Line 986: warning: exported function IsSubscriptionBeDeleted should have comment or be unexported (golint)
  • Line 1099: warning: exported function SetPartOfLabel should have comment or be unexported (golint)
  • Line 1106: warning: exported function AddPartOfLabel should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/subscriber/objectbucket/objectbucket_subscriber_item.go
  • Line 42: warning: exported var SubscriptionGVK should have comment or be unexported (golint)
  • Line 56: warning: comment on exported method SubscriberItem.Start should be of the form "Start ..." (golint)

• multicloud-operators-subscription/pkg/controller/subscription/lease_controller.go
  • Line 41: warning: exported method LeaseReconciler.Reconcile should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/controller/subscription/reference.go
  • Line 35: warning: exported var SecretKindStr should have comment or be unexported (golint)
  • Line 36: warning: exported var ConfigMapKindStr should have comment or be unexported (golint)
  • Line 37: warning: exported var SubscriptionGVK should have comment or be unexported (golint)
  • Line 60: warning: exported method ReconcileSubscription.ListAndDeployReferredObject should have comment or be unexported (golint)
  • Line 169: warning: exported method ReconcileSubscription.DeleteReferredObjects should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/label.go
  • Line 26: warning: exported function MatchLabelForSubAndDpl should have comment or be unexported (golint)
  • Line 60: warning: exported function LabelChecker should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/update_crds.go
  • Line 28: warning: exported var DefaultRepos should have comment or be unexported (golint)
  • Line 60: warning: exported function UpdateCRDs should have comment or be unexported (golint)

• multicloud-operators-subscription/cmd/manager/exec/manager.go
  • Line 52: warning: exported const AddonName should have comment (or a comment on this block) or be unexported (golint)
  • Line 56: warning: exported function RunManager should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/utils/gitrepo.go
  • Line 74: warning: comment on exported type KubeResource should be of the form "KubeResource ..." (with optional leading article) (golint)
  • Line 79: warning: exported type GitCloneOption should have comment or be unexported (golint)
  • Line 103: warning: exported type Kube should have comment or be unexported (golint)
  • Line 105: warning: exported function KubeResourceParser should have comment or be unexported (golint)
  • Line 440: warning: exported function GetSubscriptionBranchRef should have comment or be unexported (golint)
  • Line 485: warning: comment on exported function GetChannelConfigMap should be of the form "GetChannelConfigMap ..." (golint)
  • Line 505: warning: exported function ParseChannelSecret should have comment or be unexported (golint)
  • Line 543: warning: exported type SkipFunc should have comment or be unexported (golint)
  • Line 684: warning: exported function SkipHooksOnManaged should have comment or be unexported (golint)
  • Line 716: warning: exported function IsClusterAdmin should have comment or be unexported (golint)
  • Line 829: warning: exported function GetLatestCommitID should have comment or be unexported (golint)
  • Line 851: warning: exported function ParseYAML should have comment or be unexported (golint)

• multicloud-operators-subscription/pkg/subscriber/helmrepo/hemrepo_subscriber.go
  • Line 34: warning: exported type SyncSource should have comment or be unexported (golint)
  • Line 162: warning: comment on exported function CreateHelmRepoSubsriber should be of the form "CreateHelmRepoSubsriber ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

• multicloud-operators-subscription/pkg/subscriber/helmrepo/helm_subscriber_item.go
  • Line 171: warning: ineffectual assignment to existsHelmRelease (ineffassign)

• multicloud-operators-subscription/pkg/utils/subscription.go
  • Line 1034: warning: ineffectual assignment to rate (ineffassign)

• multicloud-operators-subscription/pkg/controller/mcmhub/hub.go
  • Line 89: warning: ineffectual assignment to updateSubDplAnno (ineffassign)

• multicloud-operators-subscription/pkg/controller/mcmhub/mcmhub_controller.go
  • Line 600: warning: ineffectual assignment to returnErr (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!