Preparing report...

Report for github.com/openshift/assisted-service

A+    Excellent!    Found 191 issues across 350 files

Tweet

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint45%

Golint is a linter for Go source code.

    • assisted-service/internal/common/image_status.go
    • Line 9: warning: exported type ImageStatuses should have comment or be unexported (golint)
    • Line 11: warning: exported function UnmarshalImageStatuses should have comment or be unexported (golint)
    • Line 22: warning: exported function MarshalImageStatuses should have comment or be unexported (golint)
    • Line 33: warning: exported function ImageStatusExists should have comment or be unexported (golint)
    • Line 38: warning: exported function GetImageStatus should have comment or be unexported (golint)
    • Line 43: warning: exported function SetImageStatus should have comment or be unexported (golint)
    • Line 47: warning: exported function DeleteImageStatus should have comment or be unexported (golint)
    • assisted-service/internal/controller/controllers/images.go
    • Line 24: warning: exported const OpenshiftVersionsEnvVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported function ServiceImage should have comment or be unexported (golint)
    • Line 31: warning: exported function ImageServiceImage should have comment or be unexported (golint)
    • Line 35: warning: exported function DatabaseImage should have comment or be unexported (golint)
    • Line 39: warning: exported function AgentImage should have comment or be unexported (golint)
    • Line 43: warning: exported function ControllerImage should have comment or be unexported (golint)
    • Line 47: warning: exported function InstallerImage should have comment or be unexported (golint)
    • Line 51: warning: exported function ServiceAccountName should have comment or be unexported (golint)
    • Line 55: warning: comment on exported function OpenshiftVersions should be of the form "OpenshiftVersions ..." (golint)
    • Line 62: warning: exported function OSImages should have comment or be unexported (golint)
    • Line 66: warning: exported function MustGatherImages should have comment or be unexported (golint)
    • assisted-service/internal/bminventory/inventory.go
    • Line 75: warning: exported const DefaultUser should have comment or be unexported (golint)
    • Line 77: warning: exported const WindowBetweenRequestsInSeconds should have comment or be unexported (golint)
    • Line 77: warning: var WindowBetweenRequestsInSeconds is of type time.Duration; don't use unit-specific suffix "Seconds" (golint)
    • Line 81: warning: exported const MediaDisconnected should have comment (or a comment on this block) or be unexported (golint)
    • Line 82: warning: comment on exported const ContainerAlreadyRunningExitCode should be of the form "ContainerAlreadyRunningExitCode ..." (golint)
    • Line 86: warning: exported type Config should have comment or be unexported (golint)
    • Line 114: warning: exported type Interactivity should have comment or be unexported (golint)
    • Line 117: warning: exported const Interactive should have comment (or a comment on this block) or be unexported (golint)
    • Line 121: warning: exported type OCPClusterAPI should have comment or be unexported (golint)
    • Line 125: warning: comment on exported type InstallerInternals should be of the form "InstallerInternals ..." (with optional leading article) (golint)
    • Line 164: warning: comment on exported type CRDUtils should be of the form "CRDUtils ..." (with optional leading article) (golint)
    • Line 197: warning: exported function NewBareMetalInventory should have comment or be unexported (golint)
    • Line 1253: warning: don't use underscores in Go names; var cluster_updates should be clusterUpdates (golint)
    • Line 1574: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 3010: warning: error should be the last type when returning multiple items (golint)
    • Line 3166: warning: don't use underscores in Go names; var host_count should be hostCount (golint)
    • Line 3513: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 3712: warning: context.Context should be the first parameter of a function (golint)
    • Line 3738: warning: context.Context should be the first parameter of a function (golint)
    • Line 3929: warning: context.Context should be the first parameter of a function (golint)
    • Line 6227: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 6491: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/pkg/leader/leaderelector.go
    • Line 19: warning: exported type Config should have comment or be unexported (golint)
    • Line 28: warning: exported type Leader should have comment or be unexported (golint)
    • Line 31: warning: exported type ElectorInterface should have comment or be unexported (golint)
    • Line 37: warning: exported type DummyElector should have comment or be unexported (golint)
    • Line 39: warning: exported method DummyElector.StartLeaderElection should have comment or be unexported (golint)
    • Line 43: warning: exported method DummyElector.IsLeader should have comment or be unexported (golint)
    • Line 47: warning: exported method DummyElector.RunWithLeader should have comment or be unexported (golint)
    • Line 53: warning: exported type Elector should have comment or be unexported (golint)
    • Line 61: warning: exported function NewElector should have comment or be unexported (golint)
    • Line 66: warning: exported method Elector.IsLeader should have comment or be unexported (golint)
    • Line 70: warning: comment on exported method Elector.RunWithLeader should be of the form "RunWithLeader ..." (golint)
    • Line 101: warning: exported method Elector.StartLeaderElection should have comment or be unexported (golint)
    • assisted-service/internal/cluster/validator.go
    • Line 18: warning: exported type ValidationStatus should have comment or be unexported (golint)
    • Line 21: warning: exported const ValidationSuccess should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: exported const ApiVipName should have comment (or a comment on this block) or be unexported (golint)
    • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 209: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 260: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 314: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/internal/metrics/metricsManager.go
    • Line 77: warning: exported const UnknownHWValue should have comment (or a comment on this block) or be unexported (golint)
    • Line 101: warning: exported type API should have comment or be unexported (golint)
    • Line 121: warning: exported type MetricsManager should have comment or be unexported (golint)
    • Line 152: warning: exported function NewMetricsManager should have comment or be unexported (golint)
    • Line 366: warning: exported method MetricsManager.ClusterRegistered should have comment or be unexported (golint)
    • Line 370: warning: exported method MetricsManager.HostValidationFailed should have comment or be unexported (golint)
    • Line 374: warning: exported method MetricsManager.HostValidationChanged should have comment or be unexported (golint)
    • Line 378: warning: exported method MetricsManager.ClusterValidationFailed should have comment or be unexported (golint)
    • Line 382: warning: exported method MetricsManager.ClusterValidationChanged should have comment or be unexported (golint)
    • Line 386: warning: exported method MetricsManager.InstallationStarted should have comment or be unexported (golint)
    • Line 390: warning: exported method MetricsManager.ClusterHostInstallationCount should have comment or be unexported (golint)
    • Line 394: warning: exported method MetricsManager.ClusterInstallationFinished should have comment or be unexported (golint)
    • Line 404: warning: exported method MetricsManager.Duration should have comment or be unexported (golint)
    • Line 408: warning: exported method MetricsManager.DiskSyncDuration should have comment or be unexported (golint)
    • Line 412: warning: exported method MetricsManager.ImagePullStatus should have comment or be unexported (golint)
    • Line 416: warning: exported method MetricsManager.ReportHostInstallationMetrics should have comment or be unexported (golint)
    • Line 520: warning: exported method MetricsManager.FileSystemUsage should have comment or be unexported (golint)
    • Line 524: warning: exported method MetricsManager.MonitoredHostsCount should have comment or be unexported (golint)
    • Line 528: warning: exported method MetricsManager.MonitoredClusterCount should have comment or be unexported (golint)
    • Line 532: warning: exported method MetricsManager.NetworkLatencyBetweenHosts should have comment or be unexported (golint)
    • Line 535: warning: exported method MetricsManager.PacketLossBetweenHosts should have comment or be unexported (golint)
    • assisted-service/subsystem/metrics_test.go
    • Line 404: warning: don't use underscores in Go names; var host_mem_cpu_evs should be hostMemCPUEvs (golint)
    • Line 406: warning: don't use underscores in Go names; var host_mem_cpu_props should be hostMemCPUProps (golint)
    • Line 412: warning: don't use underscores in Go names; var disk_size_type_evs should be diskSizeTypeEvs (golint)
    • Line 414: warning: don't use underscores in Go names; var disk_size_type_props should be diskSizeTypeProps (golint)
    • Line 420: warning: don't use underscores in Go names; var nic_speed_evs should be nicSpeedEvs (golint)
    • Line 422: warning: don't use underscores in Go names; var nic_speed_props should be nicSpeedProps (golint)
    • assisted-service/internal/bminventory/inventory_test.go
    • Line 105: warning: don't use underscores in Go names; var discovery_ignition_3_1 should be discoveryIgnition3_1 (golint)
    • Line 1579: warning: don't use underscores in Go names; var unregistered_hostID should be unregisteredHostID (golint)
    • Line 1650: warning: don't use underscores in Go names; var unregistered_hostID should be unregisteredHostID (golint)
    • assisted-service/internal/common/test_configuration.go
    • Line 10: warning: should not use dot imports (golint)
    • Line 18: warning: exported type TestNetworking should have comment or be unexported (golint)
    • Line 26: warning: exported type TestConfiguration should have comment or be unexported (golint)
    • Line 50: warning: exported const TestDiskId should have comment or be unexported (golint)
    • Line 51: warning: exported const TestDiskPath should have comment or be unexported (golint)
    • Line 54: warning: exported var OpenShiftVersion should have comment or be unexported (golint)
    • Line 64: warning: comment on exported var TestDefaultConfig should be of the form "TestDefaultConfig ..." (golint)
    • Line 117: warning: exported var TestNTPSourceSynced should have comment or be unexported (golint)
    • Line 118: warning: exported var TestNTPSourceUnsynced should have comment or be unexported (golint)
    • Line 119: warning: exported var TestImageStatusesSuccess should have comment or be unexported (golint)
    • Line 126: warning: exported var TestImageStatusesFailure should have comment or be unexported (golint)
    • Line 131: warning: exported var DomainAPI should have comment or be unexported (golint)
    • Line 132: warning: exported var DomainAPIInternal should have comment or be unexported (golint)
    • Line 133: warning: exported var DomainApps should have comment or be unexported (golint)
    • Line 134: warning: exported var WildcardDomain should have comment or be unexported (golint)
    • Line 136: warning: exported var DomainResolution should have comment or be unexported (golint)
    • Line 158: warning: exported var TestDomainNameResolutionSuccess should have comment or be unexported (golint)
    • Line 161: warning: exported var TestDefaultRouteConfiguration should have comment or be unexported (golint)
    • Line 163: warning: exported var TestIPv4Networking should have comment or be unexported (golint)
    • Line 171: warning: exported var TestIPv6Networking should have comment or be unexported (golint)
    • Line 179: warning: exported var TestDualStackNetworking should have comment or be unexported (golint)
    • Line 187: warning: exported function IncrementCidrIP should have comment or be unexported (golint)
    • Line 193: warning: exported function IncrementIPString should have comment or be unexported (golint)
    • Line 199: warning: exported function IncrementIP should have comment or be unexported (golint)
    • Line 208: warning: exported function IncrementCidrMask should have comment or be unexported (golint)
    • Line 215: warning: exported function GenerateTestDefaultInventory should have comment or be unexported (golint)
    • Line 239: warning: exported function GenerateTestDefaultVmwareInventory should have comment or be unexported (golint)
    • Line 266: warning: exported function CreateWildcardDomainNameResolutionReply should have comment or be unexported (golint)
    • Line 283: warning: exported type NetAddress should have comment or be unexported (golint)
    • Line 289: warning: exported function GenerateTestInventoryWithNetwork should have comment or be unexported (golint)
    • Line 310: warning: exported function GenerateTestInventoryWithSetNetwork should have comment or be unexported (golint)
    • Line 334: warning: exported function GenerateTestInventoryWithTpmVersion should have comment or be unexported (golint)
    • Line 347: warning: exported function GetTestLog should have comment or be unexported (golint)
    • Line 353: warning: exported type StaticNetworkConfig should have comment or be unexported (golint)
    • Line 358: warning: exported type DNSResolverConfig should have comment or be unexported (golint)
    • Line 361: warning: exported type DNSResolver should have comment or be unexported (golint)
    • Line 364: warning: exported type Address should have comment or be unexported (golint)
    • Line 368: warning: exported type Ipv4 should have comment or be unexported (golint)
    • Line 373: warning: exported type Interfaces should have comment or be unexported (golint)
    • Line 379: warning: exported type RouteConfig should have comment or be unexported (golint)
    • Line 385: warning: exported type Routes should have comment or be unexported (golint)
    • Line 389: warning: exported function FormatStaticConfigHostYAML should have comment or be unexported (golint)
    • assisted-service/internal/controller/controllers/crd_utils.go
    • Line 19: warning: exported type CRDUtils should have comment or be unexported (golint)
    • Line 24: warning: exported function NewCRDUtils should have comment or be unexported (golint)
    • Line 167: warning: exported type DummyCRDUtils should have comment or be unexported (golint)
    • Line 169: warning: exported function NewDummyCRDUtils should have comment or be unexported (golint)
    • Line 173: warning: exported method DummyCRDUtils.CreateAgentCR should have comment or be unexported (golint)
    • Line 177: warning: exported function AddLabel should have comment or be unexported (golint)
    • assisted-service/internal/common/error_utils.go
    • Line 16: warning: exported type NotFound should have comment or be unexported (golint)
    • Line 22: warning: exported function GenerateError should have comment or be unexported (golint)
    • Line 32: warning: exported function GenerateInternalFromError should have comment or be unexported (golint)
    • Line 42: warning: exported function GenerateInfraError should have comment or be unexported (golint)
    • Line 49: warning: exported type ApiErrorResponse should have comment or be unexported (golint)
    • Line 58: warning: exported method ApiErrorResponse.WriteResponse should have comment or be unexported (golint)
    • Line 65: warning: exported method ApiErrorResponse.StatusCode should have comment or be unexported (golint)
    • Line 69: warning: exported function NewApiError should have comment or be unexported (golint)
    • Line 76: warning: exported type InfraErrorResponse should have comment or be unexported (golint)
    • Line 80: warning: exported method InfraErrorResponse.WriteResponse should have comment or be unexported (golint)
    • Line 87: warning: exported function NewInfraError should have comment or be unexported (golint)
    • Line 96: warning: exported function IsKnownError should have comment or be unexported (golint)
    • Line 107: warning: exported function GenerateErrorResponder should have comment or be unexported (golint)
    • Line 124: warning: exported function GenerateErrorResponderWithDefault should have comment or be unexported (golint)
    • Line 135: warning: exported function ApiErrorWithDefaultInfraError should have comment or be unexported (golint)
    • assisted-service/internal/cluster/transition.go
    • Line 46: warning: exported type TransitionArgsCancelInstallation should have comment or be unexported (golint)
    • Line 70: warning: exported type TransitionArgsResetCluster should have comment or be unexported (golint)
    • Line 100: warning: exported type TransitionArgsPrepareForInstallation should have comment or be unexported (golint)
    • Line 130: warning: exported type OperatorsNamesByStatus should have comment or be unexported (golint)
    • Line 131: warning: exported type MonitoredOperatorStatuses should have comment or be unexported (golint)
    • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 249: warning: exported type TransitionArgsHandlePreInstallationError should have comment or be unexported (golint)
    • Line 266: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 276: warning: exported type TransitionArgsRefreshCluster should have comment or be unexported (golint)
    • Line 291: warning: exported function If should have comment or be unexported (golint)
    • assisted-service/pkg/auth/authenticator.go
    • Line 13: warning: exported type AuthType should have comment or be unexported (golint)
    • Line 16: warning: exported const TypeEmpty should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported type Authenticator should have comment or be unexported (golint)
    • Line 30: warning: exported type Config should have comment or be unexported (golint)
    • Line 40: warning: exported function NewAuthenticator should have comment or be unexported (golint)
    • assisted-service/api/hiveextension/v1beta1/agentclusterinstall_types.go
    • Line 11: warning: exported const ClusterSpecSyncedCondition should have comment (or a comment on this block) or be unexported (golint)
    • Line 184: warning: exported type DebugInfo should have comment or be unexported (golint)
    • Line 271: warning: exported const MasterAgentMachinePool should have comment (or a comment on this block) or be unexported (golint)
    • Line 291: warning: comment on exported type AgentClusterInstallList should be of the form "AgentClusterInstallList ..." (with optional leading article) (golint)
    • assisted-service/internal/sqllite/query.go
    • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 11: warning: comment on exported type Query should be of the form "Query ..." (with optional leading article) (golint)
    • Line 20: warning: exported function NewQuery should have comment or be unexported (golint)
    • assisted-service/internal/constants/files.go
    • Line 3: warning: exported const Kubeconfig should have comment or be unexported (golint)
    • Line 4: warning: exported const KubeconfigNoIngress should have comment or be unexported (golint)
    • Line 6: warning: comment on exported const AppsSubDomainNameHostDNSValidation should be of the form "AppsSubDomainNameHostDNSValidation ..." (golint)
    • Line 8: warning: exported const APIName should have comment or be unexported (golint)
    • Line 9: warning: exported const APIInternalName should have comment or be unexported (golint)
    • Line 11: warning: comment on exported const DNSWildcardFalseDomainName should be of the form "DNSWildcardFalseDomainName ..." (golint)
    • assisted-service/internal/events/eventstest/events_test_utils.go
    • Line 16: warning: exported function NewEventMatcher should have comment or be unexported (golint)
    • Line 25: warning: exported function WithNameMatcher should have comment or be unexported (golint)
    • Line 38: warning: exported function WithClusterIdMatcher should have comment or be unexported (golint)
    • Line 54: warning: exported function WithHostIdMatcher should have comment or be unexported (golint)
    • Line 67: warning: exported function WithInfraEnvIdMatcher should have comment or be unexported (golint)
    • Line 80: warning: exported function WithSeverityMatcher should have comment or be unexported (golint)
    • Line 93: warning: exported function WithMessageMatcher should have comment or be unexported (golint)
    • Line 106: warning: exported function WithMessageContainsMatcher should have comment or be unexported (golint)
    • Line 116: warning: exported type EventMatcher should have comment or be unexported (golint)
    • assisted-service/internal/common/common.go
    • Line 17: warning: exported const EnvConfigPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: comment on exported const Ipv6DuidDiscoveryConf should be of the form "Ipv6DuidDiscoveryConf ..." (golint)
    • Line 49: warning: comment on exported const Ipv6DuidRuntimeConf should be of the form "Ipv6DuidRuntimeConf ..." (golint)
    • Line 58: warning: comment on exported const UnmanagedResolvConf should be of the form "UnmanagedResolvConf ..." (golint)
    • Line 66: warning: comment on exported const NMDebugModeConf should be of the form "NMDebugModeConf ..." (golint)
    • Line 74: warning: exported function AllStrings should have comment or be unexported (golint)
    • Line 98: warning: exported function AreMastersSchedulable should have comment or be unexported (golint)
    • Line 102: warning: exported function GetEffectiveRole should have comment or be unexported (golint)
    • Line 109: warning: exported function GetConsoleUrl should have comment or be unexported (golint)
    • Line 113: warning: exported function IsNtpSynced should have comment or be unexported (golint)
    • Line 138: warning: exported function GetProxyConfigs should have comment or be unexported (golint)
    • Line 145: warning: exported function GetNetworksCidrs should have comment or be unexported (golint)
    • Line 155: warning: exported function GetNetworkCidrAttr should have comment or be unexported (golint)
    • Line 225: warning: exported function GetClusterNTPSources should have comment or be unexported (golint)
    • Line 232: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 237: warning: exported function GetHostNTPSources should have comment or be unexported (golint)
    • assisted-service/internal/common/inventory.go
    • Line 9: warning: exported function MarshalInventory should have comment or be unexported (golint)
    • Line 12: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 17: warning: exported function UnmarshalInventory should have comment or be unexported (golint)
    • assisted-service/pkg/conversions/conversions.go
    • Line 9: warning: exported function GbToBytes should have comment or be unexported (golint)
    • Line 13: warning: exported function GibToBytes should have comment or be unexported (golint)
    • Line 17: warning: exported function GibToMib should have comment or be unexported (golint)
    • Line 21: warning: exported function MibToGiB should have comment or be unexported (golint)
    • Line 25: warning: exported function BytesToGiB should have comment or be unexported (golint)
    • Line 29: warning: exported function MibToBytes should have comment or be unexported (golint)
    • Line 33: warning: exported function BytesToMib should have comment or be unexported (golint)
    • Line 37: warning: exported function GbToMib should have comment or be unexported (golint)
    • Line 56: warning: exported const KB should have comment (or a comment on this block) or be unexported (golint)
    • Line 63: warning: exported function BytesToString should have comment or be unexported (golint)
    • assisted-service/internal/hardware/validator.go
    • Line 28: warning: comment on exported type Validator should be of the form "Validator ..." (with optional leading article) (golint)
    • Line 43: warning: exported function NewValidator should have comment or be unexported (golint)
    • Line 56: warning: exported type ValidatorCfg should have comment or be unexported (golint)
    • assisted-service/internal/events/event.go
    • Line 19: warning: exported type Sender should have comment or be unexported (golint)
    • Line 38: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
    • Line 48: warning: exported var DefaultEventCategories should have comment or be unexported (golint)
    • Line 52: warning: exported type Events should have comment or be unexported (golint)
    • Line 57: warning: exported function New should have comment or be unexported (golint)
    • Line 155: warning: exported method Events.SendClusterEvent should have comment or be unexported (golint)
    • Line 159: warning: exported method Events.SendClusterEventAtTime should have comment or be unexported (golint)
    • Line 164: warning: exported method Events.SendHostEvent should have comment or be unexported (golint)
    • Line 168: warning: exported method Events.SendHostEventAtTime should have comment or be unexported (golint)
    • Line 174: warning: exported method Events.SendInfraEnvEvent should have comment or be unexported (golint)
    • Line 178: warning: exported method Events.SendInfraEnvEventAtTime should have comment or be unexported (golint)
    • Line 183: warning: exported method Events.AddEvent should have comment or be unexported (golint)
    • Line 188: warning: exported method Events.AddMetricsEvent should have comment or be unexported (golint)
    • Line 193: warning: exported method Events.V2AddEvent should have comment or be unexported (golint)
    • Line 198: warning: exported method Events.V2AddMetricsEvent should have comment or be unexported (golint)
    • Line 203: warning: exported method Events.GetEvents should have comment or be unexported (golint)
    • Line 247: warning: exported method Events.V2GetEvents should have comment or be unexported (golint)
    • Line 289: warning: exported type BaseEvent should have comment or be unexported (golint)
    • Line 295: warning: exported type ClusterEvent should have comment or be unexported (golint)
    • Line 300: warning: exported type HostEvent should have comment or be unexported (golint)
    • Line 307: warning: exported type InfraEnvEvent should have comment or be unexported (golint)
    • assisted-service/pkg/error/error_utils.go
    • Line 9: warning: exported type AssistedServiceErrorAPI should have comment or be unexported (golint)
    • Line 14: warning: exported type AssistedServiceInfraErrorAPI should have comment or be unexported (golint)
    • Line 38: warning: exported function GetAssistedError should have comment or be unexported (golint)
    • assisted-service/internal/cluster/validation_id.go
    • Line 11: warning: exported type ValidationID should have comment or be unexported (golint)
    • Line 18: warning: exported const IsMachineCidrDefined should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported method ValidationID.Category should have comment or be unexported (golint)
    • assisted-service/pkg/s3wrapper/upload_iso.go
    • Line 24: warning: exported type ISOUploaderAPI should have comment or be unexported (golint)
    • Line 30: warning: exported type ISOUploader should have comment or be unexported (golint)
    • Line 45: warning: exported function NewISOUploader should have comment or be unexported (golint)
    • Line 49: warning: exported method ISOUploader.UploadISO should have comment or be unexported (golint)
    • assisted-service/internal/network/lease_utils.go
    • Line 13: warning: exported function VerifyLease should have comment or be unexported (golint)
    • Line 24: warning: exported function FormatLease should have comment or be unexported (golint)
    • Line 37: warning: exported function GetEncodedApiVipLease should have comment or be unexported (golint)
    • Line 41: warning: exported function GetEncodedIngressVipLease should have comment or be unexported (golint)
    • assisted-service/pkg/generator/generator.go
    • Line 19: warning: exported type InstallConfigGenerator should have comment or be unexported (golint)
    • Line 23: warning: comment on exported type ISOInstallConfigGenerator should be of the form "ISOInstallConfigGenerator ..." (with optional leading article) (golint)
    • Line 28: warning: exported type Config should have comment or be unexported (golint)
    • Line 44: warning: exported function New should have comment or be unexported (golint)
    • assisted-service/pkg/k8sclient/k8s_utils.go
    • Line 15: warning: exported function GetApiVIP should have comment or be unexported (golint)
    • Line 43: warning: exported function GetBaseDNSDomain should have comment or be unexported (golint)
    • Line 59: warning: exported function GetMachineNetworkCIDR should have comment or be unexported (golint)
    • Line 93: warning: exported function GetSSHPublicKey should have comment or be unexported (golint)
    • Line 109: warning: exported function GetClusterVersion should have comment or be unexported (golint)
    • Line 115: warning: exported function IsNodeReady should have comment or be unexported (golint)
    • Line 124: warning: exported function GetNodeRole should have comment or be unexported (golint)
    • Line 133: warning: exported function GetNodeInternalIP should have comment or be unexported (golint)
    • Line 141: warning: exported function GetDataByKeyFromSecret should have comment or be unexported (golint)
    • assisted-service/internal/host/hostutil/update_host.go
    • Line 19: warning: exported var ResetLogsField should have comment or be unexported (golint)
    • Line 21: warning: exported function UpdateHostProgress should have comment or be unexported (golint)
    • Line 35: warning: exported function UpdateLogsProgress should have comment or be unexported (golint)
    • Line 55: warning: exported function UpdateHostStatus should have comment or be unexported (golint)
    • Line 86: warning: exported function UpdateHost should have comment or be unexported (golint)
    • assisted-service/pkg/s3wrapper/filesystem.go
    • Line 27: warning: exported type FSClient should have comment or be unexported (golint)
    • Line 34: warning: exported function NewFSClient should have comment or be unexported (golint)
    • Line 51: warning: exported method FSClient.IsAwsS3 should have comment or be unexported (golint)
    • Line 55: warning: exported method FSClient.CreateBucket should have comment or be unexported (golint)
    • Line 59: warning: exported method FSClient.CreatePublicBucket should have comment or be unexported (golint)
    • Line 63: warning: exported method FSClient.Upload should have comment or be unexported (golint)
    • Line 80: warning: exported method FSClient.UploadFile should have comment or be unexported (golint)
    • Line 94: warning: exported method FSClient.UploadFileToPublicBucket should have comment or be unexported (golint)
    • Line 98: warning: exported method FSClient.UploadISO should have comment or be unexported (golint)
    • Line 111: warning: exported method FSClient.UploadStream should have comment or be unexported (golint)
    • Line 163: warning: exported method FSClient.UploadStreamToPublicBucket should have comment or be unexported (golint)
    • Line 167: warning: exported method FSClient.Download should have comment or be unexported (golint)
    • Line 189: warning: exported method FSClient.DownloadPublic should have comment or be unexported (golint)
    • Line 193: warning: exported method FSClient.DoesObjectExist should have comment or be unexported (golint)
    • Line 208: warning: exported method FSClient.DoesPublicObjectExist should have comment or be unexported (golint)
    • Line 212: warning: exported method FSClient.DeleteObject should have comment or be unexported (golint)
    • Line 226: warning: exported method FSClient.GetObjectSizeBytes should have comment or be unexported (golint)
    • Line 235: warning: exported method FSClient.GeneratePresignedDownloadURL should have comment or be unexported (golint)
    • Line 239: warning: exported method FSClient.UpdateObjectTimestamp should have comment or be unexported (golint)
    • Line 253: warning: exported method FSClient.ExpireObjects should have comment or be unexported (golint)
    • Line 289: warning: exported method FSClient.ListObjectsByPrefix should have comment or be unexported (golint)
    • Line 381: warning: exported method FSClient.GetBaseIsoObject should have comment or be unexported (golint)
    • Line 390: warning: exported method FSClient.GetMinimalIsoObjectName should have comment or be unexported (golint)
    • Line 399: warning: exported type FSClientDecorator should have comment or be unexported (golint)
    • Line 453: warning: exported method FSClientDecorator.IsAwsS3 should have comment or be unexported (golint)
    • Line 457: warning: exported method FSClientDecorator.CreateBucket should have comment or be unexported (golint)
    • Line 461: warning: exported method FSClientDecorator.Upload should have comment or be unexported (golint)
    • Line 469: warning: exported method FSClientDecorator.UploadStream should have comment or be unexported (golint)
    • Line 477: warning: exported method FSClientDecorator.UploadFile should have comment or be unexported (golint)
    • Line 485: warning: exported method FSClientDecorator.UploadISO should have comment or be unexported (golint)
    • Line 493: warning: exported method FSClientDecorator.Download should have comment or be unexported (golint)
    • Line 497: warning: exported method FSClientDecorator.DoesObjectExist should have comment or be unexported (golint)
    • Line 501: warning: exported method FSClientDecorator.DeleteObject should have comment or be unexported (golint)
    • Line 509: warning: exported method FSClientDecorator.GetObjectSizeBytes should have comment or be unexported (golint)
    • Line 513: warning: exported method FSClientDecorator.GeneratePresignedDownloadURL should have comment or be unexported (golint)
    • Line 517: warning: exported method FSClientDecorator.UpdateObjectTimestamp should have comment or be unexported (golint)
    • Line 521: warning: exported method FSClientDecorator.ExpireObjects should have comment or be unexported (golint)
    • Line 526: warning: exported method FSClientDecorator.ListObjectsByPrefix should have comment or be unexported (golint)
    • Line 530: warning: exported method FSClientDecorator.UploadISOs should have comment or be unexported (golint)
    • Line 538: warning: exported method FSClientDecorator.GetBaseIsoObject should have comment or be unexported (golint)
    • Line 542: warning: exported method FSClientDecorator.GetMinimalIsoObjectName should have comment or be unexported (golint)
    • Line 546: warning: exported method FSClientDecorator.CreatePublicBucket should have comment or be unexported (golint)
    • Line 550: warning: exported method FSClientDecorator.UploadStreamToPublicBucket should have comment or be unexported (golint)
    • Line 558: warning: exported method FSClientDecorator.UploadFileToPublicBucket should have comment or be unexported (golint)
    • Line 566: warning: exported method FSClientDecorator.DoesPublicObjectExist should have comment or be unexported (golint)
    • Line 570: warning: exported method FSClientDecorator.DownloadPublic should have comment or be unexported (golint)
    • assisted-service/subsystem/wiremock_stubs.go
    • Line 16: warning: exported type StubDefinition should have comment or be unexported (golint)
    • Line 21: warning: exported type RequestDefinition should have comment or be unexported (golint)
    • Line 28: warning: exported type ResponseDefinition should have comment or be unexported (golint)
    • Line 34: warning: exported type Mapping should have comment or be unexported (golint)
    • Line 38: warning: exported type WireMock should have comment or be unexported (golint)
    • Line 64: warning: exported const FakePS should have comment (or a comment on this block) or be unexported (golint)
    • Line 75: warning: exported method WireMock.CreateWiremockStubsForOCM should have comment or be unexported (golint)
    • Line 605: warning: exported method WireMock.DeleteAllWiremockStubs should have comment or be unexported (golint)
    • Line 615: warning: exported method WireMock.DeleteStub should have comment or be unexported (golint)
    • assisted-service/pkg/thread/thread.go
    • Line 29: warning: exported function New should have comment or be unexported (golint)
    • Line 54: warning: exported method Thread.LastRunStartedAt should have comment or be unexported (golint)
    • Line 58: warning: exported method Thread.Name should have comment or be unexported (golint)
    • assisted-service/pkg/auth/local_authenticator.go
    • Line 20: warning: exported type LocalAuthenticator should have comment or be unexported (golint)
    • Line 27: warning: exported function NewLocalAuthenticator should have comment or be unexported (golint)
    • Line 49: warning: exported method LocalAuthenticator.AuthType should have comment or be unexported (golint)
    • Line 53: warning: exported method LocalAuthenticator.AuthAgentAuth should have comment or be unexported (golint)
    • Line 103: warning: exported method LocalAuthenticator.AuthUserAuth should have comment or be unexported (golint)
    • Line 107: warning: exported method LocalAuthenticator.AuthURLAuth should have comment or be unexported (golint)
    • Line 111: warning: exported method LocalAuthenticator.CreateAuthenticator should have comment or be unexported (golint)
    • assisted-service/internal/ignition/ignition.go
    • Line 60: warning: exported const SystemConnectionsMerged should have comment or be unexported (golint)
    • Line 91: warning: exported const RedhatRootCA should have comment or be unexported (golint)
    • Line 358: warning: exported function NewBuilder should have comment or be unexported (golint)
    • Line 1014: warning: exported function ParseToLatest should have comment or be unexported (golint)
    • Line 1179: warning: exported function MergeIgnitionConfig should have comment or be unexported (golint)
    • Line 1229: warning: exported function GetServiceIPHostnames should have comment or be unexported (golint)
    • Line 1283: warning: exported function SetHostnameForNodeIgnition should have comment or be unexported (golint)
    • Line 1435: warning: exported function QuoteSshPublicKeys should have comment or be unexported (golint)
    • assisted-service/internal/common/disks_info.go
    • Line 9: warning: exported type DisksInfo should have comment or be unexported (golint)
    • Line 11: warning: exported function UnMarshalDisks should have comment or be unexported (golint)
    • Line 22: warning: exported function MarshalDisks should have comment or be unexported (golint)
    • Line 30: warning: exported function DiskSpeedResultExists should have comment or be unexported (golint)
    • Line 39: warning: exported function GetDiskInfo should have comment or be unexported (golint)
    • Line 50: warning: exported function SetDiskSpeed should have comment or be unexported (golint)
    • Line 68: warning: exported function ResetDiskSpeed should have comment or be unexported (golint)
    • assisted-service/internal/isoeditor/rhcos.go
    • Line 32: warning: exported const RamDiskPaddingLength should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type ClusterProxyInfo should have comment or be unexported (golint)
    • Line 49: warning: exported method ClusterProxyInfo.Empty should have comment or be unexported (golint)
    • Line 53: warning: exported type OffsetInfo should have comment or be unexported (golint)
    • Line 59: warning: comment on exported type Editor should be of the form "Editor ..." (with optional leading article) (golint)
    • Line 206: warning: exported function RamdiskImageArchive should have comment or be unexported (golint)
    • Line 523: warning: exported function GetIgnitionArea should have comment or be unexported (golint)
    • Line 534: warning: exported function GetRamDiskArea should have comment or be unexported (golint)
    • Line 557: warning: exported function EmbedIgnition should have comment or be unexported (golint)
    • assisted-service/api/v1beta1/agent_types.go
    • Line 27: warning: exported const SpecSyncedCondition should have comment (or a comment on this block) or be unexported (golint)
    • Line 92: warning: exported type HostMemory should have comment or be unexported (golint)
    • Line 97: warning: exported type HostCPU should have comment or be unexported (golint)
    • Line 106: warning: exported type HostInterface should have comment or be unexported (golint)
    • Line 121: warning: exported type HostInstallationEligibility should have comment or be unexported (golint)
    • Line 126: warning: exported type HostIOPerf should have comment or be unexported (golint)
    • Line 131: warning: exported type HostDisk should have comment or be unexported (golint)
    • Line 150: warning: exported type HostBoot should have comment or be unexported (golint)
    • Line 155: warning: exported type HostSystemVendor should have comment or be unexported (golint)
    • Line 162: warning: exported type HostInventory should have comment or be unexported (golint)
    • Line 192: warning: exported type HostProgressInfo should have comment or be unexported (golint)
    • Line 201: warning: exported type HostNTPSources should have comment or be unexported (golint)
    • Line 225: warning: exported type DebugInfo should have comment or be unexported (golint)
    • assisted-service/pkg/staticnetworkconfig/generator.go
    • Line 25: warning: exported type Config should have comment or be unexported (golint)
    • Line 29: warning: exported type StaticNetworkConfigData should have comment or be unexported (golint)
    • Line 34: warning: comment on exported type StaticNetworkConfig should be of the form "StaticNetworkConfig ..." (with optional leading article) (golint)
    • Line 41: warning: exported type StaticNetworkConfigGenerator should have comment or be unexported (golint)
    • Line 47: warning: exported function New should have comment or be unexported (golint)
    • Line 54: warning: exported method StaticNetworkConfigGenerator.GenerateStaticNetworkConfigData should have comment or be unexported (golint)
    • Line 184: warning: exported method StaticNetworkConfigGenerator.ValidateStaticConfigParams should have comment or be unexported (golint)
    • Line 211: warning: exported method StaticNetworkConfigGenerator.FormatStaticNetworkConfigForDB should have comment or be unexported (golint)
    • assisted-service/internal/network/machine_network_cidr.go
    • Line 29: warning: comment on exported function CalculateMachineNetworkCIDR should be of the form "CalculateMachineNetworkCIDR ..." (golint)
    • Line 88: warning: exported function VerifyVip should have comment or be unexported (golint)
    • Line 104: warning: exported function VerifyDifferentVipAddresses should have comment or be unexported (golint)
    • Line 111: warning: exported function VerifyVips should have comment or be unexported (golint)
    • Line 138: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 170: warning: exported function GetPrimaryMachineCIDRInterface should have comment or be unexported (golint)
    • Line 178: warning: exported function GetPrimaryMachineCIDRIP should have comment or be unexported (golint)
    • Line 186: warning: exported function IpInCidr should have comment or be unexported (golint)
    • Line 214: warning: exported function GetPrimaryMachineCIDRHosts should have comment or be unexported (golint)
    • Line 293: warning: exported function GetIpForSingleNodeInstallation should have comment or be unexported (golint)
    • Line 311: warning: exported function GetClusterNetworks should have comment or be unexported (golint)
    • Line 351: warning: exported function IsHostInPrimaryMachineNetCidr should have comment or be unexported (golint)
    • Line 372: warning: exported type IPSet should have comment or be unexported (golint)
    • Line 374: warning: exported method IPSet.Add should have comment or be unexported (golint)
    • Line 378: warning: exported method IPSet.Intersect should have comment or be unexported (golint)
    • Line 408: warning: exported function MakeFreeAddressesSet should have comment or be unexported (golint)
    • Line 444: warning: comment on exported function IpInFreeList should be of the form "IpInFreeList ..." (golint)
    • Line 454: warning: exported function CreateIpWithCidr should have comment or be unexported (golint)
    • Line 463: warning: exported function CreateMachineNetworksArray should have comment or be unexported (golint)
    • assisted-service/internal/versions/versions.go
    • Line 21: warning: exported type MustGatherVersion should have comment or be unexported (golint)
    • Line 22: warning: exported type MustGatherVersions should have comment or be unexported (golint)
    • Line 24: warning: exported type Versions should have comment or be unexported (golint)
    • Line 32: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
    • Line 44: warning: exported function NewHandler should have comment or be unexported (golint)
    • assisted-service/internal/manifests/manifests.go
    • Line 55: warning: exported method Manifests.CreateClusterManifest should have comment or be unexported (golint)
    • Line 59: warning: exported method Manifests.CreateClusterManifestInternal should have comment or be unexported (golint)
    • Line 109: warning: exported method Manifests.ListClusterManifests should have comment or be unexported (golint)
    • Line 113: warning: exported method Manifests.ListClusterManifestsInternal should have comment or be unexported (golint)
    • Line 141: warning: exported method Manifests.DeleteClusterManifest should have comment or be unexported (golint)
    • Line 145: warning: exported method Manifests.DeleteClusterManifestInternal should have comment or be unexported (golint)
    • Line 191: warning: exported method Manifests.DownloadClusterManifest should have comment or be unexported (golint)
    • Line 199: warning: exported method Manifests.V2DownloadClusterManifest should have comment or be unexported (golint)
    • assisted-service/internal/host/hostcommands/instruction_manager.go
    • Line 23: warning: comment on exported type InstructionApi should be of the form "InstructionApi ..." (with optional leading article) (golint)
    • Line 33: warning: exported type StepsStruct should have comment or be unexported (golint)
    • Line 41: warning: exported type InstructionManager should have comment or be unexported (golint)
    • Line 50: warning: exported type InstructionConfig should have comment or be unexported (golint)
    • Line 65: warning: exported function NewInstructionManager should have comment or be unexported (golint)
    • Line 130: warning: exported method InstructionManager.GetNextSteps should have comment or be unexported (golint)
    • assisted-service/internal/network/utils.go
    • Line 48: warning: comment on exported function GetConfiguredAddressFamilies should be of the form "GetConfiguredAddressFamilies ..." (golint)
    • Line 69: warning: exported function GetAddressFamilies should have comment or be unexported (golint)
    • Line 102: warning: exported function IsMachineCidrAvailable should have comment or be unexported (golint)
    • Line 106: warning: exported function GetMachineCidrById should have comment or be unexported (golint)
    • Line 110: warning: exported function DerefMachineNetworks should have comment or be unexported (golint)
    • Line 119: warning: exported function DerefServiceNetworks should have comment or be unexported (golint)
    • Line 128: warning: exported function DerefClusterNetworks should have comment or be unexported (golint)
    • assisted-service/cmd/main.go
    • Line 87: warning: don't use underscores in Go names; const deployment_type_k8s should be deploymentTypeK8s (golint)
    • Line 88: warning: don't use underscores in Go names; const deployment_type_onprem should be deploymentTypeOnprem (golint)
    • Line 89: warning: don't use underscores in Go names; const deployment_type_ocp should be deploymentTypeOcp (golint)
    • Line 90: warning: don't use underscores in Go names; const storage_filesystem should be storageFilesystem (golint)
    • Line 91: warning: don't use underscores in Go names; const storage_s3 should be storageS3 (golint)
    • Line 94: warning: exported var Options should have comment or be unexported (golint)
    • Line 145: warning: exported function InitLogs should have comment or be unexported (golint)
    • Line 702: warning: exported function NewApiEnabler should have comment or be unexported (golint)
    • Line 710: warning: exported type ApiEnabler should have comment or be unexported (golint)
    • Line 726: warning: exported method ApiEnabler.Enable should have comment or be unexported (golint)
    • Line 731: warning: exported method ApiEnabler.WaitForEnabled should have comment or be unexported (golint)
    • assisted-service/pkg/requestid/requestid.go
    • Line 13: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
    • Line 55: warning: exported function ToContext should have comment or be unexported (golint)
    • Line 59: warning: exported function RequestIDLogger should have comment or be unexported (golint)
    • Line 67: warning: exported function FromRequest should have comment or be unexported (golint)
    • Line 92: warning: exported function NewID should have comment or be unexported (golint)
    • assisted-service/pkg/ocm/client.go
    • Line 14: warning: exported type Client should have comment or be unexported (golint)
    • Line 27: warning: exported type Config should have comment or be unexported (golint)
    • Line 36: warning: exported type SdKLogger should have comment or be unexported (golint)
    • Line 41: warning: exported method SdKLogger.DebugEnabled should have comment or be unexported (golint)
    • Line 45: warning: exported method SdKLogger.InfoEnabled should have comment or be unexported (golint)
    • Line 49: warning: exported method SdKLogger.WarnEnabled should have comment or be unexported (golint)
    • Line 53: warning: exported method SdKLogger.ErrorEnabled should have comment or be unexported (golint)
    • Line 57: warning: exported method SdKLogger.Debug should have comment or be unexported (golint)
    • Line 61: warning: exported method SdKLogger.Info should have comment or be unexported (golint)
    • Line 65: warning: exported method SdKLogger.Warn should have comment or be unexported (golint)
    • Line 73: warning: exported method SdKLogger.Fatal should have comment or be unexported (golint)
    • Line 77: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 131: warning: exported type RoleType should have comment or be unexported (golint)
    • Line 134: warning: exported const UserRole should have comment (or a comment on this block) or be unexported (golint)
    • assisted-service/internal/host/hostutil/host_utils.go
    • Line 19: warning: exported const MaxHostnameLength should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported function GetCurrentHostName should have comment or be unexported (golint)
    • Line 34: warning: exported function GetHostnameForMsg should have comment or be unexported (golint)
    • Line 43: warning: exported function GetEventSeverityFromHostStatus should have comment or be unexported (golint)
    • Line 58: warning: exported function ValidateHostname should have comment or be unexported (golint)
    • Line 73: warning: comment on exported function DetermineInstallationDisk should be of the form "DetermineInstallationDisk ..." (golint)
    • Line 95: warning: exported function GetDeviceIdentifier should have comment or be unexported (golint)
    • Line 107: warning: exported function GetDeviceFullName should have comment or be unexported (golint)
    • Line 111: warning: exported function GetHostInstallationPath should have comment or be unexported (golint)
    • Line 119: warning: exported function GetHostInstallationDisk should have comment or be unexported (golint)
    • Line 129: warning: exported function GetDiskByInstallationPath should have comment or be unexported (golint)
    • Line 146: warning: exported function IgnitionFileName should have comment or be unexported (golint)
    • Line 152: warning: exported function ValidateInstallerArgs should have comment or be unexported (golint)
    • Line 174: warning: exported function IsDay2Host should have comment or be unexported (golint)
    • Line 178: warning: exported function IsUnboundHost should have comment or be unexported (golint)
    • Line 182: warning: exported function MarshalConnectivityReport should have comment or be unexported (golint)
    • Line 185: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 190: warning: exported function UnmarshalConnectivityReport should have comment or be unexported (golint)
    • Line 199: warning: exported function GetHostCluster should have comment or be unexported (golint)
    • Line 209: warning: exported function IsSingleNode should have comment or be unexported (golint)
    • assisted-service/internal/cluster/common.go
    • Line 24: warning: exported const MinMastersNeededForInstallation should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported const StatusInfoReady should have comment (or a comment on this block) or be unexported (golint)
    • Line 105: warning: exported function ClusterExists should have comment or be unexported (golint)
    • Line 116: warning: exported function UpdateCluster should have comment or be unexported (golint)
    • Line 154: warning: exported function NumberOfWorkers should have comment or be unexported (golint)
    • Line 165: warning: exported function MapMasterHostsByStatus should have comment or be unexported (golint)
    • Line 169: warning: exported function MapWorkersHostsByStatus should have comment or be unexported (golint)
    • Line 188: warning: exported function MapHostsByStatus should have comment or be unexported (golint)
    • Line 207: warning: exported function UpdateMachineCidr should have comment or be unexported (golint)
    • assisted-service/api/v1beta1/infraenv_types.go
    • Line 26: warning: exported const ImageCreatedReason should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: exported const ImageCreatedCondition should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: exported type InfraEnvSpec should have comment or be unexported (golint)
    • Line 104: warning: exported type InfraEnvStatus should have comment or be unexported (golint)
    • Line 120: warning: exported type InfraEnvDebugInfo should have comment or be unexported (golint)
    • Line 129: warning: exported type InfraEnv should have comment or be unexported (golint)
    • assisted-service/internal/hardware/versioned-requirements.go
    • Line 10: warning: exported const DefaultVersion should have comment or be unexported (golint)
    • Line 12: warning: exported type VersionedRequirementsDecoder should have comment or be unexported (golint)
    • Line 14: warning: exported method VersionedRequirementsDecoder.GetVersionedHostRequirements should have comment or be unexported (golint)
    • Line 25: warning: exported method VersionedRequirementsDecoder.Decode should have comment or be unexported (golint)
    • assisted-service/internal/cluster/validations/validations.go
    • Line 27: warning: exported type Config should have comment or be unexported (golint)
    • Line 35: warning: exported const CloudOpenShiftCom should have comment (or a comment on this block) or be unexported (golint)
    • Line 64: warning: exported type PullSecretCreds should have comment or be unexported (golint)
    • Line 127: warning: exported function AddRHRegPullSecret should have comment or be unexported (golint)
    • Line 205: warning: exported function ValidateDomainNameFormat should have comment or be unexported (golint)
    • Line 216: warning: exported function ValidateHostname should have comment or be unexported (golint)
    • Line 227: warning: exported function ValidateAdditionalNTPSource should have comment or be unexported (golint)
    • Line 231: warning: exported function ValidateNTPSource should have comment or be unexported (golint)
    • Line 305: warning: exported function ValidateSSHPublicKey should have comment or be unexported (golint)
    • Line 384: warning: exported function DerefString should have comment or be unexported (golint)
    • Line 395: warning: exported function ValidateIPAddresses should have comment or be unexported (golint)
    • Line 490: warning: exported function ValidateDiskEncryptionParams should have comment or be unexported (golint)
    • assisted-service/internal/common/db.go
    • Line 17: warning: exported const InstallationPreparationSucceeded should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported type Cluster should have comment or be unexported (golint)
    • Line 68: warning: exported type Event should have comment or be unexported (golint)
    • Line 73: warning: exported type Host should have comment or be unexported (golint)
    • Line 84: warning: exported type InfraEnv should have comment or be unexported (golint)
    • Line 112: warning: exported type EagerLoadingState should have comment or be unexported (golint)
    • Line 115: warning: exported const UseEagerLoading should have comment (or a comment on this block) or be unexported (golint)
    • Line 119: warning: exported type DeleteRecordsState should have comment or be unexported (golint)
    • Line 122: warning: exported const IncludeDeletedRecords should have comment (or a comment on this block) or be unexported (golint)
    • Line 127: warning: exported const HostsTable should have comment (or a comment on this block) or be unexported (golint)
    • Line 134: warning: exported var ClusterSubTables should have comment or be unexported (golint)
    • Line 136: warning: exported function AutoMigrate should have comment or be unexported (golint)
    • Line 141: warning: exported function LoadTableFromDB should have comment or be unexported (golint)
    • Line 145: warning: exported function LoadClusterTablesFromDB should have comment or be unexported (golint)
    • Line 155: warning: exported function GetClusterFromDB should have comment or be unexported (golint)
    • Line 164: warning: exported function GetClusterFromDBWithoutDisabledHosts should have comment or be unexported (golint)
    • Line 192: warning: exported function GetClusterFromDBWhere should have comment or be unexported (golint)
    • Line 203: warning: exported function GetClustersFromDBWhere should have comment or be unexported (golint)
    • Line 214: warning: exported function GetHostFromDB should have comment or be unexported (golint)
    • Line 224: warning: exported function GetClusterHostFromDB should have comment or be unexported (golint)
    • Line 234: warning: exported function GetHostFromDBWhere should have comment or be unexported (golint)
    • Line 244: warning: exported function GetHostsFromDBWhere should have comment or be unexported (golint)
    • Line 254: warning: exported function DeleteHostFromDB should have comment or be unexported (golint)
    • Line 258: warning: exported function GetInfraEnvFromDB should have comment or be unexported (golint)
    • Line 268: warning: exported function GetInfraEnvHostsFromDB should have comment or be unexported (golint)
    • Line 272: warning: exported function GetInfraEnvsFromDBWhere should have comment or be unexported (golint)
    • Line 282: warning: exported function DeleteRecordsByClusterID should have comment or be unexported (golint)
    • Line 292: warning: exported function GetInfraEnvFromDBWhere should have comment or be unexported (golint)
    • Line 302: warning: exported function ToModelsHosts should have comment or be unexported (golint)
    • Line 310: warning: exported method Cluster.AfterFind should have comment or be unexported (golint)
    • Line 325: warning: exported function ToSqlList should have comment or be unexported (golint)
    • Line 331: warning: exported function CreateInfraEnvForCluster should have comment or be unexported (golint)
    • assisted-service/internal/operators/cnv/cnv_operator.go
    • Line 20: warning: comment on exported const MasterMemory should be of the form "MasterMemory ..." (golint)
    • Line 22: warning: exported const MasterCPU should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: comment on exported const WorkerMemory should be of the form "WorkerMemory ..." (golint)
    • Line 34: warning: exported var Operator should have comment or be unexported (golint)
    • assisted-service/internal/provider/registry/registry.go
    • Line 23: warning: comment on exported type ProviderRegistry should be of the form "ProviderRegistry ..." (with optional leading article) (golint)
    • Line 42: warning: comment on exported type Registry should be of the form "Registry ..." (with optional leading article) (golint)
    • Line 148: warning: exported function InitProviderRegistry should have comment or be unexported (golint)
    • assisted-service/internal/usage/manager.go
    • Line 15: warning: exported type FeatureUsage should have comment or be unexported (golint)
    • Line 17: warning: comment on exported type API should be of the form "API ..." (with optional leading article) (golint)
    • Line 24: warning: exported type UsageManager should have comment or be unexported (golint)
    • Line 28: warning: exported function NewManager should have comment or be unexported (golint)
    • Line 34: warning: exported method UsageManager.Add should have comment or be unexported (golint)
    • Line 45: warning: exported method UsageManager.Remove should have comment or be unexported (golint)
    • Line 49: warning: exported method UsageManager.Save should have comment or be unexported (golint)
    • Line 59: warning: exported function Unmarshal should have comment or be unexported (golint)
    • assisted-service/internal/manifests/manifests_v2.go
    • Line 13: warning: exported method Manifests.V2CreateClusterManifest should have comment or be unexported (golint)
    • Line 27: warning: exported method Manifests.V2ListClusterManifests should have comment or be unexported (golint)
    • Line 35: warning: exported method Manifests.V2DeleteClusterManifest should have comment or be unexported (golint)
    • assisted-service/pkg/executer/executer.go
    • Line 11: warning: comment on exported type Executer should be of the form "Executer ..." (with optional leading article) (golint)
    • Line 18: warning: exported type CommonExecuter should have comment or be unexported (golint)
    • Line 20: warning: exported method CommonExecuter.TempFile should have comment or be unexported (golint)
    • Line 24: warning: exported method CommonExecuter.Execute should have comment or be unexported (golint)
    • Line 29: warning: exported method CommonExecuter.ExecuteWithContext should have comment or be unexported (golint)
    • assisted-service/pkg/ocm/accounts_mgmt.go
    • Line 13: warning: exported const ProductCategoryAssistedInstall should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: comment on exported type OCMAccountsMgmt should be of the form "OCMAccountsMgmt ..." (with optional leading article) (golint)
    • assisted-service/internal/oc/release.go
    • Line 23: warning: exported const DefaultTries should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported type Config should have comment or be unexported (golint)
    • Line 32: warning: comment on exported type Release should be of the form "Release ..." (with optional leading article) (golint)
    • Line 50: warning: exported function NewRelease should have comment or be unexported (golint)
    • Line 266: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/api/common/common_types.go
    • Line 5: warning: comment on exported type ValidationResult should be of the form "ValidationResult ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ValidationsStatus should be of the form "ValidationsStatus ..." (with optional leading article) (golint)
    • Line 17: warning: comment on exported type ValidationResults should be of the form "ValidationResults ..." (with optional leading article) (golint)
    • assisted-service/pkg/auth/auth_utils.go
    • Line 14: warning: exported function AuthHeaderWriter should have comment or be unexported (golint)
    • Line 20: warning: exported function AgentAuthHeaderWriter should have comment or be unexported (golint)
    • Line 24: warning: exported function UserAuthHeaderWriter should have comment or be unexported (golint)
    • assisted-service/internal/operators/manager.go
    • Line 88: warning: comment on exported method Manager.GetRequirementsBreakdownForHostInCluster should be of the form "GetRequirementsBreakdownForHostInCluster ..." (golint)
    • Line 290: warning: exported method Manager.ResolveDependencies should have comment or be unexported (golint)
    • Line 351: warning: exported function IsEnabled should have comment or be unexported (golint)
    • Line 355: warning: exported method Manager.GetMonitoredOperatorsList should have comment or be unexported (golint)
    • Line 359: warning: exported method Manager.GetOperatorByName should have comment or be unexported (golint)
    • Line 374: warning: exported method Manager.GetSupportedOperatorsByType should have comment or be unexported (golint)
    • assisted-service/internal/isoutil/isoutil.go
    • Line 18: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
    • Line 34: warning: exported function NewHandler should have comment or be unexported (golint)
    • Line 298: warning: exported function GetFileLocation should have comment or be unexported (golint)
    • Line 308: warning: exported function GetFileSize should have comment or be unexported (golint)
    • Line 316: warning: exported function GetFile should have comment or be unexported (golint)
    • assisted-service/internal/controller/controllers/bmh_agent_controller.go
    • Line 64: warning: exported const AGENT_BMH_LABEL should have comment (or a comment on this block) or be unexported (golint)
    • Line 83: warning: exported var InfraEnvImageCooldownPeriod should have comment or be unexported (golint)
    • Line 175: warning: exported method BMACReconciler.Reconcile should have comment or be unexported (golint)
    • Line 1251: warning: exported method BMACReconciler.SetupWithManager should have comment or be unexported (golint)
    • assisted-service/internal/controller/controllers/crd_events_handler.go
    • Line 8: warning: exported const EventsChannelSize should have comment or be unexported (golint)
    • Line 10: warning: comment on exported type CRDEventsHandler should be of the form "CRDEventsHandler ..." (with optional leading article) (golint)
    • Line 20: warning: exported type CRDEventsHandlerChannels should have comment or be unexported (golint)
    • Line 26: warning: exported function NewCRDEventsHandler should have comment or be unexported (golint)
    • Line 34: warning: exported method CRDEventsHandlerChannels.NotifyUpdates should have comment or be unexported (golint)
    • Line 45: warning: exported method CRDEventsHandlerChannels.NotifyClusterDeploymentUpdates should have comment or be unexported (golint)
    • Line 49: warning: exported method CRDEventsHandlerChannels.NotifyAgentUpdates should have comment or be unexported (golint)
    • Line 53: warning: exported method CRDEventsHandlerChannels.NotifyInfraEnvUpdates should have comment or be unexported (golint)
    • Line 57: warning: exported method CRDEventsHandlerChannels.GetInfraEnvUpdates should have comment or be unexported (golint)
    • Line 61: warning: exported method CRDEventsHandlerChannels.GetClusterDeploymentUpdates should have comment or be unexported (golint)
    • Line 65: warning: exported method CRDEventsHandlerChannels.GetAgentUpdates should have comment or be unexported (golint)
    • assisted-service/pkg/ocm/utils.go
    • Line 14: warning: exported const BareMetalClusterResource should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported function AdminPayload should have comment or be unexported (golint)
    • Line 75: warning: exported function HandleOCMResponse should have comment or be unexported (golint)
    • assisted-service/internal/controller/controllers/clusterdeployments_controller.go
    • Line 33: warning: should not use dot imports (golint)
    • Line 73: warning: exported const InstallConfigOverrides should have comment (or a comment on this block) or be unexported (golint)
    • Line 78: warning: exported const HighAvailabilityModeNone should have comment or be unexported (golint)
    • Line 107: warning: exported method ClusterDeploymentsReconciler.Reconcile should have comment or be unexported (golint)
    • Line 772: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 957: warning: exported method ClusterDeploymentsReconciler.TransformClusterToDay2 should have comment or be unexported (golint)
    • Line 1113: warning: exported method ClusterDeploymentsReconciler.DeleteClusterDeploymentAgents should have comment or be unexported (golint)
    • Line 1133: warning: exported method ClusterDeploymentsReconciler.SetupWithManager should have comment or be unexported (golint)
    • assisted-service/api/v1beta1/nmstate_config_types.go
    • Line 23: warning: exported type Interface should have comment or be unexported (golint)
    • Line 32: warning: exported type RawNetConfig should have comment or be unexported (golint)
    • Line 43: warning: exported type NMStateConfigSpec should have comment or be unexported (golint)
    • Line 61: warning: exported type NMStateConfig should have comment or be unexported (golint)
    • Line 85: warning: comment on exported method NetConfig.OpenAPISchemaType should be of the form "OpenAPISchemaType ..." (golint)
    • Line 86: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • assisted-service/internal/controller/controllers/agent_controller.go
    • Line 30: warning: should not use dot imports (golint)
    • Line 58: warning: exported const AgentFinalizerName should have comment (or a comment on this block) or be unexported (golint)
    • Line 76: warning: exported method AgentReconciler.Reconcile should have comment or be unexported (golint)
    • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 249: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 264: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 892: warning: exported method AgentReconciler.SetupWithManager should have comment or be unexported (golint)
    • assisted-service/internal/host/validator.go
    • Line 30: warning: exported type ValidationStatus should have comment or be unexported (golint)
    • Line 33: warning: exported const ValidationSuccess should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported const OpenStackPlatform should have comment or be unexported (golint)
    • Line 44: warning: exported var ImageStatusDownloadRateThreshold should have comment or be unexported (golint)
    • Line 240: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 394: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 464: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 511: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/internal/dns/dns.go
    • Line 29: warning: exported type DNSDomain should have comment or be unexported (golint)
    • Line 38: warning: exported type DNSApi should have comment or be unexported (golint)
    • Line 47: warning: comment on exported type DNSProviderFactory should be of the form "DNSProviderFactory ..." (with optional leading article) (golint)
    • Line 63: warning: exported function NewDNSHandler should have comment or be unexported (golint)
    • Line 67: warning: exported function NewDNSHandlerWithProviders should have comment or be unexported (golint)
    • Line 146: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/pkg/auth/none_authenticator.go
    • Line 12: warning: exported type NoneAuthenticator should have comment or be unexported (golint)
    • Line 16: warning: exported function NewNoneAuthenticator should have comment or be unexported (golint)
    • Line 22: warning: exported method NoneAuthenticator.AuthType should have comment or be unexported (golint)
    • Line 26: warning: exported method NoneAuthenticator.AuthAgentAuth should have comment or be unexported (golint)
    • Line 31: warning: exported method NoneAuthenticator.AuthUserAuth should have comment or be unexported (golint)
    • Line 36: warning: exported method NoneAuthenticator.AuthURLAuth should have comment or be unexported (golint)
    • Line 41: warning: exported method NoneAuthenticator.CreateAuthenticator should have comment or be unexported (golint)
    • assisted-service/internal/host/transition.go
    • Line 44: warning: exported type TransitionArgsRegisterHost should have comment or be unexported (golint)
    • Line 76: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 170: warning: exported type TransitionArgsRegisterInstalledHost should have comment or be unexported (golint)
    • Line 197: warning: exported type TransitionArgsHostInstallationFailed should have comment or be unexported (golint)
    • Line 220: warning: exported type TransitionArgsCancelInstallation should have comment or be unexported (golint)
    • Line 244: warning: exported type TransitionArgsResetHost should have comment or be unexported (golint)
    • Line 269: warning: exported type TransitionArgsInstallHost should have comment or be unexported (golint)
    • Line 291: warning: exported type TransitionArgsDisableHost should have comment or be unexported (golint)
    • Line 314: warning: exported type TransitionArgsEnableHost should have comment or be unexported (golint)
    • Line 337: warning: exported type TransitionArgsBindHost should have comment or be unexported (golint)
    • Line 362: warning: exported type TransitionArgsUnbindHost should have comment or be unexported (golint)
    • Line 387: warning: exported type TransitionResettingPendingUserAction should have comment or be unexported (golint)
    • Line 430: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 440: warning: exported type TransitionArgsRefreshHost should have comment or be unexported (golint)
    • Line 448: warning: exported function If should have comment or be unexported (golint)
    • assisted-service/internal/installcfg/installcfg.go
    • Line 11: warning: exported type Platform should have comment or be unexported (golint)
    • Line 17: warning: exported type Host should have comment or be unexported (golint)
    • Line 24: warning: exported type BareMetalInstallConfigPlatform should have comment or be unexported (golint)
    • Line 31: warning: exported type VsphereInstallConfigPlatform should have comment or be unexported (golint)
    • Line 44: warning: exported type PlatformNone should have comment or be unexported (golint)
    • Line 47: warning: exported type BootstrapInPlace should have comment or be unexported (golint)
    • Line 51: warning: exported type Proxy should have comment or be unexported (golint)
    • Line 57: warning: exported type ImageContentSource should have comment or be unexported (golint)
    • Line 62: warning: exported type ClusterNetwork should have comment or be unexported (golint)
    • Line 67: warning: exported type MachineNetwork should have comment or be unexported (golint)
    • Line 71: warning: exported type InstallerConfigBaremetal should have comment or be unexported (golint)
    • Line 103: warning: exported method InstallerConfigBaremetal.Validate should have comment or be unexported (golint)
    • assisted-service/internal/oc/extract.go
    • Line 12: warning: comment on exported type Extracter should be of the form "Extracter ..." (with optional leading article) (golint)
    • Line 23: warning: exported function NewExtracter should have comment or be unexported (golint)
    • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • assisted-service/internal/usage/consts.go
    • Line 4: warning: comment on exported const AdditionalNtpSourceUsage should be of the form "AdditionalNtpSourceUsage ..." (golint)
    • Line 6: warning: comment on exported const RequestedHostnameUsage should be of the form "RequestedHostnameUsage ..." (golint)
    • Line 8: warning: comment on exported const ProxyUsage should be of the form "ProxyUsage ..." (golint)
    • Line 10: warning: comment on exported const HighAvailabilityModeUsage should be of the form "HighAvailabilityModeUsage ..." (golint)
    • Line 12: warning: comment on exported const Day2HostUsage should be of the form "Day2HostUsage ..." (golint)
    • Line 14: warning: comment on exported const VipDhcpAllocationUsage should be of the form "VipDhcpAllocationUsage ..." (golint)
    • Line 16: warning: comment on exported const DiskSelectionUsage should be of the form "DiskSelectionUsage ..." (golint)
    • Line 18: warning: comment on exported const OVNNetworkTypeUsage should be of the form "OVNNetworkTypeUsage ..." (golint)
    • Line 20: warning: comment on exported const SDNNetworkTypeUsage should be of the form "SDNNetworkTypeUsage ..." (golint)
    • Line 22: warning: comment on exported const PlatformSelectionUsage should be of the form "PlatformSelectionUsage ..." (golint)
    • Line 24: warning: comment on exported const SchedulableMasters should be of the form "SchedulableMasters ..." (golint)
    • Line 26: warning: comment on exported const AutoAssignRoleUsage should be of the form "AutoAssignRoleUsage ..." (golint)
    • Line 28: warning: comment on exported const CustomManifest should be of the form "CustomManifest ..." (golint)
    • Line 30: warning: comment on exported const DiskEncryption should be of the form "DiskEncryption ..." (golint)
    • assisted-service/internal/host/hostutil/test_utils.go
    • Line 13: warning: should not use dot imports (golint)
    • Line 19: warning: exported function GetHostFromDB should have comment or be unexported (golint)
    • Line 25: warning: exported function GenerateTestCluster should have comment or be unexported (golint)
    • Line 36: warning: exported function GenerateTestClusterWithPlatform should have comment or be unexported (golint)
    • Line 42: warning: exported function GenerateTestInfraEnv should have comment or be unexported (golint)
    • Line 52: warning: exported function GenerateUnassignedTestHost should have comment or be unexported (golint)
    • Line 56: warning: exported function GenerateTestHost should have comment or be unexported (golint)
    • Line 60: warning: exported function GenerateTestHostAddedToCluster should have comment or be unexported (golint)
    • Line 64: warning: exported function GenerateTestHostByKind should have comment or be unexported (golint)
    • Line 86: warning: exported function GenerateTestHostWithInfraEnv should have comment or be unexported (golint)
    • Line 102: warning: exported function GenerateTestHostWithNetworkAddress should have comment or be unexported (golint)
    • Line 124: warning: exported function GenerateTestConnectivityReport should have comment or be unexported (golint)
    • Line 131: warning: exported function GenerateL3ConnectivityReport should have comment or be unexported (golint)
    • Line 164: warning: exported function GenerateMasterInventoryWithSystemPlatform should have comment or be unexported (golint)
    • Line 168: warning: exported function GenerateMasterInventory should have comment or be unexported (golint)
    • Line 172: warning: exported function GenerateMasterInventoryV6 should have comment or be unexported (golint)
    • Line 176: warning: exported function GenerateMasterInventoryDualStack should have comment or be unexported (golint)
    • Line 180: warning: exported function GenerateMasterInventoryWithHostname should have comment or be unexported (golint)
    • Line 184: warning: exported function GenerateMasterInventoryWithHostnameV6 should have comment or be unexported (golint)
    • Line 188: warning: exported function GenerateMasterInventoryWithHostnameDualStack should have comment or be unexported (golint)
    • Line 192: warning: exported function GenerateMasterInventoryWithHostnameAndCpuFlags should have comment or be unexported (golint)
    • Line 224: warning: exported function GenerateMasterInventoryWithHostnameAndCpuFlagsV6 should have comment or be unexported (golint)
    • Line 252: warning: exported function GenerateMasterInventoryWithHostnameAndCpuFlagsDualStack should have comment or be unexported (golint)
    • Line 283: warning: exported function GenerateInventoryWithResources should have comment or be unexported (golint)
    • Line 312: warning: exported function GenerateInventoryWithResourcesAndMultipleDisk should have comment or be unexported (golint)
    • Line 345: warning: exported function GenerateInventoryWithResourcesWithBytes should have comment or be unexported (golint)
    • Line 373: warning: exported function GenerateIPv4Addresses should have comment or be unexported (golint)
    • Line 380: warning: exported function GenerateIPv6Addresses should have comment or be unexported (golint)
    • assisted-service/internal/isoeditor/factory.go
    • Line 11: warning: exported type Config should have comment or be unexported (golint)
    • Line 16: warning: exported type EditFunc should have comment or be unexported (golint)
    • Line 18: warning: comment on exported type Factory should be of the form "Factory ..." (with optional leading article) (golint)
    • Line 24: warning: exported type RhcosFactory should have comment or be unexported (golint)
    • Line 30: warning: exported function NewFactory should have comment or be unexported (golint)
    • Line 38: warning: exported method RhcosFactory.WithEditor should have comment or be unexported (golint)
    • assisted-service/internal/network/connectivity_groups.go
    • Line 18: warning: exported type AddressFamily should have comment or be unexported (golint)
    • Line 21: warning: exported const IPv4 should have comment (or a comment on this block) or be unexported (golint)
    • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 83: warning: exported function NewConnectivitySet should have comment or be unexported (golint)
    • Line 447: warning: comment on exported function CreateL2MajorityGroup should be of the form "CreateL2MajorityGroup ..." (golint)
    • Line 461: warning: comment on exported function CreateL3MajorityGroup should be of the form "CreateL3MajorityGroup ..." (golint)
    • assisted-service/internal/gencrypto/token.go
    • Line 11: warning: exported type LocalJWTKeyType should have comment or be unexported (golint)
    • Line 14: warning: exported const InfraEnvKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported function LocalJWT should have comment or be unexported (golint)
    • Line 26: warning: exported function LocalJWTForKey should have comment or be unexported (golint)
    • Line 26: warning: don't use underscores in Go names; func parameter private_key_pem should be privateKeyPem (golint)
    • Line 44: warning: exported function SignURL should have comment or be unexported (golint)
    • assisted-service/internal/provider/base.go
    • Line 11: warning: exported const DbFieldPlatformType should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: comment on exported type Provider should be of the form "Provider ..." (with optional leading article) (golint)
    • assisted-service/internal/imgexpirer/imgexpirer.go
    • Line 19: warning: exported const AssistedServiceLiveISOPrefix should have comment or be unexported (golint)
    • Line 26: warning: exported type Manager should have comment or be unexported (golint)
    • Line 34: warning: exported function NewManager should have comment or be unexported (golint)
    • Line 44: warning: exported method Manager.ExpirationTask should have comment or be unexported (golint)
    • Line 55: warning: exported method Manager.DeletedImageCallback should have comment or be unexported (golint)
    • Line 65: warning: exported method Manager.DeletedImageNoCallback should have comment or be unexported (golint)
    • assisted-service/internal/common/monitor_query_generator.go
    • Line 19: warning: exported type MonitorQuery should have comment or be unexported (golint)
    • Line 125: warning: exported type MonitorClusterQueryGenerator should have comment or be unexported (golint)
    • Line 133: warning: exported function NewMonitorQueryGenerator should have comment or be unexported (golint)
    • Line 148: warning: exported method MonitorClusterQueryGenerator.NewClusterQuery should have comment or be unexported (golint)
    • Line 178: warning: exported type MonitorInfraEnvQuery should have comment or be unexported (golint)
    • Line 275: warning: exported type MonitorInfraEnvQueryGenerator should have comment or be unexported (golint)
    • Line 282: warning: exported method MonitorInfraEnvQueryGenerator.NewInfraEnvQuery should have comment or be unexported (golint)
    • Line 316: warning: exported function NewInfraEnvMonitorQueryGenerator should have comment or be unexported (golint)
    • assisted-service/pkg/s3wrapper/util.go
    • Line 31: warning: exported function FixEndpointURL should have comment or be unexported (golint)
    • Line 42: warning: don't use underscores in Go names; var new_url should be newURL (golint)
    • Line 50: warning: exported function DownloadURLToTemporaryFile should have comment or be unexported (golint)
    • Line 73: warning: exported function UploadFromURLToPublicBucket should have comment or be unexported (golint)
    • Line 90: warning: exported function CreateAndUploadMinimalIso should have comment or be unexported (golint)
    • Line 168: warning: comment on exported function CreateTar should be of the form "CreateTar ..." (golint)
    • Line 214: warning: comment on exported function TarAwsFiles should be of the form "TarAwsFiles ..." (golint)
    • assisted-service/internal/network/cidr_validations.go
    • Line 9: warning: comment on exported const MinMaskDelta should be of the form "MinMaskDelta ..." (golint)
    • Line 12: warning: comment on exported const MinMachineMaskDelta should be of the form "MinMachineMaskDelta ..." (golint)
    • Line 23: warning: exported function VerifyCIDRsNotOverlap should have comment or be unexported (golint)
    • Line 57: warning: exported function VerifyClusterOrServiceCIDR should have comment or be unexported (golint)
    • Line 61: warning: exported function VerifyMachineCIDR should have comment or be unexported (golint)
    • Line 79: warning: exported function VerifyClusterCidrSize should have comment or be unexported (golint)
    • Line 104: warning: exported function VerifyClusterCIDRsNotOverlap should have comment or be unexported (golint)
    • Line 122: warning: exported function VerifyNetworkHostPrefix should have comment or be unexported (golint)
    • assisted-service/pkg/mirrorregistries/generator.go
    • Line 11: warning: comment on exported type MirrorRegistriesConfigBuilder should be of the form "MirrorRegistriesConfigBuilder ..." (with optional leading article) (golint)
    • Line 22: warning: exported function New should have comment or be unexported (golint)
    • Line 26: warning: exported type RegistriesConf should have comment or be unexported (golint)
    • assisted-service/pkg/context/param.go
    • Line 19: warning: exported function GetParam should have comment or be unexported (golint)
    • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 28: warning: comment on exported function ContextHandler should be of the form "ContextHandler ..." (golint)
    • assisted-service/internal/manifests/api/interface.go
    • Line 11: warning: comment on exported type ManifestsAPI should be of the form "ManifestsAPI ..." (with optional leading article) (golint)
    • Line 17: warning: comment on exported type ClusterManifestsInternals should be of the form "ClusterManifestsInternals ..." (with optional leading article) (golint)
    • assisted-service/internal/cluster/cluster.go
    • Line 45: warning: exported const DhcpLeaseTimeoutMinutes should have comment or be unexported (golint)
    • Line 47: warning: exported var S3FileNames should have comment or be unexported (golint)
    • Line 60: warning: exported var ClusterOwnerFileNames should have comment or be unexported (golint)
    • Line 68: warning: exported type RegistrationAPI should have comment or be unexported (golint)
    • Line 79: warning: exported type InstallationAPI should have comment or be unexported (golint)
    • Line 84: warning: exported type ProgressAPI should have comment or be unexported (golint)
    • Line 89: warning: exported type API should have comment or be unexported (golint)
    • Line 122: warning: exported type LogTimeoutConfig should have comment or be unexported (golint)
    • Line 126: warning: exported type PrepareConfig should have comment or be unexported (golint)
    • Line 131: warning: exported type Config should have comment or be unexported (golint)
    • Line 138: warning: exported type Manager should have comment or be unexported (golint)
    • Line 158: warning: exported function NewManager should have comment or be unexported (golint)
    • Line 188: warning: exported method Manager.RegisterCluster should have comment or be unexported (golint)
    • Line 199: warning: exported method Manager.RegisterAddHostsCluster should have comment or be unexported (golint)
    • Line 209: warning: exported method Manager.RegisterAddHostsOCPCluster should have comment or be unexported (golint)
    • Line 213: warning: exported method Manager.DeregisterCluster should have comment or be unexported (golint)
    • Line 301: warning: exported function GetValidations should have comment or be unexported (golint)
    • Line 327: warning: exported method Manager.RefreshStatus should have comment or be unexported (golint)
    • Line 395: warning: exported method Manager.SetUploadControllerLogsAt should have comment or be unexported (golint)
    • Line 403: warning: exported method Manager.GetMasterNodesIds should have comment or be unexported (golint)
    • Line 470: warning: exported method Manager.SkipMonitoring should have comment or be unexported (golint)
    • Line 493: warning: exported method Manager.ClusterMonitoring should have comment or be unexported (golint)
    • Line 566: warning: exported function CanDownloadFiles should have comment or be unexported (golint)
    • Line 584: warning: exported function CanDownloadKubeconfig should have comment or be unexported (golint)
    • Line 598: warning: exported method Manager.IsOperatorAvailable should have comment or be unexported (golint)
    • Line 615: warning: exported method Manager.UploadIngressCert should have comment or be unexported (golint)
    • Line 624: warning: exported method Manager.AcceptRegistration should have comment or be unexported (golint)
    • Line 637: warning: exported method Manager.VerifyClusterUpdatability should have comment or be unexported (golint)
    • Line 646: warning: exported method Manager.CancelInstallation should have comment or be unexported (golint)
    • Line 677: warning: exported method Manager.UpdateLogsProgress should have comment or be unexported (golint)
    • Line 682: warning: exported method Manager.UpdateInstallProgress should have comment or be unexported (golint)
    • Line 715: warning: exported method Manager.UpdateFinalizingProgress should have comment or be unexported (golint)
    • Line 751: warning: exported method Manager.UpdateAmsSubscriptionID should have comment or be unexported (golint)
    • Line 760: warning: exported method Manager.ResetCluster should have comment or be unexported (golint)
    • Line 784: warning: exported method Manager.PrepareForInstallation should have comment or be unexported (golint)
    • Line 796: warning: exported method Manager.HandlePreInstallError should have comment or be unexported (golint)
    • Line 810: warning: exported method Manager.HandlePreInstallSuccess should have comment or be unexported (golint)
    • Line 828: warning: exported method Manager.SetVipsData should have comment or be unexported (golint)
    • Line 873: warning: exported method Manager.CreateTarredClusterLogs should have comment or be unexported (golint)
    • Line 923: warning: exported method Manager.IsReadyForInstallation should have comment or be unexported (golint)
    • Line 989: warning: exported method Manager.SetConnectivityMajorityGroupsForCluster should have comment or be unexported (golint)
    • Line 1043: warning: exported method Manager.DeleteClusterLogs should have comment or be unexported (golint)
    • Line 1047: warning: exported method Manager.DeleteClusterFiles should have comment or be unexported (golint)
    • Line 1051: warning: exported method Manager.DeregisterInactiveCluster should have comment or be unexported (golint)
    • Line 1070: warning: exported method Manager.PermanentClustersDeletion should have comment or be unexported (golint)
    • Line 1122: warning: exported method Manager.GetClusterByKubeKey should have comment or be unexported (golint)
    • Line 1130: warning: exported method Manager.GenerateAdditionalManifests should have comment or be unexported (golint)
    • Line 1162: warning: exported method Manager.CompleteInstallation should have comment or be unexported (golint)
    • Line 1205: warning: exported method Manager.TransformClusterToDay2 should have comment or be unexported (golint)
    • assisted-service/pkg/auth/rhsso_authenticator.go
    • Line 26: warning: exported type RHSSOAuthenticator should have comment or be unexported (golint)
    • Line 35: warning: exported function NewRHSSOAuthenticator should have comment or be unexported (golint)
    • Line 52: warning: exported method RHSSOAuthenticator.AuthType should have comment or be unexported (golint)
    • Line 84: warning: exported method RHSSOAuthenticator.AuthAgentAuth should have comment or be unexported (golint)
    • Line 162: warning: exported method RHSSOAuthenticator.AuthUserAuth should have comment or be unexported (golint)
    • Line 280: warning: exported method RHSSOAuthenticator.AuthURLAuth should have comment or be unexported (golint)
    • Line 284: warning: exported method RHSSOAuthenticator.CreateAuthenticator should have comment or be unexported (golint)
    • assisted-service/pkg/s3wrapper/client.go
    • Line 38: warning: exported const DiscoveryImageTemplate should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: comment on exported type API should be of the form "API ..." (with optional leading article) (golint)
    • Line 72: warning: exported type S3Client should have comment or be unexported (golint)
    • Line 86: warning: exported type Config should have comment or be unexported (golint)
    • Line 167: warning: exported method S3Client.IsAwsS3 should have comment or be unexported (golint)
    • Line 191: warning: exported method S3Client.CreateBucket should have comment or be unexported (golint)
    • Line 195: warning: exported method S3Client.CreatePublicBucket should have comment or be unexported (golint)
    • Line 215: warning: exported method S3Client.UploadStream should have comment or be unexported (golint)
    • Line 219: warning: exported method S3Client.UploadStreamToPublicBucket should have comment or be unexported (golint)
    • Line 238: warning: exported method S3Client.UploadFile should have comment or be unexported (golint)
    • Line 242: warning: exported method S3Client.UploadFileToPublicBucket should have comment or be unexported (golint)
    • Line 246: warning: exported method S3Client.UploadISO should have comment or be unexported (golint)
    • Line 251: warning: exported method S3Client.Upload should have comment or be unexported (golint)
    • Line 283: warning: exported method S3Client.Download should have comment or be unexported (golint)
    • Line 287: warning: exported method S3Client.DownloadPublic should have comment or be unexported (golint)
    • Line 309: warning: exported method S3Client.DoesObjectExist should have comment or be unexported (golint)
    • Line 313: warning: exported method S3Client.DoesPublicObjectExist should have comment or be unexported (golint)
    • Line 317: warning: exported method S3Client.DeleteObject should have comment or be unexported (golint)
    • Line 339: warning: exported method S3Client.UpdateObjectTimestamp should have comment or be unexported (golint)
    • Line 381: warning: exported method S3Client.GetObjectSizeBytes should have comment or be unexported (golint)
    • Line 385: warning: exported method S3Client.GeneratePresignedDownloadURL should have comment or be unexported (golint)
    • Line 410: warning: exported method S3Client.ExpireObjects should have comment or be unexported (golint)
    • Line 463: warning: exported method S3Client.ListObjectsByPrefix should have comment or be unexported (golint)
    • Line 482: warning: exported method S3Client.UploadISOs should have comment or be unexported (golint)
    • Line 553: warning: exported method S3Client.GetBaseIsoObject should have comment or be unexported (golint)
    • Line 562: warning: exported method S3Client.GetMinimalIsoObjectName should have comment or be unexported (golint)
    • assisted-service/internal/network/dual_stack_validations.go
    • Line 8: warning: comment on exported function VerifyMachineNetworksDualStack should be of the form "VerifyMachineNetworksDualStack ..." (golint)
    • Line 29: warning: exported function VerifyServiceNetworksDualStack should have comment or be unexported (golint)
    • Line 46: warning: exported function VerifyClusterNetworksDualStack should have comment or be unexported (golint)
    • assisted-service/internal/host/statemachine.go
    • Line 9: warning: exported const TransitionTypeRegisterHost should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: comment on exported function NewHostStateMachine should be of the form "NewHostStateMachine ..." (golint)
    • assisted-service/internal/events/events_api.go
    • Line 18: warning: exported type Api should have comment or be unexported (golint)
    • Line 23: warning: exported function NewApi should have comment or be unexported (golint)
    • Line 30: warning: exported method Api.ListEvents should have comment or be unexported (golint)
    • Line 52: warning: exported method Api.V2ListEvents should have comment or be unexported (golint)
    • assisted-service/internal/common/common_unitest_db.go
    • Line 10: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 11: warning: should not use dot imports (golint)
    • Line 20: warning: exported type DBContext should have comment or be unexported (golint)
    • Line 25: warning: exported method DBContext.GetPort should have comment or be unexported (golint)
    • Line 28: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 38: warning: exported function InitializeDBTest should have comment or be unexported (golint)
    • Line 71: warning: exported function TerminateDBTest should have comment or be unexported (golint)
    • Line 88: warning: exported function PrepareTestDB should have comment or be unexported (golint)
    • Line 113: warning: exported function DeleteTestDB should have comment or be unexported (golint)
    • assisted-service/pkg/log/context.go
    • Line 19: warning: exported type Config should have comment or be unexported (golint)
    • Line 30: warning: exported function EntryFromContext should have comment or be unexported (golint)
    • Line 40: warning: don't use underscores in Go names; var cluster_id should be clusterID (golint)
    • Line 45: warning: don't use underscores in Go names; var host_id should be hostID (golint)
    • assisted-service/internal/host/host.go
    • Line 36: warning: exported var BootstrapStages should have comment or be unexported (golint)
    • Line 43: warning: exported var MasterStages should have comment or be unexported (golint)
    • Line 48: warning: exported var WorkerStages should have comment or be unexported (golint)
    • Line 63: warning: exported var InstallationProgressTimeout should have comment or be unexported (golint)
    • Line 84: warning: exported var WrongBootOrderIgnoreTimeoutStages should have comment or be unexported (golint)
    • Line 91: warning: exported var InstallationTimeout should have comment or be unexported (golint)
    • Line 93: warning: exported var MaxHostDisconnectionTime should have comment or be unexported (golint)
    • Line 95: warning: exported type LogTimeoutConfig should have comment or be unexported (golint)
    • Line 100: warning: exported type Config should have comment or be unexported (golint)
    • Line 109: warning: comment on exported type API should be of the form "API ..." (with optional leading article) (golint)
    • Line 163: warning: exported type Manager should have comment or be unexported (golint)
    • Line 178: warning: exported function NewManager should have comment or be unexported (golint)
    • Line 202: warning: exported method Manager.RegisterHost should have comment or be unexported (golint)
    • Line 234: warning: exported method Manager.RegisterInstalledOCPHost should have comment or be unexported (golint)
    • Line 241: warning: exported method Manager.HandleInstallationFailure should have comment or be unexported (golint)
    • Line 291: warning: exported method Manager.HandlePrepareInstallationFailure should have comment or be unexported (golint)
    • Line 305: warning: exported method Manager.RefreshInventory should have comment or be unexported (golint)
    • Line 309: warning: exported method Manager.UpdateInventory should have comment or be unexported (golint)
    • Line 449: warning: exported method Manager.RefreshRole should have comment or be unexported (golint)
    • Line 456: warning: exported method Manager.RefreshStatus should have comment or be unexported (golint)
    • Line 463: warning: exported method Manager.Install should have comment or be unexported (golint)
    • Line 474: warning: exported method Manager.EnableHost should have comment or be unexported (golint)
    • Line 481: warning: exported method Manager.DisableHost should have comment or be unexported (golint)
    • Line 488: warning: exported method Manager.BindHost should have comment or be unexported (golint)
    • Line 496: warning: exported method Manager.UnbindHost should have comment or be unexported (golint)
    • Line 503: warning: exported method Manager.GetNextSteps should have comment or be unexported (golint)
    • Line 507: warning: exported method Manager.IndexOfStage should have comment or be unexported (golint)
    • Line 516: warning: exported method Manager.UpdateInstallProgress should have comment or be unexported (golint)
    • Line 602: warning: exported method Manager.SetBootstrap should have comment or be unexported (golint)
    • Line 612: warning: exported method Manager.UpdateLogsProgress should have comment or be unexported (golint)
    • Line 618: warning: exported method Manager.SetUploadLogsAt should have comment or be unexported (golint)
    • Line 626: warning: exported method Manager.UpdateConnectivityReport should have comment or be unexported (golint)
    • Line 645: warning: exported method Manager.UpdateApiVipConnectivityReport should have comment or be unexported (golint)
    • Line 654: warning: exported method Manager.UpdateRole should have comment or be unexported (golint)
    • Line 666: warning: exported method Manager.UpdateMachineConfigPoolName should have comment or be unexported (golint)
    • Line 688: warning: exported method Manager.UpdateNTP should have comment or be unexported (golint)
    • Line 698: warning: exported method Manager.UpdateDomainNameResolution should have comment or be unexported (golint)
    • Line 714: warning: exported method Manager.UpdateImageStatus should have comment or be unexported (golint)
    • Line 747: warning: exported method Manager.UpdateHostname should have comment or be unexported (golint)
    • Line 764: warning: exported method Manager.UpdateInstallationDisk should have comment or be unexported (golint)
    • Line 798: warning: exported method Manager.UpdateKubeKeyNS should have comment or be unexported (golint)
    • Line 802: warning: exported method Manager.CancelInstallation should have comment or be unexported (golint)
    • Line 832: warning: exported method Manager.IsRequireUserActionReset should have comment or be unexported (golint)
    • Line 849: warning: exported method Manager.ResetHost should have comment or be unexported (golint)
    • Line 892: warning: exported method Manager.ResetPendingUserAction should have comment or be unexported (golint)
    • Line 921: warning: exported method Manager.GetStagesByRole should have comment or be unexported (golint)
    • Line 936: warning: exported method Manager.IsInstallable should have comment or be unexported (golint)
    • Line 961: warning: exported method Manager.ReportValidationFailedMetrics should have comment or be unexported (golint)
    • Line 1030: warning: exported method Manager.AutoAssignRole should have comment or be unexported (golint)
    • Line 1117: warning: exported method Manager.IsValidMasterCandidate should have comment or be unexported (golint)
    • Line 1151: warning: exported method Manager.GetHostValidDisks should have comment or be unexported (golint)
    • Line 1155: warning: exported method Manager.SetDiskSpeed should have comment or be unexported (golint)
    • Line 1200: warning: exported method Manager.ResetHostValidation should have comment or be unexported (golint)
    • Line 1232: warning: exported method Manager.PermanentHostsDeletion should have comment or be unexported (golint)
    • Line 1251: warning: exported type DisabledHostValidations should have comment or be unexported (golint)
    • Line 1253: warning: exported method DisabledHostValidations.Decode should have comment or be unexported (golint)
    • Line 1269: warning: exported method DisabledHostValidations.IsDisabled should have comment or be unexported (golint)
    • Line 1274: warning: exported method Manager.GetHostByKubeKey should have comment or be unexported (golint)
    • Line 1282: warning: exported method Manager.UnRegisterHost should have comment or be unexported (golint)
    • assisted-service/internal/network/manifests_generator.go
    • Line 24: warning: exported type ManifestsGeneratorAPI should have comment or be unexported (golint)
    • Line 32: warning: exported type Config should have comment or be unexported (golint)
    • Line 36: warning: exported type ManifestsGenerator should have comment or be unexported (golint)
    • Line 41: warning: exported function NewManifestsGenerator should have comment or be unexported (golint)
    • Line 215: warning: exported method ManifestsGenerator.AddChronyManifest should have comment or be unexported (golint)
    • Line 233: warning: exported method ManifestsGenerator.AddSchedulableMastersManifest should have comment or be unexported (golint)
    • Line 299: warning: exported method ManifestsGenerator.AddDiskEncryptionManifest should have comment or be unexported (golint)
    • Line 375: warning: exported method ManifestsGenerator.AddDnsmasqForSingleNode should have comment or be unexported (golint)
    • Line 460: warning: comment on exported method ManifestsGenerator.AddTelemeterManifest should be of the form "AddTelemeterManifest ..." (golint)

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • assisted-service/internal/bminventory/inventory.go
    • Line 1113: warning: cyclomatic complexity 28 of function (*bareMetalInventory).GenerateClusterISOInternal() is high (> 15) (gocyclo)
    • Line 5542: warning: cyclomatic complexity 26 of function (*bareMetalInventory).RegisterInfraEnvInternal() is high (> 15) (gocyclo)
    • Line 2203: warning: cyclomatic complexity 26 of function (*bareMetalInventory).updateClusterInternal() is high (> 15) (gocyclo)
    • Line 2693: warning: cyclomatic complexity 24 of function (*bareMetalInventory).updateNetworks() is high (> 15) (gocyclo)
    • Line 1558: warning: cyclomatic complexity 23 of function (*bareMetalInventory).InstallClusterInternal() is high (> 15) (gocyclo)
    • Line 447: warning: cyclomatic complexity 22 of function (*bareMetalInventory).RegisterClusterInternal() is high (> 15) (gocyclo)
    • Line 2365: warning: cyclomatic complexity 22 of function (*bareMetalInventory).v2UpdateClusterInternal() is high (> 15) (gocyclo)
    • Line 2486: warning: cyclomatic complexity 20 of function (*bareMetalInventory).updateNonDhcpNetworkParams() is high (> 15) (gocyclo)
    • Line 5983: warning: cyclomatic complexity 17 of function (*bareMetalInventory).V2RegisterHost() is high (> 15) (gocyclo)
    • Line 5839: warning: cyclomatic complexity 17 of function (*bareMetalInventory).updateInfraEnvData() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!