gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• image-registry/test/integration/pullthroughblob/pullthroughblob_test.go
  • Line 26: warning: cyclomatic complexity 20 of function TestPullthroughBlob() is high (> 15) (gocyclo)

• image-registry/pkg/origin-common/util/util.go
  • Line 75: warning: cyclomatic complexity 17 of function InternalImageWithMetadata() is high (> 15) (gocyclo)

• image-registry/pkg/origin-common/util/httprequest/httprequest.go
  • Line 59: warning: cyclomatic complexity 18 of function SchemeHost() is high (> 15) (gocyclo)

• image-registry/pkg/testutil/manifests.go
  • Line 156: warning: cyclomatic complexity 18 of function CreateAndUploadTestManifest() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/auth_test.go
  • Line 107: warning: cyclomatic complexity 26 of function TestAccessController() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/catalog.go
  • Line 88: warning: cyclomatic complexity 17 of function (*cachingRepositoryEnumerator).enumerateImageStreams() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/manifestservice.go
  • Line 96: warning: cyclomatic complexity 16 of function (*manifestService).Put() is high (> 15) (gocyclo)

• image-registry/pkg/cmd/dockerregistry/dockerregistry.go
  • Line 108: warning: cyclomatic complexity 19 of function Execute() is high (> 15) (gocyclo)

• image-registry/test/integration/v2/v2_docker_registry_test.go
  • Line 87: warning: cyclomatic complexity 41 of function TestV2RegistryGetTags() is high (> 15) (gocyclo)

• image-registry/test/integration/pullthrough/pullthrough_test.go
  • Line 85: warning: cyclomatic complexity 28 of function TestPullThroughInsecure() is high (> 15) (gocyclo)

• image-registry/pkg/origin-common/clientcmd/addr.go
  • Line 60: warning: cyclomatic complexity 24 of function (*Addr).Set() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/pullthroughblobstore_test.go
  • Line 329: warning: cyclomatic complexity 25 of function TestPullthroughServeBlobInsecure() is high (> 15) (gocyclo)
  • Line 35: warning: cyclomatic complexity 22 of function TestPullthroughServeBlob() is high (> 15) (gocyclo)

• image-registry/tools/import-verifier/import-verifier.go
  • Line 174: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• image-registry/pkg/imagestream/imagestream.go
  • Line 312: warning: cyclomatic complexity 16 of function (*imageStream).CreateImageStreamMapping() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/configuration/configuration.go
  • Line 469: warning: cyclomatic complexity 17 of function migrateMiddleware() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/auth.go
  • Line 182: warning: cyclomatic complexity 46 of function (*AccessController).Authorized() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/repository_test.go
  • Line 44: warning: cyclomatic complexity 28 of function TestRepositoryBlobStat() is high (> 15) (gocyclo)
  • Line 352: warning: cyclomatic complexity 25 of function TestRepositoryBlobStatCacheEviction() is high (> 15) (gocyclo)
  • Line 522: warning: cyclomatic complexity 21 of function storeTestImage() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/blobdescriptorservice_test.go
  • Line 39: warning: cyclomatic complexity 24 of function TestBlobDescriptorServiceIsApplied() is high (> 15) (gocyclo)

• image-registry/pkg/testframework/registry.go
  • Line 212: warning: cyclomatic complexity 30 of function CreateEphemeralRegistry() is high (> 15) (gocyclo)

• image-registry/tools/changelog/changelog.go
  • Line 80: warning: cyclomatic complexity 40 of function main() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/cache/cacheprovider_test.go
  • Line 131: warning: cyclomatic complexity 20 of function TestRepositoryScopedProviderStat() is high (> 15) (gocyclo)

• image-registry/test/integration/metricspullthrough/metricspullthrough_test.go
  • Line 25: warning: cyclomatic complexity 25 of function TestMetricsPullthroughBlob() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/prune/prune.go
  • Line 176: warning: cyclomatic complexity 24 of function Prune() is high (> 15) (gocyclo)

• image-registry/pkg/origin-common/clientcmd/clientcmd.go
  • Line 97: warning: cyclomatic complexity 37 of function (*Config).bindEnv() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/pullthroughmanifestservice_test.go
  • Line 227: warning: cyclomatic complexity 24 of function TestPullthroughManifestInsecure() is high (> 15) (gocyclo)
  • Line 56: warning: cyclomatic complexity 24 of function TestPullthroughManifests() is high (> 15) (gocyclo)

• image-registry/pkg/cmd/dockerregistry/listfs.go
  • Line 27: warning: cyclomatic complexity 16 of function ExecuteListFS() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/maxconnections/limiter_test.go
  • Line 87: warning: cyclomatic complexity 17 of function TestLimiterContext() is high (> 15) (gocyclo)

• image-registry/tools/gotest2junit/gotest2junit.go
  • Line 91: warning: cyclomatic complexity 29 of function stream() is high (> 15) (gocyclo)

• image-registry/pkg/dockerregistry/server/prune/restore.go
  • Line 280: warning: cyclomatic complexity 19 of function (*Fsck).Storage() is high (> 15) (gocyclo)
  • Line 195: warning: cyclomatic complexity 18 of function (*Fsck).Database() is high (> 15) (gocyclo)

golint69%

Golint is a linter for Go source code.

• image-registry/pkg/testframework/project.go
  • Line 17: warning: exported function CreateProject should have comment or be unexported (golint)
  • Line 47: warning: exported function DeleteProject should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/cache/cacheprovider.go
  • Line 12: warning: exported type Provider should have comment or be unexported (golint)
  • Line 18: warning: exported method Provider.RepositoryScoped should have comment or be unexported (golint)
  • Line 28: warning: exported method Provider.Stat should have comment or be unexported (golint)
  • Line 32: warning: exported method Provider.SetDescriptor should have comment or be unexported (golint)
  • Line 38: warning: exported method Provider.Clear should have comment or be unexported (golint)

• image-registry/pkg/imagestream/imagestream.go
  • Line 27: warning: exported const ErrImageStreamCode should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported type ImageStream should have comment or be unexported (golint)
  • Line 79: warning: exported function New should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/metrics/testing/counter.go
  • Line 76: warning: exported function NewCounterSink should have comment or be unexported (golint)

• image-registry/pkg/testframework/client.go
  • Line 20: warning: exported function GenerateRandomBytes should have comment or be unexported (golint)
  • Line 29: warning: exported function GenerateOAuthTokenPair should have comment or be unexported (golint)
  • Line 36: warning: exported function GetClientForUser should have comment or be unexported (golint)

• image-registry/pkg/testframework/wait.go
  • Line 12: warning: exported function WaitTCP should have comment or be unexported (golint)
  • Line 29: warning: exported function WaitHTTP should have comment or be unexported (golint)

• image-registry/tools/import-verifier/import-verifier.go
  • Line 27: warning: exported type ImportRestriction should have comment or be unexported (golint)

• image-registry/pkg/testframework/registry.go
  • Line 37: warning: exported type CloseFunc should have comment or be unexported (golint)
  • Line 39: warning: exported type RegistryOption should have comment or be unexported (golint)
  • Line 43: warning: exported type DisableMirroring should have comment or be unexported (golint)
  • Line 45: warning: exported method DisableMirroring.Apply should have comment or be unexported (golint)
  • Line 49: warning: exported type EnableMetrics should have comment or be unexported (golint)
  • Line 53: warning: exported method EnableMetrics.Apply should have comment or be unexported (golint)
  • Line 58: warning: exported function StartTestRegistry should have comment or be unexported (golint)
  • Line 140: warning: exported type Registry should have comment or be unexported (golint)
  • Line 146: warning: exported method Registry.Close should have comment or be unexported (golint)
  • Line 152: warning: exported method Registry.Addr should have comment or be unexported (golint)
  • Line 156: warning: exported method Registry.BaseURL should have comment or be unexported (golint)
  • Line 160: warning: exported method Registry.Repository should have comment or be unexported (golint)
  • Line 184: warning: exported type AuthConfig should have comment or be unexported (golint)
  • Line 189: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 193: warning: exported function MakeDockerConfigSecret should have comment or be unexported (golint)
  • Line 210: warning: exported type CleanupFunc should have comment or be unexported (golint)
  • Line 212: warning: exported function CreateEphemeralRegistry should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/prune/restore.go
  • Line 40: warning: exported method DryRunRestore.BrokenImage should have comment or be unexported (golint)
  • Line 68: warning: exported type StorageRestore should have comment or be unexported (golint)
  • Line 77: warning: exported method StorageRestore.ImageStreamTag should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/pullthroughmanifestservice_test.go
  • Line 32: warning: context.Context should be the first parameter of a function (golint)

• image-registry/tools/gotest2junit/gotest2junit.go
  • Line 18: warning: exported type Record should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/storage/storage.go
  • Line 12: warning: exported type Enumerator should have comment or be unexported (golint)
  • Line 16: warning: exported method Enumerator.Repositories should have comment or be unexported (golint)
  • Line 24: warning: exported method Enumerator.Blobs should have comment or be unexported (golint)
  • Line 28: warning: exported method Enumerator.Manifests should have comment or be unexported (golint)

• image-registry/pkg/testutil/util.go
  • Line 32: warning: exported function NewTransport should have comment or be unexported (golint)
  • Line 81: warning: exported function NewInsecureRepository should have comment or be unexported (golint)
  • Line 270: warning: exported const SampleImageManifestSchema1 should have comment or be unexported (golint)
  • Line 425: warning: exported function ConvertImage should have comment or be unexported (golint)
  • Line 448: warning: exported function VerifyRemoteImage should have comment or be unexported (golint)

• image-registry/pkg/kubernetes-common/credentialprovider/keyring.go
  • Line 65: warning: exported function DockerConfigEntryToLazyAuthConfiguration should have comment or be unexported (golint)
  • Line 75: warning: exported method BasicDockerKeyring.Add should have comment or be unexported (golint)
  • Line 278: warning: exported type FakeKeyring should have comment or be unexported (golint)
  • Line 283: warning: exported method FakeKeyring.Lookup should have comment or be unexported (golint)

• image-registry/pkg/testutil/manifests.go
  • Line 29: warning: exported type ManifestSchemaVersion should have comment or be unexported (golint)
  • Line 31: warning: exported type ConfigPayload should have comment or be unexported (golint)
  • Line 34: warning: exported const ManifestSchema1 should have comment (or a comment on this block) or be unexported (golint)
  • Line 126: warning: exported function MakeRandomLayer should have comment or be unexported (golint)
  • Line 139: warning: exported function MakeManifestConfig should have comment or be unexported (golint)

• image-registry/pkg/imagestream/image.go
  • Line 22: warning: exported const ErrImageGetterCode should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported function IsImageManaged should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/auth.go
  • Line 31: warning: error should be the last type when returning multiple items (golint)
  • Line 55: warning: exported type AccessController should have comment or be unexported (golint)
  • Line 93: warning: exported method App.Auth should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/catalog.go
  • Line 88: warning: receiver name r should be consistent with previous receiver name re for cachingRepositoryEnumerator (golint)

• image-registry/pkg/testframework/httptest.go
  • Line 11: warning: exported type HTTPServer should have comment or be unexported (golint)
  • Line 19: warning: exported function NewHTTPServer should have comment or be unexported (golint)
  • Line 59: warning: exported method HTTPServer.Close should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/cache/blobstater.go
  • Line 10: warning: exported type BlobStatter should have comment or be unexported (golint)

• image-registry/pkg/cmd/dockerregistry/listfs.go
  • Line 20: warning: exported type ListOptions should have comment or be unexported (golint)
  • Line 27: warning: exported function ExecuteListFS should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/configuration/configuration.go
  • Line 110: warning: exported var ErrUnsupportedVersion should have comment or be unexported (golint)
  • Line 117: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 131: warning: exported type Metrics should have comment or be unexported (golint)
  • Line 136: warning: exported type Requests should have comment or be unexported (golint)
  • Line 141: warning: exported type RequestsLimits should have comment or be unexported (golint)
  • Line 147: warning: exported type Server should have comment or be unexported (golint)
  • Line 151: warning: exported type Auth should have comment or be unexported (golint)
  • Line 156: warning: exported type Audit should have comment or be unexported (golint)
  • Line 160: warning: exported type Cache should have comment or be unexported (golint)
  • Line 165: warning: exported type Quota should have comment or be unexported (golint)
  • Line 170: warning: exported type Pullthrough should have comment or be unexported (golint)
  • Line 175: warning: exported type Compatibility should have comment or be unexported (golint)
  • Line 542: warning: exported function InitExtraConfig should have comment or be unexported (golint)

• image-registry/pkg/testutil/logger/logger.go
  • Line 8: warning: exported type Logger should have comment or be unexported (golint)
  • Line 14: warning: exported function New should have comment or be unexported (golint)

• image-registry/pkg/requesttrace/requesttrace.go
  • Line 21: warning: exported function New should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/prune/prune.go
  • Line 39: warning: exported method DryRunPruner.DeleteRepository should have comment or be unexported (golint)
  • Line 45: warning: exported method DryRunPruner.DeleteManifestLink should have comment or be unexported (golint)
  • Line 51: warning: exported method DryRunPruner.DeleteBlob should have comment or be unexported (golint)

• image-registry/pkg/testframework/config.go
  • Line 8: warning: exported function ConfigFromFile should have comment or be unexported (golint)
  • Line 17: warning: exported function UserClientConfig should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/app.go
  • Line 74: warning: exported method App.Storage should have comment or be unexported (golint)
  • Line 79: warning: exported method App.Registry should have comment or be unexported (golint)
  • Line 87: warning: exported method App.BlobStatter should have comment or be unexported (golint)
  • Line 94: warning: exported method App.CacheProvider should have comment or be unexported (golint)

• image-registry/pkg/kubernetes-common/credentialprovider/config.go
  • Line 46: warning: exported type DockerConfigEntry should have comment or be unexported (golint)
  • Line 66: warning: exported function SetPreferredDockercfgPath should have comment or be unexported (golint)
  • Line 72: warning: exported function GetPreferredDockercfgPath should have comment or be unexported (golint)
  • Line 156: warning: exported function ReadDockerConfigFile should have comment or be unexported (golint)
  • Line 176: warning: exported function ReadUrl should have comment or be unexported (golint)
  • Line 206: warning: exported function ReadDockerConfigFileFromUrl should have comment or be unexported (golint)
  • Line 209: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 245: warning: exported method DockerConfigEntry.UnmarshalJSON should have comment or be unexported (golint)
  • Line 264: warning: exported method DockerConfigEntry.MarshalJSON should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/client/interfaces.go
  • Line 20: warning: exported type UsersInterfacer should have comment or be unexported (golint)
  • Line 24: warning: exported type ImagesInterfacer should have comment or be unexported (golint)
  • Line 28: warning: exported type ImageSignaturesInterfacer should have comment or be unexported (golint)
  • Line 32: warning: exported type ImageStreamImagesNamespacer should have comment or be unexported (golint)
  • Line 36: warning: exported type ImageStreamsNamespacer should have comment or be unexported (golint)
  • Line 40: warning: exported type ImageStreamMappingsNamespacer should have comment or be unexported (golint)
  • Line 44: warning: exported type ImageStreamSecretsNamespacer should have comment or be unexported (golint)
  • Line 48: warning: exported type ImageStreamTagsNamespacer should have comment or be unexported (golint)
  • Line 52: warning: exported type LimitRangesGetter should have comment or be unexported (golint)
  • Line 56: warning: exported type LocalSubjectAccessReviewsNamespacer should have comment or be unexported (golint)
  • Line 60: warning: exported type SelfSubjectAccessReviewsNamespacer should have comment or be unexported (golint)
  • Line 66: warning: exported type ImageSignatureInterface should have comment or be unexported (golint)
  • Line 72: warning: exported type ImageStreamImageInterface should have comment or be unexported (golint)
  • Line 78: warning: exported type UserInterface should have comment or be unexported (golint)
  • Line 84: warning: exported type ImageInterface should have comment or be unexported (golint)
  • Line 92: warning: exported type ImageStreamInterface should have comment or be unexported (golint)
  • Line 101: warning: exported type ImageStreamMappingInterface should have comment or be unexported (golint)
  • Line 107: warning: exported type ImageStreamTagInterface should have comment or be unexported (golint)
  • Line 113: warning: exported type ImageStreamSecretInterface should have comment or be unexported (golint)
  • Line 119: warning: exported type LimitRangeInterface should have comment or be unexported (golint)
  • Line 125: warning: exported type LocalSubjectAccessReviewInterface should have comment or be unexported (golint)
  • Line 131: warning: exported type SelfSubjectAccessReviewInterface should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/wrapped/filewriter.go
  • Line 15: warning: exported function NewFileWriter should have comment or be unexported (golint)

• image-registry/pkg/testutil/fakeopenshift.go
  • Line 54: warning: exported method FakeOpenShift.CreateImage should have comment or be unexported (golint)
  • Line 69: warning: exported method FakeOpenShift.GetImage should have comment or be unexported (golint)
  • Line 80: warning: exported method FakeOpenShift.UpdateImage should have comment or be unexported (golint)
  • Line 95: warning: exported method FakeOpenShift.CreateImageStream should have comment or be unexported (golint)
  • Line 115: warning: exported method FakeOpenShift.UpdateImageStream should have comment or be unexported (golint)
  • Line 135: warning: exported method FakeOpenShift.GetImageStream should have comment or be unexported (golint)
  • Line 148: warning: exported method FakeOpenShift.ListImageStreams should have comment or be unexported (golint)
  • Line 169: warning: exported method FakeOpenShift.CreateImageStreamMapping should have comment or be unexported (golint)
  • Line 211: warning: exported method FakeOpenShift.CreateImageStreamTag should have comment or be unexported (golint)
  • Line 285: warning: exported method FakeOpenShift.GetImageStreamImage should have comment or be unexported (golint)
  • Line 329: warning: exported method FakeOpenShift.GetImageStreamLayers should have comment or be unexported (golint)

• image-registry/pkg/imagestream/cachedimagestreamgetter.go
  • Line 18: warning: exported const ErrImageStreamGetterCode should have comment (or a comment on this block) or be unexported (golint)

• image-registry/test/internal/storage/waitable.go
  • Line 11: warning: exported type WaitableDriver should have comment or be unexported (golint)
  • Line 25: warning: exported function NewWaitableDriver should have comment or be unexported (golint)

• image-registry/pkg/testframework/master.go
  • Line 29: warning: exported type MasterInterface should have comment or be unexported (golint)
  • Line 35: warning: exported type MasterProcess should have comment or be unexported (golint)
  • Line 39: warning: exported function StartMasterProcess should have comment or be unexported (golint)
  • Line 48: warning: exported method MasterProcess.AdminKubeConfigPath should have comment or be unexported (golint)
  • Line 52: warning: exported method MasterProcess.Stop should have comment or be unexported (golint)
  • Line 54: warning: exported method MasterProcess.WaitHealthz should have comment or be unexported (golint)
  • Line 85: warning: exported type User should have comment or be unexported (golint)
  • Line 91: warning: exported method User.KubeConfig should have comment or be unexported (golint)
  • Line 95: warning: exported type Repository should have comment or be unexported (golint)
  • Line 102: warning: exported method Repository.BaseURL should have comment or be unexported (golint)
  • Line 106: warning: exported method Repository.RepoName should have comment or be unexported (golint)
  • Line 110: warning: exported method Repository.Transport should have comment or be unexported (golint)
  • Line 114: warning: exported type Master should have comment or be unexported (golint)
  • Line 121: warning: exported function NewMaster should have comment or be unexported (golint)
  • Line 145: warning: exported method Master.WaitForRoles should have comment or be unexported (golint)
  • Line 172: warning: exported method Master.Close should have comment or be unexported (golint)
  • Line 186: warning: exported method Master.AdminKubeConfig should have comment or be unexported (golint)
  • Line 201: warning: exported method Master.StartRegistry should have comment or be unexported (golint)
  • Line 210: warning: exported method Master.CreateUser should have comment or be unexported (golint)
  • Line 222: warning: exported method Master.GrantPrunerRole should have comment or be unexported (golint)
  • Line 238: warning: exported method Master.CreateProject should have comment or be unexported (golint)

• image-registry/pkg/origin-common/image/apis/image/helper.go
  • Line 98: warning: comment on exported method DockerImageReference.RegistryURL should be of the form "RegistryURL ..." (golint)
  • Line 106: warning: exported method DockerImageReference.AsV2 should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/metrichandler.go
  • Line 13: warning: exported function RegisterMetricHandler should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/api/routes.go
  • Line 8: warning: exported var AdminPrefix should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/client/test.go
  • Line 15: warning: exported function NewFakeRegistryClient should have comment or be unexported (golint)
  • Line 26: warning: exported function NewFakeRegistryAPIClient should have comment or be unexported (golint)

• image-registry/pkg/testframework/manifest.go
  • Line 16: warning: exported type Schema2ImageData should have comment or be unexported (golint)
  • Line 28: warning: exported function NewSchema2ImageData should have comment or be unexported (golint)
  • Line 77: warning: exported function ServeV2 should have comment or be unexported (golint)
  • Line 85: warning: exported function ServeImage should have comment or be unexported (golint)
  • Line 124: warning: exported function PushSchema2ImageData should have comment or be unexported (golint)

• image-registry/pkg/cmd/dockerregistry/dockerregistry.go
  • Line 27: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 30: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 202: warning: exported function NewServer should have comment or be unexported (golint)

• image-registry/tools/gotest2junit/pkg/api/types.go
  • Line 105: warning: exported const TestResultPass should have comment (or a comment on this block) or be unexported (golint)

• image-registry/pkg/origin-common/clientcmd/clientcmd.go
  • Line 66: warning: exported method Config.BindToFile should have comment or be unexported (golint)

• image-registry/pkg/kubernetes-common/credentialprovider/provider.go
  • Line 43: warning: exported function LazyProvide should have comment or be unexported (golint)
  • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• image-registry/pkg/dockerregistry/server/signaturedispatcher.go
  • Line 51: warning: exported var ErrorCodeSignatureInvalid should have comment or be unexported (golint)

• image-registry/test/internal/storage/factory.go
  • Line 14: warning: exported const Name should have comment or be unexported (golint)
  • Line 34: warning: exported function WithDriver should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/audit/log.go
  • Line 12: warning: exported const LogEntryType should have comment (or a comment on this block) or be unexported (golint)
  • Line 123: warning: should not use basic type string as key in context.WithValue (golint)

• image-registry/pkg/origin-common/image/apis/image/types.go
  • Line 30: warning: comment on exported const ImageSignatureTypeAtomicImageV1 should be of the form "ImageSignatureTypeAtomicImageV1 ..." (golint)
  • Line 37: warning: comment on exported const LimitTypeImage should be of the form "LimitTypeImage ..." (golint)

• image-registry/pkg/dockerregistry/server/cache/blobdescriptor.go
  • Line 10: warning: exported type RepositoryScopedBlobDescriptor should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/metrics/prometheus.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 31: warning: exported var HTTPInFlightRequests should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/util_test.go
  • Line 123: warning: should not use basic type string as key in context.WithValue (golint)

• image-registry/pkg/dockerregistry/server/cache/cache.go
  • Line 16: warning: exported type DigestCache should have comment or be unexported (golint)
  • Line 25: warning: exported type DigestValue should have comment or be unexported (golint)
  • Line 30: warning: exported type DigestItem should have comment or be unexported (golint)
  • Line 46: warning: exported function NewBlobDigest should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/wrapped/storagedriver.go
  • Line 18: warning: exported function NewStorageDriver should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/wrapped/readcloser.go
  • Line 13: warning: exported function NewReadCloser should have comment or be unexported (golint)

• image-registry/pkg/dockerregistry/server/cache/repodigest.go
  • Line 5: warning: exported type RepositoryDigest should have comment or be unexported (golint)
  • Line 17: warning: exported function NewRepositoryDigest should have comment or be unexported (golint)

• image-registry/pkg/cmd/dockerregistry/restore.go
  • Line 23: warning: exported function ExecuteRestore should have comment or be unexported (golint)

• image-registry/pkg/errors/errors.go
  • Line 13: warning: exported var ErrorCodePullthroughManifest should have comment or be unexported (golint)
  • Line 39: warning: exported function NewError should have comment or be unexported (golint)

• image-registry/pkg/errors/handle.go
  • Line 18: warning: exported function Handle should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• image-registry/pkg/dockerregistry/server/manifesthandler/manifestschema2handler.go
  • Line 74: warning: "presense" is a misspelling of "presence" (misspell)

• image-registry/pkg/dockerregistry/server/auth.go
  • Line 43: warning: "infomation" is a misspelling of "information" (misspell)