gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• managed-upgrade-operator/pkg/upgraders/workerstep.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/cmd/manager/main_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/pkg/upgradesteps/action.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/pkg/upgradesteps/runner.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/pkg/upgraders/notifierstep.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/pkg/upgraders/scalerstep.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• managed-upgrade-operator/pkg/upgraders/upgraders_suite_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• managed-upgrade-operator/pkg/clusterversion/cv.go
  • Line 71: warning: cyclomatic complexity 21 of function (*clusterVersionClient).EnsureDesiredConfig() is high (> 15) (gocyclo)

• managed-upgrade-operator/pkg/validation/validation.go
  • Line 70: warning: cyclomatic complexity 35 of function (*validator).IsValidUpgradeConfig() is high (> 15) (gocyclo)

• managed-upgrade-operator/pkg/upgradeconfigmanager/upgradeconfigmanager.go
  • Line 172: warning: cyclomatic complexity 23 of function (*upgradeConfigManager).Refresh() is high (> 15) (gocyclo)

• managed-upgrade-operator/cmd/manager/main.go
  • Line 65: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

• managed-upgrade-operator/pkg/notifier/ocmnotifier.go
  • Line 138: warning: cyclomatic complexity 22 of function validateStateTransition() is high (> 15) (gocyclo)

• managed-upgrade-operator/pkg/controller/upgradeconfig/upgradeconfig_controller.go
  • Line 109: warning: cyclomatic complexity 31 of function (*ReconcileUpgradeConfig).Reconcile() is high (> 15) (gocyclo)

• managed-upgrade-operator/pkg/controller/nodekeeper/nodekeeper_controller.go
  • Line 95: warning: cyclomatic complexity 19 of function (*ReconcileNodeKeeper).Reconcile() is high (> 15) (gocyclo)

golint96%

Golint is a linter for Go source code.

• managed-upgrade-operator/pkg/controller/machineconfigpool/machineconfigpool_controller.go
  • Line 69: warning: exported method ReconcileMachineConfigPool.Reconcile should have comment or be unexported (golint)

• managed-upgrade-operator/pkg/clusterversion/cv.go
  • Line 199: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 207: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• managed-upgrade-operator/pkg/notifier/ocmnotifier.go
  • Line 27: warning: exported type OcmState should have comment or be unexported (golint)
  • Line 30: warning: exported const OcmStatePending should have comment (or a comment on this block) or be unexported (golint)

• managed-upgrade-operator/pkg/metrics/metrics.go
  • Line 26: warning: exported const Namespace should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: comment on exported type Metrics should be of the form "Metrics ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported type MetricsBuilder should be of the form "MetricsBuilder ..." (with optional leading article) (golint)
  • Line 74: warning: exported function NewBuilder should have comment or be unexported (golint)
  • Line 113: warning: exported type Counter should have comment or be unexported (golint)
  • Line 184: warning: exported method Counter.UpdateMetricValidationFailed should have comment or be unexported (golint)
  • Line 190: warning: exported method Counter.UpdateMetricValidationSucceeded should have comment or be unexported (golint)
  • Line 196: warning: exported method Counter.UpdateMetricClusterCheckFailed should have comment or be unexported (golint)
  • Line 202: warning: exported method Counter.UpdateMetricClusterCheckSucceeded should have comment or be unexported (golint)
  • Line 208: warning: exported method Counter.UpdateMetricScalingFailed should have comment or be unexported (golint)
  • Line 214: warning: exported method Counter.UpdateMetricScalingSucceeded should have comment or be unexported (golint)
  • Line 220: warning: exported method Counter.UpdateMetricUpgradeConfigSynced should have comment or be unexported (golint)
  • Line 224: warning: exported method Counter.ResetMetricUpgradeConfigSynced should have comment or be unexported (golint)
  • Line 228: warning: exported method Counter.UpdateMetricUpgradeControlPlaneTimeout should have comment or be unexported (golint)
  • Line 235: warning: exported method Counter.ResetMetricUpgradeControlPlaneTimeout should have comment or be unexported (golint)
  • Line 242: warning: exported method Counter.UpdateMetricUpgradeWorkerTimeout should have comment or be unexported (golint)
  • Line 249: warning: exported method Counter.ResetMetricUpgradeWorkerTimeout should have comment or be unexported (golint)
  • Line 256: warning: exported method Counter.UpdateMetricNodeDrainFailed should have comment or be unexported (golint)
  • Line 262: warning: exported method Counter.ResetMetricNodeDrainFailed should have comment or be unexported (golint)
  • Line 268: warning: exported method Counter.ResetAllMetricNodeDrainFailed should have comment or be unexported (golint)
  • Line 272: warning: exported method Counter.UpdateMetricUpgradeWindowNotBreached should have comment or be unexported (golint)
  • Line 278: warning: exported method Counter.UpdateMetricUpgradeWindowBreached should have comment or be unexported (golint)
  • Line 284: warning: exported method Counter.UpdateMetricNotificationEventSent should have comment or be unexported (golint)
  • Line 314: warning: exported method Counter.IsMetricNotificationEventSentSet should have comment or be unexported (golint)
  • Line 327: warning: exported method Counter.IsClusterVersionAtVersion should have comment or be unexported (golint)
  • Line 340: warning: exported method Counter.IsAlertFiring should have comment or be unexported (golint)
  • Line 364: warning: exported method Counter.Query should have comment or be unexported (golint)
  • Line 422: warning: exported type AlertResponse should have comment or be unexported (golint)
  • Line 427: warning: exported type AlertData should have comment or be unexported (golint)
  • Line 431: warning: exported type AlertResult should have comment or be unexported (golint)

• managed-upgrade-operator/pkg/ocm/builder.go
  • Line 12: warning: comment on exported type OcmClientBuilder should be of the form "OcmClientBuilder ..." (with optional leading article) (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• managed-upgrade-operator/pkg/upgraders/maintenancestep.go
  • Line 41: warning: "maintenace" is a misspelling of "maintenance" (misspell)
  • Line 67: warning: "maintenace" is a misspelling of "maintenance" (misspell)

• managed-upgrade-operator/pkg/drain/stuckTerminatingStrategy_test.go
  • Line 154: warning: "wtih" is a misspelling of "with" (misspell)