gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• openshift-azure/hack/verify/validate_pluginconfig_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• openshift-azure/pkg/sync/v21/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v21/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/cluster/update_master.go
  • Line 88: warning: cyclomatic complexity 19 of function (*Upgrade).UpdateMasterAgentPoolTogether() is high (> 15) (gocyclo)

• openshift-azure/pkg/util/arm/arm.go
  • Line 39: warning: cyclomatic complexity 17 of function FixupDepends() is high (> 15) (gocyclo)

• openshift-azure/pkg/plugin/integration_test.go
  • Line 730: warning: cyclomatic complexity 24 of function TestHowActionsCauseRotations() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v15/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/validate/plugin.go
  • Line 145: warning: cyclomatic complexity 41 of function validateImageConfig() is high (> 15) (gocyclo)
  • Line 20: warning: cyclomatic complexity 18 of function (*PluginAPIValidator).Validate() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v16/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/test/e2e/standard/testapps.go
  • Line 45: warning: cyclomatic complexity 16 of function (*SanityChecker).validateStatefulApp() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v19/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v17/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v19/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/controllers/customeradmin/rolebinding_controller.go
  • Line 55: warning: cyclomatic complexity 17 of function (*reconcileRolebinding).Reconcile() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v22/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v19/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v15/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v19/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v17/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/admin/convertertointernal.go
  • Line 534: warning: cyclomatic complexity 38 of function mergeImageConfig() is high (> 15) (gocyclo)
  • Line 432: warning: cyclomatic complexity 29 of function mergeCertificateConfig() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 23 of function mergeConfig() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v15/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v22/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/2019-10-27-preview/convertertointernal.go
  • Line 76: warning: cyclomatic complexity 19 of function mergeProperties() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v21/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v20/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/fakerp/fakerp.go
  • Line 177: warning: cyclomatic complexity 25 of function createOrUpdateWrapper() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/admin/types_test.go
  • Line 330: warning: cyclomatic complexity 24 of function TestAPIParity() is high (> 15) (gocyclo)

• openshift-azure/pkg/fakerp/customer_handlers.go
  • Line 62: warning: cyclomatic complexity 18 of function (*Server).handlePut() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/validate/validators_test.go
  • Line 77: warning: cyclomatic complexity 25 of function TestValidate() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v16/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v20/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v16/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/test/util/populate/walk.go
  • Line 43: warning: cyclomatic complexity 31 of function (walker).walk() is high (> 15) (gocyclo)

• openshift-azure/test/util/structs/walk.go
  • Line 16: warning: cyclomatic complexity 17 of function Walk() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/deepcopy.go
  • Line 7: warning: cyclomatic complexity 17 of function deepCopy() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v22/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v16/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v22/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/util/jsonpath/lexer.go
  • Line 15: warning: cyclomatic complexity 17 of function (*lexer).Lex() is high (> 15) (gocyclo)

• openshift-azure/pkg/plugin/plugin.go
  • Line 280: warning: cyclomatic complexity 38 of function (*plugin).createOrUpdateExt() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/plugin/convertertointernal.go
  • Line 14: warning: cyclomatic complexity 28 of function ToInternal() is high (> 15) (gocyclo)

• openshift-azure/pkg/cluster/kubeclient/drain.go
  • Line 73: warning: cyclomatic complexity 19 of function (*Kubeclientset).deletePods() is high (> 15) (gocyclo)

• openshift-azure/pkg/entrypoint/metricsbridge/metricsbridge.go
  • Line 211: warning: cyclomatic complexity 17 of function (*MetricsConfig).runOnce() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v17/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/util/azureclient/network/privatelink/model.go
  • Line 273: warning: cyclomatic complexity 27 of function (*PrivateEndpoint).UnmarshalJSON() is high (> 15) (gocyclo)
  • Line 69: warning: cyclomatic complexity 27 of function (*PrivateLinkService).UnmarshalJSON() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/json/marshal.go
  • Line 117: warning: cyclomatic complexity 20 of function UnmarshalJSON() is high (> 15) (gocyclo)
  • Line 33: warning: cyclomatic complexity 19 of function MarshalJSON() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v22/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v20/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v21/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v16/client.go
  • Line 274: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 20 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v15/sync.go
  • Line 315: warning: cyclomatic complexity 25 of function (*sync).writeDB() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function (*sync).calculateReadiness() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v15/client.go
  • Line 271: warning: cyclomatic complexity 20 of function (*sync).isReconcileProtected() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 18 of function (*sync).write() is high (> 15) (gocyclo)
  • Line 54: warning: cyclomatic complexity 17 of function (*sync).deleteOrphans() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v21/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v20/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v20/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/util/roundtrippers/retrying.go
  • Line 90: warning: cyclomatic complexity 18 of function (*RetryingRoundTripper).RoundTrip() is high (> 15) (gocyclo)

• openshift-azure/pkg/config/v17/generate.go
  • Line 21: warning: cyclomatic complexity 44 of function (*simpleGenerator).Generate() is high (> 15) (gocyclo)

• openshift-azure/pkg/controllers/customeradmin/group_mapping.go
  • Line 94: warning: cyclomatic complexity 18 of function reconcileUsers() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v17/wants.go
  • Line 36: warning: cyclomatic complexity 46 of function wants() is high (> 15) (gocyclo)

• openshift-azure/pkg/sync/v19/clean.go
  • Line 76: warning: cyclomatic complexity 22 of function clean() is high (> 15) (gocyclo)

• openshift-azure/pkg/api/validate/validators.go
  • Line 290: warning: cyclomatic complexity 28 of function validateAgentPoolProfile() is high (> 15) (gocyclo)

golint75%

Golint is a linter for Go source code.

• openshift-azure/pkg/sync/sync.go
  • Line 20: warning: exported type Interface should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)
  • Line 52: warning: exported function AssetNames should have comment or be unexported (golint)
  • Line 73: warning: exported function Asset should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v17/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/api/deepcopy.go
  • Line 75: warning: exported method OpenShiftManagedCluster.DeepCopy should have comment or be unexported (golint)
  • Line 80: warning: exported method Config.DeepCopy should have comment or be unexported (golint)

• openshift-azure/pkg/config/v19/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/entrypoint/metricsbridge/telemetry.go
  • Line 55: warning: exported function MetricsHandler should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/keyvault/keyvault.go
  • Line 13: warning: exported type VaultRP should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/keyvault/keyvault.go
  • Line 17: warning: exported type KeyVaultClient should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v22/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/storage/storage_addons.go
  • Line 9: warning: exported type AccountsClientAddons should have comment or be unexported (golint)

• openshift-azure/test/clients/openshift/client.go
  • Line 29: warning: exported type Client should have comment or be unexported (golint)
  • Line 84: warning: exported function NewAdminClient should have comment or be unexported (golint)
  • Line 93: warning: exported function NewCustomerAdminClient should have comment or be unexported (golint)
  • Line 102: warning: exported function NewEndUserClient should have comment or be unexported (golint)
  • Line 111: warning: exported type ClientSet should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v19/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/config/v15/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/authorization/roleassignments.go
  • Line 17: warning: exported type RoleAssignmentsClient should have comment or be unexported (golint)

• openshift-azure/test/util/diagnostics/ssh.go
  • Line 27: warning: exported function NewSSHer should have comment or be unexported (golint)

• openshift-azure/pkg/util/roundtrippers/retrying.go
  • Line 64: warning: error var timerExpired should have name of the form errFoo (golint)
  • Line 66: warning: exported type RetryingRoundTripper should have comment or be unexported (golint)
  • Line 73: warning: comment on exported function NewRetryingRoundTripper should be of the form "NewRetryingRoundTripper ..." (golint)
  • Line 90: warning: exported method RetryingRoundTripper.RoundTrip should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/loglevel.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)

• openshift-azure/pkg/entrypoint/config/config.go
  • Line 7: warning: exported type Common should have comment or be unexported (golint)
  • Line 11: warning: exported function CommonConfigFromCmd should have comment or be unexported (golint)

• openshift-azure/pkg/util/cloudprovider/cloudprovider.go
  • Line 10: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• openshift-azure/pkg/util/workspace/workspace.go
  • Line 21: warning: exported function GetWorkspaceInfo should have comment or be unexported (golint)

• openshift-azure/test/util/structs/walk.go
  • Line 11: warning: comment on exported function Walk should be of the form "Walk ..." (golint)

• openshift-azure/test/e2e/standard/sanitychecker.go
  • Line 22: warning: exported type TestError should have comment or be unexported (golint)
  • Line 33: warning: exported type DeepTestInterface should have comment or be unexported (golint)
  • Line 40: warning: exported type SanityChecker should have comment or be unexported (golint)
  • Line 73: warning: exported method SanityChecker.CreateTestApp should have comment or be unexported (golint)
  • Line 128: warning: exported method SanityChecker.ValidateTestApp should have comment or be unexported (golint)
  • Line 151: warning: exported method SanityChecker.ValidateCluster should have comment or be unexported (golint)
  • Line 216: warning: exported method SanityChecker.DeleteTestApp should have comment or be unexported (golint)
  • Line 227: warning: exported method SanityChecker.CreateProject should have comment or be unexported (golint)
  • Line 240: warning: exported method SanityChecker.DeleteProject should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/admin.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/test/e2e/specs/fakerp/forceupdate.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)

• openshift-azure/pkg/cluster/hash.go
  • Line 23: warning: exported type Hasher should have comment or be unexported (golint)
  • Line 28: warning: exported type Hash should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/graphrbac/groups_addons.go
  • Line 9: warning: exported type GroupsClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/util/derived/derived.go
  • Line 63: warning: exported function AadGroupSyncConf should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/graphrbac/groups.go
  • Line 24: warning: comment on exported function NewGroupsClient should be of the form "NewGroupsClient ..." (golint)

• openshift-azure/test/e2e/specs/metrics_server.go
  • Line 4: warning: should not use dot imports (golint)
  • Line 5: warning: should not use dot imports (golint)

• openshift-azure/pkg/arm/arm.go
  • Line 26: warning: exported type Interface should have comment or be unexported (golint)
  • Line 32: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v19/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/api/validate/types.go
  • Line 172: warning: exported function IsValidBlobName should have comment or be unexported (golint)
  • Line 209: warning: exported function IsValidAgentPoolHostname should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/client/config.go
  • Line 15: warning: exported type Config should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/scaleupdown.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/test/util/structs/structtags.go
  • Line 11: warning: comment on exported function CheckJsonTags should be of the form "CheckJsonTags ..." (golint)

• openshift-azure/cmd/releasenotes/releasenotes.go
  • Line 92: warning: exported function NewScraper should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v17/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/etcdrestore.go
  • Line 13: warning: exported method Upgrade.EtcdListBackups should have comment or be unexported (golint)
  • Line 27: warning: exported method Upgrade.EtcdRestoreDeleteMasterScaleSet should have comment or be unexported (golint)
  • Line 36: warning: exported method Upgrade.EtcdRestoreDeleteMasterScaleSetHashes should have comment or be unexported (golint)

• openshift-azure/pkg/api/plugin/config.go
  • Line 47: warning: exported type VersionConfig should have comment or be unexported (golint)

• openshift-azure/test/util/tls/tls.go
  • Line 9: warning: exported var DummyPrivateKey should have comment or be unexported (golint)

• openshift-azure/pkg/util/tls/marshal.go
  • Line 15: warning: exported function CertAsBytes should have comment or be unexported (golint)
  • Line 33: warning: exported function CertChainAsBytes should have comment or be unexported (golint)
  • Line 37: warning: exported function PrivateKeyAsBytes should have comment or be unexported (golint)
  • Line 54: warning: exported function PublicKeyAsBytes should have comment or be unexported (golint)
  • Line 76: warning: exported function SSHPublicKeyAsString should have comment or be unexported (golint)
  • Line 125: warning: exported function ParsePrivateKey should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/storage/container.go
  • Line 9: warning: exported type FakeContainerClient should have comment or be unexported (golint)
  • Line 14: warning: exported method FakeContainerClient.CreateIfNotExists should have comment or be unexported (golint)
  • Line 22: warning: exported method FakeContainerClient.GetBlobReference should have comment or be unexported (golint)
  • Line 26: warning: exported method FakeContainerClient.Exists should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeContainerClient.ListBlobs should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v16/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/vault/vault.go
  • Line 35: warning: exported function GetSecret should have comment or be unexported (golint)
  • Line 59: warning: exported function ImportCertificate should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/builds.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)
  • Line 13: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• openshift-azure/test/e2e/specs/fakerp/reimagevm.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/pkg/cluster/kubeclient/ready.go
  • Line 16: warning: exported method Kubeclientset.WaitForReadyMaster should have comment or be unexported (golint)
  • Line 39: warning: exported method Kubeclientset.WaitForReadyWorker should have comment or be unexported (golint)
  • Line 43: warning: exported method Kubeclientset.WaitForReadySyncPod should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/cloud.go
  • Line 22: warning: exported type AzureCloud should have comment or be unexported (golint)
  • Line 37: warning: exported function NewFakeAzureCloud should have comment or be unexported (golint)

• openshift-azure/pkg/util/jsonpath/jsonpath.go
  • Line 12: warning: exported type Path should have comment or be unexported (golint)
  • Line 23: warning: exported function Compile should have comment or be unexported (golint)
  • Line 34: warning: exported function MustCompile should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/compute/virtualmachinescalesets_addons.go
  • Line 11: warning: exported type VirtualMachineScaleSetsClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/config.go
  • Line 24: warning: exported function GetTestConfig should have comment or be unexported (golint)
  • Line 34: warning: exported function GetPluginTemplate should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/strimzi.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• openshift-azure/hack/verify/validate_pluginconfig.go
  • Line 12: warning: exported type VersionConfig should have comment or be unexported (golint)

• openshift-azure/hack/proxy-infrastructure/setup.go
  • Line 78: warning: exported type Config should have comment or be unexported (golint)
  • Line 89: warning: exported function Run should have comment or be unexported (golint)

• openshift-azure/pkg/api/2019-04-30/marshal.go
  • Line 8: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v20/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/test/clients/azure/client.go
  • Line 23: warning: exported var RPClient should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v17/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/authorization/roledefinitions.go
  • Line 13: warning: exported type RoleDefinitionsClient should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/graphrbac/serviceprincipals.go
  • Line 13: warning: exported type ServicePrincipalsClient should have comment or be unexported (golint)

• openshift-azure/test/util/populate/dummycerts.go
  • Line 11: warning: exported function DummyCertsAndKeys should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/shared/shared.go
  • Line 8: warning: exported const LocalHttpAddr should have comment (or a comment on this block) or be unexported (golint)

• openshift-azure/pkg/entrypoint/admissioncontroller/admissioncontroller.go
  • Line 17: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• openshift-azure/pkg/util/azureclient/resources/groups_addons.go
  • Line 7: warning: exported type GroupsClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/util/kubeconfig/kubeconfig.go
  • Line 13: warning: exported function Make should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/compute/virtualmachinescalesetvms.go
  • Line 12: warning: exported type ComputeRP should have comment or be unexported (golint)
  • Line 19: warning: exported type FakeVirtualMachineScaleSetVMsClient should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/storage/blob.go
  • Line 12: warning: exported type FakeBlobClient should have comment or be unexported (golint)
  • Line 23: warning: exported method FakeBlobClient.CreateBlockBlobFromReader should have comment or be unexported (golint)
  • Line 33: warning: exported method FakeBlobClient.CreateBlockBlob should have comment or be unexported (golint)
  • Line 39: warning: exported method FakeBlobClient.PutBlock should have comment or be unexported (golint)
  • Line 45: warning: exported method FakeBlobClient.PutBlockList should have comment or be unexported (golint)
  • Line 51: warning: exported method FakeBlobClient.Get should have comment or be unexported (golint)
  • Line 60: warning: exported method FakeBlobClient.GetSASURI should have comment or be unexported (golint)
  • Line 65: warning: exported method FakeBlobClient.Delete should have comment or be unexported (golint)
  • Line 74: warning: exported method FakeBlobClient.Exists should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/storage/blobstorage.go
  • Line 7: warning: exported type FakeBlobStorageClient should have comment or be unexported (golint)
  • Line 11: warning: exported method FakeBlobStorageClient.GetContainerReference should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v15/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/openshiftmanagedcluster/admin/client.go
  • Line 16: warning: exported type Client should have comment or be unexported (golint)
  • Line 21: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 80: warning: exported method Client.Backup should have comment or be unexported (golint)
  • Line 85: warning: exported method Client.CreateOrUpdate should have comment or be unexported (golint)
  • Line 90: warning: exported method Client.ForceUpdate should have comment or be unexported (golint)
  • Line 95: warning: exported method Client.Get should have comment or be unexported (golint)
  • Line 100: warning: exported method Client.GetControlPlanePods should have comment or be unexported (golint)
  • Line 105: warning: exported method Client.GetPluginVersion should have comment or be unexported (golint)
  • Line 110: warning: exported method Client.ListClusterVMs should have comment or be unexported (golint)
  • Line 115: warning: exported method Client.Reimage should have comment or be unexported (golint)
  • Line 120: warning: exported method Client.ListBackups should have comment or be unexported (golint)
  • Line 125: warning: exported method Client.Restore should have comment or be unexported (golint)
  • Line 130: warning: exported method Client.RotateSecrets should have comment or be unexported (golint)
  • Line 135: warning: exported method Client.RotateCertificates should have comment or be unexported (golint)
  • Line 140: warning: exported method Client.RotateCertificatesAndSecrets should have comment or be unexported (golint)
  • Line 145: warning: exported method Client.RunCommand should have comment or be unexported (golint)

• openshift-azure/pkg/api/marshal.go
  • Line 11: warning: exported method Config.MarshalJSON should have comment or be unexported (golint)
  • Line 15: warning: exported method Config.UnmarshalJSON should have comment or be unexported (golint)
  • Line 19: warning: exported method CertKeyPair.MarshalJSON should have comment or be unexported (golint)
  • Line 23: warning: exported method CertKeyPair.UnmarshalJSON should have comment or be unexported (golint)
  • Line 27: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/api/admin/marshal.go
  • Line 11: warning: exported method Config.MarshalJSON should have comment or be unexported (golint)
  • Line 15: warning: exported method Config.UnmarshalJSON should have comment or be unexported (golint)
  • Line 19: warning: exported method Certificate.MarshalJSON should have comment or be unexported (golint)
  • Line 23: warning: exported method Certificate.UnmarshalJSON should have comment or be unexported (golint)
  • Line 27: warning: exported method CertificateChain.MarshalJSON should have comment or be unexported (golint)
  • Line 31: warning: exported method CertificateChain.UnmarshalJSON should have comment or be unexported (golint)
  • Line 35: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v20/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/resources/deployments.go
  • Line 30: warning: exported method FakeDeploymentsClient.CreateOrUpdate should have comment or be unexported (golint)
  • Line 41: warning: exported method FakeDeploymentsClient.Client should have comment or be unexported (golint)
  • Line 45: warning: comment on exported method FakeDeploymentsClient.CreateOrUpdateAndWait should be of the form "CreateOrUpdateAndWait ..." (golint)

• openshift-azure/test/e2e/specs/osba_app.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• openshift-azure/test/e2e/specs/fakerp/setcontainerimage.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 9: warning: should not use dot imports (golint)

• openshift-azure/pkg/api/2019-09-30-preview/marshal.go
  • Line 8: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/updateblob/types.go
  • Line 3: warning: exported type HostnameHashes should have comment or be unexported (golint)
  • Line 10: warning: exported type ScalesetHashes should have comment or be unexported (golint)
  • Line 17: warning: exported type UpdateBlob should have comment or be unexported (golint)
  • Line 24: warning: exported function NewUpdateBlob should have comment or be unexported (golint)

• openshift-azure/pkg/config/v22/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/types.go
  • Line 68: warning: exported type Upgrade should have comment or be unexported (golint)
  • Line 147: warning: exported method Upgrade.EnrichCertificatesFromVault should have comment or be unexported (golint)
  • Line 151: warning: exported method Upgrade.EnrichStorageAccountKeys should have comment or be unexported (golint)
  • Line 155: warning: exported method Upgrade.GenerateARM should have comment or be unexported (golint)

• openshift-azure/pkg/util/pluginversion/pluginversion.go
  • Line 7: warning: exported function Parse should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/storage/storage.go
  • Line 17: warning: exported method FakeStorageClient.GetBlobService should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/resources/deployments_addons.go
  • Line 9: warning: exported type DeploymentsClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/vaultmgmt/vaultmgmt.go
  • Line 17: warning: exported type VaultMgmtClient should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v21/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v16/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/api/validate/serviceprincipal.go
  • Line 24: warning: exported type RoleLister should have comment or be unexported (golint)
  • Line 28: warning: exported type SimpleRoleLister should have comment or be unexported (golint)
  • Line 30: warning: exported method SimpleRoleLister.ListAADApplicationRoles should have comment or be unexported (golint)
  • Line 61: warning: exported type DummyRoleLister should have comment or be unexported (golint)
  • Line 65: warning: exported method DummyRoleLister.ListAADApplicationRoles should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/update_worker.go
  • Line 55: warning: comment on exported method Upgrade.UpdateWorkerAgentPool should be of the form "UpdateWorkerAgentPool ..." (golint)

• openshift-azure/pkg/cluster/updateblob/marshal.go
  • Line 11: warning: exported method HostnameHashes.MarshalJSON should have comment or be unexported (golint)
  • Line 29: warning: exported method HostnameHashes.UnmarshalJSON should have comment or be unexported (golint)
  • Line 46: warning: exported method ScalesetHashes.MarshalJSON should have comment or be unexported (golint)
  • Line 64: warning: exported method ScalesetHashes.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/test/clients/openshift/project.go
  • Line 14: warning: exported method Client.CreateProject should have comment or be unexported (golint)
  • Line 74: warning: exported method Client.CleanupProject should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/beforesuite.go
  • Line 7: warning: should not use dot imports (golint)

• openshift-azure/pkg/util/arm/arm.go
  • Line 13: warning: exported type Template should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/azureclient.go
  • Line 25: warning: exported const KeyVaultEndpoint should have comment or be unexported (golint)
  • Line 62: warning: exported function SetupClient should have comment or be unexported (golint)
  • Line 76: warning: exported function NewAuthorizer should have comment or be unexported (golint)
  • Line 88: warning: exported function GetAuthorizerFromContext should have comment or be unexported (golint)
  • Line 96: warning: exported function NewAuthorizerFromEnvironment should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/server.go
  • Line 26: warning: exported type Server should have comment or be unexported (golint)
  • Line 42: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 76: warning: exported method Server.Run should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/end_user.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 7: warning: should not use dot imports (golint)

• openshift-azure/pkg/api/plugin/marshal.go
  • Line 9: warning: exported method Config.MarshalJSON should have comment or be unexported (golint)
  • Line 13: warning: exported method Config.UnmarshalJSON should have comment or be unexported (golint)
  • Line 17: warning: exported method CertKeyPair.MarshalJSON should have comment or be unexported (golint)
  • Line 21: warning: exported method CertKeyPair.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v21/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v22/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/config/v21/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/storage/accounts.go
  • Line 12: warning: exported type StorageRP should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/resources/deploymentoperations_addons.go
  • Line 9: warning: exported type DeploymentOperationsClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/sync/v19/sync.go
  • Line 554: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/template/template.go
  • Line 16: warning: exported function Template should have comment or be unexported (golint)

• openshift-azure/cmd/createorupdate/createorupdate.go
  • Line 43: warning: exported type Client should have comment or be unexported (golint)
  • Line 256: warning: exported method Client.Delete should have comment or be unexported (golint)
  • Line 276: warning: exported method Client.Create should have comment or be unexported (golint)

• openshift-azure/pkg/api/2019-10-27-preview/marshal.go
  • Line 8: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/config/v16/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/ready.go
  • Line 12: warning: exported method Upgrade.WaitForNodesInAgentPoolProfile should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/dns/zones_addons.go
  • Line 9: warning: exported type ZonesClientAddons should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/aad.go
  • Line 27: warning: comment on exported const OSAMasterRoleDefinitionID should be of the form "OSAMasterRoleDefinitionID ..." (golint)
  • Line 29: warning: exported const OSAWorkerRoleDefinitionID should have comment (or a comment on this block) or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/keyrotation.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)

• openshift-azure/pkg/arm/v16/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v20/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/admin_actions.go
  • Line 11: warning: exported method Upgrade.Restart should have comment or be unexported (golint)
  • Line 15: warning: exported method Upgrade.Reimage should have comment or be unexported (golint)
  • Line 19: warning: exported method Upgrade.ListVMHostnames should have comment or be unexported (golint)
  • Line 40: warning: exported method Upgrade.RunCommand should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/kubeclient/types.go
  • Line 30: warning: exported type Kubeclientset should have comment or be unexported (golint)

• openshift-azure/test/reporters/capture.go
  • Line 13: warning: exported type Capture should have comment or be unexported (golint)
  • Line 20: warning: exported method Capture.Close should have comment or be unexported (golint)
  • Line 43: warning: exported function NewCapture should have comment or be unexported (golint)
  • Line 86: warning: exported function StartCapture should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/securityupdates.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/pkg/cluster/updateblob/blobservice.go
  • Line 26: warning: exported type BlobService should have comment or be unexported (golint)
  • Line 31: warning: exported function NewBlobService should have comment or be unexported (golint)

• openshift-azure/pkg/arm/v22/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/kubeclient/backup.go
  • Line 16: warning: exported method Kubeclientset.BackupCluster should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/old_tls.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 7: warning: should not use dot imports (golint)

• openshift-azure/test/e2e/specs/fakerp/command.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• openshift-azure/test/e2e/specs/fakerp/prometheus.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/pkg/cluster/kubeclient/status.go
  • Line 11: warning: exported method Kubeclientset.GetControlPlanePods should have comment or be unexported (golint)
  • Line 29: warning: exported function IsControlPlaneNamespace should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/healthcheck.go
  • Line 40: warning: exported method Upgrade.WaitForHealthzStatusOk should have comment or be unexported (golint)

• openshift-azure/test/clients/openshift/serviceaccount.go
  • Line 10: warning: exported method Client.GetServiceAccountToken should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/network/virtualnetworks.go
  • Line 11: warning: exported type NetworkRP should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeVirtualNetworksClient.Get should have comment or be unexported (golint)
  • Line 35: warning: exported method FakeVirtualNetworksClient.List should have comment or be unexported (golint)
  • Line 39: warning: exported method FakeVirtualNetworksClient.CreateOrUpdate should have comment or be unexported (golint)
  • Line 43: warning: exported method FakeVirtualNetworksClient.Delete should have comment or be unexported (golint)
  • Line 54: warning: exported method FakeVirtualNetworksClient.Client should have comment or be unexported (golint)
  • Line 54: warning: receiver name d should be consistent with previous receiver name vn for FakeVirtualNetworksClient (golint)

• openshift-azure/test/e2e/specs/fakerp/etcdbackuprecovery.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/pkg/arm/constants/const.go
  • Line 4: warning: comment on exported const VnetName should be of the form "VnetName ..." (golint)
  • Line 6: warning: exported const VnetSubnetName should have comment (or a comment on this block) or be unexported (golint)

• openshift-azure/pkg/api/admin/config.go
  • Line 165: warning: exported type CertificateChain should have comment or be unexported (golint)

• openshift-azure/pkg/config/v17/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/config/config.go
  • Line 23: warning: exported type Interface should have comment or be unexported (golint)
  • Line 29: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/kubeclient/syncpod.go
  • Line 16: warning: exported method Kubeclientset.EnsureSyncPod should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/clusterstatus.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 10: warning: should not use dot imports (golint)

• openshift-azure/pkg/controllers/customeradmin/metrics.go
  • Line 68: warning: exported function MetricsHandler should have comment or be unexported (golint)

• openshift-azure/pkg/util/writers/writers.go
  • Line 19: warning: exported type Writer should have comment or be unexported (golint)
  • Line 27: warning: exported function NewFilesystemWriter should have comment or be unexported (golint)
  • Line 61: warning: exported function NewTarWriter should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/metricsbridge.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

• openshift-azure/pkg/util/azureclient/compute/virtualmachinescalesetvms_addons.go
  • Line 11: warning: exported type VirtualMachineScaleSetVMsClientAddons should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/customer_admin.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 9: warning: should not use dot imports (golint)

• openshift-azure/pkg/arm/v15/arm.go
  • Line 30: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/cluster/kubeclient/drain.go
  • Line 17: warning: exported method Kubeclientset.DrainAndDeleteWorker should have comment or be unexported (golint)
  • Line 36: warning: exported method Kubeclientset.DeleteMaster should have comment or be unexported (golint)

• openshift-azure/pkg/fakerp/store/store.go
  • Line 14: warning: exported type Store should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/roundtrippers/authorizing.go
  • Line 13: warning: exported method AuthorizingRoundTripper.RoundTrip should have comment or be unexported (golint)

• openshift-azure/test/e2e/standard/cluster.go
  • Line 13: warning: should not use dot imports (golint)
  • Line 274: warning: exported method SanityChecker.CheckCanAccessConsole should have comment or be unexported (golint)

• openshift-azure/pkg/api/plugin.go
  • Line 11: warning: exported const ContextKeyClientAuthorizer should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported type PluginStep should have comment or be unexported (golint)
  • Line 19: warning: exported const PluginStepDeploy should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported type Command should have comment or be unexported (golint)
  • Line 67: warning: exported const CommandRestartNetworkManager should have comment (or a comment on this block) or be unexported (golint)

• openshift-azure/pkg/arm/v15/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/util/wait/wait.go
  • Line 41: warning: exported function NewFakeHTTPClient should have comment or be unexported (golint)

• openshift-azure/pkg/api/2018-09-30-preview/marshal.go
  • Line 8: warning: exported method IdentityProvider.UnmarshalJSON should have comment or be unexported (golint)

• openshift-azure/pkg/util/azureclient/fake/compute/virtualmachinescalesets.go
  • Line 13: warning: exported type FakeVirtualMachineScaleSetsClient should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/sync.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 9: warning: should not use dot imports (golint)

• openshift-azure/test/util/log/log.go
  • Line 4: warning: should not use dot imports (golint)
  • Line 9: warning: exported function GetTestLogger should have comment or be unexported (golint)

• openshift-azure/test/e2e/specs/fakerp/carotation.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)

• openshift-azure/pkg/arm/v21/derive.go
  • Line 18: warning: exported type DockerConfigJson should have comment or be unexported (golint)
  • Line 22: warning: exported type DockerConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type DockerConfigEntry should have comment or be unexported (golint)

• openshift-azure/pkg/config/v20/types.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)

• openshift-azure/pkg/util/enrich/enrich.go
  • Line 20: warning: exported function StorageAccountKeys should have comment or be unexported (golint)
  • Line 40: warning: exported function SASURIs should have comment or be unexported (golint)
  • Line 75: warning: exported function CertificatesFromVault should have comment or be unexported (golint)
  • Line 91: warning: exported function MonitorIDAndKey should have comment or be unexported (golint)
  • Line 105: warning: exported function PrivateAPIServerIPAddress should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• openshift-azure/pkg/sync/v21/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/util/writers/writers_test.go
  • Line 86: warning: ineffectual assignment to c (ineffassign)

• openshift-azure/test/e2e/specs/scaleupdown.go
  • Line 68: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/test/e2e/specs/fakerp/securityupdates.go
  • Line 60: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/plugin/plugin_test.go
  • Line 89: warning: ineffectual assignment to c (ineffassign)
  • Line 90: warning: ineffectual assignment to c (ineffassign)
  • Line 102: warning: ineffectual assignment to c (ineffassign)
  • Line 334: warning: ineffectual assignment to c (ineffassign)
  • Line 336: warning: ineffectual assignment to c (ineffassign)
  • Line 402: warning: ineffectual assignment to c (ineffassign)
  • Line 404: warning: ineffectual assignment to c (ineffassign)

• openshift-azure/pkg/sync/v22/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/plugin/integration_test.go
  • Line 863: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/sync/v20/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/test/e2e/specs/fakerp/admin.go
  • Line 52: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/cluster/update_worker_test.go
  • Line 113: warning: ineffectual assignment to c (ineffassign)
  • Line 119: warning: ineffectual assignment to c (ineffassign)
  • Line 122: warning: ineffectual assignment to c (ineffassign)

• openshift-azure/pkg/sync/v15/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/sync/v16/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/sync/v17/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/sync/v19/sync.go
  • Line 382: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/hack/setup-rbac/main.go
  • Line 26: warning: ineffectual assignment to err (ineffassign)

• openshift-azure/pkg/fakerp/dns.go
  • Line 53: warning: ineffectual assignment to err (ineffassign)

misspell98%

Misspell Finds commonly misspelled English words

• openshift-azure/pkg/startup/v17/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/pkg/startup/v15/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/pkg/startup/v19/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/pkg/startup/v20/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/test/e2e/specs/fakerp/admin.go
  • Line 58: warning: "occured" is a misspelling of "occurred" (misspell)

• openshift-azure/pkg/api/2019-10-27-preview/convertertointernal.go
  • Line 111: warning: "fiels" is a misspelling of "fields" (misspell)

• openshift-azure/pkg/api/plugin/convertertointernal_test.go
  • Line 44: warning: "intergration" is a misspelling of "integration" (misspell)

• openshift-azure/pkg/startup/v22/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/pkg/startup/v16/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)

• openshift-azure/pkg/fakerp/arm/constants/const.go
  • Line 11: warning: "infrastrucutre" is a misspelling of "infrastructure" (misspell)

• openshift-azure/pkg/startup/v21/derive_test.go
  • Line 129: warning: "lenght" is a misspelling of "length" (misspell)