gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• operator-lifecycle-manager/pkg/controller/operators/olm/operator_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/operators/olm/operatorgroup_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/operators/olm/requirements_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/grpc/source_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/crd/version.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/operators/adoption_controller.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/rbac.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/rbac_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/test/e2e/operator_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/types.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/operatorstatus/monitor_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/operators_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/operators/catalog/installplan_sync.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/resolver_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/proxy/overridden_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/certs/certs.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/grpc/source.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/operators/olm/overrides/inject/inject_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/crd/storage_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/labeler_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/controller/registry/resolver/querier_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/test/e2e/webhook_e2e_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/proxy/envvar.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/proxy/envvar_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• operator-lifecycle-manager/pkg/lib/operatorstatus/builder_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• operator-lifecycle-manager/test/e2e/metrics_e2e_test.go
  • Line 395: warning: cyclomatic complexity 18 of function getMetricsFromPod() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/catalog/operator.go
  • Line 1681: warning: cyclomatic complexity 72 of function (*Operator).ExecutePlan() is high (> 15) (gocyclo)
  • Line 116: warning: cyclomatic complexity 25 of function NewOperator() is high (> 15) (gocyclo)
  • Line 1355: warning: cyclomatic complexity 24 of function (*Operator).syncInstallPlans() is high (> 15) (gocyclo)
  • Line 816: warning: cyclomatic complexity 23 of function (*Operator).syncResolvingNamespace() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/catalog/operator_test.go
  • Line 319: warning: cyclomatic complexity 18 of function TestExecutePlan() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/registry/resolver/util_test.go
  • Line 394: warning: cyclomatic complexity 28 of function NewFakeSourceQuerier() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/olm/operator.go
  • Line 1298: warning: cyclomatic complexity 98 of function (*Operator).transitionCSVState() is high (> 15) (gocyclo)
  • Line 94: warning: cyclomatic complexity 50 of function newOperatorWithConfig() is high (> 15) (gocyclo)
  • Line 849: warning: cyclomatic complexity 37 of function (*Operator).handleClusterServiceVersionDeletion() is high (> 15) (gocyclo)
  • Line 603: warning: cyclomatic complexity 22 of function (*Operator).syncGCObject() is high (> 15) (gocyclo)
  • Line 1066: warning: cyclomatic complexity 18 of function (*Operator).syncClusterServiceVersion() is high (> 15) (gocyclo)
  • Line 1786: warning: cyclomatic complexity 17 of function (*Operator).updateInstallStatus() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/olm/requirements.go
  • Line 75: warning: cyclomatic complexity 29 of function (*Operator).requirementStatus() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/olm/apiservices.go
  • Line 43: warning: cyclomatic complexity 29 of function (*Operator).checkAPIServiceResources() is high (> 15) (gocyclo)
  • Line 440: warning: cyclomatic complexity 16 of function (*Operator).areWebhooksAvailable() is high (> 15) (gocyclo)
  • Line 312: warning: cyclomatic complexity 16 of function (*Operator).updateDeploymentSpecsWithApiServiceData() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/olm/operator_test.go
  • Line 3656: warning: cyclomatic complexity 17 of function TestSyncOperatorGroups() is high (> 15) (gocyclo)
  • Line 3355: warning: cyclomatic complexity 17 of function TestUpdates() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go
  • Line 371: warning: cyclomatic complexity 25 of function (*ConfigMapUnpacker).UnpackBundle() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/install/apiservice.go
  • Line 156: warning: cyclomatic complexity 33 of function (*StrategyDeploymentInstaller).deleteLegacyAPIServiceResources() is high (> 15) (gocyclo)
  • Line 96: warning: cyclomatic complexity 18 of function IsAPIServiceAdoptable() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/install/certresources.go
  • Line 223: warning: cyclomatic complexity 41 of function (*StrategyDeploymentInstaller).installCertRequirementsForDeployment() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/v1/zz_generated.conversion.go
  • Line 39: warning: cyclomatic complexity 25 of function RegisterConversions() is high (> 15) (gocyclo)

• operator-lifecycle-manager/cmd/olm/main.go
  • Line 84: warning: cyclomatic complexity 28 of function main() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/package-server/apis/operators/v1/zz_generated.conversion.go
  • Line 39: warning: cyclomatic complexity 19 of function RegisterConversions() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/registry/resolver/step_resolver.go
  • Line 68: warning: cyclomatic complexity 27 of function (*OperatorStepResolver).ResolveSteps() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/install/deployment.go
  • Line 237: warning: cyclomatic complexity 18 of function (*StrategyDeploymentInstaller).checkForDeployments() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/operatorstatus/status.go
  • Line 36: warning: cyclomatic complexity 25 of function MonitorClusterStatus() is high (> 15) (gocyclo)

• operator-lifecycle-manager/cmd/catalog/main.go
  • Line 81: warning: cyclomatic complexity 20 of function main() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/ownerutil/util.go
  • Line 311: warning: cyclomatic complexity 20 of function InferGroupVersionKind() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/catalog/step.go
  • Line 171: warning: cyclomatic complexity 21 of function (*builder).NewCRDV1Beta1Step() is high (> 15) (gocyclo)
  • Line 93: warning: cyclomatic complexity 21 of function (*builder).NewCRDV1Step() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/registry/resolver/resolver.go
  • Line 48: warning: cyclomatic complexity 25 of function (*SatResolver).SolveOperators() is high (> 15) (gocyclo)
  • Line 166: warning: cyclomatic complexity 24 of function (*SatResolver).getSubscriptionInstallables() is high (> 15) (gocyclo)
  • Line 637: warning: cyclomatic complexity 17 of function (*SatResolver).sortChannel() is high (> 15) (gocyclo)
  • Line 295: warning: cyclomatic complexity 16 of function (*SatResolver).getBundleInstallables() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/olm/operatorgroup.go
  • Line 53: warning: cyclomatic complexity 23 of function (*Operator).syncOperatorGroups() is high (> 15) (gocyclo)
  • Line 528: warning: cyclomatic complexity 20 of function (*Operator).ensureTenantRBAC() is high (> 15) (gocyclo)
  • Line 702: warning: cyclomatic complexity 16 of function (*Operator).copyToNamespace() is high (> 15) (gocyclo)

• operator-lifecycle-manager/cmd/olm/cleanup.go
  • Line 145: warning: cyclomatic complexity 18 of function cleanupOwnerReferences() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/controller-runtime/client/ssa.go
  • Line 97: warning: cyclomatic complexity 18 of function (*ServerSideApplier).Apply() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscription/state.go
  • Line 220: warning: cyclomatic complexity 21 of function (*catalogHealthState).UpdateHealth() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/registry/rbac/validation/rule.go
  • Line 179: warning: cyclomatic complexity 18 of function (*DefaultRuleResolver).VisitRulesFor() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/lib/operatorclient/patch.go
  • Line 309: warning: cyclomatic complexity 33 of function createThreeWayMapPatch() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/registry/resolver/cache.go
  • Line 93: warning: cyclomatic complexity 18 of function (*OperatorCache).Namespaced() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/registry/resolver/operators.go
  • Line 239: warning: cyclomatic complexity 16 of function NewOperatorFromBundle() is high (> 15) (gocyclo)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscription/reconciler.go
  • Line 207: warning: cyclomatic complexity 17 of function (*installPlanReconciler).Reconcile() is high (> 15) (gocyclo)

• operator-lifecycle-manager/test/e2e/subscription_e2e_test.go
  • Line 2649: warning: cyclomatic complexity 16 of function checkDeploymentWithPodConfiguration() is high (> 15) (gocyclo)

golint71%

Golint is a linter for Go source code.

• operator-lifecycle-manager/pkg/lib/operatorstatus/status.go
  • Line 36: warning: exported function MonitorClusterStatus should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/queueinformer/config.go
  • Line 171: warning: exported type OperatorOption should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/index/api.go
  • Line 42: warning: comment on exported function V1CRDProviderNames should be of the form "V1CRDProviderNames ..." (golint)
  • Line 69: warning: comment on exported function V1Beta1CRDProviderNames should be of the form "V1Beta1CRDProviderNames ..." (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/plugin/pkg/auth/authorizer/rbac/subject_locator.go
  • Line 28: warning: exported type RoleToRuleMapper should have comment or be unexported (golint)
  • Line 34: warning: exported type SubjectLocator should have comment or be unexported (golint)
  • Line 40: warning: exported type SubjectAccessEvaluator should have comment or be unexported (golint)
  • Line 48: warning: exported function NewSubjectAccessEvaluator should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/provider/labels.go
  • Line 6: warning: exported const OsLabelPrefix should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/apis/operators/register.go
  • Line 9: warning: exported var Group should have comment or be unexported (golint)

• operator-lifecycle-manager/test/rh-operators/metric_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• operator-lifecycle-manager/pkg/controller/operators/decorators/operator.go
  • Line 63: warning: exported type OperatorFactory should have comment or be unexported (golint)
  • Line 327: warning: exported type Component should have comment or be unexported (golint)
  • Line 356: warning: exported method Component.Matches should have comment or be unexported (golint)
  • Line 366: warning: exported method Component.Reference should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/service.go
  • Line 14: warning: exported type UnionServiceLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionServiceLister.RegisterServiceLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/scoped/error.go
  • Line 9: warning: exported function NewOperatorGroupError should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/apis/operators/v1/register.go
  • Line 12: warning: exported const Group should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• operator-lifecycle-manager/test/e2e/skopeo.go
  • Line 23: warning: exported const BuilderServiceAccount should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/types.go
  • Line 29: warning: exported const APIGroupAll should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/openshift/options.go
  • Line 26: warning: exported type NowFunc should have comment or be unexported (golint)
  • Line 28: warning: exported type ReconcilerConfig should have comment or be unexported (golint)
  • Line 44: warning: exported type ReconcilerOption should have comment or be unexported (golint)
  • Line 98: warning: exported function WithClient should have comment or be unexported (golint)
  • Line 104: warning: exported function WithScheme should have comment or be unexported (golint)
  • Line 110: warning: exported function WithName should have comment or be unexported (golint)
  • Line 116: warning: exported function WithNamespace should have comment or be unexported (golint)
  • Line 122: warning: exported function WithSyncChannel should have comment or be unexported (golint)
  • Line 128: warning: exported function WithNow should have comment or be unexported (golint)
  • Line 134: warning: exported function WithLog should have comment or be unexported (golint)
  • Line 140: warning: exported function WithTargetVersions should have comment or be unexported (golint)
  • Line 146: warning: exported function WithOLMOperator should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/storage/reststorage.go
  • Line 24: warning: exported type PackageManifestStorage should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/installabletypes.go
  • Line 12: warning: exported type BundleInstallable should have comment or be unexported (golint)
  • Line 19: warning: exported method BundleInstallable.Identifier should have comment or be unexported (golint)
  • Line 23: warning: exported method BundleInstallable.Constraints should have comment or be unexported (golint)
  • Line 27: warning: exported method BundleInstallable.MakeProhibited should have comment or be unexported (golint)
  • Line 31: warning: exported method BundleInstallable.AddConflict should have comment or be unexported (golint)
  • Line 35: warning: exported method BundleInstallable.AddDependency should have comment or be unexported (golint)
  • Line 39: warning: exported method BundleInstallable.BundleSourceInfo should have comment or be unexported (golint)
  • Line 58: warning: exported function NewBundleInstallableFromOperator should have comment or be unexported (golint)
  • Line 76: warning: exported function NewBundleInstallable should have comment or be unexported (golint)
  • Line 83: warning: exported type GenericInstallable should have comment or be unexported (golint)
  • Line 88: warning: exported method GenericInstallable.Identifier should have comment or be unexported (golint)
  • Line 92: warning: exported method GenericInstallable.Constraints should have comment or be unexported (golint)
  • Line 96: warning: exported function NewInvalidSubscriptionInstallable should have comment or be unexported (golint)
  • Line 106: warning: exported function NewSubscriptionInstallable should have comment or be unexported (golint)
  • Line 134: warning: exported function NewSingleAPIProviderInstallable should have comment or be unexported (golint)
  • Line 155: warning: exported function NewSinglePackageInstanceInstallable should have comment or be unexported (golint)
  • Line 175: warning: exported function PrettyConstraint should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/v1/defaults.go
  • Line 28: warning: exported function SetDefaults_ClusterRoleBinding should have comment or be unexported (golint)
  • Line 28: warning: don't use underscores in Go names; func SetDefaults_ClusterRoleBinding should be SetDefaultsClusterRoleBinding (golint)
  • Line 33: warning: exported function SetDefaults_RoleBinding should have comment or be unexported (golint)
  • Line 33: warning: don't use underscores in Go names; func SetDefaults_RoleBinding should be SetDefaultsRoleBinding (golint)
  • Line 38: warning: exported function SetDefaults_Subject should have comment or be unexported (golint)
  • Line 38: warning: don't use underscores in Go names; func SetDefaults_Subject should be SetDefaultsSubject (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/clusterserviceversion.go
  • Line 15: warning: exported type UnionClusterServiceVersionLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionClusterServiceVersionLister.RegisterClusterServiceVersionLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/projection/properties.go
  • Line 11: warning: exported const PropertiesAnnotationKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported function PropertiesAnnotationFromPropertyList should have comment or be unexported (golint)
  • Line 38: warning: exported function PropertyListFromPropertiesAnnotation should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/subscription.go
  • Line 15: warning: exported type UnionSubscriptionLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionSubscriptionLister.RegisterSubscriptionLister should have comment or be unexported (golint)

• operator-lifecycle-manager/test/e2e/ctx/provisioner_kubeconfig.go
  • Line 17: warning: exported function Provision should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/rbac.go
  • Line 31: warning: exported type OperatorPermissions should have comment or be unexported (golint)
  • Line 39: warning: exported function NewOperatorPermissions should have comment or be unexported (golint)
  • Line 49: warning: exported method OperatorPermissions.AddRole should have comment or be unexported (golint)
  • Line 53: warning: exported method OperatorPermissions.AddRoleBinding should have comment or be unexported (golint)
  • Line 57: warning: exported method OperatorPermissions.AddClusterRole should have comment or be unexported (golint)
  • Line 61: warning: exported method OperatorPermissions.AddClusterRoleBinding should have comment or be unexported (golint)
  • Line 65: warning: exported function RBACForClusterServiceVersion should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/olm/overrides/initializer.go
  • Line 29: warning: exported type DeploymentInitializer should have comment or be unexported (golint)
  • Line 35: warning: exported method DeploymentInitializer.GetDeploymentInitializer should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/pod.go
  • Line 14: warning: exported type UnionPodLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionPodLister.RegisterPodLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/metrics/metrics.go
  • Line 16: warning: exported const NAME_LABEL should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported type MetricsProvider should have comment or be unexported (golint)
  • Line 38: warning: exported function NewMetricsCSV should have comment or be unexported (golint)
  • Line 55: warning: exported function NewMetricsInstallPlan should have comment or be unexported (golint)
  • Line 72: warning: exported function NewMetricsSubscription should have comment or be unexported (golint)
  • Line 89: warning: exported function NewMetricsCatalogSource should have comment or be unexported (golint)
  • Line 103: warning: exported type MetricsNil should have comment or be unexported (golint)
  • Line 105: warning: exported function NewMetricsNil should have comment or be unexported (golint)
  • Line 109: warning: exported method MetricsNil.HandleMetrics should have comment or be unexported (golint)
  • Line 207: warning: exported function RegisterOLM should have comment or be unexported (golint)
  • Line 214: warning: exported function RegisterCatalog should have comment or be unexported (golint)
  • Line 223: warning: exported function CounterForSubscription should have comment or be unexported (golint)
  • Line 227: warning: exported function RegisterCatalogSourceState should have comment or be unexported (golint)
  • Line 236: warning: exported function DeleteCatalogSourceStateMetric should have comment or be unexported (golint)
  • Line 240: warning: exported function DeleteCSVMetric should have comment or be unexported (golint)
  • Line 246: warning: exported function EmitCSVMetric should have comment or be unexported (golint)
  • Line 270: warning: exported function EmitSubMetric should have comment or be unexported (golint)
  • Line 285: warning: exported function DeleteSubsMetric should have comment or be unexported (golint)
  • Line 292: warning: exported function UpdateSubsSyncCounterStorage should have comment or be unexported (golint)
  • Line 316: warning: exported function RegisterDependencyResolutionSuccess should have comment or be unexported (golint)
  • Line 320: warning: exported function RegisterDependencyResolutionFailure should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/webhook.go
  • Line 20: warning: exported function ValidWebhookRules should have comment or be unexported (golint)
  • Line 272: warning: exported const WebhookDescKey should have comment or be unexported (golint)
  • Line 273: warning: exported const WebhookHashKey should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/registry/rbac/validation/policy_comparator.go
  • Line 56: warning: comment on exported function BreakdownRule should be of the form "BreakdownRule ..." (golint)

• operator-lifecycle-manager/pkg/controller/operators/openshift/clusteroperator.go
  • Line 10: warning: exported function NewClusterOperator should have comment or be unexported (golint)
  • Line 16: warning: exported type ClusterOperator should have comment or be unexported (golint)
  • Line 20: warning: exported method ClusterOperator.GetOperatorVersion should have comment or be unexported (golint)
  • Line 30: warning: exported method ClusterOperator.GetCondition should have comment or be unexported (golint)
  • Line 40: warning: exported method ClusterOperator.SetCondition should have comment or be unexported (golint)
  • Line 52: warning: exported type Mutator should have comment or be unexported (golint)
  • Line 56: warning: exported type MutateFunc should have comment or be unexported (golint)
  • Line 58: warning: exported method MutateFunc.Mutate should have comment or be unexported (golint)
  • Line 62: warning: exported type SerialMutations should have comment or be unexported (golint)
  • Line 64: warning: exported method SerialMutations.Mutate should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/registry/rbac/validation/internal_version_adapter.go
  • Line 27: warning: exported function ConfirmNoEscalationInternal should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/cache.go
  • Line 21: warning: exported type RegistryClientProvider should have comment or be unexported (golint)
  • Line 25: warning: exported type DefaultRegistryClientProvider should have comment or be unexported (golint)
  • Line 30: warning: exported function NewDefaultRegistryClientProvider should have comment or be unexported (golint)
  • Line 37: warning: exported method DefaultRegistryClientProvider.ClientsForNamespaces should have comment or be unexported (golint)
  • Line 41: warning: exported type OperatorCacheProvider should have comment or be unexported (golint)
  • Line 46: warning: exported type OperatorCache should have comment or be unexported (golint)
  • Line 62: warning: exported function NewOperatorCache should have comment or be unexported (golint)
  • Line 77: warning: exported type NamespacedOperatorCache should have comment or be unexported (golint)
  • Line 83: warning: exported method OperatorCache.Expire should have comment or be unexported (golint)
  • Line 93: warning: exported method OperatorCache.Namespaced should have comment or be unexported (golint)
  • Line 251: warning: exported method NamespacedOperatorCache.Catalog should have comment or be unexported (golint)
  • Line 262: warning: exported method NamespacedOperatorCache.FindPreferred should have comment or be unexported (golint)
  • Line 275: warning: exported method NamespacedOperatorCache.WithExistingOperators should have comment or be unexported (golint)
  • Line 285: warning: exported method NamespacedOperatorCache.Find should have comment or be unexported (golint)
  • Line 289: warning: exported type CatalogSnapshot should have comment or be unexported (golint)
  • Line 299: warning: exported method CatalogSnapshot.Cancel should have comment or be unexported (golint)
  • Line 303: warning: exported method CatalogSnapshot.Expired should have comment or be unexported (golint)
  • Line 317: warning: exported type SortableSnapshots should have comment or be unexported (golint)
  • Line 324: warning: exported function NewSortableSnapshots should have comment or be unexported (golint)
  • Line 390: warning: exported type OperatorPredicateFunc should have comment or be unexported (golint)
  • Line 392: warning: exported method OperatorPredicateFunc.Test should have comment or be unexported (golint)
  • Line 396: warning: exported type OperatorPredicate should have comment or be unexported (golint)
  • Line 400: warning: exported method CatalogSnapshot.Find should have comment or be unexported (golint)
  • Line 406: warning: exported type OperatorFinder should have comment or be unexported (golint)
  • Line 410: warning: exported type MultiCatalogOperatorFinder should have comment or be unexported (golint)
  • Line 417: warning: exported type EmptyOperatorFinder should have comment or be unexported (golint)
  • Line 419: warning: exported method EmptyOperatorFinder.Find should have comment or be unexported (golint)
  • Line 423: warning: exported function WithCSVName should have comment or be unexported (golint)
  • Line 429: warning: exported function WithChannel should have comment or be unexported (golint)
  • Line 442: warning: exported function WithPackage should have comment or be unexported (golint)
  • Line 461: warning: exported function WithVersionInRange should have comment or be unexported (golint)
  • Line 484: warning: exported function WithLabel should have comment or be unexported (golint)
  • Line 503: warning: exported function WithCatalog should have comment or be unexported (golint)
  • Line 509: warning: exported function ProvidingAPI should have comment or be unexported (golint)
  • Line 528: warning: exported function SkipRangeIncludes should have comment or be unexported (golint)
  • Line 536: warning: exported function Replaces should have comment or be unexported (golint)
  • Line 550: warning: exported function And should have comment or be unexported (golint)
  • Line 561: warning: exported function Or should have comment or be unexported (golint)
  • Line 572: warning: exported function AtLeast should have comment or be unexported (golint)
  • Line 579: warning: exported function ExactlyOne should have comment or be unexported (golint)
  • Line 586: warning: exported function Filter should have comment or be unexported (golint)
  • Line 596: warning: exported function Matches should have comment or be unexported (golint)
  • Line 600: warning: exported function True should have comment or be unexported (golint)
  • Line 606: warning: exported function False should have comment or be unexported (golint)
  • Line 612: warning: exported function CountingPredicate should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/querier.go
  • Line 1: warning: package comment should be of the form "Package resolver ..." (golint)
  • Line 21: warning: exported const SkipPackageAnnotationKey should have comment or be unexported (golint)
  • Line 23: warning: exported type SourceRef should have comment or be unexported (golint)
  • Line 30: warning: exported type SourceQuerier should have comment or be unexported (golint)
  • Line 38: warning: exported type NamespaceSourceQuerier should have comment or be unexported (golint)
  • Line 44: warning: exported function NewNamespaceSourceQuerier should have comment or be unexported (golint)
  • Line 50: warning: exported method NamespaceSourceQuerier.Queryable should have comment or be unexported (golint)
  • Line 57: warning: exported method NamespaceSourceQuerier.FindProvider should have comment or be unexported (golint)
  • Line 80: warning: exported method NamespaceSourceQuerier.FindBundle should have comment or be unexported (golint)
  • Line 103: warning: exported method NamespaceSourceQuerier.FindLatestBundle should have comment or be unexported (golint)
  • Line 126: warning: exported method NamespaceSourceQuerier.FindReplacement should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/olm/operatorgroup.go
  • Line 28: warning: exported const AdminSuffix should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported var AdminVerbs should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/internal/alongside/alongside.go
  • Line 22: warning: exported type Annotatable should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/scoped/util.go
  • Line 37: warning: exported function IsObjectRBACRelated should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/deployment.go
  • Line 22: warning: exported const DeploymentSpecHashLabelKey should have comment or be unexported (golint)
  • Line 24: warning: exported type StrategyDeploymentInstaller should have comment or be unexported (golint)
  • Line 68: warning: exported function NewStrategyDeploymentInstaller should have comment or be unexported (golint)
  • Line 199: warning: exported method StrategyDeploymentInstaller.Install should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/operatorcondition_controller.go
  • Line 27: warning: exported const OperatorConditionEnvVarKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 92: warning: exported method OperatorConditionReconciler.Reconcile should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscription/state.go
  • Line 99: warning: exported type NoInstallPlanReferencedState should have comment or be unexported (golint)
  • Line 105: warning: exported type InstallPlanReferencedState should have comment or be unexported (golint)
  • Line 115: warning: exported type InstallPlanKnownState should have comment or be unexported (golint)
  • Line 121: warning: exported type InstallPlanMissingState should have comment or be unexported (golint)
  • Line 127: warning: exported type InstallPlanPendingState should have comment or be unexported (golint)
  • Line 133: warning: exported type InstallPlanFailedState should have comment or be unexported (golint)
  • Line 139: warning: exported type InstallPlanInstalledState should have comment or be unexported (golint)
  • Line 183: warning: exported function NewSubscriptionState should have comment or be unexported (golint)
  • Line 315: warning: exported function NewCatalogHealthState should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/apiservice.go
  • Line 96: warning: exported function IsAPIServiceAdoptable should have comment or be unexported (golint)
  • Line 146: warning: exported function IsAPIServiceAvailable should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/instrumented_resolver.go
  • Line 11: warning: exported type InstrumentedResolver should have comment or be unexported (golint)
  • Line 19: warning: exported function NewInstrumentedResolver should have comment or be unexported (golint)
  • Line 27: warning: exported method InstrumentedResolver.ResolveSteps should have comment or be unexported (golint)
  • Line 38: warning: exported method InstrumentedResolver.Expire should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/operator_controller.go
  • Line 112: warning: exported method OperatorReconciler.Reconcile should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/time/shared.go
  • Line 8: warning: exported type SharedTime should have comment or be unexported (golint)
  • Line 13: warning: exported method SharedTime.Before should have comment or be unexported (golint)
  • Line 20: warning: exported method SharedTime.After should have comment or be unexported (golint)
  • Line 27: warning: exported method SharedTime.Set should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/clusterrole.go
  • Line 12: warning: exported type UnionClusterRoleLister should have comment or be unexported (golint)
  • Line 28: warning: exported method UnionClusterRoleLister.Get should have comment or be unexported (golint)
  • Line 38: warning: exported method UnionClusterRoleLister.RegisterClusterRoleLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/lister.go
  • Line 42: warning: comment on exported type AppsV1Lister should be of the form "AppsV1Lister ..." (with optional leading article) (golint)
  • Line 49: warning: comment on exported type CoreV1Lister should be of the form "CoreV1Lister ..." (with optional leading article) (golint)
  • Line 66: warning: comment on exported type RbacV1Lister should be of the form "RbacV1Lister ..." (with optional leading article) (golint)
  • Line 79: warning: comment on exported type APIRegistrationV1Lister should be of the form "APIRegistrationV1Lister ..." (with optional leading article) (golint)
  • Line 86: warning: comment on exported type APIExtensionsV1Lister should be of the form "APIExtensionsV1Lister ..." (with optional leading article) (golint)
  • Line 92: warning: comment on exported type OperatorsV1alpha1Lister should be of the form "OperatorsV1alpha1Lister ..." (with optional leading article) (golint)
  • Line 105: warning: comment on exported type OperatorsV1Lister should be of the form "OperatorsV1Lister ..." (with optional leading article) (golint)
  • Line 249: warning: exported function NewLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/namespace.go
  • Line 12: warning: exported type UnionNamespaceLister should have comment or be unexported (golint)
  • Line 28: warning: exported method UnionNamespaceLister.Get should have comment or be unexported (golint)
  • Line 38: warning: exported method UnionNamespaceLister.RegisterNamespaceLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorclient/clusterrolebinding.go
  • Line 13: warning: comment on exported method Client.CreateClusterRoleBinding should be of the form "CreateClusterRoleBinding ..." (golint)
  • Line 18: warning: comment on exported method Client.GetClusterRoleBinding should be of the form "GetClusterRoleBinding ..." (golint)
  • Line 23: warning: comment on exported method Client.DeleteClusterRoleBinding should be of the form "DeleteClusterRoleBinding ..." (golint)
  • Line 28: warning: comment on exported method Client.UpdateClusterRoleBinding should be of the form "UpdateClusterRoleBinding ..." (golint)

• operator-lifecycle-manager/pkg/lib/queueinformer/jitter.go
  • Line 9: warning: exported const DefaultResyncPeriod should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/olm/operator.go
  • Line 54: warning: exported var ErrRequirementsNotMet should have comment or be unexported (golint)
  • Line 59: warning: exported type Operator should have comment or be unexported (golint)
  • Line 87: warning: exported function NewOperator should have comment or be unexported (golint)
  • Line 587: warning: exported method Operator.GetCSVSetGenerator should have comment or be unexported (golint)
  • Line 591: warning: exported method Operator.GetReplaceFinder should have comment or be unexported (golint)
  • Line 595: warning: exported method Operator.RegisterCSVWatchNotification should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/v1/evaluation_helpers.go
  • Line 27: warning: exported function RoleRefGroupKind should have comment or be unexported (golint)
  • Line 31: warning: exported function VerbMatches should have comment or be unexported (golint)
  • Line 44: warning: exported function APIGroupMatches should have comment or be unexported (golint)
  • Line 57: warning: exported function ResourceMatches should have comment or be unexported (golint)
  • Line 85: warning: exported function ResourceNameMatches should have comment or be unexported (golint)
  • Line 99: warning: exported function NonResourceURLMatches should have comment or be unexported (golint)
  • Line 115: warning: comment on exported function SubjectsStrings should be of the form "SubjectsStrings ..." (golint)
  • Line 141: warning: exported function String should have comment or be unexported (golint)
  • Line 173: warning: exported type SortableRuleSlice should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/status_viewer.go
  • Line 10: warning: exported const TimedOutReason should have comment or be unexported (golint)
  • Line 12: warning: comment on exported function DeploymentStatus should be of the form "DeploymentStatus ..." (golint)

• operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc_address.go
  • Line 7: warning: exported type GrpcAddressRegistryReconciler should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/registry/rbac/validation/rule.go
  • Line 37: warning: exported type AuthorizationRuleResolver should have comment or be unexported (golint)
  • Line 91: warning: exported type DefaultRuleResolver should have comment or be unexported (golint)
  • Line 98: warning: exported function NewDefaultRuleResolver should have comment or be unexported (golint)
  • Line 102: warning: exported type RoleGetter should have comment or be unexported (golint)
  • Line 106: warning: exported type RoleBindingLister should have comment or be unexported (golint)
  • Line 110: warning: exported type ClusterRoleGetter should have comment or be unexported (golint)
  • Line 114: warning: exported type ClusterRoleBindingLister should have comment or be unexported (golint)
  • Line 118: warning: exported method DefaultRuleResolver.RulesFor should have comment or be unexported (golint)
  • Line 179: warning: exported method DefaultRuleResolver.VisitRulesFor should have comment or be unexported (golint)
  • Line 320: warning: exported method StaticRoles.GetRole should have comment or be unexported (golint)
  • Line 332: warning: exported method StaticRoles.GetClusterRole should have comment or be unexported (golint)
  • Line 341: warning: exported method StaticRoles.ListRoleBindings should have comment or be unexported (golint)
  • Line 357: warning: exported method StaticRoles.ListClusterRoleBindings should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/catalogsources.go
  • Line 15: warning: exported type UnionCatalogSourceLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionCatalogSourceLister.RegisterCatalogSourceLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/serviceaccount.go
  • Line 14: warning: exported type UnionServiceAccountLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionServiceAccountLister.RegisterServiceAccountLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorclient/client.go
  • Line 1: warning: package comment should be of the form "Package operatorclient ..." (golint)
  • Line 20: warning: exported type ClientInterface should have comment or be unexported (golint)
  • Line 149: warning: comment on exported function NewClientFromConfig should be of the form "NewClientFromConfig ..." (golint)
  • Line 169: warning: exported function NewClientFromRestConfig should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/client/util.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• operator-lifecycle-manager/pkg/controller/registry/grpc/source.go
  • Line 17: warning: exported type SourceMeta should have comment or be unexported (golint)
  • Line 23: warning: exported type SourceState should have comment or be unexported (golint)
  • Line 28: warning: exported type SourceConn should have comment or be unexported (golint)
  • Line 34: warning: exported type SourceStore should have comment or be unexported (golint)
  • Line 45: warning: exported function NewSourceStore should have comment or be unexported (golint)
  • Line 56: warning: exported method SourceStore.Start should have comment or be unexported (golint)
  • Line 74: warning: exported method SourceStore.GetMeta should have comment or be unexported (golint)
  • Line 85: warning: exported method SourceStore.Exists should have comment or be unexported (golint)
  • Line 92: warning: exported method SourceStore.Get should have comment or be unexported (golint)
  • Line 102: warning: exported method SourceStore.Add should have comment or be unexported (golint)
  • Line 172: warning: exported method SourceStore.Remove should have comment or be unexported (golint)
  • Line 192: warning: exported method SourceStore.AsClients should have comment or be unexported (golint)
  • Line 211: warning: exported method SourceStore.ClientsForNamespaces should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/codec/mapstructure.go
  • Line 11: warning: exported function MetaTimeHookFunc should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/olm/apiservices.go
  • Line 23: warning: comment on exported const PackageserverName should be of the form "PackageserverName ..." (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/operatorcondition.go
  • Line 15: warning: exported type UnionOperatorConditionLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionOperatorConditionLister.RegisterOperatorConditionLister should have comment or be unexported (golint)

• operator-lifecycle-manager/test/e2e/ctx/installer_none.go
  • Line 5: warning: exported function Install should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/solver/solve.go
  • Line 14: warning: error var Incomplete should have name of the form ErrFoo (golint)
  • Line 14: warning: exported var Incomplete should have comment or be unexported (golint)
  • Line 32: warning: exported type Solver should have comment or be unexported (golint)
  • Line 120: warning: exported function New should have comment or be unexported (golint)
  • Line 130: warning: exported type Option should have comment or be unexported (golint)
  • Line 132: warning: exported function WithInput should have comment or be unexported (golint)
  • Line 140: warning: exported function WithTracer should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go
  • Line 32: warning: comment on exported const BundleLookupFailed should be of the form "BundleLookupFailed ..." (golint)
  • Line 36: warning: comment on exported const BundleUnpackTimeoutAnnotationKey should be of the form "BundleUnpackTimeoutAnnotationKey ..." (golint)
  • Line 44: warning: exported type BundleUnpackResult should have comment or be unexported (golint)
  • Line 51: warning: exported method BundleUnpackResult.Bundle should have comment or be unexported (golint)
  • Line 55: warning: exported method BundleUnpackResult.Name should have comment or be unexported (golint)
  • Line 223: warning: exported type Unpacker should have comment or be unexported (golint)
  • Line 227: warning: exported type ConfigMapUnpacker should have comment or be unexported (golint)
  • Line 242: warning: exported type ConfigMapUnpackerOption should have comment or be unexported (golint)
  • Line 244: warning: exported function NewConfigmapUnpacker should have comment or be unexported (golint)
  • Line 257: warning: exported function WithUnpackTimeout should have comment or be unexported (golint)
  • Line 263: warning: exported function WithOPMImage should have comment or be unexported (golint)
  • Line 269: warning: exported function WithUtilImage should have comment or be unexported (golint)
  • Line 275: warning: exported function WithClient should have comment or be unexported (golint)
  • Line 281: warning: exported function WithCatalogSourceLister should have comment or be unexported (golint)
  • Line 287: warning: exported function WithConfigMapLister should have comment or be unexported (golint)
  • Line 293: warning: exported function WithJobLister should have comment or be unexported (golint)
  • Line 299: warning: exported function WithPodLister should have comment or be unexported (golint)
  • Line 305: warning: exported function WithRoleLister should have comment or be unexported (golint)
  • Line 311: warning: exported function WithRoleBindingLister should have comment or be unexported (golint)
  • Line 317: warning: exported function WithNow should have comment or be unexported (golint)
  • Line 359: warning: exported const CatalogSourceMissingReason should have comment (or a comment on this block) or be unexported (golint)
  • Line 371: warning: exported method ConfigMapUnpacker.UnpackBundle should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/catalog/step.go
  • Line 33: warning: exported method StepperFunc.Status should have comment or be unexported (golint)
  • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 183: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• operator-lifecycle-manager/pkg/package-server/provider/registry.go
  • Line 61: warning: exported function PackageManifestKeyFunc should have comment or be unexported (golint)
  • Line 74: warning: exported function SplitPackageManifestKey should have comment or be unexported (golint)
  • Line 127: warning: exported function NewRegistryProvider should have comment or be unexported (golint)
  • Line 398: warning: exported method RegistryProvider.Get should have comment or be unexported (golint)
  • Line 420: warning: exported method RegistryProvider.List should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/step_resolver.go
  • Line 1: warning: package comment should be of the form "Package resolver ..." (golint)
  • Line 27: warning: exported const BundleLookupConditionPacked should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type StepResolver should have comment or be unexported (golint)
  • Line 37: warning: exported type OperatorStepResolver should have comment or be unexported (golint)
  • Line 50: warning: exported function NewOperatorStepResolver should have comment or be unexported (golint)
  • Line 64: warning: exported method OperatorStepResolver.Expire should have comment or be unexported (golint)
  • Line 68: warning: exported method OperatorStepResolver.ResolveSteps should have comment or be unexported (golint)
  • Line 173: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• operator-lifecycle-manager/cmd/olm/manager.go
  • Line 13: warning: exported function Manager should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/configmap.go
  • Line 14: warning: exported type UnionConfigMapLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionConfigMapLister.RegisterConfigMapLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubestate/kubestate.go
  • Line 7: warning: exported type State should have comment or be unexported (golint)
  • Line 16: warning: exported type ExistsState should have comment or be unexported (golint)
  • Line 22: warning: exported type AddedState should have comment or be unexported (golint)
  • Line 28: warning: exported type UpdatedState should have comment or be unexported (golint)
  • Line 34: warning: exported type DoesNotExistState should have comment or be unexported (golint)
  • Line 40: warning: exported type DeletedState should have comment or be unexported (golint)
  • Line 79: warning: exported function NewState should have comment or be unexported (golint)
  • Line 113: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 117: warning: exported type ReconcilerFunc should have comment or be unexported (golint)
  • Line 119: warning: exported method ReconcilerFunc.Reconcile should have comment or be unexported (golint)
  • Line 123: warning: exported type ReconcilerChain should have comment or be unexported (golint)
  • Line 125: warning: exported method ReconcilerChain.Reconcile should have comment or be unexported (golint)
  • Line 148: warning: exported type ResourceEvent should have comment or be unexported (golint)
  • Line 166: warning: exported function NewResourceEvent should have comment or be unexported (golint)
  • Line 173: warning: exported type Notifier should have comment or be unexported (golint)
  • Line 177: warning: exported type NotifyFunc should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscriptions.go
  • Line 10: warning: exported var ErrNilSubscription should have comment or be unexported (golint)
  • Line 14: warning: exported const PackageLabel should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/apis/operators/v1/doc.go
  • Line 6: warning: package comment should be of the form "Package v1 ..." (golint)

• operator-lifecycle-manager/pkg/lib/queueinformer/queueinformer.go
  • Line 108: warning: exported function NewQueue should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/api/wrappers/deployment_install_client.go
  • Line 1: warning: package comment should be of the form "Package wrappers ..." (golint)
  • Line 20: warning: exported var ErrNilObject should have comment or be unexported (golint)
  • Line 22: warning: exported type InstallStrategyDeploymentInterface should have comment or be unexported (golint)
  • Line 36: warning: exported type InstallStrategyDeploymentClientForNamespace should have comment or be unexported (golint)
  • Line 44: warning: exported function NewInstallStrategyDeploymentClient should have comment or be unexported (golint)
  • Line 52: warning: exported method InstallStrategyDeploymentClientForNamespace.GetOpClient should have comment or be unexported (golint)
  • Line 56: warning: exported method InstallStrategyDeploymentClientForNamespace.GetOpLister should have comment or be unexported (golint)
  • Line 60: warning: exported method InstallStrategyDeploymentClientForNamespace.CreateRole should have comment or be unexported (golint)
  • Line 64: warning: exported method InstallStrategyDeploymentClientForNamespace.CreateRoleBinding should have comment or be unexported (golint)
  • Line 68: warning: exported method InstallStrategyDeploymentClientForNamespace.EnsureServiceAccount should have comment or be unexported (golint)
  • Line 100: warning: exported method InstallStrategyDeploymentClientForNamespace.CreateDeployment should have comment or be unexported (golint)
  • Line 104: warning: exported method InstallStrategyDeploymentClientForNamespace.DeleteDeployment should have comment or be unexported (golint)
  • Line 112: warning: exported method InstallStrategyDeploymentClientForNamespace.CreateOrUpdateDeployment should have comment or be unexported (golint)
  • Line 127: warning: exported method InstallStrategyDeploymentClientForNamespace.GetServiceAccountByName should have comment or be unexported (golint)
  • Line 131: warning: exported method InstallStrategyDeploymentClientForNamespace.FindAnyDeploymentsMatchingNames should have comment or be unexported (golint)
  • Line 147: warning: exported method InstallStrategyDeploymentClientForNamespace.FindAnyDeploymentsMatchingLabels should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/solver/tracer.go
  • Line 8: warning: exported type SearchPosition should have comment or be unexported (golint)
  • Line 13: warning: exported type Tracer should have comment or be unexported (golint)
  • Line 17: warning: exported type DefaultTracer should have comment or be unexported (golint)
  • Line 19: warning: exported method DefaultTracer.Trace should have comment or be unexported (golint)
  • Line 22: warning: exported type LoggingTracer should have comment or be unexported (golint)
  • Line 26: warning: exported method LoggingTracer.Trace should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/errors.go
  • Line 4: warning: exported const StrategyErrReasonComponentMissing should have comment (or a comment on this block) or be unexported (golint)
  • Line 45: warning: exported function ReasonForError should have comment or be unexported (golint)

• operator-lifecycle-manager/test/rh-operators/operator_util.go
  • Line 1: warning: don't use an underscore in package name (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/operators.go
  • Line 20: warning: exported type APISet should have comment or be unexported (golint)
  • Line 22: warning: exported function EmptyAPISet should have comment or be unexported (golint)
  • Line 26: warning: exported method APISet.PopAPIKey should have comment or be unexported (golint)
  • Line 40: warning: exported function GVKStringToProvidedAPISet should have comment or be unexported (golint)
  • Line 54: warning: exported function APIKeyToGVKString should have comment or be unexported (golint)
  • Line 59: warning: exported function APIKeyToGVKHash should have comment or be unexported (golint)
  • Line 109: warning: exported method APISet.Difference should have comment or be unexported (golint)
  • Line 141: warning: exported type APIOwnerSet should have comment or be unexported (golint)
  • Line 143: warning: exported function EmptyAPIOwnerSet should have comment or be unexported (golint)
  • Line 147: warning: exported type OperatorSet should have comment or be unexported (golint)
  • Line 149: warning: exported function EmptyOperatorSet should have comment or be unexported (golint)
  • Line 162: warning: exported type APIMultiOwnerSet should have comment or be unexported (golint)
  • Line 164: warning: exported function EmptyAPIMultiOwnerSet should have comment or be unexported (golint)
  • Line 168: warning: exported method APIMultiOwnerSet.PopAPIKey should have comment or be unexported (golint)
  • Line 182: warning: exported method APIMultiOwnerSet.PopAPIRequirers should have comment or be unexported (golint)
  • Line 194: warning: exported type OperatorSourceInfo should have comment or be unexported (golint)
  • Line 206: warning: exported var NoCatalog should have comment or be unexported (golint)
  • Line 207: warning: exported var ExistingOperator should have comment or be unexported (golint)
  • Line 224: warning: exported type Operator should have comment or be unexported (golint)
  • Line 239: warning: exported function NewOperatorFromBundle should have comment or be unexported (golint)
  • Line 316: warning: exported function NewOperatorFromV1Alpha1CSV should have comment or be unexported (golint)
  • Line 362: warning: exported method Operator.ProvidedAPIs should have comment or be unexported (golint)
  • Line 366: warning: exported method Operator.RequiredAPIs should have comment or be unexported (golint)
  • Line 370: warning: exported method Operator.Identifier should have comment or be unexported (golint)
  • Line 374: warning: exported method Operator.Replaces should have comment or be unexported (golint)
  • Line 378: warning: exported method Operator.Skips should have comment or be unexported (golint)
  • Line 382: warning: exported method Operator.SetReplaces should have comment or be unexported (golint)
  • Line 386: warning: exported method Operator.Package should have comment or be unexported (golint)
  • Line 393: warning: exported method Operator.Channel should have comment or be unexported (golint)
  • Line 400: warning: exported method Operator.SourceInfo should have comment or be unexported (golint)
  • Line 404: warning: exported method Operator.Bundle should have comment or be unexported (golint)
  • Line 408: warning: exported method Operator.Version should have comment or be unexported (golint)
  • Line 412: warning: exported method Operator.Inline should have comment or be unexported (golint)
  • Line 416: warning: exported method Operator.Dependencies should have comment or be unexported (golint)
  • Line 420: warning: exported method Operator.Properties should have comment or be unexported (golint)
  • Line 424: warning: exported method Operator.DependencyPredicates should have comment or be unexported (golint)
  • Line 440: warning: comment on exported function PredicateForDependency should be of the form "PredicateForDependency ..." (golint)

• operator-lifecycle-manager/pkg/api/client/clientset/versioned/fake/decorator.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/rolebinding.go
  • Line 14: warning: exported type UnionRoleBindingLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionRoleBindingLister.RegisterRoleBindingLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/openshift/helpers.go
  • Line 167: warning: exported const MaxOpenShiftVersionProperty should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/clusterrolebinding.go
  • Line 12: warning: exported type UnionClusterRoleBindingLister should have comment or be unexported (golint)
  • Line 28: warning: exported method UnionClusterRoleBindingLister.Get should have comment or be unexported (golint)
  • Line 38: warning: exported method UnionClusterRoleBindingLister.RegisterClusterRoleBindingLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/steps.go
  • Line 26: warning: exported const BundleSecretKind should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: comment on exported function NewStepResourceFromObject should be of the form "NewStepResourceFromObject ..." (golint)
  • Line 89: warning: exported function NewSubscriptionStepResource should have comment or be unexported (golint)
  • Line 106: warning: exported function V1alpha1CSVFromBundle should have comment or be unexported (golint)
  • Line 114: warning: exported function NewStepResourceFromBundle should have comment or be unexported (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 165: warning: exported function NewStepsFromBundle should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/solver/lit_mapping.go
  • Line 12: warning: exported type DuplicateIdentifier should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/register.go
  • Line 24: warning: exported const GroupName should have comment or be unexported (golint)
  • Line 40: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/resolver.go
  • Line 22: warning: exported type OperatorResolver should have comment or be unexported (golint)
  • Line 26: warning: exported type SatResolver should have comment or be unexported (golint)
  • Line 31: warning: exported function NewDefaultSatResolver should have comment or be unexported (golint)
  • Line 48: warning: exported method SatResolver.SolveOperators should have comment or be unexported (golint)
  • Line 434: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/operatorgroup.go
  • Line 15: warning: exported type UnionOperatorGroupLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionOperatorGroupLister.RegisterOperatorGroupLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/server/server.go
  • Line 55: warning: exported type PackageServerOptions should have comment or be unexported (golint)
  • Line 78: warning: exported function NewPackageServerOptions should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/resolver.go
  • Line 1: warning: package comment should be of the form "Package install ..." (golint)
  • Line 16: warning: exported type Strategy should have comment or be unexported (golint)
  • Line 20: warning: exported type StrategyInstaller should have comment or be unexported (golint)
  • Line 25: warning: exported type StrategyResolverInterface should have comment or be unexported (golint)
  • Line 30: warning: exported type StrategyResolver should have comment or be unexported (golint)
  • Line 34: warning: exported method StrategyResolver.UnmarshalStrategy should have comment or be unexported (golint)
  • Line 43: warning: exported method StrategyResolver.InstallerForStrategy should have comment or be unexported (golint)
  • Line 60: warning: exported type NullStrategyInstaller should have comment or be unexported (golint)
  • Line 64: warning: exported method NullStrategyInstaller.Install should have comment or be unexported (golint)
  • Line 68: warning: exported method NullStrategyInstaller.CheckInstalled should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/ownerutil/util.go
  • Line 22: warning: exported const OwnerKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported var NotController should have comment or be unexported (golint)
  • Line 39: warning: exported function IsOwnedBy should have comment or be unexported (golint)
  • Line 48: warning: exported function IsOwnedByLabel should have comment or be unexported (golint)
  • Line 62: warning: exported function IsOwnedByKind should have comment or be unexported (golint)
  • Line 71: warning: exported function GetOwnerByKind should have comment or be unexported (golint)
  • Line 80: warning: exported function GetOwnerByKindLabel should have comment or be unexported (golint)
  • Line 226: warning: comment on exported function AddOwnerLabelsForKind should be of the form "AddOwnerLabelsForKind ..." (golint)
  • Line 302: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• operator-lifecycle-manager/test/e2e/ctx/ctx.go
  • Line 7: warning: should not use dot imports (golint)
  • Line 49: warning: exported method TestContext.Logf should have comment or be unexported (golint)
  • Line 56: warning: exported method TestContext.Scheme should have comment or be unexported (golint)
  • Line 60: warning: exported method TestContext.RESTConfig should have comment or be unexported (golint)
  • Line 64: warning: exported method TestContext.KubeClient should have comment or be unexported (golint)
  • Line 68: warning: exported method TestContext.OperatorClient should have comment or be unexported (golint)
  • Line 72: warning: exported method TestContext.DynamicClient should have comment or be unexported (golint)
  • Line 76: warning: exported method TestContext.PackageClient should have comment or be unexported (golint)
  • Line 80: warning: exported method TestContext.Client should have comment or be unexported (golint)
  • Line 84: warning: exported method TestContext.SSAClient should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/doc.go
  • Line 1: warning: package comment should be of the form "Package lib ..." (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/v1/register.go
  • Line 24: warning: exported const GroupName should have comment or be unexported (golint)
  • Line 36: warning: exported var AddToScheme should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/rule_checker.go
  • Line 76: warning: exported method CSVRuleChecker.GetRole should have comment or be unexported (golint)
  • Line 91: warning: exported method CSVRuleChecker.ListRoleBindings should have comment or be unexported (golint)
  • Line 109: warning: exported method CSVRuleChecker.GetClusterRole should have comment or be unexported (golint)
  • Line 124: warning: exported method CSVRuleChecker.ListClusterRoleBindings should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/types.go
  • Line 6: warning: exported const ConfigMapCRDName should have comment (or a comment on this block) or be unexported (golint)
  • Line 12: warning: exported type CatalogKey should have comment or be unexported (golint)
  • Line 21: warning: exported method CatalogKey.Empty should have comment or be unexported (golint)
  • Line 25: warning: exported method CatalogKey.Equal should have comment or be unexported (golint)
  • Line 34: warning: exported function NewVirtualCatalogKey should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/plugin/pkg/auth/authorizer/rbac/rbac.go
  • Line 36: warning: exported type RequestToRuleMapper should have comment or be unexported (golint)
  • Line 49: warning: exported type RBACAuthorizer should have comment or be unexported (golint)
  • Line 74: warning: exported method RBACAuthorizer.Authorize should have comment or be unexported (golint)
  • Line 128: warning: exported method RBACAuthorizer.RulesFor should have comment or be unexported (golint)
  • Line 158: warning: exported function New should have comment or be unexported (golint)
  • Line 167: warning: exported function RulesAllow should have comment or be unexported (golint)
  • Line 177: warning: exported function RuleAllows should have comment or be unexported (golint)
  • Line 194: warning: exported type RoleGetter should have comment or be unexported (golint)
  • Line 198: warning: exported method RoleGetter.GetRole should have comment or be unexported (golint)
  • Line 202: warning: exported type RoleBindingLister should have comment or be unexported (golint)
  • Line 206: warning: exported method RoleBindingLister.ListRoleBindings should have comment or be unexported (golint)
  • Line 210: warning: exported type ClusterRoleGetter should have comment or be unexported (golint)
  • Line 214: warning: exported method ClusterRoleGetter.GetClusterRole should have comment or be unexported (golint)
  • Line 218: warning: exported type ClusterRoleBindingLister should have comment or be unexported (golint)
  • Line 222: warning: exported method ClusterRoleBindingLister.ListClusterRoleBindings should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/queueinformer/resourcequeue.go
  • Line 38: warning: exported method ResourceQueueSet.RequeueEvent should have comment or be unexported (golint)
  • Line 77: warning: comment on exported method ResourceQueueSet.RequeueAfter should be of the form "RequeueAfter ..." (golint)

• operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
  • Line 28: warning: exported const CatalogSourceUpdateKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported type UpdateNotReadyErr should have comment or be unexported (golint)
  • Line 131: warning: exported type GrpcRegistryReconciler should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/install/certresources.go
  • Line 40: warning: comment on exported const KubeSystem should be of the form "KubeSystem ..." (golint)
  • Line 147: warning: exported function SecretName should have comment or be unexported (golint)
  • Line 151: warning: exported function ServiceName should have comment or be unexported (golint)
  • Line 214: warning: exported function ShouldRotateCerts should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/crd/unmarshal.go
  • Line 15: warning: exported const Kind should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: comment on exported function UnmarshalV1Beta1 should be of the form "UnmarshalV1Beta1 ..." (golint)

• operator-lifecycle-manager/pkg/lib/controller-runtime/client/ssa.go
  • Line 22: warning: exported type Object should have comment or be unexported (golint)
  • Line 27: warning: exported function NewForConfig should have comment or be unexported (golint)
  • Line 57: warning: exported function SetDefaultGroupVersionKind should have comment or be unexported (golint)
  • Line 76: warning: exported type ServerSideApplier should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/v1/helpers.go
  • Line 38: warning: exported function NewRule should have comment or be unexported (golint)
  • Line 44: warning: exported method PolicyRuleBuilder.Groups should have comment or be unexported (golint)
  • Line 49: warning: exported method PolicyRuleBuilder.Resources should have comment or be unexported (golint)
  • Line 54: warning: exported method PolicyRuleBuilder.Names should have comment or be unexported (golint)
  • Line 59: warning: exported method PolicyRuleBuilder.URLs should have comment or be unexported (golint)
  • Line 64: warning: exported method PolicyRuleBuilder.RuleOrDie should have comment or be unexported (golint)
  • Line 72: warning: exported method PolicyRuleBuilder.Rule should have comment or be unexported (golint)
  • Line 111: warning: exported function NewClusterBinding should have comment or be unexported (golint)
  • Line 124: warning: exported method ClusterRoleBindingBuilder.Groups should have comment or be unexported (golint)
  • Line 131: warning: exported method ClusterRoleBindingBuilder.Users should have comment or be unexported (golint)
  • Line 138: warning: exported method ClusterRoleBindingBuilder.SAs should have comment or be unexported (golint)
  • Line 145: warning: exported method ClusterRoleBindingBuilder.BindingOrDie should have comment or be unexported (golint)
  • Line 153: warning: exported method ClusterRoleBindingBuilder.Binding should have comment or be unexported (golint)
  • Line 189: warning: exported function NewRoleBindingForClusterRole should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/secret.go
  • Line 14: warning: exported type UnionSecretLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionSecretLister.RegisterSecretLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/queueinformer/loop_id.go
  • Line 8: warning: exported function NewLoopID should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/errors/errors.go
  • Line 13: warning: exported type UnadoptableError should have comment or be unexported (golint)
  • Line 25: warning: exported function NewUnadoptableError should have comment or be unexported (golint)
  • Line 33: warning: exported function NewMultipleExistingCRDOwnersError should have comment or be unexported (golint)
  • Line 41: warning: exported function IsMultipleExistingCRDOwnersError should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/registry_client.go
  • Line 1: warning: package comment should be of the form "Package registry ..." (golint)

• operator-lifecycle-manager/pkg/controller/operators/openshift/synctracker.go
  • Line 12: warning: exported function NewSyncTracker should have comment or be unexported (golint)
  • Line 20: warning: exported type SyncTracker should have comment or be unexported (golint)
  • Line 30: warning: exported method SyncTracker.Start should have comment or be unexported (golint)
  • Line 62: warning: exported method SyncTracker.Events should have comment or be unexported (golint)
  • Line 76: warning: exported method SyncTracker.TotalSyncs should have comment or be unexported (golint)
  • Line 83: warning: exported method SyncTracker.SuccessfulSyncs should have comment or be unexported (golint)

• operator-lifecycle-manager/test/e2e/ctx/must.go
  • Line 3: warning: exported function MustProvision should have comment or be unexported (golint)
  • Line 11: warning: exported function MustInstall should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/certs/certs.go
  • Line 18: warning: exported type CertGenerator should have comment or be unexported (golint)
  • Line 22: warning: exported type CertGeneratorFunc should have comment or be unexported (golint)
  • Line 24: warning: exported method CertGeneratorFunc.Generate should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/crd/version.go
  • Line 11: warning: comment on exported const V1Beta1Version should be of the form "V1Beta1Version ..." (golint)
  • Line 14: warning: comment on exported const V1Version should be of the form "V1Version ..." (golint)

• operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
  • Line 1: warning: package comment should be of the form "Package reconciler ..." (golint)
  • Line 163: warning: exported type ConfigMapRegistryReconciler should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/role.go
  • Line 14: warning: exported type UnionRoleLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionRoleLister.RegisterRoleLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/catalog/operator.go
  • Line 80: warning: exported const RegistryFieldManager should have comment (or a comment on this block) or be unexported (golint)
  • Line 113: warning: exported type CatalogSourceSyncFunc should have comment or be unexported (golint)
  • Line 641: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1185: warning: exported type UnpackedBundleReference should have comment or be unexported (golint)
  • Line 2210: warning: exported const PrometheusRuleKind should have comment (or a comment on this block) or be unexported (golint)

• operator-lifecycle-manager/pkg/api/client/util.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• operator-lifecycle-manager/pkg/lib/controller-runtime/client/fake_ssa.go
  • Line 12: warning: comment on exported function NewFakeApplier should be of the form "NewFakeApplier ..." (golint)

• operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go
  • Line 1: warning: package comment should be of the form "Package reconciler ..." (golint)
  • Line 95: warning: exported function Pod should have comment or be unexported (golint)

• operator-lifecycle-manager/test/e2e/dsl/dsl.go
  • Line 6: warning: should not use dot imports (golint)

• operator-lifecycle-manager/pkg/controller/operators/operatorconditiongenerator_controller.go
  • Line 90: warning: exported method OperatorConditionGeneratorReconciler.Reconcile should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/util/labels/labels.go
  • Line 23: warning: comment on exported function CloneAndAddLabel should be of the form "CloneAndAddLabel ..." (golint)
  • Line 68: warning: comment on exported function CloneSelectorAndAddLabel should be of the form "CloneSelectorAndAddLabel ..." (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/deployment.go
  • Line 14: warning: exported type UnionDeploymentLister should have comment or be unexported (golint)
  • Line 61: warning: exported method UnionDeploymentLister.RegisterDeploymentLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/operatorlister/installplan.go
  • Line 15: warning: exported type UnionInstallPlanLister should have comment or be unexported (golint)
  • Line 62: warning: exported method UnionInstallPlanLister.RegisterInstallPlanLister should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/apiserver/config.go
  • Line 55: warning: exported type PackageManifestServer should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/package-server/provider/interfaces.go
  • Line 8: warning: exported type PackageManifestProvider should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/registry/resolver/groups.go
  • Line 1: warning: package comment should be of the form "Package resolver ..." (golint)
  • Line 10: warning: exported type NamespaceSet should have comment or be unexported (golint)
  • Line 12: warning: exported function NewNamespaceSet should have comment or be unexported (golint)
  • Line 26: warning: exported method NamespaceSet.Peek should have comment or be unexported (golint)
  • Line 34: warning: exported method NamespaceSet.Intersection should have comment or be unexported (golint)
  • Line 59: warning: exported method NamespaceSet.Union should have comment or be unexported (golint)
  • Line 77: warning: exported method NamespaceSet.Contains should have comment or be unexported (golint)
  • Line 85: warning: exported method NamespaceSet.IsAllNamespaces should have comment or be unexported (golint)
  • Line 92: warning: exported type OperatorGroupSurface should have comment or be unexported (golint)
  • Line 102: warning: exported type OperatorGroup should have comment or be unexported (golint)
  • Line 109: warning: exported function NewOperatorGroup should have comment or be unexported (golint)
  • Line 126: warning: exported function NewOperatorGroupSurfaces should have comment or be unexported (golint)
  • Line 135: warning: exported method OperatorGroup.Identifier should have comment or be unexported (golint)
  • Line 139: warning: exported method OperatorGroup.Namespace should have comment or be unexported (golint)
  • Line 143: warning: exported method OperatorGroup.Targets should have comment or be unexported (golint)
  • Line 147: warning: exported method OperatorGroup.ProvidedAPIs should have comment or be unexported (golint)
  • Line 151: warning: exported method OperatorGroup.GroupIntersection should have comment or be unexported (golint)
  • Line 167: warning: exported type APIReconciliationResult should have comment or be unexported (golint)
  • Line 170: warning: exported const RemoveAPIs should have comment (or a comment on this block) or be unexported (golint)
  • Line 176: warning: exported type APIIntersectionReconciler should have comment or be unexported (golint)
  • Line 180: warning: exported type APIIntersectionReconcileFunc should have comment or be unexported (golint)
  • Line 182: warning: exported method APIIntersectionReconcileFunc.Reconcile should have comment or be unexported (golint)
  • Line 186: warning: exported function ReconcileAPIIntersection should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/olm/config.go
  • Line 22: warning: exported type OperatorOption should have comment or be unexported (golint)
  • Line 92: warning: exported function WithResyncPeriod should have comment or be unexported (golint)
  • Line 98: warning: exported function WithOperatorNamespace should have comment or be unexported (golint)
  • Line 104: warning: exported function WithWatchedNamespaces should have comment or be unexported (golint)
  • Line 110: warning: exported function WithLogger should have comment or be unexported (golint)
  • Line 116: warning: exported function WithClock should have comment or be unexported (golint)
  • Line 122: warning: exported function WithOperatorClient should have comment or be unexported (golint)
  • Line 128: warning: exported function WithExternalClient should have comment or be unexported (golint)
  • Line 134: warning: exported function WithStrategyResolver should have comment or be unexported (golint)
  • Line 140: warning: exported function WithAPIReconciler should have comment or be unexported (golint)
  • Line 146: warning: exported function WithAPILabeler should have comment or be unexported (golint)
  • Line 152: warning: exported function WithRestConfig should have comment or be unexported (golint)
  • Line 158: warning: exported function WithConfigClient should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/apis/rbac/helpers.go
  • Line 27: warning: exported function ResourceMatches should have comment or be unexported (golint)
  • Line 55: warning: comment on exported function SubjectsStrings should be of the form "SubjectsStrings ..." (golint)
  • Line 113: warning: comment on exported type PolicyRuleBuilder should be of the form "PolicyRuleBuilder ..." (with optional leading article) (golint)
  • Line 121: warning: exported function NewRule should have comment or be unexported (golint)
  • Line 127: warning: exported method PolicyRuleBuilder.Groups should have comment or be unexported (golint)
  • Line 132: warning: exported method PolicyRuleBuilder.Resources should have comment or be unexported (golint)
  • Line 137: warning: exported method PolicyRuleBuilder.Names should have comment or be unexported (golint)
  • Line 142: warning: exported method PolicyRuleBuilder.URLs should have comment or be unexported (golint)
  • Line 147: warning: exported method PolicyRuleBuilder.RuleOrDie should have comment or be unexported (golint)
  • Line 161: warning: exported method PolicyRuleBuilder.Rule should have comment or be unexported (golint)
  • Line 201: warning: comment on exported type ClusterRoleBindingBuilder should be of the form "ClusterRoleBindingBuilder ..." (with optional leading article) (golint)
  • Line 209: warning: exported function NewClusterBinding should have comment or be unexported (golint)
  • Line 222: warning: exported method ClusterRoleBindingBuilder.Groups should have comment or be unexported (golint)
  • Line 229: warning: exported method ClusterRoleBindingBuilder.Users should have comment or be unexported (golint)
  • Line 236: warning: exported method ClusterRoleBindingBuilder.SAs should have comment or be unexported (golint)
  • Line 243: warning: exported method ClusterRoleBindingBuilder.BindingOrDie should have comment or be unexported (golint)
  • Line 251: warning: exported method ClusterRoleBindingBuilder.Binding should have comment or be unexported (golint)
  • Line 259: warning: comment on exported type RoleBindingBuilder should be of the form "RoleBindingBuilder ..." (with optional leading article) (golint)
  • Line 286: warning: exported function NewRoleBindingForClusterRole should have comment or be unexported (golint)
  • Line 346: warning: exported type SortableRuleSlice should have comment or be unexported (golint)

• operator-lifecycle-manager/pkg/controller/operators/openshift/clusteroperator_controller.go
  • Line 32: warning: exported type ClusterOperatorReconciler should have comment or be unexported (golint)
  • Line 41: warning: exported function NewClusterOperatorReconciler should have comment or be unexported (golint)
  • Line 72: warning: exported method ClusterOperatorReconciler.SetupWithManager should have comment or be unexported (golint)
  • Line 84: warning: exported method ClusterOperatorReconciler.Reconcile should have comment or be unexported (golint)
  • Line 212: warning: exported const IncompatibleOperatorsInstalled should have comment (or a comment on this block) or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• operator-lifecycle-manager/test/e2e/csv_e2e_test.go
  • Line 1701: warning: ineffectual assignment to fetchedCSV (ineffassign)

• operator-lifecycle-manager/test/e2e/webhook_e2e_test.go
  • Line 519: warning: ineffectual assignment to og (ineffassign)
  • Line 775: warning: ineffectual assignment to og (ineffassign)
  • Line 835: warning: ineffectual assignment to err (ineffassign)
  • Line 838: warning: ineffectual assignment to err (ineffassign)
  • Line 898: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscription/state.go
  • Line 245: warning: ineffectual assignment to healthy (ineffassign)
  • Line 275: warning: ineffectual assignment to healthy (ineffassign)

• operator-lifecycle-manager/pkg/lib/kubernetes/pkg/registry/rbac/validation/policy_comparator.go
  • Line 164: warning: ineffectual assignment to resourceNameMatches (ineffassign)

• operator-lifecycle-manager/pkg/controller/operators/catalog/operator.go
  • Line 750: warning: ineffectual assignment to cont (ineffassign)

• operator-lifecycle-manager/pkg/controller/operators/catalog/operator_test.go
  • Line 1495: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/pkg/controller/operators/olm/operatorgroup.go
  • Line 344: warning: ineffectual assignment to err (ineffassign)
  • Line 945: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/pkg/controller/operators/catalog/subscriptions_test.go
  • Line 1056: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/pkg/package-server/provider/registry_test.go
  • Line 52: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/test/e2e/installplan_e2e_test.go
  • Line 1878: warning: ineffectual assignment to err (ineffassign)

• operator-lifecycle-manager/test/e2e/subscription_e2e_test.go
  • Line 598: warning: ineffectual assignment to err (ineffassign)
  • Line 599: warning: ineffectual assignment to err (ineffassign)
  • Line 1302: warning: ineffectual assignment to expected (ineffassign)
  • Line 2643: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• operator-lifecycle-manager/test/e2e/operator_groups_e2e_test.go
  • Line 1317: warning: "depedencies" is a misspelling of "dependencies" (misspell)
  • Line 1687: warning: "succeeed" is a misspelling of "succeed" (misspell)
  • Line 1785: warning: "succeeed" is a misspelling of "succeed" (misspell)

• operator-lifecycle-manager/pkg/lib/controller-runtime/client/ssa.go
  • Line 86: warning: "asyncronous" is a misspelling of "asynchronous" (misspell)

• operator-lifecycle-manager/pkg/metrics/metrics.go
  • Line 194: warning: "promethues" is a misspelling of "prometheus" (misspell)

• operator-lifecycle-manager/pkg/controller/operators/catalog/step.go
  • Line 164: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 243: warning: "occured" is a misspelling of "occurred" (misspell)

• operator-lifecycle-manager/pkg/controller/operators/openshift/clusteroperator_controller_test.go
  • Line 86: warning: "initally" is a misspelling of "initially" (misspell)

• operator-lifecycle-manager/pkg/lib/comparison/equal_test.go
  • Line 252: warning: "symetry" is a misspelling of "symmetry" (misspell)

• operator-lifecycle-manager/pkg/controller/operators/olm/operator_test.go
  • Line 106: warning: "strat" is a misspelling of "start" (misspell)

• operator-lifecycle-manager/test/e2e/operator_test.go
  • Line 455: warning: "nto" is a misspelling of "not" (misspell)
  • Line 463: warning: "nto" is a misspelling of "not" (misspell)

• operator-lifecycle-manager/test/e2e/subscription_e2e_test.go
  • Line 661: warning: "exising" is a misspelling of "existing" (misspell)
  • Line 700: warning: "targetting" is a misspelling of "targeting" (misspell)
  • Line 964: warning: "comparision" is a misspelling of "comparison" (misspell)
  • Line 1045: warning: "comparision" is a misspelling of "comparison" (misspell)