Preparing report...

Report for github.com/oracle/speedle

A    Great!    Found 95 issues across 139 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo78%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • speedle/pkg/eval/evaluator.go
    • Line 918: warning: cyclomatic complexity 25 of function (*PolicyEvalImpl).syncRuntimeCache() is high (> 15) (gocyclo)
    • Line 464: warning: cyclomatic complexity 25 of function (*PolicyEvalImpl).getGrantedRolesFromService() is high (> 15) (gocyclo)
    • Line 1081: warning: cyclomatic complexity 19 of function (*PolicyEvalImpl).updateRuntimeCacheWithStoreChange() is high (> 15) (gocyclo)
    • Line 139: warning: cyclomatic complexity 18 of function (*PolicyEvalImpl).populateContext() is high (> 15) (gocyclo)
    • Line 865: warning: cyclomatic complexity 17 of function (*PolicyEvalImpl).getPolicyList() is high (> 15) (gocyclo)
    • Line 406: warning: cyclomatic complexity 16 of function (*PolicyEvalImpl).getDirectRolePolicesInService() is high (> 15) (gocyclo)
    • speedle/pkg/cmd/flags/params.go
    • Line 165: warning: cyclomatic complexity 133 of function (*Parameters).ParseFlags() is high (> 15) (gocyclo)
    • Line 482: warning: cyclomatic complexity 47 of function (*Parameters).Param2Config() is high (> 15) (gocyclo)
    • speedle/pkg/store/etcd/etcdStore_test.go
    • Line 535: warning: cyclomatic complexity 28 of function TestCheckItemsCount() is high (> 15) (gocyclo)
    • Line 156: warning: cyclomatic complexity 23 of function TestEtcdStore_GetPolicyByName() is high (> 15) (gocyclo)
    • Line 295: warning: cyclomatic complexity 23 of function TestEtcdStore_GetRolePolicyByName() is high (> 15) (gocyclo)

golint42%

Golint is a linter for Go source code.

    • speedle/pkg/store/discover.go
    • Line 15: warning: exported const DefaultMaxDiscoverRequestNum should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported var DeleteNumWhenReachMaxDiscoverRequest should have its own declaration (golint)
    • Line 26: warning: exported type DiscoverRequestManager should have comment or be unexported (golint)
    • Line 41: warning: exported function GeneratePoliciesFromDiscoverRequests should have comment or be unexported (golint)
    • speedle/pkg/httputils/utils.go
    • Line 16: warning: exported type ErrorResponse should have comment or be unexported (golint)
    • Line 40: warning: exported function HandleError should have comment or be unexported (golint)
    • Line 47: warning: exported function SendBadRequestResponse should have comment or be unexported (golint)
    • Line 51: warning: exported function SendInternalErrorResponse should have comment or be unexported (golint)
    • Line 55: warning: exported function SendBasicAtzErrorResponse should have comment or be unexported (golint)
    • Line 84: warning: exported function SendBearerAtzErrorResponse should have comment or be unexported (golint)
    • Line 110: warning: exported function SendPageNotFoundResponse should have comment or be unexported (golint)
    • Line 114: warning: exported function SendEmptyListResponse should have comment or be unexported (golint)
    • Line 120: warning: exported function SendResponse should have comment or be unexported (golint)
    • Line 132: warning: exported function SendCreatedResponse should have comment or be unexported (golint)
    • Line 136: warning: exported function SendOKResponse should have comment or be unexported (golint)
    • speedle/pkg/eval/basepolicycache.go
    • Line 14: warning: comment on exported var Prefix_Pattern should be of the form "Prefix_Pattern ..." (golint)
    • Line 16: warning: don't use underscores in Go names; var Prefix_Pattern should be PrefixPattern (golint)
    • Line 17: warning: don't use underscores in Go names; var Suffix_Pattern should be SuffixPattern (golint)
    • Line 17: warning: exported var Suffix_Pattern should have comment or be unexported (golint)
    • Line 18: warning: don't use underscores in Go names; var All_Pattern should be AllPattern (golint)
    • Line 18: warning: exported var All_Pattern should have comment or be unexported (golint)
    • Line 20: warning: exported type ResourceToPolicyMap should have comment or be unexported (golint)
    • Line 64: warning: exported type BasePolicyCacheData should have comment or be unexported (golint)
    • Line 95: warning: exported function ReverseString should have comment or be unexported (golint)
    • Line 103: warning: exported function AddPolicyToResourceExpressionCache should have comment or be unexported (golint)
    • Line 187: warning: exported function DeletePolicyFromResourceExpressionCache should have comment or be unexported (golint)
    • speedle/pkg/cfg/config.go
    • Line 16: warning: exported const StorageTypeFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type StoreConfig should have comment or be unexported (golint)
    • Line 24: warning: exported type ServerConfig should have comment or be unexported (golint)
    • Line 34: warning: exported type Config should have comment or be unexported (golint)
    • Line 44: warning: exported function ReadConfig should have comment or be unexported (golint)
    • Line 58: warning: exported function ReadStoreConfig should have comment or be unexported (golint)
    • speedle/testutil/param/param.go
    • Line 10: warning: exported function CREATE_SERVICE should have comment or be unexported (golint)
    • Line 14: warning: exported function CREATE_SERVICE_WITH_FLAG should have comment or be unexported (golint)
    • Line 18: warning: exported function CREATE_SERVICE_WITH_JSONFILE should have comment or be unexported (golint)
    • Line 22: warning: exported function CREATE_SERVICE_WITH_PDLFILE should have comment or be unexported (golint)
    • Line 26: warning: exported function GET_SERVICE should have comment or be unexported (golint)
    • Line 30: warning: exported function GET_SERVICE_ALL should have comment or be unexported (golint)
    • Line 34: warning: exported function DELETE_SERVICE should have comment or be unexported (golint)
    • Line 38: warning: exported function DELETE_POLICY should have comment or be unexported (golint)
    • Line 42: warning: exported function DELETE_ROLEPOLICY should have comment or be unexported (golint)
    • Line 46: warning: exported function CREATE_POLICY should have comment or be unexported (golint)
    • Line 50: warning: exported function CREATE_ROLEPOLICY should have comment or be unexported (golint)
    • Line 54: warning: exported function GET_POLICY should have comment or be unexported (golint)
    • Line 58: warning: exported function GET_ROLEPOLICY should have comment or be unexported (golint)
    • Line 62: warning: exported function GET_POLICY_ALL should have comment or be unexported (golint)
    • Line 66: warning: exported function GET_ROLEPOLICY_ALL should have comment or be unexported (golint)
    • Line 70: warning: exported function CREATE_POLICY_WITH_FLAG should have comment or be unexported (golint)
    • Line 74: warning: exported function CREATE_POLICY_VIA_FILE should have comment or be unexported (golint)
    • Line 78: warning: exported function CREATE_POLICY_VIA_FILE_WITH_FLAG should have comment or be unexported (golint)
    • speedle/pkg/store/file/storeBuider.go
    • Line 18: warning: exported const StoreType should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: comment on exported const FileLocationKey should be of the form "FileLocationKey ..." (golint)
    • Line 28: warning: exported type FileStoreBuilder should have comment or be unexported (golint)
    • Line 30: warning: exported method FileStoreBuilder.NewStore should have comment or be unexported (golint)
    • Line 45: warning: exported method FileStoreBuilder.GetStoreParams should have comment or be unexported (golint)
    • speedle/pkg/logging/auditLog.go
    • Line 14: warning: don't use underscores in Go names; const Response_Succeeded should be ResponseSucceeded (golint)
    • Line 14: warning: exported const Response_Succeeded should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: don't use underscores in Go names; const Response_Failed should be ResponseFailed (golint)
    • Line 17: warning: don't use underscores in Go names; const Request_default_key should be RequestDefaultKey (golint)
    • Line 18: warning: don't use underscores in Go names; const Response_default_key should be ResponseDefaultKey (golint)
    • Line 20: warning: don't use underscores in Go names; const Audit_Prefix should be AuditPrefix (golint)
    • Line 22: warning: don't use underscores in Go names; const TenantID_key should be TenantIDKey (golint)
    • Line 23: warning: don't use underscores in Go names; const Target_Index_Key should be TargetIndexKey (golint)
    • Line 32: warning: exported function SetTenantID should have comment or be unexported (golint)
    • Line 41: warning: exported function AuditLog should have comment or be unexported (golint)
    • Line 45: warning: comment on exported function InitAuditLog should be of the form "InitAuditLog ..." (golint)
    • Line 50: warning: comment on exported function WriteSimpleSucceededAuditLog should be of the form "WriteSimpleSucceededAuditLog ..." (golint)
    • Line 69: warning: comment on exported function WriteSimpleFailedAuditLog should be of the form "WriteSimpleFailedAuditLog ..." (golint)
    • Line 82: warning: comment on exported function WriteSucceededAuditLog should be of the form "WriteSucceededAuditLog ..." (golint)
    • Line 94: warning: comment on exported function WriteFailedAuditLog should be of the form "WriteFailedAuditLog ..." (golint)
    • speedle/pkg/store/file/discover.go
    • Line 26: warning: exported type RequestItem should have comment or be unexported (golint)
    • Line 31: warning: exported type StoreContent should have comment or be unexported (golint)
    • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 201: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 259: warning: comment on exported method Store.GeneratePolicies should be of the form "GeneratePolicies ..." (golint)
    • Line 263: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • speedle/pkg/svcs/pmsrest/manager.go
    • Line 26: warning: exported type RESTService should have comment or be unexported (golint)
    • Line 35: warning: exported function NewRestService should have comment or be unexported (golint)
    • Line 39: warning: comment on exported function ParseRequestURI should be of the form "ParseRequestURI ..." (golint)
    • Line 99: warning: comment on exported method RESTService.CreateService should be of the form "CreateService ..." (golint)
    • Line 144: warning: exported method RESTService.DeleteService should have comment or be unexported (golint)
    • Line 163: warning: exported method RESTService.DeleteServices should have comment or be unexported (golint)
    • Line 174: warning: exported method RESTService.GetService should have comment or be unexported (golint)
    • Line 194: warning: exported method RESTService.ListServices should have comment or be unexported (golint)
    • Line 211: warning: exported method RESTService.ListPolicyAndRolePolicyCounts should have comment or be unexported (golint)
    • Line 223: warning: comment on exported method RESTService.CreatePolicy should be of the form "CreatePolicy ..." (golint)
    • Line 264: warning: exported method RESTService.DeletePolicies should have comment or be unexported (golint)
    • Line 283: warning: exported method RESTService.DeletePolicy should have comment or be unexported (golint)
    • Line 308: warning: exported method RESTService.GetPolicy should have comment or be unexported (golint)
    • Line 334: warning: exported method RESTService.ListPolicies should have comment or be unexported (golint)
    • Line 358: warning: comment on exported method RESTService.CreateRolePolicy should be of the form "CreateRolePolicy ..." (golint)
    • Line 398: warning: exported method RESTService.DeleteRolePolicies should have comment or be unexported (golint)
    • Line 417: warning: exported method RESTService.DeleteRolePolicy should have comment or be unexported (golint)
    • Line 442: warning: exported method RESTService.GetRolePolicy should have comment or be unexported (golint)
    • Line 468: warning: exported method RESTService.ListRolePolicies should have comment or be unexported (golint)
    • Line 494: warning: exported method RESTService.CreateFunction should have comment or be unexported (golint)
    • Line 521: warning: exported method RESTService.DeleteFunction should have comment or be unexported (golint)
    • Line 544: warning: exported method RESTService.DeleteFunctions should have comment or be unexported (golint)
    • Line 555: warning: exported method RESTService.GetFunction should have comment or be unexported (golint)
    • Line 578: warning: exported method RESTService.ListFunctions should have comment or be unexported (golint)
    • speedle/testutil/gcmd.go
    • Line 11: warning: comment on exported type Cmd should be of the form "Cmd ..." (with optional leading article) (golint)
    • Line 19: warning: comment on exported function Command should be of the form "Command ..." (golint)
    • Line 28: warning: comment on exported method Cmd.Run should be of the form "Run ..." (golint)
    • Line 45: warning: comment on exported method Cmd.Stdout should be of the form "Stdout ..." (golint)
    • Line 51: warning: comment on exported method Cmd.Stderr should be of the form "Stderr ..." (golint)
    • Line 56: warning: comment on exported method Cmd.Success should be of the form "Success ..." (golint)
    • speedle/api/pms/interface.go
    • Line 6: warning: exported type StoreManager should have comment or be unexported (golint)
    • Line 12: warning: exported type FunctionManager should have comment or be unexported (golint)
    • Line 21: warning: exported type ServiceManager should have comment or be unexported (golint)
    • Line 32: warning: exported type PolicyManager should have comment or be unexported (golint)
    • Line 41: warning: exported type RolePolicyManager should have comment or be unexported (golint)
    • Line 50: warning: exported type PolicyStoreWatcher should have comment or be unexported (golint)
    • Line 55: warning: exported type PolicyStoreManager should have comment or be unexported (golint)
    • Line 64: warning: exported type PolicyStoreManagerADS should have comment or be unexported (golint)
    • speedle/pkg/svcs/adsgrpc/impl.go
    • Line 77: warning: exported method GRPCService.IsAllowed should have comment or be unexported (golint)
    • Line 101: warning: exported method GRPCService.GetAllGrantedRoles should have comment or be unexported (golint)
    • Line 122: warning: exported method GRPCService.GetAllPermissions should have comment or be unexported (golint)
    • Line 151: warning: exported method GRPCService.Discover should have comment or be unexported (golint)
    • Line 326: warning: exported method GRPCService.Diagnose should have comment or be unexported (golint)
    • speedle/pkg/svcs/pmsimpl/systemLimitation.go
    • Line 14: warning: comment on exported var MaxServiceNum should be of the form "MaxServiceNum ..." (golint)
    • Line 16: warning: exported var MaxPolicyNum should have comment or be unexported (golint)
    • Line 21: warning: comment on exported function CheckService should be of the form "CheckService ..." (golint)
    • Line 70: warning: comment on exported function CheckPolicy should be of the form "CheckPolicy ..." (golint)
    • Line 104: warning: comment on exported function CheckRolePolicy should be of the form "CheckRolePolicy ..." (golint)
    • Line 161: warning: comment on exported function CheckFunction should be of the form "CheckFunction ..." (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/evaluationStage.go
    • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 57: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 67: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 180: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 353: warning: should omit 2nd value from range; this loop is equivalent to `for idx := range ...` (golint)
    • speedle/testutil/msg/output.go
    • Line 10: warning: exported function OUTPUT_SERVICE_CREATED should have comment or be unexported (golint)
    • Line 14: warning: exported function OUTPUT_SERVICE_DELETED should have comment or be unexported (golint)
    • Line 18: warning: exported function OUTPUT_POLICY_CREATED should have comment or be unexported (golint)
    • Line 22: warning: exported function OUTPUT_POLICY_DELETED should have comment or be unexported (golint)
    • Line 26: warning: exported function OUTPUT_ROLEPOLICY_CREATED should have comment or be unexported (golint)
    • Line 30: warning: exported function OUTPUT_ROLEPOLICY_DELETED should have comment or be unexported (golint)
    • Line 34: warning: exported function OUTPUT_POLICY_NOTFOUND should have comment or be unexported (golint)
    • Line 38: warning: exported function OUTPUT_ROLEPOLICY_NOTFOUND should have comment or be unexported (golint)
    • speedle/pkg/eval/evaluator_custom_function.go
    • Line 1: warning: package comment should be of the form "Package eval ..." (golint)
    • Line 29: warning: exported type Request2Delegator should have comment or be unexported (golint)
    • Line 34: warning: exported type FuncResult should have comment or be unexported (golint)
    • Line 39: warning: exported type FuncResultCache should have comment or be unexported (golint)
    • Line 61: warning: exported method FuncResultCache.AddToCache should have comment or be unexported (golint)
    • Line 75: warning: exported method FuncResultCache.ReadFromCache should have comment or be unexported (golint)
    • Line 88: warning: exported method FuncResultCache.DeleteFromCache should have comment or be unexported (golint)
    • Line 109: warning: exported method FuncResultCache.CleanExpiredResult should have comment or be unexported (golint)
    • Line 156: warning: exported function CallCustomerFunctionViaDelegator should have comment or be unexported (golint)
    • Line 178: warning: exported function CallCustomerFunction should have comment or be unexported (golint)
    • speedle/api/pms/types.go
    • Line 6: warning: exported type Permission should have comment or be unexported (golint)
    • Line 12: warning: exported type Function should have comment or be unexported (golint)
    • Line 23: warning: exported type Policy should have comment or be unexported (golint)
    • Line 34: warning: exported const Grant should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported const TypeK8SCluster should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type RolePolicy should have comment or be unexported (golint)
    • Line 55: warning: exported type Service should have comment or be unexported (golint)
    • Line 63: warning: exported const GlobalService should have comment or be unexported (golint)
    • Line 65: warning: exported type PolicyStore should have comment or be unexported (golint)
    • Line 70: warning: exported type PolicyAndRolePolicyCount should have comment or be unexported (golint)
    • Line 75: warning: exported type EventType should have comment or be unexported (golint)
    • Line 78: warning: exported const INVALID should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: exported type StoreChangeEvent should have comment or be unexported (golint)
    • Line 101: warning: exported type StoreUpdateData should have comment or be unexported (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/tokenStream.go
    • Line 19: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 23: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • speedle/pkg/eval/evaluator.go
    • Line 33: warning: exported type TokenAsserter should have comment or be unexported (golint)
    • Line 40: warning: exported type InternalEvaluator should have comment or be unexported (golint)
    • Line 63: warning: exported type PolicyEvalImpl should have comment or be unexported (golint)
    • Line 83: warning: exported method PolicyEvalImpl.Refresh should have comment or be unexported (golint)
    • Line 88: warning: exported method PolicyEvalImpl.AddServiceInRuntimeCache should have comment or be unexported (golint)
    • Line 92: warning: exported method PolicyEvalImpl.AddPolicyInRuntimeCache should have comment or be unexported (golint)
    • Line 96: warning: exported method PolicyEvalImpl.AddRolePolicyInRuntimeCache should have comment or be unexported (golint)
    • Line 100: warning: exported method PolicyEvalImpl.DeletePolicyInRuntimeCache should have comment or be unexported (golint)
    • Line 103: warning: exported method PolicyEvalImpl.DeleteRolePolicyInRuntimeCache should have comment or be unexported (golint)
    • Line 107: warning: exported method PolicyEvalImpl.DeleteFunctionInRuntimeCache should have comment or be unexported (golint)
    • Line 111: warning: exported method PolicyEvalImpl.AddFunctionInRuntimeCache should have comment or be unexported (golint)
    • Line 115: warning: exported method PolicyEvalImpl.CleanExpiredFunctionResult should have comment or be unexported (golint)
    • Line 119: warning: exported method PolicyEvalImpl.SetAsserterFunc should have comment or be unexported (golint)
    • Line 123: warning: exported method PolicyEvalImpl.AssertToken should have comment or be unexported (golint)
    • Line 237: warning: exported method PolicyEvalImpl.IsAllowed should have comment or be unexported (golint)
    • Line 242: warning: exported method PolicyEvalImpl.InternalIsAllowed should have comment or be unexported (golint)
    • Line 272: warning: comment on exported method PolicyEvalImpl.Diagnose should be of the form "Diagnose ..." (golint)
    • Line 291: warning: exported method PolicyEvalImpl.GetAllGrantedRoles should have comment or be unexported (golint)
    • Line 305: warning: comment on exported method PolicyEvalImpl.GetAllGrantedPermissions should be of the form "GetAllGrantedPermissions ..." (golint)
    • Line 423: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 451: warning: exported type Role should have comment or be unexported (golint)
    • Line 848: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 882: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 965: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 990: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1013: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • speedle/pkg/svcs/adsrest/check.go
    • Line 23: warning: exported type JsonAttribute should have comment or be unexported (golint)
    • Line 29: warning: exported type JsonPrincipal should have comment or be unexported (golint)
    • Line 35: warning: exported type JsonSubject should have comment or be unexported (golint)
    • Line 41: warning: exported type JsonContext should have comment or be unexported (golint)
    • Line 49: warning: exported type RESTService should have comment or be unexported (golint)
    • Line 53: warning: exported type IsAllowedResponse should have comment or be unexported (golint)
    • Line 59: warning: exported type AuditEvaluationResult should have comment or be unexported (golint)
    • Line 64: warning: exported type PermissionResponse should have comment or be unexported (golint)
    • Line 69: warning: exported type PolicyResponse should have comment or be unexported (golint)
    • Line 79: warning: exported type RolePolicyResponse should have comment or be unexported (golint)
    • Line 91: warning: exported type Permission should have comment or be unexported (golint)
    • Line 97: warning: exported type EvaluatedCondition should have comment or be unexported (golint)
    • Line 102: warning: comment on exported type EvaluationDebugResponse should be of the form "EvaluationDebugResponse ..." (with optional leading article) (golint)
    • Line 113: warning: exported function NewRESTService should have comment or be unexported (golint)
    • Line 123: warning: exported function NewRESTServiceWithEvaluator should have comment or be unexported (golint)
    • Line 129: warning: exported function DecodeJSONContext should have comment or be unexported (golint)
    • Line 138: warning: exported function DuplicateAttributeMap should have comment or be unexported (golint)
    • Line 149: warning: exported function VerifyAttributeName should have comment or be unexported (golint)
    • Line 169: warning: exported function ParseDateTime should have comment or be unexported (golint)
    • Line 180: warning: exported function ConvSingleValue should have comment or be unexported (golint)
    • Line 208: warning: exported function ConvMultipleValues should have comment or be unexported (golint)
    • Line 228: warning: exported function ConvValue should have comment or be unexported (golint)
    • Line 238: warning: exported function DumpRequestAttributes should have comment or be unexported (golint)
    • Line 258: warning: exported function DumpPrincipals should have comment or be unexported (golint)
    • Line 273: warning: exported function ConvertJSONRequestToContext should have comment or be unexported (golint)
    • Line 313: warning: exported method RESTService.IsAllowed should have comment or be unexported (golint)
    • Line 354: warning: exported method RESTService.GetAllGrantedRoles should have comment or be unexported (golint)
    • Line 385: warning: exported method RESTService.GetAllGrantedPermissions should have comment or be unexported (golint)
    • Line 424: warning: exported function ConvertAPIPolicy2PolicyResponse should have comment or be unexported (golint)
    • Line 456: warning: exported function ConvertAPIRolePolicy2RolePolicyResponse should have comment or be unexported (golint)
    • Line 479: warning: exported method RESTService.Diagnose should have comment or be unexported (golint)
    • speedle/pkg/store/etcd/etcdStore.go
    • Line 27: warning: exported const KeySeparator should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported type Store should have comment or be unexported (golint)
    • Line 56: warning: comment on exported method Store.ReadPolicyStore should be of the form "ReadPolicyStore ..." (golint)
    • Line 78: warning: comment on exported method Store.WritePolicyStore should be of the form "WritePolicyStore ..." (golint)
    • Line 99: warning: exported method Store.GetServiceNames should have comment or be unexported (golint)
    • Line 120: warning: exported method Store.GetPolicyAndRolePolicyCounts should have comment or be unexported (golint)
    • Line 149: warning: exported method Store.GetServiceCount should have comment or be unexported (golint)
    • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 162: warning: exported method Store.ListAllServices should have comment or be unexported (golint)
    • Line 177: warning: comment on exported method Store.GetServices should be of the form "GetServices ..." (golint)
    • Line 215: warning: exported method Store.GetServiceItself should have comment or be unexported (golint)
    • Line 240: warning: exported method Store.GetService should have comment or be unexported (golint)
    • Line 341: warning: exported method Store.CreateService should have comment or be unexported (golint)
    • Line 385: warning: comment on exported method Store.DeleteService should be of the form "DeleteService ..." (golint)
    • Line 403: warning: exported method Store.DeleteServices should have comment or be unexported (golint)
    • Line 415: warning: comment on exported method Store.Type should be of the form "Type ..." (golint)
    • Line 427: warning: exported method Store.CreateFunction should have comment or be unexported (golint)
    • Line 452: warning: exported method Store.DeleteFunction should have comment or be unexported (golint)
    • Line 470: warning: exported method Store.DeleteFunctions should have comment or be unexported (golint)
    • Line 482: warning: exported method Store.GetFunction should have comment or be unexported (golint)
    • Line 501: warning: exported method Store.ListAllFunctions should have comment or be unexported (golint)
    • Line 530: warning: exported method Store.GetFunctionCount should have comment or be unexported (golint)
    • Line 546: warning: exported method Store.Watch should have comment or be unexported (golint)
    • Line 668: warning: exported method Store.StopWatch should have comment or be unexported (golint)
    • Line 674: warning: comment on exported method Store.ListAllPolicies should be of the form "ListAllPolicies ..." (golint)
    • Line 704: warning: exported method Store.GetPolicyCount should have comment or be unexported (golint)
    • Line 709: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 743: warning: exported method Store.GetPolicy should have comment or be unexported (golint)
    • Line 762: warning: comment on exported method Store.GetRolePolicies should be of the form "GetRolePolicies ..." (golint)
    • Line 798: warning: exported method Store.DeletePolicy should have comment or be unexported (golint)
    • Line 818: warning: exported method Store.DeletePolicies should have comment or be unexported (golint)
    • Line 832: warning: exported method Store.CreatePolicy should have comment or be unexported (golint)
    • Line 864: warning: comment on exported method Store.ListAllRolePolicies should be of the form "ListAllRolePolicies ..." (golint)
    • Line 892: warning: exported method Store.GetRolePolicyCount should have comment or be unexported (golint)
    • Line 897: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 931: warning: comment on exported method Store.GetPolicies should be of the form "GetPolicies ..." (golint)
    • Line 966: warning: exported method Store.GetRolePolicy should have comment or be unexported (golint)
    • Line 985: warning: exported method Store.DeleteRolePolicy should have comment or be unexported (golint)
    • Line 1005: warning: exported method Store.DeleteRolePolicies should have comment or be unexported (golint)
    • Line 1019: warning: exported method Store.CreateRolePolicy should have comment or be unexported (golint)
    • Line 1075: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • speedle/pkg/store/store.go
    • Line 19: warning: exported type StoreBuilder should have comment or be unexported (golint)
    • Line 58: warning: comment on exported function GetAllStoreParams should be of the form "GetAllStoreParams ..." (golint)
    • Line 72: warning: exported function NewStore should have comment or be unexported (golint)
    • speedle/cmd/spctl/pdl/pdl.go
    • Line 24: warning: don't use underscores in Go names; const res_expr_prefix should be resExprPrefix (golint)
    • Line 27: warning: exported function ParsePolicy should have comment or be unexported (golint)
    • Line 59: warning: exported function ParseRolePolicy should have comment or be unexported (golint)
    • Line 345: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 354: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • speedle/api/ads/evaluation_result.go
    • Line 1: warning: package comment should be of the form "Package ads ..." (golint)
    • Line 11: warning: exported method EvaluationResult.AddRolePolicy should have comment or be unexported (golint)
    • Line 17: warning: exported method EvaluationResult.AddPolicy should have comment or be unexported (golint)
    • Line 23: warning: exported method EvaluationResult.AddPolicies should have comment or be unexported (golint)
    • speedle/pkg/store/file/fileStore.go
    • Line 22: warning: exported type Store should have comment or be unexported (golint)
    • Line 177: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 307: warning: exported method Store.Watch should have comment or be unexported (golint)
    • Line 371: warning: exported method Store.StopWatch should have comment or be unexported (golint)
    • Line 377: warning: exported method Store.Type should have comment or be unexported (golint)
    • Line 381: warning: comment on exported method Store.ListAllPolicies should be of the form "ListAllPolicies ..." (golint)
    • Line 405: warning: exported method Store.GetPolicyCount should have comment or be unexported (golint)
    • Line 418: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 444: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 449: warning: exported method Store.GetPolicy should have comment or be unexported (golint)
    • Line 468: warning: exported method Store.DeletePolicy should have comment or be unexported (golint)
    • Line 488: warning: exported method Store.DeletePolicies should have comment or be unexported (golint)
    • Line 504: warning: exported method Store.CreatePolicy should have comment or be unexported (golint)
    • Line 523: warning: comment on exported method Store.ListAllRolePolicies should be of the form "ListAllRolePolicies ..." (golint)
    • Line 547: warning: exported method Store.GetRolePolicyCount should have comment or be unexported (golint)
    • Line 560: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 586: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 591: warning: exported method Store.GetRolePolicy should have comment or be unexported (golint)
    • Line 610: warning: exported method Store.DeleteRolePolicy should have comment or be unexported (golint)
    • Line 629: warning: exported method Store.DeleteRolePolicies should have comment or be unexported (golint)
    • Line 643: warning: exported method Store.CreateRolePolicy should have comment or be unexported (golint)
    • Line 669: warning: exported method Store.CreateFunction should have comment or be unexported (golint)
    • Line 695: warning: exported method Store.DeleteFunction should have comment or be unexported (golint)
    • Line 713: warning: exported method Store.DeleteFunctions should have comment or be unexported (golint)
    • Line 725: warning: exported method Store.GetFunction should have comment or be unexported (golint)
    • Line 741: warning: exported method Store.ListAllFunctions should have comment or be unexported (golint)
    • Line 763: warning: exported method Store.GetFunctionCount should have comment or be unexported (golint)
    • Line 773: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 806: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • speedle/pkg/svcs/pmsrest/discover.go
    • Line 21: warning: exported type GetDiscoverRequestsResponse should have comment or be unexported (golint)
    • Line 26: warning: exported type GetDiscoverPoliciesResponse should have comment or be unexported (golint)
    • Line 31: warning: exported method RESTService.GetAllDiscoverRequests should have comment or be unexported (golint)
    • Line 105: warning: exported method RESTService.GetDiscoverRequests should have comment or be unexported (golint)
    • Line 185: warning: exported method RESTService.ResetDiscoverRequests should have comment or be unexported (golint)
    • Line 210: warning: exported method RESTService.ResetAllDiscoverRequests should have comment or be unexported (golint)
    • Line 228: warning: exported method RESTService.GetDiscoverPolicies should have comment or be unexported (golint)
    • speedle/testutil/grpcTestUtil.go
    • Line 24: warning: exported type GRpcClient should have comment or be unexported (golint)
    • Line 31: warning: exported function NewGRpcClient should have comment or be unexported (golint)
    • Line 36: warning: exported method GRpcClient.SetupConnection should have comment or be unexported (golint)
    • Line 59: warning: exported method GRpcClient.CloseConnection should have comment or be unexported (golint)
    • Line 66: warning: comment on exported type GRpcTestData should be of the form "GRpcTestData ..." (with optional leading article) (golint)
    • Line 76: warning: exported type GRpcTest should have comment or be unexported (golint)
    • Line 80: warning: exported function NewGRpcTestExecuter should have comment or be unexported (golint)
    • Line 86: warning: comment on exported method GRpcTest.PreExecute should be of the form "PreExecute ..." (golint)
    • Line 229: warning: comment on exported function VerifyGRpcTestByDefault should be of the form "VerifyGRpcTestByDefault ..." (golint)
    • Line 241: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 265: warning: comment on exported function VerifyGRpcAllGrantedRoleResult should be of the form "VerifyGRpcAllGrantedRoleResult ..." (golint)
    • speedle/cmd/spctl/command/root.go
    • Line 18: warning: exported const DefaultPolicyMgmtEndPoint should have comment (or a comment on this block) or be unexported (golint)
    • Line 57: warning: exported function Execute should have comment or be unexported (golint)
    • speedle/pkg/store/etcd/discover.go
    • Line 22: warning: exported const DiscoverPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported method Store.SaveDiscoverRequest should have comment or be unexported (golint)
    • Line 31: warning: exported method Store.PutRequest should have comment or be unexported (golint)
    • Line 66: warning: exported method Store.DeleteRequests should have comment or be unexported (golint)
    • Line 79: warning: exported method Store.GetLastDiscoverRequest should have comment or be unexported (golint)
    • Line 100: warning: exported method Store.GetDiscoverRequestsSinceRevision should have comment or be unexported (golint)
    • Line 123: warning: exported method Store.GetRequests should have comment or be unexported (golint)
    • Line 153: warning: exported method Store.GetDiscoverRequests should have comment or be unexported (golint)
    • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 162: warning: exported method Store.ResetDiscoverRequests should have comment or be unexported (golint)
    • Line 175: warning: comment on exported method Store.GeneratePolicies should be of the form "GeneratePolicies ..." (golint)
    • Line 176: warning: receiver name d should be consistent with previous receiver name s for Store (golint)
    • speedle/testutil/restTestUtil.go
    • Line 26: warning: exported const PMS_ENDPOINT should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported const URI_POLICY_MGMT should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: don't use underscores in Go names; const WAIT_POLICY_Initialize should be WAITPOLICYInitialize (golint)
    • Line 46: warning: exported type RestClient should have comment or be unexported (golint)
    • Line 54: warning: comment on exported method RestClient.SetPrefix should be of the form "SetPrefix ..." (golint)
    • Line 59: warning: comment on exported method RestClient.Prefix should be of the form "Prefix ..." (golint)
    • Line 64: warning: comment on exported method RestClient.SetToken should be of the form "SetToken ..." (golint)
    • Line 71: warning: comment on exported method RestClient.Token should be of the form "Token ..." (golint)
    • Line 76: warning: comment on exported method RestClient.SetBasicAuth should be of the form "SetBasicAuth ..." (golint)
    • Line 83: warning: comment on exported method RestClient.Get should be of the form "Get ..." (golint)
    • Line 124: warning: comment on exported method RestClient.Delete should be of the form "Delete ..." (golint)
    • Line 165: warning: comment on exported method RestClient.Post should be of the form "Post ..." (golint)
    • Line 253: warning: comment on exported method RestClient.Put should be of the form "Put ..." (golint)
    • Line 311: warning: comment on exported function NewRestClient should be of the form "NewRestClient ..." (golint)
    • Line 361: warning: comment on exported function NewRestClient_PMS should be of the form "NewRestClient_PMS ..." (golint)
    • Line 362: warning: don't use underscores in Go names; func NewRestClient_PMS should be NewRestClientPMS (golint)
    • Line 378: warning: comment on exported function NewRestClient_ADS should be of the form "NewRestClient_ADS ..." (golint)
    • Line 379: warning: don't use underscores in Go names; func NewRestClient_ADS should be NewRestClientADS (golint)
    • Line 397: warning: comment on exported type RestTestData should be of the form "RestTestData ..." (with optional leading article) (golint)
    • Line 407: warning: comment on exported type RestTest should be of the form "RestTest ..." (with optional leading article) (golint)
    • Line 412: warning: comment on exported method RestTest.PreExecute should be of the form "PreExecute ..." (golint)
    • Line 501: warning: comment on exported function NewRestTestExecuter should be of the form "NewRestTestExecuter ..." (golint)
    • Line 510: warning: comment on exported function VerifyRestTestByDefault should be of the form "VerifyRestTestByDefault ..." (golint)
    • Line 543: warning: comment on exported function GetRestTestData_CreateService should be of the form "GetRestTestData_CreateService ..." (golint)
    • Line 544: warning: don't use underscores in Go names; func GetRestTestData_CreateService should be GetRestTestDataCreateService (golint)
    • Line 569: warning: comment on exported function GetRestTestData_DeleteService should be of the form "GetRestTestData_DeleteService ..." (golint)
    • Line 570: warning: don't use underscores in Go names; func GetRestTestData_DeleteService should be GetRestTestDataDeleteService (golint)
    • Line 582: warning: comment on exported function GetRestTestData_CreateRolePolicy should be of the form "GetRestTestData_CreateRolePolicy ..." (golint)
    • Line 583: warning: don't use underscores in Go names; func GetRestTestData_CreateRolePolicy should be GetRestTestDataCreateRolePolicy (golint)
    • Line 611: warning: comment on exported function GetRestTestData_CreatePolicy should be of the form "GetRestTestData_CreatePolicy ..." (golint)
    • Line 612: warning: don't use underscores in Go names; func GetRestTestData_CreatePolicy should be GetRestTestDataCreatePolicy (golint)
    • Line 648: warning: comment on exported function GetTestData_Sleep should be of the form "GetTestData_Sleep ..." (golint)
    • Line 649: warning: don't use underscores in Go names; func GetTestData_Sleep should be GetTestDataSleep (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/OperatorSymbol.go
    • Line 3: warning: comment on exported type OperatorSymbol should be of the form "OperatorSymbol ..." (with optional leading article) (golint)
    • Line 10: warning: exported const VALUE should have comment (or a comment on this block) or be unexported (golint)
    • Line 223: warning: comment on exported method OperatorSymbol.IsModifierType should be of the form "IsModifierType ..." (golint)
    • Line 227: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 244: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/lexerStream.go
    • Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 37: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • speedle/pkg/eval/evaluator_allowed_test.go
    • Line 635: warning: don't use underscores in Go names; func ANDPrincpal_IN_RolePolicy_TestIsAllowedMatch_1 should be ANDPrincpalINRolePolicyTestIsAllowedMatch1 (golint)
    • Line 718: warning: don't use underscores in Go names; func ANDPrincpal_IN_RolePolicy_TestIsAllowedMatch_2 should be ANDPrincpalINRolePolicyTestIsAllowedMatch2 (golint)
    • speedle/pkg/eval/rolepolicycache.go
    • Line 16: warning: exported type RolePolicyCacheData should have comment or be unexported (golint)
    • Line 21: warning: exported function NewRolePolicyCacheData should have comment or be unexported (golint)
    • Line 40: warning: exported method RolePolicyCacheData.AddRolePolicyToCache should have comment or be unexported (golint)
    • Line 106: warning: exported method RolePolicyCacheData.DeleteRolePolicyFromCache should have comment or be unexported (golint)
    • Line 172: warning: exported method RolePolicyCacheData.GetRelatedRolePolicyMap should have comment or be unexported (golint)
    • speedle/api/ads/interface.go
    • Line 10: warning: exported type PolicyEvaluator should have comment or be unexported (golint)
    • Line 27: warning: exported type Discover should have comment or be unexported (golint)
    • Line 32: warning: exported type Diagnose should have comment or be unexported (golint)
    • speedle/api/ext/types.go
    • Line 1: warning: package comment should be of the form "Package ext ..." (golint)
    • Line 5: warning: exported type CustomerFunctionRequest should have comment or be unexported (golint)
    • Line 9: warning: exported type CustomerFunctionResponse should have comment or be unexported (golint)
    • speedle/pkg/eval/runtimeservice.go
    • Line 15: warning: exported type RuntimePolicyStore should have comment or be unexported (golint)
    • Line 23: warning: exported function NewRuntimePolicyStore should have comment or be unexported (golint)
    • Line 32: warning: exported type RuntimeService should have comment or be unexported (golint)
    • Line 41: warning: exported function NewRuntimeService should have comment or be unexported (golint)
    • Line 229: warning: don't use underscores in Go names; method delFunc_rtps should be delFuncRtps (golint)
    • Line 237: warning: don't use underscores in Go names; method delFunc_rtsvc should be delFuncRtsvc (golint)
    • Line 322: warning: exported method RuntimeService.GetRelatedPolicyMap should have comment or be unexported (golint)
    • Line 327: warning: exported method RuntimeService.GetRelatedRolePolicyMap should have comment or be unexported (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/expressionOutputStream.go
    • Line 16: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 20: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 29: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • speedle/pkg/eval/policycache.go
    • Line 15: warning: exported type PolicyCacheData should have comment or be unexported (golint)
    • Line 20: warning: exported function NewPolicyCacheData should have comment or be unexported (golint)
    • Line 39: warning: exported method PolicyCacheData.AddPolicyToCache should have comment or be unexported (golint)
    • Line 117: warning: exported method PolicyCacheData.DeletePolicyFromCache should have comment or be unexported (golint)
    • Line 183: warning: exported method PolicyCacheData.GetRelatedPolicyMap should have comment or be unexported (golint)
    • speedle/api/ads/types.go
    • Line 8: warning: exported type Principal should have comment or be unexported (golint)
    • Line 18: warning: exported type Subject should have comment or be unexported (golint)
    • Line 25: warning: exported type RequestContext should have comment or be unexported (golint)
    • Line 33: warning: exported type EvaluationResult should have comment or be unexported (golint)
    • Line 43: warning: exported type EvaluatedPolicy should have comment or be unexported (golint)
    • Line 53: warning: exported type EvaluatedRolePolicy should have comment or be unexported (golint)
    • Line 65: warning: exported type EvaluatedCondition should have comment or be unexported (golint)
    • Line 71: warning: don't use underscores in Go names; const Evaluation_TakeEffect should be EvaluationTakeEffect (golint)
    • Line 71: warning: exported const Evaluation_TakeEffect should have comment (or a comment on this block) or be unexported (golint)
    • Line 72: warning: don't use underscores in Go names; const Evaluation_ConditionFailed should be EvaluationConditionFailed (golint)
    • Line 73: warning: don't use underscores in Go names; const Evaluation_Ignored should be EvaluationIgnored (golint)
    • Line 76: warning: comment on exported type Reason should be of the form "Reason ..." (with optional leading article) (golint)
    • Line 80: warning: exported const GRANT_POLICY_FOUND should have comment (or a comment on this block) or be unexported (golint)
    • Line 90: warning: don't use underscores in Go names; const BuiltIn_Role_Anonymous should be BuiltInRoleAnonymous (golint)
    • Line 90: warning: exported const BuiltIn_Role_Anonymous should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: don't use underscores in Go names; const BuiltIn_Role_Authenticated should be BuiltInRoleAuthenticated (golint)
    • Line 92: warning: don't use underscores in Go names; const BuiltIn_Role_Everyone should be BuiltInRoleEveryone (golint)
    • Line 94: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestUser should be BuiltInAttrRequestUser (golint)
    • Line 95: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestGroups should be BuiltInAttrRequestGroups (golint)
    • Line 96: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestResource should be BuiltInAttrRequestResource (golint)
    • Line 97: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestAction should be BuiltInAttrRequestAction (golint)
    • Line 98: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestEntity should be BuiltInAttrRequestEntity (golint)
    • Line 100: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestTime should be BuiltInAttrRequestTime (golint)
    • Line 101: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestYear should be BuiltInAttrRequestYear (golint)
    • Line 102: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestMonth should be BuiltInAttrRequestMonth (golint)
    • Line 103: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestDay should be BuiltInAttrRequestDay (golint)
    • Line 104: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestHour should be BuiltInAttrRequestHour (golint)
    • Line 105: warning: don't use underscores in Go names; const BuiltIn_Attr_RequestWeekday should be BuiltInAttrRequestWeekday (golint)
    • Line 119: warning: exported const PRINCIPAL_TYPE_USER should have comment (or a comment on this block) or be unexported (golint)
    • speedle/samples/adsclient/go/src/speedle/api/authz/type.go
    • Line 3: warning: exported type Principal should have comment or be unexported (golint)
    • Line 9: warning: exported type Subject should have comment or be unexported (golint)
    • Line 17: warning: exported type RequestContext should have comment or be unexported (golint)
    • Line 26: warning: exported const HOST_PROP should have comment (or a comment on this block) or be unexported (golint)
    • speedle/cmd/spctl/client/client.go
    • Line 20: warning: exported type Client should have comment or be unexported (golint)
    • Line 55: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 64: warning: exported method Client.Delete should have comment or be unexported (golint)
    • Line 113: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 121: warning: exported method Client.Get should have comment or be unexported (golint)
    • Line 159: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 168: warning: exported method Client.Post should have comment or be unexported (golint)
    • speedle/pkg/cmd/flags/params.go
    • Line 75: warning: exported const DefaultPolicyMgmtEndPoint should have comment (or a comment on this block) or be unexported (golint)
    • Line 96: warning: exported type StrParamDetail should have comment or be unexported (golint)
    • Line 104: warning: exported method Parameters.NewHTTPServer should have comment or be unexported (golint)
    • Line 152: warning: exported method Parameters.ListenAndServe should have comment or be unexported (golint)
    • Line 447: warning: exported method Parameters.ValidateFlags should have comment or be unexported (golint)
    • Line 482: warning: exported method Parameters.Param2Config should have comment or be unexported (golint)
    • speedle/pkg/store/etcd/storeBuilder.go
    • Line 22: warning: exported const StoreType should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: comment on exported const IsEmbeddedEtcdKey should be of the form "IsEmbeddedEtcdKey ..." (golint)
    • Line 49: warning: comment on exported const DefaultKeyPrefix should be of the form "DefaultKeyPrefix ..." (golint)
    • Line 56: warning: exported type Etcd3StoreBuilder should have comment or be unexported (golint)
    • Line 58: warning: exported method Etcd3StoreBuilder.NewStore should have comment or be unexported (golint)
    • Line 164: warning: exported method Etcd3StoreBuilder.GetStoreParams should have comment or be unexported (golint)
    • speedle/testutil/cmdTestUtil.go
    • Line 21: warning: exported const SP_APP_NAME should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type CmdClient should have comment or be unexported (golint)
    • Line 36: warning: comment on exported method CmdClient.ExecuteCmd should be of the form "ExecuteCmd ..." (golint)
    • Line 59: warning: comment on exported function NewCmdClient should be of the form "NewCmdClient ..." (golint)
    • Line 79: warning: comment on exported function NewCmdClient_token should be of the form "NewCmdClient_token ..." (golint)
    • Line 80: warning: don't use underscores in Go names; func NewCmdClient_token should be NewCmdClientToken (golint)
    • Line 100: warning: comment on exported type CmdTestData should be of the form "CmdTestData ..." (with optional leading article) (golint)
    • Line 110: warning: exported type CmdTest should have comment or be unexported (golint)
    • Line 114: warning: exported function NewCmdTest should have comment or be unexported (golint)
    • Line 118: warning: comment on exported method CmdTest.PreExecute should be of the form "PreExecute ..." (golint)
    • Line 191: warning: comment on exported method CmdTest.ParseOutputForCreate should be of the form "ParseOutputForCreate ..." (golint)
    • Line 210: warning: comment on exported method CmdTest.ParseOutputForGet should be of the form "ParseOutputForGet ..." (golint)
    • Line 230: warning: comment on exported function VerifyCmdTestByDefault should be of the form "VerifyCmdTestByDefault ..." (golint)
    • Line 276: warning: comment on exported function GeneratePdlFile should be of the form "GeneratePdlFile ..." (golint)
    • Line 288: warning: comment on exported function GenerateJsonFileWithService should be of the form "GenerateJsonFileWithService ..." (golint)
    • Line 297: warning: comment on exported function GenerateJsonFileWithPolicy should be of the form "GenerateJsonFileWithPolicy ..." (golint)
    • Line 306: warning: comment on exported function GenerateJsonFileWithRolePolicy should be of the form "GenerateJsonFileWithRolePolicy ..." (golint)
    • Line 315: warning: comment on exported method CmdClient.CreateServiceWithPDL should be of the form "CreateServiceWithPDL ..." (golint)
    • speedle/testutil/testBase.go
    • Line 14: warning: exported var TestLog should have comment or be unexported (golint)
    • Line 28: warning: comment on exported method TestCase.SetPreTestFunc should be of the form "SetPreTestFunc ..." (golint)
    • Line 35: warning: comment on exported method TestCase.SetPostTestFunc should be of the form "SetPostTestFunc ..." (golint)
    • Line 42: warning: comment on exported method TestCase.SetVerifyTestFunc should be of the form "SetVerifyTestFunc ..." (golint)
    • Line 49: warning: comment on exported type TestContext should be of the form "TestContext ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type TestExecuter should be of the form "TestExecuter ..." (with optional leading article) (golint)
    • Line 62: warning: comment on exported function RunTestCases should be of the form "RunTestCases ..." (golint)
    • Line 143: warning: comment on exported function GetOSEnv should be of the form "GetOSEnv ..." (golint)
    • Line 152: warning: comment on exported function SetOSEnv should be of the form "SetOSEnv ..." (golint)
    • speedle/testutil/testUtil.go
    • Line 36: warning: exported const ERROR_SPEEDLE_NOT_SUPPORTED should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: comment on exported function PostCreateGetPolicyTest should be of the form "PostCreateGetPolicyTest ..." (golint)
    • Line 55: warning: don't use underscores in Go names; func postCreateGetPolicyTest_rest should be postCreateGetPolicyTestRest (golint)
    • Line 80: warning: don't use underscores in Go names; func postCreateGetPolicyTest_grpc should be postCreateGetPolicyTestGrpc (golint)
    • Line 107: warning: exported function PostListPolicyTest should have comment or be unexported (golint)
    • Line 119: warning: don't use underscores in Go names; func postListPolicyTest_rest should be postListPolicyTestRest (golint)
    • Line 170: warning: don't use underscores in Go names; func postListPolicyTest_grpc should be postListPolicyTestGrpc (golint)
    • Line 221: warning: comment on exported function PostCreateGetRolePolicyTest should be of the form "PostCreateGetRolePolicyTest ..." (golint)
    • Line 237: warning: don't use underscores in Go names; func postCreateGetRolePolicyTest_rest should be postCreateGetRolePolicyTestRest (golint)
    • Line 260: warning: don't use underscores in Go names; func postCreateGetRolePolicyTest_grpc should be postCreateGetRolePolicyTestGrpc (golint)
    • Line 282: warning: comment on exported function PostListRolePolicyTest should be of the form "PostListRolePolicyTest ..." (golint)
    • Line 298: warning: don't use underscores in Go names; func postListRolePolicyTest_rest should be postListRolePolicyTestRest (golint)
    • Line 343: warning: don't use underscores in Go names; func postListRolePolicyTest_grpc should be postListRolePolicyTestGrpc (golint)
    • Line 388: warning: comment on exported function PostCreateGetServiceTest should be of the form "PostCreateGetServiceTest ..." (golint)
    • Line 404: warning: don't use underscores in Go names; func postCreateGetServiceTest_rest should be postCreateGetServiceTestRest (golint)
    • Line 439: warning: don't use underscores in Go names; func postCreateGetServiceTest_grpc should be postCreateGetServiceTestGrpc (golint)
    • Line 454: warning: comment on exported function PostListServiceTest should be of the form "PostListServiceTest ..." (golint)
    • Line 470: warning: don't use underscores in Go names; func postListServiceTest_rest should be postListServiceTestRest (golint)
    • Line 509: warning: don't use underscores in Go names; func postListServiceTest_grpc should be postListServiceTestGrpc (golint)
    • Line 548: warning: comment on exported function PostGetAllGrantedRoles should be of the form "PostGetAllGrantedRoles ..." (golint)
    • Line 561: warning: don't use underscores in Go names; func postGetAllGrantedRoles_rest should be postGetAllGrantedRolesRest (golint)
    • Line 569: warning: comment on exported function PostGetAllGrantedPermissions should be of the form "PostGetAllGrantedPermissions ..." (golint)
    • Line 582: warning: don't use underscores in Go names; func postGetAllGrantedPermissions_rest should be postGetAllGrantedPermissionsRest (golint)
    • Line 614: warning: comment on exported function PreGetDeletePolicyTest should be of the form "PreGetDeletePolicyTest ..." (golint)
    • Line 632: warning: don't use underscores in Go names; func preGetDeletePolicy_rest should be preGetDeletePolicyRest (golint)
    • Line 644: warning: don't use underscores in Go names; func preGetDeletePolicy_grpc should be preGetDeletePolicyGrpc (golint)
    • Line 697: warning: exported var SpecialNames should have comment or be unexported (golint)
    • Line 699: warning: exported function InitSpecialNames should have comment or be unexported (golint)
    • Line 736: warning: don't use underscores in Go names; func CompareStringArray_NoOrder should be CompareStringArrayNoOrder (golint)
    • speedle/pkg/eval/function/builtin_functions.go
    • Line 15: warning: exported function Sqrt should have comment or be unexported (golint)
    • Line 27: warning: exported function Max should have comment or be unexported (golint)
    • Line 42: warning: exported function Min should have comment or be unexported (golint)
    • Line 57: warning: exported function Sum should have comment or be unexported (golint)
    • Line 69: warning: exported function Avg should have comment or be unexported (golint)
    • Line 80: warning: comment on exported function IsSubSet should be of the form "IsSubSet ..." (golint)
    • speedle/3rdparty/github.com/Knetic/govaluate/EvaluableExpression.go
    • Line 11: warning: exported var DUMMY_PARAMETERS should have comment or be unexported (golint)
    • Line 13: warning: comment on exported type EvaluableExpression should be of the form "EvaluableExpression ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported function NewEvaluableExpression should be of the form "NewEvaluableExpression ..." (golint)
    • Line 50: warning: comment on exported function NewEvaluableExpressionFromTokens should be of the form "NewEvaluableExpressionFromTokens ..." (golint)
    • Line 86: warning: comment on exported function NewEvaluableExpressionWithFunctions should be of the form "NewEvaluableExpressionWithFunctions ..." (golint)
    • Line 128: warning: comment on exported method EvaluableExpression.Evaluate should be of the form "Evaluate ..." (golint)
    • Line 131: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 140: warning: comment on exported method EvaluableExpression.Eval should be of the form "Eval ..." (golint)
    • Line 151: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 166: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 249: warning: comment on exported method EvaluableExpression.Tokens should be of the form "Tokens ..." (golint)
    • Line 252: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 260: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 265: warning: comment on exported method EvaluableExpression.Vars should be of the form "Vars ..." (golint)
    • Line 268: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell88%

Misspell Finds commonly misspelled English words

    • speedle/pkg/eval/runtimeservice.go
    • Line 153: warning: "garantees" is a misspelling of "guarantees" (misspell)
    • Line 170: warning: "garantees" is a misspelling of "guarantees" (misspell)
    • Line 188: warning: "garantees" is a misspelling of "guarantees" (misspell)
    • Line 205: warning: "garantees" is a misspelling of "guarantees" (misspell)