Preparing report...

Report for github.com/osrg/namazu

A+    Excellent!    Found 88 issues across 142 files

Tweet

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint40%

Golint is a linter for Go source code.

    • namazu/nmz/endpoint/rest/queue/restqueue.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 31: warning: comment on exported type ActionQueue should be of the form "ActionQueue ..." (with optional leading article) (golint)
    • Line 42: warning: comment on exported method ActionQueue.Count should be of the form "Count ..." (golint)
    • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 51: warning: comment on exported method ActionQueue.Peeking should be of the form "Peeking ..." (golint)
    • Line 52: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 60: warning: comment on exported method ActionQueue.Peek should be of the form "Peek ..." (golint)
    • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 103: warning: comment on exported method ActionQueue.Put should be of the form "Put ..." (golint)
    • Line 104: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 114: warning: comment on exported method ActionQueue.Delete should be of the form "Delete ..." (golint)
    • Line 115: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 137: warning: exported function RegisterNewQueue should have comment or be unexported (golint)
    • Line 157: warning: comment on exported function UnregisterQueue should be of the form "UnregisterQueue ..." (golint)
    • Line 169: warning: exported function GetQueue should have comment or be unexported (golint)
    • Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • namazu/nmz/util/core/coreutil.go
    • Line 29: warning: exported const NamazuVersion should have comment or be unexported (golint)
    • Line 31: warning: comment on exported function DebugMode should be of the form "DebugMode ..." (golint)
    • Line 36: warning: comment on exported function Init should be of the form "Init ..." (golint)
    • Line 44: warning: comment on exported function Recoverer should be of the form "Recoverer ..." (golint)
    • Line 59: warning: error var EthernetInspectorNotBuiltErr should have name of the form ErrFoo (golint)
    • Line 59: warning: exported var EthernetInspectorNotBuiltErr should have comment or be unexported (golint)
    • namazu/nmz/signal/action_sched_procset.go
    • Line 23: warning: comment on exported type ProcSetSchedAction should be of the form "ProcSetSchedAction ..." (with optional leading article) (golint)
    • Line 28: warning: exported function NewProcSetSchedAction should have comment or be unexported (golint)
    • namazu/nmz/signal/event_nop.go
    • Line 20: warning: comment on exported type NopEvent should be of the form "NopEvent ..." (with optional leading article) (golint)
    • Line 25: warning: exported function NewNopEvent should have comment or be unexported (golint)
    • namazu/nmz/historystorage/historystorage.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 29: warning: comment on exported const StorageTOMLConfigPath should be of the form "StorageTOMLConfigPath ..." (golint)
    • Line 33: warning: exported type HistoryStorage should have comment or be unexported (golint)
    • Line 54: warning: exported function New should have comment or be unexported (golint)
    • Line 64: warning: exported function LoadStorage should have comment or be unexported (golint)
    • namazu/nmz/explorepolicy/random/randompolicy.go
    • Line 30: warning: exported type Random should have comment or be unexported (golint)
    • Line 93: warning: exported function New should have comment or be unexported (golint)
    • Line 122: warning: exported const Name should have comment or be unexported (golint)
    • Line 124: warning: comment on exported method Random.Name should be of the form "Name ..." (golint)
    • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 129: warning: comment on exported method Random.LoadConfig should be of the form "LoadConfig ..." (golint)
    • Line 272: warning: exported method Random.SetHistoryStorage should have comment or be unexported (golint)
    • Line 276: warning: exported method Random.ActionChan should have comment or be unexported (golint)
    • Line 313: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 332: warning: exported method Random.QueueEvent should have comment or be unexported (golint)
    • namazu/nmz/signal/action_accept_event.go
    • Line 24: warning: comment on exported type EventAcceptanceAction should be of the form "EventAcceptanceAction ..." (with optional leading article) (golint)
    • Line 29: warning: exported function NewEventAcceptanceAction should have comment or be unexported (golint)
    • namazu/nmz/signal/signal.go
    • Line 44: warning: comment on exported function RegisterSignalClass should be of the form "RegisterSignalClass ..." (golint)
    • Line 63: warning: comment on exported function GetSignalClass should be of the form "GetSignalClass ..." (golint)
    • Line 71: warning: comment on exported type BasicSignal should be of the form "BasicSignal ..." (with optional leading article) (golint)
    • Line 80: warning: exported method BasicSignal.InitSignal should have comment or be unexported (golint)
    • Line 80: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 89: warning: comment on exported method BasicSignal.Get should be of the form "Get ..." (golint)
    • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 98: warning: comment on exported method BasicSignal.Set should be of the form "Set ..." (golint)
    • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 103: warning: comment on exported method BasicSignal.ID should be of the form "ID ..." (golint)
    • Line 104: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 108: warning: exported method BasicSignal.SetID should have comment or be unexported (golint)
    • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 112: warning: comment on exported method BasicSignal.EntityID should be of the form "EntityID ..." (golint)
    • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 117: warning: exported method BasicSignal.SetEntityID should have comment or be unexported (golint)
    • Line 117: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 121: warning: comment on exported method BasicSignal.Type should be of the form "Type ..." (golint)
    • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 126: warning: comment on exported method BasicSignal.SetType should be of the form "SetType ..." (golint)
    • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 135: warning: exported method BasicSignal.Class should have comment or be unexported (golint)
    • Line 135: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 139: warning: exported method BasicSignal.SetClass should have comment or be unexported (golint)
    • Line 139: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 143: warning: exported method BasicSignal.Option should have comment or be unexported (golint)
    • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 147: warning: exported method BasicSignal.SetOption should have comment or be unexported (golint)
    • Line 147: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 151: warning: comment on exported method BasicSignal.ArrivedTime should be of the form "ArrivedTime ..." (golint)
    • Line 152: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 156: warning: exported method BasicSignal.SetArrivedTime should have comment or be unexported (golint)
    • Line 156: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 160: warning: comment on exported method BasicSignal.JSONMap should be of the form "JSONMap ..." (golint)
    • Line 161: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 165: warning: exported method BasicSignal.LoadJSONMap should have comment or be unexported (golint)
    • Line 165: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 173: warning: comment on exported method BasicSignal.EqualsSignal should be of the form "EqualsSignal ..." (golint)
    • Line 174: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 189: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 193: warning: exported function NewSignalFromJSONString should have comment or be unexported (golint)
    • namazu/nmz/container/ns/ns.go
    • Line 29: warning: exported function EnterDockerNetNs should have comment or be unexported (golint)
    • Line 47: warning: exported function LeaveNetNs should have comment or be unexported (golint)
    • namazu/nmz/util/pb/pbutil.go
    • Line 26: warning: exported type Reader should have comment or be unexported (golint)
    • Line 30: warning: exported type Writer should have comment or be unexported (golint)
    • Line 34: warning: exported type ReaderWriter should have comment or be unexported (golint)
    • Line 39: warning: comment on exported function RecvMsg should be of the form "RecvMsg ..." (golint)
    • Line 75: warning: exported function SendMsg should have comment or be unexported (golint)
    • namazu/nmz/util/trace/trace.go
    • Line 25: warning: exported type SingleTrace should have comment or be unexported (golint)
    • Line 29: warning: exported method SingleTrace.Equals should have comment or be unexported (golint)
    • Line 29: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/signal/event_function.go
    • Line 27: warning: exported type FunctionEventType should have comment or be unexported (golint)
    • Line 30: warning: exported const NilFunctionEventType should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: comment on exported type CFunctionEvent should be of the form "CFunctionEvent ..." (with optional leading article) (golint)
    • Line 44: warning: comment on exported type JavaFunctionEvent should be of the form "JavaFunctionEvent ..." (with optional leading article) (golint)
    • Line 54: warning: comment on exported type Event_JavaSpecific_Param should be of the form "Event_JavaSpecific_Param ..." (with optional leading article) (golint)
    • Line 55: warning: don't use underscores in Go names; type Event_JavaSpecific_Param should be EventJavaSpecificParam (golint)
    • Line 60: warning: comment on exported type Event_JavaSpecific_StackTraceElement should be of the form "Event_JavaSpecific_StackTraceElement ..." (with optional leading article) (golint)
    • Line 61: warning: don't use underscores in Go names; type Event_JavaSpecific_StackTraceElement should be EventJavaSpecificStackTraceElement (golint)
    • Line 68: warning: exported function NewJavaFunctionEventFromPB should have comment or be unexported (golint)
    • namazu/nmz/signal/event_procset.go
    • Line 20: warning: comment on exported type ProcSetEvent should be of the form "ProcSetEvent ..." (with optional leading article) (golint)
    • Line 26: warning: exported function NewProcSetEvent should have comment or be unexported (golint)
    • namazu/nmz/util/cmd/cmdutil.go
    • Line 26: warning: exported type CmdFactory should have comment or be unexported (golint)
    • Line 31: warning: comment on exported method CmdFactory.SetWorkingDir should be of the form "SetWorkingDir ..." (golint)
    • Line 32: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 36: warning: exported method CmdFactory.GetWorkingDir should have comment or be unexported (golint)
    • Line 36: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 40: warning: comment on exported method CmdFactory.SetMaterialsDir should be of the form "SetMaterialsDir ..." (golint)
    • Line 41: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 45: warning: exported method CmdFactory.GetMaterialsDir should have comment or be unexported (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 49: warning: exported method CmdFactory.CreateCmd should have comment or be unexported (golint)
    • Line 49: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 71: warning: exported function NewCmdFactory should have comment or be unexported (golint)
    • Line 75: warning: exported var DefaultFactory should have comment or be unexported (golint)
    • namazu/example/yarn/4301-reproduce/mypolicy.go
    • Line 26: warning: should not use dot imports (golint)
    • Line 27: warning: should not use dot imports (golint)
    • Line 28: warning: should not use dot imports (golint)
    • Line 29: warning: should not use dot imports (golint)
    • Line 33: warning: exported const MyPolicyName should have comment or be unexported (golint)
    • Line 34: warning: exported const FaultySleepDuration should have comment or be unexported (golint)
    • Line 36: warning: exported type MyPolicy should have comment or be unexported (golint)
    • Line 41: warning: exported function NewMyPolicy should have comment or be unexported (golint)
    • Line 50: warning: exported method MyPolicy.Name should have comment or be unexported (golint)
    • Line 54: warning: exported method MyPolicy.LoadConfig should have comment or be unexported (golint)
    • Line 58: warning: exported method MyPolicy.SetHistoryStorage should have comment or be unexported (golint)
    • Line 72: warning: exported method MyPolicy.ActionChan should have comment or be unexported (golint)
    • Line 83: warning: exported method MyPolicy.QueueEvent should have comment or be unexported (golint)
    • namazu/nmz/historystorage/naive/common.go
    • Line 42: warning: comment on exported type Naive should be of the form "Naive ..." (with optional leading article) (golint)
    • Line 50: warning: exported method Naive.Name should have comment or be unexported (golint)
    • Line 54: warning: exported function New should have comment or be unexported (golint)
    • namazu/nmz/util/signal/misc.go
    • Line 16: warning: package comment should be of the form "Package signal ..." (golint)
    • Line 19: warning: should not use dot imports (golint)
    • Line 21: warning: comment on exported function AreActionsSliceEqual should be of the form "AreActionsSliceEqual ..." (golint)
    • namazu/nmz/endpoint/rest/restendpoint.go
    • Line 30: warning: should not use dot imports (golint)
    • Line 31: warning: should not use dot imports (golint)
    • Line 176: warning: exported type RESTEndpoint should have comment or be unexported (golint)
    • Line 184: warning: comment on exported var ActualPort should be of the form "ActualPort ..." (golint)
    • Line 204: warning: comment on exported method RESTEndpoint.Start should be of the form "Start ..." (golint)
    • Line 226: warning: exported var SingletonRESTEndpoint should have comment or be unexported (golint)
    • namazu/nmz/signal/action.go
    • Line 24: warning: exported type BasicAction should have comment or be unexported (golint)
    • Line 31: warning: comment on exported method BasicAction.Equals should be of the form "Equals ..." (golint)
    • Line 32: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 36: warning: comment on exported method BasicAction.TriggeredTime should be of the form "TriggeredTime ..." (golint)
    • Line 37: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 41: warning: comment on exported method BasicAction.SetTriggeredTime should be of the form "SetTriggeredTime ..." (golint)
    • Line 42: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 46: warning: comment on exported method BasicAction.Event should be of the form "Event ..." (golint)
    • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 67: warning: comment on exported type BasicPBAction should be of the form "BasicPBAction ..." (with optional leading article) (golint)
    • Line 74: warning: comment on exported method BasicPBAction.PBResponseMessage should be of the form "PBResponseMessage ..." (golint)
    • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/inspector/ethernet/ethernet_nfq.go
    • Line 29: warning: comment on exported type NFQInspector should be of the form "NFQInspector ..." (with optional leading article) (golint)
    • Line 39: warning: exported method NFQInspector.Serve should have comment or be unexported (golint)
    • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 95: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/util/test/testutil.go
    • Line 24: warning: comment on exported function NewNopEvent should be of the form "NewNopEvent ..." (golint)
    • Line 32: warning: comment on exported function NewPacketEvent should be of the form "NewPacketEvent ..." (golint)
    • namazu/nmz/signal/action_nop.go
    • Line 22: warning: comment on exported type NopAction should be of the form "NopAction ..." (with optional leading article) (golint)
    • Line 27: warning: comment on exported function NewNopAction should be of the form "NewNopAction ..." (golint)
    • Line 41: warning: comment on exported method NopAction.OrchestratorSideOnly should be of the form "OrchestratorSideOnly ..." (golint)
    • Line 42: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 46: warning: comment on exported method NopAction.ExecuteOnOrchestrator should be of the form "ExecuteOnOrchestrator ..." (golint)
    • Line 47: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/inspector/ethernet/hookswitch/hookswitch.go
    • Line 16: warning: package comment should be of the form "Package hookswitch ..." (golint)
    • Line 19: warning: exported type HookSwitchMeta should have comment or be unexported (golint)
    • Line 26: warning: exported type HookSwitchOp should have comment or be unexported (golint)
    • Line 29: warning: exported const Accept should have comment (or a comment on this block) or be unexported (golint)
    • namazu/nmz/endpoint/local/localendpoint.go
    • Line 20: warning: should not use dot imports (golint)
    • Line 23: warning: exported type LocalEndpoint should have comment or be unexported (golint)
    • Line 94: warning: exported method LocalEndpoint.Start should have comment or be unexported (golint)
    • Line 105: warning: exported method LocalEndpoint.Shutdown should have comment or be unexported (golint)
    • Line 114: warning: exported function NewLocalEndpoint should have comment or be unexported (golint)
    • Line 124: warning: exported var SingletonLocalEndpoint should have comment or be unexported (golint)
    • namazu/nmz/endpoint/pb/pbendpoint.go
    • Line 21: warning: should not use dot imports (golint)
    • Line 22: warning: should not use dot imports (golint)
    • Line 29: warning: exported type PBEndpoint should have comment or be unexported (golint)
    • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 142: warning: exported method PBEndpoint.Start should have comment or be unexported (golint)
    • Line 166: warning: exported function NewPBEndpoint should have comment or be unexported (golint)
    • Line 174: warning: exported var SingletonPBEndpoint should have comment or be unexported (golint)
    • namazu/nmz/inspector/proc/proc.go
    • Line 33: warning: exported type ProcInspector should have comment or be unexported (golint)
    • Line 43: warning: exported function NewProcInspector should have comment or be unexported (golint)
    • Line 53: warning: exported method ProcInspector.Serve should have comment or be unexported (golint)
    • Line 53: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 89: warning: exported method ProcInspector.Shutdown should have comment or be unexported (golint)
    • Line 89: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 93: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 148: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/orchestrator/orchestrator.go
    • Line 16: warning: package comment should be of the form "Package orchestrator ..." (golint)
    • Line 16: warning: package comment should not have leading space (golint)
    • Line 31: warning: should not use dot imports (golint)
    • Line 32: warning: should not use dot imports (golint)
    • Line 33: warning: should not use dot imports (golint)
    • Line 34: warning: should not use dot imports (golint)
    • Line 39: warning: exported type Orchestrator should have comment or be unexported (golint)
    • Line 62: warning: exported function NewOrchestrator should have comment or be unexported (golint)
    • Line 123: warning: exported method Orchestrator.Start should have comment or be unexported (golint)
    • Line 205: warning: comment on exported method Orchestrator.Shutdown should be of the form "Shutdown ..." (golint)
    • namazu/nmz/util/proc/procutil.go
    • Line 44: warning: comment on exported function Children should be of the form "Children ..." (golint)
    • Line 65: warning: comment on exported function Descendants should be of the form "Descendants ..." (golint)
    • Line 74: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 87: warning: comment on exported function DescendantLWPs should be of the form "DescendantLWPs ..." (golint)
    • namazu/nmz/signal/action_shell.go
    • Line 26: warning: comment on exported type ShellAction should be of the form "ShellAction ..." (with optional leading article) (golint)
    • Line 31: warning: comment on exported function NewShellAction should be of the form "NewShellAction ..." (golint)
    • Line 53: warning: comment on exported method ShellAction.OrchestratorSideOnly should be of the form "OrchestratorSideOnly ..." (golint)
    • Line 54: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 58: warning: comment on exported method ShellAction.ExecuteOnOrchestrator should be of the form "ExecuteOnOrchestrator ..." (golint)
    • Line 59: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/inspector/fs/fs.go
    • Line 25: warning: should not use dot imports (golint)
    • Line 28: warning: comment on exported type EQFSHookContext should be of the form "EQFSHookContext ..." (with optional leading article) (golint)
    • Line 33: warning: comment on exported type FilesystemInspector should be of the form "FilesystemInspector ..." (with optional leading article) (golint)
    • Line 40: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 44: warning: comment on exported method FilesystemInspector.Init should be of the form "Init ..." (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 56: warning: error should be the last type when returning multiple items (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 80: warning: comment on exported method FilesystemInspector.PreRead should be of the form "PreRead ..." (golint)
    • Line 81: warning: error should be the last type when returning multiple items (golint)
    • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 87: warning: comment on exported method FilesystemInspector.PostRead should be of the form "PostRead ..." (golint)
    • Line 88: warning: error should be the last type when returning multiple items (golint)
    • Line 88: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 103: warning: comment on exported method FilesystemInspector.PreOpenDir should be of the form "PreOpenDir ..." (golint)
    • Line 104: warning: error should be the last type when returning multiple items (golint)
    • Line 104: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 110: warning: comment on exported method FilesystemInspector.PostOpenDir should be of the form "PostOpenDir ..." (golint)
    • Line 111: warning: error should be the last type when returning multiple items (golint)
    • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 117: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 126: warning: comment on exported method FilesystemInspector.PreMkdir should be of the form "PreMkdir ..." (golint)
    • Line 127: warning: error should be the last type when returning multiple items (golint)
    • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 142: warning: comment on exported method FilesystemInspector.PostMkdir should be of the form "PostMkdir ..." (golint)
    • Line 143: warning: error should be the last type when returning multiple items (golint)
    • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 148: warning: comment on exported method FilesystemInspector.PreRmdir should be of the form "PreRmdir ..." (golint)
    • Line 149: warning: error should be the last type when returning multiple items (golint)
    • Line 149: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 164: warning: comment on exported method FilesystemInspector.PostRmdir should be of the form "PostRmdir ..." (golint)
    • Line 165: warning: error should be the last type when returning multiple items (golint)
    • Line 165: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 170: warning: comment on exported method FilesystemInspector.PreFsync should be of the form "PreFsync ..." (golint)
    • Line 171: warning: error should be the last type when returning multiple items (golint)
    • Line 171: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 177: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 186: warning: comment on exported method FilesystemInspector.PostFsync should be of the form "PostFsync ..." (golint)
    • Line 187: warning: error should be the last type when returning multiple items (golint)
    • Line 187: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/inspector/ethernet/tcpwatcher/tcpwatcher.go
    • Line 24: warning: comment on exported type TCPWatcher should be of the form "TCPWatcher ..." (with optional leading article) (golint)
    • Line 29: warning: exported function New should have comment or be unexported (golint)
    • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 56: warning: exported method TCPWatcher.IsTCPRetrans should have comment or be unexported (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/historystorage/mongodb/mongodb.go
    • Line 20: warning: should not use dot imports (golint)
    • Line 21: warning: should not use dot imports (golint)
    • Line 35: warning: comment on exported type MongoDB should be of the form "MongoDB ..." (with optional leading article) (golint)
    • Line 45: warning: exported function New should have comment or be unexported (golint)
    • Line 62: warning: exported method MongoDB.CreateStorage should have comment or be unexported (golint)
    • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 66: warning: exported method MongoDB.Init should have comment or be unexported (golint)
    • Line 66: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 70: warning: exported method MongoDB.Close should have comment or be unexported (golint)
    • Line 70: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 75: warning: exported method MongoDB.Name should have comment or be unexported (golint)
    • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 79: warning: exported method MongoDB.CreateNewWorkingDir should have comment or be unexported (golint)
    • Line 79: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 84: warning: exported method MongoDB.RecordNewTrace should have comment or be unexported (golint)
    • Line 84: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 117: warning: exported method MongoDB.RecordResult should have comment or be unexported (golint)
    • Line 117: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 121: warning: exported method MongoDB.NrStoredHistories should have comment or be unexported (golint)
    • Line 121: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 126: warning: exported method MongoDB.GetStoredHistory should have comment or be unexported (golint)
    • Line 126: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 131: warning: exported method MongoDB.IsSuccessful should have comment or be unexported (golint)
    • Line 131: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 136: warning: exported method MongoDB.GetRequiredTime should have comment or be unexported (golint)
    • Line 136: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 141: warning: exported method MongoDB.Search should have comment or be unexported (golint)
    • Line 141: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 146: warning: exported method MongoDB.SearchWithConverter should have comment or be unexported (golint)
    • Line 146: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/signal/event_filesystem.go
    • Line 20: warning: comment on exported type FilesystemEvent should be of the form "FilesystemEvent ..." (with optional leading article) (golint)
    • Line 25: warning: exported type FilesystemOp should have comment or be unexported (golint)
    • Line 28: warning: comment on exported const PostRead should be of the form "PostRead ..." (golint)
    • Line 30: warning: exported const PostOpenDir should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: comment on exported const PreWrite should be of the form "PreWrite ..." (golint)
    • Line 38: warning: exported function NewFilesystemEvent should have comment or be unexported (golint)
    • Line 57: warning: comment on exported method FilesystemEvent.DefaultFaultAction should be of the form "DefaultFaultAction ..." (golint)
    • Line 58: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/inspector/ethernet/ethernet_hookswitch.go
    • Line 32: warning: comment on exported type HookSwitchInspector should be of the form "HookSwitchInspector ..." (with optional leading article) (golint)
    • Line 45: warning: exported function NewHookSwitchInspector should have comment or be unexported (golint)
    • Line 56: warning: exported method HookSwitchInspector.Serve should have comment or be unexported (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 109: warning: exported method HookSwitchInspector.Shutdown should have comment or be unexported (golint)
    • Line 109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 156: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/util/mockorchestrator/mockorchestrator.go
    • Line 24: warning: comment on exported type MockOrchestrator should be of the form "MockOrchestrator ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported function NewMockOrchestrator should be of the form "NewMockOrchestrator ..." (golint)
    • Line 98: warning: exported method MockOrchestrator.Start should have comment or be unexported (golint)
    • Line 102: warning: exported method MockOrchestrator.Shutdown should have comment or be unexported (golint)
    • namazu/nmz/inspector/transceiver/resttransceiver.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 100: warning: exported type RESTTransceiver should have comment or be unexported (golint)
    • Line 108: warning: exported function NewRESTTransceiver should have comment or be unexported (golint)
    • Line 119: warning: exported method RESTTransceiver.SendEvent should have comment or be unexported (golint)
    • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 138: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 158: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 188: warning: exported method RESTTransceiver.Start should have comment or be unexported (golint)
    • Line 188: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/util/queue/impl.go
    • Line 27: warning: comment on exported type BasicTBQueueItem should be of the form "BasicTBQueueItem ..." (with optional leading article) (golint)
    • Line 35: warning: exported function NewBasicTBQueueItem should have comment or be unexported (golint)
    • Line 48: warning: exported method BasicTBQueueItem.Value should have comment or be unexported (golint)
    • Line 48: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 52: warning: exported method BasicTBQueueItem.EnqueuedTime should have comment or be unexported (golint)
    • Line 52: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 56: warning: exported method BasicTBQueueItem.MinDuration should have comment or be unexported (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 60: warning: exported method BasicTBQueueItem.MaxDuration should have comment or be unexported (golint)
    • Line 60: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 64: warning: comment on exported type BasicTBQueue should be of the form "BasicTBQueue ..." (with optional leading article) (golint)
    • Line 70: warning: exported function NewBasicTBQueue should have comment or be unexported (golint)
    • Line 110: warning: exported method BasicTBQueue.Enqueue should have comment or be unexported (golint)
    • Line 110: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 110: warning: don't use underscores in Go names; method parameter item_ should be item (golint)
    • Line 130: warning: exported method BasicTBQueue.GetDequeueChan should have comment or be unexported (golint)
    • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/util/rest/restutil.go
    • Line 26: warning: comment on exported const APIRoot should be of the form "APIRoot ..." (golint)
    • Line 29: warning: comment on exported function WriteError should be of the form "WriteError ..." (golint)
    • Line 36: warning: comment on exported function WriteJSON should be of the form "WriteJSON ..." (golint)
    • namazu/example/template/mypolicy.go
    • Line 14: warning: comment on exported type MyPolicy should be of the form "MyPolicy ..." (with optional leading article) (golint)
    • Line 19: warning: exported function NewMyPolicy should have comment or be unexported (golint)
    • Line 25: warning: comment on exported method MyPolicy.Name should be of the form "Name ..." (golint)
    • Line 30: warning: comment on exported method MyPolicy.LoadConfig should be of the form "LoadConfig ..." (golint)
    • Line 35: warning: comment on exported method MyPolicy.SetHistoryStorage should be of the form "SetHistoryStorage ..." (golint)
    • Line 40: warning: comment on exported method MyPolicy.ActionChan should be of the form "ActionChan ..." (golint)
    • Line 45: warning: comment on exported method MyPolicy.QueueEvent should be of the form "QueueEvent ..." (golint)
    • namazu/nmz/explorepolicy/dumb/dumbpolicy.go
    • Line 29: warning: exported type Dumb should have comment or be unexported (golint)
    • Line 41: warning: exported function New should have comment or be unexported (golint)
    • Line 53: warning: exported const Name should have comment or be unexported (golint)
    • Line 55: warning: comment on exported method Dumb.Name should be of the form "Name ..." (golint)
    • Line 60: warning: comment on exported method Dumb.LoadConfig should be of the form "LoadConfig ..." (golint)
    • Line 76: warning: exported method Dumb.SetHistoryStorage should have comment or be unexported (golint)
    • Line 80: warning: exported method Dumb.ActionChan should have comment or be unexported (golint)
    • Line 84: warning: exported method Dumb.QueueEvent should have comment or be unexported (golint)
    • namazu/nmz/explorepolicy/replayable/replayablepolicy.go
    • Line 30: warning: exported type Replayable should have comment or be unexported (golint)
    • Line 41: warning: exported function New should have comment or be unexported (golint)
    • Line 51: warning: exported const Name should have comment or be unexported (golint)
    • Line 53: warning: comment on exported method Replayable.Name should be of the form "Name ..." (golint)
    • Line 58: warning: comment on exported method Replayable.LoadConfig should be of the form "LoadConfig ..." (golint)
    • Line 92: warning: exported method Replayable.SetHistoryStorage should have comment or be unexported (golint)
    • Line 92: warning: receiver name d should be consistent with previous receiver name r for Replayable (golint)
    • Line 96: warning: exported method Replayable.ActionChan should have comment or be unexported (golint)
    • Line 96: warning: receiver name d should be consistent with previous receiver name r for Replayable (golint)
    • Line 116: warning: exported method Replayable.QueueEvent should have comment or be unexported (golint)
    • namazu/nmz/signal/event_packet.go
    • Line 20: warning: comment on exported type PacketEvent should be of the form "PacketEvent ..." (with optional leading article) (golint)
    • Line 25: warning: exported function NewPacketEvent should have comment or be unexported (golint)
    • Line 44: warning: comment on exported method PacketEvent.DefaultFaultAction should be of the form "DefaultFaultAction ..." (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/signal/interface_internal.go
    • Line 9: warning: comment on exported type Signal should be of the form "Signal ..." (with optional leading article) (golint)
    • Line 34: warning: exported type ArrivalSignal should have comment or be unexported (golint)
    • Line 39: warning: comment on exported type PBEvent should be of the form "PBEvent ..." (with optional leading article) (golint)
    • Line 44: warning: comment on exported type PBAction should be of the form "PBAction ..." (with optional leading article) (golint)
    • namazu/nmz/util/config/config.go
    • Line 29: warning: exported type Config should have comment or be unexported (golint)
    • Line 33: warning: comment on exported function New should be of the form "New ..." (golint)
    • Line 104: warning: exported function NewFromString should have comment or be unexported (golint)
    • Line 111: warning: exported function NewFromFile should have comment or be unexported (golint)
    • namazu/nmz/inspector/transceiver/localtransceiver.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 27: warning: exported type LocalTransceiver should have comment or be unexported (golint)
    • Line 32: warning: exported var SingletonLocalTransceiver should have comment or be unexported (golint)
    • Line 37: warning: exported method LocalTransceiver.SendEvent should have comment or be unexported (golint)
    • Line 37: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 49: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 69: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 83: warning: exported method LocalTransceiver.Start should have comment or be unexported (golint)
    • Line 83: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/signal/event.go
    • Line 23: warning: exported type BasicEvent should have comment or be unexported (golint)
    • Line 27: warning: comment on exported method BasicEvent.Equals should be of the form "Equals ..." (golint)
    • Line 28: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 32: warning: comment on exported method BasicEvent.Deferred should be of the form "Deferred ..." (golint)
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 41: warning: exported method BasicEvent.SetDeferred should have comment or be unexported (golint)
    • Line 41: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 46: warning: comment on exported method BasicEvent.ReplayHint should be of the form "ReplayHint ..." (golint)
    • Line 47: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 55: warning: exported method BasicEvent.SetReplayHint should have comment or be unexported (golint)
    • Line 55: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 60: warning: comment on exported method BasicEvent.DefaultAction should be of the form "DefaultAction ..." (golint)
    • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 68: warning: comment on exported method BasicEvent.DefaultFaultAction should be of the form "DefaultFaultAction ..." (golint)
    • Line 69: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 83: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 89: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/historystorage/naive/naive.go
    • Line 29: warning: should not use dot imports (golint)
    • Line 31: warning: should not use dot imports (golint)
    • Line 82: warning: exported method Naive.RecordNewTrace should have comment or be unexported (golint)
    • Line 141: warning: exported method Naive.CreateNewWorkingDir should have comment or be unexported (golint)
    • Line 160: warning: exported method Naive.NrStoredHistories should have comment or be unexported (golint)
    • Line 164: warning: exported method Naive.GetStoredHistory should have comment or be unexported (golint)
    • Line 183: warning: exported method Naive.RecordResult should have comment or be unexported (golint)
    • Line 198: warning: exported method Naive.IsSuccessful should have comment or be unexported (golint)
    • Line 216: warning: exported method Naive.GetRequiredTime should have comment or be unexported (golint)
    • Line 235: warning: exported method Naive.SearchWithConverter should have comment or be unexported (golint)
    • Line 254: warning: exported method Naive.Search should have comment or be unexported (golint)
    • Line 259: warning: exported method Naive.Init should have comment or be unexported (golint)
    • Line 263: warning: exported method Naive.Close should have comment or be unexported (golint)
    • namazu/nmz/util/queue/interface.go
    • Line 25: warning: comment on exported type TimeBoundedQueueItem should be of the form "TimeBoundedQueueItem ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported type TimeBoundedQueue should be of the form "TimeBoundedQueue ..." (with optional leading article) (golint)
    • namazu/nmz/signal/action_fault_packet.go
    • Line 24: warning: comment on exported type PacketFaultAction should be of the form "PacketFaultAction ..." (with optional leading article) (golint)
    • Line 29: warning: exported function NewPacketFaultAction should have comment or be unexported (golint)
    • namazu/nmz/explorepolicy/explorepolicy.go
    • Line 24: warning: exported type PolicyFactory should have comment or be unexported (golint)
    • Line 28: warning: exported function CreatePolicy should have comment or be unexported (golint)
    • Line 35: warning: exported function RegisterPolicy should have comment or be unexported (golint)
    • namazu/nmz/endpoint/endpoint.go
    • Line 61: warning: comment on exported function StartAll should be of the form "StartAll ..." (golint)
    • Line 214: warning: exported function ShutdownAll should have comment or be unexported (golint)
    • namazu/nmz/cli/tools/visualize.go
    • Line 25: warning: should not use dot imports (golint)
    • Line 26: warning: should not use dot imports (golint)
    • Line 86: warning: should omit 2nd value from range; this loop is equivalent to `for entity := range ...` (golint)
    • Line 91: warning: should omit 2nd value from range; this loop is equivalent to `for entity := range ...` (golint)
    • Line 177: warning: exported function VisualizeCommandFactory should have comment or be unexported (golint)
    • namazu/nmz/container/start.go
    • Line 28: warning: exported function StartNamazuRoutinesPre should have comment or be unexported (golint)
    • Line 64: warning: exported function StartNamazuRoutinesPost should have comment or be unexported (golint)
    • namazu/nmz/signal/interface.go
    • Line 64: warning: exported const ControlEnableOrchestration should have comment (or a comment on this block) or be unexported (golint)
    • Line 68: warning: exported type Control should have comment or be unexported (golint)
    • Line 72: warning: exported type OrchestratorSideAction should have comment or be unexported (golint)
    • namazu/nmz/cli/run.go
    • Line 65: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 76: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 89: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 95: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 123: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • namazu/nmz/signal/action_fault_filesystem.go
    • Line 24: warning: comment on exported type FilesystemFaultAction should be of the form "FilesystemFaultAction ..." (with optional leading article) (golint)
    • Line 29: warning: exported function NewFilesystemFaultAction should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell97%

Misspell Finds commonly misspelled English words