Preparing report...

Report for github.com/pachyderm/pachyderm

(v1.13.4)

A+    Excellent!    Found 86 issues across 408 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • src/server/pkg/tar/common.go
    • Line 312: warning: cyclomatic complexity 52 of function (Header).allowedFormats() is high (> 15) (gocyclo)
    • Line 608: warning: cyclomatic complexity 19 of function FileInfoHeader() is high (> 15) (gocyclo)
    • src/server/pps/cmds/cmds.go
    • Line 75: warning: cyclomatic complexity 152 of function Cmds() is high (> 15) (gocyclo)
    • Line 1162: warning: cyclomatic complexity 40 of function pipelineHelper() is high (> 15) (gocyclo)
    • Line 1396: warning: cyclomatic complexity 29 of function buildHelper() is high (> 15) (gocyclo)
    • Line 1283: warning: cyclomatic complexity 19 of function dockerBuildHelper() is high (> 15) (gocyclo)
    • src/server/pachyderm_test.go
    • Line 11165: warning: cyclomatic complexity 41 of function testSpout() is high (> 15) (gocyclo)
    • Line 4512: warning: cyclomatic complexity 30 of function testGetLogs() is high (> 15) (gocyclo)
    • Line 8223: warning: cyclomatic complexity 21 of function TestService() is high (> 15) (gocyclo)
    • Line 2968: warning: cyclomatic complexity 18 of function TestUpdatePipeline() is high (> 15) (gocyclo)
    • Line 5751: warning: cyclomatic complexity 17 of function TestGroupInput() is high (> 15) (gocyclo)
    • Line 6492: warning: cyclomatic complexity 16 of function TestGarbageCollection() is high (> 15) (gocyclo)
    • src/server/worker/pipeline/transform/registry.go
    • Line 611: warning: cyclomatic complexity 33 of function (*registry).startJob() is high (> 15) (gocyclo)
    • Line 383: warning: cyclomatic complexity 22 of function (*registry).sendDatumTasks() is high (> 15) (gocyclo)
    • Line 948: warning: cyclomatic complexity 16 of function (*registry).processJobRunning() is high (> 15) (gocyclo)
    • src/server/pkg/tar/writer_test.go
    • Line 53: warning: cyclomatic complexity 21 of function TestWriter() is high (> 15) (gocyclo)
    • Line 840: warning: cyclomatic complexity 19 of function TestWriterErrors() is high (> 15) (gocyclo)
    • Line 1023: warning: cyclomatic complexity 18 of function TestFileWriter() is high (> 15) (gocyclo)
    • src/server/pfs/server/trigger.go
    • Line 20: warning: cyclomatic complexity 21 of function (*driver).triggerCommit() is high (> 15) (gocyclo)
    • Line 107: warning: cyclomatic complexity 20 of function (*driver).isTriggered() is high (> 15) (gocyclo)
    • src/server/pfs/cmds/cmds.go
    • Line 47: warning: cyclomatic complexity 177 of function Cmds() is high (> 15) (gocyclo)
    • Line 1410: warning: cyclomatic complexity 23 of function putFileHelper() is high (> 15) (gocyclo)
    • src/server/admin/server/api_server.go
    • Line 102: warning: cyclomatic complexity 55 of function (*apiServer).Extract() is high (> 15) (gocyclo)
    • Line 833: warning: cyclomatic complexity 37 of function (*restoreCtx).applyOp() is high (> 15) (gocyclo)
    • Line 1061: warning: cyclomatic complexity 24 of function (*extractBlockReader).Read() is high (> 15) (gocyclo)
    • Line 955: warning: cyclomatic complexity 18 of function (*extractObjectReader).Read() is high (> 15) (gocyclo)
    • src/server/auth/server/config.go
    • Line 382: warning: cyclomatic complexity 26 of function validateConfig() is high (> 15) (gocyclo)
    • Line 208: warning: cyclomatic complexity 17 of function validateIDP() is high (> 15) (gocyclo)
    • Line 257: warning: cyclomatic complexity 16 of function validateIDPSAML() is high (> 15) (gocyclo)
    • src/server/pkg/tar/reader.go
    • Line 349: warning: cyclomatic complexity 23 of function (*Reader).readHeader() is high (> 15) (gocyclo)
    • Line 63: warning: cyclomatic complexity 22 of function (*Reader).next() is high (> 15) (gocyclo)
    • Line 770: warning: cyclomatic complexity 17 of function (*sparseFileReader).WriteTo() is high (> 15) (gocyclo)
    • Line 255: warning: cyclomatic complexity 16 of function mergePAX() is high (> 15) (gocyclo)
    • src/server/pkg/tar/reader_test.go
    • Line 769: warning: cyclomatic complexity 17 of function TestReadTruncation() is high (> 15) (gocyclo)
    • Line 1352: warning: cyclomatic complexity 17 of function TestFileReader() is high (> 15) (gocyclo)
    • Line 25: warning: cyclomatic complexity 16 of function TestReader() is high (> 15) (gocyclo)
    • src/server/worker/driver/driver.go
    • Line 1031: warning: cyclomatic complexity 46 of function (*driver).UploadOutput() is high (> 15) (gocyclo)
    • Line 526: warning: cyclomatic complexity 21 of function (*driver).downloadData() is high (> 15) (gocyclo)
    • Line 703: warning: cyclomatic complexity 20 of function (*driver).RunUserCode() is high (> 15) (gocyclo)
    • src/server/pfs/server/driver.go
    • Line 841: warning: cyclomatic complexity 85 of function (*driver).makeCommit() is high (> 15) (gocyclo)
    • Line 4454: warning: cyclomatic complexity 61 of function (*driver).forEachPutFile() is high (> 15) (gocyclo)
    • Line 2098: warning: cyclomatic complexity 60 of function (*driver).deleteCommit() is high (> 15) (gocyclo)
    • Line 2841: warning: cyclomatic complexity 54 of function (*driver).putFile() is high (> 15) (gocyclo)
    • Line 2422: warning: cyclomatic complexity 53 of function (*driver).createBranch() is high (> 15) (gocyclo)
    • Line 1416: warning: cyclomatic complexity 42 of function (*driver).propagateCommits() is high (> 15) (gocyclo)
    • Line 3135: warning: cyclomatic complexity 40 of function (*driver).copyFile() is high (> 15) (gocyclo)
    • Line 1801: warning: cyclomatic complexity 38 of function (*driver).listCommitF() is high (> 15) (gocyclo)
    • Line 3460: warning: cyclomatic complexity 35 of function (*driver).getFile() is high (> 15) (gocyclo)
    • Line 4214: warning: cyclomatic complexity 34 of function (*driver).applyWrite() is high (> 15) (gocyclo)
    • Line 1925: warning: cyclomatic complexity 25 of function (*driver).subscribeCommit() is high (> 15) (gocyclo)
    • Line 552: warning: cyclomatic complexity 25 of function (*driver).deleteRepo() is high (> 15) (gocyclo)
    • Line 2004: warning: cyclomatic complexity 24 of function (*driver).flushCommit() is high (> 15) (gocyclo)
    • Line 3764: warning: cyclomatic complexity 22 of function (*driver).listFile() is high (> 15) (gocyclo)
    • Line 4018: warning: cyclomatic complexity 21 of function (*driver).diffFile() is high (> 15) (gocyclo)
    • Line 1706: warning: cyclomatic complexity 21 of function (*driver).resolveCommit() is high (> 15) (gocyclo)
    • Line 1216: warning: cyclomatic complexity 21 of function (*driver).finishCommit() is high (> 15) (gocyclo)
    • Line 3953: warning: cyclomatic complexity 17 of function (*driver).globFile() is high (> 15) (gocyclo)
    • Line 3896: warning: cyclomatic complexity 16 of function (*driver).walkFile() is high (> 15) (gocyclo)
    • Line 2702: warning: cyclomatic complexity 16 of function (*driver).deleteBranch() is high (> 15) (gocyclo)
    • src/server/pfs/server/driver_v2.go
    • Line 848: warning: cyclomatic complexity 58 of function (*driverV2).deleteCommit() is high (> 15) (gocyclo)
    • Line 673: warning: cyclomatic complexity 19 of function (*driverV2).diffFileV2() is high (> 15) (gocyclo)
    • src/server/pkg/hashtree/db.go
    • Line 388: warning: cyclomatic complexity 37 of function diff() is high (> 15) (gocyclo)
    • Line 544: warning: cyclomatic complexity 21 of function (*dbHashTree).Deserialize() is high (> 15) (gocyclo)
    • Line 810: warning: cyclomatic complexity 20 of function (*dbHashTree).putFile() is high (> 15) (gocyclo)
    • src/server/pps/server/api_server.go
    • Line 2346: warning: cyclomatic complexity 94 of function (*apiServer).CreatePipelineInTransaction() is high (> 15) (gocyclo)
    • Line 1489: warning: cyclomatic complexity 48 of function (*apiServer).GetLogs() is high (> 15) (gocyclo)
    • Line 1089: warning: cyclomatic complexity 41 of function (*apiServer).listDatum() is high (> 15) (gocyclo)
    • Line 200: warning: cyclomatic complexity 39 of function (*apiServer).validateInputInTransaction() is high (> 15) (gocyclo)
    • Line 1943: warning: cyclomatic complexity 37 of function (*apiServer).validatePipelineInTransaction() is high (> 15) (gocyclo)
    • Line 3484: warning: cyclomatic complexity 35 of function (*apiServer).RunPipeline() is high (> 15) (gocyclo)
    • Line 715: warning: cyclomatic complexity 31 of function (*apiServer).listJob() is high (> 15) (gocyclo)
    • Line 4023: warning: cyclomatic complexity 28 of function (*apiServer).GarbageCollect() is high (> 15) (gocyclo)
    • Line 3265: warning: cyclomatic complexity 26 of function (*apiServer).deletePipeline() is high (> 15) (gocyclo)
    • Line 617: warning: cyclomatic complexity 26 of function (*apiServer).InspectJob() is high (> 15) (gocyclo)
    • Line 1765: warning: cyclomatic complexity 26 of function (*apiServer).getLogsLoki() is high (> 15) (gocyclo)
    • Line 439: warning: cyclomatic complexity 21 of function (*apiServer).authorizePipelineOpInTransaction() is high (> 15) (gocyclo)
    • Line 1688: warning: cyclomatic complexity 20 of function (*apiServer).getLogsFromStats() is high (> 15) (gocyclo)
    • Line 146: warning: cyclomatic complexity 20 of function validateNames() is high (> 15) (gocyclo)
    • Line 2945: warning: cyclomatic complexity 19 of function (*apiServer).inspectPipelineInTransaction() is high (> 15) (gocyclo)
    • Line 3916: warning: cyclomatic complexity 18 of function CollectActiveObjectsAndTags() is high (> 15) (gocyclo)
    • Line 2149: warning: cyclomatic complexity 18 of function (*apiServer).fixPipelineInputRepoACLsInTransaction() is high (> 15) (gocyclo)
    • Line 3072: warning: cyclomatic complexity 17 of function (*apiServer).listPipeline() is high (> 15) (gocyclo)
    • src/client/pkg/require/require.go
    • Line 87: warning: cyclomatic complexity 29 of function ElementsEqualOrErr() is high (> 15) (gocyclo)
    • Line 188: warning: cyclomatic complexity 25 of function ImagesEqual() is high (> 15) (gocyclo)
    • Line 265: warning: cyclomatic complexity 16 of function ElementsEqualUnderFn() is high (> 15) (gocyclo)
    • src/server/pfs/fuse/loopback.go
    • Line 427: warning: cyclomatic complexity 20 of function (*loopbackNode).Setattr() is high (> 15) (gocyclo)
    • Line 551: warning: cyclomatic complexity 18 of function (*loopbackNode).download() is high (> 15) (gocyclo)
    • src/server/pps/server/monitor.go
    • Line 187: warning: cyclomatic complexity 39 of function (*ppsMaster).monitorPipeline() is high (> 15) (gocyclo)
    • Line 429: warning: cyclomatic complexity 19 of function (*ppsMaster).makeCronCommits() is high (> 15) (gocyclo)
    • src/client/pkg/shard/sharder.go
    • Line 160: warning: cyclomatic complexity 39 of function (*sharder).unsafeAssignRoles() is high (> 15) (gocyclo)
    • Line 316: warning: cyclomatic complexity 29 of function (*sharder).WaitForAvailability() is high (> 15) (gocyclo)
    • Line 640: warning: cyclomatic complexity 21 of function (*sharder).fillRoles() is high (> 15) (gocyclo)
    • src/server/pps/server/worker_rc.go
    • Line 84: warning: cyclomatic complexity 33 of function (*apiServer).workerPodSpec() is high (> 15) (gocyclo)
    • Line 479: warning: cyclomatic complexity 26 of function (*apiServer).getWorkerOptions() is high (> 15) (gocyclo)
    • Line 717: warning: cyclomatic complexity 21 of function (*apiServer).createWorkerSvcAndRc() is high (> 15) (gocyclo)
    • src/server/auth/server/api_server.go
    • Line 988: warning: cyclomatic complexity 31 of function (*apiServer).Authenticate() is high (> 15) (gocyclo)
    • Line 1827: warning: cyclomatic complexity 27 of function (*apiServer).SetACLInTransaction() is high (> 15) (gocyclo)
    • Line 498: warning: cyclomatic complexity 25 of function (*apiServer).Activate() is high (> 15) (gocyclo)
    • Line 853: warning: cyclomatic complexity 24 of function (*apiServer).applyClusterRoleBindings() is high (> 15) (gocyclo)
    • Line 382: warning: cyclomatic complexity 20 of function (*apiServer).watchAdmins() is high (> 15) (gocyclo)
    • Line 1522: warning: cyclomatic complexity 19 of function (*apiServer).SetScopeInTransaction() is high (> 15) (gocyclo)
    • Line 2024: warning: cyclomatic complexity 19 of function (*apiServer).GetAuthTokenInTransaction() is high (> 15) (gocyclo)
    • Line 1200: warning: cyclomatic complexity 18 of function (*apiServer).GetOneTimePassword() is high (> 15) (gocyclo)
    • Line 1665: warning: cyclomatic complexity 17 of function (*apiServer).GetScopeInTransaction() is high (> 15) (gocyclo)
    • src/server/cmd/pachd/main.go
    • Line 290: warning: cyclomatic complexity 65 of function doFullMode() is high (> 15) (gocyclo)
    • Line 101: warning: cyclomatic complexity 31 of function doSidecarMode() is high (> 15) (gocyclo)
    • src/server/pps/server/poller.go
    • Line 174: warning: cyclomatic complexity 20 of function (*ppsMaster).pollPipelinePods() is high (> 15) (gocyclo)
    • Line 80: warning: cyclomatic complexity 16 of function (*ppsMaster).pollPipelines() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!